ba9bfb1eb1844bc4264798b7077afb6e7881fa20
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2014-11-08  Matt Baker  <mattbaker@apple.com>
2
3         Web Inspector: decouple child element folderization logic from FrameTreeElement
4         https://bugs.webkit.org/show_bug.cgi?id=138364
5
6         Reviewed by Timothy Hatcher.
7
8         Created FolderizedTreeElement base class, which FrameTreeElement now inherits via SourceCodeTreeElement.
9         FolderizedTreeElement uses settings provided by derived classes for labeling subfolders and to determine
10         folder membership for child items.
11
12         * UserInterface/Base/Main.js:
13         (WebInspector.canArchiveMainFrame):
14         * UserInterface/Main.html:
15         * UserInterface/Models/LayoutTimelineRecord.js:
16         (WebInspector.LayoutTimelineRecord.displayNameForEventType):
17         (WebInspector.LayoutTimelineRecord.EventType.displayName): Deleted.
18         * UserInterface/Models/Resource.js:
19         (WebInspector.Resource):
20         (WebInspector.Resource.typeFromMIMEType):
21         (WebInspector.Resource.displayNameForType):
22         (WebInspector.Resource.prototype.get syntheticMIMEType):
23         (WebInspector.Resource.prototype.updateForResponse):
24         (WebInspector.Resource.Type.fromMIMEType): Deleted.
25         (WebInspector.Resource.Type.displayName): Deleted.
26         * UserInterface/Models/SourceMapResource.js:
27         (WebInspector.SourceMapResource):
28         * UserInterface/Views/FolderizedTreeElement.js: Added.
29         (WebInspector.FolderizedTreeElement):
30         (WebInspector.FolderizedTreeElement.prototype.get groupedIntoFolders):
31         (WebInspector.FolderizedTreeElement.prototype.set folderSettingsKey):
32         (WebInspector.FolderizedTreeElement.prototype.registerFolderizeSettings):
33         (WebInspector.FolderizedTreeElement.prototype.set removeChildren):
34         (WebInspector.FolderizedTreeElement.prototype.addChildForRepresentedObject):
35         (WebInspector.FolderizedTreeElement.prototype.addRepresentedObjectToNewChildQueue):
36         (WebInspector.FolderizedTreeElement.prototype.removeChildForRepresentedObject):
37         (WebInspector.FolderizedTreeElement.prototype.compareChildTreeElements):
38         (WebInspector.FolderizedTreeElement.prototype.updateParentStatus):
39         (WebInspector.FolderizedTreeElement.prototype._clearNewChildQueue):
40         (WebInspector.FolderizedTreeElement.prototype._populateFromNewChildQueue):
41         (WebInspector.FolderizedTreeElement.prototype._removeRepresentedObjectFromNewChildQueue):
42         (WebInspector.FolderizedTreeElement.prototype._addTreeElement):
43         (WebInspector.FolderizedTreeElement.prototype._compareTreeElementsByMainTitle):
44         (WebInspector.FolderizedTreeElement.prototype._insertFolderTreeElement):
45         (WebInspector.FolderizedTreeElement.prototype._insertChildTreeElement):
46         (WebInspector.FolderizedTreeElement.prototype._removeTreeElement):
47         (WebInspector.FolderizedTreeElement.prototype._parentTreeElementForRepresentedObject):
48         (WebInspector.FolderizedTreeElement.prototype._folderTreeElementExpandedStateChange):
49         (WebInspector.FolderizedTreeElement.prototype._settingsForRepresentedObject):
50         (WebInspector.FolderizedTreeElement.prototype._shouldGroupIntoFolders.pushCategory):
51         (WebInspector.FolderizedTreeElement.prototype._shouldGroupIntoFolders):
52         * UserInterface/Views/FrameTreeElement.js:
53         (.this):
54         (WebInspector.FrameTreeElement.prototype.updateSourceMapResources):
55         (WebInspector.FrameTreeElement.prototype.onattach):
56         (WebInspector.FrameTreeElement.prototype.ondetach):
57         (WebInspector.FrameTreeElement.prototype.compareChildTreeElements):
58         (WebInspector.FrameTreeElement.prototype.onpopulate):
59         (WebInspector.FrameTreeElement.prototype._mainResourceDidChange):
60         (WebInspector.FrameTreeElement.prototype._resourceWasAdded):
61         (WebInspector.FrameTreeElement.prototype._resourceWasRemoved):
62         (WebInspector.FrameTreeElement.prototype._childFrameWasAdded):
63         (WebInspector.FrameTreeElement.prototype._childFrameWasRemoved):
64         (WebInspector.FrameTreeElement.prototype._childContentFlowWasAdded):
65         (WebInspector.FrameTreeElement.prototype._childContentFlowWasRemoved):
66         (WebInspector.FrameTreeElement.prototype._rootDOMNodeInvalidated):
67         (WebInspector.FrameTreeElement): Deleted.
68         (WebInspector.FrameTreeElement.prototype.removeChildren): Deleted.
69         (WebInspector.FrameTreeElement.prototype._updateParentStatus): Deleted.
70         (WebInspector.FrameTreeElement.prototype._addRepresentedObjectToNewChildQueue): Deleted.
71         (WebInspector.FrameTreeElement.prototype._removeRepresentedObjectFromNewChildQueue): Deleted.
72         (WebInspector.FrameTreeElement.prototype._populateFromNewChildQueue): Deleted.
73         (WebInspector.FrameTreeElement.prototype._clearNewChildQueue): Deleted.
74         (WebInspector.FrameTreeElement.prototype._addChildForRepresentedObject): Deleted.
75         (WebInspector.FrameTreeElement.prototype._removeChildForRepresentedObject): Deleted.
76         (WebInspector.FrameTreeElement.prototype._addTreeElementForRepresentedObject): Deleted.
77         (WebInspector.FrameTreeElement.prototype._addTreeElement): Deleted.
78         (WebInspector.FrameTreeElement.prototype._compareTreeElementsByMainTitle): Deleted.
79         (WebInspector.FrameTreeElement.prototype._insertFolderTreeElement): Deleted.
80         (WebInspector.FrameTreeElement.prototype._compareResourceTreeElements): Deleted.
81         (WebInspector.FrameTreeElement.prototype._insertResourceTreeElement): Deleted.
82         (WebInspector.FrameTreeElement.prototype._removeTreeElement): Deleted.
83         (WebInspector.FrameTreeElement.prototype._folderNameForResourceType): Deleted.
84         (WebInspector.FrameTreeElement.prototype._parentTreeElementForRepresentedObject.createFolderTreeElement): Deleted.
85         (WebInspector.FrameTreeElement.prototype._parentTreeElementForRepresentedObject): Deleted.
86         (WebInspector.FrameTreeElement.prototype._folderTreeElementExpandedStateChange): Deleted.
87         (WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders.pushResourceType): Deleted.
88         (WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders.pushCategory): Deleted.
89         (WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders): Deleted.
90         * UserInterface/Views/LayoutTimelineDataGridNode.js:
91         (WebInspector.LayoutTimelineDataGridNode.prototype.createCellContent):
92         * UserInterface/Views/LayoutTimelineView.js:
93         (WebInspector.LayoutTimelineView): Deleted.
94         * UserInterface/Views/NetworkTimelineView.js:
95         (WebInspector.NetworkTimelineView): Deleted.
96         * UserInterface/Views/ResourceDetailsSidebarPanel.js:
97         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshResourceType):
98         * UserInterface/Views/ResourceTimelineDataGridNode.js:
99         (WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent):
100         * UserInterface/Views/SourceCodeTreeElement.js:
101         (WebInspector.SourceCodeTreeElement):
102         * UserInterface/Views/TimelineDataGrid.js:
103         (WebInspector.TimelineDataGrid.createColumnScopeBar):
104         * UserInterface/Views/TimelineRecordTreeElement.js:
105         (WebInspector.TimelineRecordTreeElement):
106         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
107         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
108
109 2014-11-07  Joseph Pecoraro  <pecoraro@apple.com>
110
111         Web Inspector: Layer summary should be bottom sticky
112         https://bugs.webkit.org/show_bug.cgi?id=138518
113
114         Reviewed by Timothy Hatcher.
115
116         Previously only NavigationSidebars had a content view. Now, give all
117         Sidebars a contentElement section for content.
118
119         Update all Details Sidebars to append content to the contentElement
120         instead of directly to the element. Only two Details sidebars append
121         to the element:
122
123           - CSSStyleDetailsSidebarPanel for the navigation bar at the top
124           - LayerTreeDetailsSidebarPanel for the summary view at the bottom
125
126         Take this opportunity to fix up some naming and styles as well.
127
128         * UserInterface/Views/SidebarPanel.js:
129         (WebInspector.SidebarPanel):
130         (WebInspector.SidebarPanel.prototype.get contentElement):
131         Give every SidebarPanel a content element.
132
133         * UserInterface/Views/DetailsSidebarPanel.css: Removed.
134         (.sidebar > .panel > .content):
135         * UserInterface/Views/SidebarPanel.css: Added.
136         (.sidebar > .panel > .content):
137         And give that content element a default style.
138
139         * UserInterface/Views/NavigationSidebarPanel.css:
140         (.sidebar > .panel.navigation > .content):
141         * UserInterface/Views/NavigationSidebarPanel.js:
142         (WebInspector.NavigationSidebarPanel):
143         (WebInspector.NavigationSidebarPanel.prototype.createContentTreeOutline):
144         (WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
145         (WebInspector.NavigationSidebarPanel.prototype.get contentElement): Deleted.
146         Navigation sidebar panels now use the parent's contentElement.
147         Also, carry over their default styles, overriding the base.
148
149         * UserInterface/Views/LayerTreeDetailsSidebarPanel.js: Renamed from Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.js.
150         (WebInspector.LayerTreeDetailsSidebarPanel.prototype._buildLayerInfoSection):
151         (WebInspector.LayerTreeDetailsSidebarPanel.prototype._buildDataGridSection):
152         (WebInspector.LayerTreeDetailsSidebarPanel.prototype._buildBottomBar):
153         Rename LayerTreeSidebarPanel to make it clear this is a DetailsSidebarPanel.
154         Add the "bottom bar" to the root element, and sections to the contentElement.
155
156         * UserInterface/Views/LayerTreeDetailsSidebarPanel.css: Renamed from Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.css.
157         (.sidebar > .layer-tree.panel > .content):
158         (body.mac-platform.legacy .sidebar > .layer-tree.panel > .content):
159         Style the bottom bar to pin it to the bottom of the sidebar panel.
160
161         (WebInspector.CSSStyleDetailsSidebarPanel):
162         (WebInspector.CSSStyleDetailsSidebarPanel.prototype.refresh):
163         (WebInspector.CSSStyleDetailsSidebarPanel.prototype._navigationItemSelected):
164         Add the navigation bar to the root element, and sections to the contentElement.
165
166         * UserInterface/Base/Main.js:
167         (WebInspector.contentLoaded):
168         * UserInterface/Main.html:
169         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
170         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
171         Update for new names.
172
173         * UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
174         (WebInspector.ApplicationCacheDetailsSidebarPanel):
175         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
176         * UserInterface/Views/DOMDetailsSidebarPanel.js:
177         (WebInspector.DOMDetailsSidebarPanel):
178         * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
179         (WebInspector.DOMNodeDetailsSidebarPanel):
180         * UserInterface/Views/DetailsSidebarPanel.js:
181         (WebInspector.DetailsSidebarPanel):
182         * UserInterface/Views/ProbeDetailsSidebarPanel.js:
183         * UserInterface/Views/ResourceDetailsSidebarPanel.js:
184         (WebInspector.ResourceDetailsSidebarPanel):
185         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshURL):
186         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshImageSizeSection):
187         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRequestDataSection):
188         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
189         (WebInspector.ScopeChainDetailsSidebarPanel.prototype.refresh.delayedWork):
190         (WebInspector.ScopeChainDetailsSidebarPanel.prototype.refresh):
191         All details sidebar panels now use the contentElement instead of element for content.
192
193 2014-11-07  Timothy Hatcher  <timothy@apple.com>
194
195         Web Inspector: Cursor and scroll view jumps around when modifying styles
196         https://bugs.webkit.org/show_bug.cgi?id=137467
197
198         This merges commit e2962a5b0df56c8ee5a4482899d308decf3d7677 from CodeMirror.
199
200         Reviewed by Joseph Pecoraro.
201
202         * UserInterface/External/CodeMirror/codemirror.js:
203         (maybeScrollWindow): Signal the scrollCursorIntoView event.
204         (signalDOMEvent): Support string events by transforming them to event objects.
205
206         * UserInterface/Views/CodeMirrorAdditions.js:
207         (scrollCursorIntoView): Added. Default event listener that provides our own
208         implementation using WebKit's scrollIntoViewIfNeeded.
209
210         * UserInterface/Views/RulesStyleDetailsPanel.js:
211         (WebInspector.RulesStyleDetailsPanel.prototype.refresh): Stop doing an
212         extra scrollIntoViewIfNeeded call, CodeMirror does this.
213
214 2014-11-07  Joseph Pecoraro  <pecoraro@apple.com>
215
216         Web Inspector: Pseudo element matchedCSSRules do not include matching selector info
217         https://bugs.webkit.org/show_bug.cgi?id=138438
218
219         Reviewed by Benjamin Poulain.
220
221         * UserInterface/Base/Test.js:
222         (WebInspector.loaded):
223         Include a global setting for shadow dom used by DOM model classes.
224         Give it a "test" specific name to not override non-test setting values.
225
226 2014-11-05  Commit Queue  <commit-queue@webkit.org>
227
228         Unreviewed, rolling out r175628.
229         https://bugs.webkit.org/show_bug.cgi?id=138451
230
231         Totally borked the web inspector (Requested by smfr on
232         #webkit).
233
234         Reverted changeset:
235
236         "Web Inspector: Add infrastructure for eslint based static
237         analyzer"
238         https://bugs.webkit.org/show_bug.cgi?id=137890
239         http://trac.webkit.org/changeset/175628
240
241 2014-11-05  Joseph Pecoraro  <pecoraro@apple.com>
242
243         Web Inspector: Specificity not shown for pseudo element styles
244         https://bugs.webkit.org/show_bug.cgi?id=138436
245
246         Reviewed by Benjamin Poulain.
247
248         * UserInterface/Views/CSSStyleDeclarationSection.js:
249         (WebInspector.CSSStyleDeclarationSection.prototype.refresh):
250         Previously we were skipping the pre-selector <span>s when we were
251         not getting a listing of matched selector indices, and missing out
252         on the opportunity to give each selector a specificity. Now, always
253         loop over selectors if we have them.
254
255 2014-11-05  Jonathan Wells  <jonowells@apple.com>
256
257         Web Inspector: Add infrastructure for eslint based static analyzer
258         https://bugs.webkit.org/show_bug.cgi?id=137890
259
260         Reviewed by Timothy Hatcher.
261
262         Adding a manager to analyze source code, return warnings (AnalyzerMessages), and cache warnings.
263
264         * UserInterface/Base/Main.js: Create analyzerManager singleton.
265         * UserInterface/Controllers/AnalyzerManager.js: Added.
266         (WebInspector.AnalyzerManager):
267         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode.):
268         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode):
269         (set WebInspector.AnalyzerManager.prototype.set get sourceCodeCanBeAnalyzed):
270         (set WebInspector.AnalyzerManager.prototype._handleSourceCodeContentDidChange):
271         * UserInterface/Main.html: Add new files.
272         * UserInterface/Models/AnalyzerMessage.js: Added.
273         (WebInspector.AnalyzerMessage):
274         (WebInspector.AnalyzerMessage.prototype.get sourceCodeLocation):
275         (WebInspector.AnalyzerMessage.prototype.get sourceCode):
276         (WebInspector.AnalyzerMessage.prototype.get text):
277         (WebInspector.AnalyzerMessage.prototype.get ruleIdentifier):
278         * UserInterface/Models/SourceCode.js: Added call to WebInspector.Object.addConstructorFunctions().
279
280 2014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
281
282         Web Inspector: Too much whitespace in resource details sidebar in groups
283         https://bugs.webkit.org/show_bug.cgi?id=138386
284
285         Reviewed by Timothy Hatcher.
286
287         * UserInterface/Views/DetailsSection.css:
288         (.details-section > .content > .group:first-child > .row.simple:first-child > *):
289         (body.mac-platform.legacy .details-section > .content > .group:first-child > .row.simple:first-child > *):
290         (body.mac-platform.legacy .details-section > .content > .group > .row.text):
291         (.details-section > .content > .group > .row.properties:not(.empty)):
292         (body.mac-platform.legacy .details-section > .content > .group > .row.properties:not(.empty)):
293         Adjust top and bottom padding.
294
295 2014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
296
297         Web Inspector: Lots of TimelineDataGridNode asserts on reloads
298         https://bugs.webkit.org/show_bug.cgi?id=138387
299
300         Reviewed by Brian Burg.
301
302         The TimelineRuler.secondsPerPixel in the TimelineOverview is initialized
303         with a non-0 value and saved in a setting. However the TimelineRuler in
304         the OverviewTimelineView is not initialized with this value, and instead
305         initialized to 0. This patch initializes them to the same non-0 value.
306
307         * UserInterface/Views/OverviewTimelineView.js:
308         (WebInspector.OverviewTimelineView.prototype.set secondsPerPixel):
309         * UserInterface/Views/TimelineContentView.js:
310
311 2014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
312
313         Web Inspector: Pause on exceptions should show the actual exception
314         https://bugs.webkit.org/show_bug.cgi?id=63096
315
316         Reviewed by Timothy Hatcher.
317
318         * Localizations/en.lproj/localizedStrings.js:
319         * UserInterface/Main.html:
320         New strings / files.
321
322         * UserInterface/Controllers/DebuggerManager.js:
323         (WebInspector.DebuggerManager.prototype.get pauseReason):
324         (WebInspector.DebuggerManager.prototype.get pauseData):
325         (WebInspector.DebuggerManager.prototype.reset):
326         (WebInspector.DebuggerManager.prototype.debuggerDidPause):
327         (WebInspector.DebuggerManager.prototype._pauseReasonFromPayload):
328         Maintain the current pause reason and auxiliary data in the manager.
329
330         * UserInterface/Protocol/DebuggerObserver.js:
331         (WebInspector.DebuggerObserver.prototype.paused):
332         Pass previously unused event parameters on to the manager.
333
334         * UserInterface/Views/ConsoleMessageImpl.js:
335         (WebInspector.ConsoleMessageImpl):
336         Style error objects in the console like Objects. The new description
337         string provides a richer message if you console.log(exception).
338
339         * UserInterface/Views/DebuggerSidebarPanel.js:
340         (WebInspector.DebuggerSidebarPanel):
341         (WebInspector.DebuggerSidebarPanel.prototype._debuggerDidPause):
342         (WebInspector.DebuggerSidebarPanel.prototype._debuggerDidResume):
343         (WebInspector.DebuggerSidebarPanel.prototype._updatePauseReason):
344         Update the UI when we pause / resume to show / hide a pause reason section.
345
346         * UserInterface/Views/DetailsSectionRow.js:
347         (WebInspector.DetailsSectionRow.prototype.set emptyMessage):
348         Fix a latent bug that would have thrown an exception if the setter was ever used.
349
350         * UserInterface/Views/DetailsSectionTextRow.js: Added.
351         (WebInspector.DetailsSectionTextRow):
352         (WebInspector.DetailsSectionTextRow.prototype.get text):
353         (WebInspector.DetailsSectionTextRow.prototype.set text):
354         * UserInterface/Views/DetailsSection.css:
355         (.details-section > .content > .group > .row.simple.data > .value):
356         (.details-section > .content > .group > .row.text):
357         Simple class for a section of centered text. This is modelled after
358         the empty message text style in other sections.
359
360         * UserInterface/Views/LogContentView.css:
361         (.console-formatted-object, .console-formatted-node, .console-formatted-error):
362         (.console-formatted-object .section, .console-formatted-node .section, .console-formatted-error .section):
363         (.console-formatted-object .properties, .console-formatted-node .properties, .console-formatted-error .properties):
364         Style "error" objects like regular objects. We may wish to treat differently later.
365
366         * UserInterface/Protocol/Legacy/6.0/InspectorBackendCommands.js:
367         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
368         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
369         Regenerate legacy backend commands to get the new enum.
370
371 2014-11-04  Andrei Bucur  <abucur@adobe.com>
372
373         Building WebInspectorUI should not run the clang static analyzer by default
374         https://bugs.webkit.org/show_bug.cgi?id=137652
375
376         Reviewed by Timothy Hatcher.
377
378         There's no need to have the static analyzer enabled at compile time by default for the WebInspectorUI project.
379         It also breaks the ASAN build because the static analyzing step runs using the default compiler not the
380         ASAN clang.
381
382         * Configurations/DebugRelease.xcconfig: Remove the RUN_CLANG_STATIC_ANALYZER variable.
383
384 2014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
385
386         Web Inspector: Uncaught Exceptions when paused and hovering JavaScript without CallFrames
387         https://bugs.webkit.org/show_bug.cgi?id=138338
388
389         Reviewed by Geoffrey Garen.
390
391         * UserInterface/Views/SourceCodeTextEditor.js:
392         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptExpression):
393         Fallback to using the main page's context if there is no active call frame we can use.
394
395 2014-11-03  Joseph Pecoraro  <pecoraro@apple.com>
396
397         Web Inspector: TextEditor search doesn't work after editing contents
398         https://bugs.webkit.org/show_bug.cgi?id=138198
399
400         Reviewed by Timothy Hatcher.
401
402         * UserInterface/Views/SourceCodeTextEditor.js:
403         (WebInspector.SourceCodeTextEditor.prototype.customPerformSearch):
404         Fallback to pure TextEditor content searching (CodeMirror) if the editor has edits.
405
406         * UserInterface/Views/TextEditor.js:
407         (WebInspector.TextEditor.prototype.hasEdits):
408         Check the CodeMirror clean state to known if we have edits or not.
409
410 2014-11-03  Joseph Pecoraro  <pecoraro@apple.com>
411
412         Web Inspector: Show Selector's Specificity
413         https://bugs.webkit.org/show_bug.cgi?id=138189
414
415         Reviewed by Timothy Hatcher.
416
417         * Localizations/en.lproj/localizedStrings.js:
418         * UserInterface/Main.html:
419         * UserInterface/Test.html:
420         Add new files and strings.
421
422         * UserInterface/Models/CSSMedia.js:
423         Constructor functions are not needed, remove unnecessary code.
424
425         * UserInterface/Models/CSSRule.js:
426         (WebInspector.CSSRule.prototype.set selectors): Deleted.
427         This was unused and is no longer correct.
428
429         (WebInspector.CSSRule.prototype.get matchedSelectorText):
430         Update now that selectors are a list of objects, not just strings.
431
432         * UserInterface/Models/CSSSelector.js:
433         (WebInspector.CSSSelector):
434         (WebInspector.CSSSelector.prototype.get specificity):
435         New model object for protocol type CSS.CSSSelector.
436
437         * UserInterface/Models/DOMNodeStyles.js:
438         (WebInspector.DOMNodeStyles.prototype._parseSelectorListPayload.return):
439         (WebInspector.DOMNodeStyles.prototype._parseSelectorListPayload):
440         (WebInspector.DOMNodeStyles.prototype._parseRulePayload):
441         Handle parsing old and new SelectorLists.
442
443         * UserInterface/Views/CSSStyleDeclarationSection.js:
444         (WebInspector.CSSStyleDeclarationSection.prototype.refresh.appendSelector):
445         (WebInspector.CSSStyleDeclarationSection.prototype.refresh.appendSelectorText):
446         (WebInspector.CSSStyleDeclarationSection.prototype.refresh):
447         Update the code now that the list of selectors are model objects instead
448         of just selector text strings.
449
450 2014-11-03  Joseph Pecoraro  <pecoraro@apple.com>
451
452         Web Inspector: ALTERNATE_DISPATCHERS Let the frontend know about extra agents
453         https://bugs.webkit.org/show_bug.cgi?id=138236
454
455         Reviewed by Brian Burg.
456
457         * UserInterface/Protocol/InspectorBackend.js:
458         (InspectorBackendClass.prototype.activateDomain):
459         * UserInterface/Protocol/InspectorObserver.js:
460         (WebInspector.InspectorObserver.prototype.activateExtraDomains):
461         * UserInterface/Base/Object.js:
462         * UserInterface/Base/Test.js:
463         * UserInterface/Base/Main.js:
464         (WebInspector.activateExtraDomains):
465         Default state is that there are no extra domains. When extra domains
466         are activated, some agents need to be re-initialized. Dispatch a
467         model event so views also know to re-initialize.
468
469         * UserInterface/Controllers/ApplicationCacheManager.js:
470         (WebInspector.ApplicationCacheManager.prototype._mainResourceDidChange):
471         * UserInterface/Controllers/DOMTreeManager.js:
472         Be more careful about direct agent use during main resource changes.
473         That can happen with a JSContext extended with a Page agent.
474
475         * UserInterface/Controllers/FrameResourceManager.js:
476         (WebInspector.FrameResourceManager):
477         (WebInspector.FrameResourceManager.prototype._mainFrameDidChange):
478         (WebInspector.FrameResourceManager.prototype._extraDomainsActivated):
479         * UserInterface/Controllers/StorageManager.js:
480         (WebInspector.StorageManager):
481         (WebInspector.StorageManager.prototype._databaseForIdentifier):
482         (WebInspector.StorageManager.prototype._extraDomainsActivated):
483         It is possible new window.FooAgent's are available. Perform expected
484         initialization re-checking if the agents are now available.
485
486         * UserInterface/Models/CSSCompletions.js:
487         Avoid re-initialization if we already did it. This should never
488         happen but this is just to be safe.
489
490         * UserInterface/Views/ResourceSidebarPanel.js:
491         (WebInspector.ResourceSidebarPanel):
492         (WebInspector.ResourceSidebarPanel.prototype._extraDomainsActivated):
493         Don't disallow expandable tree elements if this is a JSContext with
494         extra domains. If that JSContext has resources, we would have been
495         unable to see child resources.
496
497 2014-10-30  Dana Burkart  <dburkart@apple.com>
498
499         <rdar://problem/18821260> Prepare for the mysterious future
500
501         Reviewed by Lucas Forschler.
502
503         * Configurations/Base.xcconfig:
504         * Configurations/DebugRelease.xcconfig:
505         * Configurations/Version.xcconfig:
506
507 2014-10-10 Brian J. Burg  <burg@cs.washington.edu>
508
509         Web Inspector: timelines should not count time elapsed while paused in the debugger
510         https://bugs.webkit.org/show_bug.cgi?id=136351
511
512         Reviewed by Timothy Hatcher.
513
514         Don't update the timeline's current time when the debugger is paused.
515
516         Start and end times for timeline records are now in seconds elapsed since timeline
517         recording started, rather than milliseconds since the epoch. Also convert code that
518         tracks page/resource load timings to use elapsed times rather than timestamps.
519
520         Add a workaround to preserve compatibility with old backends. Convert legacy timestamps
521         in multiple agents to elapsed times.
522
523         * UserInterface/Controllers/FrameResourceManager.js:
524         (WebInspector.FrameResourceManager.prototype.resourceRequestWillBeSent):
525         (WebInspector.FrameResourceManager.prototype.resourceRequestWasServedFromMemoryCache):
526         (WebInspector.FrameResourceManager.prototype.resourceRequestDidReceiveResponse):
527         (WebInspector.FrameResourceManager.prototype.resourceRequestDidReceiveData):
528         (WebInspector.FrameResourceManager.prototype.resourceRequestDidFinishLoading):
529         (WebInspector.FrameResourceManager.prototype.resourceRequestDidFailLoading):
530         (WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):
531         * UserInterface/Controllers/ProbeManager.js:
532         * UserInterface/Controllers/TimelineManager.js:
533         (WebInspector.TimelineManager.prototype.computeElapsedTime): Forward to the active TimelineRecording.
534         (WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
535         (WebInspector.TimelineManager.prototype.eventRecorded):
536         (WebInspector.TimelineManager.prototype.pageDidLoad):
537         (WebInspector.TimelineManager.prototype._loadNewRecording):
538         * UserInterface/Models/Probe.js:
539         (WebInspector.ProbeSample):
540         * UserInterface/Models/Resource.js:
541         (WebInspector.Resource.prototype.updateForRedirectResponse):
542         (WebInspector.Resource.prototype.updateForResponse):
543         (WebInspector.Resource.prototype.increaseSize):
544         (WebInspector.Resource.prototype.markAsFinished):
545         (WebInspector.Resource.prototype.markAsFailed):
546         (WebInspector.Resource.prototype.revertMarkAsFinished):
547         * UserInterface/Models/TimelineRecording.js:
548         (WebInspector.TimelineRecording.prototype.computeElapsedTime):
549         * UserInterface/Views/TimelineContentView.js:
550         (WebInspector.TimelineContentView.prototype._debuggerPaused):
551         (WebInspector.TimelineContentView.prototype._debuggerResumed):
552
553
554 2014-10-23  Jono Wells  <jonowells@apple.com>
555
556         Web Inspector: Double border appearing in node sidebar in expanded items in OS X Mavericks.
557         https://bugs.webkit.org/show_bug.cgi?id=138011
558
559         Reviewed by Timothy Hatcher.
560
561         Selector added for OS X Mavericks and earlier versions using .mac-platform.legacy.
562
563         * UserInterface/Views/DetailsSection.css:
564         (body.mac-platform.legacy .details-section .details-section:first-child):
565
566 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
567
568         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
569         https://bugs.webkit.org/show_bug.cgi?id=132044
570
571         Reviewed by Brian Burg.
572
573         Make sure Protocol/InspectorFrontendHostStub.js is loaded before
574         Base/Platform.js, because Platform uses the InspectorFrontendHost
575         object.
576
577         * UserInterface/Main.html:
578
579 2014-10-20  Joseph Pecoraro  <pecoraro@apple.com>
580
581         Web Inspector: InspectorBackendCommands should include when to activate particular domains
582         https://bugs.webkit.org/show_bug.cgi?id=137753
583
584         Reviewed by Timothy Hatcher.
585
586         * UserInterface/Base/Main.js:
587         * UserInterface/Base/Test.js:
588         (WebInspector.loaded):
589         Activation now happens automatically so remove the hardcoded activations.
590
591         * UserInterface/Protocol/InspectorBackend.js:
592         (InspectorBackendClass.prototype.activateDomain):
593         Given no filter, always activate a domain. Otherwise only activate
594         if the debuggable type matches the provided filter.
595
596         * UserInterface/Protocol/Legacy/6.0/InspectorBackendCommands.js:
597         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
598         Only web debuggables are supported in iOS 6 and 7. The JSON files do not
599         need to change, all agents will auto activate.
600
601         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
602         * Versions/Inspector-iOS-8.0.json:
603         Specify which are web debuggables in iOS 8 since JS inspection is possible.
604
605 2014-10-20  Joseph Pecoraro  <pecoraro@apple.com>
606
607         Web Inspector: Generate all Inspector domains together in JavaScriptCore
608         https://bugs.webkit.org/show_bug.cgi?id=137748
609
610         Reviewed by Brian Burg.
611
612         Change the frontend to always load all agents, but only activate a subset
613         of the agents depending on the type of the backend.
614
615         * UserInterface/Base/Main.js:
616         (WebInspector.loaded):
617         * UserInterface/Protocol/InspectorBackend.js:
618         (InspectorBackendClass.prototype.activateDomains):
619         (InspectorBackendClass.prototype.activateAllDomains):
620         (InspectorBackendClass.prototype._agentForDomain):
621         (InspectorBackendClass.prototype._dispatchEvent):
622         (InspectorBackend.Agent):
623         (InspectorBackend.Agent.prototype.get active):
624         (InspectorBackend.Agent.prototype.activate):
625         * UserInterface/Base/Test.js:
626         Only expose "window.FooAgent" or allow dispatches in the "Foo" domain
627         when that particular agent is activated. Currently we hardcode the list
628         of agents to activate for a debuggable type. This should be generated.
629
630         * UserInterface/Protocol/LoadInspectorBackendCommands.js:
631         Now there should always be a single "InspectorBackendCommands.js" file to load.
632         We may want to change the RWI path to return a single file instead of an array.
633
634         * Scripts/update-LegacyInspectorBackendCommands.rb:
635         * UserInterface/Protocol/Legacy/6.0/InspectorBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js.
636         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js.
637         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js.
638         * UserInterface/Protocol/Legacy/8.0/InspectorJSBackendCommands.js: Removed.
639         * Versions/Inspector-iOS-8.0.json: Renamed from Source/WebInspectorUI/Versions/InspectorWeb-iOS-8.0.json.
640         * Versions/InspectorJS-iOS-8.0.json: Removed.
641         Update Legacy versions to output a single InspectorBackendCommands.js file.
642         Do a straightforward merge of the iOS 8 JS/Web inputs to a single json file.
643
644         * Configurations/Base.xcconfig:
645         * Configurations/DebugRelease.xcconfig:
646         * Configurations/WebInspectorUIFramework.xcconfig:
647         * Scripts/copy-user-interface-resources-dryrun.rb:
648         * Scripts/copy-user-interface-resources.pl:
649         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
650         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
651         * WebInspectorUI.vcxproj/build-webinspectorui.pl:
652         We no longer needed WebCore's Private Headers, so simplify build files
653         and update file names where appropriate.
654
655 2014-10-17  Jono Wells  <jonowells@apple.com>
656
657         Web Inspector: Add ESLint open source library to the inspector
658         https://bugs.webkit.org/show_bug.cgi?id=137714
659
660         Reviewed by Joseph Pecoraro.
661
662         This adds back the eslint.js external library with a correction to Scripts/copy-user-interface-resources.pl
663         to prevent a build failure.
664
665         * Scripts/copy-user-interface-resources.pl: Added copy commands for ESLint.js.
666         * UserInterface/External/ESLint/LICENSE: Added.
667         * UserInterface/External/ESLint/eslint.js: Added.
668
669 2014-10-14  Jono Wells  <jonowells@apple.com>
670
671         Web Inspector: Add ESLint open source library to the inspector
672         https://bugs.webkit.org/show_bug.cgi?id=137714
673
674         Reviewed by Timothy Hatcher.
675
676         This adds the eslint.js external library for static analysis and the necessary license.
677
678         * Scripts/copy-user-interface-resources.pl:
679         * UserInterface/External/ESLint/LICENSE: Added.
680         * UserInterface/External/ESLint/eslint.js: Added.
681
682 2014-10-14  Joseph Pecoraro  <pecoraro@apple.com>
683
684         Web Inspector: paint flashing mode should be disabled when remote inspecting legacy iOS versions
685         https://bugs.webkit.org/show_bug.cgi?id=137575
686
687         Reviewed by Simon Fraser.
688
689         Remove setShowPaintRects from the legacy iOS protocol definitions.
690         The methods were unimplemented by the backends, so they should
691         not advertise supporting it.
692
693         * UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js:
694         * UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
695         * UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js:
696         * Versions/Inspector-iOS-6.0.json:
697         * Versions/Inspector-iOS-7.0.json:
698         * Versions/InspectorWeb-iOS-8.0.json:
699
700 2014-10-14  Joseph Pecoraro  <pecoraro@apple.com>
701
702         Web Inspector: Processing Instruction Nodes appear poorly in DOM Tree
703         https://bugs.webkit.org/show_bug.cgi?id=137681
704
705         Reviewed by Timothy Hatcher.
706
707         Handle processing instruction node types in more places. The
708         backend sends the contents as a pure string, not as attribute
709         pairs, so just include the string in the UI.
710
711         * UserInterface/Models/DOMSearchMatchObject.js:
712         (WebInspector.DOMSearchMatchObject.prototype._generateClassName):
713         (WebInspector.DOMSearchMatchObject.titleForDOMNode):
714         * UserInterface/Views/DOMTreeElement.js:
715         (WebInspector.DOMTreeElement.prototype._nodeTitleInfo):
716         Display the value in the UI.
717
718         * UserInterface/Views/DOMTreeElementPathComponent.js:
719         (WebInspector.DOMTreeElementPathComponent):
720         Include an icon like DOCTYPE.
721
722         * UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
723         (.syntax-highlighted .html-processing-instruction):
724         Style gray like a DOCTYPE.
725
726 2014-10-13  Joseph Pecoraro  <pecoraro@apple.com>
727
728         Web Inspector: Paint Flashing button does not match page state after reload
729         https://bugs.webkit.org/show_bug.cgi?id=137680
730
731         Reviewed by Timothy Hatcher.
732
733         * UserInterface/Base/Main.js:
734         (WebInspector.loaded):
735         Make paint flashing a frontend setting. Enable it when the inspector
736         is opened if it was previously enabled.
737
738         * UserInterface/Views/DOMTreeContentView.js:
739         (WebInspector.DOMTreeContentView):
740         (WebInspector.DOMTreeContentView.prototype._togglePaintFlashing):
741         (WebInspector.DOMTreeContentView.prototype._showPaintRectsSettingChanged):
742         Have the paint flashing button always match the global setting.
743
744 2014-10-13  Joseph Pecoraro  <pecoraro@apple.com>
745
746         Web Inspector: Improve appearance of alpha color swatches
747         https://bugs.webkit.org/show_bug.cgi?id=137627
748
749         Reviewed by Andreas Kling.
750
751         * UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
752         * UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js:
753         * Versions/Inspector-iOS-7.0.json:
754         * Versions/InspectorWeb-iOS-8.0.json:
755
756 2014-10-10  Joseph Pecoraro  <pecoraro@apple.com>
757
758         Web Inspector: Improve appearance of alpha color swatches
759         https://bugs.webkit.org/show_bug.cgi?id=137627
760
761         Reviewed by Timothy Hatcher.
762
763         This improves the sizes. The color-swatch size is 1em x 1em,
764         which ends up being 11px, and thus there is still an imbalance.
765         However on both 1x and 2x displays this looks more even.
766
767         * UserInterface/Views/CSSStyleDeclarationTextEditor.css:
768         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .color-swatch):
769
770 2014-10-10  Joseph Pecoraro  <pecoraro@apple.com>
771
772         Web Inspector: assert always logs undefined instead of the desired string
773         https://bugs.webkit.org/show_bug.cgi?id=137632
774
775         Reviewed by Timothy Hatcher.
776
777         * UserInterface/Protocol/InspectorFrontendAPI.js:
778         (InspectorFrontendAPI.dispatch):
779         Fix the assert log to include the method name.
780
781 2014-10-10  Joseph Pecoraro  <pecoraro@apple.com>
782
783         Web Inspector: CSS minification should not strip whitespace around calc +/- binary operators
784         https://bugs.webkit.org/show_bug.cgi?id=137624
785
786         Reviewed by Timothy Hatcher.
787
788         Be careful when stripping whitespace around "+". We want to strip for
789         selectors "a + b" but not for calc expressions "calc(1px + 2px)".
790
791         This is not a perfect solution, but it does a good job. It may still break
792         with more complex calc expressions, like "calc(1px + calc())" but this
793         handles the basics.
794
795         * Scripts/copy-user-interface-resources-dryrun.rb: Added.
796         * Scripts/cssmin.py:
797         (cssminify):
798
799 2014-10-09  Joseph Pecoraro  <pecoraro@apple.com>
800
801         Web Inspector: DOM Storage Editing is broken in many ways, frustrating
802         https://bugs.webkit.org/show_bug.cgi?id=137547
803
804         Reviewed by Timothy Hatcher.
805
806         * UserInterface/Models/DOMStorageObject.js:
807         (WebInspector.DOMStorageObject.prototype.getEntries): Deleted.
808         When getting entires, populate the model object with these keys/values
809         so we can accurately detect duplicates in editing.
810
811         * UserInterface/Views/DataGrid.js:
812         (WebInspector.DataGrid.prototype.determineNextCell):
813         (WebInspector.DataGrid.prototype.moveToNextCell):
814         When the users uses "Enter" to commit, stop editing.
815
816         (WebInspector.DataGrid.prototype._editingCommitted):
817         Fix title property accessor. This is not a map. This fixes an exception
818         when showing context menus on editable data grid rows.
819
820         * UserInterface/Views/DOMStorageContentView.js:
821         (WebInspector.DOMStorageContentView.prototype.cleanup):
822         (WebInspector.DOMStorageContentView.prototype.restoreOriginalValues):
823         (WebInspector.DOMStorageContentView.prototype._editingCallback):
824         Completely rewrite editing here. As soon as an edit is made, enter
825         an uncommitted state with the original key/value. When a commit is
826         allowed, update as appropriate based on the original values.
827
828 2014-10-08  Joseph Pecoraro  <pecoraro@apple.com>
829
830         Web Inspector: CSS Pretty Printing fails to put space between value functions around ending parenthesis
831         https://bugs.webkit.org/show_bug.cgi?id=137415
832
833         Reviewed by Timothy Hatcher.
834
835         Add a space after a closing parenthesis if we are still inside a property.
836         This adds space between space separated function lists such as
837         -webkit-transform:foo(...)bar(...). Also add a test for keyframe syntax.
838
839         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
840         * Tools/PrettyPrinting/css-tests/keyframes-expected.css: Added.
841         * Tools/PrettyPrinting/css-tests/keyframes.css: Added.
842         * Tools/PrettyPrinting/index.html:
843         * UserInterface/Views/CodeMirrorFormatters.js:
844
845 2014-10-08  Joseph Pecoraro  <pecoraro@apple.com>
846
847         Web Inspector: CSS Pretty Printing fails to put space between rgb(...) and numbers in minified gradients
848         https://bugs.webkit.org/show_bug.cgi?id=137414
849
850         Reviewed by Timothy Hatcher.
851
852         Add whitespace between rgb(...) and a number, possible in gradient
853         syntax like "linear-gradient(rgb(...)0%,rgb(...)100%)".
854
855         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
856         * Tools/PrettyPrinting/css-tests/gradient-expected.css: Added.
857         (.dot-nav:nth-child(1n) li a.active):
858         * Tools/PrettyPrinting/css-tests/gradient.css: Added.
859         (.dot-nav:nth-child(1n) li a.active):
860         * Tools/PrettyPrinting/index.html:
861         * UserInterface/Views/CodeMirrorFormatters.js:
862
863 2014-10-08  Joseph Pecoraro  <pecoraro@apple.com>
864
865         Web Inspector: CSS Pretty Printing fails to wrap long lines of selectors with pseudo classes/elements
866         https://bugs.webkit.org/show_bug.cgi?id=137413
867
868         Reviewed by Timothy Hatcher.
869
870         Long line wrapping was breaking as soon as there was a ':' for a psuedo
871         class or element. Likewise it was counting comment strings as part of
872         the length of the line even though it would get a newline after it.
873
874         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
875         * Tools/PrettyPrinting/css-tests/basic-expected.css:
876         (progress, section, summary, time):
877         * Tools/PrettyPrinting/css-tests/wrapping-expected.css: Added.
878         (a.tryamacs, a.upgradenows):
879         (a.tryamacs:hover, a.upgradenows:hover):
880         * Tools/PrettyPrinting/css-tests/wrapping.css: Added.
881         (a.browsewebappss,a.businessstores,a.buyiphones,a.buynows,a.buynows-arrow,a.comingsoons,p::before,a.descargarahoras,a.downloadituness,a.downloadnows,a.finds,a.freetrials,a.getstarteds,a.gos,a.howtoapplys,a.howtobuys,a.joinnows,a.learnmores,a.nikebuynows,a.notifymes,a.ordernows,a.preordernows,a.preorders,a.reserves,a.startyoursearchs,a.submits,a.tryamacs,a.upgradenows):
882         (a.browsewebappss:hover,a.businessstores:hover,a.buyiphones:hover,a.buynows:hover,a.buynows-arrow:hover,a.comingsoons:hover,p::before,a.descargarahoras:hover,a.downloadituness:hover,a.downloadnows:hover,a.finds:hover,a.freetrials:hover,a.getstarteds:hover,a.gos:hover,a.howtoapplys:hover,a.howtobuys:hover,a.joinnows:hover,a.learnmores:hover,a.nikebuynows:hover,a.notifymes:hover,a.ordernows:hover,a.preordernows:hover,a.preorders:hover,a.reserves:hover,a.startyoursearchs:hover,a.submits:hover,a.tryamacs:hover,a.upgradenows:hover):
883         * Tools/PrettyPrinting/index.html:
884         * UserInterface/Views/CodeMirrorFormatters.js:
885
886 2014-10-04  Joseph Pecoraro  <pecoraro@apple.com>
887
888         Web Inspector: Add PrettyPrinter CSS tests
889         https://bugs.webkit.org/show_bug.cgi?id=134005
890
891         Reviewed by Timothy Hatcher.
892
893         Add CSS pretty printing tests. Improve pretty printing of calc()
894         expressions and media-queries with whitespace around operators
895         and keywords. Also fix the debug output in the tool for CSS.
896
897         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
898         * Tools/PrettyPrinting/FormatterContentBuilder.js:
899         (FormatterContentBuilder.prototype._appendIndent):
900         * Tools/PrettyPrinting/FormatterDebug.js:
901         (.debugToken):
902         (Formatter.prototype.debug):
903         * Tools/PrettyPrinting/css-tests/basic-expected.css: Added.
904         * Tools/PrettyPrinting/css-tests/basic.css: Added.
905         * Tools/PrettyPrinting/css-tests/calc-expected.css: Added.
906         * Tools/PrettyPrinting/css-tests/calc.css: Added.
907         * Tools/PrettyPrinting/css-tests/media-query-expected.css: Added.
908         * Tools/PrettyPrinting/css-tests/media-query.css: Added.
909         * Tools/PrettyPrinting/css-tests/selectors-expected.css: Added.
910         * Tools/PrettyPrinting/css-tests/selectors.css: Added.
911         * Tools/PrettyPrinting/index.html:
912         * UserInterface/Views/CodeMirrorFormatters.js:
913
914 2014-10-04  Brian J. Burg  <burg@cs.washington.edu>
915
916         Unreviewed, rolling out r174319.
917
918         Causes assertions in fast/profiler tests. Needs nontrivial
919         investigation, will take offline.
920
921         Reverted changeset:
922
923         "Web Inspector: timelines should not count time elapsed while
924         paused in the debugger"
925         https://bugs.webkit.org/show_bug.cgi?id=136351
926         http://trac.webkit.org/changeset/174319
927
928 2014-10-04  Brian J. Burg  <burg@cs.washington.edu>
929
930         Web Inspector: timelines should not count time elapsed while paused in the debugger
931         https://bugs.webkit.org/show_bug.cgi?id=136351
932
933         Reviewed by Timothy Hatcher.
934
935         Don't update the timeline's current time when the debugger is paused.
936
937         Start and end times for timeline records are now in seconds elapsed since timeline
938         recording started, rather than milliseconds since the epoch. Add a workaround to
939         preserve compatibility with old backends.
940
941         * UserInterface/Controllers/TimelineManager.js:
942         (WebInspector.TimelineManager.prototype.capturingStarted):
943         (WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
944         (WebInspector.TimelineManager.prototype.eventRecorded):
945         * UserInterface/Views/TimelineContentView.js:
946         (WebInspector.TimelineContentView.prototype._debuggerPaused):
947         (WebInspector.TimelineContentView.prototype._debuggerResumed):
948
949 2014-10-03  Saam Barati  <saambarati1@gmail.com>
950
951         Web Inspector: Move the computation that results in UI strings from JSC to the Web Inspector
952         https://bugs.webkit.org/show_bug.cgi?id=137295
953
954         Reviewed by Timothy Hatcher.
955
956         The inspector now computes a set of properties that was previously 
957         computed inside JSC. 
958
959         This patch also addresses the weird experience of the 
960         type of an expression claiming to be both a Number and 
961         an Integer. This could be a bit confusing because Number 
962         is supposed to represent Double|Integer and the previous
963         UI implied that Number was equivalent to Double. The new UI only 
964         ever shows either the type of Number or Integer when showing
965         the type information of an expression. It never shows both Number
966         and Integer simultaneously to describe a single expression.
967
968         * UserInterface/Models/TypeSet.js:
969         (WebInspector.TypeSet):
970         (WebInspector.TypeSet.prototype.isContainedIn):
971         (WebInspector.TypeSet.prototype.get primitiveTypeNames):
972         * UserInterface/Views/TypePropertiesSection.js:
973         (WebInspector.TypePropertiesSection):
974         (WebInspector.TypePropertiesSection.prototype.onpopulate):
975         * UserInterface/Views/TypeTokenView.js:
976         (WebInspector.TypeTokenView):
977         (WebInspector.TypeTokenView.prototype.update):
978         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
979         (WebInspector.TypeTokenView.prototype._displayTypeName):
980
981 2014-10-02  Joseph Pecoraro  <pecoraro@apple.com>
982
983         Web Inspector: Cannot add a new CSS Rule to elements with 3 or more class names
984         https://bugs.webkit.org/show_bug.cgi?id=137375
985
986         Reviewed by Timothy Hatcher.
987
988         Correctly merge all class names with dots instead of just the first two.
989
990         * UserInterface/Models/DOMNode.js:
991
992 2014-10-02  Mark Lam  <mark.lam@apple.com>
993
994         Fixed the Inspector to be able to properly distinguish between scope types.
995         <https://webkit.org/b/137279>
996
997         Reviewed by Geoffrey Garen and Joseph Pecoraro.
998
999         * Localizations/en.lproj/localizedStrings.js:
1000         * UserInterface/Controllers/DebuggerManager.js:
1001         * UserInterface/Models/ScopeChainNode.js:
1002         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
1003         - Added handling of the FunctionNameScope case.
1004
1005 2014-10-02  Andres Gomez  <agomez@igalia.com>
1006
1007         Web Inspector: [GTK] Missing icons and enhancing the proportion and visibility of some icons
1008         https://bugs.webkit.org/show_bug.cgi?id=137248
1009
1010         Reviewed by Carlos Garcia Campos.
1011
1012         Add more free icons and removed some unused ones for the Web
1013         Inspector in GTK+.
1014         Also, enhanced the visibility and/or proportion of several of the
1015         icons.
1016
1017         * UserInterface/Images/gtk/AUTHORS:
1018         * UserInterface/Images/gtk/COPYING:
1019         * UserInterface/Images/gtk/Checkers.svg: Added.
1020         * UserInterface/Images/gtk/Circle.svg: Added.
1021         * UserInterface/Images/gtk/CloseLarge.svg: Added.
1022         * UserInterface/Images/gtk/CloseTimeline.png: Removed.
1023         * UserInterface/Images/gtk/CloseTimeline@2x.png: Removed.
1024         * UserInterface/Images/gtk/Crosshair.svg:
1025         * UserInterface/Images/gtk/DOMCharacterData.svg:
1026         * UserInterface/Images/gtk/DOMComment.svg:
1027         * UserInterface/Images/gtk/DOMDocument.svg:
1028         * UserInterface/Images/gtk/DOMDocumentType.svg:
1029         * UserInterface/Images/gtk/DOMElement.svg:
1030         * UserInterface/Images/gtk/DOMNode.svg:
1031         * UserInterface/Images/gtk/DOMTextNode.svg:
1032         * UserInterface/Images/gtk/DOMTree.svg:
1033         * UserInterface/Images/gtk/EventListener.svg:
1034         * UserInterface/Images/gtk/Exception.svg:
1035         * UserInterface/Images/gtk/Function.svg:
1036         * UserInterface/Images/gtk/GradientStop.png: Added.
1037         * UserInterface/Images/gtk/GradientStop@2x.png: Added.
1038         * UserInterface/Images/gtk/GradientStopSelected.png: Added.
1039         * UserInterface/Images/gtk/GradientStopSelected@2x.png: Added.
1040         * UserInterface/Images/gtk/Issues.svg:
1041         * UserInterface/Images/gtk/IssuesEnabled.svg:
1042         * UserInterface/Images/gtk/LessColumns.svg: Removed.
1043         * UserInterface/Images/gtk/Logs.svg:
1044         * UserInterface/Images/gtk/Memory.svg: Removed.
1045         * UserInterface/Images/gtk/MoreColumns.svg: Removed.
1046         * UserInterface/Images/gtk/Native.svg:
1047         * UserInterface/Images/gtk/NavigationItemAngleBrackets.svg:
1048         * UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg:
1049         * UserInterface/Images/gtk/NavigationItemBug.svg:
1050         * UserInterface/Images/gtk/NavigationItemFile.svg:
1051         * UserInterface/Images/gtk/NavigationItemLayers.svg:
1052         * UserInterface/Images/gtk/NavigationItemMagnifyingGlass.svg: Removed.
1053         * UserInterface/Images/gtk/NavigationItemProbes.pdf: Added.
1054         * UserInterface/Images/gtk/NavigationItemStopwatch.svg:
1055         * UserInterface/Images/gtk/NavigationItemTypes.svg: Added.
1056         * UserInterface/Images/gtk/PaintFlashing.svg: Added.
1057         * UserInterface/Images/gtk/PseudoElement.svg:
1058         * UserInterface/Images/gtk/Record.svg: Added.
1059         * UserInterface/Images/gtk/Recording.png: Removed.
1060         * UserInterface/Images/gtk/Recording@2x.png: Removed.
1061         * UserInterface/Images/gtk/RecordingHovered.png: Removed.
1062         * UserInterface/Images/gtk/RecordingHovered@2x.png: Removed.
1063         * UserInterface/Images/gtk/RecordingStopped.png: Removed.
1064         * UserInterface/Images/gtk/RecordingStopped@2x.png: Removed.
1065         * UserInterface/Images/gtk/Reflection.svg:
1066         * UserInterface/Images/gtk/ReplayPauseButton.svg: Added.
1067         * UserInterface/Images/gtk/ReplayPlayButton.svg: Added.
1068         * UserInterface/Images/gtk/ReplayRecordingButton.svg: Added.
1069         * UserInterface/Images/gtk/Request.svg:
1070         * UserInterface/Images/gtk/Resources.svg:
1071         * UserInterface/Images/gtk/Response.svg:
1072         * UserInterface/Images/gtk/ResultLine.svg:
1073         * UserInterface/Images/gtk/SourceCode.svg:
1074         * UserInterface/Images/gtk/Stop.svg: Added.
1075         * UserInterface/Images/gtk/StyleRuleAuthor.svg:
1076         * UserInterface/Images/gtk/StyleRuleInherited.svg:
1077         * UserInterface/Images/gtk/StyleRuleInheritedElement.svg:
1078         * UserInterface/Images/gtk/StyleRuleInspector.svg:
1079         * UserInterface/Images/gtk/StyleRuleUser.svg:
1080         * UserInterface/Images/gtk/StyleRuleUserAgent.svg:
1081         * UserInterface/Images/gtk/Time.svg:
1082         * UserInterface/Images/gtk/TimelineRecordAnimation.svg:
1083         * UserInterface/Images/gtk/TimelineRecordConsoleProfile.svg: Added.
1084         * UserInterface/Images/gtk/TimelineRecordEvent.svg:
1085         * UserInterface/Images/gtk/TimelineRecordLayout.svg:
1086         * UserInterface/Images/gtk/TimelineRecordPaint.svg:
1087         * UserInterface/Images/gtk/TimelineRecordProbeSampled.svg: Added.
1088         * UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg:
1089         * UserInterface/Images/gtk/TimelineRecordStyle.svg:
1090         * UserInterface/Images/gtk/TimelineRecordTimer.svg:
1091         * UserInterface/Images/gtk/Weight.svg:
1092
1093 2014-09-27  Brian J. Burg  <burg@cs.washington.edu>
1094
1095         Web Replay: Playback position updates should be sent before the next event loop input is dispatched
1096         https://bugs.webkit.org/show_bug.cgi?id=137162
1097
1098         Reviewed by Timothy Hatcher.
1099
1100         Pausing playback from the UI was broken because of a typo. Fix this, and rename
1101         stopPlayback to cancelPlayback.
1102
1103         * UserInterface/Controllers/ReplayManager.js:
1104         (WebInspector.ReplayManager.prototype.switchSession.if):
1105
1106 2014-09-26  Joseph Pecoraro  <pecoraro@apple.com>
1107
1108         Web Inspector: Automatic Inspection should continue once all breakpoints are loaded
1109         https://bugs.webkit.org/show_bug.cgi?id=137038
1110
1111         Reviewed by Timothy Hatcher.
1112
1113         * UserInterface/Base/Main.js:
1114         Send the initialized message after we have sent all other setup messages,
1115         such as enabling features and setting breakpoints.
1116
1117 2014-09-26  Saam Barati  <saambarati1@gmail.com>
1118
1119         Web Inspector: Type Token View shows type information on hover when it shouldn't
1120         https://bugs.webkit.org/show_bug.cgi?id=137152
1121
1122         Reviewed by Brian J. Burg.
1123
1124         TypeTokenView should only show type information when there is 
1125         more than one primitive type or more than zero objects types. 
1126         This fixes a bug in checking the length of object types.
1127
1128         * UserInterface/Views/TypeTokenView.js:
1129         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
1130
1131 2014-09-25  Timothy Hatcher  <timothy@apple.com>
1132
1133         Web Inspector: Show type info icon is blurry
1134         https://bugs.webkit.org/show_bug.cgi?id=137125
1135
1136         Reviewed by Darin Adler.
1137
1138         * UserInterface/Images/NavigationItemTypes.svg:
1139         * UserInterface/Views/ScriptContentView.js:
1140         (WebInspector.ScriptContentView):
1141         * UserInterface/Views/TextContentView.js:
1142         (WebInspector.TextContentView):
1143         * UserInterface/Views/TextResourceContentView.js:
1144         (WebInspector.TextResourceContentView):
1145
1146 2014-09-25  Saam Barati  <saambarati1@gmail.com>
1147
1148         Web Inspector: console.assert(bitString) TypeSet:50 
1149         https://bugs.webkit.org/show_bug.cgi?id=137051
1150
1151         Reviewed by Joseph Pecoraro.
1152
1153         This fixes TypeSet's isContainedIn method by ensuring that 
1154         the type bit string isn't zero because the test would trivially 
1155         pass if the bit string is zero.
1156
1157         * UserInterface/Models/TypeSet.js:
1158         (WebInspector.TypeSet.prototype.isContainedIn):
1159
1160 2014-09-25  Brian J. Burg  <burg@cs.washington.edu>
1161
1162         Web Inspector: FunctionCall timeline records omit profile data if the debugger has paused
1163         https://bugs.webkit.org/show_bug.cgi?id=136805
1164
1165         Reviewed by Timothy Hatcher.
1166
1167         * UserInterface/Test.html: Add missing include for ScopeChainNode.js.
1168
1169 2014-09-25  Brian J. Burg  <burg@cs.washington.edu>
1170
1171         Web Inspector: sort probe details sidebar sections by source code location string
1172         https://bugs.webkit.org/show_bug.cgi?id=137080
1173
1174         Reviewed by Timothy Hatcher.
1175
1176         Probe sections should display in the same order as associated breakpoint tree elements.
1177
1178         * UserInterface/Views/ProbeDetailsSidebarPanel.js:
1179         (WebInspector.ProbeDetailsSidebarPanel.prototype.inspect.inspectedProbeSets):
1180         (WebInspector.ProbeDetailsSidebarPanel.prototype.inspect):
1181
1182 2014-09-25  Andres Gomez  <agomez@igalia.com>
1183
1184         Unreviewed. Add more free icons for the Web Inspector in GTK+.
1185
1186         * UserInterface/Images/gtk/AUTHORS:
1187         * UserInterface/Images/gtk/ApplicationCacheManifest.png: Added.
1188         * UserInterface/Images/gtk/ApplicationCacheManifest@2x.png: Added.
1189         * UserInterface/Images/gtk/COPYING:
1190         * UserInterface/Images/gtk/COPYING_LGPL2: Added.
1191         * UserInterface/Images/gtk/Cookie.png: Added.
1192         * UserInterface/Images/gtk/Cookie@2x.png: Added.
1193         * UserInterface/Images/gtk/HoverMenuButton.png: Added.
1194         * UserInterface/Images/gtk/HoverMenuButton@2x.png: Added.
1195         * UserInterface/Images/gtk/InstructionPointer.png: Added.
1196         * UserInterface/Images/gtk/InstructionPointer@2x.png: Added.
1197         * UserInterface/Images/gtk/Log.png: Added.
1198         * UserInterface/Images/gtk/Log@2x.png: Added.
1199         * UserInterface/Images/gtk/Profile.png: Added.
1200         * UserInterface/Images/gtk/Profile@2x.png: Added.
1201         * UserInterface/Images/gtk/Recording.png: Added.
1202         * UserInterface/Images/gtk/Recording@2x.png: Added.
1203         * UserInterface/Images/gtk/RecordingHovered.png: Added.
1204         * UserInterface/Images/gtk/RecordingHovered@2x.png: Added.
1205         * UserInterface/Images/gtk/RecordingStopped.png: Added.
1206         * UserInterface/Images/gtk/RecordingStopped@2x.png: Added.
1207         * UserInterface/Images/gtk/Script.png: Added.
1208         * UserInterface/Images/gtk/Script@2x.png: Added.
1209         * UserInterface/Images/gtk/ScriptLarge.png: Added.
1210         * UserInterface/Images/gtk/ScriptLarge@2x.png: Added.
1211         * UserInterface/Images/gtk/SliderThumb.png: Added.
1212         * UserInterface/Images/gtk/SliderThumb@2x.png: Added.
1213         * UserInterface/Images/gtk/SliderThumbPressed.png: Added.
1214         * UserInterface/Images/gtk/SliderThumbPressed@2x.png: Added.
1215         * UserInterface/Images/gtk/Stopwatch.png: Added.
1216         * UserInterface/Images/gtk/Stopwatch@2x.png: Added.
1217
1218 2014-09-21  Timothy Hatcher  <timothy@apple.com>
1219
1220         Make the Web Inspector use a separate web process.
1221
1222         https://bugs.webkit.org/show_bug.cgi?id=135120
1223
1224         Reviewed by Anders Carlsson.
1225
1226         * Localizations/en.lproj/localizedStrings.js: Updated.
1227
1228         * UserInterface/Base/Main.js:
1229         (WebInspector.loaded):
1230         (WebInspector.contentLoaded):
1231         Move InspectorFrontendHost.loaded to later in the load.
1232         Calling it early just shows the window before we have
1233         a user interface to show.
1234
1235         * UserInterface/Base/Test.js:
1236         (WebInspector.loaded):
1237         (WebInspector.contentLoaded):
1238         Match the changes in Main.js.
1239
1240         * UserInterface/Protocol/InspectorFrontendAPI.js:
1241         (InspectorFrontendAPI.savedURL): Change comment.
1242         (InspectorFrontendAPI.appendedToURL): Change comment.
1243         (InspectorFrontendAPI.dispatch): Add an assert and early
1244         return to be safe from unknown commands.
1245         (InspectorFrontendAPI.loadCompleted): Delete _pendingCommands,
1246         no need to keep an empty array around a one time use.
1247
1248 2014-09-24  Andres Gomez  <agomez@igalia.com>
1249
1250         Unreviewed. Add more free icons for the Web Inspector in GTK+
1251
1252         * UserInterface/Images/gtk/AUTHORS:
1253         * UserInterface/Images/gtk/ApplicationCache.png: Added.
1254         * UserInterface/Images/gtk/ApplicationCache@2x.png: Added.
1255         * UserInterface/Images/gtk/BottomUpTree.svg: Added.
1256         * UserInterface/Images/gtk/Breakpoint.png: Added.
1257         * UserInterface/Images/gtk/Breakpoint@2x.png: Added.
1258         * UserInterface/Images/gtk/BreakpointButton.svg:
1259         * UserInterface/Images/gtk/BreakpointInactive.png: Added.
1260         * UserInterface/Images/gtk/BreakpointInactive@2x.png: Added.
1261         * UserInterface/Images/gtk/BreakpointInactiveButton.svg:
1262         * UserInterface/Images/gtk/COPYING:
1263         * UserInterface/Images/gtk/COPYING_CCBYSA3: Copied from Source/WebInspectorUI/UserInterface/Images/gtk/COPYING.
1264         * UserInterface/Images/gtk/ClippingCSS.png: Added.
1265         * UserInterface/Images/gtk/ClippingCSS@2x.png: Added.
1266         * UserInterface/Images/gtk/ClippingGeneric.png: Added.
1267         * UserInterface/Images/gtk/ClippingGeneric@2x.png: Added.
1268         * UserInterface/Images/gtk/ClippingJS.png: Added.
1269         * UserInterface/Images/gtk/ClippingJS@2x.png: Added.
1270         * UserInterface/Images/gtk/CloseTimeline.png: Added.
1271         * UserInterface/Images/gtk/CloseTimeline@2x.png: Added.
1272         * UserInterface/Images/gtk/ColorIcon.png: Added.
1273         * UserInterface/Images/gtk/ColorIcon@2x.png: Added.
1274         * UserInterface/Images/gtk/Colors.png: Added.
1275         * UserInterface/Images/gtk/Colors@2x.png: Added.
1276         * UserInterface/Images/gtk/ColorsLarge.png: Added.
1277         * UserInterface/Images/gtk/ColorsLarge@2x.png: Added.
1278         * UserInterface/Images/gtk/Database.png: Added.
1279         * UserInterface/Images/gtk/Database@2x.png: Added.
1280         * UserInterface/Images/gtk/DatabaseTable.png: Added.
1281         * UserInterface/Images/gtk/DatabaseTable@2x.png: Added.
1282         * UserInterface/Images/gtk/HierarchicalNavigationItemChevron.svg: Added.
1283         * UserInterface/Images/gtk/IndeterminateProgressSpinner1.svg: Added.
1284         * UserInterface/Images/gtk/IndeterminateProgressSpinner10.svg: Added.
1285         * UserInterface/Images/gtk/IndeterminateProgressSpinner11.svg: Added.
1286         * UserInterface/Images/gtk/IndeterminateProgressSpinner12.svg: Added.
1287         * UserInterface/Images/gtk/IndeterminateProgressSpinner2.svg: Added.
1288         * UserInterface/Images/gtk/IndeterminateProgressSpinner3.svg: Added.
1289         * UserInterface/Images/gtk/IndeterminateProgressSpinner4.svg: Added.
1290         * UserInterface/Images/gtk/IndeterminateProgressSpinner5.svg: Added.
1291         * UserInterface/Images/gtk/IndeterminateProgressSpinner6.svg: Added.
1292         * UserInterface/Images/gtk/IndeterminateProgressSpinner7.svg: Added.
1293         * UserInterface/Images/gtk/IndeterminateProgressSpinner8.svg: Added.
1294         * UserInterface/Images/gtk/IndeterminateProgressSpinner9.svg: Added.
1295         * UserInterface/Images/gtk/Issues.svg: Added.
1296         * UserInterface/Images/gtk/IssuesEnabled.svg: Added.
1297         * UserInterface/Images/gtk/LayerBorders.svg: Added.
1298         * UserInterface/Images/gtk/LessColumns.svg: Added.
1299         * UserInterface/Images/gtk/LocalStorage.png: Added.
1300         * UserInterface/Images/gtk/LocalStorage@2x.png: Added.
1301         * UserInterface/Images/gtk/Locked.svg: Added.
1302         * UserInterface/Images/gtk/Logs.svg: Added.
1303         * UserInterface/Images/gtk/Memory.svg: Added.
1304         * UserInterface/Images/gtk/MoreColumns.svg: Added.
1305         * UserInterface/Images/gtk/Native.svg: Added.
1306         * UserInterface/Images/gtk/NavigationItemAngleBrackets.svg: Added.
1307         * UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg: Added.
1308         * UserInterface/Images/gtk/NavigationItemBug.svg: Added.
1309         * UserInterface/Images/gtk/NavigationItemCurleyBraces.svg: Added.
1310         * UserInterface/Images/gtk/NavigationItemFile.svg: Added.
1311         * UserInterface/Images/gtk/NavigationItemLayers.svg: Added.
1312         * UserInterface/Images/gtk/NavigationItemLog.svg: Added.
1313         * UserInterface/Images/gtk/NavigationItemMagnifyingGlass.svg: Added.
1314         * UserInterface/Images/gtk/NavigationItemStopwatch.svg: Added.
1315         * UserInterface/Images/gtk/NavigationItemStorage.svg: Added.
1316         * UserInterface/Images/gtk/NavigationItemTrash.svg: Added.
1317         * UserInterface/Images/gtk/NavigationItemVariable.svg: Added.
1318         * UserInterface/Images/gtk/Network.png: Added.
1319         * UserInterface/Images/gtk/Network@2x.png: Added.
1320         * UserInterface/Images/gtk/NetworkLarge.png: Added.
1321         * UserInterface/Images/gtk/NetworkLarge@2x.png: Added.
1322         * UserInterface/Images/gtk/Pause.svg: Added.
1323         * UserInterface/Images/gtk/Percent.svg: Added.
1324         * UserInterface/Images/gtk/Plus.svg: Added.
1325         * UserInterface/Images/gtk/PseudoElement.svg: Added.
1326         * UserInterface/Images/gtk/Reflection.svg: Added.
1327         * UserInterface/Images/gtk/Reload.svg: Added.
1328         * UserInterface/Images/gtk/Request.svg: Added.
1329         * UserInterface/Images/gtk/Response.svg: Added.
1330         * UserInterface/Images/gtk/ResultLine.svg: Added.
1331         * UserInterface/Images/gtk/Resume.svg: Added.
1332         * UserInterface/Images/gtk/SessionStorage.png: Added.
1333         * UserInterface/Images/gtk/SessionStorage@2x.png: Added.
1334         * UserInterface/Images/gtk/ShadowDOM.svg: Added.
1335         * UserInterface/Images/gtk/SourceCode.svg: Added.
1336         * UserInterface/Images/gtk/SplitToggleDown.svg: Added.
1337         * UserInterface/Images/gtk/SplitToggleUp.svg: Added.
1338         * UserInterface/Images/gtk/StepInto.svg: Added.
1339         * UserInterface/Images/gtk/StepOut.svg: Added.
1340         * UserInterface/Images/gtk/StepOver.svg: Added.
1341         * UserInterface/Images/gtk/StyleRuleAuthor.svg: Added.
1342         * UserInterface/Images/gtk/StyleRuleInherited.svg: Added.
1343         * UserInterface/Images/gtk/StyleRuleInheritedElement.svg: Added.
1344         * UserInterface/Images/gtk/StyleRuleInspector.svg: Added.
1345         * UserInterface/Images/gtk/StyleRuleUser.svg: Added.
1346         * UserInterface/Images/gtk/StyleRuleUserAgent.svg: Added.
1347         * UserInterface/Images/gtk/Time.svg: Added.
1348         * UserInterface/Images/gtk/TimelineRecordAnimation.svg: Added.
1349         * UserInterface/Images/gtk/TimelineRecordEvent.svg: Added.
1350         * UserInterface/Images/gtk/TimelineRecordLayout.svg: Added.
1351         * UserInterface/Images/gtk/TimelineRecordPaint.svg: Added.
1352         * UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg: Added.
1353         * UserInterface/Images/gtk/TimelineRecordStyle.svg: Added.
1354         * UserInterface/Images/gtk/TimelineRecordTimer.svg: Added.
1355         * UserInterface/Images/gtk/Undock.svg: Added.
1356         * UserInterface/Images/gtk/UserInputPrompt.svg: Added.
1357         * UserInterface/Images/gtk/UserInputPromptPrevious.svg: Added.
1358         * UserInterface/Images/gtk/UserInputResult.svg: Added.
1359         * UserInterface/Images/gtk/Warning.svg: Added.
1360         * UserInterface/Images/gtk/Weight.svg: Added.
1361
1362 2014-09-23  Timothy Hatcher  <timothy@apple.com>
1363
1364         Web Inspector: Remove UserInterface/Images/gtk from Apple builds
1365         https://bugs.webkit.org/show_bug.cgi?id=136955
1366
1367         Reviewed by Joseph Pecoraro.
1368
1369         * Scripts/copy-user-interface-resources.pl:
1370         Remove Images/Legacy and Images/gtk on Mac and Windows builds by looking
1371         at the MAC_OS_X_VERSION_MAJOR and OFFICIAL_BUILD environment vars.
1372
1373 2014-09-21  Saam Barati  <saambarati1@gmail.com>
1374
1375         Web Inspector: fix TypeSet hierarchy in TypeTokenView
1376         https://bugs.webkit.org/show_bug.cgi?id=136982
1377
1378         Reviewed by Joseph Pecoraro.
1379
1380         The protocol object representation of TypeSet was being computed 
1381         incorrectly in JSC::TypeSet. This patch fixes that problem
1382         and also asserts that the type information that the Web Inspector
1383         receives is not empty.
1384
1385         * UserInterface/Models/TypeSet.js:
1386         (WebInspector.TypeSet):
1387         * UserInterface/Views/TypeTokenView.js:
1388         (WebInspector.TypeTokenView.prototype._displayTypeName):
1389
1390 2014-09-21  Saam Barati  <saambarati1@gmail.com>
1391
1392         Web Inspector: unlocalized 'many' string in type profiler inline bubble
1393         https://bugs.webkit.org/show_bug.cgi?id=136980
1394
1395         Reviewed by Timothy Hatcher.
1396
1397         Generate the localizable string for the type profiler's "many" inline bubble.
1398
1399         * Localizations/en.lproj/localizedStrings.js:
1400         * UserInterface/Views/TypeTokenView.js:
1401
1402 2014-09-20  Joseph Pecoraro  <pecoraro@apple.com>
1403
1404         Web Inspector: Option+Click on CSS url(...) should jump to resource view
1405         https://bugs.webkit.org/show_bug.cgi?id=136965
1406
1407         Reviewed by Timothy Hatcher.
1408
1409         * UserInterface/Views/CodeMirrorAdditions.js:
1410         When parsing CSS url(...) tokens, the contents of url(...)
1411         are a "string" type, not "atom".
1412
1413 2014-09-19  Daniel Bates  <dabates@apple.com>
1414
1415         Always assume internal SDK when building configuration Production
1416         https://bugs.webkit.org/show_bug.cgi?id=136925
1417         <rdar://problem/18362399>
1418
1419         Reviewed by Dan Bernstein.
1420
1421         * Configurations/DebugRelease.xcconfig: Also move #include of HaveInternalSDK.xcconfig from DebugRelease.xcconfig
1422         to Base.xcconfig so as to be consistent with the format of other Base.xcconfig/DebugRelease.xcconfig files
1423         (e.g. Source/WebCore/Configurations/Base.xcconfig and Source/WebCore/Configurations/DebugRelease.xcconfig).
1424
1425 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1426
1427         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
1428         https://bugs.webkit.org/show_bug.cgi?id=136632
1429
1430         Reviewed by Gustavo Noronha Silva.
1431
1432         Add free icons for the GTK port. These icons are from the GNOME
1433         project, some of them adapted by Andres Gomez for the inspector.
1434         This is only a subset of the icons, since we still don't have a
1435         free replacement for all of them, but at least it makes the
1436         inspector kind of usable.
1437
1438         * UserInterface/Images/gtk/AUTHORS: Added.
1439         * UserInterface/Images/gtk/BackArrow.svg: Added.
1440         * UserInterface/Images/gtk/BreakpointActionAdd.svg: Added.
1441         * UserInterface/Images/gtk/BreakpointActionRemove.svg: Added.
1442         * UserInterface/Images/gtk/BreakpointButton.svg: Added.
1443         * UserInterface/Images/gtk/BreakpointInactiveButton.svg: Added.
1444         * UserInterface/Images/gtk/Breakpoints.svg: Added.
1445         * UserInterface/Images/gtk/COPYING: Added.
1446         * UserInterface/Images/gtk/Close.svg: Added.
1447         * UserInterface/Images/gtk/CloseWhite.svg: Added.
1448         * UserInterface/Images/gtk/ContentFlow.svg: Added.
1449         * UserInterface/Images/gtk/Crosshair.svg: Added.
1450         * UserInterface/Images/gtk/DOMCharacterData.svg: Added.
1451         * UserInterface/Images/gtk/DOMComment.svg: Added.
1452         * UserInterface/Images/gtk/DOMDocument.svg: Added.
1453         * UserInterface/Images/gtk/DOMDocumentType.svg: Added.
1454         * UserInterface/Images/gtk/DOMElement.svg: Added.
1455         * UserInterface/Images/gtk/DOMNode.svg: Added.
1456         * UserInterface/Images/gtk/DOMTextNode.svg: Added.
1457         * UserInterface/Images/gtk/DOMTree.svg: Added.
1458         * UserInterface/Images/gtk/DisclosureTriangleSmallClosed.svg: Added.
1459         * UserInterface/Images/gtk/DisclosureTriangleSmallOpen.svg: Added.
1460         * UserInterface/Images/gtk/DisclosureTriangleTinyClosed.svg: Added.
1461         * UserInterface/Images/gtk/DisclosureTriangleTinyOpen.svg: Added.
1462         * UserInterface/Images/gtk/DockBottom.svg: Added.
1463         * UserInterface/Images/gtk/DockRight.svg: Added.
1464         * UserInterface/Images/gtk/DocumentCSS.png: Added.
1465         * UserInterface/Images/gtk/DocumentCSS@2x.png: Added.
1466         * UserInterface/Images/gtk/DocumentFont.png: Added.
1467         * UserInterface/Images/gtk/DocumentFont@2x.png: Added.
1468         * UserInterface/Images/gtk/DocumentGeneric.png: Added.
1469         * UserInterface/Images/gtk/DocumentGeneric@2x.png: Added.
1470         * UserInterface/Images/gtk/DocumentImage.png: Added.
1471         * UserInterface/Images/gtk/DocumentImage@2x.png: Added.
1472         * UserInterface/Images/gtk/DocumentJS.png: Added.
1473         * UserInterface/Images/gtk/DocumentJS@2x.png: Added.
1474         * UserInterface/Images/gtk/DocumentMarkup.png: Added.
1475         * UserInterface/Images/gtk/DocumentMarkup@2x.png: Added.
1476         * UserInterface/Images/gtk/DownloadArrow.svg: Added.
1477         * UserInterface/Images/gtk/Error.svg: Added.
1478         * UserInterface/Images/gtk/Errors.svg: Added.
1479         * UserInterface/Images/gtk/ErrorsEnabled.svg: Added.
1480         * UserInterface/Images/gtk/EventListener.svg: Added.
1481         * UserInterface/Images/gtk/Exception.svg: Added.
1482         * UserInterface/Images/gtk/FilterFieldGlyph.svg: Added.
1483         * UserInterface/Images/gtk/FolderGeneric.png: Added.
1484         * UserInterface/Images/gtk/FolderGeneric@2x.png: Added.
1485         * UserInterface/Images/gtk/ForwardArrow.svg: Added.
1486         * UserInterface/Images/gtk/Function.svg: Added.
1487         * UserInterface/Images/gtk/GoToArrow.svg: Added.
1488         * UserInterface/Images/gtk/Resources.svg: Added.
1489         * UserInterface/Images/gtk/SortIndicatorDownArrow.svg: Added.
1490         * UserInterface/Images/gtk/SortIndicatorUpArrow.svg: Added.
1491         * UserInterface/Images/gtk/UpDownArrows.svg: Added.
1492
1493 2014-09-17  Joseph Pecoraro  <pecoraro@apple.com>
1494
1495         Web Inspector: Remove unnecessary prefixes in WebInspectorUI CSS
1496         https://bugs.webkit.org/show_bug.cgi?id=136905
1497
1498         Reviewed by Timothy Hatcher.
1499
1500         Removed vendor prefixes from justify-content and a few lingering
1501         occurances with transition, box-shadow, and display.
1502
1503         * UserInterface/Views/BreakpointActionView.css:
1504         * UserInterface/Views/BreakpointTreeElement.css:
1505         * UserInterface/Views/ButtonNavigationItem.css:
1506         * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
1507         * UserInterface/Views/ControlToolbarItem.css:
1508         * UserInterface/Views/DebuggerDashboardView.css:
1509         * UserInterface/Views/DefaultDashboardView.css:
1510         * UserInterface/Views/FontResourceContentView.css:
1511         * UserInterface/Views/ImageResourceContentView.css:
1512         * UserInterface/Views/LayerTreeSidebarPanel.css:
1513         * UserInterface/Views/Main.css:
1514         * UserInterface/Views/NavigationBar.css:
1515         * UserInterface/Views/NavigationSidebarPanel.css:
1516         * UserInterface/Views/Popover.css:
1517         * UserInterface/Views/ReplayDashboardView.css:
1518         * UserInterface/Views/Toolbar.css:
1519
1520 2014-09-17  Dean Jackson  <dino@apple.com>
1521
1522         WebInpector can use unprefixed flexbox
1523         https://bugs.webkit.org/show_bug.cgi?id=136899
1524
1525         Reviewed by Joseph Pecoraro.
1526
1527         Now the inspector UI itself can use a non-prefixed flexbox. This was
1528         a basic search and replace for the following properties:
1529         - align-content
1530         - align-items
1531         - align-self
1532         - flex-basis
1533         - flex-direction
1534         - flex-wrap
1535         - flex-grow
1536         - flex-shrink
1537         - flex
1538         - flex-flow
1539         - justify
1540
1541         * UserInterface/Views/ButtonToolbarItem.css:
1542         * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
1543         * UserInterface/Views/ContentBrowser.css:
1544         * UserInterface/Views/ControlToolbarItem.css:
1545         * UserInterface/Views/DebuggerDashboardView.css:
1546         * UserInterface/Views/DefaultDashboardView.css:
1547         * UserInterface/Views/FilterBar.css:
1548         * UserInterface/Views/FlexibleSpaceNavigationItem.css:
1549         * UserInterface/Views/FontResourceContentView.css:
1550         * UserInterface/Views/HierarchicalPathComponent.css:
1551         * UserInterface/Views/ImageResourceContentView.css:
1552         * UserInterface/Views/LayerTreeSidebarPanel.css:
1553         * UserInterface/Views/LogContentView.css:
1554         * UserInterface/Views/Main.css:
1555         * UserInterface/Views/NavigationBar.css:
1556         * UserInterface/Views/NavigationSidebarPanel.css:
1557         * UserInterface/Views/Popover.css:
1558         * UserInterface/Views/QuickConsole.css:
1559         * UserInterface/Views/ReplayDashboardView.css:
1560         * UserInterface/Views/ResourceSidebarPanel.css:
1561         * UserInterface/Views/Toolbar.css:
1562
1563 2014-09-16  Dean Jackson  <dino@apple.com>
1564
1565         Add unprefixed flexbox display values and property names/values
1566         https://bugs.webkit.org/show_bug.cgi?id=136880
1567         <rdar://problem/18361137>
1568
1569         Reviewed by Benjamin Poulain with some extra comments by Joseph Pecoraro.
1570
1571         * UserInterface/Models/CSSKeywordCompletions.js: Switch to all the unprefixed
1572         flex properties.
1573
1574 2014-09-16  Joseph Pecoraro  <pecoraro@apple.com>
1575
1576         Web Inspector: Add Versioned Inspector protocol JSON files for iOS 8.0
1577         https://bugs.webkit.org/show_bug.cgi?id=136873
1578
1579         Reviewed by Timothy Hatcher.
1580
1581         * Scripts/update-LegacyInspectorBackendCommands.rb:
1582         * UserInterface/Protocol/Legacy/8.0/InspectorJSBackendCommands.js: Added.
1583         * UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js: Added.
1584         * Versions/InspectorJS-iOS-8.0.json: Added.
1585         * Versions/InspectorWeb-iOS-8.0.json: Added.
1586
1587 2014-09-16  Joseph Pecoraro  <pecoraro@apple.com>
1588
1589         Web Inspector: Fix ESLint no-extra-bind warnings
1590         https://bugs.webkit.org/show_bug.cgi?id=136659
1591
1592         Reviewed by Timothy Hatcher.
1593
1594         * .eslintrc:
1595         * UserInterface/Controllers/LayerTreeManager.js:
1596         (WebInspector.LayerTreeManager.prototype.layersForNode):
1597
1598 2014-09-15  Matt Baker  <mattbaker@apple.com>
1599
1600         Web Inspector: mouse drifts away from resizer when resizing docked inspector
1601         https://bugs.webkit.org/show_bug.cgi?id=22263
1602
1603         Reviewed by Joseph Pecoraro.
1604
1605         Modified the docked resizer dragging logic to record the initial mouse down position relative to the
1606         resizer client rectangle. Added check while dragging the resizer to ensure that the cursor is positioned
1607         correctly with respect to the resize direction before updating the attached window dimension.
1608
1609         * UserInterface/Base/Main.js:
1610         (WebInspector._dockedResizerMouseDown.dockedResizerDrag):
1611
1612 2014-09-11  Joseph Pecoraro  <pecoraro@apple.com>
1613
1614         Web Inspector: Fix assert in QuickConsole - main frame execution context path component
1615         https://bugs.webkit.org/show_bug.cgi?id=136748
1616
1617         Reviewed by Timothy Hatcher.
1618
1619         This can get called for the MainFrame on page navigations.
1620         In such cases we can return a better result from this method.
1621
1622         * UserInterface/Views/QuickConsole.js:
1623         (WebInspector.QuickConsole.prototype._insertExecutionContextPathComponentForFrame):
1624
1625 2014-09-11  Joseph Pecoraro  <pecoraro@apple.com>
1626
1627         Web Inspector: Hide DOM search result highlights when find banner is not showing
1628         https://bugs.webkit.org/show_bug.cgi?id=136749
1629
1630         Reviewed by Timothy Hatcher.
1631
1632         Match search highlights in TextEditor by only showing the highlight
1633         when the find banner is showing.
1634
1635         * UserInterface/Views/DOMTreeOutline.css:
1636         (.showing-find-banner .dom-tree-outline .search-result):
1637         (.dom-tree-outline .search-highlight): Deleted.
1638
1639 2014-09-11  Joseph Pecoraro  <pecoraro@apple.com>
1640
1641         Web Inspector: DOM Tree search highlights are not appearing
1642         https://bugs.webkit.org/show_bug.cgi?id=136662
1643
1644         Reviewed by Timothy Hatcher.
1645
1646         When performing a search within the DOMTreeContentView all
1647         search results should immediately highlight. When moving
1648         between search results, emphasize the current with a bouncy.
1649         Remember to remove the highlights when the search is changed
1650         or cleared.
1651
1652         * UserInterface/Views/DOMTreeContentView.js:
1653         (WebInspector.DOMTreeContentView.prototype.performSearch.searchResultsReady):
1654         (WebInspector.DOMTreeContentView.prototype.searchCleared):
1655         Shor or hide highlights when searches change.
1656
1657         (WebInspector.DOMTreeContentView.prototype.revealResult):
1658         (WebInspector.DOMTreeContentView.prototype._revealSearchResult):
1659         Emphasize the highlight when moving to a new current result.
1660
1661         (WebInspector.DOMTreeContentView.prototype._showSearchHighlights):
1662         (WebInspector.DOMTreeContentView.prototype._hideSearchHighlights):
1663         On each affected DOMTreeElement show or hide search highlights.
1664
1665         * UserInterface/Views/DOMTreeElement.js:
1666         (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight.animationEnded):
1667         (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight):
1668         Give a brief bouncy-highlight when told to emphasize the search highlight.
1669
1670         (WebInspector.DOMTreeElement.prototype.updateTitle):
1671         Remove unused and unnecessary style class on each row.
1672
1673         (WebInspector.DOMTreeElement.prototype._highlightSearchResults):
1674         Update the stale code to use new function names and accessors.
1675
1676         * UserInterface/Views/DOMTreeOutline.css:
1677         (.dom-tree-outline .search-highlight):
1678         Styles for the search highlight match search highlights in the sidebar.
1679
1680         * UserInterface/Views/Main.css:
1681         (.bouncy-highlight):
1682         * UserInterface/Views/TextEditor.css:
1683         Move bouncy-highlight to Main.css.
1684
1685 2014-09-10  Saam Barati  <saambarati1@gmail.com>
1686
1687         Web Inspector: Modify the type profiler runtime protocol to transfer some computation into the WebInspector
1688         https://bugs.webkit.org/show_bug.cgi?id=136500
1689
1690         Reviewed by Joseph Pecoraro.
1691
1692         This patch maintains the same UI in the Web Inspector for displaying
1693         type information, but now accounts for the new protocol for type profiling.
1694         
1695         The Inspector now has a TypeSet class that wraps the TypeDescription 
1696         protocol object and creates a simple interface for asking protocol objects 
1697         about their type.
1698
1699         * UserInterface/Controllers/TypeTokenAnnotator.js:
1700         (WebInspector.TypeTokenAnnotator.prototype._insertTypeTokensForEachNode):
1701         * UserInterface/Main.html:
1702         * UserInterface/Models/TypeSet.js: Added.
1703         (WebInspector.TypeSet):
1704         (WebInspector.TypeSet.fromPayload):
1705         (WebInspector.TypeSet.prototype.isContainedIn):
1706         * UserInterface/Views/SourceCodeTextEditor.js:
1707         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation.handler):
1708         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation):
1709         * UserInterface/Views/TypePropertiesSection.js:
1710         (WebInspector.TypePropertiesSection.prototype.onpopulate):
1711         (WebInspector.TypePropertyTreeElement.prototype.onpopulate):
1712         * UserInterface/Views/TypeTokenView.js:
1713         (WebInspector.TypeTokenView.prototype.update):
1714         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
1715         (WebInspector.TypeTokenView.prototype._displayTypeName):
1716
1717 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1718
1719         Web Inspector: Eliminate typeof "undefined" checks
1720         https://bugs.webkit.org/show_bug.cgi?id=136691
1721
1722         Reviewed by Alexey Proskuryakov.
1723
1724         * UserInterface/Base/Main.js:
1725         (WebInspector.linkifyURLAsNode):
1726         (WebInspector.linkifyStringAsFragment):
1727         * UserInterface/Protocol/InspectorBackend.js:
1728         (InspectorBackend.Command.prototype._invokeWithArguments):
1729         * UserInterface/Views/DataGrid.js:
1730         (WebInspector.DataGrid.prototype.get resizeMethod):
1731         * UserInterface/Views/NavigationBar.js:
1732         (WebInspector.NavigationBar.prototype.get minimumWidth):
1733
1734 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1735
1736         Web Inspector: Fix obscure ESLint warnings and skip directories
1737         https://bugs.webkit.org/show_bug.cgi?id=136686
1738
1739         Reviewed by Timothy Hatcher.
1740
1741         * .eslintignore: Added.
1742         Skip directories we do not want ESLint to process.
1743
1744         * .eslintrc:
1745         Add rules we've seen and sort sections.
1746
1747         * UserInterface/Controllers/FormatterContentBuilder.js:
1748         (FormatterContentBuilder.prototype._appendIndent):
1749         * UserInterface/Models/Color.js:
1750         * UserInterface/Models/DOMNodeStyles.js:
1751         (WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
1752         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
1753         * UserInterface/Views/DOMTreeDataGridNode.js:
1754         * UserInterface/Views/DOMTreeElement.js:
1755         (WebInspector.DOMTreeElement.prototype.ondelete):
1756         (WebInspector.DOMTreeElement.prototype._insertInLastAttributePosition):
1757         (WebInspector.DOMTreeElement.prototype._distinctClosingTagElement):
1758         * UserInterface/Views/EditingSupport.js:
1759         (WebInspector.EditingConfig):
1760         * UserInterface/Views/LayerTreeDataGridNode.js:
1761         (WebInspector.LayerTreeDataGridNode.prototype._makeOutlet):
1762         * UserInterface/Views/TreeOutline.js:
1763         (TreeOutline.prototype.appendChild):
1764         (TreeOutline.prototype.insertChild):
1765         (TreeOutline.prototype.removeChildAtIndex):
1766         (TreeOutline.prototype.removeChild):
1767         (TreeElement.prototype.expandRecursively):
1768         Fix linter issues.
1769
1770 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1771
1772         Web Inspector: Fix ESLint consistent-return warnings
1773         https://bugs.webkit.org/show_bug.cgi?id=136682
1774
1775         Reviewed by Timothy Hatcher.
1776
1777         * .eslintrc:
1778         * UserInterface/Controllers/BranchManager.js:
1779         (WebInspector.BranchManager.prototype.createBranch):
1780         * UserInterface/Controllers/FrameResourceManager.js:
1781         (WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):
1782         * UserInterface/Models/DOMNodeStyles.js:
1783         (WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
1784         * UserInterface/Views/BoxModelDetailsSectionRow.js:
1785         (WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput):
1786         * UserInterface/Views/DOMTreeElement.js:
1787         (WebInspector.DOMTreeElement.prototype.showChild):
1788         (WebInspector.DOMTreeElement.prototype._startEditingTarget):
1789         (WebInspector.DOMTreeElement.prototype._startEditing):
1790         * UserInterface/Views/EditingSupport.js:
1791         * UserInterface/Views/EventListenerSectionGroup.js:
1792         (WebInspector.EventListenerSectionGroup.prototype._nodeTextOrLink):
1793         * UserInterface/Views/FrameContentView.js:
1794         (WebInspector.FrameContentView.prototype._showContentViewForIdentifier):
1795         * UserInterface/Views/NavigationBar.js:
1796         (WebInspector.NavigationBar.prototype.insertNavigationItem):
1797         (WebInspector.NavigationBar.prototype.removeNavigationItem):
1798         * UserInterface/Views/QuickConsole.js:
1799         (WebInspector.QuickConsole.prototype._insertExecutionContextPathComponentForFrame):
1800         * UserInterface/Views/Sidebar.js:
1801         (WebInspector.Sidebar.prototype.addSidebarPanel):
1802         (WebInspector.Sidebar.prototype.removeSidebarPanel):
1803         * UserInterface/Views/TextEditor.js:
1804         (WebInspector.TextEditor.prototype.addStyleClassToLine):
1805         (WebInspector.TextEditor.prototype.removeStyleClassFromLine):
1806         (WebInspector.TextEditor.prototype.toggleStyleClassForLine):
1807
1808 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1809
1810         Web Inspector: Fix ESLint no-undef warnings
1811         https://bugs.webkit.org/show_bug.cgi?id=136660
1812
1813         Reviewed by Timothy Hatcher.
1814
1815         * UserInterface/Models/DOMSearchMatchObject.js:
1816         (WebInspector.DOMSearchMatchObject.prototype._generateClassName):
1817         (WebInspector.DOMSearchMatchObject.titleForDOMNode):
1818         * UserInterface/Models/Gradient.js:
1819         (WebInspector.Gradient.fromString):
1820         * UserInterface/Views/CodeMirrorAdditions.js:
1821         * UserInterface/Views/ReplayDashboardView.js:
1822         (WebInspector.ReplayDashboardView):
1823
1824 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1825
1826         Web Inspector: Remove unused Console search highlight methods
1827         https://bugs.webkit.org/show_bug.cgi?id=136661
1828
1829         Reviewed by Timothy Hatcher.
1830
1831         ESLint's no-undef warning complained about some undefined references
1832         in these functions that would have thrown exceptions. Turns out this
1833         code is unused, and we do highlighting in the console separately.
1834
1835         * UserInterface/Views/ConsoleCommand.js:
1836         (WebInspector.ConsoleCommand.prototype.clearHighlight): Deleted.
1837         (WebInspector.ConsoleCommand.prototype.highlightSearchResults): Deleted.
1838         (WebInspector.ConsoleCommand.prototype.matchesRegex): Deleted.
1839         * UserInterface/Views/ConsoleMessageImpl.js:
1840         (WebInspector.ConsoleMessageImpl.prototype.clearHighlight): Deleted.
1841         (WebInspector.ConsoleMessageImpl.prototype.highlightSearchResults): Deleted.
1842         (WebInspector.ConsoleMessageImpl.prototype.matchesRegex): Deleted.
1843
1844 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1845
1846         Web Inspector: Fix ESLint* no-avoidable-bind warnings
1847         https://bugs.webkit.org/show_bug.cgi?id=136690
1848
1849         Reviewed by Timothy Hatcher.
1850
1851         * UserInterface/Protocol/RemoteObject.js:
1852         (WebInspector.LocalJSONObject.prototype._children):
1853         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
1854         (WebInspector.CSSStyleDetailsSidebarPanel):
1855         * UserInterface/Views/LayerTreeSidebarPanel.js:
1856         (WebInspector.LayerTreeSidebarPanel.prototype._updateDataGrid):
1857         * UserInterface/Views/LogContentView.js:
1858         (WebInspector.LogContentView.prototype._filterMessages):
1859         * UserInterface/Views/TextResourceContentView.js:
1860         (WebInspector.TextResourceContentView.prototype.get supplementalRepresentedObjects):
1861
1862 2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
1863
1864         Disable the "unreachable-code" warning
1865         https://bugs.webkit.org/show_bug.cgi?id=136677
1866
1867         Reviewed by Darin Adler.
1868
1869         * Configurations/Base.xcconfig:
1870
1871 2014-09-08  Joseph Pecoraro  <pecoraro@apple.com>
1872
1873         Web Inspector: Fix ESLint no-trailing-spaces warnings
1874         https://bugs.webkit.org/show_bug.cgi?id=136657
1875
1876         Reviewed by Andy Estes.
1877
1878         * .eslintrc:
1879         * UserInterface/Base/DOMUtilities.js:
1880         * UserInterface/Base/URLUtilities.js:
1881         (relativePath):
1882         * UserInterface/Base/Utilities.js:
1883         * UserInterface/Controllers/CodeMirrorColorEditingController.js:
1884         (WebInspector.CodeMirrorColorEditingController.prototype._colorPickerColorChanged):
1885         * UserInterface/Controllers/CodeMirrorDragToAdjustNumberController.js:
1886         (WebInspector.CodeMirrorDragToAdjustNumberController.prototype.set enabled):
1887         (WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerCanAdjustObjectAtPoint):
1888         * UserInterface/Controllers/CodeMirrorEditingController.js:
1889         (WebInspector.CodeMirrorEditingController.prototype.handleKeydownEvent):
1890         * UserInterface/Controllers/CodeMirrorGradientEditingController.js:
1891         (WebInspector.CodeMirrorGradientEditingController.prototype.gradientSliderStopWasSelected):
1892         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
1893         (WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
1894         * UserInterface/Controllers/DragToAdjustController.js:
1895         (WebInspector.DragToAdjustController.prototype.set active):
1896         (WebInspector.DragToAdjustController.prototype._setDragging):
1897         (WebInspector.DragToAdjustController.prototype._setTracksMouseClickAndDrag):
1898         * UserInterface/External/Esprima/esprima.js:
1899         * UserInterface/Models/ApplicationCacheFrame.js:
1900         (WebInspector.ApplicationCacheFrame):
1901         * UserInterface/Models/ApplicationCacheManifest.js:
1902         (WebInspector.ApplicationCacheManifest):
1903         (WebInspector.ApplicationCacheManifest.prototype.get manifestURL):
1904         * UserInterface/Models/CookieStorageObject.js:
1905         * UserInterface/Models/DOMSearchMatchObject.js:
1906         (WebInspector.DOMSearchMatchObject.prototype.get title):
1907         (WebInspector.DOMSearchMatchObject.titleForDOMNode):
1908         * UserInterface/Models/DatabaseObject.js:
1909         (WebInspector.DatabaseObject.prototype.getTableNames):
1910         * UserInterface/Models/DatabaseTableObject.js:
1911         (WebInspector.DatabaseTableObject):
1912         * UserInterface/Models/Gradient.js:
1913         (WebInspector.Gradient.fromString):
1914         (WebInspector.RadialGradient.prototype.toString):
1915         * UserInterface/Models/IssueMessage.js:
1916         (WebInspector.IssueMessage.prototype._formatTextIfNecessary):
1917         * UserInterface/Models/Resource.js:
1918         (WebInspector.Resource.prototype.getImageSize.imageDidLoad):
1919         (WebInspector.Resource.prototype.getImageSize):
1920         * UserInterface/Models/Script.js:
1921         (WebInspector.Script.prototype._makeSyntaxTree):
1922         * UserInterface/Models/SourceCodeLocation.js:
1923         (WebInspector.SourceCodeLocation.prototype.hasDifferentDisplayLocation):
1924         * UserInterface/Models/TextMarker.js:
1925         * UserInterface/Protocol/PageObserver.js:
1926         * UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
1927         (WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.set applicationCacheFrame):
1928         (WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.refresh):
1929         (WebInspector.ApplicationCacheDetailsSidebarPanel.prototype._networkStateUpdated):
1930         * UserInterface/Views/ApplicationCacheFrameTreeElement.js:
1931         (WebInspector.ApplicationCacheFrameTreeElement):
1932         * UserInterface/Views/ApplicationCacheManifestTreeElement.js:
1933         (WebInspector.ApplicationCacheManifestTreeElement.prototype.get name):
1934         (WebInspector.ApplicationCacheManifestTreeElement.prototype.get secondaryName):
1935         * UserInterface/Views/ButtonNavigationItem.js:
1936         (WebInspector.ButtonNavigationItem):
1937         * UserInterface/Views/ColorPicker.js:
1938         * UserInterface/Views/ColorWheel.js:
1939         (WebInspector.ColorWheel.prototype._draw):
1940         * UserInterface/Views/CompletionSuggestionsView.js:
1941         (WebInspector.CompletionSuggestionsView.prototype.show):
1942         * UserInterface/Views/ConsoleCommand.js:
1943         * UserInterface/Views/ConsolePrompt.js:
1944         * UserInterface/Views/ContentFlowTreeElement.js:
1945         * UserInterface/Views/CookieStorageTreeElement.js:
1946         (WebInspector.CookieStorageTreeElement):
1947         * UserInterface/Views/EventListenerSectionGroup.js:
1948         (WebInspector.EventListenerSectionGroup.prototype._functionTextOrLink):
1949         * UserInterface/Views/GeneralTreeElementPathComponent.js:
1950         * UserInterface/Views/GoToLineDialog.js:
1951         (WebInspector.GoToLineDialog.prototype._handleKeydownEvent):
1952         * UserInterface/Views/LayerTreeDataGridNode.js:
1953         (WebInspector.LayerTreeDataGridNode.prototype._makeNameCell):
1954         * UserInterface/Views/LayerTreeSidebarPanel.js:
1955         * UserInterface/Views/LogContentView.js:
1956         (WebInspector.LogContentView.prototype._highlightRanges):
1957         * UserInterface/Views/NavigationBar.js:
1958         (WebInspector.NavigationBar):
1959         * UserInterface/Views/NavigationItem.js:
1960         (WebInspector.NavigationItem):
1961         * UserInterface/Views/ResourceDetailsSidebarPanel.js:
1962         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshImageSizeSection):
1963         * UserInterface/Views/ScopeBar.js:
1964         * UserInterface/Views/ScopeBarItem.js:
1965         (WebInspector.ScopeBarItem):
1966         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
1967         (WebInspector.ScopeChainDetailsSidebarPanel):
1968         * UserInterface/Views/ScriptTimelineDataGridNode.js:
1969         (WebInspector.ScriptTimelineDataGridNode.prototype.updateRangeTimes):
1970         * UserInterface/Views/ScriptTreeElement.js:
1971         (WebInspector.ScriptTreeElement):
1972         * UserInterface/Views/SearchBar.js:
1973         * UserInterface/Views/SearchResultTreeElement.js:
1974         (WebInspector.SearchResultTreeElement.truncateAndHighlightTitle):
1975         * UserInterface/Views/Slider.js:
1976
1977 2014-09-09  Joseph Pecoraro  <pecoraro@apple.com>
1978
1979         Web Inspector: Fix ESLint eqeqeq warnings
1980         https://bugs.webkit.org/show_bug.cgi?id=136658
1981
1982         Reviewed by Andy Estes.
1983
1984         * UserInterface/Controllers/DOMTreeManager.js:
1985         (WebInspector.DOMTreeManager.prototype.mycallback):
1986         (WebInspector.DOMTreeManager.prototype.searchResult):
1987         * UserInterface/Models/Breakpoint.js:
1988         (WebInspector.Breakpoint.prototype.clearActions):
1989         * UserInterface/Models/DOMTree.js:
1990         (WebInspector.DOMTree.prototype._requestRootDOMNode.rootObjectAvailable):
1991         (WebInspector.DOMTree.prototype._requestRootDOMNode.rootDOMNodeAvailable):
1992         (WebInspector.DOMTree.prototype._requestRootDOMNode.dispatchCallbacks):
1993         (WebInspector.DOMTree.prototype._requestRootDOMNode):
1994         * UserInterface/Models/ProbeSet.js:
1995         (WebInspector.ProbeSet.prototype.removeProbe):
1996         * UserInterface/Models/ProbeSetDataTable.js:
1997         (WebInspector.ProbeSetDataTable.prototype.addSampleForProbe):
1998         * UserInterface/Views/CodeMirrorAdditions.js:
1999         * UserInterface/Views/CookieStorageContentView.js:
2000         (WebInspector.CookieStorageContentView.prototype._filterCookies):
2001         (WebInspector.cookieMatchesResourceURL):
2002         * UserInterface/Views/DOMStorageContentView.js:
2003         (WebInspector.DOMStorageContentView.prototype._editingCallback):
2004         * UserInterface/Views/DOMTreeElement.js:
2005         (WebInspector.DOMTreeElement):
2006         (WebInspector.DOMTreeElement.prototype._updateChildren):
2007         (WebInspector.DOMTreeElement.prototype._startEditingTarget):
2008         (WebInspector.DOMTreeElement.prototype._textNodeEditingCommitted):
2009         * UserInterface/Views/DataGrid.js:
2010         (WebInspector.DataGrid.prototype._resizerDragging):
2011         * UserInterface/Views/DatabaseContentView.js:
2012         (WebInspector.DatabaseContentView.prototype._queryError):
2013         * UserInterface/Views/DetailsSectionSimpleRow.js:
2014         (.valueElementClicked):
2015         (WebInspector.DetailsSectionSimpleRow):
2016         * UserInterface/Views/Slider.js:
2017         (WebInspector.Slider.prototype.get _maxX):
2018         * UserInterface/Views/TreeOutline.js:
2019         (TreeElement.prototype.expand):
2020
2021 2014-09-09  Jono Wells  <jonowells@apple.com>
2022
2023         Web Inspector: Fix ESLint no-extra-semi
2024         https://bugs.webkit.org/show_bug.cgi?id=136666
2025
2026         Reviewed by Andy Estes.
2027
2028         Add explicit no-extra-semi rule to .eslintrc. Remove all unnecessary
2029         semicolons as identified by ESLint.
2030
2031         * .eslintrc:
2032         * Tools/PrettyPrinting/Formatter.js:
2033         (Formatter):
2034         * UserInterface/Controllers/Formatter.js:
2035         (Formatter):
2036         * UserInterface/Models/Resource.js:
2037         (WebInspector.Resource.prototype.getImageSize.imageDidLoad):
2038         (WebInspector.Resource.prototype.getImageSize):
2039         * UserInterface/Views/LayerTreeSidebarPanel.js:
2040         (WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid.comparator):
2041         (WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid):
2042         * UserInterface/Views/ObjectPropertiesSection.js:
2043         (WebInspector.ObjectPropertyTreeElement.prototype.callback):
2044         (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
2045
2046 2014-09-09  Jono Wells  <jonowells@apple.com>
2047
2048         Web Inspector: Fix ESLint semi (missing semicolon)
2049         https://bugs.webkit.org/show_bug.cgi?id=136665
2050
2051         Reviewed by Andy Estes.
2052
2053         Add missing semicolons as identified by ESLint. Add explicit semi rule to .eslintrc.
2054
2055         * .eslintrc:
2056         * Tools/PrettyPrinting/FormatterContentBuilder.js:
2057         * Tools/PrettyPrinting/FormatterDebug.js:
2058         (Formatter.prototype.debug):
2059         * UserInterface/Base/DOMUtilities.js:
2060         * UserInterface/Base/EventListener.js:
2061         (WebInspector.EventListener):
2062         (WebInspector.EventListener.prototype.this._callback):
2063         (WebInspector.EventListener.prototype.connect):
2064         * UserInterface/Base/Object.js:
2065         (WebInspector.Object):
2066         (WebInspector.Object.addConstructorFunctions):
2067         (WebInspector.Event):
2068         * UserInterface/Base/URLUtilities.js:
2069         (WebInspector.displayNameForURL):
2070         (WebInspector.displayNameForHost):
2071         * UserInterface/Base/Utilities.js:
2072         (.):
2073         * UserInterface/Controllers/BranchManager.js:
2074         (WebInspector.BranchManager):
2075         * UserInterface/Controllers/CSSStyleManager.js:
2076         (WebInspector.CSSStyleManager):
2077         * UserInterface/Controllers/CodeMirrorColorEditingController.js:
2078         (WebInspector.CodeMirrorColorEditingController):
2079         * UserInterface/Controllers/CodeMirrorEditingController.js:
2080         (WebInspector.CodeMirrorEditingController):
2081         * UserInterface/Controllers/CodeMirrorGradientEditingController.js:
2082         (WebInspector.CodeMirrorGradientEditingController):
2083         (WebInspector.CodeMirrorGradientEditingController.prototype.popoverDidPresent):
2084         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
2085         * UserInterface/Controllers/FormatterContentBuilder.js:
2086         * UserInterface/Controllers/FormatterSourceMap.js:
2087         (WebInspector.FormatterSourceMap.fromBuilder):
2088         * UserInterface/Controllers/IssueManager.js:
2089         (WebInspector.IssueManager):
2090         * UserInterface/Controllers/LogManager.js:
2091         (WebInspector.LogManager):
2092         * UserInterface/Models/BreakpointAction.js:
2093         * UserInterface/Models/CSSCompletions.js:
2094         (WebInspector.CSSCompletions):
2095         (WebInspector.CSSCompletions.requestCSSNameCompletions):
2096         * UserInterface/Models/CSSKeywordCompletions.js:
2097         (WebInspector.CSSKeywordCompletions.forProperty):
2098         (WebInspector.CSSKeywordCompletions.isColorAwareProperty):
2099         * UserInterface/Models/CSSStyleSheet.js:
2100         (WebInspector.CSSStyleSheet.resetUniqueDisplayNameNumbers):
2101         * UserInterface/Models/Color.js:
2102         (WebInspector.Color):
2103         (WebInspector.Color.fromString):
2104         * UserInterface/Models/DOMNode.js:
2105         (WebInspector.DOMNode):
2106         * UserInterface/Models/DOMSearchMatchObject.js:
2107         (WebInspector.DOMSearchMatchObject.titleForDOMNode):
2108         * UserInterface/Models/ExecutionContext.js:
2109         (WebInspector.ExecutionContext.supported):
2110         * UserInterface/Models/Gradient.js:
2111         (WebInspector.LinearGradient):
2112         (WebInspector.LinearGradient.linearGradientWithComponents):
2113         (WebInspector.RadialGradient):
2114         (WebInspector.RadialGradient.radialGradientWithComponents):
2115         * UserInterface/Models/IssueMessage.js:
2116         (WebInspector.IssueMessage):
2117         * UserInterface/Models/ReplaySessionSegment.js:
2118         (WebInspector.IncompleteSessionSegment):
2119         * UserInterface/Models/Resource.js:
2120         (WebInspector.Resource.prototype.associateWithScript):
2121         * UserInterface/Models/Script.js:
2122         (WebInspector.Script.resetUniqueDisplayNameNumbers):
2123         * UserInterface/Models/Setting.js:
2124         (WebInspector.Setting):
2125         * UserInterface/Models/SourceCodePosition.js:
2126         (WebInspector.SourceCodePosition):
2127         * UserInterface/Models/SourceMap.js:
2128         (WebInspector.SourceMap):
2129         (WebInspector.SourceMap.StringCharIterator):
2130         * UserInterface/Models/TextMarker.js:
2131         (WebInspector.TextMarker):
2132         * UserInterface/Models/TextRange.js:
2133         (WebInspector.TextRange):
2134         * UserInterface/Protocol/InspectorFrontendHostStub.js:
2135         (.WebInspector.InspectorFrontendHostStub):
2136         * UserInterface/Protocol/MessageDispatcher.js:
2137         (WebInspector.dispatchNextQueuedMessageFromBackend):
2138         (WebInspector.dispatchMessageFromBackend):
2139         * UserInterface/Protocol/RemoteObject.js:
2140         (WebInspector.RemoteObject):
2141         (WebInspector.RemoteObject.fromPrimitiveValue):
2142         (WebInspector.RemoteObject.fromLocalObject):
2143         (WebInspector.RemoteObject.resolveNode):
2144         (WebInspector.RemoteObject.fromPayload):
2145         (WebInspector.RemoteObject.type):
2146         (WebInspector.RemoteObjectProperty):
2147         (WebInspector.RemoteObjectProperty.fromPrimitiveValue):
2148         (WebInspector.LocalJSONObject):
2149         * UserInterface/Protocol/ReplayObserver.js:
2150         (WebInspector.ReplayPosition.fromProtocol):
2151         * UserInterface/Views/BreakpointActionView.js:
2152         (WebInspector.BreakpointActionView.displayStringForType):
2153         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
2154         (WebInspector.CSSStyleDeclarationTextEditor.prototype.if):
2155         * UserInterface/Views/ClusterContentView.js:
2156         (WebInspector.ClusterContentView.prototype.goBack):
2157         (WebInspector.ClusterContentView.prototype.goForward):
2158         * UserInterface/Views/CodeMirrorAdditions.js:
2159         * UserInterface/Views/ColorWheel.js:
2160         (WebInspector.ColorWheel):
2161         * UserInterface/Views/ConsoleMessage.js:
2162         (WebInspector.ConsoleMessage):
2163         (WebInspector.ConsoleMessage.create):
2164         * UserInterface/Views/ConsoleMessageImpl.js:
2165         (WebInspector.ConsoleMessageImpl):
2166         * UserInterface/Views/ContextMenu.js:
2167         (WebInspector.ContextMenuItem):
2168         (WebInspector.ContextSubMenuItem):
2169         (WebInspector.ContextMenu):
2170         (WebInspector.ContextMenu.Provider):
2171         (WebInspector.ContextMenu.registerProvider):
2172         (WebInspector.contextMenuItemSelected):
2173         (WebInspector.contextMenuCleared):
2174         * UserInterface/Views/DOMTreeElement.js:
2175         (WebInspector.DOMTreeElement):
2176         * UserInterface/Views/DOMTreeOutline.js:
2177         (WebInspector.DOMTreeOutline):
2178         * UserInterface/Views/DOMTreeUpdater.js:
2179         (WebInspector.DOMTreeUpdater):
2180         * UserInterface/Views/DatabaseContentView.js:
2181         (WebInspector.DatabaseContentView):
2182         * UserInterface/Views/EditingSupport.js:
2183         (WebInspector.isBeingEdited):
2184         (WebInspector.markBeingEdited):
2185         (WebInspector.isEditingAnyField):
2186         (WebInspector.isEventTargetAnEditableField):
2187         (WebInspector.EditingConfig):
2188         (WebInspector.startEditing):
2189         * UserInterface/Views/EventListenerSection.js:
2190         (WebInspector.EventListenerSection):
2191         * UserInterface/Views/EventListenerSectionGroup.js:
2192         (WebInspector.EventListenerSectionGroup):
2193         * UserInterface/Views/FindBanner.js:
2194         * UserInterface/Views/GeneralTreeElement.js:
2195         (WebInspector.GeneralTreeElement):
2196         * UserInterface/Views/GoToLineDialog.js:
2197         (WebInspector.GoToLineDialog):
2198         * UserInterface/Views/IndeterminateProgressSpinner.js:
2199         (WebInspector.IndeterminateProgressSpinner):
2200         * UserInterface/Views/LayoutTimelineDataGrid.js:
2201         (WebInspector.LayoutTimelineDataGrid):
2202         * UserInterface/Views/LogContentView.js:
2203         (WebInspector.LogContentView):
2204         * UserInterface/Views/NavigationItem.js:
2205         * UserInterface/Views/ObjectPropertiesSection.js:
2206         (WebInspector.ObjectPropertiesSection):
2207         (WebInspector.ObjectPropertiesSection.CompareProperties):
2208         (WebInspector.ObjectPropertyTreeElement):
2209         * UserInterface/Views/ProbeSetDetailsSection.js:
2210         * UserInterface/Views/PropertiesSection.js:
2211         (WebInspector.PropertiesSection):
2212         * UserInterface/Views/ResourceTreeElement.js:
2213         (WebInspector.ResourceTreeElement.compareResourceTreeElements):
2214         (WebInspector.ResourceTreeElement.compareFolderAndResourceTreeElements):
2215         * UserInterface/Views/ScriptTimelineDataGrid.js:
2216         (WebInspector.ScriptTimelineDataGrid):
2217         * UserInterface/Views/SearchResultTreeElement.js:
2218         (WebInspector.SearchResultTreeElement.truncateAndHighlightTitle):
2219         * UserInterface/Views/TimelineRuler.js:
2220         (WebInspector.TimelineRuler):
2221         (WebInspector.TimelineRuler.prototype.get allowsClippedLabels):
2222         (WebInspector.TimelineRuler.prototype._handleMouseUp):
2223         * UserInterface/Views/Toolbar.js:
2224         * UserInterface/Views/TreeOutline.js:
2225         (TreeOutline.prototype.appendChild):
2226         (TreeOutline.prototype.insertChild):
2227         (TreeOutline.prototype.removeChildAtIndex):
2228         (TreeOutline.prototype.removeChild):
2229         (TreeOutline.prototype.removeChildren):
2230         (TreeOutline.prototype.removeChildrenRecursive):
2231         (TreeOutline.prototype._rememberTreeElement):
2232         (TreeOutline.prototype._forgetTreeElement):
2233         (TreeOutline.prototype._forgetChildrenRecursive):
2234         (TreeOutline.prototype.getCachedTreeElement):
2235         (TreeOutline.prototype.findTreeElement):
2236         (TreeOutline.prototype._treeElementDidChange):
2237         (TreeOutline.prototype.treeElementFromPoint):
2238         (TreeOutline.prototype._treeKeyDown):
2239         (TreeOutline.prototype.expand):
2240         (TreeOutline.prototype.collapse):
2241         (TreeOutline.prototype.revealed):
2242         (TreeOutline.prototype.reveal):
2243         (TreeOutline.prototype.select):
2244         (TreeOutline.prototype.revealAndSelect):
2245         (TreeElement.prototype._attach):
2246         (TreeElement.prototype._detach):
2247         (TreeElement.treeElementMouseDown):
2248         (TreeElement.treeElementToggled):
2249         (TreeElement.treeElementDoubleClicked):
2250         (TreeElement.prototype.collapse):
2251         (TreeElement.prototype.collapseRecursively):
2252         (TreeElement.prototype.expand):
2253         (TreeElement.prototype.expandRecursively):
2254         (TreeElement.prototype.hasAncestor):
2255         (TreeElement.prototype.reveal):
2256         (TreeElement.prototype.revealed):
2257         (TreeElement.prototype.selectOnMouseDown):
2258         (TreeElement.prototype.select):
2259         (TreeElement.prototype.revealAndSelect):
2260         (TreeElement.prototype.deselect):
2261         (TreeElement.prototype.onpopulate):
2262         (TreeElement.prototype.traverseNextTreeElement):
2263         (TreeElement.prototype.traversePreviousTreeElement):
2264         (TreeElement.prototype.isEventWithinDisclosureTriangle):
2265         * UserInterface/Views/TreeOutlineDataGridSynchronizer.js:
2266         (WebInspector.TreeOutlineDataGridSynchronizer):
2267
2268 2014-09-08  Joseph Pecoraro  <pecoraro@apple.com>
2269
2270         Web Inspector: Inspector frequently restores wrong view when opened (often Timelines instead of Resource)
2271         https://bugs.webkit.org/show_bug.cgi?id=135965
2272
2273         Reviewed by Timothy Hatcher.
2274
2275         There were numerous subtle race conditions in state restoration.
2276         This patch intends to fix a number of them to get what feels
2277         like sane behavior for selected sidebar state restoration.
2278
2279         1. Starting a Timeline recording no longer automatically switches to the TimelineContentView.
2280         This was making every reload switch to Timelines. If you had
2281         a resource selected (e.g. the DOM Tree) we should go back
2282         to showing the DOM tree.
2283
2284         2. Background sidebars should not reveal and select tree elements.
2285         This was making resources get selected in Timelines when reloading the page
2286         because the background Resources sidebar was restoring selection of the resource.
2287         That is an unexpected selection and breaks the experience of Timelines.
2288
2289         3. ContentView changes during page navigation / reload should not be saved, and improve Resource restoration.
2290         If a TimelineContentView was in the ContentBrowser back/forward history,
2291         a reload with a resource selected in the Resources sidebar would end up
2292         showing the Timelines sidebar. This was because when ContentViews are
2293         closed during the navigation, the ContentBrowser would fall back to the
2294         remaining TimelineContentView and switch to its only allowed sidebar
2295         (Timelines). ResourceSidebarPanel, knowing a resource was selected,
2296         would select the MainFrame intending to stay in the Resource sidebar,
2297         but the resource is okay with showing in any sidebar, so we stay on Timelines.
2298
2299         4. Resource sidebar state restoration should propertly restore selection.
2300         On reload, state restoration would know the resource to re-select in the
2301         Resources sidebar. As ResourceTreeElements are added to the sidebar
2302         they are checked against the state restoration cookie. If they match,
2303         they would select the element and delete the cookie. Unfortunately,
2304         if this was the first TreeElement child being added to a FrameTreeElement,
2305         the FrameTreeElement onpopulate would remove all children and re-add
2306         them in a unique way. Unfortunately this means the TreeElement we
2307         selected based on the cookie, immediately got thrown away and recreated,
2308         and we no longer reveal and select it. This is a special case for
2309         FrameTreeElements which use the onpopulate SPI. So, instead of starting
2310         processing the new element queue, if this is the first time just trigger
2311         the onpopulate and elements are made just once.
2312
2313         5. Show Error Console triggering early, could have unexpected sidebar behavior.
2314         Opening Web Inspector directly to the console can run before
2315         WebInspector.contentLoaded (DOMContentLoaded). So in that case
2316         WebInspector.showFullHeightConsole was not handling if the contentBrowser
2317         had no content view yet, and the sidebar might be-reopened later on
2318         in contentLoaded based on the setting value.
2319
2320         6. Improve automatic resource selection for sidebars with multiple tree outlines.
2321         Selecting a call frame tree element was unexpectedly changing the
2322         selection to a Resource where the breakpoint was set. This was
2323         because we were only looking at one of potentially many content
2324         tree outlines in the sidebar to see if there was a user action.
2325         
2326         * UserInterface/Base/Main.js:
2327         (WebInspector.contentLoaded):
2328         (WebInspector.showFullHeightConsole):
2329         (WebInspector.toggleConsoleView):
2330         (WebInspector._mainResourceDidChange):
2331         (WebInspector._provisionalLoadStarted):
2332         (WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar):
2333         (WebInspector._updateCookieForInspectorViewState):
2334         (WebInspector._contentBrowserCurrentContentViewDidChange):
2335         * UserInterface/Views/NavigationSidebarPanel.js:
2336         (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
2337         * UserInterface/Views/ResourceSidebarPanel.js:
2338         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange.delayedWork):
2339         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange):
2340         * UserInterface/Views/TimelineSidebarPanel.js:
2341         (WebInspector.TimelineSidebarPanel.prototype._recordingLoaded):
2342
2343 2014-09-08  Matt Baker  <mattbaker@apple.com>
2344
2345         Web Inspector: Add layout test for lowercase CSSProperty names
2346         https://bugs.webkit.org/show_bug.cgi?id=135961
2347
2348         Reviewed by Joseph Pecoraro.
2349
2350         Modified test components to support testing CSSStyleManager and related classes:
2351         - Added required models to Test.html
2352         - Added CSSCompletions initialization to Test.js
2353         - CSSCompletions doesn't assume presence of CodeMirror.
2354
2355         * UserInterface/Base/Test.js:
2356         (WebInspector.loaded):
2357         * UserInterface/Models/CSSCompletions.js:
2358         * UserInterface/Test.html:
2359
2360 2014-09-08  Matt Baker  <mattbaker@apple.com>
2361
2362         Web Inspector: Fixes to layout test infrastructure
2363         https://bugs.webkit.org/show_bug.cgi?id=136360
2364
2365         Reviewed by Joseph Pecoraro.
2366
2367         Added missing includes to Test.html, which was breaking tests that
2368         depended on SourceCodeLocation and LazySourceCodeLocation. Also fixed
2369         bug which prevented test results from being resent after reloading the
2370         page under test.
2371
2372         * UserInterface/Base/Test.js:
2373         (InspectorTest.reloadPage):
2374         * UserInterface/Test.html:
2375
2376 2014-09-07  Timothy Hatcher  <timothy@apple.com>
2377
2378         Use a <circle> instead of a <path> in DownloadArrow.svg.
2379         https://bugs.webkit.org/show_bug.cgi?id=136608
2380
2381         Reviewed by Antoine Quint.
2382
2383         * UserInterface/Images/DownloadArrow.svg:
2384         * UserInterface/Views/TreeElementStatusButton.css:
2385         (.item > .status > .status-button > svg .filled):
2386         (body.mac-platform.legacy .item > .status > .status-button > svg .filled):
2387         (:focus .item.selected > .status > .status-button > svg .filled):
2388         (.item > .status > .status-button > svg .stroked):
2389         (body.mac-platform.legacy .item > .status > .status-button > svg .stroked):
2390         (:focus .item.selected > .status > .status-button > svg .stroked):
2391         Tweak CSS selectors to apply to other shapes, not just path.
2392
2393 2014-09-06  Darin Adler  <darin@apple.com>
2394
2395         Make updates suggested by new version of Xcode
2396         https://bugs.webkit.org/show_bug.cgi?id=136603
2397
2398         Reviewed by Mark Rowe.
2399
2400         * Configurations/Base.xcconfig: Added CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
2401         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
2402         CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN__DUPLICATE_METHOD_MATCH, ENABLE_STRICT_OBJC_MSGSEND,
2403         GCC_WARN_UNDECLARED_SELECTOR, and GCC_WARN_UNUSED_FUNCTION as suggested by Xcode update check.
2404         Also removed duplicate GCC_WARN_UNUSED_VARIABLE line.
2405
2406         * WebInspectorUI.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
2407
2408 2014-09-02  Brian J. Burg  <burg@cs.washington.edu>
2409
2410         LegacyProfiler: remove redundant ProfileNode members and other cleanup
2411         https://bugs.webkit.org/show_bug.cgi?id=136380
2412
2413         Reviewed by Timothy Hatcher.
2414
2415         Remove unused Profile.idleTime member.
2416
2417         * UserInterface/Models/Profile.js:
2418         (WebInspector.Profile.prototype.get idleTime): Deleted.
2419         * UserInterface/Models/ScriptTimelineRecord.js:
2420         (WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload):
2421
2422 2014-09-02  Brian J. Burg  <burg@cs.washington.edu>
2423
2424         Web Inspector: remove ProfilerAgent and legacy profiler files in the frontend
2425         https://bugs.webkit.org/show_bug.cgi?id=136462
2426
2427         Reviewed by Timothy Hatcher.
2428
2429         The legacy profiler manager didn't do anything, and its views and models
2430         have been superseded by new views and models based on the Timeline classes.
2431
2432         * .eslintrc:
2433         * UserInterface/Base/Main.js:
2434         (WebInspector.loaded):
2435         (WebInspector.openURL): Remove profile URL handling code.
2436         * UserInterface/Controllers/LegacyProfileManager.js: Removed.
2437         * UserInterface/Main.html:
2438         * UserInterface/Protocol/ConsoleObserver.js:
2439         (WebInspector.ConsoleObserver.prototype.messageAdded):
2440         * UserInterface/Protocol/InspectorFrontendAPI.js:
2441         (InspectorFrontendAPI.isProfilingJavaScript): Deleted.
2442         (InspectorFrontendAPI.startProfilingJavaScript): Deleted.
2443         (InspectorFrontendAPI.stopProfilingJavaScript): Deleted.
2444         * UserInterface/Protocol/LegacyProfilerObserver.js: Removed.
2445         * UserInterface/Views/LegacyBottomUpProfileDataGridTree.js: Removed.
2446         * UserInterface/Views/LegacyJavaScriptProfileObject.js: Removed.
2447         * UserInterface/Views/LegacyJavaScriptProfileType.js: Removed.
2448         * UserInterface/Views/LegacyJavaScriptProfileView.css: Removed.
2449         * UserInterface/Views/LegacyJavaScriptProfileView.js: Removed.
2450         * UserInterface/Views/LegacyProfileDataGridTree.js: Removed.
2451         * UserInterface/Views/LegacyProfileObject.js: Removed.
2452         * UserInterface/Views/LegacyProfileType.js: Removed.
2453         * UserInterface/Views/LegacyProfileView.css: Removed.
2454         * UserInterface/Views/LegacyProfileView.js: Removed.
2455         * UserInterface/Views/LegacyTopDownProfileDataGridTree.js: Removed.
2456
2457 2014-08-29  Saam Barati  <saambarati1@gmail.com>
2458
2459         Web Inspector: Create a UI for displaying JavaScript type information
2460         https://bugs.webkit.org/show_bug.cgi?id=135142
2461
2462         Reviewed by Joseph Pecoraro.
2463
2464         JavaScriptCore now has a type profiler. This patch provides a frontend
2465         user interface for displaying this type information in the Web Inspector.
2466         The user interface works by placing inline "type tokens" next to important
2467         JavaScript expressions: function arguments, function return types, and 
2468         variable declarations. Type information can also be seen for almost every
2469         JavaScipt expression just by hovering over it while viewing a JavaScript file.
2470
2471         Currently, turning on the type profiler is expensive, so the inspector
2472         ensures to never turn on type profiling until the user specifically asks 
2473         for type information to be turned on.
2474
2475         * UserInterface/Base/Main.js:
2476         (WebInspector.loaded):
2477         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
2478         (WebInspector.CodeMirrorTokenTrackingController.prototype._startTracking):
2479         (WebInspector.CodeMirrorTokenTrackingController.prototype._processNewHoveredToken):
2480         Added a new type profiling mode.
2481
2482         * UserInterface/Controllers/FormatterSourceMap.js:
2483         (WebInspector.FormatterSourceMap.prototype.originalToFormatted):
2484         (WebInspector.FormatterSourceMap.prototype.originalPositionToFormatted):
2485         (WebInspector.FormatterSourceMap.prototype.formattedToOriginal):
2486         (WebInspector.FormatterSourceMap.prototype.formattedToOriginalOffset):
2487         * UserInterface/Controllers/TypeTokenAnnotator.js: Added.
2488         (WebInspector.TypeTokenAnnotator):
2489         (WebInspector.TypeTokenAnnotator.prototype.get isActive):
2490         (WebInspector.TypeTokenAnnotator.prototype.get sourceCodeTextEditor):
2491         (WebInspector.TypeTokenAnnotator.prototype.pause):
2492         (WebInspector.TypeTokenAnnotator.prototype.resume):
2493         (WebInspector.TypeTokenAnnotator.prototype.refresh):
2494         (WebInspector.TypeTokenAnnotator.prototype.reset):
2495         (WebInspector.TypeTokenAnnotator.prototype.toggleTypeAnnotations):
2496         (WebInspector.TypeTokenAnnotator.prototype._insertAnnotations.):
2497         (WebInspector.TypeTokenAnnotator.prototype._insertTypeTokensForEachNode):
2498         (WebInspector.TypeTokenAnnotator.prototype._insertToken):
2499         (WebInspector.TypeTokenAnnotator.prototype.isLineTerminator):
2500         (WebInspector.TypeTokenAnnotator.prototype._translateToOffsetAfterFunctionParameterList):
2501         (WebInspector.TypeTokenAnnotator.prototype._clearTimeoutIfNeeded):
2502         This class is responsible for producing the inline "type token" annotations.
2503
2504         * UserInterface/Images/NavigationItemTypes.svg: Added.
2505         * UserInterface/Main.html:
2506         * UserInterface/Models/Script.js:
2507         (WebInspector.Script.prototype.get scriptSyntaxTree):
2508         * UserInterface/Models/ScriptSyntaxTree.js:
2509         (WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement):
2510         (WebInspector.ScriptSyntaxTree.prototype.):
2511         (WebInspector.ScriptSyntaxTree.prototype.updateTypes):
2512         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2513         * UserInterface/Views/ScriptContentView.js:
2514         (WebInspector.ScriptContentView):
2515         (WebInspector.ScriptContentView.prototype.get navigationItems):
2516         (WebInspector.ScriptContentView.prototype._contentDidPopulate):
2517         (WebInspector.ScriptContentView.prototype._toggleTypeAnnotations):
2518         (WebInspector.ScriptContentView.prototype._showJavaScriptTypeInformationSettingChanged):
2519         * UserInterface/Views/SourceCodeTextEditor.js:
2520         (WebInspector.SourceCodeTextEditor):
2521         (WebInspector.SourceCodeTextEditor.prototype.shown):
2522         (WebInspector.SourceCodeTextEditor.prototype.hidden):
2523         (WebInspector.SourceCodeTextEditor.prototype.canShowTypeAnnotations):
2524         (WebInspector.SourceCodeTextEditor.prototype.toggleTypeAnnotations):
2525         (WebInspector.SourceCodeTextEditor.prototype.showPopoverForTypes):
2526         (WebInspector.SourceCodeTextEditor.prototype.prettyPrint):
2527         (WebInspector.SourceCodeTextEditor.prototype._populateWithContent):
2528         (WebInspector.SourceCodeTextEditor.prototype._debuggerDidPause):
2529         (WebInspector.SourceCodeTextEditor.prototype._debuggerDidResume):
2530         (WebInspector.SourceCodeTextEditor.prototype._updateTokenTrackingControllerState):
2531         (WebInspector.SourceCodeTextEditor.prototype.tokenTrackingControllerNewHighlightCandidate):
2532         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation.handler):
2533         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation):
2534         (WebInspector.SourceCodeTextEditor.prototype._showPopover):
2535         (WebInspector.SourceCodeTextEditor.prototype.editingControllerDidFinishEditing):
2536         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenAnnotator):
2537         (WebInspector.SourceCodeTextEditor.prototype._enableScrollEventsForTypeTokenAnnotator):
2538         (WebInspector.SourceCodeTextEditor.prototype._disableScrollEventsForTypeTokenAnnotator):
2539         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenScrollEventHandler.scrollHandler):
2540         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenScrollEventHandler):
2541         * UserInterface/Views/TextContentView.js:
2542         (WebInspector.TextContentView.prototype.get navigationItems):
2543         * UserInterface/Views/TextEditor.js:
2544         (WebInspector.TextEditor.prototype.set formatted):
2545         (WebInspector.TextEditor.prototype.canShowTypeAnnotations):
2546         (WebInspector.TextEditor.prototype.visibleRangeOffsets):
2547         (WebInspector.TextEditor.prototype.originalOffsetToCurrentPosition):
2548         (WebInspector.TextEditor.prototype.currentOffsetToCurrentPosition):
2549         (WebInspector.TextEditor.prototype.currentPositionToOriginalOffset):
2550         (WebInspector.TextEditor.prototype.currentPositionToCurrentOffset):
2551         (WebInspector.TextEditor.prototype.setInlineWidget):
2552         (WebInspector.TextEditor.prototype.addScrollHandler):
2553         (WebInspector.TextEditor.prototype.removeScrollHandler):
2554         (WebInspector.TextEditor.prototype._scrollIntoViewCentered):
2555         * UserInterface/Views/TextResourceContentView.js:
2556         (WebInspector.TextResourceContentView):
2557         (WebInspector.TextResourceContentView.prototype.get navigationItems):
2558         (WebInspector.TextResourceContentView.prototype._contentDidPopulate):
2559         (WebInspector.TextResourceContentView.prototype._toggleTypeAnnotations):
2560         (WebInspector.TextResourceContentView.prototype._showJavaScriptTypeInformationSettingChanged):
2561         * UserInterface/Views/TypePropertiesSection.js: Added.
2562         (WebInspector.TypePropertiesSection):
2563         (WebInspector.TypePropertiesSection.prototype.onpopulate):
2564         (WebInspector.TypePropertiesSection.PropertyComparator):
2565         (WebInspector.TypePropertyTreeElement):
2566         (WebInspector.TypePropertyTreeElement.prototype.onpopulate):
2567         * UserInterface/Views/TypeTokenView.css: Added.
2568         (.type-token):
2569         (.type-token-left-spacing):
2570         (.type-token-right-spacing):
2571         (.type-token-function, .type-token-boolean):
2572         (.type-token-number):
2573         (.type-token-string):
2574         (.type-token-default):
2575         (.type-token-empty):
2576         (.type-token-many):
2577         * UserInterface/Views/TypeTokenView.js: Added.
2578         (WebInspector.TypeTokenView):
2579         (WebInspector.TypeTokenView.titleForPopover):
2580         (WebInspector.TypeTokenView.prototype.update):
2581         (WebInspector.TypeTokenView.prototype._setUpMouseoverHandlers):
2582         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
2583         The inline "type token" view.
2584
2585 2014-08-29  Saam Barati  <sbarati@apple.com>
2586
2587         Web Inspector: Fix how Popover animates
2588         https://bugs.webkit.org/show_bug.cgi?id=136353
2589
2590         Reviewed by Timothy Hatcher.
2591
2592         Popovers currently don't animate properly because they use 
2593         window.requestAnimationFrame which won't fire its callback 
2594         while the inspector is paused in the debugger. This patches
2595         switches the callback mechanism to setTimeout and also changes
2596         how a Popover's anchor animates to prevent visual glitches.
2597
2598         Popover also has a new function that allows a new target
2599         frame and new content to be set simultaneously and to
2600         animate to show the new content while changing the 
2601         location of the popover frame.
2602
2603         SourceCodeTextEditor uses Popover's new API for animating
2604         between popovers when paused in the debugger. SourceCodeTextEditor 
2605         also now ensures proper balancing of popover tracking event 
2606         listeners.
2607
2608         * UserInterface/Views/Popover.js:
2609         (WebInspector.Popover.prototype.present):
2610         (WebInspector.Popover.prototype.presentNewContentWithFrame):
2611         (WebInspector.Popover.prototype.dismiss):
2612         (WebInspector.Popover.prototype._update):
2613         (WebInspector.Popover.prototype.drawBackground):
2614         (WebInspector.Popover.prototype._animateFrame):
2615         (WebInspector.Popover.prototype._drawFrame):
2616         (WebInspector.Popover.prototype._addListenersIfNeeded):
2617         (WebInspector.Popover.prototype._animateFrame.drawBackground): Deleted.
2618         * UserInterface/Views/SourceCodeTextEditor.js:
2619         (WebInspector.SourceCodeTextEditor.prototype._showPopover):
2620         (WebInspector.SourceCodeTextEditor.prototype._dismissPopover):
2621         (WebInspector.SourceCodeTextEditor.prototype._trackPopoverEvents):
2622
2623 2014-08-28  Saam Barati  <sbarati@apple.com>
2624
2625         Web Inspector: Write tests for ScriptSyntaxTree and fix bugs in the data structure
2626         https://bugs.webkit.org/show_bug.cgi?id=136272
2627
2628         Reviewed by Joseph Pecoraro.
2629
2630         Include the necessary files in Test.html to test ScriptSyntaxTree.
2631         Also, ScriptSyntaxTree had a couple of errors for two of its nodes
2632         where they simply ignored one of the properties on the node.
2633         These errors were found while writing the tests and are fixed
2634         in this patch.
2635
2636         * UserInterface/Models/ScriptSyntaxTree.js:
2637         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2638         * UserInterface/Test.html:
2639
2640 2014-08-27  Saam Barati  <sbarati@apple.com>
2641
2642         Web Inspector: Layout issues for popover on not legacy OS
2643         https://bugs.webkit.org/show_bug.cgi?id=136268
2644
2645         Reviewed by Joseph Pecoraro.
2646
2647         On the latest OS, popovers invade the title bar's space which will
2648         cause layout issues because the title bar will render above
2649         the popover. Fix this by providing some padding for popovers on 
2650         not legacy OSs.
2651
2652         * UserInterface/Views/Popover.js:
2653
2654 2014-08-27  Timothy Hatcher  <timothy@apple.com>
2655
2656         REGRESSION: Web Inspector: Legacy toolbar has two different colors in unfocused windowed mode
2657         https://bugs.webkit.org/show_bug.cgi?id=136289
2658
2659         Reviewed by Darin Adler.
2660
2661         * UserInterface/Views/Toolbar.css:
2662         (body.mac-platform.legacy .toolbar): Override the background-color as transparent. Non-legacy
2663         uses a solid color instead of a gradient for window-inactive.
2664
2665 2014-08-26  Saam Barati  <sbarati@apple.com>
2666
2667         Web Inspector: Fix CodeMirrorTokenTrackingController::_startTracking assertion
2668         https://bugs.webkit.org/show_bug.cgi?id=136160
2669
2670         Reviewed by Joseph Pecoraro.
2671
2672         Check if '_tracking' is already true before calling '_startTracking'
2673         to prevent the assertion from always firing.
2674
2675         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
2676         (WebInspector.CodeMirrorTokenTrackingController.prototype._mouseEntered):
2677
2678 2014-08-25  Brent Fulgham  <bfulgham@apple.com>
2679
2680         [Win] Pass OFFICIAL_BUILD flag to WebInspectorUI build process
2681         https://bugs.webkit.org/show_bug.cgi?id=136229
2682
2683         Reviewed by Dean Jackson.
2684
2685         * WebInspectorUI.vcxproj/WebInspectorUI.make: Pass OFFICIAL_BUILD
2686         flag to build-webinspectorui.pl.
2687         * WebInspectorUI.vcxproj/build-webinspectorui.pl: Accept and use
2688         the OFFICIAL_BUILD flag.
2689
2690 2014-08-24  Benjamin Poulain  <benjamin@webkit.org>
2691
2692         The inspector should not use the "after" pseudo element with the compatibility syntax
2693         https://bugs.webkit.org/show_bug.cgi?id=136204
2694
2695         Reviewed by Darin Adler.
2696
2697         We should only use hte proper pseudo element syntax inside WebKit.
2698
2699         * Tools/PrettyPrinting/codemirror-additions.css:
2700         * Tools/PrettyPrinting/populate/apple.css:
2701
2702 2014-08-24  Brian J. Burg  <burg@cs.washington.edu>
2703
2704         Web Inspector: Rename DOM.RGBA and remove workarounds in the bindings generator
2705         https://bugs.webkit.org/show_bug.cgi?id=136025
2706
2707         Reviewed by Joseph Pecoraro.
2708
2709         Also rename DOM.RGBA in legacy protocol specifications.
2710
2711         * Versions/Inspector-iOS-6.0.json:
2712         * Versions/Inspector-iOS-7.0.json:
2713
2714 2014-08-21  Simon Fraser  <simon.fraser@apple.com>
2715
2716         Add a button to enable paint flashing in the web inspector
2717         https://bugs.webkit.org/show_bug.cgi?id=136133
2718
2719         Reviewed by Tim Hatcher.
2720         
2721         Add a button to the right of the layer borders button to turn on paint flashing.
2722         Future patches will actually enable this feature.
2723
2724         * Localizations/en.lproj/localizedStrings.js: Tooltip strings.
2725         * UserInterface/Images/PaintFlashing.svg: Added. "Paintbrush" icon.
2726         * UserInterface/Views/DOMTreeContentView.js:
2727         (WebInspector.DOMTreeContentView):
2728         (WebInspector.DOMTreeContentView.prototype.get navigationItems):
2729         (WebInspector.DOMTreeContentView.prototype._togglePaintFlashing):
2730
2731 2014-08-20  Saam Barati  <sbarati@apple.com>
2732
2733         Rename HighFidelityTypeProfiling variables for more clarity
2734         https://bugs.webkit.org/show_bug.cgi?id=135899
2735
2736         Reviewed by Geoffrey Garen.
2737
2738         Change a reference in a comment to a JavaScriptCore file to its 
2739         newly renamed variant.
2740
2741         * UserInterface/Models/ScriptSyntaxTree.js:
2742
2743 2014-08-18  Saam Barati  <sbarati@apple.com>
2744
2745         Web Inspector: Introduce an inspector Abstract Syntax Tree.
2746         https://bugs.webkit.org/show_bug.cgi?id=135763
2747
2748         Reviewed by Joseph Pecoraro.
2749
2750         This patch adds an Abstract Syntax Tree to the Web inspector. 
2751         This syntax tree is modeled off the Esprima.js syntax tree
2752         which complies with the Mozilla Parser API:
2753         https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Parser_API
2754         Script is the owner of the Web Inspector syntax tree, and has an API
2755         for accessing its syntax tree property.
2756
2757         * UserInterface/External/Esprima/esprima.js:
2758         * UserInterface/Main.html:
2759         * UserInterface/Models/Script.js:
2760         (WebInspector.Script):
2761         (WebInspector.Script.prototype.requestScriptSyntaxTree.makeSyntaxTreeAndCallCallback):
2762         (WebInspector.Script.prototype._resolveResource):
2763         (WebInspector.Script.prototype._makeSyntaxTree):
2764         * UserInterface/Models/ScriptSyntaxTree.js: Added.
2765         (WebInspector.ScriptSyntaxTree):
2766         (WebInspector.ScriptSyntaxTree.prototype.get parsedSuccessfully):
2767         (WebInspector.ScriptSyntaxTree.prototype.forEachNode):
2768         (WebInspector.ScriptSyntaxTree.prototype.):
2769         (WebInspector.ScriptSyntaxTree.prototype.filter):
2770         (WebInspector.ScriptSyntaxTree.prototype.filterForNodesInRange):
2771         (WebInspector.ScriptSyntaxTree.prototype.filterByRange):
2772         (WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement.removeFunctionsFilter):
2773         (WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement):
2774         (WebInspector.ScriptSyntaxTree.prototype.updateTypes):
2775         (WebInspector.ScriptSyntaxTree.prototype._defaultParserState):
2776         (WebInspector.ScriptSyntaxTree.prototype._recurse):
2777         (WebInspector.ScriptSyntaxTree.prototype._recurseArray):
2778         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2779
2780 2014-08-16  Joseph Pecoraro  <pecoraro@apple.com>
2781
2782         Web Inspector: Improve performance of selection range changes viewing Scripts timeline
2783         https://bugs.webkit.org/show_bug.cgi?id=136015
2784
2785         Reviewed by Timothy Hatcher.
2786
2787         * UserInterface/Base/Utilities.js:
2788         (clamp):
2789         Helper function to clamp a value between a min and max.
2790
2791         * UserInterface/Models/ProfileNode.js:
2792         (WebInspector.ProfileNode.prototype.get startTime):
2793         (WebInspector.ProfileNode.prototype.get endTime):
2794         These can be quickly calculated, so avoid full calculation to grab the values.
2795
2796         * UserInterface/Views/ScriptTimelineView.js:
2797         (WebInspector.ScriptTimelineView.prototype.updateLayout):
2798         Update ranges with a smart helper, instead of blindly doing it and needing refresh.
2799
2800         * UserInterface/Views/ProfileNodeDataGridNode.js:
2801         (WebInspector.ProfileNodeDataGridNode.prototype.get rangeEndTime):
2802         (WebInspector.ProfileNodeDataGridNode.prototype.get data):
2803         (WebInspector.ProfileNodeDataGridNode.prototype.updateRangeTimes):
2804         (WebInspector.ProfileNodeDataGridNode.prototype.set rangeStartTime): Deleted.
2805         (WebInspector.ProfileNodeDataGridNode.prototype.set rangeEndTime): Deleted.
2806         * UserInterface/Views/ScriptTimelineDataGridNode.js:
2807         (WebInspector.ScriptTimelineDataGridNode.prototype.updateRangeTimes):
2808         (WebInspector.ScriptTimelineDataGridNode.prototype.set rangeStartTime): Deleted.
2809         (WebInspector.ScriptTimelineDataGridNode.prototype.set rangeEndTime): Deleted.
2810         When updating the range selection, compare to the last range selection
2811         on this DataGridNode. If the visible portion of this node's time range
2812         changes, we need a refresh. Otherwise, we don't need a refresh.
2813
2814 2014-08-15  Joseph Pecoraro  <pecoraro@apple.com>
2815
2816         Web Inspector: Update Scripts/update-LegacyInspectorBackendCommands.rb for the new generator
2817         https://bugs.webkit.org/show_bug.cgi?id=136006
2818
2819         Reviewed by Timothy Hatcher.
2820
2821         * Scripts/update-LegacyInspectorBackendCommands.rb:
2822         Use the new generator and pass the appropriate flags.
2823
2824         * UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js:
2825         * UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
2826         Newly generated files using the new generator.
2827
2828         * Versions/Inspector-iOS-6.0.json:
2829         Remove unsupported features.
2830
2831 2014-08-15  Joseph Pecoraro  <pecoraro@apple.com>
2832
2833         Web Inspector: Remove forced layouts during recording caused by striped background element resizing
2834         https://bugs.webkit.org/show_bug.cgi?id=136009
2835
2836         Reviewed by Timothy Hatcher.
2837
2838         We used to manually resize and a custom striped background behind
2839         the timeline tree outline content area. This can happen frequently
2840         during timeline recordings causing forced layouts. We can eliminate
2841         the hack and instead put the stripe background on the tree outline.
2842
2843         * UserInterface/Views/TimelineSidebarPanel.js:
2844         (WebInspector.TimelineSidebarPanel.prototype.updateCustomContentOverflow): Deleted.
2845         * UserInterface/Views/TimelineSidebarPanel.css:
2846         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .content .item > .status > .status-button):
2847         (.sidebar > .panel.navigation.timeline > .content > .stripe-background): Deleted.
2848         (.sidebar > .panel.navigation.timeline.timeline-content-view-showing > .content > .stripe-background): Deleted.
2849         Eliminate the striped background element.
2850
2851         * UserInterface/Views/TimelineView.css:
2852         (.panel.navigation.timeline > .content > .navigation-sidebar-panel-content-tree-outline):
2853         (.panel.navigation.timeline.timeline-content-view-showing > .content > .navigation-sidebar-panel-content-tree-outline):
2854         Give the timeline content tree outlines the striped background.
2855
2856         * UserInterface/Views/NavigationSidebarPanel.js:
2857         (WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
2858         (WebInspector.NavigationSidebarPanel.prototype.updateCustomContentOverflow): Deleted.
2859         Remove the now unused updateCustomContentOverflow method.
2860
2861 2014-08-15  Jono Wells  <jonowells@apple.com>
2862
2863         Web Inspector: Inspect Element doesn't always highlight the correct element when inspector is closed before inspecting
2864         https://bugs.webkit.org/show_bug.cgi?id=135995
2865
2866         Reviewed by Joseph Pecoraro.
2867
2868         Change so if an element is inspected via the Inspect Element context menu, selected
2869         node restoration is disallowed until the main resource in the main frame changes.
2870         This way an attempt by a sub-frame will not change the highlighted element in the
2871         Main Frame's DOM tree unexpectedly.
2872
2873         * UserInterface/Controllers/DOMTreeManager.js:
2874         (WebInspector.DOMTreeManager):
2875         (WebInspector.DOMTreeManager.prototype._mainResourceDidChange):
2876         (WebInspector.DOMTreeManager.prototype.inspectElement):
2877
2878 2014-08-15  Brian J. Burg  <burg@cs.washington.edu>
2879
2880         Web Inspector: rewrite CodeGeneratorInspector to be modular and testable
2881         https://bugs.webkit.org/show_bug.cgi?id=131596
2882
2883         Reviewed by Joseph Pecoraro.
2884
2885         Also apply type extraction refactorings to old protocol versions for consistency.
2886
2887         * Versions/Inspector-iOS-6.0.json:
2888         * Versions/Inspector-iOS-7.0.json:
2889
2890 2014-08-15  Timothy Hatcher  <timothy@apple.com>
2891
2892         Web Inspector: Probe details sidebar data grids do not show data
2893         https://bugs.webkit.org/show_bug.cgi?id=135992
2894
2895         Reviewed by Joseph Pecoraro.
2896
2897         * UserInterface/Views/ProbeSetDataGrid.js:
2898         (WebInspector.ProbeSetDataGrid): Make the DataGrid be inline to show the data correctly.
2899
2900 2014-08-15  Timothy Hatcher  <timothy@apple.com>
2901
2902         Web Inspector: Legacy Mac toolbar appearance looks wrong
2903         https://bugs.webkit.org/show_bug.cgi?id=135962
2904
2905         Reviewed by Joseph Pecoraro.
2906
2907         * UserInterface/Views/Toolbar.css:
2908         (body.mac-platform.legacy .toolbar): Don't draw a gradient background when not docked.
2909         Move border-bottom-color from body.mac-platform.legacy.docked .toolbar to here so it
2910         applies all the time as it should have.
2911
2912 2014-08-14  Joseph Pecoraro  <pecoraro@apple.com>
2913
2914         Web Inspector: Dragging Undocked inspector by window title has broken behavior
2915         https://bugs.webkit.org/show_bug.cgi?id=135950
2916
2917         Reviewed by Timothy Hatcher.
2918
2919         * UserInterface/Base/Main.js:
2920         On Mac ports where we the inspector content goes everywhere, window dragging behavior
2921         still exists for the top 22px of the window. So don't do our JavaScript based window
2922         dragging for this special region.
2923
2924         * UserInterface/Models/KeyboardShortcut.js:
2925         (WebInspector.KeyboardShortcut.Modifier.get CommandOrControl):
2926         (WebInspector.KeyboardShortcut.prototype.get displayName):
2927         Instead of calling a host function, use the value already in the frontend.
2928
2929 2014-08-14  Joseph Pecoraro  <pecoraro@apple.com>
2930
2931         Web Inspector: Split console toggle button wrong - Images/Images/SplitToggleUp.svg does not exist
2932         https://bugs.webkit.org/show_bug.cgi?id=135957
2933
2934         Reviewed by Timothy Hatcher.
2935
2936         * UserInterface/Views/LogContentView.js:
2937         (WebInspector.LogContentView):
2938         Wrong image path passed to platformImagePath.
2939
2940 2014-08-14  Joseph Pecoraro  <pecoraro@apple.com>
2941
2942         Web Inspector: Avoid re-binding the same function over and over
2943         https://bugs.webkit.org/show_bug.cgi?id=135949
2944
2945         Reviewed by Timothy Hatcher.
2946
2947         * UserInterface/Controllers/TimelineManager.js:
2948         (WebInspector.TimelineManager.prototype._startAutoCapturing):
2949         (WebInspector.TimelineManager.prototype._stopAutoRecordingSoon):
2950         (WebInspector.TimelineManager.prototype._resetAutoRecordingDeadTimeTimeout):
2951         Stash a bound copy of the function once, and reuse it.
2952
2953 2014-08-14  Joseph Pecoraro  <pecoraro@apple.com>
2954
2955         Web Inspector: Timelines can get caught in requestAnimationFrame loop when not recording
2956         https://bugs.webkit.org/show_bug.cgi?id=135946
2957
2958         Reviewed by Timothy Hatcher.
2959
2960         Each TimelineContentView was listening for the TimelineManager's start/stop
2961         capturing events. However, only the active recording could possibly update.
2962         Likewise, if a pre-existing recording started and stopped we did not properly
2963         stop in the case where we were waiting for an event to update the current time,
2964         which would result in an infinite rAF loop of no updates.
2965
2966         * UserInterface/Models/TimelineRecording.js:
2967         (WebInspector.TimelineRecording.prototype.unloaded):
2968         When a timeline recording is unloaded trigger an event.
2969
2970         * UserInterface/Views/TimelineContentView.js:
2971         (WebInspector.TimelineContentView.prototype._startUpdatingCurrentTime):
2972         Assert we were not already waiting.
2973
2974         (WebInspector.TimelineContentView.prototype._stopUpdatingCurrentTime):
2975         Properly handle the case of starting/stoping an already existing recording
2976         without a new event coming in.
2977
2978         (WebInspector.TimelineContentView.prototype._recordingTimesUpdated):
2979         (WebInspector.TimelineContentView.prototype._recordingReset):
2980         Convert to a boolean instead of deleting state.
2981
2982         (WebInspector.TimelineContentView.prototype._recordingUnloaded):
2983         Stop listening to timeline manager events that no longer affect unloaded recordings.
2984
2985 2014-08-13  Jono Wells  <jonowells@apple.com>
2986
2987         Web Inspector: eslint configuration should be stored as .eslintrc
2988         https://bugs.webkit.org/show_bug.cgi?id=135916
2989
2990         .eslintrc file added to allow for ESLint solutions, within editors and otherwise,
2991         to be automatically configured based on the WebKit JavaScript coding style. The
2992         initial file is incomplete.
2993
2994         Reviewed by Joseph Pecoraro.
2995
2996         * .eslintrc: Added.
2997         * External/.eslintrc: Added.
2998
2999 2014-08-13  Timothy Hatcher  <timothy@apple.com>
3000
3001         Web Inspector: Missing semicolon after console.assert in TimelineSidebarPanel.js
3002         https://bugs.webkit.org/show_bug.cgi?id=135917
3003
3004         Reviewed by Joseph Pecoraro.
3005
3006         * UserInterface/Views/TimelineSidebarPanel.js:
3007
3008 2014-08-13  Joseph Pecoraro  <pecoraro@apple.com>
3009
3010         Web Inspector: Inline DataGrid inside details sidebar has double thick top border with legacy styles
3011         https://bugs.webkit.org/show_bug.cgi?id=135894
3012
3013         Reviewed by Timothy Hatcher.
3014
3015         * UserInterface/Views/DetailsSection.css:
3016         (body.mac-platform.legacy .details-section:not(.collapsed) .data-grid.inline):
3017         In legacy styles the details-section header always has a 1px bottom border.
3018         In all styles, an inline data grid had a 1px border everywhere. So, handle
3019         this specific case by removing the top border of an inline data grid
3020         that is inside an expanded details section.
3021
3022 2014-08-13  Joseph Pecoraro  <pecoraro@apple.com>
3023
3024         Web Inspector: "No Filter Results" view only shows once, does not show again
3025         https://bugs.webkit.org/show_bug.cgi?id=135892
3026
3027         Reviewed by Timothy Hatcher.
3028
3029         * UserInterface/Views/NavigationSidebarPanel.js:
3030         (WebInspector.NavigationSidebarPanel.prototype.showEmptyContentPlaceholder):
3031         We were checking at the wrong level for a parent. Check if the root
3032         placeholder element has a parent or not.
3033
3034 2014-08-13  Joseph Pecoraro  <pecoraro@apple.com>
3035
3036         Web Inspector: Incorrect border colors in event listeners sections in details sidebar
3037         https://bugs.webkit.org/show_bug.cgi?id=135891
3038
3039         Reviewed by Timothy Hatcher.
3040
3041         * UserInterface/Views/DetailsSection.css:
3042         (.details-section .details-section > .header):
3043         (.details-section .details-section:not(.collapsed) > .header):
3044         Remove box-shadow and replace with a bottom border.
3045
3046         (body.mac-platform.legacy .details-section .details-section.collapsed > .header):
3047         (.details-section .details-section.collaspsed > .header): Deleted.
3048         Collapsed was spelled incorrectly so this was not applying properly before.
3049         But correct this for legacy because legacy still uses a box-shadow.
3050
3051 2014-08-13  Joseph Pecoraro  <pecoraro@apple.com>
3052
3053         Web Inspector: Timeline Close buttons can use polish for new and legacy styles
3054         https://bugs.webkit.org/show_bug.cgi?id=135870
3055
3056         Reviewed by Timothy Hatcher.
3057
3058         * UserInterface/Images/Legacy/Close.svg:
3059         Ensure this has fill colors in tree selections.
3060
3061         * UserInterface/Views/TimelineSidebarPanel.css:
3062         (.sidebar > .panel.navigation.timeline > .timelines-content .close-button):
3063         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content .close-button):
3064         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .content .item > .status > .status-button):
3065         Size the close-button for the top overviews differently in new styles (14x14) and legacy (12x12).
3066
3067 2014-08-13  Timothy Hatcher  <timothy@apple.com>
3068
3069         Web Inspector: Workaround a NSWindow change to the title bar.
3070         https://bugs.webkit.org/show_bug.cgi?id=135880
3071
3072         Reviewed by Joseph Pecoraro.
3073
3074         * UserInterface/Base/Main.js:
3075         (WebInspector._updateToolbarHeight): Don't call in legacy mode.
3076
3077         * UserInterface/Views/DashboardContainerView.css:
3078         (.toolbar .dashboard-container):
3079         (.toolbar .dashboard):
3080         Drive-by fix some errant drop-shadows. The transparent border was pushing the inset top
3081         drop shadow down when it shouldn't. Remove duplicate background and shadow.
3082
3083         * UserInterface/Views/Main.css:
3084         (body): Set the background white, never needs to be transparent now.
3085         (body.mac-platform.legacy:not(.docked)): Set background to transparent when not docked in legacy.
3086         (body.docked.bottom): Update border color.
3087         (body.docked.right): Ditto.
3088         (body.docked.bottom.mac-platform.legacy): Keep old border color.
3089         (body.docked.right.mac-platform.legacy): Ditto.
3090
3091         * UserInterface/Views/Toolbar.css:
3092         (.toolbar): Set a default border and background gradient.
3093         (body.window-inactive .toolbar): No gradient but use a solid color when inactive.
3094         (body.mac-platform:not(.legacy):not(.docked) .toolbar): Padding on the top for the title bar.
3095         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical): Account for title bar height.
3096         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical.small-size): Ditto.
3097         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-only): Ditto.
3098         (body.mac-platform:not(.legacy):not(.docked) .toolbar.label-only): Ditto.
3099         (body.mac-platform.legacy .toolbar): No inset shadow in legacy when not docked.
3100         (body.mac-platform.legacy.docked .toolbar): Restore legacy border color.
3101         (body.mac-platform.legacy:not(.docked) .toolbar .item.button > .label): Only disable sub-pixel antialiasing on legacy!
3102         (body.mac-platform.legacy.window-inactive .toolbar): Restore legacy border color.
3103
3104 2014-08-13  Timothy Hatcher  <timothy@apple.com>
3105
3106         Web Inspector: Restore Helvetica as the dashboard font in legacy mode
3107         https://bugs.webkit.org/show_bug.cgi?id=135886
3108
3109         Reviewed by Joseph Pecoraro.
3110
3111         * UserInterface/Views/DefaultDashboardView.css:
3112         (body.mac-platform.legacy .toolbar .dashboard.default > .item):
3113
3114 2014-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3115
3116         Web Inspector: Timeline record content view close button does not work after scrolling, invisible scrollbar
3117         https://bugs.webkit.org/show_bug.cgi?id=135863
3118
3119         Reviewed by Timothy Hatcher.
3120
3121         A workaround is to not have position:relative content inside of
3122         scrollable region. Turns out this was only done in two places,
3123         and I do not see any absolutely positioned content in navigation
3124         sidebar content tree outlines. This also fixes clicking on the
3125         reload button if you've scrolled the Resources sidebar. 
3126
3127         * UserInterface/Views/NavigationSidebarPanel.css:
3128         (.navigation-sidebar-panel-content-tree-outline .children): Deleted.
3129         (.navigation-sidebar-panel-content-tree-outline .item): Deleted.
3130
3131 2014-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3132
3133         Web Inspector: Remove unused variable in Platform.js
3134         https://bugs.webkit.org/show_bug.cgi?id=135869
3135
3136         Reviewed by Timothy Hatcher.
3137
3138         * UserInterface/Base/Platform.js:
3139
3140 2014-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3141
3142         Web Inspector: Timeline selection range creation does not work when clicking event bubble or near bottom of overview
3143         https://bugs.webkit.org/show_bug.cgi?id=135849
3144
3145         Reviewed by Timothy Hatcher.
3146
3147         Click events on elements in the graph container (event bubbles) or
3148         in the scroll container (bottom 16px) were becoming the event targets.
3149         As siblings of the ruler, the dispatch would not go through the ruler.
3150         The ruler was supposed to be overlaying everything in the overview,
3151         so give the ruler a z-index so it really is overlaying elements.
3152
3153         * UserInterface/Views/TimelineRuler.css:
3154         (.timeline-ruler):
3155
3156 2014-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3157
3158         Web Inspector: GoToLine dialog clear text button looks poor
3159         https://bugs.webkit.org/show_bug.cgi?id=135828
3160
3161         Reviewed by Timothy Hatcher.
3162
3163         Legacy/CloseWhite.svg was not used, but in the case where the white
3164         close button is needed the thicker bars looks better. Re-use the
3165         Legacy image as the default CloseWhite.svg.
3166
3167         * UserInterface/Images/CloseWhite.svg:
3168         * UserInterface/Images/Legacy/CloseWhite.svg: Removed.
3169
3170 2014-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3171
3172         Web Inspector: Easier Way to go back to the Timeline Overviews
3173         https://bugs.webkit.org/show_bug.cgi?id=135827
3174
3175         Reviewed by Timothy Hatcher.
3176
3177         * Localizations/en.lproj/localizedStrings.js:
3178         Added new tooltip UIString.
3179
3180         * UserInterface/Images/Close.svg:
3181         * UserInterface/Images/CloseLarge.svg:
3182         * UserInterface/Images/Legacy/Close.svg:
3183         Add "stroked" class so the buttons can fill with white on selected rows.
3184         Also re-center the non-legacy images horizontally.
3185
3186         * UserInterface/Views/GeneralTreeElement.js:
3187         (WebInspector.GeneralTreeElement.prototype.set status):
3188         Do not recreate elements if the status did not change.
3189
3190         * UserInterface/Views/LayoutTimelineView.js:
3191         (WebInspector.LayoutTimelineView):
3192         (WebInspector.LayoutTimelineView.prototype._treeElementDeselected):
3193         (WebInspector.LayoutTimelineView.prototype._treeElementSelected):
3194         (WebInspector.LayoutTimelineView.prototype._updateTreeElementWithCloseButton):
3195         (WebInspector.LayoutTimelineView.prototype._closeStatusButtonClicked):
3196         * UserInterface/Views/NetworkTimelineView.js:
3197         (WebInspector.NetworkTimelineView):
3198         (WebInspector.NetworkTimelineView.prototype._treeElementDeselected):
3199         (WebInspector.NetworkTimelineView.prototype._treeElementSelected):
3200         (WebInspector.NetworkTimelineView.prototype._updateTreeElementWithCloseButton):
3201         (WebInspector.NetworkTimelineView.prototype._closeStatusButtonClicked):
3202         * UserInterface/Views/OverviewTimelineView.js:
3203         (WebInspector.OverviewTimelineView.prototype._treeElementDeselected):
3204         (WebInspector.OverviewTimelineView.prototype._treeElementSelected):
3205         (WebInspector.OverviewTimelineView.prototype._updateTreeElementWithCloseButton):
3206         (WebInspector.OverviewTimelineView.prototype._closeStatusButtonClicked):
3207         * UserInterface/Views/ScriptTimelineView.js:
3208         (WebInspector.ScriptTimelineView):
3209         (WebInspector.ScriptTimelineView.prototype._treeElementDeselected):
3210         (WebInspector.ScriptTimelineView.prototype._treeElementSelected):
3211         (WebInspector.ScriptTimelineView.prototype._updateTreeElementWithCloseButton):
3212         (WebInspector.ScriptTimelineView.prototype._closeStatusButtonClicked):
3213         Provide select/deselect handlers to show/hide the close status bar button
3214         when selecting a row that shows a non-Timeline content view. Currently the
3215         only content views the tree elements can show are Resource views, so the
3216         tooltip is the same everywhere.
3217
3218 2014-08-12  Timothy Hatcher  <timothy@apple.com>
3219
3220         Web Inspector: Expect to see top level JavaScript function profiler details for event handlers in timeline
3221         https://bugs.webkit.org/show_bug.cgi?id=132109
3222
3223         Reviewed by Joseph Pecoraro.
3224
3225         * UserInterface/Views/ScriptTimelineView.js:
3226         (WebInspector.ScriptTimelineView.prototype._processPendingRecords): Don't promote root node children if
3227         there is only one child.
3228
3229 2014-08-11  Brian J. Burg  <burg@cs.washington.edu>
3230
3231         Web Inspector: show a replay dashboard when capturing or replaying
3232         https://bugs.webkit.org/show_bug.cgi?id=135170
3233
3234         Reviewed by Timothy Hatcher.
3235
3236         This patch adds a replay dashboard with record/play/pause buttons. It
3237         is shown automatically when the user starts capturing an execution from
3238         the replay menu in the Timelines sidebar panel.
3239
3240         * UserInterface/Base/Main.js:
3241         (WebInspector.loaded):
3242         (WebInspector._captureDidStart):
3243         * UserInterface/Controllers/DashboardManager.js:
3244         (WebInspector.DashboardManager):
3245         * UserInterface/Images/ReplayPauseButton.svg: Added.
3246         * UserInterface/Images/ReplayPlayButton.svg: Added.
3247         * UserInterface/Images/ReplayRecordingButton.svg: Added.
3248         * UserInterface/Main.html:
3249         * UserInterface/Models/ReplayDashboard.js: Copied from Source/WebInspectorUI/UserInterface/Controllers/DashboardManager.js.
3250         (WebInspector.ReplayDashboard):
3251         * UserInterface/Views/DashboardView.js:
3252         (WebInspector.DashboardView):
3253         * UserInterface/Views/ReplayDashboardView.css: Copied from Source/WebInspectorUI/UserInterface/Controllers/DashboardManager.js.
3254         (.toolbar .dashboard.replay):
3255         (.toolbar .dashboard.replay div.navigation-bar):
3256         (.toolbar .dashboard.replay .item.button > .glyph):
3257         (.toolbar.label-only .dashboard.replay .item.button > .glyph):
3258         * UserInterface/Views/ReplayDashboardView.js: Added.
3259         (WebInspector.ReplayDashboardView):
3260         (WebInspector.ReplayDashboardView.prototype._captureButtonItemClicked):
3261         (WebInspector.ReplayDashboardView.prototype._replayButtonItemClicked):
3262         (WebInspector.ReplayDashboardView.prototype._captureStarted):
3263         (WebInspector.ReplayDashboardView.prototype._captureStopped):
3264         (WebInspector.ReplayDashboardView.prototype._playbackStarted):
3265         (WebInspector.ReplayDashboardView.prototype._playbackPaused):
3266         (WebInspector.ReplayDashboardView.prototype._playbackFinished):
3267
3268 2014-08-08  Brian J. Burg  <burg@cs.washington.edu>
3269
3270         Web Inspector: DebuggerManager commands should return promises
3271         https://bugs.webkit.org/show_bug.cgi?id=135690
3272
3273         Reviewed by Timothy Hatcher.
3274
3275         Convert the existing debugger commands to return promises. This
3276         requires separately waiting for protocol command's promise to be
3277         fulfilled, as well as waiting for the appropriate DebuggerManager
3278         event. If the protocol command promise is rejected, tear down the
3279         single-fire event listener.
3280
3281         * UserInterface/Controllers/DebuggerManager.js:
3282         (WebInspector.DebuggerManager.prototype.pause):
3283         (WebInspector.DebuggerManager.prototype.resume):
3284         (WebInspector.DebuggerManager.prototype.stepOver):
3285         (WebInspector.DebuggerManager.prototype.stepInto):
3286         (WebInspector.DebuggerManager.prototype.stepOut):
3287         * UserInterface/Controllers/ReplayManager.js: Use the promise-based API.
3288         (WebInspector.ReplayManager.prototype._suppressBreakpointsAndResumeIfNeeded):
3289
3290 2014-08-11  Timothy Hatcher  <timothy@apple.com>
3291
3292         Web Inspector: Update folder icons
3293         https://bugs.webkit.org/show_bug.cgi?id=135808
3294
3295         Reviewed by Joseph Pecoraro.
3296
3297         * UserInterface/Images/FolderGeneric.png: Updated.
3298         * UserInterface/Images/FolderGeneric@2x.png: Updated.
3299
3300 2014-08-11  Timothy Hatcher  <timothy@apple.com>
3301
3302         Web Inspector: DataGrid and its clients are a cluster-cuss of styles
3303         https://bugs.webkit.org/show_bug.cgi?id=135788
3304
3305         Clean up DataGrid and its subclasses and client styles.
3306
3307         Reviewed by Joseph Pecoraro.
3308
3309         * Localizations/en.lproj/localizedStrings.js:
3310         * UserInterface/Views/ApplicationCacheFrameContentView.css:
3311         (.content-view.application-cache-frame > .data-grid):
3312         * UserInterface/Views/CookieStorageContentView.css:
3313         (.content-view.cookie-storage > .data-grid):
3314         * UserInterface/Views/DOMStorageContentView.css:
3315         (.content-view.dom-storage > .data-grid):
3316         * UserInterface/Views/DOMTreeDataGrid.css:
3317         (.dom-tree-data-grid .data-grid):
3318         (.dom-tree-data-grid .name-column .icon):
3319         * UserInterface/Views/DOMTreeDataGrid.js:
3320         (WebInspector.DOMTreeDataGrid):
3321         * UserInterface/Views/DataGrid.css:
3322         (.data-grid):
3323         (.data-grid table):
3324         (.data-grid .data-container):
3325         (.data-grid.inline):
3326         (.data-grid th):
3327         (.data-grid :-webkit-any(th, td):not(:last-child)):
3328         (.data-grid th.sortable:active):
3329         (.data-grid th:-webkit-any(.sort-ascending, .sort-descending)):
3330         (.data-grid table.data):
3331         (.data-grid td):
3332         (.data-grid:focus tr.selected td:not(:last-child)):
3333         (body.mac-platform.legacy .data-grid:focus tr.selected td:not(:last-child)):
3334         (.data-grid :-webkit-any(th, td) > div):
3335         (.data-grid th:-webkit-any(.sort-ascending, .sort-descending) > div:first-child):
3336         (.data-grid th.sort-ascending > div:first-child::after):
3337         (.data-grid th.sort-descending > div:first-child::after):
3338         (.data-grid td .subtitle):
3339         (.data-grid td .subtitle::before):
3340         (.data-grid:focus tr.selected td .subtitle):
3341         (.data-grid td.error):
3342         (.data-grid tr.selected td.error):
3343         (.data-grid td .icon):
3344         (.data-grid td .go-to-arrow):
3345         (.data-grid tr:-webkit-any(.selected, :hover) .go-to-arrow):
3346         * UserInterface/Views/DatabaseContentView.css:
3347         (.storage-view):
3348         * UserInterface/Views/DatabaseTableContentView.css:
3349         (.content-view.database-table > .data-grid):
3350         * UserInterface/Views/DetailsSection.css:
3351         (.details-section > .content .data-grid):
3352         * UserInterface/Views/IndexedDatabaseObjectStoreContentView.css:
3353         (.content-view.indexed-database-object-store > .data-grid):
3354         * UserInterface/Views/LayerTreeDataGridNode.js:
3355         (WebInspector.LayerTreeDataGridNode.prototype._makeNameCell):
3356         (WebInspector.LayerTreeDataGridNode.prototype._updateNameCellData):
3357         * UserInterface/Views/LayerTreeSidebarPanel.css:
3358         (.layer-tree.panel .data-grid):
3359         (.layer-tree.panel .name-column .icon):
3360         (.layer-tree.panel tr.reflection .name-column .icon):
3361         (.layer-tree.panel tr.pseudo-element .name-column .icon):
3362         (.layer-tree.panel .name-column .reflection):
3363         (.layer-tree.panel tr.selected .name-column .reflection):
3364         (.layer-tree.panel .bottom-bar):
3365         (body.mac-platform.legacy .layer-tree.panel .bottom-bar):
3366         (.layer-tree.panel .bottom-bar > div):
3367         (body.mac-platform.legacy .layer-tree.panel .bottom-bar > div):
3368         (body.mac-platform.legacy .layer-tree-popover):
3369         * UserInterface/Views/LayerTreeSidebarPanel.js:
3370         (WebInspector.LayerTreeSidebarPanel):
3371         (WebInspector.LayerTreeSidebarPanel.prototype._buildLayerInfoSection):
3372         (WebInspector.LayerTreeSidebarPanel.prototype._buildDataGridSection):
3373         (WebInspector.LayerTreeSidebarPanel.prototype._buildBottomBar):
3374         (WebInspector.LayerTreeSidebarPanel.prototype._updateMetrics):
3375         * UserInterface/Views/LegacyJavaScriptProfileView.css:
3376         (.content-view.profile-view > .data-grid):
3377         * UserInterface/Views/LegacyProfileView.css:
3378         * UserInterface/Views/LogContentView.css:
3379         (.console-message .bubble):
3380         * UserInterface/Views/NetworkTimelineView.css:
3381         (.timeline-view.network > .data-grid):
3382         * UserInterface/Views/OverviewTimelineView.css:
3383         (.timeline-view.overview > .timeline-ruler > .header):
3384         (.timeline-view.overview > .data-grid):
3385         * UserInterface/Views/OverviewTimelineView.js:
3386         * UserInterface/Views/ProbeDetailsSidebarPanel.css:
3387         (.details-section.probe-set .options > .probe-add):
3388         (.popover .probe-popover):
3389         * UserInterface/Views/ProbeSetDataGrid.css:
3390         (.details-section.probe-set .data-grid tr.past-value td):
3391         (.details-section.probe-set .data-grid > td.unknown-value):
3392         (.details-section.probe-set .data-grid tr.revealed.highlighted):
3393         (.details-section.probe-set .data-grid tr.separator):
3394         (.details-section.probe-set .data-grid > tr.data-updated):
3395         (.details-section.probe-set .data-grid .selected .section *):
3396         (.details-section.probe-set .data-grid .selected td.unknown-value):
3397         (.details-section.probe-set .data-grid .section):
3398         * UserInterface/Views/QuickConsole.css:
3399         (.quick-console):
3400         * UserInterface/Views/TimelineDataGrid.css:
3401         (.data-grid.timeline th):
3402         (.data-grid.timeline > .navigation-bar-container > .navigation-bar):
3403         * UserInterface/Views/TimelineRuler.css:
3404         (.timeline-ruler > .header):
3405         (.timeline-ruler > .header > .divider):
3406
3407 2014-08-11  Brent Fulgham  <bfulgham@apple.com>
3408
3409         [Win] Adjust build script for Windows production build.
3410         https://bugs.webkit.org/show_bug.cgi?id=135806
3411         <rdar://problem/17978299>
3412
3413         Reviewed by Timothy Hatcher.
3414
3415         * WebInspectorUI.vcxproj/WebInspectorUI.make: Make sure target for
3416         xcopy operation exists.
3417         * WebInspectorUI.vcxproj/WebInspectorUI.proj: Don't create directories
3418         we don't need, make sure the target location exists before we build.
3419         * WebInspectorUI.vcxproj/build-webinspectorui.pl: Make sure that
3420         production builds get the intermediary command files from the
3421         right place.
3422
3423 2014-08-11  Brian J. Burg  <burg@cs.washington.edu>
3424
3425         Web Inspector: Add a helper to avoid leaking single-fire event listeners in Promise chains
3426         https://bugs.webkit.org/show_bug.cgi?id=135772
3427
3428         Reviewed by Timothy Hatcher.
3429
3430         A common pattern when working with promise chains is to convert an event
3431         handler into a promise by using a single-fire event listener with the
3432         resolve continuation as the callback. This is fine if the event fires;
3433         if it doesn't fire, then the event emitter permanently keeps a reference to the
3434         this-object and the callback.
3435
3436         This patch adds EventListener, a proxy object for events that can be manipulated
3437         from multiple promise callback functions. If a promise is rejected, the catch
3438         block can disconnect any event listeners set up earlier in the promise chain.
3439
3440         This patch also reimplements EventListenerSet to use multiple EventListeners,
3441         since they share the same logic to uniformly handle Inspector and DOM events.
3442
3443         Test: inspector/event-listener.html
3444         Test: inspector/event-listener-set.html
3445
3446         * UserInterface/Base/EventListener.js: Added.
3447         (WebInspector.EventListener):
3448         (WebInspector.EventListener.prototype.this._callback):
3449         (WebInspector.EventListener.prototype.connect):
3450         (WebInspector.EventListener.prototype.disconnect):
3451         * UserInterface/Base/EventListenerSet.js: Update license block.
3452         (WebInspector.EventListenerSet.prototype.register):
3453         (WebInspector.EventListenerSet.prototype.install):
3454         (WebInspector.EventListenerSet.prototype.uninstall):
3455         * UserInterface/Main.html: Include EventListener.
3456         * UserInterface/Test.html: Include EventListener and EventListenerSet.
3457
3458 2014-08-10  Timothy Hatcher  <timothy@apple.com>
3459
3460         Web Inspector: new glyphs are visible on OS X 10.9 builds
3461         https://bugs.webkit.org/show_bug.cgi?id=135743
3462
3463         Reviewed by Joseph Pecoraro.
3464
3465         * UserInterface/Images/Legacy/UserInputPrompt.svg: Removed.
3466         * UserInterface/Images/Legacy/UserInputPromptPrevious.svg: Removed.
3467         * UserInterface/Images/Legacy/UserInputResult.svg: Removed.
3468         Removed images that were not used.
3469
3470         * UserInterface/Views/DashboardContainerView.css:
3471         (body.mac-platform.legacy .dashboard-container .advance-arrow):
3472         * UserInterface/Views/DebuggerDashboardView.js:
3473         (WebInspector.DebuggerDashboardView):
3474         * UserInterface/Views/FolderIcon.css:
3475         (body.mac-platform.legacy .folder-icon .icon):
3476         * UserInterface/Views/HierarchicalPathComponent.css:
3477         (body.mac-platform.legacy .hierarchical-path-component > .selector-arrows):
3478         * UserInterface/Views/LogContentView.js:
3479         (WebInspector.LogContentView):
3480         Use legacy images.
3481
3482         * UserInterface/Views/NavigationSidebarPanel.css:
3483         (.navigation-sidebar-panel-content-tree-outline:focus .item.selected .subtitle):
3484         Fix color for selected subtitle.
3485
3486         * UserInterface/Views/TimelineSidebarPanel.js:
3487         (WebInspector.TimelineSidebarPanel):
3488         Use legacy images.
3489
3490 2014-08-09  Brian J. Burg  <burg@cs.washington.edu>
3491
3492         Web Inspector: TimelineManager should reuse empty recordings
3493         https://bugs.webkit.org/show_bug.cgi?id=135749
3494
3495         Reviewed by Timothy Hatcher.
3496
3497         Check whether the recording is empty before creating a new one.
3498
3499         * UserInterface/Controllers/TimelineManager.js:
3500         (WebInspector.TimelineManager.prototype._loadNewRecording):
3501         * UserInterface/Models/TimelineRecording.js:
3502         (WebInspector.TimelineRecording.prototype.isEmpty):
3503         (WebInspector.TimelineRecording.prototype.unloaded):
3504
3505 2014-08-08  Brian J. Burg  <burg@cs.washington.edu>
3506
3507         Web Inspector: add debugging flag to InspectorTest for unbuffered logging to stderr
3508         https://bugs.webkit.org/show_bug.cgi?id=135726
3509
3510         Reviewed by Timothy Hatcher.
3511
3512         Added a flag for debugging inspector tests which will synchronously log messages.
3513         This avoids failure modes that prevent logging from being added to the test page.
3514
3515         * UserInterface/Base/Test.js:
3516         (InspectorTest.debugLog):
3517         (InspectorTest.addResult):
3518
3519 2014-08-08  Joseph Pecoraro  <pecoraro@apple.com>
3520
3521         Web Inspector: When Switching Recordings, the UI datagrids do not update to match selection
3522         https://bugs.webkit.org/show_bug.cgi?id=135764
3523
3524         Reviewed by Timothy Hatcher.
3525
3526         * UserInterface/Views/TimelineSidebarPanel.js:
3527         When changing the activeContentView trigger an update of the datagrids by
3528         re-applying the filter, which will be different now that the view is different.
3529
3530 2014-08-08  Joseph Pecoraro  <pecoraro@apple.com>
3531
3532         Web Inspector: Uncaught Exception opening Web Inspector - TypeError: undefined is not a function - candidateObjectCookie.every
3533         https://bugs.webkit.org/show_bug.cgi?id=135762
3534
3535         Reviewed by Timothy Hatcher.
3536
3537         * UserInterface/Views/NavigationSidebarPanel.js:
3538         (WebInspector.NavigationSidebarPanel.prototype.treeElementMatchesCookie):
3539         Fix a typo, the wrong object was being used.
3540
3541 2014-08-07  Brian J. Burg  <burg@cs.washington.edu>
3542
3543         REGRESSION(r172094): timeline views are blank after reloading in some situations
3544         https://bugs.webkit.org/show_bug.cgi?id=135742
3545
3546         Reviewed by Timothy Hatcher.
3547
3548         Address various bugs that cause the wrong timeline content views to appear when
3549         starting a recording by reloading the inspected page. Fix other small oversights
3550         that were encountered in the sidebar-based view state restoration code.
3551
3552         * UserInterface/Models/TimelineRecording.js:
3553         (WebInspector.TimelineRecording.prototype.saveIdentityToCookie): Add a dummy implementation.
3554
3555         * UserInterface/Views/NavigationSidebarPanel.js:
3556         (WebInspector.NavigationSidebarPanel.prototype.treeElementMatchesCookie):
3557         This code erroneously matches any tree element whose represented object's
3558         saveIdentityToCookie function produces an empty cookie.
3559
3560         * UserInterface/Views/TimelineContentView.js:
3561         (WebInspector.TimelineContentView.prototype._showTimelineView): Add an assertion
3562         that will find mismatches between represented objects of the TimelineContentView
3563         and TimelineViews.
3564
3565         * UserInterface/Views/TimelineSidebarPanel.js:
3566         (WebInspector.TimelineSidebarPanel.prototype.restoreStateFromCookie): Don't call
3567         the superclass's implementation, since we do not want to perform a relaxed match
3568         against any of our tree elements. The only thing that can be restored across reopen
3569         is a selected timeline tree element, which is already handled by this override.
3570
3571 2014-08-07  Joseph Pecoraro  <pecoraro@apple.com>
3572
3573         Web Inspector: Fix accidental always true comparison
3574         https://bugs.webkit.org/show_bug.cgi?id=135741
3575
3576         Reviewed by Timothy Hatcher.
3577
3578         Remove accidental "!" that would always cause this comparison to succeed.
3579
3580         * UserInterface/Views/OverviewTimelineView.js:
3581         (WebInspector.OverviewTimelineView.prototype.updateLayout):
3582
3583 2014-08-07  Joseph Pecoraro  <pecoraro@apple.com>
3584
3585         Web Inspector: Timeline Filter Bars are not appearing at all
3586         https://bugs.webkit.org/show_bug.cgi?id=135740
3587
3588         Reviewed by Timothy Hatcher.
3589
3590         * UserInterface/Views/TimelineDataGrid.css:
3591         (.data-grid.timeline.has-non-default-filter > .navigation-bar-container):
3592         (.data-grid.timeline > .navigation-bar-container > .navigation-bar):
3593         (body.mac-platform.legacy .data-grid.timeline > .navigation-bar-container > .navigation-bar):
3594         Update the positioning and height for non-legacy because the console is now taller.
3595
3596         * UserInterface/Views/ScopeBar.js:
3597         (WebInspector.ScopeBar.prototype.hasNonDefaultItemSelected):
3598         Helper to know if there is a non-default filter.
3599
3600         * UserInterface/Views/TimelineDataGrid.js:
3601         (WebInspector.TimelineDataGrid.prototype.treeElementMatchesActiveScopeFilters):
3602         (WebInspector.TimelineDataGrid.prototype._scopeBarSelectedItemsDidChange):
3603         Update scope bar visibility. If non-default we want to always show it.
3604         
3605         (WebInspector.TimelineDataGrid.prototype._updateScopeBarForcedVisibility):
3606         If there is a non-default filter, force showing the bar.
3607
3608 2014-08-07  Joseph Pecoraro  <pecoraro@apple.com>
3609
3610         Web Inspector: breakpoints enabled state is not persisted across re-opening the inspector
3611         https://bugs.webkit.org/show_bug.cgi?id=135745
3612
3613         Reviewed by Timothy Hatcher.
3614
3615         When restoring breakpoints when the inspector is initializing, do not
3616         let setting these breakpoints automatically enable breakpoints. We should
3617         respect the setting in this case.
3618
3619         * UserInterface/Controllers/DebuggerManager.js:
3620         (WebInspector.DebuggerManager.restoreBreakpointsSoon):
3621         (WebInspector.DebuggerManager):
3622
3623 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3624
3625         Web Inspector: Combine and minify Esprima
3626         https://bugs.webkit.org/show_bug.cgi?id=135728
3627
3628         Reviewed by Joseph Pecoraro.
3629
3630         * Scripts/combine-resources.pl:
3631         * Scripts/copy-user-interface-resources.pl:
3632         * UserInterface/External/Esprima/LICENSE: Added.
3633
3634 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3635
3636         Fix regression where tree outline keyboard navigation is broken.
3637
3638         https://bugs.webkit.org/show_bug.cgi?id=135718
3639
3640         Reviewed by Joseph Pecoraro.
3641
3642         * UserInterface/Views/TreeOutline.js:
3643         (TreeElement.prototype.revealed): Fix the check for currentAncestor.hidden.
3644
3645 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3646
3647         Web Inspector: Filter bar text and icon are positioned too low and tight
3648         https://bugs.webkit.org/show_bug.cgi?id=135723
3649
3650         Reviewed by Joseph Pecoraro.
3651
3652         * UserInterface/Views/FilterBar.css:
3653         (.filter-bar > input[type="search"]):
3654         (.filter-bar > input[type="search"]::-webkit-search-decoration):
3655         * UserInterface/Views/SearchBar.css:
3656         (.search-bar > input[type="search"]):
3657
3658 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3659
3660         Web Inspector: Dashboard error and warning icons should be filled when enabled
3661         https://bugs.webkit.org/show_bug.cgi?id=135725
3662
3663         Reviewed by Joseph Pecoraro.
3664
3665         * UserInterface/Images/ErrorsEnabled.svg:
3666         * UserInterface/Images/IssuesEnabled.svg:
3667
3668 2014-08-07  Joseph Pecoraro  <pecoraro@apple.com>
3669
3670         Web Inspector: Dashboard contents shift when window changes active state
3671         https://bugs.webkit.org/show_bug.cgi?id=135724
3672
3673         Reviewed by Timothy Hatcher.
3674
3675         The container was getting a 1px border when inactive and none when active.
3676         Give it a transparent border when active so contents don't change size.
3677
3678         * UserInterface/Views/DashboardContainerView.css:
3679         (.toolbar .dashboard-container):
3680
3681 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3682
3683         Fix reference to missing CloseTimeline.svg image.
3684
3685         Rubber-stamped by Joseph Pecoraro.
3686
3687         * UserInterface/Views/TimelineSidebarPanel.js:
3688         (WebInspector.TimelineSidebarPanel.createTimelineTreeElement): Use CloseLarge.svg instead.
3689
3690 2014-08-07  Brent Fulgham  <bfulgham@apple.com>
3691
3692         [Win] Unreviewed build fix.
3693
3694         Add a WebInspectorUI.proj file for use with MSBuild utility.
3695
3696         * WebInspectorUI.vcxproj/WebInspectorUI.proj: Added.
3697
3698 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
3699
3700         Get rid of INPUT_SPEECH
3701         https://bugs.webkit.org/show_bug.cgi?id=135672
3702
3703         Reviewed by Andreas Kling.
3704
3705         * UserInterface/Models/CSSKeywordCompletions.js:
3706
3707 2014-08-07  Joseph Pecoraro  <pecoraro@apple.com>
3708
3709         Web Inspector: Dragging selection window when mouse goes out of window bounds does not behave as expected
3710         https://bugs.webkit.org/show_bug.cgi?id=135372
3711
3712         Reviewed by Timothy Hatcher.
3713
3714         Constrain move selection window dragging to the ruler bounds
3715         based on the mouse down position on the drag window.
3716
3717         * UserInterface/Views/TimelineRuler.js:
3718         (WebInspector.TimelineRuler.prototype._handleMouseDown):
3719         (WebInspector.TimelineRuler.prototype._handleMouseMove):
3720         (WebInspector.TimelineRuler.prototype._handleMouseUp):
3721
3722 2014-08-07  Timothy Hatcher  <timothy@apple.com>
3723
3724         Web Inspector: Update glyphs to be more like Xcode 6
3725         https://bugs.webkit.org/show_bug.cgi?id=135705
3726
3727         Reviewed by Joseph Pecoraro.
3728
3729         * Localizations/en.lproj/localizedStrings.js: Updated.
3730
3731         * UserInterface/Base/ImageUtilities.js:
3732         (platformImagePath): Added.
3733         (generateEmbossedImages.generateImage):
3734         Bump the base image version. Helper function. Use isLegacyMacOS.
3735
3736         * UserInterface/Base/Main.js:
3737         (WebInspector.contentLoaded):
3738         (WebInspector._updateDockNavigationItems):
3739         (WebInspector._generateDisclosureTriangleImages):
3740         Use new images and add legacy path. Remove the shadow.
3741
3742         * UserInterface/Images: Updated images.
3743         * UserInterface/Images/Legacy: Added. Moved legacy images here.
3744
3745         * UserInterface/Views/CSSStyleDeclarationSection.css:
3746         (.style-declaration-section):
3747         (body.mac-platform.legacy .style-declaration-section + .style-declaration-section):
3748         (.style-declaration-section.last-in-group):
3749         (.style-declaration-section.last-in-group + .style-declaration-section):
3750         Use a consistent gray for borders.
3751
3752         * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
3753         (.sidebar > .panel.details.css-style > .content > .pseudo-classes):
3754         Use a consistent gray for borders.
3755
3756         * UserInterface/Views/ContentBrowser.js:
3757         (WebInspector.ContentBrowser):
3758         Use new images and add legacy path.
3759
3760         * UserInterface/Views/ControlToolbarItem.css:
3761         (.toolbar .item.control):
3762         (body.mac-platform.legacy .toolbar .item.control):
3763         (.toolbar .item.control:hover):
3764         (body.mac-platform.legacy .toolbar .item.control:hover):
3765         Adjust the opacity for controls.
3766
3767         * UserInterface/Views/DOMTreeContentView.js:
3768         (WebInspector.DOMTreeContentView):
3769         Use new images and add legacy path.
3770
3771         * UserInterface/Views/DataGrid.css:
3772         (.data-grid tr.selected):
3773         Use a consistent gray for borders.
3774
3775         * UserInterface/Views/DataGrid.js:
3776         (WebInspector.DataGrid.prototype.get _generateSortIndicatorImagesIfNeeded):
3777         Use new images and add legacy path. Remove the shadow.
3778
3779         * UserInterface/Views/DebuggerSidebarPanel.js:
3780         (WebInspector.DebuggerSidebarPanel):
3781         Use new images and add legacy path.
3782
3783         * UserInterface/Views/DefaultDashboardView.css:
3784         (.toolbar .dashboard.default > .item):
3785         (body.mac-platform.legacy .toolbar .dashboard.default > .item):
3786         (body.mac-platform.legacy .toolbar .dashboard.default > .resourcesCount > img):
3787         (body.mac-platform.legacy .toolbar .dashboard.default > .time > img):
3788         (body.mac-platform.legacy .toolbar .dashboard.default > .logs > img):
3789         (body.mac-platform.legacy .toolbar .dashboard.default > .resourcesSize > img):
3790         (body.mac-platform.legacy .toolbar .dashboard.default > .errors > img):
3791         (body.mac-platform.legacy .toolbar .dashboard.default > .errors.enabled > img):
3792         (body.mac-platform.legacy .toolbar .dashboard.default > .issues > img):
3793         (body.mac-platform.legacy .toolbar .dashboard.default > .issues.enabled > img):
3794         Use new images and add legacy path.
3795
3796         * UserInterface/Views/DetailsSection.css:
3797         (.details-section):
3798         (.details-section .details-section:first-child):
3799         (body.mac-platform.legacy .details-section > .header):
3800         (.details-section > .content > .group):
3801         (.details-section > .content > .group:nth-child(even) > .row.simple:first-child > *):
3802         (body.mac-platform.legacy .details-section > .content > .group:last-child > .row.simple:last-child > *):
3803         Use a consistent gray for borders.
3804
3805         * UserInterface/Views/FilterBar.css:
3806         (body.mac-platform.legacy .filter-bar > input[type="search"]::-webkit-search-decoration):
3807         Use new images and add legacy path.
3808
3809         * UserInterface/Views/FindBanner.css:
3810         (.find-banner):
3811         Use a consistent gray for borders.
3812
3813         * UserInterface/Views/FindBanner.js:
3814         (WebInspector.FindBanner.prototype._generateButtonsGlyphsIfNeeded):
3815         Add legacy path.
3816
3817         * UserInterface/Views/FrameTreeElement.js:
3818         (WebInspector.FrameTreeElement.prototype.updateStatusForMainFrame):
3819         Use new images and add legacy path.
3820
3821         * UserInterface/Views/LogContentView.js:
3822         (WebInspector.LogContentView):
3823         Use new images and add legacy path.
3824
3825         * UserInterface/Views/Main.css:
3826         (#split-content-browser):
3827         Use a consistent gray for borders.
3828
3829         * UserInterface/Views/NavigationSidebarPanel.css:
3830         (.sidebar > .panel.navigation > .overflow-shadow):
3831         (body.mac-platform.legacy .sidebar > .panel.navigation > .overflow-shadow):
3832         (.sidebar > .panel.navigation > .overflow-shadow.top):
3833         (body.mac-platform.legacy .sidebar > .panel.navigation > .overflow-shadow.top):
3834         (.sidebar > .panel.navigation > .empty-content-placeholder):
3835         (body.mac-platform.legacy .sidebar > .panel.navigation > .empty-content-placeholder):
3836         (.navigation-sidebar-panel-content-tree-outline:focus .item.selected .disclosure-button):
3837         (.navigation-sidebar-panel-content-tree-outline:focus .item.selected.expanded .disclosure-button):
3838         (.navigation-sidebar-panel-content-tree-outline .item.selected):
3839         (.navigation-sidebar-panel-content-tree-outline:focus .item.selected):
3840         Adjust the styles to make the selected item use white text and icons only when focused.
3841
3842         * UserInterface/Views/NavigationSidebarPanel.js:
3843         (WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
3844         (WebInspector.NavigationSidebarPanel.prototype._generateDisclosureTrianglesIfNeeded):
3845         Remove the shadow from the disclosure triangles. Make the overflow shadow not fade.
3846
3847         * UserInterface/Views/ProbeDetailsSidebarPanel.css:
3848         (.details-section.probe-set .options > .probe-clear-samples):
3849         (.details-section.probe-set .options > .probe-remove):
3850         (.details-section.probe-set .options > .probe-add):
3851         (body.mac-platform.legacy .details-section.probe-set .options > .probe-clear-samples):
3852         (body.mac-platform.legacy .details-section.probe-set .options > .probe-remove):
3853         (body.mac-platform.legacy .details-section.probe-set .options > .probe-add):
3854         Tweak size and position of icons and use legacy paths.
3855
3856         * UserInterface/Views/QuickConsole.css:
3857         (.quick-console):
3858         Adjust padding to match filter bar height.
3859
3860         * UserInterface/Views/ResourceSidebarPanel.css:
3861         (.sidebar > .panel.navigation.resource > .search-bar):
3862         Adjust height.
3863
3864         * UserInterface/Views/RulesStyleDetailsPanel.css:
3865         (.sidebar > .panel.details.css-style .rules .label + .style-declaration-section):
3866         (.sidebar > .panel.details.css-style .rules .new-rule + .style-declaration-section):
3867         (body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .new-rule img):
3868         Use a consistent gray for borders. Don't bold the New Rule label.
3869
3870         * UserInterface/Views/ScriptContentView.js:
3871         (WebInspector.ScriptContentView):
3872         Use new images and add legacy path.
3873
3874         * UserInterface/Views/Sidebar.css:
3875         (.sidebar.left):
3876         (.sidebar.right):
3877         Use a consistent gray for borders.
3878