Web Inspector: Inline multiple console log values if they are simple
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2017-07-25  Joseph Pecoraro  <pecoraro@apple.com>
2
3         Web Inspector: Inline multiple console log values if they are simple
4         https://bugs.webkit.org/show_bug.cgi?id=174746
5         <rdar://problem/33469376>
6
7         Reviewed by Matt Baker.
8
9         * UserInterface/Models/IssueMessage.js:
10         * UserInterface/Protocol/RemoteObject.js:
11         (WebInspector.RemoteObject.type): Deleted.
12         Remove this as it isn't as useful as directly checking the type.
13
14         * UserInterface/Views/ConsoleMessageView.js:
15         (WebInspector.ConsoleMessageView.prototype._appendExtraParameters):
16         (WebInspector.ConsoleMessageView.prototype._appendFormattedArguments):
17         (WebInspector.ConsoleMessageView.prototype._hasSimpleDisplay):
18         (WebInspector.ConsoleMessageView.prototype._isStackTrace):
19         For leading primitive/simple values, display them inline on the console message.
20
21         * UserInterface/Views/FormattedValue.js:
22         (WebInspector.FormattedValue.hasSimpleDisplay):
23         Provide a helper to determine if a formatted value will be simple.
24
25 2017-07-25  Nikita Vasilyev  <nvasilyev@apple.com>
26
27         Web Inspector: Styles: Add a switch for Spreadsheet model style editor to experimental settings
28         https://bugs.webkit.org/show_bug.cgi?id=174741
29         <rdar://problem/33467954>
30
31         Reviewed by Brian Burg.
32
33         Show a blank panel when Spreadsheet Style Editor is enabled.
34
35         * UserInterface/Base/Setting.js:
36         * UserInterface/Main.html:
37         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
38         (WebInspector.CSSStyleDetailsSidebarPanel):
39         (WebInspector.CSSStyleDetailsSidebarPanel.prototype.computedStyleDetailsPanelShowProperty):
40         * UserInterface/Views/RulesStyleSpreadsheetDetailsPanel.js: Added.
41         (WebInspector.RulesStyleSpreadsheetDetailsPanel):
42         (WebInspector.RulesStyleSpreadsheetDetailsPanel.prototype.filterDidChange):
43         (WebInspector.RulesStyleSpreadsheetDetailsPanel.prototype.scrollToSectionAndHighlightProperty):
44
45         * UserInterface/Views/SettingsTabContentView.css:
46         (.content-view.settings > .settings-view > .container.hidden):
47         (.content-view.settings > .settings-view > .container-centered):
48         (.content-view.settings > .settings-view > .container button):
49         * UserInterface/Views/SettingsTabContentView.js:
50         (WebInspector.SettingsTabContentView.prototype._createDebugSettingsView):
51         * UserInterface/Views/SettingsView.js:
52         (WebInspector.SettingsView.prototype.addCenteredContainer):
53         (WebInspector.SettingsView):
54         Show "Reload Web Inspector" button when Spreadsheet Style Editor setting is modified.
55
56 2017-07-25  Devin Rousso  <drousso@apple.com>
57
58         Web Inspector: add context menu item for taking a screenshot of a node
59         https://bugs.webkit.org/show_bug.cgi?id=174754
60
61         Reviewed by Brian Burg.
62
63         * Localizations/en.lproj/localizedStrings.js:
64         * UserInterface/Views/ContextMenuUtilities.js:
65         (WebInspector.appendContextMenuItemsForDOMNode):
66         Add "Capture Element Screenshot " context menu item that opens a save dialog with a picture of the node.
67
68         * UserInterface/Base/Main.js:
69         (WebInspector.saveDataToFile):
70         Allow the saveData to specify whether the contained content is base64Encoded, instead of
71         having to go through a Blob to save base64 data.
72
73         * UserInterface/Base/Utilities.js:
74         Add Number.pad to add leading zeros up to a certain width.
75
76         Drive-by: fix failing test for Number.constrain.
77
78         * UserInterface/Models/DOMNode.js:
79         (WebInspector.DOMNode.prototype.scrollIntoView.resolvedNode.scrollIntoView): Added.
80         (WebInspector.DOMNode.prototype.scrollIntoView.resolvedNode): Added.
81         (WebInspector.DOMNode.prototype.scrollIntoView): Added.
82         * UserInterface/Views/DOMTreeElement.js:
83         (WebInspector.DOMTreeElement.prototype._populateNodeContextMenu):
84         (WebInspector.DOMTreeElement.prototype._scrollIntoView.resolvedNode.scrollIntoView): Deleted.
85         (WebInspector.DOMTreeElement.prototype._scrollIntoView.resolvedNode): Deleted.
86         (WebInspector.DOMTreeElement.prototype._scrollIntoView): Deleted.
87         * UserInterface/Views/DOMTreeOutline.js:
88         (WebInspector.DOMTreeOutline.prototype.populateContextMenu):
89         Drive-by: move "Scroll Into View" context menu command to WebInspector.appendContextMenuItemsForDOMNode
90         so that it can be triggered from more places than just the DOM tree.
91
92 2017-07-24  Nikita Vasilyev  <me@elv1s.ru>
93
94         Web Inspector: Settings: Some controls overlay settings header
95         https://bugs.webkit.org/show_bug.cgi?id=174804
96
97         Reviewed by Matt Baker.
98
99         * UserInterface/Views/SettingsTabContentView.css:
100         (.content-view.settings .navigation-bar):
101
102 2017-07-24  Matt Baker  <mattbaker@apple.com>
103
104         Web Inspector: should only show Canvases in resource type filter if debug setting enabled
105         https://bugs.webkit.org/show_bug.cgi?id=174765
106         <rdar://problem/33479009>
107
108         Reviewed by Devin Rousso.
109
110         * UserInterface/Views/ResourceSidebarPanel.js:
111         (WebInspector.ResourceSidebarPanel):
112
113 2017-07-21  Joseph Pecoraro  <pecoraro@apple.com>
114
115         Web Inspector: inspect(aFunction) should jump to function definition
116         https://bugs.webkit.org/show_bug.cgi?id=149344
117         <rdar://problem/11563607>
118
119         Reviewed by Matt Baker.
120
121         * UserInterface/Protocol/InspectorObserver.js:
122         (WebInspector.InspectorObserver.prototype.inspect):
123         If we receive a function remote object jump to its location if available.
124
125 2017-07-21  Joseph Pecoraro  <pecoraro@apple.com>
126
127         Web Inspector: Avoid subclassing WebInspector.Object if we do not need to
128         https://bugs.webkit.org/show_bug.cgi?id=174703
129
130         Reviewed by Brian Burg.
131
132         * UserInterface/Models/LogObject.js:
133         (WebInspector.LogObject):
134         (WebInspector.LogObject.prototype.get startDate): Deleted.
135         Remove unused startDate property as well.
136
137         * UserInterface/Base/YieldableTask.js:
138         * UserInterface/Debug/ProtocolTrace.js:
139         * UserInterface/Models/AnalyzerMessage.js:
140         * UserInterface/Models/ApplicationCacheFrame.js:
141         * UserInterface/Models/ApplicationCacheManifest.js:
142         * UserInterface/Models/BackForwardEntry.js:
143         * UserInterface/Models/Branch.js:
144         * UserInterface/Models/BreakpointAction.js:
145         * UserInterface/Models/CSSMedia.js:
146         * UserInterface/Models/CSSSelector.js:
147         * UserInterface/Models/CallFrame.js:
148         * UserInterface/Models/CallingContextTree.js:
149         * UserInterface/Models/CallingContextTreeNode.js:
150         * UserInterface/Models/CollectionEntry.js:
151         * UserInterface/Models/CollectionEntryPreview.js:
152         * UserInterface/Models/ConsoleMessage.js:
153         * UserInterface/Models/DOMSearchMatchObject.js:
154         * UserInterface/Models/DatabaseObject.js:
155         * UserInterface/Models/DatabaseTableObject.js:
156         * UserInterface/Models/DebuggerDashboard.js:
157         * UserInterface/Models/DebuggerData.js:
158         * UserInterface/Models/ExecutionContext.js:
159         * UserInterface/Models/ExecutionContextList.js:
160         * UserInterface/Models/GarbageCollection.js:
161         * UserInterface/Models/HeapSnapshotRootPath.js:
162         * UserInterface/Models/IndexedDatabase.js:
163         * UserInterface/Models/IndexedDatabaseObjectStore.js:
164         * UserInterface/Models/IndexedDatabaseObjectStoreIndex.js:
165         * UserInterface/Models/Instrument.js:
166         * UserInterface/Models/KeyboardShortcut.js:
167         * UserInterface/Models/LineWidget.js:
168         * UserInterface/Models/MemoryCategory.js:
169         * UserInterface/Models/MemoryPressureEvent.js:
170         * UserInterface/Models/ObjectPreview.js:
171         * UserInterface/Models/Probe.js:
172         * UserInterface/Models/ProbeSetDataFrame.js:
173         * UserInterface/Models/Profile.js:
174         * UserInterface/Models/ProfileNode.js:
175         * UserInterface/Models/ProfileNodeCall.js:
176         * UserInterface/Models/PropertyDescriptor.js:
177         * UserInterface/Models/PropertyPath.js:
178         * UserInterface/Models/PropertyPreview.js:
179         * UserInterface/Models/ResourceQueryMatch.js:
180         * UserInterface/Models/ResourceQueryResult.js:
181         * UserInterface/Models/ResourceTimingData.js:
182         * UserInterface/Models/Revision.js:
183         * UserInterface/Models/ScopeChainNode.js:
184         * UserInterface/Models/ScriptSyntaxTree.js:
185         * UserInterface/Models/SourceCodePosition.js:
186         * UserInterface/Models/SourceCodeSearchMatchObject.js:
187         * UserInterface/Models/SourceMap.js:
188         * UserInterface/Models/StackTrace.js:
189         * UserInterface/Models/StructureDescription.js:
190         * UserInterface/Models/TextMarker.js:
191         * UserInterface/Models/TextRange.js:
192         * UserInterface/Models/TimelineRange.js:
193         * UserInterface/Models/TypeDescription.js:
194         * UserInterface/Models/TypeSet.js:
195         * UserInterface/Protocol/ProtocolTracer.js:
196         * UserInterface/Proxies/FormatterWorkerProxy.js:
197         * UserInterface/Proxies/HeapSnapshotDiffProxy.js:
198         * UserInterface/Proxies/HeapSnapshotWorkerProxy.js:
199         * UserInterface/Test/TestSuite.js:
200
201 2017-07-19  Chris Dumez  <cdumez@apple.com>
202
203         Drop SQLException type
204         https://bugs.webkit.org/show_bug.cgi?id=174665
205
206         Reviewed by Sam Weinig.
207
208         Use SQLError instead of SQLException, this is what the script should really
209         use here since it is checking the code of an SQLError.
210
211         * .eslintrc:
212         * UserInterface/Models/DatabaseObject.js:
213         (WebInspector.DatabaseObject.prototype.executeSQL.queryCallback):
214         (WebInspector.DatabaseObject.prototype.executeSQL):
215         (WebInspector.DatabaseObject):
216
217 2017-07-18  Andy Estes  <aestes@apple.com>
218
219         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
220         https://bugs.webkit.org/show_bug.cgi?id=174631
221
222         Reviewed by Tim Horton.
223
224         * Configurations/Base.xcconfig:
225
226 2017-07-18  Andy Estes  <aestes@apple.com>
227
228         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
229         https://bugs.webkit.org/show_bug.cgi?id=174631
230
231         Reviewed by Sam Weinig.
232
233         * Configurations/Base.xcconfig:
234
235 2017-07-18  Brian Burg  <bburg@apple.com>
236
237         Web Inspector: adjust wording of "clear when page {navigates -> loads}"
238         https://bugs.webkit.org/show_bug.cgi?id=174589
239         <rdar://problem/32797981>
240
241         Reviewed by Joseph Pecoraro.
242
243         * Localizations/en.lproj/localizedStrings.js:
244         * UserInterface/Views/SettingsTabContentView.js:
245         (WebInspector.SettingsTabContentView.prototype._createGeneralSettingsView):
246
247 2017-07-18  Andy Estes  <aestes@apple.com>
248
249         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
250         https://bugs.webkit.org/show_bug.cgi?id=174631
251
252         Reviewed by Dan Bernstein.
253
254         * Configurations/Base.xcconfig:
255
256 2017-07-18  Andy Estes  <aestes@apple.com>
257
258         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
259         https://bugs.webkit.org/show_bug.cgi?id=174631
260
261         Reviewed by Darin Adler.
262
263         * Configurations/Base.xcconfig:
264
265 2017-07-13  Joseph Pecoraro  <pecoraro@apple.com>
266
267         Web Inspector: Remove unused and untested Page domain commands
268         https://bugs.webkit.org/show_bug.cgi?id=174429
269
270         Reviewed by Timothy Hatcher.
271
272         * UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js:
273         * UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js:
274         * UserInterface/Protocol/Legacy/11.0/InspectorBackendCommands.js:
275         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
276         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
277         * UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
278         * UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js:
279         * Versions/Inspector-iOS-10.0.json:
280         * Versions/Inspector-iOS-10.3.json:
281         * Versions/Inspector-iOS-11.0.json:
282         * Versions/Inspector-iOS-7.0.json:
283         * Versions/Inspector-iOS-8.0.json:
284         * Versions/Inspector-iOS-9.0.json:
285         * Versions/Inspector-iOS-9.3.json:
286
287 2017-07-11  Joseph Pecoraro  <pecoraro@apple.com>
288
289         Web Inspector: Correct a typo in the .eslintrc
290         https://bugs.webkit.org/show_bug.cgi?id=174389
291
292         Reviewed by Matt Baker.
293
294         * .eslintrc:
295
296 2017-07-11  Joseph Pecoraro  <pecoraro@apple.com>
297
298         Web Inspector: Node Sidebar - Improve wording for Potential Custom Element lacking a Custom definition
299         https://bugs.webkit.org/show_bug.cgi?id=174346
300
301         Reviewed by Matt Baker.
302
303         * Localizations/en.lproj/localizedStrings.js:
304         * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
305         (WebInspector.DOMNodeDetailsSidebarPanel.prototype._customElementState):
306         The text "Waiting to be upgraded" is poor. Any non-standard element with dashes
307         in the name is considered custom, but does not need to be upgraded. Lets use
308         different wording to indicate that it is detected as custom, and lacks a
309         specific Custom Element definition.
310
311 2017-07-10  Devin Rousso  <drousso@apple.com>
312
313         Web Inspector: Highlight matching CSS canvas clients when hovering contexts in the Resources tab
314         https://bugs.webkit.org/show_bug.cgi?id=174279
315
316         Reviewed by Matt Baker.
317
318         * UserInterface/Controllers/DOMTreeManager.js:
319         (WebInspector.DOMTreeManager.prototype.highlightDOMNodeList):
320         (WebInspector.DOMTreeManager.prototype.highlightSelector):
321         * UserInterface/Views/CanvasTreeElement.js:
322         (WebInspector.CanvasTreeElement.prototype._handleMouseOver):
323
324 2017-07-03  Brian Burg  <bburg@apple.com>
325
326         Web Replay: remove some unused code
327         https://bugs.webkit.org/show_bug.cgi?id=173903
328
329         Rubber-stamped by Joseph Pecoraro.
330
331         * .eslintrc:
332         * UserInterface/Base/Main.js:
333         (WebInspector.loaded):
334         * UserInterface/Controllers/DashboardManager.js:
335         (WebInspector.DashboardManager):
336         * UserInterface/Controllers/ReplayManager.js: Removed.
337         * UserInterface/Images/ReplayPauseButton.svg: Removed.
338         * UserInterface/Images/ReplayPlayButton.svg: Removed.
339         * UserInterface/Images/ReplayRecordingButton.svg: Removed.
340         * UserInterface/Images/gtk/ReplayPauseButton.svg: Removed.
341         * UserInterface/Images/gtk/ReplayPlayButton.svg: Removed.
342         * UserInterface/Images/gtk/ReplayRecordingButton.svg: Removed.
343         * UserInterface/Main.html:
344         * UserInterface/Models/ReplayDashboard.js: Removed.
345         * UserInterface/Models/ReplaySession.js: Removed.
346         * UserInterface/Models/ReplaySessionSegment.js: Removed.
347         * UserInterface/Protocol/ReplayObserver.js: Removed.
348         * UserInterface/Test.html:
349         * UserInterface/Test/Test.js:
350         (WebInspector.loaded):
351         * UserInterface/Views/DashboardView.js:
352         (WebInspector.DashboardView.create):
353         * UserInterface/Views/ReplayDashboardView.css: Removed.
354         * UserInterface/Views/ReplayDashboardView.js: Removed.
355         * UserInterface/Views/TimelineRecordingContentView.js:
356         (WebInspector.TimelineRecordingContentView.prototype._debuggerPaused):
357         (WebInspector.TimelineRecordingContentView.prototype._debuggerResumed):
358
359 2017-07-07  Devin Rousso  <drousso@apple.com>
360
361         Web Inspector: Resources are sometimes missing from the tree outline right before folderizing
362         https://bugs.webkit.org/show_bug.cgi?id=174277
363
364         Reviewed by Joseph Pecoraro.
365
366         * UserInterface/Views/TreeElement.js:
367         (WebInspector.TreeElement.prototype.expand):
368
369 2017-07-07  Devin Rousso  <drousso@apple.com>
370
371         Web Inspector: REGRESSION(r217258): WebSocket resource tree elements don't show the connection status
372         https://bugs.webkit.org/show_bug.cgi?id=174274
373
374         Reviewed by Brian Burg.
375
376         * UserInterface/Views/FrameTreeElement.js:
377         (WebInspector.FrameTreeElement):
378         * UserInterface/Views/ResourceTreeElement.js:
379         (WebInspector.ResourceTreeElement.prototype.populateContextMenu):
380         * UserInterface/Views/WebSocketResourceTreeElement.js:
381         (WebInspector.WebSocketResourceTreeElement.prototype.populateContextMenu):
382         Move "Log WebSocket" context menu item to WebSocketResourceTreeElement.
383
384 2017-07-07  Devin Rousso  <drousso@apple.com>
385
386         Web Inspector: Show all elements currently using a given CSS Canvas
387         https://bugs.webkit.org/show_bug.cgi?id=173965
388
389         Reviewed by Joseph Pecoraro.
390
391         * UserInterface/Controllers/CanvasManager.js:
392         (WebInspector.CanvasManager.prototype.cssCanvasClientNodesChanged):
393         * UserInterface/Models/Canvas.js:
394         (WebInspector.Canvas.prototype.requestCSSCanvasClientNodes):
395         (WebInspector.Canvas.prototype.cssCanvasClientNodesChanged):
396         * UserInterface/Protocol/CanvasObserver.js:
397         (WebInspector.CanvasObserver.prototype.cssCanvasClientNodesChanged):
398
399         * Localizations/en.lproj/localizedStrings.js:
400         * UserInterface/Views/CanvasDetailsSidebarPanel.js:
401         (WebInspector.CanvasDetailsSidebarPanel):
402         (WebInspector.CanvasDetailsSidebarPanel.prototype.set canvas):
403         (WebInspector.CanvasDetailsSidebarPanel.prototype.initialLayout):
404         (WebInspector.CanvasDetailsSidebarPanel.prototype.layout):
405         (WebInspector.CanvasDetailsSidebarPanel.prototype._refreshCSSCanvasSection):
406         (WebInspector.CanvasDetailsSidebarPanel.prototype._formatMemoryRow):
407         Add CSS section for CSS canvases. Currently displays a list of node links, each of which is
408         using the selected canvas via -webkit-canvas.
409
410         * UserInterface/Main.html:
411         * UserInterface/Views/CanvasDetailsSidebarPanel.css: Added.
412         (.sidebar > .panel.details.canvas .details-section > .content .row.simple > .value > .node-link):
413
414         * UserInterface/Controllers/DOMTreeManager.js:
415         (WebInspector.DOMTreeManager.prototype.ensureDocument):
416         * UserInterface/Models/Canvas.js:
417         (WebInspector.Canvas.prototype.requestNode):
418         * UserInterface/Views/SearchSidebarPanel.js:
419         (WebInspector.SearchSidebarPanel.prototype.performSearch):
420         Add convenience function that will call DOMAgent.getDocument with an empty function. Should
421         be used when it is necessary that the document has been sent to the frontend, but the
422         document node itself is not needed.
423
424 2017-07-07  Joseph Pecoraro  <pecoraro@apple.com>
425
426         Web Inspector: Clean up some unnecessary constructors
427         https://bugs.webkit.org/show_bug.cgi?id=174236
428
429         Reviewed by Brian Burg.
430
431         * UserInterface/Controllers/CodeMirrorBezierEditingController.js:
432         * UserInterface/Controllers/CodeMirrorColorEditingController.js:
433         * UserInterface/Controllers/CodeMirrorGradientEditingController.js:
434         * UserInterface/Views/DividerNavigationItem.js:
435         * UserInterface/Views/FlexibleSpaceNavigationItem.js:
436         * UserInterface/Views/IdleTreeElement.js:
437
438 2017-07-06  Devin Rousso  <drousso@apple.com>
439
440         Web Inspector: Highlight matching canvas element when hovering contexts in the Resources tab
441         https://bugs.webkit.org/show_bug.cgi?id=174209
442
443         Reviewed by Joseph Pecoraro.
444
445         * UserInterface/Views/CanvasTreeElement.js:
446         (WebInspector.CanvasTreeElement.prototype.onattach):
447         (WebInspector.CanvasTreeElement.prototype._handleMouseOver):
448         (WebInspector.CanvasTreeElement.prototype._handleMouseOut):
449
450 2017-07-06  Joseph Pecoraro  <pecoraro@apple.com>
451
452         Web Inspector: Add another Protocol Version
453         https://bugs.webkit.org/show_bug.cgi?id=174193
454         <rdar://problem/33150053>
455
456         Reviewed by Brian Burg.
457
458         * UserInterface/Protocol/Legacy/11.0/InspectorBackendCommands.js: Added.
459         * Versions/Inspector-iOS-11.0.json: Added.
460
461 2017-07-05  Devin Rousso  <drousso@apple.com>
462
463         Web Inspector: Group Inspector Style Sheets as part of the Stylesheets folder
464         https://bugs.webkit.org/show_bug.cgi?id=173435
465
466         Reviewed by Joseph Pecoraro.
467
468         * UserInterface/Views/ResourceSidebarPanel.js:
469         (WebInspector.ResourceSidebarPanel.prototype.matchTreeElementAgainstCustomFilters.match):
470         Add special case for CSSStyleSheetTreeElement.
471
472 2017-07-05  Devin Rousso  <drousso@apple.com>
473
474         Web Inspector: Split Canvas.svg into icons for 2D and 3D
475         https://bugs.webkit.org/show_bug.cgi?id=174057
476
477         Reviewed by Matt Baker.
478
479         * UserInterface/Images/Canvas2D.svg: Added.
480         * UserInterface/Images/Canvas3D.svg: Renamed from Source/WebInspectorUI/UserInterface/Images/Canvas.svg.
481         * UserInterface/Views/ResourceIcons.css:
482         (.canvas.canvas-2d .icon):
483         (.canvas:matches(.webgl, .webgl2, .webgpu) .icon):
484         (.canvas .icon): Deleted.
485
486 2017-07-05  Devin Rousso  <drousso@apple.com>
487
488         Web Inspector: Allow users to log any tracked canvas context
489         https://bugs.webkit.org/show_bug.cgi?id=173397
490         <rdar://problem/33111581>
491
492         Reviewed by Joseph Pecoraro.
493
494         * Localizations/en.lproj/localizedStrings.js:
495         * UserInterface/Protocol/RemoteObject.js:
496         (WebInspector.RemoteObject.resolveCanvasContext):
497         * UserInterface/Views/CanvasTreeElement.js:
498         (WebInspector.CanvasTreeElement.prototype.populateContextMenu):
499
500 2017-07-03  Devin Rousso  <drousso@apple.com>
501
502         Web Inspector: Support listing WebGL2 and WebGPU contexts
503         https://bugs.webkit.org/show_bug.cgi?id=173396
504
505         Reviewed by Joseph Pecoraro.
506
507         * UserInterface/Models/Canvas.js:
508         (WebInspector.Canvas.fromPayload):
509         (WebInspector.Canvas.displayNameForContextType):
510
511 2017-07-01  Dan Bernstein  <mitz@apple.com>
512
513         [macOS] Remove code only needed when building for OS X Yosemite
514         https://bugs.webkit.org/show_bug.cgi?id=174067
515
516         Reviewed by Tim Horton.
517
518         * Configurations/Base.xcconfig:
519         * Configurations/DebugRelease.xcconfig:
520         * Configurations/Version.xcconfig:
521
522 2017-06-30  Joseph Pecoraro  <pecoraro@apple.com>
523
524         Web Inspector: Type token background color in debugger looks poor
525         https://bugs.webkit.org/show_bug.cgi?id=174063
526
527         Reviewed by Devin Rousso.
528
529         * UserInterface/Views/TextEditor.css:
530         CodeMirror widgets do not get range styles like our (.execution-range-highlight).
531         Make a best effort to carry over the styles to widgets. It isn't perfect, but it
532         covers all common situations unless a selection ends inside the widget. The
533         ultimate solution would be to get the expected range styles.
534
535 2017-06-30  Joseph Pecoraro  <pecoraro@apple.com>
536
537         Web Inspector: Initial search is sometimes performed twice, produces duplicate results
538         https://bugs.webkit.org/show_bug.cgi?id=174047
539
540         Reviewed by Devin Rousso.
541
542         * UserInterface/Views/SearchTabContentView.js:
543         (WebInspector.SearchTabContentView.prototype.performSearch):
544         The initial layout of the tab content view was setting state to force a search
545         which may happen after a delay, however the global search field was causing
546         its own search to happen. We can clear the flag when a search is being performed
547         to prevent duplicating the search.
548
549 2017-06-30  Devin Rousso  <drousso@apple.com>
550
551         Web Inspector: Add small delay before showing the progress spinner when loading resources
552         https://bugs.webkit.org/show_bug.cgi?id=173437
553
554         Reviewed by Joseph Pecoraro.
555
556         * UserInterface/Views/ResourceContentView.js:
557         (WebInspector.ResourceContentView):
558         (WebInspector.ResourceContentView.prototype.removeLoadingIndicator): Added.
559         (WebInspector.ResourceContentView.prototype._contentError):
560         (WebInspector.ResourceContentView.prototype._hasContent):
561         Delay the creation of the spinner for 100ms.  If the content is available before then, just
562         clear the timeout and the spinner will never be created/shown.
563
564         We measured an average of 35ms to load and display images with slow cases being around 55ms.
565         100ms was chosen for the timeout to give some room to allow for abnormally slow loading
566         while not being too long as to be outright noticable.
567
568         * UserInterface/Views/FontResourceContentView.js:
569         (WebInspector.FontResourceContentView.prototype.contentAvailable):
570         * UserInterface/Views/ImageResourceContentView.js:
571         (WebInspector.ImageResourceContentView.prototype.contentAvailable):
572         * UserInterface/Views/TextResourceContentView.js:
573         (WebInspector.TextResourceContentView.prototype._contentWillPopulate):
574         Calls the new protected function removeLoadingIndicator to ensure that the spinner (and any
575         other element) is removed.
576
577         This is necessary because TextResourceContentView effectively has two phases of loading its
578         content: getting the content and formatting it for display.  The first follows the same path
579         as the other ResourceContentView subclasses, the second waits for the ContentWillPopulate
580         event on SourceCodeTextEditor before it actually adds the content as a subview.  In this
581         case, the spinner should only be removed right before the content is actually added, not
582         once it's ready.
583
584 2017-06-30  Commit Queue  <commit-queue@webkit.org>
585
586         Unreviewed, rolling out r218983.
587         https://bugs.webkit.org/show_bug.cgi?id=174042
588
589         Broke Debugger Call Stack TreeOutline (Requested by drousso on
590         #webkit).
591
592         Reverted changeset:
593
594         "Web Inspector: Remove unnecessary hasChildren from
595         TreeOutline"
596         https://bugs.webkit.org/show_bug.cgi?id=173986
597         http://trac.webkit.org/changeset/218983
598
599 2017-06-30  Devin Rousso  <drousso@apple.com>
600
601         Web Inspector: Default string comparisons to treat numeric characters as numbers
602         https://bugs.webkit.org/show_bug.cgi?id=173984
603
604         Reviewed by Joseph Pecoraro.
605
606         * UserInterface/Base/Utilities.js:
607         (String.prototype.extendedLocaleCompare):
608         * UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
609         (WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.receivedPropertyNames.compare):
610         * UserInterface/Controllers/ResourceQueryController.js:
611         (WebInspector.ResourceQueryController.prototype.executeQuery):
612         * UserInterface/Views/ApplicationCacheFrameContentView.js:
613         (WebInspector.ApplicationCacheFrameContentView.prototype._sortDataGrid.localeCompare):
614         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
615         (WebInspector.CSSStyleDeclarationTextEditor.prototype._iterateOverProperties):
616         * UserInterface/Views/CookieStorageContentView.js:
617         (WebInspector.CookieStorageContentView.prototype._sortDataGrid.localeCompare):
618         * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
619         (WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAttributes):
620         (WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshEventListeners.generateGroupsByNode):
621         * UserInterface/Views/DOMStorageContentView.js:
622         (WebInspector.DOMStorageContentView.prototype._sortDataGrid.comparator):
623         * UserInterface/Views/DebuggerSidebarPanel.js:
624         (WebInspector.DebuggerSidebarPanel.prototype._compareTopLevelTreeElements):
625         * UserInterface/Views/FolderizedTreeElement.js:
626         (WebInspector.FolderizedTreeElement.prototype._compareTreeElementsByMainTitle):
627         * UserInterface/Views/HeapSnapshotDataGridTree.js:
628         (WebInspector.HeapSnapshotDataGridTree.buildSortComparator):
629         * UserInterface/Views/NetworkTimelineView.js:
630         (WebInspector.NetworkTimelineView.prototype.dataGridSortComparator):
631         * UserInterface/Views/NewTabContentView.js:
632         (WebInspector.NewTabContentView.prototype._updateShownTabs):
633         * UserInterface/Views/OverviewTimelineView.js:
634         (WebInspector.OverviewTimelineView.prototype._compareDataGridNodesByStartTime):
635         * UserInterface/Views/ProbeDetailsSidebarPanel.js:
636         (WebInspector.ProbeDetailsSidebarPanel.prototype.inspect):
637         * UserInterface/Views/QuickConsole.js:
638         (WebInspector.QuickConsole.prototype._compareExecutionContextPathComponents):
639         * UserInterface/Views/ResourceDetailsSidebarPanel.js:
640         (WebInspector.ResourceDetailsSidebarPanel.prototype._createNameValueDataGrid.sortDataGrid.comparator):
641         * UserInterface/Views/ResourceSidebarPanel.js:
642         (WebInspector.ResourceSidebarPanel.prototype._compareTreeElements):
643         * UserInterface/Views/ResourceTreeElement.js:
644         (WebInspector.ResourceTreeElement.compareResourceTreeElements):
645         (WebInspector.ResourceTreeElement.compareFolderAndResourceTreeElements):
646         * UserInterface/Views/ScriptDetailsTimelineView.js:
647         (WebInspector.ScriptDetailsTimelineView.prototype.dataGridSortComparator):
648         * UserInterface/Views/StorageSidebarPanel.js:
649         (WebInspector.StorageSidebarPanel.prototype._compareTreeElements):
650         * UserInterface/Views/TimelineDataGrid.js:
651         (WebInspector.TimelineDataGrid.prototype._sortComparator):
652
653 2017-06-29  Devin Rousso  <drousso@apple.com>
654
655         Web Inspector: Provide a way for creating a new tab but not making it immediately selected
656         https://bugs.webkit.org/show_bug.cgi?id=173983
657
658         Reviewed by Joseph Pecoraro.
659
660         * UserInterface/Views/TabBar.js:
661         (WebInspector.TabBar):
662         (WebInspector.TabBar.prototype.addTabBarItem):
663         (WebInspector.TabBar.prototype.insertTabBarItem):
664         (WebInspector.TabBar.prototype.removeTabBarItem):
665         (WebInspector.TabBar.prototype._handleClick):
666         (WebInspector.TabBar.prototype._handleNewTabClick):
667         * UserInterface/Views/TabBrowser.js:
668         (WebInspector.TabBrowser.prototype.addTabForContentView):
669         (WebInspector.TabBrowser.prototype.showTabForContentView):
670         (WebInspector.TabBrowser.prototype.closeTabForContentView):
671         * UserInterface/Base/Main.js:
672         (WebInspector.contentLoaded):
673         (WebInspector._openDefaultTab):
674         (WebInspector._tryToRestorePendingTabs):
675         (WebInspector.showNewTabTab):
676         (WebInspector.createNewTabWithType):
677         Add `options` dictionaries instead of optional parameters.
678
679         (WebInspector.tabContentViewClassForRepresentedObject):
680         Drive-by fix: remove incorrect placement of WebInspector.Collection check. This function
681         determines TabContentView classes, not ContentView.
682
683 2017-06-29  Devin Rousso  <drousso@apple.com>
684
685         Web Inspector: Remove unnecessary hasChildren from TreeOutline
686         https://bugs.webkit.org/show_bug.cgi?id=173986
687
688         Reviewed by Joseph Pecoraro.
689
690         * UserInterface/Views/TreeOutline.js:
691         (WebInspector.TreeOutline):
692         (WebInspector.TreeOutline.prototype.appendChild):
693         (WebInspector.TreeOutline.prototype.insertChild):
694         (WebInspector.TreeOutline.prototype.removeChildAtIndex):
695         (WebInspector.TreeOutline.prototype.removeChild):
696         (WebInspector.TreeOutline.prototype.get selectedTreeElementIndex):
697
698         * UserInterface/Views/NavigationSidebarPanel.js:
699         (WebInspector.NavigationSidebarPanel.prototype._checkOutlinesForPendingViewStateCookie):
700         * UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js:
701         (WebInspector.VisualStyleCommaSeparatedKeywordEditor.prototype.get value):
702
703 2017-06-29  Devin Rousso  <drousso@apple.com>
704
705         Web Inspector: Cleanup unused/invalid parameters for SidebarPanels
706         https://bugs.webkit.org/show_bug.cgi?id=173985
707
708         Reviewed by Joseph Pecoraro.
709
710         * UserInterface/Views/SidebarPanel.js:
711         * UserInterface/Views/NavigationSidebarPanel.js:
712         * UserInterface/Views/NavigationSidebarPanel.css:
713         (.sidebar > .panel.navigation > .overflow-shadow.top): Deleted.
714         * UserInterface/Views/DetailsSidebarPanel.js:
715
716         * UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
717         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
718         * UserInterface/Views/DOMDetailsSidebarPanel.js:
719         * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
720         * UserInterface/Views/IndexedDatabaseDetailsSidebarPanel.js:
721         * UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
722         * UserInterface/Views/ProbeDetailsSidebarPanel.js:
723         * UserInterface/Views/ResourceDetailsSidebarPanel.js:
724         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
725         * UserInterface/Views/StorageSidebarPanel.js:
726
727 2017-06-29  Devin Rousso  <drousso@apple.com>
728
729         Web Inspector: Create a single -webkit-canvas for use inside popovers
730         https://bugs.webkit.org/show_bug.cgi?id=173820
731
732         Reviewed by Matt Baker.
733
734         * UserInterface/Views/Popover.css:
735         (.popover):
736         * UserInterface/Views/Popover.js:
737         (WebInspector.Popover):
738         (WebInspector.Popover.prototype._drawBackground):
739
740 2017-06-28  Devin Rousso  <drousso@apple.com>
741
742         Web Inspector: Instrument active pixel memory used by canvases
743         https://bugs.webkit.org/show_bug.cgi?id=173087
744         <rdar://problem/32719261>
745
746         Reviewed by Joseph Pecoraro.
747
748         * .eslintrc:
749         * UserInterface/Controllers/CanvasManager.js:
750         (WebInspector.CanvasManager.prototype.canvasMemoryChanged):
751         * UserInterface/Models/Canvas.js:
752         (WebInspector.Canvas.fromPayload):
753         (WebInspector.Canvas.prototype.get memoryCost):
754         (WebInspector.Canvas.prototype.set memoryCost):
755         * UserInterface/Protocol/CanvasObserver.js:
756         (WebInspector.CanvasObserver.prototype.canvasMemoryChanged):
757         * UserInterface/Views/CanvasDetailsSidebarPanel.js:
758         (WebInspector.CanvasDetailsSidebarPanel.prototype.initialLayout):
759         (WebInspector.CanvasDetailsSidebarPanel.prototype._refreshIdentitySection):
760         (WebInspector.CanvasDetailsSidebarPanel.prototype._formatMemoryRow):
761         (WebInspector.CanvasDetailsSidebarPanel.prototype._canvasMemoryChanged):
762
763         * Localizations/en.lproj/localizedStrings.js:
764         * UserInterface/Base/Utilities.js:
765         (Number.bytesToString.value):
766         Add support for gigabyte numbers.
767
768 2017-06-27  Joseph Pecoraro  <pecoraro@apple.com>
769
770         Web Inspector: Remove unused Inspector domain events
771         https://bugs.webkit.org/show_bug.cgi?id=173905
772
773         Reviewed by Matt Baker.
774
775         * UserInterface/Protocol/InspectorObserver.js:
776         (WebInspector.InspectorObserver.prototype.detached): Deleted.
777
778         * UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js:
779         * UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js:
780         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
781         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
782         * UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
783         * UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js:
784         * Versions/Inspector-iOS-10.0.json:
785         * Versions/Inspector-iOS-10.3.json:
786         * Versions/Inspector-iOS-7.0.json:
787         * Versions/Inspector-iOS-8.0.json:
788         * Versions/Inspector-iOS-9.0.json:
789         * Versions/Inspector-iOS-9.3.json:
790         Remove from legacy backends as well since they did not send it.
791
792 2017-06-27  Matt Baker  <mattbaker@apple.com>
793
794         Web Inspector: no discoverable way to dismiss the split console
795         https://bugs.webkit.org/show_bug.cgi?id=167034
796         <rdar://problem/30023436>
797
798         Reviewed by Devin Rousso.
799
800         This patch adds an Xcode-style toggle button to the left of the
801         split console navigation bar. Additionally, the split console code
802         has been broken out into it's own class to reduce the clutter in
803         Main.js/css, and simplify future console maintenance.
804
805         * Localizations/en.lproj/localizedStrings.js:
806
807         * UserInterface/Base/Main.js:
808         (WebInspector.loaded):
809         Replace the "split" ContentBrowser with a new ConsoleDrawer class,
810         which encapsulates the drawer height setting and resize behavior.
811         (WebInspector.contentLoaded):
812         The console drawer manages its own height.
813
814         * UserInterface/Images/HideConsoleDrawer.svg: Added.
815         * UserInterface/Images/ShowConsoleDrawer.svg: Added.
816         Console drawer toggle button images. Styled after corresponding Xcode button.
817
818         * UserInterface/Main.html:
819
820         * UserInterface/Views/ConsoleDrawer.css: Added.
821         Moved old #split-content-browser styles over from Main.css.
822         (.console-drawer):
823         (.console-drawer > .navigation-bar):
824         (.console-drawer > .navigation-bar > .item.button:not(.clear-log)):
825         Make button spacing less cramped.
826         (.console-drawer > .navigation-bar > .item:not(.flexible-space)):
827         (.console-drawer > .navigation-bar > :matches(.item.button, .log-scope-bar)):
828         (.console-drawer > .navigation-bar > .item > .glyph,):
829
830         * UserInterface/Views/ConsoleDrawer.js: Added.
831         New class responsible for console drawer expand / collapse and resizer
832         dragging, which was previously part of Main.js. The console drawer toolbar
833         now has a toggle button, debugging controls, and a call frames path item.
834         The "Show Console Tab" button has been removed.
835
836         (WebInspector.ConsoleDrawer):
837         (WebInspector.ConsoleDrawer.prototype.get collapsed):
838         (WebInspector.ConsoleDrawer.prototype.set collapsed):
839         (WebInspector.ConsoleDrawer.prototype.get height):
840         (WebInspector.ConsoleDrawer.prototype.shown):
841         (WebInspector.ConsoleDrawer.prototype.layout):
842         (WebInspector.ConsoleDrawer.prototype._consoleResizerMouseDown.dockedResizerDrag):
843         (WebInspector.ConsoleDrawer.prototype._consoleResizerMouseDown.dockedResizerDragEnd):
844         (WebInspector.ConsoleDrawer.prototype._consoleResizerMouseDown):
845         (WebInspector.ConsoleDrawer.prototype._restoreDrawerHeight):
846         (WebInspector.ConsoleDrawer.prototype._updateDrawerHeight):
847         (WebInspector.ConsoleDrawer.prototype._selectedTabContentViewDidChange):
848         When switching to a tab that doesn't support showing the console drawer,
849         hide it without altering the collapsed state.
850
851         * UserInterface/Views/LogContentView.js:
852         (WebInspector.LogContentView.prototype.get navigationItems):
853
854         * UserInterface/Views/Main.css:
855         Renamed #split-content-browser to #console-drawer, and moved related
856         styles to ConsoleDrawer.css.
857
858         (#split-content-browser): Deleted.
859         (#split-content-browser > .navigation-bar): Deleted.
860         (#split-content-browser > .navigation-bar :matches(.find-banner, .find-banner + .divider)): Deleted.
861         (#split-content-browser > .navigation-bar .item): Deleted.
862         (#split-content-browser > .navigation-bar .item:not(.flexible-space)): Deleted.
863         (#split-content-browser .hierarchical-path-component.log-icon .icon): Deleted.
864         (#split-content-browser .hierarchical-path-component.log-icon .title): Deleted.
865         (#split-content-browser .hierarchical-path-component.log-icon select): Deleted.
866         (#split-content-browser > .navigation-bar > :matches(.hierarchical-path, .log-scope-bar)): Deleted.
867         (#split-content-browser > .navigation-bar > .log-scope-bar > li): Deleted.
868
869         * UserInterface/Views/QuickConsole.js:
870         (WebInspector.QuickConsole):
871         (WebInspector.QuickConsole.prototype._toggleOrFocus):
872         (WebInspector.QuickConsole.prototype._updateStyles):
873         Update top border style in response to change in selected TabBrowser
874         tab or the console drawer collapsed state.
875
876         (WebInspector.QuickConsole.prototype.consoleLogVisibilityChanged): Deleted.
877         (WebInspector.QuickConsole.prototype.set keyboardShortcutDisabled): Deleted.
878
879 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
880
881         Remove Reflect.enumerate
882         https://bugs.webkit.org/show_bug.cgi?id=173806
883
884         Reviewed by Yusuke Suzuki.
885
886         * UserInterface/Models/NativeFunctionParameters.js:
887
888 2017-06-23  Joseph Pecoraro  <pecoraro@apple.com>
889
890         Web Inspector: Script Timeline bubbles sometimes appear to miss large events
891         https://bugs.webkit.org/show_bug.cgi?id=173746
892         <rdar://problem/32950808>
893
894         Reviewed by Brian Burg.
895
896         * UserInterface/Models/Timeline.js:
897         (WebInspector.Timeline.prototype.addRecord):
898         (WebInspector.Timeline.prototype._tryInsertInSortedOrder):
899         The list of records is assumed to be sorted by the code that draws bubbles
900         however the order in which we receive them may not be sorted. Make a quick
901         effort to sort recent records so that as we are drawing the timeline it is
902         more accurate.
903
904 2017-06-23  Brian Burg  <bburg@apple.com>
905
906         Web Inspector: RTL: flip all go-to-arrow instances
907         https://bugs.webkit.org/show_bug.cgi?id=173794
908         <rdar://problem/32221912>
909
910         Reviewed by Joseph Pecoraro.
911
912         Move the flipping transform so it applies to all go-to arrows.
913
914         * UserInterface/Views/DataGrid.css:
915         (body[dir=rtl] .data-grid td .go-to-arrow):
916         * UserInterface/Views/Main.css:
917         (body[dir=rtl] .go-to-arrow):
918
919 2017-06-22  Joseph Pecoraro  <pecoraro@apple.com>
920
921         Web Inspector: Pausing with a deep call stack can be very slow, avoid eagerly generating object previews
922         https://bugs.webkit.org/show_bug.cgi?id=173698
923
924         Reviewed by Matt Baker.
925
926         Introduce RemoteObject.prototype.updatePreview which can be used to update
927         the preview of a RemoteObject with a current view for the object. Currently
928         we only use this to fetch the preview that we did not have for the `thisObject`
929         in the scope chain sidebar. However this could be used generically to update
930         a RemoteObject's preview (ObjectPreview) at any time.
931
932         * UserInterface/Protocol/RemoteObject.js:
933         (WebInspector.RemoteObject.prototype.canLoadPreview):
934         (WebInspector.RemoteObject.prototype.updatePreview):
935         Allow a RemoteObject to update its preview property. Since this only makes
936         sense on certain Object values include a helper to know when it is appropriate
937         to fetch a preview.
938
939         * UserInterface/Views/ObjectTreePropertyTreeElement.js:
940         (WebInspector.ObjectTreePropertyTreeElement.prototype._createTitlePropertyStyle):
941         (WebInspector.ObjectTreePropertyTreeElement.prototype._loadPreviewLazilyIfNeeded):
942         If the object being shown in the sidebar does not have a preview but can load a
943         preview then attempt to load it lazily. This is the case for the `thisObject`
944         which is injected into an ObjectTree in the scope chain sidebar.
945
946 2017-06-22  Fujii Hironori  <Hironori.Fujii@sony.com>
947
948         [GTK] Web Inspector: Add icon for Canvas.svg
949         https://bugs.webkit.org/show_bug.cgi?id=173580
950
951         Reviewed by Carlos Garcia Campos.
952
953         * UserInterface/Images/gtk/Canvas.svg: Added.
954
955 2017-06-21  Fujii Hironori  <Hironori.Fujii@sony.com>
956
957         [GTK] Web Inspector: Add NavigationItemCheckers.svg
958         https://bugs.webkit.org/show_bug.cgi?id=173692
959
960         Reviewed by Carlos Garcia Campos.
961
962         * UserInterface/Images/gtk/NavigationItemCheckers.svg: Added.
963
964 2017-06-20  Devin Rousso  <drousso@apple.com>
965
966         Web Inspector: change the selected ScopeBarItem on mousedown instead of click
967         https://bugs.webkit.org/show_bug.cgi?id=173586
968
969         Reviewed by Matt Baker.
970
971         Both the Tab bar and Sidebar navigation bar switch the active item on "mousedown" instead of
972         on "click". ScopeBarItem should follow this pattern, as it is faster and keeps consistency.
973
974         * UserInterface/Views/MultipleScopeBarItem.js:
975         (WebInspector.MultipleScopeBarItem):
976         (WebInspector.MultipleScopeBarItem.prototype._handleMouseDown):
977         (WebInspector.MultipleScopeBarItem.prototype._clicked): Deleted.
978         * UserInterface/Views/ScopeBarItem.js:
979         (WebInspector.ScopeBarItem):
980         (WebInspector.ScopeBarItem.prototype._handleMouseDown):
981         (WebInspector.ScopeBarItem.prototype._clicked): Deleted.
982
983 2017-06-20  Devin Rousso  <drousso@apple.com>
984
985         Web Inspector: Send context attributes for tracked canvases
986         https://bugs.webkit.org/show_bug.cgi?id=173327
987
988         Reviewed by Joseph Pecoraro.
989
990         * UserInterface/Models/Canvas.js:
991         (WebInspector.Canvas.fromPayload):
992         (WebInspector.Canvas.prototype.get contextAttributes):
993         * UserInterface/Views/CanvasDetailsSidebarPanel.js:
994         (WebInspector.CanvasDetailsSidebarPanel.prototype.initialLayout):
995         (WebInspector.CanvasDetailsSidebarPanel.prototype.layout):
996         (WebInspector.CanvasDetailsSidebarPanel.prototype.sizeDidChange):
997         (WebInspector.CanvasDetailsSidebarPanel.prototype._refreshAttributesSection):
998
999         * UserInterface/Views/DataGridNode.js:
1000         (WebInspector.DataGridNode.prototype.createCellContent):
1001         Instead of checking if the value of the cell is falsy, check that the key exists in the data.
1002         This allows values like `false` to be displayed.
1003
1004 2017-06-19  Devin Rousso  <drousso@apple.com>
1005
1006         Web Inspector: create canvas content view and details sidebar panel
1007         https://bugs.webkit.org/show_bug.cgi?id=138941
1008         <rdar://problem/19051672>
1009
1010         Reviewed by Joseph Pecoraro.
1011
1012         * UserInterface/Models/Canvas.js:
1013         (WebInspector.Canvas):
1014         (WebInspector.Canvas.fromPayload):
1015         (WebInspector.Canvas.prototype.get displayName):
1016         (WebInspector.Canvas.requestNode): Added.
1017         (WebInspector.Canvas.prototype.requestContent): Added.
1018         (WebInspector.Canvas.prototype.saveIdentityToCookie):
1019
1020         * UserInterface/Controllers/CanvasManager.js:
1021         (WebInspector.CanvasManager.prototype.canvasAdded):
1022         (WebInspector.CanvasManager.prototype.canvasRemoved):
1023         * UserInterface/Models/Collection.js:
1024         * UserInterface/Models/Frame.js:
1025         (WebInspector.Frame):
1026         (WebInspector.Frame.prototype.get canvasCollection):
1027         (WebInspector.Frame.prototype.commitProvisionalLoad):
1028         Create a Collection for Canvas in each Frame, and modify it when canvas events are fired.
1029
1030         * UserInterface/Views/CanvasContentView.css: Added.
1031         (.content-view.canvas > .preview):
1032         (.content-view.canvas > .preview > img):
1033         * UserInterface/Views/CanvasContentView.js: Added.
1034         (WebInspector.CanvasContentView):
1035         (WebInspector.CanvasContentView.prototype.get navigationItems):
1036         (WebInspector.CanvasContentView.prototype.shown):
1037         (WebInspector.CanvasContentView.prototype.hidden):
1038         (WebInspector.CanvasContentView.prototype._showPreview):
1039         (WebInspector.CanvasContentView.prototype._updateImageGrid):
1040         (WebInspector.CanvasContentView.prototype._showGridButtonClicked):
1041         * UserInterface/Views/CanvasDetailsSidebarPanel.js: Added.
1042         (WebInspector.CanvasDetailsSidebarPanel):
1043         (WebInspector.CanvasDetailsSidebarPanel.prototype.inspect):
1044         (WebInspector.CanvasDetailsSidebarPanel.prototype.get canvas):
1045         (WebInspector.CanvasDetailsSidebarPanel.prototype.set canvas):
1046         (WebInspector.CanvasDetailsSidebarPanel.prototype.initialLayout):
1047         (WebInspector.CanvasDetailsSidebarPanel.prototype.layout):
1048         (WebInspector.CanvasDetailsSidebarPanel.prototype._refreshIdentitySection):
1049         (WebInspector.CanvasDetailsSidebarPanel.prototype._refreshSourceSection.this._canvas.requestNode.):
1050         (WebInspector.CanvasDetailsSidebarPanel.prototype._refreshSourceSection):
1051         * UserInterface/Views/CanvasTreeElement.js: Added.
1052         (WebInspector.CanvasTreeElement):
1053
1054         * UserInterface/Views/FrameTreeElement.js:
1055         (WebInspector.FrameTreeElement.prototype.onattach):
1056         (WebInspector.FrameTreeElement.prototype.ondetach):
1057         (WebInspector.FrameTreeElement.prototype.onpopulate):
1058         (WebInspector.FrameTreeElement.prototype._canvasWasAdded):
1059         (WebInspector.FrameTreeElement.prototype._canvasWasRemoved):
1060         (WebInspector.FrameTreeElement):
1061         * UserInterface/Base/Main.js:
1062         * UserInterface/Views/ContentView.js:
1063         (WebInspector.ContentView.createFromRepresentedObject):
1064         (WebInspector.ContentView.isViewable):
1065         * UserInterface/Views/ResourceSidebarPanel.js:
1066         (WebInspector.ResourceSidebarPanel):
1067         (WebInspector.ResourceSidebarPanel.prototype.matchTreeElementAgainstCustomFilters.match):
1068         (WebInspector.ResourceSidebarPanel.prototype._treeSelectionDidChange):
1069         * UserInterface/Views/ResourcesTabContentView.js:
1070         (WebInspector.ResourcesTabContentView):
1071         (WebInspector.ResourcesTabContentView.prototype.canShowRepresentedObject):
1072         Show Canvas objects and tie them to the correct ContentView and TreeElement subclasses.
1073
1074         * Localizations/en.lproj/localizedStrings.js:
1075         * UserInterface/Main.html:
1076         * UserInterface/Images/Canvas.svg: Added.
1077         * UserInterface/Views/ResourceIcons.css:
1078         (.canvas .icon):
1079         Added new files/rules/strings related to Canvas UI.
1080
1081         * UserInterface/Views/SettingsTabContentView.css:
1082         (.content-view.settings .navigation-bar):
1083
1084         * UserInterface/Base/Setting.js:
1085         * UserInterface/Views/SettingsTabContentView.js:
1086         (WebInspector.SettingsTabContentView.prototype.initialLayout):
1087         (WebInspector.SettingsTabContentView.prototype._createGeneralSettingsView):
1088         (WebInspector.SettingsTabContentView.prototype._createDebugSettingsView):
1089         Add an experimental settings toggle in the Debug view for showing canvas contexts.
1090
1091         * UserInterface/Views/FolderizedTreeElement.js:
1092         (WebInspector.FolderizedTreeElement.prototype._compareTreeElementsByMainTitle):
1093         Drive-by fix: ensure that sorting also includes numbers, so that 1 < 2 < 10.
1094
1095         * UserInterface/Views/ImageResourceContentView.js:
1096         (WebInspector.ImageResourceContentView.prototype.shown):
1097         (WebInspector.ImageResourceContentView.prototype.hidden):
1098         (WebInspector.ImageResourceContentView.prototype._updateImageGrid):
1099         (WebInspector.ImageResourceContentView.prototype._showGridButtonClicked):
1100         (WebInspector.ImageResourceContentView):
1101         Drive-by fix: change the activated state of the Show Grid navigation item if it changes
1102         in another view.
1103
1104 2017-06-19  Devin Rousso  <drousso@apple.com>
1105
1106         Web Inspector: Unify contextmenu items for all node links/previews
1107         https://bugs.webkit.org/show_bug.cgi?id=173187
1108
1109         Reviewed by Joseph Pecoraro.
1110
1111         * Localizations/en.lproj/localizedStrings.js:
1112         * UserInterface/Views/ContextMenuUtilities.js:
1113         (WebInspector.appendContextMenuItemsForDOMNode.didGetFunctionDetails): Added.
1114         (WebInspector.appendContextMenuItemsForDOMNode.didGetProperty): Added.
1115         (WebInspector.appendContextMenuItemsForDOMNode.didResolveNode): Added.
1116         (WebInspector.appendContextMenuItemsForDOMNode): Added.
1117         * UserInterface/Views/DOMTreeElement.js:
1118         (WebInspector.DOMTreeElement.prototype._populateTagContextMenu):
1119         (WebInspector.DOMTreeElement.prototype._populateNodeContextMenu):
1120         (WebInspector.DOMTreeElement.prototype._showCustomElementDefinition): Deleted.
1121         * UserInterface/Views/DOMTreeOutline.js:
1122         (WebInspector.DOMTreeOutline.prototype.populateContextMenu):
1123         (WebInspector.DOMTreeOutline.prototype._populateContextMenu.revealElement): Deleted.
1124         (WebInspector.DOMTreeOutline.prototype._populateContextMenu.logElement): Deleted.
1125         (WebInspector.DOMTreeOutline.prototype._populateContextMenu): Deleted.
1126         * UserInterface/Views/RulesStyleDetailsPanel.js:
1127         (WebInspector.RulesStyleDetailsPanel.prototype.refresh.insertMediaOrInheritanceLabel):
1128         Unify common DOM node context menu actions into a single helper function.
1129
1130         * UserInterface/Base/DOMUtilities.js:
1131         (WebInspector.linkifyNodeReference):
1132         (WebInspector.linkifyNodeReferenceElement):
1133         Rework parameters to use options dictionary.
1134
1135 2017-06-16  Matt Baker  <mattbaker@apple.com>
1136
1137         Web Inspector: Instrument 2D/WebGL canvas contexts in the backend
1138         https://bugs.webkit.org/show_bug.cgi?id=172623
1139         <rdar://problem/32415986>
1140
1141         Reviewed by Devin Rousso and Joseph Pecoraro.
1142
1143         * UserInterface/Base/Main.js:
1144         (WebInspector.loaded):
1145
1146         * UserInterface/Controllers/CanvasManager.js: Added.
1147         New frontend manager for the Canvas domain.
1148         (WebInspector.CanvasManager):
1149         (WebInspector.CanvasManager.prototype.get canvases):
1150         (WebInspector.CanvasManager.prototype.canvasAdded):
1151         (WebInspector.CanvasManager.prototype.canvasRemoved):
1152         (WebInspector.CanvasManager.prototype._mainResourceDidChange):
1153
1154         * UserInterface/Main.html:
1155         New files.
1156
1157         * UserInterface/Models/Canvas.js: Added.
1158         (WebInspector.Canvas):
1159         (WebInspector.Canvas.fromPayload):
1160         (WebInspector.Canvas.displayNameForContextType):
1161         Get displayable text "2D" or "WebGL" based on context type.
1162         (WebInspector.Canvas.resetUniqueDisplayNameNumbers):
1163         Called by CanvasManager when canvases are cleared.
1164         (WebInspector.Canvas.prototype.get identifier):
1165         (WebInspector.Canvas.prototype.get contextType):
1166         (WebInspector.Canvas.prototype.get frame):
1167         (WebInspector.Canvas.prototype.get cssCanvasName):
1168         For CSS canvases, the identifier passed to getCSSCanvasContext.
1169         (WebInspector.Canvas.prototype.get displayName):
1170         Get displayable canvas name. The name depends on how the canvas was
1171         created, and the information available:
1172           - getCSSCanvasContext: "CSS Canvas <identifier>"
1173           - getContext: "Canvas #<DOM id attribute value>"
1174           - Otherwise: "Canvas 1", "Canvas 2", ...
1175
1176         (WebInspector.Canvas.saveIdentityToCookie):
1177
1178         * UserInterface/Protocol/CanvasObserver.js: Added.
1179         (WebInspector.CanvasObserver.prototype.canvasAdded):
1180         (WebInspector.CanvasObserver.prototype.canvasRemoved):
1181         (WebInspector.CanvasObserver):
1182
1183         * UserInterface/Test.html:
1184         * UserInterface/Test/Test.js:
1185         (WebInspector.loaded):
1186
1187 2017-06-16  Matt Lewis  <jlewis3@apple.com>
1188
1189         Unreviewed, rolling out r218376.
1190
1191         The patch cause multiple Layout Test Crashes.
1192
1193         Reverted changeset:
1194
1195         "Web Inspector: Instrument 2D/WebGL canvas contexts in the
1196         backend"
1197         https://bugs.webkit.org/show_bug.cgi?id=172623
1198         http://trac.webkit.org/changeset/218376
1199
1200 2017-06-15  Matt Baker  <mattbaker@apple.com>
1201
1202         Web Inspector: Instrument 2D/WebGL canvas contexts in the backend
1203         https://bugs.webkit.org/show_bug.cgi?id=172623
1204         <rdar://problem/32415986>
1205
1206         Reviewed by Devin Rousso.
1207
1208         * UserInterface/Base/Main.js:
1209         (WebInspector.loaded):
1210
1211         * UserInterface/Controllers/CanvasManager.js: Added.
1212         New frontend manager for the Canvas domain.
1213         (WebInspector.CanvasManager):
1214         (WebInspector.CanvasManager.prototype.get canvases):
1215         (WebInspector.CanvasManager.prototype.canvasAdded):
1216         (WebInspector.CanvasManager.prototype.canvasRemoved):
1217         (WebInspector.CanvasManager.prototype._mainResourceDidChange):
1218
1219         * UserInterface/Main.html:
1220         New files.
1221
1222         * UserInterface/Models/Canvas.js: Added.
1223         (WebInspector.Canvas):
1224         (WebInspector.Canvas.fromPayload):
1225         (WebInspector.Canvas.displayNameForContextType):
1226         Get displayable text "2D" or "WebGL" based on context type.
1227         (WebInspector.Canvas.resetUniqueDisplayNameNumbers):
1228         Called by CanvasManager when canvases are cleared.
1229         (WebInspector.Canvas.prototype.get identifier):
1230         (WebInspector.Canvas.prototype.get contextType):
1231         (WebInspector.Canvas.prototype.get frame):
1232         (WebInspector.Canvas.prototype.get cssCanvasName):
1233         For CSS canvases, the identifier passed to getCSSCanvasContext.
1234         (WebInspector.Canvas.prototype.get displayName):
1235         Get displayable canvas name. The name depends on how the canvas was
1236         created, and the information available:
1237           - getCSSCanvasContext: "CSS Canvas <identifier>"
1238           - getContext: "Canvas #<DOM id attribute value>"
1239           - Otherwise: "Canvas 1", "Canvas 2", ...
1240
1241         (WebInspector.Canvas.saveIdentityToCookie):
1242
1243         * UserInterface/Protocol/CanvasObserver.js: Added.
1244         (WebInspector.CanvasObserver.prototype.canvasAdded):
1245         (WebInspector.CanvasObserver.prototype.canvasRemoved):
1246         (WebInspector.CanvasObserver):
1247
1248         * UserInterface/Test.html:
1249         * UserInterface/Test/Test.js:
1250         (WebInspector.loaded):
1251
1252 2017-06-15  Joseph Pecoraro  <pecoraro@apple.com>
1253
1254         Web Inspector: Search highlight doesn't show up in resources when paused
1255         https://bugs.webkit.org/show_bug.cgi?id=173438
1256         <rdar://problem/32800114>
1257
1258         Reviewed by Matt Baker.
1259
1260         * UserInterface/Views/TextEditor.js:
1261         (WebInspector.TextEditor.prototype.revealPosition.revealAndHighlightLine):
1262         Previously we were bailing if executionLineNumber was NaN, which means that when
1263         we were paused we were incorrectly disabling highlights in any resource that does
1264         not have the active callframe. Relax this and make it match the intended behavior
1265         of only disabling highlights if the highlight line matches the execution line.
1266
1267 2017-06-15  Joseph Pecoraro  <pecoraro@apple.com>
1268
1269         Uncaught Exception: TypeError: null is not an object (evaluating 'this.contentBrowser.contentViewForRepresentedObject')
1270         https://bugs.webkit.org/show_bug.cgi?id=173425
1271         <rdar://problem/32744172>
1272
1273         Reviewed by Devin Rousso.
1274
1275         * UserInterface/Views/ContentBrowserTabContentView.js:
1276         (WebInspector.ContentBrowserTabContentView.prototype.shown):
1277         Reorder slightly so the NavigationSidebar has its ContentBrowser set
1278         before anyone tries to restore views in the sidebar.
1279
1280         * UserInterface/Views/DebuggerSidebarPanel.js:
1281         (WebInspector.DebuggerSidebarPanel.prototype.showDefaultContentView):
1282         Try to select a script/resource content view instead of nothing.
1283
1284         (WebInspector.DebuggerSidebarPanel.prototype.saveStateToCookie):
1285         When a resource is selected, save it using the normal path.
1286
1287         * UserInterface/Views/NetworkSidebarPanel.js:
1288         (WebInspector.NetworkSidebarPanel.prototype.canShowDifferentContentView):
1289         Remove a reference to an unused / stale member variable.
1290
1291 2017-06-14  Nikita Vasilyev  <nvasilyev@apple.com>
1292
1293         Web Inspector: Pretty print / type info / code coverage buttons disappear after switching tabs
1294         https://bugs.webkit.org/show_bug.cgi?id=162515
1295         <rdar://problem/28455322>
1296
1297         Reviewed by Joseph Pecoraro.
1298
1299         Each ContentView owns a list of NavigationItems. When the ContentView moves across
1300         Tabs (ContentBrowsers) it removes its NavigationItems from the old Tab's NavigationBar
1301         and adds them to the new Tab's NavigationBar. When switching back to the original tab
1302         the ContentView is restored, but its NavigationItems are not carried back.
1303
1304         * UserInterface/Views/ContentBrowser.js:
1305         (WebInspector.ContentBrowser.prototype._updateContentViewNavigationItems):
1306         Add a forceUpdate parameter that is needed when navigationItems are unchanged but navigationBar is
1307         different.
1308
1309         (WebInspector.ContentBrowser.prototype._removeAllNavigationItems):
1310         Remove navigation items even when their navigationBar is no longer a current navigationBar,
1311         e.g. a navigationBar of the previous tab.
1312
1313         (WebInspector.ContentBrowser.prototype._contentViewNavigationItemsDidChange):
1314         * UserInterface/Views/ContentViewContainer.js:
1315         (WebInspector.ContentViewContainer.prototype._takeOwnershipOfContentView):
1316
1317 2017-06-14  Devin Rousso  <drousso@apple.com>
1318
1319         Web Inspector: REGRESSION: SVG files and favicon don't display properly
1320         https://bugs.webkit.org/show_bug.cgi?id=173389
1321         <rdar://problem/32774281>
1322
1323         Reviewed by Joseph Pecoraro.
1324
1325         * UserInterface/Views/ImageResourceContentView.css:
1326         (.content-view.resource.image img):
1327         Don't set a `min-width` as it has odd interactions with flexbox.
1328
1329 2017-06-13  Nikita Vasilyev  <nvasilyev@apple.com>
1330
1331         Web Inspector: Console: Message icons overlay source location
1332         https://bugs.webkit.org/show_bug.cgi?id=173291
1333
1334         Reviewed by Matt Baker.
1335
1336         * UserInterface/Views/ConsoleMessageView.css:
1337         (.console-message-location.call-frame):
1338         This should be a safe change since a method name and a source link already have
1339         max-width set to 20vw and 30vw respectively.
1340
1341 2017-06-13  Nikita Vasilyev  <nvasilyev@apple.com>
1342
1343         Web Inspector: Don't use -webkit-user-modify CSS property
1344         https://bugs.webkit.org/show_bug.cgi?id=173232
1345
1346         Reviewed by Devin Rousso.
1347
1348         Replace -webkit-user-modify CSS property with contentEditable HTML attribute.
1349
1350         * UserInterface/Views/Editing.css:
1351         (.editing):
1352         * UserInterface/Views/EditingSupport.js:
1353         (cleanUpAfterEditing):
1354         * UserInterface/Views/VisualStyleSelectorTreeItem.css:
1355         (.item.visual-style-selector-item:not(.dom-element-icon).editable > .titles > .title):
1356         * UserInterface/Views/VisualStyleSelectorTreeItem.js:
1357         (WebInspector.VisualStyleSelectorTreeItem.prototype.ondeselect):
1358         (WebInspector.VisualStyleSelectorTreeItem.prototype._handleMainTitleMouseDown):
1359         (WebInspector.VisualStyleSelectorTreeItem.prototype._commitSelector):
1360
1361 2017-06-13  Sam Weinig  <sam@webkit.org>
1362
1363         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
1364         https://bugs.webkit.org/show_bug.cgi?id=80733
1365
1366         Reviewed by Chris Dumez.
1367
1368         * UserInterface/Workers/HeapSnapshot/HeapSnapshot.js:
1369         (HeapSnapshot.prototype._isNodeGlobalObject):
1370
1371 2017-06-12  Devin Rousso  <drousso@apple.com>
1372
1373         Web Inspector: Add grid to images to clarify transparency and image size
1374         https://bugs.webkit.org/show_bug.cgi?id=173184
1375
1376         Reviewed by Matt Baker.
1377
1378         * Localizations/en.lproj/localizedStrings.js:
1379
1380         * UserInterface/Base/Setting.js:
1381         Add setting for controlling the image grid.
1382
1383         * UserInterface/Images/NavigationItemCheckers.svg: Added.
1384
1385         * UserInterface/Views/ImageResourceContentView.css:
1386         (.content-view.resource.image):
1387         (.content-view.resource.image img):
1388         Replace the border spacing around the image with padding on the container.  This is required
1389         because a border will extend the area that is effected by `background-image`, meaning that
1390         the checkerboard would appear in that area as well, giving misleading information as to the
1391         size of the image.
1392
1393         * UserInterface/Views/ImageResourceContentView.js:
1394         (WebInspector.ImageResourceContentView):
1395         (WebInspector.ImageResourceContentView.prototype.get navigationItems): Added.
1396         (WebInspector.ImageResourceContentView.prototype.contentAvailable):
1397         (WebInspector.ImageResourceContentView.prototype.shown): Added.
1398         (WebInspector.ImageResourceContentView.prototype._toggleImageGrid): Added.
1399         (WebInspector.ImageResourceContentView.prototype._showGridButtonClicked): Added.
1400         (WebInspector.ImageResourceContentView.prototype.get imageElement): Deleted.
1401         Apply the CSS class for showing the grid when the added navigation item is activated.
1402
1403         * UserInterface/Views/Main.css:
1404         (img.show-grid):
1405         Generates a checkerboard pattern via `background-image` using the following process:
1406          - four `linear-gradients` are drawn, one in each corner
1407          - each draws one half of a 20x20 square, specified by `background-size`
1408          - they are then repositioned using `background-position` so that the two halfs align
1409             +------+      \--2
1410             |1 /\ 2|      |\ |
1411             | /  \ |  =>  | \|
1412             |/    \|  =>  4--\
1413             |\    /|  =>      1--/
1414             | \  / |  =>      | /|
1415             |4 \/ 3|          |/ |
1416             +------+          /--3
1417
1418 2017-06-10  Dan Bernstein  <mitz@apple.com>
1419
1420         Reverted r218056 because it made the IDE reindex constantly.
1421
1422         * Configurations/DebugRelease.xcconfig:
1423
1424 2017-06-10  Dan Bernstein  <mitz@apple.com>
1425
1426         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
1427         https://bugs.webkit.org/show_bug.cgi?id=173223
1428
1429         Reviewed by Sam Weinig.
1430
1431         The rebuilds were happening due to a difference in the compiler options that the IDE and
1432         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
1433         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
1434         specify an appropriate path in CLANG_INDEX_STORE_PATH.
1435
1436         * Configurations/DebugRelease.xcconfig:
1437
1438 2017-06-10  Devin Rousso  <drousso@apple.com>
1439
1440         Web Inspector: REGRESSION(r217749): Event listeners are removed even if they haven't been added
1441         https://bugs.webkit.org/show_bug.cgi?id=173185
1442
1443         Reviewed by Joseph Pecoraro.
1444
1445         * UserInterface/Views/ResourceDetailsSidebarPanel.js:
1446         (WebInspector.ResourceDetailsSidebarPanel):
1447         (WebInspector.ResourceDetailsSidebarPanel.prototype.set resource):
1448         (WebInspector.ResourceDetailsSidebarPanel.prototype._applyResourceEventListeners):
1449         Maintain a member variable flag such that event listeners are only removed if it is true.
1450         It is only set to true once the event listeners are added.
1451
1452 2017-06-09  Devin Rousso  <drousso@apple.com>
1453
1454         Web Inspector: REGRESSION(r217258): Misspelled variable names
1455         https://bugs.webkit.org/show_bug.cgi?id=173189
1456
1457         Reviewed by Joseph Pecoraro.
1458
1459         * UserInterface/Base/Main.js:
1460         (WebInspector.tabContentViewClassForRepresentedObject):
1461         * UserInterface/Views/ResourceIcons.css:
1462         (.large :matches(.resource-icon.resource-type-stylesheet, .stylesheet-icon) .icon):
1463         (.large .resource-icon.resource-type-stylesheet .icon): Deleted.
1464
1465 2017-06-09  Joseph Pecoraro  <pecoraro@apple.com>
1466
1467         Web Inspector: Web inspector does not show non-shadow children of an element with a shadow root (e.g. <video>)
1468         https://bugs.webkit.org/show_bug.cgi?id=173121
1469         <rdar://problem/30948943>
1470
1471         Reviewed by Matt Baker.
1472
1473         * UserInterface/Models/DOMNode.js:
1474         (WebInspector.DOMNode):
1475         Only populate _children when we have both the shadowRoots and
1476         actual children payloads. Backends always send shadowRoots but
1477         only send children when requested. So if we have shadowRoots
1478         but expect actual children, don't populate _children until we
1479         request the child nodes.
1480
1481 2017-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1482
1483         Remove legacy INSPECTOR_SERVER implementation
1484         https://bugs.webkit.org/show_bug.cgi?id=172966
1485
1486         Reviewed by Žan Doberšek.
1487
1488         Remove InspectorFrontendHostStub and thr web sockets initialization.
1489
1490         * UserInterface/Base/InspectorFrontendHostStub.js: Removed.
1491         * UserInterface/Base/Main.js:
1492         (WebInspector.loaded):
1493         * UserInterface/Main.html:
1494         * UserInterface/Test.html:
1495         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
1496         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
1497
1498 2017-06-07  Devin Rousso  <drousso@apple.com>
1499
1500         Web Inspector: Add ContextMenu item to log WebSocket object to console
1501         https://bugs.webkit.org/show_bug.cgi?id=172878
1502
1503         Reviewed by Joseph Pecoraro.
1504
1505         * Localizations/en.lproj/localizedStrings.js:
1506
1507         * UserInterface/Protocol/RemoteObject.js:
1508         (WebInspector.RemoteObject.resolveWebSocket):
1509
1510         * UserInterface/Views/ResourceTreeElement.js:
1511         (WebInspector.ResourceTreeElement.prototype.populateContextMenu):
1512
1513 2017-06-07  Devin Rousso  <drousso@apple.com>
1514
1515         Web Inspector: Allow user to choose stylesheet when creating new rules
1516         https://bugs.webkit.org/show_bug.cgi?id=172487
1517
1518         Reviewed by Joseph Pecoraro.
1519
1520         * Localizations/en.lproj/localizedStrings.js:
1521         * UserInterface/Models/DOMNodeStyles.js:
1522         (WebInspector.DOMNodeStyles.prototype.addRule.inspectorStyleSheetAvailable):
1523         (WebInspector.DOMNodeStyles.prototype.addRule):
1524         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
1525         (WebInspector.CSSStyleDetailsSidebarPanel.prototype.initialLayout):
1526         (WebInspector.CSSStyleDetailsSidebarPanel.prototype._newRuleButtonContextMenu):
1527         * UserInterface/Views/RulesStyleDetailsPanel.js:
1528         (WebInspector.RulesStyleDetailsPanel.prototype.newRuleButtonClicked):
1529         (WebInspector.RulesStyleDetailsPanel.prototype.newRuleButtonContextMenu):
1530         * UserInterface/Views/VisualStyleSelectorSection.js:
1531         (WebInspector.VisualStyleSelectorSection):
1532         (WebInspector.VisualStyleSelectorSection.prototype._addNewRuleContextMenu):
1533         (WebInspector.VisualStyleSelectorSection.prototype._addNewRule): Renamed _addNewRuleClick.
1534
1535 2017-06-06  Joseph Pecoraro  <pecoraro@apple.com>
1536
1537         Unreviewed rollout r217807. Caused a test to crash.
1538
1539         * UserInterface/Proxies/HeapSnapshotNodeProxy.js:
1540         (WebInspector.HeapSnapshotNodeProxy):
1541         (WebInspector.HeapSnapshotNodeProxy.deserialize):
1542         * UserInterface/Views/HeapSnapshotClassDataGridNode.js:
1543         (WebInspector.HeapSnapshotClassDataGridNode.prototype.createCellContent):
1544         * UserInterface/Views/HeapSnapshotClusterContentView.js:
1545         (WebInspector.HeapSnapshotClusterContentView.iconStyleClassNameForClassName):
1546         * UserInterface/Views/HeapSnapshotDataGridTree.js:
1547         (WebInspector.HeapSnapshotInstancesDataGridTree.prototype.populateTopLevel):
1548         * UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:
1549         (WebInspector.HeapSnapshotInstanceDataGridNode.prototype.createCellContent):
1550         (WebInspector.HeapSnapshotInstanceDataGridNode.prototype._mouseoverHandler.appendPathRow):
1551         * UserInterface/Workers/HeapSnapshot/HeapSnapshot.js:
1552         (HeapSnapshot):
1553         (HeapSnapshot.updateCategoriesAndMetadata):
1554         (HeapSnapshot.prototype.serializeNode):
1555         (HeapSnapshot.prototype._gcRootPathes.visitNode):
1556         (HeapSnapshot.prototype._gcRootPathes):
1557
1558 2017-06-05  Joseph Pecoraro  <pecoraro@apple.com>
1559
1560         Web Inspector: Improve ES6 Class instances in Heap Snapshot instances view
1561         https://bugs.webkit.org/show_bug.cgi?id=172848
1562         <rdar://problem/25709212>
1563
1564         Reviewed by Saam Barati.
1565
1566         * UserInterface/Workers/HeapSnapshot/HeapSnapshot.js:
1567         (HeapSnapshot):
1568         Support the new snapshot version. The only thing that changes are the
1569         node flags, and its actually completely compatible with version 1.
1570
1571         (HeapSnapshot.updateCategoriesAndMetadata):
1572         List the count of object type instances in each class category.
1573
1574         (HeapSnapshot.prototype.serializeNode):
1575         Include whether or not the node is an object type.
1576
1577         * UserInterface/Proxies/HeapSnapshotNodeProxy.js:
1578         (WebInspector.HeapSnapshotNodeProxy):
1579         (WebInspector.HeapSnapshotNodeProxy.deserialize):
1580         Add a new Node isObjectType property based on the new data.
1581
1582         * UserInterface/Views/HeapSnapshotClassDataGridNode.js:
1583         (WebInspector.HeapSnapshotClassDataGridNode.prototype.createCellContent):
1584         * UserInterface/Views/HeapSnapshotClusterContentView.js:
1585         (WebInspector.HeapSnapshotClusterContentView.iconStyleClassNameForClassName):
1586         If a class contains 50% or more object type instances then it as such
1587         instead of defaulting to native.
1588
1589         * UserInterface/Views/HeapSnapshotDataGridTree.js:
1590         (WebInspector.HeapSnapshotInstancesDataGridTree.prototype.populateTopLevel):
1591         * UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:
1592         (WebInspector.HeapSnapshotInstanceDataGridNode.prototype.createCellContent):
1593         We can be more specific than the default if the individual instance is
1594         known to be an object type.
1595
1596 2017-06-02  Devin Rousso  <drousso@apple.com>
1597
1598         Web Inspector: Don't create NavigationSidebarPanel classes until they are needed by a Tab
1599         https://bugs.webkit.org/show_bug.cgi?id=172621
1600
1601         Reviewed by Timothy Hatcher.
1602
1603         * UserInterface/Views/ContentBrowserTabContentView.js:
1604         (WebInspector.ContentBrowserTabContentView):
1605         (WebInspector.ContentBrowserTabContentView.prototype.shown):
1606         * UserInterface/Views/TabContentView.js:
1607         (WebInspector.TabContentView):
1608         (WebInspector.TabContentView.prototype.get navigationSidebarPanel):
1609
1610         * UserInterface/Views/NetworkTabContentView.js:
1611         (WebInspector.NetworkTabContentView.prototype.canShowRepresentedObject):
1612         * UserInterface/Views/SearchTabContentView.js:
1613         (WebInspector.SearchTabContentView.prototype.canShowRepresentedObject):
1614         Use public getter for navigationSidebarPanel.
1615
1616         * UserInterface/Views/ResourceSidebarPanel.js:
1617         (WebInspector.ResourceSidebarPanel):
1618         (WebInspector.ResourceSidebarPanel.prototype.initialLayout): Added.
1619         Load information about the current frame once the sidebar panel is displayed.
1620
1621 2017-06-02  Devin Rousso  <drousso@apple.com>
1622
1623         Web Inspector: Use initialLayout for DetailsSidebarPanel classes
1624         https://bugs.webkit.org/show_bug.cgi?id=172381
1625
1626         Reviewed by Timothy Hatcher.
1627
1628         * UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
1629         (WebInspector.ApplicationCacheDetailsSidebarPanel):
1630         (WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.initialLayout): Added.
1631         (WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.layout):
1632         * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
1633         (WebInspector.DOMNodeDetailsSidebarPanel):
1634         (WebInspector.DOMNodeDetailsSidebarPanel.prototype.initialLayout): Added.
1635         (WebInspector.DOMNodeDetailsSidebarPanel.prototype.layout):
1636         * UserInterface/Views/IndexedDatabaseDetailsSidebarPanel.js:
1637         (WebInspector.IndexedDatabaseDetailsSidebarPanel):
1638         (WebInspector.IndexedDatabaseDetailsSidebarPanel.prototype.initialLayout): Added.
1639         (WebInspector.IndexedDatabaseDetailsSidebarPanel.prototype.layout):
1640         * UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
1641         (WebInspector.LayerTreeDetailsSidebarPanel):
1642         (WebInspector.LayerTreeDetailsSidebarPanel.prototype.initialLayout): Added.
1643         (WebInspector.LayerTreeDetailsSidebarPanel.prototype.layout):
1644         * UserInterface/Views/ProbeDetailsSidebarPanel.js:
1645         (WebInspector.ProbeDetailsSidebarPanel):
1646         (WebInspector.ProbeDetailsSidebarPanel.prototype.initialLayout): Added.
1647         * UserInterface/Views/ResourceDetailsSidebarPanel.js:
1648         (WebInspector.ResourceDetailsSidebarPanel):
1649         (WebInspector.ResourceDetailsSidebarPanel.prototype.set resource):
1650         (WebInspector.ResourceDetailsSidebarPanel.prototype.initialLayout): Added.
1651         (WebInspector.ResourceDetailsSidebarPanel.prototype.layout):
1652         (WebInspector.ResourceDetailsSidebarPanel.prototype._applyResourceEventListeners):
1653
1654 2017-06-02  Devin Rousso  <drousso@apple.com>
1655
1656         Web Inspector: The CodeMirror instance in the ConsolePrompt does't need to be refreshed each time it is shown
1657         https://bugs.webkit.org/show_bug.cgi?id=172608
1658
1659         Reviewed by Timothy Hatcher.
1660
1661         * UserInterface/Views/ConsolePrompt.js:
1662         (WebInspector.ConsolePrompt.prototype.shown): Deleted.
1663         * UserInterface/Views/DatabaseContentView.js:
1664         (WebInspector.DatabaseContentView.prototype.shown): Deleted.
1665         * UserInterface/Views/QuickConsole.js:
1666         (WebInspector.QuickConsole):
1667
1668 2017-06-02  Devin Rousso  <drousso@apple.com>
1669
1670         Web Inspector: Attributes table in Node Details Sidebar should have editable keys and values
1671         https://bugs.webkit.org/show_bug.cgi?id=167076
1672         <rdar://problem/30033629>
1673
1674         Reviewed by Timothy Hatcher.
1675
1676         * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
1677         (WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAttributes):
1678         (WebInspector.DOMNodeDetailsSidebarPanel.prototype._attributeNodeValueChanged):
1679         (WebInspector.DOMNodeDetailsSidebarPanel.prototype._createAttributesDataGrid): Deleted.
1680         Rework creation of the attributes DataGrid so that it is only created once and cleared for
1681         new content. Nodes in the DataGrid are now EditableDataGridNode instances so that attribute
1682         names and values can be changed from within the sidebar. The DataGrid is also sorted based
1683         on attribute name, to make finding attributes easier.
1684
1685         * UserInterface/Views/DataGrid.css:
1686         (.data-grid tr.editable .cell-content > input):
1687         (body:not(.window-inactive, .window-docked-inactive) .data-grid:matches(:focus, .force-focus) tr.editable.selected .cell-content > input):
1688
1689         * UserInterface/Views/DetailsSection.css:
1690         (.details-section > .content .data-grid tr:not(.editable) td.value-column):
1691         (.details-section > .content .data-grid tr:not(.editable) td.value-column > div):
1692         (.details-section > .content .data-grid td.value-column): Deleted.
1693         (.details-section > .content .data-grid td.value-column > div): Deleted.
1694
1695         * UserInterface/Main.html:
1696         * UserInterface/Views/EditableDataGridNode.js: Added.
1697         (WebInspector.EditableDataGridNode):
1698         (WebInspector.EditableDataGridNode.prototype.get element):
1699         (WebInspector.EditableDataGridNode.prototype.createCellContent):
1700         (WebInspector.EditableDataGridNode.prototype._handleKeyPress):
1701         (WebInspector.EditableDataGridNode.prototype._handleBlur):
1702         (WebInspector.EditableDataGridNode.prototype._notifyInputElementValueChanged):
1703         Special type of DataGridNode that wraps the content of each cell in an <input>.
1704
1705 2017-06-02  Devin Rousso  <drousso@apple.com>
1706
1707         Web Inspector: Existing query in Search tab doesn't perform search on reload
1708         https://bugs.webkit.org/show_bug.cgi?id=172663
1709
1710         Reviewed by Timothy Hatcher.
1711
1712         * Localizations/en.lproj/localizedStrings.js:
1713
1714         * UserInterface/Views/SearchSidebarPanel.css:
1715         (.sidebar > .panel.navigation.search.changed > .banner):
1716         (.sidebar > .panel.navigation.search.changed > .banner > a):
1717         (.sidebar > .panel.navigation.search.changed > :matches(.content, .empty-content-placeholder)):
1718
1719         * UserInterface/Views/SearchSidebarPanel.js:
1720         (WebInspector.SearchSidebarPanel.prototype.performSearch.resourcesCallback):
1721         (WebInspector.SearchSidebarPanel.prototype._mainResourceDidChange):
1722         (WebInspector.SearchSidebarPanel.prototype._contentChanged):
1723         Listen for any "resource added" event, and show the content changed banner when one occurs.
1724
1725 2017-06-02  Devin Rousso  <drousso@apple.com>
1726
1727         Web Inspector: Should see active Web Sockets when opening Web Inspector
1728         https://bugs.webkit.org/show_bug.cgi?id=172312
1729
1730         Reviewed by Joseph Pecoraro.
1731
1732         * UserInterface/Controllers/FrameResourceManager.js:
1733         (WebInspector.FrameResourceManager.prototype.webSocketHandshakeResponseReceived):
1734         (WebInspector.FrameResourceManager.prototype.initialize): Removed.
1735         Rework order of agent enable calls to ensure that the main frame is initialized before any
1736         websocket events are dispatched.
1737
1738         * UserInterface/Models/WebSocketResource.js:
1739         (WebInspector.WebSocketResource.ReadyState):
1740         Change symbol strings in enum for better printing in tests.
1741
1742 2017-06-01  Ryan Haddad  <ryanhaddad@apple.com>
1743
1744         Unreviewed, rolling out r217691.
1745
1746         This change broke the Windows build.
1747
1748         Reverted changeset:
1749
1750         "Web Inspector: Should see active Web Sockets when opening Web
1751         Inspector"
1752         https://bugs.webkit.org/show_bug.cgi?id=172312
1753         http://trac.webkit.org/changeset/217691
1754
1755 2017-06-01  Devin Rousso  <drousso@apple.com>
1756
1757         Web Inspector: Should see active Web Sockets when opening Web Inspector
1758         https://bugs.webkit.org/show_bug.cgi?id=172312
1759
1760         Reviewed by Joseph Pecoraro.
1761
1762         * UserInterface/Controllers/FrameResourceManager.js:
1763         (WebInspector.FrameResourceManager.prototype.webSocketHandshakeResponseReceived):
1764         (WebInspector.FrameResourceManager.prototype.initialize): Removed.
1765         Rework order of agent enable calls to ensure that the main frame is initialized before any
1766         websocket events are dispatched.
1767
1768         * UserInterface/Models/WebSocketResource.js:
1769         (WebInspector.WebSocketResource.ReadyState):
1770         Change symbol strings in enum for better printing in tests.
1771
1772 2017-06-01  Nikita Vasilyev  <nvasilyev@apple.com>
1773
1774         Web Inspector: Web Sockets: Unable to inspect a WebSocket that receives >50 messages per second
1775         https://bugs.webkit.org/show_bug.cgi?id=171904
1776         <rdar://problem/32095863>
1777
1778         Reviewed by Matt Baker.
1779
1780         Every size increase of a resource causes a sidebar item to be re-attached to the DOM. Sending or
1781         receiving a WebSocket message causes a size increase. When size increase happens too frequently,
1782         the go-to arrow starts to flicker and becomes unclickable. This patch makes sure a sidebar item gets
1783         re-attached only when its position (index) changes.
1784
1785         * UserInterface/Views/NetworkSidebarPanel.js:
1786         Add the go-to arrow and close buttons when treeElement.status is a spinner element.
1787
1788         (WebInspector.NetworkSidebarPanel.prototype.treeElementAddedOrChanged):
1789         * UserInterface/Views/ResourceTreeElement.js:
1790         (WebInspector.ResourceTreeElement.prototype._updateStatus):
1791         Setting status to "" removes the go-to arrow and close buttons in the Network tab.
1792         Only set status to "" to remove the spinner.
1793
1794         * UserInterface/Views/TimelineDataGrid.js:
1795         (WebInspector.TimelineDataGrid.prototype._refreshDirtyDataGridNodes):
1796         * UserInterface/Views/TreeOutline.js:
1797         (WebInspector.TreeOutline.prototype.reattachIfIndexChanged): Added.
1798
1799 2017-05-31  Devin Rousso  <drousso@apple.com>
1800
1801         Web Inspector: Add Debug view to Settings tab for debug settings and experimental features
1802         https://bugs.webkit.org/show_bug.cgi?id=172477
1803
1804         Reviewed by Joseph Pecoraro.
1805
1806         * UserInterface/Base/Setting.js:
1807         Add three new settings:
1808          - autoLogProtocolMessages
1809          - autoLogTimeStats
1810          - enableUncaughtExceptionReporter
1811
1812         * UserInterface/Debug/Bootstrap.js:
1813         (WebInspector.runBootstrapOperations):
1814         Update toolbar item state when editor in Settings tab is changed.
1815
1816         * UserInterface/Debug/UncaughtExceptionReporter.js:
1817         (handleUncaughtExceptionRecord):
1818         Return if the setting controlling the uncaught exception reporter is disabled.
1819
1820         * UserInterface/Protocol/InspectorBackend.js:
1821         (InspectorBackendClass):
1822         (InspectorBackendClass.prototype.set dumpInspectorProtocolMessages):
1823         (InspectorBackendClass.prototype.get dumpInspectorProtocolMessages):
1824         (InspectorBackendClass.prototype.set dumpInspectorTimeStats):
1825         (InspectorBackendClass.prototype.get dumpInspectorTimeStats):
1826         Replace member variables and private Setting objects with items on WebInspector.settings.
1827
1828         * UserInterface/Main.html:
1829         * UserInterface/Views/GeneralSettingsView.js: Removed.
1830         Consolidated into SettingsTabContentView.
1831
1832         * UserInterface/Views/SettingsTabContentView.js:
1833         (WebInspector.SettingsTabContentView):
1834         (WebInspector.SettingsTabContentView.prototype.initialLayout):
1835         (WebInspector.SettingsTabContentView.prototype._createGeneralSettingsView):
1836         (WebInspector.SettingsTabContentView.prototype._createDebugSettingsView):
1837         (WebInspector.SettingsTabContentView.prototype._updateDebugSettingsViewVisibility):
1838
1839         * UserInterface/Views/SettingsView.js:
1840         (WebInspector.SettingsView.prototype.addGroupWithCustomSetting):
1841
1842 2017-05-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1843
1844         [GTK] Web Inspector: BackForwardArrows.svg is not shown
1845         https://bugs.webkit.org/show_bug.cgi?id=172741
1846
1847         Reviewed by Carlos Garcia Campos.
1848
1849         * UserInterface/Images/gtk/BackForwardArrows.svg: Renamed id names to match with Apple's images.
1850
1851 2017-05-30  Joseph Pecoraro  <pecoraro@apple.com>
1852
1853         Web Inspector: images dragged from Inspector to Desktop are named "Unknown.png"
1854         https://bugs.webkit.org/show_bug.cgi?id=141515
1855         <rdar://problem/9251308>
1856
1857         Reviewed by Wenson Hsieh.
1858
1859         * UserInterface/Views/ImageResourceContentView.js:
1860         (WebInspector.ImageResourceContentView.prototype.contentAvailable):
1861         Set a non-standard "filename" attribute to provide a suggested filename
1862         for this <img> containing data: or blob: content.
1863
1864 2017-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1865
1866         [GTK] Web Inspector: Add DOM breakpoint image for GTK+
1867         https://bugs.webkit.org/show_bug.cgi?id=169326
1868
1869         Reviewed by Carlos Garcia Campos.
1870
1871         * UserInterface/Images/gtk/DOMBreakpoint.svg: Added.
1872
1873 2017-05-28  Dan Bernstein  <mitz@apple.com>
1874
1875         [Xcode] ALWAYS_SEARCH_USER_PATHS is set to YES
1876         https://bugs.webkit.org/show_bug.cgi?id=172691
1877
1878         Reviewed by Tim Horton.
1879
1880         * Configurations/Base.xcconfig: Set ALWAYS_SEARCH_USER_PATHS to NO.
1881
1882 2017-05-26  Devin Rousso  <drousso@apple.com>
1883
1884         Web Inspector: Reloading the page after switching from the Resource tab switches back
1885         https://bugs.webkit.org/show_bug.cgi?id=172622
1886
1887         Reviewed by Joseph Pecoraro.
1888
1889         * UserInterface/Views/DebuggerSidebarPanel.js:
1890         (WebInspector.DebuggerSidebarPanel.prototype._treeSelectionDidChange):
1891         * UserInterface/Views/ResourceSidebarPanel.js:
1892         (WebInspector.ResourceSidebarPanel.prototype._treeSelectionDidChange):
1893         * UserInterface/Views/SearchSidebarPanel.js:
1894         (WebInspector.SearchSidebarPanel.prototype._treeSelectionDidChange):
1895         Don't show the newly selected tree element's represented object if the sidebar is not visible.
1896
1897 2017-05-26  Devin Rousso  <drousso@apple.com>
1898
1899         Web Inspector: New Tab contents have extra vertical spacing when wrapped
1900         https://bugs.webkit.org/show_bug.cgi?id=172530
1901
1902         Reviewed by Joseph Pecoraro.
1903
1904         * UserInterface/Views/NewTabContentView.css:
1905         (.new-tab.tab.content-view):
1906
1907 2017-05-26  Fujii Hironori  <Hironori.Fujii@sony.com>
1908
1909         [GTK] Web Inspector: Add new GTK+ icons for Web Sockets
1910         https://bugs.webkit.org/show_bug.cgi?id=172296
1911
1912         Reviewed by Carlos Garcia Campos.
1913
1914         Add more free icons for the Web Inspector of GTK+ port.
1915
1916         * UserInterface/Images/gtk/WebSocket.png: Added.
1917         * UserInterface/Images/gtk/WebSocket@2x.png: Added.
1918         * UserInterface/Images/gtk/WebSocketLarge.png: Added.
1919         * UserInterface/Images/gtk/WebSocketLarge@2x.png: Added.
1920         * UserInterface/Views/ResourceIcons.css:
1921         (.resource-icon.resource-type-websocket .icon):
1922         (.large .resource-icon.resource-type-websocket .icon):
1923         (body:matches(.mac-platform, .windows-platform) .resource-icon.resource-type-websocket .icon): Deleted.
1924         (body:matches(.mac-platform, .windows-platform) .large .resource-icon.resource-type-websocket .icon): Deleted.
1925
1926 2017-05-25  Devin Rousso  <drousso@apple.com>
1927
1928         Web Inspector: Don't create DetailsSidebarPanel classes until they are needed by a Tab
1929         https://bugs.webkit.org/show_bug.cgi?id=172393
1930
1931         Reviewed by Joseph Pecoraro.
1932
1933         * UserInterface/Base/Main.js:
1934         (WebInspector.contentLoaded):
1935         Remove global instantiation of all DetailsSidebarPanel objects.
1936
1937         (WebInspector.instanceForClass):
1938         Utility function for creating and accessing an instance of a given class.
1939
1940         * UserInterface/Views/ContentBrowserTabContentView.js:
1941         (WebInspector.ContentBrowserTabContentView):
1942         * UserInterface/Views/DebuggerTabContentView.js:
1943         (WebInspector.DebuggerTabContentView):
1944         (WebInspector.DebuggerTabContentView.prototype.showDetailsSidebarPanels):
1945         * UserInterface/Views/ElementsTabContentView.js:
1946         (WebInspector.ElementsTabContentView):
1947         * UserInterface/Views/NetworkTabContentView.js:
1948         (WebInspector.NetworkTabContentView):
1949         * UserInterface/Views/ResourcesTabContentView.js:
1950         (WebInspector.ResourcesTabContentView):
1951         * UserInterface/Views/SearchTabContentView.js:
1952         (WebInspector.SearchTabContentView):
1953         * UserInterface/Views/StorageTabContentView.js:
1954         (WebInspector.StorageTabContentView):
1955         * UserInterface/Views/TabContentView.js:
1956         (WebInspector.TabContentView):
1957         (WebInspector.TabContentView.prototype.get detailsSidebarPanels):
1958         * UserInterface/Views/TimelineTabContentView.js:
1959         (WebInspector.TimelineTabContentView):
1960         Now accepts an array of DetailsSidebarPanel classes that are all instantiated when they are
1961         about to be added to the DetailsSidebar.
1962
1963 2017-05-25  Devin Rousso  <drousso@apple.com>
1964
1965         Web Inspector: Changing the width of a Sidebar when it's collapsed shouldn't trigger a layout
1966         https://bugs.webkit.org/show_bug.cgi?id=172606
1967
1968         Reviewed by Matt Baker.
1969
1970         * UserInterface/Views/Sidebar.js:
1971         (WebInspector.Sidebar.prototype._recalculateWidth):
1972
1973 2017-05-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1974
1975         [GTK] Web Inspector: Add ListStylePositionInside.svg and ListStylePositionOutside.svg
1976         https://bugs.webkit.org/show_bug.cgi?id=172574
1977
1978         Reviewed by Michael Catanzaro.
1979
1980         Add more free icons for the Web Inspector of GTK+ port.
1981
1982         * UserInterface/Images/gtk/ListStylePositionInside.svg: Added.
1983         * UserInterface/Images/gtk/ListStylePositionOutside.svg: Added.
1984
1985 2017-05-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1986
1987         [GTK] Web Inspector: Add new icons AnimationPlayStatePaused.svg and AnimationPlayStateRunning.svg
1988         https://bugs.webkit.org/show_bug.cgi?id=172579
1989
1990         Reviewed by Michael Catanzaro.
1991
1992         Add more free icons for the Web Inspector of GTK+ port.
1993
1994         * UserInterface/Images/gtk/AnimationPlayStatePaused.svg: Added.
1995         * UserInterface/Images/gtk/AnimationPlayStateRunning.svg: Added.
1996
1997 2017-05-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1998
1999         [GTK] Web Inspector: Add new GTK+ icons for garbage collect and clean buttons in Console
2000         https://bugs.webkit.org/show_bug.cgi?id=167356
2001
2002         Reviewed by Michael Catanzaro.
2003
2004         * UserInterface/Images/gtk/NavigationItemClear.svg: Aligned for 16x16 dimension.
2005         * UserInterface/Images/gtk/NavigationItemGarbageCollect.svg: Added.
2006         * UserInterface/Views/LogContentView.js:
2007         (WebInspector.LogContentView): Removed the Clear image dimension's conditional expression.
2008         * UserInterface/Views/NetworkGridContentView.js:
2009         (WebInspector.NetworkGridContentView): Ditto.
2010         * UserInterface/Views/TimelineRecordingContentView.js:
2011         (WebInspector.TimelineRecordingContentView): Ditto.
2012
2013 2017-05-24  Devin Rousso  <drousso@apple.com>
2014
2015         Web Inspector: Don't load the active recording until a Timeline view needs to be shown
2016         https://bugs.webkit.org/show_bug.cgi?id=172467
2017
2018         Reviewed by Joseph Pecoraro.
2019
2020         * UserInterface/Views/TimelineTabContentView.js:
2021         (WebInspector.TimelineTabContentView):
2022         (WebInspector.TimelineTabContentView.prototype.restoreFromCookie):
2023         (WebInspector.TimelineTabContentView.prototype._showTimelineViewForType):
2024         Move the call to `_recordingLoaded` to when a timeline view needs to be shown and only if
2025         `_displayedRecording` isn't already set. This delays the creation of the content view for
2026         the recording to right before it needs to be displayed.
2027
2028
2029 2017-05-23  Matt Baker  <mattbaker@apple.com>
2030
2031         Web Inspector: content views are not restored on reload if its tree element is filtered out
2032         https://bugs.webkit.org/show_bug.cgi?id=165744
2033         <rdar://problem/27461323>
2034
2035         Reviewed by Devin Rousso.
2036
2037         By default, NavigationSidebar should get the selected represented object
2038         from its content browser, instead of relying on the tree selection. This
2039         allows a filtered tree selection to persist across page loads.
2040
2041         * UserInterface/Views/NavigationSidebarPanel.js:
2042         (WebInspector.NavigationSidebarPanel.prototype.get currentRepresentedObject):
2043         (WebInspector.NavigationSidebarPanel.prototype.saveStateToCookie):
2044         Get the represented object from the content browser instead of relying
2045         on the tree selection (which can be filtered out).
2046
2047         (WebInspector.NavigationSidebarPanel.prototype._updateFilter):
2048         (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
2049         (WebInspector.NavigationSidebarPanel.prototype._treeElementWasFiltered):
2050         Reselect the represented object's tree element when it is shown due
2051         to a change in the filter state.
2052
2053         (WebInspector.NavigationSidebarPanel.prototype.get hasSelectedElement): Deleted.
2054         Not used.
2055         (WebInspector.NavigationSidebarPanel.prototype.representedObjectWasFiltered): Deleted.
2056         Not used. Replaced by _treeElementWasFiltered.
2057
2058 2017-05-23  Matt Baker  <mattbaker@apple.com>
2059
2060         Web Inspector: Cannot delete a disabled XHR breakpoint
2061         https://bugs.webkit.org/show_bug.cgi?id=171971
2062         <rdar://problem/32129527>
2063
2064         Reviewed by Devin Rousso.
2065
2066         * UserInterface/Controllers/DOMDebuggerManager.js:
2067         (WebInspector.DOMDebuggerManager.prototype.removeXHRBreakpoint):
2068         Dispatch XHRBreakpointRemoved event before removing the breakpoint from
2069         the backend. A disabled breakpoint will have already been removed, and
2070         an enabled breakpoint that fails to get removed from the backend should
2071         be removed from the frontend, to prevent it being resolved in the future.
2072         Drive-by fix: remove spurious dispatch of DOMBreakpointRemoved event.
2073
2074         (WebInspector.DOMDebuggerManager.prototype._detachXHRBreakpoint): Deleted.
2075         Merged with removeXHRBreakpoint to simplify implementation.
2076
2077 2017-05-23  Devin Rousso  <drousso@apple.com>
2078
2079         Web Inspector: use initialLayout for NetworkSidebarPanel
2080         https://bugs.webkit.org/show_bug.cgi?id=172470
2081
2082         Reviewed by Joseph Pecoraro.
2083
2084         * UserInterface/Views/NetworkSidebarPanel.js:
2085         (WebInspector.NetworkSidebarPanel):
2086         (WebInspector.NetworkSidebarPanel.prototype.showDefaultContentView):
2087         (WebInspector.NetworkSidebarPanel.prototype.initialLayout):
2088         Don't create NetworkGridContentView until right before it is shown.
2089
2090 2017-05-23  Fujii Hironori  <Hironori.Fujii@sony.com>
2091
2092         [GTK] Web Inspector: Add a new icon DockLeft.svg
2093         https://bugs.webkit.org/show_bug.cgi?id=172492
2094
2095         Reviewed by Carlos Garcia Campos.
2096
2097         * UserInterface/Images/gtk/DockLeft.svg: Added.
2098
2099 2017-05-23  Fujii Hironori  <Hironori.Fujii@sony.com>
2100
2101         [GTK] Web Inspector: Add a new icon CSSVariable.svg
2102         https://bugs.webkit.org/show_bug.cgi?id=172491
2103
2104         Reviewed by Carlos Garcia Campos.
2105
2106         * UserInterface/Images/gtk/CSSVariable.svg: Added.
2107
2108 2017-05-22  Devin Rousso  <drousso@apple.com>
2109
2110         Web Inspector: Changes are not applied in CSS sidebar when switching to Resources tab without blurring editor
2111         https://bugs.webkit.org/show_bug.cgi?id=172388
2112
2113         Reviewed by Joseph Pecoraro.
2114
2115         * UserInterface/Views/CSSStyleDeclarationSection.js:
2116         (WebInspector.CSSStyleDeclarationSection.prototype.refreshEditor):
2117         * UserInterface/Views/RulesStyleDetailsPanel.js:
2118         (WebInspector.RulesStyleDetailsPanel.prototype.cssStyleDeclarationSectionEditorFocused):
2119         (WebInspector.RulesStyleDetailsPanel.prototype.shown):
2120         When showing the StyleDetailsPanel, if there is an active editor, which is now saved each
2121         time one becomes focused, force an update of that editor's content.
2122
2123 2017-05-22  Joseph Pecoraro  <pecoraro@apple.com>
2124
2125         Web Inspector: New Tab contents not centered vertically
2126         https://bugs.webkit.org/show_bug.cgi?id=172486
2127
2128         Reviewed by Devin Rousso.
2129
2130         * UserInterface/Views/NewTabContentView.css:
2131         (.new-tab.tab.content-view):
2132         Use align-items instead of align-content.
2133
2134 2017-05-22  Devin Rousso  <drousso@apple.com>
2135
2136         Web Inspector: New CSS Rules should go into a new Stylesheet Resource that can be viewed/edited/saved
2137         https://bugs.webkit.org/show_bug.cgi?id=138810
2138
2139         Reviewed by Joseph Pecoraro.
2140
2141         * Localizations/en.lproj/localizedStrings.js:
2142
2143         * UserInterface/Controllers/CSSStyleManager.js:
2144         (WebInspector.CSSStyleManager):
2145         (WebInspector.CSSStyleManager.prototype.preferredInspectorStyleSheetForFrame):
2146         (WebInspector.CSSStyleManager.prototype._updateResourceContent.fetchedStyleSheetContent):
2147         Manually dispatch a change event for modifications to CSSStyleSheet objects since they are
2148         not covered by the listener for Resource changes.
2149
2150         * UserInterface/Main.html:
2151         Include WebInspector.CSSStyleSheetTreeElement.
2152
2153         * UserInterface/Models/Collection.js:
2154         (WebInspector.Collection.TypeVerifier):
2155         * UserInterface/Models/ResourceCollection.js:
2156         (WebInspector.ResourceCollection.TypeVerifier.Stylesheet):
2157         Add TypeVerifier for CSSStyleSheet.
2158
2159         * UserInterface/Models/DOMNodeStyles.js:
2160         (WebInspector.DOMNodeStyles.prototype._parseRulePayload):
2161         Manually create a SourceCodeLocation object for Inspector Style Sheets.
2162
2163         * UserInterface/Views/CSSStyleSheetTreeElement.js: Added.
2164         (WebInspector.CSSStyleSheetTreeElement):
2165
2166         * UserInterface/Views/ResourceIcons.css:
2167         (:matches(.resource-icon.resource-type-stylesheet, .stylessheet-icon) .icon):
2168
2169         * UserInterface/Views/FrameTreeElement.js:
2170         (WebInspector.FrameTreeElement.forwardingConstructor):
2171         (WebInspector.FrameTreeElement):
2172         (WebInspector.FrameTreeElement.prototype.onattach):
2173         (WebInspector.FrameTreeElement.prototype.ondetach):
2174         (WebInspector.FrameTreeElement.prototype.onpopulate):
2175         (WebInspector.FrameTreeElement.prototype._styleSheetAdded):
2176         * UserInterface/Views/ResourceSidebarPanel.js:
2177         (WebInspector.ResourceSidebarPanel):
2178         (WebInspector.ResourceSidebarPanel.prototype._styleSheetAdded):
2179         (WebInspector.ResourceSidebarPanel.prototype._treeSelectionDidChange):
2180         Listen for the creation of CSSStyleSheet objects and add them to the sidebar if they are an
2181         Inspector Style Sheet.  Regular style sheets are added via their respective resources.
2182
2183         * UserInterface/Views/NavigationSidebarPanel.js:
2184         (WebInspector.NavigationSidebarPanel.prototype._isTreeElementWithoutRepresentedObject):
2185         Prevent CSSStyleSheetTreeElement instances from attempting to save state to a cookie.
2186
2187         * UserInterface/Base/Main.js:
2188         (WebInspector.tabContentViewClassForRepresentedObject):
2189         (WebInspector.createSourceCodeLocationLink):
2190         * UserInterface/Views/ContentView.js:
2191         (WebInspector.ContentView.createFromRepresentedObject):
2192         (WebInspector.ContentView.isViewable):
2193         * UserInterface/Views/CSSStyleDeclarationSection.js:
2194         (WebInspector.CSSStyleDeclarationSection.prototype.refresh):
2195         * UserInterface/Views/ResourcesTabContentView.js:
2196         (WebInspector.ResourcesTabContentView.prototype.canShowRepresentedObject):
2197         * UserInterface/Views/ResourceContentView.js:
2198         (WebInspector.ResourceContentView):
2199         * UserInterface/Views/SourceCodeTextEditor.js:
2200         (WebInspector.SourceCodeTextEditor.prototype._prepareEditorForInitialContent):
2201         (WebInspector.SourceCodeTextEditor.prototype._looselyMatchesSourceCodeLocation):
2202         (WebInspector.SourceCodeTextEditor.prototype._matchesSourceCodeLocation):
2203         * UserInterface/Views/TextResourceContentView.js:
2204         (WebInspector.TextResourceContentView):
2205         (WebInspector.TextResourceContentView.prototype.get supportsSave):
2206         (WebInspector.TextResourceContentView.prototype.get saveData):
2207         (WebInspector.TextResourceContentView.prototype._contentWillPopulate):
2208         (WebInspector.TextResourceContentView.prototype._shouldBeEditable):
2209         Support editing and saving an Inspector Style Sheet via its CSSStyleSheet object.
2210
2211 2017-05-22  Brian Burg  <bburg@apple.com>
2212
2213         Web Inspector: webkit reload policy should match default behavior
2214         https://bugs.webkit.org/show_bug.cgi?id=171385
2215         <rdar://problem/31871515>
2216
2217         Reviewed by Joseph Pecoraro.
2218
2219         * UserInterface/Base/Main.js:
2220         Use PageAgent.reload.invoke to make the reload options more explicit.
2221
2222         * UserInterface/Test/FrontendTestHarness.js:
2223         (FrontendTestHarness.prototype.reloadPage):
2224         Convert this method to take an options dictionary rather than positional
2225         boolean arguments. Update call sites to pass correct options.
2226
2227         When running tests, we want to revalidate unexpired resources, as there
2228         does not seem to be another reliable way to trigger revalidated cached
2229         resources from a Web Inspector layout test. Make this behavior the default.
2230
2231 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
2232
2233         Support transform-box to switch sizing box in SVG
2234         https://bugs.webkit.org/show_bug.cgi?id=145783
2235
2236         Reviewed by Dean Jackson.
2237
2238         Add transform-box to the list of autocompletions.
2239
2240         * UserInterface/External/CodeMirror/css.js:
2241
2242 2017-05-22  Brian Burg  <bburg@apple.com>
2243
2244         Web Inspector: RTL: In Timelines > JavaScript & Events, digits for sample count are not localized
2245         https://bugs.webkit.org/show_bug.cgi?id=171819
2246
2247         Reviewed by Matt Baker.
2248
2249         * UserInterface/Views/ScriptTimelineDataGridNode.js:
2250         (WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent):
2251
2252 2017-05-22  Nikita Vasilyev  <nvasilyev@apple.com>
2253
2254         Web Inspector: RTL: Text in autocomplete popover should be aligned left
2255         https://bugs.webkit.org/show_bug.cgi?id=171998
2256
2257         Reviewed by Brian Burg.
2258
2259         Autocomplete popover is only used for CSS and JavaScript, and
2260         these should always be shown as LTR text.
2261
2262         * UserInterface/Views/CompletionSuggestionsView.css:
2263         (.completion-suggestions):
2264
2265 2017-05-22  Fujii Hironori  <Hironori.Fujii@sony.com>
2266
2267         [GTK] Web Inspector: Add active call frame indicator image
2268         https://bugs.webkit.org/show_bug.cgi?id=161987
2269         <rdar://problem/28307419>
2270
2271         Reviewed by Carlos Garcia Campos.
2272
2273         Add a free icon for the Web Inspector of GTK port.
2274
2275         * UserInterface/Images/gtk/ActiveCallFrame.svg: Added.
2276
2277 2017-05-19  Devin Rousso  <drousso@apple.com>
2278
2279         Web Inspector: Use initialLayout for Settings tab
2280         https://bugs.webkit.org/show_bug.cgi?id=172304
2281
2282         Reviewed by Matt Baker.
2283
2284         * UserInterface/Views/GeneralSettingsView.js:
2285         (WebInspector.GeneralSettingsView.prototype.initialLayout):
2286         Move listener for zoom factor to only update that editor.
2287
2288         * UserInterface/Views/SettingsTabContentView.js:
2289         (WebInspector.SettingsTabContentView):
2290         (WebInspector.SettingsTabContentView.prototype.initialLayout): Added.
2291         It is not necessary to create the UI for editing settings until the Settings tab is shown.
2292         Use initialLayout to ensure UI gets created exactly once, after the tab is selected.
2293
2294 2017-05-18  Devin Rousso  <drousso@apple.com>
2295
2296         REGRESSION (r?): Web Inspector: Shift-click on color square in Styles sidebar should not select text
2297         https://bugs.webkit.org/show_bug.cgi?id=171902
2298
2299         Reviewed by Matt Baker.
2300
2301         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
2302         (WebInspector.CSSStyleDeclarationTextEditor.prototype._handleMouseUp):
2303         Do not attempt to select text if the element being clicked is a bookmark (such as a swatch).
2304
2305 2017-05-18  Joseph Pecoraro  <pecoraro@apple.com>
2306
2307         Web Inspector: Web Socket Document Icon
2308         https://bugs.webkit.org/show_bug.cgi?id=170023
2309
2310         Reviewed by Matt Baker.
2311
2312         Icons made by Jon Davis.
2313
2314         * UserInterface/Images/WebSocket.png: Added.
2315         * UserInterface/Images/WebSocket@2x.png: Added.
2316         * UserInterface/Images/WebSocketLarge.png: Added.
2317         * UserInterface/Images/WebSocketLarge@2x.png: Added.
2318         New icons for Web Socket resources.
2319
2320         * UserInterface/Views/ResourceIcons.css:
2321         (body:matches(.mac-platform, .windows-platform) .resource-icon.resource-type-websocket .icon):
2322         (body:matches(.mac-platform, .windows-platform) .large .resource-icon.resource-type-websocket .icon):
2323         Use the icon.
2324
2325 2017-05-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2326
2327         Web Inspector: [GTK] Adopt currentColor for mask SVG images
2328         https://bugs.webkit.org/show_bug.cgi?id=150603
2329
2330         Reviewed by Carlos Garcia Campos.
2331
2332         * UserInterface/Images/gtk/Circle.svg:
2333         * UserInterface/Images/gtk/ClearBoth.svg:
2334         * UserInterface/Images/gtk/ClearLeft.svg:
2335         * UserInterface/Images/gtk/ClearRight.svg:
2336         * UserInterface/Images/gtk/Close.svg:
2337         * UserInterface/Images/gtk/CloseLarge.svg:
2338         * UserInterface/Images/gtk/Console.svg:
2339         * UserInterface/Images/gtk/Debugger.svg:
2340         * UserInterface/Images/gtk/DockBottom.svg:
2341         * UserInterface/Images/gtk/DockRight.svg:
2342         * UserInterface/Images/gtk/DownloadArrow.svg:
2343         * UserInterface/Images/gtk/Elements.svg:
2344         * UserInterface/Images/gtk/Errors.svg:
2345         * UserInterface/Images/gtk/Eye.svg:
2346         * UserInterface/Images/gtk/FloatLeft.svg:
2347         * UserInterface/Images/gtk/FloatRight.svg:
2348         * UserInterface/Images/gtk/FontStyleItalic.svg:
2349         * UserInterface/Images/gtk/FontStyleNormal.svg:
2350         * UserInterface/Images/gtk/Gear.svg:
2351         * UserInterface/Images/gtk/Issues.svg:
2352         * UserInterface/Images/gtk/Logs.svg:
2353         * UserInterface/Images/gtk/Minus.svg:
2354         * UserInterface/Images/gtk/NavigationItemClear.svg:
2355         * UserInterface/Images/gtk/NavigationItemTrash.svg:
2356         * UserInterface/Images/gtk/Network.svg:
2357         * UserInterface/Images/gtk/NewTab.svg:
2358         * UserInterface/Images/gtk/NewTabPlus.svg:
2359         * UserInterface/Images/gtk/Pause.svg:
2360         * UserInterface/Images/gtk/Pencil.svg:
2361         * UserInterface/Images/gtk/Plus13.svg:
2362         * UserInterface/Images/gtk/Plus15.svg:
2363         * UserInterface/Images/gtk/ReloadFull.svg:
2364         * UserInterface/Images/gtk/ReloadToolbar.svg:
2365         * UserInterface/Images/gtk/Resources.svg:
2366         * UserInterface/Images/gtk/Search.svg:
2367         * UserInterface/Images/gtk/SearchResults.svg:
2368         * UserInterface/Images/gtk/SplitToggleUp.svg:
2369         * UserInterface/Images/gtk/StepInto.svg:
2370         * UserInterface/Images/gtk/StepOut.svg:
2371         * UserInterface/Images/gtk/StepOver.svg:
2372         * UserInterface/Images/gtk/Stop.svg:
2373         * UserInterface/Images/gtk/Storage.svg:
2374         * UserInterface/Images/gtk/TextAlignCenter.svg:
2375         * UserInterface/Images/gtk/TextAlignJustify.svg:
2376         * UserInterface/Images/gtk/TextAlignLeft.svg:
2377         * UserInterface/Images/gtk/TextAlignRight.svg:
2378         * UserInterface/Images/gtk/TextDecorationLineThrough.svg:
2379         * UserInterface/Images/gtk/TextDecorationOverline.svg:
2380         * UserInterface/Images/gtk/TextDecorationUnderline.svg:
2381         * UserInterface/Images/gtk/TextTransformCapitalize.svg:
2382         * UserInterface/Images/gtk/TextTransformLowercase.svg:
2383         * UserInterface/Images/gtk/TextTransformUppercase.svg:
2384         * UserInterface/Images/gtk/Time.svg:
2385         * UserInterface/Images/gtk/Timeline.svg:
2386         * UserInterface/Images/gtk/Undock.svg:
2387         * UserInterface/Images/gtk/VisualStyleNone.svg:
2388         * UserInterface/Images/gtk/VisualStylePropertyLinked.svg:
2389         * UserInterface/Images/gtk/VisualStylePropertyUnlinked.svg:
2390         * UserInterface/Images/gtk/Weight.svg:
2391
2392 2017-05-15  Fujii Hironori  <Hironori.Fujii@sony.com>
2393
2394         [GTK] Web Inspector: Add new GTK+ icons for Search icon of Quick Open dialog
2395         https://bugs.webkit.org/show_bug.cgi?id=172110
2396
2397         Reviewed by Michael Catanzaro.
2398
2399         Add a free icon for the Web Inspector in GTK+.
2400
2401         * UserInterface/Images/gtk/Search.svg: Added.
2402
2403 2017-05-15  Fujii Hironori  <Hironori.Fujii@sony.com>
2404
2405         [GTK] Web Inspector: Add new GTK+ icons for Worker Scripts / Web Sockets
2406         https://bugs.webkit.org/show_bug.cgi?id=164138
2407
2408         Reviewed by Michael Catanzaro.
2409
2410         Add more free icons for the Web Inspector in GTK+.
2411
2412         * UserInterface/Images/gtk/WorkerScript.png: Added.
2413         * UserInterface/Images/gtk/WorkerScript@2x.png: Added.
2414         * UserInterface/Images/gtk/WorkerScriptLarge.png: Added.
2415         * UserInterface/Images/gtk/WorkerScriptLarge@2x.png: Added.
2416         * UserInterface/Views/ResourceIcons.css:
2417         (.script.worker-icon .icon):
2418         (.large .script.worker-icon .icon):
2419         (body:matches(.mac-platform, .windows-platform) .script.worker-icon .icon): Deleted.
2420         (body:matches(.mac-platform, .windows-platform) .large .script.worker-icon .icon): Deleted.
2421
2422 2017-05-11  Nikita Vasilyev  <nvasilyev@apple.com>
2423
2424         Web Inspector: RTL: "Elements > Styles - Rules" rule and media query headers should be left aligned
2425         https://bugs.webkit.org/show_bug.cgi?id=171954
2426         <rdar://problem/31961976>
2427
2428         Reviewed by Matt Baker.
2429
2430         * UserInterface/Views/CSSStyleDeclarationSection.css:
2431         (.style-declaration-section > .header):
2432         (.style-declaration-section.locked > .header > .locked-icon):
2433         (.style-declaration-section > .header > .icon):
2434         (.style-declaration-section > .header > textarea):
2435         (.style-declaration-section.invalid-selector > .header > .icon):
2436         (body[dir=ltr] .style-declaration-section > .header): Deleted.
2437         (body[dir=rtl] .style-declaration-section > .header): Deleted.
2438         (body[dir=ltr] .style-declaration-section.locked > .header > .locked-icon): Deleted.
2439         (body[dir=rtl] .style-declaration-section.locked > .header > .locked-icon): Deleted.
2440         (body[dir=ltr] .style-declaration-section > .header > .icon): Deleted.
2441         (body[dir=rtl] .style-declaration-section > .header > .icon): Deleted.
2442         (body[dir=ltr] .style-declaration-section > .header > textarea): Deleted.
2443         (body[dir=rtl] .style-declaration-section > .header > textarea): Deleted.
2444         Remove RTL rules.
2445
2446         * UserInterface/Views/CSSStyleDeclarationSection.js:
2447         (WebInspector.CSSStyleDeclarationSection):
2448         Set dir="ltr" so selector's textareas work correctly.
2449
2450         * UserInterface/Views/RulesStyleDetailsPanel.css:
2451         (.sidebar > .panel.details.css-style .rules):
2452
2453 2017-05-11  Matt Baker  <mattbaker@apple.com>
2454
2455         Web Inspector: Error trying to delete DOM breakpoints from the Debugger tab
2456         https://bugs.webkit.org/show_bug.cgi?id=171970
2457         <rdar://problem/32129262>
2458
2459         Reviewed by Brian Burg.
2460
2461         In the Debugger sidebar, DOM breakpoints can be cleared from a DOM node
2462         in two ways: by using the DOM node tree element's context menu, or by
2463         pressing the delete key while the element is selected. Each method used
2464         a different code path, and the latter had an error which caused it to fail.
2465
2466         Add a `removeDOMBreakpointsForNode` method to DOMDebuggerManager to make
2467         the operation convenient, and call it from both event handlers.
2468
2469         * UserInterface/Controllers/DOMBreakpointTreeController.js:
2470         (WebInspector.DOMBreakpointTreeController.appendBreakpointContextMenuItems):
2471         Use convenience method.
2472
2473         * UserInterface/Controllers/DOMDebuggerManager.js:
2474         (WebInspector.DOMDebuggerManager.prototype.removeDOMBreakpointsForNode):
2475         Helper function for removing all of a node's breakpoints.
2476
2477         * UserInterface/Views/DOMNodeTreeElement.js:
2478         (WebInspector.DOMNodeTreeElement.prototype.ondelete):
2479         Use convenience method.
2480
2481 2017-05-11  Fujii Hironori  <Hironori.Fujii@sony.com>
2482
2483         [GTK] Web Inspector: Add new GTK+ icons for resources in large sizes (32px @ 1x/2x)
2484         https://bugs.webkit.org/show_bug.cgi?id=155802
2485         <rdar://problem/25320686>
2486
2487         Reviewed by Carlos Garcia Campos.
2488
2489         Add more free icons for the Web Inspector in GTK+.
2490
2491         * UserInterface/Images/gtk/ClippingCSSLarge.png: Added.
2492         * UserInterface/Images/gtk/ClippingCSSLarge@2x.png: Added.
2493         * UserInterface/Images/gtk/ClippingGenericLarge.png: Added.
2494         * UserInterface/Images/gtk/ClippingGenericLarge@2x.png: Added.
2495         * UserInterface/Images/gtk/ClippingJSLarge.png: Added.
2496         * UserInterface/Images/gtk/ClippingJSLarge@2x.png: Added.
2497         * UserInterface/Images/gtk/DocumentCSSLarge.png: Added.
2498         * UserInterface/Images/gtk/DocumentCSSLarge@2x.png: Added.
2499         * UserInterface/Images/gtk/DocumentFontLarge.png: Added.
2500         * UserInterface/Images/gtk/DocumentFontLarge@2x.png: Added.
2501         * UserInterface/Images/gtk/DocumentGenericLarge.png: Added.
2502         * UserInterface/Images/gtk/DocumentGenericLarge@2x.png: Added.
2503         * UserInterface/Images/gtk/DocumentImageLarge.png: Added.
2504         * UserInterface/Images/gtk/DocumentImageLarge@2x.png: Added.
2505         * UserInterface/Images/gtk/DocumentJSLarge.png: Added.
2506         * UserInterface/Images/gtk/DocumentJSLarge@2x.png: Added.
2507         * UserInterface/Images/gtk/DocumentMarkupLarge.png: Added.
2508         * UserInterface/Images/gtk/DocumentMarkupLarge@2x.png: Added.
2509
2510 2017-05-10  Brian Burg  <bburg@apple.com>
2511
2512         Web Inspector: RTL: in Timelines > JavaScript & Events, digits for timer and animation frame number are not localized
2513         https://bugs.webkit.org/show_bug.cgi?id=171818
2514
2515         Reviewed by Joseph Pecoraro.
2516
2517         These numbers need to be formatted with %d, not %s.
2518
2519         * Localizations/en.lproj/localizedStrings.js:
2520         * UserInterface/Models/ScriptTimelineRecord.js:
2521         (WebInspector.ScriptTimelineRecord.EventType.displayName):
2522
2523 2017-05-10  Brian Burg  <bburg@apple.com>
2524
2525         Web Inspector: remove dead code for switching Toolbar display options
2526         https://bugs.webkit.org/show_bug.cgi?id=170738
2527
2528         Reviewed by Joseph Pecoraro.
2529
2530         * Localizations/en.lproj/localizedStrings.js:
2531         * UserInterface/Base/Main.js:
2532         (WebInspector.contentLoaded):
2533         * UserInterface/Views/ButtonToolbarItem.css:
2534         (.toolbar .item.button > .glyph):
2535         (.toolbar .item.button > .label):
2536         (.toolbar.icon-and-label-vertical .item.button): Deleted.
2537         (.toolbar.icon-and-label-horizontal .item.button): Deleted.
2538         (.toolbar.small-size .item.button > .glyph): Deleted.
2539         (.toolbar.label-only .item.button > .glyph): Deleted.
2540         (.toolbar.label-only .item.activate.button.activated > .label): Deleted.
2541         (.toolbar.icon-and-label-horizontal .item.button > .label): Deleted.
2542         (.toolbar.icon-only .item.button > .label): Deleted.
2543         * UserInterface/Views/ControlToolbarItem.css:
2544         (.toolbar .item.control):
2545         (.toolbar:matches(.icon-and-label-horizontal, .icon-only) .item.control): Deleted.
2546         * UserInterface/Views/DashboardContainerView.css:
2547         (.toolbar .dashboard-container):
2548         (.toolbar.icon-and-label-vertical:matches(.small-size, .normal-size) .dashboard-container): Deleted.
2549         (.toolbar.label-only .dashboard-container,): Deleted.
2550         (.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard-container): Deleted.
2551         (.toolbar.label-only .dashboard-container .advance-arrow): Deleted.
2552         (body[dir=ltr] .toolbar.label-only .dashboard-container .advance-arrow): Deleted.
2553         (body[dir=rtl] .toolbar.label-only .dashboard-container .advance-arrow): Deleted.
2554         * UserInterface/Views/DefaultDashboardView.css:
2555         (.toolbar .dashboard.default > .item):
2556         (.toolbar.label-only .dashboard.default > .item,): Deleted.
2557         (.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard.default > .item): Deleted.
2558         * UserInterface/Views/ReplayDashboardView.css:
2559         (.toolbar .dashboard.replay .item.button > .glyph):
2560         (.toolbar.label-only .dashboard.replay .item.button > .glyph): Deleted.
2561         * UserInterface/Views/Toolbar.css:
2562         (.toolbar .control-section):
2563         (.toolbar:matches(.icon-and-label-horizontal.small-size, .icon-only.small-size, .label-only) .control-section): Deleted.
2564         * UserInterface/Views/Toolbar.js:
2565         (WebInspector.Toolbar):
2566         (WebInspector.Toolbar.prototype.layout):
2567         (WebInspector.Toolbar.prototype.get displayMode): Deleted.
2568         (WebInspector.Toolbar.prototype.set displayMode): Deleted.
2569         (WebInspector.Toolbar.prototype.get sizeMode): Deleted.
2570         (WebInspector.Toolbar.prototype.set sizeMode): Deleted.
2571         (WebInspector.Toolbar.prototype._handleContextMenuEvent): Deleted.
2572         (WebInspector.Toolbar.prototype._changeDisplayMode): Deleted.
2573         (WebInspector.Toolbar.prototype._toggleSmallIcons): Deleted.
2574
2575 2017-05-10  Ross Kirsling  <ross.kirsling@sony.com>
2576
2577         Web Inspector: Copy to clipboard fails via InspectorFrontendHostStub
2578         https://bugs.webkit.org/show_bug.cgi?id=171907
2579
2580         Reviewed by Joseph Pecoraro.
2581
2582         * UserInterface/Base/InspectorFrontendHostStub.js:
2583         (WebInspector.InspectorFrontendHostStub.prototype.copyText):
2584         Actually make a text selection before attempting to copy to clipboard.
2585
2586 2017-05-09  Joseph Pecoraro  <pecoraro@apple.com>
2587
2588         Web Inspector: Provide resource load error reason text in details sidebar
2589         https://bugs.webkit.org/show_bug.cgi?id=171901
2590         <rdar://problem/29850995>
2591
2592         Reviewed by Brian Burg.
2593
2594         * Localizations/en.lproj/localizedStrings.js:
2595         * UserInterface/Controllers/FrameResourceManager.js:
2596         (WebInspector.FrameResourceManager.prototype.resourceRequestDidFailLoading):
2597         * UserInterface/Models/Resource.js:
2598         (WebInspector.Resource):
2599         (WebInspector.Resource.prototype.get failureReasonText):
2600         (WebInspector.Resource.prototype.markAsFailed):
2601         * UserInterface/Protocol/NetworkObserver.js:
2602         (WebInspector.NetworkObserver.prototype.loadingFailed):
2603         Include the error text we got from the backend. In most cases this should
2604         be a localized error description.
2605
2606         * UserInterface/Views/ResourceDetailsSidebarPanel.js:
2607         (WebInspector.ResourceDetailsSidebarPanel.prototype.set resource):
2608         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshErrorReason):
2609         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRequestAndResponse):
2610         Include an Error field alongside the status code section when there was an error.
2611
2612 2017-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2613
2614         [GTK][Win] Web Inspector: Cann't open "Quick Open" dialog by pressing Ctrl+Shift+O
2615         https://bugs.webkit.org/show_bug.cgi?id=171798
2616
2617         Reviewed by Michael Catanzaro.
2618
2619         PC can't input the shortcut keys Command+Shift+O and Command+P.
2620
2621         * UserInterface/Base/Main.js:
2622         (WebInspector.contentLoaded): Use CommandOrControl instead of Command.
2623
2624 2017-05-09  Brian Burg  <bburg@apple.com>
2625
2626         Web Inspector: Assertion failed: Cannot select item with unexpected parent bar. (at NavigationBar.js:132)
2627         https://bugs.webkit.org/show_bug.cgi?id=171885
2628
2629         Reviewed by Matt Baker.
2630
2631         This new assertion revealed a real misuse of the NavigationBar API.
2632
2633         * UserInterface/Views/NavigationBar.js:
2634         (WebInspector.NavigationBar.prototype.set selectedNavigationItem):
2635         Improve this to be an assertion so it can be paused at using the debugger.
2636
2637         * UserInterface/Views/TimelineTabContentView.js:
2638         (WebInspector.TimelineTabContentView.prototype._changeViewMode):
2639         We need to set a NavigationItem as the selected item, not its identifier.
2640         Look up the corresponding item for the identifier that we received (the view mode).
2641
2642 2017-05-08  Brian Burg  <bburg@apple.com>
2643
2644         Web Inspector: RTL: box model labels have bad alignment
2645         https://bugs.webkit.org/show_bug.cgi?id=171817
2646
2647         Reviewed by Joseph Pecoraro.
2648
2649         * UserInterface/Views/BoxModelDetailsSectionRow.css:
2650         (.details-section .row.box-model .label):
2651         (body[dir=ltr] .details-section .row.box-model .label):
2652         (body[dir=rtl] .details-section .row.box-model .label):
2653         We can't just use a mirrored leading margin because all the
2654         text here is center-aligned. Just hardcode a reasonable value.
2655
2656 2017-05-08  Joseph Pecoraro  <pecoraro@apple.com>
2657
2658         Web Inspector: Request/Response toggles not working
2659         https://bugs.webkit.org/show_bug.cgi?id=171833
2660         <rdar://problem/31341637>
2661
2662         Reviewed by Brian Burg.
2663
2664         * UserInterface/Views/HierarchicalPathNavigationItem.js:
2665         (WebInspector.HierarchicalPathNavigationItem.set components.let.componentsEqual):
2666         (WebInspector.HierarchicalPathNavigationItem.prototype.set components):
2667         If the new components being set were shallowly equal, then they wouldn't
2668         actually be updated even if ultimately they are different. In this case
2669         the Path Components with values "request" / "response" would not update
2670         between different resources because the path components had equivalent
2671         simple values. Provide a different discriminator (comparisonData) which
2672         can be an object so these path components compare as necessarily different.
2673
2674         * UserInterface/Views/HeapSnapshotClusterContentView.js:
2675         (WebInspector.HeapSnapshotClusterContentView.createPathComponent):
2676         (WebInspector.HeapSnapshotClusterContentView):
2677         * UserInterface/Views/ResourceClusterContentView.js:
2678         (WebInspector.ResourceClusterContentView.createPathComponent):
2679         (WebInspector.ResourceClusterContentView):
2680         (WebInspector.ResourceClusterContentView.prototype._resourceTypeDidChange):
2681         * UserInterface/Views/SVGImageResourceClusterContentView.js:
2682         (WebInspector.SVGImageResourceClusterContentView):
2683         * UserInterface/Views/ScriptClusterTimelineView.js:
2684         (WebInspector.ScriptClusterTimelineView.createPathComponent):
2685         (WebInspector.ScriptClusterTimelineView):
2686         Provide comparisonData for path components cases that would need it.
2687
2688 2017-05-08  Chris Dumez  <cdumez@apple.com>
2689
2690         Drop non-standard Element.scrollByLines() / scrollByPages()
2691         https://bugs.webkit.org/show_bug.cgi?id=171820
2692
2693         Reviewed by Simon Fraser.
2694
2695         Drop non-standard Element.scrollByLines() / scrollByPages() from
2696         WebInspector code.
2697
2698         * UserInterface/Models/NativeFunctionParameters.js:
2699
2700 2017-05-08  Matt Baker  <mattbaker@apple.com>
2701
2702         Web Inspector: Make it easy to dynamically show/hide a SettingsView
2703         https://bugs.webkit.org/show_bug.cgi?id=171765
2704         <rdar://problem/32031280>
2705
2706         Reviewed by Brian Burg.
2707
2708         This patch adds SettingsTabContentView.prototype.setSettingsViewVisible,
2709         for dynamically showing/hiding a child view (and its NavigationBar item).
2710         The following new behavior is relevant when more that one child SettingsView
2711         exist in the Settings tab:
2712          - Hiding the selected view will cause a new view to become selected.
2713            The previous visible view is selected, if it exists. Otherwise the
2714            next visible view is used.
2715          - Showing a view when no views are selected cause the view to be selected.
2716
2717         As the Settings tab currently has only one child view, the behavior above
2718         was tested by adding a handful of vanilla SettingsView objects to the tab
2719         and toggling their visibility.
2720
2721         * UserInterface/Views/NavigationBar.js:
2722         Simplify overloaded parameter `navigationItemOrIdentifierOrIndex`, which
2723         is used in a few places and is always an instance of NavigationItem.
2724
2725         (WebInspector.NavigationBar):
2726         (WebInspector.NavigationBar.prototype.removeNavigationItem):
2727         (WebInspector.NavigationBar.prototype.get selectedNavigationItem):
2728         (WebInspector.NavigationBar.prototype.set selectedNavigationItem):
2729         (WebInspector.NavigationBar.prototype.findNavigationItem):
2730         Lookup a navigation item by its identifier.
2731         (WebInspector.NavigationBar.prototype._findNavigationItem): Deleted.
2732         Replaced overloaded private method with new public method.
2733
2734         * UserInterface/Views/NavigationItem.js:
2735         Cleanup.
2736         (WebInspector.NavigationItem):
2737         (WebInspector.NavigationItem.prototype.get identifier):
2738         (WebInspector.NavigationItem.prototype.get element):
2739         (WebInspector.NavigationItem.prototype.get minimumWidth):
2740         (WebInspector.NavigationItem.prototype.get parentNavigationBar):
2741
2742         * UserInterface/Views/SettingsTabContentView.css:
2743         Use `visibility: hidden` instead of `display: none` when hiding the
2744         NavigationBar, so that the selected view's top position stays the same.
2745
2746         (.content-view.settings):
2747         (.content-view.settings .navigation-bar.invisible):
2748
2749         * UserInterface/Views/SettingsTabContentView.js:
2750         (WebInspector.SettingsTabContentView):
2751         Switch to an array of SettingsViews instead of a map. Fast lookup isn't
2752         a concern due to the small number of items, and having indices simplifies
2753         traversing the previous/next items in `setSettingsViewVisible`.
2754
2755         (WebInspector.SettingsTabContentView.prototype.set selectedSettingsView):
2756         Rename `page` to `settingsView`.
2757         (WebInspector.SettingsTabContentView.prototype.addSettingsView):
2758         (WebInspector.SettingsTabContentView.prototype.setSettingsViewVisible):
2759         Shows/hides the specified view. Hiding the selected SettingsView will
2760         cause another visible view to become selected, if one exists.
2761
2762         (WebInspector.SettingsTabContentView.prototype._updateNavigationBarVisibility):
2763         Helper for updating navigation bar visibility after making a change
2764         to the navigation items.
2765
2766         (WebInspector.SettingsTabContentView.prototype._navigationItemSelected):
2767
2768 2017-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
2769
2770         Unprefix unicode-bidi CSS values
2771         https://bugs.webkit.org/show_bug.cgi?id=171761
2772
2773         Reviewed by Simon Fraser.
2774
2775         * UserInterface/Models/CSSKeywordCompletions.js:
2776
2777 2017-05-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2778
2779         [GTK] Web Inspector: Add new GTK+ icon for timeline recording stopwatch
2780         https://bugs.webkit.org/show_bug.cgi?id=154088
2781
2782         Reviewed by Carlos Garcia Campos.
2783
2784         Add a free icon and remove some unused ones for the Web Inspector
2785         in GTK+.
2786
2787         * UserInterface/Images/gtk/Stopwatch.png: Removed.
2788         * UserInterface/Images/gtk/Stopwatch.svg: Added.
2789         * UserInterface/Images/gtk/Stopwatch@2x.png: Removed.
2790         * UserInterface/Views/TimelineIcons.css:
2791         (body:not(.mac-platform, .windows-platform) .stopwatch-icon .icon): Deleted.
2792
2793 2017-05-05  Nikita Vasilyev  <nvasilyev@apple.com>
2794
2795         REGRESSION (r212998): Web Inspector: bad spacing of go-to arrow for HTTP POST request data
2796         https://bugs.webkit.org/show_bug.cgi?id=171674
2797
2798         Reviewed by Matt Baker.
2799
2800         * UserInterface/Views/DetailsSection.css:
2801         (body[dir=ltr] .details-section > .content > .group > .row.simple > .value .go-to-arrow):
2802         (body[dir=rtl] .details-section > .content > .group > .row.simple > .value .go-to-arrow):
2803         Swap margin-left and margin-right. This regressed when RTL support was added.
2804
2805 2017-05-03  Devin Rousso  <webkit@devinrousso.com>
2806
2807         REGRESSION (r215630): Web Inspector: Option-Click on URL in Styles sidebar does not work
2808         https://bugs.webkit.org/show_bug.cgi?id=171569
2809
2810         Reviewed by Joseph Pecoraro.
2811
2812         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
2813         (WebInspector.SourceCodeTextEditor.prototype.tokenTrackingControllerHighlightedRangeWasClicked):
2814         Add missing `frame` parameter to `WebInspector.openURL`.
2815
2816 2017-05-03  Nikita Vasilyev  <nvasilyev@apple.com>
2817
2818         Uncaught Exception: Can't make a ContentView for an unknown representedObject of type: IndexedDatabase
2819         https://bugs.webkit.org/show_bug.cgi?id=167473
2820         <rdar://problem/30249715>
2821
2822         Reviewed by Matt Baker.
2823
2824         When an indexed database is selected in the Storage navigation sidebar, show its host, security origin, and version.
2825
2826         Previously, selecting an indexed database didn't change the content view. It could lead to a misleading state
2827         when an indexed database is selected in the sidebar, but the content view showed previously selected item such as
2828         Cookies or Local Storage.
2829
2830         * UserInterface/Main.html:
2831         * UserInterface/Views/ContentView.css:
2832         (.content-view .details-section):
2833         (.content-view .details-section > .content):
2834         (.content-view .details-section > .content > .group > .row.simple > .label):
2835         (.content-view .details-section:last-child):
2836         * UserInterface/Views/ContentView.js:
2837         (WebInspector.ContentView.createFromRepresentedObject):
2838         (WebInspector.ContentView.isViewable):
2839         * UserInterface/Views/IndexedDatabaseContentView.css: Added.
2840         (.indexed-database.content-view):
2841         (.indexed-database.content-view .indexed-database-details):
2842         (.indexed-database.content-view .details-section > .header):
2843         * UserInterface/Views/IndexedDatabaseContentView.js: Added.
2844         (WebInspector.IndexedDatabaseContentView):
2845         * UserInterface/Views/IndexedDatabaseDetailsSidebarPanel.js:
2846         (WebInspector.IndexedDatabaseDetailsSidebarPanel.prototype.inspect):
2847         Don't show the details sidebar for IndexedDB top level item since it has the same content as the content view.
2848
2849         * UserInterface/Views/StorageSidebarPanel.js:
2850         (WebInspector.StorageSidebarPanel._treeSelectionDidChange):
2851         * UserInterface/Views/StorageTabContentView.js:
2852         (WebInspector.StorageTabContentView.prototype.canShowRepresentedObject):
2853         (WebInspector.StorageTabContentView):
2854
2855 2017-05-03  Joseph Pecoraro  <pecoraro@apple.com>
2856
2857         Web Inspector: 404 Image Load does not appear as a failure in Web Inspector
2858         https://bugs.webkit.org/show_bug.cgi?id=171587
2859         <rdar://problem/13222846>
2860
2861         Reviewed by Matt Baker.
2862
2863         * UserInterface/Models/Resource.js:
2864         (WebInspector.Resource.prototype.createObjectURL):
2865         This may return null if the data is not a Blob. This can happen if we
2866         loaded non-base64Encoded text content for an Image. Such as a 404 response.
2867
2868         (WebInspector.Resource.prototype.hadLoadingError):
2869         Consistent way to check for any kind of loading error.
2870
2871         (WebInspector.Resource.prototype.getImageSize):
2872         Handle failure to create an object URL.
2873
2874         * UserInterface/Views/FontResourceContentView.js:
2875         (WebInspector.FontResourceContentView.prototype.contentAvailable):
2876         * UserInterface/Views/ImageResourceContentView.js:
2877         (WebInspector.ImageResourceContentView.prototype.contentAvailable):
2878         Handle failure to create an object URL.
2879 :
2880         * UserInterface/Views/ResourceContentView.js:
2881         (WebInspector.ResourceContentView):
2882         (WebInspector.ResourceContentView.prototype.showGenericErrorMessage):
2883         (WebInspector.ResourceContentView.prototype._protocolError): Deleted.
2884         Provide a way for subclasses to show a generic resource loading error.
2885
2886         * UserInterface/Views/ResourceTimelineDataGridNode.js:
2887         (WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent):
2888         * UserInterface/Views/ResourceTreeElement.js:
2889         (WebInspector.ResourceTreeElement.prototype._updateStatus):
2890         Use the consistent helper for denoting loading errors.
2891
2892 2017-05-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2893
2894         [GTK] Web Inspector: Remove GTK+ icon FontVariantSmallCaps.svg
2895         https://bugs.webkit.org/show_bug.cgi?id=171542
2896
2897         Reviewed by Carlos Garcia Campos.
2898
2899         This image is not used and Apple's one was removed in Bug 148720.
2900
2901         * UserInterface/Images/gtk/FontVariantSmallCaps.svg: Removed.
2902
2903 2017-05-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2904
2905         [GTK] Web Inspector: Remove GTK+ icons AnimationPlayStatePaused.svg and AnimationPlayStateRunning.svg
2906         https://bugs.webkit.org/show_bug.cgi?id=171540
2907
2908         Reviewed by Carlos Garcia Campos.
2909
2910         These images aren't used since r204152 (Bug 160566). Instead,
2911         Plus13.svg and Minus.svg are used.
2912
2913         * UserInterface/Images/gtk/BreakpointActionAdd.svg: Removed.
2914         * UserInterface/Images/gtk/BreakpointActionRemove.svg: Removed.
2915
2916 2017-04-30  Chris Dumez  <cdumez@apple.com>
2917
2918         Drop support for legacy ClientRect / ClientRectList
2919         https://bugs.webkit.org/show_bug.cgi?id=171418
2920
2921         Reviewed by Sam Weinig.
2922
2923         Drop ClientRectList-related code.
2924
2925         * UserInterface/Models/NativeFunctionParameters.js:
2926
2927 2017-04-27  Fujii Hironori  <Hironori.Fujii@sony.com>
2928
2929         [GTK] Web Inspector: Add new GTK+ icons for different Script Timeline Views (Events and Call Trees)
2930         https://bugs.webkit.org/show_bug.cgi?id=155077
2931
2932         Reviewed by Joseph Pecoraro.
2933
2934         * UserInterface/Images/gtk/CallTrees.svg: Added.
2935         * UserInterface/Images/gtk/Events.svg: Added.
2936         * UserInterface/Views/PathComponentIcons.css:
2937         (body:not(.mac-platform, .windows-platform) .heap-snapshot-record .icon,):
2938         (body:not(.mac-platform, .windows-platform) .events-icon .icon,): Deleted.
2939
2940 2017-04-27  Nikita Vasilyev  <nvasilyev@apple.com>
2941
2942         Web Inspector: Remove unused ToggleControlToolbarItem.js
2943         https://bugs.webkit.org/show_bug.cgi?id=171401
2944
2945         Reviewed by Joseph Pecoraro.
2946
2947         * UserInterface/Main.html:
2948         * UserInterface/Views/ToggleControlToolbarItem.js: Removed.
2949
2950 2017-04-27  Brian Burg  <bburg@apple.com>
2951
2952         Web Inspector: RTL: inherit system layout direction by default
2953         https://bugs.webkit.org/show_bug.cgi?id=171402
2954         <rdar://problem/30753626>
2955
2956         Reviewed by Joseph Pecoraro.
2957
2958         Web Inspector's layout direction should follow the system layout direction
2959         by default now that most RTL bugs seem to be fixed. We are ready for more
2960         feedback.
2961
2962         * UserInterface/Base/Main.js:
2963         * UserInterface/Base/Setting.js:
2964         Rename the existing "layout-direction" setting so that the new default
2965         value is set properly even for people who have overridden the layout
2966         direction while the setting was exposed to everyone.
2967
2968         * UserInterface/Views/GeneralSettingsView.js:
2969         (WebInspector.GeneralSettingsView.prototype.initialLayout):
2970         (WebInspector.GeneralSettingsView.prototype.layout):
2971         (WebInspector.GeneralSettingsView):
2972         Make the layout direction override setting only visible when DebugUI
2973         is turned on. This remains only for engineers to quickly check layout bugs.
2974
2975         * UserInterface/Views/SettingsView.js:
2976         (WebInspector.SettingsView.prototype.addGroupWithCustomSetting):
2977         (WebInspector.SettingsView.prototype.addCustomSetting): Deleted.
2978         Refactor the convenience method to return both the group and the
2979         custom setting. This allows us to toggle .hidden on the entire
2980         row for the Layout Direction setting (label and editor).
2981
2982         * Localizations/en.lproj/localizedStrings.js:
2983         Unlocalize the setting strings since they are only shown in engineering builds now.
2984
2985 2017-04-27  Brian Burg  <bburg@apple.com>
2986
2987         Web Inspector: RTL: fix alignment of "truncated call stack" message
2988         https://bugs.webkit.org/show_bug.cgi?id=170477
2989
2990         Reviewed by Devin Rousso.
2991
2992         * UserInterface/Views/ThreadTreeElement.css:
2993         (.tree-outline > .item.thread + ol > .item.truncated-call-frames):
2994         (body[dir=ltr] .tree-outline > .item.thread + ol > .item.truncated-call-frames):
2995         (body[dir=rtl] .tree-outline > .item.thread + ol > .item.truncated-call-frames):
2996         (.tree-outline > .item.thread + ol > .item.truncated-call-frames .icon):
2997         (body[dir=ltr] .tree-outline > .item.thread + ol > .item.truncated-call-frames .icon):
2998         (body[dir=rtl] .tree-outline > .item.thread + ol > .item.truncated-call-frames .icon):
2999
3000 2017-04-27  Brian Burg  <bburg@apple.com>
3001
3002         Web Inspector: RTL: layout issues in Open Resource Dialog
3003         https://bugs.webkit.org/show_bug.cgi?id=170551
3004
3005         Reviewed by Matt Baker.
3006
3007         We need to flip the cancel and search icons, and flip padding
3008         in the tree outline that contains search results.
3009
3010         I am still not happy with the title/subtitle ordering
3011         (i.e., the domain vs the resource name), but this issue will
3012         be solved primarily in the navigation sidebar first and then
3013         adjusted for Open Resource Dialog if those changes are not
3014         sufficient.
3015
3016         * UserInterface/Views/OpenResourceDialog.css:
3017         (.open-resource-dialog > .field):
3018         (body[dir=ltr] .open-resource-dialog > .field):
3019         (body[dir=rtl] .open-resource-dialog > .field):
3020         (.open-resource-dialog > .field::before):
3021         (body[dir=ltr] .open-resource-dialog > .field::before):
3022         (body[dir=rtl] .open-resource-dialog > .field::before):
3023         (.open-resource-dialog > .field > input):
3024         (body[dir=ltr] .open-resource-dialog > .field > input):
3025         (body[dir=rtl] .open-resource-dialog > .field > input):
3026         (.open-resource-dialog > .field > img):
3027         (body[dir=ltr] .open-resource-dialog > .field > img):
3028         (body[dir=rtl] .open-resource-dialog > .field > img):
3029         (.open-resource-dialog > .tree-outline .item):
3030         (body[dir=ltr] .open-resource-dialog > .tree-outline .item):
3031         (body[dir=rtl] .open-resource-dialog > .tree-outline .item):
3032
3033 2017-04-27  Brian Burg  <bburg@apple.com>
3034
3035         Web Inspector: fix tooltip wording for Reload button
3036         https://bugs.webkit.org/show_bug.cgi?id=171073
3037         <rdar://problem/31378524>
3038
3039         Reviewed by Joseph Pecoraro.
3040
3041         * Localizations/en.lproj/localizedStrings.js:
3042         * UserInterface/Base/Main.js:
3043         (WebInspector.contentLoaded):
3044
3045 2017-04-27  Fujii Hironori  <Hironori.Fujii@sony.com>
3046
3047         [GTK] Web Inspector: Add new GTK+ icons for instrument icons
3048         https://bugs.webkit.org/show_bug.cgi?id=153892
3049         <rdar://problem/24510460>
3050
3051         Reviewed by Joseph Pecoraro.
3052
3053         Add more free icons from art-libre symbolic and removed some
3054         unused ones for the Web Inspector in GTK+.
3055
3056         * UserInterface/Images/gtk/Colors.png: Removed.
3057         * UserInterface/Images/gtk/Colors@2x.png: Removed.
3058         * UserInterface/Images/gtk/ColorsLarge.png: Removed.
3059         * UserInterface/Images/gtk/ColorsLarge@2x.png: Removed.
3060         * UserInterface/Images/gtk/Frames.png: Removed.
3061         * UserInterface/Images/gtk/Frames@2x.png: Removed.
3062         * UserInterface/Images/gtk/HeapAllocationsInstrument.svg: Added.
3063         * UserInterface/Images/gtk/LayoutInstrument.svg: Added.
3064         * UserInterface/Images/gtk/MemoryInstrument.svg: Added.
3065         * UserInterface/Images/gtk/Network.png: Removed.
3066         * UserInterface/Images/gtk/Network@2x.png: Removed.
3067         * UserInterface/Images/gtk/NetworkInstrument.svg: Added.
3068         * UserInterface/Images/gtk/NetworkLarge.png: Removed.
3069         * UserInterface/Images/gtk/NetworkLarge@2x.png: Removed.
3070         * UserInterface/Images/gtk/RenderingFramesInstrument.svg: Added.
3071         * UserInterface/Images/gtk/Script.png: Removed.
3072         * UserInterface/Images/gtk/Script@2x.png: Removed.
3073         * UserInterface/Images/gtk/ScriptLarge.png: Removed.
3074         * UserInterface/Images/gtk/ScriptLarge@2x.png: Removed.
3075         * UserInterface/Images/gtk/ScriptsInstrument.svg: Added.
3076         * UserInterface/Views/TimelineIcons.css:
3077         (body:not(.mac-platform, .windows-platform) .network-icon .icon): Deleted.
3078         (body:not(.mac-platform, .windows-platform) .network-icon.large .icon): Deleted.
3079         (body:not(.mac-platform, .windows-platform) .layout-icon .icon): Deleted.
3080         (body:not(.mac-platform, .windows-platform) .layout-icon.large .icon): Deleted.
3081         (body:not(.mac-platform, .windows-platform) .script-icon .icon): Deleted.
3082         (body:not(.mac-platform, .windows-platform) .script-icon.large .icon): Deleted.
3083         (body:not(.mac-platform, .windows-platform) .rendering-frame-icon .icon): Deleted.
3084         (body:not(.mac-platform, .windows-platform) .memory-icon .icon): Deleted.
3085         (body:not(.mac-platform, .windows-platform) .heap-allocations-icon .icon): Deleted.
3086
3087 2017-04-27  Fujii Hironori  <Hironori.Fujii@sony.com>
3088
3089         [GTK] Web Inspector: gtk/NavigationItemCurleyBraces.svg is licensed under NonCommercial CC
3090         https://bugs.webkit.org/show_bug.cgi?id=170902
3091
3092         Reviewed by Michael Catanzaro.
3093
3094         * UserInterface/Images/gtk/NavigationItemCurleyBraces.svg:
3095         Replaced with new one created by me.
3096
3097 2017-04-27  Fujii Hironori  <Hironori.Fujii@sony.com>
3098
3099         [GTK] Web Inspector: some SVG images are specified 'currentColor' incorrectly
3100         https://bugs.webkit.org/show_bug.cgi?id=170977
3101
3102         Reviewed by Michael Catanzaro.
3103
3104         The keyword 'currentColor' is specifed manually in Bug 150602.
3105         But, some SVG images are specified incorrectly.
3106
3107         * UserInterface/Images/gtk/NavigationItemTypes.svg: Do not stroke
3108         with currentColor, but fill.
3109         * UserInterface/Images/gtk/UpDownArrows.svg: Ditto.
3110
3111 2017-04-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3112
3113         [GTK] Remote inspector should support inspecting targets with previous version of backend commands
3114         https://bugs.webkit.org/show_bug.cgi?id=171267
3115
3116         Reviewed by Michael Catanzaro.
3117
3118         Allow to use data URLs for script-src.
3119
3120         * UserInterface/Main.html:
3121
3122 2017-04-25  Nikita Vasilyev  <nvasilyev@apple.com>
3123
3124         REGRESSION (r209882): Web Inspector: Command-G does not work in the console
3125         https://bugs.webkit.org/show_bug.cgi?id=170555
3126         <rdar://problem/31481247>
3127
3128         Reviewed by Brian Burg.
3129
3130         Command-G didn't work in the console when the console content view was in focus. It only
3131         worked when the search input field was focused.
3132
3133         * UserInterface/Views/LogContentView.js:
3134         (WebInspector.LogContentView.prototype.findBannerRevealPreviousResult):
3135         (WebInspector.LogContentView.prototype.highlightPreviousSearchMatch): Added.
3136         (WebInspector.LogContentView.prototype.findBannerRevealNextResult):
3137         (WebInspector.LogContentView.prototype.highlightNextSearchMatch): Added.
3138         Re-introduce highlightPreviousSearchMatch and highlightNextSearchMatch methods that were
3139         removed in r209882.
3140
3141 2017-04-25  Joseph Pecoraro  <pecoraro@apple.com>
3142
3143         Web Inspector: Network Tab - Sorting by Priority Column hides all rows in the datagrid (uncaught exception)
3144         https://bugs.webkit.org/show_bug.cgi?id=171312
3145         <rdar://problem/31828554>
3146
3147         Reviewed by Brian Burg.
3148
3149         * UserInterface/Models/Resource.js:
3150         (WebInspector.Resource.comparePriority):
3151         Provide a helper for compariting NetworkPriority enum values.
3152
3153         * UserInterface/Views/NetworkGridContentView.js:
3154         (WebInspector.NetworkGridContentView):
3155         (WebInspector.NetworkGridContentView.prototype.dataGridSortComparator):
3156         * UserInterface/Views/NetworkTimelineView.js:
3157         (WebInspector.NetworkTimelineView.prototype.dataGridSortComparator):
3158         Custom sort handler for priority.
3159
3160 2017-04-25  Nikita Vasilyev  <nvasilyev@apple.com>
3161
3162         REGRESSION (r214863): Web Inspector: Uncaught Exception when losing focus from a selector field
3163         https://bugs.webkit.org/show_bug.cgi?id=171254
3164         <rdar://problem/31813959>
3165
3166         Reviewed by Joseph Pecoraro.
3167
3168         The event.relatedTarget of a blur event contains the element where focus moved to.
3169         In some cases this can be null, such as if the user leaves the application window.
3170         For example Command+Tab to switch to another application.
3171
3172         * UserInterface/Views/CSSStyleDeclarationSection.js:
3173         (WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste):
3174
3175 2017-04-25  Nikita Vasilyev  <nvasilyev@apple.com>
3176
3177         Web Inspector: Open the new bug page in the new tab
3178         https://bugs.webkit.org/show_bug.cgi?id=171253
3179
3180         Reviewed by Joseph Pecoraro.
3181
3182         * UserInterface/Debug/UncaughtExceptionReporter.js:
3183         (createErrorSheet):
3184
3185 2017-04-25  Joseph Pecoraro  <pecoraro@apple.com>
3186
3187         Web Inspector: "Space" localized string is not loaded in combined and minified builds
3188         https://bugs.webkit.org/show_bug.cgi?id=171283
3189         <rdar://problem/30871371>
3190
3191         Reviewed by Brian Burg.
3192
3193         In combined and minified builds, the document.write() to load the
3194         localized strings script doesn't happen before the KeyboardShortcut
3195         global code in Main.js evaluates, so there is no UIString because
3196         window.localizedStrings hasn't populated yet. Since this is the only
3197         instance, populate the display UIString lazily and provide warnings
3198         in minified builds if this happens.
3199
3200         * UserInterface/Base/LoadLocalizedStrings.js:
3201         (WebInspector.UIString):
3202         Provide a warning if a UIString was attempted before the strings have loaded.
3203
3204         * UserInterface/Base/Main.js:
3205         (WebInspector.loaded):
3206         For this rare instance, populate the display name of the string when we are
3207         sure strings have loaded.
3208
3209         * UserInterface/Models/KeyboardShortcut.js:
3210         Revert the UIString here, but note that it will be populated later.
3211
3212         * UserInterface/Models/Resource.js:
3213         (WebInspector.Resource.prototype.setCachedResponseBodySize):
3214         * UserInterface/Views/DOMTreeElement.js:
3215         (WebInspector.DOMTreeElement.prototype._statusImageContextmenu):
3216         Address console.asserts not ending in semicolon warnings produced during
3217         optimized builds. Without semicolons they are not stripped.
3218
3219 2017-04-25  Fujii Hironori  <Hironori.Fujii@sony.com>
3220
3221         Web Inspector: TypeError:​ sourceCodeLocation.populateLiveDisplayLocationTooltip is not a function
3222         https://bugs.webkit.org/show_bug.cgi?id=171259
3223
3224         Reviewed by Joseph Pecoraro.
3225
3226         The first argument of WebInspector.createSourceCodeLocationLink
3227         should be SourceCodeLocation type.
3228
3229         * UserInterface/Views/TimelineDataGridNode.js:
3230         (WebInspector.TimelineDataGridNode.prototype.createCellContent):
3231         Pass 'callFrame.sourceCodeLocation' instead of 'value' to the
3232         first argument.
3233
3234 2017-04-24  Matt Baker  <mattbaker@apple.com>
3235
3236         Web Inspector: DOM/XHR breakpoint sections should be collapsed by default
3237         https://bugs.webkit.org/show_bug.cgi?id=170931
3238
3239         Reviewed by Brian Burg.
3240
3241         Set the default collapsed parameter for DOM / XHR Breakpoints sections,
3242         and auto-expand the DOM Breakpoints when a breakpoint is added.
3243
3244         * UserInterface/Views/DebuggerSidebarPanel.js:
3245         (WebInspector.DebuggerSidebarPanel):
3246         (WebInspector.DebuggerSidebarPanel.prototype._domBreakpointAddedOrRemoved):
3247
3248 2017-04-21  Devin Rousso  <webkit@devinrousso.com>
3249
3250         Web Inspector: Add titles to Network grid items for easier reading when text overflows
3251         https://bugs.webkit.org/show_bug.cgi?id=170792
3252
3253         Reviewed by Brian Burg.
3254
3255         * UserInterface/Views/NetworkGridContentView.js:
3256         (WebInspector.NetworkGridContentView):
3257         * UserInterface/Views/ResourceTimelineDataGridNode.js:
3258         (WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent):
3259         (WebInspector.ResourceTimelineDataGridNode.prototype._cachedCellContent):
3260         Do not add a title if the text is an em-dash, as that title will not convey any information.
3261
3262 2017-04-21  Devin Rousso  <dcrousso+webkit@gmail.com>
3263
3264         Web Inspector: Don't show the Search tab if it's open and matches the representedObject
3265         https://bugs.webkit.org/show_bug.cgi?id=168709
3266
3267         Reviewed by Brian Burg.
3268
3269         * UserInterface/Base/Main.js:
3270         (WebInspector.handlePossibleLinkClick):
3271         (WebInspector.openURL):
3272         (WebInspector.showSourceCode):
3273         (WebInspector.showOriginalUnformattedSourceCodeLocation):
3274         (WebInspector.showOriginalOrFormattedSourceCodeLocation):
3275         (WebInspector.showOriginalOrFormattedSourceCodeTextRange):
3276         (WebInspector._frameWasAdded):
3277         (WebInspector.createSourceCodeLocationLink):
3278         (WebInspector.linkifyLocation):
3279         (WebInspector.linkifyElement):
3280         Add `options` parameter to provide greater customization.  Also fix some style issues.
3281
3282         * UserInterface/Views/NetworkGridContentView.js:
3283         (WebInspector.NetworkGridContentView.prototype.hasRepresentedObject): Deleted.
3284         * UserInterface/Views/NetworkSidebarPanel.js:
3285         (WebInspector.NetworkSidebarPanel.prototype.hasRepresentedObject): Deleted.
3286         * UserInterface/Views/NetworkTabContentView.js:
3287         (WebInspector.NetworkTabContentView.prototype.canShowRepresentedObject):
3288         * UserInterface/Views/SearchTabContentView.js:
3289         (WebInspector.SearchTabContentView.prototype.canShowRepresentedObject):
3290         Ensure that the Search tab can only display resources that it has entries for in its view.
3291         Also rework the way in which this is determined.
3292
3293         * UserInterface/Controllers/BreakpointPopoverController.js:
3294         (WebInspector.BreakpointPopoverController.prototype.appendContextMenuItems):
3295         * UserInterface/Protocol/InspectorFrontendAPI.js:
3296         (InspectorFrontendAPI.showMainResourceForFrame):
3297         * UserInterface/Views/CSSStyleDeclarationSection.js:
3298         (WebInspector.CSSStyleDeclarationSection.prototype.refresh):
3299         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
3300         (WebInspector.CSSStyleDeclarationTextEditor.tokenTrackingControllerHighlightedRangeWasClicked.showRangeInSourceCode):
3301         (WebInspector.CSSStyleDeclarationTextEditor.tokenTrackingControllerHighlightedRangeWasClicked):
3302         * UserInterface/Views/ComputedStyleDetailsPanel.js:
3303         (WebInspector.ComputedStyleDetailsPanel.prototype.cssStyleDeclarationTextEditorShowProperty):
3304         * UserInterface/Views/ConsoleMessageView.js:
3305         (WebInspector.ConsoleMessageView.prototype._linkifyLocation):
3306         * UserInterface/Views/DOMDetailsSidebarPanel.js:
3307         (WebInspector.DOMDetailsSidebarPanel.prototype._mouseWasClicked):
3308         * UserInterface/Views/DOMTreeContentView.js:
3309         (WebInspector.DOMTreeContentView.prototype._mouseWasClicked.followLink):
3310         * UserInterface/Views/DOMTreeElement.js:
3311         (WebInspector.DOMTreeElement.prototype._showCustomElementDefinition):
3312         * UserInterface/Views/DebuggerDashboardView.js:
3313         (WebInspector.DebuggerDashboardView.prototype._rebuildLocation):
3314         * UserInterface/Views/DebuggerSidebarPanel.js:
3315         (WebInspector.DebuggerSidebarPanel.prototype._treeSelectionDidChange):
3316         (WebInspector.DebuggerSidebarPanel.prototype._updatePauseReasonGotoArrow):
3317         * UserInterface/Views/ErrorObjectView.js:
3318         (WebInspector.ErrorObjectView.makeSourceLinkWithPrefix):
3319         * UserInterface/Views/EventListenerSectionGroup.js:
3320         (WebInspector.EventListenerSectionGroup.prototype._functionTextOrLink):
3321         * UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:
3322         (WebInspector.HeapSnapshotInstanceDataGridNode.prototype._populatePreview):
3323         (WebInspector.HeapSnapshotInstanceDataGridNode.prototype._mouseoverHandler.appendPathRow):
3324         * UserInterface/Views/ObjectTreeBaseTreeElement.js:
3325         (WebInspector.ObjectTreeBaseTreeElement.prototype._appendMenusItemsForObject):
3326         (WebInspector.ObjectTreeBaseTreeElement):
3327         * UserInterface/Views/ProbeSetDetailsSection.js:
3328         (WebInspector.ProbeSetDetailsSection.prototype._updateLinkElement):
3329         * UserInterface/Views/ProfileDataGridNode.js:
3330         (WebInspector.ProfileDataGridNode.prototype._displayContent):
3331         * UserInterface/Views/ResourceDetailsSidebarPanel.js:
3332         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRelatedResourcesSection):
3333         (WebInspector.ResourceDetailsSidebarPanel.prototype._goToRequestDataClicked):
3334         * UserInterface/Views/ResourceSidebarPanel.js:
3335         (WebInspector.ResourceSidebarPanel.prototype._treeSelectionDidChange):
3336         * UserInterface/Views/ResourceTimelineDataGridNode.js:
3337         (WebInspector.ResourceTimelineDataGridNode.prototype._dataGridNodeGoToArrowClicked):
3338         * UserInterface/Views/RulesStyleDetailsPanel.js:
3339         (WebInspector.RulesStyleDetailsPanel.prototype.refresh.insertMediaOrInheritanceLabel):
3340         * UserInterface/Views/SearchSidebarPanel.js:
3341         (WebInspector.SearchSidebarPanel.prototype._treeElementDoubleClick):
3342         * UserInterface/Views/SourceCodeTextEditor.js:
3343         (WebInspector.SourceCodeTextEditor.prototype.tokenTrackingControllerHighlightedRangeWasClicked):
3344         * UserInterface/Views/SourceCodeTimelineTimelineDataGridNode.js:
3345         (WebInspector.SourceCodeTimelineTimelineDataGridNode.prototype._createNameCellContent):
3346         * UserInterface/Views/TimelineDataGrid.js:
3347         (WebInspector.TimelineDataGrid.prototype._popoverCallStackTreeSelectionDidChange):
3348         * UserInterface/Views/TimelineDataGridNode.js:
3349         (WebInspector.TimelineDataGridNode.prototype.createCellContent):
3350         * UserInterface/Views/VisualStyleSelectorTreeItem.js:
3351         (WebInspector.VisualStyleSelectorTreeItem.prototype.populateContextMenu):
3352         Ensure that the Search tab is never shown from links generated by these functions.
3353         Also do the same for the Network tab in some cases.
3354
3355         * UserInterface/Views/NetworkTimelineView.js:
3356         (WebInspector.NetworkTimelineView.prototype.canShowContentViewForTreeElement): Deleted.
3357         (WebInspector.NetworkTimelineView.prototype.showContentViewForTreeElement): Deleted.
3358         Drive-by cleanup: remove dead code.
3359
3360 2017-04-20  Matt Baker  <mattbaker@apple.com>
3361
3362         Web Inspector: Add regular expression support to XHR breakpoints
3363         https://bugs.webkit.org/show_bug.cgi?id=170099
3364         <rdar://problem/31558082>
3365
3366         Reviewed by Joseph Pecoraro.
3367
3368         * Localizations/en.lproj/localizedStrings.js: