Web Inspector: SourceCode.requestContent should return a promise
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2014-12-29  Jonathan Wells  <jonowells@apple.com>
2
3         Web Inspector: SourceCode.requestContent should return a promise
4         https://bugs.webkit.org/show_bug.cgi?id=135777
5
6         Reviewed by Brian Burg.
7
8         Change SourceCode.js to request content from the backend using Promises. Change Resource.js to use this new
9         approach when determining whether a resource load has finished. Change all calls to the older
10         SourceCode#requestContentFromBackendIfNeeded to simply use requestContent and use a catch function
11         if a content request error needs to be handled. Fix a bug where the appropriate error message for an
12         invalid resource wasn't showing in the resource content view.
13
14         * UserInterface/Controllers/AnalyzerManager.js:
15         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode.):
16         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode):
17         * UserInterface/Controllers/CSSStyleManager.js:
18         (WebInspector.CSSStyleManager.prototype._updateResourceContent.fetchedStyleSheetContent):
19         (WebInspector.CSSStyleManager.prototype._updateResourceContent.styleSheetReady):
20         * UserInterface/Models/CSSStyleSheet.js:
21         (WebInspector.CSSStyleSheet.prototype.requestContentFromBackend):
22         (WebInspector.CSSStyleSheet.prototype.canRequestContentFromBackend): Deleted.
23         * UserInterface/Models/DOMNodeStyles.js:
24         (WebInspector.DOMNodeStyles.prototype.changeStyleText):
25         * UserInterface/Models/Resource.js:
26         (WebInspector.Resource.prototype.canRequestContent):
27         (WebInspector.Resource.prototype.requestContentFromBackend):
28         (WebInspector.Resource.prototype.markAsFinished):
29         (WebInspector.Resource.prototype.markAsFailed):
30         (WebInspector.Resource.prototype.getImageSize):
31         (WebInspector.Resource.prototype.canRequestContentFromBackend): Deleted.
32         * UserInterface/Models/Script.js:
33         (WebInspector.Script.prototype.requestContentFromBackend):
34         (WebInspector.Script.prototype.requestScriptSyntaxTree.catch):
35         (WebInspector.Script.prototype.canRequestContentFromBackend): Deleted.
36         * UserInterface/Models/SourceCode.js:
37         (WebInspector.SourceCode):
38         (WebInspector.SourceCode.prototype.requestContent):
39         (WebInspector.SourceCode.prototype.requestContentFromBackend):
40         (WebInspector.SourceCode.prototype._processContent):
41         (WebInspector.SourceCode.prototype.canRequestContentFromBackend): Deleted.
42         (WebInspector.SourceCode.prototype.requestContentFromBackendIfNeeded): Deleted.
43         (WebInspector.SourceCode.prototype.servicePendingContentRequests): Deleted.
44         * UserInterface/Models/SourceMapResource.js:
45         (WebInspector.SourceMapResource):
46         (WebInspector.SourceMapResource.prototype.requestContentFromBackend.sourceMapResourceLoadError):
47         (WebInspector.SourceMapResource.prototype.requestContentFromBackend):
48         (WebInspector.SourceMapResource.prototype.canRequestContentFromBackend): Deleted.
49         (WebInspector.SourceMapResource.prototype.requestContentFromBackend.sourceMapResourceLoaded): Deleted.
50         * UserInterface/Views/ResourceContentView.js:
51         (WebInspector.ResourceContentView):
52         (WebInspector.ResourceContentView.prototype._contentAvailable):
53         (WebInspector.ResourceContentView.prototype._contentError):
54         * UserInterface/Views/SourceCodeTextEditor.js:
55         (WebInspector.SourceCodeTextEditor):
56         (WebInspector.SourceCodeTextEditor.prototype._contentAvailable):
57         (WebInspector.SourceCodeTextEditor.prototype._populateWithInlineScriptContent.scriptContentAvailable):
58         (WebInspector.SourceCodeTextEditor.prototype._populateWithInlineScriptContent):
59         (WebInspector.SourceCodeTextEditor.prototype._populateWithScriptContent):
60
61 2014-12-26  Dan Bernstein  <mitz@apple.com>
62
63         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
64         https://bugs.webkit.org/show_bug.cgi?id=139950
65
66         Reviewed by David Kilzer.
67
68         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
69         in a manner that works with Xcode 5.1.1.
70
71 2014-12-20  David Kilzer  <ddkilzer@apple.com>
72
73         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
74         <http://webkit.org/b/139463>
75
76         Reviewed by Mark Rowe.
77
78         * Configurations/Base.xcconfig:
79         - Only set TOOLCHAINS on OS X.
80         * Configurations/DebugRelease.xcconfig:
81         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
82         * Configurations/Version.xcconfig:
83         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
84         * Configurations/WebInspectorUIFramework.xcconfig:
85         - Set NORMAL_PRODUCTION_FRAMEWORKS_DIR,
86           PRODUCTION_FRAMEWORKS_DIR and
87           JAVASCRIPTCORE_PRIVATE_HEADERS_DIR_Production by SDK.
88
89 2014-12-19  Commit Queue  <commit-queue@webkit.org>
90
91         Unreviewed, rolling out r177574.
92         https://bugs.webkit.org/show_bug.cgi?id=139821
93
94         "Broke Production builds by installing
95         libWebCoreTestSupport.dylib in the wrong directory" (Requested
96         by ddkilzer on #webkit).
97
98         Reverted changeset:
99
100         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
101         WebInspectorUI, WebKit, WebKit2"
102         https://bugs.webkit.org/show_bug.cgi?id=139463
103         http://trac.webkit.org/changeset/177574
104
105 2014-12-19  David Kilzer  <ddkilzer@apple.com>
106
107         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
108         <http://webkit.org/b/139463>
109
110         Reviewed by Mark Rowe.
111
112         * Configurations/Base.xcconfig:
113         - Only set TOOLCHAINS on OS X.
114         * Configurations/DebugRelease.xcconfig:
115         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
116         * Configurations/Version.xcconfig:
117         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
118         * Configurations/WebInspectorUIFramework.xcconfig:
119         - Set NORMAL_PRODUCTION_FRAMEWORKS_DIR,
120           PRODUCTION_FRAMEWORKS_DIR and
121           JAVASCRIPTCORE_PRIVATE_HEADERS_DIR_Production by SDK.
122
123 2014-12-16  Matt Baker  <mattbaker@apple.com>
124
125         Web Inspector: REGRESSION: Dragging undocked web inspector causes mouse to change from pointer to i-bar cursor over window title
126         https://bugs.webkit.org/show_bug.cgi?id=139720
127
128         Reviewed by Timothy Hatcher.
129
130         * UserInterface/Base/Main.js:
131         Prevent default handling of the mouse event when clicking in the titlebar area. WebCore won't continue handling the event,
132         but docking buttons/context menu still function.
133
134 2014-12-15  Nikita Vasilyev  <nvasilyev@apple.com>
135
136         Web Inspector: Clicking on the expand object arrow should always expand an object
137         https://bugs.webkit.org/show_bug.cgi?id=139382
138
139         Reviewed by Joseph Pecoraro.
140
141         * UserInterface/Views/LogContentView.js:
142         (WebInspector.LogContentView):
143         (WebInspector.LogContentView.prototype._click): Deleted.
144         stopPropagation was preventing the object expansion from happening as expecting.
145
146 2014-12-15  Joseph Pecoraro  <pecoraro@apple.com>
147
148         Web Inspector: CSSStyleDeclarationTextEditor fails to update if computed properties changed from empty to non-empty
149         https://bugs.webkit.org/show_bug.cgi?id=139610
150
151         Reviewed by Timothy Hatcher.
152
153         The CSSStyleDeclarationTextEditor for Computed Style Properties always has
154         empty DOMNodeStyles text. However we would not reset contents if properties
155         changed and the actualy content was empty. So once empty, we could never
156         recover. In fact, we should always refresh for Computed Styles.
157
158         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
159         (WebInspector.CSSStyleDeclarationTextEditor.prototype._propertiesChanged):
160
161 2014-12-08  Joseph Pecoraro  <pecoraro@apple.com>
162
163         Web Inspector: Hide Compositing Borders Button if backend returns an error that it is unsupported
164         https://bugs.webkit.org/show_bug.cgi?id=139307
165
166         Reviewed by Darin Adler.
167
168         * UserInterface/Views/DOMTreeContentView.js:
169         (WebInspector.DOMTreeContentView.prototype._updateCompositingBordersButtonToMatchPageSettings):
170
171 2014-12-05  Joseph Pecoraro  <pecoraro@apple.com>
172
173         Web Inspector: Uncaught Exceptions when attempting to show Content Flow
174         https://bugs.webkit.org/show_bug.cgi?id=139276
175
176         Reviewed by Brian Burg.
177
178         * UserInterface/Views/ContentView.js:
179         (WebInspector.ContentView):
180         (WebInspector.ContentView.isViewable):
181         LegacyJavaScriptProfileObject no longer exists, these references should be removed.
182
183         * UserInterface/Views/FolderizedTreeElement.js:
184         (WebInspector.FolderizedTreeElement.prototype._insertChildTreeElement):
185         This sort function references "this" and needed to be bound.
186
187 2014-12-04  Joseph Pecoraro  <pecoraro@apple.com>
188
189         Web Inspector: Network Timeline Filter Bar only has "All", missing Resource Type filters
190         https://bugs.webkit.org/show_bug.cgi?id=139268
191
192         Reviewed by Brian Burg.
193
194         * UserInterface/Views/TimelineDataGrid.js:
195         (WebInspector.TimelineDataGrid.createColumnScopeBar):
196         Users of createColumnScopeBar pass a Map object now instead of a dictionary.
197         Iterate over the map appropriately.
198
199 2014-12-04  Joseph Pecoraro  <pecoraro@apple.com>
200
201         Web Inspector: LayoutTests/inspector tests fail in Production builds due to missing test resources
202         https://bugs.webkit.org/show_bug.cgi?id=138898
203
204         Reviewed by Mark Rowe.
205
206         In Production builds, if FORCE_TOOL_INSTALL=YES is in the environment
207         we will copy all resources (for Tests) and still do the combine and
208         optimize phase for normal Production inspection resources.
209
210         * Scripts/copy-user-interface-resources.pl:
211
212 2014-12-03  Joseph Pecoraro  <pecoraro@apple.com>
213
214         Web Inspector: Missing getter, clients never see DragToAdjustController is enabled
215         https://bugs.webkit.org/show_bug.cgi?id=139228
216
217         Reviewed by Simon Fraser.
218
219         * UserInterface/Controllers/DragToAdjustController.js:
220         (WebInspector.DragToAdjustController.prototype.get enabled):
221
222 2014-12-02  Joseph Pecoraro  <pecoraro@apple.com>
223
224         Web Inspector: CSS Minification breaks some selectors with colons
225         https://bugs.webkit.org/show_bug.cgi?id=139206
226
227         Reviewed by Simon Fraser.
228
229         Do not remove spaces preceeding colons, as they may change the semantics
230         of selectors with colon prefixes (e.g. "a :not(b)").
231
232         At the same time, we can strip spaces around "!" characters, for example
233         a space is not required before "!important" priority.
234
235         * Scripts/cssmin.py:
236         (cssminify):
237
238 2014-12-01  Benjamin Poulain  <benjamin@webkit.org>
239
240         Web Inspector: add more :not() and :matches() awesomeness
241         https://bugs.webkit.org/show_bug.cgi?id=138997
242
243         Reviewed by Joseph Pecoraro.
244
245         Simplify the Inspector's CSS when possible.
246
247         * UserInterface/Views/DatabaseContentView.css:
248         (:matches(.database-user-query, .database-query-prompt, .database-query-result)::before):
249         (.database-user-query::before, .database-query-prompt::before, .database-query-result::before): Deleted.
250         * UserInterface/Views/GradientSlider.css:
251         (.gradient-slider-knob > :matches(img, div)):
252         (.gradient-slider-knob > div): Deleted.
253         * UserInterface/Views/HoverMenu.css:
254         (.hover-menu > svg > :matches(path, rect)):
255         (.hover-menu > svg > rect): Deleted.
256         * UserInterface/Views/LayerTreeDetailsSidebarPanel.css:
257         (.panel.details.layer-tree .name-column :matches(.pseudo-element, .reflection)):
258         (.panel.details.layer-tree tr.selected .name-column :matches(.pseudo-element, .reflection)):
259         (.panel.details.layer-tree .name-column .reflection): Deleted.
260         (.panel.details.layer-tree tr.selected .name-column .reflection): Deleted.
261         * UserInterface/Views/ProbeDetailsSidebarPanel.css:
262         (.details-section.probe-set .options > :matches(.probe-remove, .probe-clear-samples, .probe-add)):
263         (.details-section.probe-set .options > .probe-add): Deleted.
264         * UserInterface/Views/ResourceSidebarPanel.css:
265         (.sidebar > .panel.navigation.resource > :matches(.content, .empty-content-placeholder)):
266         (body.mac-platform.legacy .sidebar > .panel.navigation.resource > :matches(.content, .empty-content-placeholder)):
267         (.sidebar > .panel.navigation.resource > .empty-content-placeholder): Deleted.
268         (body.mac-platform.legacy .sidebar > .panel.navigation.resource > .empty-content-placeholder): Deleted.
269         * UserInterface/Views/ScopeBar.css:
270         (.scope-bar > li:matches(.selected, :active)):
271         (.scope-bar > li:active): Deleted.
272         * UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
273         (.syntax-highlighted :matches(.css-comment, .javascript-comment, .html-comment)):
274         (.syntax-highlighted :matches(.css-keyword, .css-tag, .css-at-rule, .css-important, .javascript-keyword, .html-tag)):
275         (.syntax-highlighted :matches(.css-number, .javascript-number)):
276         (.syntax-highlighted :matches(.css-property, .css-selector, .javascript-ident)):
277         (.syntax-highlighted :matches(.css-string, .javascript-string, .javascript-regexp, .html-attribute-value)):
278         (.syntax-highlighted :matches(.html-doctype, .html-processing-instruction)):
279         (.syntax-highlighted .html-comment): Deleted.
280         (.syntax-highlighted .html-tag): Deleted.
281         (.syntax-highlighted .javascript-number): Deleted.
282         (.syntax-highlighted .javascript-ident): Deleted.
283         (.syntax-highlighted .html-attribute-value): Deleted.
284         (.syntax-highlighted .html-processing-instruction): Deleted.
285         It looks like ".cm-tag.cm-bracket" was there only to override the rule below.
286         From basic testing, it looks like "cm-tag" and "cm-bracket" always appear together. I removed the "cm-bracket" rule
287         from the second rule, and simplified the first rule.
288
289         * UserInterface/Views/TimelineSidebarPanel.css:
290         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > :matches(.content, .empty-content-placeholder)):
291         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .empty-content-placeholder): Deleted.
292         * UserInterface/Views/Toolbar.css:
293         (body.mac-platform:not(.legacy, .docked) .toolbar):
294         (body.mac-platform:not(.legacy, .docked) .toolbar.icon-and-label-vertical):
295         (body.mac-platform:not(.legacy, .docked) .toolbar.icon-and-label-vertical.small-size):
296         (body.mac-platform:not(.legacy, .docked) .toolbar:matches(.icon-and-label-horizontal, .icon-only)):
297         (body.mac-platform:not(.legacy, .docked) .toolbar:matches(.icon-and-label-horizontal.small-size, .icon-only.small-size, .label-only)):
298         (.toolbar:matches(.icon-and-label-horizontal.small-size, .icon-only.small-size, .label-only) .control-section):
299         (body.mac-platform:not(.legacy):not(.docked) .toolbar): Deleted.
300         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical): Deleted.
301         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical.small-size): Deleted.
302         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-only): Deleted.
303         (body.mac-platform:not(.legacy):not(.docked) .toolbar.label-only): Deleted.
304         (.toolbar.label-only .control-section): Deleted.
305
306 2014-11-27  Andres Gomez  <agomez@igalia.com>
307
308         Web Inspector: Update NavigationItemProbes icon for the GTK+ port
309         https://bugs.webkit.org/show_bug.cgi?id=139074
310
311         Reviewed by Carlos Garcia Campos.
312
313         NavigationItemProbes was updated for the Mac port and we are now
314         having a similar ideogram in GTK+.
315
316         * UserInterface/Images/gtk/NavigationItemProbes.svg: Updated.
317
318 2014-11-21  Benjamin Poulain  <bpoulain@apple.com>
319
320         Start using the new :not() and :matches() in the Web Inspector
321         https://bugs.webkit.org/show_bug.cgi?id=138978
322
323         Reviewed by Joseph Pecoraro.
324
325         Start simpifying some definitions by using modern CSS.
326
327         * UserInterface/Views/CSSStyleDeclarationSection.css:
328         (body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section:matches(.last-in-group, :last-child)):
329         (.style-declaration-section:matches(.locked, .selector-locked) > .header > .selector):
330         (body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section:last-child): Deleted.
331         (.style-declaration-section.selector-locked > .header > .selector): Deleted.
332         * UserInterface/Views/CSSStyleDeclarationTextEditor.css:
333         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property:matches(.disabled, .invalid, .other-vendor, .not-inherited, .overridden)):
334         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property:matches(.implicit, .not-inherited)):
335         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .editing-line .css-style-declaration-property:matches(.disabled, .other-vendor, .not-inherited, .overridden)):
336         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property.overridden): Deleted.
337         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property.not-inherited): Deleted.
338         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .editing-line .css-style-declaration-property.overridden): Deleted.
339         * UserInterface/Views/ControlToolbarItem.css:
340         (.toolbar:matches(.icon-and-label-horizontal, .toolbar.icon-only) .item.control):
341         (.toolbar.icon-only .item.control): Deleted.
342         * UserInterface/Views/DOMStorageContentView.css:
343         * UserInterface/Views/DashboardContainerView.css:
344         (.toolbar.icon-and-label-vertical:matches(.small-size, .normal-size) .dashboard-container):
345         (.toolbar:matches(.label-only, .small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal)) .dashboard-container):
346         (.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard-container):
347         (.toolbar.normal-size.icon-and-label-vertical .dashboard-container): Deleted.
348         (.toolbar.small-size.icon-and-label-horizontal .dashboard-container): Deleted.
349         (.toolbar.normal-size.icon-and-label-horizontal .dashboard-container): Deleted.
350         * UserInterface/Views/DataGrid.css:
351         (.data-grid :matches(th, td):not(:last-child)):
352         (.data-grid th:matches(.sort-ascending, .sort-descending)):
353         (.data-grid :matches(th, td) > div):
354         (.data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child):
355         (.data-grid tr:matches(.selected, :hover) .go-to-arrow):
356         (.data-grid :-webkit-any(th, td):not(:last-child)): Deleted.
357         (.data-grid th:-webkit-any(.sort-ascending, .sort-descending)): Deleted.
358         (.data-grid :-webkit-any(th, td) > div): Deleted.
359         (.data-grid th:-webkit-any(.sort-ascending, .sort-descending) > div:first-child): Deleted.
360         (.data-grid tr:-webkit-any(.selected, :hover) .go-to-arrow): Deleted.
361         * UserInterface/Views/DebuggerDashboardView.css:
362         (.toolbar.collapsed .dashboard.debugger > :not(.message, .navigation-bar )):
363         (.toolbar.collapsed .dashboard.debugger > :not(.message):not(.navigation-bar )): Deleted.
364         * UserInterface/Views/DefaultDashboardView.css:
365         (body.web .toolbar.collapsed .dashboard.default > :matches(.time, .resourcesSize, .logs)):
366         (body.javascript .toolbar .dashboard.default > :matches(.time, .resourcesSize, .resourcesCount)):
367         (.toolbar:matches(.label-only, .small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal)) .dashboard.default > .item):
368         (.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard.default > .item):
369         (body.web .toolbar.collapsed .dashboard.default > .logs): Deleted.
370         (body.javascript .toolbar .dashboard.default > .resourcesCount): Deleted.
371         (.toolbar.small-size.icon-and-label-horizontal .dashboard.default > .item): Deleted.
372         (.toolbar.normal-size.icon-and-label-horizontal .dashboard.default > .item): Deleted.
373         * UserInterface/Views/DetailsSection.css:
374         (.details-section > .header > :matches(.node-link, .go-to-arrow)):
375         (.details-section > .content > .group:nth-child(even) > .row:matches(.simple:first-child > *, :not(.simple):first-child)):
376         (body.mac-platform.legacy .details-section > .content > .group:matches(:nth-child(even), :last-child) > .row.simple:last-child > *):
377         (.details-section > .content > .group > .row:matches(.empty, .text)):
378         (body.mac-platform.legacy .details-section > .content > .group > .row:matches(.empty, .text)):
379         (.details-section > .header > .go-to-arrow): Deleted.
380         (.details-section > .content > .group:nth-child(even) > .row.simple:first-child > *): Deleted.
381         (body.mac-platform.legacy .details-section > .content > .group:last-child > .row.simple:last-child > *): Deleted.
382         (.details-section > .content > .group > .row.text): Deleted.
383         (body.mac-platform.legacy .details-section > .content > .group > .row.text): Deleted.
384         * UserInterface/Views/FindBanner.css:
385         (:matches(.find-banner, .supports-find-banner).no-find-banner-transition):
386         (.supports-find-banner.no-find-banner-transition): Deleted.
387         * UserInterface/Views/FlexibleSpaceNavigationItem.css:
388         (:matches(.navigation-bar, .toolbar) .item.flexible-space):
389         (.toolbar .item.flexible-space): Deleted.
390
391 2014-11-19  Joseph Pecoraro  <pecoraro@apple.com>
392
393         Web Inspector: LayoutTests/inspector should not have localStorage side effects
394         https://bugs.webkit.org/show_bug.cgi?id=138895
395
396         Reviewed by Brian Burg.
397
398         When running inspector tests, do not restore/save WebInspector.Settings
399         to localStorage, as that will cause side effects. Instead each Setting
400         will be initialized with its default value and can be modified during
401         the run of the test.
402
403         * UserInterface/Base/Test.js:
404         (WebInspector.loaded):
405         Name the setting to match the normal setting name now that persistence
406         is not an issue.
407
408         * UserInterface/Models/Setting.js:
409         (WebInspector.Setting.prototype.get value):
410         (WebInspector.Setting.prototype.set value):
411         Do not restore/save when in tests.
412
413 2014-11-19  Joseph Pecoraro  <pecoraro@apple.com>
414
415         Web Inspector: JSContext inspection Resource search does not work
416         https://bugs.webkit.org/show_bug.cgi?id=131252
417
418         Reviewed by Timothy Hatcher.
419
420         * UserInterface/Views/ResourceSidebarPanel.js:
421         (WebInspector.ResourceSidebarPanel.prototype.performSearch.resourceCallback):
422         (WebInspector.ResourceSidebarPanel.prototype.performSearch.resourcesCallback):
423         Cleanup by reordering things a bit.
424
425         (WebInspector.ResourceSidebarPanel.prototype.performSearch.searchScripts.scriptCallback):
426         (WebInspector.ResourceSidebarPanel.prototype.performSearch.searchScripts):
427         (WebInspector.ResourceSidebarPanel.prototype.performSearch):
428         Search non-resource scripts individually.
429
430         (WebInspector.ResourceSidebarPanel.prototype._searchTreeElementForScript):
431         Lazily create a ScriptTreeElement for the search tree outline as needed.
432
433         (WebInspector.ResourceSidebarPanel.prototype._scriptsToSearch):
434         When searching scripts, just perform a shallow walk of the tree outline to find
435         Script resources that are not also Resources. Scripts are always guarenteed to
436         be in a folder when inspecting a web resource. For JSContext inspection, scripts
437         are promoted to the top level.
438
439         * UserInterface/Main.html:
440         * UserInterface/Models/SourceCodeSearchMatchObject.js: Renamed from Source/WebInspectorUI/UserInterface/Models/ResourceSearchMatchObject.js.
441         (WebInspector.SourceCodeSearchMatchObject):
442         * UserInterface/Views/SearchIcons.css:
443         (.source-code-match-icon .icon):
444         (.resource-match-icon .icon): Deleted.
445         * UserInterface/Views/SearchResultTreeElement.js:
446         (WebInspector.SearchResultTreeElement):
447         Rename ResourceSearchMatchObject to SourceCodeSearchMatchObject.
448
449 2014-11-19  Joseph Pecoraro  <pecoraro@apple.com>
450
451         Web Inspector: Provide $exception in the console for the thrown exception value
452         https://bugs.webkit.org/show_bug.cgi?id=138726
453
454         Reviewed by Timothy Hatcher.
455
456         * UserInterface/Base/Test.js:
457         (WebInspector.loaded):
458         In order to use RuntimeManager to execute in the global context or on the
459         active debugger call frame, we need to expose the quickConsole controller.
460
461         * UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
462         Expose $exception to completion when we paused because of an exception.
463
464 2014-11-19  Joseph Pecoraro  <pecoraro@apple.com>
465
466         Web Inspector: Debugger should not mutate variable when hovering mouse over ++n expression
467         https://bugs.webkit.org/show_bug.cgi?id=138839
468
469         Reviewed by Timothy Hatcher.
470
471         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
472         (WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
473
474 2014-11-19  Joseph Pecoraro  <pecoraro@apple.com>
475
476         Web Inspector: Improve basic JavaScript completion in inline <script>s
477         https://bugs.webkit.org/show_bug.cgi?id=138845
478
479         Reviewed by Timothy Hatcher.
480
481         * UserInterface/Controllers/CodeMirrorCompletionController.js:
482         (WebInspector.CodeMirrorCompletionController.prototype._generateJavaScriptCompletions):
483         Fix up CodeMirror mode handling for JavaScript completion when inside of mixed mode
484         input (html). Also add completion for CodeMirror's localVars list.
485
486 == Rolled over to ChangeLog-2014-11-19 ==