Web Inspector: Expanding event objects in console shows undefined for most values...
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2015-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2
3         Web Inspector: Expanding event objects in console shows undefined for most values, it should have real values
4         https://bugs.webkit.org/show_bug.cgi?id=137306
5
6         Reviewed by Timothy Hatcher.
7
8         When first expanding an object, show all the object's own properties and any
9         getter properties that may be on its prototype chain. Now, we only fetch
10         own properties, for __proto__ properties.
11
12         * UserInterface/Protocol/RemoteObject.js:
13         (WebInspector.RemoteObject.prototype.getOwnProperties):
14         (WebInspector.RemoteObject.prototype.getOwnAndGetterProperties):
15         (WebInspector.RemoteObject.prototype.getAllProperties):
16         (WebInspector.RemoteObject.prototype.get hasChildren): Deleted.
17         * UserInterface/Views/ObjectPropertiesSection.js:
18         (WebInspector.ObjectPropertiesSection):
19         (WebInspector.ObjectPropertiesSection.prototype.update):
20         (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
21
22 2015-01-20  Joseph Pecoraro  <pecoraro@apple.com>
23
24         Web Inspector: Should show dynamic specificity values
25         https://bugs.webkit.org/show_bug.cgi?id=140647
26
27         Reviewed by Benjamin Poulain.
28
29         For dynamic selectors, provide text in the tooltip describing that the
30         specificity is dynamic and may change, and pointing out the element
31         the current value was calculated against.
32
33         * Localizations/en.lproj/localizedStrings.js:
34         * UserInterface/Models/CSSSelector.js:
35         (WebInspector.CSSSelector):
36         (WebInspector.CSSSelector.prototype.get specificity):
37         (WebInspector.CSSSelector.prototype.get dynamic):
38         * UserInterface/Models/DOMNodeStyles.js:
39         (WebInspector.DOMNodeStyles.prototype._parseSelectorListPayload.return):
40         (WebInspector.DOMNodeStyles.prototype._parseSelectorListPayload):
41         * UserInterface/Views/CSSStyleDeclarationSection.js:
42         (WebInspector.CSSStyleDeclarationSection.prototype.refresh.appendSelector):
43
44 2015-01-19  Saam Barati  <saambarati1@gmail.com>
45
46         Web Inspector: Provide a front end for JSC's Control Flow Profiler
47         https://bugs.webkit.org/show_bug.cgi?id=138454
48
49         Reviewed by Timothy Hatcher.
50
51         This patch creates a user interface for JSC's control flow profiler.
52         The Web Inspector gets basic block ranges from JSC, and displays
53         basic blocks that have not executed as having a gray background.
54         
55         BasicBlockAnnotator is the class responsible for this UI logic.
56         It also does a few nifty things when presenting a UI for this gray
57         background color: if an entire line of code is within the basic 
58         block's boundary, the annotator will not just highlight the background 
59         behind the text, but the background of the entire line itself. This
60         provides a nicer experience when glancing through large JavaScript files.
61
62         This patch also adds some necessary wrapper methods inside TextEditor
63         for accessing CodeMirror's text highlighting functionality. It also
64         creates a way for TextEditor and SourceCodeTextEditor to listen
65         for focus events inside CodeMirror.
66
67         * UserInterface/Controllers/AnnotatorManager.js: Removed.
68         * UserInterface/Controllers/BasicBlockAnnotator.js: Added.
69         (WebInspector.BasicBlockAnnotator):
70         (WebInspector.BasicBlockAnnotator.prototype.clearAnnotations):
71         (WebInspector.BasicBlockAnnotator.prototype.insertAnnotations):
72         (WebInspector.BasicBlockAnnotator.prototype._annotateBasicBlockExecutionRanges.):
73         (WebInspector.BasicBlockAnnotator.prototype._annotateBasicBlockExecutionRanges):
74         (WebInspector.BasicBlockAnnotator.prototype.set _highlightTextForBasicBlock):
75         (WebInspector.BasicBlockAnnotator.prototype._isTextRangeOnlyWhitespace):
76         (WebInspector.BasicBlockAnnotator.prototype._canGrayOutEntireLine):
77         (WebInspector.BasicBlockAnnotator.prototype._grayOutLine):
78         (WebInspector.BasicBlockAnnotator.prototype._clearRangeForBasicBlockMarker.get marker):
79         (WebInspector.BasicBlockAnnotator.prototype._clearRangeForBasicBlockMarker):
80         * UserInterface/Main.html:
81         * UserInterface/Views/SourceCodeTextEditor.css:
82         (.basic-block-has-not-executed):
83         (.basic-block-has-not-executed-prepend::before):
84         * UserInterface/Views/SourceCodeTextEditor.js:
85         (WebInspector.SourceCodeTextEditor):
86         (WebInspector.SourceCodeTextEditor.prototype.shown):
87         (WebInspector.SourceCodeTextEditor.prototype.hidden):
88         (WebInspector.SourceCodeTextEditor.prototype.canShowTypeAnnotations):
89         (WebInspector.SourceCodeTextEditor.prototype.contentDidChange):
90         (WebInspector.SourceCodeTextEditor.prototype.gainedFocus):
91         (WebInspector.SourceCodeTextEditor.prototype.lostFocus):
92         (WebInspector.SourceCodeTextEditor.prototype.toggleTypeAnnotations):
93         (WebInspector.SourceCodeTextEditor.prototype.prettyPrint):
94         (WebInspector.SourceCodeTextEditor.prototype._populateWithContent):
95         (WebInspector.SourceCodeTextEditor.prototype._debuggerDidPause):
96         (WebInspector.SourceCodeTextEditor.prototype._debuggerDidResume):
97         (WebInspector.SourceCodeTextEditor.prototype._updateTokenTrackingControllerState):
98         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenAnnotator):
99         (WebInspector.SourceCodeTextEditor.prototype._makeBasicBlockAnnotator):
100         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenScrollEventHandler.scrollHandler):
101         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenScrollEventHandler):
102         * UserInterface/Views/TextEditor.js:
103         (WebInspector.TextEditor):
104         (WebInspector.TextEditor.prototype.getTextInRange):
105         (WebInspector.TextEditor.prototype.addStyleToTextRange):
106         (WebInspector.TextEditor.prototype.gainedFocus):
107         (WebInspector.TextEditor.prototype.lostFocus):
108
109 2015-01-16  Nikita Vasilyev  <nvasilyev@apple.com>
110
111         Web Inspector: Make message selection in the console more readable
112         https://bugs.webkit.org/show_bug.cgi?id=140385
113
114         Reviewed by Timothy Hatcher.
115
116         * UserInterface/Views/LogContentView.css:
117         (.console-item.selected):
118         (.console-messages:focus .console-item.selected):
119         (.console-item.selected .console-message::after):
120         (.console-messages:focus .console-item.selected .console-message::after):
121         (.console-messages:focus .console-item.selected .go-to-link):
122         * UserInterface/Views/Main.css:
123         (.go-to-link):
124         !important statements seem to be unnecessary, remove them.
125
126 2015-01-16  Joseph Pecoraro  <pecoraro@apple.com>
127
128         Web Inspector: Remove unused WebInspector.LocalJSONObject
129         https://bugs.webkit.org/show_bug.cgi?id=140570
130
131         Reviewed by Timothy Hatcher.
132
133         * UserInterface/Protocol/RemoteObject.js:
134         (WebInspector.RemoteObject.fromLocalObject): Deleted.
135         (WebInspector.LocalJSONObject): Deleted.
136         (WebInspector.LocalJSONObject.prototype.get description.switch.case.string_appeared_here): Deleted.
137         (WebInspector.LocalJSONObject.prototype.get description.switch.default): Deleted.
138         (WebInspector.LocalJSONObject.prototype.get description): Deleted.
139         (WebInspector.LocalJSONObject.prototype._concatenate): Deleted.
140         (WebInspector.LocalJSONObject.prototype.get type): Deleted.
141         (WebInspector.LocalJSONObject.prototype.get subtype): Deleted.
142         (WebInspector.LocalJSONObject.prototype.get hasChildren): Deleted.
143         (WebInspector.LocalJSONObject.prototype.getOwnProperties): Deleted.
144         (WebInspector.LocalJSONObject.prototype.getAllProperties): Deleted.
145         (WebInspector.LocalJSONObject.prototype._children.buildProperty): Deleted.
146         (WebInspector.LocalJSONObject.prototype._children): Deleted.
147         (WebInspector.LocalJSONObject.prototype.isError): Deleted.
148
149 2015-01-15  Joseph Pecoraro  <pecoraro@apple.com>
150
151         Web Inspector: Uncaught exceptions, attempting to dispatch unimplemented Network WebSocket methods
152         https://bugs.webkit.org/show_bug.cgi?id=140532
153
154         Reviewed by Timothy Hatcher.
155
156         * UserInterface/Protocol/NetworkObserver.js:
157         (WebInspector.NetworkObserver.prototype.webSocketFrameReceived):
158         (WebInspector.NetworkObserver.prototype.webSocketFrameError):
159         (WebInspector.NetworkObserver.prototype.webSocketFrameSent):
160         Add stubs to prevent an exception when trying to dispatch the event.
161
162 2015-01-15  Joseph Pecoraro  <pecoraro@apple.com>
163
164         Web Inspector: Reopening the inspector can selects a sub-frame instead of the Main Frame's DOM
165         https://bugs.webkit.org/show_bug.cgi?id=140513
166
167         Reviewed by Timothy Hatcher.
168
169         * UserInterface/Models/Frame.js:
170         (WebInspector.Frame.prototype.saveIdentityToCookie):
171         Specifically identify the main frame, so that any sub-frames with the same
172         URL, don't get choosen over the main frame when restoring state from cookie.
173
174 2015-01-15  Joseph Pecoraro  <pecoraro@apple.com>
175
176         Web Inspector: selecting Paint timeline records from sidebar does not trigger preview of paint quad
177         https://bugs.webkit.org/show_bug.cgi?id=139151
178
179         Reviewed by Brian Burg.
180
181         * UserInterface/Views/LayoutTimelineDataGrid.js:
182         (WebInspector.LayoutTimelineDataGrid):
183         (WebInspector.LayoutTimelineDataGrid.prototype.callFramePopoverAnchorElement):
184         (WebInspector.LayoutTimelineDataGrid.prototype.reset): Deleted.
185         (WebInspector.LayoutTimelineDataGrid.prototype.hidden): Deleted.
186         (WebInspector.LayoutTimelineDataGrid.prototype._layoutDataGridSelectedNodeChanged): Deleted.
187         (WebInspector.LayoutTimelineDataGrid.prototype._hideHighlightIfNeeded): Deleted.
188         Move the node highlight from the datagrid to the timeline view because
189         we want this to happen on both the Navigation sidebar and the datagrid.
190
191         * UserInterface/Views/LayoutTimelineView.js:
192         (WebInspector.LayoutTimelineView.prototype.shown):
193         (WebInspector.LayoutTimelineView.prototype.hidden):
194         (WebInspector.LayoutTimelineView.prototype.filterDidChange):
195         (WebInspector.LayoutTimelineView.prototype.reset):
196         (WebInspector.LayoutTimelineView.prototype._treeElementDeselected):
197         (WebInspector.LayoutTimelineView.prototype._treeElementSelected):
198         Update the highlight for major view updates.
199
200         (WebInspector.LayoutTimelineView.prototype._updateHighlight):
201         (WebInspector.LayoutTimelineView.prototype._showHighlightForRecord):
202         (WebInspector.LayoutTimelineView.prototype._hideHighlightIfNeeded):
203         (WebInspector.LayoutTimelineView.prototype._hoveredOrSelectedRecord):
204         Show a highlight for what we are hovering, or what is selected.
205         Note the selected node may not be visible due to filtering.
206
207         (WebInspector.LayoutTimelineView.prototype._mouseOverDataGrid):
208         (WebInspector.LayoutTimelineView.prototype._mouseLeaveDataGrid):
209         (WebInspector.LayoutTimelineView.prototype._mouseOverTreeOutline):
210         (WebInspector.LayoutTimelineView.prototype._mouseLeaveTreeOutline):
211         Update hovered information mousing over the datagrid and tree outline.
212
213         * UserInterface/Views/TimelineContentView.js:
214         (WebInspector.TimelineContentView.prototype.filterDidChange):
215         * UserInterface/Views/TimelineSidebarPanel.js:
216         (WebInspector.TimelineSidebarPanel.prototype.updateFilter):
217         * UserInterface/Views/TimelineView.js:
218         (WebInspector.TimelineView.prototype.filterDidChange):
219         Include a "filterDidChange" TimelineView method that gets called after
220         updateFilter (things like the filter bar or timeline range changes).
221
222         * UserInterface/Views/TreeOutline.js:
223         (TreeOutline.prototype.treeElementFromNode):
224         (TreeOutline.prototype.treeElementFromPoint):
225         Provide a helper to get a tree element from an event target.
226
227 2015-01-13  Joseph Pecoraro  <pecoraro@apple.com>
228
229         Web Inspector: TextEditor doesn't update when resizing console, white space instead of content
230         https://bugs.webkit.org/show_bug.cgi?id=140240
231
232         Reviewed by Timothy Hatcher.
233
234         * UserInterface/Base/Main.js:
235         (WebInspector._consoleResizerMouseDown.dockedResizerDrag):
236         Dispatch the event that signals the console has changed size.
237
238 2015-01-13  Joseph Pecoraro  <pecoraro@apple.com>
239
240         Web Inspector: I do not expect to see the same rule multiple times in styles sidebar
241         https://bugs.webkit.org/show_bug.cgi?id=138185
242
243         Reviewed by Timothy Hatcher.
244
245         In the styles sidebar, don't show a duplicate, lesser-specificity rule even
246         if it matches the selected element multiple times with different selectors
247         in the list.
248
249         * UserInterface/Models/CSSRule.js:
250         (WebInspector.CSSRule.prototype.isEqualTo):
251         CSSRule identifiers are objects.
252
253         * UserInterface/Views/RulesStyleDetailsPanel.js:
254         (WebInspector.RulesStyleDetailsPanel.prototype.refresh):
255         Remove duplicates from the ordered list of style declarations.
256
257 2015-01-12  Jonathan Wells  <jonowells@apple.com>
258
259         Web Inspector: Timeline: when Network Requests view is selected, in progress requests are absent.
260         https://bugs.webkit.org/show_bug.cgi?id=140090
261
262         Reviewed by Timothy Hatcher.
263
264         TimelineContentView#_updateTimes() changed to call WebInspector.timelineSidebarPanel.updateFilter() in addition
265         to updating the layout of the current timeline view. TimelineSidebarPanel.updateFilter() now responsible for
266         updating filtered resources in a TimelineView.
267
268         * UserInterface/Views/NavigationSidebarPanel.js:
269         (WebInspector.NavigationSidebarPanel.prototype._updateFilter):
270         Now handles updating the UI associated with filtering of navigation sidebar tree elements.
271
272         * UserInterface/Views/OverviewTimelineView.js:
273         (WebInspector.OverviewTimelineView.prototype.updateLayout):
274         No longer handles updating other UI along with the navigation sidebar tree elements. That is now handled by
275         WebInspector.TimelineView.prototype.filterUpdated.
276         (WebInspector.OverviewTimelineView.prototype._compareTreeElementsByDetails): Drive-by fix. Missing vars.
277
278         * UserInterface/Views/TimelineContentView.js:
279         (WebInspector.TimelineContentView.prototype._updateTimes): Add call to updateFilter().
280
281         * UserInterface/Views/TimelineView.js:
282         (WebInspector.TimelineView.prototype.filterUpdated):
283         Function added to dispatch a SelectionPathComponentsDidChange event.
284
285 2015-01-09  Enrica Casucci  <enrica@apple.com>
286
287         [iOS] Support additional text styles.
288         https://bugs.webkit.org/show_bug.cgi?id=140310
289         rdar://problem/18568864
290
291         Reviewed by Joseph Pecoraro.
292
293         Add support for three new text styles.
294
295         * UserInterface/Models/CSSKeywordCompletions.js:
296
297 2015-01-09  Timothy Hatcher  <timothy@apple.com>
298
299         Web Inspector: REGRESSION: Navigation sidebar can show blank next to the Console view
300         https://bugs.webkit.org/show_bug.cgi?id=140291
301
302         Reviewed by Joseph Pecoraro.
303
304         * UserInterface/Base/Main.js:
305         (WebInspector.contentLoaded): Don't restore collapsed false if selectedSidebarPanel is null.
306         (WebInspector._sidebarCollapsedStateDidChange): Support a _ignoreNavigationSidebarPanelCollapsedEvent flag
307         to avoid setting _navigationSidebarCollapsedSetting.
308         (WebInspector._navigationSidebarPanelSelected): Force collapsed if selectedSidebarPanel is null.
309         (WebInspector._contentBrowserCurrentContentViewDidChange): Set _ignoreNavigationSidebarPanelCollapsedEvent
310         when forcing the collapsed state to avoid setting _navigationSidebarCollapsedSetting and calling
311         _updateContentViewForCurrentNavigationSidebar.
312
313 2015-01-08  Nikita Vasilyev  <nvasilyev@apple.com>
314
315         Web Inspector: REGRESSION Showing debugger sidebar shouldn't change selected JS file
316         https://bugs.webkit.org/show_bug.cgi?id=139526
317
318         Reviewed by Timothy Hatcher.
319
320         * UserInterface/Base/Main.js:
321         (WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar):
322         When switching to Debugger, show last selected JS or HTML resource.
323
324         (WebInspector.showSplitConsole):
325         (WebInspector.showFullHeightConsole):
326         (WebInspector.toggleConsoleView):
327         (WebInspector._sidebarCollapsedStateDidChange):
328         (WebInspector._updateContentViewForCurrentNavigationSidebar):
329         (WebInspector._navigationSidebarPanelSelected):
330         (WebInspector._contentBrowserCurrentContentViewDidChange):
331         (WebInspector._updateNavigationSidebarForCurrentContentView): Deleted.
332         * UserInterface/Views/ApplicationCacheFrameContentView.js:
333         (WebInspector.ApplicationCacheFrameContentView.prototype.get allowedNavigationSidebarPanels):
334         * UserInterface/Views/CookieStorageContentView.js:
335         (WebInspector.CookieStorageContentView.prototype.get allowedNavigationSidebarPanels):
336         * UserInterface/Views/DOMStorageContentView.js:
337         (WebInspector.DOMStorageContentView.prototype.get allowedNavigationSidebarPanels):
338         * UserInterface/Views/DOMTreeContentView.js:
339         (WebInspector.DOMTreeContentView.prototype.get allowedNavigationSidebarPanels):
340         * UserInterface/Views/DatabaseContentView.js:
341         (WebInspector.DatabaseContentView.prototype.get allowedNavigationSidebarPanels):
342         * UserInterface/Views/DatabaseTableContentView.js:
343         (WebInspector.DatabaseTableContentView.prototype.get allowedNavigationSidebarPanels):
344         * UserInterface/Views/FontResourceContentView.js:
345         (WebInspector.FontResourceContentView.prototype.get allowedNavigationSidebarPanels):
346         * UserInterface/Views/FrameDOMTreeContentView.js:
347         (WebInspector.FrameDOMTreeContentView.prototype.get allowedNavigationSidebarPanels):
348         * UserInterface/Views/LogContentView.js:
349         (WebInspector.LogContentView.prototype.get allowedNavigationSidebarPanels):
350         * UserInterface/Views/ResourceClusterContentView.js:
351         (WebInspector.ResourceClusterContentView.prototype.get allowedNavigationSidebarPanels):
352         * UserInterface/Views/ResourceSidebarPanel.js:
353         (WebInspector.ResourceSidebarPanel.prototype.showDefaultContentView):
354         (WebInspector.ResourceSidebarPanel.prototype.showMainFrame):
355         * UserInterface/Views/Sidebar.js:
356         (WebInspector.Sidebar.prototype.removeSidebarPanel):
357         * UserInterface/Views/TimelineContentView.js:
358         (WebInspector.TimelineContentView.prototype.get allowedNavigationSidebarPanels):
359
360 2015-01-08  Joseph Pecoraro  <pecoraro@apple.com>
361
362         Web Inspector: Phantom breakpoint appears on empty line after reload of minified file with a breakpoint
363         https://bugs.webkit.org/show_bug.cgi?id=140276
364
365         Reviewed by Timothy Hatcher.
366
367         Styles being set on lines (e.g. breakpoint styles) before content loaded can
368         carry forward with the empty line. It is safe for us to just remove all
369         the styles from the intial empty line before we load the initial content.
370
371         * UserInterface/Views/TextEditor.js:
372         (WebInspector.TextEditor.prototype.set string.update):
373         (WebInspector.TextEditor.prototype.set string):
374
375 2015-01-08  Joseph Pecoraro  <pecoraro@apple.com>
376
377         Web Inspector: Pause Reason Improvements (Breakpoint, Debugger Statement, Pause on Next Statement)
378         https://bugs.webkit.org/show_bug.cgi?id=138991
379
380         Reviewed by Timothy Hatcher.
381
382         * Localizations/en.lproj/localizedStrings.js:
383         New UI strings for Pause Reasons.
384
385         * UserInterface/Controllers/DebuggerManager.js:
386         (WebInspector.DebuggerManager.prototype.breakpointForIdentifier):
387         Provide a way to get the breakpoint with an identifier.
388
389         * UserInterface/Images/PausedBreakpoint.svg: Added.
390         * UserInterface/Images/gtk/PausedBreakpoint.svg: Added.
391         Copy PseudoElement.svg icon and give it a new name.
392
393         * UserInterface/Views/BreakpointTreeElement.css:
394         (.breakpoint-paused-icon .icon):
395         New icon for a breakpoint causing a pause.
396
397         * UserInterface/Views/BreakpointTreeElement.js:
398         (WebInspector.BreakpointTreeElement.prototype.removeStatusImage):
399         (WebInspector.BreakpointTreeElement.prototype._updateStatus):
400         Give API to remove the breakpoint status icon from a BreakpointTreeElement.
401
402         * UserInterface/Views/DebuggerSidebarPanel.js:
403         (WebInspector.DebuggerSidebarPanel):
404         (WebInspector.DebuggerSidebarPanel.prototype.get hasSelectedElement):
405         (WebInspector.DebuggerSidebarPanel.prototype.deselectBreakpointContentTreeElements):
406         (WebInspector.DebuggerSidebarPanel.prototype.deselectPauseReasonContentTreeElements):
407         (WebInspector.DebuggerSidebarPanel.prototype._treeElementSelected):
408         Give DebuggerSidebarPanel an optional pause reason tree outline. When available
409         include it in the pattern of ensuring a single exclusive selection.
410
411         (WebInspector.DebuggerSidebarPanel.prototype._breakpointRemoved):
412         When a breakpoint is removed, check if we should update the pause reason tree outline.
413
414         (WebInspector.DebuggerSidebarPanel.prototype._updatePauseReason):
415         (WebInspector.DebuggerSidebarPanel.prototype._updatePauseReasonSection):
416         Update Pause Reason section contents depending on the reason.
417
418         (WebInspector.DebuggerSidebarPanel.prototype._updatePauseReasonGotoArrow):
419         Always try to include a goto arrow to jump to the original pause location
420         if it is available at the time of pausing.
421
422 2015-01-08  Joseph Pecoraro  <pecoraro@apple.com>
423
424         Web Inspector: Expected UserAgent styles to be crossed-out if overridden
425         https://bugs.webkit.org/show_bug.cgi?id=140154
426
427         Reviewed by Timothy Hatcher.
428
429         * UserInterface/Models/DOMNodeStyles.js:
430         (WebInspector.DOMNodeStyles.prototype._parseStylePropertyPayload):
431         Add a comment about anonymous styles. The getter is no longer used, and it is not
432         clear if we really care about this state, or if "anonymous" is an appropriate name.
433
434         (WebInspector.DOMNodeStyles.prototype._markOverriddenProperties):
435         Allow browser styles (user agent / html attributes) to be overridden.
436
437         (WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
438         When refreshing styles after changes, the Style object backing HTML attributes
439         was being completely replaced. Allow it to be remembered by a unique key.
440
441 2015-01-07  Joseph Pecoraro  <pecoraro@apple.com>
442
443         Web Inspector: Do not create rulesMap entries for rules without identifiers
444         https://bugs.webkit.org/show_bug.cgi?id=140237
445
446         Reviewed by Timothy Hatcher.
447
448         * UserInterface/Models/DOMNodeStyles.js:
449         (WebInspector.DOMNodeStyles.prototype._parseRulePayload):
450         We were accidentally converting a null into a string with a loose string
451         concatenation. Only do this if the mapKey is not-null.
452
453 2015-01-07  Saam Barati  <saambarati1@gmail.com>
454
455         Web Inspector: Abstract common functions from TypeTokenAnnotator into a parent class and introduce an AnnotatorManager
456         https://bugs.webkit.org/show_bug.cgi?id=139426
457
458         Reviewed by Timothy Hatcher.
459
460         This patch creates a parent class, Annotator, that TypeTokenAnnotator
461         inherits from. Annotator defines a common set of functionality
462         that a text editor annotator can use to mark up UI. This 
463         is in preparation other classes that will inherit from Annotator.
464         
465         This patch also introduces AnnotatorManager which controls a
466         set of Annotators and provides a single interface for
467         controlling them.
468
469         * UserInterface/Controllers/Annotator.js: Added.
470         (WebInspector.Annotator):
471         (WebInspector.Annotator.prototype.get sourceCodeTextEditor):
472         (WebInspector.Annotator.prototype.get isActive):
473         (WebInspector.Annotator.prototype.pause):
474         (WebInspector.Annotator.prototype.resume):
475         (WebInspector.Annotator.prototype.refresh):
476         (WebInspector.Annotator.prototype.reset):
477         (WebInspector.Annotator.prototype.clear):
478         (WebInspector.Annotator.prototype.insertAnnotations):
479         (WebInspector.Annotator.prototype.clearAnnotations):
480         (WebInspector.Annotator.prototype._clearTimeoutIfNeeded):
481         * UserInterface/Controllers/AnnotatorManager.js: Added.
482         (WebInspector.AnnotatorManager):
483         (WebInspector.AnnotatorManager.prototype.addAnnotator):
484         (WebInspector.AnnotatorManager.prototype.isAnnotatorActive):
485         (WebInspector.AnnotatorManager.prototype.pauseAll):
486         (WebInspector.AnnotatorManager.prototype.resumeAll):
487         (WebInspector.AnnotatorManager.prototype.refreshAllIfActive):
488         (WebInspector.AnnotatorManager.prototype.resetAllIfActive):
489         (WebInspector.AnnotatorManager.prototype.clearAll):
490         (WebInspector.AnnotatorManager.prototype.removeAllAnnotators):
491         (WebInspector.AnnotatorManager.prototype._getAnnotators):
492         * UserInterface/Controllers/TypeTokenAnnotator.js:
493         (WebInspector.TypeTokenAnnotator):
494         (WebInspector.TypeTokenAnnotator.prototype.insertAnnotations.):
495         (WebInspector.TypeTokenAnnotator.prototype.clearAnnotations):
496         (WebInspector.TypeTokenAnnotator.prototype._insertToken):
497         (WebInspector.TypeTokenAnnotator.prototype.get isActive): Deleted.
498         (WebInspector.TypeTokenAnnotator.prototype.get sourceCodeTextEditor): Deleted.
499         (WebInspector.TypeTokenAnnotator.prototype.pause): Deleted.
500         (WebInspector.TypeTokenAnnotator.prototype.resume): Deleted.
501         (WebInspector.TypeTokenAnnotator.prototype.refresh): Deleted.
502         (WebInspector.TypeTokenAnnotator.prototype.reset): Deleted.
503         (WebInspector.TypeTokenAnnotator.prototype._insertAnnotations.): Deleted.
504         (WebInspector.TypeTokenAnnotator.prototype._clearTimeoutIfNeeded): Deleted.
505         * UserInterface/Main.html:
506         * UserInterface/Views/SourceCodeTextEditor.js:
507         (WebInspector.SourceCodeTextEditor):
508         (WebInspector.SourceCodeTextEditor.prototype.shown):
509         (WebInspector.SourceCodeTextEditor.prototype.hidden):
510         (WebInspector.SourceCodeTextEditor.prototype.canShowTypeAnnotations):
511         (WebInspector.SourceCodeTextEditor.prototype.contentDidChange):
512         (WebInspector.SourceCodeTextEditor.prototype.toggleTypeAnnotations):
513         (WebInspector.SourceCodeTextEditor.prototype.prettyPrint):
514         (WebInspector.SourceCodeTextEditor.prototype._debuggerDidPause):
515         (WebInspector.SourceCodeTextEditor.prototype._debuggerDidResume):
516         (WebInspector.SourceCodeTextEditor.prototype._updateTokenTrackingControllerState):
517         (WebInspector.SourceCodeTextEditor.prototype._getAssociatedScript):
518         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenAnnotator):
519         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenScrollEventHandler.scrollHandler):
520         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenScrollEventHandler):
521
522 2015-01-06  Joseph Pecoraro  <pecoraro@apple.com>
523
524         Web Inspector: Do not style implicit CSS properties in the Style Rules section
525         https://bugs.webkit.org/show_bug.cgi?id=140161
526
527         Reviewed by Timothy Hatcher.
528
529         Previously, implicit properties being transparent in the Rules section
530         was confusing and not useful. Lets simplify what transparency means:
531
532             - Rules:  transparency means a non-inheritable property in an inherited rule
533             - Computed: transparency means an implicit value
534
535         * UserInterface/Views/CSSStyleDeclarationTextEditor.css:
536         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property.not-inherited):
537         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property:matches(.implicit, .not-inherited)): Deleted.
538
539 2015-01-06  Joseph Pecoraro  <pecoraro@apple.com>
540
541         Web Inspector: Uncaught Exception when dismissing Go To Line dialog
542         https://bugs.webkit.org/show_bug.cgi?id=139663
543
544         Reviewed by Timothy Hatcher.
545
546         Calling removeChild would trigger the blur event handler and do a
547         nested call of dismiss(), re-entering and removing while in the middle
548         of removing. Avoid re-entrancy to avoid the exception.
549
550         * UserInterface/Views/GoToLineDialog.js:
551         (WebInspector.GoToLineDialog):
552         (WebInspector.GoToLineDialog.prototype.dismiss):
553
554 2015-01-01  Darin Adler  <darin@apple.com>
555
556         We often misspell identifier as "identifer"
557         https://bugs.webkit.org/show_bug.cgi?id=140025
558
559         Reviewed by Michael Saboff.
560
561         * UserInterface/Base/Main.js:
562         (WebInspector._updateNavigationSidebarForCurrentContentView):
563         (WebInspector._contentBrowserCurrentContentViewDidChange):
564         Fix misspellings.
565
566 2014-12-29  Jonathan Wells  <jonowells@apple.com>
567
568         Web Inspector: SourceCode.requestContent should return a promise
569         https://bugs.webkit.org/show_bug.cgi?id=135777
570
571         Reviewed by Brian Burg.
572
573         Change SourceCode.js to request content from the backend using Promises. Change Resource.js to use this new
574         approach when determining whether a resource load has finished. Change all calls to the older
575         SourceCode#requestContentFromBackendIfNeeded to simply use requestContent and use a catch function
576         if a content request error needs to be handled. Fix a bug where the appropriate error message for an
577         invalid resource wasn't showing in the resource content view.
578
579         * UserInterface/Controllers/AnalyzerManager.js:
580         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode.):
581         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode):
582         * UserInterface/Controllers/CSSStyleManager.js:
583         (WebInspector.CSSStyleManager.prototype._updateResourceContent.fetchedStyleSheetContent):
584         (WebInspector.CSSStyleManager.prototype._updateResourceContent.styleSheetReady):
585         * UserInterface/Models/CSSStyleSheet.js:
586         (WebInspector.CSSStyleSheet.prototype.requestContentFromBackend):
587         (WebInspector.CSSStyleSheet.prototype.canRequestContentFromBackend): Deleted.
588         * UserInterface/Models/DOMNodeStyles.js:
589         (WebInspector.DOMNodeStyles.prototype.changeStyleText):
590         * UserInterface/Models/Resource.js:
591         (WebInspector.Resource.prototype.canRequestContent):
592         (WebInspector.Resource.prototype.requestContentFromBackend):
593         (WebInspector.Resource.prototype.markAsFinished):
594         (WebInspector.Resource.prototype.markAsFailed):
595         (WebInspector.Resource.prototype.getImageSize):
596         (WebInspector.Resource.prototype.canRequestContentFromBackend): Deleted.
597         * UserInterface/Models/Script.js:
598         (WebInspector.Script.prototype.requestContentFromBackend):
599         (WebInspector.Script.prototype.requestScriptSyntaxTree.catch):
600         (WebInspector.Script.prototype.canRequestContentFromBackend): Deleted.
601         * UserInterface/Models/SourceCode.js:
602         (WebInspector.SourceCode):
603         (WebInspector.SourceCode.prototype.requestContent):
604         (WebInspector.SourceCode.prototype.requestContentFromBackend):
605         (WebInspector.SourceCode.prototype._processContent):
606         (WebInspector.SourceCode.prototype.canRequestContentFromBackend): Deleted.
607         (WebInspector.SourceCode.prototype.requestContentFromBackendIfNeeded): Deleted.
608         (WebInspector.SourceCode.prototype.servicePendingContentRequests): Deleted.
609         * UserInterface/Models/SourceMapResource.js:
610         (WebInspector.SourceMapResource):
611         (WebInspector.SourceMapResource.prototype.requestContentFromBackend.sourceMapResourceLoadError):
612         (WebInspector.SourceMapResource.prototype.requestContentFromBackend):
613         (WebInspector.SourceMapResource.prototype.canRequestContentFromBackend): Deleted.
614         (WebInspector.SourceMapResource.prototype.requestContentFromBackend.sourceMapResourceLoaded): Deleted.
615         * UserInterface/Views/ResourceContentView.js:
616         (WebInspector.ResourceContentView):
617         (WebInspector.ResourceContentView.prototype._contentAvailable):
618         (WebInspector.ResourceContentView.prototype._contentError):
619         * UserInterface/Views/SourceCodeTextEditor.js:
620         (WebInspector.SourceCodeTextEditor):
621         (WebInspector.SourceCodeTextEditor.prototype._contentAvailable):
622         (WebInspector.SourceCodeTextEditor.prototype._populateWithInlineScriptContent.scriptContentAvailable):
623         (WebInspector.SourceCodeTextEditor.prototype._populateWithInlineScriptContent):
624         (WebInspector.SourceCodeTextEditor.prototype._populateWithScriptContent):
625
626 2014-12-26  Dan Bernstein  <mitz@apple.com>
627
628         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
629         https://bugs.webkit.org/show_bug.cgi?id=139950
630
631         Reviewed by David Kilzer.
632
633         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
634         in a manner that works with Xcode 5.1.1.
635
636 2014-12-20  David Kilzer  <ddkilzer@apple.com>
637
638         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
639         <http://webkit.org/b/139463>
640
641         Reviewed by Mark Rowe.
642
643         * Configurations/Base.xcconfig:
644         - Only set TOOLCHAINS on OS X.
645         * Configurations/DebugRelease.xcconfig:
646         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
647         * Configurations/Version.xcconfig:
648         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
649         * Configurations/WebInspectorUIFramework.xcconfig:
650         - Set NORMAL_PRODUCTION_FRAMEWORKS_DIR,
651           PRODUCTION_FRAMEWORKS_DIR and
652           JAVASCRIPTCORE_PRIVATE_HEADERS_DIR_Production by SDK.
653
654 2014-12-19  Commit Queue  <commit-queue@webkit.org>
655
656         Unreviewed, rolling out r177574.
657         https://bugs.webkit.org/show_bug.cgi?id=139821
658
659         "Broke Production builds by installing
660         libWebCoreTestSupport.dylib in the wrong directory" (Requested
661         by ddkilzer on #webkit).
662
663         Reverted changeset:
664
665         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
666         WebInspectorUI, WebKit, WebKit2"
667         https://bugs.webkit.org/show_bug.cgi?id=139463
668         http://trac.webkit.org/changeset/177574
669
670 2014-12-19  David Kilzer  <ddkilzer@apple.com>
671
672         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
673         <http://webkit.org/b/139463>
674
675         Reviewed by Mark Rowe.
676
677         * Configurations/Base.xcconfig:
678         - Only set TOOLCHAINS on OS X.
679         * Configurations/DebugRelease.xcconfig:
680         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
681         * Configurations/Version.xcconfig:
682         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
683         * Configurations/WebInspectorUIFramework.xcconfig:
684         - Set NORMAL_PRODUCTION_FRAMEWORKS_DIR,
685           PRODUCTION_FRAMEWORKS_DIR and
686           JAVASCRIPTCORE_PRIVATE_HEADERS_DIR_Production by SDK.
687
688 2014-12-16  Matt Baker  <mattbaker@apple.com>
689
690         Web Inspector: REGRESSION: Dragging undocked web inspector causes mouse to change from pointer to i-bar cursor over window title
691         https://bugs.webkit.org/show_bug.cgi?id=139720
692
693         Reviewed by Timothy Hatcher.
694
695         * UserInterface/Base/Main.js:
696         Prevent default handling of the mouse event when clicking in the titlebar area. WebCore won't continue handling the event,
697         but docking buttons/context menu still function.
698
699 2014-12-15  Nikita Vasilyev  <nvasilyev@apple.com>
700
701         Web Inspector: Clicking on the expand object arrow should always expand an object
702         https://bugs.webkit.org/show_bug.cgi?id=139382
703
704         Reviewed by Joseph Pecoraro.
705
706         * UserInterface/Views/LogContentView.js:
707         (WebInspector.LogContentView):
708         (WebInspector.LogContentView.prototype._click): Deleted.
709         stopPropagation was preventing the object expansion from happening as expecting.
710
711 2014-12-15  Joseph Pecoraro  <pecoraro@apple.com>
712
713         Web Inspector: CSSStyleDeclarationTextEditor fails to update if computed properties changed from empty to non-empty
714         https://bugs.webkit.org/show_bug.cgi?id=139610
715
716         Reviewed by Timothy Hatcher.
717
718         The CSSStyleDeclarationTextEditor for Computed Style Properties always has
719         empty DOMNodeStyles text. However we would not reset contents if properties
720         changed and the actualy content was empty. So once empty, we could never
721         recover. In fact, we should always refresh for Computed Styles.
722
723         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
724         (WebInspector.CSSStyleDeclarationTextEditor.prototype._propertiesChanged):
725
726 2014-12-08  Joseph Pecoraro  <pecoraro@apple.com>
727
728         Web Inspector: Hide Compositing Borders Button if backend returns an error that it is unsupported
729         https://bugs.webkit.org/show_bug.cgi?id=139307
730
731         Reviewed by Darin Adler.
732
733         * UserInterface/Views/DOMTreeContentView.js:
734         (WebInspector.DOMTreeContentView.prototype._updateCompositingBordersButtonToMatchPageSettings):
735
736 2014-12-05  Joseph Pecoraro  <pecoraro@apple.com>
737
738         Web Inspector: Uncaught Exceptions when attempting to show Content Flow
739         https://bugs.webkit.org/show_bug.cgi?id=139276
740
741         Reviewed by Brian Burg.
742
743         * UserInterface/Views/ContentView.js:
744         (WebInspector.ContentView):
745         (WebInspector.ContentView.isViewable):
746         LegacyJavaScriptProfileObject no longer exists, these references should be removed.
747
748         * UserInterface/Views/FolderizedTreeElement.js:
749         (WebInspector.FolderizedTreeElement.prototype._insertChildTreeElement):
750         This sort function references "this" and needed to be bound.
751
752 2014-12-04  Joseph Pecoraro  <pecoraro@apple.com>
753
754         Web Inspector: Network Timeline Filter Bar only has "All", missing Resource Type filters
755         https://bugs.webkit.org/show_bug.cgi?id=139268
756
757         Reviewed by Brian Burg.
758
759         * UserInterface/Views/TimelineDataGrid.js:
760         (WebInspector.TimelineDataGrid.createColumnScopeBar):
761         Users of createColumnScopeBar pass a Map object now instead of a dictionary.
762         Iterate over the map appropriately.
763
764 2014-12-04  Joseph Pecoraro  <pecoraro@apple.com>
765
766         Web Inspector: LayoutTests/inspector tests fail in Production builds due to missing test resources
767         https://bugs.webkit.org/show_bug.cgi?id=138898
768
769         Reviewed by Mark Rowe.
770
771         In Production builds, if FORCE_TOOL_INSTALL=YES is in the environment
772         we will copy all resources (for Tests) and still do the combine and
773         optimize phase for normal Production inspection resources.
774
775         * Scripts/copy-user-interface-resources.pl:
776
777 2014-12-03  Joseph Pecoraro  <pecoraro@apple.com>
778
779         Web Inspector: Missing getter, clients never see DragToAdjustController is enabled
780         https://bugs.webkit.org/show_bug.cgi?id=139228
781
782         Reviewed by Simon Fraser.
783
784         * UserInterface/Controllers/DragToAdjustController.js:
785         (WebInspector.DragToAdjustController.prototype.get enabled):
786
787 2014-12-02  Joseph Pecoraro  <pecoraro@apple.com>
788
789         Web Inspector: CSS Minification breaks some selectors with colons
790         https://bugs.webkit.org/show_bug.cgi?id=139206
791
792         Reviewed by Simon Fraser.
793
794         Do not remove spaces preceeding colons, as they may change the semantics
795         of selectors with colon prefixes (e.g. "a :not(b)").
796
797         At the same time, we can strip spaces around "!" characters, for example
798         a space is not required before "!important" priority.
799
800         * Scripts/cssmin.py:
801         (cssminify):
802
803 2014-12-01  Benjamin Poulain  <benjamin@webkit.org>
804
805         Web Inspector: add more :not() and :matches() awesomeness
806         https://bugs.webkit.org/show_bug.cgi?id=138997
807
808         Reviewed by Joseph Pecoraro.
809
810         Simplify the Inspector's CSS when possible.
811
812         * UserInterface/Views/DatabaseContentView.css:
813         (:matches(.database-user-query, .database-query-prompt, .database-query-result)::before):
814         (.database-user-query::before, .database-query-prompt::before, .database-query-result::before): Deleted.
815         * UserInterface/Views/GradientSlider.css:
816         (.gradient-slider-knob > :matches(img, div)):
817         (.gradient-slider-knob > div): Deleted.
818         * UserInterface/Views/HoverMenu.css:
819         (.hover-menu > svg > :matches(path, rect)):
820         (.hover-menu > svg > rect): Deleted.
821         * UserInterface/Views/LayerTreeDetailsSidebarPanel.css:
822         (.panel.details.layer-tree .name-column :matches(.pseudo-element, .reflection)):
823         (.panel.details.layer-tree tr.selected .name-column :matches(.pseudo-element, .reflection)):
824         (.panel.details.layer-tree .name-column .reflection): Deleted.
825         (.panel.details.layer-tree tr.selected .name-column .reflection): Deleted.
826         * UserInterface/Views/ProbeDetailsSidebarPanel.css:
827         (.details-section.probe-set .options > :matches(.probe-remove, .probe-clear-samples, .probe-add)):
828         (.details-section.probe-set .options > .probe-add): Deleted.
829         * UserInterface/Views/ResourceSidebarPanel.css:
830         (.sidebar > .panel.navigation.resource > :matches(.content, .empty-content-placeholder)):
831         (body.mac-platform.legacy .sidebar > .panel.navigation.resource > :matches(.content, .empty-content-placeholder)):
832         (.sidebar > .panel.navigation.resource > .empty-content-placeholder): Deleted.
833         (body.mac-platform.legacy .sidebar > .panel.navigation.resource > .empty-content-placeholder): Deleted.
834         * UserInterface/Views/ScopeBar.css:
835         (.scope-bar > li:matches(.selected, :active)):
836         (.scope-bar > li:active): Deleted.
837         * UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
838         (.syntax-highlighted :matches(.css-comment, .javascript-comment, .html-comment)):
839         (.syntax-highlighted :matches(.css-keyword, .css-tag, .css-at-rule, .css-important, .javascript-keyword, .html-tag)):
840         (.syntax-highlighted :matches(.css-number, .javascript-number)):
841         (.syntax-highlighted :matches(.css-property, .css-selector, .javascript-ident)):
842         (.syntax-highlighted :matches(.css-string, .javascript-string, .javascript-regexp, .html-attribute-value)):
843         (.syntax-highlighted :matches(.html-doctype, .html-processing-instruction)):
844         (.syntax-highlighted .html-comment): Deleted.
845         (.syntax-highlighted .html-tag): Deleted.
846         (.syntax-highlighted .javascript-number): Deleted.
847         (.syntax-highlighted .javascript-ident): Deleted.
848         (.syntax-highlighted .html-attribute-value): Deleted.
849         (.syntax-highlighted .html-processing-instruction): Deleted.
850         It looks like ".cm-tag.cm-bracket" was there only to override the rule below.
851         From basic testing, it looks like "cm-tag" and "cm-bracket" always appear together. I removed the "cm-bracket" rule
852         from the second rule, and simplified the first rule.
853
854         * UserInterface/Views/TimelineSidebarPanel.css:
855         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > :matches(.content, .empty-content-placeholder)):
856         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .empty-content-placeholder): Deleted.
857         * UserInterface/Views/Toolbar.css:
858         (body.mac-platform:not(.legacy, .docked) .toolbar):
859         (body.mac-platform:not(.legacy, .docked) .toolbar.icon-and-label-vertical):
860         (body.mac-platform:not(.legacy, .docked) .toolbar.icon-and-label-vertical.small-size):
861         (body.mac-platform:not(.legacy, .docked) .toolbar:matches(.icon-and-label-horizontal, .icon-only)):
862         (body.mac-platform:not(.legacy, .docked) .toolbar:matches(.icon-and-label-horizontal.small-size, .icon-only.small-size, .label-only)):
863         (.toolbar:matches(.icon-and-label-horizontal.small-size, .icon-only.small-size, .label-only) .control-section):
864         (body.mac-platform:not(.legacy):not(.docked) .toolbar): Deleted.
865         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical): Deleted.
866         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical.small-size): Deleted.
867         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-only): Deleted.
868         (body.mac-platform:not(.legacy):not(.docked) .toolbar.label-only): Deleted.
869         (.toolbar.label-only .control-section): Deleted.
870
871 2014-11-27  Andres Gomez  <agomez@igalia.com>
872
873         Web Inspector: Update NavigationItemProbes icon for the GTK+ port
874         https://bugs.webkit.org/show_bug.cgi?id=139074
875
876         Reviewed by Carlos Garcia Campos.
877
878         NavigationItemProbes was updated for the Mac port and we are now
879         having a similar ideogram in GTK+.
880
881         * UserInterface/Images/gtk/NavigationItemProbes.svg: Updated.
882
883 2014-11-21  Benjamin Poulain  <bpoulain@apple.com>
884
885         Start using the new :not() and :matches() in the Web Inspector
886         https://bugs.webkit.org/show_bug.cgi?id=138978
887
888         Reviewed by Joseph Pecoraro.
889
890         Start simpifying some definitions by using modern CSS.
891
892         * UserInterface/Views/CSSStyleDeclarationSection.css:
893         (body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section:matches(.last-in-group, :last-child)):
894         (.style-declaration-section:matches(.locked, .selector-locked) > .header > .selector):
895         (body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section:last-child): Deleted.
896         (.style-declaration-section.selector-locked > .header > .selector): Deleted.
897         * UserInterface/Views/CSSStyleDeclarationTextEditor.css:
898         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property:matches(.disabled, .invalid, .other-vendor, .not-inherited, .overridden)):
899         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property:matches(.implicit, .not-inherited)):
900         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .editing-line .css-style-declaration-property:matches(.disabled, .other-vendor, .not-inherited, .overridden)):
901         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property.overridden): Deleted.
902         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property.not-inherited): Deleted.
903         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .editing-line .css-style-declaration-property.overridden): Deleted.
904         * UserInterface/Views/ControlToolbarItem.css:
905         (.toolbar:matches(.icon-and-label-horizontal, .toolbar.icon-only) .item.control):
906         (.toolbar.icon-only .item.control): Deleted.
907         * UserInterface/Views/DOMStorageContentView.css:
908         * UserInterface/Views/DashboardContainerView.css:
909         (.toolbar.icon-and-label-vertical:matches(.small-size, .normal-size) .dashboard-container):
910         (.toolbar:matches(.label-only, .small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal)) .dashboard-container):
911         (.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard-container):
912         (.toolbar.normal-size.icon-and-label-vertical .dashboard-container): Deleted.
913         (.toolbar.small-size.icon-and-label-horizontal .dashboard-container): Deleted.
914         (.toolbar.normal-size.icon-and-label-horizontal .dashboard-container): Deleted.
915         * UserInterface/Views/DataGrid.css:
916         (.data-grid :matches(th, td):not(:last-child)):
917         (.data-grid th:matches(.sort-ascending, .sort-descending)):
918         (.data-grid :matches(th, td) > div):
919         (.data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child):
920         (.data-grid tr:matches(.selected, :hover) .go-to-arrow):
921         (.data-grid :-webkit-any(th, td):not(:last-child)): Deleted.
922         (.data-grid th:-webkit-any(.sort-ascending, .sort-descending)): Deleted.
923         (.data-grid :-webkit-any(th, td) > div): Deleted.
924         (.data-grid th:-webkit-any(.sort-ascending, .sort-descending) > div:first-child): Deleted.
925         (.data-grid tr:-webkit-any(.selected, :hover) .go-to-arrow): Deleted.
926         * UserInterface/Views/DebuggerDashboardView.css:
927         (.toolbar.collapsed .dashboard.debugger > :not(.message, .navigation-bar )):
928         (.toolbar.collapsed .dashboard.debugger > :not(.message):not(.navigation-bar )): Deleted.
929         * UserInterface/Views/DefaultDashboardView.css:
930         (body.web .toolbar.collapsed .dashboard.default > :matches(.time, .resourcesSize, .logs)):
931         (body.javascript .toolbar .dashboard.default > :matches(.time, .resourcesSize, .resourcesCount)):
932         (.toolbar:matches(.label-only, .small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal)) .dashboard.default > .item):
933         (.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard.default > .item):
934         (body.web .toolbar.collapsed .dashboard.default > .logs): Deleted.
935         (body.javascript .toolbar .dashboard.default > .resourcesCount): Deleted.
936         (.toolbar.small-size.icon-and-label-horizontal .dashboard.default > .item): Deleted.
937         (.toolbar.normal-size.icon-and-label-horizontal .dashboard.default > .item): Deleted.
938         * UserInterface/Views/DetailsSection.css:
939         (.details-section > .header > :matches(.node-link, .go-to-arrow)):
940         (.details-section > .content > .group:nth-child(even) > .row:matches(.simple:first-child > *, :not(.simple):first-child)):
941         (body.mac-platform.legacy .details-section > .content > .group:matches(:nth-child(even), :last-child) > .row.simple:last-child > *):
942         (.details-section > .content > .group > .row:matches(.empty, .text)):
943         (body.mac-platform.legacy .details-section > .content > .group > .row:matches(.empty, .text)):
944         (.details-section > .header > .go-to-arrow): Deleted.
945         (.details-section > .content > .group:nth-child(even) > .row.simple:first-child > *): Deleted.
946         (body.mac-platform.legacy .details-section > .content > .group:last-child > .row.simple:last-child > *): Deleted.
947         (.details-section > .content > .group > .row.text): Deleted.
948         (body.mac-platform.legacy .details-section > .content > .group > .row.text): Deleted.
949         * UserInterface/Views/FindBanner.css:
950         (:matches(.find-banner, .supports-find-banner).no-find-banner-transition):
951         (.supports-find-banner.no-find-banner-transition): Deleted.
952         * UserInterface/Views/FlexibleSpaceNavigationItem.css:
953         (:matches(.navigation-bar, .toolbar) .item.flexible-space):
954         (.toolbar .item.flexible-space): Deleted.
955
956 2014-11-19  Joseph Pecoraro  <pecoraro@apple.com>
957
958         Web Inspector: LayoutTests/inspector should not have localStorage side effects
959         https://bugs.webkit.org/show_bug.cgi?id=138895
960
961         Reviewed by Brian Burg.
962
963         When running inspector tests, do not restore/save WebInspector.Settings
964         to localStorage, as that will cause side effects. Instead each Setting
965         will be initialized with its default value and can be modified during
966         the run of the test.
967
968         * UserInterface/Base/Test.js:
969         (WebInspector.loaded):
970         Name the setting to match the normal setting name now that persistence
971         is not an issue.
972
973         * UserInterface/Models/Setting.js:
974         (WebInspector.Setting.prototype.get value):
975         (WebInspector.Setting.prototype.set value):
976         Do not restore/save when in tests.
977
978 2014-11-19  Joseph Pecoraro  <pecoraro@apple.com>
979
980         Web Inspector: JSContext inspection Resource search does not work
981         https://bugs.webkit.org/show_bug.cgi?id=131252
982
983         Reviewed by Timothy Hatcher.
984
985         * UserInterface/Views/ResourceSidebarPanel.js:
986         (WebInspector.ResourceSidebarPanel.prototype.performSearch.resourceCallback):
987         (WebInspector.ResourceSidebarPanel.prototype.performSearch.resourcesCallback):
988         Cleanup by reordering things a bit.
989
990         (WebInspector.ResourceSidebarPanel.prototype.performSearch.searchScripts.scriptCallback):
991         (WebInspector.ResourceSidebarPanel.prototype.performSearch.searchScripts):
992         (WebInspector.ResourceSidebarPanel.prototype.performSearch):
993         Search non-resource scripts individually.
994
995         (WebInspector.ResourceSidebarPanel.prototype._searchTreeElementForScript):
996         Lazily create a ScriptTreeElement for the search tree outline as needed.
997
998         (WebInspector.ResourceSidebarPanel.prototype._scriptsToSearch):
999         When searching scripts, just perform a shallow walk of the tree outline to find
1000         Script resources that are not also Resources. Scripts are always guarenteed to
1001         be in a folder when inspecting a web resource. For JSContext inspection, scripts
1002         are promoted to the top level.
1003
1004         * UserInterface/Main.html:
1005         * UserInterface/Models/SourceCodeSearchMatchObject.js: Renamed from Source/WebInspectorUI/UserInterface/Models/ResourceSearchMatchObject.js.
1006         (WebInspector.SourceCodeSearchMatchObject):
1007         * UserInterface/Views/SearchIcons.css:
1008         (.source-code-match-icon .icon):
1009         (.resource-match-icon .icon): Deleted.
1010         * UserInterface/Views/SearchResultTreeElement.js:
1011         (WebInspector.SearchResultTreeElement):
1012         Rename ResourceSearchMatchObject to SourceCodeSearchMatchObject.
1013
1014 2014-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1015
1016         Web Inspector: Provide $exception in the console for the thrown exception value
1017         https://bugs.webkit.org/show_bug.cgi?id=138726
1018
1019         Reviewed by Timothy Hatcher.
1020
1021         * UserInterface/Base/Test.js:
1022         (WebInspector.loaded):
1023         In order to use RuntimeManager to execute in the global context or on the
1024         active debugger call frame, we need to expose the quickConsole controller.
1025
1026         * UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
1027         Expose $exception to completion when we paused because of an exception.
1028
1029 2014-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1030
1031         Web Inspector: Debugger should not mutate variable when hovering mouse over ++n expression
1032         https://bugs.webkit.org/show_bug.cgi?id=138839
1033
1034         Reviewed by Timothy Hatcher.
1035
1036         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
1037         (WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
1038
1039 2014-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1040
1041         Web Inspector: Improve basic JavaScript completion in inline <script>s
1042         https://bugs.webkit.org/show_bug.cgi?id=138845
1043
1044         Reviewed by Timothy Hatcher.
1045
1046         * UserInterface/Controllers/CodeMirrorCompletionController.js:
1047         (WebInspector.CodeMirrorCompletionController.prototype._generateJavaScriptCompletions):
1048         Fix up CodeMirror mode handling for JavaScript completion when inside of mixed mode
1049         input (html). Also add completion for CodeMirror's localVars list.
1050
1051 == Rolled over to ChangeLog-2014-11-19 ==