Web Inspector: Timeline current time marker does not start moving when starting recor...
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2015-10-27  Joseph Pecoraro  <pecoraro@apple.com>
2
3         Web Inspector: Timeline current time marker does not start moving when starting recording after just opening inspector
4         https://bugs.webkit.org/show_bug.cgi?id=150178
5
6         Reviewed by Brian Burg.
7
8         * UserInterface/Controllers/TimelineManager.js:
9         (WebInspector.TimelineManager.prototype.capturingStarted):
10         * UserInterface/Models/TimelineRecording.js:
11         (WebInspector.TimelineRecording.prototype.initializeTimeBoundsIfNecessary):
12         For a recording to start updating current time the recording itself
13         must have a start time. Provide a setter so that the start time can
14         be set without waiting for a timeline record. For example the
15         timestamp that the frontend receives when it starts a recording.
16
17         * UserInterface/Views/TimelineRecordingContentView.js:
18         (WebInspector.TimelineRecordingContentView.prototype._startUpdatingCurrentTime):
19         When we have a startTime number (new backends) always use it as the current time.
20         Previously we were only doing this if current time was NaN, which would be when
21         re-starting a recording after it had stopped, but not for the initial recording
22         after opening the inspector.
23
24         * UserInterface/Views/TimelineRuler.js:
25         (WebInspector.TimelineRuler.prototype.updateLayout):
26         Even if we do not need to create new time dividers we may need to perform
27         other updates like update the current time marker. So do work before bailing.
28
29 2015-10-26  Matt Baker  <mattbaker@apple.com>
30
31         Web Inspector: WebInspector.Object can dispatch constructor-level events multiple times
32         https://bugs.webkit.org/show_bug.cgi?id=150579
33
34         Reviewed by Timothy Hatcher.
35
36         Use `hasOwnProperty` when checking for constructor event listeners when walking the
37         prototype chain. This prevents listeners registered with a base class constructor
38         from being dispatched multiple times by getting picked up higher in the prototype chain.
39
40         * UserInterface/Base/Object.js:
41         (WebInspector.Object.prototype.dispatchEventToListeners.dispatch):
42         (WebInspector.Object.prototype.dispatchEventToListeners):
43         (WebInspector.Object):
44
45 2015-10-26  Matt Baker  <mattbaker@apple.com>
46
47         Web Inspector: Hundreds of failed assertions after switching to Rendering Frames after recording complete
48         https://bugs.webkit.org/show_bug.cgi?id=150568
49
50         Reviewed by Timothy Hatcher.
51
52         When the TimelineRecordingContentView responds to the current content view changing,
53         the TimelineOverview may be swapped out (if switching from a Timelines content view to a
54         Rendering Frames content view). This patch installs a new overview (if it's changing) prior
55         to setting the TimelineSidebarPanel's tree outline, as setting the tree outline forces
56         filters to run.
57
58         Filtering tree elements requires that the timeline overview is up to date, which was the
59         cause the assertion deluge.
60
61         * UserInterface/Views/TimelineRecordingContentView.js:
62         (WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
63
64 2015-10-26  Joseph Pecoraro  <pecoraro@apple.com>
65
66         Web Inspector: Spacebar to start recording should not cause system beep
67         https://bugs.webkit.org/show_bug.cgi?id=150573
68
69         Reviewed by Timothy Hatcher.
70
71         * UserInterface/Views/TimelineSidebarPanel.js:
72         (WebInspector.TimelineSidebarPanel.prototype._toggleRecordingOnSpacebar):
73         (WebInspector.TimelineSidebarPanel.prototype._toggleNewRecordingOnSpacebar):
74         The keyboard shortcuts do not implicitly prevent default because they may bail.
75         So in cases where they do handle the key, prevent default to prevent system beeps.
76
77 2015-10-26  Matt Baker  <mattbaker@apple.com>
78
79         Web Inspector: Cleanup sidebar panels, reduce `delete` and use Maps instead of objects
80         https://bugs.webkit.org/show_bug.cgi?id=150548
81
82         Reviewed by Timothy Hatcher.
83
84         * UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
85         (WebInspector.LayerTreeDetailsSidebarPanel):
86         (WebInspector.LayerTreeDetailsSidebarPanel.prototype._updateDataGrid):
87         (WebInspector.LayerTreeDetailsSidebarPanel.prototype._dataGridNodeForLayer):
88
89         * UserInterface/Views/NavigationSidebarPanel.js:
90         (WebInspector.NavigationSidebarPanel):
91         (WebInspector.NavigationSidebarPanel.restoreStateFromCookie.finalAttemptToRestoreViewStateFromCookie):
92         (WebInspector.NavigationSidebarPanel.restoreStateFromCookie):
93         (WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement):
94         (WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
95         (WebInspector.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie):
96         Switched to using Symbol() to set external properties on tree elements.
97
98         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
99         (WebInspector.ScopeChainDetailsSidebarPanel.prototype._generateCallFramesSection):
100
101         * UserInterface/Views/StorageSidebarPanel.js:
102         (WebInspector.StorageSidebarPanel):
103         (WebInspector.StorageSidebarPanel.prototype._addDatabase):
104         (WebInspector.StorageSidebarPanel.prototype._addIndexedDatabase):
105         (WebInspector.StorageSidebarPanel.prototype._addFrameManifest):
106         (WebInspector.StorageSidebarPanel.prototype._storageCleared):
107
108 2015-10-24  Nikita Vasilyev  <nvasilyev@apple.com>
109
110         Unreviewed, rolling out r191419.
111         https://bugs.webkit.org/show_bug.cgi?id=150537
112
113         Reverted changeset:
114
115         "Web Inspector: Autocompletion previews in the CSS sidebar do not apply"
116         https://bugs.webkit.org/show_bug.cgi?id=147720
117         http://trac.webkit.org/changeset/191419
118
119 2015-10-23  Joseph Pecoraro  <pecoraro@apple.com>
120
121         Web Inspector: Remove unused ScrollLayer Timeline EventType
122         https://bugs.webkit.org/show_bug.cgi?id=150518
123
124         Reviewed by Timothy Hatcher.
125
126         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
127         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
128         * UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
129         * Versions/Inspector-iOS-7.0.json:
130         * Versions/Inspector-iOS-8.0.json:
131         * Versions/Inspector-iOS-9.0.json:
132
133 2015-10-23  Joseph Pecoraro  <pecoraro@apple.com>
134
135         Web Inspector: xlink:href should be linkified
136         https://bugs.webkit.org/show_bug.cgi?id=150505
137
138         Reviewed by Timothy Hatcher.
139
140         * UserInterface/Base/Main.js:
141         When opening a URL with a fragment, prefer opening a resource
142         that has the same URL without the fragment, otherwise this would
143         open in a new tab.
144
145         * UserInterface/Base/URLUtilities.js:
146         (absoluteURL):
147         Better handling absoluteURL("#frag", baseURL).
148
149         * UserInterface/Views/CodeMirrorAdditions.js:
150         * UserInterface/Views/DOMTreeElement.js:
151         (WebInspector.DOMTreeElement.prototype._buildAttributeDOM):
152         Allow for more "href" style attributes, such as XML namespaced
153         "xlink:href" attribute names.
154
155 2015-10-23  Nikita Vasilyev  <nvasilyev@apple.com>
156
157         Web Inspector: Command-Enter in Debugger should show a popover with evaluation result
158         https://bugs.webkit.org/show_bug.cgi?id=149195
159
160         Currenty, the only way to display the popover is to hover over the text with a mouse cursor.
161         Provide a way to display it via a keyboard shortcut.
162
163         Reviewed by Timothy Hatcher.
164
165         * UserInterface/Controllers/CodeMirrorCompletionController.js:
166         (WebInspector.CodeMirrorCompletionController): Deleted.
167         (WebInspector.CodeMirrorCompletionController.prototype._generateJavaScriptCompletions): Deleted.
168         Don't evaluate selected text from Debugger or Sources in the console.
169
170         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
171         (WebInspector.CodeMirrorTokenTrackingController):
172         (WebInspector.CodeMirrorTokenTrackingController.prototype._handleCommandEnterKey):
173         (WebInspector.CodeMirrorTokenTrackingController.prototype._hidePopover):
174         Cmd-Enter triggers the popover, Esc hides it.
175
176         (WebInspector.CodeMirrorTokenTrackingController.prototype.set mode):
177         (WebInspector.CodeMirrorTokenTrackingController.prototype.removeHighlightedRange):
178         Don't use delete.
179
180         (WebInspector.CodeMirrorTokenTrackingController.prototype._mouseMovedWithMarkedText):
181         When a token isn't hovered, hide it only when it was triggered not by the keyboard.
182
183         (WebInspector.CodeMirrorTokenTrackingController.prototype._markedTextIsNoLongerHovered):
184         Don't use delete.
185
186         (WebInspector.CodeMirrorTokenTrackingController.prototype._updateHoveredTokenInfo):
187         (WebInspector.CodeMirrorTokenTrackingController.prototype._getTokenInfoForPosition):
188         Abstract out a no side effects _getTokenInfoForPosition method, which is also used by _handleCommandEnterKey.
189
190         (WebInspector.CodeMirrorTokenTrackingController.prototype._mouseMovedOutOfEditor):
191         (WebInspector.CodeMirrorTokenTrackingController.prototype._mouseButtonWasReleasedOverEditor):
192         Don't use delete.
193
194         (WebInspector.CodeMirrorTokenTrackingController.prototype._processNewHoveredToken):
195         (WebInspector.CodeMirrorTokenTrackingController.prototype._processNonSymbolToken):
196         (WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
197         Pass tokenInfo as an argument to explicitly state that these methods require it.
198
199         (WebInspector.CodeMirrorTokenTrackingController.prototype._resetTrackingStates):
200         Don't use delete.
201
202         * UserInterface/Views/SourceCodeTextEditor.js:
203         (WebInspector.SourceCodeTextEditor.prototype.tokenTrackingControllerHighlightedRangeReleased):
204         Allow to hide the popover regardless of mouse position. Used when the text cursor moves or
205         when Esc key is pressed.
206
207 2015-10-23  Devin Rousso  <dcrousso+webkit@gmail.com>
208
209         Web Inspector: Visual sidebar should support multiple backgrounds
210         https://bugs.webkit.org/show_bug.cgi?id=148310
211
212         Reviewed by Timothy Hatcher.
213
214         Changes the layout of the Background - Style section in the Visual sidebar
215         to be a list instead of a single editable field for a background-image URL.
216         Allows for comma-separated background properties (both shorthand and
217         longhand) and displays them all in a single list for editing.
218
219         * Localizations/en.lproj/localizedStrings.js:
220         * UserInterface/Views/VisualStyleColorPicker.js:
221         (WebInspector.VisualStyleColorPicker):
222         * UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
223         (.visual-style-property-container.comma-separated-keyword-editor):
224         * UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js:
225         (WebInspector.VisualStyleCommaSeparatedKeywordEditor):
226         (WebInspector.VisualStyleCommaSeparatedKeywordEditor.prototype._generateTextFromLonghandProperties.propertyValue):
227         (WebInspector.VisualStyleCommaSeparatedKeywordEditor.prototype._generateTextFromLonghandProperties):
228         (WebInspector.VisualStyleCommaSeparatedKeywordEditor.prototype.modifyPropertyText):
229         Comma separated properties will now try to assemble a value from related longhand
230         properties so that a single shorthand property with commas may be used.
231
232         * UserInterface/Views/VisualStyleDetailsPanel.css:
233         (.sidebar > .panel.details.css-style .visual > .details-section.background .details-section.background-style .visual-style-property-container.comma-separated-keyword-editor.background):
234         * UserInterface/Views/VisualStyleDetailsPanel.js:
235         (WebInspector.VisualStyleDetailsPanel.prototype._populateBackgroundStyleSection):
236         (WebInspector.VisualStyleDetailsPanel.prototype._populateBoxShadowSection):
237         (WebInspector.VisualStyleDetailsPanel.prototype._populateTransitionSection):
238         (WebInspector.VisualStyleDetailsPanel.prototype._noRemainingCommaSeparatedEditorItems):
239         (WebInspector.VisualStyleDetailsPanel.prototype._selectedCommaSeparatedEditorItemValueChanged):
240         (WebInspector.VisualStyleDetailsPanel.prototype._commaSeparatedEditorTreeItemSelected):
241         (WebInspector.VisualStyleDetailsPanel.prototype._populateBoxShadowSection.noRemainingTreeItems): Deleted.
242         (WebInspector.VisualStyleDetailsPanel.prototype._populateBoxShadowSection.selectedBoxShadowItemValueChanged): Deleted.
243         (WebInspector.VisualStyleDetailsPanel.prototype._populateBoxShadowSection.boxShadowItemSelected): Deleted.
244         (WebInspector.VisualStyleDetailsPanel.prototype._populateTransitionSection.noRemainingTreeItems): Deleted.
245         (WebInspector.VisualStyleDetailsPanel.prototype._populateTransitionSection.selectedtransitionItemValueChanged): Deleted.
246         (WebInspector.VisualStyleDetailsPanel.prototype._populateTransitionSection.transitionItemSelected): Deleted.
247         Made the "background-image" property into a comma separated editor.
248
249         * UserInterface/Views/VisualStyleFontFamilyListEditor.js:
250         (WebInspector.VisualStyleFontFamilyListEditor):
251         * UserInterface/Views/VisualStyleKeywordIconList.js:
252         (WebInspector.VisualStyleKeywordIconList.prototype.set value):
253         (WebInspector.VisualStyleKeywordIconList.prototype._handleKeywordChanged):
254         (WebInspector.VisualStyleKeywordIconList):
255         * UserInterface/Views/VisualStyleKeywordPicker.js:
256         (WebInspector.VisualStyleKeywordPicker.prototype.updateEditorValues):
257         (WebInspector.VisualStyleKeywordPicker.prototype._setValue):
258         * UserInterface/Views/VisualStyleNumberInputBox.js:
259         (WebInspector.VisualStyleNumberInputBox.prototype.set value):
260         * UserInterface/Views/VisualStylePropertyCombiner.js:
261         (WebInspector.VisualStylePropertyCombiner):
262         (WebInspector.VisualStylePropertyCombiner.prototype.updateValuesFromText.updateCompatibleEditor):
263         (WebInspector.VisualStylePropertyCombiner.prototype.updateValuesFromText):
264         * UserInterface/Views/VisualStylePropertyEditor.js:
265         (WebInspector.VisualStylePropertyEditor):
266         (WebInspector.VisualStylePropertyEditor.prototype.update):
267         (WebInspector.VisualStylePropertyEditor.prototype.getValuesFromText):
268         (WebInspector.VisualStylePropertyEditor.prototype.get propertyMissing):
269         (WebInspector.VisualStylePropertyEditor.prototype._valueDidChange):
270         Moved "propertyMissing" into a member variable for better access.
271
272         * UserInterface/Views/VisualStyleURLInput.js:
273         (WebInspector.VisualStyleURLInput):
274         (WebInspector.VisualStyleURLInput.prototype.get synthesizedValue):
275         (WebInspector.VisualStyleURLInput.prototype.parseValue):
276         Added support for specific keywords to be used in the input field.
277
278 2015-10-22  Timothy Hatcher  <timothy@apple.com>
279
280         Web Inspector: Remove generateColoredImagesForCSS and its clients
281         https://bugs.webkit.org/show_bug.cgi?id=150474
282
283         Reviewed by Joseph Pecoraro.
284
285         * UserInterface/Base/ImageUtilities.js:
286         (generateColoredImage): Deleted.
287         (imageLoaded): Deleted.
288         (ensureImageIsLoaded): Deleted.
289         (restoreImages.restoreActiveImages): Deleted.
290         (restoreImages): Deleted.
291         (restoreImage): Deleted.
292         (update): Deleted.
293         (generateImage): Deleted.
294         (generateColoredImagesForCSS): Deleted.
295
296         * UserInterface/Base/Main.js:
297         (WebInspector.loaded): Deleted call to _generateDisclosureTriangleImages.
298         (WebInspector._generateDisclosureTriangleImages): Deleted.
299         (WebInspector.createGoToArrowButton): Deleted code to generate the states.
300
301         * UserInterface/Images/BackArrow.svg: Removed.
302         * UserInterface/Images/BackForwardArrows.svg: Added.
303         * UserInterface/Images/DisclosureTriangleSmallClosed.svg: Removed.
304         * UserInterface/Images/DisclosureTriangleSmallOpen.svg: Removed.
305         * UserInterface/Images/DisclosureTriangleTinyClosed.svg: Removed.
306         * UserInterface/Images/DisclosureTriangleTinyOpen.svg: Removed.
307         * UserInterface/Images/DisclosureTriangles.svg: Added.
308         * UserInterface/Images/ForwardArrow.svg: Removed.
309         * UserInterface/Images/GoToArrow.svg:
310         * UserInterface/Images/Locked.svg: Moved fill color here.
311         * UserInterface/Images/SortIndicatorArrows.svg: Added.
312         * UserInterface/Images/SortIndicatorDownArrow.svg: Removed.
313         * UserInterface/Images/SortIndicatorUpArrow.svg: Removed.
314         * UserInterface/Images/gtk/BackArrow.svg: Removed.
315         * UserInterface/Images/gtk/BackForwardArrows.svg: Added.
316         * UserInterface/Images/gtk/DisclosureTriangleSmallClosed.svg: Removed.
317         * UserInterface/Images/gtk/DisclosureTriangleSmallOpen.svg: Removed.
318         * UserInterface/Images/gtk/DisclosureTriangleTinyClosed.svg: Removed.
319         * UserInterface/Images/gtk/DisclosureTriangleTinyOpen.svg: Removed.
320         * UserInterface/Images/gtk/DisclosureTriangles.svg: Added.
321         * UserInterface/Images/gtk/ForwardArrow.svg: Removed.
322         * UserInterface/Images/gtk/GoToArrow.svg:
323         * UserInterface/Images/gtk/Locked.svg: Moved fill color here.
324         * UserInterface/Images/gtk/SortIndicatorArrows.svg: Added.
325         * UserInterface/Images/gtk/SortIndicatorDownArrow.svg: Removed.
326         * UserInterface/Images/gtk/SortIndicatorUpArrow.svg: Removed.
327
328         * UserInterface/Views/CSSStyleDeclarationSection.css:
329         (.style-declaration-section.locked > .header::before):
330
331         * UserInterface/Views/CSSStyleDeclarationSection.js:
332         (WebInspector.CSSStyleDeclarationSection): Deleted.
333
334         * UserInterface/Views/ConsoleMessageView.css:
335         (.console-message.expandable .console-top-level-message::before):
336         (.console-message.expandable.expanded .console-top-level-message::before):
337
338         * UserInterface/Views/ContentBrowser.js:
339         (WebInspector.ContentBrowser): Use BackForwardArrows.svg.
340
341         * UserInterface/Views/DOMTreeOutline.css:
342         (.dom-tree-outline li.parent::before):
343         (.dom-tree-outline:focus li.parent.selected::before):
344         (.dom-tree-outline li.parent.expanded::before):
345         (.dom-tree-outline:focus li.parent.expanded.selected::before):
346
347         * UserInterface/Views/DataGrid.css:
348         (.data-grid th.sort-ascending > div:first-child::after):
349         (.data-grid th.sort-descending > div:first-child::after):
350         (.data-grid tr.parent td.disclosure::before):
351         (.data-grid tr.parent.expanded td.disclosure::before):
352         (.data-grid:matches(:focus, .force-focus) tr.parent.selected td.disclosure::before):
353         (.data-grid:matches(:focus, .force-focus) tr.parent.expanded.selected td.disclosure::before):
354
355         * UserInterface/Views/DataGrid.js:
356         (WebInspector.DataGrid): Deleted call to _generateSortIndicatorImagesIfNeeded.
357         (WebInspector.DataGrid.prototype._generateSortIndicatorImagesIfNeeded): Deleted.
358
359         * UserInterface/Views/DetailsSection.css:
360         (.details-section > .header::before):
361         (.details-section > .header:not(.mouse-over-options-element):active::before):
362         (.details-section.collapsed > .header::before):
363         (.details-section.collapsed > .header:not(.mouse-over-options-element):active::before):
364
365         * UserInterface/Views/DetailsSection.js:
366         (WebInspector.DetailsSection): Deleted call to _generateDisclosureTrianglesIfNeeded.
367         (WebInspector.DetailsSection.prototype._generateDisclosureTrianglesIfNeeded): Deleted.
368
369         * UserInterface/Views/ErrorObjectView.css:
370         (.error-object > .formatted-error::before):
371         (.error-object.expanded > .formatted-error::before):
372
373         * UserInterface/Views/FindBanner.css:
374         (.find-banner > button.segmented.left > .glyph):
375         (.find-banner > button.segmented.left:active:not(:disabled) > .glyph):
376         (.find-banner > button.segmented.right > .glyph):
377         (.find-banner > button.segmented.right:active:not(:disabled) > .glyph):
378
379         * UserInterface/Views/FindBanner.js:
380         (WebInspector.FindBanner): Deleted call to _generateButtonsGlyphsIfNeeded.
381         (WebInspector.FindBanner.prototype._generateButtonsGlyphsIfNeeded): Deleted.
382
383         * UserInterface/Views/LogContentView.css:
384         (.console-group-title::before):
385         (.console-group.collapsed .console-group-title::before):
386
387         * UserInterface/Views/Main.css:
388         (.go-to-arrow):
389         (.go-to-arrow:active):
390         (:matches(:focus, .force-focus) .selected .go-to-arrow):
391         (:matches(:focus, .force-focus) .selected .go-to-arrow:active):
392
393         * UserInterface/Views/NavigationSidebarPanel.css:
394         (.navigation-sidebar-panel-content-tree-outline .item .disclosure-button):
395         (.navigation-sidebar-panel-content-tree-outline:matches(:focus, .force-focus) .item.selected .disclosure-button):
396         (.navigation-sidebar-panel-content-tree-outline .item.expanded .disclosure-button):
397         (.navigation-sidebar-panel-content-tree-outline:matches(:focus, .force-focus) .item.selected.expanded .disclosure-button):
398
399         * UserInterface/Views/NavigationSidebarPanel.js:
400         (WebInspector.NavigationSidebarPanel): Deleted call to _generateDisclosureTrianglesIfNeeded.
401         (WebInspector.NavigationSidebarPanel.prototype._generateDisclosureTrianglesIfNeeded): Deleted.
402
403         * UserInterface/Views/ObjectTreePropertyTreeElement.css:
404         (.object-tree-property.parent > .disclosure-button):
405         (.object-tree-property.parent.expanded > .disclosure-button):
406         (.object-tree-property .read-only): Deleted.
407
408         * UserInterface/Views/ObjectTreeView.css:
409         (.object-tree > :matches(.title, .object-preview)::before):
410         (.object-tree.expanded > :matches(.title, .object-preview)::before):
411
412         * UserInterface/Views/TypeTreeElement.css:
413         (.type-tree-element.parent > .disclosure-button):
414         (.type-tree-element.parent.expanded > .disclosure-button):
415
416 2015-10-22  Matt Baker  <mattbaker@apple.com>
417
418         Web Inspector: CSS Data URIs count against page weight twice
419         https://bugs.webkit.org/show_bug.cgi?id=150101
420
421         Reviewed by Timothy Hatcher.
422
423         * UserInterface/Models/DefaultDashboard.js:
424         (WebInspector.DefaultDashboard.prototype._resourceSizeDidChange):
425         Exclude resources with a data URI from the total page weight.
426
427         * UserInterface/Models/Resource.js:
428         (WebInspector.Resource):
429         (WebInspector.Resource.prototype.updateForRedirectResponse):
430         (WebInspector.Resource.prototype.updateForResponse):
431         (WebInspector.Resource.prototype.markAsFinished):
432         Removed uses of `delete`.
433
434 2015-10-22  Joseph Pecoraro  <pecoraro@apple.com>
435
436         Web Inspector: Remove unused Timeline GCEvent Record type
437         https://bugs.webkit.org/show_bug.cgi?id=150477
438
439         Reviewed by Timothy Hatcher.
440
441         iOS backends never emitted a GCEvent timeline event.
442
443         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
444         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
445         * UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
446         * Versions/Inspector-iOS-7.0.json:
447         * Versions/Inspector-iOS-8.0.json:
448         * Versions/Inspector-iOS-9.0.json:
449
450 2015-10-22  Joseph Pecoraro  <pecoraro@apple.com>
451
452         Web Inspector: srcset attributes should have hyperlinks to the resources
453         https://bugs.webkit.org/show_bug.cgi?id=150409
454
455         Reviewed by Timothy Hatcher.
456
457         Follow-up tweaks and fixes that were intended to be landed.
458
459         * UserInterface/Views/CodeMirrorAdditions.js:
460         (tokenizeSrcSetString):
461         Multiline parsing has issues recovering the state CodeMirror
462         expects, so we just bail in those cases. Leading whitespace
463         is also handled poorly, but expected to be rare.
464
465         * UserInterface/Views/DOMTreeElement.js:
466         (WebInspector.DOMTreeElement.prototype._buildAttributeDOM):
467         Trim to eliminate leading whitespace.
468
469 2015-10-22  Joseph Pecoraro  <pecoraro@apple.com>
470
471         Web Inspector: Restore :not(:placeholder-shown) behavior on search bars with comments
472         https://bugs.webkit.org/show_bug.cgi?id=150452
473
474         Reviewed by Timothy Hatcher.
475
476         * UserInterface/Views/FindBanner.css:
477         (.find-banner.console-find-banner > input[type="search"]:not(:placeholder-shown)):
478         * UserInterface/Views/SearchBar.css:
479         (.search-bar > input[type="search"]:not(:placeholder-shown)):
480         Add back the placeholder-shown related styles and add a comment about what they are for.
481
482 2015-10-22  Devin Rousso  <dcrousso+webkit@gmail.com>
483
484         Web Inspector: Tabbing over CSS properties prepended by * doesn't move the highlighted range
485         https://bugs.webkit.org/show_bug.cgi?id=150294
486
487         Reviewed by Timothy Hatcher.
488
489         Moving the selected text when tabbing and shift-tabbing now relies upon
490         the last index of ";" if it exists instead of whether the line ends with it.
491
492         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
493         (WebInspector.CSSStyleDeclarationTextEditor.prototype._handleShiftTabKey):
494         (WebInspector.CSSStyleDeclarationTextEditor.prototype._handleTabKey):
495
496 2015-10-21  Joseph Pecoraro  <pecoraro@apple.com>
497
498         Web Inspector: srcset attributes should have hyperlinks to the resources
499         https://bugs.webkit.org/show_bug.cgi?id=150409
500
501         Reviewed by Timothy Hatcher.
502
503         The "srcset" attribute parsing is a simplification of:
504         https://html.spec.whatwg.org/multipage/embedded-content.html#attr-img-srcset
505
506         The "srcset" attribute value is expected to be in comma
507         separated groups. Within each group we always expect a link,
508         and an optional descriptor. We want to linkify the link.
509
510         * UserInterface/Views/CodeMirrorAdditions.js:
511         (tokenizeSrcSetString):
512         (extendedXMLToken):
513         When parsing srcset attribute, parse links as link tokens
514         so that they are linkified in resource content views.
515
516         * UserInterface/Views/DOMTreeElement.js:
517         (WebInspector.DOMTreeElement.prototype._buildAttributeDOM):
518         When creating the DOMTree DOM for srcset attributes,
519         create link elements for the link values of attribute value.
520
521 2015-10-21  Devin Rousso  <dcrousso+webkit@gmail.com>
522
523         Web Inspector: Autocompletion previews in the CSS sidebar do not apply
524         https://bugs.webkit.org/show_bug.cgi?id=147720
525
526         Reviewed by Timothy Hatcher.
527
528         When autocompletion hints are added to styles or the console, the history
529         object used by CodeMirror was edited to remove the last entry. Instead of
530         using this method (which caused glitchy behaviour when undo-ing), call
531         CodeMirror.undo() and adjust accordingly. In addition, a marker was being
532         used as the completion hint instead of applying text, whereas these
533         changes use actual text, ensuring that completions are previewed in the page.
534
535         * UserInterface/Controllers/CodeMirrorCompletionController.js:
536         (WebInspector.CodeMirrorCompletionController):
537         (WebInspector.CodeMirrorCompletionController.prototype.close):
538         (WebInspector.CodeMirrorCompletionController.prototype._applyCompletionHint.update):
539         (WebInspector.CodeMirrorCompletionController.prototype._commitCompletionHint.update):
540         (WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint.update):
541         (WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint):
542         (WebInspector.CodeMirrorCompletionController.prototype._handleBeforeChange):
543         (WebInspector.CodeMirrorCompletionController.prototype._createCompletionHintMarker): Deleted.
544         (WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint.clearMarker): Deleted.
545
546 2015-10-21  Devin Rousso  <dcrousso+webkit@gmail.com>
547
548         Web Inspector: Add forgotten WebInspector.UIString from r190521
549         https://bugs.webkit.org/show_bug.cgi?id=150425
550
551         Reviewed by Timothy Hatcher.
552
553         * Localizations/en.lproj/localizedStrings.js:
554         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
555         (UserInterface/Views/CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded)
556
557 2015-10-21  Devin Rousso  <dcrousso+webkit@gmail.com>
558
559         Web Inspector: Adjust usages of classList.toggle to ensure a true/false value instead of undefined
560         https://bugs.webkit.org/show_bug.cgi?id=150424
561
562         Reviewed by Timothy Hatcher.
563
564         Adds "!!" in front of force parameters in classList.toggle calls that
565         could possibly be undefined (thereby breaking the UI).
566
567         * UserInterface/Views/ScopeBarItem.js:
568         (WebInspector.ScopeBarItem):
569         * UserInterface/Views/VisualStyleDetailsPanel.js:
570         (WebInspector.VisualStyleDetailsPanel.prototype._updateSections):
571         * UserInterface/Views/VisualStylePropertyEditor.js:
572         (WebInspector.VisualStylePropertyEditor):
573
574 2015-10-21  Devin Rousso  <dcrousso+webkit@gmail.com>
575
576         Web Inspector: Option-Up doesn't increment certain attribute values
577         https://bugs.webkit.org/show_bug.cgi?id=149257
578
579         Reviewed by Brian Burg.
580
581         If the user tries to modify a numerical attribute in HTML and the cursor
582         was at the beginning of the attribute value, the range of the selection
583         was within a sibling element instead of the text node containin the value.
584         This patch fixes this issue and ensures that the correct text is selected.
585
586         * UserInterface/Views/EditingSupport.js:
587         (WebInspector.startEditing.handleEditingResult):
588         Replaced var with let.
589
590 2015-10-21  Joseph Pecoraro  <pecoraro@apple.com>
591
592         Web Inspector: Use some CSS Variables in Web Inspector
593         https://bugs.webkit.org/show_bug.cgi?id=150405
594
595         Reviewed by Timothy Hatcher.
596
597         * UserInterface/Main.html:
598         Include the new variables stylesheet.
599
600         * UserInterface/Views/Variables.css: Added.
601         (:root):
602         Introduce new global variables.
603
604         * UserInterface/Views/CSSStyleDeclarationTextEditor.css:
605         (.css-style-text-editor > .CodeMirror .cm-link):
606         * UserInterface/Views/ConsoleMessageView.css:
607         (.console-message-preview-divider):
608         (.console-message-enclosed):
609         (.console-message .console-message-extra-parameters-container > li::before):
610         (.console-saved-variable):
611         * UserInterface/Views/DOMTreeOutline.css:
612         (.dom-tree-outline li.selected > span::after):
613         * UserInterface/Views/FormattedValue.css:
614         (:matches(.formatted-array, .formatted-map, .formatted-set, .formatted-weakmap, .formatted-weakset) > .size):
615         (.formatted-number):
616         (.formatted-boolean):
617         (.formatted-string):
618         (.formatted-regexp):
619         (.formatted-symbol):
620         * UserInterface/Views/ObjectPreviewView.css:
621         (.object-preview > .size):
622         * UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:
623         (.object-tree-array-index .index-name):
624         * UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
625         (.syntax-highlighted :matches(.css-keyword, .css-tag, .css-at-rule, .css-important, .javascript-keyword, .html-tag)):
626         (.syntax-highlighted :matches(.css-number, .javascript-number)):
627         (.syntax-highlighted :matches(.css-string, .javascript-string, .html-attribute-value)):
628         (.syntax-highlighted .javascript-regexp):
629         * UserInterface/Views/TypeTokenView.css:
630         (.type-token-symbol):
631         Make use of variables.
632
633 2015-10-21  Nikita Vasilyev  <nvasilyev@apple.com>
634
635         Web Inspector: Typo in a property name: style.inerhited
636         https://bugs.webkit.org/show_bug.cgi?id=150391
637
638         Reviewed by Csaba Osztrogonác.
639
640         * UserInterface/Views/RulesStyleDetailsPanel.js:
641         (WebInspector.RulesStyleDetailsPanel.prototype.refresh):
642
643 2015-10-20  Nikita Vasilyev  <nvasilyev@apple.com>
644
645         Web Inspector: Pressing Command-S while focused on the styles sidebar should save CSS file
646         https://bugs.webkit.org/show_bug.cgi?id=150298
647
648         Reviewed by Timothy Hatcher.
649
650         * UserInterface/Views/CSSStyleDeclarationSection.js:
651         (WebInspector.CSSStyleDeclarationSection):
652         Beep when saving didn't work. Inline CSS and CSS in style attributes aren't curently supported.
653
654 2015-10-20  Joseph Pecoraro  <pecoraro@apple.com>
655
656         Web Inspector: JavaScriptCore should parse sourceURL and sourceMappingURL directives
657         https://bugs.webkit.org/show_bug.cgi?id=150096
658
659         Reviewed by Geoffrey Garen.
660
661         * UserInterface/Test/InspectorProtocol.js:
662         (InspectorProtocol._sendMessage):
663         (InspectorProtocol.dispatchMessageFromBackend):
664         This is only used for tests, so avoid console.log
665         and just dump directly to the system console.
666
667 2015-10-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
668
669         [Streams API] Add skeleton for initial WritableStream support
670         https://bugs.webkit.org/show_bug.cgi?id=149951
671
672         Reviewed by Darin Adler.
673
674         * UserInterface/Models/NativeFunctionParameters.js: Added support for WritableStream.
675
676 2015-10-19  James Craig  <jcraig@apple.com>
677
678         Web Inspector: AX: console list 'input'/'output' markers are not perceivable
679         https://bugs.webkit.org/show_bug.cgi?id=133045
680
681         Enabling WebKit Web Inspector console pseudo-element labels using the new CSS4 'alt' property.
682
683         Reviewed by Brian Burg.
684
685         * UserInterface/Views/LogContentView.css: 
686         (.search-in-progress .console-item:not(.filtered-out-by-search) .highlighted.selected):
687         (.console-messages:focus .console-item.selected .console-user-command-result.console-log-level::before):
688         (@media reader): Deleted.
689
690 2015-10-18  Joseph Pecoraro  <pecoraro@apple.com>
691
692         Web Inspector: Console Search should update when console is cleared
693         https://bugs.webkit.org/show_bug.cgi?id=150141
694
695         Reviewed by Brian Burg.
696
697         * UserInterface/Views/LogContentView.js:
698         (WebInspector.LogContentView.prototype._logCleared):
699         Reperform the search if there is a search query.
700
701         (WebInspector.LogContentView.prototype._filterMessageElements):
702         Reperform the current search.
703
704 2015-10-16  Joseph Pecoraro  <pecoraro@apple.com>
705
706         Web Inspector: Add "unset" to CSS value autocompletion
707         https://bugs.webkit.org/show_bug.cgi?id=127616
708
709         Reviewed by Brian Burg.
710
711         * UserInterface/Models/CSSCompletions.js:
712         * UserInterface/Models/CSSKeywordCompletions.js:
713         (WebInspector.CSSKeywordCompletions.forProperty):
714         Treat "unset" similiar to "initial". Also, no need for "initial"
715         in an individual property's list. We always include it.
716
717         * UserInterface/Views/VisualStyleDetailsPanel.js:
718         (WebInspector.VisualStyleDetailsPanel):
719         (WebInspector.VisualStyleDetailsPanel.prototype._populateDisplaySection):
720         (WebInspector.VisualStyleDetailsPanel.prototype._populateAlignmentSection):
721         Add "Unset" alongside "Initial".
722
723 2015-10-14  Joseph Pecoraro  <pecoraro@apple.com>
724
725         Web Inspector: Include Garbage Collection Event in Timeline
726         https://bugs.webkit.org/show_bug.cgi?id=142510
727
728         Reviewed by Geoffrey Garen and Brian Burg.
729
730         * UserInterface/Base/Utilities.js:
731         (Array.prototype.partition):
732         Helper to partition an Array into two arrays.
733
734         * Localizations/en.lproj/localizedStrings.js:
735         * UserInterface/Base/Main.js:
736         (WebInspector.loaded):
737         * UserInterface/Test.html:
738         * UserInterface/Test/Test.js:
739         (WebInspector.loaded):
740         * UserInterface/Protocol/HeapObserver.js: Added.
741         (WebInspector.HeapObserver.prototype.garbageCollected):
742         (WebInspector.HeapObserver):
743         Create the new observer and manager.
744
745         * UserInterface/Models/GarbageCollection.js: Added.
746         (WebInspector.GarbageCollection):
747         (WebInspector.GarbageCollection.fromPayload):
748         (WebInspector.GarbageCollection.prototype.get type):
749         (WebInspector.GarbageCollection.prototype.get startTime):
750         (WebInspector.GarbageCollection.prototype.get endTime):
751         (WebInspector.GarbageCollection.prototype.get duration):
752         Model object for Heap.GarbageCollection.
753
754         * UserInterface/Controllers/HeapManager.js: Added.
755         (WebInspector.HeapManager):
756         (WebInspector.HeapManager.prototype.garbageCollected):
757         Dispatch events with the GC object.
758
759         * UserInterface/Controllers/TimelineManager.js:
760         (WebInspector.TimelineManager):
761         (WebInspector.TimelineManager.prototype._garbageCollected):
762         Include new GC Timeline Events as Script events.
763
764         * UserInterface/Views/ScriptTimelineOverviewGraph.js:
765         (WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout):
766         For the Script overview, make two sets of bars, one for Scripts and one for GCs.
767         The GCs bar will be overlaid on top of the the Scripts bar. This is particularly
768         useful since a GC can happen during script execution.
769
770         * UserInterface/Images/TimelineRecordGarbageCollection.svg: Added.
771         * UserInterface/Main.html:
772         * UserInterface/Models/ScriptTimelineRecord.js:
773         (WebInspector.ScriptTimelineRecord.prototype.isGarbageCollection):
774         (WebInspector.ScriptTimelineRecord.EventType.displayName):
775         * UserInterface/Views/ScriptTimelineDataGridNode.js:
776         (WebInspector.ScriptTimelineDataGridNode.prototype.get data):
777         (WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent):
778         (WebInspector.ScriptTimelineDataGridNode):
779         * UserInterface/Views/ScriptTimelineView.js:
780         (WebInspector.ScriptTimelineView.prototype._processPendingRecords):
781         * UserInterface/Views/SourceCodeTimelineTreeElement.js:
782         (WebInspector.SourceCodeTimelineTreeElement):
783         * UserInterface/Views/TimelineIcons.css:
784         (.garbage-collection-profile-record .icon):
785         * UserInterface/Views/TimelineRecordBar.css:
786         (.timeline-record-bar.timeline-record-type-script.script-timeline-record-garbage-collected > .segment):
787         UI for GC events.
788
789         * UserInterface/Views/TimelineRecordBar.js:
790         (WebInspector.TimelineRecordBar.createCombinedBars):
791         Simplify by storing start time into a variable.
792
793         * UserInterface/Views/TimelineRecordTreeElement.js:
794         (WebInspector.TimelineRecordTreeElement):
795         Icon for GC events.
796
797 2015-10-15  Commit Queue  <commit-queue@webkit.org>
798
799         Unreviewed, rolling out r191135.
800         https://bugs.webkit.org/show_bug.cgi?id=150197
801
802         This patch causes 50+ LayoutTest crashes related to the
803         inspector (Requested by ryanhaddad on #webkit).
804
805         Reverted changeset:
806
807         "Web Inspector: JavaScriptCore should parse sourceURL and
808         sourceMappingURL directives"
809         https://bugs.webkit.org/show_bug.cgi?id=150096
810         http://trac.webkit.org/changeset/191135
811
812 2015-10-15  Joseph Pecoraro  <pecoraro@apple.com>
813
814         Web Inspector: JavaScriptCore should parse sourceURL and sourceMappingURL directives
815         https://bugs.webkit.org/show_bug.cgi?id=150096
816
817         Reviewed by Geoffrey Garen.
818
819         * UserInterface/Test/InspectorProtocol.js:
820         (InspectorProtocol._sendMessage):
821         (InspectorProtocol.dispatchMessageFromBackend):
822         This is only used for tests, so avoid console.log
823         and just dump directly to the system console.
824
825 2015-10-13  João Oliveira  <hello@jxs.pt>
826
827         Web Inspector: Console SearchBar should work more like ContentBrowser FindBanner
828         https://bugs.webkit.org/show_bug.cgi?id=149505
829
830         Reviewed by Joseph Pecoraro.
831
832         Console tab now uses findBanner, adapted LogContentView to use findBanner,
833         and findBanner to be more agnostic to both usecases, either as fixed, on console tab,
834         and hideable on other inspector tabs.
835
836         * UserInterface/Views/FindBanner.css:
837         (.find-banner.console-find-banner):
838         (.find-banner.console-findbanner input[type="search"]):
839         * UserInterface/Views/FindBanner.js:
840         (WebInspector.FindBanner):
841         (WebInspector.FindBanner.set targetElement.delayedWork):
842         (WebInspector.FindBanner.prototype.set targetElement):
843         (WebInspector.FindBanner.prototype.get showing):
844         (WebInspector.FindBanner.prototype.focus):
845         (WebInspector.FindBanner.prototype._clearAndBlur):
846         (WebInspector.FindBanner.prototype.show.delayedWork):
847         (WebInspector.FindBanner.prototype.show):
848         (WebInspector.FindBanner.prototype.hide):
849         (WebInspector.FindBanner.prototype.get element): Deleted.
850         (WebInspector.FindBanner.prototype._inputFieldSearch): Deleted.
851         * UserInterface/Views/LogContentView.js:
852         (WebInspector.LogContentView):
853         (WebInspector.LogContentView.prototype.get navigationItems):
854         (WebInspector.LogContentView.prototype.handleFindEvent):
855         (WebInspector.LogContentView.prototype.findBannerRevealPreviousResult):
856         (WebInspector.LogContentView.prototype.findBannerRevealNextResult):
857         (WebInspector.LogContentView.prototype._filterMessageElements):
858         (WebInspector.LogContentView.prototype.findBannerPerformSearch):
859         (WebInspector.LogContentView.prototype.findBannerSearchCleared):
860         (WebInspector.LogContentView.prototype.revealNextSearchResult):
861         (WebInspector.LogContentView.prototype.revealPreviousSearchResult):
862         (WebInspector.LogContentView.prototype._performSearch):
863         (WebInspector.LogContentView.prototype.searchBarDidActivate): Deleted.
864         (WebInspector.LogContentView.prototype._searchTextDidChange): Deleted.
865
866 2015-10-13  Nikita Vasilyev  <nvasilyev@apple.com>
867
868         REGRESSION(r189567): Web Inspector: Clipped filter icons when debugger sidebar is narrow
869         https://bugs.webkit.org/show_bug.cgi?id=150023
870
871         r189567 changed flexbox items' default min-width from 0 to auto.
872         Explicitly set it to 0 in CSS.
873
874         Reviewed by Brian Burg.
875
876         * UserInterface/Views/FilterBar.css:
877         (.filter-bar > input[type="search"]):
878
879 2015-10-13  Yusuke Suzuki  <utatane.tea@gmail.com>
880
881         Web Inspector: Don't shadow global Object constructor in WebInspector.Object class definition
882         https://bugs.webkit.org/show_bug.cgi?id=150093
883
884         Reviewed by Joseph Pecoraro.
885
886         Currently, class expression does not define any variables. So even in `class Object { }`,
887         we were able to touch the global Object constructor (like `Object.keys`).
888         However, that is a bug. After https://bugs.webkit.org/show_bug.cgi?id=150089 fixes that bug,
889         the global `Object` is shadowed by the user-defined `class Object` name.
890
891         To solve this issue, we changed the `class Object` to `class WebInspectorObject`.
892         And we expose this class as a `WebInspector.Object`.
893
894         * UserInterface/Base/Object.js:
895
896 2015-10-10  Nikita Vasilyev  <nvasilyev@apple.com>
897
898         Web Inspector: Improve error messages for internal Inspector code
899         https://bugs.webkit.org/show_bug.cgi?id=149995
900
901         Don't log "error.stack" since the error view already includes a nicely formatted stacktrace.
902
903         Reviewed by Timothy Hatcher.
904
905         * UserInterface/Protocol/InspectorBackend.js:
906         (InspectorBackendClass.prototype._dispatchResponseToCallback):
907         (InspectorBackendClass.prototype._dispatchEvent):
908
909 2015-10-08  Nikita Vasilyev  <nvasilyev@apple.com>
910
911         Web Inspector: Stack trace view doesn't properly display lines without function names
912         https://bugs.webkit.org/show_bug.cgi?id=149922
913
914         Reviewed by Timothy Hatcher.
915
916         * UserInterface/Models/StackTrace.js:
917         (WebInspector.StackTrace._parseStackTrace):
918         (WebInspector.StackTrace._parseLocation): Added.
919
920 2015-10-08  Nikita Vasilyev  <nvasilyev@apple.com>
921
922         Web Inspector: An error view doesn't get expanded by clicking on the expand arrow
923         https://bugs.webkit.org/show_bug.cgi?id=149917
924
925         Reviewed by Timothy Hatcher.
926
927         * UserInterface/Views/ErrorObjectView.css:
928         (.error-object > .formatted-error::before):
929         (.error-object.expanded > .formatted-error::before):
930         (.error-object::before): Deleted.
931         (.error-object.expanded::before): Deleted.
932
933 2015-10-06  Nikita Vasilyev  <nvasilyev@apple.com>
934
935         Web Inspector: Clicking on a stack trace link does not navigate to the corresponding line
936         https://bugs.webkit.org/show_bug.cgi?id=149405
937
938         lineNumber should be a number type but it was a string.
939
940         Reviewed by Timothy Hatcher.
941
942         * UserInterface/Base/Main.js:
943         (WebInspector.openURL):
944         (WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
945         Keep lineNumber undefined when it isn't present in the string.
946         WebInspector.linkifyStringAsFragmentWithCustomLinkifier is only used by
947         WebInspector.linkifyStringAsFragment and it expects lineNumber to be undefined
948         when it wasn't found in the parsed string.
949
950 2015-10-06  Devin Rousso  <dcrousso+webkit@gmail.com>
951
952         Web Inspector: Fix spacing of FindBanner prev/next buttons
953         https://bugs.webkit.org/show_bug.cgi?id=149717
954
955         Reviewed by Darin Adler.
956
957         The sizing and spacing of the previous and next buttons in the FindBanner
958         is slightly off and should be readjusted to ensure that both buttons are
959         the same size and have the same spacing.
960
961         * UserInterface/Views/FindBanner.css:
962         (.find-banner > button.segmented.right > .glyph):
963         (.find-banner > button.segmented):
964         (.find-banner > button.segmented > .glyph):
965         (.find-banner > button.segmented.left): Deleted.
966         (.find-banner > button.segmented.left > .glyph): Deleted.
967         (.find-banner > button.segmented.right): Deleted.
968
969 2015-10-06  Joseph Pecoraro  <pecoraro@apple.com>
970
971         Web Inspector: Simplify TimelineRecordBar a bit
972         https://bugs.webkit.org/show_bug.cgi?id=149733
973
974         Reviewed by Timothy Hatcher.
975
976         * UserInterface/Views/TimelineRecordBar.js:
977         (WebInspector.TimelineRecordBar.prototype.set records):
978
979 2015-10-05  Nikita Vasilyev  <nvasilyev@apple.com>
980
981         Web Inspector: Error displayed as an object when passed as a second argument to console.log
982         https://bugs.webkit.org/show_bug.cgi?id=149799
983
984         Reviewed by Joseph Pecoraro.
985
986         * UserInterface/Views/ConsoleMessageView.js:
987         (WebInspector.ConsoleMessageView.prototype._appendExtraParameters):
988         Don't format errors as objects.
989
990         (WebInspector.ConsoleMessageView.prototype._formatParameter):
991         (WebInspector.ConsoleMessageView.prototype._formatParameterAsValue):
992         (WebInspector.ConsoleMessageView.prototype._formatParameterAsString):
993         (WebInspector.ConsoleMessageView.prototype._formatParameterAsNode):
994         (WebInspector.ConsoleMessageView.prototype._formatParameterAsObject):
995         (WebInspector.ConsoleMessageView.prototype._formatParameterAsError):
996         (WebInspector.ConsoleMessageView.prototype._formatParameterAsArray):
997         Replace an unnecessary span element with a document fragment.
998
999         * UserInterface/Views/ErrorObjectView.css:
1000         (.error-object):
1001         Display an error object on the same line as a list bullet.
1002
1003 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1004
1005         Unprefix -webkit-font-feature-settings
1006         https://bugs.webkit.org/show_bug.cgi?id=149722
1007
1008         Reviewed by Sam Weinig.
1009
1010         * UserInterface/Models/CSSKeywordCompletions.js:
1011
1012 2015-10-04  Nikita Vasilyev  <nvasilyev@apple.com>
1013
1014         Web Inspector: Wrong column numbers in error object views
1015         https://bugs.webkit.org/show_bug.cgi?id=149795
1016
1017         Convert columnNumber and lineNumber properties from strings to numbers
1018         to prevent accidental string concatenations.
1019
1020         Reviewed by Timothy Hatcher.
1021
1022         * UserInterface/Models/StackTrace.js:
1023         (WebInspector.StackTrace._parseStackTrace):
1024
1025 2015-10-02  Matt Baker  <mattbaker@apple.com>
1026
1027         Web Inspector: Add breakpoint option to ignore n times before stopping
1028         https://bugs.webkit.org/show_bug.cgi?id=147664
1029
1030         Reviewed by Timothy Hatcher.
1031
1032         * Localizations/en.lproj/localizedStrings.js:
1033         New strings for breakpoint popover labels.
1034
1035         * UserInterface/Controllers/BreakpointPopoverController.js:
1036         (WebInspector.BreakpointPopoverController.prototype._createPopoverContent):
1037         Add ignoreCount UI to popover, if backend support exists. UI based on same
1038         feature in Xcode's breakpoint editing dialog.
1039         (WebInspector.BreakpointPopoverController.prototype._popoverIgnoreInputChanged):
1040         User input sanity checks on numeric input.
1041
1042         * UserInterface/Controllers/DebuggerManager.js:
1043         Listen for changes to breakpoint ignoreCount property.
1044
1045         * UserInterface/Models/Breakpoint.js:
1046         (WebInspector.Breakpoint):
1047         (WebInspector.Breakpoint.prototype.get ignoreCount):
1048         (WebInspector.Breakpoint.prototype.set ignoreCount):
1049         New property for ignoreCount.
1050         (WebInspector.Breakpoint.prototype.get options):
1051         Added ignoreCount to options object.
1052         (WebInspector.Breakpoint.prototype.get info):
1053         Added ignoreCount to info object.
1054
1055         * UserInterface/Views/BreakpointPopoverController.css:
1056         (#edit-breakpoint-popover-ignore):
1057         New styles for breakpoint popover.
1058
1059 2015-10-02  Matt Baker  <mattbaker@apple.com>
1060
1061         Web Inspector: Cleanup DebuggerManager, reduce `delete` and use Maps instead of objects
1062         https://bugs.webkit.org/show_bug.cgi?id=149760
1063
1064         Reviewed by Joseph Pecoraro.
1065
1066         Replaced objects used as hashmaps with Map.
1067
1068         * UserInterface/Controllers/DebuggerManager.js:
1069         (WebInspector.DebuggerManager.prototype.breakpointsForSourceCode):
1070         (WebInspector.DebuggerManager.prototype.breakpointForIdentifier):
1071         (WebInspector.DebuggerManager.prototype.scriptForIdentifier):
1072         (WebInspector.DebuggerManager.prototype.scriptsForURL):
1073         (WebInspector.DebuggerManager.prototype.get knownNonResourceScripts):
1074         (WebInspector.DebuggerManager.prototype.removeBreakpoint):
1075         (WebInspector.DebuggerManager.prototype.breakpointResolved):
1076         (WebInspector.DebuggerManager.prototype.reset):
1077         (WebInspector.DebuggerManager.prototype.scriptDidParse):
1078         (WebInspector.DebuggerManager.prototype._sourceCodeLocationFromPayload):
1079         (WebInspector.DebuggerManager.prototype._setBreakpoint.didSetBreakpoint):
1080         (WebInspector.DebuggerManager.prototype._setBreakpoint):
1081         (WebInspector.DebuggerManager.prototype._removeBreakpoint.didRemoveBreakpoint):
1082         (WebInspector.DebuggerManager.prototype._removeBreakpoint):
1083
1084 2015-10-02  Devin Rousso  <dcrousso+webkit@gmail.com>
1085
1086         Web Inspector: Copying inline style text puts "undefined" in the pasteboard
1087         https://bugs.webkit.org/show_bug.cgi?id=149155
1088
1089         Reviewed by Brian Burg.
1090
1091         CSSStyleDeclarations for inline styles do not have a owner CSSRule, which means
1092         that they do not have a selector or media list. CSS strings must have a selector
1093         and, for inline styles without an owner rule and selector, this was a problem.
1094
1095         * UserInterface/Models/CSSStyleDeclaration.js:
1096         (WebInspector.CSSStyleDeclaration.prototype.get mediaList):
1097         (WebInspector.CSSStyleDeclaration.prototype.get selectorText):
1098         (WebInspector.CSSStyleDeclaration.prototype.generateCSSRuleString):
1099         Added getters for the list of media queries and selector text with fallbacks
1100         for CSSStyleDeclarations that do not have an owner CSSRule (inline styles).
1101
1102         * UserInterface/Test.html:
1103         Added CSSMedia include for new inspector/css/generate-css-rule-string.html test.
1104
1105         * UserInterface/Views/VisualStyleSelectorTreeItem.js:
1106         (WebInspector.VisualStyleSelectorTreeItem.prototype._handleContextMenuEvent):
1107         Removed parameter that no longer exists.
1108
1109 2015-10-02  Joseph Pecoraro  <pecoraro@apple.com>
1110
1111         Unreviewed, rolling out r190520, some tests assert / crash.
1112
1113         * Localizations/en.lproj/localizedStrings.js:
1114         * UserInterface/Base/Main.js:
1115         (WebInspector.loaded): Deleted.
1116         * UserInterface/Base/Utilities.js:
1117         (value): Deleted.
1118         * UserInterface/Controllers/HeapManager.js: Removed.
1119         * UserInterface/Controllers/TimelineManager.js:
1120         (WebInspector.TimelineManager): Deleted.
1121         (WebInspector.TimelineManager.prototype._garbageCollected): Deleted.
1122         * UserInterface/Images/TimelineRecordGarbageCollection.svg: Removed.
1123         * UserInterface/Main.html:
1124         * UserInterface/Models/GarbageCollection.js: Removed.
1125         * UserInterface/Models/ScriptTimelineRecord.js:
1126         (WebInspector.ScriptTimelineRecord.EventType.displayName):
1127         (WebInspector.ScriptTimelineRecord.prototype.isGarbageCollection): Deleted.
1128         * UserInterface/Protocol/HeapObserver.js: Removed.
1129         * UserInterface/Test.html:
1130         * UserInterface/Test/Test.js:
1131         (WebInspector.loaded): Deleted.
1132         * UserInterface/Views/ScriptTimelineDataGridNode.js:
1133         (WebInspector.ScriptTimelineDataGridNode.prototype.get data):
1134         (WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent): Deleted.
1135         (WebInspector.ScriptTimelineDataGridNode): Deleted.
1136         * UserInterface/Views/ScriptTimelineOverviewGraph.js:
1137         (WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout):
1138         * UserInterface/Views/ScriptTimelineView.js:
1139         (WebInspector.ScriptTimelineView.prototype._processPendingRecords):
1140         * UserInterface/Views/SourceCodeTimelineTreeElement.js:
1141         (WebInspector.SourceCodeTimelineTreeElement):
1142         * UserInterface/Views/TimelineIcons.css:
1143         (.garbage-collection-profile-record .icon): Deleted.
1144         * UserInterface/Views/TimelineRecordBar.css:
1145         (.timeline-record-bar.timeline-record-type-script.script-timeline-record-garbage-collected > .segment): Deleted.
1146         * UserInterface/Views/TimelineRecordBar.js:
1147         (WebInspector.TimelineRecordBar.createCombinedBars):
1148         * UserInterface/Views/TimelineRecordTreeElement.js:
1149         (WebInspector.TimelineRecordTreeElement):
1150
1151 2015-10-02  Devin Rousso  <dcrousso+webkit@gmail.com>
1152
1153         Web Inspector: Option-Click on a property name in the Computed view should jump to resource view
1154         https://bugs.webkit.org/show_bug.cgi?id=149521
1155
1156         Reviewed by Timothy Hatcher.
1157
1158         * UserInterface/Models/DOMNodeStyles.js:
1159         (WebInspector.DOMNodeStyles.prototype.effectivePropertyForName):
1160         Now tries to search for a non-canonical property before falling back to
1161         the canonical version.
1162
1163         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
1164         (WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded):
1165         If the user option-clicks the goto arrow, it shows the source for the
1166         property instead.
1167
1168         * UserInterface/Views/ComputedStyleDetailsPanel.js:
1169         (WebInspector.ComputedStyleDetailsPanel.prototype.cssStyleDeclarationTextEditorShowProperty.delegateShowProperty):
1170         (WebInspector.ComputedStyleDetailsPanel.prototype.cssStyleDeclarationTextEditorShowProperty):
1171         Attempts to show the source of the given property. Will fallback to
1172         highlighting the property in the rules panel.
1173
1174 2015-10-02  Joseph Pecoraro  <pecoraro@apple.com>
1175
1176         Web Inspector: Include Garbage Collection Event in Timeline
1177         https://bugs.webkit.org/show_bug.cgi?id=142510
1178
1179         Reviewed by Geoffrey Garen.
1180
1181         * UserInterface/Base/Utilities.js:
1182         (Array.prototype.parition):
1183         Helper to partition an Array into two arrays.
1184
1185         * UserInterface/Main.html:
1186         * Localizations/en.lproj/localizedStrings.js:
1187         * UserInterface/Base/Main.js:
1188         (WebInspector.loaded):
1189         * UserInterface/Test.html:
1190         * UserInterface/Test/Test.js:
1191         (WebInspector.loaded):
1192         * UserInterface/Protocol/HeapObserver.js:
1193         (WebInspector.HeapObserver.prototype.garbageCollected):
1194         (WebInspector.HeapObserver):
1195         Create the new observer and manager.
1196
1197         * UserInterface/Models/GarbageCollection.js:
1198         (WebInspector.GarbageCollection):
1199         (WebInspector.GarbageCollection.fromPayload):
1200         (WebInspector.GarbageCollection.prototype.get type):
1201         (WebInspector.GarbageCollection.prototype.get startTime):
1202         (WebInspector.GarbageCollection.prototype.get endTime):
1203         (WebInspector.GarbageCollection.prototype.get duration):
1204         Model object for Heap.GarbageCollection.
1205
1206         * UserInterface/Controllers/HeapManager.js:
1207         (WebInspector.HeapManager):
1208         (WebInspector.HeapManager.prototype.garbageCollected):
1209         Dispatch events with.
1210
1211         * UserInterface/Controllers/TimelineManager.js:
1212         (WebInspector.TimelineManager):
1213         (WebInspector.TimelineManager.prototype._garbageCollected):
1214         Include new GC Timeline Events as Script events.
1215
1216         * UserInterface/Views/ScriptTimelineOverviewGraph.js:
1217         (WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout):
1218         For the Script overview, make two sets of bars, one for Scripts and one for GCs.
1219         The GCs bar will be on top of the the Scripts bar. This is particularly useful
1220         since a GC can happen during script execution.
1221
1222         * UserInterface/Views/ScriptTimelineDataGridNode.js:
1223         (WebInspector.ScriptTimelineDataGridNode.prototype.get data):
1224         (WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent):
1225         (WebInspector.ScriptTimelineDataGridNode):
1226         Give a NaN call count to top level Script DataGridNodes.
1227         In the UI, display the empty placeholder for NaN call counts.
1228
1229         * UserInterface/Images/TimelineRecordGarbageCollection.svg: Added.
1230         * UserInterface/Models/ScriptTimelineRecord.js:
1231         (WebInspector.ScriptTimelineRecord.prototype.isGarbageCollection):
1232         (WebInspector.ScriptTimelineRecord.EventType.displayName):
1233         * UserInterface/Views/ScriptTimelineView.js:
1234         (WebInspector.ScriptTimelineView.prototype._processPendingRecords):
1235         * UserInterface/Views/SourceCodeTimelineTreeElement.js:
1236         (WebInspector.SourceCodeTimelineTreeElement):
1237         * UserInterface/Views/TimelineIcons.css:
1238         (.garbage-collection-profile-record .icon):
1239         * UserInterface/Views/TimelineRecordBar.css:
1240         (.timeline-record-bar.timeline-record-type-script.script-timeline-record-garbage-collected > .segment):
1241         UI for GC events.
1242
1243         * UserInterface/Views/TimelineRecordBar.js:
1244         (WebInspector.TimelineRecordBar.createCombinedBars):
1245         Simplify by storing start time into a variable.
1246
1247         * UserInterface/Views/TimelineRecordTreeElement.js:
1248         (WebInspector.TimelineRecordTreeElement):
1249         Icon for GC events.
1250
1251 2015-10-02  Nikita Vasilyev  <nvasilyev@apple.com>
1252
1253         Web Inspector: Fix indentation of console message parameters
1254         https://bugs.webkit.org/show_bug.cgi?id=149740
1255
1256         Reviewed by Darin Adler.
1257
1258         * UserInterface/Views/ConsoleMessageView.css:
1259         (.console-message .console-message-stack-trace-container > li):
1260         (.console-message .console-message-extra-parameters-container > li::before):
1261
1262 2015-10-02  Andres Gomez  <agomez@igalia.com>
1263
1264         [GTK] Web Inspector: Add GTK+ icons for new plus icons in the style sidebar
1265         https://bugs.webkit.org/show_bug.cgi?id=149227
1266
1267         Reviewed by Carlos Garcia Campos.
1268
1269         * UserInterface/Images/gtk/NewTabPlus.svg: Updated.
1270         * UserInterface/Images/gtk/Plus13.svg: Copied from Source/WebInspectorUI/UserInterface/Images/gtk/Plus.svg.
1271         * UserInterface/Images/gtk/Plus15.svg: Renamed from Source/WebInspectorUI/UserInterface/Images/gtk/Plus.svg.
1272
1273 2015-10-01  Joseph Pecoraro  <pecoraro@apple.com>
1274
1275         Web Inspector: Simplify filterableData processing
1276         https://bugs.webkit.org/show_bug.cgi?id=149730
1277
1278         Reviewed by Timothy Hatcher.
1279
1280         * UserInterface/Views/BreakpointTreeElement.js:
1281         (WebInspector.BreakpointTreeElement.prototype.get filterableData):
1282         * UserInterface/Views/NavigationSidebarPanel.js:
1283         (WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement.matchTextFilter):
1284         * UserInterface/Views/ResourceTreeElement.js:
1285         (WebInspector.ResourceTreeElement.prototype.get filterableData):
1286         * UserInterface/Views/ScriptTimelineView.js:
1287         (WebInspector.ScriptTimelineView.prototype.matchTreeElementAgainstCustomFilters): Deleted.
1288         * UserInterface/Views/SearchResultTreeElement.js:
1289         (WebInspector.SearchResultTreeElement.prototype.get filterableData):
1290         (WebInspector.SearchResultTreeElement):
1291
1292 2015-10-01  Joseph Pecoraro  <pecoraro@apple.com>
1293
1294         Web Inspector: Do not immediately create all ProfileNodeTreeElements when showing JavaScript and Events timeline
1295         https://bugs.webkit.org/show_bug.cgi?id=149726
1296
1297         Reviewed by Timothy Hatcher.
1298
1299         * UserInterface/Views/NavigationSidebarPanel.js:
1300         (WebInspector.NavigationSidebarPanel.prototype.shouldFilterPopulate):
1301         (WebInspector.NavigationSidebarPanel.prototype._updateFilter):
1302         (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
1303         We were populating during filtering if there were any custom filters.
1304         However the TimelineSidebarPanel has custom filters (based on time and type)
1305         but those don't need to trigger population. Delay population until it
1306         would actually be needed (like a text search).
1307
1308         * UserInterface/Views/TimelineSidebarPanel.js:
1309         (WebInspector.TimelineSidebarPanel.prototype.shouldFilterPopulate):
1310         Do not populate on filter via this custom filters.
1311
1312 2015-10-01  Matt Baker  <mattbaker@apple.com>
1313
1314         Web Inspector: REGRESSION (r189567): Toolbar collapses when inspector at minimum height with console open
1315         https://bugs.webkit.org/show_bug.cgi?id=149725
1316
1317         Reviewed by Timothy Hatcher.
1318
1319         CSS Flexible Box Layout Module Level 1 introduces a new `auto` initial value for the min-{width|height}
1320         of flex box items, breaking some areas of the inspector UI. This is fixed by setting a min-height of
1321         zero for the #main <div>.
1322
1323         * UserInterface/Views/Main.css:
1324         (#main):
1325
1326 2015-10-01  Nikita Vasilyev  <nvasilyev@apple.com>
1327
1328         Web Inspector: Clip string previews
1329         https://bugs.webkit.org/show_bug.cgi?id=149708
1330
1331         Only show first 140 characters in strings previews.
1332
1333         Reviewed by Joseph Pecoraro.
1334
1335         * UserInterface/Base/Utilities.js:
1336         (String.prototype.truncate): Added.
1337         A smart trancate function that doesn't split words.
1338
1339         * UserInterface/Views/ConsoleMessageView.js:
1340         (WebInspector.ConsoleMessageView.prototype._shouldConsiderObjectLossless):
1341         * UserInterface/Views/FormattedValue.js:
1342         (WebInspector.FormattedValue.createElementForTypesAndValue):
1343
1344 2015-09-30  João Oliveira  <hello@jxs.pt>
1345
1346         Web Inspector: Adjust font size of Developer Tools using Command,+ or Command,-
1347         https://bugs.webkit.org/show_bug.cgi?id=149590
1348
1349         Reviewed by Joseph Pecoraro.
1350
1351         Patch by João Oliveira and Brian Burg.
1352
1353         * UserInterface/Base/Main.js:
1354         (WebInspector.contentLoaded): Add global keyboard shortcuts for zoom in and zoom out.
1355
1356 2015-10-01  Andres Gomez  <agomez@igalia.com>
1357
1358         [GTK] Web Inspector: Add GTK+ icons for the numerical input and slider based Visual editors for CSS properties
1359         https://bugs.webkit.org/show_bug.cgi?id=147847
1360
1361         Reviewed by Carlos Garcia Campos.
1362
1363         * UserInterface/Images/gtk/VisualStylePropertyLinked.svg: Added.
1364         * UserInterface/Images/gtk/VisualStylePropertyUnlinked.svg: Added.
1365
1366 2015-10-01  Andres Gomez  <agomez@igalia.com>
1367
1368         [GTK] Web Inspector: Add GTK+ icons for the different types of non-numerical Visual editors for CSS properties
1369         https://bugs.webkit.org/show_bug.cgi?id=147846
1370
1371         Reviewed by Carlos Garcia Campos.
1372
1373         * UserInterface/Images/gtk/AUTHORS: Updated.
1374         * UserInterface/Images/gtk/ClearBoth.svg: Added.
1375         * UserInterface/Images/gtk/ClearLeft.svg: Added.
1376         * UserInterface/Images/gtk/ClearRight.svg: Added.
1377         * UserInterface/Images/gtk/CubicBezier.svg: Updated.
1378         * UserInterface/Images/gtk/FloatLeft.svg: Added.
1379         * UserInterface/Images/gtk/FloatRight.svg: Added.
1380         * UserInterface/Images/gtk/FontStyleItalic.svg: Added.
1381         * UserInterface/Images/gtk/FontStyleNormal.svg: Added.
1382         * UserInterface/Images/gtk/FontVariantSmallCaps.svg: Added.
1383         * UserInterface/Images/gtk/TextAlignCenter.svg: Added.
1384         * UserInterface/Images/gtk/TextAlignJustify.svg: Added.
1385         * UserInterface/Images/gtk/TextAlignLeft.svg: Added.
1386         * UserInterface/Images/gtk/TextAlignRight.svg: Added.
1387         * UserInterface/Images/gtk/TextDecorationLineThrough.svg: Added.
1388         * UserInterface/Images/gtk/TextDecorationOverline.svg: Added.
1389         * UserInterface/Images/gtk/TextDecorationUnderline.svg: Added.
1390         * UserInterface/Images/gtk/TextTransformCapitalize.svg: Added.
1391         * UserInterface/Images/gtk/TextTransformLowercase.svg: Added.
1392         * UserInterface/Images/gtk/TextTransformUppercase.svg: Added.
1393         * UserInterface/Images/gtk/VisualStyleNone.svg: Added.
1394
1395 2015-09-30  Joseph Pecoraro  <pecoraro@apple.com>
1396
1397         Web Inspector: Reduce `delete` in Timeline related classes
1398         https://bugs.webkit.org/show_bug.cgi?id=149686
1399
1400         Reviewed by Timothy Hatcher.
1401
1402         * UserInterface/Controllers/TimelineManager.js:
1403         (WebInspector.TimelineManager.prototype.capturingStopped):
1404         * UserInterface/Views/TimelineDataGrid.js:
1405         (WebInspector.TimelineDataGrid.prototype._refreshDirtyDataGridNodes):
1406         (WebInspector.TimelineDataGrid.prototype._sort):
1407         (WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode):
1408         * UserInterface/Views/TimelineOverview.js:
1409         (WebInspector.TimelineOverview.prototype.updateLayout):
1410         (WebInspector.TimelineOverview.prototype._handleScrollEvent):
1411         * UserInterface/Views/TreeOutlineDataGridSynchronizer.js:
1412         (WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeOutlineScrolled):
1413         (WebInspector.TreeOutlineDataGridSynchronizer.prototype._dataGridScrolled):
1414
1415         * UserInterface/Views/ProbeSetDataGrid.js:
1416         (WebInspector.ProbeSetDataGrid):
1417         (WebInspector.ProbeSetDataGrid.prototype._teardownData):
1418         Remove an unused member variable as well.
1419
1420 2015-09-30  Joseph Pecoraro  <pecoraro@apple.com>
1421
1422         Web Inspector: Thousands of timers fire after switching to JavaScript and Events timeline
1423         https://bugs.webkit.org/show_bug.cgi?id=149682
1424
1425         Reviewed by Timothy Hatcher.
1426
1427         Setting the status element of a GeneralTreeElement was triggering a
1428         TreeOutline.onchange event. For TreeOutlines with lots of tree elements
1429         (JavaScript & Events with profile nodes) this could result in thousands
1430         of onchange events that causes lots of unnecessary work and blocks
1431         future timers (like scroll synchronization) from firing.
1432
1433         This change eliminates TreeOutline change events for tree element
1434         changes that are not interesting.
1435
1436         * UserInterface/Views/GeneralTreeElement.js:
1437         (WebInspector.GeneralTreeElement.prototype.set status): Deleted.
1438         * UserInterface/Views/TreeOutline.js:
1439         (WebInspector.TreeElement.prototype.set tooltip): Deleted.
1440
1441 2015-09-30  Joseph Pecoraro  <pecoraro@apple.com>
1442
1443         Web Inspector: Reduce `delete` in TreeElements and DataGridNodes
1444         https://bugs.webkit.org/show_bug.cgi?id=149680
1445
1446         Reviewed by Timothy Hatcher.
1447
1448         * UserInterface/Views/BreakpointTreeElement.js:
1449         (WebInspector.BreakpointTreeElement):
1450         (WebInspector.BreakpointTreeElement.prototype._removeProbeSet):
1451         * UserInterface/Views/DataGrid.js:
1452         (WebInspector.DataGrid.prototype._editingCommitted.moveToNextCell):
1453         (WebInspector.DataGrid.prototype._editingCommitted):
1454         (WebInspector.DataGrid.prototype._editingCancelled):
1455         (WebInspector.DataGrid.prototype.removeColumn):
1456         (WebInspector.DataGridNode.prototype.refreshIfNeeded):
1457         (WebInspector.DataGridNode.prototype.refresh):
1458         (WebInspector.DataGridNode.prototype.expand):
1459         (WebInspector.DataGridNode.prototype.restorePosition):
1460         (WebInspector.DataGridNode):
1461         * UserInterface/Views/GeneralTreeElement.js:
1462         (WebInspector.GeneralTreeElement.prototype.ondetach):
1463         * UserInterface/Views/ResourceTimelineDataGridNode.js:
1464         (WebInspector.ResourceTimelineDataGridNode.prototype.refresh):
1465         * UserInterface/Views/TreeOutline.js:
1466         (WebInspector.TreeElement.prototype._fireDidChange):
1467         (WebInspector.TreeElement.prototype.expand):
1468
1469 2015-09-30  Andres Gomez  <agomez@igalia.com>
1470
1471         [GTK] Web Inspector: Add GTK+ icon for the Bezier curve visual editor
1472         https://bugs.webkit.org/show_bug.cgi?id=147681
1473
1474         Reviewed by Joseph Pecoraro.
1475
1476         * UserInterface/Images/gtk/CubicBezier.svg: Added.
1477
1478 2015-09-29  Joseph Pecoraro  <pecoraro@apple.com>
1479
1480         Web Inspector: Console completion suggestions should include properties on Object (hasOwnProperty, toString, etc)
1481         https://bugs.webkit.org/show_bug.cgi?id=149649
1482
1483         Reviewed by Darin Adler.
1484
1485         * UserInterface/Base/Utilities.js:
1486         (value):
1487         Since keySets in this instance are often used as hash maps with the
1488         `in` operator, create a blank object that won't have Object.prototype
1489         functions that would be seen by `in`.
1490
1491         * UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
1492         (WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.receivedPropertyNames.compare):
1493         Sort __defineGetter__ and __lookupGetter__ and friends last, since they
1494         are rarely used properties.
1495
1496 2015-09-29  Joseph Pecoraro  <pecoraro@apple.com>
1497
1498         Web Inspector: Missing completions for Symbol objects, console.error warning
1499         https://bugs.webkit.org/show_bug.cgi?id=149641
1500
1501         Reviewed by Darin Adler.
1502
1503         * UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
1504         (WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.getCompletions):
1505         (WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.evaluated):
1506         Include completions for symbol types.
1507
1508 2015-09-28  Joseph Pecoraro  <pecoraro@apple.com>
1509
1510         Web Inspector: Hitting ESC while editing element tag name leaves element in bad state
1511         https://bugs.webkit.org/show_bug.cgi?id=149506
1512
1513         Reviewed by Timothy Hatcher.
1514
1515         * UserInterface/Views/DOMTreeElement.js:
1516         (WebInspector.DOMTreeElement.prototype._startEditingTagName.editingCancelled):
1517         (WebInspector.DOMTreeElement.prototype._startEditingTagName):
1518         When cancelling editing of a tag name, revert any changes we had
1519         been making to the closing tag name.
1520
1521 2015-09-28  João Oliveira  <hello@jxs.pt>
1522
1523         Web Inspector: search shortcut in split console moves focus to search box, but doesn't show caret
1524         https://bugs.webkit.org/show_bug.cgi?id=149223
1525
1526         Reviewed by Timothy Hatcher.
1527
1528         When pressing console find shortcut (CMD+F) SearchBar now checks if there's text on _searchInput
1529         if so text is selected, if the textbox is empty, textbox gains focus.
1530
1531         * UserInterface/Views/SearchBar.js:
1532         (WebInspector.SearchBar.prototype.focus):
1533
1534 2015-09-25  Joseph Pecoraro  <pecoraro@apple.com>
1535
1536         Web Inspector: Reloading the page causes the inspector tab to switch back to "Resources" tab
1537         https://bugs.webkit.org/show_bug.cgi?id=148732
1538
1539         Reviewed by Darin Adler.
1540
1541         * UserInterface/Views/ResourceSidebarPanel.js:
1542         (WebInspector.ResourceSidebarPanel.prototype._scriptsCleared):
1543         Suppress selection of sibiling tree elements when removing extra folders.
1544
1545 2015-09-24  Ryosuke Niwa  <rniwa@webkit.org>
1546
1547         Ran sort-Xcode-project-file.
1548
1549         * WebInspectorUI.xcodeproj/project.pbxproj:
1550
1551 2015-09-23  Saam barati  <sbarati@apple.com>
1552
1553         Fix broken inspector tests.
1554
1555         Reviewed by Joseph Pecoraro and Brian Burg.
1556
1557         We can't redeclare a "let" variable and "var" variable using the same
1558         identifier at the top-level of a function.
1559
1560         * UserInterface/Test/InspectorProtocol.js:
1561         (InspectorProtocol.sendCommand):
1562         (InspectorProtocol.addEventListener):
1563         (InspectorProtocol.dispatchMessageFromBackend):
1564
1565 2015-09-23  Saam barati  <sbarati@apple.com>
1566
1567         Web Inspector: Don't use bind() when creating internal AST, instead, pass in "this" parameter to map()
1568         https://bugs.webkit.org/show_bug.cgi?id=149483
1569
1570         Reviewed by Joseph Pecoraro.
1571
1572         * UserInterface/Models/ScriptSyntaxTree.js:
1573         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
1574         (WebInspector.ScriptSyntaxTree):
1575
1576 2015-09-23  Saam barati  <sbarati@apple.com>
1577
1578         Web Inspector: Type bubbles missing for computed methods and methods on object literals
1579         https://bugs.webkit.org/show_bug.cgi?id=148562
1580
1581         Reviewed by Joseph Pecoraro.
1582
1583         This patch makes sure that computed methods are working
1584         for both classes and object literals. Also, methods now
1585         work on object literals. This patch also cleans up the
1586         "isGetterOrSetter" and "getterOrSetterRange" fields.
1587         Basically, we used this as a way to ask the type profiler
1588         for the return types of a function. Now, we just have
1589         a field called "typeProfilingReturnDivot" that is set
1590         on all functions so we don't need to conditionally ask
1591         if it's a getter or setter.
1592
1593         * UserInterface/Controllers/TypeTokenAnnotator.js:
1594         (WebInspector.TypeTokenAnnotator.prototype._insertTypeToken):
1595         * UserInterface/Models/ScriptSyntaxTree.js:
1596         (WebInspector.ScriptSyntaxTree.functionReturnDivot):
1597         (WebInspector.ScriptSyntaxTree.prototype._recurseArray):
1598         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
1599         (WebInspector.ScriptSyntaxTree):
1600
1601 2015-09-22  Devin Rousso  <dcrousso+webkit@gmail.com>
1602
1603         Web Inspector: The right sidebar always opens up on breakpoint
1604         https://bugs.webkit.org/show_bug.cgi?id=149261
1605
1606         Reviewed by Timothy Hatcher.
1607
1608         Whenever the debugger was paused, the sidebar was being forced to open.
1609         This has been removed in favor of letting the user decide.
1610
1611         * UserInterface/Base/Main.js:
1612         (WebInspector._debuggerDidPause):
1613
1614 2015-09-22  Saam barati  <sbarati@apple.com>
1615
1616         Web Inspector: [ES6] Improve Type Profiler Support for Arrow Functions
1617         https://bugs.webkit.org/show_bug.cgi?id=143171
1618
1619         Reviewed by Joseph Pecoraro.
1620
1621         Esprima and JSC both support arrow functions. We just
1622         need to support it in our AST and do the right things
1623         to include support in the type profiler bits.
1624
1625         * UserInterface/Controllers/TypeTokenAnnotator.js:
1626         (WebInspector.TypeTokenAnnotator.prototype._insertTypeToken):
1627         (WebInspector.TypeTokenAnnotator.prototype._translateToOffsetAfterFunctionParameterList.isLineTerminator):
1628         (WebInspector.TypeTokenAnnotator.prototype._translateToOffsetAfterFunctionParameterList):
1629         * UserInterface/Models/ScriptSyntaxTree.js:
1630         (WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement.removeFunctionsFilter):
1631         (WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement):
1632         (WebInspector.ScriptSyntaxTree.functionReturnDivot):
1633         (WebInspector.ScriptSyntaxTree.prototype._recurse):
1634         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
1635         (WebInspector.ScriptSyntaxTree):
1636
1637 2015-09-22  Saam barati  <sbarati@apple.com>
1638
1639         Web Inspector: update Esprima to latest version
1640         https://bugs.webkit.org/show_bug.cgi?id=148960
1641
1642         Reviewed by Joseph Pecoraro.
1643
1644         Esprima version 2.6 further supports ES6. We're
1645         updating to it so we can support more ES6 features
1646         in our script syntax tree.
1647
1648         * UserInterface/External/Esprima/LICENSE:
1649         * UserInterface/External/Esprima/esprima.js:
1650         * UserInterface/Models/ScriptSyntaxTree.js:
1651         (WebInspector.ScriptSyntaxTree.prototype._gatherIdentifiersInDeclaration.gatherIdentifiers):
1652         (WebInspector.ScriptSyntaxTree.prototype._gatherIdentifiersInDeclaration):
1653         (WebInspector.ScriptSyntaxTree.prototype._recurse):
1654         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
1655         (WebInspector.ScriptSyntaxTree):
1656
1657 2015-09-21  Matt Baker  <mattbaker@apple.com>
1658
1659         Web Inspector: requestAnimationFrame continues to be called after stopping the timeline recording
1660         https://bugs.webkit.org/show_bug.cgi?id=149390
1661
1662         Reviewed by Brian Burg.
1663
1664         * UserInterface/Views/TimelineRecordingContentView.js:
1665         (WebInspector.TimelineRecordingContentView.prototype._update):
1666         Stop calling requestAnimationFrame if this._updating is false and recording end time is NaN.
1667
1668 2015-09-17  Joseph Pecoraro  <pecoraro@apple.com>
1669
1670         Web Inspector: Simplify some functional callbacks
1671         https://bugs.webkit.org/show_bug.cgi?id=149333
1672
1673         Reviewed by Brian Burg.
1674
1675         * UserInterface/Controllers/LogManager.js:
1676         (WebInspector.LogManager.prototype.messageWasAdded):
1677         * UserInterface/Models/Color.js:
1678         (WebInspector.Color):
1679         * UserInterface/Models/Geometry.js:
1680         (WebInspector.CubicBezier.fromCoordinates):
1681         * UserInterface/Models/ObjectPreview.js:
1682         (WebInspector.ObjectPreview.fromPayload):
1683         * UserInterface/Models/TypeDescription.js:
1684         (WebInspector.TypeDescription.fromPayload):
1685         * UserInterface/Protocol/RemoteObject.js:
1686         (WebInspector.RemoteObject.prototype.getCollectionEntries):
1687         (WebInspector.RemoteObject.prototype.getCollectionEntries.): Deleted.
1688         * UserInterface/Views/TextEditor.js:
1689         (WebInspector.TextEditor.prototype.get markers):
1690         (WebInspector.TextEditor.prototype.markersAtPosition):
1691
1692 2015-09-17  Joseph Pecoraro  <pecoraro@apple.com>
1693
1694         Web Inspector: Remove unused canClearBrowserCookies / canClearBrowserCache protocol methods
1695         https://bugs.webkit.org/show_bug.cgi?id=149307
1696
1697         Reviewed by Brian Burg.
1698
1699         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
1700         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
1701         * UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
1702         * Versions/Inspector-iOS-7.0.json:
1703         * Versions/Inspector-iOS-8.0.json:
1704         * Versions/Inspector-iOS-9.0.json:
1705         Retroactively remove the protocol methods as they were unused
1706         in these earlier versions as well.
1707
1708 2015-09-17  Joseph Pecoraro  <pecoraro@apple.com>
1709
1710         REGRESSION: Web Inspector: Double clicking on an attribute second time doesn't work
1711         https://bugs.webkit.org/show_bug.cgi?id=149259
1712
1713         Reviewed by Timothy Hatcher.
1714
1715         * UserInterface/Views/DOMTreeElement.js:
1716         Be sure to clear the editing state when committed, even if the value did not change.
1717
1718 2015-09-17  Joseph Pecoraro  <pecoraro@apple.com>
1719
1720         Web Inspector: Make Find / Save keyboard shortcuts work better globally
1721         https://bugs.webkit.org/show_bug.cgi?id=149198
1722
1723         Reviewed by Brian Burg.
1724
1725         Previously find/save keyboard shortcuts required the user have the
1726         ContentView in the ContentBrowser focused. That means nothing would
1727         happen if you clicked / focused in the Sidebars. This change considers
1728         the keyboard shortcuts globally, like Copy.
1729
1730         * UserInterface/Base/Main.js:
1731         (WebInspector.contentLoaded):
1732         Add global find and save keyboard shortcuts.
1733
1734         (WebInspector._focusChanged):
1735         It is often useful to have the currentFocusedElement know if it is
1736         in a TextEditor or other CodeMirror editor. When editable the <textarea>
1737         is selected and not updating focused element. 
1738
1739         (WebInspector._focusedContentBrowser):
1740         (WebInspector._focusedContentView):
1741         Provide helpers for getting a good approximation of the current focused
1742         or visible content view that users would expect to be interacting with.
1743         Since the focus event may not fire when clicking around to elements
1744         like the <body>. Rather than make it explicitly focusable, check the
1745         document.activeElement, and if it is body aim for the main content
1746         browser instead of the currentFocusedElement which may be stale.
1747         Likewise, if the QuickConsole is focused and the split console is
1748         showing, treat it like the split browser is focused.
1749
1750         (WebInspector._focusedOrVisibleContentBrowser):
1751         (WebInspector._focusedOrVisibleContentView):
1752         If nothing is focused, default to the main content browser.
1753
1754         (WebInspector._find):
1755         Pass on to the ContentView which typically handles Find
1756         by showing its find banner.
1757
1758         (WebInspector._save):
1759         (WebInspector._saveAs):
1760         Check and save the current ContentView if supported.
1761
1762         * UserInterface/Views/LogContentView.js:
1763         (WebInspector.LogContentView.prototype.get supportsSearch):
1764         (WebInspector.LogContentView.prototype.handleFindEvent):
1765         Add custom find handling for LogContentView from the routed through the
1766         BrowserController instead of special event handlers in the controller.
1767
1768         (WebInspector.LogContentView.prototype.get supportsSave):
1769         (WebInspector.LogContentView.prototype.save): Deleted.
1770         (WebInspector.LogContentView.prototype.saveAs): Deleted.
1771         * UserInterface/Controllers/JavaScriptLogViewController.js:
1772         (WebInspector.JavaScriptLogViewController): Deleted.
1773         (WebInspector.JavaScriptLogViewController.prototype._handleFindShortcut): Deleted.
1774         (WebInspector.JavaScriptLogViewController.prototype._save): Deleted.
1775         (WebInspector.JavaScriptLogViewController.prototype._saveAs): Deleted.
1776         Special save handling is no longer needed in the log view controller.
1777
1778         * UserInterface/Views/ContentBrowser.js:
1779         (WebInspector.ContentBrowser.prototype.handleFindEvent):
1780         (WebInspector.ContentBrowser): Deleted.
1781         (WebInspector.ContentBrowser.prototype._save): Deleted.
1782         (WebInspector.ContentBrowser.prototype._saveAs): Deleted.
1783         (WebInspector.ContentBrowser.prototype._showFindBanner): Deleted.
1784         Save functionality moved globally, find functionality moved to a
1785         public method called like copy event handling.
1786
1787 2015-09-17  Joseph Pecoraro  <pecoraro@apple.com>
1788
1789         Web Inspector: Inactive window may cause many layers to be created due to Dashboard opacity
1790         https://bugs.webkit.org/show_bug.cgi?id=149274
1791
1792         Reviewed by Brian Burg.
1793
1794         The dashboard container gets an opacity when the window is inactive. Combined
1795         with the animating debugger continue button this caused a cascade of slightly
1796         overlapping content causing a cascade of a lot of small layers. The simple
1797         approach taken here is to stop the slight pulse animation when the window
1798         is inactive.
1799
1800         * UserInterface/Views/DebuggerDashboardView.css:
1801         (body.window-inactive .dashboard.debugger .navigation-bar .item.button > .glyph):
1802
1803 2015-09-17  Devin Rousso  <dcrousso+webkit@gmail.com>
1804
1805         REGRESSION(r188427): Web Inspector: Extra whitespace left behind in styles sidebar after clicking in and out
1806         https://bugs.webkit.org/show_bug.cgi?id=149197
1807
1808         Reviewed by Timothy Hatcher.
1809
1810         In r188427, logic was added to preserve the leading whitespace of styles in a CSS file.
1811         An unfortunate side effect of this was that extra newlines in between CSS properties
1812         were treated as valid and left where they were.  This is undesired behaviour and often
1813         clutters the styles sidebar.  These changes remove the extra newlines.
1814
1815         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
1816         (WebInspector.CSSStyleDeclarationTextEditor.prototype._formattedContent):
1817
1818 2015-09-16  Joseph Pecoraro  <pecoraro@apple.com>
1819
1820         Web Inspector: Reduce Annotation Update Frequency
1821         https://bugs.webkit.org/show_bug.cgi?id=149250
1822
1823         Reviewed by Saam Barati.
1824
1825         * UserInterface/Controllers/BasicBlockAnnotator.js:
1826         (WebInspector.BasicBlockAnnotator.prototype._annotateBasicBlockExecutionRanges):
1827         * UserInterface/Controllers/TypeTokenAnnotator.js:
1828         (WebInspector.BasicBlockAnnotator.prototype.insertAnnotations):
1829         Set a lower bound of 500ms on update frequency for both annotators.
1830
1831 2015-09-16  Joseph Pecoraro  <pecoraro@apple.com>
1832
1833         Web Inspector: Fix common typo "supress" => "suppress"
1834         https://bugs.webkit.org/show_bug.cgi?id=149199
1835
1836         Reviewed by Gyuyoung Kim.
1837
1838         * UserInterface/Views/DataGrid.js:
1839         (WebInspector.DataGridNode.prototype.select):
1840         (WebInspector.DataGridNode.prototype.deselect):
1841         * UserInterface/Views/SearchBar.js:
1842         (WebInspector.SearchBar):
1843
1844 2015-09-16  Joseph Pecoraro  <pecoraro@apple.com>
1845
1846         Web Inspector: Turn off line wrapping in resource text editors
1847         https://bugs.webkit.org/show_bug.cgi?id=149121
1848
1849         Reviewed by Darin Adler.
1850
1851         * UserInterface/Views/TextEditor.js:
1852         (WebInspector.TextEditor):
1853
1854 2015-09-15  Devin Rousso  <dcrousso+webkit@gmail.com>
1855
1856         Web Inspector: Picking unchanged for font-size does not reset back to the unchanged value
1857         https://bugs.webkit.org/show_bug.cgi?id=148351
1858
1859         Reviewed by Brian Burg.
1860
1861         Visual number editors now save any new values in the special placeholder element
1862         to display it whenever the "Unchanged" option is selected by the user.
1863
1864         * UserInterface/Views/VisualStyleNumberInputBox.js:
1865         (WebInspector.VisualStyleNumberInputBox.prototype.set value):
1866         (WebInspector.VisualStyleNumberInputBox.prototype.set units):
1867         (WebInspector.VisualStyleNumberInputBox.prototype._setNumberInputIsEditable):
1868         (WebInspector.VisualStyleNumberInputBox.prototype._keywordChanged):
1869         (WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputKeyDown.adjustValue):
1870         (WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputKeyDown):
1871
1872 2015-09-15  Brian Burg  <bburg@apple.com>
1873
1874         Web Inspector: command-click in NewTabContentView should open new tab without switching to it
1875         https://bugs.webkit.org/show_bug.cgi?id=149173
1876
1877         Reviewed by Joseph Pecoraro.
1878
1879         To allow a user to quickly restore tabs, it should be possible to command-click
1880         all the tabs that are desired without going back through the [+] tab button.
1881
1882         * UserInterface/Base/Main.js:
1883         (WebInspector.createNewTabWithType): Renamed.
1884
1885             Use an options object and split creating the tab from deleting the
1886             replaced tab and showing the new tab. Add better error checking.
1887
1888         (WebInspector.createNewTab): Deleted.
1889         * UserInterface/Views/NewTabContentView.js:
1890         (WebInspector.NewTabContentView):
1891         (WebInspector.NewTabContentView.prototype._createNewTabWithType): Renamed.
1892
1893             If the meta key is pressed, don't switch to the new tab or remove this view
1894             unless there are no more tabs that can be created beyond the current one.
1895
1896         (WebInspector.NewTabContentView.prototype._allowableTabTypes): Added.
1897         (WebInspector.NewTabContentView.prototype._createNewTab): Deleted.
1898
1899 2015-09-15  Joseph Pecoraro  <pecoraro@apple.com>
1900
1901         Web Inspector: Watch Expressions uncaught exceptions on page reload
1902         https://bugs.webkit.org/show_bug.cgi?id=149150
1903
1904         Reviewed by Brian Burg.
1905
1906         Instead of waiting 50ms to Resume, when the page navigates
1907         Resume immediately. This ensures nobody is using a stale
1908         activeCallFrame after the navigation.
1909
1910         Also clean up the manager a bit by removing some deletes.
1911
1912         * UserInterface/Controllers/DebuggerManager.js:
1913         (WebInspector.DebuggerManager.restoreBreakpointsSoon):
1914         (WebInspector.DebuggerManager.prototype.reset):
1915         (WebInspector.DebuggerManager.prototype.debuggerDidPause):
1916         (WebInspector.DebuggerManager.prototype.debuggerDidResume):
1917         (WebInspector.DebuggerManager.prototype._mainResourceDidChange):
1918         (WebInspector.DebuggerManager.prototype._didResumeInternal):
1919         (WebInspector.DebuggerManager.prototype._associateBreakpointsWithSourceCode):
1920         (WebInspector.DebuggerManager.prototype.debuggerDidResume.delayedWork): Deleted.
1921
1922 2015-09-15  Joseph Pecoraro  <pecoraro@apple.com>
1923
1924         Web Inspector: Closing the final inspector tab should be allowed
1925         https://bugs.webkit.org/show_bug.cgi?id=149130
1926
1927         Reviewed by Brian Burg.
1928
1929         Previously we did not allow closing the last inspector tab. Now, we
1930         will allow closing all inspector tabs, and when the last is closed,
1931         present an unclosable New Tab tab, which would then be used to create
1932         a new tab.
1933
1934         * UserInterface/Base/Main.js:
1935         (WebInspector.contentLoaded):
1936         If we have no tabs to restore, show the New Tab tab.
1937
1938         (WebInspector._openDefaultTab):
1939         When the last tab is closed, the tab bar requests we open a default tab.
1940         Open the New Tab tab.
1941
1942         (WebInspector.TabBar.prototype._handleClick):
1943         Disallow closing the single default tab.
1944
1945         (WebInspector._newTabItemClicked):
1946         (WebInspector.showNewTabTab):
1947         Share logic for showing the New Tab tab.
1948
1949         * UserInterface/Views/NewTabContentView.js:
1950         (WebInspector.NewTabContentView):
1951         Mark the new tab's tab bar item as the "default" tab bar item. It gets
1952         special behavior when it is the single normal tab (cannot be closed).
1953
1954         * UserInterface/Views/TabBar.css:
1955         (body:not(.window-inactive) .tab-bar > .item:hover > .close):
1956         (body:not(.window-inactive) .tab-bar.single-tab > .item.default-tab:hover > .close):
1957         (.tab-bar.single-tab > .item.default-tab > .close):
1958         (body:not(.window-inactive) .tab-bar:not(.single-tab) > .item:not(.hide-close-button):hover > .close): Deleted.
1959         (.tab-bar > .item.hide-close-button > .close): Deleted.
1960         Update styles to only disable the close button on the
1961         "default-tab" when it is the "single-tab" open. Otherwise
1962         always allow closing tabs.
1963
1964         * UserInterface/Views/TabBar.js:
1965         (WebInspector.TabBar.prototype.removeTabBarItem):
1966         (WebInspector.TabBar.prototype.hasNormalTab):
1967         (WebInspector.TabBar.prototype._openDefaultTab):
1968         When removing the last normal tab, send an event to open
1969         the default tab.
1970
1971         * UserInterface/Views/TabBarItem.js:
1972         (WebInspector.TabBarItem.prototype.get default):
1973         (WebInspector.TabBarItem.prototype.get isDefaultTab):
1974         (WebInspector.TabBarItem.prototype.set isDefaultTab):
1975         (WebInspector.TabBarItem.prototype.get hideCloseButton): Deleted.
1976         (WebInspector.TabBarItem.prototype.set hideCloseButton): Deleted.
1977         Switch to marking a tab bar item as the default tab. This tab
1978         will be allowed when it is the single remaining tab. Currently
1979         the default tab is always the "New Tab" tab.
1980
1981 2015-09-15  Brian Burg  <bburg@apple.com>
1982
1983         Web Inspector: new tab content view should disallow split console
1984         https://bugs.webkit.org/show_bug.cgi?id=149164
1985
1986         Reviewed by Joseph Pecoraro.
1987
1988         * UserInterface/Views/NewTabContentView.js:
1989         (WebInspector.NewTabContentView.prototype.get supportsSplitContentBrowser):
1990
1991 2015-09-14  Brian Burg  <bburg@apple.com>
1992
1993         Web Inspector: tab bar stutters when moving mouse after closing tab
1994         https://bugs.webkit.org/show_bug.cgi?id=149138
1995
1996         Reviewed by Joseph Pecoraro.
1997
1998         The tab bar lacked the 'static-layout' class between when the Promise microtask
1999         ran and the beginning of the requestAnimationFrame. This caused a flash of
2000         tabs that are way too wide.
2001
2002         Re-add the static-layout class immediately after measuring the 'after' tab size.
2003         This code should probably just manually compute tab sizes since flexbox
2004         layout is quite slow and our measurement code here forces layout several times.
2005
2006         * UserInterface/Views/TabBar.js:
2007
2008 2015-09-14  Brian Burg  <bburg@apple.com>
2009
2010         Web Inspector: backend command promises are not rejected when a protocol error occurs
2011         https://bugs.webkit.org/show_bug.cgi?id=141403
2012
2013         Reviewed by Joseph Pecoraro.
2014
2015         Fix a few corner cases for how InspectorBackend delivers command failures.
2016
2017         * UserInterface/Protocol/InspectorBackend.js:
2018         (InspectorBackend.Command.prototype.deliverFailure): Added.
2019         (InspectorBackend.Command.prototype._invokeWithArguments):
2020
2021             If argument-checking fails, return a rejected promise or invoke the supplied callback
2022             on a zero-delay setTimeout to ensure that the reply is asynchronous.
2023
2024 2015-09-14  Brian Burg  <bburg@apple.com>
2025
2026         Web Inspector: middle-clicking a tab in the tab bar should close it
2027         https://bugs.webkit.org/show_bug.cgi?id=149135
2028
2029         Reviewed by Joseph Pecoraro.
2030
2031         This matches the behavior of the tab bar in Safari and other browsers.
2032
2033         * UserInterface/Views/TabBar.js:
2034         (WebInspector.TabBar.prototype._handleMouseDown):
2035         (WebInspector.TabBar.prototype._handleClick):
2036
2037 2015-09-14  Nikita Vasilyev  <nvasilyev@apple.com>
2038
2039         Web Inspector: Border under the styles filter field is clipped
2040         https://bugs.webkit.org/show_bug.cgi?id=149115
2041
2042         Reviewed by Darin Adler.
2043
2044         * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
2045         (.sidebar > .panel.details.css-style > .content + .options-container > .filter-bar):
2046
2047 2015-09-11  Nan Wang  <n_wang@apple.com>
2048
2049         AX: ARIA 1.1 @aria-current
2050         https://bugs.webkit.org/show_bug.cgi?id=146012
2051
2052         Reviewed by Chris Fleizach.
2053
2054         Added support for ARIA 1.1 aria-current.
2055
2056         * Localizations/en.lproj/localizedStrings.js:
2057         * UserInterface/Models/DOMNode.js:
2058         * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
2059
2060 2015-09-10  Devin Rousso  <dcrousso+webkit@gmail.com>
2061
2062         Web Inspector: Styles sidebar says Media: all when it should say Media: screen
2063         https://bugs.webkit.org/show_bug.cgi?id=148436
2064
2065         Reviewed by Timothy Hatcher.
2066
2067         Removed filter that prevented "Media: screen" from being displayed.
2068
2069         * UserInterface/Views/RulesStyleDetailsPanel.js:
2070         (WebInspector.RulesStyleDetailsPanel.prototype.refresh.insertMediaOrInheritanceLabel):
2071         (WebInspector.RulesStyleDetailsPanel.prototype.refresh.filteredMediaList): Deleted.
2072
2073 2015-09-10  Matt Baker  <mattbaker@apple.com>
2074
2075         Web Inspector: Prefer calling ContentViewContainer.updateLayout directly
2076         https://bugs.webkit.org/show_bug.cgi?id=149041
2077
2078         Reviewed by Timothy Hatcher.
2079
2080         Cleaned up two places where a parent view duplicated logic encapsulated by ContentViewContainer.
2081
2082         * UserInterface/Views/ClusterContentView.js:
2083         (WebInspector.ClusterContentView.prototype.updateLayout):
2084         * UserInterface/Views/TimelineRecordingContentView.js:
2085         (WebInspector.TimelineRecordingContentView.prototype.updateLayout):
2086
2087 2015-09-08  Matt Baker  <mattbaker@apple.com>
2088
2089         Web Inspector: REGRESSION (r189189): Missing breakpoint context menu for debugger sidebar tree elements
2090         https://bugs.webkit.org/show_bug.cgi?id=148651
2091
2092         Reviewed by Timothy Hatcher.
2093
2094         * UserInterface/Base/Main.js:
2095         (WebInspector.contentLoaded):
2096         Create BreakpointPopoverController singleton, expose as public property of global WebInspector object.
2097
2098         * UserInterface/Views/BreakpointTreeElement.js:
2099         (WebInspector.BreakpointTreeElement.prototype.oncontextmenu):
2100         Use BreakpointPopoverController singleton.
2101
2102         * UserInterface/Views/SourceCodeTextEditor.js:
2103         (WebInspector.SourceCodeTextEditor):
2104         Don't create BreakpointPopoverController instance.
2105         (WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu):
2106         Use BreakpointPopoverController singleton.
2107
2108 2015-09-08  Joseph Pecoraro  <pecoraro@apple.com>
2109
2110         Fix inspector/codemirror tests.
2111
2112         Rubber-stamped by Brian Burg.
2113
2114         * UserInterface/Test.html:
2115         Reorder includes to be more like Main.html. This ensures that CodeMirror
2116         resources are loaded before Inspector sources use it, like CodeMirrorAdditions
2117         which gets merged into TestCombined.js.
2118
2119 2015-09-08  Joseph Pecoraro  <pecoraro@apple.com>
2120
2121         Web Inspector: Move PrettyPrinting tests into LayoutTests
2122         https://bugs.webkit.org/show_bug.cgi?id=148698
2123
2124         Reviewed by Timothy Hatcher.
2125
2126         * Tools/PrettyPrinting/index.html:
2127         Modify the relative path to the tests which are now in LayoutTests.
2128
2129         * UserInterface/Test.html:
2130         Load CodeMirror and related resources for Formatting.
2131
2132 2015-09-06  Andy Estes  <aestes@apple.com>
2133
2134         WebKit.xcworkspace should be be able to build iOS platforms
2135         https://bugs.webkit.org/show_bug.cgi?id=148881
2136
2137         Reviewed by Daniel Bates.
2138
2139         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
2140         for all supported platforms.
2141
2142         * Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
2143         * Configurations/WebInspectorUIFramework.xcconfig: Skipped installing on iOS.
2144
2145 2015-09-04  Brian Burg  <bburg@apple.com>
2146
2147         Web Inspector: combine Test.html resources to make tests run faster
2148         https://bugs.webkit.org/show_bug.cgi?id=148726
2149
2150         Reviewed by Timothy Hatcher.
2151
2152         In an attempt to make inspector tests run faster, always combine resources
2153         on the Test.html page. This cuts down from 110+ resource loads to 5 loads.
2154
2155         To avoid name clashes, add the 'Combined' suffix to files that would clash
2156         with uncombined Test resources, and add the 'Test' prefix when combining
2157         or minifying files that would clash with production minification. So, it
2158         would be possible for Main.html and Test.html to have different minified
2159         versions of CodeMirror or other external libraries if they use different
2160         subsets.
2161
2162         Combining is unlikely to make debugging tests more difficult, since almost
2163         all test code is marshalled and eval'd into existence anyway.
2164
2165         * Configurations/WebInspectorUIFramework.xcconfig:
2166         * Scripts/combine-resources.pl: Drive-by spelling.
2167         (concatenateFiles):
2168         (concatinateFiles): Deleted.
2169         * Scripts/copy-user-interface-resources-dryrun.rb:
2170         * Scripts/copy-user-interface-resources.pl:
2171
2172             Drive-by spelling. Add a new code path for combining Test resources, which
2173             doesn't require minification or handling CSS, images, or most externals.
2174
2175         * WebInspectorUI.vcxproj/build-webinspectorui.pl:
2176
2177             Always combine Test.html, but also ditto everything into place for
2178             engineering builds.
2179
2180 2015-09-04  Joseph Pecoraro  <pecoraro@apple.com>
2181
2182         Web Inspector: Test Runtime.saveResult and $n values
2183         https://bugs.webkit.org/show_bug.cgi?id=148837
2184
2185         Reviewed by Timothy Hatcher.
2186
2187         * UserInterface/Protocol/InspectorBackend.js:
2188         (InspectorBackendClass):
2189         Initialize the dump logging function different if we are in tests or not.
2190         When in tests, using console.log as well as dumping system activity to
2191         the system console results in an infinite loop of logging!
2192
2193         (InspectorBackendClass.prototype.dispatch):
2194         (InspectorBackendClass.prototype._sendCommandToBackendWithCallback):
2195         Use the logging function we figured out earlier.
2196
2197 2015-09-04  Joseph Pecoraro  <pecoraro@apple.com>
2198
2199         Web Inspector: Clean up and modernize DOMTreeManager
2200         https://bugs.webkit.org/show_bug.cgi?id=148821
2201
2202         Reviewed by Timothy Hatcher.
2203
2204         * UserInterface/Controllers/DOMTreeManager.js:
2205         (WebInspector.DOMTreeManager.prototype.requestDocument.onDocumentAvailable):
2206         (WebInspector.DOMTreeManager.prototype.requestDocument):
2207         (WebInspector.DOMTreeManager.prototype.pushNodeByPathToFrontend):
2208         (WebInspector.DOMTreeManager.prototype._wrapClientCallback):
2209         (WebInspector.DOMTreeManager.prototype._attributeModified):
2210         (WebInspector.DOMTreeManager.prototype._attributeRemoved):
2211         (WebInspector.DOMTreeManager.prototype._inlineStyleInvalidated):
2212         (WebInspector.DOMTreeManager.prototype._loadNodeAttributes):
2213         (WebInspector.DOMTreeManager.prototype.cancelSearch):
2214         (WebInspector.DOMTreeManager.prototype.querySelector):
2215         (WebInspector.DOMTreeManager.prototype.querySelectorAll):
2216         (WebInspector.DOMTreeManager.prototype.highlightDOMNode):
2217         (WebInspector.DOMTreeManager.prototype._buildHighlightConfig):
2218         Cleanup and modernize where appropriate.
2219
2220         * UserInterface/Views/SearchSidebarPanel.js:
2221         (WebInspector.SearchSidebarPanel.prototype.performSearch):
2222         Callback is now required.
2223
2224 2015-09-04  Matt Baker  <mattbaker@apple.com>
2225
2226         Web Inspector: Render Frames "Other" task filter checkbox misaligned with text
2227         https://bugs.webkit.org/show_bug.cgi?id=148788
2228
2229         Reviewed by Timothy Hatcher.
2230
2231         * UserInterface/Views/ChartDetailsSectionRow.css:
2232         (.details-section > .content > .group > .row.chart > .chart-content > .legend > .legend-item > label > .color-key):
2233         Adjust "fake" checkbox margin to align with label text.
2234
2235 2015-09-04  Joseph Pecoraro  <pecoraro@apple.com>
2236
2237         Web Inspector: Expand Console domain test coverage
2238         https://bugs.webkit.org/show_bug.cgi?id=148740
2239
2240         Reviewed by Brian Burg.
2241
2242         * UserInterface/Protocol/RemoteObject.js:
2243         Add a few helpers for checking the RemoteObject type.
2244
2245 2015-09-02  Commit Queue  <commit-queue@webkit.org>
2246
2247         Unreviewed, rolling out r189241.
2248         https://bugs.webkit.org/show_bug.cgi?id=148703
2249
2250         These tests crash with assertions (Requested by ap on
2251         #webkit).
2252
2253         Reverted changeset:
2254
2255         "Web Inspector: Move PrettyPrinting tests into LayoutTests"
2256         https://bugs.webkit.org/show_bug.cgi?id=148698
2257         http://trac.webkit.org/changeset/189241
2258
2259 2015-09-01  Joseph Pecoraro  <pecoraro@apple.com>
2260
2261         Web Inspector: Move PrettyPrinting tests into LayoutTests
2262         https://bugs.webkit.org/show_bug.cgi?id=148698
2263
2264         Reviewed by Timothy Hatcher.
2265
2266         * Tools/PrettyPrinting/index.html:
2267         Modify the relative path to the tests which are now in LayoutTests.
2268
2269         * UserInterface/Test.html:
2270         Load CodeMirror and related resources for Formatting.
2271
2272 2015-09-01  Matt Baker  <mattbaker@apple.com>
2273
2274         Web Inspector: REGRESSION (r187873): Location column icon is missing in timeline data grids
2275         https://bugs.webkit.org/show_bug.cgi?id=148691
2276
2277         Reviewed by Timothy Hatcher.
2278
2279         * UserInterface/Views/TimelineDataGridNode.js:
2280         (WebInspector.TimelineDataGridNode.prototype.createCellContent):
2281         Added "icon" class name. Was using removed class variable (class="undefined").
2282
2283 2015-09-01  Matt Baker  <mattbaker@apple.com>
2284
2285         Web Inspector: Show layout/paint pixel area in the Rendering Frames tree outline
2286         https://bugs.webkit.org/show_bug.cgi?id=148674
2287
2288         Reviewed by Brian Burg.
2289
2290         * Localizations/en.lproj/localizedStrings.js:
2291         New UI string.
2292
2293         * UserInterface/Views/RenderingFrameTimelineView.css:
2294         (.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .navigation-sidebar-panel-content-tree-outline.rendering-frame .item:not(.paint-record):not(.layout-record) .subtitle):
2295         (.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .navigation-sidebar-panel-content-tree-outline.rendering-frame .item .subtitle): Deleted.
2296         Show subtitles for layout and paint records only. We still want to hide script record subtitles,
2297         since that information is already in the 'Location' column.
2298
2299         * UserInterface/Views/RenderingFrameTimelineView.js:
2300         (WebInspector.RenderingFrameTimelineView.prototype._processPendingRecords):
2301         Add tree element subtitle for LayoutTimelineRecords that specify width and height.
2302
2303 2015-09-01  Matt Baker  <mattbaker@apple.com>
2304
2305         Web Inspector: Reorder columns in the Rendering Frames data grid by importance
2306         https://bugs.webkit.org/show_bug.cgi?id=148672
2307
2308         Reviewed by Timothy Hatcher.
2309
2310         * UserInterface/Views/RenderingFrameTimelineView.js:
2311         (WebInspector.RenderingFrameTimelineView):
2312         Updated column order, rearranged the column object setup code to match.
2313
2314 2015-09-01  Brian Burg  <bburg@apple.com>
2315
2316         Web Inspector: rewrite inspector/console/command-line-api.html to use AsyncTestSuite
2317         https://bugs.webkit.org/show_bug.cgi?id=148637
2318
2319         Reviewed by Darin Adler.
2320
2321         * UserInterface/Base/Object.js:
2322         (WebInspector.Object.singleFireEventListener):
2323         (WebInspector.Object.singleFireEventListener.let.wrappedCallback): Arrow.
2324
2325 2015-09-01  Devin Rousso  <drousso@apple.com>
2326
2327         Web Inspector: New rule button in the style sidebar is blurry and too dark
2328         https://bugs.webkit.org/show_bug.cgi?id=148108
2329
2330         Reviewed by Timothy Hatcher.
2331
2332         Added support for Plus and Minus icons on non-retina screens.
2333         Also removed some CSS rules that no longer apply to anything.
2334
2335         * UserInterface/Images/Minus.svg:
2336         * UserInterface/Images/NewTabPlus.svg:
2337         * UserInterface/Images/Plus.svg: Removed.
2338         * UserInterface/Images/Plus13.svg: Copied from Source/WebInspectorUI/UserInterface/Images/Plus.svg.
2339         * UserInterface/Images/Plus15.svg: Copied from Source/WebInspectorUI/UserInterface/Images/Plus.svg.
2340
2341         * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
2342         (.sidebar > .panel.details.css-style > .content + .options-container):
2343         (.sidebar > .panel.details.css-style > .content + .options-container > .new-rule):
2344
2345         * UserInterface/Views/ProbeDetailsSidebarPanel.css:
2346         (.details-section.probe-set .options > .probe-add):
2347
2348         * UserInterface/Views/RulesStyleDetailsPanel.css:
2349         (.sidebar > .panel.details.css-style .rules .new-rule): Deleted.
2350         (.sidebar > .panel.details.css-style .rules > *:first-child:matches(.new-rule)): Deleted.
2351         (.sidebar > .panel.details.css-style > .content.filter-in-progress .new-rule): Deleted.
2352         (.sidebar > .panel.details.css-style > .content:not(.filter-in-progress) > .rules > .new-rule + .style-declaration-section): Deleted.
2353         (.sidebar > .panel.details.css-style > .content:not(.filter-in-progress) > .rules > .new-rule + .label): Deleted.
2354         (.sidebar > .panel.details.css-style .rules .new-rule img): Deleted.
2355         (.sidebar > .panel.details.css-style .rules .new-rule:hover): Deleted.
2356         (.sidebar > .panel.details.css-style .rules .new-rule:active): Deleted.
2357         (@media (-webkit-min-device-pixel-ratio: 2)): Deleted.
2358         Removed CSS rules that no longer apply.  The new rule button was moved to the Styles sidebar.
2359
2360         * UserInterface/Views/ScopeChainDetailsSidebarPanel.css:
2361         (.details-section.watch-expressions .options > .watch-expression-add):
2362
2363         * UserInterface/Views/TabBar.css:
2364         (.tab-bar > .item.new-tab-button > .icon):
2365
2366         * UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
2367         (.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-controls > div):
2368
2369         * UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js:
2370         (WebInspector.VisualStyleCommaSeparatedKeywordEditor):
2371
2372         * UserInterface/Views/VisualStyleSelectorSection.js:
2373         (WebInspector.VisualStyleSelectorSection):
2374
2375 2015-09-01  Brian Burg  <bburg@apple.com>
2376
2377         Web Inspector: add TestSuite hooks for per-testcase setup and teardown actions
2378         https://bugs.webkit.org/show_bug.cgi?id=148641
2379
2380         Reviewed by Timothy Hatcher.
2381
2382         It should be possible to run setup and teardown actions for each test case.
2383         The use case here is to add listeners, set up testcase-specific state, etc.
2384         To match how test functions work in each suite, the sync and async implementations
2385         take functions with no arguments and(resolve, reject), respectively.
2386
2387         * UserInterface/Test/TestSuite.js:
2388         (TestSuite.prototype.addTestCase):
2389         (TestSuite.messageFromThrownObject):
2390         (TestSuite):
2391         (AsyncTestSuite.prototype.runTestCases): Stick the extra functions in the chain.
2392         (AsyncTestSuite):
2393         (SyncTestSuite.prototype.runTestCases):
2394         (SyncTestSuite):
2395
2396 2015-09-01  Matt Baker  <mattbaker@apple.com>
2397
2398         Web Inspector: Visual style editor shouldn't allow alpha characters in numeric input fields
2399         https://bugs.webkit.org/show_bug.cgi?id=148580
2400
2401         Reviewed by Brian Burg.
2402
2403         * UserInterface/Views/VisualStyleNumberInputBox.js:
2404         (WebInspector.VisualStyleNumberInputBox):
2405         Added input element "changed" handler, renamed "keyup" handler to match "keydown" handler.
2406         (WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputChanged):
2407         Validate input in response to changed event.
2408
2409 2015-08-31  Nikita Vasilyev  <nvasilyev@apple.com>
2410
2411         Web Inspector: Command-Enter for selected JS in Debugger/Sources shouldn't change the focus
2412         https://bugs.webkit.org/show_bug.cgi?id=148613
2413
2414         Reviewed by Timothy Hatcher.
2415
2416         * UserInterface/Views/ConsoleTabContentView.js:
2417         (WebInspector.ConsoleTabContentView.prototype.shown):
2418         Always focus on the console prompt when the console tab get selected.
2419
2420         * UserInterface/Views/LogContentView.js:
2421         (WebInspector.LogContentView.prototype.shown): Deleted.
2422
2423 2015-08-31  Joseph Pecoraro  <pecoraro@apple.com>
2424
2425         Web Inspector: Debugger Popovers should work for object literal shorthand variables
2426         https://bugs.webkit.org/show_bug.cgi?id=148603
2427
2428         Reviewed by Timothy Hatcher.
2429
2430         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
2431         (WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
2432         Allow debugger popovers for object property shorthands, because they
2433         are actually variables that have values. Previously we ignored property
2434         name literals, because they were just property names until ES6.
2435
2436         * UserInterface/Views/CodeMirrorAdditions.js:
2437         Add a helper for walking through token types from a start position. It may be useful elsewhere.
2438
2439 2015-08-31  Matt Baker  <mattbaker@apple.com>
2440
2441         Web Inspector: Move the Popover code out of the Breakpoint model object
2442         https://bugs.webkit.org/show_bug.cgi?id=127328
2443
2444         Reviewed by Timothy Hatcher.
2445
2446         * UserInterface/Controllers/BreakpointPopoverController.js: Added.
2447         (WebInspector.BreakpointPopoverController):
2448         (WebInspector.BreakpointPopoverController.prototype.appendContextMenuItems.editBreakpoint):
2449         (WebInspector.BreakpointPopoverController.prototype.appendContextMenuItems.removeBreakpoint):
2450         (WebInspector.BreakpointPopoverController.prototype.appendContextMenuItems.toggleBreakpoint):
2451         (WebInspector.BreakpointPopoverController.prototype.appendContextMenuItems.toggleAutoContinue):
2452         (WebInspector.BreakpointPopoverController.prototype.appendContextMenuItems.revealOriginalSourceCodeLocation):
2453         (WebInspector.BreakpointPopoverController.prototype.appendContextMenuItems):
2454         (WebInspector.BreakpointPopoverController.prototype.showEditBreakpointPopover):
2455         (WebInspector.BreakpointPopoverController.prototype._createPopoverContent):
2456         (WebInspector.BreakpointPopoverController.prototype._popoverToggleEnabledCheckboxChanged):
2457         (WebInspector.BreakpointPopoverController.prototype._popoverConditionInputChanged):
2458         (WebInspector.BreakpointPopoverController.prototype._popoverToggleAutoContinueCheckboxChanged):
2459         (WebInspector.BreakpointPopoverController.prototype._popoverConditionInputKeyDown):
2460         (WebInspector.BreakpointPopoverController.prototype._popoverActionsCreateAddActionButton):
2461         (WebInspector.BreakpointPopoverController.prototype._popoverActionsAddActionButtonClicked):
2462         (WebInspector.BreakpointPopoverController.prototype._popoverActionsInsertBreakpointActionView):
2463         (WebInspector.BreakpointPopoverController.prototype.breakpointActionViewAppendActionView):
2464         (WebInspector.BreakpointPopoverController.prototype.breakpointActionViewRemoveActionView):
2465         (WebInspector.BreakpointPopoverController.prototype.breakpointActionViewResized):
2466         (WebInspector.BreakpointPopoverController.prototype.willDismissPopover):
2467         (WebInspector.BreakpointPopoverController.prototype.didDismissPopover):
2468         Added controller class to encapsulate view logic previously located in WebInspector.Breakpoint.
2469
2470         * UserInterface/Main.html:
2471         Added and updated file paths.
2472
2473         * UserInterface/Models/Breakpoint.js:
2474         (WebInspector.Breakpoint.prototype.appendContextMenuItems.editBreakpoint): Deleted.
2475         (WebInspector.Breakpoint.prototype.appendContextMenuItems.removeBreakpoint): Deleted.
2476         (WebInspector.Breakpoint.prototype.appendContextMenuItems.toggleBreakpoint): Deleted.
2477         (WebInspector.Breakpoint.prototype.appendContextMenuItems.toggleAutoContinue): Deleted.
2478         (WebInspector.Breakpoint.prototype.appendContextMenuItems.revealOriginalSourceCodeLocation): Deleted.
2479         (WebInspector.Breakpoint.prototype.appendContextMenuItems): Deleted.
2480         (WebInspector.Breakpoint.prototype._popoverToggleEnabledCheckboxChanged): Deleted.
2481         (WebInspector.Breakpoint.prototype._popoverConditionInputChanged): Deleted.
2482         (WebInspector.Breakpoint.prototype._popoverToggleAutoContinueCheckboxChanged): Deleted.
2483         (WebInspector.Breakpoint.prototype._popoverConditionInputKeyDown): Deleted.
2484         (WebInspector.Breakpoint.prototype._editBreakpointPopoverContentElement): Deleted.
2485         (WebInspector.Breakpoint.prototype._popoverActionsCreateAddActionButton): Deleted.
2486         (WebInspector.Breakpoint.prototype._popoverActionsAddActionButtonClicked): Deleted.
2487         (WebInspector.Breakpoint.prototype._popoverActionsInsertBreakpointActionView): Deleted.
2488         (WebInspector.Breakpoint.prototype.breakpointActionViewAppendActionView): Deleted.
2489         (WebInspector.Breakpoint.prototype.breakpointActionViewRemoveActionView): Deleted.
2490         (WebInspector.Breakpoint.prototype.breakpointActionViewResized): Deleted.
2491         (WebInspector.Breakpoint.prototype.willDismissPopover): Deleted.
2492         (WebInspector.Breakpoint.prototype.didDismissPopover): Deleted.
2493         (WebInspector.Breakpoint.prototype._showEditBreakpointPopover): Deleted.
2494         Removed view logic.
2495
2496         * UserInterface/Views/BreakpointPopoverController.css: Renamed from Source/WebInspectorUI/UserInterface/Views/Breakpoint.css.
2497         (.popover .edit-breakpoint-popover-content):
2498         (.popover .edit-breakpoint-popover-content.wide):
2499         (.popover .edit-breakpoint-popover-content > label.toggle):
2500         (.popover .edit-breakpoint-popover-content > table):
2501         (.popover .edit-breakpoint-popover-content > table > tr > th):
2502         (.popover .edit-breakpoint-popover-content > table > tr > td):
2503         (#edit-breakpoint-popover-condition):
2504         (#edit-breakpoint-popoover-auto-continue):
2505
2506         * UserInterface/Views/SourceCodeTextEditor.js:
2507         (WebInspector.SourceCodeTextEditor):
2508         Creates a BreakpointPopoverController instance. The lifetime of the 'Edit Breakpoint' view is internal to the
2509         controller, and can't be initiated outside of a context menu item click.
2510
2511 2015-08-31  Matt Baker  <mattbaker@apple.com>
2512
2513         Web Inspector: Rendering Frame tasks making up < 1% of the selection don't appear in the pie chart
2514         https://bugs.webkit.org/show_bug.cgi?id=148549
2515
2516         Reviewed by Timothy Hatcher.
2517
2518         Small data points can be invisible or difficult to see in the pie chart. This patch introduces
2519         a minimum slice size of 1.5% (determined by visual inspection) for chart items.
2520
2521         Legend items continue to show the original data point values, not the adjusted values used to
2522         draw the chart slices.
2523
2524         * UserInterface/Views/ChartDetailsSectionRow.js:
2525         (WebInspector.ChartDetailsSectionRow):
2526         (WebInspector.ChartDetailsSectionRow.prototype._updateLayout):
2527         Adjust display values up or down as needed, so no data point is less than the
2528         minimum and all chart slices still total 100%.
2529
2530 2015-08-28  Joseph Pecoraro  <pecoraro@apple.com>
2531
2532         Web Inspector: "animationEnd" event names should be "animationend" (broken dashboard animation after pause)
2533         https://bugs.webkit.org/show_bug.cgi?id=148604
2534
2535         Reviewed by Timothy Hatcher.
2536
2537         * UserInterface/Views/DOMTreeElement.js:
2538         (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight):
2539         * UserInterface/Views/DashboardContainerView.js:
2540         (WebInspector.DashboardContainerView.prototype._showDashboardView.animationEnded):
2541         (WebInspector.DashboardContainerView.prototype._showDashboardView):
2542         (WebInspector.DashboardContainerView.prototype._hideDashboardView.animationEnded):
2543         (WebInspector.DashboardContainerView.prototype._hideDashboardView):
2544         * UserInterface/Views/DefaultDashboardView.js:
2545         (WebInspector.DefaultDashboardView.prototype._setConsoleItemValue.animationEnded):
2546         (WebInspector.DefaultDashboardView.prototype._setConsoleItemValue):
2547         * UserInterface/Views/TextEditor.js:
2548         (WebInspector.TextEditor.prototype._revealSearchResult):
2549
2550 2015-08-28  Joseph Pecoraro  <pecoraro@apple.com>
2551
2552         Web Inspector: Resource.prototype.associateWithScript assertions firing
2553         https://bugs.webkit.org/show_bug.cgi?id=148601
2554
2555         Reviewed by Timothy Hatcher.
2556
2557         * UserInterface/Models/Resource.js:
2558         (WebInspector.Resource.prototype.associateWithScript):
2559         Restore the code that was here before it was converted to asserts.
2560         It looked as if it was iOS 6 only but it was not.
2561
2562 2015-08-28  Joseph Pecoraro  <pecoraro@apple.com>
2563
2564         Web Inspector: Improve ScriptSyntaxTree a bit
2565         https://bugs.webkit.org/show_bug.cgi?id=148563
2566
2567         Reviewed by Timothy Hatcher.
2568
2569         * UserInterface/Models/ScriptSyntaxTree.js:
2570         (WebInspector.ScriptSyntaxTree.prototype._recurse):
2571         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2572         Share and fix ClassDeclaration and ClassExpression recursion to visit
2573         the identifier (node.id). Include the kind with a VariableDeclaration
2574         ("var", "let", "const").
2575
2576 2015-08-28  Joseph Pecoraro  <pecoraro@apple.com>
2577
2578         Web Inspector: Separate creating a style sheet from adding a new rule in the protocol
2579         https://bugs.webkit.org/show_bug.cgi?id=148502
2580
2581         Reviewed by Timothy Hatcher.
2582
2583         The backend allows creating multiple stylesheets. This patch makes
2584         the frontend have a preferred InspectorStyleSheet per-frame.
2585
2586         * UserInterface/Base/Object.js:
2587         (WebInspector.Object.singleFireEventListener):
2588         Return the wrapped listener so it can be removed if needed.
2589
2590         * UserInterface/Models/CSSStyleSheet.js:
2591         (WebInspector.CSSStyleSheet.prototype.isInspectorStyleSheet):
2592         Helper to check if the current stylesheet is an inspector created stylesheet.
2593
2594         * UserInterface/Controllers/CSSStyleManager.js:
2595         (WebInspector.CSSStyleManager.prototype.preferredInspectorStyleSheetForFrame):
2596         (WebInspector.CSSStyleManager.prototype.preferredInspectorStyleSheetForFrame.documentNodeAvailable):
2597         (WebInspector.CSSStyleManager.prototype.preferredInspectorStyleSheetForFrame.bodyNodeAvailable):
2598         (WebInspector.CSSStyleManager.prototype.preferredInspectorStyleSheetForFrame.cssRuleAvailable):
2599         (WebInspector.CSSStyleManager.prototype._inspectorStyleSheetsForFrame):
2600         Lookup the inspector stylesheet for a particular frame. If one doesn't exist create it.
2601         For legacy backends, exploit "addRule" to create the inspector stylesheet.
2602
2603         * UserInterface/Models/DOMNode.js:
2604         * UserInterface/Models/DOMNodeStyles.js:
2605         (WebInspector.DOMNodeStyles.prototype.addEmptyRule.inspectorStyleSheetAvailable):
2606         (WebInspector.DOMNodeStyles.prototype.addEmptyRule):
2607         Currently add all new rules to the inspector stylesheet.
2608
2609 2015-08-28  Joseph Pecoraro  <pecoraro@apple.com>
2610
2611         Web Inspector: Type Profiler does not understand Functions within Default Argument Expressions
2612         https://bugs.webkit.org/show_bug.cgi?id=148557
2613
2614         Reviewed by Timothy Hatcher.
2615
2616         * UserInterface/Models/ScriptSyntaxTree.js:
2617         (WebInspector.ScriptSyntaxTree.prototype._recurse):
2618         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2619         (WebInspector.ScriptSyntaxTree):
2620         Add support for abstracting and recursing through the default parameter
2621         expressions Esprima has on function expressions and declarations.
2622
2623 2015-08-28  Joseph Pecoraro  <pecoraro@apple.com>
2624
2625         Web Inspector: Type Profiler does not understand Functions inside Template Strings (ScriptSyntaxTree warnings)
2626         https://bugs.webkit.org/show_bug.cgi?id=148556
2627
2628         Reviewed by Timothy Hatcher.
2629
2630         * UserInterface/Models/ScriptSyntaxTree.js:
2631         (WebInspector.ScriptSyntaxTree.prototype._recurse):
2632         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2633         (WebInspector.ScriptSyntaxTree):
2634         Add support for abstracting and recursing through the Esprima template nodes.
2635
2636 2015-08-27  Joseph Pecoraro  <pecoraro@apple.com>
2637
2638         Web Inspector: Standardize on CSSStyleSheet.Type enum and move more protocol enum conversion to the manager
2639         https://bugs.webkit.org/show_bug.cgi?id=148515
2640
2641         Reviewed by Brian Burg.
2642
2643         * UserInterface/Controllers/CSSStyleManager.js:
2644         (WebInspector.CSSStyleManager.protocolStyleSheetOriginToEnum):
2645         (WebInspector.CSSStyleManager.protocolMediaSourceToEnum):
2646         Protocol enum to frontend enum conversion.
2647
2648         * UserInterface/Models/DOMNodeStyles.js:
2649         (WebInspector.DOMNodeStyles.prototype.refresh.fetchedComputedStyle):
2650         (WebInspector.DOMNodeStyles.prototype.refresh):
2651         (WebInspector.DOMNodeStyles.prototype._parseRulePayload):
2652         (WebInspector.DOMNodeStyles.prototype._collectStylesInCascadeOrder):
2653         Use the manager to convert from a protocol payload enum to frontend num for css types.
2654
2655         * UserInterface/Models/CSSRule.js:
2656         (WebInspector.CSSRule.prototype.get editable):
2657         * UserInterface/Views/CSSStyleDeclarationSection.js:
2658         (WebInspector.CSSStyleDeclarationSection):
2659         (WebInspector.CSSStyleDeclarationSection.prototype.refresh):
2660         * UserInterface/Views/RulesStyleDetailsPanel.js:
2661         (WebInspector.RulesStyleDetailsPanel.prototype.refresh.appendStyleSection):
2662         (WebInspector.RulesStyleDetailsPanel.prototype.refresh):
2663         * UserInterface/Views/VisualStyleSelectorSection.js:
2664         (WebInspector.VisualStyleSelectorSection.prototype.update.createSelectorItem):
2665         (WebInspector.VisualStyleSelectorSection.prototype.update.uniqueOrderedRules.set return):
2666         (WebInspector.VisualStyleSelectorSection.prototype.update.uniqueOrderedRules):
2667         (WebInspector.VisualStyleSelectorSection.prototype.update):
2668         * UserInterface/Views/VisualStyleSelectorTreeItem.js:
2669         (WebInspector.VisualStyleSelectorTreeItem):
2670         Update enum use.
2671
2672 2015-08-26  Nikita Vasilyev  <nvasilyev@apple.com>
2673
2674         Web Inspector: [Regression] [Mavericks]: Undocked Web Inspector toolbar is two different colors and has extra space
2675         https://bugs.webkit.org/show_bug.cgi?id=148510
2676
2677         Make body element transparent and remove extra padding above the toolbar only for OS X Mavericks.
2678
2679         Reviewed by Timothy Hatcher.
2680
2681         * UserInterface/Base/Main.js:
2682         (WebInspector.contentLoaded):
2683         * UserInterface/Views/Main.css:
2684         (body:not(.mavericks)):
2685         (body): Deleted.
2686         * UserInterface/Views/Toolbar.css:
2687         (body:not(.mavericks) .toolbar):
2688         (body.window-inactive:not(.mavericks) .toolbar):
2689         (body.mac-platform:not(.docked, .mavericks) .toolbar):
2690         (.toolbar): Deleted.
2691         (body.window-inactive .toolbar): Deleted.
2692         (body.mac-platform:not(.docked) .toolbar): Deleted.
2693
2694 2015-08-26  Joseph Pecoraro  <pecoraro@apple.com>
2695
2696         Web Inspector: Uncaught exception in CSS Completion - TypeError: undefined is not an object (evaluating 'this._values[middleIndex].startsWith')
2697         https://bugs.webkit.org/show_bug.cgi?id=148508
2698
2699         Reviewed by Timothy Hatcher.
2700
2701         * UserInterface/Models/CSSCompletions.js:
2702         (WebInspector.CSSCompletions):
2703         Add a comment explaining that the constructor may be called with
2704         a list of strings or a list of objects from the protocol. Add
2705         a fast path for when this is constructed with a list of strings.
2706
2707 2015-08-26  Matt Baker  <mattbaker@apple.com>
2708
2709         Web Inspector: Rendering Frames timeline pie chart should use SVG instead of 2D canvas
2710         https://bugs.webkit.org/show_bug.cgi?id=148457
2711
2712         Reviewed by Timothy Hatcher.
2713
2714         * UserInterface/Views/ChartDetailsSectionRow.css:
2715         (.details-section > .content > .group > .row.chart > .chart-content > svg > path.hidden):
2716         (.details-section > .content > .group > .row.chart > .chart-content > svg > path.chart-segment):
2717         (.details-section > .content > .group > .row.chart > .chart-content > svg > path.empty-chart):
2718         New styles for SVG chart elements.
2719
2720         * UserInterface/Views/ChartDetailsSectionRow.js:
2721         (WebInspector.ChartDetailsSectionRow):
2722         Calculate radii and create SVG chart elements.
2723         (WebInspector.ChartDetailsSectionRow.prototype.clearItems):
2724         Remove chart segment path elements.
2725         (WebInspector.ChartDetailsSectionRow.prototype._needsLayout):
2726         (WebInspector.ChartDetailsSectionRow.prototype._updateLayout.createSegmentPathData):
2727         Helper function that creates path data for a single pie chart segment.
2728         (WebInspector.ChartDetailsSectionRow.prototype._updateLayout):
2729         Creates path elements as needed, and updates path data for for non-zero data points.
2730         (WebInspector.ChartDetailsSectionRow.prototype.set innerLabel): Deleted.
2731         (WebInspector.ChartDetailsSectionRow.prototype.set innerRadius): Deleted.
2732         These properties are now set during construction.
2733         (WebInspector.ChartDetailsSectionRow.prototype.updateLayout): Deleted.
2734         Renamed to _updateLayout.
2735
2736         * UserInterface/Views/TimelineSidebarPanel.js:
2737         Chart size and inner radius passed to chart constructor.
2738
2739 2015-08-26  Joseph Pecoraro  <pecoraro@apple.com>
2740
2741         Web Inspector: Implement tracking of active stylesheets in the frontend
2742         https://bugs.webkit.org/show_bug.cgi?id=105828
2743
2744         Reviewed by Timothy Hatcher.
2745
2746         * UserInterface/Models/CSSStyleSheet.js:
2747         (WebInspector.CSSStyleSheet):
2748         (WebInspector.CSSStyleSheet.prototype.get origin):
2749         (WebInspector.CSSStyleSheet.prototype.updateInfo):
2750         Add a new origin attribute that has been sent from the backend for a while.
2751
2752         * UserInterface/Controllers/CSSStyleManager.js:
2753         (WebInspector.CSSStyleManager.prototype.styleSheetAdded):
2754         (WebInspector.CSSStyleManager.prototype.styleSheetRemoved):
2755         Handle the new events by managing the new CSSStyleSheets.
2756         
2757         (WebInspector.CSSStyleManager):
2758         (WebInspector.CSSStyleManager.prototype._mainResourceDidChange):
2759         Reset the legacy fetching flag. Fetching is only needed for legacy backends.
2760
2761         (WebInspector.CSSStyleManager.prototype._fetchInfoForAllStyleSheets):
2762         Include the new origin property in the legacy updateInfo path.
2763
2764         * UserInterface/Protocol/CSSObserver.js:
2765         (WebInspector.CSSObserver.prototype.styleSheetAdded):
2766         (WebInspector.CSSObserver.prototype.styleSheetRemoved):
2767         Forward to the manager.
2768
2769         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
2770         (WebInspector.CSSStyleDetailsSidebarPanel):
2771         Refresh the sidebar when stylesheets are added / removed, as that
2772         may affect the style of the select element.
2773
2774 2015-08-26  Joseph Pecoraro  <pecoraro@apple.com>
2775
2776         Web Inspector: Drop iOS 6 Legacy Remote Inspector Support
2777         https://bugs.webkit.org/show_bug.cgi?id=148456
2778
2779         Reviewed by Timothy Hatcher.
2780
2781         * UserInterface/Base/Main.js:
2782         (WebInspector.loaded):
2783         (WebInspector._updateReloadToolbarButton):
2784         (WebInspector._updateDownloadToolbarButton):
2785         (WebInspector.canArchiveMainFrame):
2786         * UserInterface/Controllers/CSSStyleManager.js:
2787         (WebInspector.CSSStyleManager.prototype._frameURLMapKey):
2788         (WebInspector.CSSStyleManager.prototype._lookupStyleSheet.styleSheetsFetched):
2789         (WebInspector.CSSStyleManager._updateResourceContent.fetchedStyleSheetContent):
2790         (WebInspector.CSSStyleManager.prototype._clearStyleSheetsForResource): Deleted.
2791         * UserInterface/Controllers/DOMTreeManager.js:
2792         (WebInspector.DOMTreeManager.prototype.highlightSelector):
2793         * UserInterface/Controllers/DebuggerManager.js:
2794         (WebInspector.DebuggerManager.prototype._setBreakpoint):
2795         * UserInterface/Controllers/JavaScriptLogViewController.js:
2796         * UserInterface/Controllers/RuntimeManager.js:
2797         (WebInspector.RuntimeManager):
2798         (WebInspector.RuntimeManager.prototype.evaluateInInspectedWindow):
2799         * UserInterface/Controllers/SourceMapManager.js:
2800         (WebInspector.SourceMapManager.prototype._loadAndParseSourceMap):
2801         * UserInterface/Controllers/StorageManager.js:
2802         (WebInspector.StorageManager):
2803         (WebInspector.StorageManager.prototype._addDOMStorageIfNeeded):
2804         (WebInspector.StorageManager.prototype.domStorageWasUpdated): Deleted.
2805         (WebInspector.StorageManager.prototype._domStorageForIdentifier): Deleted.
2806         (WebInspector.StorageManager.prototype._extraDomainsActivated): Deleted.
2807         * UserInterface/Controllers/TimelineManager.js:
2808         (WebInspector.TimelineManager.prototype._processRecord):
2809         * UserInterface/Models/Breakpoint.js:
2810         (WebInspector.Breakpoint.prototype._editBreakpointPopoverContentElement):
2811         * UserInterface/Models/CSSCompletions.js:
2812         (WebInspector.CSSCompletions):
2813         (WebInspector.CSSCompletions.requestCSSCompletions):
2814         * UserInterface/Models/CSSKeywordCompletions.js:
2815         (WebInspector.CSSKeywordCompletions.addCustomCompletions): Deleted.
2816         * UserInterface/Models/CSSProperty.js:
2817         (WebInspector.CSSProperty):
2818         (WebInspector.CSSProperty.prototype.update):
2819         * UserInterface/Models/CSSRule.js:
2820         (WebInspector.CSSRule.prototype.get matchedSelectors): Deleted.
2821         (WebInspector.CSSRule.prototype.get matchedSelectorText): Deleted.
2822         * UserInterface/Models/DOMNodeStyles.js:
2823         (WebInspector.DOMNodeStyles.prototype.refresh.parseRuleMatchArrayPayload):
2824         (WebInspector.DOMNodeStyles.prototype.refresh.fetchedMatchedStyles):
2825         (WebInspector.DOMNodeStyles.prototype.changeRule.changeText):
2826         (WebInspector.DOMNodeStyles.prototype.changeStyleText):
2827         (WebInspector.DOMNodeStyles.prototype._parseStylePropertyPayload):
2828         (WebInspector.DOMNodeStyles.prototype._parseRulePayload):
2829         (WebInspector.DOMNodeStyles.prototype.changeStyleText.attributeChanged): Deleted.
2830         (WebInspector.DOMNodeStyles.prototype.changeStyleText.fetchedStyleSheetContent.contentDidChange): Deleted.
2831         (WebInspector.DOMNodeStyles.prototype.changeStyleText.fetchedStyleSheetContent): Deleted.
2832         (WebInspector.DOMNodeStyles.prototype._parseSourceRangePayload): Deleted.
2833         (WebInspector.DOMNodeStyles.prototype._parseSelectorListPayload): Deleted.
2834         * UserInterface/Models/DOMStorageObject.js:
2835         * UserInterface/Models/DOMTree.js:
2836         (WebInspector.DOMTree.prototype.requestRootDOMNode):
2837         (WebInspector.DOMTree.prototype._requestRootDOMNode):
2838         * UserInterface/Models/DatabaseObject.js:
2839         (WebInspector.DatabaseObject.prototype.executeSQL.queryCallback):
2840         (WebInspector.DatabaseObject.prototype.executeSQL):
2841         (WebInspector.DatabaseObject):
2842         (WebInspector.DatabaseObject.prototype.executeSQL.callback): Deleted.
2843         * UserInterface/Models/ExecutionContext.js:
2844         (WebInspector.ExecutionContext.supported): Deleted.
2845         * UserInterface/Models/IssueMessage.js:
2846         (WebInspector.IssueMessage): Deleted.
2847         * UserInterface/Models/LayoutTimelineRecord.js:
2848         (WebInspector.LayoutTimelineRecord):
2849         (WebInspector.LayoutTimelineRecord.prototype.get width):
2850         (WebInspector.LayoutTimelineRecord.prototype.get height):
2851         (WebInspector.LayoutTimelineRecord.prototype.get area):
2852         (WebInspector.LayoutTimelineRecord.prototype.get x): Deleted.
2853         (WebInspector.LayoutTimelineRecord.prototype.get y): Deleted.
2854         (WebInspector.LayoutTimelineRecord.prototype.get rect): Deleted.
2855         * UserInterface/Models/ProfileNode.js:
2856         * UserInterface/Models/Resource.js:
2857         (WebInspector.Resource.prototype.associateWithScript):
2858         * UserInterface/Models/ScriptTimelineRecord.js:
2859         (WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload.profileNodeFromPayload):
2860         * UserInterface/Models/SourceMapResource.js:
2861         (WebInspector.SourceMapResource.prototype.requestContentFromBackend):
2862         * UserInterface/Models/TextRange.js:
2863         (WebInspector.TextRange.prototype.resolveLinesAndColumns.countNewLineCharacters): Deleted.
2864         (WebInspector.TextRange.prototype.resolveLinesAndColumns): Deleted.
2865         * UserInterface/Models/TimelineRecording.js:
2866         * UserInterface/Protocol/ConsoleObserver.js:
2867         (WebInspector.ConsoleObserver.prototype.messageAdded): Deleted.
2868         * UserInterface/Protocol/DOMStorageObserver.js:
2869         (WebInspector.DOMStorageObserver.prototype.addDOMStorage): Deleted.
2870         (WebInspector.DOMStorageObserver.prototype.updateDOMStorage): Deleted.
2871         * UserInterface/Protocol/DatabaseObserver.js:
2872         (WebInspector.DatabaseObserver.prototype.sqlTransactionSucceeded): Deleted.
2873         (WebInspector.DatabaseObserver.prototype.sqlTransactionFailed): Deleted.
2874         (WebInspector.DatabaseObserver): Deleted.
2875         * UserInterface/Protocol/Legacy/6.0/InspectorBackendCommands.js: Removed.
2876         * UserInterface/Views/CookieStorageContentView.js:
2877         (WebInspector.CookieStorageContentView.prototype._deleteCallback):
2878         (WebInspector.CookieStorageContentView):
2879         * UserInterface/Views/DOMTreeContentView.js:
2880         (WebInspector.DOMTreeContentView.prototype._updateCompositingBordersButtonToMatchPageSettings): Deleted.
2881         * UserInterface/Views/EventListenerSectionGroup.js:
2882         (WebInspector.EventListenerSectionGroup.prototype._functionTextOrLink):
2883         (WebInspector.EventListenerSectionGroup):
2884         * UserInterface/Views/LayoutTimelineView.js:
2885         (WebInspector.LayoutTimelineView.prototype._showHighlightForRecord):
2886         * UserInterface/Views/QuickConsole.js:
2887         (WebInspector.QuickConsole):
2888         (WebInspector.QuickConsole.prototype._createExecutionContextPathComponentFromFrame):
2889         (WebInspector.QuickConsole.prototype._frameAdded): Deleted.
2890         (WebInspector.QuickConsole.prototype._frameRemoved): Deleted.
2891         (WebInspector.QuickConsole.prototype._frameMainResourceChanged): Deleted.
2892         * UserInterface/Views/ScriptTimelineDataGridNode.js:
2893         (WebInspector.ScriptTimelineDataGridNode.prototype.get data):
2894         * UserInterface/Views/SourceCodeTextEditor.js:
2895         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenAnnotator):
2896         (WebInspector.SourceCodeTextEditor.prototype._makeBasicBlockAnnotator):
2897         * Versions/Inspector-iOS-6.0.json: Removed.
2898         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
2899         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
2900
2901 2015-08-26  Nikita Vasilyev  <nvasilyev@apple.com>
2902
2903         Web Inspector: Command-Enter should evaluate selected JS in Debugger/Sources
2904         https://bugs.webkit.org/show_bug.cgi?id=148368
2905
2906         Reviewed by Timothy Hatcher.
2907
2908         * UserInterface/Controllers/CodeMirrorCompletionController.js:
2909         (WebInspector.CodeMirrorCompletionController):
2910         (WebInspector.CodeMirrorCompletionController.prototype._generateJavaScriptCompletions):
2911         Evaluate selected text in the console only for JS and HTML resources. HTML resources
2912         should be allowed because they can have commented out (inside <!-- -->) and
2913         inline (onclick="") JavaScript.
2914
2915 2015-08-25  Brian Burg  <bburg@apple.com>
2916
2917         Web Inspector: no need to allocate protocolErrors array for every dispatched backend command
2918         https://bugs.webkit.org/show_bug.cgi?id=146466
2919
2920         Reviewed by Joseph Pecoraro.
2921
2922         * UserInterface/TestStub.html: Fix a typo, this property exists on ProtocolTest.
2923
2924 2015-08-26  Matt Baker  <mattbaker@apple.com>
2925
2926         Web Inspector: Rendering Frames legend item checkbox colors are too light
2927         https://bugs.webkit.org/show_bug.cgi?id=148465
2928
2929         Reviewed by Timothy Hatcher.
2930
2931         * UserInterface/Views/ChartDetailsSectionRow.js:
2932         (WebInspector.ChartDetailsSectionRow.prototype._addCheckboxColorFilter):
2933         Gamma primitive should use an "exponent" attribute instead of "value".
2934         Increased gamma exponent to 1.4.
2935
2936 2015-08-26  Nikita Vasilyev  <nvasilyev@apple.com>
2937
2938         Web Inspector: Make DOM node attribute changes highlighting less obnoxious
2939         https://bugs.webkit.org/show_bug.cgi?id=148050
2940
2941         Reviewed by Timothy Hatcher.
2942
2943         * UserInterface/Views/DOMTreeOutline.css:
2944         (@keyframes node-state-changed): Change color to a light green.
2945         (.node-state-changed): Add a slight ease-in for the animation function.
2946
2947 2015-08-26  Joseph Pecoraro  <pecoraro@apple.com>
2948
2949         Web Inspector: Add Refresh button to Cookie Content View
2950         https://bugs.webkit.org/show_bug.cgi?id=148468
2951
2952         Reviewed by Timothy Hatcher.
2953
2954         * UserInterface/Views/CookieStorageContentView.js:
2955         (WebInspector.CookieStorageContentView):
2956         (WebInspector.CookieStorageContentView.prototype.get navigationItems):
2957         (WebInspector.CookieStorageContentView.prototype._refreshButtonClicked):
2958
2959 2015-08-25  Brian Burg  <bburg@apple.com>
2960
2961         Web Inspector: message dispatch metrics should use high-resolution timing data
2962         https://bugs.webkit.org/show_bug.cgi?id=135467
2963
2964         Reviewed by Timothy Hatcher.
2965
2966         Use performance.now if it's available, otherwise fallback to Date.now().
2967         Format timestamps with fixed decimal point, and sprinkle some ES6.
2968
2969         * UserInterface/Base/Utilities.js:
2970         (timestamp): Added.
2971         * UserInterface/Protocol/InspectorBackend.js:
2972         (InspectorBackendClass):
2973         (InspectorBackendClass.prototype._sendCommandToBackendWithCallback):
2974         (InspectorBackendClass.prototype._dispatchEvent):
2975         * UserInterface/Protocol/MessageDispatcher.js:
2976         (WebInspector.dispatchNextQueuedMessageFromBackend):
2977         (WebInspector.dispatchMessageFromBackend): Be consistent about using `this`.
2978
2979 2015-08-25  Matt Baker  <mattbaker@apple.com>
2980
2981         Web Inspector: Rendering Frames pie chart should use the needsLayout/updateLayout idiom
2982         https://bugs.webkit.org/show_bug.cgi?id=148412
2983
2984         Reviewed by Timothy Hatcher.
2985
2986         * UserInterface/Views/ChartDetailsSectionRow.js:
2987         (WebInspector.ChartDetailsSectionRow):
2988         (WebInspector.ChartDetailsSectionRow.prototype.set innerLabel):
2989         (WebInspector.ChartDetailsSectionRow.prototype.set innerRadius):
2990         Schedule a layout.
2991         (WebInspector.ChartDetailsSectionRow.prototype.set data): Deleted.
2992         Replaced by addItem, setItemValue, and clearItems.
2993         (WebInspector.ChartDetailsSectionRow.prototype.addItem):
2994         (WebInspector.ChartDetailsSectionRow.prototype.setItemValue):
2995         (WebInspector.ChartDetailsSectionRow.prototype.clearItems):
2996         Add/update data points and schedule a layout.
2997         (WebInspector.ChartDetailsSectionRow.prototype._needsLayout):
2998         (WebInspector.ChartDetailsSectionRow.prototype.updateLayout):
2999         Update legend and draw pie chart.
3000         (WebInspector.ChartDetailsSectionRow.prototype._createLegend): Deleted.
3001         Refactored as _updateLegend.
3002         (WebInspector.ChartDetailsSectionRow.prototype._refresh): Deleted.
3003         Refactored as updateLayout.
3004
3005         * UserInterface/Views/TimelineSidebarPanel.js:
3006         (WebInspector.TimelineSidebarPanel):
3007         Add chart data points once.
3008         (WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart):
3009         Update chart values.
3010
3011 2015-08-24  Brian Burg  <bburg@apple.com>
3012
3013         Web Inspector: add protocol test for existing error handling performed by the backend
3014         https://bugs.webkit.org/show_bug.cgi?id=147097
3015
3016         Reviewed by Joseph Pecoraro.
3017
3018         Add a way to send raw messages to the backend while still awaiting on responses.
3019         This is necessary to test protocol error handling in the inspector backend.
3020
3021         * UserInterface/Test/InspectorProtocol.js:
3022         (InspectorProtocol.sendCommand):
3023         (InspectorProtocol.awaitCommand): Use awaitMessage internally.
3024         (InspectorProtocol.awaitMessage): Added. Use a dummy requestId if none is supplied.
3025         (InspectorProtocol._sendMessage): Added.
3026         (InspectorProtocol.dispatchMessageFromBackend):
3027         Reject with the error object instead of the error message, so error code/data can be checked.
3028         (InspectorProtocol.sendMessage): Deleted, it is now a private method.
3029
3030 2015-08-24  Timothy Hatcher  <timothy@apple.com>
3031
3032         Web Inspector: Change webkitAnimationEnd use, should be animationEnd
3033         https://bugs.webkit.org/show_bug.cgi?id=148385
3034
3035         Reviewed by Joseph Pecoraro.
3036
3037         * UserInterface/Views/DOMTreeElement.js:
3038         (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight):
3039         * UserInterface/Views/DashboardContainerView.js:
3040         (WebInspector.DashboardContainerView.prototype._showDashboardView.animationEnded):
3041         (WebInspector.DashboardContainerView.prototype._showDashboardView):
3042         (WebInspector.DashboardContainerView.prototype._hideDashboardView.animationEnded):
3043         (WebInspector.DashboardContainerView.prototype._hideDashboardView):
3044         * UserInterface/Views/DefaultDashboardView.js:
3045         (WebInspector.DefaultDashboardView.prototype._setConsoleItemValue.animationEnded):
3046         (WebInspector.DefaultDashboardView.prototype._setConsoleItemValue):
3047         * UserInterface/Views/TextEditor.js:
3048         (WebInspector.TextEditor.prototype.revealPosition.revealAndHighlightLine):
3049         (WebInspector.TextEditor.prototype.revealPosition):
3050         (WebInspector.TextEditor.prototype._revealSearchResult):
3051
3052 2015-08-24  Nikita Vasilyev  <nvasilyev@apple.com>
3053
3054         REGRESSION (r188581): Web Inspector: Console user command isn't visible when it's expected to be
3055         https://bugs.webkit.org/show_bug.cgi?id=148283
3056
3057         One of the improvements of r188581 "Option-Enter should commit console command
3058         without erasing the prompt" was not to show a console user command if it's the
3059         same as the previous one.
3060
3061         However, there could be a lot of other messages between the last two user
3062         commands - console.log, CSS warnings, etc. In that case we should show a console
3063         user command again by resetting _lastCommitted.
3064
3065         Reviewed by Timothy Hatcher.
3066
3067         * UserInterface/Controllers/JavaScriptLogViewController.js:
3068         (WebInspector.JavaScriptLogViewController):
3069         (WebInspector.JavaScriptLogViewController.prototype.startNewSession):
3070         (WebInspector.JavaScriptLogViewController.prototype._appendConsoleMessageView):
3071         Reset _lastCommitted for all messages except for user commands and use command results.
3072
3073 2015-08-24  Matt Baker  <mattbaker@apple.com>
3074
3075         Web Inspector: Rendering Frames filter checkboxes all become checked during recording
3076         https://bugs.webkit.org/show_bug.cgi?id=148375
3077
3078         Reviewed by Timothy Hatcher.
3079
3080         * UserInterface/Views/ChartDetailsSectionRow.js:
3081         (WebInspector.ChartDetailsSectionRow.prototype._createLegend):
3082         Removed incorrect code that forced checked to true.
3083
3084         * UserInterface/Views/TimelineSidebarPanel.js:
3085         (WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart):
3086         Persist legend item checkbox state when updating the chart.
3087
3088 2015-08-23  Matt Baker  <mattbaker@apple.com>
3089
3090         Web Inspector: Filtered style not applied to graph elements during timeline recording
3091         https://bugs.webkit.org/show_bug.cgi?id=148339
3092
3093         Reviewed by Brian Burg.
3094
3095         * UserInterface/Views/NavigationSidebarPanel.js:
3096         (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
3097         Check for hidden state change when applying filters to newly added tree elements.
3098
3099 2015-08-23  Timothy Hatcher  <timothy@apple.com>
3100
3101         Web Inspector: Drop webkit prefixes from animation, keyframes and transform
3102         https://bugs.webkit.org/show_bug.cgi?id=148364
3103
3104         Reviewed by Darin Adler.
3105
3106         * UserInterface/Views/BreakpointTreeElement.css:
3107         (.breakpoint-generic-line-icon .icon > span):
3108         (.data-updated.breakpoint-generic-line-icon .icon > span):
3109         * UserInterface/Views/ColorPicker.css:
3110         (.color-picker > .slider):
3111         * UserInterface/Views/DashboardContainerView.css:
3112         (.toolbar .dashboard):
3113         (.toolbar .dashboard.slide-out-up):
3114         (.toolbar .dashboard.slide-out-down):
3115         (.toolbar .dashboard.slide-in-up):
3116         (.toolbar .dashboard.slide-in-down):
3117         (@keyframes slide-top-edge):
3118         (@keyframes slide-bottom-edge):
3119         (@-webkit-keyframes slide-top-edge): Deleted.
3120         (@-webkit-keyframes slide-bottom-edge): Deleted.
3121         * UserInterface/Views/DebuggerDashboardView.css:
3122         (.dashboard.debugger .navigation-bar .item.button > .glyph):
3123         (@keyframes pulse-pause-button):
3124         (@-webkit-keyframes pulse-pause-button): Deleted.
3125         * UserInterface/Views/DefaultDashboardView.css:
3126         (.toolbar .dashboard.default > .item.pulsing):
3127         (@keyframes console-item-pulse):
3128         (@-webkit-keyframes console-item-pulse): Deleted.
3129         * UserInterface/Views/GoToLineDialog.css:
3130         (.go-to-line-dialog):
3131         * UserInterface/Views/HoverMenu.css:
3132         (.hover-menu):
3133         * UserInterface/Views/IndeterminateProgressSpinner.css:
3134         (@keyframes discrete-spinner):
3135         (.indeterminate-progress-spinner):
3136         (@-webkit-keyframes discrete-spinner): Deleted.
3137         * UserInterface/Views/Main.css:
3138         (.bouncy-highlight):
3139         (@keyframes bouncy-highlight-animation):
3140         (@-webkit-keyframes bouncy-highlight-animation): Deleted.
3141         * UserInterface/Views/ProbeSetDataGrid.css:
3142         (.details-section.probe-set .data-grid tr.revealed.highlighted):
3143         (@keyframes blink-frame-highlight):
3144         (.details-section.probe-set .data-grid > tr.data-updated):
3145         (@keyframes blink-probe-frame):
3146         (@-webkit-keyframes blink-frame-highlight): Deleted.
3147         (@-webkit-keyframes blink-probe-frame): Deleted.
3148         * UserInterface/Views/TextEditor.css:
3149         (.text-editor > .CodeMirror .highlighted):
3150         (@keyframes text-editor-highlight-fadeout):
3151         (.text-editor > .CodeMirror .hovered-expression-highlight):
3152         (@keyframes text-editor-hovered-expression-highlight-fadeout):
3153         (@-webkit-keyframes text-editor-highlight-fadeout): Deleted.
3154         (@-webkit-keyframes text-editor-hovered-expression-highlight-fadeout): Deleted.
3155         * UserInterface/Views/TimelineOverview.css:
3156         (.timeline-overview.frames > .timeline-ruler > .markers > .divider):
3157         (.timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .selection-handle.right):
3158         (.timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .shaded-area.right):
3159         * UserInterface/Views/TimelineRuler.css:
3160         (.timeline-ruler > .header > .divider):
3161         (.timeline-ruler > .markers > .divider):
3162         (.timeline-ruler > .markers > .marker):
3163         (.timeline-ruler > .selection-handle.left):
3164         (.timeline-ruler > .selection-handle.right):
3165
3166 2015-08-21  Saam barati  <sbarati@apple.com>
3167
3168         Web Inspector: Type profiler shows 'Undefined' annotation for functions with no return statements
3169         https://bugs.webkit.org/show_bug.cgi?id=146882
3170
3171         Reviewed by Joseph Pecoraro.
3172
3173         * UserInterface/Controllers/TypeTokenAnnotator.js:
3174         (WebInspector.TypeTokenAnnotator.prototype._insertTypeToken):
3175         * UserInterface/Models/ScriptSyntaxTree.js:
3176         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
3177         (WebInspector.ScriptSyntaxTree):
3178
3179 2015-08-21  Joseph Pecoraro  <pecoraro@apple.com>
3180
3181         Web Inspector: WebInspector.domTreeManager.regionLayoutUpdated does not exist
3182         https://bugs.webkit.org/show_bug.cgi?id=148348
3183
3184         Reviewed by Timothy Hatcher.
3185
3186         * UserInterface/Protocol/CSSObserver.js:
3187         (WebInspector.CSSObserver.prototype.regionLayoutUpdated):
3188         Just do the same as the new event name.
3189
3190 2015-08-21  Brian Burg  <bburg@apple.com>
3191
3192         Web Inspector: clean up uses of `new` with zero-argument constructors and factory methods
3193         https://bugs.webkit.org/show_bug.cgi?id=148311
3194
3195         Reviewed by Timothy Hatcher.
3196
3197         * UserInterface/Protocol/InspectorFrontendHostStub.js:
3198         * UserInterface/Views/ClusterContentView.js:
3199         (WebInspector.ClusterContentView):
3200         * UserInterface/Views/ColorPicker.js:
3201         (WebInspector.ColorPicker):
3202         * UserInterface/Views/ContentView.js:
3203         (WebInspector.ContentView.createFromRepresentedObject): This was causing a console assertion
3204         when a breakpoint tree element was selected and the inspector tried to restore the view state
3205         after a reload or back/forward navigation.
3206
3207         * UserInterface/Views/NavigationSidebarPanel.js:
3208         (WebInspector.NavigationSidebarPanel):
3209         * UserInterface/Views/TimelineRecordingContentView.js:
3210         (WebInspector.TimelineRecordingContentView):
3211
3212 2015-08-20  Brian Burg  <bburg@apple.com>
3213
3214         Web Inspector: add a regression test for the fix introduced in r188679
3215         https://bugs.webkit.org/show_bug.cgi?id=148223
3216
3217         Reviewed by Joseph Pecoraro.
3218
3219         Turns out that we were possibly leaking a single DOMTree on reload.
3220         Always clear the main frame's DOMTree as well as those of sub-frames.
3221
3222         * UserInterface/Base/Object.js: Add back single-fire listeners.
3223         (WebInspector.Object.singleFireEventListener.let.wrappedCallback):
3224         (WebInspector.Object.singleFireEventListener):
3225         (WebInspector.Object.retainedObjectsWithPrototype):
3226         (WebInspector.Object.prototype.singleFireEventListener):
3227         (WebInspector.Object.prototype.retainedObjectsWithPrototype):
3228         * UserInterface/Models/Frame.js:
3229         (WebInspector.Frame.prototype.removeAllChildFrames): Clear own tree too.
3230
3231 2015-08-20  Joseph Pecoraro  <pecoraro@apple.com>
3232
3233         Web Inspector: Better Remember open tab types and order if using JSContext inspector
3234         https://bugs.webkit.org/show_bug.cgi?id=148285
3235
3236         Reviewed by Timothy Hatcher.
3237
3238         * UserInterface/Base/Main.js:
3239         (WebInspector.contentLoaded):
3240         (WebInspector.activateExtraDomains):
3241         Save and restore extra domain related tabs at the expected saved index.
3242
3243         (WebInspector._rememberOpenTabs):
3244         Keep unsupported tab types in the setting so when they are supported they open.
3245
3246         * UserInterface/Base/Utilities.js:
3247         Add a helper for inserting a single object into an array.
3248
3249 2015-08-20  Nikita Vasilyev  <nvasilyev@apple.com>
3250
3251         Web Inspector: inline errors/warnings are taller than the line height
3252         https://bugs.webkit.org/show_bug.cgi?id=148232
3253
3254         Reviewed by Timothy Hatcher.
3255
3256         * UserInterface/Views/SourceCodeTextEditor.css:
3257         (.source-code.text-editor > .CodeMirror .issue-widget.inline):
3258         (.source-code.text-editor > .CodeMirror .issue-widget.inline > .text):
3259
3260 2015-08-20  Joseph Pecoraro  <pecoraro@apple.com>
3261
3262         JSContext Inspector: Uncaught Exception opening Search Tab
3263         https://bugs.webkit.org/show_bug.cgi?id=148284
3264
3265         Reviewed by Timothy Hatcher.
3266
3267         * UserInterface/Views/SearchSidebarPanel.js:
3268         (WebInspector.SearchSidebarPanel):
3269         This is copied / pasted code that shouldn't apply to the Search tab.
3270         We want to show results under Resources in the Search tab.
3271
3272 2015-08-20  Nikita Vasilyev  <nvasilyev@apple.com>
3273
3274         Web Inspector: Truncate data URIs
3275         https://bugs.webkit.org/show_bug.cgi?id=148212
3276
3277         Reviewed by Timothy Hatcher.
3278
3279         * UserInterface/Base/URLUtilities.js:
3280         (parseURL):
3281         Exit early to avoid an expensive RegExp match on a potentially very large data URI.
3282
3283         (parseQueryString):
3284         Fix typo.
3285
3286         (WebInspector.displayNameForURL):
3287         (WebInspector.truncateURL):
3288         By default, only show first and last 3 characters of data URIs.
3289
3290         * UserInterface/Models/Resource.js:
3291         (WebInspector.Resource.prototype.get displayURL):
3292         For tooltips, show first and last 32 characters of data URIs.
3293
3294         * UserInterface/Models/SourceCodeLocation.js:
3295         (WebInspector.SourceCodeLocation.prototype._locationString):
3296         * UserInterface/Views/ResourceTreeElement.js:
3297         (WebInspector.ResourceTreeElement.prototype._updateToolTip):
3298
3299 2015-08-20  Devin Rousso  <drousso@apple.com>
3300
3301         Web Inspector: Add flex alignment section to Visual sidebar
3302         https://bugs.webkit.org/show_bug.cgi?id=148243
3303
3304         Reviewed by Timothy Hatcher.
3305
3306         Uses select keyword pickers to contain the list of possible values.  Also supports
3307         the upcoming Grid layout keywords in the advanced keyword list.
3308
3309         * Localizations/en.lproj/localizedStrings.js:
3310         * UserInterface/Views/VisualStyleDetailsPanel.js:
3311         (WebInspector.VisualStyleDetailsPanel):
3312         (WebInspector.VisualStyleDetailsPanel.prototype._populateFlexboxSection):
3313         (WebInspector.VisualStyleDetailsPanel.prototype._populateAlignmentSection):
3314
3315 2015-08-20  Devin Rousso  <drousso@apple.com>
3316
3317         Web Inspector: Labels in the computed panel are shifted when a filter is applieds
3318         https://bugs.webkit.org/show_bug.cgi?id=148250
3319
3320         Reviewed by Timothy Hatcher.
3321
3322         Added to the selectors for filtering to ensure they only apply to the rules panel.
3323
3324         * UserInterface/Views/RulesStyleDetailsPanel.css:
3325         (.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label):
3326         (.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label:not(.filter-section-non-matching) ~ .label):
3327         (.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label.filter-matching-label):
3328         (.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label:not(.filter-section-non-matching) + .label.filter-matching-label:not(.filter-section-non-matching)):
3329         (.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .new-rule):
3330         (.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .style-declaration-section:not(.filter-section-non-matching) ~ .label:not(.filter-section-non-matching)):
3331         (@media (-webkit-min-device-pixel-ratio: 2)):
3332         (.sidebar > .panel.details.css-style > .content.filter-in-progress .label): Deleted.
3333         (.sidebar > .panel.details.css-style > .content.filter-in-progress .label:not(.filter-section-non-matching) ~ .label): Deleted.
3334         (.sidebar > .panel.details.css-style > .content.filter-in-progress .label.filter-matching-label): Deleted.
3335         (.sidebar > .panel.details.css-style > .content.filter-in-progress .label:not(.filter-section-non-matching) + .label.filter-matching-label:not(.filter-section-non-matching)): Deleted.
3336         (.sidebar > .panel.details.css-style > .content.filter-in-progress .new-rule): Deleted.
3337         (.sidebar > .panel.details.css-style > .content.filter-in-progress .style-declaration-section:not(.filter-section-non-matching) ~ .label:not(.filter-section-non-matching)): Deleted.
3338
3339 2015-08-20  Devin Rousso  <drousso@apple.com>
3340
3341         Web Inspector: Fix "attempted to assign to readonly property" in Visual editor links
3342         https://bugs.webkit.org/show_bug.cgi?id=148264
3343
3344         Reviewed by Timothy Hatcher.
3345
3346         * UserInterface/Views/VisualStylePropertyEditorLink.js:
3347         (WebInspector.VisualStylePropertyEditorLink.prototype.set linked):
3348         No longer attempts to set the "hidden" attribute of the link icons before they exist.
3349
3350 2015-08-20  Devin Rousso  <drousso@apple.com>
3351
3352         Web Inspector: Visual editor adds extra spaces to styles with no properties
3353         https://bugs.webkit.org/show_bug.cgi?id=148242
3354
3355         Reviewed by Timothy Hatcher.