Web Inspector: Add infrastructure for eslint based static analyzer
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2014-11-10  Jonathan Wells  <jonowells@apple.com>
2
3         Web Inspector: Add infrastructure for eslint based static analyzer
4         https://bugs.webkit.org/show_bug.cgi?id=137890
5
6         Reviewed by Timothy Hatcher.
7
8         Fix to previous patch to add AnalyzerManager and AnalyzerMessage classes. Changed Main.html to include ESLint.js
9         before Main.js in the combined resources.
10
11         * UserInterface/Base/Main.js:
12         * UserInterface/Controllers/AnalyzerManager.js: Added.
13         (WebInspector.AnalyzerManager):
14         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode.):
15         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode):
16         (set WebInspector.AnalyzerManager.prototype.set get sourceCodeCanBeAnalyzed):
17         (set WebInspector.AnalyzerManager.prototype._handleSourceCodeContentDidChange):
18         * UserInterface/Main.html:
19         * UserInterface/Models/AnalyzerMessage.js: Added.
20         (WebInspector.AnalyzerMessage):
21         (WebInspector.AnalyzerMessage.prototype.get sourceCodeLocation):
22         (WebInspector.AnalyzerMessage.prototype.get sourceCode):
23         (WebInspector.AnalyzerMessage.prototype.get text):
24         (WebInspector.AnalyzerMessage.prototype.get ruleIdentifier):
25         * UserInterface/Models/SourceCode.js:
26
27 2014-11-08  Matt Baker  <mattbaker@apple.com>
28
29         Web Inspector: decouple child element folderization logic from FrameTreeElement
30         https://bugs.webkit.org/show_bug.cgi?id=138364
31
32         Reviewed by Timothy Hatcher.
33
34         Created FolderizedTreeElement base class, which FrameTreeElement now inherits via SourceCodeTreeElement.
35         FolderizedTreeElement uses settings provided by derived classes for labeling subfolders and to determine
36         folder membership for child items.
37
38         * UserInterface/Base/Main.js:
39         (WebInspector.canArchiveMainFrame):
40         * UserInterface/Main.html:
41         * UserInterface/Models/LayoutTimelineRecord.js:
42         (WebInspector.LayoutTimelineRecord.displayNameForEventType):
43         (WebInspector.LayoutTimelineRecord.EventType.displayName): Deleted.
44         * UserInterface/Models/Resource.js:
45         (WebInspector.Resource):
46         (WebInspector.Resource.typeFromMIMEType):
47         (WebInspector.Resource.displayNameForType):
48         (WebInspector.Resource.prototype.get syntheticMIMEType):
49         (WebInspector.Resource.prototype.updateForResponse):
50         (WebInspector.Resource.Type.fromMIMEType): Deleted.
51         (WebInspector.Resource.Type.displayName): Deleted.
52         * UserInterface/Models/SourceMapResource.js:
53         (WebInspector.SourceMapResource):
54         * UserInterface/Views/FolderizedTreeElement.js: Added.
55         (WebInspector.FolderizedTreeElement):
56         (WebInspector.FolderizedTreeElement.prototype.get groupedIntoFolders):
57         (WebInspector.FolderizedTreeElement.prototype.set folderSettingsKey):
58         (WebInspector.FolderizedTreeElement.prototype.registerFolderizeSettings):
59         (WebInspector.FolderizedTreeElement.prototype.set removeChildren):
60         (WebInspector.FolderizedTreeElement.prototype.addChildForRepresentedObject):
61         (WebInspector.FolderizedTreeElement.prototype.addRepresentedObjectToNewChildQueue):
62         (WebInspector.FolderizedTreeElement.prototype.removeChildForRepresentedObject):
63         (WebInspector.FolderizedTreeElement.prototype.compareChildTreeElements):
64         (WebInspector.FolderizedTreeElement.prototype.updateParentStatus):
65         (WebInspector.FolderizedTreeElement.prototype._clearNewChildQueue):
66         (WebInspector.FolderizedTreeElement.prototype._populateFromNewChildQueue):
67         (WebInspector.FolderizedTreeElement.prototype._removeRepresentedObjectFromNewChildQueue):
68         (WebInspector.FolderizedTreeElement.prototype._addTreeElement):
69         (WebInspector.FolderizedTreeElement.prototype._compareTreeElementsByMainTitle):
70         (WebInspector.FolderizedTreeElement.prototype._insertFolderTreeElement):
71         (WebInspector.FolderizedTreeElement.prototype._insertChildTreeElement):
72         (WebInspector.FolderizedTreeElement.prototype._removeTreeElement):
73         (WebInspector.FolderizedTreeElement.prototype._parentTreeElementForRepresentedObject):
74         (WebInspector.FolderizedTreeElement.prototype._folderTreeElementExpandedStateChange):
75         (WebInspector.FolderizedTreeElement.prototype._settingsForRepresentedObject):
76         (WebInspector.FolderizedTreeElement.prototype._shouldGroupIntoFolders.pushCategory):
77         (WebInspector.FolderizedTreeElement.prototype._shouldGroupIntoFolders):
78         * UserInterface/Views/FrameTreeElement.js:
79         (.this):
80         (WebInspector.FrameTreeElement.prototype.updateSourceMapResources):
81         (WebInspector.FrameTreeElement.prototype.onattach):
82         (WebInspector.FrameTreeElement.prototype.ondetach):
83         (WebInspector.FrameTreeElement.prototype.compareChildTreeElements):
84         (WebInspector.FrameTreeElement.prototype.onpopulate):
85         (WebInspector.FrameTreeElement.prototype._mainResourceDidChange):
86         (WebInspector.FrameTreeElement.prototype._resourceWasAdded):
87         (WebInspector.FrameTreeElement.prototype._resourceWasRemoved):
88         (WebInspector.FrameTreeElement.prototype._childFrameWasAdded):
89         (WebInspector.FrameTreeElement.prototype._childFrameWasRemoved):
90         (WebInspector.FrameTreeElement.prototype._childContentFlowWasAdded):
91         (WebInspector.FrameTreeElement.prototype._childContentFlowWasRemoved):
92         (WebInspector.FrameTreeElement.prototype._rootDOMNodeInvalidated):
93         (WebInspector.FrameTreeElement): Deleted.
94         (WebInspector.FrameTreeElement.prototype.removeChildren): Deleted.
95         (WebInspector.FrameTreeElement.prototype._updateParentStatus): Deleted.
96         (WebInspector.FrameTreeElement.prototype._addRepresentedObjectToNewChildQueue): Deleted.
97         (WebInspector.FrameTreeElement.prototype._removeRepresentedObjectFromNewChildQueue): Deleted.
98         (WebInspector.FrameTreeElement.prototype._populateFromNewChildQueue): Deleted.
99         (WebInspector.FrameTreeElement.prototype._clearNewChildQueue): Deleted.
100         (WebInspector.FrameTreeElement.prototype._addChildForRepresentedObject): Deleted.
101         (WebInspector.FrameTreeElement.prototype._removeChildForRepresentedObject): Deleted.
102         (WebInspector.FrameTreeElement.prototype._addTreeElementForRepresentedObject): Deleted.
103         (WebInspector.FrameTreeElement.prototype._addTreeElement): Deleted.
104         (WebInspector.FrameTreeElement.prototype._compareTreeElementsByMainTitle): Deleted.
105         (WebInspector.FrameTreeElement.prototype._insertFolderTreeElement): Deleted.
106         (WebInspector.FrameTreeElement.prototype._compareResourceTreeElements): Deleted.
107         (WebInspector.FrameTreeElement.prototype._insertResourceTreeElement): Deleted.
108         (WebInspector.FrameTreeElement.prototype._removeTreeElement): Deleted.
109         (WebInspector.FrameTreeElement.prototype._folderNameForResourceType): Deleted.
110         (WebInspector.FrameTreeElement.prototype._parentTreeElementForRepresentedObject.createFolderTreeElement): Deleted.
111         (WebInspector.FrameTreeElement.prototype._parentTreeElementForRepresentedObject): Deleted.
112         (WebInspector.FrameTreeElement.prototype._folderTreeElementExpandedStateChange): Deleted.
113         (WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders.pushResourceType): Deleted.
114         (WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders.pushCategory): Deleted.
115         (WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders): Deleted.
116         * UserInterface/Views/LayoutTimelineDataGridNode.js:
117         (WebInspector.LayoutTimelineDataGridNode.prototype.createCellContent):
118         * UserInterface/Views/LayoutTimelineView.js:
119         (WebInspector.LayoutTimelineView): Deleted.
120         * UserInterface/Views/NetworkTimelineView.js:
121         (WebInspector.NetworkTimelineView): Deleted.
122         * UserInterface/Views/ResourceDetailsSidebarPanel.js:
123         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshResourceType):
124         * UserInterface/Views/ResourceTimelineDataGridNode.js:
125         (WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent):
126         * UserInterface/Views/SourceCodeTreeElement.js:
127         (WebInspector.SourceCodeTreeElement):
128         * UserInterface/Views/TimelineDataGrid.js:
129         (WebInspector.TimelineDataGrid.createColumnScopeBar):
130         * UserInterface/Views/TimelineRecordTreeElement.js:
131         (WebInspector.TimelineRecordTreeElement):
132         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
133         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
134
135 2014-11-07  Joseph Pecoraro  <pecoraro@apple.com>
136
137         Web Inspector: Layer summary should be bottom sticky
138         https://bugs.webkit.org/show_bug.cgi?id=138518
139
140         Reviewed by Timothy Hatcher.
141
142         Previously only NavigationSidebars had a content view. Now, give all
143         Sidebars a contentElement section for content.
144
145         Update all Details Sidebars to append content to the contentElement
146         instead of directly to the element. Only two Details sidebars append
147         to the element:
148
149           - CSSStyleDetailsSidebarPanel for the navigation bar at the top
150           - LayerTreeDetailsSidebarPanel for the summary view at the bottom
151
152         Take this opportunity to fix up some naming and styles as well.
153
154         * UserInterface/Views/SidebarPanel.js:
155         (WebInspector.SidebarPanel):
156         (WebInspector.SidebarPanel.prototype.get contentElement):
157         Give every SidebarPanel a content element.
158
159         * UserInterface/Views/DetailsSidebarPanel.css: Removed.
160         (.sidebar > .panel > .content):
161         * UserInterface/Views/SidebarPanel.css: Added.
162         (.sidebar > .panel > .content):
163         And give that content element a default style.
164
165         * UserInterface/Views/NavigationSidebarPanel.css:
166         (.sidebar > .panel.navigation > .content):
167         * UserInterface/Views/NavigationSidebarPanel.js:
168         (WebInspector.NavigationSidebarPanel):
169         (WebInspector.NavigationSidebarPanel.prototype.createContentTreeOutline):
170         (WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
171         (WebInspector.NavigationSidebarPanel.prototype.get contentElement): Deleted.
172         Navigation sidebar panels now use the parent's contentElement.
173         Also, carry over their default styles, overriding the base.
174
175         * UserInterface/Views/LayerTreeDetailsSidebarPanel.js: Renamed from Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.js.
176         (WebInspector.LayerTreeDetailsSidebarPanel.prototype._buildLayerInfoSection):
177         (WebInspector.LayerTreeDetailsSidebarPanel.prototype._buildDataGridSection):
178         (WebInspector.LayerTreeDetailsSidebarPanel.prototype._buildBottomBar):
179         Rename LayerTreeSidebarPanel to make it clear this is a DetailsSidebarPanel.
180         Add the "bottom bar" to the root element, and sections to the contentElement.
181
182         * UserInterface/Views/LayerTreeDetailsSidebarPanel.css: Renamed from Source/WebInspectorUI/UserInterface/Views/LayerTreeSidebarPanel.css.
183         (.sidebar > .layer-tree.panel > .content):
184         (body.mac-platform.legacy .sidebar > .layer-tree.panel > .content):
185         Style the bottom bar to pin it to the bottom of the sidebar panel.
186
187         (WebInspector.CSSStyleDetailsSidebarPanel):
188         (WebInspector.CSSStyleDetailsSidebarPanel.prototype.refresh):
189         (WebInspector.CSSStyleDetailsSidebarPanel.prototype._navigationItemSelected):
190         Add the navigation bar to the root element, and sections to the contentElement.
191
192         * UserInterface/Base/Main.js:
193         (WebInspector.contentLoaded):
194         * UserInterface/Main.html:
195         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
196         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
197         Update for new names.
198
199         * UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
200         (WebInspector.ApplicationCacheDetailsSidebarPanel):
201         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
202         * UserInterface/Views/DOMDetailsSidebarPanel.js:
203         (WebInspector.DOMDetailsSidebarPanel):
204         * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
205         (WebInspector.DOMNodeDetailsSidebarPanel):
206         * UserInterface/Views/DetailsSidebarPanel.js:
207         (WebInspector.DetailsSidebarPanel):
208         * UserInterface/Views/ProbeDetailsSidebarPanel.js:
209         * UserInterface/Views/ResourceDetailsSidebarPanel.js:
210         (WebInspector.ResourceDetailsSidebarPanel):
211         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshURL):
212         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshImageSizeSection):
213         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRequestDataSection):
214         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
215         (WebInspector.ScopeChainDetailsSidebarPanel.prototype.refresh.delayedWork):
216         (WebInspector.ScopeChainDetailsSidebarPanel.prototype.refresh):
217         All details sidebar panels now use the contentElement instead of element for content.
218
219 2014-11-07  Timothy Hatcher  <timothy@apple.com>
220
221         Web Inspector: Cursor and scroll view jumps around when modifying styles
222         https://bugs.webkit.org/show_bug.cgi?id=137467
223
224         This merges commit e2962a5b0df56c8ee5a4482899d308decf3d7677 from CodeMirror.
225
226         Reviewed by Joseph Pecoraro.
227
228         * UserInterface/External/CodeMirror/codemirror.js:
229         (maybeScrollWindow): Signal the scrollCursorIntoView event.
230         (signalDOMEvent): Support string events by transforming them to event objects.
231
232         * UserInterface/Views/CodeMirrorAdditions.js:
233         (scrollCursorIntoView): Added. Default event listener that provides our own
234         implementation using WebKit's scrollIntoViewIfNeeded.
235
236         * UserInterface/Views/RulesStyleDetailsPanel.js:
237         (WebInspector.RulesStyleDetailsPanel.prototype.refresh): Stop doing an
238         extra scrollIntoViewIfNeeded call, CodeMirror does this.
239
240 2014-11-07  Joseph Pecoraro  <pecoraro@apple.com>
241
242         Web Inspector: Pseudo element matchedCSSRules do not include matching selector info
243         https://bugs.webkit.org/show_bug.cgi?id=138438
244
245         Reviewed by Benjamin Poulain.
246
247         * UserInterface/Base/Test.js:
248         (WebInspector.loaded):
249         Include a global setting for shadow dom used by DOM model classes.
250         Give it a "test" specific name to not override non-test setting values.
251
252 2014-11-05  Commit Queue  <commit-queue@webkit.org>
253
254         Unreviewed, rolling out r175628.
255         https://bugs.webkit.org/show_bug.cgi?id=138451
256
257         Totally borked the web inspector (Requested by smfr on
258         #webkit).
259
260         Reverted changeset:
261
262         "Web Inspector: Add infrastructure for eslint based static
263         analyzer"
264         https://bugs.webkit.org/show_bug.cgi?id=137890
265         http://trac.webkit.org/changeset/175628
266
267 2014-11-05  Joseph Pecoraro  <pecoraro@apple.com>
268
269         Web Inspector: Specificity not shown for pseudo element styles
270         https://bugs.webkit.org/show_bug.cgi?id=138436
271
272         Reviewed by Benjamin Poulain.
273
274         * UserInterface/Views/CSSStyleDeclarationSection.js:
275         (WebInspector.CSSStyleDeclarationSection.prototype.refresh):
276         Previously we were skipping the pre-selector <span>s when we were
277         not getting a listing of matched selector indices, and missing out
278         on the opportunity to give each selector a specificity. Now, always
279         loop over selectors if we have them.
280
281 2014-11-05  Jonathan Wells  <jonowells@apple.com>
282
283         Web Inspector: Add infrastructure for eslint based static analyzer
284         https://bugs.webkit.org/show_bug.cgi?id=137890
285
286         Reviewed by Timothy Hatcher.
287
288         Adding a manager to analyze source code, return warnings (AnalyzerMessages), and cache warnings.
289
290         * UserInterface/Base/Main.js: Create analyzerManager singleton.
291         * UserInterface/Controllers/AnalyzerManager.js: Added.
292         (WebInspector.AnalyzerManager):
293         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode.):
294         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode):
295         (set WebInspector.AnalyzerManager.prototype.set get sourceCodeCanBeAnalyzed):
296         (set WebInspector.AnalyzerManager.prototype._handleSourceCodeContentDidChange):
297         * UserInterface/Main.html: Add new files.
298         * UserInterface/Models/AnalyzerMessage.js: Added.
299         (WebInspector.AnalyzerMessage):
300         (WebInspector.AnalyzerMessage.prototype.get sourceCodeLocation):
301         (WebInspector.AnalyzerMessage.prototype.get sourceCode):
302         (WebInspector.AnalyzerMessage.prototype.get text):
303         (WebInspector.AnalyzerMessage.prototype.get ruleIdentifier):
304         * UserInterface/Models/SourceCode.js: Added call to WebInspector.Object.addConstructorFunctions().
305
306 2014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
307
308         Web Inspector: Too much whitespace in resource details sidebar in groups
309         https://bugs.webkit.org/show_bug.cgi?id=138386
310
311         Reviewed by Timothy Hatcher.
312
313         * UserInterface/Views/DetailsSection.css:
314         (.details-section > .content > .group:first-child > .row.simple:first-child > *):
315         (body.mac-platform.legacy .details-section > .content > .group:first-child > .row.simple:first-child > *):
316         (body.mac-platform.legacy .details-section > .content > .group > .row.text):
317         (.details-section > .content > .group > .row.properties:not(.empty)):
318         (body.mac-platform.legacy .details-section > .content > .group > .row.properties:not(.empty)):
319         Adjust top and bottom padding.
320
321 2014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
322
323         Web Inspector: Lots of TimelineDataGridNode asserts on reloads
324         https://bugs.webkit.org/show_bug.cgi?id=138387
325
326         Reviewed by Brian Burg.
327
328         The TimelineRuler.secondsPerPixel in the TimelineOverview is initialized
329         with a non-0 value and saved in a setting. However the TimelineRuler in
330         the OverviewTimelineView is not initialized with this value, and instead
331         initialized to 0. This patch initializes them to the same non-0 value.
332
333         * UserInterface/Views/OverviewTimelineView.js:
334         (WebInspector.OverviewTimelineView.prototype.set secondsPerPixel):
335         * UserInterface/Views/TimelineContentView.js:
336
337 2014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
338
339         Web Inspector: Pause on exceptions should show the actual exception
340         https://bugs.webkit.org/show_bug.cgi?id=63096
341
342         Reviewed by Timothy Hatcher.
343
344         * Localizations/en.lproj/localizedStrings.js:
345         * UserInterface/Main.html:
346         New strings / files.
347
348         * UserInterface/Controllers/DebuggerManager.js:
349         (WebInspector.DebuggerManager.prototype.get pauseReason):
350         (WebInspector.DebuggerManager.prototype.get pauseData):
351         (WebInspector.DebuggerManager.prototype.reset):
352         (WebInspector.DebuggerManager.prototype.debuggerDidPause):
353         (WebInspector.DebuggerManager.prototype._pauseReasonFromPayload):
354         Maintain the current pause reason and auxiliary data in the manager.
355
356         * UserInterface/Protocol/DebuggerObserver.js:
357         (WebInspector.DebuggerObserver.prototype.paused):
358         Pass previously unused event parameters on to the manager.
359
360         * UserInterface/Views/ConsoleMessageImpl.js:
361         (WebInspector.ConsoleMessageImpl):
362         Style error objects in the console like Objects. The new description
363         string provides a richer message if you console.log(exception).
364
365         * UserInterface/Views/DebuggerSidebarPanel.js:
366         (WebInspector.DebuggerSidebarPanel):
367         (WebInspector.DebuggerSidebarPanel.prototype._debuggerDidPause):
368         (WebInspector.DebuggerSidebarPanel.prototype._debuggerDidResume):
369         (WebInspector.DebuggerSidebarPanel.prototype._updatePauseReason):
370         Update the UI when we pause / resume to show / hide a pause reason section.
371
372         * UserInterface/Views/DetailsSectionRow.js:
373         (WebInspector.DetailsSectionRow.prototype.set emptyMessage):
374         Fix a latent bug that would have thrown an exception if the setter was ever used.
375
376         * UserInterface/Views/DetailsSectionTextRow.js: Added.
377         (WebInspector.DetailsSectionTextRow):
378         (WebInspector.DetailsSectionTextRow.prototype.get text):
379         (WebInspector.DetailsSectionTextRow.prototype.set text):
380         * UserInterface/Views/DetailsSection.css:
381         (.details-section > .content > .group > .row.simple.data > .value):
382         (.details-section > .content > .group > .row.text):
383         Simple class for a section of centered text. This is modelled after
384         the empty message text style in other sections.
385
386         * UserInterface/Views/LogContentView.css:
387         (.console-formatted-object, .console-formatted-node, .console-formatted-error):
388         (.console-formatted-object .section, .console-formatted-node .section, .console-formatted-error .section):
389         (.console-formatted-object .properties, .console-formatted-node .properties, .console-formatted-error .properties):
390         Style "error" objects like regular objects. We may wish to treat differently later.
391
392         * UserInterface/Protocol/Legacy/6.0/InspectorBackendCommands.js:
393         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
394         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
395         Regenerate legacy backend commands to get the new enum.
396
397 2014-11-04  Andrei Bucur  <abucur@adobe.com>
398
399         Building WebInspectorUI should not run the clang static analyzer by default
400         https://bugs.webkit.org/show_bug.cgi?id=137652
401
402         Reviewed by Timothy Hatcher.
403
404         There's no need to have the static analyzer enabled at compile time by default for the WebInspectorUI project.
405         It also breaks the ASAN build because the static analyzing step runs using the default compiler not the
406         ASAN clang.
407
408         * Configurations/DebugRelease.xcconfig: Remove the RUN_CLANG_STATIC_ANALYZER variable.
409
410 2014-11-04  Joseph Pecoraro  <pecoraro@apple.com>
411
412         Web Inspector: Uncaught Exceptions when paused and hovering JavaScript without CallFrames
413         https://bugs.webkit.org/show_bug.cgi?id=138338
414
415         Reviewed by Geoffrey Garen.
416
417         * UserInterface/Views/SourceCodeTextEditor.js:
418         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptExpression):
419         Fallback to using the main page's context if there is no active call frame we can use.
420
421 2014-11-03  Joseph Pecoraro  <pecoraro@apple.com>
422
423         Web Inspector: TextEditor search doesn't work after editing contents
424         https://bugs.webkit.org/show_bug.cgi?id=138198
425
426         Reviewed by Timothy Hatcher.
427
428         * UserInterface/Views/SourceCodeTextEditor.js:
429         (WebInspector.SourceCodeTextEditor.prototype.customPerformSearch):
430         Fallback to pure TextEditor content searching (CodeMirror) if the editor has edits.
431
432         * UserInterface/Views/TextEditor.js:
433         (WebInspector.TextEditor.prototype.hasEdits):
434         Check the CodeMirror clean state to known if we have edits or not.
435
436 2014-11-03  Joseph Pecoraro  <pecoraro@apple.com>
437
438         Web Inspector: Show Selector's Specificity
439         https://bugs.webkit.org/show_bug.cgi?id=138189
440
441         Reviewed by Timothy Hatcher.
442
443         * Localizations/en.lproj/localizedStrings.js:
444         * UserInterface/Main.html:
445         * UserInterface/Test.html:
446         Add new files and strings.
447
448         * UserInterface/Models/CSSMedia.js:
449         Constructor functions are not needed, remove unnecessary code.
450
451         * UserInterface/Models/CSSRule.js:
452         (WebInspector.CSSRule.prototype.set selectors): Deleted.
453         This was unused and is no longer correct.
454
455         (WebInspector.CSSRule.prototype.get matchedSelectorText):
456         Update now that selectors are a list of objects, not just strings.
457
458         * UserInterface/Models/CSSSelector.js:
459         (WebInspector.CSSSelector):
460         (WebInspector.CSSSelector.prototype.get specificity):
461         New model object for protocol type CSS.CSSSelector.
462
463         * UserInterface/Models/DOMNodeStyles.js:
464         (WebInspector.DOMNodeStyles.prototype._parseSelectorListPayload.return):
465         (WebInspector.DOMNodeStyles.prototype._parseSelectorListPayload):
466         (WebInspector.DOMNodeStyles.prototype._parseRulePayload):
467         Handle parsing old and new SelectorLists.
468
469         * UserInterface/Views/CSSStyleDeclarationSection.js:
470         (WebInspector.CSSStyleDeclarationSection.prototype.refresh.appendSelector):
471         (WebInspector.CSSStyleDeclarationSection.prototype.refresh.appendSelectorText):
472         (WebInspector.CSSStyleDeclarationSection.prototype.refresh):
473         Update the code now that the list of selectors are model objects instead
474         of just selector text strings.
475
476 2014-11-03  Joseph Pecoraro  <pecoraro@apple.com>
477
478         Web Inspector: ALTERNATE_DISPATCHERS Let the frontend know about extra agents
479         https://bugs.webkit.org/show_bug.cgi?id=138236
480
481         Reviewed by Brian Burg.
482
483         * UserInterface/Protocol/InspectorBackend.js:
484         (InspectorBackendClass.prototype.activateDomain):
485         * UserInterface/Protocol/InspectorObserver.js:
486         (WebInspector.InspectorObserver.prototype.activateExtraDomains):
487         * UserInterface/Base/Object.js:
488         * UserInterface/Base/Test.js:
489         * UserInterface/Base/Main.js:
490         (WebInspector.activateExtraDomains):
491         Default state is that there are no extra domains. When extra domains
492         are activated, some agents need to be re-initialized. Dispatch a
493         model event so views also know to re-initialize.
494
495         * UserInterface/Controllers/ApplicationCacheManager.js:
496         (WebInspector.ApplicationCacheManager.prototype._mainResourceDidChange):
497         * UserInterface/Controllers/DOMTreeManager.js:
498         Be more careful about direct agent use during main resource changes.
499         That can happen with a JSContext extended with a Page agent.
500
501         * UserInterface/Controllers/FrameResourceManager.js:
502         (WebInspector.FrameResourceManager):
503         (WebInspector.FrameResourceManager.prototype._mainFrameDidChange):
504         (WebInspector.FrameResourceManager.prototype._extraDomainsActivated):
505         * UserInterface/Controllers/StorageManager.js:
506         (WebInspector.StorageManager):
507         (WebInspector.StorageManager.prototype._databaseForIdentifier):
508         (WebInspector.StorageManager.prototype._extraDomainsActivated):
509         It is possible new window.FooAgent's are available. Perform expected
510         initialization re-checking if the agents are now available.
511
512         * UserInterface/Models/CSSCompletions.js:
513         Avoid re-initialization if we already did it. This should never
514         happen but this is just to be safe.
515
516         * UserInterface/Views/ResourceSidebarPanel.js:
517         (WebInspector.ResourceSidebarPanel):
518         (WebInspector.ResourceSidebarPanel.prototype._extraDomainsActivated):
519         Don't disallow expandable tree elements if this is a JSContext with
520         extra domains. If that JSContext has resources, we would have been
521         unable to see child resources.
522
523 2014-10-30  Dana Burkart  <dburkart@apple.com>
524
525         <rdar://problem/18821260> Prepare for the mysterious future
526
527         Reviewed by Lucas Forschler.
528
529         * Configurations/Base.xcconfig:
530         * Configurations/DebugRelease.xcconfig:
531         * Configurations/Version.xcconfig:
532
533 2014-10-10 Brian J. Burg  <burg@cs.washington.edu>
534
535         Web Inspector: timelines should not count time elapsed while paused in the debugger
536         https://bugs.webkit.org/show_bug.cgi?id=136351
537
538         Reviewed by Timothy Hatcher.
539
540         Don't update the timeline's current time when the debugger is paused.
541
542         Start and end times for timeline records are now in seconds elapsed since timeline
543         recording started, rather than milliseconds since the epoch. Also convert code that
544         tracks page/resource load timings to use elapsed times rather than timestamps.
545
546         Add a workaround to preserve compatibility with old backends. Convert legacy timestamps
547         in multiple agents to elapsed times.
548
549         * UserInterface/Controllers/FrameResourceManager.js:
550         (WebInspector.FrameResourceManager.prototype.resourceRequestWillBeSent):
551         (WebInspector.FrameResourceManager.prototype.resourceRequestWasServedFromMemoryCache):
552         (WebInspector.FrameResourceManager.prototype.resourceRequestDidReceiveResponse):
553         (WebInspector.FrameResourceManager.prototype.resourceRequestDidReceiveData):
554         (WebInspector.FrameResourceManager.prototype.resourceRequestDidFinishLoading):
555         (WebInspector.FrameResourceManager.prototype.resourceRequestDidFailLoading):
556         (WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):
557         * UserInterface/Controllers/ProbeManager.js:
558         * UserInterface/Controllers/TimelineManager.js:
559         (WebInspector.TimelineManager.prototype.computeElapsedTime): Forward to the active TimelineRecording.
560         (WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
561         (WebInspector.TimelineManager.prototype.eventRecorded):
562         (WebInspector.TimelineManager.prototype.pageDidLoad):
563         (WebInspector.TimelineManager.prototype._loadNewRecording):
564         * UserInterface/Models/Probe.js:
565         (WebInspector.ProbeSample):
566         * UserInterface/Models/Resource.js:
567         (WebInspector.Resource.prototype.updateForRedirectResponse):
568         (WebInspector.Resource.prototype.updateForResponse):
569         (WebInspector.Resource.prototype.increaseSize):
570         (WebInspector.Resource.prototype.markAsFinished):
571         (WebInspector.Resource.prototype.markAsFailed):
572         (WebInspector.Resource.prototype.revertMarkAsFinished):
573         * UserInterface/Models/TimelineRecording.js:
574         (WebInspector.TimelineRecording.prototype.computeElapsedTime):
575         * UserInterface/Views/TimelineContentView.js:
576         (WebInspector.TimelineContentView.prototype._debuggerPaused):
577         (WebInspector.TimelineContentView.prototype._debuggerResumed):
578
579
580 2014-10-23  Jono Wells  <jonowells@apple.com>
581
582         Web Inspector: Double border appearing in node sidebar in expanded items in OS X Mavericks.
583         https://bugs.webkit.org/show_bug.cgi?id=138011
584
585         Reviewed by Timothy Hatcher.
586
587         Selector added for OS X Mavericks and earlier versions using .mac-platform.legacy.
588
589         * UserInterface/Views/DetailsSection.css:
590         (body.mac-platform.legacy .details-section .details-section:first-child):
591
592 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
593
594         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
595         https://bugs.webkit.org/show_bug.cgi?id=132044
596
597         Reviewed by Brian Burg.
598
599         Make sure Protocol/InspectorFrontendHostStub.js is loaded before
600         Base/Platform.js, because Platform uses the InspectorFrontendHost
601         object.
602
603         * UserInterface/Main.html:
604
605 2014-10-20  Joseph Pecoraro  <pecoraro@apple.com>
606
607         Web Inspector: InspectorBackendCommands should include when to activate particular domains
608         https://bugs.webkit.org/show_bug.cgi?id=137753
609
610         Reviewed by Timothy Hatcher.
611
612         * UserInterface/Base/Main.js:
613         * UserInterface/Base/Test.js:
614         (WebInspector.loaded):
615         Activation now happens automatically so remove the hardcoded activations.
616
617         * UserInterface/Protocol/InspectorBackend.js:
618         (InspectorBackendClass.prototype.activateDomain):
619         Given no filter, always activate a domain. Otherwise only activate
620         if the debuggable type matches the provided filter.
621
622         * UserInterface/Protocol/Legacy/6.0/InspectorBackendCommands.js:
623         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
624         Only web debuggables are supported in iOS 6 and 7. The JSON files do not
625         need to change, all agents will auto activate.
626
627         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
628         * Versions/Inspector-iOS-8.0.json:
629         Specify which are web debuggables in iOS 8 since JS inspection is possible.
630
631 2014-10-20  Joseph Pecoraro  <pecoraro@apple.com>
632
633         Web Inspector: Generate all Inspector domains together in JavaScriptCore
634         https://bugs.webkit.org/show_bug.cgi?id=137748
635
636         Reviewed by Brian Burg.
637
638         Change the frontend to always load all agents, but only activate a subset
639         of the agents depending on the type of the backend.
640
641         * UserInterface/Base/Main.js:
642         (WebInspector.loaded):
643         * UserInterface/Protocol/InspectorBackend.js:
644         (InspectorBackendClass.prototype.activateDomains):
645         (InspectorBackendClass.prototype.activateAllDomains):
646         (InspectorBackendClass.prototype._agentForDomain):
647         (InspectorBackendClass.prototype._dispatchEvent):
648         (InspectorBackend.Agent):
649         (InspectorBackend.Agent.prototype.get active):
650         (InspectorBackend.Agent.prototype.activate):
651         * UserInterface/Base/Test.js:
652         Only expose "window.FooAgent" or allow dispatches in the "Foo" domain
653         when that particular agent is activated. Currently we hardcode the list
654         of agents to activate for a debuggable type. This should be generated.
655
656         * UserInterface/Protocol/LoadInspectorBackendCommands.js:
657         Now there should always be a single "InspectorBackendCommands.js" file to load.
658         We may want to change the RWI path to return a single file instead of an array.
659
660         * Scripts/update-LegacyInspectorBackendCommands.rb:
661         * UserInterface/Protocol/Legacy/6.0/InspectorBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js.
662         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js.
663         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js: Renamed from Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js.
664         * UserInterface/Protocol/Legacy/8.0/InspectorJSBackendCommands.js: Removed.
665         * Versions/Inspector-iOS-8.0.json: Renamed from Source/WebInspectorUI/Versions/InspectorWeb-iOS-8.0.json.
666         * Versions/InspectorJS-iOS-8.0.json: Removed.
667         Update Legacy versions to output a single InspectorBackendCommands.js file.
668         Do a straightforward merge of the iOS 8 JS/Web inputs to a single json file.
669
670         * Configurations/Base.xcconfig:
671         * Configurations/DebugRelease.xcconfig:
672         * Configurations/WebInspectorUIFramework.xcconfig:
673         * Scripts/copy-user-interface-resources-dryrun.rb:
674         * Scripts/copy-user-interface-resources.pl:
675         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
676         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
677         * WebInspectorUI.vcxproj/build-webinspectorui.pl:
678         We no longer needed WebCore's Private Headers, so simplify build files
679         and update file names where appropriate.
680
681 2014-10-17  Jono Wells  <jonowells@apple.com>
682
683         Web Inspector: Add ESLint open source library to the inspector
684         https://bugs.webkit.org/show_bug.cgi?id=137714
685
686         Reviewed by Joseph Pecoraro.
687
688         This adds back the eslint.js external library with a correction to Scripts/copy-user-interface-resources.pl
689         to prevent a build failure.
690
691         * Scripts/copy-user-interface-resources.pl: Added copy commands for ESLint.js.
692         * UserInterface/External/ESLint/LICENSE: Added.
693         * UserInterface/External/ESLint/eslint.js: Added.
694
695 2014-10-14  Jono Wells  <jonowells@apple.com>
696
697         Web Inspector: Add ESLint open source library to the inspector
698         https://bugs.webkit.org/show_bug.cgi?id=137714
699
700         Reviewed by Timothy Hatcher.
701
702         This adds the eslint.js external library for static analysis and the necessary license.
703
704         * Scripts/copy-user-interface-resources.pl:
705         * UserInterface/External/ESLint/LICENSE: Added.
706         * UserInterface/External/ESLint/eslint.js: Added.
707
708 2014-10-14  Joseph Pecoraro  <pecoraro@apple.com>
709
710         Web Inspector: paint flashing mode should be disabled when remote inspecting legacy iOS versions
711         https://bugs.webkit.org/show_bug.cgi?id=137575
712
713         Reviewed by Simon Fraser.
714
715         Remove setShowPaintRects from the legacy iOS protocol definitions.
716         The methods were unimplemented by the backends, so they should
717         not advertise supporting it.
718
719         * UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js:
720         * UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
721         * UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js:
722         * Versions/Inspector-iOS-6.0.json:
723         * Versions/Inspector-iOS-7.0.json:
724         * Versions/InspectorWeb-iOS-8.0.json:
725
726 2014-10-14  Joseph Pecoraro  <pecoraro@apple.com>
727
728         Web Inspector: Processing Instruction Nodes appear poorly in DOM Tree
729         https://bugs.webkit.org/show_bug.cgi?id=137681
730
731         Reviewed by Timothy Hatcher.
732
733         Handle processing instruction node types in more places. The
734         backend sends the contents as a pure string, not as attribute
735         pairs, so just include the string in the UI.
736
737         * UserInterface/Models/DOMSearchMatchObject.js:
738         (WebInspector.DOMSearchMatchObject.prototype._generateClassName):
739         (WebInspector.DOMSearchMatchObject.titleForDOMNode):
740         * UserInterface/Views/DOMTreeElement.js:
741         (WebInspector.DOMTreeElement.prototype._nodeTitleInfo):
742         Display the value in the UI.
743
744         * UserInterface/Views/DOMTreeElementPathComponent.js:
745         (WebInspector.DOMTreeElementPathComponent):
746         Include an icon like DOCTYPE.
747
748         * UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
749         (.syntax-highlighted .html-processing-instruction):
750         Style gray like a DOCTYPE.
751
752 2014-10-13  Joseph Pecoraro  <pecoraro@apple.com>
753
754         Web Inspector: Paint Flashing button does not match page state after reload
755         https://bugs.webkit.org/show_bug.cgi?id=137680
756
757         Reviewed by Timothy Hatcher.
758
759         * UserInterface/Base/Main.js:
760         (WebInspector.loaded):
761         Make paint flashing a frontend setting. Enable it when the inspector
762         is opened if it was previously enabled.
763
764         * UserInterface/Views/DOMTreeContentView.js:
765         (WebInspector.DOMTreeContentView):
766         (WebInspector.DOMTreeContentView.prototype._togglePaintFlashing):
767         (WebInspector.DOMTreeContentView.prototype._showPaintRectsSettingChanged):
768         Have the paint flashing button always match the global setting.
769
770 2014-10-13  Joseph Pecoraro  <pecoraro@apple.com>
771
772         Web Inspector: Improve appearance of alpha color swatches
773         https://bugs.webkit.org/show_bug.cgi?id=137627
774
775         Reviewed by Andreas Kling.
776
777         * UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
778         * UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js:
779         * Versions/Inspector-iOS-7.0.json:
780         * Versions/InspectorWeb-iOS-8.0.json:
781
782 2014-10-10  Joseph Pecoraro  <pecoraro@apple.com>
783
784         Web Inspector: Improve appearance of alpha color swatches
785         https://bugs.webkit.org/show_bug.cgi?id=137627
786
787         Reviewed by Timothy Hatcher.
788
789         This improves the sizes. The color-swatch size is 1em x 1em,
790         which ends up being 11px, and thus there is still an imbalance.
791         However on both 1x and 2x displays this looks more even.
792
793         * UserInterface/Views/CSSStyleDeclarationTextEditor.css:
794         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .color-swatch):
795
796 2014-10-10  Joseph Pecoraro  <pecoraro@apple.com>
797
798         Web Inspector: assert always logs undefined instead of the desired string
799         https://bugs.webkit.org/show_bug.cgi?id=137632
800
801         Reviewed by Timothy Hatcher.
802
803         * UserInterface/Protocol/InspectorFrontendAPI.js:
804         (InspectorFrontendAPI.dispatch):
805         Fix the assert log to include the method name.
806
807 2014-10-10  Joseph Pecoraro  <pecoraro@apple.com>
808
809         Web Inspector: CSS minification should not strip whitespace around calc +/- binary operators
810         https://bugs.webkit.org/show_bug.cgi?id=137624
811
812         Reviewed by Timothy Hatcher.
813
814         Be careful when stripping whitespace around "+". We want to strip for
815         selectors "a + b" but not for calc expressions "calc(1px + 2px)".
816
817         This is not a perfect solution, but it does a good job. It may still break
818         with more complex calc expressions, like "calc(1px + calc())" but this
819         handles the basics.
820
821         * Scripts/copy-user-interface-resources-dryrun.rb: Added.
822         * Scripts/cssmin.py:
823         (cssminify):
824
825 2014-10-09  Joseph Pecoraro  <pecoraro@apple.com>
826
827         Web Inspector: DOM Storage Editing is broken in many ways, frustrating
828         https://bugs.webkit.org/show_bug.cgi?id=137547
829
830         Reviewed by Timothy Hatcher.
831
832         * UserInterface/Models/DOMStorageObject.js:
833         (WebInspector.DOMStorageObject.prototype.getEntries): Deleted.
834         When getting entires, populate the model object with these keys/values
835         so we can accurately detect duplicates in editing.
836
837         * UserInterface/Views/DataGrid.js:
838         (WebInspector.DataGrid.prototype.determineNextCell):
839         (WebInspector.DataGrid.prototype.moveToNextCell):
840         When the users uses "Enter" to commit, stop editing.
841
842         (WebInspector.DataGrid.prototype._editingCommitted):
843         Fix title property accessor. This is not a map. This fixes an exception
844         when showing context menus on editable data grid rows.
845
846         * UserInterface/Views/DOMStorageContentView.js:
847         (WebInspector.DOMStorageContentView.prototype.cleanup):
848         (WebInspector.DOMStorageContentView.prototype.restoreOriginalValues):
849         (WebInspector.DOMStorageContentView.prototype._editingCallback):
850         Completely rewrite editing here. As soon as an edit is made, enter
851         an uncommitted state with the original key/value. When a commit is
852         allowed, update as appropriate based on the original values.
853
854 2014-10-08  Joseph Pecoraro  <pecoraro@apple.com>
855
856         Web Inspector: CSS Pretty Printing fails to put space between value functions around ending parenthesis
857         https://bugs.webkit.org/show_bug.cgi?id=137415
858
859         Reviewed by Timothy Hatcher.
860
861         Add a space after a closing parenthesis if we are still inside a property.
862         This adds space between space separated function lists such as
863         -webkit-transform:foo(...)bar(...). Also add a test for keyframe syntax.
864
865         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
866         * Tools/PrettyPrinting/css-tests/keyframes-expected.css: Added.
867         * Tools/PrettyPrinting/css-tests/keyframes.css: Added.
868         * Tools/PrettyPrinting/index.html:
869         * UserInterface/Views/CodeMirrorFormatters.js:
870
871 2014-10-08  Joseph Pecoraro  <pecoraro@apple.com>
872
873         Web Inspector: CSS Pretty Printing fails to put space between rgb(...) and numbers in minified gradients
874         https://bugs.webkit.org/show_bug.cgi?id=137414
875
876         Reviewed by Timothy Hatcher.
877
878         Add whitespace between rgb(...) and a number, possible in gradient
879         syntax like "linear-gradient(rgb(...)0%,rgb(...)100%)".
880
881         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
882         * Tools/PrettyPrinting/css-tests/gradient-expected.css: Added.
883         (.dot-nav:nth-child(1n) li a.active):
884         * Tools/PrettyPrinting/css-tests/gradient.css: Added.
885         (.dot-nav:nth-child(1n) li a.active):
886         * Tools/PrettyPrinting/index.html:
887         * UserInterface/Views/CodeMirrorFormatters.js:
888
889 2014-10-08  Joseph Pecoraro  <pecoraro@apple.com>
890
891         Web Inspector: CSS Pretty Printing fails to wrap long lines of selectors with pseudo classes/elements
892         https://bugs.webkit.org/show_bug.cgi?id=137413
893
894         Reviewed by Timothy Hatcher.
895
896         Long line wrapping was breaking as soon as there was a ':' for a psuedo
897         class or element. Likewise it was counting comment strings as part of
898         the length of the line even though it would get a newline after it.
899
900         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
901         * Tools/PrettyPrinting/css-tests/basic-expected.css:
902         (progress, section, summary, time):
903         * Tools/PrettyPrinting/css-tests/wrapping-expected.css: Added.
904         (a.tryamacs, a.upgradenows):
905         (a.tryamacs:hover, a.upgradenows:hover):
906         * Tools/PrettyPrinting/css-tests/wrapping.css: Added.
907         (a.browsewebappss,a.businessstores,a.buyiphones,a.buynows,a.buynows-arrow,a.comingsoons,p::before,a.descargarahoras,a.downloadituness,a.downloadnows,a.finds,a.freetrials,a.getstarteds,a.gos,a.howtoapplys,a.howtobuys,a.joinnows,a.learnmores,a.nikebuynows,a.notifymes,a.ordernows,a.preordernows,a.preorders,a.reserves,a.startyoursearchs,a.submits,a.tryamacs,a.upgradenows):
908         (a.browsewebappss:hover,a.businessstores:hover,a.buyiphones:hover,a.buynows:hover,a.buynows-arrow:hover,a.comingsoons:hover,p::before,a.descargarahoras:hover,a.downloadituness:hover,a.downloadnows:hover,a.finds:hover,a.freetrials:hover,a.getstarteds:hover,a.gos:hover,a.howtoapplys:hover,a.howtobuys:hover,a.joinnows:hover,a.learnmores:hover,a.nikebuynows:hover,a.notifymes:hover,a.ordernows:hover,a.preordernows:hover,a.preorders:hover,a.reserves:hover,a.startyoursearchs:hover,a.submits:hover,a.tryamacs:hover,a.upgradenows:hover):
909         * Tools/PrettyPrinting/index.html:
910         * UserInterface/Views/CodeMirrorFormatters.js:
911
912 2014-10-04  Joseph Pecoraro  <pecoraro@apple.com>
913
914         Web Inspector: Add PrettyPrinter CSS tests
915         https://bugs.webkit.org/show_bug.cgi?id=134005
916
917         Reviewed by Timothy Hatcher.
918
919         Add CSS pretty printing tests. Improve pretty printing of calc()
920         expressions and media-queries with whitespace around operators
921         and keywords. Also fix the debug output in the tool for CSS.
922
923         * Tools/PrettyPrinting/CodeMirrorFormatters.js:
924         * Tools/PrettyPrinting/FormatterContentBuilder.js:
925         (FormatterContentBuilder.prototype._appendIndent):
926         * Tools/PrettyPrinting/FormatterDebug.js:
927         (.debugToken):
928         (Formatter.prototype.debug):
929         * Tools/PrettyPrinting/css-tests/basic-expected.css: Added.
930         * Tools/PrettyPrinting/css-tests/basic.css: Added.
931         * Tools/PrettyPrinting/css-tests/calc-expected.css: Added.
932         * Tools/PrettyPrinting/css-tests/calc.css: Added.
933         * Tools/PrettyPrinting/css-tests/media-query-expected.css: Added.
934         * Tools/PrettyPrinting/css-tests/media-query.css: Added.
935         * Tools/PrettyPrinting/css-tests/selectors-expected.css: Added.
936         * Tools/PrettyPrinting/css-tests/selectors.css: Added.
937         * Tools/PrettyPrinting/index.html:
938         * UserInterface/Views/CodeMirrorFormatters.js:
939
940 2014-10-04  Brian J. Burg  <burg@cs.washington.edu>
941
942         Unreviewed, rolling out r174319.
943
944         Causes assertions in fast/profiler tests. Needs nontrivial
945         investigation, will take offline.
946
947         Reverted changeset:
948
949         "Web Inspector: timelines should not count time elapsed while
950         paused in the debugger"
951         https://bugs.webkit.org/show_bug.cgi?id=136351
952         http://trac.webkit.org/changeset/174319
953
954 2014-10-04  Brian J. Burg  <burg@cs.washington.edu>
955
956         Web Inspector: timelines should not count time elapsed while paused in the debugger
957         https://bugs.webkit.org/show_bug.cgi?id=136351
958
959         Reviewed by Timothy Hatcher.
960
961         Don't update the timeline's current time when the debugger is paused.
962
963         Start and end times for timeline records are now in seconds elapsed since timeline
964         recording started, rather than milliseconds since the epoch. Add a workaround to
965         preserve compatibility with old backends.
966
967         * UserInterface/Controllers/TimelineManager.js:
968         (WebInspector.TimelineManager.prototype.capturingStarted):
969         (WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
970         (WebInspector.TimelineManager.prototype.eventRecorded):
971         * UserInterface/Views/TimelineContentView.js:
972         (WebInspector.TimelineContentView.prototype._debuggerPaused):
973         (WebInspector.TimelineContentView.prototype._debuggerResumed):
974
975 2014-10-03  Saam Barati  <saambarati1@gmail.com>
976
977         Web Inspector: Move the computation that results in UI strings from JSC to the Web Inspector
978         https://bugs.webkit.org/show_bug.cgi?id=137295
979
980         Reviewed by Timothy Hatcher.
981
982         The inspector now computes a set of properties that was previously 
983         computed inside JSC. 
984
985         This patch also addresses the weird experience of the 
986         type of an expression claiming to be both a Number and 
987         an Integer. This could be a bit confusing because Number 
988         is supposed to represent Double|Integer and the previous
989         UI implied that Number was equivalent to Double. The new UI only 
990         ever shows either the type of Number or Integer when showing
991         the type information of an expression. It never shows both Number
992         and Integer simultaneously to describe a single expression.
993
994         * UserInterface/Models/TypeSet.js:
995         (WebInspector.TypeSet):
996         (WebInspector.TypeSet.prototype.isContainedIn):
997         (WebInspector.TypeSet.prototype.get primitiveTypeNames):
998         * UserInterface/Views/TypePropertiesSection.js:
999         (WebInspector.TypePropertiesSection):
1000         (WebInspector.TypePropertiesSection.prototype.onpopulate):
1001         * UserInterface/Views/TypeTokenView.js:
1002         (WebInspector.TypeTokenView):
1003         (WebInspector.TypeTokenView.prototype.update):
1004         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
1005         (WebInspector.TypeTokenView.prototype._displayTypeName):
1006
1007 2014-10-02  Joseph Pecoraro  <pecoraro@apple.com>
1008
1009         Web Inspector: Cannot add a new CSS Rule to elements with 3 or more class names
1010         https://bugs.webkit.org/show_bug.cgi?id=137375
1011
1012         Reviewed by Timothy Hatcher.
1013
1014         Correctly merge all class names with dots instead of just the first two.
1015
1016         * UserInterface/Models/DOMNode.js:
1017
1018 2014-10-02  Mark Lam  <mark.lam@apple.com>
1019
1020         Fixed the Inspector to be able to properly distinguish between scope types.
1021         <https://webkit.org/b/137279>
1022
1023         Reviewed by Geoffrey Garen and Joseph Pecoraro.
1024
1025         * Localizations/en.lproj/localizedStrings.js:
1026         * UserInterface/Controllers/DebuggerManager.js:
1027         * UserInterface/Models/ScopeChainNode.js:
1028         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
1029         - Added handling of the FunctionNameScope case.
1030
1031 2014-10-02  Andres Gomez  <agomez@igalia.com>
1032
1033         Web Inspector: [GTK] Missing icons and enhancing the proportion and visibility of some icons
1034         https://bugs.webkit.org/show_bug.cgi?id=137248
1035
1036         Reviewed by Carlos Garcia Campos.
1037
1038         Add more free icons and removed some unused ones for the Web
1039         Inspector in GTK+.
1040         Also, enhanced the visibility and/or proportion of several of the
1041         icons.
1042
1043         * UserInterface/Images/gtk/AUTHORS:
1044         * UserInterface/Images/gtk/COPYING:
1045         * UserInterface/Images/gtk/Checkers.svg: Added.
1046         * UserInterface/Images/gtk/Circle.svg: Added.
1047         * UserInterface/Images/gtk/CloseLarge.svg: Added.
1048         * UserInterface/Images/gtk/CloseTimeline.png: Removed.
1049         * UserInterface/Images/gtk/CloseTimeline@2x.png: Removed.
1050         * UserInterface/Images/gtk/Crosshair.svg:
1051         * UserInterface/Images/gtk/DOMCharacterData.svg:
1052         * UserInterface/Images/gtk/DOMComment.svg:
1053         * UserInterface/Images/gtk/DOMDocument.svg:
1054         * UserInterface/Images/gtk/DOMDocumentType.svg:
1055         * UserInterface/Images/gtk/DOMElement.svg:
1056         * UserInterface/Images/gtk/DOMNode.svg:
1057         * UserInterface/Images/gtk/DOMTextNode.svg:
1058         * UserInterface/Images/gtk/DOMTree.svg:
1059         * UserInterface/Images/gtk/EventListener.svg:
1060         * UserInterface/Images/gtk/Exception.svg:
1061         * UserInterface/Images/gtk/Function.svg:
1062         * UserInterface/Images/gtk/GradientStop.png: Added.
1063         * UserInterface/Images/gtk/GradientStop@2x.png: Added.
1064         * UserInterface/Images/gtk/GradientStopSelected.png: Added.
1065         * UserInterface/Images/gtk/GradientStopSelected@2x.png: Added.
1066         * UserInterface/Images/gtk/Issues.svg:
1067         * UserInterface/Images/gtk/IssuesEnabled.svg:
1068         * UserInterface/Images/gtk/LessColumns.svg: Removed.
1069         * UserInterface/Images/gtk/Logs.svg:
1070         * UserInterface/Images/gtk/Memory.svg: Removed.
1071         * UserInterface/Images/gtk/MoreColumns.svg: Removed.
1072         * UserInterface/Images/gtk/Native.svg:
1073         * UserInterface/Images/gtk/NavigationItemAngleBrackets.svg:
1074         * UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg:
1075         * UserInterface/Images/gtk/NavigationItemBug.svg:
1076         * UserInterface/Images/gtk/NavigationItemFile.svg:
1077         * UserInterface/Images/gtk/NavigationItemLayers.svg:
1078         * UserInterface/Images/gtk/NavigationItemMagnifyingGlass.svg: Removed.
1079         * UserInterface/Images/gtk/NavigationItemProbes.pdf: Added.
1080         * UserInterface/Images/gtk/NavigationItemStopwatch.svg:
1081         * UserInterface/Images/gtk/NavigationItemTypes.svg: Added.
1082         * UserInterface/Images/gtk/PaintFlashing.svg: Added.
1083         * UserInterface/Images/gtk/PseudoElement.svg:
1084         * UserInterface/Images/gtk/Record.svg: Added.
1085         * UserInterface/Images/gtk/Recording.png: Removed.
1086         * UserInterface/Images/gtk/Recording@2x.png: Removed.
1087         * UserInterface/Images/gtk/RecordingHovered.png: Removed.
1088         * UserInterface/Images/gtk/RecordingHovered@2x.png: Removed.
1089         * UserInterface/Images/gtk/RecordingStopped.png: Removed.
1090         * UserInterface/Images/gtk/RecordingStopped@2x.png: Removed.
1091         * UserInterface/Images/gtk/Reflection.svg:
1092         * UserInterface/Images/gtk/ReplayPauseButton.svg: Added.
1093         * UserInterface/Images/gtk/ReplayPlayButton.svg: Added.
1094         * UserInterface/Images/gtk/ReplayRecordingButton.svg: Added.
1095         * UserInterface/Images/gtk/Request.svg:
1096         * UserInterface/Images/gtk/Resources.svg:
1097         * UserInterface/Images/gtk/Response.svg:
1098         * UserInterface/Images/gtk/ResultLine.svg:
1099         * UserInterface/Images/gtk/SourceCode.svg:
1100         * UserInterface/Images/gtk/Stop.svg: Added.
1101         * UserInterface/Images/gtk/StyleRuleAuthor.svg:
1102         * UserInterface/Images/gtk/StyleRuleInherited.svg:
1103         * UserInterface/Images/gtk/StyleRuleInheritedElement.svg:
1104         * UserInterface/Images/gtk/StyleRuleInspector.svg:
1105         * UserInterface/Images/gtk/StyleRuleUser.svg:
1106         * UserInterface/Images/gtk/StyleRuleUserAgent.svg:
1107         * UserInterface/Images/gtk/Time.svg:
1108         * UserInterface/Images/gtk/TimelineRecordAnimation.svg:
1109         * UserInterface/Images/gtk/TimelineRecordConsoleProfile.svg: Added.
1110         * UserInterface/Images/gtk/TimelineRecordEvent.svg:
1111         * UserInterface/Images/gtk/TimelineRecordLayout.svg:
1112         * UserInterface/Images/gtk/TimelineRecordPaint.svg:
1113         * UserInterface/Images/gtk/TimelineRecordProbeSampled.svg: Added.
1114         * UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg:
1115         * UserInterface/Images/gtk/TimelineRecordStyle.svg:
1116         * UserInterface/Images/gtk/TimelineRecordTimer.svg:
1117         * UserInterface/Images/gtk/Weight.svg:
1118
1119 2014-09-27  Brian J. Burg  <burg@cs.washington.edu>
1120
1121         Web Replay: Playback position updates should be sent before the next event loop input is dispatched
1122         https://bugs.webkit.org/show_bug.cgi?id=137162
1123
1124         Reviewed by Timothy Hatcher.
1125
1126         Pausing playback from the UI was broken because of a typo. Fix this, and rename
1127         stopPlayback to cancelPlayback.
1128
1129         * UserInterface/Controllers/ReplayManager.js:
1130         (WebInspector.ReplayManager.prototype.switchSession.if):
1131
1132 2014-09-26  Joseph Pecoraro  <pecoraro@apple.com>
1133
1134         Web Inspector: Automatic Inspection should continue once all breakpoints are loaded
1135         https://bugs.webkit.org/show_bug.cgi?id=137038
1136
1137         Reviewed by Timothy Hatcher.
1138
1139         * UserInterface/Base/Main.js:
1140         Send the initialized message after we have sent all other setup messages,
1141         such as enabling features and setting breakpoints.
1142
1143 2014-09-26  Saam Barati  <saambarati1@gmail.com>
1144
1145         Web Inspector: Type Token View shows type information on hover when it shouldn't
1146         https://bugs.webkit.org/show_bug.cgi?id=137152
1147
1148         Reviewed by Brian J. Burg.
1149
1150         TypeTokenView should only show type information when there is 
1151         more than one primitive type or more than zero objects types. 
1152         This fixes a bug in checking the length of object types.
1153
1154         * UserInterface/Views/TypeTokenView.js:
1155         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
1156
1157 2014-09-25  Timothy Hatcher  <timothy@apple.com>
1158
1159         Web Inspector: Show type info icon is blurry
1160         https://bugs.webkit.org/show_bug.cgi?id=137125
1161
1162         Reviewed by Darin Adler.
1163
1164         * UserInterface/Images/NavigationItemTypes.svg:
1165         * UserInterface/Views/ScriptContentView.js:
1166         (WebInspector.ScriptContentView):
1167         * UserInterface/Views/TextContentView.js:
1168         (WebInspector.TextContentView):
1169         * UserInterface/Views/TextResourceContentView.js:
1170         (WebInspector.TextResourceContentView):
1171
1172 2014-09-25  Saam Barati  <saambarati1@gmail.com>
1173
1174         Web Inspector: console.assert(bitString) TypeSet:50 
1175         https://bugs.webkit.org/show_bug.cgi?id=137051
1176
1177         Reviewed by Joseph Pecoraro.
1178
1179         This fixes TypeSet's isContainedIn method by ensuring that 
1180         the type bit string isn't zero because the test would trivially 
1181         pass if the bit string is zero.
1182
1183         * UserInterface/Models/TypeSet.js:
1184         (WebInspector.TypeSet.prototype.isContainedIn):
1185
1186 2014-09-25  Brian J. Burg  <burg@cs.washington.edu>
1187
1188         Web Inspector: FunctionCall timeline records omit profile data if the debugger has paused
1189         https://bugs.webkit.org/show_bug.cgi?id=136805
1190
1191         Reviewed by Timothy Hatcher.
1192
1193         * UserInterface/Test.html: Add missing include for ScopeChainNode.js.
1194
1195 2014-09-25  Brian J. Burg  <burg@cs.washington.edu>
1196
1197         Web Inspector: sort probe details sidebar sections by source code location string
1198         https://bugs.webkit.org/show_bug.cgi?id=137080
1199
1200         Reviewed by Timothy Hatcher.
1201
1202         Probe sections should display in the same order as associated breakpoint tree elements.
1203
1204         * UserInterface/Views/ProbeDetailsSidebarPanel.js:
1205         (WebInspector.ProbeDetailsSidebarPanel.prototype.inspect.inspectedProbeSets):
1206         (WebInspector.ProbeDetailsSidebarPanel.prototype.inspect):
1207
1208 2014-09-25  Andres Gomez  <agomez@igalia.com>
1209
1210         Unreviewed. Add more free icons for the Web Inspector in GTK+.
1211
1212         * UserInterface/Images/gtk/AUTHORS:
1213         * UserInterface/Images/gtk/ApplicationCacheManifest.png: Added.
1214         * UserInterface/Images/gtk/ApplicationCacheManifest@2x.png: Added.
1215         * UserInterface/Images/gtk/COPYING:
1216         * UserInterface/Images/gtk/COPYING_LGPL2: Added.
1217         * UserInterface/Images/gtk/Cookie.png: Added.
1218         * UserInterface/Images/gtk/Cookie@2x.png: Added.
1219         * UserInterface/Images/gtk/HoverMenuButton.png: Added.
1220         * UserInterface/Images/gtk/HoverMenuButton@2x.png: Added.
1221         * UserInterface/Images/gtk/InstructionPointer.png: Added.
1222         * UserInterface/Images/gtk/InstructionPointer@2x.png: Added.
1223         * UserInterface/Images/gtk/Log.png: Added.
1224         * UserInterface/Images/gtk/Log@2x.png: Added.
1225         * UserInterface/Images/gtk/Profile.png: Added.
1226         * UserInterface/Images/gtk/Profile@2x.png: Added.
1227         * UserInterface/Images/gtk/Recording.png: Added.
1228         * UserInterface/Images/gtk/Recording@2x.png: Added.
1229         * UserInterface/Images/gtk/RecordingHovered.png: Added.
1230         * UserInterface/Images/gtk/RecordingHovered@2x.png: Added.
1231         * UserInterface/Images/gtk/RecordingStopped.png: Added.
1232         * UserInterface/Images/gtk/RecordingStopped@2x.png: Added.
1233         * UserInterface/Images/gtk/Script.png: Added.
1234         * UserInterface/Images/gtk/Script@2x.png: Added.
1235         * UserInterface/Images/gtk/ScriptLarge.png: Added.
1236         * UserInterface/Images/gtk/ScriptLarge@2x.png: Added.
1237         * UserInterface/Images/gtk/SliderThumb.png: Added.
1238         * UserInterface/Images/gtk/SliderThumb@2x.png: Added.
1239         * UserInterface/Images/gtk/SliderThumbPressed.png: Added.
1240         * UserInterface/Images/gtk/SliderThumbPressed@2x.png: Added.
1241         * UserInterface/Images/gtk/Stopwatch.png: Added.
1242         * UserInterface/Images/gtk/Stopwatch@2x.png: Added.
1243
1244 2014-09-21  Timothy Hatcher  <timothy@apple.com>
1245
1246         Make the Web Inspector use a separate web process.
1247
1248         https://bugs.webkit.org/show_bug.cgi?id=135120
1249
1250         Reviewed by Anders Carlsson.
1251
1252         * Localizations/en.lproj/localizedStrings.js: Updated.
1253
1254         * UserInterface/Base/Main.js:
1255         (WebInspector.loaded):
1256         (WebInspector.contentLoaded):
1257         Move InspectorFrontendHost.loaded to later in the load.
1258         Calling it early just shows the window before we have
1259         a user interface to show.
1260
1261         * UserInterface/Base/Test.js:
1262         (WebInspector.loaded):
1263         (WebInspector.contentLoaded):
1264         Match the changes in Main.js.
1265
1266         * UserInterface/Protocol/InspectorFrontendAPI.js:
1267         (InspectorFrontendAPI.savedURL): Change comment.
1268         (InspectorFrontendAPI.appendedToURL): Change comment.
1269         (InspectorFrontendAPI.dispatch): Add an assert and early
1270         return to be safe from unknown commands.
1271         (InspectorFrontendAPI.loadCompleted): Delete _pendingCommands,
1272         no need to keep an empty array around a one time use.
1273
1274 2014-09-24  Andres Gomez  <agomez@igalia.com>
1275
1276         Unreviewed. Add more free icons for the Web Inspector in GTK+
1277
1278         * UserInterface/Images/gtk/AUTHORS:
1279         * UserInterface/Images/gtk/ApplicationCache.png: Added.
1280         * UserInterface/Images/gtk/ApplicationCache@2x.png: Added.
1281         * UserInterface/Images/gtk/BottomUpTree.svg: Added.
1282         * UserInterface/Images/gtk/Breakpoint.png: Added.
1283         * UserInterface/Images/gtk/Breakpoint@2x.png: Added.
1284         * UserInterface/Images/gtk/BreakpointButton.svg:
1285         * UserInterface/Images/gtk/BreakpointInactive.png: Added.
1286         * UserInterface/Images/gtk/BreakpointInactive@2x.png: Added.
1287         * UserInterface/Images/gtk/BreakpointInactiveButton.svg:
1288         * UserInterface/Images/gtk/COPYING:
1289         * UserInterface/Images/gtk/COPYING_CCBYSA3: Copied from Source/WebInspectorUI/UserInterface/Images/gtk/COPYING.
1290         * UserInterface/Images/gtk/ClippingCSS.png: Added.
1291         * UserInterface/Images/gtk/ClippingCSS@2x.png: Added.
1292         * UserInterface/Images/gtk/ClippingGeneric.png: Added.
1293         * UserInterface/Images/gtk/ClippingGeneric@2x.png: Added.
1294         * UserInterface/Images/gtk/ClippingJS.png: Added.
1295         * UserInterface/Images/gtk/ClippingJS@2x.png: Added.
1296         * UserInterface/Images/gtk/CloseTimeline.png: Added.
1297         * UserInterface/Images/gtk/CloseTimeline@2x.png: Added.
1298         * UserInterface/Images/gtk/ColorIcon.png: Added.
1299         * UserInterface/Images/gtk/ColorIcon@2x.png: Added.
1300         * UserInterface/Images/gtk/Colors.png: Added.
1301         * UserInterface/Images/gtk/Colors@2x.png: Added.
1302         * UserInterface/Images/gtk/ColorsLarge.png: Added.
1303         * UserInterface/Images/gtk/ColorsLarge@2x.png: Added.
1304         * UserInterface/Images/gtk/Database.png: Added.
1305         * UserInterface/Images/gtk/Database@2x.png: Added.
1306         * UserInterface/Images/gtk/DatabaseTable.png: Added.
1307         * UserInterface/Images/gtk/DatabaseTable@2x.png: Added.
1308         * UserInterface/Images/gtk/HierarchicalNavigationItemChevron.svg: Added.
1309         * UserInterface/Images/gtk/IndeterminateProgressSpinner1.svg: Added.
1310         * UserInterface/Images/gtk/IndeterminateProgressSpinner10.svg: Added.
1311         * UserInterface/Images/gtk/IndeterminateProgressSpinner11.svg: Added.
1312         * UserInterface/Images/gtk/IndeterminateProgressSpinner12.svg: Added.
1313         * UserInterface/Images/gtk/IndeterminateProgressSpinner2.svg: Added.
1314         * UserInterface/Images/gtk/IndeterminateProgressSpinner3.svg: Added.
1315         * UserInterface/Images/gtk/IndeterminateProgressSpinner4.svg: Added.
1316         * UserInterface/Images/gtk/IndeterminateProgressSpinner5.svg: Added.
1317         * UserInterface/Images/gtk/IndeterminateProgressSpinner6.svg: Added.
1318         * UserInterface/Images/gtk/IndeterminateProgressSpinner7.svg: Added.
1319         * UserInterface/Images/gtk/IndeterminateProgressSpinner8.svg: Added.
1320         * UserInterface/Images/gtk/IndeterminateProgressSpinner9.svg: Added.
1321         * UserInterface/Images/gtk/Issues.svg: Added.
1322         * UserInterface/Images/gtk/IssuesEnabled.svg: Added.
1323         * UserInterface/Images/gtk/LayerBorders.svg: Added.
1324         * UserInterface/Images/gtk/LessColumns.svg: Added.
1325         * UserInterface/Images/gtk/LocalStorage.png: Added.
1326         * UserInterface/Images/gtk/LocalStorage@2x.png: Added.
1327         * UserInterface/Images/gtk/Locked.svg: Added.
1328         * UserInterface/Images/gtk/Logs.svg: Added.
1329         * UserInterface/Images/gtk/Memory.svg: Added.
1330         * UserInterface/Images/gtk/MoreColumns.svg: Added.
1331         * UserInterface/Images/gtk/Native.svg: Added.
1332         * UserInterface/Images/gtk/NavigationItemAngleBrackets.svg: Added.
1333         * UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg: Added.
1334         * UserInterface/Images/gtk/NavigationItemBug.svg: Added.
1335         * UserInterface/Images/gtk/NavigationItemCurleyBraces.svg: Added.
1336         * UserInterface/Images/gtk/NavigationItemFile.svg: Added.
1337         * UserInterface/Images/gtk/NavigationItemLayers.svg: Added.
1338         * UserInterface/Images/gtk/NavigationItemLog.svg: Added.
1339         * UserInterface/Images/gtk/NavigationItemMagnifyingGlass.svg: Added.
1340         * UserInterface/Images/gtk/NavigationItemStopwatch.svg: Added.
1341         * UserInterface/Images/gtk/NavigationItemStorage.svg: Added.
1342         * UserInterface/Images/gtk/NavigationItemTrash.svg: Added.
1343         * UserInterface/Images/gtk/NavigationItemVariable.svg: Added.
1344         * UserInterface/Images/gtk/Network.png: Added.
1345         * UserInterface/Images/gtk/Network@2x.png: Added.
1346         * UserInterface/Images/gtk/NetworkLarge.png: Added.
1347         * UserInterface/Images/gtk/NetworkLarge@2x.png: Added.
1348         * UserInterface/Images/gtk/Pause.svg: Added.
1349         * UserInterface/Images/gtk/Percent.svg: Added.
1350         * UserInterface/Images/gtk/Plus.svg: Added.
1351         * UserInterface/Images/gtk/PseudoElement.svg: Added.
1352         * UserInterface/Images/gtk/Reflection.svg: Added.
1353         * UserInterface/Images/gtk/Reload.svg: Added.
1354         * UserInterface/Images/gtk/Request.svg: Added.
1355         * UserInterface/Images/gtk/Response.svg: Added.
1356         * UserInterface/Images/gtk/ResultLine.svg: Added.
1357         * UserInterface/Images/gtk/Resume.svg: Added.
1358         * UserInterface/Images/gtk/SessionStorage.png: Added.
1359         * UserInterface/Images/gtk/SessionStorage@2x.png: Added.
1360         * UserInterface/Images/gtk/ShadowDOM.svg: Added.
1361         * UserInterface/Images/gtk/SourceCode.svg: Added.
1362         * UserInterface/Images/gtk/SplitToggleDown.svg: Added.
1363         * UserInterface/Images/gtk/SplitToggleUp.svg: Added.
1364         * UserInterface/Images/gtk/StepInto.svg: Added.
1365         * UserInterface/Images/gtk/StepOut.svg: Added.
1366         * UserInterface/Images/gtk/StepOver.svg: Added.
1367         * UserInterface/Images/gtk/StyleRuleAuthor.svg: Added.
1368         * UserInterface/Images/gtk/StyleRuleInherited.svg: Added.
1369         * UserInterface/Images/gtk/StyleRuleInheritedElement.svg: Added.
1370         * UserInterface/Images/gtk/StyleRuleInspector.svg: Added.
1371         * UserInterface/Images/gtk/StyleRuleUser.svg: Added.
1372         * UserInterface/Images/gtk/StyleRuleUserAgent.svg: Added.
1373         * UserInterface/Images/gtk/Time.svg: Added.
1374         * UserInterface/Images/gtk/TimelineRecordAnimation.svg: Added.
1375         * UserInterface/Images/gtk/TimelineRecordEvent.svg: Added.
1376         * UserInterface/Images/gtk/TimelineRecordLayout.svg: Added.
1377         * UserInterface/Images/gtk/TimelineRecordPaint.svg: Added.
1378         * UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg: Added.
1379         * UserInterface/Images/gtk/TimelineRecordStyle.svg: Added.
1380         * UserInterface/Images/gtk/TimelineRecordTimer.svg: Added.
1381         * UserInterface/Images/gtk/Undock.svg: Added.
1382         * UserInterface/Images/gtk/UserInputPrompt.svg: Added.
1383         * UserInterface/Images/gtk/UserInputPromptPrevious.svg: Added.
1384         * UserInterface/Images/gtk/UserInputResult.svg: Added.
1385         * UserInterface/Images/gtk/Warning.svg: Added.
1386         * UserInterface/Images/gtk/Weight.svg: Added.
1387
1388 2014-09-23  Timothy Hatcher  <timothy@apple.com>
1389
1390         Web Inspector: Remove UserInterface/Images/gtk from Apple builds
1391         https://bugs.webkit.org/show_bug.cgi?id=136955
1392
1393         Reviewed by Joseph Pecoraro.
1394
1395         * Scripts/copy-user-interface-resources.pl:
1396         Remove Images/Legacy and Images/gtk on Mac and Windows builds by looking
1397         at the MAC_OS_X_VERSION_MAJOR and OFFICIAL_BUILD environment vars.
1398
1399 2014-09-21  Saam Barati  <saambarati1@gmail.com>
1400
1401         Web Inspector: fix TypeSet hierarchy in TypeTokenView
1402         https://bugs.webkit.org/show_bug.cgi?id=136982
1403
1404         Reviewed by Joseph Pecoraro.
1405
1406         The protocol object representation of TypeSet was being computed 
1407         incorrectly in JSC::TypeSet. This patch fixes that problem
1408         and also asserts that the type information that the Web Inspector
1409         receives is not empty.
1410
1411         * UserInterface/Models/TypeSet.js:
1412         (WebInspector.TypeSet):
1413         * UserInterface/Views/TypeTokenView.js:
1414         (WebInspector.TypeTokenView.prototype._displayTypeName):
1415
1416 2014-09-21  Saam Barati  <saambarati1@gmail.com>
1417
1418         Web Inspector: unlocalized 'many' string in type profiler inline bubble
1419         https://bugs.webkit.org/show_bug.cgi?id=136980
1420
1421         Reviewed by Timothy Hatcher.
1422
1423         Generate the localizable string for the type profiler's "many" inline bubble.
1424
1425         * Localizations/en.lproj/localizedStrings.js:
1426         * UserInterface/Views/TypeTokenView.js:
1427
1428 2014-09-20  Joseph Pecoraro  <pecoraro@apple.com>
1429
1430         Web Inspector: Option+Click on CSS url(...) should jump to resource view
1431         https://bugs.webkit.org/show_bug.cgi?id=136965
1432
1433         Reviewed by Timothy Hatcher.
1434
1435         * UserInterface/Views/CodeMirrorAdditions.js:
1436         When parsing CSS url(...) tokens, the contents of url(...)
1437         are a "string" type, not "atom".
1438
1439 2014-09-19  Daniel Bates  <dabates@apple.com>
1440
1441         Always assume internal SDK when building configuration Production
1442         https://bugs.webkit.org/show_bug.cgi?id=136925
1443         <rdar://problem/18362399>
1444
1445         Reviewed by Dan Bernstein.
1446
1447         * Configurations/DebugRelease.xcconfig: Also move #include of HaveInternalSDK.xcconfig from DebugRelease.xcconfig
1448         to Base.xcconfig so as to be consistent with the format of other Base.xcconfig/DebugRelease.xcconfig files
1449         (e.g. Source/WebCore/Configurations/Base.xcconfig and Source/WebCore/Configurations/DebugRelease.xcconfig).
1450
1451 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1452
1453         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
1454         https://bugs.webkit.org/show_bug.cgi?id=136632
1455
1456         Reviewed by Gustavo Noronha Silva.
1457
1458         Add free icons for the GTK port. These icons are from the GNOME
1459         project, some of them adapted by Andres Gomez for the inspector.
1460         This is only a subset of the icons, since we still don't have a
1461         free replacement for all of them, but at least it makes the
1462         inspector kind of usable.
1463
1464         * UserInterface/Images/gtk/AUTHORS: Added.
1465         * UserInterface/Images/gtk/BackArrow.svg: Added.
1466         * UserInterface/Images/gtk/BreakpointActionAdd.svg: Added.
1467         * UserInterface/Images/gtk/BreakpointActionRemove.svg: Added.
1468         * UserInterface/Images/gtk/BreakpointButton.svg: Added.
1469         * UserInterface/Images/gtk/BreakpointInactiveButton.svg: Added.
1470         * UserInterface/Images/gtk/Breakpoints.svg: Added.
1471         * UserInterface/Images/gtk/COPYING: Added.
1472         * UserInterface/Images/gtk/Close.svg: Added.
1473         * UserInterface/Images/gtk/CloseWhite.svg: Added.
1474         * UserInterface/Images/gtk/ContentFlow.svg: Added.
1475         * UserInterface/Images/gtk/Crosshair.svg: Added.
1476         * UserInterface/Images/gtk/DOMCharacterData.svg: Added.
1477         * UserInterface/Images/gtk/DOMComment.svg: Added.
1478         * UserInterface/Images/gtk/DOMDocument.svg: Added.
1479         * UserInterface/Images/gtk/DOMDocumentType.svg: Added.
1480         * UserInterface/Images/gtk/DOMElement.svg: Added.
1481         * UserInterface/Images/gtk/DOMNode.svg: Added.
1482         * UserInterface/Images/gtk/DOMTextNode.svg: Added.
1483         * UserInterface/Images/gtk/DOMTree.svg: Added.
1484         * UserInterface/Images/gtk/DisclosureTriangleSmallClosed.svg: Added.
1485         * UserInterface/Images/gtk/DisclosureTriangleSmallOpen.svg: Added.
1486         * UserInterface/Images/gtk/DisclosureTriangleTinyClosed.svg: Added.
1487         * UserInterface/Images/gtk/DisclosureTriangleTinyOpen.svg: Added.
1488         * UserInterface/Images/gtk/DockBottom.svg: Added.
1489         * UserInterface/Images/gtk/DockRight.svg: Added.
1490         * UserInterface/Images/gtk/DocumentCSS.png: Added.
1491         * UserInterface/Images/gtk/DocumentCSS@2x.png: Added.
1492         * UserInterface/Images/gtk/DocumentFont.png: Added.
1493         * UserInterface/Images/gtk/DocumentFont@2x.png: Added.
1494         * UserInterface/Images/gtk/DocumentGeneric.png: Added.
1495         * UserInterface/Images/gtk/DocumentGeneric@2x.png: Added.
1496         * UserInterface/Images/gtk/DocumentImage.png: Added.
1497         * UserInterface/Images/gtk/DocumentImage@2x.png: Added.
1498         * UserInterface/Images/gtk/DocumentJS.png: Added.
1499         * UserInterface/Images/gtk/DocumentJS@2x.png: Added.
1500         * UserInterface/Images/gtk/DocumentMarkup.png: Added.
1501         * UserInterface/Images/gtk/DocumentMarkup@2x.png: Added.
1502         * UserInterface/Images/gtk/DownloadArrow.svg: Added.
1503         * UserInterface/Images/gtk/Error.svg: Added.
1504         * UserInterface/Images/gtk/Errors.svg: Added.
1505         * UserInterface/Images/gtk/ErrorsEnabled.svg: Added.
1506         * UserInterface/Images/gtk/EventListener.svg: Added.
1507         * UserInterface/Images/gtk/Exception.svg: Added.
1508         * UserInterface/Images/gtk/FilterFieldGlyph.svg: Added.
1509         * UserInterface/Images/gtk/FolderGeneric.png: Added.
1510         * UserInterface/Images/gtk/FolderGeneric@2x.png: Added.
1511         * UserInterface/Images/gtk/ForwardArrow.svg: Added.
1512         * UserInterface/Images/gtk/Function.svg: Added.
1513         * UserInterface/Images/gtk/GoToArrow.svg: Added.
1514         * UserInterface/Images/gtk/Resources.svg: Added.
1515         * UserInterface/Images/gtk/SortIndicatorDownArrow.svg: Added.
1516         * UserInterface/Images/gtk/SortIndicatorUpArrow.svg: Added.
1517         * UserInterface/Images/gtk/UpDownArrows.svg: Added.
1518
1519 2014-09-17  Joseph Pecoraro  <pecoraro@apple.com>
1520
1521         Web Inspector: Remove unnecessary prefixes in WebInspectorUI CSS
1522         https://bugs.webkit.org/show_bug.cgi?id=136905
1523
1524         Reviewed by Timothy Hatcher.
1525
1526         Removed vendor prefixes from justify-content and a few lingering
1527         occurances with transition, box-shadow, and display.
1528
1529         * UserInterface/Views/BreakpointActionView.css:
1530         * UserInterface/Views/BreakpointTreeElement.css:
1531         * UserInterface/Views/ButtonNavigationItem.css:
1532         * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
1533         * UserInterface/Views/ControlToolbarItem.css:
1534         * UserInterface/Views/DebuggerDashboardView.css:
1535         * UserInterface/Views/DefaultDashboardView.css:
1536         * UserInterface/Views/FontResourceContentView.css:
1537         * UserInterface/Views/ImageResourceContentView.css:
1538         * UserInterface/Views/LayerTreeSidebarPanel.css:
1539         * UserInterface/Views/Main.css:
1540         * UserInterface/Views/NavigationBar.css:
1541         * UserInterface/Views/NavigationSidebarPanel.css:
1542         * UserInterface/Views/Popover.css:
1543         * UserInterface/Views/ReplayDashboardView.css:
1544         * UserInterface/Views/Toolbar.css:
1545
1546 2014-09-17  Dean Jackson  <dino@apple.com>
1547
1548         WebInpector can use unprefixed flexbox
1549         https://bugs.webkit.org/show_bug.cgi?id=136899
1550
1551         Reviewed by Joseph Pecoraro.
1552
1553         Now the inspector UI itself can use a non-prefixed flexbox. This was
1554         a basic search and replace for the following properties:
1555         - align-content
1556         - align-items
1557         - align-self
1558         - flex-basis
1559         - flex-direction
1560         - flex-wrap
1561         - flex-grow
1562         - flex-shrink
1563         - flex
1564         - flex-flow
1565         - justify
1566
1567         * UserInterface/Views/ButtonToolbarItem.css:
1568         * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
1569         * UserInterface/Views/ContentBrowser.css:
1570         * UserInterface/Views/ControlToolbarItem.css:
1571         * UserInterface/Views/DebuggerDashboardView.css:
1572         * UserInterface/Views/DefaultDashboardView.css:
1573         * UserInterface/Views/FilterBar.css:
1574         * UserInterface/Views/FlexibleSpaceNavigationItem.css:
1575         * UserInterface/Views/FontResourceContentView.css:
1576         * UserInterface/Views/HierarchicalPathComponent.css:
1577         * UserInterface/Views/ImageResourceContentView.css:
1578         * UserInterface/Views/LayerTreeSidebarPanel.css:
1579         * UserInterface/Views/LogContentView.css:
1580         * UserInterface/Views/Main.css:
1581         * UserInterface/Views/NavigationBar.css:
1582         * UserInterface/Views/NavigationSidebarPanel.css:
1583         * UserInterface/Views/Popover.css:
1584         * UserInterface/Views/QuickConsole.css:
1585         * UserInterface/Views/ReplayDashboardView.css:
1586         * UserInterface/Views/ResourceSidebarPanel.css:
1587         * UserInterface/Views/Toolbar.css:
1588
1589 2014-09-16  Dean Jackson  <dino@apple.com>
1590
1591         Add unprefixed flexbox display values and property names/values
1592         https://bugs.webkit.org/show_bug.cgi?id=136880
1593         <rdar://problem/18361137>
1594
1595         Reviewed by Benjamin Poulain with some extra comments by Joseph Pecoraro.
1596
1597         * UserInterface/Models/CSSKeywordCompletions.js: Switch to all the unprefixed
1598         flex properties.
1599
1600 2014-09-16  Joseph Pecoraro  <pecoraro@apple.com>
1601
1602         Web Inspector: Add Versioned Inspector protocol JSON files for iOS 8.0
1603         https://bugs.webkit.org/show_bug.cgi?id=136873
1604
1605         Reviewed by Timothy Hatcher.
1606
1607         * Scripts/update-LegacyInspectorBackendCommands.rb:
1608         * UserInterface/Protocol/Legacy/8.0/InspectorJSBackendCommands.js: Added.
1609         * UserInterface/Protocol/Legacy/8.0/InspectorWebBackendCommands.js: Added.
1610         * Versions/InspectorJS-iOS-8.0.json: Added.
1611         * Versions/InspectorWeb-iOS-8.0.json: Added.
1612
1613 2014-09-16  Joseph Pecoraro  <pecoraro@apple.com>
1614
1615         Web Inspector: Fix ESLint no-extra-bind warnings
1616         https://bugs.webkit.org/show_bug.cgi?id=136659
1617
1618         Reviewed by Timothy Hatcher.
1619
1620         * .eslintrc:
1621         * UserInterface/Controllers/LayerTreeManager.js:
1622         (WebInspector.LayerTreeManager.prototype.layersForNode):
1623
1624 2014-09-15  Matt Baker  <mattbaker@apple.com>
1625
1626         Web Inspector: mouse drifts away from resizer when resizing docked inspector
1627         https://bugs.webkit.org/show_bug.cgi?id=22263
1628
1629         Reviewed by Joseph Pecoraro.
1630
1631         Modified the docked resizer dragging logic to record the initial mouse down position relative to the
1632         resizer client rectangle. Added check while dragging the resizer to ensure that the cursor is positioned
1633         correctly with respect to the resize direction before updating the attached window dimension.
1634
1635         * UserInterface/Base/Main.js:
1636         (WebInspector._dockedResizerMouseDown.dockedResizerDrag):
1637
1638 2014-09-11  Joseph Pecoraro  <pecoraro@apple.com>
1639
1640         Web Inspector: Fix assert in QuickConsole - main frame execution context path component
1641         https://bugs.webkit.org/show_bug.cgi?id=136748
1642
1643         Reviewed by Timothy Hatcher.
1644
1645         This can get called for the MainFrame on page navigations.
1646         In such cases we can return a better result from this method.
1647
1648         * UserInterface/Views/QuickConsole.js:
1649         (WebInspector.QuickConsole.prototype._insertExecutionContextPathComponentForFrame):
1650
1651 2014-09-11  Joseph Pecoraro  <pecoraro@apple.com>
1652
1653         Web Inspector: Hide DOM search result highlights when find banner is not showing
1654         https://bugs.webkit.org/show_bug.cgi?id=136749
1655
1656         Reviewed by Timothy Hatcher.
1657
1658         Match search highlights in TextEditor by only showing the highlight
1659         when the find banner is showing.
1660
1661         * UserInterface/Views/DOMTreeOutline.css:
1662         (.showing-find-banner .dom-tree-outline .search-result):
1663         (.dom-tree-outline .search-highlight): Deleted.
1664
1665 2014-09-11  Joseph Pecoraro  <pecoraro@apple.com>
1666
1667         Web Inspector: DOM Tree search highlights are not appearing
1668         https://bugs.webkit.org/show_bug.cgi?id=136662
1669
1670         Reviewed by Timothy Hatcher.
1671
1672         When performing a search within the DOMTreeContentView all
1673         search results should immediately highlight. When moving
1674         between search results, emphasize the current with a bouncy.
1675         Remember to remove the highlights when the search is changed
1676         or cleared.
1677
1678         * UserInterface/Views/DOMTreeContentView.js:
1679         (WebInspector.DOMTreeContentView.prototype.performSearch.searchResultsReady):
1680         (WebInspector.DOMTreeContentView.prototype.searchCleared):
1681         Shor or hide highlights when searches change.
1682
1683         (WebInspector.DOMTreeContentView.prototype.revealResult):
1684         (WebInspector.DOMTreeContentView.prototype._revealSearchResult):
1685         Emphasize the highlight when moving to a new current result.
1686
1687         (WebInspector.DOMTreeContentView.prototype._showSearchHighlights):
1688         (WebInspector.DOMTreeContentView.prototype._hideSearchHighlights):
1689         On each affected DOMTreeElement show or hide search highlights.
1690
1691         * UserInterface/Views/DOMTreeElement.js:
1692         (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight.animationEnded):
1693         (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight):
1694         Give a brief bouncy-highlight when told to emphasize the search highlight.
1695
1696         (WebInspector.DOMTreeElement.prototype.updateTitle):
1697         Remove unused and unnecessary style class on each row.
1698
1699         (WebInspector.DOMTreeElement.prototype._highlightSearchResults):
1700         Update the stale code to use new function names and accessors.
1701
1702         * UserInterface/Views/DOMTreeOutline.css:
1703         (.dom-tree-outline .search-highlight):
1704         Styles for the search highlight match search highlights in the sidebar.
1705
1706         * UserInterface/Views/Main.css:
1707         (.bouncy-highlight):
1708         * UserInterface/Views/TextEditor.css:
1709         Move bouncy-highlight to Main.css.
1710
1711 2014-09-10  Saam Barati  <saambarati1@gmail.com>
1712
1713         Web Inspector: Modify the type profiler runtime protocol to transfer some computation into the WebInspector
1714         https://bugs.webkit.org/show_bug.cgi?id=136500
1715
1716         Reviewed by Joseph Pecoraro.
1717
1718         This patch maintains the same UI in the Web Inspector for displaying
1719         type information, but now accounts for the new protocol for type profiling.
1720         
1721         The Inspector now has a TypeSet class that wraps the TypeDescription 
1722         protocol object and creates a simple interface for asking protocol objects 
1723         about their type.
1724
1725         * UserInterface/Controllers/TypeTokenAnnotator.js:
1726         (WebInspector.TypeTokenAnnotator.prototype._insertTypeTokensForEachNode):
1727         * UserInterface/Main.html:
1728         * UserInterface/Models/TypeSet.js: Added.
1729         (WebInspector.TypeSet):
1730         (WebInspector.TypeSet.fromPayload):
1731         (WebInspector.TypeSet.prototype.isContainedIn):
1732         * UserInterface/Views/SourceCodeTextEditor.js:
1733         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation.handler):
1734         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation):
1735         * UserInterface/Views/TypePropertiesSection.js:
1736         (WebInspector.TypePropertiesSection.prototype.onpopulate):
1737         (WebInspector.TypePropertyTreeElement.prototype.onpopulate):
1738         * UserInterface/Views/TypeTokenView.js:
1739         (WebInspector.TypeTokenView.prototype.update):
1740         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
1741         (WebInspector.TypeTokenView.prototype._displayTypeName):
1742
1743 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1744
1745         Web Inspector: Eliminate typeof "undefined" checks
1746         https://bugs.webkit.org/show_bug.cgi?id=136691
1747
1748         Reviewed by Alexey Proskuryakov.
1749
1750         * UserInterface/Base/Main.js:
1751         (WebInspector.linkifyURLAsNode):
1752         (WebInspector.linkifyStringAsFragment):
1753         * UserInterface/Protocol/InspectorBackend.js:
1754         (InspectorBackend.Command.prototype._invokeWithArguments):
1755         * UserInterface/Views/DataGrid.js:
1756         (WebInspector.DataGrid.prototype.get resizeMethod):
1757         * UserInterface/Views/NavigationBar.js:
1758         (WebInspector.NavigationBar.prototype.get minimumWidth):
1759
1760 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1761
1762         Web Inspector: Fix obscure ESLint warnings and skip directories
1763         https://bugs.webkit.org/show_bug.cgi?id=136686
1764
1765         Reviewed by Timothy Hatcher.
1766
1767         * .eslintignore: Added.
1768         Skip directories we do not want ESLint to process.
1769
1770         * .eslintrc:
1771         Add rules we've seen and sort sections.
1772
1773         * UserInterface/Controllers/FormatterContentBuilder.js:
1774         (FormatterContentBuilder.prototype._appendIndent):
1775         * UserInterface/Models/Color.js:
1776         * UserInterface/Models/DOMNodeStyles.js:
1777         (WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
1778         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
1779         * UserInterface/Views/DOMTreeDataGridNode.js:
1780         * UserInterface/Views/DOMTreeElement.js:
1781         (WebInspector.DOMTreeElement.prototype.ondelete):
1782         (WebInspector.DOMTreeElement.prototype._insertInLastAttributePosition):
1783         (WebInspector.DOMTreeElement.prototype._distinctClosingTagElement):
1784         * UserInterface/Views/EditingSupport.js:
1785         (WebInspector.EditingConfig):
1786         * UserInterface/Views/LayerTreeDataGridNode.js:
1787         (WebInspector.LayerTreeDataGridNode.prototype._makeOutlet):
1788         * UserInterface/Views/TreeOutline.js:
1789         (TreeOutline.prototype.appendChild):
1790         (TreeOutline.prototype.insertChild):
1791         (TreeOutline.prototype.removeChildAtIndex):
1792         (TreeOutline.prototype.removeChild):
1793         (TreeElement.prototype.expandRecursively):
1794         Fix linter issues.
1795
1796 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1797
1798         Web Inspector: Fix ESLint consistent-return warnings
1799         https://bugs.webkit.org/show_bug.cgi?id=136682
1800
1801         Reviewed by Timothy Hatcher.
1802
1803         * .eslintrc:
1804         * UserInterface/Controllers/BranchManager.js:
1805         (WebInspector.BranchManager.prototype.createBranch):
1806         * UserInterface/Controllers/FrameResourceManager.js:
1807         (WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):
1808         * UserInterface/Models/DOMNodeStyles.js:
1809         (WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
1810         * UserInterface/Views/BoxModelDetailsSectionRow.js:
1811         (WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput):
1812         * UserInterface/Views/DOMTreeElement.js:
1813         (WebInspector.DOMTreeElement.prototype.showChild):
1814         (WebInspector.DOMTreeElement.prototype._startEditingTarget):
1815         (WebInspector.DOMTreeElement.prototype._startEditing):
1816         * UserInterface/Views/EditingSupport.js:
1817         * UserInterface/Views/EventListenerSectionGroup.js:
1818         (WebInspector.EventListenerSectionGroup.prototype._nodeTextOrLink):
1819         * UserInterface/Views/FrameContentView.js:
1820         (WebInspector.FrameContentView.prototype._showContentViewForIdentifier):
1821         * UserInterface/Views/NavigationBar.js:
1822         (WebInspector.NavigationBar.prototype.insertNavigationItem):
1823         (WebInspector.NavigationBar.prototype.removeNavigationItem):
1824         * UserInterface/Views/QuickConsole.js:
1825         (WebInspector.QuickConsole.prototype._insertExecutionContextPathComponentForFrame):
1826         * UserInterface/Views/Sidebar.js:
1827         (WebInspector.Sidebar.prototype.addSidebarPanel):
1828         (WebInspector.Sidebar.prototype.removeSidebarPanel):
1829         * UserInterface/Views/TextEditor.js:
1830         (WebInspector.TextEditor.prototype.addStyleClassToLine):
1831         (WebInspector.TextEditor.prototype.removeStyleClassFromLine):
1832         (WebInspector.TextEditor.prototype.toggleStyleClassForLine):
1833
1834 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1835
1836         Web Inspector: Fix ESLint no-undef warnings
1837         https://bugs.webkit.org/show_bug.cgi?id=136660
1838
1839         Reviewed by Timothy Hatcher.
1840
1841         * UserInterface/Models/DOMSearchMatchObject.js:
1842         (WebInspector.DOMSearchMatchObject.prototype._generateClassName):
1843         (WebInspector.DOMSearchMatchObject.titleForDOMNode):
1844         * UserInterface/Models/Gradient.js:
1845         (WebInspector.Gradient.fromString):
1846         * UserInterface/Views/CodeMirrorAdditions.js:
1847         * UserInterface/Views/ReplayDashboardView.js:
1848         (WebInspector.ReplayDashboardView):
1849
1850 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1851
1852         Web Inspector: Remove unused Console search highlight methods
1853         https://bugs.webkit.org/show_bug.cgi?id=136661
1854
1855         Reviewed by Timothy Hatcher.
1856
1857         ESLint's no-undef warning complained about some undefined references
1858         in these functions that would have thrown exceptions. Turns out this
1859         code is unused, and we do highlighting in the console separately.
1860
1861         * UserInterface/Views/ConsoleCommand.js:
1862         (WebInspector.ConsoleCommand.prototype.clearHighlight): Deleted.
1863         (WebInspector.ConsoleCommand.prototype.highlightSearchResults): Deleted.
1864         (WebInspector.ConsoleCommand.prototype.matchesRegex): Deleted.
1865         * UserInterface/Views/ConsoleMessageImpl.js:
1866         (WebInspector.ConsoleMessageImpl.prototype.clearHighlight): Deleted.
1867         (WebInspector.ConsoleMessageImpl.prototype.highlightSearchResults): Deleted.
1868         (WebInspector.ConsoleMessageImpl.prototype.matchesRegex): Deleted.
1869
1870 2014-09-10  Joseph Pecoraro  <pecoraro@apple.com>
1871
1872         Web Inspector: Fix ESLint* no-avoidable-bind warnings
1873         https://bugs.webkit.org/show_bug.cgi?id=136690
1874
1875         Reviewed by Timothy Hatcher.
1876
1877         * UserInterface/Protocol/RemoteObject.js:
1878         (WebInspector.LocalJSONObject.prototype._children):
1879         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
1880         (WebInspector.CSSStyleDetailsSidebarPanel):
1881         * UserInterface/Views/LayerTreeSidebarPanel.js:
1882         (WebInspector.LayerTreeSidebarPanel.prototype._updateDataGrid):
1883         * UserInterface/Views/LogContentView.js:
1884         (WebInspector.LogContentView.prototype._filterMessages):
1885         * UserInterface/Views/TextResourceContentView.js:
1886         (WebInspector.TextResourceContentView.prototype.get supplementalRepresentedObjects):
1887
1888 2014-09-09  Benjamin Poulain  <bpoulain@apple.com>
1889
1890         Disable the "unreachable-code" warning
1891         https://bugs.webkit.org/show_bug.cgi?id=136677
1892
1893         Reviewed by Darin Adler.
1894
1895         * Configurations/Base.xcconfig:
1896
1897 2014-09-08  Joseph Pecoraro  <pecoraro@apple.com>
1898
1899         Web Inspector: Fix ESLint no-trailing-spaces warnings
1900         https://bugs.webkit.org/show_bug.cgi?id=136657
1901
1902         Reviewed by Andy Estes.
1903
1904         * .eslintrc:
1905         * UserInterface/Base/DOMUtilities.js:
1906         * UserInterface/Base/URLUtilities.js:
1907         (relativePath):
1908         * UserInterface/Base/Utilities.js:
1909         * UserInterface/Controllers/CodeMirrorColorEditingController.js:
1910         (WebInspector.CodeMirrorColorEditingController.prototype._colorPickerColorChanged):
1911         * UserInterface/Controllers/CodeMirrorDragToAdjustNumberController.js:
1912         (WebInspector.CodeMirrorDragToAdjustNumberController.prototype.set enabled):
1913         (WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerCanAdjustObjectAtPoint):
1914         * UserInterface/Controllers/CodeMirrorEditingController.js:
1915         (WebInspector.CodeMirrorEditingController.prototype.handleKeydownEvent):
1916         * UserInterface/Controllers/CodeMirrorGradientEditingController.js:
1917         (WebInspector.CodeMirrorGradientEditingController.prototype.gradientSliderStopWasSelected):
1918         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
1919         (WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
1920         * UserInterface/Controllers/DragToAdjustController.js:
1921         (WebInspector.DragToAdjustController.prototype.set active):
1922         (WebInspector.DragToAdjustController.prototype._setDragging):
1923         (WebInspector.DragToAdjustController.prototype._setTracksMouseClickAndDrag):
1924         * UserInterface/External/Esprima/esprima.js:
1925         * UserInterface/Models/ApplicationCacheFrame.js:
1926         (WebInspector.ApplicationCacheFrame):
1927         * UserInterface/Models/ApplicationCacheManifest.js:
1928         (WebInspector.ApplicationCacheManifest):
1929         (WebInspector.ApplicationCacheManifest.prototype.get manifestURL):
1930         * UserInterface/Models/CookieStorageObject.js:
1931         * UserInterface/Models/DOMSearchMatchObject.js:
1932         (WebInspector.DOMSearchMatchObject.prototype.get title):
1933         (WebInspector.DOMSearchMatchObject.titleForDOMNode):
1934         * UserInterface/Models/DatabaseObject.js:
1935         (WebInspector.DatabaseObject.prototype.getTableNames):
1936         * UserInterface/Models/DatabaseTableObject.js:
1937         (WebInspector.DatabaseTableObject):
1938         * UserInterface/Models/Gradient.js:
1939         (WebInspector.Gradient.fromString):
1940         (WebInspector.RadialGradient.prototype.toString):
1941         * UserInterface/Models/IssueMessage.js:
1942         (WebInspector.IssueMessage.prototype._formatTextIfNecessary):
1943         * UserInterface/Models/Resource.js:
1944         (WebInspector.Resource.prototype.getImageSize.imageDidLoad):
1945         (WebInspector.Resource.prototype.getImageSize):
1946         * UserInterface/Models/Script.js:
1947         (WebInspector.Script.prototype._makeSyntaxTree):
1948         * UserInterface/Models/SourceCodeLocation.js:
1949         (WebInspector.SourceCodeLocation.prototype.hasDifferentDisplayLocation):
1950         * UserInterface/Models/TextMarker.js:
1951         * UserInterface/Protocol/PageObserver.js:
1952         * UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
1953         (WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.set applicationCacheFrame):
1954         (WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.refresh):
1955         (WebInspector.ApplicationCacheDetailsSidebarPanel.prototype._networkStateUpdated):
1956         * UserInterface/Views/ApplicationCacheFrameTreeElement.js:
1957         (WebInspector.ApplicationCacheFrameTreeElement):
1958         * UserInterface/Views/ApplicationCacheManifestTreeElement.js:
1959         (WebInspector.ApplicationCacheManifestTreeElement.prototype.get name):
1960         (WebInspector.ApplicationCacheManifestTreeElement.prototype.get secondaryName):
1961         * UserInterface/Views/ButtonNavigationItem.js:
1962         (WebInspector.ButtonNavigationItem):
1963         * UserInterface/Views/ColorPicker.js:
1964         * UserInterface/Views/ColorWheel.js:
1965         (WebInspector.ColorWheel.prototype._draw):
1966         * UserInterface/Views/CompletionSuggestionsView.js:
1967         (WebInspector.CompletionSuggestionsView.prototype.show):
1968         * UserInterface/Views/ConsoleCommand.js:
1969         * UserInterface/Views/ConsolePrompt.js:
1970         * UserInterface/Views/ContentFlowTreeElement.js:
1971         * UserInterface/Views/CookieStorageTreeElement.js:
1972         (WebInspector.CookieStorageTreeElement):
1973         * UserInterface/Views/EventListenerSectionGroup.js:
1974         (WebInspector.EventListenerSectionGroup.prototype._functionTextOrLink):
1975         * UserInterface/Views/GeneralTreeElementPathComponent.js:
1976         * UserInterface/Views/GoToLineDialog.js:
1977         (WebInspector.GoToLineDialog.prototype._handleKeydownEvent):
1978         * UserInterface/Views/LayerTreeDataGridNode.js:
1979         (WebInspector.LayerTreeDataGridNode.prototype._makeNameCell):
1980         * UserInterface/Views/LayerTreeSidebarPanel.js:
1981         * UserInterface/Views/LogContentView.js:
1982         (WebInspector.LogContentView.prototype._highlightRanges):
1983         * UserInterface/Views/NavigationBar.js:
1984         (WebInspector.NavigationBar):
1985         * UserInterface/Views/NavigationItem.js:
1986         (WebInspector.NavigationItem):
1987         * UserInterface/Views/ResourceDetailsSidebarPanel.js:
1988         (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshImageSizeSection):
1989         * UserInterface/Views/ScopeBar.js:
1990         * UserInterface/Views/ScopeBarItem.js:
1991         (WebInspector.ScopeBarItem):
1992         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
1993         (WebInspector.ScopeChainDetailsSidebarPanel):
1994         * UserInterface/Views/ScriptTimelineDataGridNode.js:
1995         (WebInspector.ScriptTimelineDataGridNode.prototype.updateRangeTimes):
1996         * UserInterface/Views/ScriptTreeElement.js:
1997         (WebInspector.ScriptTreeElement):
1998         * UserInterface/Views/SearchBar.js:
1999         * UserInterface/Views/SearchResultTreeElement.js:
2000         (WebInspector.SearchResultTreeElement.truncateAndHighlightTitle):
2001         * UserInterface/Views/Slider.js:
2002
2003 2014-09-09  Joseph Pecoraro  <pecoraro@apple.com>
2004
2005         Web Inspector: Fix ESLint eqeqeq warnings
2006         https://bugs.webkit.org/show_bug.cgi?id=136658
2007
2008         Reviewed by Andy Estes.
2009
2010         * UserInterface/Controllers/DOMTreeManager.js:
2011         (WebInspector.DOMTreeManager.prototype.mycallback):
2012         (WebInspector.DOMTreeManager.prototype.searchResult):
2013         * UserInterface/Models/Breakpoint.js:
2014         (WebInspector.Breakpoint.prototype.clearActions):
2015         * UserInterface/Models/DOMTree.js:
2016         (WebInspector.DOMTree.prototype._requestRootDOMNode.rootObjectAvailable):
2017         (WebInspector.DOMTree.prototype._requestRootDOMNode.rootDOMNodeAvailable):
2018         (WebInspector.DOMTree.prototype._requestRootDOMNode.dispatchCallbacks):
2019         (WebInspector.DOMTree.prototype._requestRootDOMNode):
2020         * UserInterface/Models/ProbeSet.js:
2021         (WebInspector.ProbeSet.prototype.removeProbe):
2022         * UserInterface/Models/ProbeSetDataTable.js:
2023         (WebInspector.ProbeSetDataTable.prototype.addSampleForProbe):
2024         * UserInterface/Views/CodeMirrorAdditions.js:
2025         * UserInterface/Views/CookieStorageContentView.js:
2026         (WebInspector.CookieStorageContentView.prototype._filterCookies):
2027         (WebInspector.cookieMatchesResourceURL):
2028         * UserInterface/Views/DOMStorageContentView.js:
2029         (WebInspector.DOMStorageContentView.prototype._editingCallback):
2030         * UserInterface/Views/DOMTreeElement.js:
2031         (WebInspector.DOMTreeElement):
2032         (WebInspector.DOMTreeElement.prototype._updateChildren):
2033         (WebInspector.DOMTreeElement.prototype._startEditingTarget):
2034         (WebInspector.DOMTreeElement.prototype._textNodeEditingCommitted):
2035         * UserInterface/Views/DataGrid.js:
2036         (WebInspector.DataGrid.prototype._resizerDragging):
2037         * UserInterface/Views/DatabaseContentView.js:
2038         (WebInspector.DatabaseContentView.prototype._queryError):
2039         * UserInterface/Views/DetailsSectionSimpleRow.js:
2040         (.valueElementClicked):
2041         (WebInspector.DetailsSectionSimpleRow):
2042         * UserInterface/Views/Slider.js:
2043         (WebInspector.Slider.prototype.get _maxX):
2044         * UserInterface/Views/TreeOutline.js:
2045         (TreeElement.prototype.expand):
2046
2047 2014-09-09  Jono Wells  <jonowells@apple.com>
2048
2049         Web Inspector: Fix ESLint no-extra-semi
2050         https://bugs.webkit.org/show_bug.cgi?id=136666
2051
2052         Reviewed by Andy Estes.
2053
2054         Add explicit no-extra-semi rule to .eslintrc. Remove all unnecessary
2055         semicolons as identified by ESLint.
2056
2057         * .eslintrc:
2058         * Tools/PrettyPrinting/Formatter.js:
2059         (Formatter):
2060         * UserInterface/Controllers/Formatter.js:
2061         (Formatter):
2062         * UserInterface/Models/Resource.js:
2063         (WebInspector.Resource.prototype.getImageSize.imageDidLoad):
2064         (WebInspector.Resource.prototype.getImageSize):
2065         * UserInterface/Views/LayerTreeSidebarPanel.js:
2066         (WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid.comparator):
2067         (WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid):
2068         * UserInterface/Views/ObjectPropertiesSection.js:
2069         (WebInspector.ObjectPropertyTreeElement.prototype.callback):
2070         (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
2071
2072 2014-09-09  Jono Wells  <jonowells@apple.com>
2073
2074         Web Inspector: Fix ESLint semi (missing semicolon)
2075         https://bugs.webkit.org/show_bug.cgi?id=136665
2076
2077         Reviewed by Andy Estes.
2078
2079         Add missing semicolons as identified by ESLint. Add explicit semi rule to .eslintrc.
2080
2081         * .eslintrc:
2082         * Tools/PrettyPrinting/FormatterContentBuilder.js:
2083         * Tools/PrettyPrinting/FormatterDebug.js:
2084         (Formatter.prototype.debug):
2085         * UserInterface/Base/DOMUtilities.js:
2086         * UserInterface/Base/EventListener.js:
2087         (WebInspector.EventListener):
2088         (WebInspector.EventListener.prototype.this._callback):
2089         (WebInspector.EventListener.prototype.connect):
2090         * UserInterface/Base/Object.js:
2091         (WebInspector.Object):
2092         (WebInspector.Object.addConstructorFunctions):
2093         (WebInspector.Event):
2094         * UserInterface/Base/URLUtilities.js:
2095         (WebInspector.displayNameForURL):
2096         (WebInspector.displayNameForHost):
2097         * UserInterface/Base/Utilities.js:
2098         (.):
2099         * UserInterface/Controllers/BranchManager.js:
2100         (WebInspector.BranchManager):
2101         * UserInterface/Controllers/CSSStyleManager.js:
2102         (WebInspector.CSSStyleManager):
2103         * UserInterface/Controllers/CodeMirrorColorEditingController.js:
2104         (WebInspector.CodeMirrorColorEditingController):
2105         * UserInterface/Controllers/CodeMirrorEditingController.js:
2106         (WebInspector.CodeMirrorEditingController):
2107         * UserInterface/Controllers/CodeMirrorGradientEditingController.js:
2108         (WebInspector.CodeMirrorGradientEditingController):
2109         (WebInspector.CodeMirrorGradientEditingController.prototype.popoverDidPresent):
2110         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
2111         * UserInterface/Controllers/FormatterContentBuilder.js:
2112         * UserInterface/Controllers/FormatterSourceMap.js:
2113         (WebInspector.FormatterSourceMap.fromBuilder):
2114         * UserInterface/Controllers/IssueManager.js:
2115         (WebInspector.IssueManager):
2116         * UserInterface/Controllers/LogManager.js:
2117         (WebInspector.LogManager):
2118         * UserInterface/Models/BreakpointAction.js:
2119         * UserInterface/Models/CSSCompletions.js:
2120         (WebInspector.CSSCompletions):
2121         (WebInspector.CSSCompletions.requestCSSNameCompletions):
2122         * UserInterface/Models/CSSKeywordCompletions.js:
2123         (WebInspector.CSSKeywordCompletions.forProperty):
2124         (WebInspector.CSSKeywordCompletions.isColorAwareProperty):
2125         * UserInterface/Models/CSSStyleSheet.js:
2126         (WebInspector.CSSStyleSheet.resetUniqueDisplayNameNumbers):
2127         * UserInterface/Models/Color.js:
2128         (WebInspector.Color):
2129         (WebInspector.Color.fromString):
2130         * UserInterface/Models/DOMNode.js:
2131         (WebInspector.DOMNode):
2132         * UserInterface/Models/DOMSearchMatchObject.js:
2133         (WebInspector.DOMSearchMatchObject.titleForDOMNode):
2134         * UserInterface/Models/ExecutionContext.js:
2135         (WebInspector.ExecutionContext.supported):
2136         * UserInterface/Models/Gradient.js:
2137         (WebInspector.LinearGradient):
2138         (WebInspector.LinearGradient.linearGradientWithComponents):
2139         (WebInspector.RadialGradient):
2140         (WebInspector.RadialGradient.radialGradientWithComponents):
2141         * UserInterface/Models/IssueMessage.js:
2142         (WebInspector.IssueMessage):
2143         * UserInterface/Models/ReplaySessionSegment.js:
2144         (WebInspector.IncompleteSessionSegment):
2145         * UserInterface/Models/Resource.js:
2146         (WebInspector.Resource.prototype.associateWithScript):
2147         * UserInterface/Models/Script.js:
2148         (WebInspector.Script.resetUniqueDisplayNameNumbers):
2149         * UserInterface/Models/Setting.js:
2150         (WebInspector.Setting):
2151         * UserInterface/Models/SourceCodePosition.js:
2152         (WebInspector.SourceCodePosition):
2153         * UserInterface/Models/SourceMap.js:
2154         (WebInspector.SourceMap):
2155         (WebInspector.SourceMap.StringCharIterator):
2156         * UserInterface/Models/TextMarker.js:
2157         (WebInspector.TextMarker):
2158         * UserInterface/Models/TextRange.js:
2159         (WebInspector.TextRange):
2160         * UserInterface/Protocol/InspectorFrontendHostStub.js:
2161         (.WebInspector.InspectorFrontendHostStub):
2162         * UserInterface/Protocol/MessageDispatcher.js:
2163         (WebInspector.dispatchNextQueuedMessageFromBackend):
2164         (WebInspector.dispatchMessageFromBackend):
2165         * UserInterface/Protocol/RemoteObject.js:
2166         (WebInspector.RemoteObject):
2167         (WebInspector.RemoteObject.fromPrimitiveValue):
2168         (WebInspector.RemoteObject.fromLocalObject):
2169         (WebInspector.RemoteObject.resolveNode):
2170         (WebInspector.RemoteObject.fromPayload):
2171         (WebInspector.RemoteObject.type):
2172         (WebInspector.RemoteObjectProperty):
2173         (WebInspector.RemoteObjectProperty.fromPrimitiveValue):
2174         (WebInspector.LocalJSONObject):
2175         * UserInterface/Protocol/ReplayObserver.js:
2176         (WebInspector.ReplayPosition.fromProtocol):
2177         * UserInterface/Views/BreakpointActionView.js:
2178         (WebInspector.BreakpointActionView.displayStringForType):
2179         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
2180         (WebInspector.CSSStyleDeclarationTextEditor.prototype.if):
2181         * UserInterface/Views/ClusterContentView.js:
2182         (WebInspector.ClusterContentView.prototype.goBack):
2183         (WebInspector.ClusterContentView.prototype.goForward):
2184         * UserInterface/Views/CodeMirrorAdditions.js:
2185         * UserInterface/Views/ColorWheel.js:
2186         (WebInspector.ColorWheel):
2187         * UserInterface/Views/ConsoleMessage.js:
2188         (WebInspector.ConsoleMessage):
2189         (WebInspector.ConsoleMessage.create):
2190         * UserInterface/Views/ConsoleMessageImpl.js:
2191         (WebInspector.ConsoleMessageImpl):
2192         * UserInterface/Views/ContextMenu.js:
2193         (WebInspector.ContextMenuItem):
2194         (WebInspector.ContextSubMenuItem):
2195         (WebInspector.ContextMenu):
2196         (WebInspector.ContextMenu.Provider):
2197         (WebInspector.ContextMenu.registerProvider):
2198         (WebInspector.contextMenuItemSelected):
2199         (WebInspector.contextMenuCleared):
2200         * UserInterface/Views/DOMTreeElement.js:
2201         (WebInspector.DOMTreeElement):
2202         * UserInterface/Views/DOMTreeOutline.js:
2203         (WebInspector.DOMTreeOutline):
2204         * UserInterface/Views/DOMTreeUpdater.js:
2205         (WebInspector.DOMTreeUpdater):
2206         * UserInterface/Views/DatabaseContentView.js:
2207         (WebInspector.DatabaseContentView):
2208         * UserInterface/Views/EditingSupport.js:
2209         (WebInspector.isBeingEdited):
2210         (WebInspector.markBeingEdited):
2211         (WebInspector.isEditingAnyField):
2212         (WebInspector.isEventTargetAnEditableField):
2213         (WebInspector.EditingConfig):
2214         (WebInspector.startEditing):
2215         * UserInterface/Views/EventListenerSection.js:
2216         (WebInspector.EventListenerSection):
2217         * UserInterface/Views/EventListenerSectionGroup.js:
2218         (WebInspector.EventListenerSectionGroup):
2219         * UserInterface/Views/FindBanner.js:
2220         * UserInterface/Views/GeneralTreeElement.js:
2221         (WebInspector.GeneralTreeElement):
2222         * UserInterface/Views/GoToLineDialog.js:
2223         (WebInspector.GoToLineDialog):
2224         * UserInterface/Views/IndeterminateProgressSpinner.js:
2225         (WebInspector.IndeterminateProgressSpinner):
2226         * UserInterface/Views/LayoutTimelineDataGrid.js:
2227         (WebInspector.LayoutTimelineDataGrid):
2228         * UserInterface/Views/LogContentView.js:
2229         (WebInspector.LogContentView):
2230         * UserInterface/Views/NavigationItem.js:
2231         * UserInterface/Views/ObjectPropertiesSection.js:
2232         (WebInspector.ObjectPropertiesSection):
2233         (WebInspector.ObjectPropertiesSection.CompareProperties):
2234         (WebInspector.ObjectPropertyTreeElement):
2235         * UserInterface/Views/ProbeSetDetailsSection.js:
2236         * UserInterface/Views/PropertiesSection.js:
2237         (WebInspector.PropertiesSection):
2238         * UserInterface/Views/ResourceTreeElement.js:
2239         (WebInspector.ResourceTreeElement.compareResourceTreeElements):
2240         (WebInspector.ResourceTreeElement.compareFolderAndResourceTreeElements):
2241         * UserInterface/Views/ScriptTimelineDataGrid.js:
2242         (WebInspector.ScriptTimelineDataGrid):
2243         * UserInterface/Views/SearchResultTreeElement.js:
2244         (WebInspector.SearchResultTreeElement.truncateAndHighlightTitle):
2245         * UserInterface/Views/TimelineRuler.js:
2246         (WebInspector.TimelineRuler):
2247         (WebInspector.TimelineRuler.prototype.get allowsClippedLabels):
2248         (WebInspector.TimelineRuler.prototype._handleMouseUp):
2249         * UserInterface/Views/Toolbar.js:
2250         * UserInterface/Views/TreeOutline.js:
2251         (TreeOutline.prototype.appendChild):
2252         (TreeOutline.prototype.insertChild):
2253         (TreeOutline.prototype.removeChildAtIndex):
2254         (TreeOutline.prototype.removeChild):
2255         (TreeOutline.prototype.removeChildren):
2256         (TreeOutline.prototype.removeChildrenRecursive):
2257         (TreeOutline.prototype._rememberTreeElement):
2258         (TreeOutline.prototype._forgetTreeElement):
2259         (TreeOutline.prototype._forgetChildrenRecursive):
2260         (TreeOutline.prototype.getCachedTreeElement):
2261         (TreeOutline.prototype.findTreeElement):
2262         (TreeOutline.prototype._treeElementDidChange):
2263         (TreeOutline.prototype.treeElementFromPoint):
2264         (TreeOutline.prototype._treeKeyDown):
2265         (TreeOutline.prototype.expand):
2266         (TreeOutline.prototype.collapse):
2267         (TreeOutline.prototype.revealed):
2268         (TreeOutline.prototype.reveal):
2269         (TreeOutline.prototype.select):
2270         (TreeOutline.prototype.revealAndSelect):
2271         (TreeElement.prototype._attach):
2272         (TreeElement.prototype._detach):
2273         (TreeElement.treeElementMouseDown):
2274         (TreeElement.treeElementToggled):
2275         (TreeElement.treeElementDoubleClicked):
2276         (TreeElement.prototype.collapse):
2277         (TreeElement.prototype.collapseRecursively):
2278         (TreeElement.prototype.expand):
2279         (TreeElement.prototype.expandRecursively):
2280         (TreeElement.prototype.hasAncestor):
2281         (TreeElement.prototype.reveal):
2282         (TreeElement.prototype.revealed):
2283         (TreeElement.prototype.selectOnMouseDown):
2284         (TreeElement.prototype.select):
2285         (TreeElement.prototype.revealAndSelect):
2286         (TreeElement.prototype.deselect):
2287         (TreeElement.prototype.onpopulate):
2288         (TreeElement.prototype.traverseNextTreeElement):
2289         (TreeElement.prototype.traversePreviousTreeElement):
2290         (TreeElement.prototype.isEventWithinDisclosureTriangle):
2291         * UserInterface/Views/TreeOutlineDataGridSynchronizer.js:
2292         (WebInspector.TreeOutlineDataGridSynchronizer):
2293
2294 2014-09-08  Joseph Pecoraro  <pecoraro@apple.com>
2295
2296         Web Inspector: Inspector frequently restores wrong view when opened (often Timelines instead of Resource)
2297         https://bugs.webkit.org/show_bug.cgi?id=135965
2298
2299         Reviewed by Timothy Hatcher.
2300
2301         There were numerous subtle race conditions in state restoration.
2302         This patch intends to fix a number of them to get what feels
2303         like sane behavior for selected sidebar state restoration.
2304
2305         1. Starting a Timeline recording no longer automatically switches to the TimelineContentView.
2306         This was making every reload switch to Timelines. If you had
2307         a resource selected (e.g. the DOM Tree) we should go back
2308         to showing the DOM tree.
2309
2310         2. Background sidebars should not reveal and select tree elements.
2311         This was making resources get selected in Timelines when reloading the page
2312         because the background Resources sidebar was restoring selection of the resource.
2313         That is an unexpected selection and breaks the experience of Timelines.
2314
2315         3. ContentView changes during page navigation / reload should not be saved, and improve Resource restoration.
2316         If a TimelineContentView was in the ContentBrowser back/forward history,
2317         a reload with a resource selected in the Resources sidebar would end up
2318         showing the Timelines sidebar. This was because when ContentViews are
2319         closed during the navigation, the ContentBrowser would fall back to the
2320         remaining TimelineContentView and switch to its only allowed sidebar
2321         (Timelines). ResourceSidebarPanel, knowing a resource was selected,
2322         would select the MainFrame intending to stay in the Resource sidebar,
2323         but the resource is okay with showing in any sidebar, so we stay on Timelines.
2324
2325         4. Resource sidebar state restoration should propertly restore selection.
2326         On reload, state restoration would know the resource to re-select in the
2327         Resources sidebar. As ResourceTreeElements are added to the sidebar
2328         they are checked against the state restoration cookie. If they match,
2329         they would select the element and delete the cookie. Unfortunately,
2330         if this was the first TreeElement child being added to a FrameTreeElement,
2331         the FrameTreeElement onpopulate would remove all children and re-add
2332         them in a unique way. Unfortunately this means the TreeElement we
2333         selected based on the cookie, immediately got thrown away and recreated,
2334         and we no longer reveal and select it. This is a special case for
2335         FrameTreeElements which use the onpopulate SPI. So, instead of starting
2336         processing the new element queue, if this is the first time just trigger
2337         the onpopulate and elements are made just once.
2338
2339         5. Show Error Console triggering early, could have unexpected sidebar behavior.
2340         Opening Web Inspector directly to the console can run before
2341         WebInspector.contentLoaded (DOMContentLoaded). So in that case
2342         WebInspector.showFullHeightConsole was not handling if the contentBrowser
2343         had no content view yet, and the sidebar might be-reopened later on
2344         in contentLoaded based on the setting value.
2345
2346         6. Improve automatic resource selection for sidebars with multiple tree outlines.
2347         Selecting a call frame tree element was unexpectedly changing the
2348         selection to a Resource where the breakpoint was set. This was
2349         because we were only looking at one of potentially many content
2350         tree outlines in the sidebar to see if there was a user action.
2351         
2352         * UserInterface/Base/Main.js:
2353         (WebInspector.contentLoaded):
2354         (WebInspector.showFullHeightConsole):
2355         (WebInspector.toggleConsoleView):
2356         (WebInspector._mainResourceDidChange):
2357         (WebInspector._provisionalLoadStarted):
2358         (WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar):
2359         (WebInspector._updateCookieForInspectorViewState):
2360         (WebInspector._contentBrowserCurrentContentViewDidChange):
2361         * UserInterface/Views/NavigationSidebarPanel.js:
2362         (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
2363         * UserInterface/Views/ResourceSidebarPanel.js:
2364         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange.delayedWork):
2365         (WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange):
2366         * UserInterface/Views/TimelineSidebarPanel.js:
2367         (WebInspector.TimelineSidebarPanel.prototype._recordingLoaded):
2368
2369 2014-09-08  Matt Baker  <mattbaker@apple.com>
2370
2371         Web Inspector: Add layout test for lowercase CSSProperty names
2372         https://bugs.webkit.org/show_bug.cgi?id=135961
2373
2374         Reviewed by Joseph Pecoraro.
2375
2376         Modified test components to support testing CSSStyleManager and related classes:
2377         - Added required models to Test.html
2378         - Added CSSCompletions initialization to Test.js
2379         - CSSCompletions doesn't assume presence of CodeMirror.
2380
2381         * UserInterface/Base/Test.js:
2382         (WebInspector.loaded):
2383         * UserInterface/Models/CSSCompletions.js:
2384         * UserInterface/Test.html:
2385
2386 2014-09-08  Matt Baker  <mattbaker@apple.com>
2387
2388         Web Inspector: Fixes to layout test infrastructure
2389         https://bugs.webkit.org/show_bug.cgi?id=136360
2390
2391         Reviewed by Joseph Pecoraro.
2392
2393         Added missing includes to Test.html, which was breaking tests that
2394         depended on SourceCodeLocation and LazySourceCodeLocation. Also fixed
2395         bug which prevented test results from being resent after reloading the
2396         page under test.
2397
2398         * UserInterface/Base/Test.js:
2399         (InspectorTest.reloadPage):
2400         * UserInterface/Test.html:
2401
2402 2014-09-07  Timothy Hatcher  <timothy@apple.com>
2403
2404         Use a <circle> instead of a <path> in DownloadArrow.svg.
2405         https://bugs.webkit.org/show_bug.cgi?id=136608
2406
2407         Reviewed by Antoine Quint.
2408
2409         * UserInterface/Images/DownloadArrow.svg:
2410         * UserInterface/Views/TreeElementStatusButton.css:
2411         (.item > .status > .status-button > svg .filled):
2412         (body.mac-platform.legacy .item > .status > .status-button > svg .filled):
2413         (:focus .item.selected > .status > .status-button > svg .filled):
2414         (.item > .status > .status-button > svg .stroked):
2415         (body.mac-platform.legacy .item > .status > .status-button > svg .stroked):
2416         (:focus .item.selected > .status > .status-button > svg .stroked):
2417         Tweak CSS selectors to apply to other shapes, not just path.
2418
2419 2014-09-06  Darin Adler  <darin@apple.com>
2420
2421         Make updates suggested by new version of Xcode
2422         https://bugs.webkit.org/show_bug.cgi?id=136603
2423
2424         Reviewed by Mark Rowe.
2425
2426         * Configurations/Base.xcconfig: Added CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
2427         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
2428         CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN__DUPLICATE_METHOD_MATCH, ENABLE_STRICT_OBJC_MSGSEND,
2429         GCC_WARN_UNDECLARED_SELECTOR, and GCC_WARN_UNUSED_FUNCTION as suggested by Xcode update check.
2430         Also removed duplicate GCC_WARN_UNUSED_VARIABLE line.
2431
2432         * WebInspectorUI.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
2433
2434 2014-09-02  Brian J. Burg  <burg@cs.washington.edu>
2435
2436         LegacyProfiler: remove redundant ProfileNode members and other cleanup
2437         https://bugs.webkit.org/show_bug.cgi?id=136380
2438
2439         Reviewed by Timothy Hatcher.
2440
2441         Remove unused Profile.idleTime member.
2442
2443         * UserInterface/Models/Profile.js:
2444         (WebInspector.Profile.prototype.get idleTime): Deleted.
2445         * UserInterface/Models/ScriptTimelineRecord.js:
2446         (WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload):
2447
2448 2014-09-02  Brian J. Burg  <burg@cs.washington.edu>
2449
2450         Web Inspector: remove ProfilerAgent and legacy profiler files in the frontend
2451         https://bugs.webkit.org/show_bug.cgi?id=136462
2452
2453         Reviewed by Timothy Hatcher.
2454
2455         The legacy profiler manager didn't do anything, and its views and models
2456         have been superseded by new views and models based on the Timeline classes.
2457
2458         * .eslintrc:
2459         * UserInterface/Base/Main.js:
2460         (WebInspector.loaded):
2461         (WebInspector.openURL): Remove profile URL handling code.
2462         * UserInterface/Controllers/LegacyProfileManager.js: Removed.
2463         * UserInterface/Main.html:
2464         * UserInterface/Protocol/ConsoleObserver.js:
2465         (WebInspector.ConsoleObserver.prototype.messageAdded):
2466         * UserInterface/Protocol/InspectorFrontendAPI.js:
2467         (InspectorFrontendAPI.isProfilingJavaScript): Deleted.
2468         (InspectorFrontendAPI.startProfilingJavaScript): Deleted.
2469         (InspectorFrontendAPI.stopProfilingJavaScript): Deleted.
2470         * UserInterface/Protocol/LegacyProfilerObserver.js: Removed.
2471         * UserInterface/Views/LegacyBottomUpProfileDataGridTree.js: Removed.
2472         * UserInterface/Views/LegacyJavaScriptProfileObject.js: Removed.
2473         * UserInterface/Views/LegacyJavaScriptProfileType.js: Removed.
2474         * UserInterface/Views/LegacyJavaScriptProfileView.css: Removed.
2475         * UserInterface/Views/LegacyJavaScriptProfileView.js: Removed.
2476         * UserInterface/Views/LegacyProfileDataGridTree.js: Removed.
2477         * UserInterface/Views/LegacyProfileObject.js: Removed.
2478         * UserInterface/Views/LegacyProfileType.js: Removed.
2479         * UserInterface/Views/LegacyProfileView.css: Removed.
2480         * UserInterface/Views/LegacyProfileView.js: Removed.
2481         * UserInterface/Views/LegacyTopDownProfileDataGridTree.js: Removed.
2482
2483 2014-08-29  Saam Barati  <saambarati1@gmail.com>
2484
2485         Web Inspector: Create a UI for displaying JavaScript type information
2486         https://bugs.webkit.org/show_bug.cgi?id=135142
2487
2488         Reviewed by Joseph Pecoraro.
2489
2490         JavaScriptCore now has a type profiler. This patch provides a frontend
2491         user interface for displaying this type information in the Web Inspector.
2492         The user interface works by placing inline "type tokens" next to important
2493         JavaScript expressions: function arguments, function return types, and 
2494         variable declarations. Type information can also be seen for almost every
2495         JavaScipt expression just by hovering over it while viewing a JavaScript file.
2496
2497         Currently, turning on the type profiler is expensive, so the inspector
2498         ensures to never turn on type profiling until the user specifically asks 
2499         for type information to be turned on.
2500
2501         * UserInterface/Base/Main.js:
2502         (WebInspector.loaded):
2503         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
2504         (WebInspector.CodeMirrorTokenTrackingController.prototype._startTracking):
2505         (WebInspector.CodeMirrorTokenTrackingController.prototype._processNewHoveredToken):
2506         Added a new type profiling mode.
2507
2508         * UserInterface/Controllers/FormatterSourceMap.js:
2509         (WebInspector.FormatterSourceMap.prototype.originalToFormatted):
2510         (WebInspector.FormatterSourceMap.prototype.originalPositionToFormatted):
2511         (WebInspector.FormatterSourceMap.prototype.formattedToOriginal):
2512         (WebInspector.FormatterSourceMap.prototype.formattedToOriginalOffset):
2513         * UserInterface/Controllers/TypeTokenAnnotator.js: Added.
2514         (WebInspector.TypeTokenAnnotator):
2515         (WebInspector.TypeTokenAnnotator.prototype.get isActive):
2516         (WebInspector.TypeTokenAnnotator.prototype.get sourceCodeTextEditor):
2517         (WebInspector.TypeTokenAnnotator.prototype.pause):
2518         (WebInspector.TypeTokenAnnotator.prototype.resume):
2519         (WebInspector.TypeTokenAnnotator.prototype.refresh):
2520         (WebInspector.TypeTokenAnnotator.prototype.reset):
2521         (WebInspector.TypeTokenAnnotator.prototype.toggleTypeAnnotations):
2522         (WebInspector.TypeTokenAnnotator.prototype._insertAnnotations.):
2523         (WebInspector.TypeTokenAnnotator.prototype._insertTypeTokensForEachNode):
2524         (WebInspector.TypeTokenAnnotator.prototype._insertToken):
2525         (WebInspector.TypeTokenAnnotator.prototype.isLineTerminator):
2526         (WebInspector.TypeTokenAnnotator.prototype._translateToOffsetAfterFunctionParameterList):
2527         (WebInspector.TypeTokenAnnotator.prototype._clearTimeoutIfNeeded):
2528         This class is responsible for producing the inline "type token" annotations.
2529
2530         * UserInterface/Images/NavigationItemTypes.svg: Added.
2531         * UserInterface/Main.html:
2532         * UserInterface/Models/Script.js:
2533         (WebInspector.Script.prototype.get scriptSyntaxTree):
2534         * UserInterface/Models/ScriptSyntaxTree.js:
2535         (WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement):
2536         (WebInspector.ScriptSyntaxTree.prototype.):
2537         (WebInspector.ScriptSyntaxTree.prototype.updateTypes):
2538         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2539         * UserInterface/Views/ScriptContentView.js:
2540         (WebInspector.ScriptContentView):
2541         (WebInspector.ScriptContentView.prototype.get navigationItems):
2542         (WebInspector.ScriptContentView.prototype._contentDidPopulate):
2543         (WebInspector.ScriptContentView.prototype._toggleTypeAnnotations):
2544         (WebInspector.ScriptContentView.prototype._showJavaScriptTypeInformationSettingChanged):
2545         * UserInterface/Views/SourceCodeTextEditor.js:
2546         (WebInspector.SourceCodeTextEditor):
2547         (WebInspector.SourceCodeTextEditor.prototype.shown):
2548         (WebInspector.SourceCodeTextEditor.prototype.hidden):
2549         (WebInspector.SourceCodeTextEditor.prototype.canShowTypeAnnotations):
2550         (WebInspector.SourceCodeTextEditor.prototype.toggleTypeAnnotations):
2551         (WebInspector.SourceCodeTextEditor.prototype.showPopoverForTypes):
2552         (WebInspector.SourceCodeTextEditor.prototype.prettyPrint):
2553         (WebInspector.SourceCodeTextEditor.prototype._populateWithContent):
2554         (WebInspector.SourceCodeTextEditor.prototype._debuggerDidPause):
2555         (WebInspector.SourceCodeTextEditor.prototype._debuggerDidResume):
2556         (WebInspector.SourceCodeTextEditor.prototype._updateTokenTrackingControllerState):
2557         (WebInspector.SourceCodeTextEditor.prototype.tokenTrackingControllerNewHighlightCandidate):
2558         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation.handler):
2559         (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation):
2560         (WebInspector.SourceCodeTextEditor.prototype._showPopover):
2561         (WebInspector.SourceCodeTextEditor.prototype.editingControllerDidFinishEditing):
2562         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenAnnotator):
2563         (WebInspector.SourceCodeTextEditor.prototype._enableScrollEventsForTypeTokenAnnotator):
2564         (WebInspector.SourceCodeTextEditor.prototype._disableScrollEventsForTypeTokenAnnotator):
2565         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenScrollEventHandler.scrollHandler):
2566         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenScrollEventHandler):
2567         * UserInterface/Views/TextContentView.js:
2568         (WebInspector.TextContentView.prototype.get navigationItems):
2569         * UserInterface/Views/TextEditor.js:
2570         (WebInspector.TextEditor.prototype.set formatted):
2571         (WebInspector.TextEditor.prototype.canShowTypeAnnotations):
2572         (WebInspector.TextEditor.prototype.visibleRangeOffsets):
2573         (WebInspector.TextEditor.prototype.originalOffsetToCurrentPosition):
2574         (WebInspector.TextEditor.prototype.currentOffsetToCurrentPosition):
2575         (WebInspector.TextEditor.prototype.currentPositionToOriginalOffset):
2576         (WebInspector.TextEditor.prototype.currentPositionToCurrentOffset):
2577         (WebInspector.TextEditor.prototype.setInlineWidget):
2578         (WebInspector.TextEditor.prototype.addScrollHandler):
2579         (WebInspector.TextEditor.prototype.removeScrollHandler):
2580         (WebInspector.TextEditor.prototype._scrollIntoViewCentered):
2581         * UserInterface/Views/TextResourceContentView.js:
2582         (WebInspector.TextResourceContentView):
2583         (WebInspector.TextResourceContentView.prototype.get navigationItems):
2584         (WebInspector.TextResourceContentView.prototype._contentDidPopulate):
2585         (WebInspector.TextResourceContentView.prototype._toggleTypeAnnotations):
2586         (WebInspector.TextResourceContentView.prototype._showJavaScriptTypeInformationSettingChanged):
2587         * UserInterface/Views/TypePropertiesSection.js: Added.
2588         (WebInspector.TypePropertiesSection):
2589         (WebInspector.TypePropertiesSection.prototype.onpopulate):
2590         (WebInspector.TypePropertiesSection.PropertyComparator):
2591         (WebInspector.TypePropertyTreeElement):
2592         (WebInspector.TypePropertyTreeElement.prototype.onpopulate):
2593         * UserInterface/Views/TypeTokenView.css: Added.
2594         (.type-token):
2595         (.type-token-left-spacing):
2596         (.type-token-right-spacing):
2597         (.type-token-function, .type-token-boolean):
2598         (.type-token-number):
2599         (.type-token-string):
2600         (.type-token-default):
2601         (.type-token-empty):
2602         (.type-token-many):
2603         * UserInterface/Views/TypeTokenView.js: Added.
2604         (WebInspector.TypeTokenView):
2605         (WebInspector.TypeTokenView.titleForPopover):
2606         (WebInspector.TypeTokenView.prototype.update):
2607         (WebInspector.TypeTokenView.prototype._setUpMouseoverHandlers):
2608         (WebInspector.TypeTokenView.prototype._shouldShowPopover):
2609         The inline "type token" view.
2610
2611 2014-08-29  Saam Barati  <sbarati@apple.com>
2612
2613         Web Inspector: Fix how Popover animates
2614         https://bugs.webkit.org/show_bug.cgi?id=136353
2615
2616         Reviewed by Timothy Hatcher.
2617
2618         Popovers currently don't animate properly because they use 
2619         window.requestAnimationFrame which won't fire its callback 
2620         while the inspector is paused in the debugger. This patches
2621         switches the callback mechanism to setTimeout and also changes
2622         how a Popover's anchor animates to prevent visual glitches.
2623
2624         Popover also has a new function that allows a new target
2625         frame and new content to be set simultaneously and to
2626         animate to show the new content while changing the 
2627         location of the popover frame.
2628
2629         SourceCodeTextEditor uses Popover's new API for animating
2630         between popovers when paused in the debugger. SourceCodeTextEditor 
2631         also now ensures proper balancing of popover tracking event 
2632         listeners.
2633
2634         * UserInterface/Views/Popover.js:
2635         (WebInspector.Popover.prototype.present):
2636         (WebInspector.Popover.prototype.presentNewContentWithFrame):
2637         (WebInspector.Popover.prototype.dismiss):
2638         (WebInspector.Popover.prototype._update):
2639         (WebInspector.Popover.prototype.drawBackground):
2640         (WebInspector.Popover.prototype._animateFrame):
2641         (WebInspector.Popover.prototype._drawFrame):
2642         (WebInspector.Popover.prototype._addListenersIfNeeded):
2643         (WebInspector.Popover.prototype._animateFrame.drawBackground): Deleted.
2644         * UserInterface/Views/SourceCodeTextEditor.js:
2645         (WebInspector.SourceCodeTextEditor.prototype._showPopover):
2646         (WebInspector.SourceCodeTextEditor.prototype._dismissPopover):
2647         (WebInspector.SourceCodeTextEditor.prototype._trackPopoverEvents):
2648
2649 2014-08-28  Saam Barati  <sbarati@apple.com>
2650
2651         Web Inspector: Write tests for ScriptSyntaxTree and fix bugs in the data structure
2652         https://bugs.webkit.org/show_bug.cgi?id=136272
2653
2654         Reviewed by Joseph Pecoraro.
2655
2656         Include the necessary files in Test.html to test ScriptSyntaxTree.
2657         Also, ScriptSyntaxTree had a couple of errors for two of its nodes
2658         where they simply ignored one of the properties on the node.
2659         These errors were found while writing the tests and are fixed
2660         in this patch.
2661
2662         * UserInterface/Models/ScriptSyntaxTree.js:
2663         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2664         * UserInterface/Test.html:
2665
2666 2014-08-27  Saam Barati  <sbarati@apple.com>
2667
2668         Web Inspector: Layout issues for popover on not legacy OS
2669         https://bugs.webkit.org/show_bug.cgi?id=136268
2670
2671         Reviewed by Joseph Pecoraro.
2672
2673         On the latest OS, popovers invade the title bar's space which will
2674         cause layout issues because the title bar will render above
2675         the popover. Fix this by providing some padding for popovers on 
2676         not legacy OSs.
2677
2678         * UserInterface/Views/Popover.js:
2679
2680 2014-08-27  Timothy Hatcher  <timothy@apple.com>
2681
2682         REGRESSION: Web Inspector: Legacy toolbar has two different colors in unfocused windowed mode
2683         https://bugs.webkit.org/show_bug.cgi?id=136289
2684
2685         Reviewed by Darin Adler.
2686
2687         * UserInterface/Views/Toolbar.css:
2688         (body.mac-platform.legacy .toolbar): Override the background-color as transparent. Non-legacy
2689         uses a solid color instead of a gradient for window-inactive.
2690
2691 2014-08-26  Saam Barati  <sbarati@apple.com>
2692
2693         Web Inspector: Fix CodeMirrorTokenTrackingController::_startTracking assertion
2694         https://bugs.webkit.org/show_bug.cgi?id=136160
2695
2696         Reviewed by Joseph Pecoraro.
2697
2698         Check if '_tracking' is already true before calling '_startTracking'
2699         to prevent the assertion from always firing.
2700
2701         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
2702         (WebInspector.CodeMirrorTokenTrackingController.prototype._mouseEntered):
2703
2704 2014-08-25  Brent Fulgham  <bfulgham@apple.com>
2705
2706         [Win] Pass OFFICIAL_BUILD flag to WebInspectorUI build process
2707         https://bugs.webkit.org/show_bug.cgi?id=136229
2708
2709         Reviewed by Dean Jackson.
2710
2711         * WebInspectorUI.vcxproj/WebInspectorUI.make: Pass OFFICIAL_BUILD
2712         flag to build-webinspectorui.pl.
2713         * WebInspectorUI.vcxproj/build-webinspectorui.pl: Accept and use
2714         the OFFICIAL_BUILD flag.
2715
2716 2014-08-24  Benjamin Poulain  <benjamin@webkit.org>
2717
2718         The inspector should not use the "after" pseudo element with the compatibility syntax
2719         https://bugs.webkit.org/show_bug.cgi?id=136204
2720
2721         Reviewed by Darin Adler.
2722
2723         We should only use hte proper pseudo element syntax inside WebKit.
2724
2725         * Tools/PrettyPrinting/codemirror-additions.css:
2726         * Tools/PrettyPrinting/populate/apple.css:
2727
2728 2014-08-24  Brian J. Burg  <burg@cs.washington.edu>
2729
2730         Web Inspector: Rename DOM.RGBA and remove workarounds in the bindings generator
2731         https://bugs.webkit.org/show_bug.cgi?id=136025
2732
2733         Reviewed by Joseph Pecoraro.
2734
2735         Also rename DOM.RGBA in legacy protocol specifications.
2736
2737         * Versions/Inspector-iOS-6.0.json:
2738         * Versions/Inspector-iOS-7.0.json:
2739
2740 2014-08-21  Simon Fraser  <simon.fraser@apple.com>
2741
2742         Add a button to enable paint flashing in the web inspector
2743         https://bugs.webkit.org/show_bug.cgi?id=136133
2744
2745         Reviewed by Tim Hatcher.
2746         
2747         Add a button to the right of the layer borders button to turn on paint flashing.
2748         Future patches will actually enable this feature.
2749
2750         * Localizations/en.lproj/localizedStrings.js: Tooltip strings.
2751         * UserInterface/Images/PaintFlashing.svg: Added. "Paintbrush" icon.
2752         * UserInterface/Views/DOMTreeContentView.js:
2753         (WebInspector.DOMTreeContentView):
2754         (WebInspector.DOMTreeContentView.prototype.get navigationItems):
2755         (WebInspector.DOMTreeContentView.prototype._togglePaintFlashing):
2756
2757 2014-08-20  Saam Barati  <sbarati@apple.com>
2758
2759         Rename HighFidelityTypeProfiling variables for more clarity
2760         https://bugs.webkit.org/show_bug.cgi?id=135899
2761
2762         Reviewed by Geoffrey Garen.
2763
2764         Change a reference in a comment to a JavaScriptCore file to its 
2765         newly renamed variant.
2766
2767         * UserInterface/Models/ScriptSyntaxTree.js:
2768
2769 2014-08-18  Saam Barati  <sbarati@apple.com>
2770
2771         Web Inspector: Introduce an inspector Abstract Syntax Tree.
2772         https://bugs.webkit.org/show_bug.cgi?id=135763
2773
2774         Reviewed by Joseph Pecoraro.
2775
2776         This patch adds an Abstract Syntax Tree to the Web inspector. 
2777         This syntax tree is modeled off the Esprima.js syntax tree
2778         which complies with the Mozilla Parser API:
2779         https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Parser_API
2780         Script is the owner of the Web Inspector syntax tree, and has an API
2781         for accessing its syntax tree property.
2782
2783         * UserInterface/External/Esprima/esprima.js:
2784         * UserInterface/Main.html:
2785         * UserInterface/Models/Script.js:
2786         (WebInspector.Script):
2787         (WebInspector.Script.prototype.requestScriptSyntaxTree.makeSyntaxTreeAndCallCallback):
2788         (WebInspector.Script.prototype._resolveResource):
2789         (WebInspector.Script.prototype._makeSyntaxTree):
2790         * UserInterface/Models/ScriptSyntaxTree.js: Added.
2791         (WebInspector.ScriptSyntaxTree):
2792         (WebInspector.ScriptSyntaxTree.prototype.get parsedSuccessfully):
2793         (WebInspector.ScriptSyntaxTree.prototype.forEachNode):
2794         (WebInspector.ScriptSyntaxTree.prototype.):
2795         (WebInspector.ScriptSyntaxTree.prototype.filter):
2796         (WebInspector.ScriptSyntaxTree.prototype.filterForNodesInRange):
2797         (WebInspector.ScriptSyntaxTree.prototype.filterByRange):
2798         (WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement.removeFunctionsFilter):
2799         (WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement):
2800         (WebInspector.ScriptSyntaxTree.prototype.updateTypes):
2801         (WebInspector.ScriptSyntaxTree.prototype._defaultParserState):
2802         (WebInspector.ScriptSyntaxTree.prototype._recurse):
2803         (WebInspector.ScriptSyntaxTree.prototype._recurseArray):
2804         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2805
2806 2014-08-16  Joseph Pecoraro  <pecoraro@apple.com>
2807
2808         Web Inspector: Improve performance of selection range changes viewing Scripts timeline
2809         https://bugs.webkit.org/show_bug.cgi?id=136015
2810
2811         Reviewed by Timothy Hatcher.
2812
2813         * UserInterface/Base/Utilities.js:
2814         (clamp):
2815         Helper function to clamp a value between a min and max.
2816
2817         * UserInterface/Models/ProfileNode.js:
2818         (WebInspector.ProfileNode.prototype.get startTime):
2819         (WebInspector.ProfileNode.prototype.get endTime):
2820         These can be quickly calculated, so avoid full calculation to grab the values.
2821
2822         * UserInterface/Views/ScriptTimelineView.js:
2823         (WebInspector.ScriptTimelineView.prototype.updateLayout):
2824         Update ranges with a smart helper, instead of blindly doing it and needing refresh.
2825
2826         * UserInterface/Views/ProfileNodeDataGridNode.js:
2827         (WebInspector.ProfileNodeDataGridNode.prototype.get rangeEndTime):
2828         (WebInspector.ProfileNodeDataGridNode.prototype.get data):
2829         (WebInspector.ProfileNodeDataGridNode.prototype.updateRangeTimes):
2830         (WebInspector.ProfileNodeDataGridNode.prototype.set rangeStartTime): Deleted.
2831         (WebInspector.ProfileNodeDataGridNode.prototype.set rangeEndTime): Deleted.
2832         * UserInterface/Views/ScriptTimelineDataGridNode.js:
2833         (WebInspector.ScriptTimelineDataGridNode.prototype.updateRangeTimes):
2834         (WebInspector.ScriptTimelineDataGridNode.prototype.set rangeStartTime): Deleted.
2835         (WebInspector.ScriptTimelineDataGridNode.prototype.set rangeEndTime): Deleted.
2836         When updating the range selection, compare to the last range selection
2837         on this DataGridNode. If the visible portion of this node's time range
2838         changes, we need a refresh. Otherwise, we don't need a refresh.
2839
2840 2014-08-15  Joseph Pecoraro  <pecoraro@apple.com>
2841
2842         Web Inspector: Update Scripts/update-LegacyInspectorBackendCommands.rb for the new generator
2843         https://bugs.webkit.org/show_bug.cgi?id=136006
2844
2845         Reviewed by Timothy Hatcher.
2846
2847         * Scripts/update-LegacyInspectorBackendCommands.rb:
2848         Use the new generator and pass the appropriate flags.
2849
2850         * UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js:
2851         * UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
2852         Newly generated files using the new generator.
2853
2854         * Versions/Inspector-iOS-6.0.json:
2855         Remove unsupported features.
2856
2857 2014-08-15  Joseph Pecoraro  <pecoraro@apple.com>
2858
2859         Web Inspector: Remove forced layouts during recording caused by striped background element resizing
2860         https://bugs.webkit.org/show_bug.cgi?id=136009
2861
2862         Reviewed by Timothy Hatcher.
2863
2864         We used to manually resize and a custom striped background behind
2865         the timeline tree outline content area. This can happen frequently
2866         during timeline recordings causing forced layouts. We can eliminate
2867         the hack and instead put the stripe background on the tree outline.
2868
2869         * UserInterface/Views/TimelineSidebarPanel.js:
2870         (WebInspector.TimelineSidebarPanel.prototype.updateCustomContentOverflow): Deleted.
2871         * UserInterface/Views/TimelineSidebarPanel.css:
2872         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .content .item > .status > .status-button):
2873         (.sidebar > .panel.navigation.timeline > .content > .stripe-background): Deleted.
2874         (.sidebar > .panel.navigation.timeline.timeline-content-view-showing > .content > .stripe-background): Deleted.
2875         Eliminate the striped background element.
2876
2877         * UserInterface/Views/TimelineView.css:
2878         (.panel.navigation.timeline > .content > .navigation-sidebar-panel-content-tree-outline):
2879         (.panel.navigation.timeline.timeline-content-view-showing > .content > .navigation-sidebar-panel-content-tree-outline):
2880         Give the timeline content tree outlines the striped background.
2881
2882         * UserInterface/Views/NavigationSidebarPanel.js:
2883         (WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
2884         (WebInspector.NavigationSidebarPanel.prototype.updateCustomContentOverflow): Deleted.
2885         Remove the now unused updateCustomContentOverflow method.
2886
2887 2014-08-15  Jono Wells  <jonowells@apple.com>
2888
2889         Web Inspector: Inspect Element doesn't always highlight the correct element when inspector is closed before inspecting
2890         https://bugs.webkit.org/show_bug.cgi?id=135995
2891
2892         Reviewed by Joseph Pecoraro.
2893
2894         Change so if an element is inspected via the Inspect Element context menu, selected
2895         node restoration is disallowed until the main resource in the main frame changes.
2896         This way an attempt by a sub-frame will not change the highlighted element in the
2897         Main Frame's DOM tree unexpectedly.
2898
2899         * UserInterface/Controllers/DOMTreeManager.js:
2900         (WebInspector.DOMTreeManager):
2901         (WebInspector.DOMTreeManager.prototype._mainResourceDidChange):
2902         (WebInspector.DOMTreeManager.prototype.inspectElement):
2903
2904 2014-08-15  Brian J. Burg  <burg@cs.washington.edu>
2905
2906         Web Inspector: rewrite CodeGeneratorInspector to be modular and testable
2907         https://bugs.webkit.org/show_bug.cgi?id=131596
2908
2909         Reviewed by Joseph Pecoraro.
2910
2911         Also apply type extraction refactorings to old protocol versions for consistency.
2912
2913         * Versions/Inspector-iOS-6.0.json:
2914         * Versions/Inspector-iOS-7.0.json:
2915
2916 2014-08-15  Timothy Hatcher  <timothy@apple.com>
2917
2918         Web Inspector: Probe details sidebar data grids do not show data
2919         https://bugs.webkit.org/show_bug.cgi?id=135992
2920
2921         Reviewed by Joseph Pecoraro.
2922
2923         * UserInterface/Views/ProbeSetDataGrid.js:
2924         (WebInspector.ProbeSetDataGrid): Make the DataGrid be inline to show the data correctly.
2925
2926 2014-08-15  Timothy Hatcher  <timothy@apple.com>
2927
2928         Web Inspector: Legacy Mac toolbar appearance looks wrong
2929         https://bugs.webkit.org/show_bug.cgi?id=135962
2930
2931         Reviewed by Joseph Pecoraro.
2932
2933         * UserInterface/Views/Toolbar.css:
2934         (body.mac-platform.legacy .toolbar): Don't draw a gradient background when not docked.
2935         Move border-bottom-color from body.mac-platform.legacy.docked .toolbar to here so it
2936         applies all the time as it should have.
2937
2938 2014-08-14  Joseph Pecoraro  <pecoraro@apple.com>
2939
2940         Web Inspector: Dragging Undocked inspector by window title has broken behavior
2941         https://bugs.webkit.org/show_bug.cgi?id=135950
2942
2943         Reviewed by Timothy Hatcher.
2944
2945         * UserInterface/Base/Main.js:
2946         On Mac ports where we the inspector content goes everywhere, window dragging behavior
2947         still exists for the top 22px of the window. So don't do our JavaScript based window
2948         dragging for this special region.
2949
2950         * UserInterface/Models/KeyboardShortcut.js:
2951         (WebInspector.KeyboardShortcut.Modifier.get CommandOrControl):
2952         (WebInspector.KeyboardShortcut.prototype.get displayName):
2953         Instead of calling a host function, use the value already in the frontend.
2954
2955 2014-08-14  Joseph Pecoraro  <pecoraro@apple.com>
2956
2957         Web Inspector: Split console toggle button wrong - Images/Images/SplitToggleUp.svg does not exist
2958         https://bugs.webkit.org/show_bug.cgi?id=135957
2959
2960         Reviewed by Timothy Hatcher.
2961
2962         * UserInterface/Views/LogContentView.js:
2963         (WebInspector.LogContentView):
2964         Wrong image path passed to platformImagePath.
2965
2966 2014-08-14  Joseph Pecoraro  <pecoraro@apple.com>
2967
2968         Web Inspector: Avoid re-binding the same function over and over
2969         https://bugs.webkit.org/show_bug.cgi?id=135949
2970
2971         Reviewed by Timothy Hatcher.
2972
2973         * UserInterface/Controllers/TimelineManager.js:
2974         (WebInspector.TimelineManager.prototype._startAutoCapturing):
2975         (WebInspector.TimelineManager.prototype._stopAutoRecordingSoon):
2976         (WebInspector.TimelineManager.prototype._resetAutoRecordingDeadTimeTimeout):
2977         Stash a bound copy of the function once, and reuse it.
2978
2979 2014-08-14  Joseph Pecoraro  <pecoraro@apple.com>
2980
2981         Web Inspector: Timelines can get caught in requestAnimationFrame loop when not recording
2982         https://bugs.webkit.org/show_bug.cgi?id=135946
2983
2984         Reviewed by Timothy Hatcher.
2985
2986         Each TimelineContentView was listening for the TimelineManager's start/stop
2987         capturing events. However, only the active recording could possibly update.
2988         Likewise, if a pre-existing recording started and stopped we did not properly
2989         stop in the case where we were waiting for an event to update the current time,
2990         which would result in an infinite rAF loop of no updates.
2991
2992         * UserInterface/Models/TimelineRecording.js:
2993         (WebInspector.TimelineRecording.prototype.unloaded):
2994         When a timeline recording is unloaded trigger an event.
2995
2996         * UserInterface/Views/TimelineContentView.js:
2997         (WebInspector.TimelineContentView.prototype._startUpdatingCurrentTime):
2998         Assert we were not already waiting.
2999
3000         (WebInspector.TimelineContentView.prototype._stopUpdatingCurrentTime):
3001         Properly handle the case of starting/stoping an already existing recording
3002         without a new event coming in.
3003
3004         (WebInspector.TimelineContentView.prototype._recordingTimesUpdated):
3005         (WebInspector.TimelineContentView.prototype._recordingReset):
3006         Convert to a boolean instead of deleting state.
3007
3008         (WebInspector.TimelineContentView.prototype._recordingUnloaded):
3009         Stop listening to timeline manager events that no longer affect unloaded recordings.
3010
3011 2014-08-13  Jono Wells  <jonowells@apple.com>
3012
3013         Web Inspector: eslint configuration should be stored as .eslintrc
3014         https://bugs.webkit.org/show_bug.cgi?id=135916
3015
3016         .eslintrc file added to allow for ESLint solutions, within editors and otherwise,
3017         to be automatically configured based on the WebKit JavaScript coding style. The
3018         initial file is incomplete.
3019
3020         Reviewed by Joseph Pecoraro.
3021
3022         * .eslintrc: Added.
3023         * External/.eslintrc: Added.
3024
3025 2014-08-13  Timothy Hatcher  <timothy@apple.com>
3026
3027         Web Inspector: Missing semicolon after console.assert in TimelineSidebarPanel.js
3028         https://bugs.webkit.org/show_bug.cgi?id=135917
3029
3030         Reviewed by Joseph Pecoraro.
3031
3032         * UserInterface/Views/TimelineSidebarPanel.js:
3033
3034 2014-08-13  Joseph Pecoraro  <pecoraro@apple.com>
3035
3036         Web Inspector: Inline DataGrid inside details sidebar has double thick top border with legacy styles
3037         https://bugs.webkit.org/show_bug.cgi?id=135894
3038
3039         Reviewed by Timothy Hatcher.
3040
3041         * UserInterface/Views/DetailsSection.css:
3042         (body.mac-platform.legacy .details-section:not(.collapsed) .data-grid.inline):
3043         In legacy styles the details-section header always has a 1px bottom border.
3044         In all styles, an inline data grid had a 1px border everywhere. So, handle
3045         this specific case by removing the top border of an inline data grid
3046         that is inside an expanded details section.
3047
3048 2014-08-13  Joseph Pecoraro  <pecoraro@apple.com>
3049
3050         Web Inspector: "No Filter Results" view only shows once, does not show again
3051         https://bugs.webkit.org/show_bug.cgi?id=135892
3052
3053         Reviewed by Timothy Hatcher.
3054
3055         * UserInterface/Views/NavigationSidebarPanel.js:
3056         (WebInspector.NavigationSidebarPanel.prototype.showEmptyContentPlaceholder):
3057         We were checking at the wrong level for a parent. Check if the root
3058         placeholder element has a parent or not.
3059
3060 2014-08-13  Joseph Pecoraro  <pecoraro@apple.com>
3061
3062         Web Inspector: Incorrect border colors in event listeners sections in details sidebar
3063         https://bugs.webkit.org/show_bug.cgi?id=135891
3064
3065         Reviewed by Timothy Hatcher.
3066
3067         * UserInterface/Views/DetailsSection.css:
3068         (.details-section .details-section > .header):
3069         (.details-section .details-section:not(.collapsed) > .header):
3070         Remove box-shadow and replace with a bottom border.
3071
3072         (body.mac-platform.legacy .details-section .details-section.collapsed > .header):
3073         (.details-section .details-section.collaspsed > .header): Deleted.
3074         Collapsed was spelled incorrectly so this was not applying properly before.
3075         But correct this for legacy because legacy still uses a box-shadow.
3076
3077 2014-08-13  Joseph Pecoraro  <pecoraro@apple.com>
3078
3079         Web Inspector: Timeline Close buttons can use polish for new and legacy styles
3080         https://bugs.webkit.org/show_bug.cgi?id=135870
3081
3082         Reviewed by Timothy Hatcher.
3083
3084         * UserInterface/Images/Legacy/Close.svg:
3085         Ensure this has fill colors in tree selections.
3086
3087         * UserInterface/Views/TimelineSidebarPanel.css:
3088         (.sidebar > .panel.navigation.timeline > .timelines-content .close-button):
3089         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content .close-button):
3090         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .content .item > .status > .status-button):
3091         Size the close-button for the top overviews differently in new styles (14x14) and legacy (12x12).
3092
3093 2014-08-13  Timothy Hatcher  <timothy@apple.com>
3094
3095         Web Inspector: Workaround a NSWindow change to the title bar.
3096         https://bugs.webkit.org/show_bug.cgi?id=135880
3097
3098         Reviewed by Joseph Pecoraro.
3099
3100         * UserInterface/Base/Main.js:
3101         (WebInspector._updateToolbarHeight): Don't call in legacy mode.
3102
3103         * UserInterface/Views/DashboardContainerView.css:
3104         (.toolbar .dashboard-container):
3105         (.toolbar .dashboard):
3106         Drive-by fix some errant drop-shadows. The transparent border was pushing the inset top
3107         drop shadow down when it shouldn't. Remove duplicate background and shadow.
3108
3109         * UserInterface/Views/Main.css:
3110         (body): Set the background white, never needs to be transparent now.
3111         (body.mac-platform.legacy:not(.docked)): Set background to transparent when not docked in legacy.
3112         (body.docked.bottom): Update border color.
3113         (body.docked.right): Ditto.
3114         (body.docked.bottom.mac-platform.legacy): Keep old border color.
3115         (body.docked.right.mac-platform.legacy): Ditto.
3116
3117         * UserInterface/Views/Toolbar.css:
3118         (.toolbar): Set a default border and background gradient.
3119         (body.window-inactive .toolbar): No gradient but use a solid color when inactive.
3120         (body.mac-platform:not(.legacy):not(.docked) .toolbar): Padding on the top for the title bar.
3121         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical): Account for title bar height.
3122         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical.small-size): Ditto.
3123         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-only): Ditto.
3124         (body.mac-platform:not(.legacy):not(.docked) .toolbar.label-only): Ditto.
3125         (body.mac-platform.legacy .toolbar): No inset shadow in legacy when not docked.
3126         (body.mac-platform.legacy.docked .toolbar): Restore legacy border color.
3127         (body.mac-platform.legacy:not(.docked) .toolbar .item.button > .label): Only disable sub-pixel antialiasing on legacy!
3128         (body.mac-platform.legacy.window-inactive .toolbar): Restore legacy border color.
3129
3130 2014-08-13  Timothy Hatcher  <timothy@apple.com>
3131
3132         Web Inspector: Restore Helvetica as the dashboard font in legacy mode
3133         https://bugs.webkit.org/show_bug.cgi?id=135886
3134
3135         Reviewed by Joseph Pecoraro.
3136
3137         * UserInterface/Views/DefaultDashboardView.css:
3138         (body.mac-platform.legacy .toolbar .dashboard.default > .item):
3139
3140 2014-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3141
3142         Web Inspector: Timeline record content view close button does not work after scrolling, invisible scrollbar
3143         https://bugs.webkit.org/show_bug.cgi?id=135863
3144
3145         Reviewed by Timothy Hatcher.
3146
3147         A workaround is to not have position:relative content inside of
3148         scrollable region. Turns out this was only done in two places,
3149         and I do not see any absolutely positioned content in navigation
3150         sidebar content tree outlines. This also fixes clicking on the
3151         reload button if you've scrolled the Resources sidebar. 
3152
3153         * UserInterface/Views/NavigationSidebarPanel.css:
3154         (.navigation-sidebar-panel-content-tree-outline .children): Deleted.
3155         (.navigation-sidebar-panel-content-tree-outline .item): Deleted.
3156
3157 2014-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3158
3159         Web Inspector: Remove unused variable in Platform.js
3160         https://bugs.webkit.org/show_bug.cgi?id=135869
3161
3162         Reviewed by Timothy Hatcher.
3163
3164         * UserInterface/Base/Platform.js:
3165
3166 2014-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3167
3168         Web Inspector: Timeline selection range creation does not work when clicking event bubble or near bottom of overview
3169         https://bugs.webkit.org/show_bug.cgi?id=135849
3170
3171         Reviewed by Timothy Hatcher.
3172
3173         Click events on elements in the graph container (event bubbles) or
3174         in the scroll container (bottom 16px) were becoming the event targets.
3175         As siblings of the ruler, the dispatch would not go through the ruler.
3176         The ruler was supposed to be overlaying everything in the overview,
3177         so give the ruler a z-index so it really is overlaying elements.
3178
3179         * UserInterface/Views/TimelineRuler.css:
3180         (.timeline-ruler):
3181
3182 2014-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3183
3184         Web Inspector: GoToLine dialog clear text button looks poor
3185         https://bugs.webkit.org/show_bug.cgi?id=135828
3186
3187         Reviewed by Timothy Hatcher.
3188
3189         Legacy/CloseWhite.svg was not used, but in the case where the white
3190         close button is needed the thicker bars looks better. Re-use the
3191         Legacy image as the default CloseWhite.svg.
3192
3193         * UserInterface/Images/CloseWhite.svg:
3194         * UserInterface/Images/Legacy/CloseWhite.svg: Removed.
3195
3196 2014-08-12  Joseph Pecoraro  <pecoraro@apple.com>
3197
3198         Web Inspector: Easier Way to go back to the Timeline Overviews
3199         https://bugs.webkit.org/show_bug.cgi?id=135827
3200
3201         Reviewed by Timothy Hatcher.
3202
3203         * Localizations/en.lproj/localizedStrings.js:
3204         Added new tooltip UIString.
3205
3206         * UserInterface/Images/Close.svg:
3207         * UserInterface/Images/CloseLarge.svg:
3208         * UserInterface/Images/Legacy/Close.svg:
3209         Add "stroked" class so the buttons can fill with white on selected rows.
3210         Also re-center the non-legacy images horizontally.
3211
3212         * UserInterface/Views/GeneralTreeElement.js:
3213         (WebInspector.GeneralTreeElement.prototype.set status):
3214         Do not recreate elements if the status did not change.
3215
3216         * UserInterface/Views/LayoutTimelineView.js:
3217         (WebInspector.LayoutTimelineView):
3218         (WebInspector.LayoutTimelineView.prototype._treeElementDeselected):
3219         (WebInspector.LayoutTimelineView.prototype._treeElementSelected):
3220         (WebInspector.LayoutTimelineView.prototype._updateTreeElementWithCloseButton):
3221         (WebInspector.LayoutTimelineView.prototype._closeStatusButtonClicked):
3222         * UserInterface/Views/NetworkTimelineView.js:
3223         (WebInspector.NetworkTimelineView):
3224         (WebInspector.NetworkTimelineView.prototype._treeElementDeselected):
3225         (WebInspector.NetworkTimelineView.prototype._treeElementSelected):
3226         (WebInspector.NetworkTimelineView.prototype._updateTreeElementWithCloseButton):
3227         (WebInspector.NetworkTimelineView.prototype._closeStatusButtonClicked):
3228         * UserInterface/Views/OverviewTimelineView.js:
3229         (WebInspector.OverviewTimelineView.prototype._treeElementDeselected):
3230         (WebInspector.OverviewTimelineView.prototype._treeElementSelected):
3231         (WebInspector.OverviewTimelineView.prototype._updateTreeElementWithCloseButton):
3232         (WebInspector.OverviewTimelineView.prototype._closeStatusButtonClicked):
3233         * UserInterface/Views/ScriptTimelineView.js:
3234         (WebInspector.ScriptTimelineView):
3235         (WebInspector.ScriptTimelineView.prototype._treeElementDeselected):
3236         (WebInspector.ScriptTimelineView.prototype._treeElementSelected):
3237         (WebInspector.ScriptTimelineView.prototype._updateTreeElementWithCloseButton):
3238         (WebInspector.ScriptTimelineView.prototype._closeStatusButtonClicked):
3239         Provide select/deselect handlers to show/hide the close status bar button
3240         when selecting a row that shows a non-Timeline content view. Currently the
3241         only content views the tree elements can show are Resource views, so the
3242         tooltip is the same everywhere.
3243
3244 2014-08-12  Timothy Hatcher  <timothy@apple.com>
3245
3246         Web Inspector: Expect to see top level JavaScript function profiler details for event handlers in timeline
3247         https://bugs.webkit.org/show_bug.cgi?id=132109
3248
3249         Reviewed by Joseph Pecoraro.
3250
3251         * UserInterface/Views/ScriptTimelineView.js:
3252         (WebInspector.ScriptTimelineView.prototype._processPendingRecords): Don't promote root node children if
3253         there is only one child.
3254
3255 2014-08-11  Brian J. Burg  <burg@cs.washington.edu>
3256
3257         Web Inspector: show a replay dashboard when capturing or replaying
3258         https://bugs.webkit.org/show_bug.cgi?id=135170
3259
3260         Reviewed by Timothy Hatcher.
3261
3262         This patch adds a replay dashboard with record/play/pause buttons. It
3263         is shown automatically when the user starts capturing an execution from
3264         the replay menu in the Timelines sidebar panel.
3265
3266         * UserInterface/Base/Main.js:
3267         (WebInspector.loaded):
3268         (WebInspector._captureDidStart):
3269         * UserInterface/Controllers/DashboardManager.js:
3270         (WebInspector.DashboardManager):
3271         * UserInterface/Images/ReplayPauseButton.svg: Added.
3272         * UserInterface/Images/ReplayPlayButton.svg: Added.
3273         * UserInterface/Images/ReplayRecordingButton.svg: Added.
3274         * UserInterface/Main.html:
3275         * UserInterface/Models/ReplayDashboard.js: Copied from Source/WebInspectorUI/UserInterface/Controllers/DashboardManager.js.
3276         (WebInspector.ReplayDashboard):
3277         * UserInterface/Views/DashboardView.js:
3278         (WebInspector.DashboardView):
3279         * UserInterface/Views/ReplayDashboardView.css: Copied from Source/WebInspectorUI/UserInterface/Controllers/DashboardManager.js.
3280         (.toolbar .dashboard.replay):
3281         (.toolbar .dashboard.replay div.navigation-bar):
3282         (.toolbar .dashboard.replay .item.button > .glyph):
3283         (.toolbar.label-only .dashboard.replay .item.button > .glyph):
3284         * UserInterface/Views/ReplayDashboardView.js: Added.
3285         (WebInspector.ReplayDashboardView):
3286         (WebInspector.ReplayDashboardView.prototype._captureButtonItemClicked):
3287         (WebInspector.ReplayDashboardView.prototype._replayButtonItemClicked):
3288         (WebInspector.ReplayDashboardView.prototype._captureStarted):
3289         (WebInspector.ReplayDashboardView.prototype._captureStopped):
3290         (WebInspector.ReplayDashboardView.prototype._playbackStarted):
3291         (WebInspector.ReplayDashboardView.prototype._playbackPaused):
3292         (WebInspector.ReplayDashboardView.prototype._playbackFinished):
3293
3294 2014-08-08  Brian J. Burg  <burg@cs.washington.edu>
3295
3296         Web Inspector: DebuggerManager commands should return promises
3297         https://bugs.webkit.org/show_bug.cgi?id=135690
3298
3299         Reviewed by Timothy Hatcher.
3300
3301         Convert the existing debugger commands to return promises. This
3302         requires separately waiting for protocol command's promise to be
3303         fulfilled, as well as waiting for the appropriate DebuggerManager
3304         event. If the protocol command promise is rejected, tear down the
3305         single-fire event listener.
3306
3307         * UserInterface/Controllers/DebuggerManager.js:
3308         (WebInspector.DebuggerManager.prototype.pause):
3309         (WebInspector.DebuggerManager.prototype.resume):
3310         (WebInspector.DebuggerManager.prototype.stepOver):
3311         (WebInspector.DebuggerManager.prototype.stepInto):
3312         (WebInspector.DebuggerManager.prototype.stepOut):
3313         * UserInterface/Controllers/ReplayManager.js: Use the promise-based API.
3314         (WebInspector.ReplayManager.prototype._suppressBreakpointsAndResumeIfNeeded):
3315
3316 2014-08-11  Timothy Hatcher  <timothy@apple.com>
3317
3318         Web Inspector: Update folder icons
3319         https://bugs.webkit.org/show_bug.cgi?id=135808
3320
3321         Reviewed by Joseph Pecoraro.
3322
3323         * UserInterface/Images/FolderGeneric.png: Updated.
3324         * UserInterface/Images/FolderGeneric@2x.png: Updated.