Cleaning up formatting on recent additions win TestExpectations file
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2015-10-26  Matt Baker  <mattbaker@apple.com>
2
3         Web Inspector: WebInspector.Object can dispatch constructor-level events multiple times
4         https://bugs.webkit.org/show_bug.cgi?id=150579
5
6         Reviewed by Timothy Hatcher.
7
8         Use `hasOwnProperty` when checking for constructor event listeners when walking the
9         prototype chain. This prevents listeners registered with a base class constructor
10         from being dispatched multiple times by getting picked up higher in the prototype chain.
11
12         * UserInterface/Base/Object.js:
13         (WebInspector.Object.prototype.dispatchEventToListeners.dispatch):
14         (WebInspector.Object.prototype.dispatchEventToListeners):
15         (WebInspector.Object):
16
17 2015-10-26  Matt Baker  <mattbaker@apple.com>
18
19         Web Inspector: Hundreds of failed assertions after switching to Rendering Frames after recording complete
20         https://bugs.webkit.org/show_bug.cgi?id=150568
21
22         Reviewed by Timothy Hatcher.
23
24         When the TimelineRecordingContentView responds to the current content view changing,
25         the TimelineOverview may be swapped out (if switching from a Timelines content view to a
26         Rendering Frames content view). This patch installs a new overview (if it's changing) prior
27         to setting the TimelineSidebarPanel's tree outline, as setting the tree outline forces
28         filters to run.
29
30         Filtering tree elements requires that the timeline overview is up to date, which was the
31         cause the assertion deluge.
32
33         * UserInterface/Views/TimelineRecordingContentView.js:
34         (WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
35
36 2015-10-26  Joseph Pecoraro  <pecoraro@apple.com>
37
38         Web Inspector: Spacebar to start recording should not cause system beep
39         https://bugs.webkit.org/show_bug.cgi?id=150573
40
41         Reviewed by Timothy Hatcher.
42
43         * UserInterface/Views/TimelineSidebarPanel.js:
44         (WebInspector.TimelineSidebarPanel.prototype._toggleRecordingOnSpacebar):
45         (WebInspector.TimelineSidebarPanel.prototype._toggleNewRecordingOnSpacebar):
46         The keyboard shortcuts do not implicitly prevent default because they may bail.
47         So in cases where they do handle the key, prevent default to prevent system beeps.
48
49 2015-10-26  Matt Baker  <mattbaker@apple.com>
50
51         Web Inspector: Cleanup sidebar panels, reduce `delete` and use Maps instead of objects
52         https://bugs.webkit.org/show_bug.cgi?id=150548
53
54         Reviewed by Timothy Hatcher.
55
56         * UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
57         (WebInspector.LayerTreeDetailsSidebarPanel):
58         (WebInspector.LayerTreeDetailsSidebarPanel.prototype._updateDataGrid):
59         (WebInspector.LayerTreeDetailsSidebarPanel.prototype._dataGridNodeForLayer):
60
61         * UserInterface/Views/NavigationSidebarPanel.js:
62         (WebInspector.NavigationSidebarPanel):
63         (WebInspector.NavigationSidebarPanel.restoreStateFromCookie.finalAttemptToRestoreViewStateFromCookie):
64         (WebInspector.NavigationSidebarPanel.restoreStateFromCookie):
65         (WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement):
66         (WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
67         (WebInspector.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie):
68         Switched to using Symbol() to set external properties on tree elements.
69
70         * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
71         (WebInspector.ScopeChainDetailsSidebarPanel.prototype._generateCallFramesSection):
72
73         * UserInterface/Views/StorageSidebarPanel.js:
74         (WebInspector.StorageSidebarPanel):
75         (WebInspector.StorageSidebarPanel.prototype._addDatabase):
76         (WebInspector.StorageSidebarPanel.prototype._addIndexedDatabase):
77         (WebInspector.StorageSidebarPanel.prototype._addFrameManifest):
78         (WebInspector.StorageSidebarPanel.prototype._storageCleared):
79
80 2015-10-24  Nikita Vasilyev  <nvasilyev@apple.com>
81
82         Unreviewed, rolling out r191419.
83         https://bugs.webkit.org/show_bug.cgi?id=150537
84
85         Reverted changeset:
86
87         "Web Inspector: Autocompletion previews in the CSS sidebar do not apply"
88         https://bugs.webkit.org/show_bug.cgi?id=147720
89         http://trac.webkit.org/changeset/191419
90
91 2015-10-23  Joseph Pecoraro  <pecoraro@apple.com>
92
93         Web Inspector: Remove unused ScrollLayer Timeline EventType
94         https://bugs.webkit.org/show_bug.cgi?id=150518
95
96         Reviewed by Timothy Hatcher.
97
98         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
99         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
100         * UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
101         * Versions/Inspector-iOS-7.0.json:
102         * Versions/Inspector-iOS-8.0.json:
103         * Versions/Inspector-iOS-9.0.json:
104
105 2015-10-23  Joseph Pecoraro  <pecoraro@apple.com>
106
107         Web Inspector: xlink:href should be linkified
108         https://bugs.webkit.org/show_bug.cgi?id=150505
109
110         Reviewed by Timothy Hatcher.
111
112         * UserInterface/Base/Main.js:
113         When opening a URL with a fragment, prefer opening a resource
114         that has the same URL without the fragment, otherwise this would
115         open in a new tab.
116
117         * UserInterface/Base/URLUtilities.js:
118         (absoluteURL):
119         Better handling absoluteURL("#frag", baseURL).
120
121         * UserInterface/Views/CodeMirrorAdditions.js:
122         * UserInterface/Views/DOMTreeElement.js:
123         (WebInspector.DOMTreeElement.prototype._buildAttributeDOM):
124         Allow for more "href" style attributes, such as XML namespaced
125         "xlink:href" attribute names.
126
127 2015-10-23  Nikita Vasilyev  <nvasilyev@apple.com>
128
129         Web Inspector: Command-Enter in Debugger should show a popover with evaluation result
130         https://bugs.webkit.org/show_bug.cgi?id=149195
131
132         Currenty, the only way to display the popover is to hover over the text with a mouse cursor.
133         Provide a way to display it via a keyboard shortcut.
134
135         Reviewed by Timothy Hatcher.
136
137         * UserInterface/Controllers/CodeMirrorCompletionController.js:
138         (WebInspector.CodeMirrorCompletionController): Deleted.
139         (WebInspector.CodeMirrorCompletionController.prototype._generateJavaScriptCompletions): Deleted.
140         Don't evaluate selected text from Debugger or Sources in the console.
141
142         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
143         (WebInspector.CodeMirrorTokenTrackingController):
144         (WebInspector.CodeMirrorTokenTrackingController.prototype._handleCommandEnterKey):
145         (WebInspector.CodeMirrorTokenTrackingController.prototype._hidePopover):
146         Cmd-Enter triggers the popover, Esc hides it.
147
148         (WebInspector.CodeMirrorTokenTrackingController.prototype.set mode):
149         (WebInspector.CodeMirrorTokenTrackingController.prototype.removeHighlightedRange):
150         Don't use delete.
151
152         (WebInspector.CodeMirrorTokenTrackingController.prototype._mouseMovedWithMarkedText):
153         When a token isn't hovered, hide it only when it was triggered not by the keyboard.
154
155         (WebInspector.CodeMirrorTokenTrackingController.prototype._markedTextIsNoLongerHovered):
156         Don't use delete.
157
158         (WebInspector.CodeMirrorTokenTrackingController.prototype._updateHoveredTokenInfo):
159         (WebInspector.CodeMirrorTokenTrackingController.prototype._getTokenInfoForPosition):
160         Abstract out a no side effects _getTokenInfoForPosition method, which is also used by _handleCommandEnterKey.
161
162         (WebInspector.CodeMirrorTokenTrackingController.prototype._mouseMovedOutOfEditor):
163         (WebInspector.CodeMirrorTokenTrackingController.prototype._mouseButtonWasReleasedOverEditor):
164         Don't use delete.
165
166         (WebInspector.CodeMirrorTokenTrackingController.prototype._processNewHoveredToken):
167         (WebInspector.CodeMirrorTokenTrackingController.prototype._processNonSymbolToken):
168         (WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
169         Pass tokenInfo as an argument to explicitly state that these methods require it.
170
171         (WebInspector.CodeMirrorTokenTrackingController.prototype._resetTrackingStates):
172         Don't use delete.
173
174         * UserInterface/Views/SourceCodeTextEditor.js:
175         (WebInspector.SourceCodeTextEditor.prototype.tokenTrackingControllerHighlightedRangeReleased):
176         Allow to hide the popover regardless of mouse position. Used when the text cursor moves or
177         when Esc key is pressed.
178
179 2015-10-23  Devin Rousso  <dcrousso+webkit@gmail.com>
180
181         Web Inspector: Visual sidebar should support multiple backgrounds
182         https://bugs.webkit.org/show_bug.cgi?id=148310
183
184         Reviewed by Timothy Hatcher.
185
186         Changes the layout of the Background - Style section in the Visual sidebar
187         to be a list instead of a single editable field for a background-image URL.
188         Allows for comma-separated background properties (both shorthand and
189         longhand) and displays them all in a single list for editing.
190
191         * Localizations/en.lproj/localizedStrings.js:
192         * UserInterface/Views/VisualStyleColorPicker.js:
193         (WebInspector.VisualStyleColorPicker):
194         * UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
195         (.visual-style-property-container.comma-separated-keyword-editor):
196         * UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js:
197         (WebInspector.VisualStyleCommaSeparatedKeywordEditor):
198         (WebInspector.VisualStyleCommaSeparatedKeywordEditor.prototype._generateTextFromLonghandProperties.propertyValue):
199         (WebInspector.VisualStyleCommaSeparatedKeywordEditor.prototype._generateTextFromLonghandProperties):
200         (WebInspector.VisualStyleCommaSeparatedKeywordEditor.prototype.modifyPropertyText):
201         Comma separated properties will now try to assemble a value from related longhand
202         properties so that a single shorthand property with commas may be used.
203
204         * UserInterface/Views/VisualStyleDetailsPanel.css:
205         (.sidebar > .panel.details.css-style .visual > .details-section.background .details-section.background-style .visual-style-property-container.comma-separated-keyword-editor.background):
206         * UserInterface/Views/VisualStyleDetailsPanel.js:
207         (WebInspector.VisualStyleDetailsPanel.prototype._populateBackgroundStyleSection):
208         (WebInspector.VisualStyleDetailsPanel.prototype._populateBoxShadowSection):
209         (WebInspector.VisualStyleDetailsPanel.prototype._populateTransitionSection):
210         (WebInspector.VisualStyleDetailsPanel.prototype._noRemainingCommaSeparatedEditorItems):
211         (WebInspector.VisualStyleDetailsPanel.prototype._selectedCommaSeparatedEditorItemValueChanged):
212         (WebInspector.VisualStyleDetailsPanel.prototype._commaSeparatedEditorTreeItemSelected):
213         (WebInspector.VisualStyleDetailsPanel.prototype._populateBoxShadowSection.noRemainingTreeItems): Deleted.
214         (WebInspector.VisualStyleDetailsPanel.prototype._populateBoxShadowSection.selectedBoxShadowItemValueChanged): Deleted.
215         (WebInspector.VisualStyleDetailsPanel.prototype._populateBoxShadowSection.boxShadowItemSelected): Deleted.
216         (WebInspector.VisualStyleDetailsPanel.prototype._populateTransitionSection.noRemainingTreeItems): Deleted.
217         (WebInspector.VisualStyleDetailsPanel.prototype._populateTransitionSection.selectedtransitionItemValueChanged): Deleted.
218         (WebInspector.VisualStyleDetailsPanel.prototype._populateTransitionSection.transitionItemSelected): Deleted.
219         Made the "background-image" property into a comma separated editor.
220
221         * UserInterface/Views/VisualStyleFontFamilyListEditor.js:
222         (WebInspector.VisualStyleFontFamilyListEditor):
223         * UserInterface/Views/VisualStyleKeywordIconList.js:
224         (WebInspector.VisualStyleKeywordIconList.prototype.set value):
225         (WebInspector.VisualStyleKeywordIconList.prototype._handleKeywordChanged):
226         (WebInspector.VisualStyleKeywordIconList):
227         * UserInterface/Views/VisualStyleKeywordPicker.js:
228         (WebInspector.VisualStyleKeywordPicker.prototype.updateEditorValues):
229         (WebInspector.VisualStyleKeywordPicker.prototype._setValue):
230         * UserInterface/Views/VisualStyleNumberInputBox.js:
231         (WebInspector.VisualStyleNumberInputBox.prototype.set value):
232         * UserInterface/Views/VisualStylePropertyCombiner.js:
233         (WebInspector.VisualStylePropertyCombiner):
234         (WebInspector.VisualStylePropertyCombiner.prototype.updateValuesFromText.updateCompatibleEditor):
235         (WebInspector.VisualStylePropertyCombiner.prototype.updateValuesFromText):
236         * UserInterface/Views/VisualStylePropertyEditor.js:
237         (WebInspector.VisualStylePropertyEditor):
238         (WebInspector.VisualStylePropertyEditor.prototype.update):
239         (WebInspector.VisualStylePropertyEditor.prototype.getValuesFromText):
240         (WebInspector.VisualStylePropertyEditor.prototype.get propertyMissing):
241         (WebInspector.VisualStylePropertyEditor.prototype._valueDidChange):
242         Moved "propertyMissing" into a member variable for better access.
243
244         * UserInterface/Views/VisualStyleURLInput.js:
245         (WebInspector.VisualStyleURLInput):
246         (WebInspector.VisualStyleURLInput.prototype.get synthesizedValue):
247         (WebInspector.VisualStyleURLInput.prototype.parseValue):
248         Added support for specific keywords to be used in the input field.
249
250 2015-10-22  Timothy Hatcher  <timothy@apple.com>
251
252         Web Inspector: Remove generateColoredImagesForCSS and its clients
253         https://bugs.webkit.org/show_bug.cgi?id=150474
254
255         Reviewed by Joseph Pecoraro.
256
257         * UserInterface/Base/ImageUtilities.js:
258         (generateColoredImage): Deleted.
259         (imageLoaded): Deleted.
260         (ensureImageIsLoaded): Deleted.
261         (restoreImages.restoreActiveImages): Deleted.
262         (restoreImages): Deleted.
263         (restoreImage): Deleted.
264         (update): Deleted.
265         (generateImage): Deleted.
266         (generateColoredImagesForCSS): Deleted.
267
268         * UserInterface/Base/Main.js:
269         (WebInspector.loaded): Deleted call to _generateDisclosureTriangleImages.
270         (WebInspector._generateDisclosureTriangleImages): Deleted.
271         (WebInspector.createGoToArrowButton): Deleted code to generate the states.
272
273         * UserInterface/Images/BackArrow.svg: Removed.
274         * UserInterface/Images/BackForwardArrows.svg: Added.
275         * UserInterface/Images/DisclosureTriangleSmallClosed.svg: Removed.
276         * UserInterface/Images/DisclosureTriangleSmallOpen.svg: Removed.
277         * UserInterface/Images/DisclosureTriangleTinyClosed.svg: Removed.
278         * UserInterface/Images/DisclosureTriangleTinyOpen.svg: Removed.
279         * UserInterface/Images/DisclosureTriangles.svg: Added.
280         * UserInterface/Images/ForwardArrow.svg: Removed.
281         * UserInterface/Images/GoToArrow.svg:
282         * UserInterface/Images/Locked.svg: Moved fill color here.
283         * UserInterface/Images/SortIndicatorArrows.svg: Added.
284         * UserInterface/Images/SortIndicatorDownArrow.svg: Removed.
285         * UserInterface/Images/SortIndicatorUpArrow.svg: Removed.
286         * UserInterface/Images/gtk/BackArrow.svg: Removed.
287         * UserInterface/Images/gtk/BackForwardArrows.svg: Added.
288         * UserInterface/Images/gtk/DisclosureTriangleSmallClosed.svg: Removed.
289         * UserInterface/Images/gtk/DisclosureTriangleSmallOpen.svg: Removed.
290         * UserInterface/Images/gtk/DisclosureTriangleTinyClosed.svg: Removed.
291         * UserInterface/Images/gtk/DisclosureTriangleTinyOpen.svg: Removed.
292         * UserInterface/Images/gtk/DisclosureTriangles.svg: Added.
293         * UserInterface/Images/gtk/ForwardArrow.svg: Removed.
294         * UserInterface/Images/gtk/GoToArrow.svg:
295         * UserInterface/Images/gtk/Locked.svg: Moved fill color here.
296         * UserInterface/Images/gtk/SortIndicatorArrows.svg: Added.
297         * UserInterface/Images/gtk/SortIndicatorDownArrow.svg: Removed.
298         * UserInterface/Images/gtk/SortIndicatorUpArrow.svg: Removed.
299
300         * UserInterface/Views/CSSStyleDeclarationSection.css:
301         (.style-declaration-section.locked > .header::before):
302
303         * UserInterface/Views/CSSStyleDeclarationSection.js:
304         (WebInspector.CSSStyleDeclarationSection): Deleted.
305
306         * UserInterface/Views/ConsoleMessageView.css:
307         (.console-message.expandable .console-top-level-message::before):
308         (.console-message.expandable.expanded .console-top-level-message::before):
309
310         * UserInterface/Views/ContentBrowser.js:
311         (WebInspector.ContentBrowser): Use BackForwardArrows.svg.
312
313         * UserInterface/Views/DOMTreeOutline.css:
314         (.dom-tree-outline li.parent::before):
315         (.dom-tree-outline:focus li.parent.selected::before):
316         (.dom-tree-outline li.parent.expanded::before):
317         (.dom-tree-outline:focus li.parent.expanded.selected::before):
318
319         * UserInterface/Views/DataGrid.css:
320         (.data-grid th.sort-ascending > div:first-child::after):
321         (.data-grid th.sort-descending > div:first-child::after):
322         (.data-grid tr.parent td.disclosure::before):
323         (.data-grid tr.parent.expanded td.disclosure::before):
324         (.data-grid:matches(:focus, .force-focus) tr.parent.selected td.disclosure::before):
325         (.data-grid:matches(:focus, .force-focus) tr.parent.expanded.selected td.disclosure::before):
326
327         * UserInterface/Views/DataGrid.js:
328         (WebInspector.DataGrid): Deleted call to _generateSortIndicatorImagesIfNeeded.
329         (WebInspector.DataGrid.prototype._generateSortIndicatorImagesIfNeeded): Deleted.
330
331         * UserInterface/Views/DetailsSection.css:
332         (.details-section > .header::before):
333         (.details-section > .header:not(.mouse-over-options-element):active::before):
334         (.details-section.collapsed > .header::before):
335         (.details-section.collapsed > .header:not(.mouse-over-options-element):active::before):
336
337         * UserInterface/Views/DetailsSection.js:
338         (WebInspector.DetailsSection): Deleted call to _generateDisclosureTrianglesIfNeeded.
339         (WebInspector.DetailsSection.prototype._generateDisclosureTrianglesIfNeeded): Deleted.
340
341         * UserInterface/Views/ErrorObjectView.css:
342         (.error-object > .formatted-error::before):
343         (.error-object.expanded > .formatted-error::before):
344
345         * UserInterface/Views/FindBanner.css:
346         (.find-banner > button.segmented.left > .glyph):
347         (.find-banner > button.segmented.left:active:not(:disabled) > .glyph):
348         (.find-banner > button.segmented.right > .glyph):
349         (.find-banner > button.segmented.right:active:not(:disabled) > .glyph):
350
351         * UserInterface/Views/FindBanner.js:
352         (WebInspector.FindBanner): Deleted call to _generateButtonsGlyphsIfNeeded.
353         (WebInspector.FindBanner.prototype._generateButtonsGlyphsIfNeeded): Deleted.
354
355         * UserInterface/Views/LogContentView.css:
356         (.console-group-title::before):
357         (.console-group.collapsed .console-group-title::before):
358
359         * UserInterface/Views/Main.css:
360         (.go-to-arrow):
361         (.go-to-arrow:active):
362         (:matches(:focus, .force-focus) .selected .go-to-arrow):
363         (:matches(:focus, .force-focus) .selected .go-to-arrow:active):
364
365         * UserInterface/Views/NavigationSidebarPanel.css:
366         (.navigation-sidebar-panel-content-tree-outline .item .disclosure-button):
367         (.navigation-sidebar-panel-content-tree-outline:matches(:focus, .force-focus) .item.selected .disclosure-button):
368         (.navigation-sidebar-panel-content-tree-outline .item.expanded .disclosure-button):
369         (.navigation-sidebar-panel-content-tree-outline:matches(:focus, .force-focus) .item.selected.expanded .disclosure-button):
370
371         * UserInterface/Views/NavigationSidebarPanel.js:
372         (WebInspector.NavigationSidebarPanel): Deleted call to _generateDisclosureTrianglesIfNeeded.
373         (WebInspector.NavigationSidebarPanel.prototype._generateDisclosureTrianglesIfNeeded): Deleted.
374
375         * UserInterface/Views/ObjectTreePropertyTreeElement.css:
376         (.object-tree-property.parent > .disclosure-button):
377         (.object-tree-property.parent.expanded > .disclosure-button):
378         (.object-tree-property .read-only): Deleted.
379
380         * UserInterface/Views/ObjectTreeView.css:
381         (.object-tree > :matches(.title, .object-preview)::before):
382         (.object-tree.expanded > :matches(.title, .object-preview)::before):
383
384         * UserInterface/Views/TypeTreeElement.css:
385         (.type-tree-element.parent > .disclosure-button):
386         (.type-tree-element.parent.expanded > .disclosure-button):
387
388 2015-10-22  Matt Baker  <mattbaker@apple.com>
389
390         Web Inspector: CSS Data URIs count against page weight twice
391         https://bugs.webkit.org/show_bug.cgi?id=150101
392
393         Reviewed by Timothy Hatcher.
394
395         * UserInterface/Models/DefaultDashboard.js:
396         (WebInspector.DefaultDashboard.prototype._resourceSizeDidChange):
397         Exclude resources with a data URI from the total page weight.
398
399         * UserInterface/Models/Resource.js:
400         (WebInspector.Resource):
401         (WebInspector.Resource.prototype.updateForRedirectResponse):
402         (WebInspector.Resource.prototype.updateForResponse):
403         (WebInspector.Resource.prototype.markAsFinished):
404         Removed uses of `delete`.
405
406 2015-10-22  Joseph Pecoraro  <pecoraro@apple.com>
407
408         Web Inspector: Remove unused Timeline GCEvent Record type
409         https://bugs.webkit.org/show_bug.cgi?id=150477
410
411         Reviewed by Timothy Hatcher.
412
413         iOS backends never emitted a GCEvent timeline event.
414
415         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
416         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
417         * UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
418         * Versions/Inspector-iOS-7.0.json:
419         * Versions/Inspector-iOS-8.0.json:
420         * Versions/Inspector-iOS-9.0.json:
421
422 2015-10-22  Joseph Pecoraro  <pecoraro@apple.com>
423
424         Web Inspector: srcset attributes should have hyperlinks to the resources
425         https://bugs.webkit.org/show_bug.cgi?id=150409
426
427         Reviewed by Timothy Hatcher.
428
429         Follow-up tweaks and fixes that were intended to be landed.
430
431         * UserInterface/Views/CodeMirrorAdditions.js:
432         (tokenizeSrcSetString):
433         Multiline parsing has issues recovering the state CodeMirror
434         expects, so we just bail in those cases. Leading whitespace
435         is also handled poorly, but expected to be rare.
436
437         * UserInterface/Views/DOMTreeElement.js:
438         (WebInspector.DOMTreeElement.prototype._buildAttributeDOM):
439         Trim to eliminate leading whitespace.
440
441 2015-10-22  Joseph Pecoraro  <pecoraro@apple.com>
442
443         Web Inspector: Restore :not(:placeholder-shown) behavior on search bars with comments
444         https://bugs.webkit.org/show_bug.cgi?id=150452
445
446         Reviewed by Timothy Hatcher.
447
448         * UserInterface/Views/FindBanner.css:
449         (.find-banner.console-find-banner > input[type="search"]:not(:placeholder-shown)):
450         * UserInterface/Views/SearchBar.css:
451         (.search-bar > input[type="search"]:not(:placeholder-shown)):
452         Add back the placeholder-shown related styles and add a comment about what they are for.
453
454 2015-10-22  Devin Rousso  <dcrousso+webkit@gmail.com>
455
456         Web Inspector: Tabbing over CSS properties prepended by * doesn't move the highlighted range
457         https://bugs.webkit.org/show_bug.cgi?id=150294
458
459         Reviewed by Timothy Hatcher.
460
461         Moving the selected text when tabbing and shift-tabbing now relies upon
462         the last index of ";" if it exists instead of whether the line ends with it.
463
464         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
465         (WebInspector.CSSStyleDeclarationTextEditor.prototype._handleShiftTabKey):
466         (WebInspector.CSSStyleDeclarationTextEditor.prototype._handleTabKey):
467
468 2015-10-21  Joseph Pecoraro  <pecoraro@apple.com>
469
470         Web Inspector: srcset attributes should have hyperlinks to the resources
471         https://bugs.webkit.org/show_bug.cgi?id=150409
472
473         Reviewed by Timothy Hatcher.
474
475         The "srcset" attribute parsing is a simplification of:
476         https://html.spec.whatwg.org/multipage/embedded-content.html#attr-img-srcset
477
478         The "srcset" attribute value is expected to be in comma
479         separated groups. Within each group we always expect a link,
480         and an optional descriptor. We want to linkify the link.
481
482         * UserInterface/Views/CodeMirrorAdditions.js:
483         (tokenizeSrcSetString):
484         (extendedXMLToken):
485         When parsing srcset attribute, parse links as link tokens
486         so that they are linkified in resource content views.
487
488         * UserInterface/Views/DOMTreeElement.js:
489         (WebInspector.DOMTreeElement.prototype._buildAttributeDOM):
490         When creating the DOMTree DOM for srcset attributes,
491         create link elements for the link values of attribute value.
492
493 2015-10-21  Devin Rousso  <dcrousso+webkit@gmail.com>
494
495         Web Inspector: Autocompletion previews in the CSS sidebar do not apply
496         https://bugs.webkit.org/show_bug.cgi?id=147720
497
498         Reviewed by Timothy Hatcher.
499
500         When autocompletion hints are added to styles or the console, the history
501         object used by CodeMirror was edited to remove the last entry. Instead of
502         using this method (which caused glitchy behaviour when undo-ing), call
503         CodeMirror.undo() and adjust accordingly. In addition, a marker was being
504         used as the completion hint instead of applying text, whereas these
505         changes use actual text, ensuring that completions are previewed in the page.
506
507         * UserInterface/Controllers/CodeMirrorCompletionController.js:
508         (WebInspector.CodeMirrorCompletionController):
509         (WebInspector.CodeMirrorCompletionController.prototype.close):
510         (WebInspector.CodeMirrorCompletionController.prototype._applyCompletionHint.update):
511         (WebInspector.CodeMirrorCompletionController.prototype._commitCompletionHint.update):
512         (WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint.update):
513         (WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint):
514         (WebInspector.CodeMirrorCompletionController.prototype._handleBeforeChange):
515         (WebInspector.CodeMirrorCompletionController.prototype._createCompletionHintMarker): Deleted.
516         (WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint.clearMarker): Deleted.
517
518 2015-10-21  Devin Rousso  <dcrousso+webkit@gmail.com>
519
520         Web Inspector: Add forgotten WebInspector.UIString from r190521
521         https://bugs.webkit.org/show_bug.cgi?id=150425
522
523         Reviewed by Timothy Hatcher.
524
525         * Localizations/en.lproj/localizedStrings.js:
526         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
527         (UserInterface/Views/CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded)
528
529 2015-10-21  Devin Rousso  <dcrousso+webkit@gmail.com>
530
531         Web Inspector: Adjust usages of classList.toggle to ensure a true/false value instead of undefined
532         https://bugs.webkit.org/show_bug.cgi?id=150424
533
534         Reviewed by Timothy Hatcher.
535
536         Adds "!!" in front of force parameters in classList.toggle calls that
537         could possibly be undefined (thereby breaking the UI).
538
539         * UserInterface/Views/ScopeBarItem.js:
540         (WebInspector.ScopeBarItem):
541         * UserInterface/Views/VisualStyleDetailsPanel.js:
542         (WebInspector.VisualStyleDetailsPanel.prototype._updateSections):
543         * UserInterface/Views/VisualStylePropertyEditor.js:
544         (WebInspector.VisualStylePropertyEditor):
545
546 2015-10-21  Devin Rousso  <dcrousso+webkit@gmail.com>
547
548         Web Inspector: Option-Up doesn't increment certain attribute values
549         https://bugs.webkit.org/show_bug.cgi?id=149257
550
551         Reviewed by Brian Burg.
552
553         If the user tries to modify a numerical attribute in HTML and the cursor
554         was at the beginning of the attribute value, the range of the selection
555         was within a sibling element instead of the text node containin the value.
556         This patch fixes this issue and ensures that the correct text is selected.
557
558         * UserInterface/Views/EditingSupport.js:
559         (WebInspector.startEditing.handleEditingResult):
560         Replaced var with let.
561
562 2015-10-21  Joseph Pecoraro  <pecoraro@apple.com>
563
564         Web Inspector: Use some CSS Variables in Web Inspector
565         https://bugs.webkit.org/show_bug.cgi?id=150405
566
567         Reviewed by Timothy Hatcher.
568
569         * UserInterface/Main.html:
570         Include the new variables stylesheet.
571
572         * UserInterface/Views/Variables.css: Added.
573         (:root):
574         Introduce new global variables.
575
576         * UserInterface/Views/CSSStyleDeclarationTextEditor.css:
577         (.css-style-text-editor > .CodeMirror .cm-link):
578         * UserInterface/Views/ConsoleMessageView.css:
579         (.console-message-preview-divider):
580         (.console-message-enclosed):
581         (.console-message .console-message-extra-parameters-container > li::before):
582         (.console-saved-variable):
583         * UserInterface/Views/DOMTreeOutline.css:
584         (.dom-tree-outline li.selected > span::after):
585         * UserInterface/Views/FormattedValue.css:
586         (:matches(.formatted-array, .formatted-map, .formatted-set, .formatted-weakmap, .formatted-weakset) > .size):
587         (.formatted-number):
588         (.formatted-boolean):
589         (.formatted-string):
590         (.formatted-regexp):
591         (.formatted-symbol):
592         * UserInterface/Views/ObjectPreviewView.css:
593         (.object-preview > .size):
594         * UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:
595         (.object-tree-array-index .index-name):
596         * UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
597         (.syntax-highlighted :matches(.css-keyword, .css-tag, .css-at-rule, .css-important, .javascript-keyword, .html-tag)):
598         (.syntax-highlighted :matches(.css-number, .javascript-number)):
599         (.syntax-highlighted :matches(.css-string, .javascript-string, .html-attribute-value)):
600         (.syntax-highlighted .javascript-regexp):
601         * UserInterface/Views/TypeTokenView.css:
602         (.type-token-symbol):
603         Make use of variables.
604
605 2015-10-21  Nikita Vasilyev  <nvasilyev@apple.com>
606
607         Web Inspector: Typo in a property name: style.inerhited
608         https://bugs.webkit.org/show_bug.cgi?id=150391
609
610         Reviewed by Csaba Osztrogonác.
611
612         * UserInterface/Views/RulesStyleDetailsPanel.js:
613         (WebInspector.RulesStyleDetailsPanel.prototype.refresh):
614
615 2015-10-20  Nikita Vasilyev  <nvasilyev@apple.com>
616
617         Web Inspector: Pressing Command-S while focused on the styles sidebar should save CSS file
618         https://bugs.webkit.org/show_bug.cgi?id=150298
619
620         Reviewed by Timothy Hatcher.
621
622         * UserInterface/Views/CSSStyleDeclarationSection.js:
623         (WebInspector.CSSStyleDeclarationSection):
624         Beep when saving didn't work. Inline CSS and CSS in style attributes aren't curently supported.
625
626 2015-10-20  Joseph Pecoraro  <pecoraro@apple.com>
627
628         Web Inspector: JavaScriptCore should parse sourceURL and sourceMappingURL directives
629         https://bugs.webkit.org/show_bug.cgi?id=150096
630
631         Reviewed by Geoffrey Garen.
632
633         * UserInterface/Test/InspectorProtocol.js:
634         (InspectorProtocol._sendMessage):
635         (InspectorProtocol.dispatchMessageFromBackend):
636         This is only used for tests, so avoid console.log
637         and just dump directly to the system console.
638
639 2015-10-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
640
641         [Streams API] Add skeleton for initial WritableStream support
642         https://bugs.webkit.org/show_bug.cgi?id=149951
643
644         Reviewed by Darin Adler.
645
646         * UserInterface/Models/NativeFunctionParameters.js: Added support for WritableStream.
647
648 2015-10-19  James Craig  <jcraig@apple.com>
649
650         Web Inspector: AX: console list 'input'/'output' markers are not perceivable
651         https://bugs.webkit.org/show_bug.cgi?id=133045
652
653         Enabling WebKit Web Inspector console pseudo-element labels using the new CSS4 'alt' property.
654
655         Reviewed by Brian Burg.
656
657         * UserInterface/Views/LogContentView.css: 
658         (.search-in-progress .console-item:not(.filtered-out-by-search) .highlighted.selected):
659         (.console-messages:focus .console-item.selected .console-user-command-result.console-log-level::before):
660         (@media reader): Deleted.
661
662 2015-10-18  Joseph Pecoraro  <pecoraro@apple.com>
663
664         Web Inspector: Console Search should update when console is cleared
665         https://bugs.webkit.org/show_bug.cgi?id=150141
666
667         Reviewed by Brian Burg.
668
669         * UserInterface/Views/LogContentView.js:
670         (WebInspector.LogContentView.prototype._logCleared):
671         Reperform the search if there is a search query.
672
673         (WebInspector.LogContentView.prototype._filterMessageElements):
674         Reperform the current search.
675
676 2015-10-16  Joseph Pecoraro  <pecoraro@apple.com>
677
678         Web Inspector: Add "unset" to CSS value autocompletion
679         https://bugs.webkit.org/show_bug.cgi?id=127616
680
681         Reviewed by Brian Burg.
682
683         * UserInterface/Models/CSSCompletions.js:
684         * UserInterface/Models/CSSKeywordCompletions.js:
685         (WebInspector.CSSKeywordCompletions.forProperty):
686         Treat "unset" similiar to "initial". Also, no need for "initial"
687         in an individual property's list. We always include it.
688
689         * UserInterface/Views/VisualStyleDetailsPanel.js:
690         (WebInspector.VisualStyleDetailsPanel):
691         (WebInspector.VisualStyleDetailsPanel.prototype._populateDisplaySection):
692         (WebInspector.VisualStyleDetailsPanel.prototype._populateAlignmentSection):
693         Add "Unset" alongside "Initial".
694
695 2015-10-14  Joseph Pecoraro  <pecoraro@apple.com>
696
697         Web Inspector: Include Garbage Collection Event in Timeline
698         https://bugs.webkit.org/show_bug.cgi?id=142510
699
700         Reviewed by Geoffrey Garen and Brian Burg.
701
702         * UserInterface/Base/Utilities.js:
703         (Array.prototype.partition):
704         Helper to partition an Array into two arrays.
705
706         * Localizations/en.lproj/localizedStrings.js:
707         * UserInterface/Base/Main.js:
708         (WebInspector.loaded):
709         * UserInterface/Test.html:
710         * UserInterface/Test/Test.js:
711         (WebInspector.loaded):
712         * UserInterface/Protocol/HeapObserver.js: Added.
713         (WebInspector.HeapObserver.prototype.garbageCollected):
714         (WebInspector.HeapObserver):
715         Create the new observer and manager.
716
717         * UserInterface/Models/GarbageCollection.js: Added.
718         (WebInspector.GarbageCollection):
719         (WebInspector.GarbageCollection.fromPayload):
720         (WebInspector.GarbageCollection.prototype.get type):
721         (WebInspector.GarbageCollection.prototype.get startTime):
722         (WebInspector.GarbageCollection.prototype.get endTime):
723         (WebInspector.GarbageCollection.prototype.get duration):
724         Model object for Heap.GarbageCollection.
725
726         * UserInterface/Controllers/HeapManager.js: Added.
727         (WebInspector.HeapManager):
728         (WebInspector.HeapManager.prototype.garbageCollected):
729         Dispatch events with the GC object.
730
731         * UserInterface/Controllers/TimelineManager.js:
732         (WebInspector.TimelineManager):
733         (WebInspector.TimelineManager.prototype._garbageCollected):
734         Include new GC Timeline Events as Script events.
735
736         * UserInterface/Views/ScriptTimelineOverviewGraph.js:
737         (WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout):
738         For the Script overview, make two sets of bars, one for Scripts and one for GCs.
739         The GCs bar will be overlaid on top of the the Scripts bar. This is particularly
740         useful since a GC can happen during script execution.
741
742         * UserInterface/Images/TimelineRecordGarbageCollection.svg: Added.
743         * UserInterface/Main.html:
744         * UserInterface/Models/ScriptTimelineRecord.js:
745         (WebInspector.ScriptTimelineRecord.prototype.isGarbageCollection):
746         (WebInspector.ScriptTimelineRecord.EventType.displayName):
747         * UserInterface/Views/ScriptTimelineDataGridNode.js:
748         (WebInspector.ScriptTimelineDataGridNode.prototype.get data):
749         (WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent):
750         (WebInspector.ScriptTimelineDataGridNode):
751         * UserInterface/Views/ScriptTimelineView.js:
752         (WebInspector.ScriptTimelineView.prototype._processPendingRecords):
753         * UserInterface/Views/SourceCodeTimelineTreeElement.js:
754         (WebInspector.SourceCodeTimelineTreeElement):
755         * UserInterface/Views/TimelineIcons.css:
756         (.garbage-collection-profile-record .icon):
757         * UserInterface/Views/TimelineRecordBar.css:
758         (.timeline-record-bar.timeline-record-type-script.script-timeline-record-garbage-collected > .segment):
759         UI for GC events.
760
761         * UserInterface/Views/TimelineRecordBar.js:
762         (WebInspector.TimelineRecordBar.createCombinedBars):
763         Simplify by storing start time into a variable.
764
765         * UserInterface/Views/TimelineRecordTreeElement.js:
766         (WebInspector.TimelineRecordTreeElement):
767         Icon for GC events.
768
769 2015-10-15  Commit Queue  <commit-queue@webkit.org>
770
771         Unreviewed, rolling out r191135.
772         https://bugs.webkit.org/show_bug.cgi?id=150197
773
774         This patch causes 50+ LayoutTest crashes related to the
775         inspector (Requested by ryanhaddad on #webkit).
776
777         Reverted changeset:
778
779         "Web Inspector: JavaScriptCore should parse sourceURL and
780         sourceMappingURL directives"
781         https://bugs.webkit.org/show_bug.cgi?id=150096
782         http://trac.webkit.org/changeset/191135
783
784 2015-10-15  Joseph Pecoraro  <pecoraro@apple.com>
785
786         Web Inspector: JavaScriptCore should parse sourceURL and sourceMappingURL directives
787         https://bugs.webkit.org/show_bug.cgi?id=150096
788
789         Reviewed by Geoffrey Garen.
790
791         * UserInterface/Test/InspectorProtocol.js:
792         (InspectorProtocol._sendMessage):
793         (InspectorProtocol.dispatchMessageFromBackend):
794         This is only used for tests, so avoid console.log
795         and just dump directly to the system console.
796
797 2015-10-13  João Oliveira  <hello@jxs.pt>
798
799         Web Inspector: Console SearchBar should work more like ContentBrowser FindBanner
800         https://bugs.webkit.org/show_bug.cgi?id=149505
801
802         Reviewed by Joseph Pecoraro.
803
804         Console tab now uses findBanner, adapted LogContentView to use findBanner,
805         and findBanner to be more agnostic to both usecases, either as fixed, on console tab,
806         and hideable on other inspector tabs.
807
808         * UserInterface/Views/FindBanner.css:
809         (.find-banner.console-find-banner):
810         (.find-banner.console-findbanner input[type="search"]):
811         * UserInterface/Views/FindBanner.js:
812         (WebInspector.FindBanner):
813         (WebInspector.FindBanner.set targetElement.delayedWork):
814         (WebInspector.FindBanner.prototype.set targetElement):
815         (WebInspector.FindBanner.prototype.get showing):
816         (WebInspector.FindBanner.prototype.focus):
817         (WebInspector.FindBanner.prototype._clearAndBlur):
818         (WebInspector.FindBanner.prototype.show.delayedWork):
819         (WebInspector.FindBanner.prototype.show):
820         (WebInspector.FindBanner.prototype.hide):
821         (WebInspector.FindBanner.prototype.get element): Deleted.
822         (WebInspector.FindBanner.prototype._inputFieldSearch): Deleted.
823         * UserInterface/Views/LogContentView.js:
824         (WebInspector.LogContentView):
825         (WebInspector.LogContentView.prototype.get navigationItems):
826         (WebInspector.LogContentView.prototype.handleFindEvent):
827         (WebInspector.LogContentView.prototype.findBannerRevealPreviousResult):
828         (WebInspector.LogContentView.prototype.findBannerRevealNextResult):
829         (WebInspector.LogContentView.prototype._filterMessageElements):
830         (WebInspector.LogContentView.prototype.findBannerPerformSearch):
831         (WebInspector.LogContentView.prototype.findBannerSearchCleared):
832         (WebInspector.LogContentView.prototype.revealNextSearchResult):
833         (WebInspector.LogContentView.prototype.revealPreviousSearchResult):
834         (WebInspector.LogContentView.prototype._performSearch):
835         (WebInspector.LogContentView.prototype.searchBarDidActivate): Deleted.
836         (WebInspector.LogContentView.prototype._searchTextDidChange): Deleted.
837
838 2015-10-13  Nikita Vasilyev  <nvasilyev@apple.com>
839
840         REGRESSION(r189567): Web Inspector: Clipped filter icons when debugger sidebar is narrow
841         https://bugs.webkit.org/show_bug.cgi?id=150023
842
843         r189567 changed flexbox items' default min-width from 0 to auto.
844         Explicitly set it to 0 in CSS.
845
846         Reviewed by Brian Burg.
847
848         * UserInterface/Views/FilterBar.css:
849         (.filter-bar > input[type="search"]):
850
851 2015-10-13  Yusuke Suzuki  <utatane.tea@gmail.com>
852
853         Web Inspector: Don't shadow global Object constructor in WebInspector.Object class definition
854         https://bugs.webkit.org/show_bug.cgi?id=150093
855
856         Reviewed by Joseph Pecoraro.
857
858         Currently, class expression does not define any variables. So even in `class Object { }`,
859         we were able to touch the global Object constructor (like `Object.keys`).
860         However, that is a bug. After https://bugs.webkit.org/show_bug.cgi?id=150089 fixes that bug,
861         the global `Object` is shadowed by the user-defined `class Object` name.
862
863         To solve this issue, we changed the `class Object` to `class WebInspectorObject`.
864         And we expose this class as a `WebInspector.Object`.
865
866         * UserInterface/Base/Object.js:
867
868 2015-10-10  Nikita Vasilyev  <nvasilyev@apple.com>
869
870         Web Inspector: Improve error messages for internal Inspector code
871         https://bugs.webkit.org/show_bug.cgi?id=149995
872
873         Don't log "error.stack" since the error view already includes a nicely formatted stacktrace.
874
875         Reviewed by Timothy Hatcher.
876
877         * UserInterface/Protocol/InspectorBackend.js:
878         (InspectorBackendClass.prototype._dispatchResponseToCallback):
879         (InspectorBackendClass.prototype._dispatchEvent):
880
881 2015-10-08  Nikita Vasilyev  <nvasilyev@apple.com>
882
883         Web Inspector: Stack trace view doesn't properly display lines without function names
884         https://bugs.webkit.org/show_bug.cgi?id=149922
885
886         Reviewed by Timothy Hatcher.
887
888         * UserInterface/Models/StackTrace.js:
889         (WebInspector.StackTrace._parseStackTrace):
890         (WebInspector.StackTrace._parseLocation): Added.
891
892 2015-10-08  Nikita Vasilyev  <nvasilyev@apple.com>
893
894         Web Inspector: An error view doesn't get expanded by clicking on the expand arrow
895         https://bugs.webkit.org/show_bug.cgi?id=149917
896
897         Reviewed by Timothy Hatcher.
898
899         * UserInterface/Views/ErrorObjectView.css:
900         (.error-object > .formatted-error::before):
901         (.error-object.expanded > .formatted-error::before):
902         (.error-object::before): Deleted.
903         (.error-object.expanded::before): Deleted.
904
905 2015-10-06  Nikita Vasilyev  <nvasilyev@apple.com>
906
907         Web Inspector: Clicking on a stack trace link does not navigate to the corresponding line
908         https://bugs.webkit.org/show_bug.cgi?id=149405
909
910         lineNumber should be a number type but it was a string.
911
912         Reviewed by Timothy Hatcher.
913
914         * UserInterface/Base/Main.js:
915         (WebInspector.openURL):
916         (WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
917         Keep lineNumber undefined when it isn't present in the string.
918         WebInspector.linkifyStringAsFragmentWithCustomLinkifier is only used by
919         WebInspector.linkifyStringAsFragment and it expects lineNumber to be undefined
920         when it wasn't found in the parsed string.
921
922 2015-10-06  Devin Rousso  <dcrousso+webkit@gmail.com>
923
924         Web Inspector: Fix spacing of FindBanner prev/next buttons
925         https://bugs.webkit.org/show_bug.cgi?id=149717
926
927         Reviewed by Darin Adler.
928
929         The sizing and spacing of the previous and next buttons in the FindBanner
930         is slightly off and should be readjusted to ensure that both buttons are
931         the same size and have the same spacing.
932
933         * UserInterface/Views/FindBanner.css:
934         (.find-banner > button.segmented.right > .glyph):
935         (.find-banner > button.segmented):
936         (.find-banner > button.segmented > .glyph):
937         (.find-banner > button.segmented.left): Deleted.
938         (.find-banner > button.segmented.left > .glyph): Deleted.
939         (.find-banner > button.segmented.right): Deleted.
940
941 2015-10-06  Joseph Pecoraro  <pecoraro@apple.com>
942
943         Web Inspector: Simplify TimelineRecordBar a bit
944         https://bugs.webkit.org/show_bug.cgi?id=149733
945
946         Reviewed by Timothy Hatcher.
947
948         * UserInterface/Views/TimelineRecordBar.js:
949         (WebInspector.TimelineRecordBar.prototype.set records):
950
951 2015-10-05  Nikita Vasilyev  <nvasilyev@apple.com>
952
953         Web Inspector: Error displayed as an object when passed as a second argument to console.log
954         https://bugs.webkit.org/show_bug.cgi?id=149799
955
956         Reviewed by Joseph Pecoraro.
957
958         * UserInterface/Views/ConsoleMessageView.js:
959         (WebInspector.ConsoleMessageView.prototype._appendExtraParameters):
960         Don't format errors as objects.
961
962         (WebInspector.ConsoleMessageView.prototype._formatParameter):
963         (WebInspector.ConsoleMessageView.prototype._formatParameterAsValue):
964         (WebInspector.ConsoleMessageView.prototype._formatParameterAsString):
965         (WebInspector.ConsoleMessageView.prototype._formatParameterAsNode):
966         (WebInspector.ConsoleMessageView.prototype._formatParameterAsObject):
967         (WebInspector.ConsoleMessageView.prototype._formatParameterAsError):
968         (WebInspector.ConsoleMessageView.prototype._formatParameterAsArray):
969         Replace an unnecessary span element with a document fragment.
970
971         * UserInterface/Views/ErrorObjectView.css:
972         (.error-object):
973         Display an error object on the same line as a list bullet.
974
975 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
976
977         Unprefix -webkit-font-feature-settings
978         https://bugs.webkit.org/show_bug.cgi?id=149722
979
980         Reviewed by Sam Weinig.
981
982         * UserInterface/Models/CSSKeywordCompletions.js:
983
984 2015-10-04  Nikita Vasilyev  <nvasilyev@apple.com>
985
986         Web Inspector: Wrong column numbers in error object views
987         https://bugs.webkit.org/show_bug.cgi?id=149795
988
989         Convert columnNumber and lineNumber properties from strings to numbers
990         to prevent accidental string concatenations.
991
992         Reviewed by Timothy Hatcher.
993
994         * UserInterface/Models/StackTrace.js:
995         (WebInspector.StackTrace._parseStackTrace):
996
997 2015-10-02  Matt Baker  <mattbaker@apple.com>
998
999         Web Inspector: Add breakpoint option to ignore n times before stopping
1000         https://bugs.webkit.org/show_bug.cgi?id=147664
1001
1002         Reviewed by Timothy Hatcher.
1003
1004         * Localizations/en.lproj/localizedStrings.js:
1005         New strings for breakpoint popover labels.
1006
1007         * UserInterface/Controllers/BreakpointPopoverController.js:
1008         (WebInspector.BreakpointPopoverController.prototype._createPopoverContent):
1009         Add ignoreCount UI to popover, if backend support exists. UI based on same
1010         feature in Xcode's breakpoint editing dialog.
1011         (WebInspector.BreakpointPopoverController.prototype._popoverIgnoreInputChanged):
1012         User input sanity checks on numeric input.
1013
1014         * UserInterface/Controllers/DebuggerManager.js:
1015         Listen for changes to breakpoint ignoreCount property.
1016
1017         * UserInterface/Models/Breakpoint.js:
1018         (WebInspector.Breakpoint):
1019         (WebInspector.Breakpoint.prototype.get ignoreCount):
1020         (WebInspector.Breakpoint.prototype.set ignoreCount):
1021         New property for ignoreCount.
1022         (WebInspector.Breakpoint.prototype.get options):
1023         Added ignoreCount to options object.
1024         (WebInspector.Breakpoint.prototype.get info):
1025         Added ignoreCount to info object.
1026
1027         * UserInterface/Views/BreakpointPopoverController.css:
1028         (#edit-breakpoint-popover-ignore):
1029         New styles for breakpoint popover.
1030
1031 2015-10-02  Matt Baker  <mattbaker@apple.com>
1032
1033         Web Inspector: Cleanup DebuggerManager, reduce `delete` and use Maps instead of objects
1034         https://bugs.webkit.org/show_bug.cgi?id=149760
1035
1036         Reviewed by Joseph Pecoraro.
1037
1038         Replaced objects used as hashmaps with Map.
1039
1040         * UserInterface/Controllers/DebuggerManager.js:
1041         (WebInspector.DebuggerManager.prototype.breakpointsForSourceCode):
1042         (WebInspector.DebuggerManager.prototype.breakpointForIdentifier):
1043         (WebInspector.DebuggerManager.prototype.scriptForIdentifier):
1044         (WebInspector.DebuggerManager.prototype.scriptsForURL):
1045         (WebInspector.DebuggerManager.prototype.get knownNonResourceScripts):
1046         (WebInspector.DebuggerManager.prototype.removeBreakpoint):
1047         (WebInspector.DebuggerManager.prototype.breakpointResolved):
1048         (WebInspector.DebuggerManager.prototype.reset):
1049         (WebInspector.DebuggerManager.prototype.scriptDidParse):
1050         (WebInspector.DebuggerManager.prototype._sourceCodeLocationFromPayload):
1051         (WebInspector.DebuggerManager.prototype._setBreakpoint.didSetBreakpoint):
1052         (WebInspector.DebuggerManager.prototype._setBreakpoint):
1053         (WebInspector.DebuggerManager.prototype._removeBreakpoint.didRemoveBreakpoint):
1054         (WebInspector.DebuggerManager.prototype._removeBreakpoint):
1055
1056 2015-10-02  Devin Rousso  <dcrousso+webkit@gmail.com>
1057
1058         Web Inspector: Copying inline style text puts "undefined" in the pasteboard
1059         https://bugs.webkit.org/show_bug.cgi?id=149155
1060
1061         Reviewed by Brian Burg.
1062
1063         CSSStyleDeclarations for inline styles do not have a owner CSSRule, which means
1064         that they do not have a selector or media list. CSS strings must have a selector
1065         and, for inline styles without an owner rule and selector, this was a problem.
1066
1067         * UserInterface/Models/CSSStyleDeclaration.js:
1068         (WebInspector.CSSStyleDeclaration.prototype.get mediaList):
1069         (WebInspector.CSSStyleDeclaration.prototype.get selectorText):
1070         (WebInspector.CSSStyleDeclaration.prototype.generateCSSRuleString):
1071         Added getters for the list of media queries and selector text with fallbacks
1072         for CSSStyleDeclarations that do not have an owner CSSRule (inline styles).
1073
1074         * UserInterface/Test.html:
1075         Added CSSMedia include for new inspector/css/generate-css-rule-string.html test.
1076
1077         * UserInterface/Views/VisualStyleSelectorTreeItem.js:
1078         (WebInspector.VisualStyleSelectorTreeItem.prototype._handleContextMenuEvent):
1079         Removed parameter that no longer exists.
1080
1081 2015-10-02  Joseph Pecoraro  <pecoraro@apple.com>
1082
1083         Unreviewed, rolling out r190520, some tests assert / crash.
1084
1085         * Localizations/en.lproj/localizedStrings.js:
1086         * UserInterface/Base/Main.js:
1087         (WebInspector.loaded): Deleted.
1088         * UserInterface/Base/Utilities.js:
1089         (value): Deleted.
1090         * UserInterface/Controllers/HeapManager.js: Removed.
1091         * UserInterface/Controllers/TimelineManager.js:
1092         (WebInspector.TimelineManager): Deleted.
1093         (WebInspector.TimelineManager.prototype._garbageCollected): Deleted.
1094         * UserInterface/Images/TimelineRecordGarbageCollection.svg: Removed.
1095         * UserInterface/Main.html:
1096         * UserInterface/Models/GarbageCollection.js: Removed.
1097         * UserInterface/Models/ScriptTimelineRecord.js:
1098         (WebInspector.ScriptTimelineRecord.EventType.displayName):
1099         (WebInspector.ScriptTimelineRecord.prototype.isGarbageCollection): Deleted.
1100         * UserInterface/Protocol/HeapObserver.js: Removed.
1101         * UserInterface/Test.html:
1102         * UserInterface/Test/Test.js:
1103         (WebInspector.loaded): Deleted.
1104         * UserInterface/Views/ScriptTimelineDataGridNode.js:
1105         (WebInspector.ScriptTimelineDataGridNode.prototype.get data):
1106         (WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent): Deleted.
1107         (WebInspector.ScriptTimelineDataGridNode): Deleted.
1108         * UserInterface/Views/ScriptTimelineOverviewGraph.js:
1109         (WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout):
1110         * UserInterface/Views/ScriptTimelineView.js:
1111         (WebInspector.ScriptTimelineView.prototype._processPendingRecords):
1112         * UserInterface/Views/SourceCodeTimelineTreeElement.js:
1113         (WebInspector.SourceCodeTimelineTreeElement):
1114         * UserInterface/Views/TimelineIcons.css:
1115         (.garbage-collection-profile-record .icon): Deleted.
1116         * UserInterface/Views/TimelineRecordBar.css:
1117         (.timeline-record-bar.timeline-record-type-script.script-timeline-record-garbage-collected > .segment): Deleted.
1118         * UserInterface/Views/TimelineRecordBar.js:
1119         (WebInspector.TimelineRecordBar.createCombinedBars):
1120         * UserInterface/Views/TimelineRecordTreeElement.js:
1121         (WebInspector.TimelineRecordTreeElement):
1122
1123 2015-10-02  Devin Rousso  <dcrousso+webkit@gmail.com>
1124
1125         Web Inspector: Option-Click on a property name in the Computed view should jump to resource view
1126         https://bugs.webkit.org/show_bug.cgi?id=149521
1127
1128         Reviewed by Timothy Hatcher.
1129
1130         * UserInterface/Models/DOMNodeStyles.js:
1131         (WebInspector.DOMNodeStyles.prototype.effectivePropertyForName):
1132         Now tries to search for a non-canonical property before falling back to
1133         the canonical version.
1134
1135         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
1136         (WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded):
1137         If the user option-clicks the goto arrow, it shows the source for the
1138         property instead.
1139
1140         * UserInterface/Views/ComputedStyleDetailsPanel.js:
1141         (WebInspector.ComputedStyleDetailsPanel.prototype.cssStyleDeclarationTextEditorShowProperty.delegateShowProperty):
1142         (WebInspector.ComputedStyleDetailsPanel.prototype.cssStyleDeclarationTextEditorShowProperty):
1143         Attempts to show the source of the given property. Will fallback to
1144         highlighting the property in the rules panel.
1145
1146 2015-10-02  Joseph Pecoraro  <pecoraro@apple.com>
1147
1148         Web Inspector: Include Garbage Collection Event in Timeline
1149         https://bugs.webkit.org/show_bug.cgi?id=142510
1150
1151         Reviewed by Geoffrey Garen.
1152
1153         * UserInterface/Base/Utilities.js:
1154         (Array.prototype.parition):
1155         Helper to partition an Array into two arrays.
1156
1157         * UserInterface/Main.html:
1158         * Localizations/en.lproj/localizedStrings.js:
1159         * UserInterface/Base/Main.js:
1160         (WebInspector.loaded):
1161         * UserInterface/Test.html:
1162         * UserInterface/Test/Test.js:
1163         (WebInspector.loaded):
1164         * UserInterface/Protocol/HeapObserver.js:
1165         (WebInspector.HeapObserver.prototype.garbageCollected):
1166         (WebInspector.HeapObserver):
1167         Create the new observer and manager.
1168
1169         * UserInterface/Models/GarbageCollection.js:
1170         (WebInspector.GarbageCollection):
1171         (WebInspector.GarbageCollection.fromPayload):
1172         (WebInspector.GarbageCollection.prototype.get type):
1173         (WebInspector.GarbageCollection.prototype.get startTime):
1174         (WebInspector.GarbageCollection.prototype.get endTime):
1175         (WebInspector.GarbageCollection.prototype.get duration):
1176         Model object for Heap.GarbageCollection.
1177
1178         * UserInterface/Controllers/HeapManager.js:
1179         (WebInspector.HeapManager):
1180         (WebInspector.HeapManager.prototype.garbageCollected):
1181         Dispatch events with.
1182
1183         * UserInterface/Controllers/TimelineManager.js:
1184         (WebInspector.TimelineManager):
1185         (WebInspector.TimelineManager.prototype._garbageCollected):
1186         Include new GC Timeline Events as Script events.
1187
1188         * UserInterface/Views/ScriptTimelineOverviewGraph.js:
1189         (WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout):
1190         For the Script overview, make two sets of bars, one for Scripts and one for GCs.
1191         The GCs bar will be on top of the the Scripts bar. This is particularly useful
1192         since a GC can happen during script execution.
1193
1194         * UserInterface/Views/ScriptTimelineDataGridNode.js:
1195         (WebInspector.ScriptTimelineDataGridNode.prototype.get data):
1196         (WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent):
1197         (WebInspector.ScriptTimelineDataGridNode):
1198         Give a NaN call count to top level Script DataGridNodes.
1199         In the UI, display the empty placeholder for NaN call counts.
1200
1201         * UserInterface/Images/TimelineRecordGarbageCollection.svg: Added.
1202         * UserInterface/Models/ScriptTimelineRecord.js:
1203         (WebInspector.ScriptTimelineRecord.prototype.isGarbageCollection):
1204         (WebInspector.ScriptTimelineRecord.EventType.displayName):
1205         * UserInterface/Views/ScriptTimelineView.js:
1206         (WebInspector.ScriptTimelineView.prototype._processPendingRecords):
1207         * UserInterface/Views/SourceCodeTimelineTreeElement.js:
1208         (WebInspector.SourceCodeTimelineTreeElement):
1209         * UserInterface/Views/TimelineIcons.css:
1210         (.garbage-collection-profile-record .icon):
1211         * UserInterface/Views/TimelineRecordBar.css:
1212         (.timeline-record-bar.timeline-record-type-script.script-timeline-record-garbage-collected > .segment):
1213         UI for GC events.
1214
1215         * UserInterface/Views/TimelineRecordBar.js:
1216         (WebInspector.TimelineRecordBar.createCombinedBars):
1217         Simplify by storing start time into a variable.
1218
1219         * UserInterface/Views/TimelineRecordTreeElement.js:
1220         (WebInspector.TimelineRecordTreeElement):
1221         Icon for GC events.
1222
1223 2015-10-02  Nikita Vasilyev  <nvasilyev@apple.com>
1224
1225         Web Inspector: Fix indentation of console message parameters
1226         https://bugs.webkit.org/show_bug.cgi?id=149740
1227
1228         Reviewed by Darin Adler.
1229
1230         * UserInterface/Views/ConsoleMessageView.css:
1231         (.console-message .console-message-stack-trace-container > li):
1232         (.console-message .console-message-extra-parameters-container > li::before):
1233
1234 2015-10-02  Andres Gomez  <agomez@igalia.com>
1235
1236         [GTK] Web Inspector: Add GTK+ icons for new plus icons in the style sidebar
1237         https://bugs.webkit.org/show_bug.cgi?id=149227
1238
1239         Reviewed by Carlos Garcia Campos.
1240
1241         * UserInterface/Images/gtk/NewTabPlus.svg: Updated.
1242         * UserInterface/Images/gtk/Plus13.svg: Copied from Source/WebInspectorUI/UserInterface/Images/gtk/Plus.svg.
1243         * UserInterface/Images/gtk/Plus15.svg: Renamed from Source/WebInspectorUI/UserInterface/Images/gtk/Plus.svg.
1244
1245 2015-10-01  Joseph Pecoraro  <pecoraro@apple.com>
1246
1247         Web Inspector: Simplify filterableData processing
1248         https://bugs.webkit.org/show_bug.cgi?id=149730
1249
1250         Reviewed by Timothy Hatcher.
1251
1252         * UserInterface/Views/BreakpointTreeElement.js:
1253         (WebInspector.BreakpointTreeElement.prototype.get filterableData):
1254         * UserInterface/Views/NavigationSidebarPanel.js:
1255         (WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement.matchTextFilter):
1256         * UserInterface/Views/ResourceTreeElement.js:
1257         (WebInspector.ResourceTreeElement.prototype.get filterableData):
1258         * UserInterface/Views/ScriptTimelineView.js:
1259         (WebInspector.ScriptTimelineView.prototype.matchTreeElementAgainstCustomFilters): Deleted.
1260         * UserInterface/Views/SearchResultTreeElement.js:
1261         (WebInspector.SearchResultTreeElement.prototype.get filterableData):
1262         (WebInspector.SearchResultTreeElement):
1263
1264 2015-10-01  Joseph Pecoraro  <pecoraro@apple.com>
1265
1266         Web Inspector: Do not immediately create all ProfileNodeTreeElements when showing JavaScript and Events timeline
1267         https://bugs.webkit.org/show_bug.cgi?id=149726
1268
1269         Reviewed by Timothy Hatcher.
1270
1271         * UserInterface/Views/NavigationSidebarPanel.js:
1272         (WebInspector.NavigationSidebarPanel.prototype.shouldFilterPopulate):
1273         (WebInspector.NavigationSidebarPanel.prototype._updateFilter):
1274         (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
1275         We were populating during filtering if there were any custom filters.
1276         However the TimelineSidebarPanel has custom filters (based on time and type)
1277         but those don't need to trigger population. Delay population until it
1278         would actually be needed (like a text search).
1279
1280         * UserInterface/Views/TimelineSidebarPanel.js:
1281         (WebInspector.TimelineSidebarPanel.prototype.shouldFilterPopulate):
1282         Do not populate on filter via this custom filters.
1283
1284 2015-10-01  Matt Baker  <mattbaker@apple.com>
1285
1286         Web Inspector: REGRESSION (r189567): Toolbar collapses when inspector at minimum height with console open
1287         https://bugs.webkit.org/show_bug.cgi?id=149725
1288
1289         Reviewed by Timothy Hatcher.
1290
1291         CSS Flexible Box Layout Module Level 1 introduces a new `auto` initial value for the min-{width|height}
1292         of flex box items, breaking some areas of the inspector UI. This is fixed by setting a min-height of
1293         zero for the #main <div>.
1294
1295         * UserInterface/Views/Main.css:
1296         (#main):
1297
1298 2015-10-01  Nikita Vasilyev  <nvasilyev@apple.com>
1299
1300         Web Inspector: Clip string previews
1301         https://bugs.webkit.org/show_bug.cgi?id=149708
1302
1303         Only show first 140 characters in strings previews.
1304
1305         Reviewed by Joseph Pecoraro.
1306
1307         * UserInterface/Base/Utilities.js:
1308         (String.prototype.truncate): Added.
1309         A smart trancate function that doesn't split words.
1310
1311         * UserInterface/Views/ConsoleMessageView.js:
1312         (WebInspector.ConsoleMessageView.prototype._shouldConsiderObjectLossless):
1313         * UserInterface/Views/FormattedValue.js:
1314         (WebInspector.FormattedValue.createElementForTypesAndValue):
1315
1316 2015-09-30  João Oliveira  <hello@jxs.pt>
1317
1318         Web Inspector: Adjust font size of Developer Tools using Command,+ or Command,-
1319         https://bugs.webkit.org/show_bug.cgi?id=149590
1320
1321         Reviewed by Joseph Pecoraro.
1322
1323         Patch by João Oliveira and Brian Burg.
1324
1325         * UserInterface/Base/Main.js:
1326         (WebInspector.contentLoaded): Add global keyboard shortcuts for zoom in and zoom out.
1327
1328 2015-10-01  Andres Gomez  <agomez@igalia.com>
1329
1330         [GTK] Web Inspector: Add GTK+ icons for the numerical input and slider based Visual editors for CSS properties
1331         https://bugs.webkit.org/show_bug.cgi?id=147847
1332
1333         Reviewed by Carlos Garcia Campos.
1334
1335         * UserInterface/Images/gtk/VisualStylePropertyLinked.svg: Added.
1336         * UserInterface/Images/gtk/VisualStylePropertyUnlinked.svg: Added.
1337
1338 2015-10-01  Andres Gomez  <agomez@igalia.com>
1339
1340         [GTK] Web Inspector: Add GTK+ icons for the different types of non-numerical Visual editors for CSS properties
1341         https://bugs.webkit.org/show_bug.cgi?id=147846
1342
1343         Reviewed by Carlos Garcia Campos.
1344
1345         * UserInterface/Images/gtk/AUTHORS: Updated.
1346         * UserInterface/Images/gtk/ClearBoth.svg: Added.
1347         * UserInterface/Images/gtk/ClearLeft.svg: Added.
1348         * UserInterface/Images/gtk/ClearRight.svg: Added.
1349         * UserInterface/Images/gtk/CubicBezier.svg: Updated.
1350         * UserInterface/Images/gtk/FloatLeft.svg: Added.
1351         * UserInterface/Images/gtk/FloatRight.svg: Added.
1352         * UserInterface/Images/gtk/FontStyleItalic.svg: Added.
1353         * UserInterface/Images/gtk/FontStyleNormal.svg: Added.
1354         * UserInterface/Images/gtk/FontVariantSmallCaps.svg: Added.
1355         * UserInterface/Images/gtk/TextAlignCenter.svg: Added.
1356         * UserInterface/Images/gtk/TextAlignJustify.svg: Added.
1357         * UserInterface/Images/gtk/TextAlignLeft.svg: Added.
1358         * UserInterface/Images/gtk/TextAlignRight.svg: Added.
1359         * UserInterface/Images/gtk/TextDecorationLineThrough.svg: Added.
1360         * UserInterface/Images/gtk/TextDecorationOverline.svg: Added.
1361         * UserInterface/Images/gtk/TextDecorationUnderline.svg: Added.
1362         * UserInterface/Images/gtk/TextTransformCapitalize.svg: Added.
1363         * UserInterface/Images/gtk/TextTransformLowercase.svg: Added.
1364         * UserInterface/Images/gtk/TextTransformUppercase.svg: Added.
1365         * UserInterface/Images/gtk/VisualStyleNone.svg: Added.
1366
1367 2015-09-30  Joseph Pecoraro  <pecoraro@apple.com>
1368
1369         Web Inspector: Reduce `delete` in Timeline related classes
1370         https://bugs.webkit.org/show_bug.cgi?id=149686
1371
1372         Reviewed by Timothy Hatcher.
1373
1374         * UserInterface/Controllers/TimelineManager.js:
1375         (WebInspector.TimelineManager.prototype.capturingStopped):
1376         * UserInterface/Views/TimelineDataGrid.js:
1377         (WebInspector.TimelineDataGrid.prototype._refreshDirtyDataGridNodes):
1378         (WebInspector.TimelineDataGrid.prototype._sort):
1379         (WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode):
1380         * UserInterface/Views/TimelineOverview.js:
1381         (WebInspector.TimelineOverview.prototype.updateLayout):
1382         (WebInspector.TimelineOverview.prototype._handleScrollEvent):
1383         * UserInterface/Views/TreeOutlineDataGridSynchronizer.js:
1384         (WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeOutlineScrolled):
1385         (WebInspector.TreeOutlineDataGridSynchronizer.prototype._dataGridScrolled):
1386
1387         * UserInterface/Views/ProbeSetDataGrid.js:
1388         (WebInspector.ProbeSetDataGrid):
1389         (WebInspector.ProbeSetDataGrid.prototype._teardownData):
1390         Remove an unused member variable as well.
1391
1392 2015-09-30  Joseph Pecoraro  <pecoraro@apple.com>
1393
1394         Web Inspector: Thousands of timers fire after switching to JavaScript and Events timeline
1395         https://bugs.webkit.org/show_bug.cgi?id=149682
1396
1397         Reviewed by Timothy Hatcher.
1398
1399         Setting the status element of a GeneralTreeElement was triggering a
1400         TreeOutline.onchange event. For TreeOutlines with lots of tree elements
1401         (JavaScript & Events with profile nodes) this could result in thousands
1402         of onchange events that causes lots of unnecessary work and blocks
1403         future timers (like scroll synchronization) from firing.
1404
1405         This change eliminates TreeOutline change events for tree element
1406         changes that are not interesting.
1407
1408         * UserInterface/Views/GeneralTreeElement.js:
1409         (WebInspector.GeneralTreeElement.prototype.set status): Deleted.
1410         * UserInterface/Views/TreeOutline.js:
1411         (WebInspector.TreeElement.prototype.set tooltip): Deleted.
1412
1413 2015-09-30  Joseph Pecoraro  <pecoraro@apple.com>
1414
1415         Web Inspector: Reduce `delete` in TreeElements and DataGridNodes
1416         https://bugs.webkit.org/show_bug.cgi?id=149680
1417
1418         Reviewed by Timothy Hatcher.
1419
1420         * UserInterface/Views/BreakpointTreeElement.js:
1421         (WebInspector.BreakpointTreeElement):
1422         (WebInspector.BreakpointTreeElement.prototype._removeProbeSet):
1423         * UserInterface/Views/DataGrid.js:
1424         (WebInspector.DataGrid.prototype._editingCommitted.moveToNextCell):
1425         (WebInspector.DataGrid.prototype._editingCommitted):
1426         (WebInspector.DataGrid.prototype._editingCancelled):
1427         (WebInspector.DataGrid.prototype.removeColumn):
1428         (WebInspector.DataGridNode.prototype.refreshIfNeeded):
1429         (WebInspector.DataGridNode.prototype.refresh):
1430         (WebInspector.DataGridNode.prototype.expand):
1431         (WebInspector.DataGridNode.prototype.restorePosition):
1432         (WebInspector.DataGridNode):
1433         * UserInterface/Views/GeneralTreeElement.js:
1434         (WebInspector.GeneralTreeElement.prototype.ondetach):
1435         * UserInterface/Views/ResourceTimelineDataGridNode.js:
1436         (WebInspector.ResourceTimelineDataGridNode.prototype.refresh):
1437         * UserInterface/Views/TreeOutline.js:
1438         (WebInspector.TreeElement.prototype._fireDidChange):
1439         (WebInspector.TreeElement.prototype.expand):
1440
1441 2015-09-30  Andres Gomez  <agomez@igalia.com>
1442
1443         [GTK] Web Inspector: Add GTK+ icon for the Bezier curve visual editor
1444         https://bugs.webkit.org/show_bug.cgi?id=147681
1445
1446         Reviewed by Joseph Pecoraro.
1447
1448         * UserInterface/Images/gtk/CubicBezier.svg: Added.
1449
1450 2015-09-29  Joseph Pecoraro  <pecoraro@apple.com>
1451
1452         Web Inspector: Console completion suggestions should include properties on Object (hasOwnProperty, toString, etc)
1453         https://bugs.webkit.org/show_bug.cgi?id=149649
1454
1455         Reviewed by Darin Adler.
1456
1457         * UserInterface/Base/Utilities.js:
1458         (value):
1459         Since keySets in this instance are often used as hash maps with the
1460         `in` operator, create a blank object that won't have Object.prototype
1461         functions that would be seen by `in`.
1462
1463         * UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
1464         (WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.receivedPropertyNames.compare):
1465         Sort __defineGetter__ and __lookupGetter__ and friends last, since they
1466         are rarely used properties.
1467
1468 2015-09-29  Joseph Pecoraro  <pecoraro@apple.com>
1469
1470         Web Inspector: Missing completions for Symbol objects, console.error warning
1471         https://bugs.webkit.org/show_bug.cgi?id=149641
1472
1473         Reviewed by Darin Adler.
1474
1475         * UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
1476         (WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.getCompletions):
1477         (WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.evaluated):
1478         Include completions for symbol types.
1479
1480 2015-09-28  Joseph Pecoraro  <pecoraro@apple.com>
1481
1482         Web Inspector: Hitting ESC while editing element tag name leaves element in bad state
1483         https://bugs.webkit.org/show_bug.cgi?id=149506
1484
1485         Reviewed by Timothy Hatcher.
1486
1487         * UserInterface/Views/DOMTreeElement.js:
1488         (WebInspector.DOMTreeElement.prototype._startEditingTagName.editingCancelled):
1489         (WebInspector.DOMTreeElement.prototype._startEditingTagName):
1490         When cancelling editing of a tag name, revert any changes we had
1491         been making to the closing tag name.
1492
1493 2015-09-28  João Oliveira  <hello@jxs.pt>
1494
1495         Web Inspector: search shortcut in split console moves focus to search box, but doesn't show caret
1496         https://bugs.webkit.org/show_bug.cgi?id=149223
1497
1498         Reviewed by Timothy Hatcher.
1499
1500         When pressing console find shortcut (CMD+F) SearchBar now checks if there's text on _searchInput
1501         if so text is selected, if the textbox is empty, textbox gains focus.
1502
1503         * UserInterface/Views/SearchBar.js:
1504         (WebInspector.SearchBar.prototype.focus):
1505
1506 2015-09-25  Joseph Pecoraro  <pecoraro@apple.com>
1507
1508         Web Inspector: Reloading the page causes the inspector tab to switch back to "Resources" tab
1509         https://bugs.webkit.org/show_bug.cgi?id=148732
1510
1511         Reviewed by Darin Adler.
1512
1513         * UserInterface/Views/ResourceSidebarPanel.js:
1514         (WebInspector.ResourceSidebarPanel.prototype._scriptsCleared):
1515         Suppress selection of sibiling tree elements when removing extra folders.
1516
1517 2015-09-24  Ryosuke Niwa  <rniwa@webkit.org>
1518
1519         Ran sort-Xcode-project-file.
1520
1521         * WebInspectorUI.xcodeproj/project.pbxproj:
1522
1523 2015-09-23  Saam barati  <sbarati@apple.com>
1524
1525         Fix broken inspector tests.
1526
1527         Reviewed by Joseph Pecoraro and Brian Burg.
1528
1529         We can't redeclare a "let" variable and "var" variable using the same
1530         identifier at the top-level of a function.
1531
1532         * UserInterface/Test/InspectorProtocol.js:
1533         (InspectorProtocol.sendCommand):
1534         (InspectorProtocol.addEventListener):
1535         (InspectorProtocol.dispatchMessageFromBackend):
1536
1537 2015-09-23  Saam barati  <sbarati@apple.com>
1538
1539         Web Inspector: Don't use bind() when creating internal AST, instead, pass in "this" parameter to map()
1540         https://bugs.webkit.org/show_bug.cgi?id=149483
1541
1542         Reviewed by Joseph Pecoraro.
1543
1544         * UserInterface/Models/ScriptSyntaxTree.js:
1545         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
1546         (WebInspector.ScriptSyntaxTree):
1547
1548 2015-09-23  Saam barati  <sbarati@apple.com>
1549
1550         Web Inspector: Type bubbles missing for computed methods and methods on object literals
1551         https://bugs.webkit.org/show_bug.cgi?id=148562
1552
1553         Reviewed by Joseph Pecoraro.
1554
1555         This patch makes sure that computed methods are working
1556         for both classes and object literals. Also, methods now
1557         work on object literals. This patch also cleans up the
1558         "isGetterOrSetter" and "getterOrSetterRange" fields.
1559         Basically, we used this as a way to ask the type profiler
1560         for the return types of a function. Now, we just have
1561         a field called "typeProfilingReturnDivot" that is set
1562         on all functions so we don't need to conditionally ask
1563         if it's a getter or setter.
1564
1565         * UserInterface/Controllers/TypeTokenAnnotator.js:
1566         (WebInspector.TypeTokenAnnotator.prototype._insertTypeToken):
1567         * UserInterface/Models/ScriptSyntaxTree.js:
1568         (WebInspector.ScriptSyntaxTree.functionReturnDivot):
1569         (WebInspector.ScriptSyntaxTree.prototype._recurseArray):
1570         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
1571         (WebInspector.ScriptSyntaxTree):
1572
1573 2015-09-22  Devin Rousso  <dcrousso+webkit@gmail.com>
1574
1575         Web Inspector: The right sidebar always opens up on breakpoint
1576         https://bugs.webkit.org/show_bug.cgi?id=149261
1577
1578         Reviewed by Timothy Hatcher.
1579
1580         Whenever the debugger was paused, the sidebar was being forced to open.
1581         This has been removed in favor of letting the user decide.
1582
1583         * UserInterface/Base/Main.js:
1584         (WebInspector._debuggerDidPause):
1585
1586 2015-09-22  Saam barati  <sbarati@apple.com>
1587
1588         Web Inspector: [ES6] Improve Type Profiler Support for Arrow Functions
1589         https://bugs.webkit.org/show_bug.cgi?id=143171
1590
1591         Reviewed by Joseph Pecoraro.
1592
1593         Esprima and JSC both support arrow functions. We just
1594         need to support it in our AST and do the right things
1595         to include support in the type profiler bits.
1596
1597         * UserInterface/Controllers/TypeTokenAnnotator.js:
1598         (WebInspector.TypeTokenAnnotator.prototype._insertTypeToken):
1599         (WebInspector.TypeTokenAnnotator.prototype._translateToOffsetAfterFunctionParameterList.isLineTerminator):
1600         (WebInspector.TypeTokenAnnotator.prototype._translateToOffsetAfterFunctionParameterList):
1601         * UserInterface/Models/ScriptSyntaxTree.js:
1602         (WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement.removeFunctionsFilter):
1603         (WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement):
1604         (WebInspector.ScriptSyntaxTree.functionReturnDivot):
1605         (WebInspector.ScriptSyntaxTree.prototype._recurse):
1606         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
1607         (WebInspector.ScriptSyntaxTree):
1608
1609 2015-09-22  Saam barati  <sbarati@apple.com>
1610
1611         Web Inspector: update Esprima to latest version
1612         https://bugs.webkit.org/show_bug.cgi?id=148960
1613
1614         Reviewed by Joseph Pecoraro.
1615
1616         Esprima version 2.6 further supports ES6. We're
1617         updating to it so we can support more ES6 features
1618         in our script syntax tree.
1619
1620         * UserInterface/External/Esprima/LICENSE:
1621         * UserInterface/External/Esprima/esprima.js:
1622         * UserInterface/Models/ScriptSyntaxTree.js:
1623         (WebInspector.ScriptSyntaxTree.prototype._gatherIdentifiersInDeclaration.gatherIdentifiers):
1624         (WebInspector.ScriptSyntaxTree.prototype._gatherIdentifiersInDeclaration):
1625         (WebInspector.ScriptSyntaxTree.prototype._recurse):
1626         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
1627         (WebInspector.ScriptSyntaxTree):
1628
1629 2015-09-21  Matt Baker  <mattbaker@apple.com>
1630
1631         Web Inspector: requestAnimationFrame continues to be called after stopping the timeline recording
1632         https://bugs.webkit.org/show_bug.cgi?id=149390
1633
1634         Reviewed by Brian Burg.
1635
1636         * UserInterface/Views/TimelineRecordingContentView.js:
1637         (WebInspector.TimelineRecordingContentView.prototype._update):
1638         Stop calling requestAnimationFrame if this._updating is false and recording end time is NaN.
1639
1640 2015-09-17  Joseph Pecoraro  <pecoraro@apple.com>
1641
1642         Web Inspector: Simplify some functional callbacks
1643         https://bugs.webkit.org/show_bug.cgi?id=149333
1644
1645         Reviewed by Brian Burg.
1646
1647         * UserInterface/Controllers/LogManager.js:
1648         (WebInspector.LogManager.prototype.messageWasAdded):
1649         * UserInterface/Models/Color.js:
1650         (WebInspector.Color):
1651         * UserInterface/Models/Geometry.js:
1652         (WebInspector.CubicBezier.fromCoordinates):
1653         * UserInterface/Models/ObjectPreview.js:
1654         (WebInspector.ObjectPreview.fromPayload):
1655         * UserInterface/Models/TypeDescription.js:
1656         (WebInspector.TypeDescription.fromPayload):
1657         * UserInterface/Protocol/RemoteObject.js:
1658         (WebInspector.RemoteObject.prototype.getCollectionEntries):
1659         (WebInspector.RemoteObject.prototype.getCollectionEntries.): Deleted.
1660         * UserInterface/Views/TextEditor.js:
1661         (WebInspector.TextEditor.prototype.get markers):
1662         (WebInspector.TextEditor.prototype.markersAtPosition):
1663
1664 2015-09-17  Joseph Pecoraro  <pecoraro@apple.com>
1665
1666         Web Inspector: Remove unused canClearBrowserCookies / canClearBrowserCache protocol methods
1667         https://bugs.webkit.org/show_bug.cgi?id=149307
1668
1669         Reviewed by Brian Burg.
1670
1671         * UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
1672         * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
1673         * UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
1674         * Versions/Inspector-iOS-7.0.json:
1675         * Versions/Inspector-iOS-8.0.json:
1676         * Versions/Inspector-iOS-9.0.json:
1677         Retroactively remove the protocol methods as they were unused
1678         in these earlier versions as well.
1679
1680 2015-09-17  Joseph Pecoraro  <pecoraro@apple.com>
1681
1682         REGRESSION: Web Inspector: Double clicking on an attribute second time doesn't work
1683         https://bugs.webkit.org/show_bug.cgi?id=149259
1684
1685         Reviewed by Timothy Hatcher.
1686
1687         * UserInterface/Views/DOMTreeElement.js:
1688         Be sure to clear the editing state when committed, even if the value did not change.
1689
1690 2015-09-17  Joseph Pecoraro  <pecoraro@apple.com>
1691
1692         Web Inspector: Make Find / Save keyboard shortcuts work better globally
1693         https://bugs.webkit.org/show_bug.cgi?id=149198
1694
1695         Reviewed by Brian Burg.
1696
1697         Previously find/save keyboard shortcuts required the user have the
1698         ContentView in the ContentBrowser focused. That means nothing would
1699         happen if you clicked / focused in the Sidebars. This change considers
1700         the keyboard shortcuts globally, like Copy.
1701
1702         * UserInterface/Base/Main.js:
1703         (WebInspector.contentLoaded):
1704         Add global find and save keyboard shortcuts.
1705
1706         (WebInspector._focusChanged):
1707         It is often useful to have the currentFocusedElement know if it is
1708         in a TextEditor or other CodeMirror editor. When editable the <textarea>
1709         is selected and not updating focused element. 
1710
1711         (WebInspector._focusedContentBrowser):
1712         (WebInspector._focusedContentView):
1713         Provide helpers for getting a good approximation of the current focused
1714         or visible content view that users would expect to be interacting with.
1715         Since the focus event may not fire when clicking around to elements
1716         like the <body>. Rather than make it explicitly focusable, check the
1717         document.activeElement, and if it is body aim for the main content
1718         browser instead of the currentFocusedElement which may be stale.
1719         Likewise, if the QuickConsole is focused and the split console is
1720         showing, treat it like the split browser is focused.
1721
1722         (WebInspector._focusedOrVisibleContentBrowser):
1723         (WebInspector._focusedOrVisibleContentView):
1724         If nothing is focused, default to the main content browser.
1725
1726         (WebInspector._find):
1727         Pass on to the ContentView which typically handles Find
1728         by showing its find banner.
1729
1730         (WebInspector._save):
1731         (WebInspector._saveAs):
1732         Check and save the current ContentView if supported.
1733
1734         * UserInterface/Views/LogContentView.js:
1735         (WebInspector.LogContentView.prototype.get supportsSearch):
1736         (WebInspector.LogContentView.prototype.handleFindEvent):
1737         Add custom find handling for LogContentView from the routed through the
1738         BrowserController instead of special event handlers in the controller.
1739
1740         (WebInspector.LogContentView.prototype.get supportsSave):
1741         (WebInspector.LogContentView.prototype.save): Deleted.
1742         (WebInspector.LogContentView.prototype.saveAs): Deleted.
1743         * UserInterface/Controllers/JavaScriptLogViewController.js:
1744         (WebInspector.JavaScriptLogViewController): Deleted.
1745         (WebInspector.JavaScriptLogViewController.prototype._handleFindShortcut): Deleted.
1746         (WebInspector.JavaScriptLogViewController.prototype._save): Deleted.
1747         (WebInspector.JavaScriptLogViewController.prototype._saveAs): Deleted.
1748         Special save handling is no longer needed in the log view controller.
1749
1750         * UserInterface/Views/ContentBrowser.js:
1751         (WebInspector.ContentBrowser.prototype.handleFindEvent):
1752         (WebInspector.ContentBrowser): Deleted.
1753         (WebInspector.ContentBrowser.prototype._save): Deleted.
1754         (WebInspector.ContentBrowser.prototype._saveAs): Deleted.
1755         (WebInspector.ContentBrowser.prototype._showFindBanner): Deleted.
1756         Save functionality moved globally, find functionality moved to a
1757         public method called like copy event handling.
1758
1759 2015-09-17  Joseph Pecoraro  <pecoraro@apple.com>
1760
1761         Web Inspector: Inactive window may cause many layers to be created due to Dashboard opacity
1762         https://bugs.webkit.org/show_bug.cgi?id=149274
1763
1764         Reviewed by Brian Burg.
1765
1766         The dashboard container gets an opacity when the window is inactive. Combined
1767         with the animating debugger continue button this caused a cascade of slightly
1768         overlapping content causing a cascade of a lot of small layers. The simple
1769         approach taken here is to stop the slight pulse animation when the window
1770         is inactive.
1771
1772         * UserInterface/Views/DebuggerDashboardView.css:
1773         (body.window-inactive .dashboard.debugger .navigation-bar .item.button > .glyph):
1774
1775 2015-09-17  Devin Rousso  <dcrousso+webkit@gmail.com>
1776
1777         REGRESSION(r188427): Web Inspector: Extra whitespace left behind in styles sidebar after clicking in and out
1778         https://bugs.webkit.org/show_bug.cgi?id=149197
1779
1780         Reviewed by Timothy Hatcher.
1781
1782         In r188427, logic was added to preserve the leading whitespace of styles in a CSS file.
1783         An unfortunate side effect of this was that extra newlines in between CSS properties
1784         were treated as valid and left where they were.  This is undesired behaviour and often
1785         clutters the styles sidebar.  These changes remove the extra newlines.
1786
1787         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
1788         (WebInspector.CSSStyleDeclarationTextEditor.prototype._formattedContent):
1789
1790 2015-09-16  Joseph Pecoraro  <pecoraro@apple.com>
1791
1792         Web Inspector: Reduce Annotation Update Frequency
1793         https://bugs.webkit.org/show_bug.cgi?id=149250
1794
1795         Reviewed by Saam Barati.
1796
1797         * UserInterface/Controllers/BasicBlockAnnotator.js:
1798         (WebInspector.BasicBlockAnnotator.prototype._annotateBasicBlockExecutionRanges):
1799         * UserInterface/Controllers/TypeTokenAnnotator.js:
1800         (WebInspector.BasicBlockAnnotator.prototype.insertAnnotations):
1801         Set a lower bound of 500ms on update frequency for both annotators.
1802
1803 2015-09-16  Joseph Pecoraro  <pecoraro@apple.com>
1804
1805         Web Inspector: Fix common typo "supress" => "suppress"
1806         https://bugs.webkit.org/show_bug.cgi?id=149199
1807
1808         Reviewed by Gyuyoung Kim.
1809
1810         * UserInterface/Views/DataGrid.js:
1811         (WebInspector.DataGridNode.prototype.select):
1812         (WebInspector.DataGridNode.prototype.deselect):
1813         * UserInterface/Views/SearchBar.js:
1814         (WebInspector.SearchBar):
1815
1816 2015-09-16  Joseph Pecoraro  <pecoraro@apple.com>
1817
1818         Web Inspector: Turn off line wrapping in resource text editors
1819         https://bugs.webkit.org/show_bug.cgi?id=149121
1820
1821         Reviewed by Darin Adler.
1822
1823         * UserInterface/Views/TextEditor.js:
1824         (WebInspector.TextEditor):
1825
1826 2015-09-15  Devin Rousso  <dcrousso+webkit@gmail.com>
1827
1828         Web Inspector: Picking unchanged for font-size does not reset back to the unchanged value
1829         https://bugs.webkit.org/show_bug.cgi?id=148351
1830
1831         Reviewed by Brian Burg.
1832
1833         Visual number editors now save any new values in the special placeholder element
1834         to display it whenever the "Unchanged" option is selected by the user.
1835
1836         * UserInterface/Views/VisualStyleNumberInputBox.js:
1837         (WebInspector.VisualStyleNumberInputBox.prototype.set value):
1838         (WebInspector.VisualStyleNumberInputBox.prototype.set units):
1839         (WebInspector.VisualStyleNumberInputBox.prototype._setNumberInputIsEditable):
1840         (WebInspector.VisualStyleNumberInputBox.prototype._keywordChanged):
1841         (WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputKeyDown.adjustValue):
1842         (WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputKeyDown):
1843
1844 2015-09-15  Brian Burg  <bburg@apple.com>
1845
1846         Web Inspector: command-click in NewTabContentView should open new tab without switching to it
1847         https://bugs.webkit.org/show_bug.cgi?id=149173
1848
1849         Reviewed by Joseph Pecoraro.
1850
1851         To allow a user to quickly restore tabs, it should be possible to command-click
1852         all the tabs that are desired without going back through the [+] tab button.
1853
1854         * UserInterface/Base/Main.js:
1855         (WebInspector.createNewTabWithType): Renamed.
1856
1857             Use an options object and split creating the tab from deleting the
1858             replaced tab and showing the new tab. Add better error checking.
1859
1860         (WebInspector.createNewTab): Deleted.
1861         * UserInterface/Views/NewTabContentView.js:
1862         (WebInspector.NewTabContentView):
1863         (WebInspector.NewTabContentView.prototype._createNewTabWithType): Renamed.
1864
1865             If the meta key is pressed, don't switch to the new tab or remove this view
1866             unless there are no more tabs that can be created beyond the current one.
1867
1868         (WebInspector.NewTabContentView.prototype._allowableTabTypes): Added.
1869         (WebInspector.NewTabContentView.prototype._createNewTab): Deleted.
1870
1871 2015-09-15  Joseph Pecoraro  <pecoraro@apple.com>
1872
1873         Web Inspector: Watch Expressions uncaught exceptions on page reload
1874         https://bugs.webkit.org/show_bug.cgi?id=149150
1875
1876         Reviewed by Brian Burg.
1877
1878         Instead of waiting 50ms to Resume, when the page navigates
1879         Resume immediately. This ensures nobody is using a stale
1880         activeCallFrame after the navigation.
1881
1882         Also clean up the manager a bit by removing some deletes.
1883
1884         * UserInterface/Controllers/DebuggerManager.js:
1885         (WebInspector.DebuggerManager.restoreBreakpointsSoon):
1886         (WebInspector.DebuggerManager.prototype.reset):
1887         (WebInspector.DebuggerManager.prototype.debuggerDidPause):
1888         (WebInspector.DebuggerManager.prototype.debuggerDidResume):
1889         (WebInspector.DebuggerManager.prototype._mainResourceDidChange):
1890         (WebInspector.DebuggerManager.prototype._didResumeInternal):
1891         (WebInspector.DebuggerManager.prototype._associateBreakpointsWithSourceCode):
1892         (WebInspector.DebuggerManager.prototype.debuggerDidResume.delayedWork): Deleted.
1893
1894 2015-09-15  Joseph Pecoraro  <pecoraro@apple.com>
1895
1896         Web Inspector: Closing the final inspector tab should be allowed
1897         https://bugs.webkit.org/show_bug.cgi?id=149130
1898
1899         Reviewed by Brian Burg.
1900
1901         Previously we did not allow closing the last inspector tab. Now, we
1902         will allow closing all inspector tabs, and when the last is closed,
1903         present an unclosable New Tab tab, which would then be used to create
1904         a new tab.
1905
1906         * UserInterface/Base/Main.js:
1907         (WebInspector.contentLoaded):
1908         If we have no tabs to restore, show the New Tab tab.
1909
1910         (WebInspector._openDefaultTab):
1911         When the last tab is closed, the tab bar requests we open a default tab.
1912         Open the New Tab tab.
1913
1914         (WebInspector.TabBar.prototype._handleClick):
1915         Disallow closing the single default tab.
1916
1917         (WebInspector._newTabItemClicked):
1918         (WebInspector.showNewTabTab):
1919         Share logic for showing the New Tab tab.
1920
1921         * UserInterface/Views/NewTabContentView.js:
1922         (WebInspector.NewTabContentView):
1923         Mark the new tab's tab bar item as the "default" tab bar item. It gets
1924         special behavior when it is the single normal tab (cannot be closed).
1925
1926         * UserInterface/Views/TabBar.css:
1927         (body:not(.window-inactive) .tab-bar > .item:hover > .close):
1928         (body:not(.window-inactive) .tab-bar.single-tab > .item.default-tab:hover > .close):
1929         (.tab-bar.single-tab > .item.default-tab > .close):
1930         (body:not(.window-inactive) .tab-bar:not(.single-tab) > .item:not(.hide-close-button):hover > .close): Deleted.
1931         (.tab-bar > .item.hide-close-button > .close): Deleted.
1932         Update styles to only disable the close button on the
1933         "default-tab" when it is the "single-tab" open. Otherwise
1934         always allow closing tabs.
1935
1936         * UserInterface/Views/TabBar.js:
1937         (WebInspector.TabBar.prototype.removeTabBarItem):
1938         (WebInspector.TabBar.prototype.hasNormalTab):
1939         (WebInspector.TabBar.prototype._openDefaultTab):
1940         When removing the last normal tab, send an event to open
1941         the default tab.
1942
1943         * UserInterface/Views/TabBarItem.js:
1944         (WebInspector.TabBarItem.prototype.get default):
1945         (WebInspector.TabBarItem.prototype.get isDefaultTab):
1946         (WebInspector.TabBarItem.prototype.set isDefaultTab):
1947         (WebInspector.TabBarItem.prototype.get hideCloseButton): Deleted.
1948         (WebInspector.TabBarItem.prototype.set hideCloseButton): Deleted.
1949         Switch to marking a tab bar item as the default tab. This tab
1950         will be allowed when it is the single remaining tab. Currently
1951         the default tab is always the "New Tab" tab.
1952
1953 2015-09-15  Brian Burg  <bburg@apple.com>
1954
1955         Web Inspector: new tab content view should disallow split console
1956         https://bugs.webkit.org/show_bug.cgi?id=149164
1957
1958         Reviewed by Joseph Pecoraro.
1959
1960         * UserInterface/Views/NewTabContentView.js:
1961         (WebInspector.NewTabContentView.prototype.get supportsSplitContentBrowser):
1962
1963 2015-09-14  Brian Burg  <bburg@apple.com>
1964
1965         Web Inspector: tab bar stutters when moving mouse after closing tab
1966         https://bugs.webkit.org/show_bug.cgi?id=149138
1967
1968         Reviewed by Joseph Pecoraro.
1969
1970         The tab bar lacked the 'static-layout' class between when the Promise microtask
1971         ran and the beginning of the requestAnimationFrame. This caused a flash of
1972         tabs that are way too wide.
1973
1974         Re-add the static-layout class immediately after measuring the 'after' tab size.
1975         This code should probably just manually compute tab sizes since flexbox
1976         layout is quite slow and our measurement code here forces layout several times.
1977
1978         * UserInterface/Views/TabBar.js:
1979
1980 2015-09-14  Brian Burg  <bburg@apple.com>
1981
1982         Web Inspector: backend command promises are not rejected when a protocol error occurs
1983         https://bugs.webkit.org/show_bug.cgi?id=141403
1984
1985         Reviewed by Joseph Pecoraro.
1986
1987         Fix a few corner cases for how InspectorBackend delivers command failures.
1988
1989         * UserInterface/Protocol/InspectorBackend.js:
1990         (InspectorBackend.Command.prototype.deliverFailure): Added.
1991         (InspectorBackend.Command.prototype._invokeWithArguments):
1992
1993             If argument-checking fails, return a rejected promise or invoke the supplied callback
1994             on a zero-delay setTimeout to ensure that the reply is asynchronous.
1995
1996 2015-09-14  Brian Burg  <bburg@apple.com>
1997
1998         Web Inspector: middle-clicking a tab in the tab bar should close it
1999         https://bugs.webkit.org/show_bug.cgi?id=149135
2000
2001         Reviewed by Joseph Pecoraro.
2002
2003         This matches the behavior of the tab bar in Safari and other browsers.
2004
2005         * UserInterface/Views/TabBar.js:
2006         (WebInspector.TabBar.prototype._handleMouseDown):
2007         (WebInspector.TabBar.prototype._handleClick):
2008
2009 2015-09-14  Nikita Vasilyev  <nvasilyev@apple.com>
2010
2011         Web Inspector: Border under the styles filter field is clipped
2012         https://bugs.webkit.org/show_bug.cgi?id=149115
2013
2014         Reviewed by Darin Adler.
2015
2016         * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
2017         (.sidebar > .panel.details.css-style > .content + .options-container > .filter-bar):
2018
2019 2015-09-11  Nan Wang  <n_wang@apple.com>
2020
2021         AX: ARIA 1.1 @aria-current
2022         https://bugs.webkit.org/show_bug.cgi?id=146012
2023
2024         Reviewed by Chris Fleizach.
2025
2026         Added support for ARIA 1.1 aria-current.
2027
2028         * Localizations/en.lproj/localizedStrings.js:
2029         * UserInterface/Models/DOMNode.js:
2030         * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
2031
2032 2015-09-10  Devin Rousso  <dcrousso+webkit@gmail.com>
2033
2034         Web Inspector: Styles sidebar says Media: all when it should say Media: screen
2035         https://bugs.webkit.org/show_bug.cgi?id=148436
2036
2037         Reviewed by Timothy Hatcher.
2038
2039         Removed filter that prevented "Media: screen" from being displayed.
2040
2041         * UserInterface/Views/RulesStyleDetailsPanel.js:
2042         (WebInspector.RulesStyleDetailsPanel.prototype.refresh.insertMediaOrInheritanceLabel):
2043         (WebInspector.RulesStyleDetailsPanel.prototype.refresh.filteredMediaList): Deleted.
2044
2045 2015-09-10  Matt Baker  <mattbaker@apple.com>
2046
2047         Web Inspector: Prefer calling ContentViewContainer.updateLayout directly
2048         https://bugs.webkit.org/show_bug.cgi?id=149041
2049
2050         Reviewed by Timothy Hatcher.
2051
2052         Cleaned up two places where a parent view duplicated logic encapsulated by ContentViewContainer.
2053
2054         * UserInterface/Views/ClusterContentView.js:
2055         (WebInspector.ClusterContentView.prototype.updateLayout):
2056         * UserInterface/Views/TimelineRecordingContentView.js:
2057         (WebInspector.TimelineRecordingContentView.prototype.updateLayout):
2058
2059 2015-09-08  Matt Baker  <mattbaker@apple.com>
2060
2061         Web Inspector: REGRESSION (r189189): Missing breakpoint context menu for debugger sidebar tree elements
2062         https://bugs.webkit.org/show_bug.cgi?id=148651
2063
2064         Reviewed by Timothy Hatcher.
2065
2066         * UserInterface/Base/Main.js:
2067         (WebInspector.contentLoaded):
2068         Create BreakpointPopoverController singleton, expose as public property of global WebInspector object.
2069
2070         * UserInterface/Views/BreakpointTreeElement.js:
2071         (WebInspector.BreakpointTreeElement.prototype.oncontextmenu):
2072         Use BreakpointPopoverController singleton.
2073
2074         * UserInterface/Views/SourceCodeTextEditor.js:
2075         (WebInspector.SourceCodeTextEditor):
2076         Don't create BreakpointPopoverController instance.
2077         (WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu):
2078         Use BreakpointPopoverController singleton.
2079
2080 2015-09-08  Joseph Pecoraro  <pecoraro@apple.com>
2081
2082         Fix inspector/codemirror tests.
2083
2084         Rubber-stamped by Brian Burg.
2085
2086         * UserInterface/Test.html:
2087         Reorder includes to be more like Main.html. This ensures that CodeMirror
2088         resources are loaded before Inspector sources use it, like CodeMirrorAdditions
2089         which gets merged into TestCombined.js.
2090
2091 2015-09-08  Joseph Pecoraro  <pecoraro@apple.com>
2092
2093         Web Inspector: Move PrettyPrinting tests into LayoutTests
2094         https://bugs.webkit.org/show_bug.cgi?id=148698
2095
2096         Reviewed by Timothy Hatcher.
2097
2098         * Tools/PrettyPrinting/index.html:
2099         Modify the relative path to the tests which are now in LayoutTests.
2100
2101         * UserInterface/Test.html:
2102         Load CodeMirror and related resources for Formatting.
2103
2104 2015-09-06  Andy Estes  <aestes@apple.com>
2105
2106         WebKit.xcworkspace should be be able to build iOS platforms
2107         https://bugs.webkit.org/show_bug.cgi?id=148881
2108
2109         Reviewed by Daniel Bates.
2110
2111         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
2112         for all supported platforms.
2113
2114         * Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
2115         * Configurations/WebInspectorUIFramework.xcconfig: Skipped installing on iOS.
2116
2117 2015-09-04  Brian Burg  <bburg@apple.com>
2118
2119         Web Inspector: combine Test.html resources to make tests run faster
2120         https://bugs.webkit.org/show_bug.cgi?id=148726
2121
2122         Reviewed by Timothy Hatcher.
2123
2124         In an attempt to make inspector tests run faster, always combine resources
2125         on the Test.html page. This cuts down from 110+ resource loads to 5 loads.
2126
2127         To avoid name clashes, add the 'Combined' suffix to files that would clash
2128         with uncombined Test resources, and add the 'Test' prefix when combining
2129         or minifying files that would clash with production minification. So, it
2130         would be possible for Main.html and Test.html to have different minified
2131         versions of CodeMirror or other external libraries if they use different
2132         subsets.
2133
2134         Combining is unlikely to make debugging tests more difficult, since almost
2135         all test code is marshalled and eval'd into existence anyway.
2136
2137         * Configurations/WebInspectorUIFramework.xcconfig:
2138         * Scripts/combine-resources.pl: Drive-by spelling.
2139         (concatenateFiles):
2140         (concatinateFiles): Deleted.
2141         * Scripts/copy-user-interface-resources-dryrun.rb:
2142         * Scripts/copy-user-interface-resources.pl:
2143
2144             Drive-by spelling. Add a new code path for combining Test resources, which
2145             doesn't require minification or handling CSS, images, or most externals.
2146
2147         * WebInspectorUI.vcxproj/build-webinspectorui.pl:
2148
2149             Always combine Test.html, but also ditto everything into place for
2150             engineering builds.
2151
2152 2015-09-04  Joseph Pecoraro  <pecoraro@apple.com>
2153
2154         Web Inspector: Test Runtime.saveResult and $n values
2155         https://bugs.webkit.org/show_bug.cgi?id=148837
2156
2157         Reviewed by Timothy Hatcher.
2158
2159         * UserInterface/Protocol/InspectorBackend.js:
2160         (InspectorBackendClass):
2161         Initialize the dump logging function different if we are in tests or not.
2162         When in tests, using console.log as well as dumping system activity to
2163         the system console results in an infinite loop of logging!
2164
2165         (InspectorBackendClass.prototype.dispatch):
2166         (InspectorBackendClass.prototype._sendCommandToBackendWithCallback):
2167         Use the logging function we figured out earlier.
2168
2169 2015-09-04  Joseph Pecoraro  <pecoraro@apple.com>
2170
2171         Web Inspector: Clean up and modernize DOMTreeManager
2172         https://bugs.webkit.org/show_bug.cgi?id=148821
2173
2174         Reviewed by Timothy Hatcher.
2175
2176         * UserInterface/Controllers/DOMTreeManager.js:
2177         (WebInspector.DOMTreeManager.prototype.requestDocument.onDocumentAvailable):
2178         (WebInspector.DOMTreeManager.prototype.requestDocument):
2179         (WebInspector.DOMTreeManager.prototype.pushNodeByPathToFrontend):
2180         (WebInspector.DOMTreeManager.prototype._wrapClientCallback):
2181         (WebInspector.DOMTreeManager.prototype._attributeModified):
2182         (WebInspector.DOMTreeManager.prototype._attributeRemoved):
2183         (WebInspector.DOMTreeManager.prototype._inlineStyleInvalidated):
2184         (WebInspector.DOMTreeManager.prototype._loadNodeAttributes):
2185         (WebInspector.DOMTreeManager.prototype.cancelSearch):
2186         (WebInspector.DOMTreeManager.prototype.querySelector):
2187         (WebInspector.DOMTreeManager.prototype.querySelectorAll):
2188         (WebInspector.DOMTreeManager.prototype.highlightDOMNode):
2189         (WebInspector.DOMTreeManager.prototype._buildHighlightConfig):
2190         Cleanup and modernize where appropriate.
2191
2192         * UserInterface/Views/SearchSidebarPanel.js:
2193         (WebInspector.SearchSidebarPanel.prototype.performSearch):
2194         Callback is now required.
2195
2196 2015-09-04  Matt Baker  <mattbaker@apple.com>
2197
2198         Web Inspector: Render Frames "Other" task filter checkbox misaligned with text
2199         https://bugs.webkit.org/show_bug.cgi?id=148788
2200
2201         Reviewed by Timothy Hatcher.
2202
2203         * UserInterface/Views/ChartDetailsSectionRow.css:
2204         (.details-section > .content > .group > .row.chart > .chart-content > .legend > .legend-item > label > .color-key):
2205         Adjust "fake" checkbox margin to align with label text.
2206
2207 2015-09-04  Joseph Pecoraro  <pecoraro@apple.com>
2208
2209         Web Inspector: Expand Console domain test coverage
2210         https://bugs.webkit.org/show_bug.cgi?id=148740
2211
2212         Reviewed by Brian Burg.
2213
2214         * UserInterface/Protocol/RemoteObject.js:
2215         Add a few helpers for checking the RemoteObject type.
2216
2217 2015-09-02  Commit Queue  <commit-queue@webkit.org>
2218
2219         Unreviewed, rolling out r189241.
2220         https://bugs.webkit.org/show_bug.cgi?id=148703
2221
2222         These tests crash with assertions (Requested by ap on
2223         #webkit).
2224
2225         Reverted changeset:
2226
2227         "Web Inspector: Move PrettyPrinting tests into LayoutTests"
2228         https://bugs.webkit.org/show_bug.cgi?id=148698
2229         http://trac.webkit.org/changeset/189241
2230
2231 2015-09-01  Joseph Pecoraro  <pecoraro@apple.com>
2232
2233         Web Inspector: Move PrettyPrinting tests into LayoutTests
2234         https://bugs.webkit.org/show_bug.cgi?id=148698
2235
2236         Reviewed by Timothy Hatcher.
2237
2238         * Tools/PrettyPrinting/index.html:
2239         Modify the relative path to the tests which are now in LayoutTests.
2240
2241         * UserInterface/Test.html:
2242         Load CodeMirror and related resources for Formatting.
2243
2244 2015-09-01  Matt Baker  <mattbaker@apple.com>
2245
2246         Web Inspector: REGRESSION (r187873): Location column icon is missing in timeline data grids
2247         https://bugs.webkit.org/show_bug.cgi?id=148691
2248
2249         Reviewed by Timothy Hatcher.
2250
2251         * UserInterface/Views/TimelineDataGridNode.js:
2252         (WebInspector.TimelineDataGridNode.prototype.createCellContent):
2253         Added "icon" class name. Was using removed class variable (class="undefined").
2254
2255 2015-09-01  Matt Baker  <mattbaker@apple.com>
2256
2257         Web Inspector: Show layout/paint pixel area in the Rendering Frames tree outline
2258         https://bugs.webkit.org/show_bug.cgi?id=148674
2259
2260         Reviewed by Brian Burg.
2261
2262         * Localizations/en.lproj/localizedStrings.js:
2263         New UI string.
2264
2265         * UserInterface/Views/RenderingFrameTimelineView.css:
2266         (.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .navigation-sidebar-panel-content-tree-outline.rendering-frame .item:not(.paint-record):not(.layout-record) .subtitle):
2267         (.sidebar > .panel.navigation.timeline.timeline-recording-content-view-showing .navigation-sidebar-panel-content-tree-outline.rendering-frame .item .subtitle): Deleted.
2268         Show subtitles for layout and paint records only. We still want to hide script record subtitles,
2269         since that information is already in the 'Location' column.
2270
2271         * UserInterface/Views/RenderingFrameTimelineView.js:
2272         (WebInspector.RenderingFrameTimelineView.prototype._processPendingRecords):
2273         Add tree element subtitle for LayoutTimelineRecords that specify width and height.
2274
2275 2015-09-01  Matt Baker  <mattbaker@apple.com>
2276
2277         Web Inspector: Reorder columns in the Rendering Frames data grid by importance
2278         https://bugs.webkit.org/show_bug.cgi?id=148672
2279
2280         Reviewed by Timothy Hatcher.
2281
2282         * UserInterface/Views/RenderingFrameTimelineView.js:
2283         (WebInspector.RenderingFrameTimelineView):
2284         Updated column order, rearranged the column object setup code to match.
2285
2286 2015-09-01  Brian Burg  <bburg@apple.com>
2287
2288         Web Inspector: rewrite inspector/console/command-line-api.html to use AsyncTestSuite
2289         https://bugs.webkit.org/show_bug.cgi?id=148637
2290
2291         Reviewed by Darin Adler.
2292
2293         * UserInterface/Base/Object.js:
2294         (WebInspector.Object.singleFireEventListener):
2295         (WebInspector.Object.singleFireEventListener.let.wrappedCallback): Arrow.
2296
2297 2015-09-01  Devin Rousso  <drousso@apple.com>
2298
2299         Web Inspector: New rule button in the style sidebar is blurry and too dark
2300         https://bugs.webkit.org/show_bug.cgi?id=148108
2301
2302         Reviewed by Timothy Hatcher.
2303
2304         Added support for Plus and Minus icons on non-retina screens.
2305         Also removed some CSS rules that no longer apply to anything.
2306
2307         * UserInterface/Images/Minus.svg:
2308         * UserInterface/Images/NewTabPlus.svg:
2309         * UserInterface/Images/Plus.svg: Removed.
2310         * UserInterface/Images/Plus13.svg: Copied from Source/WebInspectorUI/UserInterface/Images/Plus.svg.
2311         * UserInterface/Images/Plus15.svg: Copied from Source/WebInspectorUI/UserInterface/Images/Plus.svg.
2312
2313         * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
2314         (.sidebar > .panel.details.css-style > .content + .options-container):
2315         (.sidebar > .panel.details.css-style > .content + .options-container > .new-rule):
2316
2317         * UserInterface/Views/ProbeDetailsSidebarPanel.css:
2318         (.details-section.probe-set .options > .probe-add):
2319
2320         * UserInterface/Views/RulesStyleDetailsPanel.css:
2321         (.sidebar > .panel.details.css-style .rules .new-rule): Deleted.
2322         (.sidebar > .panel.details.css-style .rules > *:first-child:matches(.new-rule)): Deleted.
2323         (.sidebar > .panel.details.css-style > .content.filter-in-progress .new-rule): Deleted.
2324         (.sidebar > .panel.details.css-style > .content:not(.filter-in-progress) > .rules > .new-rule + .style-declaration-section): Deleted.
2325         (.sidebar > .panel.details.css-style > .content:not(.filter-in-progress) > .rules > .new-rule + .label): Deleted.
2326         (.sidebar > .panel.details.css-style .rules .new-rule img): Deleted.
2327         (.sidebar > .panel.details.css-style .rules .new-rule:hover): Deleted.
2328         (.sidebar > .panel.details.css-style .rules .new-rule:active): Deleted.
2329         (@media (-webkit-min-device-pixel-ratio: 2)): Deleted.
2330         Removed CSS rules that no longer apply.  The new rule button was moved to the Styles sidebar.
2331
2332         * UserInterface/Views/ScopeChainDetailsSidebarPanel.css:
2333         (.details-section.watch-expressions .options > .watch-expression-add):
2334
2335         * UserInterface/Views/TabBar.css:
2336         (.tab-bar > .item.new-tab-button > .icon):
2337
2338         * UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
2339         (.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-controls > div):
2340
2341         * UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js:
2342         (WebInspector.VisualStyleCommaSeparatedKeywordEditor):
2343
2344         * UserInterface/Views/VisualStyleSelectorSection.js:
2345         (WebInspector.VisualStyleSelectorSection):
2346
2347 2015-09-01  Brian Burg  <bburg@apple.com>
2348
2349         Web Inspector: add TestSuite hooks for per-testcase setup and teardown actions
2350         https://bugs.webkit.org/show_bug.cgi?id=148641
2351
2352         Reviewed by Timothy Hatcher.
2353
2354         It should be possible to run setup and teardown actions for each test case.
2355         The use case here is to add listeners, set up testcase-specific state, etc.
2356         To match how test functions work in each suite, the sync and async implementations
2357         take functions with no arguments and(resolve, reject), respectively.
2358
2359         * UserInterface/Test/TestSuite.js:
2360         (TestSuite.prototype.addTestCase):
2361         (TestSuite.messageFromThrownObject):
2362         (TestSuite):
2363         (AsyncTestSuite.prototype.runTestCases): Stick the extra functions in the chain.
2364         (AsyncTestSuite):
2365         (SyncTestSuite.prototype.runTestCases):
2366         (SyncTestSuite):
2367
2368 2015-09-01  Matt Baker  <mattbaker@apple.com>
2369
2370         Web Inspector: Visual style editor shouldn't allow alpha characters in numeric input fields
2371         https://bugs.webkit.org/show_bug.cgi?id=148580
2372
2373         Reviewed by Brian Burg.
2374
2375         * UserInterface/Views/VisualStyleNumberInputBox.js:
2376         (WebInspector.VisualStyleNumberInputBox):
2377         Added input element "changed" handler, renamed "keyup" handler to match "keydown" handler.
2378         (WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputChanged):
2379         Validate input in response to changed event.
2380
2381 2015-08-31  Nikita Vasilyev  <nvasilyev@apple.com>
2382
2383         Web Inspector: Command-Enter for selected JS in Debugger/Sources shouldn't change the focus
2384         https://bugs.webkit.org/show_bug.cgi?id=148613
2385
2386         Reviewed by Timothy Hatcher.
2387
2388         * UserInterface/Views/ConsoleTabContentView.js:
2389         (WebInspector.ConsoleTabContentView.prototype.shown):
2390         Always focus on the console prompt when the console tab get selected.
2391
2392         * UserInterface/Views/LogContentView.js:
2393         (WebInspector.LogContentView.prototype.shown): Deleted.
2394
2395 2015-08-31  Joseph Pecoraro  <pecoraro@apple.com>
2396
2397         Web Inspector: Debugger Popovers should work for object literal shorthand variables
2398         https://bugs.webkit.org/show_bug.cgi?id=148603
2399
2400         Reviewed by Timothy Hatcher.
2401
2402         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
2403         (WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
2404         Allow debugger popovers for object property shorthands, because they
2405         are actually variables that have values. Previously we ignored property
2406         name literals, because they were just property names until ES6.
2407
2408         * UserInterface/Views/CodeMirrorAdditions.js:
2409         Add a helper for walking through token types from a start position. It may be useful elsewhere.
2410
2411 2015-08-31  Matt Baker  <mattbaker@apple.com>
2412
2413         Web Inspector: Move the Popover code out of the Breakpoint model object
2414         https://bugs.webkit.org/show_bug.cgi?id=127328
2415
2416         Reviewed by Timothy Hatcher.
2417
2418         * UserInterface/Controllers/BreakpointPopoverController.js: Added.
2419         (WebInspector.BreakpointPopoverController):
2420         (WebInspector.BreakpointPopoverController.prototype.appendContextMenuItems.editBreakpoint):
2421         (WebInspector.BreakpointPopoverController.prototype.appendContextMenuItems.removeBreakpoint):
2422         (WebInspector.BreakpointPopoverController.prototype.appendContextMenuItems.toggleBreakpoint):
2423         (WebInspector.BreakpointPopoverController.prototype.appendContextMenuItems.toggleAutoContinue):
2424         (WebInspector.BreakpointPopoverController.prototype.appendContextMenuItems.revealOriginalSourceCodeLocation):
2425         (WebInspector.BreakpointPopoverController.prototype.appendContextMenuItems):
2426         (WebInspector.BreakpointPopoverController.prototype.showEditBreakpointPopover):
2427         (WebInspector.BreakpointPopoverController.prototype._createPopoverContent):
2428         (WebInspector.BreakpointPopoverController.prototype._popoverToggleEnabledCheckboxChanged):
2429         (WebInspector.BreakpointPopoverController.prototype._popoverConditionInputChanged):
2430         (WebInspector.BreakpointPopoverController.prototype._popoverToggleAutoContinueCheckboxChanged):
2431         (WebInspector.BreakpointPopoverController.prototype._popoverConditionInputKeyDown):
2432         (WebInspector.BreakpointPopoverController.prototype._popoverActionsCreateAddActionButton):
2433         (WebInspector.BreakpointPopoverController.prototype._popoverActionsAddActionButtonClicked):
2434         (WebInspector.BreakpointPopoverController.prototype._popoverActionsInsertBreakpointActionView):
2435         (WebInspector.BreakpointPopoverController.prototype.breakpointActionViewAppendActionView):
2436         (WebInspector.BreakpointPopoverController.prototype.breakpointActionViewRemoveActionView):
2437         (WebInspector.BreakpointPopoverController.prototype.breakpointActionViewResized):
2438         (WebInspector.BreakpointPopoverController.prototype.willDismissPopover):
2439         (WebInspector.BreakpointPopoverController.prototype.didDismissPopover):
2440         Added controller class to encapsulate view logic previously located in WebInspector.Breakpoint.
2441
2442         * UserInterface/Main.html:
2443         Added and updated file paths.
2444
2445         * UserInterface/Models/Breakpoint.js:
2446         (WebInspector.Breakpoint.prototype.appendContextMenuItems.editBreakpoint): Deleted.
2447         (WebInspector.Breakpoint.prototype.appendContextMenuItems.removeBreakpoint): Deleted.
2448         (WebInspector.Breakpoint.prototype.appendContextMenuItems.toggleBreakpoint): Deleted.
2449         (WebInspector.Breakpoint.prototype.appendContextMenuItems.toggleAutoContinue): Deleted.
2450         (WebInspector.Breakpoint.prototype.appendContextMenuItems.revealOriginalSourceCodeLocation): Deleted.
2451         (WebInspector.Breakpoint.prototype.appendContextMenuItems): Deleted.
2452         (WebInspector.Breakpoint.prototype._popoverToggleEnabledCheckboxChanged): Deleted.
2453         (WebInspector.Breakpoint.prototype._popoverConditionInputChanged): Deleted.
2454         (WebInspector.Breakpoint.prototype._popoverToggleAutoContinueCheckboxChanged): Deleted.
2455         (WebInspector.Breakpoint.prototype._popoverConditionInputKeyDown): Deleted.
2456         (WebInspector.Breakpoint.prototype._editBreakpointPopoverContentElement): Deleted.
2457         (WebInspector.Breakpoint.prototype._popoverActionsCreateAddActionButton): Deleted.
2458         (WebInspector.Breakpoint.prototype._popoverActionsAddActionButtonClicked): Deleted.
2459         (WebInspector.Breakpoint.prototype._popoverActionsInsertBreakpointActionView): Deleted.
2460         (WebInspector.Breakpoint.prototype.breakpointActionViewAppendActionView): Deleted.
2461         (WebInspector.Breakpoint.prototype.breakpointActionViewRemoveActionView): Deleted.
2462         (WebInspector.Breakpoint.prototype.breakpointActionViewResized): Deleted.
2463         (WebInspector.Breakpoint.prototype.willDismissPopover): Deleted.
2464         (WebInspector.Breakpoint.prototype.didDismissPopover): Deleted.
2465         (WebInspector.Breakpoint.prototype._showEditBreakpointPopover): Deleted.
2466         Removed view logic.
2467
2468         * UserInterface/Views/BreakpointPopoverController.css: Renamed from Source/WebInspectorUI/UserInterface/Views/Breakpoint.css.
2469         (.popover .edit-breakpoint-popover-content):
2470         (.popover .edit-breakpoint-popover-content.wide):
2471         (.popover .edit-breakpoint-popover-content > label.toggle):
2472         (.popover .edit-breakpoint-popover-content > table):
2473         (.popover .edit-breakpoint-popover-content > table > tr > th):
2474         (.popover .edit-breakpoint-popover-content > table > tr > td):
2475         (#edit-breakpoint-popover-condition):
2476         (#edit-breakpoint-popoover-auto-continue):
2477
2478         * UserInterface/Views/SourceCodeTextEditor.js:
2479         (WebInspector.SourceCodeTextEditor):
2480         Creates a BreakpointPopoverController instance. The lifetime of the 'Edit Breakpoint' view is internal to the
2481         controller, and can't be initiated outside of a context menu item click.
2482
2483 2015-08-31  Matt Baker  <mattbaker@apple.com>
2484
2485         Web Inspector: Rendering Frame tasks making up < 1% of the selection don't appear in the pie chart
2486         https://bugs.webkit.org/show_bug.cgi?id=148549
2487
2488         Reviewed by Timothy Hatcher.
2489
2490         Small data points can be invisible or difficult to see in the pie chart. This patch introduces
2491         a minimum slice size of 1.5% (determined by visual inspection) for chart items.
2492
2493         Legend items continue to show the original data point values, not the adjusted values used to
2494         draw the chart slices.
2495
2496         * UserInterface/Views/ChartDetailsSectionRow.js:
2497         (WebInspector.ChartDetailsSectionRow):
2498         (WebInspector.ChartDetailsSectionRow.prototype._updateLayout):
2499         Adjust display values up or down as needed, so no data point is less than the
2500         minimum and all chart slices still total 100%.
2501
2502 2015-08-28  Joseph Pecoraro  <pecoraro@apple.com>
2503
2504         Web Inspector: "animationEnd" event names should be "animationend" (broken dashboard animation after pause)
2505         https://bugs.webkit.org/show_bug.cgi?id=148604
2506
2507         Reviewed by Timothy Hatcher.
2508
2509         * UserInterface/Views/DOMTreeElement.js:
2510         (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight):
2511         * UserInterface/Views/DashboardContainerView.js:
2512         (WebInspector.DashboardContainerView.prototype._showDashboardView.animationEnded):
2513         (WebInspector.DashboardContainerView.prototype._showDashboardView):
2514         (WebInspector.DashboardContainerView.prototype._hideDashboardView.animationEnded):
2515         (WebInspector.DashboardContainerView.prototype._hideDashboardView):
2516         * UserInterface/Views/DefaultDashboardView.js:
2517         (WebInspector.DefaultDashboardView.prototype._setConsoleItemValue.animationEnded):
2518         (WebInspector.DefaultDashboardView.prototype._setConsoleItemValue):
2519         * UserInterface/Views/TextEditor.js:
2520         (WebInspector.TextEditor.prototype._revealSearchResult):
2521
2522 2015-08-28  Joseph Pecoraro  <pecoraro@apple.com>
2523
2524         Web Inspector: Resource.prototype.associateWithScript assertions firing
2525         https://bugs.webkit.org/show_bug.cgi?id=148601
2526
2527         Reviewed by Timothy Hatcher.
2528
2529         * UserInterface/Models/Resource.js:
2530         (WebInspector.Resource.prototype.associateWithScript):
2531         Restore the code that was here before it was converted to asserts.
2532         It looked as if it was iOS 6 only but it was not.
2533
2534 2015-08-28  Joseph Pecoraro  <pecoraro@apple.com>
2535
2536         Web Inspector: Improve ScriptSyntaxTree a bit
2537         https://bugs.webkit.org/show_bug.cgi?id=148563
2538
2539         Reviewed by Timothy Hatcher.
2540
2541         * UserInterface/Models/ScriptSyntaxTree.js:
2542         (WebInspector.ScriptSyntaxTree.prototype._recurse):
2543         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2544         Share and fix ClassDeclaration and ClassExpression recursion to visit
2545         the identifier (node.id). Include the kind with a VariableDeclaration
2546         ("var", "let", "const").
2547
2548 2015-08-28  Joseph Pecoraro  <pecoraro@apple.com>
2549
2550         Web Inspector: Separate creating a style sheet from adding a new rule in the protocol
2551         https://bugs.webkit.org/show_bug.cgi?id=148502
2552
2553         Reviewed by Timothy Hatcher.
2554
2555         The backend allows creating multiple stylesheets. This patch makes
2556         the frontend have a preferred InspectorStyleSheet per-frame.
2557
2558         * UserInterface/Base/Object.js:
2559         (WebInspector.Object.singleFireEventListener):
2560         Return the wrapped listener so it can be removed if needed.
2561
2562         * UserInterface/Models/CSSStyleSheet.js:
2563         (WebInspector.CSSStyleSheet.prototype.isInspectorStyleSheet):
2564         Helper to check if the current stylesheet is an inspector created stylesheet.
2565
2566         * UserInterface/Controllers/CSSStyleManager.js:
2567         (WebInspector.CSSStyleManager.prototype.preferredInspectorStyleSheetForFrame):
2568         (WebInspector.CSSStyleManager.prototype.preferredInspectorStyleSheetForFrame.documentNodeAvailable):
2569         (WebInspector.CSSStyleManager.prototype.preferredInspectorStyleSheetForFrame.bodyNodeAvailable):
2570         (WebInspector.CSSStyleManager.prototype.preferredInspectorStyleSheetForFrame.cssRuleAvailable):
2571         (WebInspector.CSSStyleManager.prototype._inspectorStyleSheetsForFrame):
2572         Lookup the inspector stylesheet for a particular frame. If one doesn't exist create it.
2573         For legacy backends, exploit "addRule" to create the inspector stylesheet.
2574
2575         * UserInterface/Models/DOMNode.js:
2576         * UserInterface/Models/DOMNodeStyles.js:
2577         (WebInspector.DOMNodeStyles.prototype.addEmptyRule.inspectorStyleSheetAvailable):
2578         (WebInspector.DOMNodeStyles.prototype.addEmptyRule):
2579         Currently add all new rules to the inspector stylesheet.
2580
2581 2015-08-28  Joseph Pecoraro  <pecoraro@apple.com>
2582
2583         Web Inspector: Type Profiler does not understand Functions within Default Argument Expressions
2584         https://bugs.webkit.org/show_bug.cgi?id=148557
2585
2586         Reviewed by Timothy Hatcher.
2587
2588         * UserInterface/Models/ScriptSyntaxTree.js:
2589         (WebInspector.ScriptSyntaxTree.prototype._recurse):
2590         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2591         (WebInspector.ScriptSyntaxTree):
2592         Add support for abstracting and recursing through the default parameter
2593         expressions Esprima has on function expressions and declarations.
2594
2595 2015-08-28  Joseph Pecoraro  <pecoraro@apple.com>
2596
2597         Web Inspector: Type Profiler does not understand Functions inside Template Strings (ScriptSyntaxTree warnings)
2598         https://bugs.webkit.org/show_bug.cgi?id=148556
2599
2600         Reviewed by Timothy Hatcher.
2601
2602         * UserInterface/Models/ScriptSyntaxTree.js:
2603         (WebInspector.ScriptSyntaxTree.prototype._recurse):
2604         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
2605         (WebInspector.ScriptSyntaxTree):
2606         Add support for abstracting and recursing through the Esprima template nodes.
2607
2608 2015-08-27  Joseph Pecoraro  <pecoraro@apple.com>
2609
2610         Web Inspector: Standardize on CSSStyleSheet.Type enum and move more protocol enum conversion to the manager
2611         https://bugs.webkit.org/show_bug.cgi?id=148515
2612
2613         Reviewed by Brian Burg.
2614
2615         * UserInterface/Controllers/CSSStyleManager.js:
2616         (WebInspector.CSSStyleManager.protocolStyleSheetOriginToEnum):
2617         (WebInspector.CSSStyleManager.protocolMediaSourceToEnum):
2618         Protocol enum to frontend enum conversion.
2619
2620         * UserInterface/Models/DOMNodeStyles.js:
2621         (WebInspector.DOMNodeStyles.prototype.refresh.fetchedComputedStyle):
2622         (WebInspector.DOMNodeStyles.prototype.refresh):
2623         (WebInspector.DOMNodeStyles.prototype._parseRulePayload):
2624         (WebInspector.DOMNodeStyles.prototype._collectStylesInCascadeOrder):
2625         Use the manager to convert from a protocol payload enum to frontend num for css types.
2626
2627         * UserInterface/Models/CSSRule.js:
2628         (WebInspector.CSSRule.prototype.get editable):
2629         * UserInterface/Views/CSSStyleDeclarationSection.js:
2630         (WebInspector.CSSStyleDeclarationSection):
2631         (WebInspector.CSSStyleDeclarationSection.prototype.refresh):
2632         * UserInterface/Views/RulesStyleDetailsPanel.js:
2633         (WebInspector.RulesStyleDetailsPanel.prototype.refresh.appendStyleSection):
2634         (WebInspector.RulesStyleDetailsPanel.prototype.refresh):
2635         * UserInterface/Views/VisualStyleSelectorSection.js:
2636         (WebInspector.VisualStyleSelectorSection.prototype.update.createSelectorItem):
2637         (WebInspector.VisualStyleSelectorSection.prototype.update.uniqueOrderedRules.set return):
2638         (WebInspector.VisualStyleSelectorSection.prototype.update.uniqueOrderedRules):
2639         (WebInspector.VisualStyleSelectorSection.prototype.update):
2640         * UserInterface/Views/VisualStyleSelectorTreeItem.js:
2641         (WebInspector.VisualStyleSelectorTreeItem):
2642         Update enum use.
2643
2644 2015-08-26  Nikita Vasilyev  <nvasilyev@apple.com>
2645
2646         Web Inspector: [Regression] [Mavericks]: Undocked Web Inspector toolbar is two different colors and has extra space
2647         https://bugs.webkit.org/show_bug.cgi?id=148510
2648
2649         Make body element transparent and remove extra padding above the toolbar only for OS X Mavericks.
2650
2651         Reviewed by Timothy Hatcher.
2652
2653         * UserInterface/Base/Main.js:
2654         (WebInspector.contentLoaded):
2655         * UserInterface/Views/Main.css:
2656         (body:not(.mavericks)):
2657         (body): Deleted.
2658         * UserInterface/Views/Toolbar.css:
2659         (body:not(.mavericks) .toolbar):
2660         (body.window-inactive:not(.mavericks) .toolbar):
2661         (body.mac-platform:not(.docked, .mavericks) .toolbar):
2662         (.toolbar): Deleted.
2663         (body.window-inactive .toolbar): Deleted.
2664         (body.mac-platform:not(.docked) .toolbar): Deleted.
2665
2666 2015-08-26  Joseph Pecoraro  <pecoraro@apple.com>
2667
2668         Web Inspector: Uncaught exception in CSS Completion - TypeError: undefined is not an object (evaluating 'this._values[middleIndex].startsWith')
2669         https://bugs.webkit.org/show_bug.cgi?id=148508
2670
2671         Reviewed by Timothy Hatcher.
2672
2673         * UserInterface/Models/CSSCompletions.js:
2674         (WebInspector.CSSCompletions):
2675         Add a comment explaining that the constructor may be called with
2676         a list of strings or a list of objects from the protocol. Add
2677         a fast path for when this is constructed with a list of strings.
2678
2679 2015-08-26  Matt Baker  <mattbaker@apple.com>
2680
2681         Web Inspector: Rendering Frames timeline pie chart should use SVG instead of 2D canvas
2682         https://bugs.webkit.org/show_bug.cgi?id=148457
2683
2684         Reviewed by Timothy Hatcher.
2685
2686         * UserInterface/Views/ChartDetailsSectionRow.css:
2687         (.details-section > .content > .group > .row.chart > .chart-content > svg > path.hidden):
2688         (.details-section > .content > .group > .row.chart > .chart-content > svg > path.chart-segment):
2689         (.details-section > .content > .group > .row.chart > .chart-content > svg > path.empty-chart):
2690         New styles for SVG chart elements.
2691
2692         * UserInterface/Views/ChartDetailsSectionRow.js:
2693         (WebInspector.ChartDetailsSectionRow):
2694         Calculate radii and create SVG chart elements.
2695         (WebInspector.ChartDetailsSectionRow.prototype.clearItems):
2696         Remove chart segment path elements.
2697         (WebInspector.ChartDetailsSectionRow.prototype._needsLayout):
2698         (WebInspector.ChartDetailsSectionRow.prototype._updateLayout.createSegmentPathData):
2699         Helper function that creates path data for a single pie chart segment.
2700         (WebInspector.ChartDetailsSectionRow.prototype._updateLayout):
2701         Creates path elements as needed, and updates path data for for non-zero data points.
2702         (WebInspector.ChartDetailsSectionRow.prototype.set innerLabel): Deleted.
2703         (WebInspector.ChartDetailsSectionRow.prototype.set innerRadius): Deleted.
2704         These properties are now set during construction.
2705         (WebInspector.ChartDetailsSectionRow.prototype.updateLayout): Deleted.
2706         Renamed to _updateLayout.
2707
2708         * UserInterface/Views/TimelineSidebarPanel.js:
2709         Chart size and inner radius passed to chart constructor.
2710
2711 2015-08-26  Joseph Pecoraro  <pecoraro@apple.com>
2712
2713         Web Inspector: Implement tracking of active stylesheets in the frontend
2714         https://bugs.webkit.org/show_bug.cgi?id=105828
2715
2716         Reviewed by Timothy Hatcher.
2717
2718         * UserInterface/Models/CSSStyleSheet.js:
2719         (WebInspector.CSSStyleSheet):
2720         (WebInspector.CSSStyleSheet.prototype.get origin):
2721         (WebInspector.CSSStyleSheet.prototype.updateInfo):
2722         Add a new origin attribute that has been sent from the backend for a while.
2723
2724         * UserInterface/Controllers/CSSStyleManager.js:
2725         (WebInspector.CSSStyleManager.prototype.styleSheetAdded):
2726         (WebInspector.CSSStyleManager.prototype.styleSheetRemoved):
2727         Handle the new events by managing the new CSSStyleSheets.
2728         
2729         (WebInspector.CSSStyleManager):
2730         (WebInspector.CSSStyleManager.prototype._mainResourceDidChange):
2731         Reset the legacy fetching flag. Fetching is only needed for legacy backends.
2732
2733         (WebInspector.CSSStyleManager.prototype._fetchInfoForAllStyleSheets):
2734         Include the new origin property in the legacy updateInfo path.
2735
2736         * UserInterface/Protocol/CSSObserver.js:
2737         (WebInspector.CSSObserver.prototype.styleSheetAdded):
2738         (WebInspector.CSSObserver.prototype.styleSheetRemoved):
2739         Forward to the manager.
2740
2741         * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
2742         (WebInspector.CSSStyleDetailsSidebarPanel):
2743         Refresh the sidebar when stylesheets are added / removed, as that
2744         may affect the style of the select element.
2745
2746 2015-08-26  Joseph Pecoraro  <pecoraro@apple.com>
2747
2748         Web Inspector: Drop iOS 6 Legacy Remote Inspector Support
2749         https://bugs.webkit.org/show_bug.cgi?id=148456
2750
2751         Reviewed by Timothy Hatcher.
2752
2753         * UserInterface/Base/Main.js:
2754         (WebInspector.loaded):
2755         (WebInspector._updateReloadToolbarButton):
2756         (WebInspector._updateDownloadToolbarButton):
2757         (WebInspector.canArchiveMainFrame):
2758         * UserInterface/Controllers/CSSStyleManager.js:
2759         (WebInspector.CSSStyleManager.prototype._frameURLMapKey):
2760         (WebInspector.CSSStyleManager.prototype._lookupStyleSheet.styleSheetsFetched):
2761         (WebInspector.CSSStyleManager._updateResourceContent.fetchedStyleSheetContent):
2762         (WebInspector.CSSStyleManager.prototype._clearStyleSheetsForResource): Deleted.
2763         * UserInterface/Controllers/DOMTreeManager.js:
2764         (WebInspector.DOMTreeManager.prototype.highlightSelector):
2765         * UserInterface/Controllers/DebuggerManager.js:
2766         (WebInspector.DebuggerManager.prototype._setBreakpoint):
2767         * UserInterface/Controllers/JavaScriptLogViewController.js:
2768         * UserInterface/Controllers/RuntimeManager.js:
2769         (WebInspector.RuntimeManager):
2770         (WebInspector.RuntimeManager.prototype.evaluateInInspectedWindow):
2771         * UserInterface/Controllers/SourceMapManager.js:
2772         (WebInspector.SourceMapManager.prototype._loadAndParseSourceMap):
2773         * UserInterface/Controllers/StorageManager.js:
2774         (WebInspector.StorageManager):
2775         (WebInspector.StorageManager.prototype._addDOMStorageIfNeeded):
2776         (WebInspector.StorageManager.prototype.domStorageWasUpdated): Deleted.
2777         (WebInspector.StorageManager.prototype._domStorageForIdentifier): Deleted.
2778         (WebInspector.StorageManager.prototype._extraDomainsActivated): Deleted.
2779         * UserInterface/Controllers/TimelineManager.js:
2780         (WebInspector.TimelineManager.prototype._processRecord):
2781         * UserInterface/Models/Breakpoint.js:
2782         (WebInspector.Breakpoint.prototype._editBreakpointPopoverContentElement):
2783         * UserInterface/Models/CSSCompletions.js:
2784         (WebInspector.CSSCompletions):
2785         (WebInspector.CSSCompletions.requestCSSCompletions):
2786         * UserInterface/Models/CSSKeywordCompletions.js:
2787         (WebInspector.CSSKeywordCompletions.addCustomCompletions): Deleted.
2788         * UserInterface/Models/CSSProperty.js:
2789         (WebInspector.CSSProperty):
2790         (WebInspector.CSSProperty.prototype.update):
2791         * UserInterface/Models/CSSRule.js:
2792         (WebInspector.CSSRule.prototype.get matchedSelectors): Deleted.
2793         (WebInspector.CSSRule.prototype.get matchedSelectorText): Deleted.
2794         * UserInterface/Models/DOMNodeStyles.js:
2795         (WebInspector.DOMNodeStyles.prototype.refresh.parseRuleMatchArrayPayload):
2796         (WebInspector.DOMNodeStyles.prototype.refresh.fetchedMatchedStyles):
2797         (WebInspector.DOMNodeStyles.prototype.changeRule.changeText):
2798         (WebInspector.DOMNodeStyles.prototype.changeStyleText):
2799         (WebInspector.DOMNodeStyles.prototype._parseStylePropertyPayload):
2800         (WebInspector.DOMNodeStyles.prototype._parseRulePayload):
2801         (WebInspector.DOMNodeStyles.prototype.changeStyleText.attributeChanged): Deleted.
2802         (WebInspector.DOMNodeStyles.prototype.changeStyleText.fetchedStyleSheetContent.contentDidChange): Deleted.
2803         (WebInspector.DOMNodeStyles.prototype.changeStyleText.fetchedStyleSheetContent): Deleted.
2804         (WebInspector.DOMNodeStyles.prototype._parseSourceRangePayload): Deleted.
2805         (WebInspector.DOMNodeStyles.prototype._parseSelectorListPayload): Deleted.
2806         * UserInterface/Models/DOMStorageObject.js:
2807         * UserInterface/Models/DOMTree.js:
2808         (WebInspector.DOMTree.prototype.requestRootDOMNode):
2809         (WebInspector.DOMTree.prototype._requestRootDOMNode):
2810         * UserInterface/Models/DatabaseObject.js:
2811         (WebInspector.DatabaseObject.prototype.executeSQL.queryCallback):
2812         (WebInspector.DatabaseObject.prototype.executeSQL):
2813         (WebInspector.DatabaseObject):
2814         (WebInspector.DatabaseObject.prototype.executeSQL.callback): Deleted.
2815         * UserInterface/Models/ExecutionContext.js:
2816         (WebInspector.ExecutionContext.supported): Deleted.
2817         * UserInterface/Models/IssueMessage.js:
2818         (WebInspector.IssueMessage): Deleted.
2819         * UserInterface/Models/LayoutTimelineRecord.js:
2820         (WebInspector.LayoutTimelineRecord):
2821         (WebInspector.LayoutTimelineRecord.prototype.get width):
2822         (WebInspector.LayoutTimelineRecord.prototype.get height):
2823         (WebInspector.LayoutTimelineRecord.prototype.get area):
2824         (WebInspector.LayoutTimelineRecord.prototype.get x): Deleted.
2825         (WebInspector.LayoutTimelineRecord.prototype.get y): Deleted.
2826         (WebInspector.LayoutTimelineRecord.prototype.get rect): Deleted.
2827         * UserInterface/Models/ProfileNode.js:
2828         * UserInterface/Models/Resource.js:
2829         (WebInspector.Resource.prototype.associateWithScript):
2830         * UserInterface/Models/ScriptTimelineRecord.js:
2831         (WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload.profileNodeFromPayload):
2832         * UserInterface/Models/SourceMapResource.js:
2833         (WebInspector.SourceMapResource.prototype.requestContentFromBackend):
2834         * UserInterface/Models/TextRange.js:
2835         (WebInspector.TextRange.prototype.resolveLinesAndColumns.countNewLineCharacters): Deleted.
2836         (WebInspector.TextRange.prototype.resolveLinesAndColumns): Deleted.
2837         * UserInterface/Models/TimelineRecording.js:
2838         * UserInterface/Protocol/ConsoleObserver.js:
2839         (WebInspector.ConsoleObserver.prototype.messageAdded): Deleted.
2840         * UserInterface/Protocol/DOMStorageObserver.js:
2841         (WebInspector.DOMStorageObserver.prototype.addDOMStorage): Deleted.
2842         (WebInspector.DOMStorageObserver.prototype.updateDOMStorage): Deleted.
2843         * UserInterface/Protocol/DatabaseObserver.js:
2844         (WebInspector.DatabaseObserver.prototype.sqlTransactionSucceeded): Deleted.
2845         (WebInspector.DatabaseObserver.prototype.sqlTransactionFailed): Deleted.
2846         (WebInspector.DatabaseObserver): Deleted.
2847         * UserInterface/Protocol/Legacy/6.0/InspectorBackendCommands.js: Removed.
2848         * UserInterface/Views/CookieStorageContentView.js:
2849         (WebInspector.CookieStorageContentView.prototype._deleteCallback):
2850         (WebInspector.CookieStorageContentView):
2851         * UserInterface/Views/DOMTreeContentView.js:
2852         (WebInspector.DOMTreeContentView.prototype._updateCompositingBordersButtonToMatchPageSettings): Deleted.
2853         * UserInterface/Views/EventListenerSectionGroup.js:
2854         (WebInspector.EventListenerSectionGroup.prototype._functionTextOrLink):
2855         (WebInspector.EventListenerSectionGroup):
2856         * UserInterface/Views/LayoutTimelineView.js:
2857         (WebInspector.LayoutTimelineView.prototype._showHighlightForRecord):
2858         * UserInterface/Views/QuickConsole.js:
2859         (WebInspector.QuickConsole):
2860         (WebInspector.QuickConsole.prototype._createExecutionContextPathComponentFromFrame):
2861         (WebInspector.QuickConsole.prototype._frameAdded): Deleted.
2862         (WebInspector.QuickConsole.prototype._frameRemoved): Deleted.
2863         (WebInspector.QuickConsole.prototype._frameMainResourceChanged): Deleted.
2864         * UserInterface/Views/ScriptTimelineDataGridNode.js:
2865         (WebInspector.ScriptTimelineDataGridNode.prototype.get data):
2866         * UserInterface/Views/SourceCodeTextEditor.js:
2867         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenAnnotator):
2868         (WebInspector.SourceCodeTextEditor.prototype._makeBasicBlockAnnotator):
2869         * Versions/Inspector-iOS-6.0.json: Removed.
2870         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
2871         * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
2872
2873 2015-08-26  Nikita Vasilyev  <nvasilyev@apple.com>
2874
2875         Web Inspector: Command-Enter should evaluate selected JS in Debugger/Sources
2876         https://bugs.webkit.org/show_bug.cgi?id=148368
2877
2878         Reviewed by Timothy Hatcher.
2879
2880         * UserInterface/Controllers/CodeMirrorCompletionController.js:
2881         (WebInspector.CodeMirrorCompletionController):
2882         (WebInspector.CodeMirrorCompletionController.prototype._generateJavaScriptCompletions):
2883         Evaluate selected text in the console only for JS and HTML resources. HTML resources
2884         should be allowed because they can have commented out (inside <!-- -->) and
2885         inline (onclick="") JavaScript.
2886
2887 2015-08-25  Brian Burg  <bburg@apple.com>
2888
2889         Web Inspector: no need to allocate protocolErrors array for every dispatched backend command
2890         https://bugs.webkit.org/show_bug.cgi?id=146466
2891
2892         Reviewed by Joseph Pecoraro.
2893
2894         * UserInterface/TestStub.html: Fix a typo, this property exists on ProtocolTest.
2895
2896 2015-08-26  Matt Baker  <mattbaker@apple.com>
2897
2898         Web Inspector: Rendering Frames legend item checkbox colors are too light
2899         https://bugs.webkit.org/show_bug.cgi?id=148465
2900
2901         Reviewed by Timothy Hatcher.
2902
2903         * UserInterface/Views/ChartDetailsSectionRow.js:
2904         (WebInspector.ChartDetailsSectionRow.prototype._addCheckboxColorFilter):
2905         Gamma primitive should use an "exponent" attribute instead of "value".
2906         Increased gamma exponent to 1.4.
2907
2908 2015-08-26  Nikita Vasilyev  <nvasilyev@apple.com>
2909
2910         Web Inspector: Make DOM node attribute changes highlighting less obnoxious
2911         https://bugs.webkit.org/show_bug.cgi?id=148050
2912
2913         Reviewed by Timothy Hatcher.
2914
2915         * UserInterface/Views/DOMTreeOutline.css:
2916         (@keyframes node-state-changed): Change color to a light green.
2917         (.node-state-changed): Add a slight ease-in for the animation function.
2918
2919 2015-08-26  Joseph Pecoraro  <pecoraro@apple.com>
2920
2921         Web Inspector: Add Refresh button to Cookie Content View
2922         https://bugs.webkit.org/show_bug.cgi?id=148468
2923
2924         Reviewed by Timothy Hatcher.
2925
2926         * UserInterface/Views/CookieStorageContentView.js:
2927         (WebInspector.CookieStorageContentView):
2928         (WebInspector.CookieStorageContentView.prototype.get navigationItems):
2929         (WebInspector.CookieStorageContentView.prototype._refreshButtonClicked):
2930
2931 2015-08-25  Brian Burg  <bburg@apple.com>
2932
2933         Web Inspector: message dispatch metrics should use high-resolution timing data
2934         https://bugs.webkit.org/show_bug.cgi?id=135467
2935
2936         Reviewed by Timothy Hatcher.
2937
2938         Use performance.now if it's available, otherwise fallback to Date.now().
2939         Format timestamps with fixed decimal point, and sprinkle some ES6.
2940
2941         * UserInterface/Base/Utilities.js:
2942         (timestamp): Added.
2943         * UserInterface/Protocol/InspectorBackend.js:
2944         (InspectorBackendClass):
2945         (InspectorBackendClass.prototype._sendCommandToBackendWithCallback):
2946         (InspectorBackendClass.prototype._dispatchEvent):
2947         * UserInterface/Protocol/MessageDispatcher.js:
2948         (WebInspector.dispatchNextQueuedMessageFromBackend):
2949         (WebInspector.dispatchMessageFromBackend): Be consistent about using `this`.
2950
2951 2015-08-25  Matt Baker  <mattbaker@apple.com>
2952
2953         Web Inspector: Rendering Frames pie chart should use the needsLayout/updateLayout idiom
2954         https://bugs.webkit.org/show_bug.cgi?id=148412
2955
2956         Reviewed by Timothy Hatcher.
2957
2958         * UserInterface/Views/ChartDetailsSectionRow.js:
2959         (WebInspector.ChartDetailsSectionRow):
2960         (WebInspector.ChartDetailsSectionRow.prototype.set innerLabel):
2961         (WebInspector.ChartDetailsSectionRow.prototype.set innerRadius):
2962         Schedule a layout.
2963         (WebInspector.ChartDetailsSectionRow.prototype.set data): Deleted.
2964         Replaced by addItem, setItemValue, and clearItems.
2965         (WebInspector.ChartDetailsSectionRow.prototype.addItem):
2966         (WebInspector.ChartDetailsSectionRow.prototype.setItemValue):
2967         (WebInspector.ChartDetailsSectionRow.prototype.clearItems):
2968         Add/update data points and schedule a layout.
2969         (WebInspector.ChartDetailsSectionRow.prototype._needsLayout):
2970         (WebInspector.ChartDetailsSectionRow.prototype.updateLayout):
2971         Update legend and draw pie chart.
2972         (WebInspector.ChartDetailsSectionRow.prototype._createLegend): Deleted.
2973         Refactored as _updateLegend.
2974         (WebInspector.ChartDetailsSectionRow.prototype._refresh): Deleted.
2975         Refactored as updateLayout.
2976
2977         * UserInterface/Views/TimelineSidebarPanel.js:
2978         (WebInspector.TimelineSidebarPanel):
2979         Add chart data points once.
2980         (WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart):
2981         Update chart values.
2982
2983 2015-08-24  Brian Burg  <bburg@apple.com>
2984
2985         Web Inspector: add protocol test for existing error handling performed by the backend
2986         https://bugs.webkit.org/show_bug.cgi?id=147097
2987
2988         Reviewed by Joseph Pecoraro.
2989
2990         Add a way to send raw messages to the backend while still awaiting on responses.
2991         This is necessary to test protocol error handling in the inspector backend.
2992
2993         * UserInterface/Test/InspectorProtocol.js:
2994         (InspectorProtocol.sendCommand):
2995         (InspectorProtocol.awaitCommand): Use awaitMessage internally.
2996         (InspectorProtocol.awaitMessage): Added. Use a dummy requestId if none is supplied.
2997         (InspectorProtocol._sendMessage): Added.
2998         (InspectorProtocol.dispatchMessageFromBackend):
2999         Reject with the error object instead of the error message, so error code/data can be checked.
3000         (InspectorProtocol.sendMessage): Deleted, it is now a private method.
3001
3002 2015-08-24  Timothy Hatcher  <timothy@apple.com>
3003
3004         Web Inspector: Change webkitAnimationEnd use, should be animationEnd
3005         https://bugs.webkit.org/show_bug.cgi?id=148385
3006
3007         Reviewed by Joseph Pecoraro.
3008
3009         * UserInterface/Views/DOMTreeElement.js:
3010         (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight):
3011         * UserInterface/Views/DashboardContainerView.js:
3012         (WebInspector.DashboardContainerView.prototype._showDashboardView.animationEnded):
3013         (WebInspector.DashboardContainerView.prototype._showDashboardView):
3014         (WebInspector.DashboardContainerView.prototype._hideDashboardView.animationEnded):
3015         (WebInspector.DashboardContainerView.prototype._hideDashboardView):
3016         * UserInterface/Views/DefaultDashboardView.js:
3017         (WebInspector.DefaultDashboardView.prototype._setConsoleItemValue.animationEnded):
3018         (WebInspector.DefaultDashboardView.prototype._setConsoleItemValue):
3019         * UserInterface/Views/TextEditor.js:
3020         (WebInspector.TextEditor.prototype.revealPosition.revealAndHighlightLine):
3021         (WebInspector.TextEditor.prototype.revealPosition):
3022         (WebInspector.TextEditor.prototype._revealSearchResult):
3023
3024 2015-08-24  Nikita Vasilyev  <nvasilyev@apple.com>
3025
3026         REGRESSION (r188581): Web Inspector: Console user command isn't visible when it's expected to be
3027         https://bugs.webkit.org/show_bug.cgi?id=148283
3028
3029         One of the improvements of r188581 "Option-Enter should commit console command
3030         without erasing the prompt" was not to show a console user command if it's the
3031         same as the previous one.
3032
3033         However, there could be a lot of other messages between the last two user
3034         commands - console.log, CSS warnings, etc. In that case we should show a console
3035         user command again by resetting _lastCommitted.
3036
3037         Reviewed by Timothy Hatcher.
3038
3039         * UserInterface/Controllers/JavaScriptLogViewController.js:
3040         (WebInspector.JavaScriptLogViewController):
3041         (WebInspector.JavaScriptLogViewController.prototype.startNewSession):
3042         (WebInspector.JavaScriptLogViewController.prototype._appendConsoleMessageView):
3043         Reset _lastCommitted for all messages except for user commands and use command results.
3044
3045 2015-08-24  Matt Baker  <mattbaker@apple.com>
3046
3047         Web Inspector: Rendering Frames filter checkboxes all become checked during recording
3048         https://bugs.webkit.org/show_bug.cgi?id=148375
3049
3050         Reviewed by Timothy Hatcher.
3051
3052         * UserInterface/Views/ChartDetailsSectionRow.js:
3053         (WebInspector.ChartDetailsSectionRow.prototype._createLegend):
3054         Removed incorrect code that forced checked to true.
3055
3056         * UserInterface/Views/TimelineSidebarPanel.js:
3057         (WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart):
3058         Persist legend item checkbox state when updating the chart.
3059
3060 2015-08-23  Matt Baker  <mattbaker@apple.com>
3061
3062         Web Inspector: Filtered style not applied to graph elements during timeline recording
3063         https://bugs.webkit.org/show_bug.cgi?id=148339
3064
3065         Reviewed by Brian Burg.
3066
3067         * UserInterface/Views/NavigationSidebarPanel.js:
3068         (WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
3069         Check for hidden state change when applying filters to newly added tree elements.
3070
3071 2015-08-23  Timothy Hatcher  <timothy@apple.com>
3072
3073         Web Inspector: Drop webkit prefixes from animation, keyframes and transform
3074         https://bugs.webkit.org/show_bug.cgi?id=148364
3075
3076         Reviewed by Darin Adler.
3077
3078         * UserInterface/Views/BreakpointTreeElement.css:
3079         (.breakpoint-generic-line-icon .icon > span):
3080         (.data-updated.breakpoint-generic-line-icon .icon > span):
3081         * UserInterface/Views/ColorPicker.css:
3082         (.color-picker > .slider):
3083         * UserInterface/Views/DashboardContainerView.css:
3084         (.toolbar .dashboard):
3085         (.toolbar .dashboard.slide-out-up):
3086         (.toolbar .dashboard.slide-out-down):
3087         (.toolbar .dashboard.slide-in-up):
3088         (.toolbar .dashboard.slide-in-down):
3089         (@keyframes slide-top-edge):
3090         (@keyframes slide-bottom-edge):
3091         (@-webkit-keyframes slide-top-edge): Deleted.
3092         (@-webkit-keyframes slide-bottom-edge): Deleted.
3093         * UserInterface/Views/DebuggerDashboardView.css:
3094         (.dashboard.debugger .navigation-bar .item.button > .glyph):
3095         (@keyframes pulse-pause-button):
3096         (@-webkit-keyframes pulse-pause-button): Deleted.
3097         * UserInterface/Views/DefaultDashboardView.css:
3098         (.toolbar .dashboard.default > .item.pulsing):
3099         (@keyframes console-item-pulse):
3100         (@-webkit-keyframes console-item-pulse): Deleted.
3101         * UserInterface/Views/GoToLineDialog.css:
3102         (.go-to-line-dialog):
3103         * UserInterface/Views/HoverMenu.css:
3104         (.hover-menu):
3105         * UserInterface/Views/IndeterminateProgressSpinner.css:
3106         (@keyframes discrete-spinner):
3107         (.indeterminate-progress-spinner):
3108         (@-webkit-keyframes discrete-spinner): Deleted.
3109         * UserInterface/Views/Main.css:
3110         (.bouncy-highlight):
3111         (@keyframes bouncy-highlight-animation):
3112         (@-webkit-keyframes bouncy-highlight-animation): Deleted.
3113         * UserInterface/Views/ProbeSetDataGrid.css:
3114         (.details-section.probe-set .data-grid tr.revealed.highlighted):
3115         (@keyframes blink-frame-highlight):
3116         (.details-section.probe-set .data-grid > tr.data-updated):
3117         (@keyframes blink-probe-frame):
3118         (@-webkit-keyframes blink-frame-highlight): Deleted.
3119         (@-webkit-keyframes blink-probe-frame): Deleted.
3120         * UserInterface/Views/TextEditor.css:
3121         (.text-editor > .CodeMirror .highlighted):
3122         (@keyframes text-editor-highlight-fadeout):
3123         (.text-editor > .CodeMirror .hovered-expression-highlight):
3124         (@keyframes text-editor-hovered-expression-highlight-fadeout):
3125         (@-webkit-keyframes text-editor-highlight-fadeout): Deleted.
3126         (@-webkit-keyframes text-editor-hovered-expression-highlight-fadeout): Deleted.
3127         * UserInterface/Views/TimelineOverview.css:
3128         (.timeline-overview.frames > .timeline-ruler > .markers > .divider):
3129         (.timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .selection-handle.right):
3130         (.timeline-overview.frames > .timeline-ruler:not(.both-handles-clamped) > .shaded-area.right):
3131         * UserInterface/Views/TimelineRuler.css:
3132         (.timeline-ruler > .header > .divider):
3133         (.timeline-ruler > .markers > .divider):
3134         (.timeline-ruler > .markers > .marker):
3135         (.timeline-ruler > .selection-handle.left):
3136         (.timeline-ruler > .selection-handle.right):
3137
3138 2015-08-21  Saam barati  <sbarati@apple.com>
3139
3140         Web Inspector: Type profiler shows 'Undefined' annotation for functions with no return statements
3141         https://bugs.webkit.org/show_bug.cgi?id=146882
3142
3143         Reviewed by Joseph Pecoraro.
3144
3145         * UserInterface/Controllers/TypeTokenAnnotator.js:
3146         (WebInspector.TypeTokenAnnotator.prototype._insertTypeToken):
3147         * UserInterface/Models/ScriptSyntaxTree.js:
3148         (WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
3149         (WebInspector.ScriptSyntaxTree):
3150
3151 2015-08-21  Joseph Pecoraro  <pecoraro@apple.com>
3152
3153         Web Inspector: WebInspector.domTreeManager.regionLayoutUpdated does not exist
3154         https://bugs.webkit.org/show_bug.cgi?id=148348
3155
3156         Reviewed by Timothy Hatcher.
3157
3158         * UserInterface/Protocol/CSSObserver.js:
3159         (WebInspector.CSSObserver.prototype.regionLayoutUpdated):
3160         Just do the same as the new event name.
3161
3162 2015-08-21  Brian Burg  <bburg@apple.com>
3163
3164         Web Inspector: clean up uses of `new` with zero-argument constructors and factory methods
3165         https://bugs.webkit.org/show_bug.cgi?id=148311
3166
3167         Reviewed by Timothy Hatcher.
3168
3169         * UserInterface/Protocol/InspectorFrontendHostStub.js:
3170         * UserInterface/Views/ClusterContentView.js:
3171         (WebInspector.ClusterContentView):
3172         * UserInterface/Views/ColorPicker.js:
3173         (WebInspector.ColorPicker):
3174         * UserInterface/Views/ContentView.js:
3175         (WebInspector.ContentView.createFromRepresentedObject): This was causing a console assertion
3176         when a breakpoint tree element was selected and the inspector tried to restore the view state
3177         after a reload or back/forward navigation.
3178
3179         * UserInterface/Views/NavigationSidebarPanel.js:
3180         (WebInspector.NavigationSidebarPanel):
3181         * UserInterface/Views/TimelineRecordingContentView.js:
3182         (WebInspector.TimelineRecordingContentView):
3183
3184 2015-08-20  Brian Burg  <bburg@apple.com>
3185
3186         Web Inspector: add a regression test for the fix introduced in r188679
3187         https://bugs.webkit.org/show_bug.cgi?id=148223
3188
3189         Reviewed by Joseph Pecoraro.
3190
3191         Turns out that we were possibly leaking a single DOMTree on reload.
3192         Always clear the main frame's DOMTree as well as those of sub-frames.
3193
3194         * UserInterface/Base/Object.js: Add back single-fire listeners.
3195         (WebInspector.Object.singleFireEventListener.let.wrappedCallback):
3196         (WebInspector.Object.singleFireEventListener):
3197         (WebInspector.Object.retainedObjectsWithPrototype):
3198         (WebInspector.Object.prototype.singleFireEventListener):
3199         (WebInspector.Object.prototype.retainedObjectsWithPrototype):
3200         * UserInterface/Models/Frame.js:
3201         (WebInspector.Frame.prototype.removeAllChildFrames): Clear own tree too.
3202
3203 2015-08-20  Joseph Pecoraro  <pecoraro@apple.com>
3204
3205         Web Inspector: Better Remember open tab types and order if using JSContext inspector
3206         https://bugs.webkit.org/show_bug.cgi?id=148285
3207
3208         Reviewed by Timothy Hatcher.
3209
3210         * UserInterface/Base/Main.js:
3211         (WebInspector.contentLoaded):
3212         (WebInspector.activateExtraDomains):
3213         Save and restore extra domain related tabs at the expected saved index.
3214
3215         (WebInspector._rememberOpenTabs):
3216         Keep unsupported tab types in the setting so when they are supported they open.
3217
3218         * UserInterface/Base/Utilities.js:
3219         Add a helper for inserting a single object into an array.
3220
3221 2015-08-20  Nikita Vasilyev  <nvasilyev@apple.com>
3222
3223         Web Inspector: inline errors/warnings are taller than the line height
3224         https://bugs.webkit.org/show_bug.cgi?id=148232
3225
3226         Reviewed by Timothy Hatcher.
3227
3228         * UserInterface/Views/SourceCodeTextEditor.css:
3229         (.source-code.text-editor > .CodeMirror .issue-widget.inline):
3230         (.source-code.text-editor > .CodeMirror .issue-widget.inline > .text):
3231
3232 2015-08-20  Joseph Pecoraro  <pecoraro@apple.com>
3233
3234         JSContext Inspector: Uncaught Exception opening Search Tab
3235         https://bugs.webkit.org/show_bug.cgi?id=148284
3236
3237         Reviewed by Timothy Hatcher.
3238
3239         * UserInterface/Views/SearchSidebarPanel.js:
3240         (WebInspector.SearchSidebarPanel):
3241         This is copied / pasted code that shouldn't apply to the Search tab.
3242         We want to show results under Resources in the Search tab.
3243
3244 2015-08-20  Nikita Vasilyev  <nvasilyev@apple.com>
3245
3246         Web Inspector: Truncate data URIs
3247         https://bugs.webkit.org/show_bug.cgi?id=148212
3248
3249         Reviewed by Timothy Hatcher.
3250
3251         * UserInterface/Base/URLUtilities.js:
3252         (parseURL):
3253         Exit early to avoid an expensive RegExp match on a potentially very large data URI.
3254
3255         (parseQueryString):
3256         Fix typo.
3257
3258         (WebInspector.displayNameForURL):
3259         (WebInspector.truncateURL):
3260         By default, only show first and last 3 characters of data URIs.
3261
3262         * UserInterface/Models/Resource.js:
3263         (WebInspector.Resource.prototype.get displayURL):
3264         For tooltips, show first and last 32 characters of data URIs.
3265
3266         * UserInterface/Models/SourceCodeLocation.js:
3267         (WebInspector.SourceCodeLocation.prototype._locationString):
3268         * UserInterface/Views/ResourceTreeElement.js:
3269         (WebInspector.ResourceTreeElement.prototype._updateToolTip):
3270
3271 2015-08-20  Devin Rousso  <drousso@apple.com>
3272
3273         Web Inspector: Add flex alignment section to Visual sidebar
3274         https://bugs.webkit.org/show_bug.cgi?id=148243
3275
3276         Reviewed by Timothy Hatcher.
3277
3278         Uses select keyword pickers to contain the list of possible values.  Also supports
3279         the upcoming Grid layout keywords in the advanced keyword list.
3280
3281         * Localizations/en.lproj/localizedStrings.js:
3282         * UserInterface/Views/VisualStyleDetailsPanel.js:
3283         (WebInspector.VisualStyleDetailsPanel):
3284         (WebInspector.VisualStyleDetailsPanel.prototype._populateFlexboxSection):
3285         (WebInspector.VisualStyleDetailsPanel.prototype._populateAlignmentSection):
3286
3287 2015-08-20  Devin Rousso  <drousso@apple.com>
3288
3289         Web Inspector: Labels in the computed panel are shifted when a filter is applieds
3290         https://bugs.webkit.org/show_bug.cgi?id=148250
3291
3292         Reviewed by Timothy Hatcher.
3293
3294         Added to the selectors for filtering to ensure they only apply to the rules panel.
3295
3296         * UserInterface/Views/RulesStyleDetailsPanel.css:
3297         (.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label):
3298         (.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label:not(.filter-section-non-matching) ~ .label):
3299         (.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label.filter-matching-label):
3300         (.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label:not(.filter-section-non-matching) + .label.filter-matching-label:not(.filter-section-non-matching)):
3301         (.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .new-rule):
3302         (.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .style-declaration-section:not(.filter-section-non-matching) ~ .label:not(.filter-section-non-matching)):
3303         (@media (-webkit-min-device-pixel-ratio: 2)):
3304         (.sidebar > .panel.details.css-style > .content.filter-in-progress .label): Deleted.
3305         (.sidebar > .panel.details.css-style > .content.filter-in-progress .label:not(.filter-section-non-matching) ~ .label): Deleted.
3306         (.sidebar > .panel.details.css-style > .content.filter-in-progress .label.filter-matching-label): Deleted.
3307         (.sidebar > .panel.details.css-style > .content.filter-in-progress .label:not(.filter-section-non-matching) + .label.filter-matching-label:not(.filter-section-non-matching)): Deleted.
3308         (.sidebar > .panel.details.css-style > .content.filter-in-progress .new-rule): Deleted.
3309         (.sidebar > .panel.details.css-style > .content.filter-in-progress .style-declaration-section:not(.filter-section-non-matching) ~ .label:not(.filter-section-non-matching)): Deleted.
3310
3311 2015-08-20  Devin Rousso  <drousso@apple.com>
3312
3313         Web Inspector: Fix "attempted to assign to readonly property" in Visual editor links
3314         https://bugs.webkit.org/show_bug.cgi?id=148264
3315
3316         Reviewed by Timothy Hatcher.
3317
3318         * UserInterface/Views/VisualStylePropertyEditorLink.js:
3319         (WebInspector.VisualStylePropertyEditorLink.prototype.set linked):
3320         No longer attempts to set the "hidden" attribute of the link icons before they exist.
3321
3322 2015-08-20  Devin Rousso  <drousso@apple.com>
3323
3324         Web Inspector: Visual editor adds extra spaces to styles with no properties
3325         https://bugs.webkit.org/show_bug.cgi?id=148242
3326
3327         Reviewed by Timothy Hatcher.
3328
3329         * UserInterface/Models/CSSStyleDeclaration.js:
3330         (WebInspector.CSSStyleDeclaration.prototype.set text):
3331         Now trims the text and, if the resulting string has no length or the style is inline,
3332         replaces the text to be set with the trimmed text.
3333
3334         * UserInterface/Views/VisualStylePropertyCombiner.js:
3335         (WebInspector.VisualStylePropertyCombiner.prototype.modifyPropertyText):
3336         Removed unnecessary trim.
3337
3338 2015-08-20  Devin Rousso  <drousso@apple.com>
3339
3340         Web Inspector: Font size between computed and set value is off in visual styles popups
3341         https://bugs.webkit.org/show_bug.cgi?id=148226
3342
3343         Reviewed by Timothy Hatcher.
3344
3345         * UserInterface/Views/VisualStylePropertyEditor.css:
3346         (.visual-style-property-container > .visual-style-property-value-container > .visual-style-special-property-placeholder):
3347         Increased font-size to match the font-size of the overlaid select element.
3348
3349 2015-08-20  Matt Baker  <mattbaker@apple.com>
3350
3351         Web Inspector: Filtered frames shouldn't be selectable in the Rendering Frames overview graph
3352         https://bugs.webkit.org/show_bug.cgi?id=148253
3353
3354         Reviewed by Timothy Hatcher.
3355
3356         * UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
3357         Check record's filtered state before setting new frame selection.