FontCache should only deal with SimpleFontData
[WebKit-https.git] / Source / WebInspectorUI / ChangeLog
1 2015-01-08  Nikita Vasilyev  <nvasilyev@apple.com>
2
3         Web Inspector: REGRESSION Showing debugger sidebar shouldn't change selected JS file
4         https://bugs.webkit.org/show_bug.cgi?id=139526
5
6         Reviewed by Timothy Hatcher.
7
8         * UserInterface/Base/Main.js:
9         (WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar):
10         When switching to Debugger, show last selected JS or HTML resource.
11
12         (WebInspector.showSplitConsole):
13         (WebInspector.showFullHeightConsole):
14         (WebInspector.toggleConsoleView):
15         (WebInspector._sidebarCollapsedStateDidChange):
16         (WebInspector._updateContentViewForCurrentNavigationSidebar):
17         (WebInspector._navigationSidebarPanelSelected):
18         (WebInspector._contentBrowserCurrentContentViewDidChange):
19         (WebInspector._updateNavigationSidebarForCurrentContentView): Deleted.
20         * UserInterface/Views/ApplicationCacheFrameContentView.js:
21         (WebInspector.ApplicationCacheFrameContentView.prototype.get allowedNavigationSidebarPanels):
22         * UserInterface/Views/CookieStorageContentView.js:
23         (WebInspector.CookieStorageContentView.prototype.get allowedNavigationSidebarPanels):
24         * UserInterface/Views/DOMStorageContentView.js:
25         (WebInspector.DOMStorageContentView.prototype.get allowedNavigationSidebarPanels):
26         * UserInterface/Views/DOMTreeContentView.js:
27         (WebInspector.DOMTreeContentView.prototype.get allowedNavigationSidebarPanels):
28         * UserInterface/Views/DatabaseContentView.js:
29         (WebInspector.DatabaseContentView.prototype.get allowedNavigationSidebarPanels):
30         * UserInterface/Views/DatabaseTableContentView.js:
31         (WebInspector.DatabaseTableContentView.prototype.get allowedNavigationSidebarPanels):
32         * UserInterface/Views/FontResourceContentView.js:
33         (WebInspector.FontResourceContentView.prototype.get allowedNavigationSidebarPanels):
34         * UserInterface/Views/FrameDOMTreeContentView.js:
35         (WebInspector.FrameDOMTreeContentView.prototype.get allowedNavigationSidebarPanels):
36         * UserInterface/Views/LogContentView.js:
37         (WebInspector.LogContentView.prototype.get allowedNavigationSidebarPanels):
38         * UserInterface/Views/ResourceClusterContentView.js:
39         (WebInspector.ResourceClusterContentView.prototype.get allowedNavigationSidebarPanels):
40         * UserInterface/Views/ResourceSidebarPanel.js:
41         (WebInspector.ResourceSidebarPanel.prototype.showDefaultContentView):
42         (WebInspector.ResourceSidebarPanel.prototype.showMainFrame):
43         * UserInterface/Views/Sidebar.js:
44         (WebInspector.Sidebar.prototype.removeSidebarPanel):
45         * UserInterface/Views/TimelineContentView.js:
46         (WebInspector.TimelineContentView.prototype.get allowedNavigationSidebarPanels):
47
48 2015-01-08  Joseph Pecoraro  <pecoraro@apple.com>
49
50         Web Inspector: Phantom breakpoint appears on empty line after reload of minified file with a breakpoint
51         https://bugs.webkit.org/show_bug.cgi?id=140276
52
53         Reviewed by Timothy Hatcher.
54
55         Styles being set on lines (e.g. breakpoint styles) before content loaded can
56         carry forward with the empty line. It is safe for us to just remove all
57         the styles from the intial empty line before we load the initial content.
58
59         * UserInterface/Views/TextEditor.js:
60         (WebInspector.TextEditor.prototype.set string.update):
61         (WebInspector.TextEditor.prototype.set string):
62
63 2015-01-08  Joseph Pecoraro  <pecoraro@apple.com>
64
65         Web Inspector: Pause Reason Improvements (Breakpoint, Debugger Statement, Pause on Next Statement)
66         https://bugs.webkit.org/show_bug.cgi?id=138991
67
68         Reviewed by Timothy Hatcher.
69
70         * Localizations/en.lproj/localizedStrings.js:
71         New UI strings for Pause Reasons.
72
73         * UserInterface/Controllers/DebuggerManager.js:
74         (WebInspector.DebuggerManager.prototype.breakpointForIdentifier):
75         Provide a way to get the breakpoint with an identifier.
76
77         * UserInterface/Images/PausedBreakpoint.svg: Added.
78         * UserInterface/Images/gtk/PausedBreakpoint.svg: Added.
79         Copy PseudoElement.svg icon and give it a new name.
80
81         * UserInterface/Views/BreakpointTreeElement.css:
82         (.breakpoint-paused-icon .icon):
83         New icon for a breakpoint causing a pause.
84
85         * UserInterface/Views/BreakpointTreeElement.js:
86         (WebInspector.BreakpointTreeElement.prototype.removeStatusImage):
87         (WebInspector.BreakpointTreeElement.prototype._updateStatus):
88         Give API to remove the breakpoint status icon from a BreakpointTreeElement.
89
90         * UserInterface/Views/DebuggerSidebarPanel.js:
91         (WebInspector.DebuggerSidebarPanel):
92         (WebInspector.DebuggerSidebarPanel.prototype.get hasSelectedElement):
93         (WebInspector.DebuggerSidebarPanel.prototype.deselectBreakpointContentTreeElements):
94         (WebInspector.DebuggerSidebarPanel.prototype.deselectPauseReasonContentTreeElements):
95         (WebInspector.DebuggerSidebarPanel.prototype._treeElementSelected):
96         Give DebuggerSidebarPanel an optional pause reason tree outline. When available
97         include it in the pattern of ensuring a single exclusive selection.
98
99         (WebInspector.DebuggerSidebarPanel.prototype._breakpointRemoved):
100         When a breakpoint is removed, check if we should update the pause reason tree outline.
101
102         (WebInspector.DebuggerSidebarPanel.prototype._updatePauseReason):
103         (WebInspector.DebuggerSidebarPanel.prototype._updatePauseReasonSection):
104         Update Pause Reason section contents depending on the reason.
105
106         (WebInspector.DebuggerSidebarPanel.prototype._updatePauseReasonGotoArrow):
107         Always try to include a goto arrow to jump to the original pause location
108         if it is available at the time of pausing.
109
110 2015-01-08  Joseph Pecoraro  <pecoraro@apple.com>
111
112         Web Inspector: Expected UserAgent styles to be crossed-out if overridden
113         https://bugs.webkit.org/show_bug.cgi?id=140154
114
115         Reviewed by Timothy Hatcher.
116
117         * UserInterface/Models/DOMNodeStyles.js:
118         (WebInspector.DOMNodeStyles.prototype._parseStylePropertyPayload):
119         Add a comment about anonymous styles. The getter is no longer used, and it is not
120         clear if we really care about this state, or if "anonymous" is an appropriate name.
121
122         (WebInspector.DOMNodeStyles.prototype._markOverriddenProperties):
123         Allow browser styles (user agent / html attributes) to be overridden.
124
125         (WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
126         When refreshing styles after changes, the Style object backing HTML attributes
127         was being completely replaced. Allow it to be remembered by a unique key.
128
129 2015-01-07  Joseph Pecoraro  <pecoraro@apple.com>
130
131         Web Inspector: Do not create rulesMap entries for rules without identifiers
132         https://bugs.webkit.org/show_bug.cgi?id=140237
133
134         Reviewed by Timothy Hatcher.
135
136         * UserInterface/Models/DOMNodeStyles.js:
137         (WebInspector.DOMNodeStyles.prototype._parseRulePayload):
138         We were accidentally converting a null into a string with a loose string
139         concatenation. Only do this if the mapKey is not-null.
140
141 2015-01-07  Saam Barati  <saambarati1@gmail.com>
142
143         Web Inspector: Abstract common functions from TypeTokenAnnotator into a parent class and introduce an AnnotatorManager
144         https://bugs.webkit.org/show_bug.cgi?id=139426
145
146         Reviewed by Timothy Hatcher.
147
148         This patch creates a parent class, Annotator, that TypeTokenAnnotator
149         inherits from. Annotator defines a common set of functionality
150         that a text editor annotator can use to mark up UI. This 
151         is in preparation other classes that will inherit from Annotator.
152         
153         This patch also introduces AnnotatorManager which controls a
154         set of Annotators and provides a single interface for
155         controlling them.
156
157         * UserInterface/Controllers/Annotator.js: Added.
158         (WebInspector.Annotator):
159         (WebInspector.Annotator.prototype.get sourceCodeTextEditor):
160         (WebInspector.Annotator.prototype.get isActive):
161         (WebInspector.Annotator.prototype.pause):
162         (WebInspector.Annotator.prototype.resume):
163         (WebInspector.Annotator.prototype.refresh):
164         (WebInspector.Annotator.prototype.reset):
165         (WebInspector.Annotator.prototype.clear):
166         (WebInspector.Annotator.prototype.insertAnnotations):
167         (WebInspector.Annotator.prototype.clearAnnotations):
168         (WebInspector.Annotator.prototype._clearTimeoutIfNeeded):
169         * UserInterface/Controllers/AnnotatorManager.js: Added.
170         (WebInspector.AnnotatorManager):
171         (WebInspector.AnnotatorManager.prototype.addAnnotator):
172         (WebInspector.AnnotatorManager.prototype.isAnnotatorActive):
173         (WebInspector.AnnotatorManager.prototype.pauseAll):
174         (WebInspector.AnnotatorManager.prototype.resumeAll):
175         (WebInspector.AnnotatorManager.prototype.refreshAllIfActive):
176         (WebInspector.AnnotatorManager.prototype.resetAllIfActive):
177         (WebInspector.AnnotatorManager.prototype.clearAll):
178         (WebInspector.AnnotatorManager.prototype.removeAllAnnotators):
179         (WebInspector.AnnotatorManager.prototype._getAnnotators):
180         * UserInterface/Controllers/TypeTokenAnnotator.js:
181         (WebInspector.TypeTokenAnnotator):
182         (WebInspector.TypeTokenAnnotator.prototype.insertAnnotations.):
183         (WebInspector.TypeTokenAnnotator.prototype.clearAnnotations):
184         (WebInspector.TypeTokenAnnotator.prototype._insertToken):
185         (WebInspector.TypeTokenAnnotator.prototype.get isActive): Deleted.
186         (WebInspector.TypeTokenAnnotator.prototype.get sourceCodeTextEditor): Deleted.
187         (WebInspector.TypeTokenAnnotator.prototype.pause): Deleted.
188         (WebInspector.TypeTokenAnnotator.prototype.resume): Deleted.
189         (WebInspector.TypeTokenAnnotator.prototype.refresh): Deleted.
190         (WebInspector.TypeTokenAnnotator.prototype.reset): Deleted.
191         (WebInspector.TypeTokenAnnotator.prototype._insertAnnotations.): Deleted.
192         (WebInspector.TypeTokenAnnotator.prototype._clearTimeoutIfNeeded): Deleted.
193         * UserInterface/Main.html:
194         * UserInterface/Views/SourceCodeTextEditor.js:
195         (WebInspector.SourceCodeTextEditor):
196         (WebInspector.SourceCodeTextEditor.prototype.shown):
197         (WebInspector.SourceCodeTextEditor.prototype.hidden):
198         (WebInspector.SourceCodeTextEditor.prototype.canShowTypeAnnotations):
199         (WebInspector.SourceCodeTextEditor.prototype.contentDidChange):
200         (WebInspector.SourceCodeTextEditor.prototype.toggleTypeAnnotations):
201         (WebInspector.SourceCodeTextEditor.prototype.prettyPrint):
202         (WebInspector.SourceCodeTextEditor.prototype._debuggerDidPause):
203         (WebInspector.SourceCodeTextEditor.prototype._debuggerDidResume):
204         (WebInspector.SourceCodeTextEditor.prototype._updateTokenTrackingControllerState):
205         (WebInspector.SourceCodeTextEditor.prototype._getAssociatedScript):
206         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenAnnotator):
207         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenScrollEventHandler.scrollHandler):
208         (WebInspector.SourceCodeTextEditor.prototype._makeTypeTokenScrollEventHandler):
209
210 2015-01-06  Joseph Pecoraro  <pecoraro@apple.com>
211
212         Web Inspector: Do not style implicit CSS properties in the Style Rules section
213         https://bugs.webkit.org/show_bug.cgi?id=140161
214
215         Reviewed by Timothy Hatcher.
216
217         Previously, implicit properties being transparent in the Rules section
218         was confusing and not useful. Lets simplify what transparency means:
219
220             - Rules:  transparency means a non-inheritable property in an inherited rule
221             - Computed: transparency means an implicit value
222
223         * UserInterface/Views/CSSStyleDeclarationTextEditor.css:
224         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property.not-inherited):
225         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property:matches(.implicit, .not-inherited)): Deleted.
226
227 2015-01-06  Joseph Pecoraro  <pecoraro@apple.com>
228
229         Web Inspector: Uncaught Exception when dismissing Go To Line dialog
230         https://bugs.webkit.org/show_bug.cgi?id=139663
231
232         Reviewed by Timothy Hatcher.
233
234         Calling removeChild would trigger the blur event handler and do a
235         nested call of dismiss(), re-entering and removing while in the middle
236         of removing. Avoid re-entrancy to avoid the exception.
237
238         * UserInterface/Views/GoToLineDialog.js:
239         (WebInspector.GoToLineDialog):
240         (WebInspector.GoToLineDialog.prototype.dismiss):
241
242 2015-01-01  Darin Adler  <darin@apple.com>
243
244         We often misspell identifier as "identifer"
245         https://bugs.webkit.org/show_bug.cgi?id=140025
246
247         Reviewed by Michael Saboff.
248
249         * UserInterface/Base/Main.js:
250         (WebInspector._updateNavigationSidebarForCurrentContentView):
251         (WebInspector._contentBrowserCurrentContentViewDidChange):
252         Fix misspellings.
253
254 2014-12-29  Jonathan Wells  <jonowells@apple.com>
255
256         Web Inspector: SourceCode.requestContent should return a promise
257         https://bugs.webkit.org/show_bug.cgi?id=135777
258
259         Reviewed by Brian Burg.
260
261         Change SourceCode.js to request content from the backend using Promises. Change Resource.js to use this new
262         approach when determining whether a resource load has finished. Change all calls to the older
263         SourceCode#requestContentFromBackendIfNeeded to simply use requestContent and use a catch function
264         if a content request error needs to be handled. Fix a bug where the appropriate error message for an
265         invalid resource wasn't showing in the resource content view.
266
267         * UserInterface/Controllers/AnalyzerManager.js:
268         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode.):
269         (set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode):
270         * UserInterface/Controllers/CSSStyleManager.js:
271         (WebInspector.CSSStyleManager.prototype._updateResourceContent.fetchedStyleSheetContent):
272         (WebInspector.CSSStyleManager.prototype._updateResourceContent.styleSheetReady):
273         * UserInterface/Models/CSSStyleSheet.js:
274         (WebInspector.CSSStyleSheet.prototype.requestContentFromBackend):
275         (WebInspector.CSSStyleSheet.prototype.canRequestContentFromBackend): Deleted.
276         * UserInterface/Models/DOMNodeStyles.js:
277         (WebInspector.DOMNodeStyles.prototype.changeStyleText):
278         * UserInterface/Models/Resource.js:
279         (WebInspector.Resource.prototype.canRequestContent):
280         (WebInspector.Resource.prototype.requestContentFromBackend):
281         (WebInspector.Resource.prototype.markAsFinished):
282         (WebInspector.Resource.prototype.markAsFailed):
283         (WebInspector.Resource.prototype.getImageSize):
284         (WebInspector.Resource.prototype.canRequestContentFromBackend): Deleted.
285         * UserInterface/Models/Script.js:
286         (WebInspector.Script.prototype.requestContentFromBackend):
287         (WebInspector.Script.prototype.requestScriptSyntaxTree.catch):
288         (WebInspector.Script.prototype.canRequestContentFromBackend): Deleted.
289         * UserInterface/Models/SourceCode.js:
290         (WebInspector.SourceCode):
291         (WebInspector.SourceCode.prototype.requestContent):
292         (WebInspector.SourceCode.prototype.requestContentFromBackend):
293         (WebInspector.SourceCode.prototype._processContent):
294         (WebInspector.SourceCode.prototype.canRequestContentFromBackend): Deleted.
295         (WebInspector.SourceCode.prototype.requestContentFromBackendIfNeeded): Deleted.
296         (WebInspector.SourceCode.prototype.servicePendingContentRequests): Deleted.
297         * UserInterface/Models/SourceMapResource.js:
298         (WebInspector.SourceMapResource):
299         (WebInspector.SourceMapResource.prototype.requestContentFromBackend.sourceMapResourceLoadError):
300         (WebInspector.SourceMapResource.prototype.requestContentFromBackend):
301         (WebInspector.SourceMapResource.prototype.canRequestContentFromBackend): Deleted.
302         (WebInspector.SourceMapResource.prototype.requestContentFromBackend.sourceMapResourceLoaded): Deleted.
303         * UserInterface/Views/ResourceContentView.js:
304         (WebInspector.ResourceContentView):
305         (WebInspector.ResourceContentView.prototype._contentAvailable):
306         (WebInspector.ResourceContentView.prototype._contentError):
307         * UserInterface/Views/SourceCodeTextEditor.js:
308         (WebInspector.SourceCodeTextEditor):
309         (WebInspector.SourceCodeTextEditor.prototype._contentAvailable):
310         (WebInspector.SourceCodeTextEditor.prototype._populateWithInlineScriptContent.scriptContentAvailable):
311         (WebInspector.SourceCodeTextEditor.prototype._populateWithInlineScriptContent):
312         (WebInspector.SourceCodeTextEditor.prototype._populateWithScriptContent):
313
314 2014-12-26  Dan Bernstein  <mitz@apple.com>
315
316         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
317         https://bugs.webkit.org/show_bug.cgi?id=139950
318
319         Reviewed by David Kilzer.
320
321         * Configurations/Base.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
322         in a manner that works with Xcode 5.1.1.
323
324 2014-12-20  David Kilzer  <ddkilzer@apple.com>
325
326         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
327         <http://webkit.org/b/139463>
328
329         Reviewed by Mark Rowe.
330
331         * Configurations/Base.xcconfig:
332         - Only set TOOLCHAINS on OS X.
333         * Configurations/DebugRelease.xcconfig:
334         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
335         * Configurations/Version.xcconfig:
336         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
337         * Configurations/WebInspectorUIFramework.xcconfig:
338         - Set NORMAL_PRODUCTION_FRAMEWORKS_DIR,
339           PRODUCTION_FRAMEWORKS_DIR and
340           JAVASCRIPTCORE_PRIVATE_HEADERS_DIR_Production by SDK.
341
342 2014-12-19  Commit Queue  <commit-queue@webkit.org>
343
344         Unreviewed, rolling out r177574.
345         https://bugs.webkit.org/show_bug.cgi?id=139821
346
347         "Broke Production builds by installing
348         libWebCoreTestSupport.dylib in the wrong directory" (Requested
349         by ddkilzer on #webkit).
350
351         Reverted changeset:
352
353         "Switch from using PLATFORM_NAME to SDK selectors in WebCore,
354         WebInspectorUI, WebKit, WebKit2"
355         https://bugs.webkit.org/show_bug.cgi?id=139463
356         http://trac.webkit.org/changeset/177574
357
358 2014-12-19  David Kilzer  <ddkilzer@apple.com>
359
360         Switch from using PLATFORM_NAME to SDK selectors in WebCore, WebInspectorUI, WebKit, WebKit2
361         <http://webkit.org/b/139463>
362
363         Reviewed by Mark Rowe.
364
365         * Configurations/Base.xcconfig:
366         - Only set TOOLCHAINS on OS X.
367         * Configurations/DebugRelease.xcconfig:
368         - Only set MACOSX_DEPLOYMENT_TARGET and SDKROOT on OS X.
369         * Configurations/Version.xcconfig:
370         - Set SYSTEM_VERSION_PREFIX separately for iOS and OS X.
371         * Configurations/WebInspectorUIFramework.xcconfig:
372         - Set NORMAL_PRODUCTION_FRAMEWORKS_DIR,
373           PRODUCTION_FRAMEWORKS_DIR and
374           JAVASCRIPTCORE_PRIVATE_HEADERS_DIR_Production by SDK.
375
376 2014-12-16  Matt Baker  <mattbaker@apple.com>
377
378         Web Inspector: REGRESSION: Dragging undocked web inspector causes mouse to change from pointer to i-bar cursor over window title
379         https://bugs.webkit.org/show_bug.cgi?id=139720
380
381         Reviewed by Timothy Hatcher.
382
383         * UserInterface/Base/Main.js:
384         Prevent default handling of the mouse event when clicking in the titlebar area. WebCore won't continue handling the event,
385         but docking buttons/context menu still function.
386
387 2014-12-15  Nikita Vasilyev  <nvasilyev@apple.com>
388
389         Web Inspector: Clicking on the expand object arrow should always expand an object
390         https://bugs.webkit.org/show_bug.cgi?id=139382
391
392         Reviewed by Joseph Pecoraro.
393
394         * UserInterface/Views/LogContentView.js:
395         (WebInspector.LogContentView):
396         (WebInspector.LogContentView.prototype._click): Deleted.
397         stopPropagation was preventing the object expansion from happening as expecting.
398
399 2014-12-15  Joseph Pecoraro  <pecoraro@apple.com>
400
401         Web Inspector: CSSStyleDeclarationTextEditor fails to update if computed properties changed from empty to non-empty
402         https://bugs.webkit.org/show_bug.cgi?id=139610
403
404         Reviewed by Timothy Hatcher.
405
406         The CSSStyleDeclarationTextEditor for Computed Style Properties always has
407         empty DOMNodeStyles text. However we would not reset contents if properties
408         changed and the actualy content was empty. So once empty, we could never
409         recover. In fact, we should always refresh for Computed Styles.
410
411         * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
412         (WebInspector.CSSStyleDeclarationTextEditor.prototype._propertiesChanged):
413
414 2014-12-08  Joseph Pecoraro  <pecoraro@apple.com>
415
416         Web Inspector: Hide Compositing Borders Button if backend returns an error that it is unsupported
417         https://bugs.webkit.org/show_bug.cgi?id=139307
418
419         Reviewed by Darin Adler.
420
421         * UserInterface/Views/DOMTreeContentView.js:
422         (WebInspector.DOMTreeContentView.prototype._updateCompositingBordersButtonToMatchPageSettings):
423
424 2014-12-05  Joseph Pecoraro  <pecoraro@apple.com>
425
426         Web Inspector: Uncaught Exceptions when attempting to show Content Flow
427         https://bugs.webkit.org/show_bug.cgi?id=139276
428
429         Reviewed by Brian Burg.
430
431         * UserInterface/Views/ContentView.js:
432         (WebInspector.ContentView):
433         (WebInspector.ContentView.isViewable):
434         LegacyJavaScriptProfileObject no longer exists, these references should be removed.
435
436         * UserInterface/Views/FolderizedTreeElement.js:
437         (WebInspector.FolderizedTreeElement.prototype._insertChildTreeElement):
438         This sort function references "this" and needed to be bound.
439
440 2014-12-04  Joseph Pecoraro  <pecoraro@apple.com>
441
442         Web Inspector: Network Timeline Filter Bar only has "All", missing Resource Type filters
443         https://bugs.webkit.org/show_bug.cgi?id=139268
444
445         Reviewed by Brian Burg.
446
447         * UserInterface/Views/TimelineDataGrid.js:
448         (WebInspector.TimelineDataGrid.createColumnScopeBar):
449         Users of createColumnScopeBar pass a Map object now instead of a dictionary.
450         Iterate over the map appropriately.
451
452 2014-12-04  Joseph Pecoraro  <pecoraro@apple.com>
453
454         Web Inspector: LayoutTests/inspector tests fail in Production builds due to missing test resources
455         https://bugs.webkit.org/show_bug.cgi?id=138898
456
457         Reviewed by Mark Rowe.
458
459         In Production builds, if FORCE_TOOL_INSTALL=YES is in the environment
460         we will copy all resources (for Tests) and still do the combine and
461         optimize phase for normal Production inspection resources.
462
463         * Scripts/copy-user-interface-resources.pl:
464
465 2014-12-03  Joseph Pecoraro  <pecoraro@apple.com>
466
467         Web Inspector: Missing getter, clients never see DragToAdjustController is enabled
468         https://bugs.webkit.org/show_bug.cgi?id=139228
469
470         Reviewed by Simon Fraser.
471
472         * UserInterface/Controllers/DragToAdjustController.js:
473         (WebInspector.DragToAdjustController.prototype.get enabled):
474
475 2014-12-02  Joseph Pecoraro  <pecoraro@apple.com>
476
477         Web Inspector: CSS Minification breaks some selectors with colons
478         https://bugs.webkit.org/show_bug.cgi?id=139206
479
480         Reviewed by Simon Fraser.
481
482         Do not remove spaces preceeding colons, as they may change the semantics
483         of selectors with colon prefixes (e.g. "a :not(b)").
484
485         At the same time, we can strip spaces around "!" characters, for example
486         a space is not required before "!important" priority.
487
488         * Scripts/cssmin.py:
489         (cssminify):
490
491 2014-12-01  Benjamin Poulain  <benjamin@webkit.org>
492
493         Web Inspector: add more :not() and :matches() awesomeness
494         https://bugs.webkit.org/show_bug.cgi?id=138997
495
496         Reviewed by Joseph Pecoraro.
497
498         Simplify the Inspector's CSS when possible.
499
500         * UserInterface/Views/DatabaseContentView.css:
501         (:matches(.database-user-query, .database-query-prompt, .database-query-result)::before):
502         (.database-user-query::before, .database-query-prompt::before, .database-query-result::before): Deleted.
503         * UserInterface/Views/GradientSlider.css:
504         (.gradient-slider-knob > :matches(img, div)):
505         (.gradient-slider-knob > div): Deleted.
506         * UserInterface/Views/HoverMenu.css:
507         (.hover-menu > svg > :matches(path, rect)):
508         (.hover-menu > svg > rect): Deleted.
509         * UserInterface/Views/LayerTreeDetailsSidebarPanel.css:
510         (.panel.details.layer-tree .name-column :matches(.pseudo-element, .reflection)):
511         (.panel.details.layer-tree tr.selected .name-column :matches(.pseudo-element, .reflection)):
512         (.panel.details.layer-tree .name-column .reflection): Deleted.
513         (.panel.details.layer-tree tr.selected .name-column .reflection): Deleted.
514         * UserInterface/Views/ProbeDetailsSidebarPanel.css:
515         (.details-section.probe-set .options > :matches(.probe-remove, .probe-clear-samples, .probe-add)):
516         (.details-section.probe-set .options > .probe-add): Deleted.
517         * UserInterface/Views/ResourceSidebarPanel.css:
518         (.sidebar > .panel.navigation.resource > :matches(.content, .empty-content-placeholder)):
519         (body.mac-platform.legacy .sidebar > .panel.navigation.resource > :matches(.content, .empty-content-placeholder)):
520         (.sidebar > .panel.navigation.resource > .empty-content-placeholder): Deleted.
521         (body.mac-platform.legacy .sidebar > .panel.navigation.resource > .empty-content-placeholder): Deleted.
522         * UserInterface/Views/ScopeBar.css:
523         (.scope-bar > li:matches(.selected, :active)):
524         (.scope-bar > li:active): Deleted.
525         * UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
526         (.syntax-highlighted :matches(.css-comment, .javascript-comment, .html-comment)):
527         (.syntax-highlighted :matches(.css-keyword, .css-tag, .css-at-rule, .css-important, .javascript-keyword, .html-tag)):
528         (.syntax-highlighted :matches(.css-number, .javascript-number)):
529         (.syntax-highlighted :matches(.css-property, .css-selector, .javascript-ident)):
530         (.syntax-highlighted :matches(.css-string, .javascript-string, .javascript-regexp, .html-attribute-value)):
531         (.syntax-highlighted :matches(.html-doctype, .html-processing-instruction)):
532         (.syntax-highlighted .html-comment): Deleted.
533         (.syntax-highlighted .html-tag): Deleted.
534         (.syntax-highlighted .javascript-number): Deleted.
535         (.syntax-highlighted .javascript-ident): Deleted.
536         (.syntax-highlighted .html-attribute-value): Deleted.
537         (.syntax-highlighted .html-processing-instruction): Deleted.
538         It looks like ".cm-tag.cm-bracket" was there only to override the rule below.
539         From basic testing, it looks like "cm-tag" and "cm-bracket" always appear together. I removed the "cm-bracket" rule
540         from the second rule, and simplified the first rule.
541
542         * UserInterface/Views/TimelineSidebarPanel.css:
543         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > :matches(.content, .empty-content-placeholder)):
544         (body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .empty-content-placeholder): Deleted.
545         * UserInterface/Views/Toolbar.css:
546         (body.mac-platform:not(.legacy, .docked) .toolbar):
547         (body.mac-platform:not(.legacy, .docked) .toolbar.icon-and-label-vertical):
548         (body.mac-platform:not(.legacy, .docked) .toolbar.icon-and-label-vertical.small-size):
549         (body.mac-platform:not(.legacy, .docked) .toolbar:matches(.icon-and-label-horizontal, .icon-only)):
550         (body.mac-platform:not(.legacy, .docked) .toolbar:matches(.icon-and-label-horizontal.small-size, .icon-only.small-size, .label-only)):
551         (.toolbar:matches(.icon-and-label-horizontal.small-size, .icon-only.small-size, .label-only) .control-section):
552         (body.mac-platform:not(.legacy):not(.docked) .toolbar): Deleted.
553         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical): Deleted.
554         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical.small-size): Deleted.
555         (body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-only): Deleted.
556         (body.mac-platform:not(.legacy):not(.docked) .toolbar.label-only): Deleted.
557         (.toolbar.label-only .control-section): Deleted.
558
559 2014-11-27  Andres Gomez  <agomez@igalia.com>
560
561         Web Inspector: Update NavigationItemProbes icon for the GTK+ port
562         https://bugs.webkit.org/show_bug.cgi?id=139074
563
564         Reviewed by Carlos Garcia Campos.
565
566         NavigationItemProbes was updated for the Mac port and we are now
567         having a similar ideogram in GTK+.
568
569         * UserInterface/Images/gtk/NavigationItemProbes.svg: Updated.
570
571 2014-11-21  Benjamin Poulain  <bpoulain@apple.com>
572
573         Start using the new :not() and :matches() in the Web Inspector
574         https://bugs.webkit.org/show_bug.cgi?id=138978
575
576         Reviewed by Joseph Pecoraro.
577
578         Start simpifying some definitions by using modern CSS.
579
580         * UserInterface/Views/CSSStyleDeclarationSection.css:
581         (body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section:matches(.last-in-group, :last-child)):
582         (.style-declaration-section:matches(.locked, .selector-locked) > .header > .selector):
583         (body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section:last-child): Deleted.
584         (.style-declaration-section.selector-locked > .header > .selector): Deleted.
585         * UserInterface/Views/CSSStyleDeclarationTextEditor.css:
586         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property:matches(.disabled, .invalid, .other-vendor, .not-inherited, .overridden)):
587         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property:matches(.implicit, .not-inherited)):
588         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .editing-line .css-style-declaration-property:matches(.disabled, .other-vendor, .not-inherited, .overridden)):
589         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property.overridden): Deleted.
590         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property.not-inherited): Deleted.
591         (.css-style-text-editor > .CodeMirror .CodeMirror-lines .editing-line .css-style-declaration-property.overridden): Deleted.
592         * UserInterface/Views/ControlToolbarItem.css:
593         (.toolbar:matches(.icon-and-label-horizontal, .toolbar.icon-only) .item.control):
594         (.toolbar.icon-only .item.control): Deleted.
595         * UserInterface/Views/DOMStorageContentView.css:
596         * UserInterface/Views/DashboardContainerView.css:
597         (.toolbar.icon-and-label-vertical:matches(.small-size, .normal-size) .dashboard-container):
598         (.toolbar:matches(.label-only, .small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal)) .dashboard-container):
599         (.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard-container):
600         (.toolbar.normal-size.icon-and-label-vertical .dashboard-container): Deleted.
601         (.toolbar.small-size.icon-and-label-horizontal .dashboard-container): Deleted.
602         (.toolbar.normal-size.icon-and-label-horizontal .dashboard-container): Deleted.
603         * UserInterface/Views/DataGrid.css:
604         (.data-grid :matches(th, td):not(:last-child)):
605         (.data-grid th:matches(.sort-ascending, .sort-descending)):
606         (.data-grid :matches(th, td) > div):
607         (.data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child):
608         (.data-grid tr:matches(.selected, :hover) .go-to-arrow):
609         (.data-grid :-webkit-any(th, td):not(:last-child)): Deleted.
610         (.data-grid th:-webkit-any(.sort-ascending, .sort-descending)): Deleted.
611         (.data-grid :-webkit-any(th, td) > div): Deleted.
612         (.data-grid th:-webkit-any(.sort-ascending, .sort-descending) > div:first-child): Deleted.
613         (.data-grid tr:-webkit-any(.selected, :hover) .go-to-arrow): Deleted.
614         * UserInterface/Views/DebuggerDashboardView.css:
615         (.toolbar.collapsed .dashboard.debugger > :not(.message, .navigation-bar )):
616         (.toolbar.collapsed .dashboard.debugger > :not(.message):not(.navigation-bar )): Deleted.
617         * UserInterface/Views/DefaultDashboardView.css:
618         (body.web .toolbar.collapsed .dashboard.default > :matches(.time, .resourcesSize, .logs)):
619         (body.javascript .toolbar .dashboard.default > :matches(.time, .resourcesSize, .resourcesCount)):
620         (.toolbar:matches(.label-only, .small-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal)) .dashboard.default > .item):
621         (.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard.default > .item):
622         (body.web .toolbar.collapsed .dashboard.default > .logs): Deleted.
623         (body.javascript .toolbar .dashboard.default > .resourcesCount): Deleted.
624         (.toolbar.small-size.icon-and-label-horizontal .dashboard.default > .item): Deleted.
625         (.toolbar.normal-size.icon-and-label-horizontal .dashboard.default > .item): Deleted.
626         * UserInterface/Views/DetailsSection.css:
627         (.details-section > .header > :matches(.node-link, .go-to-arrow)):
628         (.details-section > .content > .group:nth-child(even) > .row:matches(.simple:first-child > *, :not(.simple):first-child)):
629         (body.mac-platform.legacy .details-section > .content > .group:matches(:nth-child(even), :last-child) > .row.simple:last-child > *):
630         (.details-section > .content > .group > .row:matches(.empty, .text)):
631         (body.mac-platform.legacy .details-section > .content > .group > .row:matches(.empty, .text)):
632         (.details-section > .header > .go-to-arrow): Deleted.
633         (.details-section > .content > .group:nth-child(even) > .row.simple:first-child > *): Deleted.
634         (body.mac-platform.legacy .details-section > .content > .group:last-child > .row.simple:last-child > *): Deleted.
635         (.details-section > .content > .group > .row.text): Deleted.
636         (body.mac-platform.legacy .details-section > .content > .group > .row.text): Deleted.
637         * UserInterface/Views/FindBanner.css:
638         (:matches(.find-banner, .supports-find-banner).no-find-banner-transition):
639         (.supports-find-banner.no-find-banner-transition): Deleted.
640         * UserInterface/Views/FlexibleSpaceNavigationItem.css:
641         (:matches(.navigation-bar, .toolbar) .item.flexible-space):
642         (.toolbar .item.flexible-space): Deleted.
643
644 2014-11-19  Joseph Pecoraro  <pecoraro@apple.com>
645
646         Web Inspector: LayoutTests/inspector should not have localStorage side effects
647         https://bugs.webkit.org/show_bug.cgi?id=138895
648
649         Reviewed by Brian Burg.
650
651         When running inspector tests, do not restore/save WebInspector.Settings
652         to localStorage, as that will cause side effects. Instead each Setting
653         will be initialized with its default value and can be modified during
654         the run of the test.
655
656         * UserInterface/Base/Test.js:
657         (WebInspector.loaded):
658         Name the setting to match the normal setting name now that persistence
659         is not an issue.
660
661         * UserInterface/Models/Setting.js:
662         (WebInspector.Setting.prototype.get value):
663         (WebInspector.Setting.prototype.set value):
664         Do not restore/save when in tests.
665
666 2014-11-19  Joseph Pecoraro  <pecoraro@apple.com>
667
668         Web Inspector: JSContext inspection Resource search does not work
669         https://bugs.webkit.org/show_bug.cgi?id=131252
670
671         Reviewed by Timothy Hatcher.
672
673         * UserInterface/Views/ResourceSidebarPanel.js:
674         (WebInspector.ResourceSidebarPanel.prototype.performSearch.resourceCallback):
675         (WebInspector.ResourceSidebarPanel.prototype.performSearch.resourcesCallback):
676         Cleanup by reordering things a bit.
677
678         (WebInspector.ResourceSidebarPanel.prototype.performSearch.searchScripts.scriptCallback):
679         (WebInspector.ResourceSidebarPanel.prototype.performSearch.searchScripts):
680         (WebInspector.ResourceSidebarPanel.prototype.performSearch):
681         Search non-resource scripts individually.
682
683         (WebInspector.ResourceSidebarPanel.prototype._searchTreeElementForScript):
684         Lazily create a ScriptTreeElement for the search tree outline as needed.
685
686         (WebInspector.ResourceSidebarPanel.prototype._scriptsToSearch):
687         When searching scripts, just perform a shallow walk of the tree outline to find
688         Script resources that are not also Resources. Scripts are always guarenteed to
689         be in a folder when inspecting a web resource. For JSContext inspection, scripts
690         are promoted to the top level.
691
692         * UserInterface/Main.html:
693         * UserInterface/Models/SourceCodeSearchMatchObject.js: Renamed from Source/WebInspectorUI/UserInterface/Models/ResourceSearchMatchObject.js.
694         (WebInspector.SourceCodeSearchMatchObject):
695         * UserInterface/Views/SearchIcons.css:
696         (.source-code-match-icon .icon):
697         (.resource-match-icon .icon): Deleted.
698         * UserInterface/Views/SearchResultTreeElement.js:
699         (WebInspector.SearchResultTreeElement):
700         Rename ResourceSearchMatchObject to SourceCodeSearchMatchObject.
701
702 2014-11-19  Joseph Pecoraro  <pecoraro@apple.com>
703
704         Web Inspector: Provide $exception in the console for the thrown exception value
705         https://bugs.webkit.org/show_bug.cgi?id=138726
706
707         Reviewed by Timothy Hatcher.
708
709         * UserInterface/Base/Test.js:
710         (WebInspector.loaded):
711         In order to use RuntimeManager to execute in the global context or on the
712         active debugger call frame, we need to expose the quickConsole controller.
713
714         * UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
715         Expose $exception to completion when we paused because of an exception.
716
717 2014-11-19  Joseph Pecoraro  <pecoraro@apple.com>
718
719         Web Inspector: Debugger should not mutate variable when hovering mouse over ++n expression
720         https://bugs.webkit.org/show_bug.cgi?id=138839
721
722         Reviewed by Timothy Hatcher.
723
724         * UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
725         (WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
726
727 2014-11-19  Joseph Pecoraro  <pecoraro@apple.com>
728
729         Web Inspector: Improve basic JavaScript completion in inline <script>s
730         https://bugs.webkit.org/show_bug.cgi?id=138845
731
732         Reviewed by Timothy Hatcher.
733
734         * UserInterface/Controllers/CodeMirrorCompletionController.js:
735         (WebInspector.CodeMirrorCompletionController.prototype._generateJavaScriptCompletions):
736         Fix up CodeMirror mode handling for JavaScript completion when inside of mixed mode
737         input (html). Also add completion for CodeMirror's localVars list.
738
739 == Rolled over to ChangeLog-2014-11-19 ==