f06f090a081ef9452bc7d9476f6b35371b8b6493
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-05-09  Robin Dunn  <robin@alldunn.com>
2
3         Reviewed by Kevin Ollivier.
4
5         [wx] Update the popup menu code to grab the native control and initialize the
6         event handler properly.
7         
8         https://bugs.webkit.org/show_bug.cgi?id=60482
9
10         * platform/wx/PopupMenuWx.cpp:
11         (WebCore::PopupMenuWx::PopupMenuWx):
12         (WebCore::PopupMenuWx::~PopupMenuWx):
13         (WebCore::PopupMenuWx::show):
14
15 2011-05-09  Robin Dunn  <robin@alldunn.com>
16
17         Reviewed by Kevin Ollivier.
18
19         [wx] Make sure other controls adjust the rect to handle transforms, and turn off the
20         adjustment in 2.9.2+ where it is handled internally by wx.
21         
22         Also add a couple drawing and focus handling fixes for text fields and menulist controls.
23         
24         https://bugs.webkit.org/show_bug.cgi?id=60481
25
26         * platform/wx/RenderThemeWx.cpp:
27         (WebCore::getAdjustedRect):
28         (WebCore::RenderThemeWx::supportsFocus):
29         (WebCore::RenderThemeWx::paintButton):
30         (WebCore::RenderThemeWx::adjustTextFieldStyle):
31         (WebCore::RenderThemeWx::paintTextField):
32         (WebCore::RenderThemeWx::adjustMenuListStyle):
33         (WebCore::RenderThemeWx::paintMenuList):
34         (WebCore::RenderThemeWx::paintMenuListButton):
35
36 2011-05-09  Tony Gentilcore  <tonyg@chromium.org>
37
38         Reviewed by Darin Adler.
39
40         Style fix: Function names must begin with lowercase letter and should not use "get".
41         https://bugs.webkit.org/show_bug.cgi?id=60475
42
43         * dom/Document.cpp:
44         (WebCore::Document::webkitVisibilityState):
45         * page/PageVisibilityState.cpp:
46         (WebCore::pageVisibilityStateString): Renamed.
47         * page/PageVisibilityState.h:
48
49 2011-05-09  Adam Barth  <abarth@webkit.org>
50
51         Reviewed by Tony Gentilcore.
52
53         Make Chromium build with strict PassOwnPtr
54         https://bugs.webkit.org/show_bug.cgi?id=60461
55
56         Fix many, many PassOwnPtr nits.
57
58         * bindings/v8/V8Proxy.cpp:
59         (WebCore::V8Proxy::precompileScript):
60         * bindings/v8/custom/V8DOMWindowCustom.cpp:
61         (WebCore::WindowSetTimeoutImpl):
62         * bindings/v8/custom/V8MessageEventCustom.cpp:
63         (WebCore::V8MessageEvent::initMessageEventCallback):
64         * bindings/v8/custom/V8WorkerContextCustom.cpp:
65         (WebCore::SetTimeoutOrInterval):
66         * dom/Document.cpp:
67         (WebCore::Document::removedLastRef):
68         (WebCore::Document::detach):
69         * fileapi/DOMFileSystem.h:
70         (WebCore::DOMFileSystem::scheduleCallback):
71         * fileapi/FileSystemCallbacks.cpp:
72         (WebCore::FileSystemCallbacks::didOpenFileSystem):
73         (WebCore::ResolveURICallbacks::didOpenFileSystem):
74         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
75         (WebCore::GraphicsLayer::create):
76         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
77         (WebCore::CCLayerImpl::createRenderSurface):
78         * platform/graphics/gpu/BicubicShader.cpp:
79         (WebCore::BicubicShader::create):
80         * platform/graphics/gpu/ConvolutionShader.cpp:
81         (WebCore::ConvolutionShader::create):
82         * platform/graphics/gpu/LoopBlinnSolidFillShader.cpp:
83         (WebCore::LoopBlinnSolidFillShader::create):
84         * platform/graphics/gpu/SolidFillShader.cpp:
85         (WebCore::SolidFillShader::create):
86         * platform/graphics/gpu/TexShader.cpp:
87         (WebCore::TexShader::create):
88         * platform/graphics/gpu/Texture.cpp:
89         (WebCore::Texture::create):
90         * storage/chromium/DatabaseTrackerChromium.cpp:
91         (WebCore::TrackerRemoveOpenDatabaseTask::create):
92         * storage/chromium/SQLTransactionClientChromium.cpp:
93         (WebCore::NotifyDatabaseChangedTask::create):
94
95 2011-05-07  Martin Robinson  <mrobinson@igalia.com>
96
97         Reviewed by Daniel Bates.
98
99         [Soup] Clean up error handling in ResourceHandleSoup
100         https://bugs.webkit.org/show_bug.cgi?id=60436
101
102         Instead of repeating the ResourceError creation twice, abstract
103         it into a helper method.
104
105         No new tests. This is a code cleanup.
106
107         * platform/network/soup/ResourceHandleSoup.cpp:
108         (WebCore::soupErrorShouldCauseLoadFailure): Added.
109         (WebCore::convertSoupErrorToResourceError): Added.
110         (WebCore::sendRequestCallback): Use the new helpers.
111         (WebCore::readCallback): Ditto.
112
113 2011-05-09  Abhishek Arya  <inferno@chromium.org>
114
115         Reviewed by Dave Hyatt.
116
117         Regression(r85869): Restore dirty line logic in RenderInline::destroy.
118         https://bugs.webkit.org/show_bug.cgi?id=60448
119
120         Test: fast/inline/inline-destroy-dirty-lines-crash.html
121
122         * rendering/RenderInline.cpp:
123         (WebCore::RenderInline::destroy):
124
125 2011-05-09  Alejandro G. Castro  <alex@igalia.com>
126
127         Reviewed by Martin Robinson.
128
129         [GTK] WidgetGtk setFocus can not access directly the widget in WK2
130         https://bugs.webkit.org/show_bug.cgi?id=60016
131
132         Added code to check the situation where we do not have direct
133         access to the widget. We use the page to grab the focus which
134         would send a request to the UIProcess in WK2.
135
136         * platform/gtk/WidgetGtk.cpp:
137         (WebCore::Widget::setFocus):
138
139 2011-05-09  Leandro Gracia Gil  <leandrogracia@chromium.org>
140
141         Reviewed by Tony Gentilcore.
142
143         Media Stream API: add exception raising to the getUserMedia method.
144         https://bugs.webkit.org/show_bug.cgi?id=60387
145
146         Perform the required changes to support rising exceptions in the
147         navigator.getUserMedia method. This is required by the latest changes in the spec:
148         http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#dom-navigator-getusermedia
149
150         Test: fast/dom/MediaStream/argument-types.html
151
152         * bindings/js/JSNavigatorCustom.cpp:
153         (WebCore::JSNavigator::webkitGetUserMedia):
154         * bindings/v8/custom/V8NavigatorCustom.cpp:
155         (WebCore::V8Navigator::webkitGetUserMediaCallback):
156         * page/Navigator.cpp:
157         (WebCore::Navigator::webkitGetUserMedia):
158         * page/Navigator.h:
159         * page/Navigator.idl:
160
161 2011-05-09  Csaba Osztrogonác  <ossy@webkit.org>
162
163         Unreviewed Qt 4.8 fix.
164
165         * WebCore.pro: 4.8 bots are updated with the full QRawFont APIs, so we can set HAVE_QRAWFONT now.
166
167 2011-05-09  Adam Roben  <aroben@apple.com>
168
169         Windows project file fix after r86047
170
171         * WebCore.vcproj/WebCore.vcproj: Added missing closing tags.
172
173 2011-05-06  Chris Marrin  <cmarrin@apple.com>
174
175         Reviewed by Darin Adler.
176
177         Fix layer names to say "tiled" and show CALayer addresses, not PlatformCALayer addresses
178         https://bugs.webkit.org/show_bug.cgi?id=60417
179
180         Layer name now has "Tiled" prepended if it is a TiledLayer. This is true on Mac where
181         the layer is a CATiledLayer and on Win where the layer is actually still a CACFLayer
182         but implements a tiled layer. I also now print the address of the CALayer or CACFLayer
183         instead of the PlatformCALayer everywhere.
184
185         * platform/graphics/ca/GraphicsLayerCA.cpp:
186         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
187
188 2011-05-09  Rob Buis  <rbuis@rim.com>
189
190         Reviewed by Dirk Schulze.
191
192         Elements should assert that the QualifiedName given to their constructor corresponds to the Element constructed
193         https://bugs.webkit.org/show_bug.cgi?id=22576
194
195         Add tag name ASSERTs in SVG Element constructors.
196
197         No new tests, since no change in behaviour.
198
199         * svg/SVGAElement.cpp:
200         (WebCore::SVGAElement::SVGAElement):
201         * svg/SVGAltGlyphElement.cpp:
202         (WebCore::SVGAltGlyphElement::SVGAltGlyphElement):
203         * svg/SVGAnimateColorElement.cpp:
204         (WebCore::SVGAnimateColorElement::SVGAnimateColorElement):
205         * svg/SVGAnimateElement.cpp:
206         (WebCore::SVGAnimateElement::SVGAnimateElement):
207         * svg/SVGAnimateMotionElement.cpp:
208         (WebCore::SVGAnimateMotionElement::SVGAnimateMotionElement):
209         * svg/SVGAnimateTransformElement.cpp:
210         (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
211         * svg/SVGCircleElement.cpp:
212         (WebCore::SVGCircleElement::SVGCircleElement):
213         * svg/SVGClipPathElement.cpp:
214         (WebCore::SVGClipPathElement::SVGClipPathElement):
215         * svg/SVGCursorElement.cpp:
216         (WebCore::SVGCursorElement::SVGCursorElement):
217         * svg/SVGDefsElement.cpp:
218         (WebCore::SVGDefsElement::SVGDefsElement):
219         * svg/SVGDescElement.cpp:
220         (WebCore::SVGDescElement::SVGDescElement):
221         * svg/SVGEllipseElement.cpp:
222         (WebCore::SVGEllipseElement::SVGEllipseElement):
223         * svg/SVGFEBlendElement.cpp:
224         (WebCore::SVGFEBlendElement::SVGFEBlendElement):
225         * svg/SVGFEColorMatrixElement.cpp:
226         (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
227         * svg/SVGFEComponentTransferElement.cpp:
228         (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement):
229         * svg/SVGFECompositeElement.cpp:
230         (WebCore::SVGFECompositeElement::SVGFECompositeElement):
231         * svg/SVGFEConvolveMatrixElement.cpp:
232         (WebCore::SVGFEConvolveMatrixElement::SVGFEConvolveMatrixElement):
233         * svg/SVGFEDiffuseLightingElement.cpp:
234         (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement):
235         * svg/SVGFEDisplacementMapElement.cpp:
236         (WebCore::SVGFEDisplacementMapElement::SVGFEDisplacementMapElement):
237         * svg/SVGFEDistantLightElement.cpp:
238         (WebCore::SVGFEDistantLightElement::SVGFEDistantLightElement):
239         * svg/SVGFEDropShadowElement.cpp:
240         (WebCore::SVGFEDropShadowElement::SVGFEDropShadowElement):
241         * svg/SVGFEFloodElement.cpp:
242         (WebCore::SVGFEFloodElement::SVGFEFloodElement):
243         * svg/SVGFEFuncAElement.cpp:
244         (WebCore::SVGFEFuncAElement::SVGFEFuncAElement):
245         * svg/SVGFEFuncBElement.cpp:
246         (WebCore::SVGFEFuncBElement::SVGFEFuncBElement):
247         * svg/SVGFEFuncGElement.cpp:
248         (WebCore::SVGFEFuncGElement::SVGFEFuncGElement):
249         * svg/SVGFEFuncRElement.cpp:
250         (WebCore::SVGFEFuncRElement::SVGFEFuncRElement):
251         * svg/SVGFEGaussianBlurElement.cpp:
252         (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
253         * svg/SVGFEImageElement.cpp:
254         (WebCore::SVGFEImageElement::SVGFEImageElement):
255         * svg/SVGFEMergeElement.cpp:
256         (WebCore::SVGFEMergeElement::SVGFEMergeElement):
257         * svg/SVGFEMergeNodeElement.cpp:
258         (WebCore::SVGFEMergeNodeElement::SVGFEMergeNodeElement):
259         * svg/SVGFEMorphologyElement.cpp:
260         (WebCore::SVGFEMorphologyElement::SVGFEMorphologyElement):
261         * svg/SVGFEOffsetElement.cpp:
262         (WebCore::SVGFEOffsetElement::SVGFEOffsetElement):
263         * svg/SVGFEPointLightElement.cpp:
264         (WebCore::SVGFEPointLightElement::SVGFEPointLightElement):
265         * svg/SVGFESpecularLightingElement.cpp:
266         (WebCore::SVGFESpecularLightingElement::SVGFESpecularLightingElement):
267         * svg/SVGFESpotLightElement.cpp:
268         (WebCore::SVGFESpotLightElement::SVGFESpotLightElement):
269         * svg/SVGFETileElement.cpp:
270         (WebCore::SVGFETileElement::SVGFETileElement):
271         * svg/SVGFETurbulenceElement.cpp:
272         (WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement):
273         * svg/SVGFilterElement.cpp:
274         (WebCore::SVGFilterElement::SVGFilterElement):
275         * svg/SVGFontElement.cpp:
276         (WebCore::SVGFontElement::SVGFontElement):
277         * svg/SVGFontFaceElement.cpp:
278         (WebCore::SVGFontFaceElement::SVGFontFaceElement):
279         * svg/SVGFontFaceFormatElement.cpp:
280         (WebCore::SVGFontFaceFormatElement::SVGFontFaceFormatElement):
281         * svg/SVGFontFaceNameElement.cpp:
282         (WebCore::SVGFontFaceNameElement::SVGFontFaceNameElement):
283         * svg/SVGFontFaceSrcElement.cpp:
284         (WebCore::SVGFontFaceSrcElement::SVGFontFaceSrcElement):
285         * svg/SVGFontFaceUriElement.cpp:
286         (WebCore::SVGFontFaceUriElement::SVGFontFaceUriElement):
287         * svg/SVGForeignObjectElement.cpp:
288         (WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
289         * svg/SVGGElement.cpp:
290         (WebCore::SVGGElement::SVGGElement):
291         * svg/SVGGlyphElement.cpp:
292         (WebCore::SVGGlyphElement::SVGGlyphElement):
293         * svg/SVGHKernElement.cpp:
294         (WebCore::SVGHKernElement::SVGHKernElement):
295         * svg/SVGImageElement.cpp:
296         (WebCore::SVGImageElement::SVGImageElement):
297         * svg/SVGLineElement.cpp:
298         (WebCore::SVGLineElement::SVGLineElement):
299         * svg/SVGLinearGradientElement.cpp:
300         (WebCore::SVGLinearGradientElement::SVGLinearGradientElement):
301         * svg/SVGMPathElement.cpp:
302         (WebCore::SVGMPathElement::SVGMPathElement):
303         * svg/SVGMarkerElement.cpp:
304         (WebCore::SVGMarkerElement::SVGMarkerElement):
305         * svg/SVGMaskElement.cpp:
306         (WebCore::SVGMaskElement::SVGMaskElement):
307         * svg/SVGMetadataElement.cpp:
308         (WebCore::SVGMetadataElement::SVGMetadataElement):
309         * svg/SVGMissingGlyphElement.cpp:
310         (WebCore::SVGMissingGlyphElement::SVGMissingGlyphElement):
311         * svg/SVGPathElement.cpp:
312         (WebCore::SVGPathElement::SVGPathElement):
313         * svg/SVGPatternElement.cpp:
314         (WebCore::SVGPatternElement::SVGPatternElement):
315         * svg/SVGPolygonElement.cpp:
316         (WebCore::SVGPolygonElement::SVGPolygonElement):
317         * svg/SVGPolylineElement.cpp:
318         (WebCore::SVGPolylineElement::SVGPolylineElement):
319         * svg/SVGRadialGradientElement.cpp:
320         (WebCore::SVGRadialGradientElement::SVGRadialGradientElement):
321         * svg/SVGRectElement.cpp:
322         (WebCore::SVGRectElement::SVGRectElement):
323         * svg/SVGSVGElement.cpp:
324         (WebCore::SVGSVGElement::SVGSVGElement):
325         * svg/SVGScriptElement.cpp:
326         (WebCore::SVGScriptElement::SVGScriptElement):
327         * svg/SVGSetElement.cpp:
328         (WebCore::SVGSetElement::SVGSetElement):
329         * svg/SVGStopElement.cpp:
330         (WebCore::SVGStopElement::SVGStopElement):
331         * svg/SVGStyleElement.cpp:
332         (WebCore::SVGStyleElement::SVGStyleElement):
333         * svg/SVGSwitchElement.cpp:
334         (WebCore::SVGSwitchElement::SVGSwitchElement):
335         * svg/SVGSymbolElement.cpp:
336         (WebCore::SVGSymbolElement::SVGSymbolElement):
337         * svg/SVGTRefElement.cpp:
338         (WebCore::SVGTRefElement::SVGTRefElement):
339         * svg/SVGTSpanElement.cpp:
340         (WebCore::SVGTSpanElement::SVGTSpanElement):
341         * svg/SVGTextElement.cpp:
342         (WebCore::SVGTextElement::SVGTextElement):
343         * svg/SVGTextPathElement.cpp:
344         (WebCore::SVGTextPathElement::SVGTextPathElement):
345         * svg/SVGTitleElement.cpp:
346         (WebCore::SVGTitleElement::SVGTitleElement):
347         * svg/SVGUseElement.cpp:
348         (WebCore::SVGUseElement::SVGUseElement):
349         * svg/SVGVKernElement.cpp:
350         (WebCore::SVGVKernElement::SVGVKernElement):
351         * svg/SVGViewElement.cpp:
352         (WebCore::SVGViewElement::SVGViewElement):
353
354 2011-05-09  Shishir Agrawal  <shishir@chromium.org>
355
356         Reviewed by Tony Gentilcore.
357
358         Implement Page Visibility API.
359         https://bugs.webkit.org/show_bug.cgi?id=54181
360
361         Tests: fast/events/page-visibility-iframe-delete-test.html
362                fast/events/page-visibility-iframe-move-test.html
363                fast/events/page-visibility-iframe-propagation-test.html
364                fast/events/page-visibility-transition-test.html
365
366         * CMakeLists.txt:
367         * GNUmakefile.list.am:
368         * WebCore.gypi:
369         * WebCore.pro:
370         * WebCore.vcproj/WebCore.vcproj:
371         * WebCore.xcodeproj/project.pbxproj:
372         * dom/Document.cpp:
373         (WebCore::Document::visibilityState):
374         (WebCore::Document::webkitVisibilityState):
375         (WebCore::Document::webkitIsVisible):
376         (WebCore::Document::dispatchVisibilityStateChangeEvent):
377         * dom/Document.h:
378         * dom/Document.idl:
379         * dom/EventNames.h:
380         * page/Frame.cpp:
381         (WebCore::Frame::dispatchVisibilityStateChangeEvent):
382         * page/Frame.h:
383         * page/Page.cpp:
384         (WebCore::Page::Page):
385         (WebCore::Page::setVisibilityState):
386         (WebCore::Page::visibilityState):
387         * page/Page.h:
388         * page/PageVisibilityState.cpp: Added.
389         (WebCore::GetPageVisibilityStateString):
390         * page/PageVisibilityState.h: Added.
391
392 2011-05-09  Luke Macpherson   <macpherson@chromium.org>
393
394         Reviewed by Eric Seidel.
395
396         Implement expanding CSS border properties in CSSStyleApplyProperty.
397         https://bugs.webkit.org/show_bug.cgi?id=60456
398
399         No new tests added as no functionality changed.
400
401         * css/CSSStyleApplyProperty.cpp:
402         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
403         Create CSS border expanding property handlers.
404         * css/CSSStyleSelector.cpp:
405         (WebCore::CSSStyleSelector::applyProperty):
406         Remove property handlers that are no longer needed.
407
408 2011-05-08  Ryosuke Niwa  <rniwa@webkit.org>
409
410         Reviewed by Kent Tamura.
411
412         selectstart event does not fire when selection is made via select all
413         https://bugs.webkit.org/show_bug.cgi?id=60376
414
415         Fire selectstart event when a user selects all contents (i.e. document.execCommand('SelectAll')) in
416         document, editable region, or text control.
417
418         Tests: editing/selection/selectstart-on-selectall.html
419                editing/selection/selectstart-prevent-selectall.html
420
421         * dom/Node.h: Removed canSelectAll and selectAll as they are left over from WMLSelectElement.
422         * editing/FrameSelection.cpp:
423         (WebCore::FrameSelection::selectAll): Dispatch selectstart event on selectStartTarget, which is
424         input element or textarea element when the current selection is inside a shadow DOM, and the root
425         editable element if it's inside a non-shadow editable region, and the body element otherwise.
426         * html/HTMLSelectElement.h: Made canSelectAll and selectAll public since they are no longer
427         declared in Node.
428
429 2011-05-08  Luke Macpherson   <macpherson@chromium.org>
430
431         Reviewed by Eric Seidel.
432
433         Make RenderStyle::setColumnBreakInside() reject unsupported enum values.
434         https://bugs.webkit.org/show_bug.cgi?id=60249
435
436         No new tests added as no functionality changed.
437
438         * css/CSSStyleSelector.cpp:
439         (WebCore::CSSStyleSelector::applyProperty):
440         Remove special-case code and use appropriate macro.
441         * rendering/style/RenderStyle.h:
442         (WebCore::InheritedFlags::setColumnBreakInside):
443         Assert that supported values are used.
444
445 2011-05-08  Ryosuke Niwa  <rniwa@webkit.org>
446
447         Reviewed by Darin Adler.
448
449         Extract a DragCaretController from FrameSelection
450         https://bugs.webkit.org/show_bug.cgi?id=60273
451
452         Extracted CaretBase and DragCaretController from FrameSelection. CaretBase is a base class for
453         DragCaretController and FrameSelection and provides functions to paint caret.
454
455         Since DragCaretController doesn't need to store selection, it only holds one VisiblePosition.
456
457         * WebCore.exp.in:
458         * editing/FrameSelection.cpp:
459         (WebCore::CaretBase::CaretBase): Added.
460         (WebCore::DragCaretController::DragCaretController): Added; Set m_caretVisible true.
461         (WebCore::DragCaretController::isContentRichlyEditable): Added.
462         (WebCore::FrameSelection::FrameSelection): Several member variables are move to CaretBase.
463         (WebCore::DragCaretController::setCaretPosition): Extracted from FrameSelection::setSelection.
464         (WebCore::FrameSelection::setSelection): Removed an early exit for DragCaretController.
465         (WebCore::clearRenderViewSelection): Extracted from FrameSelection::respondToNodeModification.
466         (WebCore::DragCaretController::nodeWillBeRemoved): Extracted from FrameSelection::nodeWillBeRemoved
467         and respondToNodeModification. Note that the position DragCaretController holds is equivalent to
468         FrameSelection's base or start so when removingNodeRemovesPosition returns true for m_position,
469         we used to execute the first if clause and cleared render tree selection and DOM tree selection.
470         This is exactly what new DragCaretController::nodeWillBeRemoved does.
471         (WebCore::FrameSelection::nodeWillBeRemoved): Simplified early exist conditions.
472         (WebCore::FrameSelection::respondToNodeModification): Calls clearRenderViewSelection.
473         (WebCore::CaretBase::updateCaretRect): Takes document, caretPosition, selection type, and boolean isOrphaned.
474         Note that we can't obtain the document from caretPosition because VisiblePosition can be null even if
475         FrameSelection's start was not null.
476         (WebCore::caretRendersInsideNode): Moved; Made static local.
477         (WebCore::CaretBase::caretRenderer): Extracted from FrameSelection::caretRenderer.
478         (WebCore::FrameSelection::caretRenderer): Calls CaretBase::caretRenderer.
479         (WebCore::DragCaretController::caretRenderer): Ditto.
480         (WebCore::FrameSelection::localCaretRect): Calls updateCaretRect with extra arguments.
481         (WebCore::CaretBase::absoluteBoundsForLocalRect): Moved from FrameSelection; Takes Node*.
482         (WebCore::CaretBase::caretRepaintRect): Ditto.
483         (WebCore::FrameSelection::recomputeCaretRect): Calls absoluteBoundsForLocalRect, caretRepaintRect,
484         and shouldRepaintCaret with extra arguments.
485         (WebCore::CaretBase::shouldRepaintCaret): Takes a boolean isContentEditable.
486         (WebCore::FrameSelection::invalidateCaretRect): Calls CaretBase::invalidateCaretRect.
487         (WebCore::CaretBase::invalidateCaretRect): Extracted from FrameSelection::invalidateCaretRect.
488         (WebCore::FrameSelection::paintCaret): Calls CaretBase::paintCaret.
489         (WebCore::CaretBase::paintCaret): Extracted from FrameSelection::paintCaret.
490         (WebCore::FrameSelection::updateAppearance): Removed an assertion that this function is never called for
491         DragCaretController.
492         (WebCore::DragCaretController::paintDragCaret): Moved from FrameSelection::paintDragCaret.
493         * editing/FrameSelection.h:
494         (WebCore::CaretBase::localCaretRectForPainting): Added.
495         (WebCore::DragCaretController::isContentEditable): Added.
496         (WebCore::DragCaretController::hasCaret): Added.
497         (WebCore::DragCaretController::caretPosition): Added.
498         (WebCore::DragCaretController::clear): Added.
499         * page/DragController.cpp:
500         (WebCore::DragController::tryDocumentDrag): Uses DragCaretController.
501         (WebCore::DragController::dispatchTextInputEventFor): Ditto.
502         (WebCore::DragController::concludeEditDrag): Ditto.
503         (WebCore::DragController::placeDragCaret): Ditto.
504         * page/Page.cpp:
505         (WebCore::Page::Page): Instantiates DragCaretController instead of FrameSelection.
506         * page/Page.h:
507         (WebCore::Page::dragCaretController): Returns DragCaretController* instead of FrameSelection*.
508         * rendering/RenderBlock.cpp:
509         (WebCore::RenderBlock::paintCaret): Uses FrameSelection and DragCaretController.
510
511 2011-05-08  Dan Bernstein  <mitz@apple.com>
512
513         Reviewed by Darin Adler.
514
515         <rdar://problem/9401853> REGRESSION (r78846): Insufficient expansion for justification when there are multiple inline boxes
516         https://bugs.webkit.org/show_bug.cgi?id=60432
517
518         * rendering/InlineTextBox.h:
519         (WebCore::InlineTextBox::setExpansion): Changed back to take a int, since the m_expansion member
520         variable is a (truncated) int anyway.
521         * rendering/RenderBlockLineLayout.cpp:
522         (WebCore::computeExpansionForJustifiedText): Changed the expansion local variable into an int
523         so that the right amount is added to the total width. Also changed to use an early return.
524
525 2011-05-08  Pavel Feldman  <pfeldman@chromium.org>
526
527         Not reviewed: ignore 0 responses in the inspector network instrumentation.
528
529         * inspector/front-end/NetworkManager.js:
530
531 2011-05-08  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
532
533         Reviewed by Kenneth Rohde Christiansen.
534
535         [Qt] GraphicsContext3D::getImageData() does not retrieve image data correctly
536         https://bugs.webkit.org/show_bug.cgi?id=58556
537
538         Tests: fast/canvas/webgl/gl-teximage.html
539
540         * platform/graphics/qt/GraphicsContext3DQt.cpp:
541         (WebCore::GraphicsContext3D::getImageData):
542
543 2011-05-07  Dan Bernstein  <mitz@apple.com>
544
545         Reviewed by Maciej Stachowiak.
546
547         <rdar://problem/9403055> REGRESSION (r85499): Inline images in iChat overflow their chat bubbles
548         https://bugs.webkit.org/show_bug.cgi?id=60443
549
550         Test: fast/replaced/table-percent-height-positioned.html
551
552         * rendering/RenderBox.cpp:
553         (WebCore::RenderBox::computeReplacedLogicalHeightUsing): Do not apply the logic to prevent precent-height
554         replaced elements from being squeezed by table cells when the replaced element is positioned (and thus
555         doesn’t affect the table cell’s height).
556
557 2011-05-07  Sheriff Bot  <webkit.review.bot@gmail.com>
558
559         Unreviewed, rolling out r86016.
560         http://trac.webkit.org/changeset/86016
561         https://bugs.webkit.org/show_bug.cgi?id=60445
562
563         caused crashes on the WK2 Windows bots (Requested by
564         jessieberlin on #webkit).
565
566         * platform/network/ResourceHandle.h:
567         * platform/network/cf/CookieStorageCFNet.cpp:
568         (WebCore::currentCookieStorage):
569         (WebCore::defaultCookieStorage):
570         * platform/network/cf/ResourceHandleCFNet.cpp:
571         (WebCore::willSendRequest):
572         (WebCore::makeFinalRequest):
573         (WebCore::ResourceHandle::willSendRequest):
574         * platform/network/cf/ResourceRequestCFNet.cpp:
575         (WebCore::ResourceRequest::doUpdatePlatformRequest):
576
577 2011-05-07  Sheriff Bot  <webkit.review.bot@gmail.com>
578
579         Unreviewed, rolling out r85974.
580         http://trac.webkit.org/changeset/85974
581         https://bugs.webkit.org/show_bug.cgi?id=60444
582
583         broke browser tests (Requested by inferno-sec on #webkit).
584
585         * platform/network/chromium/ResourceResponse.cpp:
586         (WebCore::ResourceResponse::doPlatformCopyData):
587         (WebCore::ResourceResponse::doPlatformAdopt):
588         * platform/network/chromium/ResourceResponse.h:
589         (WebCore::ResourceResponse::downloadFilePath):
590         (WebCore::ResourceResponse::setDownloadFilePath):
591
592 2011-05-07  Jessie Berlin  <jberlin@apple.com>
593
594         Reviewed by Steve Falkenburg.
595
596         [Windows WebKit2] Use cookies set in WebKit1
597         https://bugs.webkit.org/show_bug.cgi?id=60274
598
599         Share the default storage session between the UI and Web Processes.
600
601         * platform/network/cf/CookieStorageCFNet.cpp:
602         (WebCore::defaultSessionCookieStorage):
603         Keep track of the default storage session cookie storage.
604         (WebCore::currentCookieStorage):
605         Call defaultCookieStorage to get the default cookie storage.
606         (WebCore::defaultCookieStorage):
607         If there is a default storage session cookie storage, prefer that over getting the default
608         cookie storage. In the Web Process, asking CFNetwork for the default cookie storage directly
609         without specifying a storage session will not get the cookie storage being shared by the UI
610         and Web Processes.
611
612         * platform/network/ResourceHandle.h:
613         * platform/network/cf/ResourceHandleCFNet.cpp:
614         (WebCore::willSendRequest):
615         Make sure to set the current storage session on any requests used by the Web
616         Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
617         doing anything with the Web Process's default storage session (which is not the one shared
618         with the UI Process).
619         (WebCore::makeFinalRequest):
620         Ditto.
621         (WebCore::ResourceHandle::willSendRequest):
622         Ditto.
623         (WebCore::ResourceHandle::currentStorageSession):
624         If there is a Private Browsing storage session, return that.
625         If not, on Windows return the default storage session that is being shared with the UI
626         Process and on Mac return 0.
627         (WebCore::defaultCFURLStorageSession):
628         (WebCore::ResourceHandle::setDefaultStorageSession):
629         (WebCore::ResourceHandle::defaultStorageSession):
630
631         * platform/network/cf/ResourceRequestCFNet.cpp:
632         (WebCore::ResourceRequest::doUpdatePlatformRequest):
633         Make sure to set the current storage session on any requests used by the Web
634         Process before CFNetwork has to do anything with them, in order for CFNetwork to avoid
635         doing anything with the Web Process's default storage session (which is not the one shared
636         with the UI Process).
637
638 2011-05-07  Joe Mason  <jmason@rim.com>
639
640         Reviewed by Daniel Bates.
641
642         FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
643         https://bugs.webkit.org/show_bug.cgi?id=52211
644
645         Create a UserGestureIndicator when calling the clientRedirected callback.
646
647         * loader/NavigationScheduler.cpp:
648         (WebCore::ScheduledURLNavigation::didStartTimer):
649         (WebCore::ScheduledURLNavigation::didStopTimer):
650         (WebCore::ScheduledFormSubmission::didStartTimer):
651         (WebCore::ScheduledFormSubmission::didStopTimer):
652
653 2011-05-06  Jon Lee  <jonlee@apple.com>
654
655         Reviewed by Alice Liu.
656
657         Crash when sending a wheel event to a node with no shadow ancestor node
658         https://bugs.webkit.org/show_bug.cgi?id=60429
659         <rdar://problem/9389619>
660
661         * page/EventHandler.cpp:
662         (WebCore::EventHandler::handleWheelEvent):add check to see if the shadow ancestor node of the node that was under the mouse exists before trying to dispatch the wheel event to it.
663
664 2011-05-06  Kent Tamura  <tkent@chromium.org>
665
666         Reviewed by Ryosuke Niwa.
667
668         Eliminate WebCore/dom/InputElement.{cpp,h}
669         https://bugs.webkit.org/show_bug.cgi?id=60262
670
671         - Fold in all of the code of InputElement.{cpp,h} into HTMLInputElement
672           and TextFieldInputType.
673         - Change the return type of Node::toInputElement():
674           InputElement* -> HTMLInputElement*
675
676         No new tests. This change should not change the existing behaviour.
677
678         * CMakeLists.txt: Remove InpuntElement.cpp and/or InputElement.h.
679         * GNUmakefile.list.am: ditto.
680         * WebCore.exp.in: Add symbols of functions exposed to WebKit.
681         * WebCore.gypi: Remove InpuntElement.cpp and/or InputElement.h.
682         * WebCore.pro: ditto.
683         * WebCore.vcproj/WebCore.vcproj: ditto.
684         * WebCore.xcodeproj/project.pbxproj: ditto.
685         * accessibility/AXObjectCache.cpp:
686         (WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
687           Follow the return type change of Node::toInputElement().
688         * accessibility/AccessibilityRenderObject.cpp:
689         (WebCore::AccessibilityRenderObject::isPasswordField): ditto.
690         (WebCore::AccessibilityRenderObject::isIndeterminate): ditto.
691         (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio): ditto.
692         (WebCore::AccessibilityRenderObject::isChecked): ditto.
693         * css/CSSStyleSelector.cpp:
694         (WebCore::CSSStyleSelector::canShareStyleWithElement): ditto.
695         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ditto.
696         * dom/CheckedRadioButtons.cpp:
697         (WebCore::CheckedRadioButtons::removeButton): ditto.
698         * dom/DOMAllInOne.cpp: Remove InputElement.h.
699         * dom/InputElement.cpp: Removed.
700         * dom/InputElement.h: Removed.
701         * dom/Node.cpp:
702         (WebCore::Node::toInputElement):
703           Change the return type from InputElement* to HTMLInputElement*.
704         * dom/Node.h: ditto.
705         * html/HTMLInputElement.cpp:
706         (WebCore::HTMLInputElement::HTMLInputElement):
707         (WebCore::HTMLInputElement::formControlName):
708         (WebCore::HTMLInputElement::tooLong):
709         (WebCore::HTMLInputElement::updateFocusAppearance):
710         (WebCore::HTMLInputElement::aboutToUnload):
711         (WebCore::HTMLInputElement::handleFocusEvent):
712         (WebCore::HTMLInputElement::handleBlurEvent):
713         (WebCore::HTMLInputElement::updateType):
714         (WebCore::HTMLInputElement::parseMappedAttribute):
715         (WebCore::HTMLInputElement::size):
716         (WebCore::HTMLInputElement::copyNonAttributeProperties):
717         (WebCore::HTMLInputElement::value):
718         (WebCore::HTMLInputElement::suggestedValue):
719         (WebCore::HTMLInputElement::setSuggestedValue):
720         (WebCore::HTMLInputElement::setValue):
721         (WebCore::HTMLInputElement::setValueFromRenderer):
722         (WebCore::HTMLInputElement::setFileListFromRenderer):
723         (WebCore::HTMLInputElement::setDefaultName):
724         (WebCore::HTMLInputElement::maxLength):
725         (WebCore::HTMLInputElement::cacheSelection):
726         (WebCore::formatCodes): Moved from InputElement.
727         (WebCore::cursorPositionToMaskIndex): ditto.
728         (WebCore::HTMLInputElement::isConformToInputMask): ditto.
729         (WebCore::HTMLInputElement::validateInputMask): ditto.
730         (WebCore::HTMLInputElement::setWapInputFormat): ditto.
731         (WebCore::HTMLInputElement::notifyFormStateChanged): ditto.
732         (WebCore::HTMLInputElement::parseMaxLengthAttribute): ditto.
733         (WebCore::HTMLInputElement::updateValueIfNeeded):ditto.
734         * html/HTMLInputElement.h:
735           - Add data members which were defined in InputElementData.
736           - Make some functions public because the public interface InputElement is removed.
737           - Make some functions non-virtual because they don't override
738             corresponding virtual functions of InputElement anymore.
739         (WebCore::HTMLInputElement::toInputElement):
740           Follow the return type change of Node::toInputElement().
741         (WebCore::HTMLInputElement::isIndeterminate):
742         (WebCore::HTMLInputElement::isAutofilled):
743         (WebCore::HTMLInputElement::supportsMaxLength):
744         (WebCore::HTMLInputElement::cachedSelectionStart):
745         (WebCore::HTMLInputElement::cachedSelectionEnd):
746         * html/HTMLTextAreaElement.cpp: Remove unused InputElement.h.
747         * html/InputType.cpp:
748         (WebCore::InputType::handleBeforeTextInsertedEvent): Remove the code.
749         * html/InputType.h: Update for the above.
750         * html/TextFieldInputType.cpp:
751         (WebCore::replaceEOLAndLimitLength): Moved from InputElement.cpp.
752         (WebCore::TextFieldInputType::sanitizeValue): Implement with replaceEOLAndLimitLength().
753         (WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):
754           Move the code from InputElement::handleBeforeTextInsertedEvent().
755         * html/TextFieldInputType.h: Update declarations.
756         * rendering/RenderTextControlSingleLine.cpp:
757           - Remove ASSERT(node()->isHTMLElement()) because it is checked in the constructor.
758           - Follow the return type change of inputElement().
759         (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
760           Make sure node() is an HTMLInputElement instance.
761         (WebCore::RenderTextControlSingleLine::addSearchResult):
762         (WebCore::RenderTextControlSingleLine::stopSearchEventTimer):
763         (WebCore::RenderTextControlSingleLine::showPopup):
764         (WebCore::RenderTextControlSingleLine::hidePopup):
765         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
766         (WebCore::RenderTextControlSingleLine::updateFromElement):
767         (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
768         (WebCore::RenderTextControlSingleLine::createResultsButtonStyle):
769         (WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
770         (WebCore::RenderTextControlSingleLine::createInnerSpinButtonStyle):
771         (WebCore::RenderTextControlSingleLine::createOuterSpinButtonStyle):
772         (WebCore::RenderTextControlSingleLine::createSpeechButtonStyle):
773         (WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
774         (WebCore::RenderTextControlSingleLine::startSearchEventTimer):
775         (WebCore::RenderTextControlSingleLine::searchEventTimerFired):
776         (WebCore::RenderTextControlSingleLine::valueChanged):
777         (WebCore::RenderTextControlSingleLine::setTextFromItem):
778         (WebCore::RenderTextControlSingleLine::inputElement):
779         * rendering/RenderTextControlSingleLine.h:
780           Change the return type of inputElement(): InputElement* -> HTMLInputElement*.
781         * rendering/RenderTheme.cpp:
782         (WebCore::RenderTheme::isChecked):
783           Follow the return type change of Node::toInputElement().
784         (WebCore::RenderTheme::isIndeterminate): ditto.
785         (WebCore::RenderTheme::shouldHaveSpinButton):
786           Change the parameter type: InputElement* -> HTMLInputElement*.
787         * rendering/RenderTheme.h: ditto.
788
789 2011-05-06  Adam Barth  <abarth@webkit.org>
790
791         Reviewed by Eric Seidel.
792
793         Implement "Report-Only" mode for CSP
794         https://bugs.webkit.org/show_bug.cgi?id=60402
795
796         This mode lets web sites try out CSP by getting violation reports (and
797         console spam) without actually changing the behavior of their web sites.
798
799         Test: http/tests/security/contentSecurityPolicy/report-only.html
800
801         * dom/Document.cpp:
802         (WebCore::Document::processHttpEquiv):
803         * loader/FrameLoader.cpp:
804         (WebCore::FrameLoader::didBeginDocument):
805         * page/ContentSecurityPolicy.cpp:
806         (WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
807         (WebCore::ContentSecurityPolicy::didReceiveHeader):
808         (WebCore::ContentSecurityPolicy::reportViolation):
809         (WebCore::ContentSecurityPolicy::checkInlineAndReportViolation):
810         (WebCore::ContentSecurityPolicy::checkEvalAndReportViolation):
811         (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation):
812         (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
813         * page/ContentSecurityPolicy.h:
814
815 2011-05-06  Beth Dakin  <bdakin@apple.com>
816
817         Reviewed by Darin Adler.
818
819         https://bugs.webkit.org/show_bug.cgi?id=60421
820         Custom scrollbars nested inside an overlay scrollbar overflow region end up 
821         painting twice
822         -and corresponding-
823         <rdar://problem/9389072>
824
825         Be sure not to paint custom css scrollbars during the special overlay-scrollbar 
826         painting pass.
827         * rendering/RenderLayer.cpp:
828         (WebCore::RenderLayer::paintOverflowControls):
829
830 2011-05-06  Cary Clark  <caryclark@google.com>
831
832         Reviewed by Eric Seidel.
833
834         Add utility for converting SkCanvas to CGContext
835         https://bugs.webkit.org/show_bug.cgi?id=59808
836
837         Skia on Mac uses Skia to render WebKit, and CG 
838         to render UI elements. The CG elements need a 
839         transcribed graphics context that preserves the 
840         canvas matrix, and the canvas clip. 
841
842         The BitLockerSkia utility class sets up a CGContext 
843         from the SkCanvas, locks the bitmap's bits, and 
844         releases the lock when the class goes out of scope. 
845
846         Each time the CGContext is retrieved, it is rebuilt. 
847         This permits the caller to modify the same canvas 
848         between calls. 
849
850         This change adds utilities but does not modify any 
851         existing code. For now, there are no callers to these 
852         utilities, so there is no functional change.
853
854         No new tests.
855
856         * platform/graphics/skia/BitLockerSkia.cpp: Added.
857         (WebCore::SkMatrixToCGAffineTransform): Conversion utility.
858         (WebCore::BitLockerSkia::BitLockerSkia): Takes SkCanvas.
859         (WebCore::BitLockerSkia::~BitLockerSkia): Unlocks, cleans up.
860         (WebCore::BitLockerSkia::release): Internal private helper.
861         (WebCore::BitLockerSkia::cgContext): Returns CGContextRef.
862         * platform/graphics/skia/BitLockerSkia.h: Added.
863
864 2011-05-06  Martin Robinson  <mrobinson@igalia.com>
865
866         Reviewed by Xan Lopez.
867
868         [GTK] [WebKit2] WebView::windowToScreen needs an implementation
869         https://bugs.webkit.org/show_bug.cgi?id=55960
870
871         Abstract coordinate system translation code from WebKit into WebCore.
872         This will allow the code to be shared between WebKit and WebKit2. The code
873         now lives in a new GtkUtilities.cpp helper file.
874
875         * GNUmakefile.list.am: Added GtkUtilities to the source list.
876         * platform/gtk/GtkUtilities.cpp: Added.
877         (WebCore::convertWidgetRectToScreenRect):
878         * platform/gtk/GtkUtilities.h: Added.
879
880 2011-05-06  Martin Robinson  <mrobinson@igalia.com>
881
882         Reviewed by Xan Lopez.
883
884         Remove some unnecessary static methods in ResourceHandleSoup.
885
886         No new tests. This is only a small cleanup.
887
888         * platform/network/soup/ResourceHandleSoup.cpp:
889         (WebCore::restartedCallback): Call ResourceResponse::updateFromSoupMessage directly.
890         (WebCore::gotHeadersCallback):Ditto.
891         (WebCore::contentSniffedCallback):Ditto.
892         (WebCore::sendRequestCallback):Ditto.
893         (WebCore::ResourceHandle::defaultSession): Create the soup session directly.
894
895 2011-05-06  Martin Robinson  <mrobinson@igalia.com>
896
897         Reviewed by Xan Lopez.
898
899         [Soup] ResourceHandles are leaked on 304 responses
900         https://bugs.webkit.org/show_bug.cgi?id=60413
901
902         Always call cleanupSoupRequestOperation, even when the request was not
903         canceled. Before the code would call didFinishLoading and then never clean up
904         the request.
905
906         No new tests. This simply fixes a memory leak.
907
908         * platform/network/soup/ResourceHandleSoup.cpp:
909         (WebCore::sendRequestCallback):
910
911 2011-05-06  Adam Barth  <abarth@webkit.org>
912
913         Reviewed by Eric Seidel.
914
915         Add disable-javascript-urls CSP directive
916         https://bugs.webkit.org/show_bug.cgi?id=60301
917
918         This CSP directive is not in the CSP spec.  This patch is somewhat of
919         an experiment to see whether this feature is useful.  Based on our
920         implementation experience, we will coordinate with folks via the W3C to
921         see if this makes sense to add to the spec.
922
923         Test: http/tests/security/contentSecurityPolicy/javascript-urls-blocked.html
924
925         * page/ContentSecurityPolicy.cpp:
926         (WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
927         (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
928         (WebCore::ContentSecurityPolicy::addDirective):
929         * page/ContentSecurityPolicy.h:
930
931 2011-05-06  Brett Wilson  <brettw@chromium.org>
932
933         Reviewed by Adam Barth.
934
935         Use a File object to store the downloaded file reference rather than
936         just the path. This keeps the file and permissions in scope (using the
937         already-existing blob system) so the browser won't delete the file
938         when the load is complete. Instead, the file will be cleaned up when
939         the request objects are deleted.
940         https://bugs.webkit.org/show_bug.cgi?id=60281
941
942         * platform/network/chromium/ResourceResponse.cpp:
943         (WebCore::ResourceResponse::doPlatformCopyData):
944         (WebCore::ResourceResponse::doPlatformAdopt):
945         * platform/network/chromium/ResourceResponse.h:
946         (WebCore::ResourceResponse::downloadedFile):
947         (WebCore::ResourceResponse::setDownloadedFile):
948
949 2011-05-06  Alexis Menard  <alexis.menard@openbossa.org>
950
951         Reviewed by Darin Adler.
952
953         Fix two warnings of unused variables.
954         https://bugs.webkit.org/show_bug.cgi?id=60370
955
956         Remove two unused local variable from the code.
957
958         No new tests, the existing ones should cover.
959
960         * rendering/RenderFlexibleBox.cpp:
961         (WebCore::RenderFlexibleBox::layoutVerticalBox):
962         * svg/animation/SVGSMILElement.cpp:
963         (WebCore::SVGSMILElement::calculateNextProgressTime):
964
965 2011-05-06  Adam Barth  <abarth@webkit.org>
966
967         Reviewed by Eric Seidel.
968
969         Wire up CSP's eval blocking to V8's new API
970         https://bugs.webkit.org/show_bug.cgi?id=60384
971
972         * bindings/v8/ScriptController.cpp:
973         (WebCore::ScriptController::disableEval):
974
975 2011-05-06  David Hyatt  <hyatt@apple.com>
976
977         Reviewed by Dan Bernstein.
978
979         https://bugs.webkit.org/show_bug.cgi?id=60398 (<rdar://problem/9307696>)
980         REGRESSION (r81684?): cox.com sign in button is missing
981         
982         Fix a typo in r81684 where the ascent was used in a comparison instead of boxHeight.
983         This restores the original behavior before the refactoring messed it up.
984
985         Added fast/inline/nested-top-alignment.html
986
987         * rendering/InlineFlowBox.cpp:
988         (WebCore::InlineFlowBox::computeLogicalBoxHeights):
989
990 2011-05-06  David Hyatt  <hyatt@apple.com>
991
992         Reviewed by Dan Bernstein.
993
994         https://bugs.webkit.org/show_bug.cgi?id=60390 (<rdar://problem/9364449>)
995         REGRESSION (r81992): portions of ticketmaster site render blank
996
997         Make simplified layout skip from a positioned object out to its containing block.  There is no
998         need to dirty the intermediate inlines, and in this case it's actively harmful, since the
999         block responsible for the layout of the positioned object doesn't get m_posChildNeedsLayout set.
1000
1001         Added fast/block/positioning/hiding-inside-relpositioned-inline.html
1002
1003         * rendering/RenderObject.h:
1004         (WebCore::RenderObject::markContainingBlocksForLayout):
1005
1006 2011-05-06  Pavel Feldman  <pfeldman@chromium.org>
1007
1008         Not reviewed: move selection test into the text area branch.
1009
1010         * inspector/front-end/TextViewer.js:
1011         (WebInspector.TextViewer.prototype._contextMenu):
1012
1013 2011-05-04  Adrienne Walker  <enne@google.com>
1014
1015         Reviewed by James Robinson.
1016
1017         [chromium] Fix incorrect scissor rect for layers that render into a rendersurface
1018         https://bugs.webkit.org/show_bug.cgi?id=59020
1019
1020         Allow for empty scissor rects, which implies scissoring to the render
1021         surface. The previous code and previous patch on this bug both didn't
1022         take into account that the scissor rect should be the render surface
1023         and not the projection of the layer itself, because child layers
1024         aren't necessarily contained within the bounds of their superlayer.
1025
1026         Test: compositing/flat-with-transformed-child.html
1027
1028         * platform/graphics/chromium/LayerRendererChromium.cpp:
1029         (WebCore::LayerRendererChromium::paintLayerContents):
1030         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
1031         (WebCore::LayerRendererChromium::drawLayer):
1032         (WebCore::LayerRendererChromium::setScissorToRect):
1033
1034 2011-05-06  Simon Fraser  <simon.fraser@apple.com>
1035
1036         Reviewed by Sam Weinig.
1037
1038         Lazily allocate ScrollAnimator in ScrollableArea
1039         https://bugs.webkit.org/show_bug.cgi?id=60327
1040
1041         Avoid allocating the ScrollAnimator up-front, because we
1042         create lots of ScrollableAreas via RenderLayer, and we should
1043         only need the animator when scrolling.
1044
1045         * platform/ScrollableArea.cpp:
1046         (WebCore::ScrollableArea::ScrollableArea):
1047         (WebCore::ScrollableArea::scrollAnimator):
1048         (WebCore::ScrollableArea::scroll):
1049         (WebCore::ScrollableArea::scrollToOffsetWithoutAnimation):
1050         (WebCore::ScrollableArea::scrollToXOffsetWithoutAnimation):
1051         (WebCore::ScrollableArea::scrollToYOffsetWithoutAnimation):
1052         (WebCore::ScrollableArea::handleWheelEvent):
1053         (WebCore::ScrollableArea::handleGestureEvent):
1054         * platform/ScrollableArea.h:
1055
1056 2011-05-06  Eric Carlson  <eric.carlson@apple.com>
1057
1058         Reviewed by Darin Adler.
1059
1060         REGRESSION (r77954): HTTP Live Streams have incorrect controller UI
1061         https://bugs.webkit.org/show_bug.cgi?id=60304
1062         <rdar://problem/9392609>
1063
1064         Don't assume that the only time the media controls UI may need to change is on a 
1065         network state change, readyState changes can be significant as well.
1066
1067         Tested manually because we don't have any live streams to test in DRT.
1068
1069         * html/HTMLMediaElement.cpp:
1070         (WebCore::HTMLMediaElement::setNetworkState): changedNetworkState -> updateStatusDisplay.
1071         (WebCore::HTMLMediaElement::setReadyState): Call updateStatusDisplay.
1072
1073         * html/shadow/MediaControlRootElement.cpp:
1074         (WebCore::MediaControlRootElement::reset): changedNetworkState -> updateStatusDisplay.
1075         (WebCore::MediaControlRootElement::updateStatusDisplay): Ditto.
1076         * html/shadow/MediaControlRootElement.h:
1077
1078         * html/shadow/MediaControlRootElementChromium.cpp:
1079         (WebCore::MediaControlRootElementChromium::reset): Ditto.
1080         (WebCore::MediaControlRootElementChromium::updateStatusDisplay): Ditto.
1081         * html/shadow/MediaControlRootElementChromium.h:
1082         * html/shadow/MediaControls.h:
1083
1084 2011-05-06  Andreas Kling  <andreas.kling@nokia.com>
1085
1086         Unreviewed Qt 4.8 build fix.
1087
1088         * WebCore.pro: Don't set HAVE_QRAWFONT yet. Left a FIXME so we can
1089         enable it after the 4.8 bots are updated with the full QRawFont APIs.
1090
1091 2011-05-06  Alexander Pavlov  <apavlov@chromium.org>
1092
1093         Reviewed by Yury Semikhatsky.
1094
1095         Web Inspector: editing CSS in the Resources panel and not committing does not revert the change.
1096         https://bugs.webkit.org/show_bug.cgi?id=60319
1097
1098         * inspector/front-end/ResourceView.js:
1099         (WebInspector.ResourceSourceFrame.prototype.cancelEditing):
1100
1101 2011-05-06  Joe Mason  <jmason@rim.com>
1102
1103         Reviewed by Adam Barth.
1104
1105         WebSocket urls should always be encoded as UTF-8.
1106         https://bugs.webkit.org/show_bug.cgi?id=57138
1107
1108         Change WebSocket::connect to take the raw URL string and parse it
1109         internally using the simple KURL constructor, which expects an absolute
1110         UTF-8 encoded URL.  This ensures that all code that creates a WebSocket
1111         goes through this method instead of completeURL.
1112
1113         Test: http/tests/websocket/tests/url-with-nonascii-query.html
1114
1115         * bindings/js/JSWebSocketCustom.cpp:
1116         (WebCore::JSWebSocketConstructor::constructJSWebSocket): Pass String instead of KURL to WebSocket::connect().
1117         * websockets/WebSocket.cpp:
1118         (WebCore::WebSocket::connect): Now takes a String instead of a KURL and parses it using UTF-8.
1119         * websockets/WebSocket.h:
1120
1121 2011-05-06  Luke Macpherson   <macpherson@chromium.org>
1122
1123         Reviewed by Eric Seidel.
1124
1125         Make CSSStyleSelector::applyProperty() CSSPropertyWebkitColorCorrection case use appropriate macro.
1126         https://bugs.webkit.org/show_bug.cgi?id=60339
1127
1128         No tests added as no functionality changed.
1129
1130         * css/CSSStyleSelector.cpp:
1131         (WebCore::CSSStyleSelector::applyProperty):
1132         Use correct macro for CSSPropertySpeak.
1133         * rendering/style/RenderStyle.h:
1134         (WebCore::InheritedFlags::initialColorSpace):
1135         Add initialColorSpace() static method.
1136
1137 2011-05-06  Luke Macpherson   <macpherson@chromium.org>
1138
1139         Reviewed by Eric Seidel.
1140
1141         Make RenderStyle::setPageBreakInside() reject unsupported enum values.
1142         https://bugs.webkit.org/show_bug.cgi?id=60235
1143
1144         No tests added as no functionality changed.
1145
1146         * css/CSSStyleSelector.cpp:
1147         (WebCore::CSSStyleSelector::applyProperty):
1148         Remove special-case code and use appropriate macro.
1149         * rendering/style/RenderStyle.h:
1150         (WebCore::InheritedFlags::setPageBreakInside):
1151         Assert that only supported values are used.
1152
1153 2011-05-06  Luke Macpherson   <macpherson@chromium.org>
1154
1155         Reviewed by Eric Seidel.
1156
1157         Move burden of checking for BJustify box alignment into RenderStyle
1158         https://bugs.webkit.org/show_bug.cgi?id=60246
1159
1160         No new tests added as no functionality changed.
1161
1162         * css/CSSStyleSelector.cpp:
1163         (WebCore::CSSStyleSelector::applyProperty):
1164         Remove special-case logic checking for BJUSTIFY and use existing macro.
1165         * rendering/style/RenderStyle.h:
1166         (WebCore::InheritedFlags::setBoxAlign):
1167         Assert valid values are used.
1168
1169 2011-05-06  Luke Macpherson   <macpherson@chromium.org>
1170
1171         Reviewed by Eric Seidel.
1172
1173         Make CSSStyleSelector::applyProperty() CSSPropertyPointerEvents use the correct macro.
1174         https://bugs.webkit.org/show_bug.cgi?id=60338
1175
1176         No tests added as no functionality changed.
1177
1178         * css/CSSStyleSelector.cpp:
1179         (WebCore::CSSStyleSelector::applyProperty):
1180         Use correct macro for CSSPropertySpeak.
1181
1182 2011-05-06  Alexis Menard  <alexis.menard@openbossa.org>
1183
1184         Reviewed by Alexey Proskuryakov.
1185
1186         Build fix with gcc 4.6 and c++0x support.
1187         https://bugs.webkit.org/show_bug.cgi?id=60284
1188
1189         When enabling support of c++0x the compilation fails because of an
1190         ambiguous overload error. In this code when constructing the pair
1191         we use the new c++0x rvalue reference feature (&&). It means we are
1192         calling String(const WTF::AtomicString&) which becomes ambiguous because
1193         it has an overload WTF::String::String(const WTF::String&) and usually one
1194         with the native port string type (e.g. QString). In this code we want the
1195         String version because the pair store Strings.
1196
1197         No new tests, build fix.
1198
1199         * loader/FormSubmission.cpp:
1200         (WebCore::FormSubmission::create):
1201
1202 2011-05-06  Cris Neckar  <cdn@chromium.org>
1203
1204         Reviewed by Dirk Schulze.
1205
1206         Tests for crash when a transform is applied to certain filters.
1207         https://bugs.webkit.org/show_bug.cgi?id=59551
1208
1209         Test: svg/filters/filter-after-transform-crash.svg
1210
1211         * platform/graphics/filters/FEComposite.cpp:
1212         (WebCore::FEComposite::determineAbsolutePaintRect):
1213         * platform/graphics/filters/FEConvolveMatrix.h:
1214         (WebCore::FEConvolveMatrix::determineAbsolutePaintRect):
1215         * platform/graphics/filters/FEDisplacementMap.h:
1216         (WebCore::FEDisplacementMap::determineAbsolutePaintRect):
1217         * platform/graphics/filters/FEFlood.h:
1218         (WebCore::FEFlood::determineAbsolutePaintRect):
1219         * platform/graphics/filters/FELighting.h:
1220         (WebCore::FELighting::determineAbsolutePaintRect):
1221         * platform/graphics/filters/FETile.h:
1222         (WebCore::FETile::determineAbsolutePaintRect):
1223         * platform/graphics/filters/FETurbulence.h:
1224         (WebCore::FETurbulence::determineAbsolutePaintRect):
1225         * platform/graphics/filters/FilterEffect.cpp:
1226         (WebCore::isFilterSizeValid):
1227         (WebCore::FilterEffect::determineAbsolutePaintRect):
1228         (WebCore::FilterEffect::asUnmultipliedImage):
1229         (WebCore::FilterEffect::asPremultipliedImage):
1230         (WebCore::FilterEffect::copyUnmultipliedImage):
1231         (WebCore::FilterEffect::copyPremultipliedImage):
1232         (WebCore::FilterEffect::createUnmultipliedImageResult):
1233         (WebCore::FilterEffect::createPremultipliedImageResult):
1234         * platform/graphics/filters/FilterEffect.h:
1235         (WebCore::FilterEffect::maxEffectRect):
1236         (WebCore::FilterEffect::setMaxEffectRect):
1237         * rendering/svg/RenderSVGResourceFilter.cpp:
1238         * rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
1239         (WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
1240
1241 2011-05-06  Luke Macpherson   <macpherson@chromium.org>
1242
1243         Reviewed by Eric Seidel.
1244
1245         Use cast to convert primitive value to FontSmoothingMode.
1246         https://bugs.webkit.org/show_bug.cgi?id=60242
1247
1248         No tests added as no functionality changed.
1249
1250         * css/CSSStyleSelector.cpp:
1251         (WebCore::CSSStyleSelector::applyProperty):
1252         Use cast to convert primitive value to FontSmoothingMode.
1253
1254 2011-05-05  Luke Macpherson   <macpherson@chromium.org>
1255
1256         Reviewed by Eric Seidel.
1257
1258         Make CSSPropertySpeak use the correct macro.
1259         https://bugs.webkit.org/show_bug.cgi?id=60335
1260
1261         No tests added as no functionality changed.
1262
1263         * css/CSSStyleSelector.cpp:
1264         (WebCore::CSSStyleSelector::applyProperty):
1265         Use correct macro for CSSPropertySpeak.
1266
1267 2011-05-05  Eric Carlson  <eric.carlson@apple.com>
1268
1269         Reviewed by Maciej Stachowiak.
1270
1271         <rdar://problem/9390864>
1272         https://bugs.webkit.org/show_bug.cgi?id=60343
1273         Crash on Recovery System when trying to load page that includes media element
1274
1275         Automated test not possible, tested manually.
1276
1277         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
1278         (WebCore::MediaPlayerPrivateAVFoundationObjC::isAvailable): Only return true if
1279             AVFoundation and CoreMedia are installed.
1280
1281         * platform/mac/SoftLinking.h: Define SOFT_LINK_FRAMEWORK_OPTIONAL, identical to 
1282             SOFT_LINK_FRAMEWORK except that it doesn't ASSERT if the framework doesn't exist.
1283
1284 2011-05-05  Eric Carlson  <eric.carlson@apple.com>
1285
1286         Reviewed by Darin Adler.
1287
1288         Live streams sometimes won't play with AVFoundation backend
1289         https://bugs.webkit.org/show_bug.cgi?id=58961
1290         rdar://problem/9284748
1291
1292         Tested manually because we don't have any live streams to test in DRT.
1293
1294         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
1295         (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Don't special case seeking, assume
1296             AVFoundation will notify us when internal states change.
1297
1298         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Make m_timeObserver
1299             a RetainPtr
1300         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
1301         (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Ditto.
1302         (WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Ditto.
1303
1304 2011-05-05  Jay Civelli  <jcivelli@chromium.org>
1305
1306         Reviewed by Adam Barth.
1307
1308         Adding quoted-printable encoding/decoding capabilities.
1309         This is needed for MHTML support.
1310         https://bugs.webkit.org/show_bug.cgi?id=59834
1311
1312         * CMakeLists.txt:
1313         * GNUmakefile.list.am:
1314         * WebCore.gypi:
1315         * WebCore.pro:
1316         * WebCore.vcproj/WebCore.vcproj:
1317         * WebCore.xcodeproj/project.pbxproj:
1318         * platform/text/QuotedPrintable.cpp: Added.
1319         * platform/text/QuotedPrintable.h: Added.
1320
1321 2011-05-05  Andy Estes  <aestes@apple.com>
1322
1323         Reviewed by Eric Seidel.
1324
1325         Implement document.innerHTML
1326         https://bugs.webkit.org/show_bug.cgi?id=60316
1327
1328         ASSERT that contextElement is non-0 when constructing a HTMLTreeBuilder
1329         for fragment parsing. This assertion will become invalid when
1330         document.innerHTML is implemented, which is the only case where HTML5
1331         specifies that a fragment will not have a context element.
1332
1333         * html/parser/HTMLTreeBuilder.cpp:
1334         (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
1335
1336 2011-05-05  Kevin Ollivier  <kevino@theolliviers.com>
1337
1338         [wx] Unreviewed build fix. Include ApplicationServices for wx port.
1339
1340         * platform/graphics/GlyphBuffer.h:
1341         * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
1342
1343 2011-05-05  Dan Bernstein  <mitz@apple.com>
1344
1345         Reviewed by Simon Fraser.
1346
1347         WebCore part of <rdar://problem/9155590> Broken animation in iAd producer
1348
1349         * WebCore.exp.in: Export wkExecutableWasLinkedOnOrBeforeSnowLeopard.
1350         * platform/graphics/ca/GraphicsLayerCA.cpp:
1351         (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes): Account for the binary-compatiblity
1352         check in Core Animation.
1353         * platform/mac/WebCoreSystemInterface.h: Added wkExecutableWasLinkedOnOrBeforeSnowLeopard.
1354         * platform/mac/WebCoreSystemInterface.mm: Ditto.
1355
1356 2011-05-05  Sam Weinig  <sam@webkit.org>
1357
1358         Reviewed by Anders Carlsson.
1359
1360         WebKit2 (Mac): Background tabs/windows can force themselves to the front
1361         <rdar://problem/9386346>
1362         https://bugs.webkit.org/show_bug.cgi?id=60315
1363
1364         * platform/mac/WidgetMac.mm:
1365         (WebCore::Widget::setFocus):
1366         It is incorrect for us to call Chrome::focus() here, which could bring a window/tab
1367         to the front. Calling focusNSView() was only necessary because in WebKit we must inform
1368         the platform widget that the focus has changed. WebKit2 Mac now matches other ports.
1369
1370 2011-05-05  Justin Novosad  <junov@chromium.org>
1371
1372         Reviewed by Kenneth Russell.
1373
1374         [Chromium] Change the --accelerated-2d-canvas flag to mean Ganesh, and stop using --enable-accelerated-drawing for that purpose
1375         https://bugs.webkit.org/show_bug.cgi?id=60173
1376
1377         * page/Page.cpp:
1378         (WebCore::Page::sharedGraphicsContext3D):
1379         Flipping the switch to make Skia the default for the accelerated 2d canvas
1380
1381 2011-05-05  Tony Gentilcore  <tonyg@chromium.org>
1382
1383         Reviewed by Adam Barth.
1384
1385         ASSERT(m_state == ParsingState) fires @ www.canalplus.fr
1386         https://bugs.webkit.org/show_bug.cgi?id=60101
1387
1388         Test: fast/parser/close-while-stopping.html
1389
1390         * dom/Document.cpp:
1391         (WebCore::Document::close): According to http://www.whatwg.org/specs/web-apps/current-work/#dom-document-close,
1392         the close() steps should be aborted if there is no script-created parser
1393         associated with the document. Our parser lives throughout
1394         http://www.whatwg.org/specs/web-apps/current-work/#the-end, but it seems
1395         the spec doesn't consider the parser active any more. So to properly
1396         respect this, we need to check that the parser is still parsing.
1397
1398 2011-04-28  Evan Martin  <evan@chromium.org>
1399
1400         Reviewed by Ojan Vafai.
1401
1402         REGRESSION: backspace should not go back on Linux
1403         https://bugs.webkit.org/show_bug.cgi?id=59731
1404
1405         Add a new EditingBehavior, shouldNavigateBackOnBackspace, which is false on
1406         Linux, and test for it in the default backspace handler.
1407
1408         * editing/EditingBehavior.h:
1409         (WebCore::EditingBehavior::shouldNavigateBackOnBackspace):
1410         * page/EventHandler.cpp:
1411         (WebCore::EventHandler::defaultBackspaceEventHandler):
1412
1413 2011-05-05  Igor Oliveira  <igor.oliveira@openbossa.org>
1414
1415         Reviewed by Kenneth Russell.
1416
1417         Framebuffer object is being created twice
1418         https://bugs.webkit.org/show_bug.cgi?id=60207
1419
1420         Does not create more than one opengl framebuffer
1421
1422         * platform/graphics/gpu/mac/DrawingBufferMac.mm:
1423         (WebCore::DrawingBuffer::DrawingBuffer):
1424         * platform/graphics/gpu/qt/DrawingBufferQt.cpp:
1425         (WebCore::DrawingBuffer::DrawingBuffer):
1426         * platform/graphics/gtk/DrawingBufferGtk.cpp:
1427         (WebCore::DrawingBuffer::DrawingBuffer):
1428
1429 2011-05-05  Simon Fraser  <simon.fraser@apple.com>
1430
1431         Reviewed by Beth Dakin.
1432
1433         Every RenderLayer registers itself as a ScrollableArea
1434         https://bugs.webkit.org/show_bug.cgi?id=59650
1435
1436         Rather than registering every RenderLayer as a ScrollableArea
1437         on layer creation, only register RenderLayers which are overflow-
1438         scrollable. Use the m_scrollableAreaPage pointer to keep track
1439         of whether we've registered to avoid excess work.
1440
1441         * rendering/RenderLayer.cpp:
1442         (WebCore::RenderLayer::RenderLayer):
1443         (WebCore::RenderLayer::scrollsOverflow):
1444         (WebCore::RenderLayer::styleChanged):
1445         * rendering/RenderLayer.h:
1446
1447 2011-05-05  Jer Noble  <jer.noble@apple.com>
1448
1449         Reviewed by Steve Falkenburg.
1450
1451         Workaround iTunes' incorrect registry entry for .m4a extensions.
1452         https://bugs.webkit.org/show_bug.cgi?id=60229
1453
1454         No new tests, as a test already exits for .m4a support (LayoutTests/media/audio-mpeg4-supported.html).
1455         The test failed to catch this regression because the build bots haven't installed iTunes.
1456         
1457         Add a hard-coded MIME type mapping for 'm4a' -> 'audio/x-m4a'.
1458
1459         * platform/win/MIMETypeRegistryWin.cpp:
1460         (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
1461
1462 2011-05-05  Abhishek Arya  <inferno@chromium.org>
1463
1464         Reviewed by Dave Hyatt.
1465
1466         When style changes for a RenderBlock and we lose our ability to intrude into
1467         floats in the next siblings block (e.g a position change), make sure to mark
1468         our childs with floats for layout and iterate through our next sibling block
1469         chain to see which ones contain the float that also exists in our floating
1470         objects list and clear those using markAllDescendantsWithFloatsForLayout.
1471         https://bugs.webkit.org/show_bug.cgi?id=56299
1472
1473         Tests: fast/block/float/float-not-removed-from-next-sibling-crash.html
1474                fast/block/float/float-not-removed-from-next-sibling.html
1475                fast/block/float/float-not-removed-from-next-sibling2.html
1476                fast/block/float/float-not-removed-from-next-sibling3.html
1477                fast/block/float/float-not-removed-from-next-sibling4.html
1478
1479         * rendering/RenderBlock.cpp:
1480         (WebCore::RenderBlock::styleWillChange):
1481         (WebCore::RenderBlock::styleDidChange):
1482         (WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
1483         * rendering/RenderBlock.h:
1484
1485 2011-05-05  Brian Weinstein  <bweinstein@apple.com>
1486
1487         Reviewed by Timothy Hatcher.
1488
1489         WebKit2: Docking Web Inspector doesn't respect maximum inspector size
1490         https://bugs.webkit.org/show_bug.cgi?id=60294
1491         <rdar://problem/9388518>
1492
1493         Make a needed function public and export it.
1494
1495         * WebCore.exp.in: Export constrainedAttaechedWindowHeight.
1496         * inspector/InspectorFrontendClientLocal.h: Make constrainedAttaechedWindowHeight public.
1497
1498 2011-05-05  Tony Gentilcore  <tonyg@chromium.org>
1499
1500         Reviewed by Nate Chapin.
1501
1502         [Navigation Timing] navigationStart should always be available
1503         https://bugs.webkit.org/show_bug.cgi?id=59448
1504
1505         * page/PerformanceTiming.cpp:
1506         (WebCore::PerformanceTiming::navigationStart):
1507
1508 2011-05-05  Eric Carlson  <eric.carlson@apple.com>
1509
1510         Reviewed by Adam Roben.
1511
1512         Block callbacks delivered during destruction
1513         https://bugs.webkit.org/show_bug.cgi?id=60291
1514         <rdar://problem/9382942>
1515
1516         No new tests, tested by existing tests.
1517
1518         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
1519         (WebCore::MediaPlayerPrivateAVFoundation::~MediaPlayerPrivateAVFoundation): Call 
1520             setIgnoreLoadStateChanges(true) to cancel all callbacks.
1521         (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Return immediately if 
1522             m_ignoreLoadStateChanges is true.
1523         (WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): loadStateChanged -> updateStates.
1524             Don't call updateStates after calling loadedTimeRangesChanged, it already does it.
1525         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
1526
1527 2011-05-05  David Hyatt  <hyatt@apple.com>
1528
1529         Reviewed by Darin Adler.
1530
1531         <rdar://problem/9354979> REGRESSION (r83070-r83126): Conversation takes 10 seconds to load and makes mail unresponsive
1532
1533         Culled inlines were triggering some pathological line box tree groveling that isn't even necessary.
1534         Removed the ancient code (that used to be in RenderFlow), since it made no sense in the RenderBlock case
1535         (it was running for inline blocks, which was definitely not even the intent) or in the RenderInline case
1536         (the object being removed has no effect on any lines).
1537         
1538         Also tweaked culledInlineFirstLineBox and culledInlineLastLineBox to avoid bailing if the first replaced object that
1539         is encountered has a null inlineBoxWrapper().  Just a slight speed optimization to avoid an extra null check.
1540         
1541         * rendering/RenderBlock.cpp:
1542         (WebCore::RenderBlock::destroy):
1543         * rendering/RenderInline.cpp:
1544         (WebCore::RenderInline::destroy):
1545         (WebCore::RenderInline::culledInlineFirstLineBox):
1546         (WebCore::RenderInline::culledInlineLastLineBox):
1547
1548 2011-05-05  Bharathwaaj Srinivasan  <bharathwaaj.s@gmail.com>
1549
1550         Reviewed by Holger Freyther.
1551
1552         Fix build-webkit --minimal.
1553         https://bugs.webkit.org/show_bug.cgi?id=60257
1554
1555         No new tests. This is just a build fix.
1556
1557         * bindings/js/JSDOMBinding.cpp:
1558
1559 2011-05-05  Eric Carlson  <eric.carlson@apple.com>
1560
1561         Reviewed by Adam Roben.
1562
1563         The preload attribute of the video tag is not completely implemented
1564         https://bugs.webkit.org/show_bug.cgi?id=43673
1565         <rdar://problem/9369746>
1566
1567         This change implements "preload=metadata" for the AVFoundation backend.
1568         Tested manually with manual-tests/media-elements/video-preload.html.
1569
1570         * html/HTMLMediaElement.cpp:
1571         (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_havePreparedToPlay.
1572         (WebCore::HTMLMediaElement::prepareForLoad): Ditto.
1573         (WebCore::HTMLMediaElement::prepareToPlay): New, tell player to prepare to play.
1574         (WebCore::HTMLMediaElement::seek): Call prepareToPlay when preload is less than 'auto'
1575             because we need to have media data loaded to seek.
1576         (WebCore::HTMLMediaElement::updatePlayState): Call prepareToPlay.
1577         * html/HTMLMediaElement.h:
1578
1579         * manual-tests/media-elements/video-preload.html: Make changing urls work. 
1580
1581         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
1582         (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):  Remove 
1583             m_videoFrameHasDrawn and m_delayingLoad as they are no longer used.
1584         (WebCore::MediaPlayerPrivateAVFoundation::resumeLoad): Removed.
1585         (WebCore::MediaPlayerPrivateAVFoundation::load): Don't initialize m_videoFrameHasDrawn. 
1586             Move all preload logic to setPreload, call it from here.
1587         (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Move all preload logic to 
1588             setPreload, call it.
1589         (WebCore::MediaPlayerPrivateAVFoundation::duration): Don't cache duration = 0, it is
1590             unlikely to be correct and isn't worth caching. Use invalidTime() function.
1591         (WebCore::MediaPlayerPrivateAVFoundation::seeking): Use invalidTime() function.
1592         (WebCore::MediaPlayerPrivateAVFoundation::setNaturalSize): Add logging.
1593         (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Update for name change AVAssetStatus
1594             to AssetStatus. Always create a AVPlayerItem for live streams because they can't be inspected
1595             without one. Set networkState to 'idle' when the playback buffer is full because that is
1596             a signal that AVFoundation won't do any more IO. Set readyState to 'HAVE_CURRENT_DATA' 
1597             when the first frame is available.
1598         (WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Call tracksChanged so we cache
1599             width, height, hasVideo, etc.
1600         (WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): Use invalidTime() function.
1601         (WebCore::MediaPlayerPrivateAVFoundation::timeChanged): Ditto.
1602         (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Ditto.
1603         (WebCore::MediaPlayerPrivateAVFoundation::repaint): Don't set m_videoFrameHasDrawn, it is done
1604             in derived classes.
1605         (WebCore::MediaPlayerPrivateAVFoundation::setPreload): Centralize all logic about when to create
1606             AVAsset and AVPlayerItem here.
1607         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
1608
1609         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
1610         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
1611         (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize
1612             m_videoFrameHasDrawn.
1613         (WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame): New, renamed from
1614             videoLayerIsReadyToDisplay. Return true if we have a layer with frames available or
1615             if we have painted a frame to the context.
1616         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): New, create the AVAsset
1617             if necessary.
1618         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForCacheResource): Ditto.
1619         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Restructure logic.
1620         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): New, create AVPlayerItem.
1621         (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): Correct logging.
1622         (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus): Return "buffer full" when
1623             the buffer is full.
1624         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Get the duration from the
1625             AVAsset when we haven't allocated the AVPlayerItem yet so that we can return duration
1626             when we only have metadata.
1627         (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): Update for name change.
1628         (WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Set m_videoFrameHasDrawn.
1629         (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Get attributes from AVAsset
1630             when when we haven't allocated the AVPlayerItem yet so that we can report attributes
1631             when we only have metadata.
1632         (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): Guard against being called before
1633             we have allocated the AVPlayerItem.
1634
1635 2011-05-05  Ryosuke Niwa  <rniwa@webkit.org>
1636
1637         Reviewed by Eric Seidel.
1638
1639         Rename SelectionController to FrameSelection
1640         https://bugs.webkit.org/show_bug.cgi?id=60234
1641
1642         * CMakeLists.txt:
1643         * GNUmakefile.list.am:
1644         * WebCore.exp.in:
1645         * WebCore.gypi:
1646         * WebCore.pro:
1647         * WebCore.vcproj/WebCore.vcproj:
1648         * WebCore.xcodeproj/project.pbxproj:
1649         * accessibility/AccessibilityObject.cpp:
1650         * accessibility/AccessibilityRenderObject.cpp:
1651         (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
1652         * accessibility/mac/AccessibilityObjectWrapper.mm:
1653         * bindings/objc/ExceptionHandlers.h:
1654         * css/CSSStyleSelector.cpp:
1655         * dom/ContainerNode.cpp:
1656         (WebCore::ContainerNode::cloneChildNodes):
1657         * dom/Document.cpp:
1658         * dom/InputElement.cpp:
1659         * editing/DeleteButtonController.cpp:
1660         * editing/EditCommand.cpp:
1661         * editing/EditingAllInOne.cpp:
1662         * editing/EditingStyle.cpp:
1663         * editing/Editor.cpp:
1664         (WebCore::Editor::canCopy):
1665         (WebCore::Editor::canDelete):
1666         (WebCore::Editor::markMisspellingsAfterTypingToWord):
1667         (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
1668         (WebCore::Editor::changeSelectionAfterCommand):
1669         (WebCore::Editor::respondToChangedSelection):
1670         * editing/Editor.h:
1671         * editing/EditorCommand.cpp:
1672         (WebCore::executeDeleteToMark):
1673         (WebCore::executeMoveBackward):
1674         (WebCore::executeMoveBackwardAndModifySelection):
1675         (WebCore::executeMoveDown):
1676         (WebCore::executeMoveDownAndModifySelection):
1677         (WebCore::executeMoveForward):
1678         (WebCore::executeMoveForwardAndModifySelection):
1679         (WebCore::executeMoveLeft):
1680         (WebCore::executeMoveLeftAndModifySelection):
1681         (WebCore::executeMovePageDown):
1682         (WebCore::executeMovePageDownAndModifySelection):
1683         (WebCore::executeMovePageUp):
1684         (WebCore::executeMovePageUpAndModifySelection):
1685         (WebCore::executeMoveRight):
1686         (WebCore::executeMoveRightAndModifySelection):
1687         (WebCore::executeMoveToBeginningOfDocument):
1688         (WebCore::executeMoveToBeginningOfDocumentAndModifySelection):
1689         (WebCore::executeMoveToBeginningOfLine):
1690         (WebCore::executeMoveToBeginningOfLineAndModifySelection):
1691         (WebCore::executeMoveToBeginningOfParagraph):
1692         (WebCore::executeMoveToBeginningOfParagraphAndModifySelection):
1693         (WebCore::executeMoveToBeginningOfSentence):
1694         (WebCore::executeMoveToBeginningOfSentenceAndModifySelection):
1695         (WebCore::executeMoveToEndOfDocument):
1696         (WebCore::executeMoveToEndOfDocumentAndModifySelection):
1697         (WebCore::executeMoveToEndOfSentence):
1698         (WebCore::executeMoveToEndOfSentenceAndModifySelection):
1699         (WebCore::executeMoveToEndOfLine):
1700         (WebCore::executeMoveToEndOfLineAndModifySelection):
1701         (WebCore::executeMoveToEndOfParagraph):
1702         (WebCore::executeMoveToEndOfParagraphAndModifySelection):
1703         (WebCore::executeMoveParagraphBackwardAndModifySelection):
1704         (WebCore::executeMoveParagraphForwardAndModifySelection):
1705         (WebCore::executeMoveUp):
1706         (WebCore::executeMoveUpAndModifySelection):
1707         (WebCore::executeMoveWordBackward):
1708         (WebCore::executeMoveWordBackwardAndModifySelection):
1709         (WebCore::executeMoveWordForward):
1710         (WebCore::executeMoveWordForwardAndModifySelection):
1711         (WebCore::executeMoveWordLeft):
1712         (WebCore::executeMoveWordLeftAndModifySelection):
1713         (WebCore::executeMoveWordRight):
1714         (WebCore::executeMoveWordRightAndModifySelection):
1715         (WebCore::executeMoveToLeftEndOfLine):
1716         (WebCore::executeMoveToLeftEndOfLineAndModifySelection):
1717         (WebCore::executeMoveToRightEndOfLine):
1718         (WebCore::executeMoveToRightEndOfLineAndModifySelection):
1719         * editing/FrameSelection.cpp: Copied from Source/WebCore/editing/SelectionController.cpp.
1720         (WebCore::FrameSelection::FrameSelection):
1721         (WebCore::FrameSelection::moveTo):
1722         (WebCore::FrameSelection::setSelection):
1723         (WebCore::FrameSelection::nodeWillBeRemoved):
1724         (WebCore::FrameSelection::respondToNodeModification):
1725         (WebCore::FrameSelection::textWillBeReplaced):
1726         (WebCore::FrameSelection::setIsDirectional):
1727         (WebCore::FrameSelection::directionOfEnclosingBlock):
1728         (WebCore::FrameSelection::willBeModified):
1729         (WebCore::FrameSelection::positionForPlatform):
1730         (WebCore::FrameSelection::startForPlatform):
1731         (WebCore::FrameSelection::endForPlatform):
1732         (WebCore::FrameSelection::modifyExtendingRight):
1733         (WebCore::FrameSelection::modifyExtendingForward):
1734         (WebCore::FrameSelection::modifyMovingRight):
1735         (WebCore::FrameSelection::modifyMovingForward):
1736         (WebCore::FrameSelection::modifyExtendingLeft):
1737         (WebCore::FrameSelection::modifyExtendingBackward):
1738         (WebCore::FrameSelection::modifyMovingLeft):
1739         (WebCore::FrameSelection::modifyMovingBackward):
1740         (WebCore::FrameSelection::modify):
1741         (WebCore::FrameSelection::xPosForVerticalArrowNavigation):
1742         (WebCore::FrameSelection::clear):
1743         (WebCore::FrameSelection::setStart):
1744         (WebCore::FrameSelection::setEnd):
1745         (WebCore::FrameSelection::setBase):
1746         (WebCore::FrameSelection::setExtent):
1747         (WebCore::FrameSelection::setCaretRectNeedsUpdate):
1748         (WebCore::FrameSelection::updateCaretRect):
1749         (WebCore::FrameSelection::caretRenderer):
1750         (WebCore::FrameSelection::localCaretRect):
1751         (WebCore::FrameSelection::absoluteBoundsForLocalRect):
1752         (WebCore::FrameSelection::absoluteCaretBounds):
1753         (WebCore::FrameSelection::caretRepaintRect):
1754         (WebCore::FrameSelection::recomputeCaretRect):
1755         (WebCore::FrameSelection::shouldRepaintCaret):
1756         (WebCore::FrameSelection::invalidateCaretRect):
1757         (WebCore::FrameSelection::paintCaret):
1758         (WebCore::FrameSelection::debugRenderer):
1759         (WebCore::FrameSelection::contains):
1760         (WebCore::FrameSelection::selectFrameElementInParentIfFullySelected):
1761         (WebCore::FrameSelection::selectAll):
1762         (WebCore::FrameSelection::setSelectedRange):
1763         (WebCore::FrameSelection::isInPasswordField):
1764         (WebCore::FrameSelection::caretRendersInsideNode):
1765         (WebCore::FrameSelection::focusedOrActiveStateChanged):
1766         (WebCore::FrameSelection::pageActivationChanged):
1767         (WebCore::FrameSelection::updateSecureKeyboardEntryIfActive):
1768         (WebCore::FrameSelection::setUseSecureKeyboardEntry):
1769         (WebCore::FrameSelection::setFocused):
1770         (WebCore::FrameSelection::isFocusedAndActive):
1771         (WebCore::FrameSelection::updateAppearance):
1772         (WebCore::FrameSelection::setCaretVisible):
1773         (WebCore::FrameSelection::clearCaretRectIfNeeded):
1774         (WebCore::FrameSelection::caretBlinkTimerFired):
1775         (WebCore::FrameSelection::notifyRendererOfSelectionChange):
1776         (WebCore::FrameSelection::setFocusedNodeIfNeeded):
1777         (WebCore::FrameSelection::paintDragCaret):
1778         (WebCore::FrameSelection::copyTypingStyle):
1779         (WebCore::FrameSelection::shouldDeleteSelection):
1780         (WebCore::FrameSelection::bounds):
1781         (WebCore::FrameSelection::getClippedVisibleTextRectangles):
1782         (WebCore::FrameSelection::currentForm):
1783         (WebCore::FrameSelection::revealSelection):
1784         (WebCore::FrameSelection::setSelectionFromNone):
1785         (WebCore::FrameSelection::shouldChangeSelection):
1786         (WebCore::FrameSelection::formatForDebugger):
1787         (WebCore::FrameSelection::showTreeForThis):
1788         (showTree):
1789         * editing/FrameSelection.h: Copied from Source/WebCore/editing/SelectionController.h.
1790         (WebCore::FrameSelection::typingStyle):
1791         (WebCore::FrameSelection::clearTypingStyle):
1792         (WebCore::FrameSelection::setTypingStyle):
1793         (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
1794         * editing/ModifySelectionListLevel.cpp:
1795         * editing/RemoveFormatCommand.cpp:
1796         * editing/ReplaceSelectionCommand.cpp:
1797         * editing/SelectionController.cpp: Removed.
1798         * editing/SelectionController.h: Removed.
1799         * editing/SetSelectionCommand.cpp:
1800         (WebCore::SetSelectionCommand::SetSelectionCommand):
1801         (WebCore::SetSelectionCommand::doApply):
1802         (WebCore::SetSelectionCommand::doUnapply):
1803         * editing/SetSelectionCommand.h:
1804         (WebCore::SetSelectionCommand::create):
1805         * editing/SpellingCorrectionCommand.cpp:
1806         (WebCore::SpellingCorrectionCommand::doApply):
1807         * editing/SpellingCorrectionController.cpp:
1808         (WebCore::SpellingCorrectionController::respondToUnappliedSpellCorrection):
1809         * editing/TypingCommand.cpp:
1810         (WebCore::TypingCommand::deleteKeyPressed):
1811         (WebCore::TypingCommand::forwardDeleteKeyPressed):
1812         * editing/chromium/FrameSelectionChromium.cpp: Copied from Source/WebCore/editing/chromium/SelectionControllerChromium.cpp.
1813         (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
1814         * editing/chromium/SelectionControllerChromium.cpp: Removed.
1815         * editing/gtk/FrameSelectionGtk.cpp: Copied from Source/WebCore/editing/gtk/SelectionControllerGtk.cpp.
1816         (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
1817         * editing/gtk/SelectionControllerGtk.cpp: Removed.
1818         * editing/mac/EditorMac.mm:
1819         (WebCore::Editor::canCopyExcludingStandaloneImages):
1820         * editing/mac/FrameSelectionMac.mm: Copied from Source/WebCore/editing/mac/SelectionControllerMac.mm.
1821         (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
1822         * editing/mac/SelectionControllerMac.mm: Removed.
1823         * editing/qt/EditorQt.cpp:
1824         * loader/archive/cf/LegacyWebArchive.cpp:
1825         * page/ContextMenuController.cpp:
1826         (WebCore::ContextMenuController::populate):
1827         * page/DOMSelection.cpp:
1828         (WebCore::DOMSelection::type):
1829         (WebCore::DOMSelection::modify):
1830         (WebCore::DOMSelection::addRange):
1831         (WebCore::DOMSelection::deleteFromDocument):
1832         (WebCore::DOMSelection::containsNode):
1833         * page/DragController.cpp:
1834         (WebCore::DragController::dragIsMove):
1835         * page/DragController.h:
1836         * page/EventHandler.cpp:
1837         (WebCore::setSelectionIfNeeded):
1838         (WebCore::setNonDirectionalSelectionIfNeeded):
1839         (WebCore::EventHandler::sendContextMenuEventForKey):
1840         (WebCore::EventHandler::handleKeyboardSelectionMovement):
1841         * page/EventHandler.h:
1842         * page/FocusController.cpp:
1843         (WebCore::clearSelectionIfNeeded):
1844         * page/Frame.cpp:
1845         (WebCore::Frame::Frame):
1846         * page/Frame.h:
1847         (WebCore::Frame::selection):
1848         * page/Page.cpp:
1849         (WebCore::Page::Page):
1850         * page/Page.h:
1851         (WebCore::Page::dragCaretController):
1852         * page/chromium/DragControllerChromium.cpp:
1853         * page/chromium/EventHandlerChromium.cpp:
1854         * page/win/DragControllerWin.cpp:
1855         * page/win/EventHandlerWin.cpp:
1856         * rendering/HitTestResult.cpp:
1857         * rendering/RenderBlock.cpp:
1858         (WebCore::RenderBlock::destroy):
1859         (WebCore::RenderBlock::paintCaret):
1860         * rendering/RenderImage.cpp:
1861         * rendering/RenderInline.cpp:
1862         (WebCore::RenderInline::destroy):
1863         * rendering/RenderLayer.cpp:
1864         * rendering/RenderListBox.cpp:
1865         * rendering/RenderObjectChildList.cpp:
1866         (WebCore::RenderObjectChildList::removeChildNode):
1867         * rendering/RenderTextControl.cpp:
1868         * rendering/RenderTextControlSingleLine.cpp:
1869         * rendering/RenderTheme.cpp:
1870         * rendering/RenderTreeAsText.cpp:
1871         * svg/SVGSVGElement.cpp:
1872         * svg/SVGTextContentElement.cpp:
1873         (WebCore::SVGTextContentElement::selectSubString):
1874
1875 2011-05-05  Brent Fulgham  <bfulgham@webkit.org>
1876
1877         [WinCairo] unreviewed build correction.
1878
1879         * platform/network/curl/ResourceRequest.h:
1880         Stub out the new pipelined http logic for cURL.
1881
1882 2011-05-05  Pavel Feldman  <pfeldman@chromium.org>
1883
1884         Reviewed by Yury Semikhatsky.
1885
1886         Web Inspector: searching for node does not result in bringToFront call.
1887         https://bugs.webkit.org/show_bug.cgi?id=60222
1888
1889         * inspector/front-end/ElementsPanel.js:
1890         (WebInspector.ElementsPanel.prototype.updateFocusedNode):
1891
1892 2011-05-05  Andreas Kling  <andreas.kling@nokia.com>
1893
1894         Reviewed by Simon Hausmann.
1895
1896         [Qt] Implement the fast font path for Qt.
1897         https://bugs.webkit.org/show_bug.cgi?id=51106
1898
1899         Use the new QRawFont and QGlyphs APIs in Qt 4.8 to implement the fast paths for
1900         rendering and measurement of simple text.
1901
1902         Since this is still unreleased API, it's guarded by HAVE(QRAWFONT) until the new
1903         classes are fully integrated into the Qt 4.8 release branch.
1904
1905         * WebCore.pro: Add HAVE_QRAWFONT define (for Qt >= 4.8) and new files to build.
1906
1907         * platform/graphics/Font.cpp:
1908         (WebCore::Font::drawText): Disable fast font path for stroked text, and when
1909         painting text with a shadow. (Qt-only)
1910         (WebCore::Font::codePath): Try to use fast font path in more cases.
1911
1912         * platform/graphics/qt/FontCacheQt.cpp:
1913         (WebCore::rawFontForCharacters): Helper function, returns a suitable QRawFont
1914         to use for rendering a given string. Goes through QTextLayout to find the best
1915         font based on the original QFont query.
1916         (WebCore::FontCache::getFontDataForCharacters): Implemented using helper above.
1917
1918         * platform/graphics/qt/FontPlatformData.h:
1919         (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
1920         (WebCore::FontPlatformData::FontPlatformData):
1921         (WebCore::FontPlatformData::rawFont):
1922         * platform/graphics/qt/FontPlatformDataQt.cpp:
1923         (WebCore::FontPlatformData::FontPlatformData): Add a QRawFont member to FontPlatformData.
1924
1925         * platform/graphics/qt/FontQt.cpp:
1926         (WebCore::fillPenForContext):
1927         (WebCore::strokePenForContext):
1928         (WebCore::drawTextCommon): Factored QPen creation out of drawTextCommon
1929         to share code between complex and simple font rendering paths.
1930         (WebCore::Font::drawGlyphs): Implemented using QPainter::drawGlyphs().
1931
1932         * platform/graphics/qt/GlyphPageTreeNodeQt.cpp:
1933         (WebCore::GlyphPage::fill): Implemented using QRawFont::glyphIndexesForString().
1934
1935         * platform/graphics/qt/SimpleFontDataQt.cpp:
1936         (WebCore::SimpleFontData::determinePitch): Return false when using QRawFont since we
1937         have no way of knowing the pitch.
1938         (WebCore::SimpleFontData::containsCharacters): Implemented using QRawFont::supportsCharacter().
1939         (WebCore::SimpleFontData::platformWidthForGlyph): Implemented using QRawFont::advancesForGlyphIndexes().
1940         (WebCore::SimpleFontData::scaledFontData): Added, based on other ports.
1941         (WebCore::SimpleFontData::smallCapsFontData): Ditto.
1942         (WebCore::SimpleFontData::emphasisMarkFontData): Ditto.
1943         (WebCore::SimpleFontData::platformBoundsForGlyph): Stub.
1944         (WebCore::SimpleFontData::platformInit): Use QRawFont APIs to retrieve font metrics.
1945         (WebCore::SimpleFontData::platformCharWidthInit): Ditto.
1946
1947 2011-05-05  Alexis Menard  <alexis.menard@openbossa.org>
1948
1949         Reviewed by Andreas Kling.
1950
1951         [Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
1952         https://bugs.webkit.org/show_bug.cgi?id=60224
1953
1954         We should use nullptr rather than 0. nullptr will be added in the new C++ standard
1955         but WebKit already has a nullptr class if there is no c++0x support.
1956
1957         * platform/qt/RenderThemeQt.cpp:
1958         (WebCore::RenderThemeQt::adjustProgressBarStyle):
1959         (WebCore::RenderThemeQt::adjustSliderTrackStyle):
1960         (WebCore::RenderThemeQt::adjustSliderThumbStyle):
1961
1962 2011-05-05  Ilya Tikhonovsky  <loislo@chromium.org>
1963
1964         Reviewed by Yury Semikhatsky.
1965
1966         Web Inspector: rename BrowserDebugger to DOMDebugger.
1967
1968         https://bugs.webkit.org/show_bug.cgi?id=60256
1969         InspectorBrowserDebuggerAgent => InspectorDOMDebuggerAgent
1970         browserDebugger => domDebugger
1971
1972         * CMakeLists.txt:
1973         * GNUmakefile.list.am:
1974         * WebCore.gypi:
1975         * WebCore.pro:
1976         * WebCore.vcproj/WebCore.vcproj:
1977         * WebCore.xcodeproj/project.pbxproj:
1978         * inspector/CodeGeneratorInspector.pm:
1979         * inspector/InspectorAgent.cpp:
1980         (WebCore::InspectorAgent::InspectorAgent):
1981         (WebCore::InspectorAgent::inspectedPageDestroyed):
1982         (WebCore::InspectorAgent::disconnectFrontend):
1983         * inspector/InspectorAgent.h:
1984         (WebCore::InspectorAgent::DOMDebuggerAgent):
1985         * inspector/InspectorController.cpp:
1986         (WebCore::InspectorController::connectFrontend):
1987         * inspector/InspectorDOMDebuggerAgent.cpp: Renamed from Source/WebCore/inspector/InspectorBrowserDebuggerAgent.cpp.
1988         (WebCore::InspectorDOMDebuggerAgent::create):
1989         (WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
1990         (WebCore::InspectorDOMDebuggerAgent::~InspectorDOMDebuggerAgent):
1991         (WebCore::InspectorDOMDebuggerAgent::debuggerWasEnabled):
1992         (WebCore::InspectorDOMDebuggerAgent::debuggerWasDisabled):
1993         (WebCore::InspectorDOMDebuggerAgent::disable):
1994         (WebCore::InspectorDOMDebuggerAgent::clearFrontend):
1995         (WebCore::InspectorDOMDebuggerAgent::discardBindings):
1996         (WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint):
1997         (WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint):
1998         (WebCore::InspectorDOMDebuggerAgent::didInsertDOMNode):
1999         (WebCore::InspectorDOMDebuggerAgent::didRemoveDOMNode):
2000         (WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):
2001         (WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):
2002         (WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
2003         (WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
2004         (WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
2005         (WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):
2006         (WebCore::InspectorDOMDebuggerAgent::hasBreakpoint):
2007         (WebCore::InspectorDOMDebuggerAgent::updateSubtreeBreakpoints):
2008         (WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
2009         (WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint):
2010         (WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint):
2011         (WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
2012         (WebCore::InspectorDOMDebuggerAgent::clear):
2013         * inspector/InspectorDOMDebuggerAgent.h: Renamed from Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h.
2014         * inspector/InspectorInstrumentation.cpp:
2015         (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
2016         (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
2017         (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
2018         (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
2019         (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
2020         (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
2021         (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
2022         * inspector/InstrumentingAgents.h:
2023         (WebCore::InstrumentingAgents::InstrumentingAgents):
2024         (WebCore::InstrumentingAgents::inspectorDOMDebuggerAgent):
2025         (WebCore::InstrumentingAgents::setInspectorDOMDebuggerAgent):
2026         * inspector/WorkerInspectorController.cpp:
2027         (WebCore::WorkerInspectorController::connectFrontend):
2028
2029 2011-05-04  Yury Semikhatsky  <yurys@chromium.org>
2030
2031         Reviewed by Pavel Feldman.
2032
2033         Web Inspector: show only Console and Scripts panels in worker inspector front-end
2034         https://bugs.webkit.org/show_bug.cgi?id=60159
2035
2036         * inspector/front-end/WorkerManager.js:
2037         (WebInspector.WorkerManager.isWorkerFrontend):
2038         * inspector/front-end/inspector.js: show only Scripts and Console panels in the worker inspector front-end.
2039
2040 2011-05-03  Hans Wennborg  <hans@chromium.org>
2041
2042         Reviewed by Steve Block.
2043
2044         IndexedDB: Unit tests for LevelDB key coding functions
2045         https://bugs.webkit.org/show_bug.cgi?id=59692
2046
2047         Fix some embarrassing bugs uncovered by unit tests.
2048
2049         No new functionality, but this is now covered by unit tests in the Chromium WebKit port.
2050
2051         * storage/IDBLevelDBCoding.cpp:
2052         (WebCore::IDBLevelDBCoding::decodeInt):
2053         (WebCore::IDBLevelDBCoding::decodeVarInt):
2054
2055 2011-05-05  Young Han Lee  <joybro@company100.net>
2056
2057         Reviewed by Csaba Osztrogonác.
2058
2059         [Texmap][Qt] Enable strict OwnPtr for Qt with texmap enabled.
2060         https://bugs.webkit.org/show_bug.cgi?id=60251
2061
2062         No new tests. Build fix.
2063
2064         * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
2065         (WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
2066
2067 2011-05-04  Jay Civelli  <jcivelli@chromium.org>
2068
2069         Reviewed by Adam Barth.
2070
2071         Adding a utility class to read a SharedBuffer line by line.
2072         https://bugs.webkit.org/show_bug.cgi?id=59946
2073
2074         * CMakeLists.txt:
2075         * GNUmakefile.list.am:
2076         * WebCore.gypi:
2077         * WebCore.pro:
2078         * WebCore.vcproj/WebCore.vcproj:
2079         * WebCore.xcodeproj/project.pbxproj:
2080         * platform/SharedBufferCRLFLineReader.cpp: Added.
2081         * platform/SharedBufferCRLFLineReader.h: Added.
2082
2083 2011-05-04  Sheriff Bot  <webkit.review.bot@gmail.com>
2084
2085         Unreviewed, rolling out r85788.
2086         http://trac.webkit.org/changeset/85788
2087         https://bugs.webkit.org/show_bug.cgi?id=60250
2088
2089         svg/text/text-block-child-crash.xhtml asserts (Requested by
2090         Ossy on #webkit).
2091
2092         * css/CSSStyleSelector.cpp:
2093         (WebCore::CSSStyleSelector::applyProperty):
2094
2095 2011-05-04  Ryosuke Niwa  <rniwa@webkit.org>
2096
2097         Reviewed by Eric Seidel.
2098
2099         Make more member functions in EventHandler private
2100         https://bugs.webkit.org/show_bug.cgi?id=60200
2101
2102         Reduced the number of public member functions in EventHandler.
2103
2104         * WebCore.exp.in:
2105         * page/EventHandler.cpp:
2106         (WebCore::EventHandler::handleAutoscroll):
2107         (WebCore::EventHandler::autoscrollTimerFired):
2108         (WebCore::EventHandler::stopAutoscrollTimer):
2109         (WebCore::EventHandler::handleMousePressEvent):
2110         (WebCore::EventHandler::handleMouseMoveEvent):
2111         (WebCore::EventHandler::keyEvent):
2112         (WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult):
2113         * page/EventHandler.h:
2114         (WebCore::EventHandler::mouseDownMayStartSelect):
2115
2116 2011-05-04  James Robinson  <jamesr@chromium.org>
2117
2118         Reviewed by Kenneth Russell.
2119
2120         [chromium] REGRESSION(85136): Composited content vanishes when transform-style changes from preserve-3d to flat
2121         https://bugs.webkit.org/show_bug.cgi?id=60202
2122
2123         In r85136 I accidentally transposed two lines in GraphicsLayerChromium when adding a null check.  This switches
2124         the order back and adds a regression test.
2125
2126         Test: compositing/repaint/transform-style-change.html
2127
2128         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
2129         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
2130
2131 2011-05-04  Cris Neckar  <cdn@chromium.org>
2132
2133         Reviewed by Adam Barth.
2134
2135         Expose WebView directly through ChromeClient.
2136         https://bugs.webkit.org/show_bug.cgi?id=49902
2137
2138         Test: fast/media/media-svg-crash.html
2139
2140         * loader/EmptyClients.h:
2141         (WebCore::EmptyChromeClient::webView):
2142         * page/ChromeClient.h:
2143         * page/brew/ChromeClientBrew.h:
2144         (WebCore::ChromeClientBrew::webView):
2145
2146 2011-05-04  Joseph Pecoraro  <joepeck@webkit.org>
2147
2148         Reviewed by Darin Adler.
2149
2150         Unable to Paste After Deleting Text from Input due to -webkit-user-select
2151         https://bugs.webkit.org/show_bug.cgi?id=60219
2152
2153         When deleting all the text inside the input a placeholder <br>
2154         element was inserted for the selection point. However, when
2155         pasting, the test run computes the -webkit-user-select for the
2156         <br> element, instead of what would be the text inside the
2157         <input> and incorrectly disallows selection and prevented
2158         the paste.
2159
2160         Test: editing/pasteboard/paste-placeholder-input.html
2161
2162         * editing/ReplaceSelectionCommand.cpp:
2163         (WebCore::ReplacementFragment::insertFragmentForTestRendering): skip
2164         <br> elements above us as those are likely placeholder elements.
2165
2166 2011-05-04  Fridrich Strba  <fridrich.strba@bluewin.ch>
2167
2168         Reviewed by Martin Robinson.
2169
2170         Windows build of WebKit GTK needs to be able to find SystemInfo.h
2171         https://bugs.webkit.org/show_bug.cgi?id=60221
2172
2173         * GNUmakefile.am: add Source/WebCore/platform/win to the paths searched
2174         for headers, since Source/WebCore/platform/win/SystemInfo.h
2175         header is needed by Source/WebKit/gtk/webkit/webkitwebsettings.cpp
2176         on Windows.
2177
2178 2011-05-04  Vangelis Kokkevis  <vangelis@chromium.org>
2179
2180         Reviewed by Kenneth Russell.
2181
2182         [chromium] Improve sorting of layers in hierarchies that preserve-3d
2183         by testing for overlapping regions between layer pairs and doing a
2184         topological sort to determine the right order.
2185         https://bugs.webkit.org/show_bug.cgi?id=59255
2186
2187         Test: platform/chromium/compositing/perpendicular-layer-sorting.html
2188
2189         * WebCore.gypi:
2190         * platform/graphics/chromium/LayerRendererChromium.cpp:
2191         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
2192         * platform/graphics/chromium/LayerRendererChromium.h:
2193         * platform/graphics/chromium/cc/CCLayerImpl.h:
2194         (WebCore::CCLayerImpl::clearRenderSurface):
2195         * platform/graphics/chromium/cc/CCLayerSorter.cpp: Added.
2196         (WebCore::perpProduct):
2197         (WebCore::innerProduct):
2198         (WebCore::pointInColinearEdge):
2199         (WebCore::edgeEdgeTest):
2200         (WebCore::CCLayerSorter::LayerIntersector::LayerIntersector):
2201         (WebCore::CCLayerSorter::LayerIntersector::go):
2202         (WebCore::CCLayerSorter::LayerIntersector::edgeTriangleTest):
2203         (WebCore::CCLayerSorter::LayerIntersector::triangleTriangleTest):
2204         (WebCore::CCLayerSorter::LayerIntersector::checkZDiff):
2205         (WebCore::CCLayerSorter::LayerIntersector::layerZFromProjectedPoint):
2206         (WebCore::CCLayerSorter::CCLayerSorter):
2207         (WebCore::CCLayerSorter::checkOverlap):
2208         (WebCore::CCLayerSorter::createGraphNodes):
2209         (WebCore::CCLayerSorter::createGraphEdges):
2210         (WebCore::CCLayerSorter::removeEdgeFromList):
2211         (WebCore::CCLayerSorter::sort):
2212         * platform/graphics/chromium/cc/CCLayerSorter.h: Added.
2213         (WebCore::CCLayerSorter::GraphNode::GraphNode):
2214         (WebCore::CCLayerSorter::GraphEdge::GraphEdge):
2215
2216 2011-05-03  Jer Noble  <jer.noble@apple.com>
2217
2218         Reviewed by Antti Koivisto.
2219
2220         Safari: Video at apple.com cannot play at full screen mode with layout distortion
2221         https://bugs.webkit.org/show_bug.cgi?id=60140
2222
2223         Because a fullscreen element may be in a stacking context with a lower z-index than
2224         a sibling stacking context, those higher contexts would sometimes "pop" through the 
2225         full screen renderer. To facilitate eliminating all the stacking contexts aside from
2226         the full screen renderer, added a new pseudo-class specific to video or audio full
2227         screen elements. Then, added a new UA rule which resets the z-index and opacities of 
2228         all elements under said pseudo-class to auto and 1 respectively. To facilitate quick
2229         identity checking of HTMLMediaElements, added isMediaElement() virtual function to 
2230         Element and HTMLMediaElement. 
2231
2232         Test: fullscreen/full-screen-stacking-context.html
2233
2234         * css/CSSSelector.cpp:
2235         (WebCore::CSSSelector::pseudoId): Support PseudoFullScreenMediaDocument.
2236         (WebCore::nameToPseudoTypeMap): Support fullScreenMediaDocument.
2237         (WebCore::CSSSelector::extractPseudoType): Support PseudoFullScreenMediaDocument.
2238         * css/CSSSelector.h: Add PseudoFullScreenMediaDocument.
2239         * css/CSSStyleSelector.cpp:
2240         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Support PseudoFullScreenMediaDocument.
2241         * css/fullscreen.css:
2242         (:root:-webkit-full-screen-document:not(:-webkit-full-screen)): Corrected these names, 
2243             which were missing the -webkit prefix.
2244         (:root:-webkit-full-screen-media-document *:not(-webkit-full-screen)): Added.
2245         * dom/Element.h:
2246         (WebCore::Element::isMediaElement): Added, returns false.
2247         * html/HTMLMediaElement.h:
2248         (WebCore::HTMLMediaElement::isMediaElement): Added, returns true.
2249         * rendering/style/RenderStyleConstants.h: Added FULL_SCREEN_MEDIA_DOCUMENT.
2250
2251 2011-05-04  Levi Weintraub  <leviw@chromium.org>
2252
2253         Reviewed by Eric Seidel.
2254
2255         Split findNextLineBreak into a LineBreaker class
2256         https://bugs.webkit.org/show_bug.cgi?id=60209
2257
2258         Breaking findNextLineBreak into a new class inside RenderBlock. Currently it's tracking
2259         nearly no state, but subsequent patches will move some of the local variables used throughout
2260         the nextLineBreak function into member variables to simplify breaking off helper functions from
2261         the bloated function.
2262
2263         No new tests since this is just moving code around.
2264
2265         * WebCore.xcodeproj/project.pbxproj:
2266         * rendering/RenderBlock.h:
2267         (WebCore::RenderBlock::LineBreaker::LineBreaker):
2268         (WebCore::RenderBlock::LineBreaker::lineWasHyphenated): Accessor.
2269         (WebCore::RenderBlock::LineBreaker::positionedObjects): Ditto.
2270         (WebCore::RenderBlock::LineBreaker::clear): Ditto.
2271         * rendering/RenderBlockLineLayout.cpp:
2272         (WebCore::RenderBlock::layoutRunsAndFloats):
2273         (WebCore::RenderBlock::LineBreaker::skipTrailingWhitespace):
2274         (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
2275         (WebCore::RenderBlock::LineBreaker::reset):
2276         (WebCore::RenderBlock::LineBreaker::nextLineBreak):
2277
2278 2011-05-04  Fridrich Strba  <fridrich.strba@bluewin.ch>
2279
2280         Reviewed by Adam Barth.
2281
2282         Add COMPILER(MINGW) to the compilers using the Microsoft C Runtime's vsnprintf.
2283         The vsnprintf is part of Microsoft C runtime used also by MinGW (GCC) toolchain.
2284         https://bugs.webkit.org/show_bug.cgi?id=58579
2285
2286         * dom/XMLDocumentParserLibxml2.cpp:
2287         (WebCore::XMLDocumentParser::error):
2288
2289 2011-05-04  Alexis Menard  <alexis.menard@openbossa.org>
2290
2291         Unreviewed warning fix.
2292
2293         The variable is just used in the ASSERT macro. Let's use ASSERT_UNUSED to avoid
2294         a warning in Release build.
2295
2296         * dom/Node.cpp:
2297         (WebCore::Node::removeEventListener):
2298         * platform/DateComponents.cpp:
2299         (WebCore::DateComponents::parseTime):
2300         * rendering/RenderLayer.cpp:
2301         (WebCore::RenderLayer::convertToLayerCoords):
2302         * storage/StorageMap.cpp:
2303         (WebCore::StorageMap::importItem):
2304         * svg/SVGUseElement.cpp:
2305         (WebCore::SVGUseElement::buildShadowTree):
2306         (WebCore::SVGUseElement::expandUseElementsInShadowTree):
2307
2308 2011-05-04  Alexis Menard  <alexis.menard@openbossa.org>
2309
2310         Unreviewed warning fix.
2311
2312         The variable is just used in the ASSERT macro. Let's use ASSERT_UNUSED to avoid
2313         a warning in Release build.
2314
2315         * accessibility/AccessibilityRenderObject.cpp:
2316         (WebCore::lastChildConsideringContinuation):
2317
2318 2011-05-04  Dimitri Glazkov  <dglazkov@chromium.org>
2319
2320         Sort xcodeproj files.
2321
2322         The WebCore.xcodeproj got out of sorts again.
2323
2324         * WebCore.xcodeproj/project.pbxproj: Ran sort-XCode-project-file.
2325
2326 2011-05-04  Alexis Menard  <alexis.menard@openbossa.org>
2327
2328         Reviewed by Adam Barth.
2329
2330         Warning fix.
2331
2332         * bindings/js/DOMObjectHashTableMap.h:
2333         (WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
2334
2335 2011-05-04  Rob Buis  <rbuis@rim.com>
2336
2337         Reviewed by Darin Adler.
2338
2339         NULL deref when SVG elements have table styles 
2340         https://bugs.webkit.org/show_bug.cgi?id=45561
2341
2342         Restrict computed CSS values for SVG display property to block, inline or none.
2343
2344         Tests: svg/custom/display-table-caption-foreignObject.svg
2345                svg/custom/display-table-caption-inherit-foreignObject.xhtml
2346                svg/custom/display-table-caption-inherit-text.xhtml
2347                svg/custom/display-table-caption-text.svg
2348
2349         * css/CSSStyleSelector.cpp:
2350         (WebCore::CSSStyleSelector::applyProperty):
2351
2352 2011-05-04  Tao Bai  <michaelbai@chromium.org>
2353
2354         Reviewed by David Kilzer.
2355
2356         Populate touch-icon url to FrameLoaderClient
2357         https://bugs.webkit.org/show_bug.cgi?id=59143
2358         
2359         Parsed and populated apple-touch-icon url to FrameLoaderClient.
2360         Changed favicon to be a type of icon.
2361
2362         * CMakeLists.txt:
2363         * Configurations/FeatureDefines.xcconfig:
2364         * GNUmakefile.am:
2365         * GNUmakefile.list.am:
2366         * WebCore.gypi:
2367         * WebCore.vcproj/WebCore.vcproj:
2368         * WebCore.xcodeproj/project.pbxproj:
2369         * dom/Document.cpp:
2370         (WebCore::Document::iconURL):
2371         (WebCore::Document::setIconURL):
2372         * dom/Document.h:
2373         * dom/IconURL.cpp: Added.
2374         (WebCore::toIconIndex):
2375         * dom/IconURL.h: Added.
2376         (WebCore::IconURL::IconURL):
2377         * features.pri:
2378         * html/HTMLLinkElement.cpp:
2379         (WebCore::HTMLLinkElement::tokenizeRelAttribute):
2380         (WebCore::HTMLLinkElement::process):
2381         (WebCore::HTMLLinkElement::addSubresourceAttributeURLs):
2382         * html/HTMLLinkElement.h:
2383         (WebCore::HTMLLinkElement::RelAttribute::RelAttribute):
2384         (WebCore::HTMLLinkElement::isEnabledViaScript):
2385         * html/parser/HTMLPreloadScanner.cpp:
2386         (WebCore::HTMLNames::PreloadTask::relAttributeIsStyleSheet):
2387         * loader/DocumentLoader.cpp:
2388         (WebCore::DocumentLoader::iconURL):
2389         (WebCore::DocumentLoader::setIconURL):
2390         * loader/DocumentLoader.h:
2391         * loader/EmptyClients.h:
2392         (WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
2393         * loader/FrameLoader.cpp:
2394         (WebCore::FrameLoader::iconURL):
2395         (WebCore::FrameLoader::iconURLs):
2396         (WebCore::FrameLoader::fillIconURL):
2397         (WebCore::FrameLoader::getDefaultIconURL):
2398         (WebCore::FrameLoader::setIconURL):
2399         (WebCore::FrameLoader::didChangeIcons):
2400         * loader/FrameLoader.h:
2401         * loader/FrameLoaderClient.h:
2402
2403 2011-05-04  Chris Marrin  <cmarrin@apple.com>
2404
2405         Reviewed by Simon Fraser.
2406
2407         Crash in PlatformCALayer ::replaceSublayer when layer has not superlayer
2408         https://bugs.webkit.org/show_bug.cgi?id=60191
2409
2410         Skip replaceSublayer when there is no superlayer rather than asserting.
2411         This is probably not a problem and happens when restructuring the layer
2412         tree. Avoiding this crash will allow us to get more testing.
2413
2414         * platform/graphics/ca/GraphicsLayerCA.cpp:
2415         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
2416
2417 2011-05-04  Martin Robinson  <mrobinson@igalia.com>
2418
2419         Reviewed by Gustavo Noronha Silva.
2420
2421         Fix the GTK+ 2.x build for Windows. Instead of making getStockIcon a RenderTheme
2422         method, just use extern declarations to avoid having to declare it in the header.
2423         This will prevent having to include glib.h in RenderThemeGtk.h, which is included
2424         in many C++ files.
2425
2426         No new tests. This is just a build fix.
2427
2428         * platform/gtk/RenderThemeGtk.cpp: Update getStockIcon calls to say getStockIconForWidgetType.
2429         (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration):
2430         (WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
2431         (WebCore::RenderThemeGtk::paintCapsLockIndicator):
2432         (WebCore::RenderThemeGtk::paintMediaButton):
2433         * platform/gtk/RenderThemeGtk.h: Removed getStockIcon declaration. Make gtkContainer() and
2434         gtkEntry() public because they are now accessed externally from getStockIcon().
2435         * platform/gtk/RenderThemeGtk2.cpp: Update getStockIcon calls.
2436         (WebCore::getStockIconForWidgetType):
2437         * platform/gtk/RenderThemeGtk3.cpp: Ditto.
2438         (WebCore::getStockIconForWidgetType):
2439
2440 2011-05-04  Mark Pilgrim  <pilgrim@chromium.org>
2441
2442         Reviewed by Tony Chang.
2443
2444         IndexedDB open (database) should fail if name is null
2445         https://bugs.webkit.org/show_bug.cgi?id=60022
2446
2447         Test: storage/indexeddb/mozilla/open-database-null-name.html
2448
2449         Combination problem: Bug in IDL didn't pass null values to .cpp layer,
2450         then .cpp layer didn't check for null value anyway.
2451
2452         * storage/IDBFactory.cpp:
2453         (WebCore::IDBFactory::open): check for null name
2454         * storage/IDBFactory.idl: pass null name as null
2455
2456 2011-05-04  Jer Noble  <jer.noble@apple.com>
2457
2458         Reviewed by Darin Adler.
2459
2460         Entering full screen fails >= second time on Vimeo.com.
2461         https://bugs.webkit.org/show_bug.cgi?id=60143
2462
2463         Force the RenderFullScreen's layer backing to be recreated when setAnimating() is called.
2464         Previously, the RenderLayerCompositor would fail to reparent the RenderFullScreen's layer
2465         at the end of an animation, if it determined that the RenderFullScreen would still require
2466         a layer even when not animating.
2467
2468         * rendering/RenderFullScreen.cpp:
2469         (RenderFullScreen::setAnimating): Clear the renderer's layer.
2470
2471 2011-05-04  Simon Fraser  <simon.fraser@apple.com>
2472
2473         Reviewed by Darin Adler.
2474
2475         Avoid allocating a new image buffer in ~CanvasRenderingContext2D()
2476         https://bugs.webkit.org/show_bug.cgi?id=59849
2477
2478         When attempting to unwind the graphics state stack in the
2479         CanvasRenderingContext2D destructor, don't allow HTMLCanvasElement
2480         to create a new ImageBuffer.
2481
2482         * html/HTMLCanvasElement.cpp:
2483         (WebCore::HTMLCanvasElement::existingDrawingContext):
2484         * html/HTMLCanvasElement.h:
2485         * html/canvas/CanvasRenderingContext2D.cpp:
2486         (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
2487
2488 2011-05-04  Andrey Kosyakov  <caseq@chromium.org>
2489
2490         Reviewed by Yury Semikhatsky.
2491
2492         Web Inspector: expose shadow DOM in the Elements panel
2493         https://bugs.webkit.org/show_bug.cgi?id=60160
2494
2495         Test: inspector/elements/shadow-dom.html
2496
2497         * dom/Element.cpp:
2498         (WebCore::Element::ensureShadowRoot):
2499         (WebCore::Element::removeShadowRoot):
2500         * inspector/Inspector.json:
2501         * inspector/InspectorDOMAgent.cpp:
2502         (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
2503         (WebCore::InspectorDOMAgent::buildObjectForNode):
2504         (WebCore::InspectorDOMAgent::didInsertDOMNode):
2505         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
2506         (WebCore::InspectorDOMAgent::isContainerNode):
2507         * inspector/InspectorDOMAgent.h:
2508         * inspector/front-end/DOMAgent.js:
2509         (WebInspector.DOMNode):
2510         (WebInspector.DOMNode.prototype.inShadowTree):
2511         (WebInspector.DOMNode.prototype._setShadowRootPayload):
2512         (WebInspector.DOMNode.prototype._renumber):
2513         (WebInspector.DOMAgent.prototype._bindNodes):
2514         (WebInspector.DOMAgent.prototype.querySelectorAll):
2515         (WebInspector.DOMAgent.prototype._shadowRootUpdated):
2516         (WebInspector.DOMDispatcher.prototype.searchResults):
2517         (WebInspector.DOMDispatcher.prototype.shadowRootUpdated):
2518         * inspector/front-end/ElementsPanel.js:
2519         (WebInspector.ElementsPanel):
2520         (WebInspector.ElementsPanel.prototype._nodeUpdated):
2521         (WebInspector.ElementsPanel.prototype._attributesUpdated):
2522         (WebInspector.ElementsPanel.prototype._nodeRemoved):
2523         (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
2524         (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
2525         * inspector/front-end/ElementsTreeOutline.js:
2526         (WebInspector.ElementsTreeElement):
2527         (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
2528         (WebInspector.ElementsTreeElement.prototype._updateChildren):
2529         ():
2530         * inspector/front-end/inspector.css:
2531         (#elements-content .dom-shadow-root):
2532         (.outline-disclosure li .webkit-html-tag.shadow):
2533         * inspector/front-end/utilities.js:
2534
2535 2011-05-03  Adam Roben  <aroben@apple.com>
2536
2537         Remove an unnecessary OwnPtr equality check in XSLT code
2538
2539         Fixes <http://webkit.org/b/60053> Testing OwnPtrs for equality should cause a compiler error
2540
2541         Reviewed by Anders Carlsson and Antti Koivisto.
2542
2543         * dom/Document.cpp:
2544         (WebCore::Document::setTransformSource): No need to check for equality. If the pointers are
2545         equal, we're screwed anyway. (And the caller always passes in a newly-allocated object, so
2546         we're safe.)
2547
2548 2011-05-04  Leandro Gracia Gil  <leandrogracia@chromium.org>
2549
2550         Reviewed by Tony Gentilcore.
2551
2552         Media Stream API: add the skeleton of the frame and page controllers and the embedder client.
2553         https://bugs.webkit.org/show_bug.cgi?id=56922
2554
2555         Add the basic outlines of the page controller, the per-frame controller and the embedder
2556         client interface for the Media Stream API. Provide methods to handle the situations
2557         where a frame is detached from the page or transferred between pages.
2558
2559         Tests for the Media Stream API will be provided by the bug 56587.
2560
2561         * CMakeLists.txt:
2562         * GNUmakefile.list.am:
2563         * WebCore.gypi:
2564         * WebCore.pro:
2565         * WebCore.vcproj/WebCore.vcproj:
2566         * WebCore.xcodeproj/project.pbxproj:
2567         * page/Frame.cpp:
2568         (WebCore::Frame::Frame):
2569         (WebCore::Frame::~Frame):
2570         (WebCore::Frame::pageDestroyed):
2571         (WebCore::Frame::transferChildFrameToNewDocument):
2572         * page/Frame.h:
2573         (WebCore::Frame::mediaStreamFrameController):
2574         * page/MediaStreamClient.h: Added.
2575         (WebCore::MediaStreamClient::~MediaStreamClient):
2576         * page/MediaStreamController.cpp: Added.
2577         (WebCore::MediaStreamController::Request::Request):
2578         (WebCore::MediaStreamController::Request::localId):
2579         (WebCore::MediaStreamController::Request::frameController):
2580         (WebCore::MediaStreamController::MediaStreamController):
2581         (WebCore::MediaStreamController::~MediaStreamController):
2582         (WebCore::MediaStreamController::unregisterFrameController):
2583         (WebCore::MediaStreamController::registerRequest):
2584         * page/MediaStreamController.h: Added.
2585         * page/MediaStreamFrameController.cpp: Added.
2586         (WebCore::MediaStreamFrameController::Request::Request):
2587         (WebCore::MediaStreamFrameController::Request::~Request):
2588         (WebCore::MediaStreamFrameController::Request::scriptExecutionContext):
2589         (WebCore::MediaStreamFrameController::Request::isGenerateStreamRequest):
2590         (WebCore::MediaStreamFrameController::Request::isRecordedDataRequest):
2591         (WebCore::MediaStreamFrameController::RequestMap::abort):
2592         (WebCore::MediaStreamFrameController::RequestMap::abortAll):
2593         (WebCore::MediaStreamFrameController::MediaStreamFrameController):
2594         (WebCore::MediaStreamFrameController::~MediaStreamFrameController):
2595         (WebCore::MediaStreamFrameController::securityOrigin):
2596         (WebCore::MediaStreamFrameController::scriptExecutionContext):
2597         (WebCore::MediaStreamFrameController::pageController):
2598         (WebCore::MediaStreamFrameController::enterDetachedState):
2599         (WebCore::MediaStreamFrameController::disconnectPage):
2600         (WebCore::MediaStreamFrameController::disconnectFrame):
2601         (WebCore::MediaStreamFrameController::transferToNewPage):
2602         * page/MediaStreamFrameController.h: Added.
2603         * page/Page.cpp:
2604         (WebCore::Page::Page):
2605         (WebCore::Page::PageClients::PageClients):
2606         * page/Page.h:
2607         (WebCore::Page::mediaStreamController):
2608
2609 2011-05-04  Alexander Pavlov  <apavlov@chromium.org>
2610
2611         Reviewed by Yury Semikhatsky.
2612
2613         Web Inspector: Double-click in a read-only style rule results in a non-editable blank property
2614         https://bugs.webkit.org/show_bug.cgi?id=60150
2615
2616         * inspector/front-end/StylesSidebarPane.js:
2617         (WebInspector.StylePropertiesSection.prototype._handleEmptySpaceDoubleClick):
2618
2619 2011-05-04  Dominic Battre  <battre@chromium.org>
2620
2621         Reviewed by Tony Gentilcore.
2622
2623         Fix missing header in case SVG is disabled
2624         https://bugs.webkit.org/show_bug.cgi?id=60153
2625
2626         * dom/EventDispatcher.cpp:
2627
2628 2011-05-04  Luke Macpherson   <macpherson@chromium.org>
2629
2630         Reviewed by Eric Seidel.
2631
2632         Rename CSSStyleApplyProperty::propertyValue and setPropertyValue.
2633         https://bugs.webkit.org/show_bug.cgi?id=60006
2634
2635         No new tests as no functionality added. Simple rename only.
2636
2637         * css/CSSStyleApplyProperty.cpp:
2638         Rename propertyValue propertyHandler and setPropertyValue setPropertyHandler.
2639         * css/CSSStyleApplyProperty.h:
2640         Rename propertyValue propertyHandler and setPropertyValue setPropertyHandler.
2641
2642 2011-05-04  Ryosuke Niwa  <rniwa@webkit.org>
2643
2644         Reviewed by Eric Seidel.
2645
2646         Cleanup conditionals in findNextLineBreak
2647         https://bugs.webkit.org/show_bug.cgi?id=60117
2648
2649         Simplified conditional statements in findNextLineBreak.
2650
2651         * rendering/RenderBlockLineLayout.cpp:
2652         (WebCore::RenderBlock::findNextLineBreak):
2653
2654 2011-05-04  Luke Macpherson   <macpherson@chromium.org>
2655
2656         Reviewed by Eric Seidel.
2657
2658         Make CSSStyleSelector::applyProperty() CSSPropertyWebkitHyphens case use appropriate macro.
2659         https://bugs.webkit.org/show_bug.cgi?id=60114
2660
2661         No new tests as no functionality changes.
2662
2663         * css/CSSStyleSelector.cpp:
2664         (WebCore::CSSStyleSelector::applyProperty):
2665         Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro to remove code duplication.
2666
2667 2011-05-04  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2668
2669         Reviewed by Andreas Kling.
2670
2671         [Qt] Fix QNetworkReplyWrapper to not depend on QNetworkReply::isFinished() method
2672         https://bugs.webkit.org/show_bug.cgi?id=59070
2673
2674         Applications using our API and our autotests subclass QNetworkReply as part of providing a
2675         custom QNetworkAccessManager. But there's an API limitation in Qt 4.7, that makes
2676         QNetworkReply::isFinished() always be false for these custom replies. This was fixed in Qt
2677         4.8, see http://bugreports.qt.nokia.com/browse/QTBUG-11737.
2678
2679         The consequence is that QtWebKit cannot rely on this function. So now QNetworkReplyWrapper
2680         watches for the finished() signal and set a dynamic property "_q_isFinished" on the reply
2681         indicating that it is finished. When there's no finished signal (synchronous) we set the
2682         dynamic property once we get the reply.
2683
2684         This fixes tst_QWebFrame::requestedUrl(), that was breaking because sniffer was not
2685         emitting its own finished() signal, causing QWebFrame::loadFinished() to not be emitted.
2686
2687         * platform/network/qt/QNetworkReplyHandler.cpp:
2688         (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
2689         Connect the finished signal to the new setFinished() slot.
2690
2691         (WebCore::QNetworkReplyWrapper::synchronousLoad):
2692         Since we don't get the finished signal for synchronous loads, set the dynamic property
2693         before processing it.
2694
2695         (WebCore::QNetworkReplyWrapper::resetConnections):
2696         Do not reset the connection to setFinished().
2697
2698         (WebCore::QNetworkReplyWrapper::setFinished):
2699         Set the dynamic property in the reply.
2700
2701         (WebCore::QNetworkReplyWrapper::emitMetaDataChanged):
2702         (WebCore::QNetworkReplyHandler::start):
2703         Change to use wrapper's isFinished() instead of asking the reply directly.
2704
2705         * platform/network/qt/QNetworkReplyHandler.h:
2706         (WebCore::QNetworkReplyWrapper::isFinished):
2707         Checks the dynamic property of the reply.
2708
2709         * platform/network/qt/QtMIMETypeSniffer.cpp:
2710         (QtMIMETypeSniffer::sniff):
2711         Use the dynamic property to check if the reply is finished.
2712
2713 2011-05-04  Eric Seidel  <eric@webkit.org>
2714
2715         Reviewed by Ryosuke Niwa.
2716
2717         Split createLineBoxesFromBidiRuns out from layoutRunsAndFloats
2718         https://bugs.webkit.org/show_bug.cgi?id=60080
2719
2720         No functional change, just moving code.
2721
2722         * rendering/RenderBlock.h:
2723         * rendering/RenderBlockLineLayout.cpp:
2724         (WebCore::RenderBlock::createLineBoxesFromBidiRuns):
2725         (WebCore::RenderBlock::layoutRunsAndFloats):
2726
2727 2011-05-04  Andreas Kling  <andreas.kling@nokia.com>
2728
2729         Reviewed by Kenneth Rohde Christiansen.
2730
2731         [Qt] Remove unused function FontPlatformData::pixelSize()
2732         https://bugs.webkit.org/show_bug.cgi?id=60156
2733
2734         * platform/graphics/qt/FontPlatformData.h:
2735         (WebCore::FontPlatformData::pixelSize): Removed.
2736
2737 2011-05-04  Luke Macpherson   <macpherson@chromium.org>
2738
2739         Reviewed by Darin Adler.
2740
2741         Remove redundant conversion from auto table layout to auto table layout in CSSStyleSelector::applyProperty()
2742         https://bugs.webkit.org/show_bug.cgi?id=60011
2743
2744         No new tests added as no functionality changed.
2745
2746         * css/CSSStyleSelector.cpp:
2747         (WebCore::CSSStyleSelector::applyProperty):
2748         Remove reundant check for auto table layout.
2749
2750 2011-05-04  Mihai Parparita  <mihaip@chromium.org>
2751
2752         Reviewed by Darin Adler.
2753
2754         Remove double-free checks for bug 56124
2755         https://bugs.webkit.org/show_bug.cgi?id=60037
2756
2757         Antti's speculative fix for bug 56124 (r84151) appears to have worked,
2758         these CRASH() calls are not triggering anymore.
2759
2760         * css/CSSSelector.h:
2761         (WebCore::CSSSelector::CSSSelector):
2762         (WebCore::CSSSelector::~CSSSelector):
2763         * css/CSSSelectorList.cpp:
2764         (WebCore::CSSSelectorList::deleteSelectors):
2765
2766 2011-05-04  Satish Sampath  <satish@chromium.org>
2767
2768         Reviewed by Tony Gentilcore.
2769
2770         Layout the speech input button to the left of outer spin button properly.
2771         https://bugs.webkit.org/show_bug.cgi?id=59742
2772
2773         * rendering/RenderTextControlSingleLine.cpp:
2774         (WebCore::RenderTextControlSingleLine::layout):
2775
2776 2011-05-04  Yury Semikhatsky  <yurys@chromium.org>
2777
2778         Unreviewed. Build fix.
2779
2780         * bindings/js/JSInjectedScriptHostCustom.cpp: fix includes declaration
2781
2782 2011-05-03  Yury Semikhatsky  <yurys@chromium.org>
2783
2784         Reviewed by Pavel Feldman.
2785
2786         Web Inspector: can't inspect element in an iframe when element originates from non-frame document
2787         https://bugs.webkit.org/show_bug.cgi?id=60031
2788         
2789         Inspected object type evaluation has moved into native bindings. This way it doesn't
2790         depend on the current JS context.
2791
2792         Test: inspector/elements/elements-inspect-iframe-from-different-domain.html
2793
2794         * bindings/js/JSInjectedScriptHostCustom.cpp:
2795         (WebCore::JSInjectedScriptHost::isHTMLAllCollection): this method helps distinguish
2796         real undefined values from HTMLAllCollection
2797         (WebCore::JSInjectedScriptHost::type): method that returns presice type of the passed
2798         value
2799         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
2800         (WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback):
2801         (WebCore::V8InjectedScriptHost::typeCallback):
2802         * inspector/InjectedScriptHost.idl:
2803         * inspector/InjectedScriptSource.js:
2804         (.):
2805
2806 2011-05-03  Pratik Solanki  <psolanki@apple.com>
2807
2808         Reviewed by Antti Koivisto.
2809
2810         Part of WebCore should use CFNetwork-based loader on Mac
2811         https://bugs.webkit.org/show_bug.cgi?id=51836
2812
2813         Merge the conflicting definitions of WebCore::privateBrowsingCookieStorage() into one. Clean
2814         up some warnings and #if USE(CFNETWORK) around code.
2815
2816         * platform/mac/CookieJar.mm:
2817         * platform/network/CookieStorage.h:
2818         * platform/network/cf/CookieStorageCFNet.cpp:
2819         (WebCore::privateBrowsingCookieStorage):
2820         (WebCore::currentCookieStorage):
2821         (WebCore::setCurrentCookieStorage):
2822         (WebCore::setCookieStoragePrivateBrowsingEnabled):
2823         (WebCore::notifyCookiesChangedOnMainThread):
2824         (WebCore::notifyCookiesChanged):
2825         * platform/network/cf/CookieStorageCFNet.h:
2826         * platform/network/mac/CookieStorageMac.mm:
2827
2828 2011-05-03  Justin Novosad  <junov@chromium.org>
2829
2830         Reviewed by Kenneth Russell.
2831
2832         [Chromium] Make accelerated 2d canvas enabled by default with skia
2833         https://bugs.webkit.org/show_bug.cgi?id=59929
2834
2835         No new tests. Covered by existing layout tests
2836
2837         * html/canvas/CanvasRenderingContext2D.cpp:
2838         (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
2839         Initialized for accelerated canvas if either the accelerated2dCanvas
2840         or the legacyAccelerated2dCanvas flags are enabled
2841         * page/Page.cpp:
2842         (WebCore::Page::sharedGraphicsContext3D):
2843         This is where the code goes to implement the functionality for the
2844         legacy vs current acceleration paths for the 2D canvas. Currently,
2845         this is a no-op, and always select the legacy path.  This is temporary
2846         until we are ready to sort the GPU layout tests (rebasline vs. bug)
2847         * page/Settings.cpp:  Added new flage for legacyAccelerated2dCanvas
2848         (WebCore::Settings::Settings):
2849         (WebCore::Settings::setLegacyAccelerated2dCanvasEnabled):
2850         * page/Settings.h:
2851         (WebCore::Settings::legacyAccelerated2dCanvasEnabled):
2852
2853 2011-04-29  Jer Noble  <jer.noble@apple.com>
2854
2855         Reviewed by Eric Seidel.
2856
2857         Implement FULLSCREEN_API on Windows, Part 4: Enable it
2858         https://bugs.webkit.org/show_bug.cgi?id=59798
2859
2860         * WebCore.vcproj/WebCore.vcproj: Add missing full screen related
2861             files to the project.
2862
2863 2011-05-03  Alpha Lam  <hclam@chromium.org>
2864
2865         Not reviewed. Build fix.
2866
2867         More places from 0 to nullptr.
2868
2869         * bindings/v8/V8Proxy.cpp:
2870         (WebCore::V8Proxy::precompileScript):
2871         * platform/graphics/chromium/LayerTilerChromium.cpp:
2872         (WebCore::LayerTilerChromium::create):
2873         * platform/graphics/gpu/BicubicShader.cpp:
2874         (WebCore::BicubicShader::create):
2875         * platform/graphics/gpu/ConvolutionShader.cpp:
2876         (WebCore::ConvolutionShader::create):
2877         * platform/graphics/gpu/LoopBlinnSolidFillShader.cpp:
2878         (WebCore::LoopBlinnSolidFillShader::create):
2879         * platform/graphics/gpu/SolidFillShader.cpp:
2880         (WebCore::SolidFillShader::create):
2881         * platform/graphics/gpu/TexShader.cpp:
2882         (WebCore::TexShader::create):
2883         * platform/graphics/skia/PlatformContextSkia.cpp:
2884         (WebCore::PlatformContextSkia::~PlatformContextSkia):
2885         * platform/leveldb/LevelDBDatabase.cpp:
2886         (WebCore::LevelDBDatabase::createIterator):
2887         * platform/text/LocalizedNumberICU.cpp:
2888         (WebCore::createFormatterForCurrentLocale):
2889
2890 2011-05-03  Alpha Lam  <hclam@chromium.org>
2891
2892         Not reviewed. Build fix.
2893
2894         Using nullptr instead of 0. This makes visual studio happy.
2895
2896         * storage/IDBTransactionBackendInterface.h:
2897
2898 2011-05-03  Luke Macpherson   <macpherson@chromium.org>
2899
2900         Reviewed by Dimitri Glazkov.
2901
2902         Add template parameter to ApplyPropertyColor to improve clarity by removing constructor parameter side effects.
2903         https://bugs.webkit.org/show_bug.cgi?id=59774
2904
2905         No new tests required as on new functionality.
2906
2907         * css/CSSStyleApplyProperty.cpp:
2908         (WebCore::ApplyPropertyColor::applyValue):
2909         Added template parameter "inheritColorFromParent = false".
2910         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
2911         Use template parameter where appropriate.
2912
2913 2011-05-03  Dan Bernstein  <mitz@apple.com>
2914
2915         Reviewed by Darin Adler.
2916
2917         <rdar://problem/9313186> Make the fix for <rdar://problem/9190108> more robust.
2918
2919         Added a pointer from FloatingObject to its originating line, if there is one, and made sure to
2920         dirty the line when the float is removed, instead of relying on the float always intersecting
2921         its originating line.
2922
2923         * rendering/RenderBlock.cpp:
2924         (WebCore::RenderBlock::removeFloatingObject):
2925         (WebCore::RenderBlock::removeFloatingObjectsBelow):
2926         (WebCore::RenderBlock::clearFloats):
2927         * rendering/RenderBlock.h:
2928         (WebCore::RenderBlock::FloatingObject::FloatingObject):
2929         * rendering/RenderBlockLineLayout.cpp:
2930         (WebCore::RenderBlock::appendFloatingObjectToLastLine):
2931         (WebCore::RenderBlock::layoutRunsAndFloats):
2932         (WebCore::RenderBlock::determineStartPosition):
2933
2934 2011-05-02  Jer Noble  <jer.noble@apple.com>
2935
2936         Reviewed by Adam Roben.
2937
2938         Implement FULLSCREEN_API on Windows, Part 3: WebKit2
2939         https://bugs.webkit.org/show_bug.cgi?id=59845
2940
2941         Move WebFullScreenController into WebCore to facilitate code sharing between WebKit
2942         and WebKit2.  WebFullScreenController now uses a Client class to request work on its
2943         behalf by WebKit and WebKit2.  MediaPlayerPrivateFullscreenWindow now only creates a 
2944         CALayerHost once a root layer is set, as the CALayerHost was causing child window drawing
2945         problems, and because a CALayerHost is overkill if the window is only drawing black to
2946         its client area.
2947
2948         * WebCore.vcproj/WebCore.vcproj:
2949         * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
2950         (WebCore::MediaPlayerPrivateFullscreenWindow::MediaPlayerPrivateFullscreenWindow): Do not create 
2951             m_layerHost in the constructor.
2952         (WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): NULL check m_layerHost.
2953         (WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer): Lazily instantiate m_layerHost.
2954         (WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): NULL check m_layerHost; if a root layer is
2955             not present, fill the window with black in WM_PAINT.
2956         * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
2957         * platform/graphics/win/FullScreenController.cpp: Renamed from Source/WebKit/win/WebFullScreenController.cpp.
2958         * platform/graphics/win/FullScreenController.h: Renamed from Source/WebKit/win/WebFullScreenController.h.
2959         * platform/graphics/win/FullScreenControllerClient.h: Split out from FullScreenController.h
2960         (WebCore::FullScreenControllerClient::~FullScreenControllerClient):
2961
2962 2011-05-03  Brady Eidson  <beidson@apple.com>
2963
2964         Reviewed by Sam Weinig.
2965
2966         https://bugs.webkit.org/show_bug.cgi?id=60087 and <rdar://problem/9373182>
2967         WK2 Icon Database should provide access to all image representations in the icon.
2968
2969         Add an accessor for CG platforms to get a CFArrayRef of all the CGImageRefs represented:
2970         * platform/graphics/BitmapImage.h:
2971         * platform/graphics/Image.h:
2972         (WebCore::Image::getCGImageArray):
2973         * platform/graphics/cg/ImageCG.cpp:
2974         (WebCore::BitmapImage::getCGImageArray):
2975
2976 2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>
2977
2978         Reviewed by Eric Seidel.
2979
2980         findNextLineBreak splits InlineIterator into 3 pieces
2981         https://bugs.webkit.org/show_bug.cgi?id=60082
2982
2983         Avoid splitting InlineIterator into 3 variables with inter-dependencies.
2984
2985         * rendering/InlineIterator.h:
2986         (WebCore::InlineIterator::fastIncrementInTextNode): Added.
2987         (WebCore::InlineIterator::previousInSameNode): Added.
2988         * rendering/RenderBlockLineLayout.cpp:
2989         (WebCore::RenderBlock::findNextLineBreak):
2990
2991 2011-05-03  Dean Jackson  <dino@apple.com>
2992
2993         Reviewed by Simon Fraser.
2994
2995         Interrupted transitions are not correctly removed
2996         https://bugs.webkit.org/show_bug.cgi?id=60062
2997
2998         CompositeAnimation was replacing any existing
2999         transition as a new one was created. However, it wasn't
3000         clearing the lists in AnimationControllerPrivate that
3001         signal when a hardware animation starts. Rather than
3002         simple removing the existing transition, we now tell
3003         AnimationControllerPrivate that is has gone.
3004
3005         Test: transitions/3d/interrupted-transition.html
3006
3007         * page/animation/CompositeAnimation.cpp:
3008         (WebCore::CompositeAnimation::updateTransitions):
3009
3010 2011-05-03  Enrica Casucci  <enrica@apple.com>
3011
3012         Reviewed by Ryosuke Niwa.
3013
3014         Crash in SpellingCorrectionController::respondToChangedSelection.
3015         https://bugs.webkit.org/show_bug.cgi?id=60071
3016         <rdar://problem/9358190>
3017
3018         Creating a Visible position could trigger a layout and there is no
3019         guarantee that the selection is still valid after that.
3020
3021         Tests: editing/selection/undo-crash.html
3022
3023         * editing/SpellingCorrectionController.cpp:
3024         (WebCore::SpellingCorrectionController::respondToChangedSelection):
3025
3026 2011-05-03  Levi Weintraub  <leviw@chromium.org>
3027
3028         Reviewed by Eric Seidel.
3029
3030         Refactor computeInlineDirectionPositionsForLine into smaller functions
3031         https://bugs.webkit.org/show_bug.cgi?id=60072
3032
3033         Split three functions off from computeInlineDirectionPositionsForLine
3034         to improve its readability.
3035
3036         No new tests since this is just moving code around.
3037
3038         * rendering/RenderBlock.h:
3039         * rendering/RenderBlockLineLayout.cpp:
3040         (WebCore::RenderBlock::setMarginsForRubyRun):
3041         (WebCore::setLogicalWidthForTextRun):
3042         (WebCore::computeExpansionForJustifiedText):
3043         (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
3044
3045 2011-05-03  David Kilzer  <ddkilzer@apple.com>
3046
3047         <http://webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking
3048
3049         Reviewed by Antti Koivisto.
3050
3051         * platform/network/cf/ResourceRequestCFNet.cpp:
3052         (WebCore::ResourceRequest::doUpdatePlatformRequest): Set the
3053         priority on the request if HTTP pipelining is enabled.
3054         (WebCore::ResourceRequest::doUpdateResourceRequest): Read the
3055         priority from the request if HTTP pipelining is enabled.
3056         (readBooleanPreference): Enable code when compiling with
3057         USE(CFNETWORK).
3058         (WebCore::initializeMaximumHTTPConnectionCountPerHost): Ditto.
3059         Comment out setting the minimum fast lane priority on Windows
3060         since it's not currently available.
3061
3062 2011-05-03  Simon Fraser  <simon.fraser@apple.com>
3063
3064         Reviewed by Dan Bernstein.
3065
3066         <rdar://problem/9278296> Flicker zooming on Google Maps satellite view with accelerated compositing turned on
3067
3068         Conditionalize compositing tiled layer size-constraining logic to older
3069         OSes.
3070
3071         * platform/graphics/ca/GraphicsLayerCA.cpp:
3072         (WebCore::GraphicsLayerCA::constrainedSize):
3073
3074 2011-05-03  Roland Steiner  <rolandsteiner@chromium.org>
3075
3076         Reviewed by Dimitri Glazkov.
3077
3078         Allow access keys to be used in shadow DOM
3079         https://bugs.webkit.org/show_bug.cgi?id=59979
3080
3081         Move access key methods and members back to Document from TreeScope.
3082         Also traverse into shadow trees when building the access key map.
3083
3084         No new tests. (refactoring)
3085
3086         * dom/Document.cpp:
3087         (WebCore::Document::Document):
3088         (WebCore::Document::getElementByAccessKey):
3089         (WebCore::Document::buildAccessKeyMap):
3090         (WebCore::Document::invalidateAccessKeyMap):
3091         * dom/Document.h:
3092         * dom/TreeScope.cpp:
3093         (WebCore::TreeScope::TreeScope):
3094         (WebCore::TreeScope::destroyTreeScopeData):
3095         * dom/TreeScope.h:
3096
3097 2011-05-03  Dan Bernstein  <mitz@apple.com>
3098
3099         Reviewed by Darin Adler.
3100
3101         <rdar://problem/8891395> -[DOMRange textRects] returns incorrect results for vertical or flipped text
3102         https://bugs.webkit.org/show_bug.cgi?id=60067
3103
3104         No test because this code path is only used by the Objective-C API, which is not testable from DumpRenderTree.
3105
3106         * rendering/RenderText.cpp:
3107         (WebCore::RenderText::absoluteRectsForRange): Use width/height instead of logicalWidth/logicalHeight here,
3108         and perform the local-to-absolute mapping on the rects rather than their origin, in order to get the right
3109         results for flipped writing modes.
3110
3111 2011-05-03  Anton Muhin  <antonm@chromium.org>
3112
3113         Reviewed by Yury Semikhatsky.
3114
3115         [v8] remove an ASSERT from grouping logic
3116         https://bugs.webkit.org/show_bug.cgi?id=60024
3117
3118         This ASSERT was exploratory.  Alas, right now I am aware of no easy way to
3119         repro it.  Removing for now for greener bots.
3120
3121         No new tests, only an ASSERT removal.
3122
3123         * bindings/v8/V8GCController.cpp:
3124         (WebCore::calculateGroupId):
3125
3126 2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>
3127
3128         Reviewed by Darin Adler.
3129
3130         WebKit allows selection that crosses the shadow boundary of a readonly input element
3131         https://bugs.webkit.org/show_bug.cgi?id=60000
3132
3133         The bug was caused by VisibleSelection's not validating shadow DOM boundaries.
3134         Fixed the bug by adding an extra adjustment, adjustSelectionToAvoidCrossingShadowBoundaries,
3135         in its validation process.
3136
3137         Tests: editing/selection/select-across-readonly-input-1.html
3138                editing/selection/select-across-readonly-input-2.html
3139                editing/selection/select-across-readonly-input-3.html
3140                editing/selection/select-across-readonly-input-4.html
3141                editing/selection/select-across-readonly-input-5.html
3142
3143         * editing/VisibleSelection.cpp:
3144         (WebCore::VisibleSelection::validate): Calls adjustSelectionToAvoidCrossingShadowBoundaries.
3145         (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): Added.
3146         * editing/VisibleSelection.h:
3147
3148 2011-05-03  Eric Seidel  <eric@webkit.org>
3149
3150         Reviewed by Ryosuke Niwa.
3151
3152         Split out layoutRunsAndFloats from layoutInlineChildren
3153         https://bugs.webkit.org/show_bug.cgi?id=60052
3154
3155         No new tests, just moving code here.  There should be
3156         no change in behavior.
3157
3158         * rendering/RenderBlock.h:
3159         * rendering/RenderBlockLineLayout.cpp:
3160         (WebCore::RenderBlock::layoutRunsAndFloats):
3161         (WebCore::RenderBlock::layoutInlineChildren):
3162
3163 2011-05-03  James Robinson  <jamesr@chromium.org>
3164
3165         Reviewed by Kenneth Russell.
3166
3167         [chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
3168         https://bugs.webkit.org/show_bug.cgi?id=59965
3169
3170         Fixes a few bugs leading to a crash if a canvas already being composited was resized to huge dimensions.
3171
3172         Test: fast/canvas/canvas-resize-after-paint.html
3173
3174         * html/canvas/CanvasRenderingContext2D.cpp:
3175         (WebCore::CanvasRenderingContext2D::reset):
3176             Mark the canvas's layer as needing a synthetic style recalculation when creating or destroying the backing
3177             DrawingBuffer so that we exit compositing mode properly if we can't handle the canvas dimensions.
3178         * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
3179         (WebCore::Canvas2DLayerChromium::setLayerRenderer):
3180             Add a null check for m_drawingBuffer
3181         * platform/graphics/gpu/DrawingBuffer.cpp:
3182         (WebCore::DrawingBuffer::clear):
3183             Avoid clearing the m_context pointer in reset() - we destroy the DrawingBuffer whenever reset() fails, so
3184             this is unnecessary.
3185
3186 2011-05-03  Adam Roben  <aroben@apple.com>
3187
3188         Fix most strict PassOwnPtr violations on Windows
3189
3190         Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
3191         enabled
3192
3193         Reviewed by Anders Carlsson.
3194
3195         * loader/EmptyClients.h:
3196         * platform/GeolocationService.cpp:
3197         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
3198         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
3199         * platform/mock/GeolocationServiceMock.cpp:
3200         * rendering/RenderTheme.cpp:
3201         * rendering/RenderThemeSafari.cpp:
3202
3203 2011-05-03  Levi Weintraub  <leviw@chromium.org>
3204
3205         Reviewed by Eric Seidel.
3206
3207         Extract LineInfo class
3208         https://bugs.webkit.org/show_bug.cgi?id=60044
3209
3210         Created a LineInfo class in RenderBlockLineLayout.cpp that brings together the relevant
3211         layout information about a line. This simplifies function signatures and clears up initialization.
3212
3213         No new tests as this is refactoring.
3214
3215         * rendering/RenderBlock.h: Updated internal layout function signatures to use LineInfo.
3216         * rendering/RenderBlockLineLayout.cpp:
3217         (WebCore::LineInfo::LineInfo):
3218         (WebCore::LineInfo::isFirstLine):
3219         (WebCore::LineInfo::isLastLine):
3220         (WebCore::LineInfo::isEmpty):
3221         (WebCore::LineInfo::previousLineBrokeCleanly):
3222         (WebCore::LineInfo::setFirstLine):
3223         (WebCore::LineInfo::setLastLine):
3224         (WebCore::LineInfo::setEmpty):
3225         (WebCore::LineInfo::setPreviousLineBrokeCleanly):
3226         (WebCore::RenderBlock::createLineBoxes):
3227         (WebCore::RenderBlock::constructLine):
3228         (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
3229         (WebCore::RenderBlock::layoutInlineChildren):
3230         (WebCore::RenderBlock::determineStartPosition):
3231         (WebCore::skipNonBreakingSpace):
3232         (WebCore::shouldCollapseWhiteSpace):
3233         (WebCore::requiresLineBox): Moved from RenderBlock.h and made it locally scoped to RenderBlockLineLayout.cpp
3234         (WebCore::RenderBlock::generatesLineBoxesForInlineChild):
3235         (WebCore::RenderBlock::skipTrailingWhitespace):
3236         (WebCore::RenderBlock::skipLeadingWhitespace):
3237         (WebCore::RenderBlock::findNextLineBreak):
3238
3239 2011-05-03  Roland Steiner  <rolandsteiner@chromium.org>
3240
3241         Reviewed by Dimitri Glazkov.
3242
3243         Update node list cache count on the containing TreeScope rather than the Document
3244         https://bugs.webkit.org/show_bug.cgi?id=59983
3245
3246         Change code to call add/removeNodeListCache() and hasNodeListCaches() on the proper tree scope.
3247         Move updating of the node list cache count from setDocument() to setTreeScopeRecursively().
3248         Make setDocument() and setDocumentRecursively() private.
3249
3250         No new tests. (refactoring)
3251
3252         * dom/ContainerNode.cpp:
3253         (WebCore::ContainerNode::childrenChanged):
3254         * dom/Node.cpp:
3255         (WebCore::Node::~Node):
3256         (WebCore::Node::setDocument):
3257         (WebCore::Node::setTreeScopeRecursively):
3258         (WebCore::Node::childNodes):
3259         (WebCore::Node::registerDynamicNodeList):
3260         (WebCore::Node::unregisterDynamicNodeList):
3261         (WebCore::Node::notifyLocalNodeListsAttributeChanged):
3262         (WebCore::Node::notifyLocalNodeListsChildrenChanged):
3263         (WebCore::Node::getElementsByTagName):
3264         (WebCore::Node::getElementsByTagNameNS):
3265         (WebCore::Node::getElementsByName):
3266         (WebCore::Node::getElementsByClassName):
3267         * dom/Node.h:
3268         * html/HTMLFormControlElement.cpp:
3269         (WebCore::HTMLFormControlElement::labels):
3270
3271 2011-05-03  Ryosuke Niwa  <rniwa@webkit.org>
3272
3273         Reviewed by Eric Seidel.
3274
3275         Bundle trailingSpaceObject and trailingPositionedBoxes in findNextLineBreak as a class
3276         https://bugs.webkit.org/show_bug.cgi?id=60046
3277
3278         Extracted TrailingObjects that encapsulates trailingSpaceObject and trailingPositionedBoxes.
3279
3280         * rendering/RenderBlockLineLayout.cpp:
3281         (WebCore::TrailingObjects::TrailingObjects):
3282         (WebCore::TrailingObjects::setTrailingWhitespace):
3283         (WebCore::TrailingObjects::clear):
3284         (WebCore::TrailingObjects::appendBoxIfNeeded):
3285         (WebCore::TrailingObjects::addMidpoints):
3286         (WebCore::RenderBlock::findNextLineBreak):
3287
3288 2011-05-03  Igor Oliveira  <igor.oliveira@openbossa.org>
3289
3290         Reviewed by Eric Seidel.
3291
3292         [Qt] Implement initial support to DataTransferItems
3293         https://bugs.webkit.org/show_bug.cgi?id=58448
3294
3295         Implement initial support to DataTransferItems. DataTransferItems are used to 
3296         hold data for drag and drop operations. DataTransferItems hold a list of 
3297         DataTransferItem objects each of which holds an item being dragged.
3298
3299         * WebCore.pro:
3300         * dom/DataTransferItems.idl:
3301         * editing/qt/EditorQt.cpp:
3302         (WebCore::Editor::newGeneralClipboard):
3303         * page/qt/EventHandlerQt.cpp:
3304         (WebCore::EventHandler::createDraggingClipboard):
3305         * platform/chromium/DataTransferItemsChromium.h:
3306         * platform/qt/ClipboardQt.cpp:
3307         (WebCore::Clipboard::create):
3308         (WebCore::ClipboardQt::ClipboardQt):
3309         (WebCore::ClipboardQt::items):
3310         * platform/qt/ClipboardQt.h:
3311         (WebCore::ClipboardQt::create):
3312         * platform/qt/DataTransferItemQt.cpp: Added.
3313         (WebCore::DataTransferItem::create):
3314         (WebCore::DataTransferItemQt::createFromPasteboard):
3315         (WebCore::DataTransferItemQt::create):
3316         (WebCore::DataTransferItemQt::DataTransferItemQt):
3317         (WebCore::DataTransferItemQt::getAsString):
3318         (WebCore::DataTransferItemQt::getAsFile):
3319         * platform/qt/DataTransferItemQt.h: Added.
3320         * platform/qt/DataTransferItemsQt.cpp: Copied from Source/WebCore/editing/qt/EditorQt.cpp.
3321         (WebCore::DataTransferItemsQt::create):
3322         (WebCore::DataTransferItemsQt::DataTransferItemsQt):
3323         (WebCore::DataTransferItemsQt::addPasteboardItem):
3324         * platform/qt/DataTransferItemsQt.h: Copied from Source/WebCore/editing/qt/EditorQt.cpp.
3325
3326 2011-05-03  Julien Chaffraix  <jchaffraix@codeaurora.org>
3327
3328         Reviewed by Dimitri Glazkov.
3329
3330         Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
3331         https://bugs.webkit.org/show_bug.cgi?id=58703
3332
3333         No new tests, refactoring only.
3334
3335         * dom/Element.cpp:
3336         (WebCore::Element::copyNonAttributeProperties):
3337         (WebCore::Element::insertedIntoDocument):
3338         (WebCore::Element::removedFromDocument):
3339         (WebCore::Element::insertedIntoTree):
3340         (WebCore::Element::removedFromTree):
3341         (WebCore::Element::attach):
3342         (WebCore::Element::detach):
3343         (WebCore::Element::recalcStyle):
3344         (WebCore::Element::shadowRoot):
3345         (WebCore::Element::ensureShadowRoot):
3346         (WebCore::Element::childrenChanged):
3347         * dom/Node.cpp:
3348         (WebCore::Node::setTreeScopeRecursively):
3349         (WebCore::shadowRoot):
3350         (WebCore::Node::setDocumentRecursively):
3351         (WebCore::NodeRendererFactory::findVisualParent):
3352         Updated all the call sites for shadowRoot and ensureShadowRoot in the 2
3353         previous classes.
3354
3355         * dom/Element.h: Updated 2 methods' signature to return a ShadowRoot*.
3356
3357         * dom/ShadowRoot.h: Removed toShadowRoot as it is not used anymore.
3358
3359         * html/HTMLDetailsElement.cpp:
3360         * html/HTMLSummaryElement.cpp:
3361         Added #include for ShadowRoot.h.
3362
3363 2011-05-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3364
3365         Reviewed by Kenneth Rohde Christiansen.
3366
3367         [EFL] Implement mediaSliderTrack
3368         https://bugs.webkit.org/show_bug.cgi?id=59998
3369
3370         Implement paintMediaSliderTrack.
3371
3372         * platform/efl/RenderThemeEfl.cpp:
3373         (WebCore::RenderThemeEfl::RenderThemeEfl):
3374         (WebCore::RenderThemeEfl::paintMediaSliderTrack):
3375         * platform/efl/RenderThemeEfl.h:
3376
3377 2011-05-03  Mikhail Naganov  <mnaganov@chromium.org>
3378
3379         Reviewed by Pavel Feldman.
3380
3381         WebInspector: [Chromium] Fix slowness of Summary view nodes expansion in detailed heap profiles.
3382         https://bugs.webkit.org/show_bug.cgi?id=60023
3383
3384         * inspector/front-end/DetailedHeapshotGridNodes.js:
3385         (WebInspector.HeapSnapshotConstructorNode):
3386         (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
3387         * inspector/front-end/HeapSnapshot.js:
3388         (WebInspector.HeapSnapshot.prototype.dispose):
3389         (WebInspector.HeapSnapshot.prototype.aggregates):
3390         (WebInspector.HeapSnapshot.prototype._buildAggregates):
3391         (WebInspector.HeapSnapshot.prototype._sortAggregateIndexes):
3392         (WebInspector.HeapSnapshot.prototype.createNodesProviderForClass):
3393         (WebInspector.HeapSnapshotFilteredOrderedIterator):
3394         (WebInspector.HeapSnapshotNodesProvider):
3395         * inspector/front-end/HeapSnapshotProxy.js:
3396         (WebInspector.HeapSnapshotProxy.prototype.aggregates):
3397         (WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForClass):
3398
3399 2011-05-03  Mikhail Naganov  <mnaganov@chromium.org>
3400
3401         Reviewed by Pavel Feldman.
3402
3403         WebInspector: [Chromium] Hint user that to display retaining paths, an object entry must be clicked.
3404         https://bugs.webkit.org/show_bug.cgi?id=60029
3405
3406         * English.lproj/localizedStrings.js:
3407         * inspector/front-end/DetailedHeapshotView.js:
3408         (WebInspector.HeapSnapshotRetainingPathsList.prototype.reset):
3409         (WebInspector.DetailedHeapshotView.prototype._mouseClickInContainmentGrid):
3410
3411 2011-05-03  Beth Dakin  <bdakin@apple.com>
3412
3413         Reviewed by Dan Bernstein.
3414
3415         https://bugs.webkit.org/show_bug.cgi?id=60045
3416         Scrollbar thumb sometimes leaves artifacts in the track after scrolling
3417         -and corresponding-
3418         <rdar://problem/9015376>
3419
3420         When we're using WK_SCROLLBAR_PAINTER, the AppleScrollBarVariant default should 
3421         always be ignored.
3422         * platform/mac/ScrollbarThemeMac.mm:
3423         (WebCore::updateArrowPlacement):
3424
3425 2011-05-03  David Hyatt  <hyatt@apple.com>
3426
3427         Reviewed by Dan Bernstein.
3428
3429         https://bugs.webkit.org/show_bug.cgi?id=60040
3430         <rdar://problem/9261591>
3431
3432         Links broken at iplanwebsites.com. Make sure that culledInlineAbsoluteQuads still does
3433         a translation of a 0,0 point to absolute coordinates so that the top left position is
3434         accurate.
3435
3436         Added fast/inline/skipped-whitespace-client-rect.html
3437         
3438         * rendering/RenderInline.cpp:
3439         (WebCore::RenderInline::culledInlineAbsoluteQuads):
3440
3441 2011-05-03  Sam Weinig  <sam@webkit.org>
3442
3443         Fix chromium build.
3444
3445         * page/Settings.cpp:
3446
3447 2011-05-02  Roland Steiner  <rolandsteiner@chromium.org>
3448
3449         Reviewed by Dimitri Glazkov.
3450
3451         Bug 59974 - Update image map on the containing TreeScope rather than the Document
3452         https://bugs.webkit.org/show_bug.cgi?id=59974
3453
3454         No new tests. (reefactoring)
3455
3456         * html/HTMLMapElement.cpp:
3457         (WebCore::HTMLMapElement::parseMappedAttribute):
3458         (WebCore::HTMLMapElement::insertedIntoDocument):
3459         (WebCore::HTMLMapElement::removedFromDocument):
3460         * rendering/RenderImage.cpp:
3461         (WebCore::RenderImage::imageMap):
3462
3463 2011-05-03  Sam Weinig  <sam@webkit.org>
3464
3465         Fix chromium build.
3466
3467         * loader/HistoryController.cpp:
3468
3469 2011-05-02  Roland Steiner  <rolandsteiner@chromium.org>
3470
3471         Reviewed by Dimitri Glazkov.
3472
3473         Bug 59966 - Update ID hash on the containing TreeScope rather than the Document
3474         https://bugs.webkit.org/show_bug.cgi?id=59966
3475
3476         No new tests. (refactoring)
3477
3478         * accessibility/AccessibilityRenderObject.cpp:
3479         (WebCore::AccessibilityRenderObject::elementsFromAttribute):
3480         (WebCore::AccessibilityRenderObject::activeDescendant):
3481         * accessibility/AccessibilityRenderObject.h:
3482         (WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
3483         * css/CSSCursorImageValue.cpp: