ed474822d1e96843676030a9c34882890b999b15
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2012-02-22  Raymond Liu  <raymond.liu@intel.com>
2
3         Have the DynamicsCompressorNode support multi-channel data
4         https://bugs.webkit.org/show_bug.cgi?id=77856
5
6         Reviewed by Chris Rogers.
7
8         * platform/audio/DynamicsCompressor.cpp:
9         (WebCore::DynamicsCompressor::DynamicsCompressor):
10         (WebCore::DynamicsCompressor::setEmphasisStageParameters):
11         (WebCore::DynamicsCompressor::process):
12         (WebCore::DynamicsCompressor::reset):
13         (WebCore::DynamicsCompressor::setNumberOfChannels):
14         (WebCore):
15         * platform/audio/DynamicsCompressor.h:
16         (DynamicsCompressor):
17         * platform/audio/DynamicsCompressorKernel.cpp:
18         (WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
19         (WebCore::DynamicsCompressorKernel::setNumberOfChannels):
20         (WebCore):
21         (WebCore::DynamicsCompressorKernel::setPreDelayTime):
22         (WebCore::DynamicsCompressorKernel::process):
23         (WebCore::DynamicsCompressorKernel::reset):
24         * platform/audio/DynamicsCompressorKernel.h:
25         (DynamicsCompressorKernel):
26         * webaudio/DynamicsCompressorNode.cpp:
27         (WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
28         (WebCore::DynamicsCompressorNode::initialize):
29
30 2012-02-22  Bear Travis  <betravis@adobe.com>
31
32         Not correctly recalculating layout for elements within nested SVG elements
33         https://bugs.webkit.org/show_bug.cgi?id=77535
34
35         Reviewed by Dirk Schulze.
36
37         Relatively positioned text is not correctly updating its position when the
38         size of its nearest viewport changes. Updating to mark text for layout when
39         viewPort size changes.
40         
41         Test: svg/repaint/inner-svg-change-viewPort-relative.svg
42
43         * rendering/svg/SVGRenderSupport.cpp:
44         (WebCore::SVGRenderSupport::layoutChildren):
45
46 2012-02-22  Alexei Svitkine  <asvitkine@chromium.org>
47
48         [chromium] Fix remaining compositing/rubberbanding test failures
49         https://bugs.webkit.org/show_bug.cgi?id=78008
50
51         These were happening due to the fact that ScrollView wasn't updating
52         the overhang layer when the contentsSize was updated. This is necessary
53         because calculateOverhangAreasForPainting() takes the contentsSize into
54         account when determining whether the overhang areas are visible.
55
56         Reviewed by James Robinson.
57
58         Re-enabled the following tests with updated baselines:
59         * platform/chromium/compositing/rubberbanding/transform-overhang-e-expected.png:
60         * platform/chromium/compositing/rubberbanding/transform-overhang-s-expected.png:
61         * platform/chromium/compositing/rubberbanding/transform-overhang-se-expected.png:
62         * platform/chromium/test_expectations.txt:
63
64         * platform/ScrollView.cpp:
65         (WebCore::ScrollView::setContentsSize):
66         (WebCore::ScrollView::scrollContents):
67         (WebCore::ScrollView::updateOverhangAreas):
68         (WebCore):
69         * platform/ScrollView.h:
70         (ScrollView):
71
72 2012-02-22  Vsevolod Vlasov  <vsevik@chromium.org>
73
74         Web Inspector: [Regression] network worker tests crash on qt.
75         https://bugs.webkit.org/show_bug.cgi?id=79263
76
77         Reviewed by Pavel Feldman.
78
79         * inspector/InspectorPageAgent.cpp:
80         (WebCore::InspectorPageAgent::createDecoder):
81         (WebCore::InspectorPageAgent::cachedResourceContent):
82
83 2012-02-22  Adrienne Walker  <enne@google.com>
84
85         Unreviewed, rolling out r108518.
86         http://trac.webkit.org/changeset/108518
87         https://bugs.webkit.org/show_bug.cgi?id=75864
88
89         Breaks surfaceOcclusionWithOverlappingSiblingSurfaces unit test.
90
91         * WebCore.gypi:
92         * platform/graphics/chromium/cc/CCLayerIterator.cpp:
93         (WebCore):
94         (WebCore::CCLayerIteratorActions::BackToFront::begin):
95         (WebCore::CCLayerIteratorActions::BackToFront::end):
96         (WebCore::CCLayerIteratorActions::BackToFront::next):
97         (WebCore::CCLayerIteratorActions::FrontToBack::begin):
98         (WebCore::CCLayerIteratorActions::FrontToBack::end):
99         (WebCore::CCLayerIteratorActions::FrontToBack::next):
100         (WebCore::CCLayerIteratorActions::FrontToBack::goToHighestInSubtree):
101         * platform/graphics/chromium/cc/CCLayerIterator.h:
102         (WebCore):
103         (WebCore::CCLayerIterator::CCLayerIterator):
104         (WebCore::CCLayerIterator::operator++):
105         (WebCore::CCLayerIterator::operator==):
106         (WebCore::CCLayerIterator::operator->):
107         (WebCore::CCLayerIterator::operator*):
108         (WebCore::CCLayerIterator::representsTargetRenderSurface):
109         (WebCore::CCLayerIterator::representsContributingRenderSurface):
110         (WebCore::CCLayerIterator::targetRenderSurfaceLayer):
111         (CCLayerIterator):
112         (BackToFront):
113         (FrontToBack):
114         * platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Added.
115         (WebCore):
116         (CCLayerIteratorPositionValue):
117         (WebCore::CCLayerIteratorPosition::CCLayerIteratorPosition):
118         (CCLayerIteratorPosition):
119         (WebCore::CCLayerIteratorPosition::currentLayer):
120         (WebCore::CCLayerIteratorPosition::currentLayerRepresentsContributingRenderSurface):
121         (WebCore::CCLayerIteratorPosition::currentLayerRepresentsTargetRenderSurface):
122         (WebCore::CCLayerIteratorPosition::targetRenderSurfaceLayer):
123         (WebCore::CCLayerIteratorPosition::targetRenderSurface):
124         (WebCore::CCLayerIteratorPosition::targetRenderSurfaceChildren):
125         (WebCore::CCLayerIteratorPosition::operator==):
126
127 2012-02-22  Dan Bernstein  <mitz@apple.com>
128
129         REGRESSION (r62632): page-break-inside: avoid is ignored
130         https://bugs.webkit.org/show_bug.cgi?id=79262
131
132         Reviewed by Adele Peterson.
133
134         This was disabled in r62632 because of <http://webkit.org/b/41532>. Changes to the
135         pagination code since then have invalidated that bug, so enabling the feature again does not
136         re-introduce the bug.
137
138         Updated expected results for printing/page-break-inside-avoid.html.
139
140         * rendering/RenderBlock.cpp:
141         (WebCore::RenderBlock::adjustForUnsplittableChild):
142
143 2012-02-22  Philippe Normand  <pnormand@igalia.com>
144
145         [GStreamer] webkitwebsrc: use HTTP referer provided by MediaPlayer
146         https://bugs.webkit.org/show_bug.cgi?id=79236
147
148         Reviewed by Martin Robinson.
149
150         Store a pointer to the MediaPlayer object in the private structure
151         of the WebKitWebSrc element so we can call its public methods,
152         like ::referrer().
153
154         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
155         (WebCore::MediaPlayerPrivateGStreamer::sourceChanged):
156         * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
157         (_WebKitWebSrcPrivate):
158         * platform/graphics/gstreamer/WebKitWebSourceGStreamer.h:
159
160 2012-02-22  Martin Robinson  <mrobinson@igalia.com>
161
162         [GTK] Clean build is broken when using make -j
163         https://bugs.webkit.org/show_bug.cgi?id=76388
164
165         No new tests. This is just a build fix.
166
167         Use order-only dependencies to ensure that built sources are built before
168         files that depend on them.
169
170         * GNUmakefile.am: Establish an order-only dependency on some built sources before starting
171         to build non-generated sources. Rename some temporary files and variables to be more consistent.
172         * bindings/gobject/GNUmakefile.am: Updated to reflect new variable names.
173
174 2012-02-22  Dana Jansens  <danakj@chromium.org>
175
176         [Chromium] New CCOcclusionTracker class with tests
177         https://bugs.webkit.org/show_bug.cgi?id=78549
178
179         Reviewed by James Robinson.
180
181         Adds a CCOcclusionTrackerBase template class that is able to track occlusion
182         of layers while traversing the layer tree from front-to-back, with typedefed
183         versions for the main and impl threads.
184
185         At each step of the front-to-back traversal, the class should be notified of
186         changes to the current render target, and when done working with a layer, the
187         layer is added the tracked occlusion.
188
189         The class provides tests for checking if a rect in content space
190         for a layer/surface is occluded by others in front of it.
191
192         Unit tests: CCOcclusionTrackerTest.cpp
193
194         * WebCore.gypi:
195         * platform/graphics/chromium/cc/CCOcclusionTracker.cpp: Added.
196         (WebCore):
197         (WebCore::::enterTargetRenderSurface):
198         (WebCore::::finishedTargetRenderSurface):
199         (WebCore::transformSurfaceOpaqueRegion):
200         (WebCore::::leaveToTargetRenderSurface):
201         (WebCore::contentToScreenSpaceTransform):
202         (WebCore::contentToTargetSurfaceTransform):
203         (WebCore::computeOcclusionBehindLayer):
204         (WebCore::::markOccludedBehindLayer):
205         (WebCore::testContentRectOccluded):
206         (WebCore::::occluded):
207         (WebCore::::surfaceOccluded):
208         (WebCore::rectSubtractRegion):
209         (WebCore::computeUnoccludedContentRect):
210         (WebCore::::unoccludedContentRect):
211         (WebCore::::surfaceUnoccludedContentRect):
212         (WebCore::::currentOcclusionInScreenSpace):
213         (WebCore::::currentOcclusionInTargetSurface):
214         * platform/graphics/chromium/cc/CCOcclusionTracker.h: Added.
215         (WebCore):
216         (CCOcclusionTrackerBase):
217         (WebCore::CCOcclusionTrackerBase::CCOcclusionTrackerBase):
218         (StackObject):
219
220 2012-02-22  Joshua Bell  <jsbell@chromium.org>
221
222         [Chromium] IndexedDB: Integrate with about:tracing
223         https://bugs.webkit.org/show_bug.cgi?id=78831
224
225         Annotate interesting IDB functions so they show up in the
226         tracing utility included in the Chromium port.
227
228         Reviewed by Tony Chang.
229
230         * WebCore.gypi:
231         * WebCore.xcodeproj/project.pbxproj:
232         * bindings/v8/IDBBindingUtilities.cpp:
233         (WebCore::createIDBKeyFromSerializedValueAndKeyPath):
234         (WebCore::injectIDBKeyIntoSerializedValue):
235         * storage/IDBCursor.cpp:
236         (WebCore::IDBCursor::direction):
237         (WebCore::IDBCursor::key):
238         (WebCore::IDBCursor::primaryKey):
239         (WebCore::IDBCursor::value):
240         (WebCore::IDBCursor::update):
241         (WebCore::IDBCursor::continueFunction):
242         (WebCore::IDBCursor::deleteFunction):
243         * storage/IDBCursorBackendImpl.cpp:
244         (WebCore::IDBCursorBackendImpl::direction):
245         (WebCore::IDBCursorBackendImpl::key):
246         (WebCore::IDBCursorBackendImpl::primaryKey):
247         (WebCore::IDBCursorBackendImpl::value):
248         (WebCore::IDBCursorBackendImpl::update):
249         (WebCore::IDBCursorBackendImpl::continueFunction):
250         (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
251         (WebCore::IDBCursorBackendImpl::deleteFunction):
252         (WebCore::IDBCursorBackendImpl::prefetchContinue):
253         (WebCore::IDBCursorBackendImpl::prefetchContinueInternal):
254         (WebCore::IDBCursorBackendImpl::prefetchReset):
255         (WebCore::IDBCursorBackendImpl::close):
256         * storage/IDBDatabase.cpp:
257         (WebCore::IDBDatabase::dispatchEvent):
258         * storage/IDBIndex.cpp:
259         (WebCore::IDBIndex::openCursor):
260         (WebCore::IDBIndex::count):
261         (WebCore::IDBIndex::openKeyCursor):
262         (WebCore::IDBIndex::get):
263         (WebCore::IDBIndex::getKey):
264         * storage/IDBIndexBackendImpl.cpp:
265         (WebCore::IDBIndexBackendImpl::openCursorInternal):
266         (WebCore::IDBIndexBackendImpl::openCursor):
267         (WebCore::IDBIndexBackendImpl::openKeyCursor):
268         (WebCore::IDBIndexBackendImpl::countInternal):
269         (WebCore::IDBIndexBackendImpl::count):
270         (WebCore::IDBIndexBackendImpl::getInternal):
271         (WebCore::IDBIndexBackendImpl::get):
272         (WebCore::IDBIndexBackendImpl::getKey):
273         * storage/IDBObjectStore.cpp:
274         (WebCore::IDBObjectStore::name):
275         (WebCore::IDBObjectStore::keyPath):
276         (WebCore::IDBObjectStore::indexNames):
277         (WebCore::IDBObjectStore::transaction):
278         (WebCore::IDBObjectStore::get):
279         (WebCore::IDBObjectStore::add):
280         (WebCore::IDBObjectStore::put):
281         (WebCore::IDBObjectStore::deleteFunction):
282         (WebCore::IDBObjectStore::clear):
283         (WebCore::IDBObjectStore::createIndex):
284         (WebCore::IDBObjectStore::index):
285         (WebCore::IDBObjectStore::openCursor):
286         (WebCore::IDBObjectStore::count):
287         * storage/IDBObjectStoreBackendImpl.cpp:
288         (WebCore::IDBObjectStoreBackendImpl::get):
289         (WebCore::IDBObjectStoreBackendImpl::getInternal):
290         (WebCore::fetchKeyFromKeyPath):
291         (WebCore::injectKeyIntoKeyPath):
292         (WebCore::IDBObjectStoreBackendImpl::put):
293         (WebCore::IDBObjectStoreBackendImpl::putInternal):
294         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
295         (WebCore::IDBObjectStoreBackendImpl::deleteInternal):
296         (WebCore::IDBObjectStoreBackendImpl::clear):
297         (WebCore::IDBObjectStoreBackendImpl::openCursor):
298         (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
299         (WebCore::IDBObjectStoreBackendImpl::count):
300         (WebCore::IDBObjectStoreBackendImpl::countInternal):
301         * storage/IDBRequest.cpp:
302         (WebCore::IDBRequest::onSuccess):
303         (WebCore::IDBRequest::onSuccessWithContinuation):
304         (WebCore::IDBRequest::dispatchEvent):
305         * storage/IDBTracing.h: Added.
306         * storage/IDBTransaction.cpp:
307         (WebCore::IDBTransaction::dispatchEvent):
308         * storage/IDBTransactionBackendImpl.cpp:
309         (WebCore::IDBTransactionBackendImpl::abort):
310         (WebCore::IDBTransactionBackendImpl::commit):
311         (WebCore::IDBTransactionBackendImpl::taskTimerFired):
312         (WebCore::IDBTransactionBackendImpl::taskEventTimerFired):
313
314 2012-02-22  Dana Jansens  <danakj@chromium.org>
315
316         [chromium] Push CCLayerIteratorPosition struct into CCLayerIterator class.
317         https://bugs.webkit.org/show_bug.cgi?id=75864
318
319         Reviewed by James Robinson.
320
321         * platform/graphics/chromium/cc/CCLayerIterator.cpp:
322         (WebCore::CCLayerIteratorActions::BackToFront::begin):
323         (WebCore::CCLayerIteratorActions::BackToFront::end):
324         (WebCore::CCLayerIteratorActions::BackToFront::next):
325         (WebCore::CCLayerIteratorActions::FrontToBack::begin):
326         (WebCore::CCLayerIteratorActions::FrontToBack::end):
327         (WebCore::CCLayerIteratorActions::FrontToBack::next):
328         (WebCore::CCLayerIteratorActions::FrontToBack::goToHighestInSubtree):
329         * platform/graphics/chromium/cc/CCLayerIterator.h:
330         (WebCore::CCLayerIterator::CCLayerIterator):
331         (WebCore::CCLayerIterator::operator++):
332         (WebCore::CCLayerIterator::operator==):
333         (WebCore::CCLayerIterator::operator->):
334         (WebCore::CCLayerIterator::operator*):
335         (WebCore::CCLayerIterator::representsTargetRenderSurface):
336         (WebCore::CCLayerIterator::representsContributingRenderSurface):
337         (WebCore::CCLayerIterator::currentLayer):
338         (WebCore::CCLayerIterator::currentLayerRepresentsContributingRenderSurface):
339         (WebCore::CCLayerIterator::currentLayerRepresentsTargetRenderSurface):
340         (WebCore::CCLayerIterator::targetRenderSurfaceLayer):
341         (WebCore::CCLayerIterator::targetRenderSurface):
342         (WebCore::CCLayerIterator::targetRenderSurfaceChildren):
343         * platform/graphics/chromium/cc/CCLayerIteratorPosition.h: Removed.
344
345 2012-02-22  Pavel Feldman  <pfeldman@google.com>
346
347         Web Inspector: console doesn't show properly arrays from which tail values have been deleted
348         https://bugs.webkit.org/show_bug.cgi?id=79242
349
350         Reviewed by Yury Semikhatsky.
351
352         * English.lproj/localizedStrings.js:
353         * inspector/front-end/ConsoleMessage.js:
354         (WebInspector.ConsoleMessageImpl.prototype._printArray.appendUndefined):
355         (WebInspector.ConsoleMessageImpl.prototype._printArray):
356
357 2012-02-22  Pavel Feldman  <pfeldman@google.com>
358
359         Web Inspector: warning external font mime (font/font/woff).
360         https://bugs.webkit.org/show_bug.cgi?id=79244
361
362         Reviewed by Yury Semikhatsky.
363
364         * inspector/front-end/Resource.js:
365
366 2012-02-22  Yury Semikhatsky  <yurys@chromium.org>
367
368         Web Inspector: use dots as markers on the counter graphs
369         https://bugs.webkit.org/show_bug.cgi?id=79243
370
371         Changed counter graphs marker and counter text styles.
372
373         Reviewed by Pavel Feldman.
374
375         * English.lproj/localizedStrings.js:
376         * inspector/front-end/MemoryStatistics.js:
377         (WebInspector.MemoryStatistics):
378         (WebInspector.MemoryStatistics.prototype._createCounterSidebarElement):
379         (WebInspector.MemoryStatistics.prototype.addTimlineEvent):
380         (WebInspector.MemoryStatistics.prototype._draw):
381         (WebInspector.MemoryStatistics.prototype._onMouseOut):
382         (WebInspector.MemoryStatistics.prototype._onMouseOver):
383         (WebInspector.MemoryStatistics.prototype._onMouseMove):
384         (WebInspector.MemoryStatistics.prototype._refreshCurrentValues):
385         (WebInspector.MemoryStatistics.prototype._recordIndexAt):
386         (WebInspector.MemoryStatistics.prototype._highlightCurrentPositionOnGraphs):
387         (WebInspector.MemoryStatistics.prototype._clearMarkers):
388         (WebInspector.MemoryStatistics.prototype._saveImageUnderMarker):
389         (WebInspector.MemoryStatistics.prototype.refresh):
390         (WebInspector.MemoryStatistics.prototype._drawPolyline):
391         (WebInspector.MemoryStatistics.prototype._clear):
392         * inspector/front-end/timelinePanel.css:
393         (.memory-counter-sidebar-info):
394         (.memory-counter-sidebar-info .title):
395         (.memory-counter-sidebar-info .counter-value):
396
397 2012-02-22  Pavel Feldman  <pfeldman@google.com>
398
399         Web Inspector: make 'glue asynchronous events' optional.
400         https://bugs.webkit.org/show_bug.cgi?id=79240
401
402         Reviewed by Yury Semikhatsky.
403
404         * English.lproj/localizedStrings.js:
405         * inspector/front-end/Images/statusbarButtonGlyphs.png:
406         * inspector/front-end/TimelinePanel.js:
407         (WebInspector.TimelinePanel.prototype.get statusBarItems):
408         (WebInspector.TimelinePanel.prototype._createStatusbarButtons):
409         (WebInspector.TimelinePanel.prototype._glueParentButtonClicked):
410         (WebInspector.TimelinePanel.prototype._toggleStartAtZeroButtonClicked):
411         (WebInspector.TimelinePanel.prototype._repopulateRecords):
412         (WebInspector.TimelinePanel.prototype._findParentRecord):
413         (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
414         (WebInspector.TimelinePanel.prototype.sidebarResized):
415         (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
416         (WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition):
417         (WebInspector.TimelineRecordGraphRow):
418         (WebInspector.TimelineRecordGraphRow.prototype.update):
419         (WebInspector.TimelinePanel.FormattedRecord.prototype._calculateAggregatedStats):
420         * inspector/front-end/timelinePanel.css:
421         (.glue-async-status-bar-item .glyph):
422         (.timeline-start-at-zero-status-bar-item .glyph):
423
424 2012-02-22  Vsevolod Vlasov  <vsevik@chromium.org>
425
426         Web Inspector: [REGRESSION] Console xhr logging is broken for async xhrs since r107672.
427         https://bugs.webkit.org/show_bug.cgi?id=79229
428
429         Reviewed by Pavel Feldman.
430
431         Test: http/tests/inspector/console-xhr-logging-async.html
432
433         * inspector/InspectorResourceAgent.cpp:
434         (WebCore::InspectorResourceAgent::setInitialScriptContent):
435         * xml/XMLHttpRequest.cpp:
436         (WebCore::XMLHttpRequest::didFinishLoading):
437
438 2012-02-22  Andrey Kosyakov  <caseq@chromium.org>
439
440         Web Inspector: fix memory counters and start-at-zero modes of timeline panels to co-exist nicely
441         https://bugs.webkit.org/show_bug.cgi?id=79241
442
443         Reviewed by Yury Semikhatsky.
444
445         * inspector/front-end/MemoryStatistics.js:
446         (WebInspector.MemoryStatistics.prototype.addTimlineEvent):
447         * inspector/front-end/TimelineOverviewPane.js:
448         (WebInspector.TimelineOverviewPane):
449         (WebInspector.TimelineOverviewPane.prototype._showTimelines):
450         (WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
451         (WebInspector.TimelineOverviewPane.prototype.setStartAtZero):
452         (WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
453         * inspector/front-end/TimelinePanel.js:
454         (WebInspector.TimelinePanel.prototype._timelinesOverviewModeChanged):
455
456 2012-02-22  Andrey Kosyakov  <caseq@chromium.org>
457
458         Web Inspector: [experimental] add a mode to display timeline events aligned by the start time
459         https://bugs.webkit.org/show_bug.cgi?id=79123
460
461         Reviewed by Pavel Feldman.
462
463         * inspector/front-end/Images/statusbarButtonGlyphs.png:
464         * inspector/front-end/Settings.js:
465         (WebInspector.ExperimentsSettings):
466         * inspector/front-end/TimelineOverviewPane.js:
467         (WebInspector.TimelineOverviewPane):
468         (WebInspector.TimelineOverviewPane.prototype._showTimelines):
469         (WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
470         (WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
471         (WebInspector.TimelineOverviewPane.prototype.setStartAtZero):
472         (WebInspector.TimelineOverviewPane.prototype.update):
473         (WebInspector.TimelineOverviewPane.prototype.reset):
474         (WebInspector.TimelineOverviewWindow):
475         (WebInspector.TimelineOverviewWindow.prototype.reset):
476         (WebInspector.TimelineOverviewWindow.prototype._setWindowPosition):
477         (WebInspector.TimelineOverviewWindow.prototype.scrollWindow):
478         (WebInspector.TimelineStartAtZeroOverview):
479         (WebInspector.TimelineStartAtZeroOverview.prototype.reset):
480         (WebInspector.TimelineStartAtZeroOverview.prototype.update):
481         (WebInspector.TimelineStartAtZeroOverview.prototype._filterRecords):
482         (WebInspector.TimelineStartAtZeroOverview.prototype._buildBar):
483         (WebInspector.TimelineStartAtZeroOverview.prototype._onWindowChanged):
484         * inspector/front-end/TimelinePanel.js:
485         (WebInspector.TimelinePanel.prototype.get statusBarItems):
486         (WebInspector.TimelinePanel.prototype._createStatusbarButtons):
487         (WebInspector.TimelinePanel.prototype._toggleStartAtZeroButtonClicked):
488         (WebInspector.TimelinePanel.prototype.get _startAtZero):
489         (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
490         (WebInspector.TimelinePanel.prototype.sidebarResized):
491         (WebInspector.TimelinePanel.prototype._onRecordsCleared):
492         (WebInspector.TimelinePanel.prototype._resetPanel):
493         (WebInspector.TimelinePanel.prototype._scheduleRefresh):
494         (WebInspector.TimelinePanel.prototype._refresh):
495         (WebInspector.TimelinePanel.prototype._filterRecords):
496         (WebInspector.TimelinePanel.prototype._refreshRecords):
497         (WebInspector.TimelineCalculator.prototype.computeBarGraphWindowPosition):
498         (WebInspector.TimelineStartAtZeroCalculator):
499         (WebInspector.TimelineStartAtZeroCalculator.prototype.computeBarGraphPercentages):
500         (WebInspector.TimelineStartAtZeroCalculator.prototype.computeBarGraphWindowPosition):
501         (WebInspector.TimelineStartAtZeroCalculator.prototype.calculateWindow):
502         (WebInspector.TimelineStartAtZeroCalculator.prototype.reset):
503         (WebInspector.TimelineStartAtZeroCalculator.prototype.updateBoundaries):
504         (WebInspector.TimelineStartAtZeroCalculator.prototype.formatValue):
505         (WebInspector.TimelinePanel.FormattedRecord):
506         (WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo):
507         (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
508         (WebInspector.TimelinePanel.FormattedRecord.prototype._calculateAggregatedStats):
509         (WebInspector.TimelinePanel.FormattedRecord.prototype.get aggregatedStats):
510         (WebInspector.TimelineModel.prototype.get records):
511         (WebInspector.TimelinePresentationModel):
512         (WebInspector.TimelinePresentationModel.prototype.reset):
513         (WebInspector.TimelinePresentationModel.prototype.setWindowIndices):
514         (WebInspector.TimelineRecordFilter):
515         (WebInspector.TimelineRecordFilter.prototype.accept):
516         (WebInspector.TimelineStartAtZeroRecordFilter):
517         (WebInspector.TimelineStartAtZeroRecordFilter.prototype.accept):
518         * inspector/front-end/timelinePanel.css:
519         (.timeline-start-at-zero #timeline-overview-sidebar):
520         (.timeline-start-at-zero #timeline-overview-grid):
521         (.timeline-overview-window):
522         (.timeline-start-at-zero .timeline-overview-window):
523         (.timeline-start-at-zero .timeline-overview-dividers-background):
524         (.timeline-overview-window-rulers):
525         (.timeline-start-at-zero #timeline-overview-memory):
526         (.popover .timeline-loading):
527         (.popover .timeline-scripting):
528         (.popover .timeline-rendering):
529         (.timeline-start-at-zero-status-bar-item .glyph):
530         (.timeline-start-at-zero-status-bar-item.toggled-on .glyph):
531         (.timeline-overview-start-at-zero):
532         (.timeline-overview-start-at-zero-bars):
533         (.timeline-overview-start-at-zero-bars .padding):
534         (.timeline-overview-start-at-zero-bars .timeline-bar-vertical):
535         (.timeline-bar-vertical div:first-child):
536         (.timeline-bar-vertical .timeline-loading):
537         (.timeline-bar-vertical .timeline-scripting):
538         (.timeline-bar-vertical .timeline-rendering):
539
540 2012-02-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
541
542         [Qt] Disregard previous backing store as soon as possible
543         https://bugs.webkit.org/show_bug.cgi?id=79232
544
545         Reviewed by Simon Hausmann and No'am Rosenthal.
546
547         Make it possible to drop non-visible tiles and to test
548         if the current visible rect is fully covered.
549
550         * platform/graphics/TiledBackingStore.cpp:
551         (WebCore::TiledBackingStore::visibleContentsRect):
552         (WebCore::TiledBackingStore::coverageRatio):
553         (WebCore::TiledBackingStore::visibleAreaIsCovered):
554         (WebCore):
555         (WebCore::TiledBackingStore::createTiles):
556         (WebCore::TiledBackingStore::removeAllNonVisibleTiles):
557         * platform/graphics/TiledBackingStore.h:
558         (TiledBackingStore):
559
560 2012-02-22  Simon Hausmann  <simon.hausmann@nokia.com>
561
562         [Qt] Move QMenu dependant scrollbar context menu handling out of WebCore
563         https://bugs.webkit.org/show_bug.cgi?id=79233
564
565         Reviewed by Kenneth Rohde Christiansen.
566
567         Move the code into WebKit/qt/Api/qwebpage.cpp, the only place where it is called from.
568
569         * Target.pri: Remove ScrollbarQt.cpp from build.
570         * platform/Scrollbar.h: Remove Qt-only context menu handling but make moveThum
571         accessible from the outside.
572         * platform/qt/ScrollbarQt.cpp: Removed. Not needed anymore.
573
574 2012-02-22  Vsevolod Vlasov  <vsevik@chromium.org>
575
576         Web Inspector: retrieving content for some XHR requests crashes inspected page renderer
577         https://bugs.webkit.org/show_bug.cgi?id=79026
578
579         Reviewed by Pavel Feldman.
580
581         Fixed loading empty xhr content and xhr content decoding that was
582         broken in r107672.
583
584         Tests: http/tests/inspector/network/network-cyrillic-xhr.html
585                http/tests/inspector/network/network-empty-xhr.html
586
587         * inspector/InspectorPageAgent.cpp:
588         (WebCore):
589         (WebCore::InspectorPageAgent::createDecoder):
590         (WebCore::InspectorPageAgent::cachedResourceContent):
591         * inspector/InspectorPageAgent.h:
592         (WebCore):
593         * inspector/NetworkResourcesData.cpp:
594         (WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
595         (WebCore::NetworkResourcesData::responseReceived):
596         * inspector/NetworkResourcesData.h:
597         (WebCore::NetworkResourcesData::ResourceData::decoder):
598         (WebCore::NetworkResourcesData::ResourceData::setDecoder):
599
600 2012-02-22  Peter Rybin  <peter.rybin@gmail.com>
601
602         Web Inspector: CodeGeneratorInspector.py: remove neural-net-style constructions
603         https://bugs.webkit.org/show_bug.cgi?id=79153
604
605         Reviewed by Yury Semikhatsky.
606
607         CParamType class removed completely, some ("virtual") methods are
608         removed. TypeModel notion is added instead with some minor helper
609         classes and methods.
610
611         * inspector/CodeGeneratorInspector.py:
612         (DomainNameFixes):
613         (RawTypes.BaseType):
614         (RawTypes.String):
615         (RawTypes.String.get_raw_type_model):
616         (RawTypes.Int):
617         (RawTypes.Int.get_raw_type_model):
618         (RawTypes.Number):
619         (RawTypes.Number.get_raw_type_model):
620         (RawTypes.Bool):
621         (RawTypes.Bool.get_raw_type_model):
622         (RawTypes.Object):
623         (RawTypes.Object.get_raw_type_model):
624         (RawTypes.Any):
625         (RawTypes.Any.get_raw_type_model):
626         (RawTypes.Array):
627         (RawTypes.Array.get_raw_type_model):
628         (replace_right_shift):
629         (CommandReturnPassModel):
630         (CommandReturnPassModel.ByReference):
631         (CommandReturnPassModel.ByReference.__init__):
632         (CommandReturnPassModel.ByReference.get_return_var_type):
633         (CommandReturnPassModel.get_output_argument_prefix):
634         (CommandReturnPassModel.get_output_to_raw_expression):
635         (CommandReturnPassModel.get_output_parameter_type):
636         (CommandReturnPassModel.get_set_return_condition):
637         (CommandReturnPassModel.ByPointer):
638         (CommandReturnPassModel.ByPointer.__init__):
639         (CommandReturnPassModel.ByPointer.get_return_var_type):
640         (TypeModel):
641         (TypeModel.RefPtrBased):
642         (TypeModel.RefPtrBased.__init__):
643         (TypeModel.RefPtrBased.get_optional):
644         (TypeModel.RefPtrBased.get_command_return_pass_model):
645         (TypeModel.RefPtrBased.get_input_param_type_text):
646         (TypeModel.RefPtrBased.get_event_setter_expression_pattern):
647         (TypeModel.Enum):
648         (TypeModel.Enum.__init__):
649         (TypeModel.Enum.get_optional):
650         (TypeModel.Enum.get_optional.EnumOptional):
651         (TypeModel.Enum.get_optional.EnumOptional.get_optional):
652         (TypeModel.Enum.get_optional.EnumOptional.get_command_return_pass_model):
653         (TypeModel.Enum.get_input_param_type_text):
654         (TypeModel.Enum.get_event_setter_expression_pattern):
655         (TypeModel.Enum.get_command_return_pass_model):
656         (TypeModel.ValueType):
657         (TypeModel.ValueType.__init__):
658         (TypeModel.ValueType.get_optional):
659         (TypeModel.ValueType.get_command_return_pass_model):
660         (TypeModel.ValueType.get_input_param_type_text):
661         (TypeModel.ValueType.get_event_setter_expression_pattern):
662         (TypeModel.ValueType.ValueOptional):
663         (TypeModel.ValueType.ValueOptional.__init__):
664         (TypeModel.ValueType.ValueOptional.get_optional):
665         (TypeModel.ValueType.ValueOptional.get_command_return_pass_model):
666         (TypeModel.ValueType.ValueOptional.get_input_param_type_text):
667         (TypeModel.ValueType.ValueOptional.get_event_setter_expression_pattern):
668         (TypeModel.init_class):
669         (TypeBindings.create_ad_hoc_type_declaration.Helper):
670         (TypeBindings.create_type_declaration_.EnumBinding.get_array_item_c_type_text):
671         (TypeBindings.create_type_declaration_.EnumBinding.get_setter_value_expression_pattern):
672         (TypeBindings.create_type_declaration_.EnumBinding):
673         (TypeBindings.create_type_declaration_.EnumBinding.get_type_model):
674         (TypeBindings.create_type_declaration_):
675         (TypeBindings.create_type_declaration_.get_type_model):
676         (TypeBindings.create_type_declaration_.get_array_item_c_type_text):
677         (get_type_model):
678         (AdHocTypeContextImpl.__init__):
679         (PlainObjectBinding):
680         (PlainObjectBinding.get_type_model):
681         (AdHocTypeContext):
682         (ArrayBinding.get_array_item_c_type_text):
683         (ArrayBinding):
684         (ArrayBinding.get_type_model):
685         (RawTypeBinding.get_validator_call_text):
686         (RawTypeBinding.reduce_to_raw_type):
687         (RawTypeBinding):
688         (RawTypeBinding.get_type_model):
689         (MethodGenerateModes.StrictParameterMode.get_c_param_type_text):
690         (MethodGenerateModes.RawParameterMode.get_c_param_type_text):
691         (MethodGenerateModes.CombinedMode.get_c_param_type_text):
692         (Generator.go):
693         (Generator.process_event):
694         (Generator.process_command):
695         (Generator.resolve_type_and_generate_ad_hoc):
696         (Generator.resolve_type_and_generate_ad_hoc.AdHocTypeContext):
697         * inspector/InspectorDebuggerAgent.cpp:
698         (WebCore::InspectorDebuggerAgent::didParseSource):
699
700 2012-02-21  Vsevolod Vlasov  <vsevik@chromium.org>
701
702         Web Inspector: [InspectorIndexedDB] Show IndexedDB views on selection IndexedDB elements in resources panel.
703         https://bugs.webkit.org/show_bug.cgi?id=79098
704
705         Reviewed by Pavel Feldman.
706
707         * English.lproj/localizedStrings.js:
708         * WebCore.gypi:
709         * WebCore.vcproj/WebCore.vcproj:
710         * inspector/InspectorIndexedDBAgent.cpp:
711         (WebCore):
712         * inspector/compile-front-end.sh:
713         * inspector/front-end/IndexedDBModel.js:
714         (WebInspector.IndexedDBModel.prototype._assertFrameId):
715         (WebInspector.IndexedDBModel.prototype.loadObjectStoreData):
716         (WebInspector.IndexedDBModel.prototype.loadIndexData):
717         * inspector/front-end/IndexedDBViews.js: Added.
718         * inspector/front-end/ObjectPropertiesSection.js:
719         (WebInspector.ObjectPropertiesSection):
720         (WebInspector.ObjectPropertiesSection.prototype.updateProperties):
721         * inspector/front-end/ResourcesPanel.js:
722         (WebInspector.ResourcesPanel.prototype.showIndexedDB):
723         (WebInspector.IndexedDBTreeElement.prototype.refreshIndexedDB):
724         (WebInspector.IndexedDBTreeElement.prototype._indexedDBAdded):
725         (WebInspector.IDBDatabaseTreeElement):
726         (WebInspector.IDBDatabaseTreeElement.prototype.get itemURL):
727         (WebInspector.IDBDatabaseTreeElement.prototype.update):
728         (WebInspector.IDBDatabaseTreeElement.prototype.onselect):
729         (WebInspector.IDBObjectStoreTreeElement):
730         (WebInspector.IDBObjectStoreTreeElement.prototype.get itemURL):
731         (WebInspector.IDBObjectStoreTreeElement.prototype.update):
732         (WebInspector.IDBObjectStoreTreeElement.prototype.onselect):
733         (WebInspector.IDBIndexTreeElement):
734         (WebInspector.IDBIndexTreeElement.prototype.get itemURL):
735         (WebInspector.IDBIndexTreeElement.prototype.update):
736         (WebInspector.IDBIndexTreeElement.prototype.onselect):
737         * inspector/front-end/WebKit.qrc:
738         * inspector/front-end/externs.js:
739         * inspector/front-end/indexedDBViews.css: Added.
740         * inspector/front-end/inspector.html:
741
742 2012-02-22  Nikolas Zimmermann  <nzimmermann@rim.com>
743
744         REGRESSION(58212): html foreignObjects with positions other than static not hidden correctly when parent has display:none
745         https://bugs.webkit.org/show_bug.cgi?id=41386
746
747         Reviewed by Zoltan Herczeg.
748
749         r58212 gave SVGGElements a renderer, regardless if "display: none" was set or not, for various reasons (see change set).
750         The <g> renderer for such cases is a RenderSVGHiddenContainer. We make sure in SVG that such subtrees are never used
751         for painting & hittesting - they only exist for the purpose of SVG DOM (query getCTM, etc..) and to create renderers
752         for child resources, like <g display="none"><linearGradient>.
753
754         This concept still works fine for: <g display="none"><foreignObject><body>Foobar</body></foreignObject></g>, as
755         RenderSVGForeignObject::paint is never called thus we never paint the subtree of the <fO>. If the <body> elements
756         contains "position: relative" a new layer is created for the <body>. When the document paints we have two seperated
757         layers, and the <body> layer doesn't know that it's actually inside a "SVG hidden subtree", and gets painted, where it
758         shouldn't. HTML doesn't have this problems, as a display: none object, never creates a renderer.
759
760         The fix is to disallow layer creation in hidden SVG subtrees, to mimic what would happen if we'd follow HTML rules
761         to not create renderers for display: none objects. This avoids any indirections - as no layers are created anymore.
762
763         Tests: svg/foreignObject/fO-display-none-with-relative-pos-content.svg
764                svg/foreignObject/fO-display-none.svg
765                svg/foreignObject/fO-parent-display-changes.svg
766                svg/foreignObject/fO-parent-display-none-with-relative-pos-content.svg
767                svg/foreignObject/fO-parent-display-none.svg
768                svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content.svg
769                svg/foreignObject/fO-parent-of-parent-display-none.svg
770
771         * rendering/RenderBoxModelObject.cpp:
772         (WebCore::RenderBoxModelObject::styleDidChange): Only create layers, if its allowed -- layerCreationAllowedForSubtree() will always return true for HTML, and only false for layers inside a hidden SVG subtree.
773         * rendering/RenderObject.cpp:
774         (WebCore::RenderObject::addChild): Only create layers, if its allowed.
775         * rendering/RenderObject.h: Add inline layerCreationAllowedForSubtree() helper, that craws the tree to find a RenderSVGHiddenContainer ancestor, if not present, return true.
776
777 2012-02-22  Zoltan Herczeg  <zherczeg@webkit.org>
778
779         Drop clipToImageBuffer from RenderBoxModelObject
780         https://bugs.webkit.org/show_bug.cgi?id=79225
781
782         Reviewed by Nikolas Zimmermann.
783
784         -webkit-background-clip: text is a rarely used non-standard
785         feature uses clipToImageBuffer. It is replaced by
786         CompositeDestinationIn on a transparent layer. The new
787         approach has the same speed as the old one.
788
789         Existing tests cover this issue.
790
791         * rendering/RenderBoxModelObject.cpp:
792         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
793
794 2012-02-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
795
796         Merge setVisibleRectTrajectoryVector and adjustVisibleRect to
797         the more descriptive coverWithTilesIfNeeded
798         https://bugs.webkit.org/show_bug.cgi?id=79230
799
800         Reviewed by Simon Hausmann.
801
802         Both setVisibleRectTrajectoryVector and the adjustVisibleRect are
803         used for initiating re-tiling, so make that more obvious and merge
804         the two.
805
806         * platform/graphics/TiledBackingStore.cpp:
807         (WebCore::TiledBackingStore::coverWithTilesIfNeeded):
808         * platform/graphics/TiledBackingStore.h:
809         (TiledBackingStore):
810
811 2012-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>
812
813         REGRESSION: unbalanced transparency layers for clipPath
814         https://bugs.webkit.org/show_bug.cgi?id=78074
815
816         Reviewed by Zoltan Herczeg.
817
818         If we're rendering to a mask image buffer, all children are rendered with opacity=1, regardless what their RenderStyles specify.
819         SVGRenderSupport::finishRenderSVGContent() did not take this into account and always called endTransparencyLayer(). Fix that
820         by checking if we're rendering to a mask image buffer, if so don't call endTransparencyLayer().
821
822         Add new reftest covering both the visual & logical correctness (no assertion).
823
824         Tests: svg/clip-path/opacity-assertion-expected.svg
825                svg/clip-path/opacity-assertion.svg
826
827         * rendering/svg/SVGRenderSupport.cpp:
828         (WebCore::isRenderingMaskImage): Extraced as sharable helper function.
829         (WebCore::SVGRenderSupport::prepareToRenderSVGContent): Factor out isRenderingMaskImage() function.
830         (WebCore::SVGRenderSupport::finishRenderSVGContent): Only call endTransparencyLayer(), if we actually called beginTL() first. 
831
832 2012-02-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
833
834         Improve comments in tiling code.
835
836         Rubberstamped by Simon Hausmann.
837
838         * platform/graphics/TiledBackingStore.cpp:
839         (WebCore::TiledBackingStore::createTiles):
840
841 2012-02-22  'Pavel Feldman'  <pfeldman@google.com>
842
843         Not reviewed: build fix.
844
845         * inspector/InspectorController.cpp:
846         * inspector/InspectorController.h:
847         (InspectorController):
848
849 2012-02-21  Pavel Feldman  <pfeldman@google.com>
850
851         Web Inspector: do not filter out requestAnimationFrame from timeline, implement stop on animation events.
852         https://bugs.webkit.org/show_bug.cgi?id=79116
853
854         Reviewed by Yury Semikhatsky.
855
856         * English.lproj/localizedStrings.js:
857         * dom/ScriptedAnimationController.cpp:
858         (WebCore::ScriptedAnimationController::registerCallback):
859         * inspector/InspectorInstrumentation.cpp:
860         (WebCore):
861         (WebCore::InspectorInstrumentation::didRequestAnimationFrameCallbackImpl):
862         (WebCore::InspectorInstrumentation::didCancelAnimationFrameCallbackImpl):
863         (WebCore::InspectorInstrumentation::willFireAnimationFrameEventImpl):
864         * inspector/InspectorInstrumentation.h:
865         (InspectorInstrumentation):
866         (WebCore::InspectorInstrumentation::didRequestAnimationFrameCallback):
867         * inspector/InspectorTimelineAgent.cpp:
868         (TimelineRecordType):
869         (WebCore::InspectorTimelineAgent::didRequestAnimationFrameCallback):
870         (WebCore::InspectorTimelineAgent::didCancelAnimationFrameCallback):
871         (WebCore::InspectorTimelineAgent::willFireAnimationFrameEvent):
872         (WebCore::InspectorTimelineAgent::didFireAnimationFrameEvent):
873         * inspector/InspectorTimelineAgent.h:
874         (InspectorTimelineAgent):
875         * inspector/front-end/BreakpointsSidebarPane.js:
876         (WebInspector.EventListenerBreakpointsSidebarPane):
877         (WebInspector.EventListenerBreakpointsSidebarPane.eventNameForUI):
878         * inspector/front-end/TimelineAgent.js:
879         * inspector/front-end/TimelinePanel.js:
880         (WebInspector.TimelinePanel):
881         (WebInspector.TimelinePanel.prototype.get _recordStyles):
882         (WebInspector.TimelinePanel.prototype._findParentRecord):
883         (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
884         (WebInspector.TimelinePanel.prototype._onRecordsCleared):
885         (WebInspector.TimelinePanel.FormattedRecord):
886         (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
887         (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
888
889 2012-02-22  Changhun Kang  <temoochin@company100.net>
890
891         Remove unused class declaration in WebCore/page/scrolling/ScrollingCoordinator.h
892         https://bugs.webkit.org/show_bug.cgi?id=79175
893
894         Reviewed by Kentaro Hara.
895
896         * page/scrolling/ScrollingCoordinator.h:
897         Remove PlatformGestureEvent class declaration.
898         (WebCore):
899
900 2012-02-22  Andras Becsi  <andras.becsi@nokia.com>
901
902         [Qt][WK2] Fix the N9 build
903         https://bugs.webkit.org/show_bug.cgi?id=79101
904
905         Reviewed by Simon Hausmann.
906
907         Fixed the include order of the rolled out r108359 not to break
908         the build with CONFIG+=force_static_libs_as_shared.
909
910         * platform/graphics/OpenGLShims.h: Add missing include.
911
912 2012-02-22  Shinya Kawanaka  <shinyak@chromium.org>
913
914         firstRendererOf() should also return a fallback element renderer in NodeRenderingContext.
915         https://bugs.webkit.org/show_bug.cgi?id=79180
916
917         Reviewed by Hajime Morita.
918
919         Currently we have handled AttachingFallback in some special mannger, however if firstRendererOf
920         and lastRendererOf return a fallback element renderer, we don't need to handle it in such a manner.
921
922         We have introduced new attaching phase: AttachingFallbacked, and AttachingNotFallbacked.
923         They are used for fallback elements.
924
925         Added new test cases in:
926           fast/dom/shadow/shadow-contents-fallback.html
927           fast/dom/shadow/shadow-contents-fallback-dynamic.html
928
929         * dom/NodeRenderingContext.cpp:
930         (WebCore::NodeRenderingContext::NodeRenderingContext):
931         (WebCore::firstRendererOf):
932         (WebCore::lastRendererOf):
933         (WebCore::NodeRenderingContext::nextRenderer):
934         (WebCore::NodeRenderingContext::previousRenderer):
935         (WebCore::NodeRenderingContext::shouldCreateRenderer):
936         * dom/NodeRenderingContext.h:
937         * html/shadow/InsertionPoint.h:
938         (WebCore::isInsertionPoint):
939         (WebCore):
940         (WebCore::toInsertionPoint):
941
942 2012-02-22  Csaba Osztrogonác  <ossy@webkit.org>
943
944         [Qt] Unreviewed gardening after r108464.
945
946         * Target.pri:
947
948 2012-02-22  Sheriff Bot  <webkit.review.bot@gmail.com>
949
950         Unreviewed, rolling out r108468.
951         http://trac.webkit.org/changeset/108468
952         https://bugs.webkit.org/show_bug.cgi?id=79219
953
954         Broke Chromium Win release build (Requested by bashi on
955         #webkit).
956
957         * CMakeLists.txt:
958         * GNUmakefile.list.am:
959         * Target.pri:
960         * WebCore.gypi:
961         * WebCore.vcproj/WebCore.vcproj:
962         * WebCore.xcodeproj/project.pbxproj:
963         * websockets/WebSocket.cpp:
964         (WebCore::WebSocket::didConnect):
965         * websockets/WebSocketChannel.cpp:
966         (WebCore::WebSocketChannel::connect):
967         (WebCore::WebSocketChannel::fail):
968         (WebCore::WebSocketChannel::processFrame):
969         (WebCore::WebSocketChannel::sendFrame):
970         * websockets/WebSocketChannel.h:
971         * websockets/WebSocketDeflateFramer.cpp: Removed.
972         * websockets/WebSocketDeflateFramer.h: Removed.
973
974 2012-02-20  Roland Steiner  <rolandsteiner@chromium.org>
975
976         <style scoped>: Add runtime-flag
977         https://bugs.webkit.org/show_bug.cgi?id=79074
978
979         Added runtime-flag.
980         Query runtime flag when (un)registering a <style scoped> element, and when determineing a style sheet's scope.
981
982         Reviewed by Dimitri Glazkov.
983
984         No new tests. (no change in functionality)
985
986         * bindings/generic/RuntimeEnabledFeatures.cpp:
987         (WebCore):
988         * bindings/generic/RuntimeEnabledFeatures.h:
989         (RuntimeEnabledFeatures):
990         (WebCore::RuntimeEnabledFeatures::styleScopedEnabled):
991         (WebCore::RuntimeEnabledFeatures::setStyleScopedEnabled):
992         * css/CSSStyleSelector.cpp:
993         (WebCore::CSSStyleSelector::determineScopingElement):
994         * html/HTMLStyleElement.cpp:
995         (WebCore::HTMLStyleElement::registerWithScopingNode):
996         (WebCore::HTMLStyleElement::unregisterWithScopingNode):
997         * html/HTMLStyleElement.idl:
998
999 2012-02-21  Alexander Pavlov  <apavlov@chromium.org>
1000
1001         Web Inspector: Audit rules to recommend unprefixing supported CSS properties
1002         https://bugs.webkit.org/show_bug.cgi?id=78985
1003
1004         Reviewed by Pavel Feldman.
1005
1006         * inspector/front-end/AuditCategories.js:
1007         (WebInspector.AuditCategories.PagePerformance.prototype.initialize):
1008         * inspector/front-end/AuditRules.js:
1009         (WebInspector.AuditRules.CSSRuleBase):
1010         (WebInspector.AuditRules.CSSRuleBase.prototype.doRun.sheetsCallback):
1011         (WebInspector.AuditRules.CSSRuleBase.prototype.doRun):
1012         (WebInspector.AuditRules.CSSRuleBase.prototype._visitStyleSheet.sheetCallback):
1013         (WebInspector.AuditRules.CSSRuleBase.prototype._visitStyleSheet):
1014         (WebInspector.AuditRules.CSSRuleBase.prototype._visitRule):
1015         (WebInspector.AuditRules.CSSRuleBase.prototype.visitStyleSheet):
1016         (WebInspector.AuditRules.CSSRuleBase.prototype.didVisitStyleSheet):
1017         (WebInspector.AuditRules.CSSRuleBase.prototype.visitRule):
1018         (WebInspector.AuditRules.CSSRuleBase.prototype.didVisitRule):
1019         (WebInspector.AuditRules.CSSRuleBase.prototype.visitProperty):
1020         (WebInspector.AuditRules.VendorPrefixedCSSProperties):
1021         (WebInspector.AuditRules.VendorPrefixedCSSProperties.prototype.didVisitStyleSheet):
1022         (WebInspector.AuditRules.VendorPrefixedCSSProperties.prototype.visitRule):
1023         (WebInspector.AuditRules.VendorPrefixedCSSProperties.prototype.didVisitRule):
1024         (WebInspector.AuditRules.VendorPrefixedCSSProperties.prototype.visitProperty):
1025         * inspector/front-end/ResourceUtils.js:
1026
1027 2012-02-22  Shinya Kawanaka  <shinyak@chromium.org>
1028
1029         Node::attach() should be after attaching children in Element::attach().
1030         https://bugs.webkit.org/show_bug.cgi?id=79201
1031
1032         Reviewed by Hajime Morita.
1033
1034         In Element::attach(), Node::attach() is called before attaching children if a shaodw root exists.
1035         This may cause O(N^2) problem in NodeRenderingContext.
1036
1037         No new tests. Existing tests should cover this.
1038
1039         * dom/Element.cpp:
1040         (WebCore::Element::attach):
1041
1042 2012-02-22  Kenichi Ishibashi  <bashi@chromium.org>
1043
1044         Adding WebSocket per-frame DEFLATE extension
1045         https://bugs.webkit.org/show_bug.cgi?id=77522
1046
1047         Add WebSocketDeflateFramer class which handles deflate-frame extension.
1048         This class encapsulates WebSocketDeflater and WebSocketInflater classes,
1049         which depend on zlib, so that WebSocketChannel is not necessary to aware
1050         zlib dependency.
1051
1052         Reviewed by Kent Tamura.
1053
1054         Tests: http/tests/websocket/tests/hybi/compressed-control-frame.html
1055                http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html
1056                http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html
1057                http/tests/websocket/tests/hybi/deflate-frame-parameter.html
1058
1059         * CMakeLists.txt: Added WebSocketDeflateFramer.(cpp|h)
1060         * GNUmakefile.list.am: Ditto.
1061         * Target.pri: Ditto.
1062         * WebCore.gypi: Ditto.
1063         * WebCore.vcproj/WebCore.vcproj: Ditto.
1064         * WebCore.xcodeproj/project.pbxproj: Ditto.
1065         * websockets/WebSocket.cpp:
1066         (WebCore::WebSocket::didConnect): Set m_extensions.
1067         * websockets/WebSocketChannel.cpp:
1068         (WebCore::WebSocketChannel::connect): Add deflate-frame extension processor to WebSocketHanshake if deflate can use.
1069         (WebCore::WebSocketChannel::fail): Call m_deflateFramer.didFail().
1070         (WebCore::WebSocketChannel::processFrame): Decompress frames if needed.
1071         (WebCore::WebSocketChannel::sendFrame): Compress frames if possible.
1072         * websockets/WebSocketChannel.h:
1073         * websockets/WebSocketDeflateFramer.cpp: Added.
1074         (WebCore):
1075         (WebSocketExtensionDeflateFrame):
1076         (WebCore::WebSocketExtensionDeflateFrame::create):
1077         (WebCore::WebSocketExtensionDeflateFrame::~WebSocketExtensionDeflateFrame):
1078         (WebCore::WebSocketExtensionDeflateFrame::WebSocketExtensionDeflateFrame):
1079         (WebCore::WebSocketExtensionDeflateFrame::handshakeString):
1080         (WebCore::WebSocketExtensionDeflateFrame::processResponse):
1081         (WebCore::DeflateResultHolder::DeflateResultHolder):
1082         (WebCore::DeflateResultHolder::~DeflateResultHolder):
1083         (WebCore::DeflateResultHolder::fail):
1084         (WebCore::InflateResultHolder::InflateResultHolder):
1085         (WebCore::InflateResultHolder::~InflateResultHolder):
1086         (WebCore::InflateResultHolder::fail):
1087         (WebCore::WebSocketDeflateFramer::WebSocketDeflateFramer):
1088         (WebCore::WebSocketDeflateFramer::createExtensionProcessor):
1089         (WebCore::WebSocketDeflateFramer::canDeflate):
1090         (WebCore::WebSocketDeflateFramer::enableDeflate):
1091         (WebCore::WebSocketDeflateFramer::deflate):
1092         (WebCore::WebSocketDeflateFramer::resetDeflateContext):
1093         (WebCore::WebSocketDeflateFramer::inflate):
1094         (WebCore::WebSocketDeflateFramer::resetInflateContext):
1095         (WebCore::WebSocketDeflateFramer::didFail):
1096         * websockets/WebSocketDeflateFramer.h: Added.
1097         (WebCore):
1098         (DeflateResultHolder):
1099         (WebCore::DeflateResultHolder::succeeded):
1100         (WebCore::DeflateResultHolder::failureReason):
1101         (InflateResultHolder):
1102         (WebCore::InflateResultHolder::succeeded):
1103         (WebCore::InflateResultHolder::failureReason):
1104         (WebSocketDeflateFramer):
1105         (WebCore::WebSocketDeflateFramer::enabled):
1106
1107 2012-02-22  Yuta Kitamura  <yutak@chromium.org>
1108
1109         Unreviewed, rolling out r108453.
1110         http://trac.webkit.org/changeset/108453
1111         https://bugs.webkit.org/show_bug.cgi?id=78549
1112
1113         Broke Chromium's webkit_unit_tests.
1114
1115         * WebCore.gypi:
1116         * platform/graphics/chromium/cc/CCOcclusionTracker.cpp: Removed.
1117         * platform/graphics/chromium/cc/CCOcclusionTracker.h: Removed.
1118
1119 2012-02-22  Zoltan Herczeg  <zherczeg@webkit.org>
1120
1121         [Qt] clipToImageBuffer assertion fix in debug mode on Qt.
1122
1123         Rubber stamped by Csaba Osztrogonác.
1124
1125         * platform/graphics/qt/GraphicsContextQt.cpp:
1126         (WebCore::GraphicsContext::restorePlatformState):
1127
1128 2012-02-22  Adam Barth  <abarth@webkit.org>
1129
1130         [GTK] fast/frames/frame-dead-region.html crash
1131         https://bugs.webkit.org/show_bug.cgi?id=79205
1132
1133         Unreviewed.
1134
1135         Apparently we're not supposed to call willDetachPage from
1136         CachedFrame::destroy.  This call got added in
1137         http://trac.webkit.org/changeset/108428, but it seems to cause a crash.
1138
1139         * loader/FrameLoader.cpp:
1140         (WebCore::FrameLoader::closeAndRemoveChild):
1141         (WebCore::FrameLoader::detachFromParent):
1142         * page/Frame.h:
1143         (WebCore::Frame::detachFromPage):
1144         * page/Page.cpp:
1145         (WebCore::Page::~Page):
1146
1147 2012-02-22  Adam Barth  <abarth@webkit.org>
1148
1149         Move Geolocation code into Modules/geolocation
1150         https://bugs.webkit.org/show_bug.cgi?id=79204
1151
1152         Reviewed by Hajime Morita.
1153
1154         There are still some dangling references into the Geolocation module,
1155         which I will clean up in a followup patch.
1156
1157         * CMakeLists.txt:
1158         * DerivedSources.make:
1159         * DerivedSources.pri:
1160         * GNUmakefile.list.am:
1161         * Modules/geolocation/Geolocation.cpp: Copied from Source/WebCore/page/Geolocation.cpp.
1162         * Modules/geolocation/Geolocation.h: Copied from Source/WebCore/page/Geolocation.h.
1163         * Modules/geolocation/Geolocation.idl: Copied from Source/WebCore/page/Geolocation.idl.
1164         * Modules/geolocation/GeolocationController.cpp: Copied from Source/WebCore/page/GeolocationController.cpp.
1165         * Modules/geolocation/GeolocationController.h: Copied from Source/WebCore/page/GeolocationController.h.
1166         * Modules/geolocation/GeolocationError.h: Copied from Source/WebCore/page/GeolocationError.h.
1167         * Modules/geolocation/GeolocationPosition.h: Copied from Source/WebCore/page/GeolocationPosition.h.
1168         * Modules/geolocation/Geoposition.h: Copied from Source/WebCore/page/Geoposition.h.
1169         * Modules/geolocation/Geoposition.idl: Copied from Source/WebCore/page/Geoposition.idl.
1170         * Modules/geolocation/PositionCallback.h: Copied from Source/WebCore/page/PositionCallback.h.
1171         * Modules/geolocation/PositionCallback.idl: Copied from Source/WebCore/page/PositionCallback.idl.
1172         * Modules/geolocation/PositionError.h: Copied from Source/WebCore/page/PositionError.h.
1173         * Modules/geolocation/PositionError.idl: Copied from Source/WebCore/page/PositionError.idl.
1174         * Modules/geolocation/PositionErrorCallback.h: Copied from Source/WebCore/page/PositionErrorCallback.h.
1175         * Modules/geolocation/PositionErrorCallback.idl: Copied from Source/WebCore/page/PositionErrorCallback.idl.
1176         * Modules/geolocation/PositionOptions.h: Copied from Source/WebCore/page/PositionOptions.h.
1177         * Target.pri:
1178         * WebCore.gypi:
1179         * WebCore.vcproj/WebCore.vcproj:
1180         * WebCore.xcodeproj/project.pbxproj:
1181         * page/Geolocation.cpp: Removed.
1182         * page/Geolocation.h: Removed.
1183         * page/Geolocation.idl: Removed.
1184         * page/GeolocationController.cpp: Removed.
1185         * page/GeolocationController.h: Removed.
1186         * page/GeolocationError.h: Removed.
1187         * page/GeolocationPosition.h: Removed.
1188         * page/Geoposition.h: Removed.
1189         * page/Geoposition.idl: Removed.
1190         * page/PositionCallback.h: Removed.
1191         * page/PositionCallback.idl: Removed.
1192         * page/PositionError.h: Removed.
1193         * page/PositionError.idl: Removed.
1194         * page/PositionErrorCallback.h: Removed.
1195         * page/PositionErrorCallback.idl: Removed.
1196         * page/PositionOptions.h: Removed.
1197
1198 2012-02-22  Frederik Gladhorn  <frederik.gladhorn@nokia.com>
1199
1200         [gtk] Accessibility: use find funtion in vector instead of for.
1201         https://bugs.webkit.org/show_bug.cgi?id=77878
1202
1203         Reviewed by Hajime Morita.
1204
1205         Minor cleanup, use the find function from vector.
1206
1207         * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
1208         (webkitAccessibleGetIndexInParent):
1209
1210 2012-02-22  Ryosuke Niwa  <rniwa@webkit.org>
1211
1212         Remove the remaining uses of CSSStyleDeclaration in Editor
1213         https://bugs.webkit.org/show_bug.cgi?id=78939
1214
1215         Reviewed by Enrica Casucci.
1216
1217         Changed the argument types of shouldApplyStyle, applyParagraphStyle, applyStyleToSelection,
1218         applyParagraphStyleToSelection, and computeAndSetTypingStyle in Editor from CSSStyleDeclaration
1219         to StylePropertySet.
1220
1221         * WebCore.exp.in:
1222         * WebCore.xcodeproj/project.pbxproj:
1223         * editing/Editor.cpp:
1224         (WebCore::Editor::applyStyle):
1225         (WebCore::Editor::shouldApplyStyle):
1226         (WebCore::Editor::applyParagraphStyle):
1227         (WebCore::Editor::applyStyleToSelection):
1228         (WebCore::Editor::applyParagraphStyleToSelection):
1229         (WebCore::Editor::setBaseWritingDirection):
1230         (WebCore::Editor::computeAndSetTypingStyle):
1231         * editing/Editor.h:
1232         (WebCore):
1233         (Editor):
1234         * editing/EditorCommand.cpp:
1235         (WebCore::applyCommandToFrame):
1236         (WebCore::executeApplyParagraphStyle):
1237         (WebCore::executeMakeTextWritingDirectionLeftToRight):
1238         (WebCore::executeMakeTextWritingDirectionNatural):
1239         (WebCore::executeMakeTextWritingDirectionRightToLeft):
1240         * loader/EmptyClients.h:
1241         (WebCore::EmptyEditorClient::shouldApplyStyle):
1242         * page/DragController.cpp:
1243         (WebCore::DragController::concludeEditDrag):
1244         * page/EditorClient.h:
1245         (WebCore):
1246         (EditorClient):
1247
1248 2012-02-22  Dana Jansens  <danakj@chromium.org>
1249
1250         [chromium] Cull quads outside of the scissoring damage rect
1251         https://bugs.webkit.org/show_bug.cgi?id=79181
1252
1253         Reviewed by James Robinson.
1254
1255         Quads outside of the partial swap cause us to execute GL operations
1256         that actually use a fair amount of CPU time (enough to affect power
1257         usage). Here we cull quads by only keeping their intersection
1258         with the damage rect used for partial swap.
1259
1260         Unit test: CCQuadCuller.cpp
1261
1262         * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
1263         (WebCore::CCLayerTreeHostImpl::optimizeRenderPasses):
1264         * platform/graphics/chromium/cc/CCQuadCuller.cpp:
1265         (WebCore::CCQuadCuller::cullOccludedQuads):
1266         * platform/graphics/chromium/cc/CCQuadCuller.h:
1267         (CCQuadCuller):
1268         * platform/graphics/chromium/cc/CCRenderPass.cpp:
1269         (WebCore::CCRenderPass::optimizeQuads):
1270         * platform/graphics/chromium/cc/CCRenderPass.h:
1271         (CCRenderPass):
1272
1273 2012-02-21  Dana Jansens  <danakj@chromium.org>
1274
1275         [Chromium] New CCOcclusionTracker class with tests
1276         https://bugs.webkit.org/show_bug.cgi?id=78549
1277
1278         Reviewed by James Robinson.
1279
1280         Adds a CCOcclusionTrackerBase template class that is able to track occlusion
1281         of layers while traversing the layer tree from front-to-back, with typedefed
1282         versions for the main and impl threads.
1283
1284         At each step of the front-to-back traversal, the class should be notified of
1285         changes to the current render target, and when done working with a layer, the
1286         layer is added the tracked occlusion.
1287
1288         The class provides tests for checking if a rect in content space
1289         for a layer/surface is occluded by others in front of it.
1290
1291         Unit tests: CCOcclusionTrackerTest.cpp
1292
1293         * WebCore.gypi:
1294         * platform/graphics/chromium/cc/CCOcclusionTracker.cpp: Added.
1295         (WebCore):
1296         (WebCore::::enterTargetRenderSurface):
1297         (WebCore::::finishedTargetRenderSurface):
1298         (WebCore::transformSurfaceOpaqueRegion):
1299         (WebCore::::leaveToTargetRenderSurface):
1300         (WebCore::contentToScreenSpaceTransform):
1301         (WebCore::contentToTargetSurfaceTransform):
1302         (WebCore::computeOcclusionBehindLayer):
1303         (WebCore::::markOccludedBehindLayer):
1304         (WebCore::testContentRectOccluded):
1305         (WebCore::::occluded):
1306         (WebCore::::surfaceOccluded):
1307         (WebCore::rectSubtractRegion):
1308         (WebCore::computeUnoccludedContentRect):
1309         (WebCore::::unoccludedContentRect):
1310         (WebCore::::surfaceUnoccludedContentRect):
1311         (WebCore::::currentOcclusionInScreenSpace):
1312         (WebCore::::currentOcclusionInTargetSurface):
1313         * platform/graphics/chromium/cc/CCOcclusionTracker.h: Added.
1314         (WebCore):
1315         (CCOcclusionTrackerBase):
1316         (WebCore::CCOcclusionTrackerBase::CCOcclusionTrackerBase):
1317         (StackObject):
1318
1319 2012-02-21  Andreas Kling  <awesomekling@apple.com>
1320
1321         Cache <font face> family lists in CSSValuePool.
1322         <http://webkit.org/b/79195>
1323
1324         Reviewed by Antti Koivisto.
1325
1326         HTMLFontElements with "face" attributes are very common in legacy web content.
1327         Add a String->CSSValue cache for these in CSSValuePool and use it to avoid
1328         reparsing and recreating duplicate font face values.
1329
1330         This knocks 20ms (~1.5%) worth of samples off of the Moz page cycler on my system.
1331
1332         * css/CSSParser.cpp:
1333         (WebCore::CSSParser::parseFontFaceValue):
1334         * css/CSSParser.h:
1335         * css/CSSValuePool.cpp:
1336         (WebCore::CSSValuePool::createFontFaceValue):
1337         * css/CSSValuePool.h:
1338         * html/HTMLFontElement.cpp:
1339         (WebCore::HTMLFontElement::collectStyleForAttribute):
1340
1341 2012-02-21  Adam Barth  <abarth@webkit.org>
1342
1343         Separate the implementation of registerProtocolHandler from Navigator.cpp
1344         https://bugs.webkit.org/show_bug.cgi?id=78945
1345
1346         Reviewed by Eric Seidel.
1347
1348         The implementation of registerProtocolHandler needlessly complicates
1349         the implementation of Navigator.cpp.  In principle,
1350         registerProtocolHandler (and possibly registerContentHandler, when we
1351         implement that feature) could be its own module, but that seems like
1352         overkill for one or two files.
1353
1354         * CMakeLists.txt:
1355         * GNUmakefile.list.am:
1356         * Target.pri:
1357         * WebCore.gypi:
1358         * WebCore.vcproj/WebCore.vcproj:
1359         * WebCore.xcodeproj/project.pbxproj:
1360         * page/Navigator.cpp:
1361         (WebCore):
1362         * page/Navigator.h:
1363         (Navigator):
1364         * page/Navigator.idl:
1365
1366 2012-02-21  MORITA Hajime  <morrita@google.com>
1367
1368         HasIDFlag and HasClassFlag can be removed.
1369         https://bugs.webkit.org/show_bug.cgi?id=77861
1370
1371         Reviewed by Andreas Kling.
1372
1373         Replaced HasIDFlag and HasClassFlag with a check against
1374         ElementAttributeData. It looks these flags (originally bitfields)
1375         were legacy of ancient era, where we didn't cache @id and @class
1376         values and needed a hash lookup for each check.
1377
1378         No new tests. No behavioral change.
1379
1380         * dom/Element.cpp:
1381         (WebCore::Element::idAttributeChanged):
1382         * dom/Element.h:
1383         (WebCore::Element::hasID):
1384         (WebCore):
1385         (WebCore::Element::hasClass):
1386         (WebCore::Node::hasID):
1387         (WebCore::Node::hasClass):
1388         * dom/ElementAttributeData.h:
1389         (WebCore::ElementAttributeData::hasID):
1390         (WebCore::ElementAttributeData::hasClass):
1391         (ElementAttributeData):
1392         * dom/Node.h:
1393         (Node):
1394         (WebCore::nodeStyleChangeShift):
1395         * dom/StyledElement.cpp:
1396         (WebCore::StyledElement::classAttributeChanged):
1397
1398 2012-02-21  Matthew Delaney  <mdelaney@apple.com>
1399
1400         2D Canvas setTransform makes unnecessary matrix mults
1401         https://bugs.webkit.org/show_bug.cgi?id=79190
1402
1403         Reviewed by Dan Bernstein.
1404
1405         No new tests - plenty of current tests using setTransform.
1406
1407         * html/canvas/CanvasRenderingContext2D.cpp:
1408         (WebCore::CanvasRenderingContext2D::setTransform):
1409
1410 2012-02-21  MORITA Hajime <morrita@google.com>
1411
1412         INPUT_SPEECH should be implemented as a PageSupplement.
1413         https://bugs.webkit.org/show_bug.cgi?id=79051
1414
1415         Turned SpeechInput to a PageSupplement.
1416
1417         Reviewed by Adam Barth.
1418
1419         No new tests. No behavior change.
1420
1421         * html/shadow/TextControlInnerElements.cpp:
1422         (WebCore::InputFieldSpeechButtonElement::speechInput):
1423         (WebCore::InputFieldSpeechButtonElement::attach):
1424         * page/Page.cpp:
1425         (WebCore::Page::Page):
1426         (WebCore::Page::PageClients::PageClients):
1427         * page/Page.h:
1428         (WebCore):
1429         (PageClients):
1430         (Page):
1431         * page/SpeechInput.cpp:
1432         (WebCore::SpeechInput::supplementName):
1433         (WebCore):
1434         (WebCore::provideSpeechInputTo):
1435         * page/SpeechInput.h:
1436         (SpeechInput):
1437         (WebCore::SpeechInput::from):
1438         * page/SpeechInputClient.h:
1439         (WebCore):
1440
1441 2012-02-21  Alexandre Elias  <aelias@google.com>
1442
1443         [chromium] Add three small zoom gesture features
1444         https://bugs.webkit.org/show_bug.cgi?id=74216
1445
1446         Reviewed by James Robinson.
1447
1448         1. Support panning around with two fingers.
1449         2. When double-tap zooming, issue the commit at final/scroll scale as
1450         early as possible.
1451         3. When pinch zooming out, issue a commit at minimum scale to avoid
1452         showing checkerboard.
1453
1454         Added test for panning to CCLayerTreeHostImplTest::pinchGesture.
1455         (The other features are heuristics whose exact behavior we don't need
1456         to lock in with a test.)
1457
1458         * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
1459         (WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
1460         (WebCore::CCLayerTreeHostImpl::pinchGestureBegin):
1461         (WebCore::CCLayerTreeHostImpl::pinchGestureUpdate):
1462         (WebCore::CCLayerTreeHostImpl::computeDoubleTapZoomDeltas):
1463         (WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
1464         (WebCore::CCLayerTreeHostImpl::makeScrollAndScaleSet):
1465         (WebCore::CCLayerTreeHostImpl::processScrollDeltas):
1466         * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
1467
1468 2012-02-21  Filip Pizlo  <fpizlo@apple.com>
1469
1470         JSC should be a triple-tier VM
1471         https://bugs.webkit.org/show_bug.cgi?id=75812
1472         <rdar://problem/10079694>
1473
1474         Reviewed by Gavin Barraclough.
1475         
1476         No new tests, because there is no change in behavior.
1477
1478         * CMakeLists.txt:
1479
1480 2012-02-21  Kentaro Hara  <haraken@chromium.org>
1481
1482         NavigatorMediaStream.idl defines an interface for NavigatorGamepad
1483         https://bugs.webkit.org/show_bug.cgi?id=79152
1484
1485         Reviewed by Adam Barth.
1486
1487         Fixed a typo: NavigatorGamepad => NavigatorMediaStream
1488
1489         This typo fix just changes the name of generated files:
1490
1491         - V8NavigatorGamepad.h => V8NavigatorMediaStream.h
1492         - V8NavigatorGamepad.cpp => V8NavigatorMediaStream.cpp
1493
1494         The reason why the typo has not caused any serious build issues is that
1495         the generate files for supplemental interfaces are "empty" and not important.
1496         They just exist to control makefile dependencies.
1497
1498         No tests. No change in behavior.
1499
1500         * mediastream/NavigatorMediaStream.idl:
1501
1502 2012-02-21  Daniel Sievers  <sievers@chromium.org>
1503
1504         [Chromium] Fix compositor setting color uniforms incorrectly for solid color quads.
1505         https://bugs.webkit.org/show_bug.cgi?id=76017
1506
1507         Reviewed by James Robinson.
1508
1509         * platform/graphics/chromium/LayerRendererChromium.cpp:
1510         (WebCore::LayerRendererChromium::drawSolidColorQuad):
1511
1512 2012-02-21  Max Vujovic  <mvujovic@adobe.com>
1513
1514         getCTM() on SVG root element with borders, paddings, and viewbox returns incorrect values
1515         https://bugs.webkit.org/show_bug.cgi?id=78631
1516
1517         Reviewed by Eric Seidel.
1518
1519         SVGSVGElement::currentViewportSize was returning the size of the SVG viewport plus CSS
1520         borders and paddings, causing the CTM calculation to be off.
1521
1522         Test: svg/dom/SVGLocatable-getCTM-svg-root.html
1523
1524         * svg/SVGSVGElement.cpp:
1525         (WebCore::SVGSVGElement::currentViewportSize):
1526
1527             SVGSVGElement::currentViewportSize now uses the contentBoxRect instead of the frameRect.
1528             The contentBoxRect corresponds to the SVG viewport and does not include borders and
1529             paddings.
1530
1531 2012-02-21  Robin Cao  <robin.cao@torchmobile.com.cn>
1532
1533         [BlackBerry] Upstream Icon class in platform/graphics/blackberry
1534         https://bugs.webkit.org/show_bug.cgi?id=79088
1535
1536         Reviewed by Antonio Gomes.
1537
1538         Initial upstreaming, no new tests.
1539
1540         * platform/graphics/blackberry/IconBlackBerry.cpp: Added.
1541         (WebCore):
1542         (WebCore::Icon::~Icon):
1543         (WebCore::Icon::paint):
1544         (WebCore::Icon::createIconForFiles):
1545
1546 2012-02-21  Kenichi Ishibashi  <bashi@chromium.org>
1547
1548         Rename "reserved1" flag of WebSocketFrame to compress
1549         https://bugs.webkit.org/show_bug.cgi?id=79187
1550
1551         WebSocket deflate-frame extension draft specification defines COMP bit.
1552         http://tools.ietf.org/html/draft-tyoshino-hybi-websocket-perframe-deflate-05#page-11
1553
1554         Reviewed by Kent Tamura.
1555
1556         No new tests. http/tests/websocket/tests/hybi/reserved-bits.html is revised to follow the change.
1557
1558         * websockets/WebSocketChannel.cpp:
1559         (WebCore):
1560         (WebCore::WebSocketChannel::parseFrame): "reserved1" renamed "compress".
1561         (WebCore::WebSocketChannel::processFrame): Removed reserved1 flag check.
1562         (WebCore::makeFrameData):
1563         (WebCore::WebSocketChannel::sendFrame):
1564         * websockets/WebSocketFrame.h: "reserved1" flag renamed "compress".
1565         (WebCore::WebSocketFrame::WebSocketFrame):
1566         (WebSocketFrame):
1567
1568 2012-02-21  Yael Aharon  <yael.aharon@nokia.com>
1569
1570         [Texmap] Move all TextureMapper related files to graphics/texmap
1571         https://bugs.webkit.org/show_bug.cgi?id=79141
1572
1573         Reviewed by Martin Robinson.
1574
1575         Move TextureMaooerGL and TextureMapperShaderManager files to graphics/texmap.
1576         No new tests. 
1577
1578         * GNUmakefile.list.am:
1579         * Target.pri:
1580         * WebCore.gypi:
1581         * platform/graphics/qt/GraphicsContext3DQt.cpp
1582         * platform/graphics/opengl/TextureMapperGL.cpp: Removed.
1583         * platform/graphics/opengl/TextureMapperGL.h: Removed.
1584         * platform/graphics/opengl/TextureMapperShaderManager.cpp: Removed.
1585         * platform/graphics/opengl/TextureMapperShaderManager.h: Removed.
1586         * platform/graphics/texmap/TextureMapperGL.cpp: Copied from Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp.
1587         * platform/graphics/texmap/TextureMapperGL.h: Copied from Source/WebCore/platform/graphics/opengl/TextureMapperGL.h.
1588         * platform/graphics/texmap/TextureMapperShaderManager.cpp: Copied from Source/WebCore/platform/graphics/opengl/TextureMapperShaderManager.cpp.
1589         * platform/graphics/texmap/TextureMapperShaderManager.h: Copied from Source/WebCore/platform/graphics/opengl/TextureMapperShaderManager.h.
1590
1591 2012-02-20  MORITA Hajime  <morrita@google.com>
1592
1593         MEDIA_STREAM should be implemented as a PageSupplement.
1594         https://bugs.webkit.org/show_bug.cgi?id=79050
1595
1596         Reviewed by Adam Barth.
1597
1598         Added UserMediaController which implements PageSupplement. This
1599         controller mediates WebCore-to-client communication and lifecycle
1600         management. Then pushed UserMediaController out as a
1601         PageSupplement module.
1602
1603         No new tests. No behavior change.
1604
1605         * WebCore.gypi:
1606         * GNUmakefile.list.am:
1607         * mediastream/NavigatorMediaStream.cpp:
1608         (WebCore::NavigatorMediaStream::webkitGetUserMedia):
1609         * mediastream/UserMediaClient.h:
1610         (WebCore):
1611         * mediastream/UserMediaController.cpp: Added.
1612         (WebCore):
1613         (WebCore::UserMediaController::supplementName):
1614         (WebCore::UserMediaController::UserMediaController):
1615         (WebCore::UserMediaController::~UserMediaController):
1616         (WebCore::UserMediaController::create):
1617         (WebCore::provideUserMediaTo):
1618         * mediastream/UserMediaController.h: Added.
1619         (WebCore):
1620         (UserMediaController):
1621         (WebCore::UserMediaController::client):
1622         (WebCore::UserMediaController::from):
1623         (WebCore::UserMediaController::requestUserMedia):
1624         (WebCore::UserMediaController::cancelUserMediaRequest):
1625         * mediastream/UserMediaRequest.cpp:
1626         (WebCore::UserMediaRequest::create):
1627         (WebCore::UserMediaRequest::UserMediaRequest):
1628         (WebCore::UserMediaRequest::didCompleteQuery):
1629         (WebCore::UserMediaRequest::contextDestroyed):
1630         * mediastream/UserMediaRequest.h:
1631         (WebCore):
1632         (UserMediaRequest):
1633         * page/Page.cpp:
1634         (WebCore::Page::Page):
1635         (WebCore::Page::~Page):
1636         (WebCore::Page::PageClients::PageClients):
1637         * page/Page.h:
1638         (WebCore):
1639         (PageClients):
1640         (Page):
1641
1642 2012-02-21  James Robinson  <jamesr@chromium.org>
1643
1644         Node::isContentEditable should only update styles, not layout
1645         https://bugs.webkit.org/show_bug.cgi?id=78637
1646
1647         Reviewed by Ryosuke Niwa.
1648
1649         isContentEditable depends on knowing the node's current computed style, so it has to update styles if they are
1650         out of date.  It does not depend on knowing any layout-derived properties, however, so updating layout is just a
1651         waste of time.
1652
1653         Behavior is covered by existing layout tests, primarily in editing/
1654
1655         * dom/Node.cpp:
1656         (WebCore::Node::isContentEditable):
1657         (WebCore::Node::isContentRichlyEditable):
1658
1659 2012-02-21  James Robinson  <jamesr@chromium.org>
1660
1661         Partially revert r108418 - move allowEventDispatch() call back to where it used to be.
1662
1663         Rubber-stamped by Ryosuke Niwa.
1664
1665         Tested by fast/text/find-layout-crash.html
1666
1667         * dom/ContainerNode.cpp:
1668         (WebCore::ContainerNode::removeChildren):
1669
1670 2012-02-21  Anders Carlsson  <andersca@apple.com>
1671
1672         Background jitters on pages with background-attachment: fixed
1673         https://bugs.webkit.org/show_bug.cgi?id=79182
1674
1675         Reviewed by Dan Bernstein.
1676
1677         Make sure to update the main frame scroll position before updating the scrolling layer.
1678         This also fixes a (purely theoretical) bug where we wouldn't be updating the main frame
1679         position if the main frame didn't have a scroll layer.
1680
1681         * page/scrolling/ScrollingCoordinator.cpp:
1682         (WebCore::ScrollingCoordinator::updateMainFrameScrollPositionAndScrollLayerPosition):
1683
1684 2012-02-21  Dana Jansens  <danakj@chromium.org>
1685
1686         Early-out in Region::unite() for adding an empty region.
1687         https://bugs.webkit.org/show_bug.cgi?id=79174
1688
1689         Reviewed by Anders Carlsson.
1690
1691         * platform/graphics/Region.cpp:
1692         (WebCore::Region::unite):
1693
1694 2012-02-21  Dana Jansens  <danakj@chromium.org>
1695
1696         [chromium] Painting a layer clears opaque rect in untouched tiles
1697         https://bugs.webkit.org/show_bug.cgi?id=79157
1698
1699         Reviewed by James Robinson.
1700
1701         When painting a tiled layer, we would throw away the saved opaque rect
1702         for any tiles that were not part of the paint. So now we check
1703         if we are able to save the existing saved opaque rect in a more
1704         proper way:
1705         1. If any pixels of the saved rect are painted non-opaque, we replace
1706         the saved rect.
1707         2. If an opaque rect is drawn outside of the saved rect, we replace
1708         the saved rect.
1709
1710         Unit test: TiledLayerChromiumTest.cpp
1711
1712         * platform/graphics/chromium/TiledLayerChromium.cpp:
1713         (WebCore::TiledLayerChromium::prepareToUpdateTiles):
1714         (WebCore::TiledLayerChromium::addSelfToOccludedScreenSpace):
1715
1716 2012-02-21  Raymond Toy  <rtoy@google.com>
1717
1718         Small typo in AudioPannerNode.cpp
1719         https://bugs.webkit.org/show_bug.cgi?id=75890
1720
1721         Change to check elevation as intended instead of azimuth.
1722         
1723         Reviewed by Chris Rogers.
1724
1725         No new tests for correction of typo.
1726
1727         * webaudio/AudioPannerNode.cpp:
1728         (WebCore::AudioPannerNode::getAzimuthElevation):
1729
1730 2012-02-21  Adam Barth  <abarth@webkit.org>
1731
1732         Frame and Navigator shouldn't need to worry about Geolocation
1733         https://bugs.webkit.org/show_bug.cgi?id=78860
1734
1735         Reviewed by Eric Seidel.
1736
1737         This patch removes some Geolocation-specific code from Frame and
1738         Navigator in favor of our new supplemental module mechanism.  We're
1739         still refining the module system, but we seem to be converging on a
1740         simple Observer/Supplement design.
1741
1742         In a future patch, I'll move the remaining Geolocation-related files in
1743         WebCore into Modules/geolocation.  This patch appears to be the first
1744         patch that introduces a module used by all the various build systems,
1745         which is why there's a bit more build system overhead than usual.
1746
1747         * Modules/geolocation: Added.
1748         * Modules/geolocation/NavigatorGeolocation.cpp: Added.
1749         (WebCore):
1750         (WebCore::NavigatorGeolocation::NavigatorGeolocation):
1751         (WebCore::NavigatorGeolocation::~NavigatorGeolocation):
1752         (WebCore::NavigatorGeolocation::pageDestroyed):
1753         (WebCore::NavigatorGeolocation::from):
1754         (WebCore::NavigatorGeolocation::geolocation):
1755         * Modules/geolocation/NavigatorGeolocation.h: Added.
1756         (WebCore):
1757         (NavigatorGeolocation):
1758         * Modules/geolocation/NavigatorGeolocation.idl: Added.
1759             - I've temporarily disabled this API for GObject because it generates
1760               a strange compile error.  Once I land this patch, I'll spend some
1761               more time fixing the compile error.
1762         * page/DOMWindow.cpp:
1763         (WebCore):
1764         * page/DOMWindow.h:
1765         (DOMWindow):
1766         * page/Frame.cpp:
1767         (WebCore::Frame::pageDestroyed):
1768         (WebCore::Frame::transferChildFrameToNewDocument):
1769         * page/FrameDestructionObserver.cpp:
1770         (WebCore::FrameDestructionObserver::pageDestroyed):
1771         (WebCore):
1772         * page/FrameDestructionObserver.h:
1773         (FrameDestructionObserver):
1774         * page/Navigator.cpp:
1775         (WebCore):
1776         * page/Navigator.h:
1777         (WebCore):
1778         (Navigator):
1779         * page/Navigator.idl:
1780
1781 2012-02-21  Shawn Singh  <shawnsingh@chromium.org>
1782
1783         [chromium] Refactor CCLayerTreeHostCommon: merge scattered setTargetRenderSurface logic
1784         https://bugs.webkit.org/show_bug.cgi?id=78936
1785
1786         Reviewed by James Robinson.
1787
1788         No change in behavior, the code moved around already covered by existing tests.
1789
1790         In calculateDrawTransformsAndVisibility(), there are two separate
1791         if-else statements where setTargetRenderSurface logic is
1792         performed, and this makes the code less readable and more error
1793         prone. This patch merges the logic, removing the redundant if-else
1794         statements.
1795
1796         This code also merges one other set of if-statements that are
1797         equivalent, if (layer->parent()) and if (layer!=rootLayer).
1798
1799         * platform/graphics/chromium/LayerChromium.cpp:
1800         (WebCore::LayerChromium::createRenderSurface):
1801         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
1802         (WebCore::CCLayerImpl::createRenderSurface):
1803         * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
1804         (WebCore::calculateDrawTransformsAndVisibilityInternal):
1805
1806 2012-02-21  Kentaro Hara  <haraken@chromium.org>
1807
1808         Remove FIXME from resolve-supplemental.pl
1809         https://bugs.webkit.org/show_bug.cgi?id=79160
1810
1811         Reviewed by Adam Barth.
1812
1813         The IDL attribute checker has been enabled in all build systems.
1814         This patch removes FIXME in resolve-supplemental.pl.
1815         Also, this patch improves a comment in IDLAttributes.txt.
1816
1817         No tests. No change in behavior.
1818
1819         * bindings/scripts/IDLAttributes.txt:
1820         * bindings/scripts/resolve-supplemental.pl:
1821
1822 2012-02-21  Emil A Eklund  <eae@chromium.org>
1823
1824         Add FractionalLayoutRect for sub-pixel layout
1825         https://bugs.webkit.org/show_bug.cgi?id=78924
1826
1827         Reviewed by Eric Seidel.
1828
1829         Add FractionalLayoutUnit version of Rect class. Uses FractionalLayoutPoint
1830         and FractionalLayoutSize internally.
1831
1832         Also add conversions to int/float versions of same.
1833
1834         No new tests.
1835
1836         * GNUmakefile.list.am:
1837         * WebCore.vcproj/WebCore.vcproj:
1838         * WebCore.xcodeproj/project.pbxproj:
1839         * platform/graphics/FloatRect.cpp:
1840         (WebCore::FloatRect::FloatRect):
1841         (WebCore):
1842         * platform/graphics/FloatRect.h:
1843         (WebCore):
1844         (FloatRect):
1845         * platform/graphics/FractionalLayoutRect.cpp: Added.
1846         (WebCore):
1847         (WebCore::FractionalLayoutRect::FractionalLayoutRect):
1848         (WebCore::FractionalLayoutRect::intersects):
1849         (WebCore::FractionalLayoutRect::contains):
1850         (WebCore::FractionalLayoutRect::intersect):
1851         (WebCore::FractionalLayoutRect::unite):
1852         (WebCore::FractionalLayoutRect::uniteIfNonZero):
1853         (WebCore::FractionalLayoutRect::scale):
1854         (WebCore::unionRect):
1855         (WebCore::enclosingIntRect):
1856         (WebCore::enclosingFractionalLayoutRect):
1857         (WebCore::pixelSnappedIntRect):
1858         * platform/graphics/FractionalLayoutRect.h: Added.
1859         (WebCore):
1860         (FractionalLayoutRect):
1861         (WebCore::FractionalLayoutRect::FractionalLayoutRect):
1862         (WebCore::FractionalLayoutRect::location):
1863         (WebCore::FractionalLayoutRect::size):
1864         (WebCore::FractionalLayoutRect::setLocation):
1865         (WebCore::FractionalLayoutRect::setSize):
1866         (WebCore::FractionalLayoutRect::x):
1867         (WebCore::FractionalLayoutRect::y):
1868         (WebCore::FractionalLayoutRect::maxX):
1869         (WebCore::FractionalLayoutRect::maxY):
1870         (WebCore::FractionalLayoutRect::width):
1871         (WebCore::FractionalLayoutRect::height):
1872         (WebCore::FractionalLayoutRect::setX):
1873         (WebCore::FractionalLayoutRect::setY):
1874         (WebCore::FractionalLayoutRect::setWidth):
1875         (WebCore::FractionalLayoutRect::setHeight):
1876         (WebCore::FractionalLayoutRect::isEmpty):
1877         (WebCore::FractionalLayoutRect::center):
1878         (WebCore::FractionalLayoutRect::move):
1879         (WebCore::FractionalLayoutRect::moveBy):
1880         (WebCore::FractionalLayoutRect::expand):
1881         (WebCore::FractionalLayoutRect::contract):
1882         (WebCore::FractionalLayoutRect::shiftXEdgeTo):
1883         (WebCore::FractionalLayoutRect::shiftMaxXEdgeTo):
1884         (WebCore::FractionalLayoutRect::shiftYEdgeTo):
1885         (WebCore::FractionalLayoutRect::shiftMaxYEdgeTo):
1886         (WebCore::FractionalLayoutRect::minXMinYCorner):
1887         (WebCore::FractionalLayoutRect::maxXMinYCorner):
1888         (WebCore::FractionalLayoutRect::minXMaxYCorner):
1889         (WebCore::FractionalLayoutRect::maxXMaxYCorner):
1890         (WebCore::FractionalLayoutRect::contains):
1891         (WebCore::FractionalLayoutRect::inflateX):
1892         (WebCore::FractionalLayoutRect::inflateY):
1893         (WebCore::FractionalLayoutRect::inflate):
1894         (WebCore::FractionalLayoutRect::transposedRect):
1895         (WebCore::FractionalLayoutRect::infiniteRect):
1896         (WebCore::intersection):
1897         (WebCore::unionRect):
1898         (WebCore::operator==):
1899         (WebCore::operator!=):
1900         * platform/graphics/IntRect.cpp:
1901         (WebCore::IntRect::IntRect):
1902         (WebCore):
1903         * platform/graphics/IntRect.h:
1904         (WebCore):
1905         (IntRect):
1906
1907 2012-02-21  James Robinson  <jamesr@chromium.org>
1908
1909         Enable ScrollingCoordinator in chromium whenever compositing is enabled
1910         https://bugs.webkit.org/show_bug.cgi?id=79165
1911
1912         Reviewed by Adam Barth.
1913
1914         As the title says.
1915
1916         * page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
1917         (WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
1918         (WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
1919         (WebCore::ScrollingCoordinator::setScrollLayer):
1920         (WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
1921         (WebCore::ScrollingCoordinator::setScrollParameters):
1922         (WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
1923         (WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
1924             Remove ASSERT_NOT_REACHED()ed from these functions, they are now expected to be called but do nothing.
1925         * rendering/RenderLayerBacking.cpp:
1926         (WebCore::RenderLayerBacking::RenderLayerBacking):
1927             Guard a mac-specific piece of code in #if PLATFORM(MAC). This code already has a FIXME.
1928         * rendering/RenderLayerCompositor.cpp:
1929         (WebCore::shouldCompositeOverflowControls):
1930             Make coordinatesScroll..() sufficient but not necessary for compositing overflow controls. In chromium, we
1931             want to composite overflow controls even for FrameViews that we aren't coordinating via the
1932             ScrollingCoordinator.
1933
1934 2012-02-21  Adam Klein  <adamk@chromium.org>
1935
1936         Setting innerText causes DOMSubtreeModified to be dispatched too early
1937         https://bugs.webkit.org/show_bug.cgi?id=79140
1938
1939         Reviewed by Ryosuke Niwa.
1940
1941         Followup to r108152: move children change notifications later in
1942         ContainerNode::removeChildren(), thus making sure Node::inDocument()
1943         is in the correct state when we call into script.
1944
1945         Tests: fast/dom/getElementById-consistency3.html
1946                fast/dom/getElementById-consistency4.html
1947                fast/dom/getElementById-consistency5.html
1948
1949         * dom/ContainerNode.cpp:
1950         (WebCore::ContainerNode::removeChildren):
1951
1952 2012-02-15  Ryosuke Niwa  <rniwa@webkit.org>
1953
1954         Assertion failure in TextIterator::handleTextBox
1955         https://bugs.webkit.org/show_bug.cgi?id=78530
1956
1957         Reviewed by Eric Seidel.
1958
1959         The assertion failure was caused by handleTextNodeFirstLetter's updating m_text without clearing
1960         m_sortedTextBoxesPosition. Re-structured handleTextNode so that we always reset m_sortedTextBoxesPosition
1961         when we have a first-letter.
1962
1963         Test: editing/text-iterator/rtl-first-letter-text-iterator-crash.html
1964
1965         * editing/TextIterator.cpp:
1966         (WebCore::TextIterator::handleTextNode):
1967         (WebCore::TextIterator::handleTextBox):
1968         (WebCore::TextIterator::handleTextNodeFirstLetter):
1969
1970 2012-02-21  Yael Aharon  <yael.aharon@nokia.com>
1971
1972         Unreviewed build fix.
1973
1974         No new tests.
1975
1976         * platform/graphics/opengl/TextureMapperGL.cpp:
1977
1978 2012-02-21  Adam Klein  <adamk@chromium.org>
1979
1980         ContainerNode::childrenChanged must be called immediately after removing children
1981         https://bugs.webkit.org/show_bug.cgi?id=79162
1982
1983         Reviewed by Ryosuke Niwa.
1984
1985         In r108152, a call to childrenChanged() was erroneously moved
1986         below the call to child->removedFromDocument(). This breaks, at the
1987         least, the behavior of the <title> element. This patch corrects the
1988         mistake and adds a test.
1989
1990         Test: fast/dom/title-directionality-removeChild.html
1991
1992         * dom/ContainerNode.cpp:
1993         (WebCore::ContainerNode::removeChild):
1994
1995 2012-02-21  Luke Macpherson   <macpherson@chromium.org>
1996
1997         Implement many instances of HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE in CSSStyleApplyProperty.
1998         https://bugs.webkit.org/show_bug.cgi?id=79067
1999
2000         Reviewed by Andreas Kling.
2001
2002         No new tests / refactoring only.
2003
2004         * css/CSSStyleApplyProperty.cpp:
2005         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
2006         * css/CSSStyleSelector.cpp:
2007         (WebCore::CSSStyleSelector::collectMatchingRulesForList):
2008         * rendering/style/RenderStyle.h:
2009
2010 2012-02-21  Jon Lee  <jonlee@apple.com>
2011
2012         Bring notifications support to WK1 mac
2013         https://bugs.webkit.org/show_bug.cgi?id=78783
2014         <rdar://problem/10610578>
2015
2016         Reviewed by Anders Carlsson.
2017
2018         * WebCore.exp.in: Expose dispatchErrorEvent on Notification.
2019
2020 2012-02-21  No'am Rosenthal  <noam.rosenthal@nokia.com>
2021
2022         [Qt] Previous web page appears outside content rect
2023         https://bugs.webkit.org/show_bug.cgi?id=78816
2024
2025         Adjust the scissor clipping by -1, as the glScissor() function requires coordinates and
2026         not sizes.
2027
2028         Reviewed by Kenneth Rohde Christiansen.
2029
2030         No new functionality.
2031
2032         * platform/graphics/opengl/TextureMapperGL.cpp:
2033         (WebCore::scissorClip):
2034
2035 2012-02-21  Victor Carbune  <vcarbune@adobe.com>
2036
2037         Added support for pause-on-exit flag on a TextTrackCue.
2038         https://bugs.webkit.org/show_bug.cgi?id=72173
2039
2040         Reviewed by Eric Carlson.
2041
2042         Test: media/track/track-cues-pause-on-exit.html
2043
2044         * html/HTMLMediaElement.cpp:
2045         (WebCore::HTMLMediaElement::updateActiveTextTrackCues): Implemented
2046         support for pausing the video if the pause-on-exit flag is set on
2047         a cue that is currently exiting.
2048
2049 2012-02-21  Kentaro Hara  <haraken@chromium.org>
2050
2051         Enable the IDL attribute checker in all build systems
2052         https://bugs.webkit.org/show_bug.cgi?id=79090
2053
2054         Reviewed by Adam Barth.
2055
2056         We have enabled the IDL attribute checker in Chromium in r108322.
2057         This patch enables the IDL attribute checker in all other
2058         build systems.
2059
2060         No tests. I manually checked that [Custommm], [CallWith=],
2061         [CallWith=ScriptExecutionContext|Foo] cause build failures.
2062
2063         * CMakeLists.txt:
2064         * DerivedSources.make:
2065         * DerivedSources.pri:
2066         * GNUmakefile.am:
2067         * UseJSC.cmake:
2068         * UseV8.cmake:
2069         * WebCore.vcproj/WebCore.vcproj:
2070         * WebCore.xcodeproj/project.pbxproj:
2071         * bindings/scripts/IDLAttributes.txt: Added [ObjCCustomImplementation]
2072         since I forgot to add it in r108322.
2073
2074 2012-02-21  Yael Aharon  <yael.aharon@nokia.com>
2075
2076         [Texmap] Better management of shaders in TextureMapperGL
2077         https://bugs.webkit.org/show_bug.cgi?id=78674
2078  
2079         Reviewed by Noam Rosenthal.
2080  
2081         Split TextureMapperGL.cpp into two files.
2082         Get rid of the enums that we were using to identify shaders and to identify variables.
2083         Switch flip and opaque from using bool to using enums.
2084  
2085         No new tests. This is refactoring only.
2086  
2087         * GNUmakefile.list.am:
2088         * Target.pri:
2089         * WebCore.gypi:
2090         * platform/graphics/OpenGLShims.h:
2091         * platform/graphics/opengl/TextureMapperGL.cpp:
2092         (WebCore):
2093         (SharedGLData):
2094         (WebCore::TextureMapperGLData::SharedGLData::SharedGLData):
2095         (WebCore::TextureMapperGLData::SharedGLData::~SharedGLData):
2096         (WebCore::TextureMapperGLData::TextureMapperGLData):
2097         (TextureMapperGLData):
2098         (WebCore::TextureMapperGL::drawTexture):
2099         (WebCore::TextureMapperGL::drawTextureWithMaskAndOpacity):
2100         (WebCore::TextureMapperGL::drawTextureSimple):
2101         (WebCore::TextureMapperGL::beginClip):
2102         * platform/graphics/opengl/TextureMapperGL.h:
2103         * platform/graphics/opengl/TextureMapperShaderManager.cpp: Added.
2104         (WebCore):
2105         (WebCore::FRAGMENT_SHADER):
2106         (WebCore::TextureMapperShaderProgram::initializeProgram):
2107         (WebCore::TextureMapperShaderProgram::getUniformLocation):
2108         (WebCore::TextureMapperShaderProgram::~TextureMapperShaderProgram):
2109         (WebCore::TextureMapperShaderProgramSimple::create):
2110         (WebCore::TextureMapperShaderProgramSimple::TextureMapperShaderProgramSimple):
2111         (WebCore::TextureMapperShaderProgramSimple::vertexShaderSource):
2112         (WebCore::TextureMapperShaderProgramSimple::fragmentShaderSource):
2113         (WebCore::TextureMapperShaderProgramOpacityAndMask::create):
2114         (WebCore::TextureMapperShaderProgramOpacityAndMask::TextureMapperShaderProgramOpacityAndMask):
2115         (WebCore::TextureMapperShaderProgramOpacityAndMask::vertexShaderSource):
2116         (WebCore::TextureMapperShaderProgramOpacityAndMask::fragmentShaderSource):
2117         (WebCore::TextureMapperShaderProgramClip::create):
2118         (WebCore::TextureMapperShaderProgramClip::TextureMapperShaderProgramClip):
2119         (WebCore::TextureMapperShaderProgramClip::vertexShaderSource):
2120         (WebCore::TextureMapperShaderProgramClip::fragmentShaderSource):
2121         (WebCore::TextureMapperShaderManager::TextureMapperShaderManager):
2122         (WebCore::TextureMapperShaderManager::~TextureMapperShaderManager):
2123         * platform/graphics/opengl/TextureMapperShaderManager.h: Added.
2124         (WebCore):
2125         (WebCore::debugGLCommand):
2126         (TextureMapperShaderProgram):
2127         (WebCore::TextureMapperShaderProgram::id):
2128         (WebCore::TextureMapperShaderProgram::vertexAttrib):
2129         (WebCore::TextureMapperShaderProgram::shaderType):
2130         (TextureMapperShaderProgramSimple):
2131         (WebCore::TextureMapperShaderProgramSimple::matrixVariable):
2132         (WebCore::TextureMapperShaderProgramSimple::sourceMatrixVariable):
2133         (WebCore::TextureMapperShaderProgramSimple::sourceTextureVariable):
2134         (WebCore::TextureMapperShaderProgramSimple::opacityVariable):
2135         (TextureMapperShaderProgramOpacityAndMask):
2136         (WebCore::TextureMapperShaderProgramOpacityAndMask::sourceMatrixVariable):
2137         (WebCore::TextureMapperShaderProgramOpacityAndMask::matrixVariable):
2138         (WebCore::TextureMapperShaderProgramOpacityAndMask::maskMatrixVariable):
2139         (WebCore::TextureMapperShaderProgramOpacityAndMask::sourceTextureVariable):
2140         (WebCore::TextureMapperShaderProgramOpacityAndMask::maskTextureVariable):
2141         (WebCore::TextureMapperShaderProgramOpacityAndMask::opacityVariable):
2142         (TextureMapperShaderProgramClip):
2143         (WebCore::TextureMapperShaderProgramClip::matrixVariable):
2144         (TextureMapperShaderManager):
2145         (WebCore::TextureMapperShaderManager::getShaderProgram):
2146         * platform/graphics/qt/GraphicsContext3DQt.cpp:
2147         (WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
2148         * platform/graphics/texmap/TextureMapper.h:
2149         (WebCore::BitmapTexture::reset):
2150         (WebCore::BitmapTexture::isOpaque):
2151         (BitmapTexture):
2152
2153 2012-02-21  Anders Carlsson  <andersca@apple.com>
2154
2155         The tile cache should keep track of the tile coverage rect
2156         https://bugs.webkit.org/show_bug.cgi?id=79149
2157         <rdar://problem/10877338>
2158
2159         Reviewed by Andreas Kling.
2160
2161         Keep track of the tile coverage rect and use it to avoid trying to iterate over non-existent tiles on large pages.
2162
2163         * platform/graphics/ca/mac/TileCache.h:
2164         (TileCache):
2165         * platform/graphics/ca/mac/TileCache.mm:
2166         (WebCore::TileCache::setNeedsDisplayInRect):
2167         (WebCore::TileCache::revalidateTiles):
2168
2169 2012-02-21  Andreas Kling  <awesomekling@apple.com>
2170
2171         Make WebKitCSSShaderValue inherit directly from CSSValue.
2172         <http://webkit.org/b/79144>
2173
2174         Reviewed by Antti Koivisto.
2175
2176         WebKitCSSShaderValue was inheriting from CSSPrimitiveValue but only used
2177         it for storing the shader URL. Moved that to a String member instead.
2178
2179         WebKitCSSShaderValues didn't even return true for isPrimitiveValue() so
2180         there should be no behavior change whatsoever here.
2181
2182         * css/WebKitCSSShaderValue.cpp:
2183         (WebCore::WebKitCSSShaderValue::WebKitCSSShaderValue):
2184         (WebCore::WebKitCSSShaderValue::cachedShader):
2185         (WebCore::WebKitCSSShaderValue::customCssText):
2186         * css/WebKitCSSShaderValue.h:
2187         (WebKitCSSShaderValue):
2188
2189 2012-02-21  James Robinson  <jamesr@chromium.org>
2190
2191         Unreviewed windows build fix - avoid return statement after return if USE(ACCELERATED_COMPOSITING) is set.
2192
2193         * page/scrolling/ScrollingCoordinator.cpp:
2194         (WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView):
2195
2196 2012-02-21  James Robinson  <jamesr@chromium.org>
2197
2198         ScrollingCoordinator::coordinatesScrollingForFrameView should be conditional on compositing being active
2199         https://bugs.webkit.org/show_bug.cgi?id=79126
2200
2201         Reviewed by Anders Carlsson.
2202
2203         The ScrollingCoordinator should only attempt to coordinate scrolling when compositing is active, since it's all
2204         about manipulating GraphicsLayers. Adds a runtime check.
2205
2206         Also removes some stray #if ENABLE(THREADED_SCROLLING) guards that snuck into FrameView.
2207
2208         * page/FrameView.cpp:
2209         (WebCore::FrameView::addFixedObject):
2210         (WebCore::FrameView::removeFixedObject):
2211         * page/scrolling/ScrollingCoordinator.cpp:
2212         (WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView):
2213         (WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
2214
2215 2012-02-21  James Robinson  <jamesr@chromium.org>
2216
2217         Chromium build fix. Unreviwed but rubber-stamped by Antti.
2218
2219         * dom/Document.cpp:
2220         * editing/ReplaceSelectionCommand.cpp:
2221         * inspector/InspectorStyleSheet.h:
2222
2223 2012-02-21  Eric Carlson  <eric.carlson@apple.com>
2224
2225         Set Referrer header for media downloads
2226         https://bugs.webkit.org/show_bug.cgi?id=78614
2227
2228         Reviewed by Alexey Proskuryakov.
2229
2230         Test: http/tests/media/video-referer.html was modified to test this change.
2231
2232         * html/HTMLMediaElement.cpp:
2233         (WebCore::HTMLMediaElement::mediaPlayerReferrer): New, return the document's referer.
2234         * html/HTMLMediaElement.h:
2235
2236         * platform/graphics/MediaPlayer.cpp:
2237         (WebCore::MediaPlayer::referrer): New, return the client's mediaPlayerReferrer.
2238         * platform/graphics/MediaPlayer.h:
2239         (WebCore::MediaPlayerClient::mediaPlayerReferrer):
2240
2241         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
2242         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
2243         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Tell AVFoundation to add
2244             a referer header.
2245
2246 2012-02-21  Antti Koivisto  <antti@apple.com>
2247
2248         Not reviewed.
2249
2250         Remove some obsolete comments, use consistent name for propertyID.
2251
2252         * css/StylePropertySet.h:
2253         (StylePropertySet):
2254
2255 2012-02-21  Antti Koivisto  <antti@apple.com>
2256
2257         Clean up StylePropertySet included headers
2258         https://bugs.webkit.org/show_bug.cgi?id=79134
2259
2260         Reviewed by Andreas Kling.
2261
2262         Remove unneccesary includes.
2263
2264         * bindings/js/JSDOMBinding.h:
2265         * css/StylePropertySet.cpp:
2266         * css/StylePropertySet.h:
2267         (WebCore):
2268         (StylePropertySet):
2269         * editing/RemoveCSSPropertyCommand.cpp:
2270
2271 2012-02-21  Lin Wei  <wei.a.lin@intel.com>
2272
2273         Fix bug from r107672.
2274         https://bugs.webkit.org/show_bug.cgi?id=78773
2275
2276         Before set MediaStreamTrack disable/enable operation,
2277         checking the status of MediaStream that contains this MediaStreamTrack.
2278         if MediaStream is finished, then skipping operation of 
2279         didSetMediaStreamTrackEnabled().
2280
2281         Reviewed by Adam Barth.
2282         * mediastream/MediaStreamTrack.cpp:
2283         (WebCore::MediaStreamTrack::setEnabled):
2284
2285 2012-02-21  Julien Chaffraix  <jchaffraix@webkit.org>
2286
2287         Move RenderLayer::scrolledContentOffset calls to a common function
2288         https://bugs.webkit.org/show_bug.cgi?id=76971
2289
2290         Reviewed by David Hyatt.
2291
2292         Refactoring without any change in behavior.
2293
2294         This change adds a RenderBox::scrolledContentOffset function to handle all
2295         the calls that goes through the layer(). This indirection will enable us to
2296         add layer() checks without patching a lot of call sites as part of bug 75568.
2297
2298         We also moved down the concept of scroll offset down to RenderBox where it belongs!
2299
2300         * rendering/RenderLayer.h:
2301         (RenderLayer):
2302         (WebCore::RenderLayer::scrolledContentOffset):
2303         Moved scrolledContent to the private section of the class to prevent misuse.
2304
2305         * rendering/RenderBox.cpp:
2306         (WebCore::RenderBox::scrolledContentOffset):
2307         New function to add an indirection with RenderLayer.
2308
2309         * editing/visible_units.cpp:
2310         (WebCore::absoluteLineDirectionPointToLocalPointInBlock):
2311         * rendering/LayoutState.cpp:
2312         (WebCore::LayoutState::LayoutState):
2313         * rendering/RenderBlock.cpp:
2314         (WebCore::RenderBlock::layoutBlock):
2315         (WebCore::RenderBlock::paintObject):
2316         (WebCore::RenderBlock::selectionGapRectsForRepaint):
2317         (WebCore::RenderBlock::paintSelection):
2318         (WebCore::RenderBlock::nodeAtPoint):
2319         (WebCore::RenderBlock::offsetForContents):
2320         * rendering/RenderBox.cpp:
2321         (WebCore::RenderBox::offsetFromContainer):
2322         (WebCore::RenderBox::computeRectForRepaint):
2323         * rendering/RenderBox.h:
2324         (RenderBox):
2325         * rendering/RenderBoxModelObject.cpp:
2326         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
2327         * rendering/RenderInline.cpp:
2328         (WebCore::RenderInline::clippedOverflowRectForRepaint):
2329         (WebCore::RenderInline::computeRectForRepaint):
2330         (WebCore::RenderInline::offsetFromContainer):
2331         * rendering/RenderObject.cpp:
2332         (WebCore::RenderObject::computeRectForRepaint):
2333         (WebCore::RenderObject::mapLocalToContainer):
2334         (WebCore::RenderObject::mapAbsoluteToLocalPoint):
2335         (WebCore::RenderObject::offsetFromContainer):
2336         * rendering/RenderTextControlSingleLine.cpp:
2337         (WebCore::RenderTextControlInnerBlock::positionForPoint):
2338         Patched all those call sites to use the new function.
2339
2340 2012-02-21  Emil A Eklund  <eae@chromium.org>
2341
2342         Remove obsolete float comparison FIXMEs
2343         https://bugs.webkit.org/show_bug.cgi?id=79127
2344
2345         Reviewed by Eric Seidel.
2346
2347         Remove obsolete FIXME comments added back when we were planning to use
2348         floating point units for layout.
2349
2350         No new tests, no code changes.
2351
2352         * page/FrameView.cpp:
2353         (WebCore::FrameView::init):
2354         * rendering/RenderBlock.cpp:
2355         (WebCore::RenderBlock::layoutBlock):
2356         (WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
2357         (WebCore::RenderBlock::getClearDelta):
2358         * rendering/RenderBox.cpp:
2359         (WebCore::RenderBox::computeLogicalHeight):
2360         (WebCore::RenderBox::computeLogicalHeightUsing):
2361         (WebCore::RenderBox::computePercentageLogicalHeight):
2362         * rendering/RenderBoxModelObject.cpp:
2363         (WebCore::ImageQualityController::shouldPaintAtLowQuality):
2364
2365 2012-02-21  Alexander Pavlov  <apavlov@chromium.org>
2366
2367         Web Inspector: it is nearly impossible to select and copy text on the Elements panel.
2368         https://bugs.webkit.org/show_bug.cgi?id=60814
2369
2370         Reviewed by Pavel Feldman.
2371
2372         * inspector/front-end/inspector.js:
2373         (WebInspector.documentClick.followLink):
2374         (WebInspector.documentClick):
2375
2376 2012-02-21  Abhishek Arya  <inferno@chromium.org>
2377
2378         Crash in RenderTableSection::nodeAtPoint.
2379         https://bugs.webkit.org/show_bug.cgi?id=78922
2380
2381         Reviewed by Julien Chaffraix.
2382
2383         Test: fast/table/table-section-node-at-point-crash.html
2384
2385         * rendering/RenderTableSection.cpp:
2386         (WebCore::RenderTableSection::nodeAtPoint): recalc cells if the
2387         m_needsCellRecalc is set. Otherwise, we will end up accessing
2388         removed table cells.
2389
2390 2012-02-21  Antti Koivisto  <antti@apple.com>
2391
2392         Move PropertySetCSSStyleDeclaration to a file of its own
2393         https://bugs.webkit.org/show_bug.cgi?id=79121
2394
2395         Rubber-stamped by Andreas Kling.
2396
2397         This makes StylePropertySet.cpp more readable.
2398
2399         * CMakeLists.txt:
2400         * GNUmakefile.list.am:
2401         * Target.pri:
2402         * WebCore.gypi:
2403         * WebCore.vcproj/WebCore.vcproj:
2404         * WebCore.xcodeproj/project.pbxproj:
2405         * css/PropertySetCSSStyleDeclaration.cpp: Copied from Source/WebCore/css/StylePropertySet.cpp.
2406         (WebCore::PropertySetCSSStyleDeclaration::ref):
2407         (WebCore::PropertySetCSSStyleDeclaration::deref):
2408         (WebCore):
2409         * css/PropertySetCSSStyleDeclaration.h: Added.
2410         (WebCore):
2411         (PropertySetCSSStyleDeclaration):
2412         (WebCore::PropertySetCSSStyleDeclaration::PropertySetCSSStyleDeclaration):
2413         (WebCore::PropertySetCSSStyleDeclaration::parentElement):
2414         (WebCore::PropertySetCSSStyleDeclaration::clearParentRule):
2415         (WebCore::PropertySetCSSStyleDeclaration::clearParentElement):
2416         (WebCore::PropertySetCSSStyleDeclaration::contextStyleSheet):
2417         (WebCore::PropertySetCSSStyleDeclaration::setNeedsStyleRecalc):
2418         (RuleCSSStyleDeclaration):
2419         (WebCore::RuleCSSStyleDeclaration::RuleCSSStyleDeclaration):
2420         (WebCore::RuleCSSStyleDeclaration::parentRule):
2421         (WebCore::RuleCSSStyleDeclaration::clearParentRule):
2422         (InlineCSSStyleDeclaration):
2423         (WebCore::InlineCSSStyleDeclaration::InlineCSSStyleDeclaration):
2424         (WebCore::InlineCSSStyleDeclaration::parentElement):
2425         (WebCore::InlineCSSStyleDeclaration::clearParentElement):
2426         * css/StylePropertySet.cpp:
2427         (WebCore):
2428
2429 2012-02-21  Philippe Normand  <pnormand@igalia.com>
2430
2431         [GTK] WebAudio build is broken
2432         https://bugs.webkit.org/show_bug.cgi?id=79113
2433
2434         Reviewed by Martin Robinson.
2435
2436         * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
2437         (webKitWebAudioGStreamerChannelPosition): Set a default value for
2438         the position variable.
2439         * platform/audio/gtk/AudioBusGtk.cpp: Include CString.h, needed
2440         for sharedResourcesPath().
2441
2442 2012-02-21  Andreas Kling  <awesomekling@apple.com>
2443
2444         Kill FontFamilyValue.
2445         <http://webkit.org/b/79103>
2446
2447         Reviewed by Antti Koivisto.
2448
2449         Remove FontFamilyValue and replace all usage by CSSPrimitiveValue.
2450         The class was only used to filter font family names, removing bracketed
2451         suffixes, e.g "[Xft]".
2452
2453         This was added to KHTML in 2002 to support the use of specific X11 font
2454         families inside KMail: <https://bugs.kde.org/show_bug.cgi?id=38808>
2455
2456         Test: fast/css/font-family-trailing-bracket-gunk.html
2457
2458         * CMakeLists.txt:
2459         * GNUmakefile.list.am:
2460         * Target.pri:
2461         * WebCore.gypi:
2462         * WebCore.order:
2463         * WebCore.vcproj/WebCore.vcproj:
2464         * WebCore.xcodeproj/project.pbxproj:
2465         * css/CSSFontSelector.cpp:
2466         (WebCore::CSSFontSelector::addFontFaceRule):
2467         * css/CSSParser.cpp:
2468         * css/CSSStyleSelector.cpp:
2469         (WebCore::CSSStyleSelector::collectMatchingRulesForList):
2470         * css/CSSValue.cpp:
2471         (WebCore::CSSValue::cssText):
2472         (WebCore::CSSValue::destroy):
2473         * css/CSSValue.h:
2474         * css/CSSValuePool.cpp:
2475         (WebCore::CSSValuePool::createFontFamilyValue):
2476         * css/CSSValuePool.h:
2477         (CSSValuePool):
2478         * css/FontFamilyValue.cpp: Removed.
2479         * css/FontFamilyValue.h: Removed.
2480
2481 2012-02-21  Alexis Menard  <alexis.menard@openbossa.org>
2482
2483         Little optimization for CSSParser::parseFillShorthand.
2484         https://bugs.webkit.org/show_bug.cgi?id=79042
2485
2486         Reviewed by Hajime Morita.
2487
2488         Remove one extra loop that we can combine with the following one
2489         which adds the properties to the parser's list of properties. I also
2490         removed a useless check.
2491         Instruments shows on the css-parser-yui benchmark an improvement
2492         of 13ms (from 77ms spent in the function to 64ms).
2493
2494         No new tests : refactoring, existings tests should cover.
2495
2496         * css/CSSParser.cpp:
2497         (WebCore::CSSParser::parseFillShorthand):
2498
2499 2012-02-20  David Hyatt  <hyatt@apple.com>
2500
2501         https://bugs.webkit.org/show_bug.cgi?id=79046
2502         
2503         width of overflow:hidden blocks is wrong when their margins overlap floats.
2504         
2505         Relevant discussion is here: http://lists.w3.org/Archives/Public/www-style/2012Feb/0954.html
2506         
2507         This patch makes the following changes to how objects shrink when avoiding floats:
2508         (1) The containing block width used for percentage calculations is now constant. This means that
2509         an overflow:hidden block with a margin-left of 10% will no longer change what 10% means depending
2510         on the available line width. From a code perspective, containingBlockLogicalWidthForContent and
2511         containingBlockLogicalWidthForContentInRegion no longer contain any special-case code for
2512         shrinkToAvoidFloats() objects.
2513
2514         (2) Now the computation of the logical width for the shrinking object itself handles the adjustments.
2515         Two kinds of adjustments are made for both the start and end margins. Conceptually what we do is shrink
2516         the object to the available line width minus our margins, and then expand the width back out to the content edge
2517         or to the float edge as necessary. If the float fully fits in the margin, then we expand back out to the
2518         content edge. Otherwise if the float doesn't fit, then we expand only to the float edge, making sure our
2519         margin overlaps with the float. This expansion is not performed for negative margins, since our result is already
2520         correct in that case.
2521         
2522         Reviewed by Dan Bernstein.
2523
2524         Added the new tests from the thread on www-style about this issue (from Alan Gresley and George Talbot)
2525         in fast/block/float.
2526
2527         * rendering/RenderBlock.cpp:
2528         (WebCore::RenderBlock::containsFloat):
2529         * rendering/RenderBlock.h:
2530         (WebCore::RenderBlock::containsFloats):
2531         Changed to be const.
2532
2533         (WebCore::RenderBlock::endOffsetForLine):
2534         (WebCore::RenderBlock::endOffsetForContent):
2535         Added endOffsetForXXX methods to mirror their startOffset counterparts. Used by the width adjustment code.
2536
2537         * rendering/RenderBox.cpp:
2538         (WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
2539         New method that handles shrinking the logical width to the line width (and then re-expanding back out to the
2540         float and/or content edges as needed).
2541
2542         (WebCore::RenderBox::containingBlockLogicalWidthForContent):
2543         (WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
2544         Patched to no longer do the shrinking of objects to avoid floats.
2545
2546         (WebCore::RenderBox::computeLogicalWidthInRegion):
2547         (WebCore::RenderBox::computeLogicalWidthInRegionUsing):
2548         Patched to handle calling the new shrinking code to adjust our logical width.
2549
2550         * rendering/RenderBox.h:
2551         (RenderBox):
2552         The signature of computeLogicalWithUsing changed to be region-specific and to carry along enough information
2553         to efficiently perform the shrinking.
2554
2555         * rendering/RenderTable.cpp:
2556         (WebCore::RenderTable::computeLogicalWidth):
2557         Patched to handle calling the new shrinking code to adjust our logical width.
2558
2559 2012-02-21  Sam Weinig  <sam@webkit.org>
2560
2561         Attempt to fix the Snow Leopard build.
2562
2563         * Configurations/Base.xcconfig:
2564
2565 2012-02-21  Sam Weinig  <sam@webkit.org>
2566
2567         Use libc++ when building with Clang on Mac
2568         https://bugs.webkit.org/show_bug.cgi?id=78981
2569
2570         Reviewed by Dan Bernstein.
2571
2572         * Configurations/Base.xcconfig:
2573
2574 2012-02-21  Adam Roben  <aroben@apple.com>
2575
2576         Mac build fix
2577
2578         * WebCore.xcodeproj/project.pbxproj: Mark TextTrack.h and TextTrackCue.h private so that
2579         WebKit can include them.
2580
2581 2012-02-21  Andras Becsi  <andras.becsi@nokia.com>
2582
2583         [Qt][WK2] Fix the N9 build
2584         https://bugs.webkit.org/show_bug.cgi?id=79101
2585
2586         Reviewed by Noam Rosenthal.
2587
2588         No new tests needed.
2589
2590         * platform/graphics/opengl/TextureMapperGL.cpp: Add missing include.
2591
2592 2012-02-21  Adam Roben  <aroben@apple.com>
2593
2594         Roll out r108309, r108323, and r108326
2595
2596         They broke the 32-bit Lion build.
2597
2598         Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.
2599
2600         * CMakeLists.txt:
2601
2602 2012-02-21  Alexander Pavlov  <apavlov@chromium.org>
2603
2604         Web Inspector: [SuggestBox] textPrompt.css disablement displays garbled suggest box
2605         https://bugs.webkit.org/show_bug.cgi?id=79107
2606
2607         Reviewed by Pavel Feldman.
2608
2609         * inspector/front-end/TextPrompt.js:
2610         (WebInspector.TextPrompt.SuggestBox):
2611         (WebInspector.TextPrompt.SuggestBox.prototype.get visible):
2612         (WebInspector.TextPrompt.SuggestBox.prototype.hide):
2613         (WebInspector.TextPrompt.SuggestBox.prototype.removeFromElement):
2614         (WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
2615         * inspector/front-end/textPrompt.css:
2616         (.suggest-box):
2617
2618 2012-02-21  Yury Semikhatsky  <yurys@chromium.org>
2619
2620         Web Inspector: timeline hangs on a page with deep chain of nested events.
2621         https://bugs.webkit.org/show_bug.cgi?id=79106
2622
2623         Use stack of states instead of recursive calls when traversing records tree to
2624         avoid stack overflow.
2625
2626         Reviewed by Pavel Feldman.
2627
2628         * inspector/front-end/TimelineOverviewPane.js:
2629         (WebInspector.TimelineOverviewPane.prototype._forAllRecords):
2630         * inspector/front-end/TimelinePanel.js:
2631         (WebInspector.TimelinePanel.prototype._filterRecords):
2632
2633 2012-02-21  Pavel Feldman  <pfeldman@google.com>
2634
2635         Web Inspector: [crash] upon style modification after navigation
2636         https://bugs.webkit.org/show_bug.cgi?id=79108
2637
2638         Reviewed by Yury Semikhatsky.
2639
2640         * inspector/InspectorHistory.cpp:
2641         (WebCore::InspectorHistory::undo):
2642         (WebCore::InspectorHistory::redo):
2643         (WebCore::InspectorHistory::reset):
2644
2645 2012-02-21  Patrick Gansterer  <paroga@webkit.org>
2646
2647         Use WTF::cryptographicallyRandomValues in FileSystemWin.cpp
2648         https://bugs.webkit.org/show_bug.cgi?id=79089
2649
2650         Reviewed by Adam Roben.
2651
2652         Avoid loading and unloading of the crypto library during every
2653         call to openTemporaryFile() and make the code easier.
2654
2655         * platform/win/FileSystemWin.cpp:
2656         (WebCore::openTemporaryFile):
2657
2658 2012-02-21  Alexander Færøy  <alexander.faeroy@nokia.com>
2659
2660         Remove stylesheet pointer from StylePropertySet
2661         https://bugs.webkit.org/show_bug.cgi?id=79092
2662
2663         Reviewed by Csaba Osztrogonác.
2664
2665         Qt buildfix after r108345.
2666
2667         * css/CSSParser.cpp:
2668         (WebCore::parseColorValue):
2669
2670 2012-02-21  Csaba Osztrogonác  <ossy@webkit.org>
2671
2672         Remove stylesheet pointer from StylePropertySet
2673         https://bugs.webkit.org/show_bug.cgi?id=79092
2674
2675         Reviewed by Antti Koivisto.
2676
2677         Qt buildfix after r108345. We need this workaround because of buggy gcc (4.4.5), which
2678         reported a false warning: 'value$m_ptr' may be used uninitialized in this function
2679
2680         * css/CSSParser.cpp:
2681         (WebCore::parseSimpleLengthValue):
2682
2683 2012-02-21  Andreas Kling  <awesomekling@apple.com>
2684
2685         Shrink attribute style property sets after populating them.
2686         <http://webkit.org/b/78972>
2687
2688         Reviewed by Antti Koivisto.
2689
2690         Add a StylePropertySet::shrinkToFit() and call it at the end of updateStyleAttribute()
2691         to minimize the amount of wasted space.
2692
2693         * css/StylePropertySet.h:
2694         (WebCore::StylePropertySet::shrinkToFit):
2695         * dom/StyledElement.cpp:
2696         (WebCore::StyledElement::updateAttributeStyle):
2697
2698 2012-02-21  Antti Koivisto  <antti@apple.com>
2699
2700         Remove stylesheet pointer from StylePropertySet
2701         https://bugs.webkit.org/show_bug.cgi?id=79092
2702
2703         Reviewed by Andreas Kling.
2704
2705         The context should be passed as an argument for CSS parser invoking setters that actually need it.
2706         
2707         - Remove the context stylesheet pointer.
2708         - Add context stylesheet argument to setters.
2709         - Drop an unnecessary StylePropertySet constructor, pass strict parsing flag directly.
2710         - Adapt to changes by passing in the context stylesheet where needed.
2711         - Add StyledElement::applyPresentationAttributeToStyle helpers for building up the attribute style.
2712
2713         * css/CSSFontFaceRule.cpp:
2714         (WebCore::CSSFontFaceRule::addSubresourceStyleURLs):
2715         * css/CSSParser.cpp:
2716         (WebCore::parseColorValue):
2717         (WebCore::parseSimpleLengthValue):
2718         (WebCore::CSSParser::parseValue):
2719         (WebCore::CSSParser::parseDeclaration):
2720         (WebCore::CSSParser::createStyleRule):
2721         (WebCore::CSSParser::createFontFaceRule):
2722         (WebCore::CSSParser::createPageRule):
2723         (WebCore::CSSParser::createKeyframeRule):
2724         * css/CSSParser.h:
2725         (CSSParser):
2726         * css/CSSStyleRule.cpp:
2727         (WebCore::CSSStyleRule::addSubresourceStyleURLs):
2728         * css/StylePropertySet.cpp:
2729         (WebCore::PropertySetCSSStyleDeclaration::contextStyleSheet):
2730         (WebCore::PropertySetCSSStyleDeclaration::setNeedsStyleRecalc):
2731         (RuleCSSStyleDeclaration):
2732         (InlineCSSStyleDeclaration):
2733         (WebCore):
2734         (WebCore::StylePropertySet::StylePropertySet):
2735         (WebCore::StylePropertySet::setProperty):
2736         (WebCore::StylePropertySet::parseDeclaration):
2737         (WebCore::StylePropertySet::addSubresourceStyleURLs):
2738         (WebCore::StylePropertySet::clearParentRule):
2739         (WebCore::StylePropertySet::clearParentElement):
2740         (WebCore::PropertySetCSSStyleDeclaration::setCssText):
2741         (WebCore::PropertySetCSSStyleDeclaration::setProperty):
2742         (WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
2743         (WebCore::PropertySetCSSStyleDeclaration::parentStyleSheet):
2744         (WebCore::RuleCSSStyleDeclaration::setNeedsStyleRecalc):
2745         (WebCore::RuleCSSStyleDeclaration::contextStyleSheet):
2746         (WebCore::InlineCSSStyleDeclaration::contextStyleSheet):
2747         (SameSizeAsStylePropertySet):
2748         * css/StylePropertySet.h:
2749         (WebCore::StylePropertySet::create):
2750         (StylePropertySet):
2751         * css/WebKitCSSMatrix.cpp:
2752         (WebCore::WebKitCSSMatrix::setMatrixValue):
2753         * dom/ElementAttributeData.cpp:
2754         (WebCore::ElementAttributeData::ensureInlineStyleDecl):
2755         * dom/StyledElement.cpp:
2756         (WebCore):
2757         (WebCore::StyledElement::parseAttribute):
2758         (WebCore::StyledElement::setInlineStyleProperty):
2759         (WebCore::StyledElement::addSubresourceAttributeURLs):
2760         (WebCore::StyledElement::updateAttributeStyle):
2761         * dom/StyledElement.h:
2762         (StyledElement):
2763         (WebCore::StyledElement::applyPresentationAttributeToStyle):
2764         (WebCore):
2765         * html/HTMLBRElement.cpp:
2766         (WebCore::HTMLBRElement::collectStyleForAttribute):
2767         * html/HTMLBodyElement.cpp:
2768         (WebCore::HTMLBodyElement::collectStyleForAttribute):
2769         * html/HTMLDivElement.cpp:
2770         (WebCore::HTMLDivElement::collectStyleForAttribute):
2771         * html/HTMLElement.cpp:
2772         (WebCore::HTMLElement::applyBorderAttributeToStyle):
2773         (WebCore::HTMLElement::mapLanguageAttributeToLocale):
2774         (WebCore::HTMLElement::collectStyleForAttribute):
2775         (WebCore::HTMLElement::applyAlignmentAttributeToStyle):
2776         (WebCore::HTMLElement::addHTMLLengthToStyle):
2777         (WebCore::HTMLElement::addHTMLColorToStyle):
2778         * html/HTMLElement.h:
2779         (HTMLElement):
2780         * html/HTMLFontElement.cpp:
2781         (WebCore::HTMLFontElement::collectStyleForAttribute):
2782         * html/HTMLHRElement.cpp:
2783         (WebCore::HTMLHRElement::collectStyleForAttribute):
2784         * html/HTMLImageElement.cpp:
2785         (WebCore::HTMLImageElement::collectStyleForAttribute):
2786         * html/HTMLLIElement.cpp:
2787         (WebCore::HTMLLIElement::collectStyleForAttribute):
2788         * html/HTMLMarqueeElement.cpp:
2789         (WebCore::HTMLMarqueeElement::collectStyleForAttribute):
2790         * html/HTMLOListElement.cpp:
2791         (WebCore::HTMLOListElement::collectStyleForAttribute):
2792         * html/HTMLParagraphElement.cpp:
2793         (WebCore::HTMLParagraphElement::collectStyleForAttribute):
2794         * html/HTMLTableCaptionElement.cpp:
2795         (WebCore::HTMLTableCaptionElement::collectStyleForAttribute):
2796         * html/HTMLTableCellElement.cpp:
2797         (WebCore::HTMLTableCellElement::collectStyleForAttribute):
2798         * html/HTMLTableElement.cpp:
2799         (WebCore::HTMLTableElement::collectStyleForAttribute):
2800         * html/HTMLTablePartElement.cpp:
2801         (WebCore::HTMLTablePartElement::collectStyleForAttribute):
2802         * html/HTMLTextAreaElement.cpp:
2803         (WebCore::HTMLTextAreaElement::collectStyleForAttribute):
2804         * html/HTMLUListElement.cpp:
2805         (WebCore::HTMLUListElement::collectStyleForAttribute):
2806         * html/canvas/CanvasRenderingContext2D.cpp:
2807         (WebCore::CanvasRenderingContext2D::setFont):
2808         * mathml/MathMLElement.cpp:
2809         (WebCore::MathMLElement::collectStyleForAttribute):
2810         * svg/SVGFontFaceElement.cpp:
2811         (WebCore::SVGFontFaceElement::insertedIntoDocument):
2812         (WebCore::SVGFontFaceElement::removedFromDocument):
2813         (WebCore::SVGFontFaceElement::removeFromMappedElementSheet):
2814         * svg/SVGImageElement.cpp:
2815         (WebCore::SVGImageElement::collectStyleForAttribute):
2816         * svg/SVGStyledElement.cpp:
2817         (WebCore::SVGStyledElement::collectStyleForAttribute):
2818         * svg/SVGTextContentElement.cpp:
2819         (WebCore::SVGTextContentElement::collectStyleForAttribute):
2820
2821 2012-02-21  Yury Semikhatsky  <yurys@chromium.org>
2822
2823         [V8] Web Inspector: set breakpoint/pause doesn't work when worker is in a tight loop
2824         https://bugs.webkit.org/show_bug.cgi?id=79097
2825
2826         Worker script will be interrupted to dispatch all arriving inspector commands.
2827         This way debugger will be operable even if worker is in a tight loop.
2828
2829         Reviewed by Pavel Feldman.
2830
2831         * bindings/js/ScriptDebugServer.h:
2832         (Task):
2833         (WebCore::ScriptDebugServer::Task::~Task):
2834         (ScriptDebugServer):
2835         * bindings/js/WorkerScriptDebugServer.cpp:
2836         (WebCore::WorkerScriptDebugServer::interruptAndRunTask):
2837         (WebCore):
2838         * bindings/js/WorkerScriptDebugServer.h:
2839         (WorkerScriptDebugServer):
2840         * bindings/v8/ScriptDebugServer.cpp:
2841         (WebCore::ScriptDebugServer::interruptAndRun):
2842         * bindings/v8/ScriptDebugServer.h:
2843         (ScriptDebugServer):
2844         * bindings/v8/WorkerScriptDebugServer.cpp:
2845         (WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
2846         (WebCore::WorkerScriptDebugServer::interruptAndRunTask):
2847         (WebCore):
2848         * bindings/v8/WorkerScriptDebugServer.h:
2849         (v8):
2850         (WebCore):
2851         (WorkerScriptDebugServer):
2852         * inspector/WorkerDebuggerAgent.cpp:
2853         (WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
2854         (WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent):
2855         (WebCore):
2856         (WebCore::WorkerDebuggerAgent::interruptAndDispatchInspectorCommands):
2857         * inspector/WorkerDebuggerAgent.h:
2858         (WebCore):
2859         (WorkerDebuggerAgent):
2860         * workers/WorkerMessagingProxy.cpp:
2861         (WebCore):
2862         (WebCore::WorkerMessagingProxy::sendMessageToInspector):
2863         * workers/WorkerRunLoop.cpp:
2864         (WebCore::WorkerRunLoop::run):
2865         (WebCore::WorkerRunLoop::runInMode):
2866         * workers/WorkerRunLoop.h:
2867         (WorkerRunLoop):
2868
2869 2012-02-21  'Pavel Feldman'  <pfeldman@google.com>
2870
2871         Not reviewed: fixing Mac build (take 2).
2872
2873         * inspector/InspectorPageAgent.cpp:
2874         (WebCore::InspectorPageAgent::setShowPaintRects):
2875
2876 2012-02-21  'Pavel Feldman'  <pfeldman@google.com>
2877
2878         Not reviewed: fixing Mac build.
2879
2880         * inspector/DOMNodeHighlighter.cpp:
2881         (WebCore::DOMNodeHighlighter::drawOutline):
2882         * inspector/DOMNodeHighlighter.h:
2883         (DOMNodeHighlighter):
2884         * inspector/InspectorInstrumentation.cpp:
2885         (WebCore::InspectorInstrumentation::willPaintImpl):
2886         * inspector/InspectorInstrumentation.h:
2887         (InspectorInstrumentation):
2888         (WebCore::InspectorInstrumentation::willPaint):
2889         * inspector/InspectorPageAgent.cpp:
2890         (WebCore::InspectorPageAgent::InspectorPageAgent):
2891         (WebCore::InspectorPageAgent::willPaint):
2892         (WebCore::InspectorPageAgent::didPaint):
2893         * inspector/InspectorPageAgent.h:
2894
2895 2012-02-21  Peter Rybin  <peter.rybin@gmail.com>
2896
2897         Web Inspector: Switch Debugger agent to TypeBuilder
2898         https://bugs.webkit.org/show_bug.cgi?id=78390
2899
2900         Reviewed by Vsevolod Vlasov.
2901
2902         Client code is switched to TypeBuilder.
2903
2904         * inspector/CodeGeneratorInspector.py:
2905         * inspector/InjectedScript.cpp:
2906         (WebCore::InjectedScript::evaluateOnCallFrame):
2907         (WebCore::InjectedScript::getFunctionDetails):
2908         (WebCore::InjectedScript::getProperties):
2909         (WebCore::InjectedScript::wrapCallFrames):
2910         * inspector/InjectedScript.h:
2911         (InjectedScript):
2912         * inspector/InspectorDebuggerAgent.cpp:
2913         (WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
2914         (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
2915         (WebCore::InspectorDebuggerAgent::getFunctionDetails):
2916         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
2917         (WebCore::InspectorDebuggerAgent::currentCallFrames):
2918         (WebCore::InspectorDebuggerAgent::didParseSource):
2919         * inspector/InspectorDebuggerAgent.h:
2920         (InspectorDebuggerAgent):
2921
2922 2012-02-21  'Pavel Feldman'  <pfeldman@google.com>
2923
2924         Not reviewed: fixing poor merge in r108332.
2925
2926         * inspector/front-end/StylesSidebarPane.js:
2927         (WebInspector.StylePropertiesSection.prototype._handleSelectorClick):
2928         * inspector/front-end/externs.js:
2929
2930 2012-02-21  Alexander Pavlov  <apavlov@chromium.org>
2931
2932         Web Inspector: [Styles] Rule source URL tooltip should show line number
2933         https://bugs.webkit.org/show_bug.cgi?id=79087
2934
2935         Reviewed by Pavel Feldman.
2936
2937         * inspector/front-end/StylesSidebarPane.js:
2938         (WebInspector.StylePropertiesSection):
2939         (WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):
2940
2941 2012-02-21  Pavel Feldman  <pfeldman@chomium.org>
2942
2943         Web Inspector: clicking empty space should not re-enter edit mode
2944         https://bugs.webkit.org/show_bug.cgi?id=79024
2945
2946         Reviewed by Vsevolod Vlasov.
2947
2948         * inspector/front-end/StylesSidebarPane.js:
2949         (WebInspector.StylePropertiesSection):
2950         (WebInspector.StylePropertiesSection.prototype._handleEmptySpaceMouseDown):
2951         (WebInspector.StylePropertiesSection.prototype._handleEmptySpaceClick):
2952
2953 2012-02-21  Pavel Feldman  <pfeldman@chomium.org>
2954
2955         Web Inspector: evaluate on hover does not work for large files.
2956         https://bugs.webkit.org/show_bug.cgi?id=79015
2957
2958         Reviewed by Yury Semikhatsky.
2959
2960         * inspector/front-end/JavaScriptSourceFrame.js:
2961         (WebInspector.JavaScriptSourceFrame.prototype._getPopoverAnchor):
2962         (WebInspector.JavaScriptSourceFrame.prototype._highlightExpression):
2963         * inspector/front-end/Popover.js:
2964         (WebInspector.PopoverHelper.prototype._handleMouseAction):
2965         * inspector/front-end/SourceJavaScriptTokenizer.js:
2966         (WebInspector.SourceJavaScriptTokenizer):
2967         (WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
2968         * inspector/front-end/SourceJavaScriptTokenizer.re2js:
2969
2970 2012-02-21  Pavel Feldman  <pfeldman@google.com>
2971
2972         Web Inspector: add "show paint rectangles" setting.
2973         https://bugs.webkit.org/show_bug.cgi?id=79030
2974
2975         Reviewed by Yury Semikhatsky.
2976
2977         * English.lproj/localizedStrings.js:
2978         * inspector/DOMNodeHighlighter.cpp:
2979         (WebCore::DOMNodeHighlighter::drawOutline):
2980         (DOMNodeHighlighter):
2981         * inspector/DOMNodeHighlighter.h:
2982         (WebCore):
2983         (DOMNodeHighlighter):
2984         * inspector/Inspector.json:
2985         * inspector/InspectorController.cpp:
2986         (WebCore::InspectorController::InspectorController):
2987         * inspector/InspectorInstrumentation.cpp:
2988         (WebCore::InspectorInstrumentation::willPaintImpl):
2989         (WebCore::InspectorInstrumentation::didPaintImpl):
2990         * inspector/InspectorInstrumentation.h:
2991         (WebCore):
2992         (InspectorInstrumentation):
2993         (WebCore::InspectorInstrumentation::willPaint):
2994         * inspector/InspectorPageAgent.cpp:
2995         (PageAgentState):
2996         (WebCore::InspectorPageAgent::create):
2997         (WebCore::InspectorPageAgent::InspectorPageAgent):
2998         (WebCore::InspectorPageAgent::setShowPaintRects):
2999         (WebCore):
3000         (WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
3001         (WebCore::InspectorPageAgent::willPaint):
3002         (WebCore::InspectorPageAgent::didPaint):
3003         (WebCore::InspectorPageAgent::buildObjectForFrame):
3004         * inspector/InspectorPageAgent.h:
3005         (WebCore):
3006         * inspector/front-end/Settings.js:
3007         (WebInspector.Settings):
3008         * inspector/front-end/SettingsScreen.js:
3009         (WebInspector.SettingsScreen):
3010         (WebInspector.SettingsScreen.prototype._showPaintRectsChanged):
3011         * inspector/front-end/inspector.js:
3012         * page/FrameView.cpp:
3013         (WebCore::FrameView::paintContents):
3014         * rendering/RenderLayerBacking.cpp:
3015         (WebCore::RenderLayerBacking::paintContents):
3016
3017 2012-02-21  Andras Becsi  <andras.becsi@nokia.com>
3018
3019         [Qt] Clean-up project file after r108310
3020
3021         Reviewed by Csaba Osztrogonác.
3022
3023         No new tests needed.
3024
3025         * Target.pri: Fix path for TextTrack headers.
3026
3027 2012-02-17  Philippe Normand  <pnormand@igalia.com>
3028
3029         [GStreamer] media/W3C failures
3030         https://bugs.webkit.org/show_bug.cgi?id=75078
3031
3032         Reviewed by Martin Robinson.
3033
3034         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
3035         (WebCore::MediaPlayerPrivateGStreamer::load): Clean out everything
3036         after file:// url path to cope with media/W3C tests loading
3037         file:///path/to/media.ext?some parameters.
3038
3039 2012-02-21  Matt Lilek  <mrl@apple.com>
3040
3041         Not reviewed, build fix for non-client-based Geolocation builds after r107982.
3042
3043         * page/Geolocation.cpp:
3044
3045 2012-02-21  Yury Semikhatsky  <yurys@chromium.org>
3046
3047         [V8] Web Inspector: simplify worker debugger implementation
3048         https://bugs.webkit.org/show_bug.cgi?id=79085
3049
3050         There is one instance of WorkerScriptDebugServer per worker thread. We don't
3051         need to resolve WorkerContext from V8::Context anymore.
3052
3053         Reviewed by Pavel Feldman.
3054
3055         * bindings/v8/WorkerScriptDebugServer.cpp:
3056         (WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
3057         (WebCore::WorkerScriptDebugServer::addListener):
3058         (WebCore::WorkerScriptDebugServer::removeListener):
3059         (WebCore::WorkerScriptDebugServer::getDebugListenerForContext):
3060         (WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
3061         * bindings/v8/WorkerScriptDebugServer.h:
3062         (WorkerScriptDebugServer):
3063         * inspector/WorkerDebuggerAgent.cpp:
3064         (WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
3065         (WebCore::WorkerDebuggerAgent::startListeningScriptDebugServer):
3066         (WebCore::WorkerDebuggerAgent::stopListeningScriptDebugServer):
3067
3068 2012-02-21  Kentaro Hara  <haraken@chromium.org>
3069
3070         Enable the IDL attribute checker in Chromium
3071         https://bugs.webkit.org/show_bug.cgi?id=79082
3072
3073         Reviewed by Adam Barth.
3074
3075         We have fixed 10~ bugs caused by typos of IDL attributes.
3076         This patch adds an IDL attribute checker, which checks if all IDL attributes
3077         used in IDL files are implemented by code generators.
3078
3079             - The IDL attribute checker uses IDLAttributes.txt, which lists all
3080               IDL attributes implemented in code generators. If we want to add
3081               a new IDL attribute, we need to add it to IDLAttributes.txt manually.
3082             - The IDL attribute checker checks if all IDL attributes used in IDL files
3083               are listed in IDLAttributes.txt.
3084             - If the IDL attribute checker fails, the build fails with a verbose error message.
3085
3086         No tests. I manually checked that [Custommm], [CallWith=],
3087         [CallWith=ScriptExecutionContext|Foo] cause build failures.
3088
3089         * WebCore.gyp/WebCore.gyp: Modified to enable the IDL attribute checker.
3090
3091         * bindings/scripts/resolve-supplemental.pl:
3092         (loadIDLAttributes): This method loads a list of IDL attributes from IDLAttributes.txt.
3093         (checkIDLAttributes): This method implementes the IDL attribute checker as described above.
3094         (checkIfIDLAttributesExists):
3095
3096         * bindings/scripts/IDLParser.pm: "1" is not good to represent that
3097         the IDL attribute does not have any value. This patch changed it to "VALUE_IS_MISSING".
3098         (parseExtendedAttributes):
3099         (ParseInterface):
3100         * bindings/scripts/CodeGenerator.pm: Ditto.
3101         (ContentAttributeName):
3102         * bindings/scripts/CodeGeneratorV8.pm: Ditto.
3103         (GenerateNormalAttrGetter):
3104         (GenerateNormalAttrSetter):
3105         (GenerateSingleBatchedAttribute):
3106         (GetRuntimeEnableFunctionName):
3107         * bindings/scripts/IDLAttributes.txt: Added. This file lists all IDL attributes implemented
3108         in code generators.
3109
3110 2012-02-21  Patrick Gansterer  <paroga@webkit.org>
3111
3112         Use Win32 API to get file information
3113         https://bugs.webkit.org/show_bug.cgi?id=55336
3114
3115         Reviewed by Adam Roben.
3116
3117         Use FindFirstFile() in favour over _wstat64() to share the code with WinCE.
3118
3119         * platform/win/FileSystemWin.cpp:
3120         (WebCore):
3121         (WebCore::getFindData):
3122         (WebCore::getFileSize):
3123         (WebCore::getFileModificationTime):
3124         (WebCore::fileExists):
3125
3126 2012-02-20  Adam Barth  <abarth@webkit.org>
3127
3128         Invalid cast in WebCore::toElement / WebCore::HTMLElementStack::ElementRecord::element
3129         https://bugs.webkit.org/show_bug.cgi?id=78975
3130
3131         Reviewed by Eric Seidel.
3132
3133         We're supposed to set the action attribute on the form element we just
3134         created.  Previously, we assumed the newly created form element would
3135         be on the top of the stack of open elements, but if we're in the table
3136         body insertion mode, the form element gets treated as self closing and
3137         is therefore popped off the stack of open elements.
3138
3139         Fortunately, we already cache a pointer to the most recently inserted
3140         form element on the HTMLConstructionSite, so we can just grab the
3141         element from there.
3142
3143         Test: html5lib/runner.html
3144
3145         * html/parser/HTMLTreeBuilder.cpp:
3146         (WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
3147         (WebCore):
3148
3149 2012-02-20  Adam Barth  <abarth@webkit.org>
3150
3151         Unite TextTrack-related files with their friends in WebCore/html/track
3152         https://bugs.webkit.org/show_bug.cgi?id=78941
3153
3154         Reviewed by Eric Seidel.
3155
3156         The code that supports <track> seems to be split between the
3157         WebCore/html directory and the WebCore/html/track directory.  This
3158         patch unites this code in the WebCore/html/track directory.
3159
3160         * CMakeLists.txt:
3161         * DerivedSources.make:
3162         * DerivedSources.pri:
3163         * GNUmakefile.list.am:
3164         * WebCore.gypi:
3165         * WebCore.xcodeproj/project.pbxproj:
3166         * html/LoadableTextTrack.cpp: Removed.
3167         * html/LoadableTextTrack.h: Removed.
3168         * html/TextTrack.cpp: Removed.
3169         * html/TextTrack.h: Removed.
3170         * html/TextTrack.idl: Removed.
3171         * html/TextTrackCue.cpp: Removed.
3172         * html/TextTrackCue.h: Removed.
3173         * html/TextTrackCue.idl: Removed.
3174         * html/TextTrackCueList.cpp: Removed.
3175         * html/TextTrackCueList.h: Removed.
3176         * html/TextTrackCueList.idl: Removed.
3177         * html/track/LoadableTextTrack.cpp: Copied from Source/WebCore/html/LoadableTextTrack.cpp.
3178         * html/track/LoadableTextTrack.h: Copied from Source/WebCore/html/LoadableTextTrack.h.
3179         * html/track/TextTrack.cpp: Copied from Source/WebCore/html/TextTrack.cpp.
3180         * html/track/TextTrack.h: Copied from Source/WebCore/html/TextTrack.h.
3181         * html/track/TextTrack.idl: Copied from Source/WebCore/html/TextTrack.idl.
3182         * html/track/TextTrackCue.cpp: Copied from Source/WebCore/html/TextTrackCue.cpp.
3183         * html/track/TextTrackCue.h: Copied from Source/WebCore/html/TextTrackCue.h.
3184         * html/track/TextTrackCue.idl: Copied from Source/WebCore/html/TextTrackCue.idl.
3185         * html/track/TextTrackCueList.cpp: Copied from Source/WebCore/html/TextTrackCueList.cpp.
3186         * html/track/TextTrackCueList.h: Copied from Source/WebCore/html/TextTrackCueList.h.
3187         * html/track/TextTrackCueList.idl: Copied from Source/WebCore/html/TextTrackCueList.idl.
3188
3189 2012-02-20  Filip Pizlo  <fpizlo@apple.com>
3190
3191         JSC should be a triple-tier VM
3192         https://bugs.webkit.org/show_bug.cgi?id=75812
3193         <rdar://problem/10079694>
3194
3195         Reviewed by Gavin Barraclough.
3196         
3197         No new tests, because there is no change in behavior.
3198
3199         * CMakeLists.txt:
3200
3201 2012-02-20  Benjamin Poulain  <benjamin@webkit.org>
3202
3203         Get rid of the LocalizationStrategy
3204         https://bugs.webkit.org/show_bug.cgi?id=78324
3205
3206         Reviewed by Sam Weinig.
3207
3208         Remove LocalizationStrategy and unify the localization behind
3209         LocalizedStrings.h and LocalizedStrings.cpp.
3210
3211         * CMakeLists.txt:
3212         * GNUmakefile.list.am:
3213         * Target.pri:
3214         * WebCore.exp.in:
3215         * WebCore.gypi:
3216         * WebCore.order:
3217         * WebCore.vcproj/WebCore.vcproj:
3218         * WebCore.xcodeproj/project.pbxproj:
3219         * platform/DefaultLocalizationStrategy.cpp: Removed.
3220         * platform/DefaultLocalizationStrategy.h: Removed.
3221         * platform/LocalizationStrategy.h: Removed.
3222         * platform/LocalizedStrings.cpp:
3223         * platform/LocalizedStrings.h:
3224         (WebCore):
3225         * platform/PlatformStrategies.cpp:
3226         * platform/PlatformStrategies.h:
3227         (WebCore):
3228         (WebCore::PlatformStrategies::PlatformStrategies):
3229         (PlatformStrategies):
3230         * platform/qt/LocalizedStringsQt.cpp: Copied from Source/WebKit/qt/WebCoreSupport/PlatformStrategiesQt.cpp.
3231
3232 2012-02-20  Kentaro Hara  <haraken@chromium.org>
3233
3234         Remove [TreatReturnedNullStringAsNull] from HTMLMediaElement.mediaGroup
3235         https://bugs.webkit.org/show_bug.cgi?id=79064
3236
3237         Reviewed by Hajime Morita.
3238
3239         [TreatReturnedNullStringAsNull] is a typo of [TreatReturnedNullStringAs=Null].
3240         But as far as I read the spec
3241         (http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#attr-media-mediagroup),
3242         there is no statement about what value should be returned when HTMLMediaElement.mediaGroup
3243         is not yet initialized. In particular, there is no statement that says "null should
3244         be returned when HTMLMediaElement.mediaGroup is not initialized". Thus, instead of
3245         fixing the typo, just removing [TreatReturnedNullStringAsNull] would make sense.
3246         Removing [TreatReturnedNullStringAsNull] does not change the current behavior.
3247
3248         Test: media/media-controller.html (No change in the test results.)
3249
3250         * html/HTMLMediaElement.idl:
3251
3252 2012-02-20  Hayato Ito  <hayato@chromium.org>
3253
3254         Use InsertinonPoint instead of HTMLContentElement.
3255         https://bugs.webkit.org/show_bug.cgi?id=78778
3256
3257         Reviewed by Hajime Morita.
3258
3259         Replace HTMLContentElement with InsertionPoint in NodeRenderingContext and HTMLContentSelection.
3260         This is one of followup patches for r108207.
3261
3262         No new tests, no change in behavior.
3263
3264         * dom/NodeRenderingContext.cpp:
3265         (WebCore::nextRendererOf):
3266         (WebCore::previousRendererOf):
3267         (WebCore::firstRendererOf):
3268         (WebCore::lastRendererOf):
3269         * dom/NodeRenderingContext.h:
3270         (WebCore):
3271         (NodeRenderingContext):
3272         (WebCore::NodeRenderingContext::insertionPoint):
3273         * dom/ShadowRoot.cpp:
3274         (WebCore::ShadowRoot::insertionPointFor):
3275         * dom/ShadowRoot.h:
3276         (WebCore):
3277         * html/shadow/HTMLContentElement.cpp:
3278         (WebCore::HTMLContentElement::HTMLContentElement):
3279         (WebCore::HTMLContentElement::attach):
3280         (WebCore::HTMLContentElement::detach):
3281         * html/shadow/HTMLContentElement.h:
3282         (HTMLContentElement):
3283         * html/shadow/HTMLContentSelector.cpp:
3284         (WebCore::HTMLContentSelector::select):
3285         * html/shadow/HTMLContentSelector.h:
3286         (WebCore):
3287         (HTMLContentSelection):
3288         (WebCore::HTMLContentSelection::insertionPoint):
3289         (WebCore::HTMLContentSelection::HTMLContentSelection):
3290         (WebCore::HTMLContentSelection::create):
3291         * html/shadow/InsertionPoint.cpp:
3292         (WebCore::InsertionPoint::InsertionPoint):
3293         * html/shadow/InsertionPoint.h:
3294         (WebCore::InsertionPoint::selections):
3295         (WebCore::InsertionPoint::hasSelection):
3296         (InsertionPoint):
3297
3298 2012-02-20  David Barton  <dbarton@mathscribe.com>
3299
3300         MathML internals - code clean-up for RenderMathMLSubSup
3301         https://bugs.webkit.org/show_bug.cgi?id=79063
3302
3303         Reviewed by Eric Seidel.
3304
3305         In the next patch, I will shrink and revise the <msubsup> formatting code. To make this
3306         easier to follow, I am first doing some simple code clean-up.
3307
3308         No new tests.
3309
3310         * rendering/mathml/RenderMathMLRow.cpp:
3311         (WebCore::RenderMathMLRow::layout):
3312         * rendering/mathml/RenderMathMLRow.h:
3313         (WebCore::RenderMathMLRow::isRenderMathMLRow):
3314         * rendering/mathml/RenderMathMLSubSup.cpp:
3315         (WebCore::RenderMathMLSubSup::stretchToHeight):
3316         (WebCore::RenderMathMLSubSup::layout):
3317             - There is no need to iterate over baseWrapper's children since it should have only
3318               one child, the base of the <msubsup>.
3319
3320 2012-02-20  Kentaro Hara  <haraken@chromium.org>
3321
3322         Replace [V8Custom=DOMWindowNOP] with [V8Custom]
3323         https://bugs.webkit.org/show_bug.cgi?id=79062
3324
3325         Reviewed by Adam Barth.
3326
3327         [V8Custom=DOMWindowNOP] is not implemented by CodeGeneratorV8.pm.
3328         This patch replaces it with [V8Custom].
3329
3330         No new tests. No change in behavior.
3331
3332         * page/DOMWindow.idl:
3333
3334 2012-02-20  Kentaro Hara  <haraken@chromium.org>
3335
3336         [JSGenerateIsReachable=ImplRoot] is not implemented, it should be [JSGenerateIsReachable]
3337         https://bugs.webkit.org/show_bug.cgi?id=79061
3338
3339         Reviewed by Adam Barth.
3340
3341         CSSStyleDeclaration.idl uses [JSGenerateIsReachable=ImplRoot],
3342         but "ImplRoot" is not implemented in CodeGeneratorJS.pm.
3343         This patch replaces [JSGenerateIsReachable=ImplRoot] with [JSGenerateIsReachable].
3344
3345         No tests. No change in behavior.
3346
3347         * css/CSSStyleDeclaration.idl:
3348
3349 2012-02-20  Kentaro Hara  <haraken@chromium.org>
3350
3351         [EnabledAtRuntime] in HTMLShadowElement.idl should be [V8EnabledAtRuntime]
3352         https://bugs.webkit.org/show_bug.cgi?id=79058
3353
3354         Reviewed by Adam Barth.
3355
3356         [EnabledAtRuntime] does not exist any longer. It should be [V8EnabledAtRuntime].
3357
3358         No tests.
3359
3360         * html/shadow/HTMLShadowElement.idl:
3361
3362 2012-02-20  Kentaro Hara  <haraken@chromium.org>
3363
3364         Replace [Callback=FunctionOnly] with [Callback]
3365         https://bugs.webkit.org/show_bug.cgi?id=79060
3366
3367         Reviewed by Adam Barth.
3368
3369         [Callback=FunctionOnly] is not implemented by any code generator.
3370         This patch replaces it with [Callback].
3371
3372         No tests. No change in behavior.
3373
3374         * Modules/intents/IntentResultCallback.idl:
3375         * Modules/intents/NavigatorIntents.idl:
3376         * dom/RequestAnimationFrameCallback.idl:
3377         * mediastream/NavigatorMediaStream.idl:
3378         * mediastream/NavigatorUserMediaErrorCallback.idl:
3379         * mediastream/NavigatorUserMediaSuccessCallback.idl:
3380         * mediastream/PeerConnection.idl:
3381         * mediastream/SignalingCallback.idl:
3382         * page/PositionCallback.idl:
3383         * page/PositionErrorCallback.idl:
3384
3385 2012-02-20  Andy Chen  <andchen@rim.com>
3386
3387         2012-02-17  Andy Chen  <andchen@rim.com>
3388
3389         [BlackBerry] Need to override active/inactive text search highlight color for RenderThemeBlackBerry
3390         https://bugs.webkit.org/show_bug.cgi?id=78920
3391
3392         Override two functions for text search highlight colors so that we can
3393         provide platform specified colors.
3394
3395         Reviewed by Antonio Gomes.
3396
3397         No function change so no new tests.
3398
3399         * platform/blackberry/RenderThemeBlackBerry.cpp:
3400         (WebCore::RenderThemeBlackBerry::platformActiveTextSearchHighlightColor):
3401         (WebCore::RenderThemeBlackBerry::platformInactiveTextSearchHighlightColor):
3402         * platform/blackberry/RenderThemeBlackBerry.h:
3403
3404 2012-02-20  John Knottenbelt  <jknotten@chromium.org>
3405
3406         Default canvas backing store to be 1:1 with specified dimensions.
3407         https://bugs.webkit.org/show_bug.cgi?id=78971
3408
3409         Reviewed by Adam Barth.
3410
3411         Although the canvas specification states that the backing image may
3412         be larger than the user-specified dimensions, there are a number of
3413         philip canvas tests that fail when the backing image data is not
3414         1:1 with the specified canvas dimensions. These failures are
3415         tracked in https://bugs.webkit.org/show_bug.cgi?id=73645
3416
3417         This change defaults the canvas backing store to be 1:1 with the
3418         user-specified dimensions, while also providing an
3419         ENABLE(HIGH_DPI_CANVAS) build option to reinstate the original
3420         behaviour, so that the above bug may be more easily fixed.
3421
3422         * html/HTMLCanvasElement.cpp:
3423         (WebCore::HTMLCanvasElement::HTMLCanvasElement):
3424
3425 2012-02-20  Mary Wu  <mary.wu@torchmobile.com.cn>
3426
3427         Upstream RenderThemeBlackberry.h/.cpp into WebCore/platform/blackberry
3428         https://bugs.webkit.org/show_bug.cgi?id=78785
3429
3430         Main Contributors:
3431         Daniel Bates <dbates@rim.com>
3432         Bryan Gislason <bgislason@rim.com>
3433         Akash Vaswani <akvaswani@rim.com>
3434         Dave Battista <dbattista@rim.com>
3435         Robin Cao  <robin.cao@torchmobile.com.cn>
3436         Genevieve Mak <gmak@rim.com>
3437         Mike Fenton  <mifenton@rim.com>
3438
3439         Reviewed by Antonio Gomes.
3440
3441         Initial upstream, no new tests.
3442
3443         * platform/blackberry/RenderThemeBlackBerry.cpp: Added.
3444         * platform/blackberry/RenderThemeBlackBerry.h: Added.
3445
3446 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
3447
3448         [GTK] [EFL] Collapse duplicate WebGL support code
3449         https://bugs.webkit.org/show_bug.cgi?id=78970
3450
3451         Reviewed by Gustavo Noronha Silva.
3452
3453         No new tests. This just cleans up duplicated code.
3454
3455         Centralize duplicated WebGL code for EFL and GTK+ in the Cairo
3456         directory. This is in preparation for the changes necessary to
3457         connect WebGL to the TextureMapper AC.
3458
3459         * GNUmakefile.list.am: Update source list.
3460         * PlatformEfl.cmake: Update source list.
3461         * platform/graphics/cairo/DrawingBufferCairo.cpp: Renamed from Source/WebCore/platform/graphics/gtk/DrawingBufferGtk.cpp.
3462         * platform/graphics/cairo/GraphicsContext3DCairo.cpp: Integrated the code From GraphicsContext3DGtk.cpp.
3463         * platform/graphics/efl/DrawingBufferEfl.cpp: Removed.
3464         * platform/graphics/efl/GraphicsContext3DEfl.cpp: Removed.
3465         * platform/graphics/gtk/GraphicsContext3DGtk.cpp: Removed.
3466
3467 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
3468
3469         [UNIX] Plugin information fields are not interpreted as UTF-8
3470         https://bugs.webkit.org/show_bug.cgi?id=78635
3471
3472         Reviewed by Gustavo Noronha Silva.
3473
3474         Interpret plugin metadata as UTF8 aways. This matches the behavior
3475         of Chromium and the Totem plugin.
3476
3477         This is tested by a change to TestNetscapePlugin and expectations updates.
3478
3479         * plugins/efl/PluginPackageEfl.cpp:
3480         (WebCore::PluginPackage::fetchInfo): Use String::fromUTF8.
3481         * plugins/gtk/PluginPackageGtk.cpp:
3482         (WebCore::PluginPackage::fetchInfo): Use String::fromUTF8.
3483         * plugins/qt/PluginPackageQt.cpp:
3484         (WebCore::PluginPackage::fetchInfo): Use String::fromUTF8.
3485
3486 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
3487
3488         [GTK] Web content oftens steals focus from other widgets
3489         https://bugs.webkit.org/show_bug.cgi?id=77791
3490
3491         Reviewed by Gustavo Noronha Silva.
3492
3493         * platform/gtk/WidgetGtk.cpp:
3494         (WebCore::Widget::setFocus): No longer do anything special to try
3495         to grab "real" widget focus. This matches the behavior on Qt.
3496         * plugins/gtk/PluginViewGtk.cpp:
3497         (WebCore::PluginView::setFocus): Moved the focus handling to here.
3498         This ensures that behavior for plugins does not change.
3499
3500 2012-02-20  Yael Aharon  <yael.aharon@nokia.com>
3501
3502         Regression (108135) isOpaque() returns uninitialized variable.
3503         https://bugs.webkit.org/show_bug.cgi?id=79049
3504
3505         Reviewed by Noam Rosenthal.
3506
3507         isOpaque() should use the new m_flags instead of the old m_isOpaque.
3508         No new tests. No new functionality.
3509
3510         * platform/graphics/texmap/TextureMapper.h:
3511         (WebCore::BitmapTexture::reset):
3512         (WebCore::BitmapTexture::isOpaque):
3513         (BitmapTexture):
3514