Add missing ifdef for JAVASCRIPT_DEBUGGER feature.
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-10-10  Nayan Kumar K  <nayankk@motorola.com>
2
3         Add missing ifdef for JAVASCRIPT_DEBUGGER feature.
4         https://bugs.webkit.org/show_bug.cgi?id=69758
5
6         Reviewed by Adam Barth.
7
8         No new tests added since this is a build failure fix.
9
10         * bindings/v8/custom/V8ScriptProfileCustom.cpp:
11         * bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
12
13 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
14
15         REGRESSION(96070) 25% intl1 PLT regression from scrollbar invalidation
16         https://bugs.webkit.org/show_bug.cgi?id=69238
17
18         Reviewed by Darin Adler.
19
20         Fix PLT regression from additional scrollbars invalidations.
21         
22         Don't invalidate the scrollbar rect from setHasHorizontalScrollbar()
23         and setHasVerticalScrollbar(), because this is called during FrameView
24         teardown, at which point the invalidation is redundant.
25         
26         Instead, invalidate from ScrollView::updateScrollbars(), which is
27         called only when scrollbars change because of size or layout
28         changes.
29
30         * platform/ScrollView.cpp:
31         (WebCore::ScrollView::setHasHorizontalScrollbar):
32         (WebCore::ScrollView::setHasVerticalScrollbar):
33         (WebCore::ScrollView::updateScrollbars):
34
35 2011-10-10  Abhishek Arya  <inferno@chromium.org>
36
37         Style for updated due to inability to locate
38         :before content in presence of listmarkers and runins.
39         https://bugs.webkit.org/show_bug.cgi?id=68624
40
41         Reviewed by Dan Bernstein.
42
43         Tests: fast/lists/inline-before-content-after-list-marker.html
44                fast/runin/runin-between-list-marker-and-before-content.html
45                fast/runin/runin-into-div-with-float-child.html
46                fast/runin/runin-not-go-into-float.html
47
48         * rendering/RenderBlock.cpp:
49         (WebCore::RenderBlock::handleRunInChild): Fix as per spec that
50         we should not be skipping over floating/positioned renderers to
51         push runins into neighbouring block. This matches Opera renderings.
52         * rendering/RenderObject.cpp: Add const to parameter variable
53         to make call from beforePseudoElementRenderer easier. Also matches
54         CounterNode.h definition.
55         (WebCore::RenderObject::nextInPreOrder):
56         (WebCore::RenderObject::nextInPreOrderAfterChildren):
57         * rendering/RenderObject.h: Same const addition.
58         * rendering/RenderObjectChildList.cpp:
59         (WebCore::RenderObjectChildList::beforePseudoElementRenderer):
60         Remove skipping of floating/positioned renderers, similar to
61         handleRunIn. Revert code change in r94857 and add better next
62         sibling iterator. This addresses the layouttest in r94857 where
63         :before content is in its own anonymous rendertable.
64
65 2011-10-10  Abhishek Arya  <inferno@chromium.org>
66
67         Handle insertion into an anonymous table part that
68         is followed by a non-anonymous block correctly.
69         https://bugs.webkit.org/show_bug.cgi?id=69536
70
71         Reviewed by Dan Bernstein.
72
73         Tests: fast/table/table-insert-before-non-anonymous-block.html
74
75         * rendering/RenderTable.cpp:
76         (WebCore::RenderTable::addChild):
77         * rendering/RenderTableRow.cpp:
78         (WebCore::RenderTableRow::addChild):
79         * rendering/RenderTableSection.cpp:
80         (WebCore::RenderTableSection::addChild):
81         (WebCore::RenderTableSection::splitColumn):
82
83 2011-10-10  Kent Tamura  <tkent@chromium.org>
84
85         Make static functions in HTMLSelectElement.cpp member functions of HTMLSelectElement class
86         https://bugs.webkit.org/show_bug.cgi?id=69755
87
88         Reviewed by Ryosuke Niwa.
89
90         
91         No new tests, just a refactoring.
92
93         * html/HTMLSelectElement.cpp:
94         (WebCore::HTMLSelectElement::nextValidIndex):
95         Make this a static member function of HTMLSelectElement.
96         (WebCore::HTMLSelectElement::nextSelectableListIndex):
97         Make this a member function of HTMLSelectElement.
98         (WebCore::HTMLSelectElement::previousSelectableListIndex): ditto.
99         (WebCore::HTMLSelectElement::firstSelectableListIndex): ditto.
100         (WebCore::HTMLSelectElement::lastSelectableListIndex): ditto.
101         (WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): ditto.
102         (WebCore::HTMLSelectElement::selectAll): Update callsite of the above functions.
103         (WebCore::HTMLSelectElement::setSelectedIndexInternal): ditto.
104         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
105         * html/HTMLSelectElement.h:
106          - Add the above function declarations.
107          - Move SkipDirection definition from HTMLSelectElement.cpp.
108
109 2011-10-10  Pavel Feldman  <pfeldman@google.com>
110
111         Web Inspector: annotate DOMAgent, Debugger(Presentation)Model with types.
112         https://bugs.webkit.org/show_bug.cgi?id=69726
113
114         Reviewed by Yury Semikhatsky.
115
116         * inspector/compile-front-end.sh:
117         * inspector/front-end/ApplicationCacheItemsView.js:
118         (WebInspector.ApplicationCacheItemsView):
119         * inspector/front-end/AuditsPanel.js:
120         (WebInspector.AuditsPanel):
121         * inspector/front-end/BreakpointManager.js:
122         (WebInspector.BreakpointManager.prototype._breakpointResolved):
123         * inspector/front-end/CSSStyleModel.js:
124         * inspector/front-end/CompilerSourceMapping.js:
125         (WebInspector.CompilerSourceMapping.prototype.compiledLocationToSourceLocation):
126         (WebInspector.CompilerSourceMapping.prototype.sourceLocationToCompiledLocation):
127         (WebInspector.CompilerSourceMapping.prototype.sources):
128         * inspector/front-end/ConsoleView.js:
129         (WebInspector.ConsoleView.prototype._completions.evaluated):
130         (WebInspector.ConsoleView.prototype._completions.receivedPropertyNamesFromEval):
131         (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
132         * inspector/front-end/CookieItemsView.js:
133         (WebInspector.CookieItemsView):
134         * inspector/front-end/DOMAgent.js:
135         (WebInspector.DOMNode.prototype.isXMLNode):
136         (WebInspector.DOMDocument):
137         (WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable.onDocumentAvailable):
138         (WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable):
139         (WebInspector.DOMDispatcher.prototype.characterDataModified):
140         (WebInspector.DOMDispatcher.prototype.childNodeCountUpdated):
141         (WebInspector.DOMDispatcher.prototype.childNodeInserted):
142         (WebInspector.DOMDispatcher.prototype.childNodeRemoved):
143         * inspector/front-end/DOMStorageItemsView.js:
144         (WebInspector.DOMStorageItemsView):
145         * inspector/front-end/DatabaseTableView.js:
146         (WebInspector.DatabaseTableView):
147         * inspector/front-end/DebuggerModel.js:
148         (WebInspector.DebuggerModel):
149         (WebInspector.DebuggerPausedDetails):
150         (WebInspector.DebuggerModel.prototype.reset):
151         (WebInspector.DebuggerModel.prototype.get callFrames):
152         (WebInspector.DebuggerModel.prototype._pausedScript):
153         (WebInspector.DebuggerModel.prototype._resumedScript):
154         (WebInspector.DebuggerModel.prototype._parsedScriptSource):
155         (WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
156         (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
157         (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
158         * inspector/front-end/DebuggerPresentationModel.js:
159         (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
160         (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
161         (WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
162         (WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
163         (WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
164         (WebInspector.DebuggerPresentationModel.prototype._createPresentationMessage):
165         (WebInspector.PresentationConsoleMessage):
166         (WebInspector.PresentationCallFrame.prototype.evaluate):
167         (WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateSourceAnchors):
168         * inspector/front-end/ElementsPanel.js:
169         (WebInspector.ElementsPanel):
170         (WebInspector.ElementsPanel.prototype._documentUpdated.selectLastSelectedNode):
171         (WebInspector.ElementsPanel.prototype._documentUpdated):
172         * inspector/front-end/NetworkPanel.js:
173         * inspector/front-end/Object.js:
174         (WebInspector.Object.prototype.dispatchEventToListeners):
175         (WebInspector.Event):
176         (WebInspector.Event.prototype.stopPropagation):
177         (WebInspector.Event.prototype.preventDefault):
178         * inspector/front-end/RawSourceCode.js:
179         (WebInspector.RawSourceCode.SourceMapping):
180         (WebInspector.RawSourceCode.SourceMapping.prototype.rawLocationToUILocation):
181         (WebInspector.RawSourceCode.SourceMapping.prototype.uiLocationToRawLocation):
182         (WebInspector.RawSourceCode.PlainSourceMapping.prototype.rawLocationToUILocation):
183         (WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
184         (WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
185         (WebInspector.RawSourceCode.CompilerSourceMapping.prototype.rawLocationToUILocation):
186         (WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):
187         * inspector/front-end/Script.js:
188         (WebInspector.Script):
189         (WebInspector.Script.prototype.requestSource):
190         (WebInspector.Script.prototype.searchInContent):
191         (WebInspector.Script.prototype.editSource):
192         * inspector/front-end/ScriptsPanel.js:
193         (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
194         * inspector/front-end/TimelinePanel.js:
195         (WebInspector.TimelinePanel.prototype._createStatusbarButtons):
196         * inspector/front-end/UISourceCode.js:
197         (WebInspector.UISourceCode):
198         (WebInspector.ContentProvider.SearchMatch):
199         * inspector/front-end/WatchExpressionsSidebarPane.js:
200         (WebInspector.WatchExpressionsSection.prototype.update):
201         * inspector/front-end/externs.js:
202         * inspector/generate-protocol-externs:
203
204 2011-10-10  Ilya Tikhonovsky  <loislo@chromium.org>
205
206         Web Inspector: Linkifier.reset throw an exception if it is called after reset of debuggerPresentationModel.
207         https://bugs.webkit.org/show_bug.cgi?id=69756
208
209         Reviewed by Yury Semikhatsky.
210
211         * inspector/front-end/DebuggerPresentationModel.js:
212         (WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
213
214 2011-09-28  Pavel Podivilov  <podivilov@chromium.org>
215
216         Web Inspector: RawSourceCode could be mapped to multiple sources.
217         https://bugs.webkit.org/show_bug.cgi?id=68526
218
219         Replace SourceMapping.uiSourceCode with SourceMapping.uiSourceCodeList as there could be more
220         then one UISourceCode associated with a RawSourceCode.
221
222         Reviewed by Pavel Feldman.
223
224         * inspector/front-end/DebuggerPresentationModel.js:
225         (WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
226         (WebInspector.DebuggerPresentationModel.prototype._updateSourceMapping):
227         (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
228         (WebInspector.PresentationCallFrame.prototype.get url):
229         (WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
230         (WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
231         * inspector/front-end/ScriptsPanel.js:
232         (WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
233         * inspector/front-end/SourceFile.js:
234         (WebInspector.RawSourceCode.prototype._saveSourceMapping):
235         (WebInspector.RawSourceCode.PlainSourceMapping):
236         (WebInspector.RawSourceCode.PlainSourceMapping.prototype.rawLocationToUILocation):
237         (WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiSourceCodeList):
238         (WebInspector.RawSourceCode.FormattedSourceMapping):
239         (WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
240         (WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiSourceCodeList):
241
242 2011-10-10  Andreas Kling  <kling@webkit.org>
243
244         Shrink RenderLayer and ScrollableArea.
245         https://bugs.webkit.org/show_bug.cgi?id=69759
246
247         Reviewed by Antti Koivisto.
248
249         Rearrange the members of RenderLayer and its base class ScrollableArea
250         to maximize struct packing, shrinking RenderLayer by one CPU word on
251         32-bit (and two on 64-bit.)
252
253         This reduces memory consumption by 134 kB (on 64-bit) when loading the
254         full HTML5 spec.
255
256         * platform/ScrollableArea.h:
257         (WebCore::ScrollableArea::verticalScrollElasticity):
258         (WebCore::ScrollableArea::horizontalScrollElasticity):
259         (WebCore::ScrollableArea::scrollbarOverlayStyle):
260
261             Cast the now-bitfield members to the appropriate enum types.
262
263         * rendering/RenderLayer.h:
264         * rendering/RenderLayer.cpp:
265         (WebCore::RenderLayer::RenderLayer):
266
267             Move shouldBeNormalFlowOnly() call out of initializer list since it
268             depends on m_renderer being initialized.
269
270 2011-10-10  Cary Clark  <caryclark@google.com>
271
272         [Skia on Chromium Mac] Set canExpandAroundIdeographsInComplexText to true
273         https://bugs.webkit.org/show_bug.cgi?id=69656
274         https://bugs.webkit.org/show_bug.cgi?id=62987
275         https://bugs.webkit.org/show_bug.cgi?id=62889
276
277         Reviewed by Stephen White.
278
279         Skia on Linux and Windows uses different font engines from
280         Skia on Mac. After determining that the underlying CoreText
281         can handle it, enabling this allows justification to work
282         correctly.
283
284         Tests: fast/text/justify-ideograph-complex.html
285
286         * platform/graphics/skia/FontSkia.cpp:
287         (WebCore::Font::canExpandAroundIdeographsInComplexText):
288
289 2011-10-10  Ilya Tikhonovsky  <loislo@chromium.org>
290
291         Web Inspector: memory leak in Resource panel.
292         https://bugs.webkit.org/show_bug.cgi?id=69754
293
294         Reviewed by Yury Semikhatsky.
295
296         * inspector/front-end/ResourcesPanel.js:
297         (WebInspector.ResourcesPanel.prototype.reset):
298         * inspector/front-end/View.js:
299         (WebInspector.View.prototype.childViews):
300
301 2011-10-06  Pavel Podivilov  <podivilov@chromium.org>
302
303         Web Inspector: saving JavaScript after live edit resets scroller position.
304         https://bugs.webkit.org/show_bug.cgi?id=69340
305
306         Do not recreate SourceFrame when content is changed. Instead, update text model in existing SourceFrame.
307
308         Reviewed by Yury Semikhatsky.
309
310         * inspector/front-end/DebuggerPresentationModel.js:
311         (WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
312         (WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
313         * inspector/front-end/JavaScriptSourceFrame.js:
314         (WebInspector.JavaScriptSourceFrame):
315         * inspector/front-end/RawSourceCode.js:
316         (WebInspector.RawSourceCode.prototype.setCompilerSourceMappingProvider):
317         * inspector/front-end/SourceFrame.js:
318         (WebInspector.SourceFrame.prototype._setReadOnly):
319         (WebInspector.SourceFrame.prototype.contentChanged):
320         * inspector/front-end/UISourceCode.js:
321         (WebInspector.UISourceCode.prototype.contentChanged):
322
323 2011-10-10  Ilya Tikhonovsky  <loislo@chromium.org>
324
325         Unreviewed test fix for r97050.
326
327         * inspector/front-end/DebuggerPresentationModel.js:
328         (WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
329
330 2011-10-10  Andreas Kling  <kling@webkit.org>
331
332         Shrink RenderListItem on 64-bit.
333         https://bugs.webkit.org/show_bug.cgi?id=69751
334
335         Reviewed by Kenneth Rohde Christiansen.
336
337         Rearrange members to utilize the padding at the end of RenderBlock.
338         This shrinks RenderListItem by 8 bytes on 64-bit, reducing memory consumption
339         by 60 kB when loading the full HTML5 spec.
340
341         * rendering/RenderListItem.h:
342
343 2011-10-10  Andreas Kling  <kling@webkit.org>
344
345         Shrink RootInlineBox.
346         https://bugs.webkit.org/show_bug.cgi?id=69707
347
348         Reviewed by Antti Koivisto.
349
350         Move the bitfields from RootInlineBox up into its base class (InlineFlowBox.)
351         This shrinks RootInlineBox by one CPU word without growing InlineFlowBox.
352         Enum bitfields were changed to "unsigned" for the MSVC signedness quirk.
353
354         Also move one 32-bit member to the head of RootInlineBox so it falls into the
355         padding at the end of InlineFlowBox on 64-bit.
356
357         This reduces memory consumption by 780 kB (on 64-bit) when loading the full
358         HTML5 spec.
359
360         * rendering/InlineFlowBox.h:
361         (WebCore::InlineFlowBox::InlineFlowBox):
362         * rendering/RootInlineBox.cpp:
363         (WebCore::RootInlineBox::RootInlineBox):
364         (WebCore::RootInlineBox::lineBreakBidiStatus):
365         * rendering/RootInlineBox.h:
366
367 2011-10-10  Pavel Podivilov  <podivilov@chromium.org>
368
369         Unreviewed, attempt to fix chromium mac build after r97034.
370
371         * platform/ScrollAnimatorNone.h:
372
373 2011-10-10  Ilya Tikhonovsky  <loislo@chromium.org>
374
375         Web Inspector: small memory leak in scripts panel.
376         https://bugs.webkit.org/show_bug.cgi?id=69744
377
378         Scripts panel doesn't clean the list of child views.
379
380         Reviewed by Yury Semikhatsky.
381
382         * inspector/front-end/DebuggerPresentationModel.js:
383         (WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
384         * inspector/front-end/ScriptsPanel.js:
385         (WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
386
387 2011-10-07  Yury Semikhatsky  <yurys@chromium.org>
388
389         Web Inspector: allow to start WorkerContext paused
390         https://bugs.webkit.org/show_bug.cgi?id=69635
391
392         Allow to pause WorkerContext on start.
393
394         Reviewed by Pavel Feldman.
395
396         * bindings/v8/ScriptDebugServer.cpp:
397         (WebCore::ScriptDebugServer::setPauseOnNextStatement):
398         * bindings/v8/WorkerScriptDebugServer.cpp:
399         (WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
400         * bindings/v8/WorkerScriptDebugServer.h:
401         * inspector/InspectorController.cpp:
402         (WebCore::InspectorController::InspectorController):
403         * inspector/InspectorInstrumentation.cpp:
404         (WebCore::InspectorInstrumentation::willEvaluateWorkerScript):
405         * inspector/InspectorInstrumentation.h:
406         * inspector/InspectorRuntimeAgent.cpp:
407         (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
408         (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
409         (WebCore::InspectorRuntimeAgent::pauseWorkerContext): this method will start
410         running worker message loop in "debug" mode, i.e. it will process only inspector
411         tasks until method InspectorRuntimeAgent::resume is called.
412         (WebCore::InspectorRuntimeAgent::resume):
413         * inspector/InspectorRuntimeAgent.h:
414         * inspector/WorkerDebuggerAgent.cpp:
415         * inspector/WorkerDebuggerAgent.h:
416         * inspector/WorkerInspectorController.cpp:
417         (WebCore::WorkerInspectorController::WorkerInspectorController):
418         (WebCore::WorkerInspectorController::resume): method which is called from WebKit layer
419         when it is known that inspector state was restored and it is OK to resume worker execution.
420         * inspector/WorkerInspectorController.h:
421         * workers/DedicatedWorkerThread.cpp:
422         (WebCore::DedicatedWorkerThread::create):
423         (WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
424         * workers/DedicatedWorkerThread.h:
425         * workers/SharedWorkerThread.cpp:
426         (WebCore::SharedWorkerThread::create):
427         (WebCore::SharedWorkerThread::SharedWorkerThread):
428         * workers/SharedWorkerThread.h:
429         * workers/WorkerMessagingProxy.cpp:
430         (WebCore::WorkerMessagingProxy::startWorkerContext):
431         (WebCore::WorkerMessagingProxy::disconnectFromInspector):
432         (WebCore::WorkerMessagingProxy::sendMessageToInspector):
433         * workers/WorkerThread.cpp:
434         (WebCore::WorkerThreadStartupData::create):
435         (WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
436         (WebCore::WorkerThread::WorkerThread): WorkerThread is passed a booleand flag indicating
437         whether the context should be paused and wait for explicit resume command before it
438         starts running its script.
439         (WebCore::WorkerThread::workerThread):
440         * workers/WorkerThread.h:
441
442 2011-10-10  Sheriff Bot  <webkit.review.bot@gmail.com>
443
444         Unreviewed, rolling out r97045.
445         http://trac.webkit.org/changeset/97045
446         https://bugs.webkit.org/show_bug.cgi?id=69746
447
448         makes apple bots very crashy :( (Requested by kling on
449         #webkit).
450
451         * css/CSSStyleApplyProperty.cpp:
452         (WebCore::ApplyPropertyColor::applyInheritValue):
453         * page/animation/AnimationBase.cpp:
454         (WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
455         (WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
456         (WebCore::AnimationBase::ensurePropertyMap):
457         * platform/graphics/Color.h:
458         (WebCore::Color::Color):
459         * rendering/style/BorderValue.h:
460         (WebCore::BorderValue::BorderValue):
461         (WebCore::BorderValue::isTransparent):
462         (WebCore::BorderValue::operator==):
463         (WebCore::BorderValue::color):
464         * rendering/style/OutlineValue.h:
465         (WebCore::OutlineValue::operator==):
466         * rendering/style/RenderStyle.h:
467         (WebCore::InheritedFlags::setBorderLeftColor):
468         (WebCore::InheritedFlags::setBorderRightColor):
469         (WebCore::InheritedFlags::setBorderTopColor):
470         (WebCore::InheritedFlags::setBorderBottomColor):
471         (WebCore::InheritedFlags::setOutlineColor):
472         (WebCore::InheritedFlags::setColumnRuleColor):
473         (WebCore::InheritedFlags::fillPaintColor):
474         (WebCore::InheritedFlags::strokePaintColor):
475         (WebCore::InheritedFlags::borderLeftColor):
476         (WebCore::InheritedFlags::borderRightColor):
477         (WebCore::InheritedFlags::borderTopColor):
478         (WebCore::InheritedFlags::borderBottomColor):
479         (WebCore::InheritedFlags::backgroundColor):
480         (WebCore::InheritedFlags::color):
481         (WebCore::InheritedFlags::columnRuleColor):
482         (WebCore::InheritedFlags::outlineColor):
483         (WebCore::InheritedFlags::textEmphasisColor):
484         (WebCore::InheritedFlags::textFillColor):
485         (WebCore::InheritedFlags::textStrokeColor):
486         (WebCore::InheritedFlags::stopColor):
487         (WebCore::InheritedFlags::floodColor):
488         (WebCore::InheritedFlags::lightingColor):
489
490 2011-10-06  Andreas Kling  <kling@webkit.org>
491
492         Shrink BorderValue.
493         https://bugs.webkit.org/show_bug.cgi?id=69521
494
495         Reviewed by Antti Koivisto.
496
497         Unroll BorderValue's Color member so we can pack the color's validity flag
498         in BorderValue's bitfield.
499
500         This shrinks BorderValue by 32 bit, which in turn shrinks BorderData by
501         16 bytes. This reduces memory consumption by 760 kB when loading the full
502         HTML5 spec.
503
504         * platform/graphics/Color.h:
505         (WebCore::Color::Color):
506
507             Allow construction of Color objects with specific validity.
508
509         * rendering/style/BorderValue.h:
510         (WebCore::BorderValue::BorderValue):
511         (WebCore::BorderValue::isTransparent):
512         (WebCore::BorderValue::operator==):
513         (WebCore::BorderValue::setColor):
514         (WebCore::BorderValue::color):
515         * rendering/style/OutlineValue.h:
516         (WebCore::OutlineValue::operator==):
517
518             Unroll m_color into BorderValue by splitting it into an RGBA32 and a bool.
519             Made those variables private and added color(), setColor() accessors.
520
521         * rendering/style/RenderStyle.h:
522         (WebCore::InheritedFlags::setBorderLeftColor):
523         (WebCore::InheritedFlags::setBorderRightColor):
524         (WebCore::InheritedFlags::setBorderTopColor):
525         (WebCore::InheritedFlags::setBorderBottomColor):
526         (WebCore::InheritedFlags::setOutlineColor):
527         (WebCore::InheritedFlags::setColumnRuleColor):
528
529             Added a SET_BORDERVALUE_COLOR macro and use that instead of SET_VAR
530             when setting BorderValue colors.
531
532         (WebCore::InheritedFlags::fillPaintColor):
533         (WebCore::InheritedFlags::strokePaintColor):
534         (WebCore::InheritedFlags::borderLeftColor):
535         (WebCore::InheritedFlags::borderRightColor):
536         (WebCore::InheritedFlags::borderTopColor):
537         (WebCore::InheritedFlags::borderBottomColor):
538         (WebCore::InheritedFlags::backgroundColor):
539         (WebCore::InheritedFlags::color):
540         (WebCore::InheritedFlags::columnRuleColor):
541         (WebCore::InheritedFlags::outlineColor):
542         (WebCore::InheritedFlags::textEmphasisColor):
543         (WebCore::InheritedFlags::textFillColor):
544         (WebCore::InheritedFlags::textStrokeColor):
545         (WebCore::InheritedFlags::stopColor):
546         (WebCore::InheritedFlags::floodColor):
547         (WebCore::InheritedFlags::lightingColor):
548
549             Made color getters return "Color" instead of "const Color&" since
550             BorderValue no longer has an actual object to return the reference to.
551
552         * css/CSSStyleApplyProperty.cpp:
553         (WebCore::ApplyPropertyColor::applyInheritValue):
554         * page/animation/AnimationBase.cpp:
555         (WebCore::PropertyWrapperColor::PropertyWrapperColor):
556         (WebCore::PropertyWrapperColor::blend):
557         (WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
558         (WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
559         (WebCore::AnimationBase::ensurePropertyMap):
560
561             Adapt to RenderStyle color getters now returning "Color" instead of
562             "const Color&".
563
564 2011-10-09  Yury Semikhatsky  <yurys@chromium.org>
565
566         Missing m_notificationPresenter initialization in WorkerThread constructor
567         https://bugs.webkit.org/show_bug.cgi?id=69741
568
569         Added missing m_notificationPresenter(0)
570
571         Reviewed by Pavel Feldman.
572
573         * workers/WorkerThread.cpp:
574         (WebCore::WorkerThread::WorkerThread):
575
576 2011-10-09  Daniel Bates  <dbates@webkit.org>
577
578         Another attempt to fix the Leopard Intel Debug build after changeset 97034 <http://trac.webkit.org/changeset/97034>
579         (https://bugs.webkit.org/show_bug.cgi?id=68035)
580
581         * page/FrameView.cpp:
582         (WebCore::FrameView::zoomAnimatorTransformChanged): Explicitly convert a double precision result
583         to a single precision result. I am unsure if this fix is correct. We need to look into this some
584         more. See <https://bugs.webkit.org/show_bug.cgi?id=69739> for more details.
585
586 2011-10-09  Daniel Bates  <dbates@webkit.org>
587
588         Attempt to fix the Leopard Intel Debug build after changeset 97034 <http://trac.webkit.org/changeset/97034>
589         (https://bugs.webkit.org/show_bug.cgi?id=68035)
590
591         * page/FrameView.cpp:
592         (WebCore::FrameView::zoomAnimatorTransformChanged): Explicitly convert double precision result to
593         an integer. I am unsure if this fix is correct. We need to look into this some more. See
594         <https://bugs.webkit.org/show_bug.cgi?id=69739> for more details.
595
596 2011-10-09  Luke Macpherson   <macpherson@chromium.org>
597
598         Fix Lion, Leopard and Snow Leopard builds after changeset 97034 <http://trac.webkit.org/changeset/97034>
599         (https://bugs.webkit.org/show_bug.cgi?id=68035)
600         https://bugs.webkit.org/show_bug.cgi?id=69735
601
602         Reviewed by Daniel Bates.
603
604         * testing/Internals.cpp:
605         Mark unused parameters to prevent compile errors when GESTURE_EVENTS and SMOOTH_SCROLLING are disabled.
606         (WebCore::Internals::setEnableScrollAnimator):
607         (WebCore::Internals::setZoomAnimatorTransform):
608         (WebCore::Internals::setZoomParameters):
609
610 2011-10-09  Kent Tamura  <tkent@chromium.org>
611
612         Remove redundant code of HTMLSelectElement.
613         https://bugs.webkit.org/show_bug.cgi?id=69701
614
615         Reviewed by Darin Adler.
616
617         No new tests, just a refactoring.
618
619         * html/HTMLSelectElement.cpp:
620         (WebCore::HTMLSelectElement::deselectItems):
621         Rename inner deselectItems() to deselectItemsWithoutValidation().
622         (WebCore::HTMLSelectElement::setSelectedIndex):
623         Rename a callsite of another setSelectedIndex() to setSelectedIndexInternal().
624         (WebCore::HTMLSelectElement::setSelectedIndexByUser):
625         ditto, and update a callsite of updateSelectedState().
626         (WebCore::HTMLSelectElement::listBoxSelectItem):
627         Update a callsite of updateSelectedState().
628         (WebCore::HTMLSelectElement::activeSelectionEndListIndex):
629         Update a callsite of lastSelectedListIndex().
630         (WebCore::HTMLSelectElement::selectAll):
631         Update callsites of functions which are changed to non-static.
632         (WebCore::HTMLSelectElement::saveLastSelection):
633         Merge a static function and a non-static function.
634         (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto.
635         (WebCore::HTMLSelectElement::setActiveSelectionEndIndex): ditto.
636         (WebCore::HTMLSelectElement::updateListBoxSelection): ditto.
637         (WebCore::HTMLSelectElement::listBoxOnChange): ditto.
638         (WebCore::HTMLSelectElement::menuListOnChange): ditto.
639         (WebCore::HTMLSelectElement::scrollToSelection): ditto.
640         (WebCore::HTMLSelectElement::setOptionsChangedOnRenderer): Made this non-static.
641         (WebCore::HTMLSelectElement::setRecalcListItems):
642         Merge a static function and a non-static function.
643         (WebCore::HTMLSelectElement::selectedIndex): ditto.
644         (WebCore::HTMLSelectElement::setSelectedIndexInternal):
645         Made this non-static, and renamed from setSelectedIndex() because
646         of conflict with an existing function.
647         (WebCore::HTMLSelectElement::optionToListIndex):
648         Merge a static function and a non-static function.
649         (WebCore::HTMLSelectElement::listToOptionIndex): ditto.
650         (WebCore::HTMLSelectElement::dispatchFocusEvent):
651         Update a callsite of function which is changed to no-staic.
652         (WebCore::HTMLSelectElement::dispatchBlurEvent): ditto.
653         (WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
654         Made this non-static, and renamed from deselectItems() to avoid conflict.
655         (WebCore::HTMLSelectElement::restoreFormControlState):
656         Update a callsite of function which is changed to no-staic.
657         (WebCore::HTMLSelectElement::reset): ditto.
658         (WebCore::HTMLSelectElement::platformHandleKeydownEvent): Made this non-static.
659         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
660         (WebCore::HTMLSelectElement::updateSelectedState): ditto.
661         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
662         (WebCore::HTMLSelectElement::defaultEventHandler):
663         Merged a static function and a non-static function.
664         (WebCore::HTMLSelectElement::lastSelectedListIndex): Made this non-static.
665         (WebCore::HTMLSelectElement::typeAheadFind): ditto.
666         (WebCore::HTMLSelectElement::accessKeySetSelectedIndex): ditto.
667         * html/HTMLSelectElement.h:
668         * html/HTMLSelectElementWin.cpp:
669         (WebCore::HTMLSelectElement::platformHandleKeydownEvent): Made this non-static.
670
671 2011-10-09  Adam Barth  <abarth@webkit.org>
672
673         CSP should log unrecognized directives to the console
674         https://bugs.webkit.org/show_bug.cgi?id=69728
675
676         Reviewed by Sam Weinig.
677
678         Several of the web developers who have been experimenting with CSP have
679         run into trouble with directives we don't support.  For example, one
680         developer was confused for a while why image-src didn't do what he
681         expected.  Logging a message to the console will help these folks
682         figure out what's going on.
683
684         * page/ContentSecurityPolicy.cpp:
685         (WebCore::ContentSecurityPolicy::reportUnrecognizedDirective):
686         (WebCore::ContentSecurityPolicy::addDirective):
687         * page/ContentSecurityPolicy.h:
688
689 2011-10-09  W. James MacLean  <wjmaclean@chromium.org>
690
691         [chromium] Zoom animator front-end
692         https://bugs.webkit.org/show_bug.cgi?id=68035
693
694         Adds necessary components to ScrollAnimatorNone to support a zoom animation
695         feature. Includes test infrastructure via testing/Internals to capture
696         in-progress texture scaling (zoom-animator-scale-test.html) as well as a
697         final view --- after pageScaleFactor has been applied --- in zoom-animator-scale-test2.html.
698
699         Removes temporary test fields from Settings.
700
701         Reviewed by Kenneth Russell.
702
703         Test: platform/chromium/compositing/zoom-animator-scale-test2.html
704
705         * page/EventHandler.cpp:
706         (WebCore::EventHandler::handleGestureEvent):
707         * page/FrameView.cpp:
708         (WebCore::FrameView::zoomAnimatorTransformChanged):
709         * page/FrameView.h:
710         * page/Settings.cpp:
711         (WebCore::Settings::Settings):
712         * page/Settings.h:
713         * platform/ScrollAnimator.cpp:
714         (WebCore::ScrollAnimator::ScrollAnimator):
715         (WebCore::ScrollAnimator::notifyZoomChanged):
716         (WebCore::ScrollAnimator::zoomTranslation):
717         (WebCore::ScrollAnimator::resetZoom):
718         (WebCore::ScrollAnimator::setZoomParametersForTest):
719         * platform/ScrollAnimator.h:
720         (WebCore::ScrollAnimator::zoomScale):
721         * platform/ScrollAnimatorNone.cpp:
722         (WebCore::ScrollAnimatorNone::ZoomData::ZoomData):
723         (WebCore::ScrollAnimatorNone::ZoomData::animateZoom):
724         (WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
725         (WebCore::ScrollAnimatorNone::zoom):
726         (WebCore::ScrollAnimatorNone::handleGestureEvent):
727         (WebCore::ScrollAnimatorNone::animationTimerFired):
728         * platform/ScrollAnimatorNone.h:
729         * platform/ScrollableArea.cpp:
730         (WebCore::ScrollableArea::zoomAnimatorTransformChanged):
731         * platform/ScrollableArea.h:
732         * testing/Internals.cpp:
733         (WebCore::Internals::setEnableScrollAnimator):
734         (WebCore::Internals::setZoomAnimatorTransform):
735         (WebCore::Internals::getPageScaleFactor):
736         (WebCore::Internals::setZoomParameters):
737         * testing/Internals.h:
738         * testing/Internals.idl:
739
740 2011-10-09  Dan Bernstein  <mitz@apple.com>
741
742         <rdar://problem/9484496> REGRESSION (WebKit2): Checkboxes and radio buttons are drawn 1 pixel too high, not repainted properly
743         https://bugs.webkit.org/show_bug.cgi?id=69727
744
745         Reviewed by Anders Carlsson.
746
747         * platform/mac/ThemeMac.mm: Made WebCoreFlippedView an NSControl subclass so that the NSButtonCell
748         used to draw checkboxes and radio buttons can make it its controlView, and consequently check and
749         obey its flippedness.
750
751 2011-10-09  Benjamin Poulain  <benjamin@webkit.org>
752
753         Do not compare the first glyph to itself in Font::drawGlyphBuffer()
754         https://bugs.webkit.org/show_bug.cgi?id=69715
755
756         Reviewed by Andreas Kling.
757
758         When looking for glyphs with similar properties, we should
759         skip the first one since the comparison of fontData 
760         and offset will always fail.
761
762         This is covered by the existing tests.
763
764         * platform/graphics/FontFastPath.cpp:
765         (WebCore::Font::drawGlyphBuffer):
766
767 2011-10-08  Justin Schuh  <jschuh@chromium.org>
768
769         Make ThreadGlobalData members use OwnPtr
770         https://bugs.webkit.org/show_bug.cgi?id=69710
771
772         Reviewed by Adam Barth.
773
774         No functional changes. No new tests required.
775
776         * platform/ThreadGlobalData.cpp:
777         (WebCore::ThreadGlobalData::ThreadGlobalData):
778         (WebCore::ThreadGlobalData::~ThreadGlobalData):
779         (WebCore::ThreadGlobalData::destroy):
780         * platform/ThreadGlobalData.h:
781
782 2011-10-08  Mark Hahnenberg  <mhahnenberg@apple.com>
783
784         Add static version of JSCell::getConstructData
785         https://bugs.webkit.org/show_bug.cgi?id=69673
786
787         Reviewed by Geoffrey Garen.
788
789         No new tests.
790
791         Added static version of getConstructData to all classes that 
792         override it and changed the virtual versions to call the static 
793         versions.  This is the first step in de-virtualizing JSCell::getConstructData.
794
795         * bindings/js/JSAudioConstructor.cpp:
796         (WebCore::JSAudioConstructor::getConstructData):
797         * bindings/js/JSAudioConstructor.h:
798         * bindings/js/JSImageConstructor.cpp:
799         (WebCore::JSImageConstructor::getConstructData):
800         * bindings/js/JSImageConstructor.h:
801         * bindings/js/JSOptionConstructor.cpp:
802         (WebCore::JSOptionConstructor::getConstructData):
803         * bindings/js/JSOptionConstructor.h:
804         * bindings/scripts/CodeGeneratorJS.pm:
805         (GenerateConstructorDeclaration):
806         (GenerateConstructorDefinition):
807         * bindings/scripts/test/JS/JSTestInterface.cpp:
808         (WebCore::JSTestInterfaceConstructor::getConstructData):
809         * bridge/runtime_object.cpp:
810         (JSC::Bindings::RuntimeObject::getConstructData):
811         * bridge/runtime_object.h:
812
813 2011-10-08  Mark Hahnenberg  <mhahnenberg@apple.com>
814
815         Add static version of JSCell::getOwnPropertySlot
816         https://bugs.webkit.org/show_bug.cgi?id=69593
817
818         Reviewed by Geoffrey Garen.
819
820         No new tests.
821
822         Added static version of getOwnPropertySlot to every class that overrides
823         JSCell::getOwnPropertySlot.  The virtual versions now call the static versions.
824         This is the first step in de-virtualizing JSCell::getOwnPropertySlot.
825
826         * bindings/js/JSDOMWindowShell.cpp:
827         (WebCore::JSDOMWindowShell::getOwnPropertySlot):
828         * bindings/js/JSDOMWindowShell.h:
829         * bridge/objc/objc_runtime.h:
830         * bridge/objc/objc_runtime.mm:
831         (JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertySlot):
832         * bridge/qt/qt_runtime.cpp:
833         (JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertySlot):
834         (JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertySlot):
835         * bridge/qt/qt_runtime.h:
836         * bridge/runtime_array.cpp:
837         (JSC::RuntimeArray::getOwnPropertySlot):
838         * bridge/runtime_array.h:
839         * bridge/runtime_method.cpp:
840         (JSC::RuntimeMethod::getOwnPropertySlot):
841         * bridge/runtime_method.h:
842         * bridge/runtime_object.cpp:
843         (JSC::Bindings::RuntimeObject::getOwnPropertySlot):
844         * bridge/runtime_object.h:
845
846 2011-10-03  Carlos Garcia Campos  <cgarcia@igalia.com> and Martin Robinson  <mrobinson@igalia.com>
847
848         [GTK] Implement drag and drop support in WebKit2
849         https://bugs.webkit.org/show_bug.cgi?id=63706
850
851         Reviewed by Philippe Normand.
852
853         * platform/DragData.h:
854         * platform/gtk/DataObjectGtk.cpp:
855         (WebCore::DataObjectGtk::text): Mark as const.
856         (WebCore::DataObjectGtk::markup): Ditto.
857         (WebCore::DataObjectGtk::urlLabel): Ditto.
858         * platform/gtk/DataObjectGtk.h: Remove unused member
859         m_dragContext.
860         (WebCore::DataObjectGtk::url): Mark as const.
861         (WebCore::DataObjectGtk::uriList): Ditto.
862         (WebCore::DataObjectGtk::filenames): Ditto.
863         (WebCore::DataObjectGtk::image): Ditto.
864         (WebCore::DataObjectGtk::hasText): Ditto.
865         (WebCore::DataObjectGtk::hasMarkup): Ditto.
866         (WebCore::DataObjectGtk::hasURIList): Ditto.
867         (WebCore::DataObjectGtk::hasURL): Ditto.
868         (WebCore::DataObjectGtk::hasFilenames): Ditto.
869         (WebCore::DataObjectGtk::hasImage): Ditto.
870         * platform/gtk/DragIcon.cpp: Added. A helper which takes care of
871         creating a transparent drag window for drags.
872         * platform/gtk/DragIcon.h: Added.
873
874 2011-10-08  Abhishek Arya  <inferno@chromium.org>
875
876         Add support for ADDRESS_SANITIZER in RenderArena
877         allocate, free calls.
878         https://bugs.webkit.org/show_bug.cgi?id=69636
879
880         Reviewed by Darin Adler.
881
882         Use malloc, free directly without using the debug header. Otherwise,
883         we won't be able to detect out of bounds access in debug header.
884
885         * rendering/RenderArena.cpp:
886         (WebCore::RenderArena::allocate):
887         (WebCore::RenderArena::free):
888
889 2011-10-08  Kent Tamura  <tkent@chromium.org>
890
891         Remove some static functions of HTMLSelectElement
892         https://bugs.webkit.org/show_bug.cgi?id=69621
893
894         Reviewed by Darin Adler.
895
896         Merge a static function and the corresponding non-static member function
897         into one function if there are no other callers of the static function.
898
899         No new tests, just a refactoring.
900
901         * html/HTMLFormControlElement.h:
902         Make formControlName() protected because it is called from
903         HTMLSelectElement.
904         * html/HTMLSelectElement.cpp:
905         (WebCore::HTMLSelectElement::parseMappedAttribute):
906         Remove two argument of parseMultipleAttribute().
907         (WebCore::HTMLSelectElement::selectAll):
908         Merged the static function and the member function.
909         (WebCore::HTMLSelectElement::dispatchFocusEvent): ditto.
910         (WebCore::HTMLSelectElement::dispatchBlurEvent): ditto.
911         (WebCore::HTMLSelectElement::saveFormControlState): ditto.
912         (WebCore::HTMLSelectElement::restoreFormControlState):
913         (WebCore::HTMLSelectElement::parseMultipleAttribute):
914          - Make this non-static member function.
915          - Use reattachIfAttached().
916         (WebCore::HTMLSelectElement::appendFormData): Merged.
917         (WebCore::HTMLSelectElement::reset): ditto.
918         (WebCore::HTMLSelectElement::insertedIntoTree): ditto.
919         (WebCore::HTMLSelectElement::accessKeySetSelectedIndex): ditto.
920         (WebCore::HTMLSelectElement::length): Merged with optionCount().
921         * html/HTMLSelectElement.h:
922
923 2011-10-08  Sheriff Bot  <webkit.review.bot@gmail.com>
924
925         Unreviewed, rolling out r96996.
926         http://trac.webkit.org/changeset/96996
927         https://bugs.webkit.org/show_bug.cgi?id=69697
928
929         It broke all tests on the Qt bot (Requested by Ossy_night on
930         #webkit).
931
932         * WebCore.exp.in:
933         * bindings/js/JSCallbackData.cpp:
934         (WebCore::JSCallbackData::invokeCallback):
935         * bindings/js/JSCustomXPathNSResolver.cpp:
936         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
937         * bindings/js/JSErrorHandler.cpp:
938         (WebCore::JSErrorHandler::handleEvent):
939         * bindings/js/JSEventListener.cpp:
940         (WebCore::JSEventListener::handleEvent):
941         * bindings/js/JSHTMLAllCollectionCustom.cpp:
942         (WebCore::JSHTMLAllCollection::getCallDataVirtual):
943         * bindings/js/JSHTMLAppletElementCustom.cpp:
944         (WebCore::JSHTMLAppletElement::getCallDataVirtual):
945         * bindings/js/JSHTMLEmbedElementCustom.cpp:
946         (WebCore::JSHTMLEmbedElement::getCallDataVirtual):
947         * bindings/js/JSHTMLObjectElementCustom.cpp:
948         (WebCore::JSHTMLObjectElement::getCallDataVirtual):
949         * bindings/js/JSInjectedScriptHostCustom.cpp:
950         (WebCore::JSInjectedScriptHost::evaluate):
951         * bindings/js/JSPluginElementFunctions.cpp:
952         (WebCore::runtimeObjectGetCallData):
953         * bindings/scripts/CodeGeneratorJS.pm:
954         (GenerateHeader):
955         * bridge/objc/objc_runtime.h:
956         * bridge/objc/objc_runtime.mm:
957         (JSC::Bindings::ObjcFallbackObjectImp::getCallDataVirtual):
958         * bridge/qt/qt_runtime.cpp:
959         (JSC::Bindings::QtRuntimeMetaMethod::getCallDataVirtual):
960         (JSC::Bindings::QtRuntimeConnectionMethod::call):
961         (JSC::Bindings::QtRuntimeConnectionMethod::getCallDataVirtual):
962         (JSC::Bindings::isJavaScriptFunction):
963         * bridge/qt/qt_runtime.h:
964         * bridge/runtime_method.cpp:
965         (JSC::RuntimeMethod::getCallDataVirtual):
966         * bridge/runtime_method.h:
967         * bridge/runtime_object.cpp:
968         (JSC::Bindings::RuntimeObject::getCallDataVirtual):
969         * bridge/runtime_object.h:
970
971 2011-10-08  Ryosuke Niwa  <rniwa@webkit.org>
972
973         Snow Leopard build fix after r96976. Apparently we just need a full rebuild.
974
975         * config.h:
976
977 2011-10-07  Mark Hahnenberg  <mhahnenberg@apple.com>
978
979         Add static version of JSCell::deleteProperty
980         https://bugs.webkit.org/show_bug.cgi?id=69659
981
982         Reviewed by Geoffrey Garen.
983
984         No new tests.
985
986         Added static version of both versions of put to all classes that 
987         override them and changed the virtual versions to call the static 
988         versions.  This is the first step in de-virtualizing JSCell::deleteProperty.
989
990         * bridge/objc/objc_runtime.h:
991         * bridge/objc/objc_runtime.mm:
992         (JSC::Bindings::ObjcFallbackObjectImp::deleteProperty):
993         * bridge/runtime_array.cpp:
994         (JSC::RuntimeArray::deleteProperty):
995         * bridge/runtime_array.h:
996         * bridge/runtime_object.cpp:
997         (JSC::Bindings::RuntimeObject::deleteProperty):
998         * bridge/runtime_object.h:
999
1000 2011-10-07  Justin Schuh  <jschuh@chromium.org>
1001
1002         Make isXMLMIMEType regex use TLS
1003         https://bugs.webkit.org/show_bug.cgi?id=69665
1004
1005         Reviewed by Adam Barth.
1006
1007         Test: fast/workers/worker-multi-startup.html
1008
1009         * dom/DOMImplementation.cpp:
1010         (WebCore::XMLMIMETypeRegExp::XMLMIMETypeRegExp):
1011         (WebCore::XMLMIMETypeRegExp::~XMLMIMETypeRegExp):
1012         (WebCore::XMLMIMETypeRegExp::isXMLMIMEType):
1013         (WebCore::DOMImplementation::isXMLMIMEType):
1014         * dom/DOMImplementation.h:
1015         * platform/ThreadGlobalData.cpp:
1016         (WebCore::ThreadGlobalData::ThreadGlobalData):
1017         (WebCore::ThreadGlobalData::destroy):
1018         * platform/ThreadGlobalData.h:
1019         (WebCore::ThreadGlobalData::xmlTypeRegExp):
1020
1021 2011-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1022
1023         Unreviewed, rolling out r96847.
1024         http://trac.webkit.org/changeset/96847
1025         https://bugs.webkit.org/show_bug.cgi?id=69684
1026
1027         may have caused memory regression on win chromium (Requested
1028         by simonjam on #webkit).
1029
1030         * platform/graphics/chromium/FontChromiumWin.cpp:
1031         (WebCore::Font::drawGlyphs):
1032
1033 2011-10-07  Mark Hahnenberg  <mhahnenberg@apple.com>
1034
1035         Remove getCallDataVirtual methods
1036         https://bugs.webkit.org/show_bug.cgi?id=69186
1037
1038         Reviewed by Geoffrey Garen.
1039
1040         No new tests.
1041
1042         Removed all getCallDataVirtual methods and replaced their call sites 
1043         with an explicit lookup in the MethodTable.
1044
1045         * WebCore.exp.in:
1046         * bindings/js/JSCallbackData.cpp:
1047         (WebCore::JSCallbackData::invokeCallback):
1048         * bindings/js/JSCustomXPathNSResolver.cpp:
1049         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
1050         * bindings/js/JSErrorHandler.cpp:
1051         (WebCore::JSErrorHandler::handleEvent):
1052         * bindings/js/JSEventListener.cpp:
1053         (WebCore::JSEventListener::handleEvent):
1054         * bindings/js/JSHTMLAllCollectionCustom.cpp:
1055         * bindings/js/JSHTMLAppletElementCustom.cpp:
1056         * bindings/js/JSHTMLEmbedElementCustom.cpp:
1057         * bindings/js/JSHTMLObjectElementCustom.cpp:
1058         * bindings/js/JSInjectedScriptHostCustom.cpp:
1059         (WebCore::JSInjectedScriptHost::evaluate):
1060         * bindings/js/JSPluginElementFunctions.cpp:
1061         (WebCore::runtimeObjectGetCallData):
1062         * bindings/scripts/CodeGeneratorJS.pm:
1063         (GenerateHeader):
1064         * bridge/objc/objc_runtime.h:
1065         * bridge/objc/objc_runtime.mm:
1066         * bridge/qt/qt_runtime.cpp:
1067         (JSC::Bindings::QtRuntimeConnectionMethod::call):
1068         (JSC::Bindings::isJavaScriptFunction):
1069         * bridge/qt/qt_runtime.h:
1070         (JSC::Bindings::QtRuntimeMetaMethod::createStructure):
1071         (JSC::Bindings::QtRuntimeConnectionMethod::createStructure):
1072         * bridge/runtime_method.cpp:
1073         * bridge/runtime_method.h:
1074         * bridge/runtime_object.cpp:
1075         * bridge/runtime_object.h:
1076
1077 2011-10-07  Mark Hahnenberg  <mhahnenberg@apple.com>
1078
1079         Add static version of JSCell::put
1080         https://bugs.webkit.org/show_bug.cgi?id=69382
1081
1082         Reviewed by Geoffrey Garen.
1083
1084         No new tests.
1085
1086         Added static version of both versions of put to all classes that 
1087         override them and changed the virtual versions to call the static 
1088         versions.
1089
1090         * bindings/scripts/CodeGeneratorJS.pm:
1091         (GenerateHeader):
1092         (GenerateImplementation):
1093         * bindings/scripts/test/JS/JSTestObj.cpp:
1094         (WebCore::JSTestObj::put):
1095         * bindings/scripts/test/JS/JSTestObj.h:
1096         * bridge/objc/objc_runtime.h:
1097         * bridge/objc/objc_runtime.mm:
1098         (JSC::Bindings::ObjcFallbackObjectImp::put):
1099         * bridge/runtime_array.cpp:
1100         (JSC::RuntimeArray::put):
1101         * bridge/runtime_array.h:
1102         * bridge/runtime_object.cpp:
1103         (JSC::Bindings::RuntimeObject::put):
1104         * bridge/runtime_object.h:
1105
1106 2011-10-07  Anantanarayanan G Iyengar  <ananta@chromium.org>
1107
1108          https://bugs.webkit.org/show_bug.cgi?id=69471
1109
1110          We now wrap the window script NPObject which is requested by NPAPI plugins for
1111          scripting. The wrapped NPObject pointer maintains a weak reference to the
1112          window script NPObject and is cleared out when the window script object is destroyed.
1113          The NPObject wrapper is destroyed when the last outstanding reference is released.
1114
1115          Reviewed by Nate Chapin.
1116
1117          No tests added as there is no change in functionality.
1118
1119         * WebCore.gypi:
1120         * bindings/v8/NPObjectWrapper.cpp: Added.
1121         (WebCore::NPObjectWrapper::NPObjectWrapper):
1122         (WebCore::NPObjectWrapper::create):
1123         (WebCore::NPObjectWrapper::clear):
1124         (WebCore::NPObjectWrapper::getWrapper):
1125         (WebCore::NPObjectWrapper::getUnderlyingNPObject):
1126         (WebCore::NPObjectWrapper::getObjectForCall):
1127         (WebCore::NPObjectWrapper::NPAllocate):
1128         (WebCore::NPObjectWrapper::NPDeallocate):
1129         (WebCore::NPObjectWrapper::NPPInvalidate):
1130         (WebCore::NPObjectWrapper::NPHasMethod):
1131         (WebCore::NPObjectWrapper::NPInvoke):
1132         (WebCore::NPObjectWrapper::NPInvokeDefault):
1133         (WebCore::NPObjectWrapper::NPHasProperty):
1134         (WebCore::NPObjectWrapper::NPGetProperty):
1135         (WebCore::NPObjectWrapper::NPSetProperty):
1136         (WebCore::NPObjectWrapper::NPRemoveProperty):
1137         (WebCore::NPObjectWrapper::NPNEnumerate):
1138         (WebCore::NPObjectWrapper::NPNConstruct):
1139         (WebCore::NPObjectWrapper::NPInvokePrivate):
1140         * bindings/v8/NPObjectWrapper.h: Added.
1141         * bindings/v8/NPV8Object.cpp:
1142         (_NPN_EvaluateHelper):
1143         * bindings/v8/ScriptController.cpp:
1144         (WebCore::ScriptController::ScriptController):
1145         (WebCore::ScriptController::clearScriptObjects):
1146         (WebCore::ScriptController::windowScriptNPObject):
1147         * bindings/v8/ScriptController.h:
1148
1149 2011-10-07  Antoine Labour  <piman@chromium.org>
1150
1151         Webkit API for compositor
1152         https://bugs.webkit.org/show_bug.cgi?id=69107
1153
1154         Reviewed by Darin Fisher.
1155
1156         Covered by existing compositing tests.
1157
1158         * platform/graphics/chromium/ContentLayerChromium.h: 
1159
1160 2011-10-07  Ben Wells  <benwells@chromium.org>
1161
1162         CSS text-transform should apply to select elements
1163         https://bugs.webkit.org/show_bug.cgi?id=69503
1164
1165         Reviewed by Ojan Vafai.
1166
1167         Select elements are drawn in two ways depending on whether they are multiple and what their size is.
1168         Neither method previously handled text-transforms. Both of these rendering styles are now updated to transform
1169         their text correctly.
1170
1171         Test: fast/css/text-transform-select.html
1172
1173         * rendering/RenderListBox.cpp:
1174         (WebCore::RenderListBox::updateFromElement):
1175         (WebCore::RenderListBox::paintItemForeground):
1176         * rendering/RenderMenuList.cpp:
1177         (WebCore::RenderMenuList::updateOptionsWidth):
1178         (WebCore::RenderMenuList::setText):
1179         (WebCore::RenderMenuList::itemText):
1180         * rendering/RenderText.cpp:
1181         (WebCore::makeCapitalized):
1182         (WebCore::applyTextTransform):
1183         (WebCore::RenderText::setTextInternal):
1184         (WebCore::RenderText::textWithoutTranscoding):
1185         * rendering/RenderText.h:
1186
1187 2011-10-07  Tony Chang  <tony@chromium.org>
1188
1189         fix a crash when loading non-html multipart data
1190         https://bugs.webkit.org/show_bug.cgi?id=69675
1191
1192         Reviewed by Adam Barth.
1193
1194         setupForReplaceByMIMEType calls DocumentWriter::end().  This leads to
1195         a crash on Mac because WebHTMLRepresentation() calls commitLoad(nil),
1196         which tries to write to the DocumentWriter.  By just inlining the code
1197         to load the last page, we avoid this crash (and makes the non-html
1198         multipart code more like the html multipart code).
1199
1200         * loader/DocumentLoader.cpp:
1201         (WebCore::DocumentLoader::maybeFinishLoadingMultipartContent):
1202
1203 2011-10-07  Sergey Glazunov  <serg.glazunov@gmail.com>
1204
1205         XSLT-generated document should inherit its SecurityOrigin from the source document
1206         https://bugs.webkit.org/show_bug.cgi?id=69661
1207
1208         Reviewed by Adam Barth.
1209
1210         Test: http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml
1211
1212         * xml/XSLTProcessor.cpp:
1213         (WebCore::XSLTProcessor::createDocumentFromSource):
1214
1215 2011-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1216
1217         Unreviewed, rolling out r96944.
1218         http://trac.webkit.org/changeset/96944
1219         https://bugs.webkit.org/show_bug.cgi?id=69662
1220
1221         Caused many tests to crash on Snow Leopard (Requested by rniwa
1222         on #webkit).
1223
1224         * css/CSSStyleApplyProperty.cpp:
1225         (WebCore::ApplyPropertyColor::applyInheritValue):
1226         * page/animation/AnimationBase.cpp:
1227         (WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
1228         (WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
1229         (WebCore::AnimationBase::ensurePropertyMap):
1230         * platform/graphics/Color.h:
1231         (WebCore::Color::Color):
1232         * rendering/style/BorderValue.h:
1233         (WebCore::BorderValue::BorderValue):
1234         (WebCore::BorderValue::isTransparent):
1235         (WebCore::BorderValue::operator==):
1236         (WebCore::BorderValue::color):
1237         * rendering/style/OutlineValue.h:
1238         (WebCore::OutlineValue::operator==):
1239         * rendering/style/RenderStyle.h:
1240         (WebCore::InheritedFlags::setBorderLeftColor):
1241         (WebCore::InheritedFlags::setBorderRightColor):
1242         (WebCore::InheritedFlags::setBorderTopColor):
1243         (WebCore::InheritedFlags::setBorderBottomColor):
1244         (WebCore::InheritedFlags::setOutlineColor):
1245         (WebCore::InheritedFlags::setColumnRuleColor):
1246         (WebCore::InheritedFlags::fillPaintColor):
1247         (WebCore::InheritedFlags::strokePaintColor):
1248         (WebCore::InheritedFlags::borderLeftColor):
1249         (WebCore::InheritedFlags::borderRightColor):
1250         (WebCore::InheritedFlags::borderTopColor):
1251         (WebCore::InheritedFlags::borderBottomColor):
1252         (WebCore::InheritedFlags::backgroundColor):
1253         (WebCore::InheritedFlags::color):
1254         (WebCore::InheritedFlags::columnRuleColor):
1255         (WebCore::InheritedFlags::outlineColor):
1256         (WebCore::InheritedFlags::textEmphasisColor):
1257         (WebCore::InheritedFlags::textFillColor):
1258         (WebCore::InheritedFlags::textStrokeColor):
1259         (WebCore::InheritedFlags::stopColor):
1260         (WebCore::InheritedFlags::floodColor):
1261         (WebCore::InheritedFlags::lightingColor):
1262
1263 2011-10-07  David Hyatt  <hyatt@apple.com>
1264
1265         https://bugs.webkit.org/show_bug.cgi?id=69658
1266         
1267         [CSS3 Regions] Box painting of overflow into regions is incorrect because children were being
1268         incorrectly clamped to their containing block region ranges. Change the clamping model so that
1269         renderRegionForLine no longer does it. A block will now truly have an accurate range across
1270         all the regions that paint it. Instead, do the clamping at the time a child box asks the containing
1271         block for its information. At that time clamp to the start and end regions, so that we never ask
1272         a containing block for info about a region that it doesn't exist in.
1273
1274         Reviewed by Anders Carlsson.
1275
1276         Added new test in fast/regions and updated an old result to be correct.
1277
1278         * rendering/RenderBlock.cpp:
1279         (WebCore::RenderBlock::pageLogicalHeightForOffset):
1280         (WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
1281         (WebCore::RenderBlock::regionAtBlockOffset):
1282         (WebCore::RenderBlock::clampToStartAndEndRegions):
1283         * rendering/RenderBlock.h:
1284         * rendering/RenderBox.cpp:
1285         (WebCore::RenderBox::borderBoxRectInRegion):
1286         (WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
1287         (WebCore::RenderBox::renderBoxRegionInfo):
1288         * rendering/RenderFlowThread.cpp:
1289         (WebCore::RenderFlowThread::renderRegionForLine):
1290         (WebCore::RenderFlowThread::regionLogicalWidthForLine):
1291         (WebCore::RenderFlowThread::regionLogicalHeightForLine):
1292         (WebCore::RenderFlowThread::regionRemainingLogicalHeightForLine):
1293         (WebCore::RenderFlowThread::mapFromFlowToRegion):
1294         (WebCore::RenderFlowThread::setRegionRangeForBox):
1295         * rendering/RenderFlowThread.h:
1296
1297 2011-10-07  Chang Shu  <cshu@webkit.org>
1298
1299         Remove compile time flag ENABLE_PASSWORD_ECHO
1300         https://bugs.webkit.org/show_bug.cgi?id=69647
1301
1302         As we have runtime flag in the page/Settings, we should remove this redundant compile time flag.
1303
1304         Reviewed by Andreas Kling.
1305
1306         * config.h:
1307         * page/Settings.cpp:
1308         (WebCore::Settings::Settings):
1309
1310 2011-10-07  Chris Fleizach  <cfleizach@apple.com>
1311
1312         Bug 69562 - AccessibilityImageMapLink holds onto it's parent even after it's been freed
1313         https://bugs.webkit.org/show_bug.cgi?id=69562
1314
1315         Some fake objects, like AXImageMapLink, have weak references to their parent's (since they are fake objects and
1316         need some connection to the parent). However, if the parent disappears before the child, then we're left with a 
1317         out of date reference to that parent.
1318
1319         The fix is to allow these elements to clear their parentage when the parent goes away.
1320
1321         Reviewed by Darin Adler.
1322
1323         Test: accessibility/image-map-update-parent-crash.html
1324
1325         * accessibility/AccessibilityMenuListOption.cpp:
1326         (WebCore::AccessibilityMenuListOption::isVisible):
1327         * accessibility/AccessibilityMenuListPopup.cpp:
1328         (WebCore::AccessibilityMenuListPopup::isOffScreen):
1329         (WebCore::AccessibilityMenuListPopup::isEnabled):
1330         (WebCore::AccessibilityMenuListPopup::press):
1331         (WebCore::AccessibilityMenuListPopup::addChildren):
1332         (WebCore::AccessibilityMenuListPopup::childrenChanged):
1333         * accessibility/AccessibilityMockObject.h:
1334         (WebCore::AccessibilityMockObject::detachFromParent):
1335         * accessibility/AccessibilityObject.cpp:
1336         (WebCore::AccessibilityObject::clearChildren):
1337         * accessibility/AccessibilityObject.h:
1338         (WebCore::AccessibilityObject::detachFromParent):
1339         * accessibility/AccessibilitySlider.cpp:
1340         (WebCore::AccessibilitySliderThumb::elementRect):
1341         * accessibility/AccessibilityTableColumn.cpp:
1342         (WebCore::AccessibilityTableColumn::headerObjectForSection):
1343
1344 2011-10-07  Andreas Kling  <kling@webkit.org>
1345
1346         Pack StyleRareNonInheritedData even harder on 64-bit.
1347         https://bugs.webkit.org/show_bug.cgi?id=69648
1348
1349         Reviewed by Benjamin Poulain.
1350
1351         Rearrange the members of StyleRareNonInheritedData to fold as much
1352         as possible into the padding at the end of RefCounted.
1353
1354         This shrinks StyleRareNonInheritedData by 16 bytes on 64-bit,
1355         reducing memory consumption by another 140 kB when loading the
1356         full HTML5 spec.
1357
1358         * rendering/style/StyleRareNonInheritedData.cpp:
1359         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
1360         * rendering/style/StyleRareNonInheritedData.h:
1361
1362 2011-10-07  Cary Clark  <caryclark@google.com>
1363
1364         Enable color profiles, unless profile is grayscale
1365         https://bugs.webkit.org/show_bug.cgi?id=69622
1366         https://bugs.webkit.org/show_bug.cgi?id=49950
1367         http://code.google.com/p/chromium/issues/detail?id=80844
1368
1369         Further specialize the earlier fix described in 49950 to
1370         allow color profiles in YCbCr images, but disallow color
1371         profiles marked as grayData.
1372         (see http://www.color.org/ICC1v42_2006-05.pdf 7.2.6 )
1373
1374         Reviewed by Adam Barth.
1375
1376         Test: fast/images/gray-scale-jpeg-with-color-profile.html
1377               fast/images/color-jpeg-with-color-profile.html
1378
1379         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
1380         (WebCore::readColorProfile):
1381         (WebCore::JPEGImageReader::decode):
1382
1383 2011-10-07  Chris Fleizach  <cfleizach@apple.com>
1384
1385         AX: re-organize fake elements to use new AccessibilityMockObject
1386         https://bugs.webkit.org/show_bug.cgi?id=69588
1387
1388         This adds an AccessibilityMockObject for "fake" elements to descend from.
1389         Its benefit is to consolidate the various ways that these fake elements are setting
1390         and returning their parent objects.
1391
1392         No functional change, hence no new tests.
1393
1394         Reviewed by Jon Honeycutt.
1395
1396         * CMakeLists.txt:
1397         * GNUmakefile.list.am:
1398         * WebCore.gypi:
1399         * WebCore.pro:
1400         * WebCore.vcproj/WebCore.vcproj:
1401         * WebCore.xcodeproj/project.pbxproj:
1402         * accessibility/AccessibilityARIAGrid.cpp:
1403         (WebCore::AccessibilityARIAGrid::addChildren):
1404         * accessibility/AccessibilityImageMapLink.cpp:
1405         (WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):
1406         * accessibility/AccessibilityImageMapLink.h:
1407         (WebCore::AccessibilityImageMapLink::node):
1408         * accessibility/AccessibilityMenuList.cpp:
1409         (WebCore::AccessibilityMenuList::addChildren):
1410         * accessibility/AccessibilityMenuList.h:
1411         (WebCore::toAccessibilityMenuList):
1412         * accessibility/AccessibilityMenuListOption.cpp:
1413         (WebCore::AccessibilityMenuListOption::AccessibilityMenuListOption):
1414         (WebCore::AccessibilityMenuListOption::isVisible):
1415         * accessibility/AccessibilityMenuListOption.h:
1416         * accessibility/AccessibilityMenuListPopup.cpp:
1417         (WebCore::AccessibilityMenuListPopup::AccessibilityMenuListPopup):
1418         (WebCore::AccessibilityMenuListPopup::isOffScreen):
1419         (WebCore::AccessibilityMenuListPopup::isEnabled):
1420         (WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):
1421         (WebCore::AccessibilityMenuListPopup::press):
1422         (WebCore::AccessibilityMenuListPopup::addChildren):
1423         (WebCore::AccessibilityMenuListPopup::childrenChanged):
1424         (WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
1425         * accessibility/AccessibilityMenuListPopup.h:
1426         * accessibility/AccessibilityMockObject.cpp: Added.
1427         (WebCore::AccessibilityMockObject::AccessibilityMockObject):
1428         (WebCore::AccessibilityMockObject::~AccessibilityMockObject):
1429         * accessibility/AccessibilityMockObject.h: Added.
1430         (WebCore::AccessibilityMockObject::parentObject):
1431         (WebCore::AccessibilityMockObject::setParent):
1432         (WebCore::AccessibilityMockObject::detachFromParent):
1433         * accessibility/AccessibilitySlider.cpp:
1434         (WebCore::AccessibilitySlider::addChildren):
1435         (WebCore::AccessibilitySliderThumb::AccessibilitySliderThumb):
1436         (WebCore::AccessibilitySliderThumb::elementRect):
1437         * accessibility/AccessibilitySlider.h:
1438         * accessibility/AccessibilityTable.cpp:
1439         (WebCore::AccessibilityTable::addChildren):
1440         (WebCore::AccessibilityTable::headerContainer):
1441         * accessibility/AccessibilityTable.h:
1442         (WebCore::toAccessibilityTable):
1443         * accessibility/AccessibilityTableColumn.cpp:
1444         (WebCore::AccessibilityTableColumn::AccessibilityTableColumn):
1445         (WebCore::AccessibilityTableColumn::setParent):
1446         (WebCore::AccessibilityTableColumn::headerObject):
1447         (WebCore::AccessibilityTableColumn::headerObjectForSection):
1448         (WebCore::AccessibilityTableColumn::accessibilityIsIgnored):
1449         (WebCore::AccessibilityTableColumn::addChildren):
1450         * accessibility/AccessibilityTableColumn.h:
1451         * accessibility/AccessibilityTableHeaderContainer.cpp:
1452         (WebCore::AccessibilityTableHeaderContainer::AccessibilityTableHeaderContainer):
1453         (WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):
1454         (WebCore::AccessibilityTableHeaderContainer::addChildren):
1455         * accessibility/AccessibilityTableHeaderContainer.h:
1456
1457 2011-10-07  Nate Chapin  <japhet@chromium.org>
1458
1459         Make IconLoader a CachedResourceClient instead of a SubresourceLoaderClient.
1460         This is one of the steps required to remove the SubresourceLoaderClient interface,
1461         which will simplify the layering in the loader.
1462         https://bugs.webkit.org/show_bug.cgi?id=69567
1463
1464         Reviewed by Adam Barth.
1465
1466         No new tests, no functionality change intended.
1467
1468         * CMakeLists.txt:
1469         * GNUmakefile.list.am:
1470         * WebCore.gypi:
1471         * WebCore.pro:
1472         * WebCore.vcproj/WebCore.vcproj:
1473         * WebCore.xcodeproj/project.pbxproj:
1474         * loader/cache/CachedRawResource.cpp: Added.
1475         * loader/cache/CachedRawResource.h: Added.
1476         * loader/cache/CachedResource.cpp:
1477         * loader/cache/CachedResource.h:
1478         (WebCore::CachedResource::ignoreForRequestCount): Renamed and generalized from isLinkResource(),
1479             which was only used to decided whether the CachedResource should count toward
1480             CachedResourceLoader::requestCount().
1481         * loader/cache/CachedResourceLoader.cpp:
1482         * loader/cache/CachedResourceLoader.h:
1483         * loader/cache/CachedResourceRequest.cpp:
1484         * loader/cache/CachedResourceRequest.h:
1485         * loader/icon/IconLoader.cpp: Get a CachedResource instead of a SubresourceLoader.
1486         (WebCore::IconLoader::notifyFinished): Merge in the status code check that was in didReceiveResponse(),
1487             since we won't be checking any callbacks before the load completes.
1488         * loader/icon/IconLoader.h:
1489
1490 2011-10-07  Adam Bergkvist  <adam.bergkvist@ericsson.com>
1491
1492         Add WebCore platform interfaces needed by updated PeerConnection design
1493         https://bugs.webkit.org/show_bug.cgi?id=68460
1494
1495         Reviewed by Adam Barth.
1496
1497         Added the PeerConnection platform files to WebCore/platform/mediastream
1498
1499         Currently not testable.
1500
1501         * GNUmakefile.am:
1502         * GNUmakefile.list.am:
1503         * WebCore.gyp/WebCore.gyp:
1504         * WebCore.gypi:
1505         * platform/mediastream/MediaStreamComponent.h: Added.
1506         (WebCore::MediaStreamComponent::create):
1507         (WebCore::MediaStreamComponent::source):
1508         (WebCore::MediaStreamComponent::enabled):
1509         (WebCore::MediaStreamComponent::setEnabled):
1510         (WebCore::MediaStreamComponent::MediaStreamComponent):
1511         * platform/mediastream/MediaStreamDescriptor.h: Added.
1512         (WebCore::MediaStreamDescriptor::create):
1513         (WebCore::MediaStreamDescriptor::owner):
1514         (WebCore::MediaStreamDescriptor::setOwner):
1515         (WebCore::MediaStreamDescriptor::label):
1516         (WebCore::MediaStreamDescriptor::component):
1517         (WebCore::MediaStreamDescriptor::numberOfComponents):
1518         (WebCore::MediaStreamDescriptor::ended):
1519         (WebCore::MediaStreamDescriptor::setEnded):
1520         (WebCore::MediaStreamDescriptor::MediaStreamDescriptor):
1521         * platform/mediastream/MediaStreamSource.h: Added.
1522         (WebCore::MediaStreamSource::create):
1523         (WebCore::MediaStreamSource::id):
1524         (WebCore::MediaStreamSource::type):
1525         (WebCore::MediaStreamSource::name):
1526         (WebCore::MediaStreamSource::muted):
1527         (WebCore::MediaStreamSource::setMuted):
1528         (WebCore::MediaStreamSource::MediaStreamSource):
1529         * platform/mediastream/PeerHandler.cpp: Added.
1530         (WebCore::PeerHandler::PeerHandler):
1531         (WebCore::PeerHandler::~PeerHandler):
1532         (WebCore::PeerHandler::produceInitialOffer):
1533         (WebCore::PeerHandler::handleInitialOffer):
1534         (WebCore::PeerHandler::processSDP):
1535         (WebCore::PeerHandler::processPendingStreams):
1536         (WebCore::PeerHandler::sendDataStreamMessage):
1537         (WebCore::PeerHandler::stop):
1538         * platform/mediastream/PeerHandler.h: Added.
1539         (WebCore::PeerHandlerClient::~PeerHandlerClient):
1540         (WebCore::PeerHandler::create):
1541
1542 2011-10-07  Vineet Chaudary  <vineet.chaudhary@motorola.com>
1543
1544         background-color affects the font color in disabled textarea.
1545         https://bugs.webkit.org/show_bug.cgi?id=65361
1546
1547         Reviewed by Darin Adler.
1548
1549         For the transparent/translucent background colors use lightening fortext color.
1550
1551         * rendering/RenderTextControl.cpp:
1552         (WebCore::disabledTextColor):
1553
1554 2011-10-07  David Barr  <davidbarr@chromium.org>
1555
1556         Implement currentColor support for box-shadow and text-shadow
1557         https://bugs.webkit.org/show_bug.cgi?id=68218
1558
1559         Reviewed by Simon Fraser.
1560
1561         Test: fast/box-shadow/box-shadow-currentcolor.html
1562
1563         * css/CSSParser.cpp:
1564         (WebCore::CSSParser::parseShadow): Add CSSValueCurrentcolor to supported keywords.
1565
1566 2011-10-07  Pavel Feldman  <pfeldman@google.com>
1567
1568         Web Inspector: add Audits panel to the compilation.
1569         https://bugs.webkit.org/show_bug.cgi?id=69633
1570
1571         Reviewed by Yury Semikhatsky.
1572
1573         * inspector/compile-front-end.sh:
1574         * inspector/front-end/AuditCategories.js:
1575         * inspector/front-end/AuditLauncherView.js:
1576         * inspector/front-end/AuditResultView.js:
1577         * inspector/front-end/AuditRules.js:
1578         (WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
1579         (WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
1580         (WebInspector.AuditRules.CacheControlRule.prototype.handleNonCacheableResources):
1581         * inspector/front-end/AuditsPanel.js:
1582         (WebInspector.AuditsPanel):
1583         * inspector/front-end/NetworkLog.js:
1584         * inspector/front-end/treeoutline.js:
1585
1586 2011-10-07  Andreas Kling  <kling@webkit.org>
1587
1588         Functions that return "const Color" should simply return "Color".
1589
1590         Rubber-stamped by Antti Koivisto.
1591
1592         * rendering/RenderLayerBacking.cpp:
1593         (WebCore::RenderLayerBacking::rendererBackgroundColor):
1594         * rendering/RenderLayerBacking.h:
1595         * rendering/RenderTable.h:
1596         (WebCore::RenderTable::bgColor):
1597         * rendering/style/RenderStyle.cpp:
1598         (WebCore::RenderStyle::colorIncludingFallback):
1599         (WebCore::RenderStyle::visitedDependentColor):
1600         * rendering/style/RenderStyle.h:
1601
1602 2011-10-07  Pavel Feldman  <pfeldman@google.com>
1603
1604         Web Inspector: TypeError: Cannot read property 'styleSheetId' of undefined in tests.
1605         https://bugs.webkit.org/show_bug.cgi?id=69634
1606
1607         Reviewed by Yury Semikhatsky.
1608
1609         * inspector/front-end/CSSStyleModel.js:
1610         (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
1611
1612 2011-10-06  Andreas Kling  <kling@webkit.org>
1613
1614         Shrink BorderValue.
1615         https://bugs.webkit.org/show_bug.cgi?id=69521
1616
1617         Reviewed by Antti Koivisto.
1618
1619         Unroll BorderValue's Color member so we can pack the color's validity flag
1620         in BorderValue's bitfield.
1621
1622         This shrinks BorderValue by 32 bit, which in turn shrinks BorderData by
1623         16 bytes. This reduces memory consumption by 760 kB when loading the full
1624         HTML5 spec.
1625
1626         * platform/graphics/Color.h:
1627         (WebCore::Color::Color):
1628
1629             Allow construction of Color objects with specific validity.
1630
1631         * rendering/style/BorderValue.h:
1632         (WebCore::BorderValue::BorderValue):
1633         (WebCore::BorderValue::isTransparent):
1634         (WebCore::BorderValue::operator==):
1635         (WebCore::BorderValue::setColor):
1636         (WebCore::BorderValue::color):
1637         * rendering/style/OutlineValue.h:
1638         (WebCore::OutlineValue::operator==):
1639
1640             Unroll m_color into BorderValue by splitting it into an RGBA32 and a bool.
1641             Made those variables private and added color(), setColor() accessors.
1642
1643         * rendering/style/RenderStyle.h:
1644         (WebCore::InheritedFlags::setBorderLeftColor):
1645         (WebCore::InheritedFlags::setBorderRightColor):
1646         (WebCore::InheritedFlags::setBorderTopColor):
1647         (WebCore::InheritedFlags::setBorderBottomColor):
1648         (WebCore::InheritedFlags::setOutlineColor):
1649         (WebCore::InheritedFlags::setColumnRuleColor):
1650
1651             Added a SET_BORDERVALUE_COLOR macro and use that instead of SET_VAR
1652             when setting BorderValue colors.
1653
1654         (WebCore::InheritedFlags::fillPaintColor):
1655         (WebCore::InheritedFlags::strokePaintColor):
1656         (WebCore::InheritedFlags::borderLeftColor):
1657         (WebCore::InheritedFlags::borderRightColor):
1658         (WebCore::InheritedFlags::borderTopColor):
1659         (WebCore::InheritedFlags::borderBottomColor):
1660         (WebCore::InheritedFlags::backgroundColor):
1661         (WebCore::InheritedFlags::color):
1662         (WebCore::InheritedFlags::columnRuleColor):
1663         (WebCore::InheritedFlags::outlineColor):
1664         (WebCore::InheritedFlags::textEmphasisColor):
1665         (WebCore::InheritedFlags::textFillColor):
1666         (WebCore::InheritedFlags::textStrokeColor):
1667         (WebCore::InheritedFlags::stopColor):
1668         (WebCore::InheritedFlags::floodColor):
1669         (WebCore::InheritedFlags::lightingColor):
1670
1671             Made color getters return "Color" instead of "const Color&" since
1672             BorderValue no longer has an actual object to return the reference to.
1673
1674         * css/CSSStyleApplyProperty.cpp:
1675         (WebCore::ApplyPropertyColor::applyInheritValue):
1676         * page/animation/AnimationBase.cpp:
1677         (WebCore::PropertyWrapperColor::PropertyWrapperColor):
1678         (WebCore::PropertyWrapperColor::blend):
1679         (WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
1680         (WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
1681         (WebCore::AnimationBase::ensurePropertyMap):
1682
1683             Adapt to RenderStyle color getters now returning "Color" instead of
1684             "const Color&".
1685
1686 2011-10-07  Philippe Normand  <pnormand@igalia.com>
1687
1688         [GStreamer] webkitwebsrc: avoid GST_BOILERPLATE_FULL
1689         https://bugs.webkit.org/show_bug.cgi?id=69630
1690
1691         Reviewed by Martin Robinson.
1692
1693         Use G_DEFINE_TYPE_WITH_CODE instead of GST_BOILERPLATE_FULL and
1694         replace use of gst_ghost_pad_new_no_target_from_template() and
1695         gst_ghost_pad_set_target() with a single call to
1696         gst_ghost_pad_new_from_template(). These changes keep the element
1697         compatible with GStreamer 0.10 while preparing the port to 0.11.
1698
1699         * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
1700         (webkit_web_src_class_init):
1701         (webkit_web_src_init):
1702
1703 2011-10-07  Martin Robinson  <mrobinson@igalia.com>
1704
1705         [Freetype] Pseudo-italics do not work
1706         https://bugs.webkit.org/show_bug.cgi?id=40856
1707
1708         Reviewed by Philippe Normand.
1709
1710         * platform/graphics/freetype/FontPlatformData.h: Add the font description as an argument initializeWithFontFace.
1711         * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
1712         (WebCore::FontPlatformData::FontPlatformData): Pass the font description to initializeWithFontFace.
1713         (WebCore::FontPlatformData::initializeWithFontFace): If we were asked for an italic font and we were
1714         given one that wasn't oblique or italic, activate the synthetic oblique bit.
1715
1716 2011-10-07  Philippe Normand  <pnormand@igalia.com>
1717
1718         [GStreamer] avoid direct access to GstMessage structure field
1719         https://bugs.webkit.org/show_bug.cgi?id=69629
1720
1721         Reviewed by Martin Robinson.
1722
1723         Use gst_message_get_structure() instead of direct access to the
1724         structure field. No direct benefit apart from compatibility with
1725         GStreamer 0.11.
1726
1727         * platform/graphics/gstreamer/GStreamerGWorld.cpp:
1728         (WebCore::gstGWorldSyncMessageCallback):
1729         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
1730         (WebCore::MediaPlayerPrivateGStreamer::handleMessage):
1731         (WebCore::MediaPlayerPrivateGStreamer::mediaLocationChanged):
1732
1733 2011-10-07  Pavel Feldman  <pfeldman@google.com>
1734
1735         Web Inspector: add timeline panel to the compilation.
1736         https://bugs.webkit.org/show_bug.cgi?id=69628
1737
1738         Reviewed by Yury Semikhatsky.
1739
1740         * inspector/compile-front-end.sh:
1741         * inspector/front-end/SidebarTreeElement.js:
1742         (WebInspector.SidebarTreeElement):
1743         * inspector/front-end/SourceCSSTokenizer.js:
1744         (WebInspector.SourceCSSTokenizer.prototype.nextToken):
1745         * inspector/front-end/SourceCSSTokenizer.re2js:
1746         * inspector/front-end/SourceHTMLTokenizer.js:
1747         (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
1748         * inspector/front-end/SourceHTMLTokenizer.re2js:
1749         * inspector/front-end/SourceJavaScriptTokenizer.js:
1750         (WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
1751         * inspector/front-end/SourceJavaScriptTokenizer.re2js:
1752         * inspector/front-end/TimelineGrid.js:
1753         * inspector/front-end/TimelineOverviewPane.js:
1754         (WebInspector.TimelineOverviewPane.prototype._createTimelineCategoryStatusBarCheckbox):
1755         * inspector/front-end/TimelinePanel.js:
1756         (WebInspector.TimelinePanel.prototype._createEventDivider):
1757         (WebInspector.TimelinePanel.prototype._addRecordToTimeline):
1758         (WebInspector.TimelinePanel.prototype._findParentRecord):
1759         (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
1760         (WebInspector.TimelinePanel.prototype.updateMainViewWidth):
1761         (WebInspector.TimelinePanel.prototype.onResize):
1762         (WebInspector.TimelinePanel.prototype._windowChanged):
1763         (WebInspector.TimelinePanel.prototype._refreshRecords):
1764         (WebInspector.TimelineRecordGraphRow.prototype._onClick):
1765         (WebInspector.TimelinePanel.FormattedRecord):
1766         (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
1767         (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
1768
1769 2011-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1770
1771         Unreviewed, rolling out r96892.
1772         http://trac.webkit.org/changeset/96892
1773         https://bugs.webkit.org/show_bug.cgi?id=69626
1774
1775         it broke windows canary bots (Requested by podivilov on
1776         #webkit).
1777
1778         * WebCore.gyp/scripts/rule_binding.py:
1779
1780 2011-10-07  Andreas Kling  <kling@webkit.org>
1781
1782         Shrink StyleInheritedData.
1783         https://bugs.webkit.org/show_bug.cgi?id=69625
1784
1785         Reviewed by Antti Koivisto.
1786
1787         Rearrange the members of StyleInheritedData to fold as much
1788         as possible into the padding at the end of RefCounted.
1789
1790         This shrinks StyleInheritedData by 8 bytes on 64-bit, reducing
1791         memory consumption by 500 kB when loading the full HTML5 spec.
1792
1793         * rendering/style/StyleInheritedData.cpp:
1794         (WebCore::StyleInheritedData::StyleInheritedData):
1795         * rendering/style/StyleInheritedData.h:
1796
1797 2011-10-07  Pavel Feldman  <pfeldman@google.com>
1798
1799         Web Inspector: make ScriptsPanel compile
1800         https://bugs.webkit.org/show_bug.cgi?id=69623
1801
1802         Reviewed by Yury Semikhatsky.
1803
1804         * inspector/compile-front-end.sh:
1805         * inspector/front-end/CallStackSidebarPane.js:
1806         (WebInspector.CallStackSidebarPane.prototype.update):
1807         (WebInspector.CallStackSidebarPane.prototype._placardSelected):
1808         * inspector/front-end/DebuggerModel.js:
1809         * inspector/front-end/JavaScriptSourceFrame.js:
1810         (WebInspector.JavaScriptSourceFrame):
1811         * inspector/front-end/KeyboardShortcut.js:
1812         * inspector/front-end/Object.js:
1813         * inspector/front-end/ObjectPropertiesSection.js:
1814         * inspector/front-end/ScopeChainSidebarPane.js:
1815         (WebInspector.ScopeChainSidebarPane.prototype.update):
1816         * inspector/front-end/ScriptsPanel.js:
1817         (WebInspector.ScriptsPanel.prototype._setScriptSourceIsBeingEdited):
1818         (WebInspector.ScriptsPanel.prototype._createSourceFrame):
1819         (WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
1820         (WebInspector.SourceFrameDelegateForScriptsPanel):
1821         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
1822         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.debuggingSupported):
1823         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setBreakpoint):
1824         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.updateBreakpoint):
1825         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.removeBreakpoint):
1826         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.findBreakpoint):
1827         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.continueToLine):
1828         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.canEditScriptSource):
1829         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSource):
1830         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSourceIsBeingEdited):
1831         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.debuggerPaused):
1832         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.evaluateInSelectedCallFrame):
1833         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.releaseEvaluationResult):
1834         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
1835         * inspector/front-end/StatusBarButton.js:
1836         * inspector/front-end/WatchExpressionsSidebarPane.js:
1837         (WebInspector.WatchExpressionsSection.prototype.update.appendResult):
1838         (WebInspector.WatchExpressionsSection.prototype.update):
1839         (WebInspector.WatchExpressionTreeElement.prototype.startEditing):
1840         * inspector/front-end/WorkerManager.js:
1841         (WebInspector.WorkerManager.prototype._openInspectorWindow):
1842         (WebInspector.WorkerManager.prototype._pageInspectorClosing):
1843         (WebInspector.DedicatedWorkerMessageForwarder.prototype._receiveMessage):
1844         * inspector/front-end/WorkersSidebarPane.js:
1845         (WebInspector.WorkersSidebarPane.prototype.removeWorker):
1846         * inspector/front-end/externs.js:
1847         (WebInspector.linkifyURL):
1848         (InjectedFakeWorker):
1849         * inspector/front-end/inspector.js:
1850
1851 2011-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1852
1853         Unreviewed, rolling out r96879.
1854         http://trac.webkit.org/changeset/96879
1855         https://bugs.webkit.org/show_bug.cgi?id=69618
1856
1857         Broke CCLayerTreeHostTestShortlived1 on chromium mac.
1858         (Requested by podivilov on #webkit).
1859
1860         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
1861
1862 2011-10-07  Pavel Feldman  <pfeldman@google.com>
1863
1864         Web Inspector: add ResourcesPanel to the compilation.
1865         https://bugs.webkit.org/show_bug.cgi?id=69612
1866
1867         Reviewed by Yury Semikhatsky.
1868
1869         * inspector/compile-front-end.sh:
1870         * inspector/front-end/ApplicationCacheItemsView.js:
1871         (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
1872         * inspector/front-end/NetworkPanel.js:
1873         * inspector/front-end/ResourceView.js:
1874         * inspector/front-end/ResourcesPanel.js:
1875         (WebInspector.ResourcesPanel.prototype.showAnchorLocation):
1876         (WebInspector.ResourcesPanel.prototype.showResource):
1877         (WebInspector.BaseStorageTreeElement.prototype.isEventWithinDisclosureTriangle):
1878         (WebInspector.FrameTreeElement.prototype.frameNavigated):
1879         (WebInspector.StorageCategoryView):
1880         (WebInspector.SearchResultsTreeElementsTraverser.prototype.last):
1881         * inspector/front-end/externs.js:
1882         (WebInspector.openRequestInNetworkPanel):
1883
1884 2011-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1885
1886         Unreviewed, rolling out r96909.
1887         http://trac.webkit.org/changeset/96909
1888         https://bugs.webkit.org/show_bug.cgi?id=69616
1889
1890         Broke chromium mac compilation (Requested by podivilov on
1891         #webkit).
1892
1893         * platform/graphics/chromium/ContentLayerChromium.h:
1894
1895 2011-10-07  Vsevolod Vlasov  <vsevik@chromium.org>
1896
1897         Web Inspector: Element highlighting does not highlight padding/border/margin for inline elements.
1898         https://bugs.webkit.org/show_bug.cgi?id=69558
1899
1900         Reviewed by Pavel Feldman.
1901
1902         * inspector/DOMNodeHighlighter.cpp:
1903
1904 2011-10-07  Mario Sanchez Prada  <msanchez@igalia.com>
1905
1906         [GTK] Don't expose objects with unknown role on GTK
1907         https://bugs.webkit.org/show_bug.cgi?id=69561
1908
1909         Reviewed by Chris Fleizach.
1910
1911         Ignore accessibility objects in accessibilityPlatformIncludesObject.
1912
1913         Test: platform/gtk/accessibility/unknown-roles-not-exposed.html
1914
1915         * accessibility/gtk/AccessibilityObjectAtk.cpp:
1916         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
1917         For unknown accessibility objects, return IgnoreObject.
1918
1919 2011-10-07  Pavel Feldman  <pfeldman@chromium.org>
1920
1921         Web Inspector: add Elements and Network panels to the compilation
1922         https://bugs.webkit.org/show_bug.cgi?id=69604
1923
1924         Reviewed by Yury Semikhatsky.
1925
1926         * inspector/compile-front-end.sh:
1927         * inspector/front-end/BreakpointsSidebarPane.js:
1928         (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked):
1929         (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked):
1930         * inspector/front-end/DOMAgent.js:
1931         * inspector/front-end/DOMBreakpointsSidebarPane.js:
1932         * inspector/front-end/DataGrid.js:
1933         (WebInspector.DataGrid.prototype._startEditingConfig):
1934         * inspector/front-end/Drawer.js:
1935         * inspector/front-end/ElementsPanel.js:
1936         (WebInspector.ElementsPanel.prototype._hideSearchHighlights):
1937         (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
1938         (WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes.collapseDimmed):
1939         (WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes):
1940         (WebInspector.ElementsPanel.prototype._registerShortcuts):
1941         * inspector/front-end/ElementsTreeOutline.js:
1942         (WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
1943         (WebInspector.ElementsTreeElement.prototype._startEditingTextNode):
1944         (WebInspector.ElementsTreeElement.prototype._startEditingTagName):
1945         (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
1946         * inspector/front-end/GoToLineDialog.js:
1947         (WebInspector.GoToLineDialog._show):
1948         * inspector/front-end/MetricsSidebarPane.js:
1949         (WebInspector.MetricsSidebarPane.prototype.startEditing):
1950         * inspector/front-end/NetworkPanel.js:
1951         (WebInspector.NetworkLogView.prototype._onLoadEventFired):
1952         (WebInspector.NetworkLogView.prototype._domContentLoadedEventFired):
1953         (WebInspector.NetworkLogView.prototype._updateOffscreenRows):
1954         (WebInspector.NetworkLogView.prototype._removeAllNodeHighlights):
1955         (WebInspector.NetworkPanel.prototype._resourceByAnchor):
1956         (WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
1957         * inspector/front-end/ObjectPropertiesSection.js:
1958         (WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
1959         * inspector/front-end/Panel.js:
1960         * inspector/front-end/Popover.js:
1961         * inspector/front-end/SourceFrame.js:
1962         (WebInspector.SourceFrame.prototype._editBreakpointCondition):
1963         * inspector/front-end/StylesSidebarPane.js:
1964         (WebInspector.StylePropertiesSection.prototype.startEditingSelector):
1965         (WebInspector.StylePropertyTreeElement.prototype):
1966         * inspector/front-end/TimelineGrid.js:
1967         * inspector/front-end/UIUtils.js:
1968         (WebInspector.EditingConfig):
1969         (WebInspector.startEditing.editingCancelled):
1970         (WebInspector.startEditing.editingCommitted):
1971         (WebInspector.formatLocalized):
1972         (WebInspector.openLinkExternallyLabel):
1973         (WebInspector.openInNetworkPanelLabel):
1974         (WebInspector.copyLinkAddressLabel):
1975         * inspector/front-end/externs.js:
1976         (WebInspector.extensionServer.notifyObjectSelected):
1977         (WebInspector.openResource):
1978         * inspector/front-end/inspector.js:
1979         (WebInspector.resourceForURL):
1980
1981 2011-10-07  Anna Cavender  <annacc@chromium.org>
1982
1983         Change enum value names for TextTrack::readyState and TextTrack::mode
1984         https://bugs.webkit.org/show_bug.cgi?id=69603
1985
1986         Reviewed by David Levin.
1987
1988         No new tests. No new functionality.
1989
1990         * html/LoadableTextTrack.cpp:
1991         (WebCore::LoadableTextTrack::trackLoadStarted):
1992         (WebCore::LoadableTextTrack::trackLoadError):
1993         (WebCore::LoadableTextTrack::trackLoadCompleted):
1994         * html/TextTrack.cpp:
1995         (WebCore::TextTrack::TextTrack):
1996         (WebCore::TextTrack::setMode):
1997         * html/TextTrack.h:
1998
1999 2011-10-07  Anna Cavender  <annacc@chromium.org>
2000
2001         Adding parens in WebVTTParser.cpp to appease compiler preferences.
2002         https://bugs.webkit.org/show_bug.cgi?id=69602
2003
2004         Reviewed by David Levin.
2005
2006         No new tests. No new functionality.
2007
2008         * html/track/WebVTTParser.cpp:
2009         (WebCore::WebVTTParser::constructTreeFromToken):
2010
2011 2011-10-06  Antoine Labour  <piman@chromium.org>
2012
2013         Webkit API for compositor
2014         https://bugs.webkit.org/show_bug.cgi?id=69107
2015
2016         Reviewed by Darin Fisher.
2017
2018         Covered by existing compositing tests.
2019
2020         * platform/graphics/chromium/ContentLayerChromium.h: 
2021
2022 2011-10-06  Kent Tamura  <tkent@chromium.org>
2023
2024         Remove SelectElement class
2025         https://bugs.webkit.org/show_bug.cgi?id=69518
2026
2027         Reviewed by Ryosuke Niwa.
2028
2029         SelectElement used to be an abstract class for HTMLSelectElement
2030         and WMLSelectElement. SelectElement is not needed anymore because
2031         WML was removed.
2032
2033         This patch just removes SelectElement by moving SelectElement
2034         functions to HTMLSelectElement.
2035
2036         No new tests. Just a refactoring.
2037
2038         * WebCore.vcproj/WebCore.vcproj:
2039         Rename dom\SelectElementWin.cpp to html\HTMLSelectElementWin.cpp.
2040         * accessibility/AccessibilityListBoxOption.cpp:
2041         (WebCore::AccessibilityListBoxOption::setSelected):
2042         Remove unnecessary cast.
2043         * accessibility/AccessibilityRenderObject.cpp:
2044         (WebCore::AccessibilityRenderObject::stringValue):
2045         Use HTMLSelectElement instead of SelectElement.
2046         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2047         (optionFromSelection): ditto.
2048         (webkit_accessible_selection_get_selection_count): ditto.
2049         * accessibility/gtk/AXObjectCacheAtk.cpp:
2050         (notifyChildrenSelectionChange): ditto.
2051         * dom/OptionElement.cpp:
2052         (WebCore::OptionElement::optionIndex): ditto.
2053         * dom/OptionElement.h: ditto.
2054         * dom/SelectElement.cpp:
2055         (WebCore::SelectElementData::checkListItems): ditto.
2056         (WebCore::SelectElementData::listItems): ditto.
2057         * dom/SelectElementWin.cpp: Removed.
2058         * dom/SelectElement.h: Removed SelectElement class declaration.
2059         * html/HTMLSelectElement.cpp: Move functions from SelectElement.cpp.
2060         (WebCore::HTMLSelectElement::selectedIndex):
2061         Removed 'SelectElement::' because the function is moved to HTMLSelectElement.
2062         (WebCore::HTMLSelectElement::deselectItems): dito.
2063         (WebCore::HTMLSelectElement::setSelectedIndex): dito.
2064         (WebCore::HTMLSelectElement::setSelectedIndexByUser): ditto.
2065         (WebCore::HTMLSelectElement::activeSelectionEndListIndex): ditto.
2066         (WebCore::HTMLSelectElement::length): ditto.
2067         (WebCore::HTMLSelectElement::saveFormControlState): ditto.
2068         (WebCore::HTMLSelectElement::restoreFormControlState): ditto.
2069         (WebCore::HTMLSelectElement::parseMappedAttribute): ditto.
2070         (WebCore::HTMLSelectElement::selectAll): ditto.
2071         (WebCore::HTMLSelectElement::appendFormData): ditto.
2072         (WebCore::HTMLSelectElement::optionToListIndex): ditto.
2073         (WebCore::HTMLSelectElement::listToOptionIndex): ditto.
2074         (WebCore::HTMLSelectElement::recalcListItems): ditto.
2075         (WebCore::HTMLSelectElement::setRecalcListItems): ditto.
2076         (WebCore::HTMLSelectElement::reset): ditto.
2077         (WebCore::HTMLSelectElement::dispatchFocusEvent): ditto.
2078         (WebCore::HTMLSelectElement::dispatchBlurEvent): ditto.
2079         (WebCore::HTMLSelectElement::defaultEventHandler): ditto.
2080         (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto.
2081         (WebCore::HTMLSelectElement::setActiveSelectionEndIndex): ditto.
2082         (WebCore::HTMLSelectElement::updateListBoxSelection): ditto.
2083         (WebCore::HTMLSelectElement::menuListOnChange): ditto.
2084         (WebCore::HTMLSelectElement::listBoxOnChange): ditto.
2085         (WebCore::HTMLSelectElement::saveLastSelection): ditto.
2086         (WebCore::HTMLSelectElement::accessKeySetSelectedIndex): ditto.
2087         (WebCore::HTMLSelectElement::scrollToSelection): ditto.
2088         (WebCore::HTMLSelectElement::insertedIntoTree): ditto.
2089         (WebCore::nextValidIndex): Moved from SelectElement.cpp.
2090         (WebCore::nextSelectableListIndex): ditto.
2091         (WebCore::previousSelectableListIndex): ditto.
2092         (WebCore::firstSelectableListIndex): ditto.
2093         (WebCore::lastSelectableListIndex): ditto.
2094         (WebCore::nextSelectableListIndexPageAway): ditto.
2095         (WebCore::HTMLSelectElement::setOptionsChangedOnRenderer): ditto.
2096         (WebCore::HTMLSelectElement::parseMultipleAttribute): ditto.
2097         (WebCore::HTMLSelectElement::platformHandleKeydownEvent): ditto.
2098         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
2099         (WebCore::HTMLSelectElement::updateSelectedState): ditto.
2100         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
2101         (WebCore::HTMLSelectElement::lastSelectedListIndex): ditto.
2102         (WebCore::stripLeadingWhiteSpace): ditto.
2103         (WebCore::HTMLSelectElement::typeAheadFind): ditto.
2104         (WebCore::HTMLSelectElement::optionCount): ditto.
2105         (WebCore::toSelectElement): ditto.
2106         * html/HTMLSelectElementWin.cpp: Copied from Source/WebCore/dom/SelectElementWin.cpp.
2107         (WebCore::HTMLSelectElement::platformHandleKeydownEvent):
2108         * html/HTMLSelectElement.h: Removed 'virtual' of SelectElement functions.
2109         (WebCore::HTMLSelectElement::size):
2110         (WebCore::HTMLSelectElement::multiple):
2111         (WebCore::HTMLSelectElement::listItems):
2112         (WebCore::HTMLSelectElement::updateValidity):
2113         * rendering/RenderListBox.cpp: Replace SelectElement with HTMLSelectElement
2114         (WebCore::RenderListBox::RenderListBox):
2115         (WebCore::RenderListBox::scrollToRevealSelection):
2116         (WebCore::RenderListBox::addFocusRingRects):
2117         (WebCore::RenderListBox::paintItemForeground):
2118         (WebCore::RenderListBox::paintItemBackground):
2119         (WebCore::RenderListBox::panScroll):
2120         (WebCore::RenderListBox::autoscroll):
2121         (WebCore::RenderListBox::valueChanged):
2122         * rendering/RenderMenuList.cpp: Replace SelectElement with HTMLSelectElement
2123         (WebCore::RenderMenuList::RenderMenuList):
2124         (WebCore::RenderMenuList::setTextFromOption):
2125         (WebCore::RenderMenuList::showPopup):
2126         (WebCore::RenderMenuList::valueChanged):
2127         (WebCore::RenderMenuList::listBoxSelectItem):
2128         (WebCore::RenderMenuList::multiple):
2129         (WebCore::RenderMenuList::didSetSelectedIndex):
2130         (WebCore::RenderMenuList::didUpdateActiveOption):
2131         (WebCore::RenderMenuList::itemText):
2132         (WebCore::RenderMenuList::itemAccessibilityText):
2133         (WebCore::RenderMenuList::itemToolTip):
2134         (WebCore::RenderMenuList::itemIsEnabled):
2135         (WebCore::RenderMenuList::itemStyle):
2136         (WebCore::RenderMenuList::itemBackgroundColor):
2137         (WebCore::RenderMenuList::listSize):
2138         (WebCore::RenderMenuList::selectedIndex):
2139         (WebCore::RenderMenuList::itemIsSeparator):
2140         (WebCore::RenderMenuList::itemIsLabel):
2141         (WebCore::RenderMenuList::itemIsSelected):
2142         (WebCore::RenderMenuList::setTextFromItem):
2143
2144 2011-10-06  Sheriff Bot  <webkit.review.bot@gmail.com>
2145
2146         Unreviewed, rolling out r96896.
2147         http://trac.webkit.org/changeset/96896
2148         https://bugs.webkit.org/show_bug.cgi?id=69601
2149
2150         broke windows and mac chromium builds (Requested by simonjam
2151         on #webkit).
2152
2153         * platform/graphics/chromium/ContentLayerChromium.h:
2154
2155 2011-10-06  Antoine Labour  <piman@chromium.org>
2156
2157         Webkit API for compositor
2158         https://bugs.webkit.org/show_bug.cgi?id=69107
2159
2160         Reviewed by Darin Fisher.
2161
2162         Covered by existing compositing tests.
2163
2164         * platform/graphics/chromium/ContentLayerChromium.h: 
2165
2166 2011-10-06  Joseph Pecoraro  <joepeck@webkit.org>
2167
2168         Reviewed by Kent Tamura.
2169
2170         Pass "accept" mime type information into FileChooser at all call sites
2171         https://bugs.webkit.org/show_bug.cgi?id=69592
2172
2173         No new tests. This only exposes some more information to
2174         WebKit ports, no functionality change in WebCore.
2175
2176         * html/FileInputType.cpp:
2177         (WebCore::FileInputType::receiveDropForDirectoryUpload):
2178
2179 2011-10-06  Kent Tamura  <tkent@chromium.org>
2180
2181         [JSC binding] Fix inconsistent behavior of DOMStringMap
2182         https://bugs.webkit.org/show_bug.cgi?id=53752
2183
2184         Reviewed by Darin Adler.
2185
2186         The dataset behavior was inconsistent. The get operation handled
2187         data-* attributes first, and the put and delete operations handled
2188         JavaScript properties first.
2189
2190         Like Firefox and Opera, the put and delete operations should
2191         handle data-* attribute first.
2192
2193         * bindings/js/JSDOMStringMapCustom.cpp:
2194         (WebCore::JSDOMStringMap::deleteProperty):
2195          Handles DOMStringMap first, then returns false if the DOMStringMap makes an error.
2196         (WebCore::JSDOMStringMap::putDelegate): ditto.
2197
2198 2011-10-06  Nico Weber  <thakis@chromium.org>
2199
2200         [chromium] Let rule_binding use os.execvp() instead of subprocess.call() to spawn fewer processes.
2201         https://bugs.webkit.org/show_bug.cgi?id=69589
2202
2203         Reviewed by Adam Barth.
2204
2205         When building with `make -j40`, all the binding rules are built en bloc. Since this script currently
2206         uses subprocess.call(), that actually spawns 80 processes at once. OS X has a max process limit of
2207         255 by default, so the build used to fail with
2208         "open2: fork failed: Resource temporarily unavailable at ../bindings/scripts/preprocessor.pm line 60"
2209         As a fix, use execvp() instead, which replaces the current process instead of spawning a new one.
2210
2211         * WebCore.gyp/scripts/rule_binding.py:
2212
2213 2011-10-06  Anders Carlsson  <andersca@apple.com>
2214
2215         When building with clang, enable -Wglobal-constructors and -Wexit-time-destructors
2216         https://bugs.webkit.org/show_bug.cgi?id=69586
2217
2218         Reviewed by Darin Adler.
2219
2220         * Configurations/Base.xcconfig:
2221         Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.
2222         
2223         * WebCore.xcodeproj/project.pbxproj:
2224         When building with clang, we don't need to run the check-for-global-initializers and
2225         check-for-exit-time-destructors anymore.
2226         
2227         * platform/graphics/filters/FEGaussianBlur.cpp:
2228         (gaussianKernelFactor):
2229         (WebCore::FEGaussianBlur::calculateKernelSize):
2230         (WebCore::FEGaussianBlur::calculateStdDeviation):
2231         Change the gaussian kernel factor global to be an inline function instead.
2232
2233 2011-10-06  Anders Carlsson  <andersca@apple.com>
2234
2235         Add DEFINE_DEBUG_ONLY_GLOBAL for globals that should be defined in debug builds
2236         https://bugs.webkit.org/show_bug.cgi?id=69584
2237
2238         Reviewed by Darin Adler.
2239
2240         Adopt the DEFINE_DEBUG_ONLY_GLOBAL macro.
2241
2242         * bindings/js/JSLazyEventListener.cpp:
2243         * dom/Node.cpp:
2244         * dom/Range.cpp:
2245         * history/CachedPage.cpp:
2246         * loader/SubresourceLoader.cpp:
2247         * loader/cache/CachedResource.cpp:
2248         * page/Frame.cpp:
2249         * page/Page.cpp:
2250         * rendering/BidiRun.cpp:
2251         * rendering/RenderObject.cpp:
2252         * svg/SVGElementInstance.cpp:
2253         * xml/XMLHttpRequest.cpp:
2254
2255 2011-10-06  James Robinson  <jamesr@chromium.org>
2256
2257         [chromium] Remove USE(THREADED_COMPOSITING) from the tree
2258         https://bugs.webkit.org/show_bug.cgi?id=69489
2259
2260         Reviewed by Darin Fisher.
2261
2262         This macro isn't needed any more since the logic it guarded is guarded by a runtime switch.
2263
2264         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
2265
2266 2011-10-06  David Grogan  <dgrogan@chromium.org>
2267
2268         Return null for the value of IDB key cursors instead of ASSERTing
2269         https://bugs.webkit.org/show_bug.cgi?id=69131
2270         
2271         This is in support of the IndexedDB performance improvement here:
2272         http://codereview.chromium.org/7834006/
2273
2274         Reviewed by Tony Chang.
2275
2276         * storage/IDBCursorBackendImpl.cpp:
2277         (WebCore::IDBCursorBackendImpl::value):
2278
2279 2011-10-06  Alexey Proskuryakov  <ap@apple.com>
2280
2281         [Mac] Should be able to scroll embedded PDFs using mouse
2282         https://bugs.webkit.org/show_bug.cgi?id=69579
2283
2284         Reviewed by Darin Adler.
2285
2286         Hit testing doesn't find scrollbars installed by a plug-in, so mouse events don't work.
2287
2288         As we want to use WebKit scrollbars with PDF plug-in, a cleaner long-term solution would be
2289         to have a base class under PluginViewBase that can handle scrolling instead of doing that
2290         in PluginView and Plugin.
2291
2292         * plugins/PluginViewBase.h:
2293         (WebCore::PluginViewBase::horizontalScrollbar):
2294         (WebCore::PluginViewBase::verticalScrollbar):
2295         Added accessors for scrollbars installed by plug-in.
2296
2297         * rendering/nodeAtPoint.cpp: (WebCore::RenderEmbeddedObject::nodeAtPoint):
2298         Like RenderLayer, add scrollbars to hit result after normal  hit testing.
2299
2300         * rendering/RenderEmbeddedObject.h: Added a nodeAtPoint override.
2301
2302         * rendering/RenderWidget.h: Made nodeAtPoint() protected instead of private, so that
2303         RenderEmbeddedObject could call it.
2304
2305 2011-10-06  Dan Bernstein  <mitz@apple.com>
2306
2307         <rdar://problem/9717490> Flash of white when navigating daringfireball.net
2308         https://bugs.webkit.org/show_bug.cgi?id=69581
2309
2310         Reviewed by Darin Adler.
2311
2312         * platform/ScrollView.cpp:
2313         (WebCore::ScrollView::updateScrollbars): Moved the calls to Scrollbar::setEnabled() into the code
2314         section where invalidation is suppressed if necessary, so that they do not trigger premature invalidation.
2315
2316 2011-10-06  Dan Bernstein  <mitz@apple.com>
2317
2318         Added a comment explaining code added in r96834.
2319
2320         Suggested by Darin Adler.
2321
2322         * editing/FrameSelection.cpp:
2323         (WebCore::FrameSelection::updateAppearance):
2324
2325 2011-10-05  Ryosuke Niwa  <rniwa@webkit.org>
2326
2327         Deleting line break before h1 converts h1 to span
2328         https://bugs.webkit.org/show_bug.cgi?id=45784
2329
2330         Reviewed by Enrica Casucci.
2331
2332         This patch fundamentally alters the kind of styles we preserve while merging or moving paragraphs.
2333         StylizedMarkupAccumulator no longer wraps nodes by computed style when it's not annotating for interchange.
2334         Instead, it accumulates implicit and inline styles of ancestors of the serialized contents.
2335
2336         The most significant code change is in StyledMarkupAccumulator::serializeNodes where we setup m_wrappingStyle
2337         by merging implicit and inline style of ancestors with mergeInlineAndImplicitStyleOfElement. Because it walks up
2338         the DOM tree upwards, it should not be overriding any CSS properties. Consequently, mergeStyle,
2339         mergeInlineStyleOfElement, and mergeInlineAndImplicitStyleOfElement are modified to take CSSPropertyOverrideMode.
2340
2341         New behavior matches that of Internet Explorer and Firefox when merging paragraphs.
2342
2343         Tests: editing/deleting/merge-paragraph-from-address.html
2344                editing/deleting/merge-paragraph-from-h6-with-style-2.html
2345                editing/deleting/merge-paragraph-from-h6-with-style.html
2346                editing/deleting/merge-paragraph-from-h6.html
2347                editing/deleting/merge-paragraph-from-listing.html
2348                editing/deleting/merge-paragraph-from-p-with-style-2.html
2349                editing/deleting/merge-paragraph-from-p-with-style-3.html
2350                editing/deleting/merge-paragraph-from-p-with-style.html
2351                editing/deleting/merge-paragraph-into-h1-with-style.html
2352                editing/deleting/merge-paragraph-into-h1.html
2353                editing/deleting/merge-paragraph-into-pre.html
2354
2355         * css/CSSValueList.cpp:
2356         (WebCore::CSSValueList::hasValue): Made const.
2357         * css/CSSValueList.h:
2358         * editing/ApplyStyleCommand.cpp:
2359         (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Calls mergeInlineStyleOfElement.
2360         (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Ditto.
2361         * editing/EditingStyle.cpp:
2362         (WebCore::copyEditingProperties): Takes a boolean includeBackgroundColor.
2363         (WebCore::isEditingProperty): Extracted from elementIsStyledSpanOrHTMLEquivalent.
2364         (WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent): Calls isEditingProperty.
2365         (WebCore::EditingStyle::mergeTypingStyle): Calls mergeStyle.
2366         (WebCore::EditingStyle::mergeInlineStyleOfElement): Takes CSSPropertyOverrideMode.
2367         (WebCore::elementMatchesAndPropertyIsNotInInlineStyleDecl): Added.
2368         (WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement): Added.
2369         (WebCore::mergeTextDecorationValues): Extracted from mergeStyle.
2370         (WebCore::EditingStyle::mergeStyle): Takes CSSPropertyOverrideMode.
2371         * editing/EditingStyle.h:
2372         * editing/ReplaceSelectionCommand.cpp:
2373         (WebCore::nodeToSplitToAvoidPastingIntoInlineNodesWithStyle): Extracted from doApply.
2374         (WebCore::ReplaceSelectionCommand::doApply): Calls nodeToSplitToAvoidPastingIntoInlineNodesWithStyle.
2375         (WebCore::ReplaceSelectionCommand::performTrivialReplace): Exit early when we need to split the tree to avoid
2376         pasting into inline nodes with style. Also remove a collapsed or spurious br.
2377         * editing/markup.cpp:
2378         (WebCore::StyledMarkupAccumulator::serializeNodes):
2379
2380 2011-10-06  Abhishek Arya  <inferno@chromium.org>
2381
2382         Crash in VisiblePosition::canonicalPosition.
2383         https://bugs.webkit.org/show_bug.cgi?id=69568
2384
2385         Reviewed by Ryosuke Niwa.
2386
2387         Move the position's containerNode calculation after layout is
2388         complete(in updateLayoutIgnorePendingStylesheets).        
2389
2390         Test: editing/selection/selection-plugin-clear-crash.html
2391
2392         * editing/VisiblePosition.cpp:
2393         (WebCore::VisiblePosition::canonicalPosition):
2394
2395 2011-10-06  Sheriff Bot  <webkit.review.bot@gmail.com>
2396
2397         Unreviewed, rolling out r96861.
2398         http://trac.webkit.org/changeset/96861
2399         https://bugs.webkit.org/show_bug.cgi?id=69573
2400
2401         This patch didn't compile on windows (Requested by annacc on
2402         #webkit).
2403
2404         * html/track/WebVTTParser.cpp:
2405         (WebCore::WebVTTParser::constructTreeFromToken):
2406
2407 2011-10-06  Anna Cavender  <annacc@chromium.org>
2408
2409         Adding parens in WebVTTParser.cpp to appease compiler preferences.
2410         https://bugs.webkit.org/show_bug.cgi?id=69460
2411
2412         Reviewed by David Levin.
2413
2414         No new tests. No new functionality.
2415
2416         * html/track/WebVTTParser.cpp:
2417         (WebCore::WebVTTParser::constructTreeFromToken):
2418
2419 2011-10-06  Fady Samuel  <fsamuel@chromium.org>
2420
2421         Code clean-up: Make RenderObject::absoluteBoundingBoxRect and associated methods const and make its parameter useTransforms no longer default to false
2422         https://bugs.webkit.org/show_bug.cgi?id=69009
2423
2424         Reviewed by Simon Fraser.
2425
2426         Upcoming patches may make use of absoluteBoundingBoxRect on a const RenderObject, so this needed to be fixed.
2427         Making useTransforms default to true instead of false and replacing instances of absoluteBoundingBoxRect() to
2428         absoluteBoundingBoxRectIgnoringTransforms() partially addreses // FIXME: useTransforms should go away eventually.
2429
2430         * WebCore.exp.in:
2431         * dom/Element.cpp:
2432         (WebCore::Element::screenRect):
2433         * dom/Node.cpp:
2434         (WebCore::Node::getRect):
2435         (WebCore::Node::renderRect):
2436         * html/shadow/SliderThumbElement.cpp:
2437         (WebCore::SliderThumbElement::setPositionFromPoint):
2438         * html/shadow/TextControlInnerElements.cpp:
2439         (WebCore::InputFieldSpeechButtonElement::startSpeechInput):
2440         * inspector/DOMNodeHighlighter.cpp:
2441         * plugins/IFrameShimSupport.cpp:
2442         (WebCore::getPluginOcclusions):
2443         * rendering/RenderBlock.cpp:
2444         (WebCore::RenderBlock::absoluteRects):
2445         (WebCore::RenderBlock::absoluteQuads):
2446         * rendering/RenderBlock.h:
2447         * rendering/RenderBox.cpp:
2448         (WebCore::RenderBox::absoluteRects):
2449         (WebCore::RenderBox::absoluteQuads):
2450         * rendering/RenderBox.h:
2451         * rendering/RenderFileUploadControl.cpp:
2452         (WebCore::RenderFileUploadControl::paintObject):
2453         * rendering/RenderIFrame.cpp:
2454         (WebCore::RenderIFrame::flattenFrame):
2455         * rendering/RenderInline.cpp:
2456         (WebCore::RenderInline::absoluteRects):
2457         (WebCore::RenderInline::culledInlineAbsoluteRects):
2458         (WebCore::RenderInline::absoluteQuads):
2459         (WebCore::RenderInline::culledInlineAbsoluteQuads):
2460         * rendering/RenderInline.h:
2461         * rendering/RenderMenuList.cpp:
2462         (WebCore::RenderMenuList::showPopup):
2463         * rendering/RenderObject.cpp:
2464         (WebCore::RenderObject::absoluteBoundingBoxRect):
2465         (WebCore::RenderObject::addAbsoluteRectForLayer):
2466         (WebCore::RenderObject::paintingRootRect):
2467         * rendering/RenderObject.h:
2468         (WebCore::RenderObject::absoluteRects):
2469         (WebCore::RenderObject::absoluteBoundingBoxRectIgnoringTransforms):
2470         (WebCore::RenderObject::absoluteQuads):
2471         * rendering/RenderText.cpp:
2472         (WebCore::RenderText::absoluteRects):
2473         (WebCore::RenderText::absoluteQuads):
2474         * rendering/RenderText.h:
2475         * rendering/RenderTextControlSingleLine.cpp:
2476         (WebCore::RenderTextControlSingleLine::showPopup):
2477         * rendering/RenderThemeSafari.cpp:
2478         (WebCore::RenderThemeSafari::paintSearchFieldCancelButton):
2479         (WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration):
2480         (WebCore::RenderThemeSafari::paintSearchFieldResultsButton):
2481         * rendering/RenderView.cpp:
2482         (WebCore::RenderView::absoluteRects):
2483         (WebCore::RenderView::absoluteQuads):
2484         * rendering/RenderView.h:
2485         * rendering/svg/RenderSVGBlock.cpp:
2486         (WebCore::RenderSVGBlock::absoluteRects):
2487         * rendering/svg/RenderSVGBlock.h:
2488         * rendering/svg/RenderSVGHiddenContainer.cpp:
2489         (WebCore::RenderSVGHiddenContainer::absoluteQuads):
2490         * rendering/svg/RenderSVGHiddenContainer.h:
2491         * rendering/svg/RenderSVGInline.cpp:
2492         (WebCore::RenderSVGInline::absoluteQuads):
2493         * rendering/svg/RenderSVGInline.h:
2494         * rendering/svg/RenderSVGModelObject.cpp:
2495         (WebCore::RenderSVGModelObject::absoluteRects):
2496         (WebCore::RenderSVGModelObject::absoluteQuads):
2497         * rendering/svg/RenderSVGModelObject.h:
2498         * rendering/svg/RenderSVGText.cpp:
2499         (WebCore::RenderSVGText::absoluteQuads):
2500         * rendering/svg/RenderSVGText.h:
2501         * testing/Internals.cpp:
2502         (WebCore::Internals::boundingBox):
2503
2504 2011-10-06  Simon Hausmann  <simon.hausmann@nokia.com>
2505
2506         [Qt][Wk2] Fix build with Qt 5 when QtScript is built as standalone module
2507         https://bugs.webkit.org/show_bug.cgi?id=69520
2508
2509         Reviewed by Csaba Osztrogonác.
2510
2511         * WebCore.pri: Use qt5 scope.
2512         * WebCore.pro: Use qt5 scope and pull in QtScript for the time being.
2513
2514 2011-10-06  Tony Chang  <tony@chromium.org>
2515
2516         last frame of a multipart response is not displayed
2517         https://bugs.webkit.org/show_bug.cgi?id=69449
2518
2519         Reviewed by Adam Barth.
2520
2521         Test: http/tests/multipart/load-last-non-html-frame.php
2522
2523         * loader/DocumentLoader.cpp:
2524         (WebCore::DocumentLoader::maybeFinishLoadingMultipartContent): for non-progressive load pages, commit the load so the
2525             last frame will be displayed.
2526         * loader/DocumentLoader.h:
2527         * loader/MainResourceLoader.cpp:
2528         (WebCore::MainResourceLoader::didFinishLoading):
2529
2530 2011-10-06  Gavin Peters  <gavinp@chromium.org>
2531
2532         conditionalize m_cachedScript stacks to just Chromium port
2533         https://bugs.webkit.org/show_bug.cgi?id=69537
2534
2535         New stack saving telemetry code in ScriptElement shouldn't have
2536         been put in all ports; just narrowing it to the chromium port will
2537         save other ports the memory hit of this diagnostic code.
2538
2539         Reviewed by Nate Chapin.
2540
2541         No new tests.
2542
2543         * dom/ScriptElement.cpp:
2544         (WebCore::ScriptElement::ScriptElement):
2545         (WebCore::ScriptElement::requestScript):
2546         (WebCore::ScriptElement::stopLoadRequest):
2547         (WebCore::ScriptElement::notifyFinished):
2548         * dom/ScriptElement.h:
2549
2550 2011-10-06  Arthur Hsu  <arthurhsu@chromium.org>
2551
2552         Ensure font loaded before calling Skia to drawPosText in Chrome sandbox
2553         https://bugs.webkit.org/show_bug.cgi?id=69370
2554
2555         Reviewed by James Robinson.
2556
2557         * platform/graphics/chromium/FontChromiumWin.cpp:
2558         (WebCore::Font::drawGlyphs):
2559
2560 2011-10-06  Chris Rogers  <crogers@google.com>
2561
2562         BiquadFilterNode must not reset filter state if type attribute is set to the same type
2563         https://bugs.webkit.org/show_bug.cgi?id=69485
2564
2565         Reviewed by Kenneth Russell.
2566
2567         No new tests.  This particular case is difficult to test with a layout test using OfflineAudioContext.
2568
2569         * webaudio/BiquadProcessor.cpp:
2570         (WebCore::BiquadProcessor::setType):
2571         * webaudio/BiquadProcessor.h:
2572
2573 2011-10-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
2574
2575         [EFL] Do not create cairo surfaces with the wrong size for form elements
2576         https://bugs.webkit.org/show_bug.cgi?id=69533
2577
2578         Reviewed by Ryosuke Niwa.
2579
2580         RenderThemeEfl::cacheThemePartResizeAndReset resizes the Ecore_Evas
2581         associated with an entry, but did not reset the `size` attribute of the
2582         struct -- in practice, this meant the subsequent call to
2583         themePartCacheEntrySurfaceCreate would create a cairo surface with the
2584         previous size, thus rendering an element with the wrong size.
2585
2586         No new tests, this is triggered by running running pixel tests for
2587         running, in this order, fast/forms/button-sizes.html,
2588         fast/forms/input-appearance-preventDefault.html,
2589         fast/forms/input-appearance-spinbutton-disabled-readonly.html,
2590         fast/forms/input-appearance-width.html,
2591         fast/forms/input-button-sizes.html,
2592         fast/forms/input-placeholder-text-indent.html and
2593         fast/forms/input-text-click-inside.html (!).
2594
2595         * platform/efl/RenderThemeEfl.cpp:
2596         (WebCore::RenderThemeEfl::cacheThemePartResizeAndReset): Reset the
2597         size attribute when resizing the canvas.
2598
2599 2011-10-06  Chris Rogers  <crogers@google.com>
2600
2601         Make sure OfflineAudioContext can not be created with a sample-rate less than 44.1KHz
2602         https://bugs.webkit.org/show_bug.cgi?id=69483
2603
2604         Reviewed by Kenneth Russell.
2605
2606         No new tests.
2607
2608         * webaudio/AudioBuffer.cpp:
2609         (WebCore::AudioBuffer::create):
2610         * webaudio/AudioContext.cpp:
2611         (WebCore::AudioContext::createBuffer):
2612
2613 2011-10-06  David Hyatt  <hyatt@apple.com>
2614
2615         https://bugs.webkit.org/show_bug.cgi?id=69544
2616         
2617         [CSS3 Regions] Compute the starting and ending regions of a block, so that we can clamp
2618         descendants to those regions. This is preparation for having true overflow in the boxes
2619         in each region, and it's also a performance optimization to reduce the amount of
2620         region walking that the RenderFlowThread is doing.
2621
2622         Add a range map to RenderFlowThread to cache the start/end regions for each box.
2623         
2624         Amend everyone who calls renderRegionForLine to pass in the box that is making the query.
2625         This box is then used to clamp to start and end regions so that any regions outside of that
2626         range will never be examined.
2627
2628         Reviewed by Dan Bernstein.
2629
2630         Test: fast/regions/top-overflow-out-of-second-region.html
2631
2632         * rendering/RenderBlock.cpp:
2633         (WebCore::RenderBlock::layoutBlock):
2634         (WebCore::RenderBlock::hasNextPage):
2635         (WebCore::RenderBlock::pageLogicalHeightForOffset):
2636         (WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
2637         (WebCore::RenderBlock::regionAtBlockOffset):
2638         * rendering/RenderFlowThread.cpp:
2639         (WebCore::RenderFlowThread::~RenderFlowThread):
2640         (WebCore::RenderFlowThread::layout):
2641         (WebCore::RenderFlowThread::renderRegionForLine):
2642         (WebCore::RenderFlowThread::regionLogicalWidthForLine):
2643         (WebCore::RenderFlowThread::regionLogicalHeightForLine):
2644         (WebCore::RenderFlowThread::regionRemainingLogicalHeightForLine):
2645         (WebCore::RenderFlowThread::mapFromFlowToRegion):
2646         (WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
2647         (WebCore::RenderFlowThread::logicalWidthChangedInRegions):
2648         (WebCore::RenderFlowThread::setRegionRangeForBox):
2649         (WebCore::RenderFlowThread::getRegionRangeForBox):
2650         * rendering/RenderFlowThread.h:
2651         * rendering/RenderRegion.cpp:
2652         (WebCore::RenderRegion::takeRenderBoxRegionInfo):
2653         (WebCore::RenderRegion::removeRenderBoxRegionInfo):
2654         * rendering/RenderRegion.h:
2655
2656 2011-10-05  Gavin Barraclough  <barraclough@apple.com>
2657
2658         Add explicit JSGlobalThis type.
2659         https://bugs.webkit.org/show_bug.cgi?id=69478
2660
2661         Reviewed by Darin Adler.
2662
2663         JSC supports a split global object, as used by WebCore for the Window. As a stage
2664         of making this visible to JSC, make it so that if the global this value is not the
2665         global object itself, it must be a subclass of JSGlobalThis.
2666
2667         * ForwardingHeaders/runtime/JSGlobalThis.h: Added.
2668             - Added forwarding header.
2669         * bindings/js/JSDOMGlobalObject.cpp:
2670         (WebCore::JSDOMGlobalObject::finishCreation):
2671         * bindings/js/JSDOMGlobalObject.h:
2672             - finishCreation takes a JSGlobalThis, or thisValue is implicit.
2673         * bindings/js/JSDOMWindowShell.h:
2674             - Make the window shell a subclass of JSGlobalThis.
2675         * bindings/js/JSWorkerContextBase.cpp:
2676         (WebCore::JSWorkerContextBase::finishCreation):
2677             - Don't pass the thisValue to JSGlobalObject::finishCreation.
2678         * bindings/js/JSWorkerContextBase.h:
2679         * bindings/scripts/CodeGeneratorJS.pm:
2680         (GenerateHeader):
2681             - Don't pass the thisValue to JSGlobalObject::finishCreation,
2682               for worker contexts.
2683
2684 2011-10-06  Anna Cavender  <annacc@chromium.org>
2685
2686         Fix CodeGeneratorV8 for EnabledAtRuntime when class has no parent class.
2687         https://bugs.webkit.org/show_bug.cgi?id=69480
2688
2689         Reviewed by Adam Barth.
2690
2691         No new tests. No new functionality, yet.
2692
2693         * bindings/scripts/CodeGeneratorV8.pm:
2694
2695 2011-10-06  Dan Bernstein  <mitz@apple.com>
2696
2697         <rdar://problem/10232866> Assertion failure beneath blockSelectionGaps() when a selected node is removed
2698
2699         Reviewed by Ryosuke Niwa.
2700
2701         Test: editing/selection/invalid-in-RenderView.html
2702
2703         * editing/FrameSelection.cpp:
2704         (WebCore::FrameSelection::updateAppearance): Ensure that the VisibleSelection used to set the selection
2705         in the RenderView is valid, by reconstructing it from the current selection.
2706
2707 2011-10-06  Andreas Kling  <kling@webkit.org>
2708
2709         InlineBox's virtualLogicalHeight() partially limited to builds with SVG.
2710         https://bugs.webkit.org/show_bug.cgi?id=69538
2711
2712         Reviewed by Dan Bernstein.
2713
2714         Remove erroneous ENABLE(SVG) guards around the initialization and use
2715         of InlineBox::hasVirtualLogicalHeight.
2716
2717         This variable is used by TrailingFloatsRootInlineBox and should always
2718         be respected regardless of SVG support.
2719
2720         * rendering/InlineBox.cpp:
2721         (WebCore::InlineBox::logicalHeight):
2722         * rendering/InlineBox.h:
2723         (WebCore::InlineBox::InlineBox):
2724
2725 2011-10-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2726
2727         [GTK] Implement cache model for WebKit2
2728         https://bugs.webkit.org/show_bug.cgi?id=68434
2729
2730         Reviewed by Martin Robinson.
2731
2732         Add a function to FileSystem to get the free space of the file
2733         system where the given path is on.
2734
2735         * platform/FileSystem.h:
2736         * platform/gtk/FileSystemGtk.cpp:
2737         (WebCore::getVolumeFreeSizeForPath):
2738
2739 2011-10-06  Sergey Glazunov  <serg.glazunov@gmail.com>
2740
2741         Add check for JavaScript URLs in HTMLPlugInImageElement::allowedToLoadFrameURL
2742         https://bugs.webkit.org/show_bug.cgi?id=68813
2743
2744         Reviewed by Adam Barth.
2745
2746         Test: http/tests/security/xss-DENIED-object-element.html
2747
2748         * html/HTMLPlugInImageElement.cpp:
2749         (WebCore::HTMLPlugInImageElement::allowedToLoadFrameURL):
2750
2751 2011-10-06  Yury Semikhatsky  <yurys@chromium.org>
2752
2753         Web Inspector: avoid assertion failure in ~InspectorDebuggerAgent in case of workers
2754         https://bugs.webkit.org/show_bug.cgi?id=69534
2755
2756         Make sure frontend is disconnected before WorkerInspectorController is destroyed.
2757
2758         Reviewed by Pavel Feldman.
2759
2760         * inspector/WorkerInspectorController.cpp:
2761         (WebCore::WorkerInspectorController::~WorkerInspectorController):
2762
2763 2011-10-05  Alexey Proskuryakov  <ap@apple.com>
2764
2765         https://bugs.webkit.org/show_bug.cgi?id=69492
2766         [Mac] Should be able to scroll embedded PDFs from keyboard
2767
2768         Reviewed by Darin Adler.
2769
2770         * WebCore.exp.in: Export ScrollableArea::scroll.
2771
2772         * html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::defaultEventHandler): Call base
2773         class default event handler, so that events on focused plug-in elements would fall through
2774         to EventHandler::defaultKeyboardEventHandler.
2775
2776         * plugins/PluginViewBase.h: (WebCore::PluginViewBase::scroll): Added a method that's called
2777         on a plug-in when WebCore asks it to scroll. Plug-in cannot really know what key events
2778         result in scroll actions.
2779
2780         * rendering/RenderEmbeddedObject.cpp:
2781         (WebCore::RenderEmbeddedObject::scroll):
2782         (WebCore::RenderEmbeddedObject::logicalScroll):
2783         * rendering/RenderEmbeddedObject.h:
2784         Ask plug-in to scroll when EventHandler::scrollOverflow() is called.
2785
2786 2011-10-06  Konstantin Scheglov  <scheglov@google.com>
2787
2788         REGRESSION (r95852?): Disappearing Border on bugs.webkit.org attachments <table>
2789         https://bugs.webkit.org/show_bug.cgi?id=69296
2790
2791         Reviewed by David Hyatt.
2792
2793         Test: fast/table/border-collapsing/cached-69296.html
2794
2795         Remember BorderValue in CollapsedBorderValue by value.
2796         See https://bugs.webkit.org/show_bug.cgi?id=69296#c7 for motivation.
2797
2798         * rendering/style/CollapsedBorderValue.h:
2799         (WebCore::CollapsedBorderValue::CollapsedBorderValue):
2800         (WebCore::CollapsedBorderValue::width):
2801         (WebCore::CollapsedBorderValue::style):
2802         (WebCore::CollapsedBorderValue::exists):
2803         (WebCore::CollapsedBorderValue::isTransparent):
2804         (WebCore::CollapsedBorderValue::operator==):
2805         * rendering/RenderTableCell.cpp:
2806         (WebCore::RenderTableCell::collapsedStartBorder):
2807         (WebCore::RenderTableCell::collapsedEndBorder):
2808         (WebCore::RenderTableCell::collapsedBeforeBorder):
2809         (WebCore::RenderTableCell::collapsedAfterBorder):
2810
2811 2011-10-06  Gavin Peters  <gavinp@chromium.org>
2812
2813         save resource zeroing stacks in ScriptElement for debugging
2814         https://bugs.webkit.org/show_bug.cgi?id=69453
2815
2816         The state machine tracking how m_cachedScript gets zeroed shows that sometimes we get
2817         two notifyFinished() events in a ScriptElement, which can crash chrome (see chrome bug
2818         75604).  This patch will save a stack in the ScriptElement when this happens, so that if
2819         we do later crash, we can see how we did the first zeroing.
2820
2821         See http://code.google.com/p/chromium/issues/detail?id=75604 for the chromium bug that
2822         this change will help track down.
2823
2824         Reviewed by Nate Chapin.
2825
2826         No new tests, this shouldn't affect output at all, and isn't particularly testable.
2827
2828         * dom/ScriptElement.cpp:
2829         (WebCore::ScriptElement::ScriptElement):
2830         (WebCore::ScriptElement::stopLoadRequest):
2831         (WebCore::ScriptElement::notifyFinished):
2832         * dom/ScriptElement.h:
2833
2834 2011-10-06  Rémi Duraffort  <remi.duraffort@st.com>
2835
2836         Fix compilation by adding some missing ENABLE(VIDEO|XSLT)
2837         https://bugs.webkit.org/show_bug.cgi?id=69522
2838
2839         Unreviewed build fix
2840
2841         * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
2842         * bindings/v8/custom/V8HTMLAudioElementConstructor.h:
2843         * bindings/v8/custom/V8XSLTProcessorCustom.cpp:
2844
2845 2011-10-06  Pavel Feldman  <pfeldman@google.com>
2846
2847         Web Inspector: add Styles and Metrics sidebars to the compilation.
2848         https://bugs.webkit.org/show_bug.cgi?id=69529
2849
2850         Reviewed by Yury Semikhatsky.
2851
2852         * inspector/compile-front-end.sh:
2853         * inspector/front-end/CSSCompletions.js:
2854         (WebInspector.CSSCompletions.requestCSSNameCompletions):
2855         * inspector/front-end/CSSKeywordCompletions.js:
2856         (WebInspector.CSSKeywordCompletions.forProperty):
2857         (WebInspector.CSSKeywordCompletions.isColorAwareProperty):
2858         * inspector/front-end/Checkbox.js:
2859         * inspector/front-end/ElementsPanel.js:
2860         * inspector/front-end/MetricsSidebarPane.js:
2861         (WebInspector.MetricsSidebarPane.prototype._updateMetrics):
2862         (WebInspector.MetricsSidebarPane.prototype.startEditing):
2863         (WebInspector.MetricsSidebarPane.prototype._handleKeyDown):
2864         * inspector/front-end/SourceCSSTokenizer.js:
2865         (WebInspector.SourceCSSTokenizer):
2866         * inspector/front-end/SourceCSSTokenizer.re2js:
2867         * inspector/front-end/StylesSidebarPane.js:
2868         (WebInspector.StylesSidebarPane.prototype.update):
2869         (WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
2870         (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
2871         (WebInspector.StylePropertiesSection.prototype.onpopulate):
2872         (WebInspector.StylePropertiesSection.prototype.startEditingSelector):
2873         (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
2874         (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
2875         (WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
2876         (WebInspector.BlankStylePropertiesSection.prototype.makeNormal):
2877         (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
2878         (WebInspector.StylePropertyTreeElement.prototype):
2879         * inspector/front-end/externs.js:
2880         (WebInspector.linkifyResourceAsNode):
2881         (Element.prototype.scrollIntoViewIfNeeded):
2882         (Element.prototype.selectionLeftOffset):
2883         * inspector/front-end/inspector.js:
2884         * inspector/front-end/utilities.js:
2885
2886 2011-10-06  Pavel Feldman  <pfeldman@google.com>
2887
2888         Web Inspector: extract DOMPresentation, make EventListenersSidebar compile
2889         https://bugs.webkit.org/show_bug.cgi?id=69527
2890
2891         Reviewed by Yury Semikhatsky.
2892
2893         * WebCore.gypi:
2894         * WebCore.vcproj/WebCore.vcproj:
2895         * inspector/compile-front-end.sh:
2896         * inspector/front-end/DOMAgent.js:
2897         (WebInspector.DOMNode.prototype.nodeNameInCorrectCase):
2898         (WebInspector.DOMNode.prototype.moveTo):
2899         (WebInspector.DOMNode.prototype.isXMLNode):
2900         * inspector/front-end/DOMBreakpointsSidebarPane.js:
2901         (WebInspector.DOMBreakpointsSidebarPane.prototype._setBreakpoint):
2902         * inspector/front-end/DOMPresentation.js: Added.
2903         (WebInspector.DOMPresentation.decorateNodeLabel):
2904         (WebInspector.DOMPresentation.linkifyNodeReference):
2905         (WebInspector.DOMPresentation.linkifyNodeById):
2906         * inspector/front-end/ElementsPanel.js:
2907         (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
2908         * inspector/front-end/ElementsTreeOutline.js:
2909         (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode):
2910         * inspector/front-end/EventListenersSidebarPane.js:
2911         * inspector/front-end/ObjectPropertiesSection.js:
2912         * inspector/front-end/PropertiesSection.js:
2913         * inspector/front-end/Section.js:
2914         * inspector/front-end/StylesSidebarPane.js:
2915         (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
2916         (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
2917         * inspector/front-end/WebKit.qrc:
2918         * inspector/front-end/inspector.html:
2919
2920 2011-10-06  Pavel Feldman  <pfeldman@google.com>
2921
2922         Web Inspector: add all Resource panel views to the compilation.
2923         https://bugs.webkit.org/show_bug.cgi?id=69526
2924
2925         Reviewed by Yury Semikhatsky.
2926
2927         * inspector/compile-front-end.sh:
2928         * inspector/front-end/CookieItemsView.js:
2929         (WebInspector.CookieItemsView.prototype._contextMenu):
2930         (WebInspector.Cookies.cookieMatchesResourceURL):
2931         * inspector/front-end/CookiesTable.js:
2932         (WebInspector.CookiesTable):
2933         (WebInspector.CookiesTable.prototype._onDeleteFromGrid):
2934         * inspector/front-end/DOMStorageItemsView.js:
2935         (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
2936         * inspector/front-end/DataGrid.js:
2937         (WebInspector.DataGrid.createSortableDataGrid.sortDataGrid.comparator):
2938         (WebInspector.DataGrid.createSortableDataGrid.sortDataGrid):
2939         (WebInspector.DataGrid.createSortableDataGrid):
2940         * inspector/front-end/DatabaseQueryView.js:
2941         (WebInspector.DatabaseQueryView.prototype._queryFinished):
2942         * inspector/front-end/DatabaseTableView.js:
2943         (WebInspector.DatabaseTableView.prototype._queryFinished):
2944         * inspector/front-end/ResourcesPanel.js:
2945         (WebInspector.ResourcesPanel.prototype.reset):
2946         (WebInspector.ResourcesPanel.prototype.showDatabase):
2947         * inspector/front-end/TextPrompt.js:
2948
2949 2011-10-06  Pavel Feldman  <pfeldman@google.com>
2950
2951         Web Inspector: add all Resource panel views to the compilation.
2952         https://bugs.webkit.org/show_bug.cgi?id=69526
2953
2954         Reviewed by Yury Semikhatsky.
2955
2956         * inspector/compile-front-end.sh:
2957         * inspector/front-end/CookieItemsView.js:
2958         (WebInspector.CookieItemsView.prototype._contextMenu):
2959         (WebInspector.Cookies.cookieMatchesResourceURL):
2960         * inspector/front-end/CookiesTable.js:
2961         (WebInspector.CookiesTable):
2962         (WebInspector.CookiesTable.prototype._onDeleteFromGrid):
2963         * inspector/front-end/DOMStorageItemsView.js:
2964         (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
2965         * inspector/front-end/DataGrid.js:
2966         (WebInspector.DataGrid.createSortableDataGrid.sortDataGrid.comparator):
2967         (WebInspector.DataGrid.createSortableDataGrid.sortDataGrid):
2968         (WebInspector.DataGrid.createSortableDataGrid):
2969         * inspector/front-end/DatabaseQueryView.js:
2970         (WebInspector.DatabaseQueryView.prototype._queryFinished):
2971         * inspector/front-end/DatabaseTableView.js:
2972         (WebInspector.DatabaseTableView.prototype._queryFinished):
2973         * inspector/front-end/ResourcesPanel.js:
2974         (WebInspector.ResourcesPanel.prototype.reset):
2975         (WebInspector.ResourcesPanel.prototype.showDatabase):
2976         * inspector/front-end/TextPrompt.js:
2977
2978 2011-10-06  Sheriff Bot  <webkit.review.bot@gmail.com>
2979
2980         Unreviewed, rolling out r96791.
2981         http://trac.webkit.org/changeset/96791
2982         https://bugs.webkit.org/show_bug.cgi?id=69528
2983
2984         webkit_unit_tests broken on Mac and Win (Requested by
2985         hwennborg on #webkit).
2986
2987         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
2988
2989 2011-10-05  Mikhail Naganov  <mnaganov@chromium.org>
2990
2991         Web Inspector: [Chromium] Heap Snapshot colors legend help popup is not shown.
2992         https://bugs.webkit.org/show_bug.cgi?id=69482
2993
2994         Reviewed by Yury Semikhatsky.
2995
2996         * inspector/front-end/DetailedHeapshotView.js:
2997         (WebInspector.DetailedHeapshotView.prototype._helpClicked):
2998
2999 2011-10-05  Pavel Feldman  <pfeldman@google.com>
3000
3001         Web Inspector: add 10 more front-end classes to the compilation process.
3002         https://bugs.webkit.org/show_bug.cgi?id=69445
3003
3004         Reviewed by Yury Semikhatsky.
3005
3006         * inspector/compile-front-end.sh:
3007         * inspector/front-end/HAREntry.js:
3008         * inspector/front-end/HandlerRegistry.js:
3009         * inspector/front-end/IFrameView.js:
3010         * inspector/front-end/JavaScriptSourceFrame.js:
3011         * inspector/front-end/PanelEnablerView.js:
3012         (WebInspector.PanelEnablerView):
3013         * inspector/front-end/PartialQuickSort.js:
3014         * inspector/front-end/PropertiesSidebarPane.js:
3015         (WebInspector.PropertiesSidebarPane.prototype.update.fillSection):
3016         (WebInspector.PropertiesSidebarPane.prototype.update):
3017         * inspector/front-end/ShowMoreDataGridNode.js:
3018         * inspector/front-end/SidebarTreeElement.js:
3019         * inspector/front-end/TimelineAgent.js:
3020         * inspector/front-end/WelcomeView.js:
3021         * inspector/front-end/externs.js:
3022         (WebInspector.addMainEventListeners):
3023
3024 2011-10-05  Pavel Feldman  <pfeldman@google.com>
3025
3026         Web Inspector: make ElementsTreeOutline compile
3027         https://bugs.webkit.org/show_bug.cgi?id=69439
3028
3029         Reviewed by Yury Semikhatsky.
3030
3031         * inspector/compile-front-end.sh:
3032         * inspector/front-end/DOMAgent.js:
3033         * inspector/front-end/DOMSyntaxHighlighter.js:
3034         * inspector/front-end/ElementsPanel.js:
3035         (WebInspector.ElementsPanel.get this):
3036         (WebInspector.ElementsPanel):
3037         (WebInspector.ElementsPanel.prototype._populateContextMenu):
3038         (WebInspector.ElementsPanel.prototype._inspectElementRequested):
3039         * inspector/front-end/ElementsTreeOutline.js:
3040         (WebInspector.ElementsTreeOutline):
3041         (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement):
3042         (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
3043         (WebInspector.ElementsTreeOutline.prototype._updateModifiedNodes):
3044         (WebInspector.ElementsTreeOutline.prototype._populateContextMenu):
3045         (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
3046         (WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
3047         (WebInspector.ElementsTreeElement.prototype._startEditingTextNode):
3048         (WebInspector.ElementsTreeElement.prototype._startEditingTagName):
3049         (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
3050         (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.changeTagNameCallback):
3051         (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
3052         ():
3053         * inspector/front-end/externs.js:
3054         (WebInspector.highlightDOMNode):
3055         (WebInspector.resourceURLForRelatedNode):
3056
3057 2011-10-06  Pavel Feldman  <pfeldman@google.com>
3058
3059         Web Inspector: Inspector fails to start if there was at least one watch expression.
3060         https://bugs.webkit.org/show_bug.cgi?id=69516
3061
3062         Reviewed by Yury Semikhatsky.
3063
3064         * inspector/front-end/ConsoleView.js:
3065         * inspector/front-end/WatchExpressionsSidebarPane.js:
3066         (WebInspector.WatchExpressionsSidebarPane):
3067
3068 2011-10-06  Dominic Cooney   <dominicc@chromium.org>
3069
3070         Don't make virtual calls in Node::parentNode.
3071         https://bugs.webkit.org/show_bug.cgi?id=69266
3072
3073         Reviewed by Antti Koivisto.
3074
3075         ShadowRoot and SVGShadowRoot remain semantically separate (eg
3076         isShadowRoot/isSVGShadowRoot) but share a flag
3077         (IsShadowRootOrSVGShadowRootFlag, hitherto IsShadowRootFlag just
3078         for ShadowRoot). In combination with IsSVGFlag ShadowRoot (false)
3079         can be distinguished from SVGShadowRoot (true). This lets us make
3080         isSVGShadowRoot non-virtual.
3081
3082         No change in behavior => No new tests.
3083
3084         * dom/Node.cpp:
3085         (WebCore::Node::shadowHost):
3086         * dom/Node.h:
3087         (WebCore::Node::isSVGShadowRoot):
3088         (WebCore::Node::isShadowRoot):
3089         (WebCore::Node::parentNode):
3090         (WebCore::Node::parentNodeGuaranteedHostFree):
3091         * rendering/svg/SVGShadowTreeElements.cpp:
3092         (WebCore::SVGShadowTreeContainerElement::SVGShadowTreeContainerElement):
3093         (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement):
3094         * rendering/svg/SVGShadowTreeElements.h:
3095         * svg/SVGElement.cpp:
3096         (WebCore::SVGElement::SVGElement):
3097         * svg/SVGElement.h:
3098         * svg/SVGGElement.cpp:
3099         (WebCore::SVGGElement::SVGGElement):
3100         * svg/SVGGElement.h:
3101         * svg/SVGStyledElement.cpp:
3102         (WebCore::SVGStyledElement::SVGStyledElement):
3103         * svg/SVGStyledElement.h:
3104         * svg/SVGStyledLocatableElement.cpp:
3105         (WebCore::SVGStyledLocatableElement::SVGStyledLocatableElement):
3106         * svg/SVGStyledLocatableElement.h:
3107         * svg/SVGStyledTransformableElement.cpp:
3108         (WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement):
3109         * svg/SVGStyledTransformableElement.h:
3110
3111 2011-10-06  John Knottenbelt  <jknotten@chromium.org>
3112
3113         Take pageScaleFactor into account for MouseRelatedEvents.
3114         https://bugs.webkit.org/show_bug.cgi?id=67592
3115
3116         Reviewed by Tony Gentilcore.
3117
3118         Tests: fast/events/page-scaled-mouse-click-iframe.html
3119                fast/events/page-scaled-mouse-click.html
3120
3121         * dom/MouseRelatedEvent.cpp:
3122         (WebCore::contentsScrollOffset):
3123         (WebCore::MouseRelatedEvent::MouseRelatedEvent):
3124         (WebCore::frameScaleFactor):
3125         (WebCore::MouseRelatedEvent::computePageLocation):
3126         (WebCore::MouseRelatedEvent::computeRelativePosition):
3127
3128 2011-10-03  Hans Wennborg  <hans@chromium.org>
3129
3130         IndexedDB: Remove SQLite-LevelDB migration code
3131         https://bugs.webkit.org/show_bug.cgi?id=69264
3132
3133         Reviewed by Tony Chang.
3134
3135         Remove migration functionality.
3136
3137         Just removing code, so no new tests.
3138
3139         * storage/IDBFactoryBackendImpl.cpp:
3140         (WebCore::IDBFactoryBackendImpl::open):
3141         * storage/IDBFactoryBackendImpl.h:
3142
3143 2011-10-06  James Robinson  <jamesr@chromium.org>
3144
3145         [chromium] Remove USE(THREADED_COMPOSITING) from the tree
3146         https://bugs.webkit.org/show_bug.cgi?id=69489
3147
3148         Reviewed by Darin Fisher.
3149
3150         This macro isn't needed any more since the logic it guarded is guarded by a runtime switch.
3151
3152         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
3153
3154 2011-10-05  Kentaro Hara  <haraken@chromium.org>
3155
3156         Refactor IDL attributes about constructor
3157         https://bugs.webkit.org/show_bug.cgi?id=69074
3158
3159         Reviewed by Adam Barth.
3160
3161         Currently, IDL attributes about constructor are confusing:
3162
3163         - [CustomConstructFunction] means that there is a custom constructor for JSC.
3164         - [V8CustomConstructor] means that there is a custom constructor for V8.
3165         - [CustomConstructor] exists in CodeGenerator*.pm but is not used in any IDL files.
3166         - For almost all IDL files, [CustomConstructFunction] and [V8CustomConstructor] are used at the same time.
3167         - ObjC, CPP and GObject bindings do not support custom constructors.
3168
3169         This patch makes the following changes:
3170
3171         - Rename [CustomConstructFunction] to [JSCustomConstructor].
3172         - [JSCustomConstructor] means that there is a custom constructor for JSC.
3173         - [V8CustomConstructor] means that there is a custom constructor for V8.
3174         - [CustomConstructor] means that there is a custom constructor for both JSC and V8.
3175
3176         No new tests. No change in behavior. Confirm that build succeeds.
3177
3178         * bindings/scripts/CodeGeneratorJS.pm: Removed [CustomConstructFunction] and added [JSCustomConstructor]
3179         (GenerateHeader):
3180         (GenerateAttributesHashTable):
3181         (GenerateImplementation):
3182         (GenerateConstructorDefinition):
3183         * css/WebKitCSSMatrix.idl: Renamed [CustomConstructFunction] to [JSCustomConstructor]. If both [JSCustomConstructor] and [V8CustomConstructor] are specified, then we replaced them with [CustomConstructor].
3184         * dom/CustomEvent.idl: Ditto.
3185         * dom/ErrorEvent.idl: Ditto.
3186         * dom/Event.idl: Ditto.
3187         * dom/HashChangeEvent.idl: Ditto.
3188         * dom/MessageChannel.idl: Ditto.
3189         * dom/MessageEvent.idl: Ditto.
3190         * dom/PageTransitionEvent.idl: Ditto.
3191         * dom/PopStateEvent.idl: Ditto.
3192         * dom/ProgressEvent.idl: Ditto.
3193         * dom/WebKitAnimationEvent.idl: Ditto.
3194         * html/DOMFormData.idl: Ditto.
3195         * html/canvas/ArrayBuffer.idl: Ditto.
3196         * html/canvas/DataView.idl: Ditto.
3197         * html/canvas/Float32Array.idl: Ditto.
3198         * html/canvas/Float64Array.idl: Ditto.
3199         * html/canvas/Int16Array.idl: Ditto.
3200         * html/canvas/Int32Array.idl: Ditto.
3201         * html/canvas/Int8Array.idl: Ditto.
3202         * html/canvas/Uint16Array.idl: Ditto.
3203         * html/canvas/Uint32Array.idl: Ditto.
3204         * html/canvas/Uint8Array.idl: Ditto.
3205         * p2p/PeerConnection.idl: Ditto.
3206         * page/EventSource.idl: Ditto.
3207         * page/WebKitPoint.idl: Ditto.
3208         * webaudio/AudioContext.idl: Ditto.
3209         * websockets/CloseEvent.idl: Ditto.
3210         * websockets/WebSocket.idl: Ditto.
3211         * workers/SharedWorker.idl: Ditto.
3212         * workers/Worker.idl: Ditto.
3213         * xml/XMLHttpRequest.idl: Ditto.
3214         * xml/XSLTProcessor.idl: Ditto.
3215
3216 2011-10-03  Andy Estes  <aestes@apple.com>
3217
3218         Add the option to suppress rendering until the document's load event fires.
3219         https://bugs.webkit.org/show_bug.cgi?id=69298
3220
3221         Reviewed by Simon Fraser.
3222
3223         Add a WebCore setting that suppresses painting and compositing layer
3224         updates until the document's load event fires. This masks the effects
3225         of incremental rendering (for clients that opt in) by ensuring that all
3226         sub-resources have loaded and a full layout has taken place before
3227         painting the document for the first time.
3228
3229         No tests currently possible. Testing this would require the ability for
3230         DRT to dump state while resources are loading, which it doesn't
3231         currently do.
3232
3233         * dom/Document.cpp:
3234         (WebCore::Document::implicitClose): If rendering was previously
3235         suppressed, force a repaint and compositing layer update.
3236         (WebCore::Document::visualUpdatesAllowed): Add a helper method to
3237         determine if the document is in a state where rendering is allowed.
3238         * dom/Document.h:
3239         * page/Settings.cpp:
3240         (WebCore::Settings::Settings):
3241         * page/Settings.h:
3242         (WebCore::Settings::setSuppressIncrementalRendering):
3243         (WebCore::Settings::suppressIncrementalRendering):
3244         * rendering/RenderLayer.cpp:
3245         (WebCore::shouldSuppressPaintingLayer): Encapsulate the FOUC and
3246         painting suppression checks into a single helper function for
3247         readability's sake.
3248         (WebCore::RenderLayer::paintLayer):
3249         * rendering/RenderLayerCompositor.cpp:
3250         (WebCore::RenderLayerCompositor::updateCompositingLayers): If we should
3251         suppress compositing layer updates and the load event has yet to fire,
3252         return early.
3253
3254 2011-10-05  Yuta Kitamura  <yutak@chromium.org>
3255
3256         WebSocket: Add extensions attribute
3257         https://bugs.webkit.org/show_bug.cgi?id=69408
3258
3259         Reviewed by Kent Tamura.
3260
3261         Add WebSocket's "extensions" attribute as specified in the WebSocket API
3262         <http://dev.w3.org/html5/websockets/#the-websocket-interface>.
3263
3264         WebSocket protocol extension is not implemented at all, thus this attribute
3265         always returns an empty string.
3266
3267         Test: http/tests/websocket/tests/hybi/extensions.html
3268               http/tests/websocket/tests/hixie76/undefined-attributes.html (updated)
3269
3270         * websockets/WebSocket.cpp:
3271         (WebCore::WebSocket::extensions):
3272         If the hixie-76 protocol is chosen, we need to return "undefined" in order to
3273         keep behavior of the ports which have not used the newer hybi protocol yet.
3274         * websockets/WebSocket.h:
3275         * websockets/WebSocket.idl:
3276
3277 2011-10-05  Dominic Cooney  <dominicc@chromium.org>
3278
3279         IsShadowRootFlag should not depend on whether a ShadowRoot is attached to a host.
3280         https://bugs.webkit.org/show_bug.cgi?id=69406
3281
3282         Reviewed by Hajime Morita.
3283
3284         No change in behavior => No new tests.
3285
3286         * dom/Node.cpp:
3287         (WebCore::Node::setShadowHost): Don't twiddle the flag.
3288         * dom/Node.h:
3289         * dom/ShadowRoot.cpp:
3290         (WebCore::ShadowRoot::ShadowRoot): Set the IsShadowRootFlag on creation.
3291         * dom/TreeScope.cpp:
3292         (WebCore::TreeScope::TreeScope): Let ShadowRoot set creation flags.
3293         * dom/TreeScope.h:
3294
3295 2011-10-05  Chris Rogers  <crogers@google.com>
3296
3297         Define a log2f() function for Windows in wtf/MathExtras.h
3298         https://bugs.webkit.org/show_bug.cgi?id=69491
3299
3300         Reviewed by Darin Adler.
3301
3302         No new tests. This change is tested in existing layout tests.
3303
3304         * webaudio/AudioParamTimeline.cpp:
3305         (WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
3306
3307 2011-10-05  Erik Arvidsson  <arv@chromium.org>
3308
3309         window.location.href and others needlessly decodes URI-encoded characters
3310         https://bugs.webkit.org/show_bug.cgi?id=30225
3311
3312         Reviewed by Darin Adler.
3313
3314         Don't decode KURL::path() and stop using KURL::deprecatedString() in Location methods.
3315
3316         This slightly changes how we parse data and javascript URLs (non hierarchical URLs) to
3317         not encode so aggressively.
3318
3319         * fileapi/DOMFileSystemBase.cpp:
3320         (WebCore::DOMFileSystemBase::crackFileSystemURL): Manually decode path()
3321         * loader/FrameLoader.cpp:
3322         (WebCore::FrameLoader::defaultObjectContentType): Manually decode path()
3323         * page/Location.cpp:
3324         (WebCore::Location::href): Use string() instead of deprecatedString()
3325         * page/Location.h:
3326         (WebCore::Location::toString): Inline call to href()
3327         * platform/KURL.cpp:
3328         (WebCore::KURL::path): Don't decode.
3329         (WebCore::escapeAndAppendNonHierarchicalPart): Rename escapeAndAppendFragment to escapeAndAppendNonHierarchicalPart
3330                                                        since this is now used for more than just fragments.
3331         (WebCore::KURL::parse): Don't decode
3332         * platform/KURLGoogle.cpp:
3333         (WebCore::KURL::path): Remove out of date comment
3334         * platform/qt/KURLQt.cpp:
3335         (WebCore::KURL::fileSystemPath): Manually decode path()
3336         * platform/win/ClipboardWin.cpp:
3337         (WebCore::createGlobalHDropContent): Manually decode path()
3338         * workers/WorkerLocation.cpp:
3339         (WebCore::WorkerLocation::href): Use string() instead of deprecatedString()
3340         * workers/WorkerLocation.h:
3341         (WebCore::WorkerLocation::toString): Inline call to href()
3342
3343 2011-10-05  Darin Adler  <darin@apple.com>
3344
3345         [Mac] Use four more named cursors if present
3346         https://bugs.webkit.org/show_bug.cgi?id=69488
3347
3348         Reviewed by Dan Bernstein.
3349
3350         * platform/mac/CursorMac.mm:
3351         (WebCore::Cursor::ensurePlatformCursor): Use the names "Help", "Cell",
3352         "ZoomIn", and "ZoomOut" to get those cursors. Structure the code so it
3353         falls back if the cursors are not present.
3354
3355 2011-10-05  Tony Chang  <tony@chromium.org>
3356
3357         force margin:auto to 0 in flex items
3358         https://bugs.webkit.org/show_bug.cgi?id=69475
3359
3360         Reviewed by Ojan Vafai.
3361
3362         The spec used to say the margin had a value of flex(1 0 0), but changed to just be 0.
3363
3364         * rendering/RenderFlexibleBox.cpp:
3365         (WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
3366         (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
3367
3368 2011-10-05  Dean Jackson  <dino@apple.com>
3369
3370         Computed style for filter property
3371         https://bugs.webkit.org/show_bug.cgi?id=68477
3372
3373         Reviewed by Simon Fraser.
3374
3375         Reports the computed style for the new -webkit-filter
3376         property value.
3377
3378         Test: css3/filters/filter-property-computed-style.html
3379
3380         * css/CSSComputedStyleDeclaration.cpp:
3381         (WebCore::computedFilter):
3382         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3383
3384 2011-10-05  Jer Noble  <jer.noble@apple.com>
3385
3386         Enable WEB_AUDIO by default in the WebKit/mac port.
3387         https://bugs.webkit.org/show_bug.cgi?id=68587
3388
3389         Reviewed by Simon Fraser.
3390
3391         No new tests; existing webaudio/ layout tests cover this.
3392
3393         * Configurations/FeatureDefines.xcconfig:
3394         * WebCore.xcodeproj/project.pbxproj: Add a build step which copies audio resources to
3395             the WebCore.framework bundle.
3396
3397 2011-10-03  Ojan Vafai  <ojan@chromium.org>
3398
3399         [flexbox] take marginBeforeForChild into account when positioning children
3400         https://bugs.webkit.org/show_bug.cgi?id=69313
3401
3402         Reviewed by Tony Chang.
3403
3404         * rendering/RenderFlexibleBox.cpp:
3405         (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
3406
3407 2011-10-05  Vangelis Kokkevis  <vangelis@chromium.org>
3408
3409         Switching threaded compositor from a compile time option to a
3410         run time one.
3411         https://bugs.webkit.org/show_bug.cgi?id=69391
3412
3413         Reviewed by Darin Fisher.
3414
3415         Mostly converted #if USE(THREADED_COMPOSITING) to a regular if statements.
3416         In addition, CCLayerTreeHost::scheduleComposite() is removed as it wasn't being
3417         called from anywhere, 
3418
3419         No new tests as it doesn't add new functionality.
3420
3421         * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
3422         (WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
3423         (WebCore::CCLayerTreeHost::setNeedsRedraw):
3424         (WebCore::CCLayerTreeHost::composite):
3425         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
3426         * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
3427         (WebCore::CCSingleThreadProxy::setNeedsCommitThenRedraw):
3428         (WebCore::CCSingleThreadProxy::compositeImmediately):
3429         * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
3430
3431 2011-10-05  Dean Jackson  <dino@apple.com>
3432
3433         Parse '-webkit-filter' property syntax
3434         https://bugs.webkit.org/show_bug.cgi?id=68473
3435
3436         Reviewed by Nikolas Zimmermann.
3437
3438         Parse the new -webkit-filter property, looking for shorthand
3439         functions then testing number, type and value of parameters.
3440
3441         Note that support for drop-shadow() was omitted from this
3442         patch because parsing CSS shadow syntax was going to require some
3443         refactoring of the box and text shadow code. The followup
3444         bug is https://bugs.webkit.org/show_bug.cgi?id=69108.
3445
3446         Also, computed style will return null for filters at the moment.
3447         That's https://bugs.webkit.org/show_bug.cgi?id=68477.
3448
3449         Tests: css3/filters/filter-property-parsing-invalid.html
3450                css3/filters/filter-property-parsing.html
3451
3452         * CMakeLists.txt:
3453         * CodeGenerators.pri:
3454         * DerivedSources.cpp:
3455         * DerivedSources.make:
3456         * GNUmakefile.list.am:
3457         * WebCore.gypi:
3458         * WebCore.pro:
3459         * WebCore.vcproj/WebCore.vcproj:
3460         * WebCore.xcodeproj/project.pbxproj:
3461             Build files updated for new WebKitCSSFilterValue classes.
3462         * bindings/js/JSCSSValueCustom.cpp:
3463         (WebCore::toJS):
3464         * bindings/objc/DOMCSS.mm:
3465             Test if value is WebKitCSSFilterValue.
3466         * css/CSSParser.cpp:
3467         (WebCore::filterInfoForName):
3468         (WebCore::CSSParser::isValidFilterArgument):
3469         (WebCore::CSSParser::parseFilter):
3470         * css/CSSParser.h:
3471         * css/CSSStyleSelector.cpp:
3472         (WebCore::CSSStyleSelector::applyProperty):
3473         (WebCore::filterOperationForType):
3474         (WebCore::CSSStyleSelector::createFilterOperations):
3475         * css/CSSStyleSelector.h:
3476             Handle the new shorthand functions in -webkit-filter.
3477         * css/CSSValue.h:
3478         (WebCore::CSSValue::isWebKitCSSFilterValue):
3479             Add virtual function that returns false here.
3480         * css/WebKitCSSFilterValue.cpp: Added.
3481         (WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):
3482         (WebCore::WebKitCSSFilterValue::~WebKitCSSFilterValue):
3483         (WebCore::WebKitCSSFilterValue::cssText):
3484         * css/WebKitCSSFilterValue.h: Added.
3485         (WebCore::WebKitCSSFilterValue::create):