df7c5e42dd2c9e2b34ccd415dd325c7de63b3dad
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-07-08  Benjamin Poulain  <benjamin@webkit.org>
2
3         [Qt] Enable HTTP Pipelining by default
4         https://bugs.webkit.org/show_bug.cgi?id=64169
5
6         Reviewed by Andreas Kling.
7
8         QNetworkAccessManager disables HTTP pipelining by default. We enable it by
9         setting an attribute on the request.
10
11         * platform/network/qt/ResourceRequestQt.cpp:
12         (WebCore::ResourceRequest::toNetworkRequest):
13
14 2011-07-08  Alexander Pavlov  <apavlov@chromium.org>
15
16         Web Inspector: CSS inspector gets confused about specificity of !important properties
17         https://bugs.webkit.org/show_bug.cgi?id=64074
18
19         Reviewed by Yury Semikhatsky.
20
21         * inspector/front-end/StylesSidebarPane.js:
22         (WebInspector.StylesSidebarPane.prototype._markUsedProperties):
23
24 2011-07-08  Alexander Pavlov  <apavlov@chromium.org>
25
26         [Chromium] Unreviewed, clang build fix.
27
28         * inspector/InspectorStyleTextEditor.h:
29
30 2011-07-08  Pavel Feldman  <pfeldman@google.com>
31
32         Web Inspector: add support for drag'n'drop of non-elements (comments, text, etc.)
33         https://bugs.webkit.org/show_bug.cgi?id=64163
34
35         Reviewed by Yury Semikhatsky.
36
37         * inspector/Inspector.json:
38         * inspector/InspectorDOMAgent.cpp:
39         (WebCore::InspectorDOMAgent::moveTo):
40         * inspector/front-end/ElementsTreeOutline.js:
41         (WebInspector.ElementsTreeOutline.prototype._isValidDragSourceOrTarget):
42
43 2011-07-08  Andrey Kosyakov  <caseq@chromium.org>
44
45         Web Inspector: secure access to extensions API
46         https://bugs.webkit.org/show_bug.cgi?id=64080
47
48         Reviewed by Pavel Feldman.
49
50         * inspector/front-end/ExtensionAPI.js:
51         (WebInspector.injectedExtensionAPI.Panels.prototype.create):
52         (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
53         * inspector/front-end/ExtensionPanel.js:
54         (WebInspector.ExtensionPanel):
55         * inspector/front-end/ExtensionServer.js:
56         (WebInspector.ExtensionServer):
57         (WebInspector.ExtensionServer.prototype._onCreatePanel):
58         (WebInspector.ExtensionServer.prototype._onSetSidebarPage):
59         (WebInspector.ExtensionServer.prototype._addExtensions):
60         (WebInspector.ExtensionServer.prototype._onWindowMessage):
61         (WebInspector.ExtensionServer.prototype._registerSubscriptionHandler):
62         (WebInspector.ExtensionServer.prototype._expandResourcePath):
63         (WebInspector.ExtensionServer.prototype._normalizePath):
64
65 2011-07-08  Adam Barth  <abarth@webkit.org>
66
67         Unreviewed, rolling out r90615.
68         http://trac.webkit.org/changeset/90615
69         https://bugs.webkit.org/show_bug.cgi?id=64158
70
71         broke inspector/extensions/extensions.html (Requested by caseq
72         on #webkit).
73
74         * inspector/front-end/ExtensionAPI.js:
75         (WebInspector.injectedExtensionAPI.Panels.prototype.create):
76         (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
77         (WebInspector.injectedExtensionAPI.expandURL):
78         * inspector/front-end/ExtensionPanel.js:
79         (WebInspector.ExtensionPanel):
80         * inspector/front-end/ExtensionServer.js:
81         (WebInspector.ExtensionServer):
82         (WebInspector.ExtensionServer.prototype._onCreatePanel):
83         (WebInspector.ExtensionServer.prototype._onSetSidebarPage):
84         (WebInspector.ExtensionServer.prototype._addExtensions):
85         (WebInspector.ExtensionServer.prototype._onWindowMessage):
86         (WebInspector.ExtensionServer.prototype._registerSubscriptionHandler):
87
88 2011-07-07  Alexander Pavlov  <apavlov@chromium.org>
89
90         Web Inspector: Adding CSS properties results in messy style rules
91         https://bugs.webkit.org/show_bug.cgi?id=63622
92
93         Reviewed by Pavel Feldman.
94
95         Test: inspector/styles/styles-formatting.html
96
97         * CMakeLists.txt:
98         * GNUmakefile.list.am:
99         * WebCore.gypi:
100         * WebCore.pro:
101         * WebCore.vcproj/WebCore.vcproj:
102         * WebCore.xcodeproj/project.pbxproj:
103         * css/CSSPropertySourceData.cpp:
104         (WebCore::SourceRange::length):
105         * css/CSSPropertySourceData.h:
106         * inspector/InspectorStyleSheet.cpp:
107         (WebCore::InspectorStyle::InspectorStyle):
108         (WebCore::InspectorStyle::setPropertyText):
109         (WebCore::InspectorStyle::toggleProperty):
110         (WebCore::InspectorStyle::applyStyleText):
111         (WebCore::InspectorStyle::newLineAndWhitespaceDelimiters):
112         * inspector/InspectorStyleSheet.h:
113         * inspector/InspectorStyleTextEditor.cpp: Added.
114         (WebCore::InspectorStyleTextEditor::InspectorStyleTextEditor):
115         (WebCore::InspectorStyleTextEditor::insertProperty):
116         (WebCore::InspectorStyleTextEditor::replaceProperty):
117         (WebCore::InspectorStyleTextEditor::removeProperty):
118         (WebCore::InspectorStyleTextEditor::enableProperty):
119         (WebCore::InspectorStyleTextEditor::disableProperty):
120         (WebCore::InspectorStyleTextEditor::disabledIndexByOrdinal):
121         (WebCore::InspectorStyleTextEditor::shiftDisabledProperties):
122         (WebCore::InspectorStyleTextEditor::internalReplaceProperty):
123         * inspector/InspectorStyleTextEditor.h: Added.
124         (WebCore::InspectorStyleTextEditor::styleText):
125
126 2011-07-08  Alexander Pavlov  <apavlov@chromium.org>
127
128         Web Inspector: Quotes are rendered as &quot; in the DOM tree
129         https://bugs.webkit.org/show_bug.cgi?id=64154
130
131         Reviewed by Yury Semikhatsky.
132
133         Since we currently rely on setting textContent rather than innerHTML for the DOM tree elements,
134         escapeHTML() calls unnecessarily HTML-escape certain characters in the DOM tree contents.
135
136         * inspector/front-end/ElementsTreeOutline.js:
137         (WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):
138         ():
139
140 2011-07-08  Vsevolod Vlasov  <vsevik@chromium.org>
141
142         Web Inspector: Remove unused code from InspectorAgent.h.
143         https://bugs.webkit.org/show_bug.cgi?id=64120
144
145         Reviewed by Joseph Pecoraro.
146
147         * inspector/InspectorAgent.h:
148
149 2011-07-08  Andrey Kosyakov  <caseq@chromium.org>
150
151         Web Inspector: secure access to extensions API
152         https://bugs.webkit.org/show_bug.cgi?id=64080
153
154         Reviewed by Pavel Feldman.
155
156         * inspector/front-end/ExtensionAPI.js:
157         (WebInspector.injectedExtensionAPI.Panels.prototype.create):
158         (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
159         * inspector/front-end/ExtensionPanel.js:
160         (WebInspector.ExtensionPanel):
161         * inspector/front-end/ExtensionServer.js:
162         (WebInspector.ExtensionServer):
163         (WebInspector.ExtensionServer.prototype._onCreatePanel):
164         (WebInspector.ExtensionServer.prototype._onSetSidebarPage):
165         (WebInspector.ExtensionServer.prototype._addExtensions):
166         (WebInspector.ExtensionServer.prototype._onWindowMessage):
167         (WebInspector.ExtensionServer.prototype._registerSubscriptionHandler):
168         (WebInspector.ExtensionServer.prototype._expandResourcePath):
169         (WebInspector.ExtensionServer.prototype._normalizePath):
170
171 2011-07-08  Yury Semikhatsky  <yurys@chromium.org>
172
173         Web Inspector: typing undefined = 1 in console crashes browser
174         https://bugs.webkit.org/show_bug.cgi?id=64155
175
176         Do not access undefined value directly when producing JSON objects as undefined
177         may be overriden by the inspected page.
178
179         Reviewed by Pavel Feldman.
180
181         Test: inspector/console/console-eval-undefined-override.html
182
183         * inspector/InjectedScriptSource.js:
184         (.):
185         ():
186
187 2011-07-07  Emil A Eklund  <eae@chromium.org>
188
189         Switch HitTestResult to to new layout types
190         https://bugs.webkit.org/show_bug.cgi?id=64131
191
192         Reviewed by Eric Seidel.
193
194         No new tests, no functionality changes.
195
196         * page/MouseEventWithHitTestResults.cpp:
197         (WebCore::MouseEventWithHitTestResults::localPoint):
198         * page/MouseEventWithHitTestResults.h:
199         * rendering/HitTestResult.cpp:
200         (WebCore::HitTestResult::HitTestResult):
201         (WebCore::HitTestResult::addNodeToRectBasedTestResult):
202         (WebCore::HitTestResult::rectForPoint):
203         * rendering/HitTestResult.h:
204         (WebCore::HitTestResult::point):
205         (WebCore::HitTestResult::localPoint):
206         (WebCore::HitTestResult::setPoint):
207         (WebCore::HitTestResult::setLocalPoint):
208         (WebCore::HitTestResult::rectForPoint):
209
210 2011-07-07  Levi Weintraub  <leviw@chromium.org>
211
212         Switch remaining paint functions to new layout types
213         https://bugs.webkit.org/show_bug.cgi?id=64116
214
215         Reviewed by Eric Seidel.
216
217         Switching all functions with IntPoint paintOffsets to the new Layout types.
218
219         No new tests, no functionality changes.
220
221         * rendering/EllipsisBox.cpp:
222         (WebCore::EllipsisBox::paint):
223         (WebCore::EllipsisBox::paintSelection):
224         * rendering/EllipsisBox.h:
225         * rendering/InlineBox.cpp:
226         (WebCore::InlineBox::paint):
227         * rendering/InlineBox.h:
228         * rendering/InlineFlowBox.cpp:
229         (WebCore::InlineFlowBox::paint):
230         * rendering/InlineFlowBox.h:
231         * rendering/InlineTextBox.cpp:
232         (WebCore::InlineTextBox::paint):
233         (WebCore::InlineTextBox::paintCustomHighlight):
234         * rendering/InlineTextBox.h:
235         * rendering/LayoutTypes.h:
236         * rendering/RenderBlock.cpp:
237         (WebCore::RenderBlock::paintColumnRules):
238         (WebCore::RenderBlock::paintColumnContents):
239         (WebCore::RenderBlock::paintContents):
240         (WebCore::RenderBlock::paintChildren):
241         (WebCore::RenderBlock::paintCaret):
242         (WebCore::RenderBlock::paintObject):
243         (WebCore::RenderBlock::paintFloats):
244         (WebCore::RenderBlock::paintEllipsisBoxes):
245         (WebCore::RenderBlock::paintContinuationOutlines):
246         (WebCore::RenderBlock::paintSelection):
247         * rendering/RenderBlock.h:
248         * rendering/RenderBox.cpp:
249         (WebCore::RenderBox::paintCustomHighlight):
250         * rendering/RenderBox.h:
251         * rendering/RenderInline.cpp:
252         (WebCore::RenderInline::paintOutline):
253         (WebCore::RenderInline::paintOutlineForLine):
254         * rendering/RenderInline.h:
255         * rendering/RenderLayer.cpp:
256         (WebCore::RenderLayer::paintOverflowControls):
257         (WebCore::RenderLayer::paintScrollCorner):
258         (WebCore::RenderLayer::paintResizer):
259         * rendering/RenderLayer.h:
260         * rendering/RenderLineBoxList.cpp:
261         (WebCore::RenderLineBoxList::paint):
262         * rendering/RenderListBox.cpp:
263         (WebCore::RenderListBox::paintScrollbar):
264         (WebCore::RenderListBox::paintItemForeground):
265         (WebCore::RenderListBox::paintItemBackground):
266         * rendering/RenderListBox.h:
267         * rendering/RenderObject.cpp:
268         (WebCore::RenderObject::paintFocusRing):
269         (WebCore::RenderObject::paintOutline):
270         * rendering/RenderObject.h:
271         * rendering/RenderReplaced.cpp:
272         (WebCore::RenderReplaced::shouldPaint):
273         * rendering/RenderReplaced.h:
274         * rendering/RenderScrollbarPart.cpp:
275         (WebCore::RenderScrollbarPart::paintIntoRect):
276         * rendering/RenderScrollbarPart.h:
277         * rendering/RenderTableCell.cpp:
278         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
279         * rendering/RenderTableSection.cpp:
280         (WebCore::RenderTableSection::paintCell):
281         * rendering/RenderTableSection.h:
282         * rendering/RenderTextControl.cpp:
283         (WebCore::RenderTextControl::paintPlaceholder):
284         * rendering/RootInlineBox.cpp:
285         (WebCore::RootInlineBox::paintEllipsisBox):
286         (WebCore::RootInlineBox::paintCustomHighlight):
287         (WebCore::RootInlineBox::paint):
288         * rendering/RootInlineBox.h:
289         * rendering/mathml/RenderMathMLBlock.cpp:
290         (WebCore::RenderMathMLBlock::paint):
291         * rendering/mathml/RenderMathMLFraction.cpp:
292         (WebCore::RenderMathMLFraction::paint):
293         * rendering/mathml/RenderMathMLRoot.cpp:
294         (WebCore::RenderMathMLRoot::paint):
295         * rendering/mathml/RenderMathMLSquareRoot.cpp:
296         (WebCore::RenderMathMLSquareRoot::paint):
297
298 2011-07-07  Steve VanDeBogart  <vandebo@chromium.org>
299
300         Work around Skia PDF's lack of inverted path support.
301         https://bugs.webkit.org/show_bug.cgi?id=64032
302
303         Reviewed by James Robinson.
304
305         The trick used in http://neugierig.org/software/chromium/notes/2010/07/clipping.html
306         to support antialiased clips doesn't work when printing to Skia's PDF backend because
307         the backend does not support inverted paths. This manifests as rounded buttons not being
308         drawn when printing, tracked as Chrome bug 79519.
309         
310         However, when the output is a vector device, like PDF, we don't need antialiased clips.
311         It's up to the PDF rendering engine to do that.  So we can simply disable the antialiased
312         clip code if the output is a vector device.
313         
314         I think the fix isn't testable because it requires examining the printed output.
315
316         * platform/graphics/skia/PlatformContextSkia.cpp:
317         (WebCore::PlatformContextSkia::clipPathAntiAliased):
318
319 2011-07-07  Emil A Eklund  <eae@chromium.org>
320
321         Switch rendering tree selection code to to new layout types
322         https://bugs.webkit.org/show_bug.cgi?id=63762
323
324         Reviewed by Eric Seidel.
325
326         Switch selection getters and selection gap calculation methods over to
327         new layout abstraction.
328
329         No new tests, no functionality changes.
330
331         * rendering/InlineTextBox.cpp:
332         (WebCore::InlineTextBox::selectionTop):
333         (WebCore::InlineTextBox::selectionBottom):
334         (WebCore::InlineTextBox::selectionHeight):
335         (WebCore::InlineTextBox::isSelected):
336         * rendering/InlineTextBox.h:
337         * rendering/RenderBR.h:
338         (WebCore::RenderBR::selectionRectForRepaint):
339         * rendering/RenderBlock.cpp:
340         (WebCore::RenderBlock::selectionGapRectsForRepaint):
341         (WebCore::RenderBlock::selectionGaps):
342         (WebCore::RenderBlock::inlineSelectionGaps):
343         (WebCore::RenderBlock::blockSelectionGaps):
344         (WebCore::RenderBlock::blockSelectionGap):
345         (WebCore::RenderBlock::logicalLeftSelectionGap):
346         (WebCore::RenderBlock::logicalRightSelectionGap):
347         (WebCore::RenderBlock::logicalLeftSelectionOffset):
348         (WebCore::RenderBlock::logicalRightSelectionOffset):
349         (WebCore::RenderBlock::positionForPointWithInlineChildren):
350         (WebCore::RenderBlock::desiredColumnWidth):
351         * rendering/RenderBlock.h:
352         (WebCore::RenderBlock::selectionRectForRepaint):
353         * rendering/RenderListMarker.cpp:
354         (WebCore::RenderListMarker::selectionRectForRepaint):
355         * rendering/RenderListMarker.h:
356         * rendering/RenderObject.h:
357         (WebCore::RenderObject::selectionRect):
358         (WebCore::RenderObject::selectionRectForRepaint):
359         * rendering/RenderReplaced.cpp:
360         (WebCore::RenderReplaced::selectionRectForRepaint):
361         * rendering/RenderReplaced.h:
362         * rendering/RenderSelectionInfo.h:
363         (WebCore::RenderSelectionInfo::RenderSelectionInfo):
364         * rendering/RenderText.cpp:
365         (WebCore::RenderText::selectionRectForRepaint):
366         * rendering/RenderText.h:
367         * rendering/RootInlineBox.cpp:
368         (WebCore::RootInlineBox::selectionTop):
369         (WebCore::RootInlineBox::selectionBottom):
370         * rendering/RootInlineBox.h:
371         (WebCore::RootInlineBox::selectionHeight):
372
373 2011-07-07  Gavin Peters  <gavinp@chromium.org>
374
375         Reviewed by Alexey Proskuryakov.
376
377         fast/dom/HTMLLinkElement/link-and-subresource-test.html is flaky on chromium debug bots
378         https://bugs.webkit.org/show_bug.cgi?id=60097
379
380         The culprit was that CachedResource:stopLoading() was using *this
381         after a call to checkNotify(), which isn't kosher.  This patch
382         uses a CachedResourceHandle to keep the CachedResource alive.
383
384         The test is a very close copy of the eponymous
385         link-and-subresource-test.html, only substituting invalid
386         resources for the valid ones in that test.  The reproduction is
387         timing related, and happens much more consistantly with an invalid
388         resource for whatever reason.
389         Test: fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html
390
391         * loader/cache/CachedResource.cpp:
392         (WebCore::CachedResource::stopLoading):
393
394 2011-07-07  James Robinson  <jamesr@chromium.org>
395
396         Reviewed by Kenneth Russell.
397
398         Use v8::AdjustAmountOfExternalAllocatedMemory for ArrayBuffers
399         https://bugs.webkit.org/show_bug.cgi?id=42912
400
401         This calls v8's AdjustAmountOfExternalAllocatedMemory when ArrayBuffers are allocated/deallocated so that V8's
402         garbage collection heuristics can account for the memory held by these objects.  On the new test page, this
403         reduces the peak memory use from 5BG+ (or a crash in 32-bit systems) to <300MB.
404
405         Test: WebCore/manual-tests/array-buffer-memory.html
406
407         * html/canvas/ArrayBuffer.cpp:
408         (WebCore::ArrayBuffer::~ArrayBuffer):
409         (WebCore::ArrayBuffer::tryAllocate):
410
411 2011-07-07  Ryosuke Niwa  <rniwa@webkit.org>
412
413         Move all code related to cachedSelection to HTMLTextFormControlElement
414         https://bugs.webkit.org/show_bug.cgi?id=64118
415
416         Reviewed by Alexey Proskuryakov.
417
418         Moved m_cachedSelectionStart and m_cachedSelectionEnd from HTMLInputElement
419         and HTMLTextAreaElement to HTMLTextFormControlElement
420
421         Also removed cached selection related functions from RenderTextControl,
422         RenderTextControlSingleLine, and RenderTextControlMultiLine because they were
423         merely providing wrapper functions to enable polymorphism between
424         input and textarea elements and their WML equivalents.
425
426         * editing/FrameSelection.cpp:
427         (WebCore::FrameSelection::notifyRendererOfSelectionChange): Calls HTMLTextFormControlElement's
428         selectionChanged instead of RenderTextControl's.
429         * html/HTMLFormControlElement.cpp:
430         (WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement): Initialize
431         m_cachedSelectionStart and m_cachedSelectionEnd.
432         (WebCore::HTMLTextFormControlElement::selectionStart):
433         (WebCore::HTMLTextFormControlElement::selectionEnd):
434         (WebCore::HTMLTextFormControlElement::selection):
435         (WebCore::HTMLTextFormControlElement::restoreCachedSelection): Added.
436         (WebCore::HTMLTextFormControlElement::selectionChanged): Extracted from
437         RenderTextControl::selectionChanged.
438         * html/HTMLFormControlElement.h:
439         (WebCore::HTMLTextFormControlElement::cacheSelection): Extracted from HTMLInputElement
440         and HTMLTextAreaElement.
441         (WebCore::HTMLTextFormControlElement::hasCachedSelectionStart): Added.
442         (WebCore::HTMLTextFormControlElement::hasCachedSelectionEnd): Added.
443         * html/HTMLInputElement.cpp:
444         (WebCore::HTMLInputElement::HTMLInputElement):
445         (WebCore::HTMLInputElement::updateFocusAppearance):
446         * html/HTMLInputElement.h:
447         * html/HTMLTextAreaElement.cpp:
448         (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
449         (WebCore::HTMLTextAreaElement::updateFocusAppearance):
450         * html/HTMLTextAreaElement.h:
451         (WebCore::HTMLTextAreaElement::isEmptyValue):
452         * rendering/RenderTextControl.cpp:
453         (WebCore::setSelectionRange):
454         * rendering/RenderTextControl.h:
455         * rendering/RenderTextControlMultiLine.cpp:
456         * rendering/RenderTextControlMultiLine.h:
457         * rendering/RenderTextControlSingleLine.cpp:
458         * rendering/RenderTextControlSingleLine.h:
459
460 2011-07-07  Emil A Eklund  <eae@chromium.org>
461
462         Switch addFocusRingRects to to new layout types
463         https://bugs.webkit.org/show_bug.cgi?id=64114
464
465         Reviewed by Eric Seidel.
466
467         No new tests, no functionality changes.
468
469         * rendering/LayoutTypes.h:
470         (WebCore::flooredLayoutPoint):
471         * rendering/RenderBlock.cpp:
472         (WebCore::RenderBlock::addFocusRingRects):
473         * rendering/RenderBlock.h:
474         * rendering/RenderBox.cpp:
475         (WebCore::RenderBox::addFocusRingRects):
476         * rendering/RenderBox.h:
477         * rendering/RenderInline.cpp:
478         (WebCore::RenderInline::addFocusRingRects):
479         * rendering/RenderInline.h:
480         * rendering/RenderListBox.cpp:
481         (WebCore::RenderListBox::addFocusRingRects):
482         * rendering/RenderListBox.h:
483         * rendering/RenderObject.h:
484         (WebCore::RenderObject::addFocusRingRects):
485         * rendering/RenderTextControl.cpp:
486         (WebCore::RenderTextControl::addFocusRingRects):
487         * rendering/RenderTextControl.h:
488         * rendering/svg/RenderSVGContainer.cpp:
489         (WebCore::RenderSVGContainer::addFocusRingRects):
490         * rendering/svg/RenderSVGContainer.h:
491         * rendering/svg/RenderSVGImage.cpp:
492         (WebCore::RenderSVGImage::addFocusRingRects):
493         * rendering/svg/RenderSVGImage.h:
494         * rendering/svg/RenderSVGPath.cpp:
495         (WebCore::RenderSVGPath::addFocusRingRects):
496         * rendering/svg/RenderSVGPath.h:
497
498 2011-07-06  Adrienne Walker  <enne@google.com>
499
500         [chromium] Reduce compositor texture memory by skipping layers and clipping surfaces
501         https://bugs.webkit.org/show_bug.cgi?id=64052
502
503         Reviewed by James Robinson.
504
505         Layers and surfaces that are entirely transparent are now skipped.
506         Parent scissor rects are now applied to the content rect of surfaces
507         so that offscreen surfaces can be skipped.
508
509         Landing this for vangelis@chromium.org.
510
511         Covered by existing tests.
512
513         * platform/graphics/chromium/LayerRendererChromium.cpp:
514         (WebCore::calculateVisibleRect):
515         (WebCore::calculateVisibleLayerRect):
516         (WebCore::LayerRendererChromium::paintLayerContents):
517         (WebCore::LayerRendererChromium::drawLayers):
518         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
519         (WebCore::LayerRendererChromium::updateCompositorResources):
520         (WebCore::LayerRendererChromium::drawLayer):
521         * platform/graphics/chromium/RenderSurfaceChromium.cpp:
522         (WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
523
524 2011-07-07  Adam Barth  <abarth@webkit.org>
525
526         Unreviewed, rolling out r90581.
527         http://trac.webkit.org/changeset/90581
528         https://bugs.webkit.org/show_bug.cgi?id=64124
529
530         Broke a bunch of inspector tests (Requested by ojan on
531         #webkit).
532
533         * inspector/front-end/ExtensionAPI.js:
534         (WebInspector.injectedExtensionAPI.Panels.prototype.create):
535         (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
536         (WebInspector.injectedExtensionAPI.expandURL):
537         * inspector/front-end/ExtensionPanel.js:
538         (WebInspector.ExtensionPanel):
539         * inspector/front-end/ExtensionServer.js:
540         (WebInspector.ExtensionServer):
541         (WebInspector.ExtensionServer.prototype._onCreatePanel):
542         (WebInspector.ExtensionServer.prototype._onSetSidebarPage):
543         (WebInspector.ExtensionServer.prototype._addExtensions):
544         (WebInspector.ExtensionServer.prototype._onWindowMessage):
545         (WebInspector.ExtensionServer.prototype._registerSubscriptionHandler):
546
547 2011-07-07  Adrienne Walker  <enne@google.com>
548
549         [chromium] Fix crash when compositing gets disabled mid-paint
550         https://bugs.webkit.org/show_bug.cgi?id=64119
551
552         Reviewed by James Robinson.
553
554         WebKit paint can disable compositing and call setRootLayer(0). Adding
555         a check for this in drawLayers prevents a null pointer deref.
556
557         * platform/graphics/chromium/LayerRendererChromium.cpp:
558         (WebCore::LayerRendererChromium::drawLayers):
559
560 2011-07-07  Dirk Schulze  <krit@webkit.org>
561
562         SVGAnimateTransform does not support calcMode=discrete
563         https://bugs.webkit.org/show_bug.cgi?id=63914
564
565         Reviewed by Rob Buis.
566
567         CalcMode discrete specifies that the animation function will jump from one value to the next without any interpolation.
568         Implemented calcMode discrete by checking current progress of animation. If we are in the first half of the animation,
569         we use the start value of the aniamtion, end value for the second half of the animation. The key time at 50% is used on
570         all other animations as well as on other SVG viewers.
571
572         Added a manual test. DRT crashes on an automated test with the SVG animation API. Opened a new bug report: 64104.
573
574         * manual-tests/svg-animateTransform-calcMode-discrete.svg: Added.
575         * svg/SVGAnimateTransformElement.cpp:
576         (WebCore::SVGAnimateTransformElement::calculateAnimatedValue):
577
578 2011-07-07  Dirk Schulze  <krit@webkit.org>
579
580         Reviewed by Rob Buis.
581
582         SVGAnimatedPath needs fallback for 'by' animation
583         https://bugs.webkit.org/show_bug.cgi?id=63865
584         
585         Added fallback to 'to' animation for 'by' animated SVGAnimatedPathAnimator.
586         
587         Clenup of SVGAnimateElement. Removed all switches since we support all AnimatedTypes
588         with the exception of AnimatedEnumeration. AnimatedEnumeration gets animated as AnimatedString at the moment. 
589
590         Test: svg/animations/svgpath-animation-1.html
591
592         * svg/SVGAnimateElement.cpp:
593         (WebCore::getPropertyValue):
594         (WebCore::inheritsFromProperty):
595         (WebCore::attributeValueIsCurrentColor):
596         (WebCore::SVGAnimateElement::adjustForCurrentColor):
597         (WebCore::SVGAnimateElement::determineAnimatedAttributeType):
598         (WebCore::SVGAnimateElement::calculateAnimatedValue):
599         (WebCore::SVGAnimateElement::calculateFromAndToValues):
600         (WebCore::SVGAnimateElement::calculateFromAndByValues):
601         (WebCore::SVGAnimateElement::resetToBaseValue):
602         (WebCore::SVGAnimateElement::applyResultsToTarget):
603         (WebCore::SVGAnimateElement::calculateDistance):
604         * svg/SVGAnimatedPath.cpp:
605         (WebCore::SVGAnimatedPathAnimator::calculateFromAndByValues):
606
607 2011-07-07  Andrey Kosyakov  <caseq@chromium.org>
608
609         Web Inspector: secure access to extensions API
610         https://bugs.webkit.org/show_bug.cgi?id=64080
611
612         Reviewed by Pavel Feldman.
613
614         * inspector/front-end/ExtensionAPI.js:
615         (WebInspector.injectedExtensionAPI.Panels.prototype.create):
616         (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
617         * inspector/front-end/ExtensionPanel.js:
618         (WebInspector.ExtensionPanel):
619         * inspector/front-end/ExtensionServer.js:
620         (WebInspector.ExtensionServer):
621         (WebInspector.ExtensionServer.prototype._onCreatePanel):
622         (WebInspector.ExtensionServer.prototype._onSetSidebarPage):
623         (WebInspector.ExtensionServer.prototype._addExtensions):
624         (WebInspector.ExtensionServer.prototype._onWindowMessage):
625         (WebInspector.ExtensionServer.prototype._registerSubscriptionHandler):
626         (WebInspector.ExtensionServer.prototype._expandResourcePath):
627
628 2011-07-07  Kyusun Kim  <maniagoon@company100.net>
629
630         The return value of SharedBuffer::createWithContentsOfFile must have valid m_size.
631         https://bugs.webkit.org/show_bug.cgi?id=63313
632
633         Reviewed by Eric Seidel.
634
635         * platform/posix/SharedBufferPOSIX.cpp:
636         (WebCore::SharedBuffer::createWithContentsOfFile):
637
638 2011-07-07  Dan Bernstein  <mitz@apple.com>
639
640         <rdar://problem/9737435> Re-enable -webkit-column-break-inside: avoid
641         https://bugs.webkit.org/show_bug.cgi?id=64102
642
643         Reviewed by Simon Fraser.
644
645         -webkit-column-break-inside: avoid was disabled in r62632 along with page-break-inside: avoid.
646         The latter remains disabled.
647
648         * rendering/RenderBlock.cpp:
649         (WebCore::RenderBlock::adjustForUnsplittableChild): Treat the child as unsplittable if
650         '-webkit-column-break-inside: avoid' was specified.
651
652 2011-07-07  Andrey Kosyakov  <caseq@chromium.org>
653
654         Web Inspector: visual regressions in network panel
655         https://bugs.webkit.org/show_bug.cgi?id=64089
656
657         Reviewed by Pavel Feldman.
658
659         * inspector/front-end/networkPanel.css:
660         (.data-grid.network-log-grid tr.filler td):
661         (.network.panel .sidebar):
662
663 2011-07-07  Julien Chaffraix  <jchaffraix@webkit.org>
664
665         Reviewed by David Hyatt.
666
667         Partial layout when a flex-box has visibility: collapse
668         https://bugs.webkit.org/show_bug.cgi?id=63776
669
670         Tests: fast/flexbox/crash-button-input-autofocus.html
671                fast/flexbox/crash-button-keygen.html
672                fast/flexbox/crash-button-relayout.html
673
674         The issue is that FlexBoxIterator would skip any child if it has visibility: collapsed.
675         However if one of the child is anonymous, it may wrap some other child that would be skipped.
676         Now FlexBoxIterator is called during the layout phase and thus some nodes would not relayouted
677         as expected.
678
679         * rendering/RenderDeprecatedFlexibleBox.cpp:
680         (WebCore::FlexBoxIterator::next): When iterating, don't skip anonymous content as there may
681         be real content hiding below.
682
683 2011-07-07  Vsevolod Vlasov  <vsevik@chromium.org>
684
685         Web Inspector: URL links in styles open new tab instead of showing resources panel.
686         https://bugs.webkit.org/show_bug.cgi?id=64090
687
688         Reviewed by Pavel Feldman.
689
690         * inspector/front-end/StylesSidebarPane.js:
691         (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
692
693 2011-07-07  Andrey Kosyakov  <caseq@chromium.org>
694
695         Web Inspector: active panel does not receive resize event when drawer is resized
696         https://bugs.webkit.org/show_bug.cgi?id=64094
697
698         Reviewed by Pavel Feldman.
699
700         * inspector/front-end/Drawer.js:
701         (WebInspector.Drawer.prototype._statusBarDragging):
702
703 2011-07-07  Pavel Feldman  <pfeldman@chromium.org>
704
705         Web Inspector: prevent default action during drag'n'drop in the Elements panel.
706         https://bugs.webkit.org/show_bug.cgi?id=64081
707
708         Reviewed by Yury Semikhatsky.
709
710         * inspector/front-end/ElementsTreeOutline.js:
711         (WebInspector.ElementsTreeOutline):
712         (WebInspector.ElementsTreeOutline.prototype._ondragstart):
713         (WebInspector.ElementsTreeOutline.prototype._ondragover):
714         (WebInspector.ElementsTreeOutline.prototype._ondragend):
715         * inspector/front-end/treeoutline.js:
716         (TreeOutline.prototype.treeElementFromPoint):
717
718 2011-07-07  Nikolas Zimmermann  <nzimmermann@rim.com>
719
720         Move remaining enums out of SVG*Element classes
721         https://bugs.webkit.org/show_bug.cgi?id=64075
722
723         Reviewed by Dirk Schulze.
724
725         Move remaining enums out of SVG*Element classes. This is a preparation patch for bug 63797.
726         Also move the SVGPropertyTraits template specializations for enum types before the class
727         definition in the header, otherwhise we can't use SVGPropertyTraits<FooType>::fromString/toString
728         in the DECLARE_ANIMATED* macros, which is needed soon.
729
730         No new tests, just refactoring.
731
732         * rendering/svg/RenderSVGResourceGradient.cpp:
733         (WebCore::RenderSVGResourceGradient::applyResource):
734         * rendering/svg/RenderSVGResourceGradient.h:
735         * rendering/svg/RenderSVGResourceMarker.cpp:
736         (WebCore::RenderSVGResourceMarker::angle):
737         (WebCore::RenderSVGResourceMarker::markerTransformation):
738         * rendering/svg/RenderSVGResourceMarker.h:
739         (WebCore::RenderSVGResourceMarker::markerUnits):
740         * rendering/svg/RenderSVGTextPath.cpp:
741         (WebCore::RenderSVGTextPath::RenderSVGTextPath):
742         (WebCore::RenderSVGTextPath::exactAlignment):
743         (WebCore::RenderSVGTextPath::stretchMethod):
744         * rendering/svg/SVGRenderTreeAsText.cpp:
745         (WebCore::operator<<):
746         (WebCore::writeCommonGradientProperties):
747         * rendering/svg/SVGTextChunkBuilder.cpp:
748         (WebCore::SVGTextChunkBuilder::addTextChunk):
749         * rendering/svg/SVGTextLayoutEngine.cpp:
750         (WebCore::SVGTextLayoutEngine::parentDefinesTextLength):
751         (WebCore::SVGTextLayoutEngine::beginTextPathLayout):
752         * svg/GradientAttributes.h:
753         (WebCore::GradientAttributes::GradientAttributes):
754         (WebCore::GradientAttributes::spreadMethod):
755         (WebCore::GradientAttributes::setSpreadMethod):
756         * svg/SVGComponentTransferFunctionElement.h:
757         * svg/SVGFEBlendElement.h:
758         * svg/SVGFEColorMatrixElement.h:
759         * svg/SVGFECompositeElement.h:
760         * svg/SVGFEConvolveMatrixElement.h:
761         * svg/SVGFEDisplacementMapElement.h:
762         * svg/SVGFEMorphologyElement.h:
763         * svg/SVGFETurbulenceElement.h:
764         * svg/SVGGradientElement.cpp:
765         (WebCore::SVGGradientElement::SVGGradientElement):
766         * svg/SVGGradientElement.h:
767         * svg/SVGMarkerElement.cpp:
768         (WebCore::SVGMarkerElement::SVGMarkerElement):
769         (WebCore::SVGMarkerElement::parseMappedAttribute):
770         (WebCore::SVGMarkerElement::setOrientToAuto):
771         (WebCore::SVGMarkerElement::setOrientToAngle):
772         (WebCore::SVGMarkerElement::synchronizeOrientType):
773         (WebCore::SVGMarkerElement::orientTypeAnimated):
774         * svg/SVGMarkerElement.h:
775         * svg/SVGTextContentElement.cpp:
776         (WebCore::SVGTextContentElement::SVGTextContentElement):
777         * svg/SVGTextContentElement.h:
778         * svg/SVGTextPathElement.cpp:
779         (WebCore::SVGTextPathElement::SVGTextPathElement):
780         * svg/SVGTextPathElement.h:
781
782 2011-07-07  Ilya Tikhonovsky  <loislo@chromium.org>
783
784         Web Inspector: Protocol: pointers to optional "in" parameters passing to the
785         backend methods should be NULL if they are not specified in the message.
786         https://bugs.webkit.org/show_bug.cgi?id=64083
787
788         Reviewed by Pavel Feldman.
789
790         * inspector/CodeGeneratorInspector.pm:
791         (generateBackendFunction):
792         (generateArgumentGetters):
793         * inspector/InspectorCSSAgent.cpp:
794         (WebCore::InspectorCSSAgent::getStylesForNode):
795
796 2011-07-07  Ilya Tikhonovsky  <loislo@chromium.org>
797
798         Web Inspector: Searching on the Network panel doesn't do anything?
799         https://bugs.webkit.org/show_bug.cgi?id=55489
800
801         This is initial implementation of search in Network panel.
802         It is pretty simple search only for names and paths.
803
804         Reviewed by Pavel Feldman.
805
806         * inspector/front-end/NetworkPanel.js:
807         (WebInspector.NetworkPanel.prototype.refresh):
808         (WebInspector.NetworkPanel.prototype._reset):
809         (WebInspector.NetworkPanel.prototype._updateOffscreenRows):
810         (WebInspector.NetworkPanel.prototype._matchResource):
811         (WebInspector.NetworkPanel.prototype._clearSearchMatchedList):
812         (WebInspector.NetworkPanel.prototype._highlightNthMatchedResource):
813         (WebInspector.NetworkPanel.prototype.performSearch):
814         (WebInspector.NetworkDataGridNode.prototype.createCells):
815         * inspector/front-end/utilities.js:
816         (String.prototype.escapeHTML):
817         ():
818
819 2011-07-07  Vsevolod Vlasov  <vsevik@chromium.org>
820
821         Web Inspector: Resources panel shows only one resource when multiple resources have the same url.
822         https://bugs.webkit.org/show_bug.cgi?id=63936
823
824         Reviewed by Pavel Feldman.
825
826         Test: http/tests/inspector/resource-tree/resource-tree-non-unique-url.html
827
828         * inspector/front-end/ResourcesPanel.js:
829         (WebInspector.FrameTreeElement.prototype.appendResource):
830
831 2011-07-07  Vsevolod Vlasov  <vsevik@chromium.org>
832
833         Web Inspector: Add support for clearing cache and cookies from network panel.
834         https://bugs.webkit.org/show_bug.cgi?id=63999
835
836         Reviewed by Pavel Feldman.
837
838         * English.lproj/localizedStrings.js:
839         * inspector/Inspector.json:
840         * inspector/InspectorClient.h:
841         (WebCore::InspectorClient::clearBrowserCache):
842         (WebCore::InspectorClient::clearBrowserCookies):
843         * inspector/InspectorController.cpp:
844         (WebCore::InspectorController::InspectorController):
845         * inspector/InspectorResourceAgent.cpp:
846         (WebCore::InspectorResourceAgent::clearBrowserCache):
847         (WebCore::InspectorResourceAgent::clearBrowserCookies):
848         (WebCore::InspectorResourceAgent::InspectorResourceAgent):
849         * inspector/InspectorResourceAgent.h:
850         (WebCore::InspectorResourceAgent::create):
851         * inspector/front-end/NetworkPanel.js:
852         (WebInspector.NetworkPanel.prototype._contextMenu):
853         (WebInspector.NetworkPanel.prototype._clearBrowserCache):
854         (WebInspector.NetworkPanel.prototype._clearBrowserCookies):
855         * inspector/front-end/Settings.js:
856
857 2011-07-07  Shinya Kawanaka  <shinyak@google.com>
858
859         Added more key bindings for input[type=range].
860         https://bugs.webkit.org/show_bug.cgi?id=52262
861
862         Added PageUp/PageDown/Home/End key bindings for input[type=range].
863         PageUp/PageDown change value by about 10%.
864         Home/End change value to minimum/maximum.
865
866         Reviewed by Kent Tamura.
867
868         * html/RangeInputType.cpp:
869         (WebCore::RangeInputType::handleKeydownEvent):
870           Added key bindings.
871
872 2011-07-07  Oleg Romashin  <romaxa@gmail.com>
873
874         Fix InspectorInstrumentation compilation.
875         https://bugs.webkit.org/show_bug.cgi?id=64033
876
877         Reviewed by Yury Semikhatsky.
878
879         No new tests. just compile fix.
880
881         * inspector/InspectorInstrumentation.cpp:
882         (WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl):
883
884 2011-07-06  Mihnea Ovidenie  <mihnea@adobe.com>
885
886         Reviewed by David Hyatt.
887
888         [CSSRegions] Parse flow property
889         https://bugs.webkit.org/show_bug.cgi?id=61730
890
891         Test: fast/regions/webkit-flow-parsing.html
892
893         * css/CSSComputedStyleDeclaration.cpp:
894         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
895         * css/CSSParser.cpp:
896         (WebCore::CSSParser::parseValue):
897         (WebCore::CSSParser::parseFlowThread):
898         * css/CSSParser.h:
899         * css/CSSPropertyNames.in:
900         * css/CSSStyleSelector.cpp:
901         (WebCore::CSSStyleSelector::applyProperty):
902         * rendering/style/RenderStyle.cpp:
903         (WebCore::RenderStyle::diff):
904         * rendering/style/RenderStyle.h:
905         (WebCore::InheritedFlags::flowThread):
906         (WebCore::InheritedFlags::setFlowThread):
907         (WebCore::InheritedFlags::initialFlowThread):
908         * rendering/style/StyleRareNonInheritedData.cpp:
909         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
910         (WebCore::StyleRareNonInheritedData::operator==):
911         * rendering/style/StyleRareNonInheritedData.h:
912
913 2011-07-06  MORITA Hajime  <morrita@google.com>
914
915         [ShadowContentElement] Redundant RenderText objects are created on the content boundaries.
916         https://bugs.webkit.org/show_bug.cgi?id=63977
917
918         Reviewed by Dimitri Glazkov.
919
920         NodeRenderingContext::nextRenderer() and previousRenderer() didn't work well
921         when it crosses content elements:
922         - It doesn't step into forwarded children of ShadowContentElement.
923         - It doesn't step out from traversing forwarded children to
924           neighbors of the content element of that forwarded chidren.
925         
926         This change makes it to step into and out from content element.
927         
928         Test: fast/dom/shadow/content-element-renderers.html
929
930         * dom/NodeRenderingContext.cpp:
931         (WebCore::firstRendererOf): Added
932         (WebCore::lastRendererOf): Added
933         (WebCore::NodeRenderingContext::nextRenderer):
934         (WebCore::NodeRenderingContext::previousRenderer):
935
936 2011-07-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
937
938         [EFL] Add Fullscreen API feature
939         https://bugs.webkit.org/show_bug.cgi?id=63975
940
941         Add needed files for enabling ENABLE_FULLSCREEN_API feature.
942
943         Reviewed by Adam Barth.
944
945         * CMakeLists.txt: Add RenderFullScreen.cpp, fullscreen.css
946
947 2011-07-06  Emil A Eklund  <eae@chromium.org>
948
949         Switch absoluteRects to to new layout types
950         https://bugs.webkit.org/show_bug.cgi?id=64035
951
952         Reviewed by Eric Seidel.
953
954         Move absoluteRects over to new layout unit abstraction.
955         Add flooredLayoutPoint, mapped to flooredIntPoint.
956
957         No new tests, no functionality changes.
958
959         * rendering/LayoutTypes.h:
960         (WebCore::flooredLayoutPoint):
961         * rendering/RenderBlock.cpp:
962         (WebCore::RenderBlock::absoluteRects):
963         * rendering/RenderBlock.h:
964         * rendering/RenderBox.cpp:
965         (WebCore::RenderBox::absoluteRects):
966         * rendering/RenderInline.cpp:
967         (WebCore::RenderInline::absoluteRects):
968         * rendering/RenderInline.h:
969         * rendering/RenderObject.cpp:
970         (WebCore::RenderObject::absoluteBoundingBoxRect):
971         * rendering/RenderObject.h:
972         (WebCore::RenderObject::absoluteRects):
973         * rendering/RenderText.cpp:
974         (WebCore::RenderText::absoluteRects):
975         * rendering/RenderText.h:
976         * rendering/RenderView.cpp:
977         (WebCore::RenderView::absoluteRects):
978         * rendering/RenderView.h:
979         * rendering/svg/RenderSVGBlock.cpp:
980         (WebCore::RenderSVGBlock::absoluteRects):
981         * rendering/svg/RenderSVGBlock.h:
982         * rendering/svg/RenderSVGModelObject.cpp:
983         (WebCore::RenderSVGModelObject::absoluteRects):
984         * rendering/svg/RenderSVGModelObject.h:
985
986 2011-07-06  Emil A Eklund  <eae@chromium.org>
987
988         Reviewed by Eric Seidel.
989
990         Switch offsetFromContainer and related to to new layout types
991         https://bugs.webkit.org/show_bug.cgi?id=63659
992
993         Switch offsetFromContainer and related mapping methods to new layout unit
994         abstraction.
995
996         No new tests, no functionality changes.
997
998         * rendering/LayoutTypes.h:
999         (WebCore::enclosingLayoutRect):
1000         (WebCore::roundedLayoutPoint):
1001         (WebCore::roundedLayoutUnit):
1002         Add LayoutUnit versions of enclosingIntRect, roundedIntPoint and lroundf.
1003         For now these map to their int counterpart but once we switch to float or
1004         fixed point they'll be no-ops and eventually will be removed. 
1005         
1006         * rendering/RenderBox.cpp:
1007         (WebCore::RenderBox::mapLocalToContainer):
1008         (WebCore::RenderBox::mapAbsoluteToLocalPoint):
1009         (WebCore::RenderBox::offsetFromContainer):
1010         * rendering/RenderBox.h:
1011         * rendering/RenderInline.cpp:
1012         (WebCore::RenderInline::linesBoundingBox):
1013         (WebCore::RenderInline::offsetFromContainer):
1014         (WebCore::RenderInline::mapLocalToContainer):
1015         (WebCore::RenderInline::mapAbsoluteToLocalPoint):
1016         (WebCore::RenderInline::relativePositionedInlineOffset):
1017         * rendering/RenderInline.h:
1018         * rendering/RenderObject.cpp:
1019         (WebCore::RenderObject::offsetFromContainer):
1020         (WebCore::RenderObject::offsetFromAncestorContainer):
1021         * rendering/RenderObject.h:
1022         * rendering/RenderTableCell.cpp:
1023         (WebCore::RenderTableCell::offsetFromContainer):
1024         * rendering/RenderTableCell.h:
1025         * rendering/RenderThemeMac.mm:
1026         (WebCore::RenderThemeMac::convertToPaintingRect):
1027
1028 2011-07-06  Levi Weintraub  <leviw@chromium.org>
1029
1030         Switch FrameSelection to new Layout Types
1031         https://bugs.webkit.org/show_bug.cgi?id=64043
1032
1033         Reviewed by Eric Seidel.
1034
1035         Switching the selection classes to the new layout types. Changing
1036         NoXPosForVerticalArrowNavigation to a static inline since as it stood it violated
1037         our global initializer rule when converted to numeric_limits from INT_MIN.
1038
1039         No new tests, no functionality changes.
1040
1041         * editing/FrameSelection.cpp:
1042         (WebCore::FrameSelection::modify):
1043         (WebCore::absoluteCaretY):
1044         (WebCore::FrameSelection::lineDirectionPointForBlockDirectionNavigation):
1045         (WebCore::CaretBase::clearCaretRect):
1046         (WebCore::CaretBase::updateCaretRect):
1047         (WebCore::FrameSelection::localCaretRect):
1048         (WebCore::CaretBase::absoluteBoundsForLocalRect):
1049         (WebCore::FrameSelection::absoluteCaretBounds):
1050         (WebCore::repaintRectForCaret):
1051         (WebCore::CaretBase::caretRepaintRect):
1052         (WebCore::FrameSelection::recomputeCaretRect):
1053         (WebCore::FrameSelection::paintCaret):
1054         (WebCore::CaretBase::paintCaret):
1055         (WebCore::FrameSelection::contains):
1056         (WebCore::DragCaretController::paintDragCaret):
1057         (WebCore::FrameSelection::bounds):
1058         (WebCore::FrameSelection::revealSelection):
1059         * editing/FrameSelection.h:
1060         (WebCore::CaretBase::localCaretRectWithoutUpdate):
1061
1062 2011-07-06  Levi Weintraub  <leviw@chromium.org>
1063
1064         Switch Overflow and FrameRect methods in InlineBox to Layout Units
1065         https://bugs.webkit.org/show_bug.cgi?id=64034
1066
1067         Reviewed by Eric Seidel.
1068
1069         Switching Overflow and FrameRect methods on InlineBox to new Layout Unit abstraction and
1070         cleaning up some compilation errors that crop up when building with floating point layout units.
1071
1072         No new tests, no functionality changes.
1073
1074         * css/CSSComputedStyleDeclaration.cpp:
1075         (WebCore::sizingBox):
1076         * dom/Document.h:
1077         * editing/DeleteButtonController.cpp:
1078         (WebCore::isDeletableElement):
1079         * inspector/DOMNodeHighlighter.cpp:
1080         (WebCore::DOMNodeHighlighter::drawNodeHighlight):
1081         * page/animation/AnimationBase.cpp:
1082         (WebCore::blendFunc):
1083         * platform/ScrollView.h:
1084         (WebCore::ScrollView::visibleWidth):
1085         (WebCore::ScrollView::visibleHeight):
1086         * platform/ScrollableArea.h:
1087         (WebCore::ScrollableArea::visibleHeight):
1088         (WebCore::ScrollableArea::visibleWidth):
1089         * platform/graphics/FloatPoint.h: Adding FloatPoint and FloatSize move[By] functions
1090         (WebCore::FloatPoint::move):
1091         (WebCore::FloatPoint::moveBy):
1092         * rendering/AutoTableLayout.cpp:
1093         (WebCore::AutoTableLayout::computePreferredLogicalWidths):
1094         (WebCore::AutoTableLayout::layout):
1095         * rendering/InlineFlowBox.h:
1096         (WebCore::InlineFlowBox::layoutOverflowRect):
1097         (WebCore::InlineFlowBox::logicalLeftLayoutOverflow):
1098         (WebCore::InlineFlowBox::logicalRightLayoutOverflow):
1099         (WebCore::InlineFlowBox::logicalTopLayoutOverflow):
1100         (WebCore::InlineFlowBox::logicalBottomLayoutOverflow):
1101         (WebCore::InlineFlowBox::logicalLayoutOverflowRect):
1102         (WebCore::InlineFlowBox::visualOverflowRect):
1103         (WebCore::InlineFlowBox::logicalLeftVisualOverflow):
1104         (WebCore::InlineFlowBox::logicalRightVisualOverflow):
1105         (WebCore::InlineFlowBox::logicalTopVisualOverflow):
1106         (WebCore::InlineFlowBox::logicalBottomVisualOverflow):
1107         (WebCore::InlineFlowBox::logicalVisualOverflowRect):
1108         (WebCore::InlineFlowBox::frameRectIncludingLineHeight):
1109         (WebCore::InlineFlowBox::logicalFrameRectIncludingLineHeight):
1110         * rendering/RenderBlock.h:
1111         (WebCore::RenderBlock::RenderBlockRareData::positiveMarginBeforeDefault):
1112         (WebCore::RenderBlock::RenderBlockRareData::negativeMarginBeforeDefault):
1113         (WebCore::RenderBlock::RenderBlockRareData::positiveMarginAfterDefault):
1114         (WebCore::RenderBlock::RenderBlockRareData::negativeMarginAfterDefault):
1115
1116 2011-07-06  Emil A Eklund  <eae@chromium.org>
1117
1118         Reviewed by Eric Seidel.
1119         
1120         Switch nodeAtPoint to to new layout types
1121         https://bugs.webkit.org/show_bug.cgi?id=63663
1122
1123         No new tests, no functionality changes.
1124
1125         * rendering/EllipsisBox.cpp:
1126         (WebCore::EllipsisBox::nodeAtPoint):
1127         * rendering/EllipsisBox.h:
1128         * rendering/InlineBox.cpp:
1129         (WebCore::InlineBox::nodeAtPoint):
1130         * rendering/InlineBox.h:
1131         * rendering/InlineFlowBox.cpp:
1132         (WebCore::InlineFlowBox::nodeAtPoint):
1133         * rendering/InlineFlowBox.h:
1134         * rendering/InlineTextBox.cpp:
1135         (WebCore::InlineTextBox::nodeAtPoint):
1136         * rendering/InlineTextBox.h:
1137         * rendering/LayoutTypes.h:
1138         (WebCore::toLayoutSize):
1139         (WebCore::toLayoutPoint):
1140         (WebCore::roundedLayoutPoint):
1141         (WebCore::roundedLayoutUnit):
1142         * rendering/RenderBlock.cpp:
1143         (WebCore::RenderBlock::nodeAtPoint):
1144         * rendering/RenderBlock.h:
1145         * rendering/RenderBox.cpp:
1146         (WebCore::RenderBox::nodeAtPoint):
1147         * rendering/RenderBox.h:
1148         * rendering/RenderFrameSet.cpp:
1149         (WebCore::RenderFrameSet::nodeAtPoint):
1150         * rendering/RenderFrameSet.h:
1151         * rendering/RenderImage.cpp:
1152         (WebCore::RenderImage::nodeAtPoint):
1153         * rendering/RenderImage.h:
1154         * rendering/RenderInline.cpp:
1155         (WebCore::RenderInline::nodeAtPoint):
1156         * rendering/RenderInline.h:
1157         * rendering/RenderListBox.cpp:
1158         (WebCore::RenderListBox::nodeAtPoint):
1159         * rendering/RenderListBox.h:
1160         * rendering/RenderObject.cpp:
1161         (WebCore::RenderObject::nodeAtPoint):
1162         * rendering/RenderObject.h:
1163         * rendering/RenderTable.cpp:
1164         (WebCore::RenderTable::nodeAtPoint):
1165         * rendering/RenderTable.h:
1166         * rendering/RenderTableRow.cpp:
1167         (WebCore::RenderTableRow::nodeAtPoint):
1168         * rendering/RenderTableRow.h:
1169         * rendering/RenderTableSection.cpp:
1170         (WebCore::RenderTableSection::nodeAtPoint):
1171         * rendering/RenderTableSection.h:
1172         * rendering/RenderText.h:
1173         (WebCore::RenderText::nodeAtPoint):
1174         * rendering/RenderTextControlMultiLine.cpp:
1175         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
1176         * rendering/RenderTextControlMultiLine.h:
1177         * rendering/RenderTextControlSingleLine.cpp:
1178         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
1179         * rendering/RenderTextControlSingleLine.h:
1180         * rendering/RenderWidget.cpp:
1181         (WebCore::RenderWidget::nodeAtPoint):
1182         * rendering/RenderWidget.h:
1183         * rendering/RootInlineBox.cpp:
1184         (WebCore::RootInlineBox::nodeAtPoint):
1185         * rendering/RootInlineBox.h:
1186         * rendering/svg/RenderSVGForeignObject.cpp:
1187         (WebCore::RenderSVGForeignObject::nodeAtFloatPoint):
1188         (WebCore::RenderSVGForeignObject::nodeAtPoint):
1189         * rendering/svg/RenderSVGForeignObject.h:
1190         * rendering/svg/RenderSVGModelObject.cpp:
1191         (WebCore::RenderSVGModelObject::nodeAtPoint):
1192         * rendering/svg/RenderSVGModelObject.h:
1193         * rendering/svg/RenderSVGRoot.cpp:
1194         (WebCore::RenderSVGRoot::nodeAtPoint):
1195         * rendering/svg/RenderSVGRoot.h:
1196         * rendering/svg/RenderSVGText.cpp:
1197         (WebCore::RenderSVGText::nodeAtPoint):
1198         * rendering/svg/RenderSVGText.h:
1199         * rendering/svg/SVGInlineTextBox.cpp:
1200         (WebCore::SVGInlineTextBox::nodeAtPoint):
1201         * rendering/svg/SVGInlineTextBox.h:
1202
1203 2011-07-06  Adrienne Walker  <enne@google.com>
1204
1205         [chromium] Add compositor texture manager soft limits and lost focus reclaiming
1206         https://bugs.webkit.org/show_bug.cgi?id=64009
1207
1208         Reviewed by James Robinson.
1209
1210         Add a soft limit for texture memory. Unprotected textures will get
1211         reclaimed when above this limit. Increase the hard limit for maximum
1212         texture memory as well, now that there is a better heuristic and
1213         textures are reclaimed from tabs without focus.
1214
1215         Landing this for vangelis@chromium.org.
1216
1217         * platform/graphics/chromium/LayerRendererChromium.cpp:
1218         (WebCore::LayerRendererChromium::releaseTextures):
1219         (WebCore::LayerRendererChromium::initializeSharedObjects):
1220         * platform/graphics/chromium/LayerRendererChromium.h:
1221         * platform/graphics/chromium/LayerTilerChromium.cpp:
1222         (WebCore::LayerTilerChromium::protectTileTextures):
1223         * platform/graphics/chromium/LayerTilerChromium.h:
1224         * platform/graphics/chromium/TextureManager.cpp:
1225         (WebCore::TextureManager::TextureManager):
1226         (WebCore::TextureManager::requestTexture):
1227         * platform/graphics/chromium/TextureManager.h:
1228         (WebCore::TextureManager::create):
1229
1230 2011-07-06  Pavel Feldman  <pfeldman@chromium.org>
1231
1232         Not reviewed: Web Inspector: fixing typo introduced in the r90397.
1233
1234         * inspector/front-end/StylesSidebarPane.js:
1235
1236 2011-07-06  Mike Reed  <reed@google.com>
1237
1238         [skia] don't include deprecated header
1239         https://bugs.webkit.org/show_bug.cgi?id=64025
1240
1241         Reviewed by James Robinson.
1242
1243         No new tests. Just removing #include of an unused header that will be gone soon
1244
1245         * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
1246         * platform/graphics/skia/PlatformContextSkia.cpp:
1247
1248 2011-06-30  Cris Neckar  <cdn@chromium.org>
1249
1250         Reviewed by Darin Fisher.
1251
1252         Add versioning to Chromium clipboard and prevent polling from inside events.
1253         https://bugs.webkit.org/show_bug.cgi?id=63738
1254
1255         * platform/chromium/ChromiumDataObject.cpp:
1256         (WebCore::ChromiumDataObject::getSequenceNumber):
1257         * platform/chromium/ChromiumDataObject.h:
1258         * platform/chromium/ClipboardChromium.cpp:
1259         (WebCore::ClipboardChromium::ClipboardChromium):
1260         (WebCore::ClipboardChromium::getData):
1261         (WebCore::ClipboardChromium::platformClipboardChanged):
1262         * platform/chromium/ClipboardChromium.h:
1263         * platform/chromium/DataTransferItemChromium.cpp:
1264         (WebCore::DataTransferItemChromium::getAsString):
1265         (WebCore::DataTransferItemChromium::getAsFile):
1266         * platform/chromium/PlatformBridge.h:
1267         * svg/SVGAnimationElement.cpp:
1268         (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
1269
1270 2011-07-01  James Robinson  <jamesr@chromium.org>
1271
1272         Reviewed by Stephen White.
1273
1274         [chromium] Externalize layer visibility calculation
1275         https://bugs.webkit.org/show_bug.cgi?id=63847
1276
1277         This moves the layer visibility calculation from the layer itself out to LayerRendererChromium, like the other
1278         calculated properties.  Previously, we were doing this calculating at paint time and again at draw time and
1279         relying on the fact that this produced the same value.  This avoids the redundant calculation.
1280
1281         Covered by existing compositing/ layout tests.
1282
1283         * platform/graphics/chromium/ContentLayerChromium.cpp:
1284         (WebCore::ContentLayerChromium::ContentLayerChromium):
1285         (WebCore::ContentLayerChromium::paintContentsIfDirty):
1286         (WebCore::ContentLayerChromium::tilingTransform):
1287         (WebCore::ContentLayerChromium::contentBounds):
1288         (WebCore::ContentLayerChromium::updateLayerSize):
1289         (WebCore::ContentLayerChromium::draw):
1290         (WebCore::ContentLayerChromium::setTilingOption):
1291         (WebCore::ContentLayerChromium::setIsMask):
1292         * platform/graphics/chromium/ContentLayerChromium.h:
1293         * platform/graphics/chromium/ImageLayerChromium.cpp:
1294         (WebCore::ImageLayerChromium::paintContentsIfDirty):
1295         (WebCore::ImageLayerChromium::contentBounds):
1296         * platform/graphics/chromium/ImageLayerChromium.h:
1297         * platform/graphics/chromium/LayerChromium.cpp:
1298         (WebCore::LayerChromium::pushPropertiesTo):
1299         * platform/graphics/chromium/LayerChromium.h:
1300         (WebCore::LayerChromium::contentBounds):
1301         (WebCore::LayerChromium::visibleLayerRect):
1302         (WebCore::LayerChromium::setVisibleLayerRect):
1303         (WebCore::LayerChromium::draw):
1304         * platform/graphics/chromium/LayerRendererChromium.cpp:
1305         (WebCore::calculateVisibleLayerRect):
1306         (WebCore::LayerRendererChromium::paintLayerContents):
1307         (WebCore::LayerRendererChromium::drawLayer):
1308         * platform/graphics/chromium/RenderSurfaceChromium.cpp:
1309         (WebCore::RenderSurfaceChromium::draw):
1310         * platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
1311         (WebCore::CCCanvasLayerImpl::draw):
1312         * platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
1313         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
1314         (WebCore::CCLayerImpl::draw):
1315         * platform/graphics/chromium/cc/CCLayerImpl.h:
1316         (WebCore::CCLayerImpl::contentBounds):
1317         (WebCore::CCLayerImpl::setContentBounds):
1318         (WebCore::CCLayerImpl::visibleLayerRect):
1319         (WebCore::CCLayerImpl::setVisibleLayerRect):
1320         (WebCore::CCLayerImpl::doubleSided):
1321         (WebCore::CCLayerImpl::setDoubleSided):
1322         * platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
1323         (WebCore::CCPluginLayerImpl::draw):
1324         * platform/graphics/chromium/cc/CCPluginLayerImpl.h:
1325         * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
1326         (WebCore::CCVideoLayerImpl::draw):
1327         * platform/graphics/chromium/cc/CCVideoLayerImpl.h:
1328
1329 2011-07-06  John Sullivan  <sullivan@apple.com>
1330
1331         IconDatabase::synchronousIconForPageURL() has inconsistent API when no custom icon is available
1332         <https://bugs.webkit.org/show_bug.cgi?id=64015>
1333         <rdar://problem/9706277>
1334
1335         For some URLs it would return a particular size of default icon; for other
1336         URLs it would return 0.
1337
1338         Reviewed by Ada Chan.
1339
1340         * loader/icon/IconDatabase.cpp:
1341         (WebCore::IconDatabase::synchronousIconForPageURL):
1342         Return 0 in all cases where there is no custom icon.
1343
1344 2011-07-06  Emil A Eklund  <eae@chromium.org>
1345
1346         Reviewed by Eric Seidel.
1347
1348         Switch RenderLayer::hitTest* to to new layout types
1349         https://bugs.webkit.org/show_bug.cgi?id=63640
1350
1351         Switch hit testing and supporting methods for RenderLayer over to the new
1352         layout unit abstraction.
1353         
1354         No new tests, no functionality changes.
1355
1356         * rendering/LayoutTypes.h:
1357         (WebCore::roundedLayoutPoint):
1358         Add roundedLayoutPoint abstraction, calls roundedIntPoint now but will be a
1359         no-op (and eventually go away) once we switch to float or fixed point.
1360         
1361         * rendering/RenderLayer.cpp:
1362         (WebCore::RenderLayer::createLocalTransformState):
1363         (WebCore::RenderLayer::hitTestLayer):
1364         (WebCore::RenderLayer::hitTestList):
1365         (WebCore::RenderLayer::hitTestPaginatedChildLayer):
1366         (WebCore::RenderLayer::hitTestChildLayerColumns):
1367         (WebCore::RenderLayer::calculateRects):
1368         * rendering/RenderLayer.h:
1369
1370 2011-07-06  Simon Fraser  <simon.fraser@apple.com>
1371
1372         Have RenderLayerCompositor take care of clearing backing store when entering the page cache
1373         https://bugs.webkit.org/show_bug.cgi?id=64018
1374
1375         Reviewed by Joseph Pecoraro.
1376
1377         Move responsibility for tearing down all RenderLayer backing stores from
1378         RenderLayer itself to RenderLayerCompositor, since RenderLayerCompositor 
1379         manages backing store creation and destruction in general.
1380
1381         * page/FrameView.cpp:
1382         (WebCore::FrameView::clearBackingStores):
1383         * rendering/RenderLayer.cpp:
1384         * rendering/RenderLayer.h:
1385         * rendering/RenderLayerCompositor.cpp:
1386         (WebCore::RenderLayerCompositor::clearBackingForLayerIncludingDescendants):
1387         (WebCore::RenderLayerCompositor::clearBackingForAllLayers):
1388         * rendering/RenderLayerCompositor.h:
1389
1390 2011-07-06  Ryuan Choi  <ryuan.choi@samsung.com>
1391
1392         [Performance] Only call sendContentResizeNotification when the scrollbar actually did change
1393         https://bugs.webkit.org/show_bug.cgi?id=47320
1394
1395         Reviewed by Eric Seidel.
1396
1397         Move avoidScrollbarCreation checking code from setHasHorizontalScrollbar
1398         and setHasVerticalScrollbar to their caller in order to keep sendContentResizedNotification
1399         false in case scrollbar is not really changed.
1400         As a result, it will remove unnecessary relayout in the above case.
1401
1402         No new tests as this is very hard to write tests for. The bug only
1403         occured when scrolling the sites which contain frame in browser with
1404         frameFlattening. This should not change functionality in other case.
1405
1406         * platform/ScrollView.cpp:
1407         (WebCore::ScrollView::setHasHorizontalScrollbar):
1408         (WebCore::ScrollView::setHasVerticalScrollbar):
1409         (WebCore::ScrollView::updateScrollbars):
1410
1411 2011-07-06  Nate Chapin  <japhet@chromium.org>
1412
1413         Don't let all subresources keep isLoadingInAPISense() from
1414         returning false, only requests that affect
1415         CachedResourceRequest::requestCount().
1416         https://bugs.webkit.org/show_bug.cgi?id=62066
1417
1418         Reviewed by Adam Barth.
1419
1420         * dom/Document.cpp:
1421         (WebCore::Document::Document):
1422         (WebCore::Document::dispatchWindowLoadEvent):
1423         * dom/Document.h:
1424         (WebCore::Document::loadEventFinished):
1425         * loader/DocumentLoader.cpp:
1426         (WebCore::DocumentLoader::isLoadingInAPISense):
1427
1428 2011-07-06  Pavel Feldman  <pfeldman@google.com>
1429
1430         Web Inspector: implement drag'n'drop in the elements panel for reordering nodes.
1431         https://bugs.webkit.org/show_bug.cgi?id=63990
1432
1433         Reviewed by Yury Semikhatsky.
1434
1435         * inspector/Inspector.json:
1436         * inspector/InspectorDOMAgent.cpp:
1437         (WebCore::InspectorDOMAgent::moveTo):
1438         * inspector/InspectorDOMAgent.h:
1439         * inspector/front-end/DOMAgent.js:
1440         (WebInspector.DOMNode.prototype._removeChild):
1441         (WebInspector.DOMNode.prototype.ownerDocumentElement):
1442         (WebInspector.DOMNode.prototype.moveTo):
1443         (WebInspector.DOMAgent.prototype._childNodeRemoved):
1444         * inspector/front-end/ElementsTreeOutline.js:
1445         (WebInspector.ElementsTreeOutline):
1446         (WebInspector.ElementsTreeOutline.prototype._ondragstart):
1447         (WebInspector.ElementsTreeOutline.prototype._ondragover):
1448         (WebInspector.ElementsTreeOutline.prototype._ondragleave):
1449         (WebInspector.ElementsTreeOutline.prototype._isValidDragSourceOrTarget):
1450         (WebInspector.ElementsTreeOutline.prototype._ondragend.callback):
1451         (WebInspector.ElementsTreeOutline.prototype._ondragend):
1452         (WebInspector.ElementsTreeOutline.prototype._clearDragOverTreeElementMarker):
1453         (WebInspector.ElementsTreeOutline.prototype.populateContextMenu.focusElement):
1454         (WebInspector.ElementsTreeOutline.prototype.populateContextMenu):
1455         (WebInspector.ElementsTreeElement.prototype.onattach):
1456         * inspector/front-end/inspector.css:
1457         (.outline-disclosure li.elements-drag-over .selection):
1458         * inspector/front-end/treeoutline.js:
1459         (TreeOutline.prototype.treeElementFromEvent):
1460
1461 2011-07-06  Andras Becsi  <abecsi@webkit.org>
1462
1463         Fix "warning: a `;' might be needed at the end of action code"
1464
1465         Unreviewed gardening.
1466
1467         No new tests needed.
1468
1469         * css/CSSGrammar.y: Future versions of Bison will not add the ';' so add it.
1470
1471 2011-07-06  Andras Becsi  <abecsi@webkit.org>
1472
1473         [Qt] Revome unused but set shadowBlur variable after r90406.
1474
1475         Unreviewed build fix.
1476
1477         No new tests needed.
1478
1479         * platform/graphics/qt/GraphicsContextQt.cpp:
1480         (WebCore::GraphicsContext::fillPath): Use the GraphicsContext brush.
1481
1482 2011-07-06  Andras Becsi  <abecsi@webkit.org>
1483
1484         [Qt] Remove duplicate entries of ShadowBlur sources from project file.
1485
1486         Rubber-stamped by Csaba Osztrogon√°c.
1487
1488         No new tests needed.
1489
1490         * WebCore.pro: These files were already added in r84410.
1491
1492 2011-07-05  Kentaro Hara  <haraken@google.com>
1493
1494         Trigger a 'change' event whenever selected files are changed
1495         https://bugs.webkit.org/show_bug.cgi?id=63929
1496
1497         Reviewed by Kent Tamura.
1498
1499         Record previously selected files and then compare them with newly selected files.
1500         If the previously selected files and their order are not equal to those of
1501         the newly selected files, we trigger the 'change' event.
1502
1503         Test: fast/forms/file-input-change-event.html
1504
1505         * html/FileInputType.cpp:
1506         (WebCore::FileInputType::filesChosen): Calls dispathChangeEvent() only when the previously selected files are different from the newly selected files
1507
1508 2011-06-29  Kent Tamura  <tkent@chromium.org>
1509
1510         Reviewed by Alexey Proskuryakov.
1511
1512         [Mac] REGRESSION (r88415): Range slider doesn't have focus appearance.
1513         https://bugs.webkit.org/show_bug.cgi?id=63573
1514
1515         * rendering/RenderThemeMac.mm:
1516         (WebCore::RenderThemeMac::paintSliderThumb):
1517         Need to pass the RenderObject of the owner <input> because
1518         updateFocusedState() checks the outline style of the specified
1519         renderer, and we'd like to make a slider thumb reflect the owner
1520         focus style.
1521
1522 2011-07-05  Hans Wennborg  <hans@chromium.org>
1523
1524         [V8][Chromium] Remove use of OwnHandle from V8LocalContext
1525         https://bugs.webkit.org/show_bug.cgi?id=63925
1526
1527         Reviewed by Adam Barth.
1528
1529         Replace the OwnHandle<> member in V8LocalContext with
1530         v8::Persistent<v8::Context>.
1531         The code that used OwnHandle<> would not correctly Dispose
1532         of the Context, which would cause the memory to fill up when creating
1533         and destructing many V8LocalContext objects, such as in the case
1534         of IndexedDB.
1535
1536         * bindings/v8/V8Utilities.cpp:
1537         (WebCore::V8LocalContext::V8LocalContext):
1538         (WebCore::V8LocalContext::~V8LocalContext):
1539         * bindings/v8/V8Utilities.h:
1540
1541 2011-07-05  Igor Oliveira  <igor.oliveira@openbossa.org>
1542
1543         [Qt] Add ShadowBlur support
1544         https://bugs.webkit.org/show_bug.cgi?id=62997
1545
1546         Use ShadowBlur instead of ContextShadow to handle canvas and css shadows. ShadowBlur is
1547         a newer and platform independent shadow implementation.
1548         Qt QPainter does not have support for shadows so is necessary to create a layer support
1549         to draw complex shapes and fonts. The beginShadowLayer creates a temporary shadow buffer
1550         where the canvas can draw onto and endShadowLayer applies the blur filter, colors the
1551         shadow buffer and draw the final shadow to the graphics context.
1552
1553         Reviewed by Andreas Kling.
1554
1555         * WebCore.pro:
1556         * platform/graphics/GraphicsContext.cpp:
1557         * platform/graphics/GraphicsContext.h:
1558         * platform/graphics/ShadowBlur.cpp:
1559         (WebCore::ShadowBlur::ShadowBlur):
1560         (WebCore::ShadowBlur::setShadowValues):
1561         (WebCore::ShadowBlur::updateShadowBlurValues):
1562         (WebCore::ShadowBlur::clear):
1563         (WebCore::ShadowBlur::blurAndColorShadowBuffer):
1564         (WebCore::ShadowBlur::beginShadowLayer):
1565         (WebCore::ShadowBlur::endShadowLayer):
1566         * platform/graphics/ShadowBlur.h:
1567         (WebCore::ShadowBlur::type):
1568         * platform/graphics/qt/ContextShadowQt.cpp: Removed.
1569         * platform/graphics/qt/FontQt.cpp:
1570         (WebCore::drawTextCommon):
1571         (WebCore::Font::drawGlyphs):
1572         * platform/graphics/qt/GraphicsContextQt.cpp:
1573         (WebCore::GraphicsContextPlatformPrivate::mustUseShadowBlur):
1574         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
1575         (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
1576         (WebCore::GraphicsContext::savePlatformState):
1577         (WebCore::GraphicsContext::restorePlatformState):
1578         (WebCore::GraphicsContext::fillPath):
1579         (WebCore::GraphicsContext::strokePath):
1580         (WebCore::GraphicsContext::fillRect):
1581         (WebCore::GraphicsContext::fillRoundedRect):
1582         (WebCore::GraphicsContext::shadowBlur):
1583         (WebCore::GraphicsContext::clipBounds):
1584         (WebCore::GraphicsContext::setPlatformShadow):
1585         (WebCore::GraphicsContext::clearPlatformShadow):
1586         * platform/graphics/qt/ImageQt.cpp:
1587         (WebCore::BitmapImage::draw):
1588         * platform/graphics/qt/StillImageQt.cpp:
1589         (WebCore::StillImage::draw):
1590
1591 2011-07-05  Sam Weinig  <sam@webkit.org>
1592
1593         Null deref accessing CustomEvent.detail
1594         <rdar://problem/9724577>
1595         https://bugs.webkit.org/show_bug.cgi?id=63885
1596
1597         Reviewed by Anders Carlsson.
1598
1599         Test: fast/events/custom-event-uninitialized.html
1600
1601         * bindings/scripts/CodeGeneratorJS.pm:
1602         Guard against uninitialized script value.
1603
1604 2011-07-05  Pratik Solanki  <psolanki@apple.com>
1605
1606         Reviewed by Dan Bernstein.
1607
1608         Coalesce data array into one NSData before calling didReceiveData
1609         https://bugs.webkit.org/show_bug.cgi?id=63916
1610         <rdar://problem/9715181>
1611
1612         Instead of calling didReceiveData multiple times with smaller chunks of data, we merge the
1613         data buffers into one and call it once.
1614
1615         No new tests because the flag isn't enabled yet.
1616
1617         * platform/network/mac/ResourceHandleMac.mm:
1618         (-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]):
1619
1620 2011-07-05  Tamas Czene  <Czene.Tamas@stud.u-szeged.hu>
1621
1622         Reviewed by Simon Fraser.
1623
1624         Remove virtual functions from StyleImage.
1625         https://bugs.webkit.org/show_bug.cgi?id=63909
1626
1627         We can remove the virtual "isChachedImage, isPendingImage, isGeneratedImage" functions to speed up the StyleImage.
1628         Some profile data shows this part is significant, especially in small CSS-based sites.
1629         Removing the virtual functions - removing the calls - makes a small performance progression on this part.
1630
1631         * rendering/style/StyleCachedImage.h:
1632         (WebCore::StyleCachedImage::StyleCachedImage):
1633         * rendering/style/StyleGeneratedImage.h:
1634         (WebCore::StyleGeneratedImage::StyleGeneratedImage):
1635         * rendering/style/StyleImage.h:
1636         (WebCore::StyleImage::isCachedImage):
1637         (WebCore::StyleImage::isPendingImage):
1638         (WebCore::StyleImage::isGeneratedImage):
1639         (WebCore::StyleImage::StyleImage):
1640         * rendering/style/StylePendingImage.h:
1641         (WebCore::StylePendingImage::StylePendingImage):
1642
1643 2011-07-05  Pavel Feldman  <pfeldman@google.com>
1644
1645         Web Inspector: add "element state" setting to the styles section title.
1646         https://bugs.webkit.org/show_bug.cgi?id=63932
1647
1648         Reviewed by Yury Semikhatsky.
1649
1650         * English.lproj/localizedStrings.js:
1651         * WebCore.gypi:
1652         * inspector/front-end/Images/paneElementStateButtons.png: Added.
1653         * inspector/front-end/StylesSidebarPane.js:
1654         (WebInspector.StylesSidebarPane.muteEventListener):
1655         (WebInspector.StylesSidebarPane):
1656         (WebInspector.StylesSidebarPane.prototype.update):
1657         (WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
1658         (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
1659         (WebInspector.StylesSidebarPane.prototype.addBlankSection):
1660         (WebInspector.StylesSidebarPane.prototype.registerShortcuts):
1661         (WebInspector.StylesSidebarPane.prototype._toggleElementStatePane):
1662         (WebInspector.StylesSidebarPane.prototype._createElementStatePane.clickListener):
1663         (WebInspector.StylesSidebarPane.prototype._createElementStatePane.createCheckbox):
1664         (WebInspector.StylesSidebarPane.prototype._createElementStatePane):
1665         * inspector/front-end/WebKit.qrc:
1666         * inspector/front-end/inspector.css:
1667         (.pane > .title > .pane-title-button:active, .pane > .title > .pane-title-button.toggled):
1668         (.pane > .title > .pane-title-button.element-state):
1669         (.styles-element-state-pane):
1670         (.styles-element-state-pane.expanded):
1671         (.styles-element-state-pane > table):
1672         (.styles-element-state-pane input):
1673
1674 2011-06-22  Pavel Podivilov  <podivilov@chromium.org>
1675
1676         Reviewed by Yury Semikhatsky.
1677
1678         Web Inspector: extract duplicated code that deals with source mappings.
1679         https://bugs.webkit.org/show_bug.cgi?id=63139
1680
1681         * inspector/front-end/ConsoleView.js:
1682         (WebInspector.ConsoleMessage.prototype.isEqual):
1683         (WebInspector.ConsoleMessage.prototype.get stackTrace):
1684         * inspector/front-end/DebuggerPresentationModel.js:
1685         (WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation):
1686         (WebInspector.DebuggerPresentationModel.prototype._updateAnchor):
1687         (WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage.didGetUILocation):
1688         (WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage):
1689         (WebInspector.DebuggerPresentationModel.prototype.continueToLine):
1690         (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didGetScriptLocation):
1691         (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
1692         (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.updateSourceFileBreakpointsAndDispatchEvent):
1693         (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didGetUILocation):
1694         (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
1695         (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
1696         (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
1697         (WebInspector.PresenationCallFrame):
1698         (WebInspector.PresenationCallFrame.prototype.sourceLine):
1699
1700 2011-07-05  Ilya Tikhonovsky  <loislo@chromium.org>
1701
1702         Web Inspector: WebInspector frontend reports a protocol error in remote debugging mode.
1703         https://bugs.webkit.org/show_bug.cgi?id=63935
1704
1705         it was error generated for obsolete message "loaded" which was sent from frontend to backend.
1706
1707         Reviewed by Yury Semikhatsky.
1708
1709         * inspector/CodeGeneratorInspector.pm:
1710         * inspector/front-end/inspector.js:
1711         (WebInspector.loaded.WebInspector.socket.onopen):
1712         (WebInspector.loaded):
1713
1714 2011-07-05  Andrey Kosyakov  <caseq@chromium.org>
1715
1716         Web Inspector: [refactoring] remove network-sidebar style, add network-log-grid
1717         https://bugs.webkit.org/show_bug.cgi?id=63913
1718
1719         Reviewed by Yury Semikhatsky.
1720
1721         * inspector/front-end/NetworkPanel.js:
1722         (WebInspector.NetworkPanel):
1723         (WebInspector.NetworkPanel.prototype._createTable):
1724         * inspector/front-end/networkPanel.css:
1725         (.network-log-grid):
1726         (.network-log-grid table.data):
1727         (.network-log-grid.small table.data):
1728         (.network-log-grid td):
1729         (.network-log-grid.small td):
1730         (.network-log-grid th):
1731         (.network-log-grid.small th):
1732         (.network-log-grid th, .network.panel .data-grid th.sort-descending, .network.panel .data-grid th.sort-ascending):
1733         (.network-log-grid .data-container):
1734         (.network-log-grid.small .data-container):
1735         (.network-log-grid select):
1736         (.network-log-grid.small tr.offscreen):
1737         (.network-log-grid tr.offscreen):
1738         (.network-log-grid tr.offscreen td):
1739         (.network-log-grid tr.filler):
1740         (.network-log-grid tr:not(.filler) td.name-column):
1741         (.network.panel:not(.viewing-resource) .network-log-grid td.name-column:hover):
1742         (.network-log-grid td.time-column):
1743         (.network-log-grid.small .network-graph-side):
1744         (.network-log-grid th.sortable:active):
1745         (.network-log-grid tr.selected .network-cell-subtitle):
1746         (.network-log-grid .icon):
1747         (.network-log-grid.small .icon):
1748         (.network-log-grid .network-category-scripts .icon):
1749         (.network-log-grid.small .network-category-scripts .icon):
1750         (.network-log-grid .network-category-documents .icon):
1751         (.network-log-grid.small .network-category-documents .icon):
1752         (.network-log-grid .network-category-stylesheets .icon):
1753         (.network-log-grid.small .network-category-stylesheets .icon):
1754         (.network-log-grid .network-category-images .icon):
1755         (.network-log-grid.small .network-category-images .icon):
1756         (.network-log-grid .image-network-icon-preview):
1757         (.network-log-grid.small .image-network-icon-preview):
1758         (.network-timeline-grid.small .network-event-divider):
1759         (.network-log-grid .resources-dividers):
1760         (.network-log-grid .resources-dividers-label-bar):
1761         (.network-timeline-grid.small .resources-dividers-label-bar):
1762         (.network-timeline-grid .resources-divider-label):
1763         (.network-timeline-grid .resources-dividers-label-bar .resources-divider):
1764         (.network-timeline-grid.small .resources-dividers-label-bar .resources-divider):
1765         (.network-timeline-grid .resources-divider.first .resources-divider-label):
1766         (.network-timeline-grid .resources-dividers-label-bar .resources-divider.first):
1767         (.network-timeline-grid tr.filler td):
1768         (.network-summary-bar td):
1769         (.network.panel.viewing-resource .network-log-grid th):
1770         (.network-log-grid.full-grid-mode .viewer-column):
1771         (.network-log-grid.brief-grid-mode .time-column):
1772         (.network-log-grid.viewing-resource-mode .timeline-column):
1773         (.network.panel .sidebar):
1774         (.network.panel.viewing-resource .network-log-grid .data-grid-resizer):
1775
1776 2011-07-05  Alexandru Chiculita  <achicu@adobe.com>
1777
1778         Reviewed by Simon Hausmann.
1779
1780         [Qt] "cat" is not available when building.
1781         https://bugs.webkit.org/show_bug.cgi?id=63924
1782
1783         Changed 'cat' to 'perl -ne \"print $1\"' because 'cat' is not available on Windows with
1784         MSVC toolchain. It passed the Qt buildbots, because they run with cygwin.
1785
1786         Project file change. No tests needed.
1787
1788         * CodeGenerators.pri:
1789 2011-07-05  Vsevolod Vlasov  <vsevik@chromium.org>
1790
1791         Unreviewed; Qt Linux Release minimal compile fix.
1792
1793         * testing/Internals.h:
1794         (WebCore::Internals::setInspectorResourcesDataSizeLimits):
1795         * testing/Internals.idl:
1796
1797 2011-07-05  Vsevolod Vlasov  <vsevik@chromium.org>
1798
1799         Web Inspector: Show content for plugin requests in network panel.
1800         https://bugs.webkit.org/show_bug.cgi?id=30080
1801
1802         Now the data from didReceiveData callback is passed to inspector.
1803         It is then saved in NetworkResourcesData structure for plugin requests.
1804         Added window.internals.setInspectorResourcesDataSizeLimits() method
1805         for testing replacement logic.
1806
1807         Reviewed by Pavel Feldman.
1808
1809         Tests: http/tests/inspector/network/network-content-replacement-embed.html
1810                http/tests/inspector/network/network-content-replacement-xhr.html
1811                http/tests/inspector/network/network-embed.html
1812
1813         * WebCore.exp.in:
1814         * inspector/InspectorController.cpp:
1815         (WebCore::InspectorController::setResourcesDataSizeLimitsFromInternals):
1816         * inspector/InspectorController.h:
1817         * inspector/InspectorInstrumentation.cpp:
1818         (WebCore::InspectorInstrumentation::didReceiveDataImpl):
1819         * inspector/InspectorInstrumentation.h:
1820         (WebCore::InspectorInstrumentation::didReceiveData):
1821         * inspector/InspectorResourceAgent.cpp:
1822         (WebCore::InspectorResourceAgent::didReceiveResponse):
1823         (WebCore::InspectorResourceAgent::didReceiveData):
1824         (WebCore::InspectorResourceAgent::didFinishLoading):
1825         (WebCore::InspectorResourceAgent::setInitialXHRContent):
1826         (WebCore::InspectorResourceAgent::setResourcesDataSizeLimitsFromInternals):
1827         (WebCore::InspectorResourceAgent::getResourceContent):
1828         * inspector/InspectorResourceAgent.h:
1829         * inspector/NetworkResourcesData.cpp:
1830         (WebCore::NetworkResourcesData::ResourceData::ResourceData):
1831         (WebCore::NetworkResourcesData::ResourceData::setContent):
1832         (WebCore::NetworkResourcesData::ResourceData::purgeContent):
1833         (WebCore::NetworkResourcesData::ResourceData::createDecoder):
1834         (WebCore::NetworkResourcesData::ResourceData::dataLength):
1835         (WebCore::NetworkResourcesData::ResourceData::appendData):
1836         (WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
1837         (WebCore::NetworkResourcesData::NetworkResourcesData):
1838         (WebCore::NetworkResourcesData::responseReceived):
1839         (WebCore::NetworkResourcesData::setResourceContent):
1840         (WebCore::NetworkResourcesData::maybeAddResourceData):
1841         (WebCore::NetworkResourcesData::maybeDecodeDataToContent):
1842         (WebCore::NetworkResourcesData::data):
1843         (WebCore::NetworkResourcesData::clear):
1844         (WebCore::NetworkResourcesData::setResourcesDataSizeLimits):
1845         (WebCore::NetworkResourcesData::ensureNoDataForIdentifier):
1846         (WebCore::NetworkResourcesData::ensureFreeSpace):
1847         * inspector/NetworkResourcesData.h:
1848         (WebCore::NetworkResourcesData::ResourceData::hasContent):
1849         (WebCore::NetworkResourcesData::ResourceData::content):
1850         (WebCore::NetworkResourcesData::ResourceData::decoder):
1851         (WebCore::NetworkResourcesData::ResourceData::buffer):
1852         (WebCore::NetworkResourcesData::ResourceData::setBuffer):
1853         (WebCore::NetworkResourcesData::ResourceData::hasData):
1854         * inspector/front-end/Resource.js:
1855         (WebInspector.Resource.prototype.get contentEncoded):
1856         * inspector/front-end/ResourcePreviewView.js:
1857         (WebInspector.ResourcePreviewView.prototype.contentLoaded):
1858         (WebInspector.ResourcePreviewView.prototype._createEmptyView):
1859         (WebInspector.ResourcePreviewView.prototype._createPreviewView):
1860         * inspector/front-end/ResourceView.js:
1861         (WebInspector.ResourceView.hasTextContent):
1862         * loader/DocumentThreadableLoader.cpp:
1863         (WebCore::DocumentThreadableLoader::didReceiveData):
1864         * loader/FrameLoader.cpp:
1865         (WebCore::FrameLoader::willLoadMediaElementURL):
1866         (WebCore::FrameLoader::commitProvisionalLoad):
1867         (WebCore::FrameLoader::loadResourceSynchronously):
1868         (WebCore::FrameLoader::loadedResourceFromMemoryCache):
1869         * loader/ResourceLoadNotifier.cpp:
1870         (WebCore::ResourceLoadNotifier::didReceiveData):
1871         (WebCore::ResourceLoadNotifier::dispatchDidReceiveData):
1872         (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
1873         * loader/ResourceLoadNotifier.h:
1874         * loader/appcache/ApplicationCacheGroup.cpp:
1875         (WebCore::ApplicationCacheGroup::didReceiveData):
1876         * testing/Internals.cpp:
1877         (WebCore::Internals::setInspectorResourcesDataSizeLimits):
1878         * testing/Internals.h:
1879         * testing/Internals.idl:
1880
1881 2011-07-05  Kent Tamura  <tkent@chromium.org>
1882
1883         Add an assertion that percent height box is unregistered correctly.
1884         https://bugs.webkit.org/show_bug.cgi?id=62792
1885
1886         Reviewed by Hajime Morita.
1887
1888         No new tests. This won't change behavior.
1889
1890         * rendering/RenderBlock.cpp:
1891         (WebCore::RenderBlock::hasPercentHeightDescendant): Added.
1892         * rendering/RenderBlock.h: Declare hasPercentHeightDescendant().
1893         * rendering/RenderBox.cpp:
1894         (WebCore::RenderBox::destroy): Assert !hasPercentHeightDescendant().
1895
1896 2011-07-04  Pavel Feldman  <pfeldman@google.com>
1897
1898         Web Inspector: Enable settings screen with settings for console and elements panels.
1899         https://bugs.webkit.org/show_bug.cgi?id=62853
1900
1901         Reviewed by Yury Semikhatsky.
1902
1903         * English.lproj/localizedStrings.js:
1904         * inspector/front-end/HelpScreen.js:
1905         (WebInspector.HelpScreen.prototype.hide):
1906         * inspector/front-end/SettingsScreen.js:
1907         (WebInspector.SettingsScreen):
1908         (WebInspector.SettingsScreen.prototype._createRadioSetting.clickListener):
1909         (WebInspector.SettingsScreen.prototype._createRadioSetting.get for):
1910         * inspector/front-end/ShortcutsScreen.js:
1911         (WebInspector.ShortcutsScreen.prototype.hide):
1912         * inspector/front-end/StylesSidebarPane.js:
1913         (WebInspector.StylesSidebarPane.prototype._colorFormatSettingChanged):
1914         (WebInspector.StylesSidebarPane.prototype._updateColorFormatFilter.get var):
1915         (WebInspector.StylesSidebarPane.prototype._updateColorFormatFilter):
1916         (WebInspector.StylesSidebarPane.prototype._changeSetting):
1917         (WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
1918         * inspector/front-end/inspector.css:
1919         (#counters):
1920         * inspector/front-end/inspector.js:
1921         (WebInspector._createGlobalStatusBarItems):
1922         (WebInspector._toggleSettings):
1923         (WebInspector._showShortcutsScreen):
1924         (WebInspector._hideShortcutsScreen):
1925         (WebInspector._showSettingsScreen.onhide):
1926         (WebInspector._showSettingsScreen):
1927         (WebInspector._hideSettingsScreen):
1928         (WebInspector.documentKeyDown):
1929
1930 2011-07-05  Shinya Kawanaka  <shinyak@google.com>
1931
1932         Reviewed by Kent Tamura.
1933
1934         The default step is used when attribute step of input[type='number'] is "any".
1935         https://bugs.webkit.org/show_bug.cgi?id=57723
1936
1937         When step is "any", 0 was chosen as step, but this is not intuitive.
1938         So changed to use the default step.
1939
1940         * html/HTMLInputElement.cpp:
1941         (WebCore::HTMLInputElement::getAllowedValueStep):
1942           Calls getAllowedValueStepWithDecimalPlaces with RejectAny.
1943         (WebCore::HTMLInputElement::getAllowedValueStepWithDecimalPlaces):
1944           Takes a new arugument AnyStepHandling. If it is AnyIsDefaultStep, this method
1945           allows "step" attribute to take a value "any" to use the default step as step value.
1946           Otherwise, INVALID_STATE_ERR will be returned if "step" is "any".
1947         (WebCore::HTMLInputElement::applyStep): ditto.
1948         (WebCore::HTMLInputElement::stepUp):
1949           Calls applyStep with RejectAny.
1950         (WebCore::HTMLInputElement::stepDown): ditto.
1951         (WebCore::HTMLInputElement::stepUpFromRenderer):
1952           Removes a check that step is "any". It is checked in getAllowedValueStepWithDecimalPlaces.
1953         * html/HTMLInputElement.h:
1954
1955 2011-07-04  Dominic Cooney   <dominicc@chromium.org>
1956
1957         Simplify <progress> element's isDeterminate logic.
1958         https://bugs.webkit.org/show_bug.cgi?id=63889
1959
1960         Reviewed by Hajime Morita.
1961
1962         Covered by existing tests
1963         fast/dom/HTMLProgressElement/indeterminate-progress-*.html
1964
1965         * html/HTMLProgressElement.cpp:
1966         (WebCore::HTMLProgressElement::position): don't duplicate isDeterminate
1967         (WebCore::HTMLProgressElement::isDeterminate): remove redundant tests
1968         (WebCore::HTMLProgressElement::didElementStateChange): fix formatting
1969         * html/HTMLProgressElement.h:
1970
1971 2011-07-04  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1972
1973         Reviewed by Kent Tamura.
1974
1975         [EFL] Add hasOwnDisabledStateHandlingFor() to RenderThemeEfl
1976         https://bugs.webkit.org/show_bug.cgi?id=63884
1977
1978         As MediaControlRootElement decides whether it will display timeline
1979         according to the return value of RenderTheme's hasOwnDisabledStateHandlingFor(),
1980         RenderThemeEfl has to implement this function.
1981
1982         Existing tests cover the visibility of the controls.
1983
1984         * platform/efl/RenderThemeEfl.h:
1985         (WebCore::RenderThemeEfl::hasOwnDisabledStateHandlingFor):
1986
1987 2011-07-04  Kent Tamura  <tkent@chromium.org>
1988
1989         REGRESSION (r87067): Text overflows from short height text field.
1990         https://bugs.webkit.org/show_bug.cgi?id=61768
1991
1992         Reviewed by Dimitri Glazkov.
1993
1994         Since r87067, the RenderStyle for the inner text element is reset
1995         by the value update, but the renderer for the inner text element
1996         keeps to have metrics calculated by the previous style. So
1997         RenderTextControlSingleLine::layout() didn't set a desired height
1998         to the renderer for the inner text element.
1999
2000         This patch changes the style creation code so that it has the
2001         desired height initially.
2002
2003         Test: fast/forms/textfield-overflow-by-value-update.html
2004
2005         * rendering/RenderTextControlSingleLine.cpp:
2006         (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
2007         Initialize m_desiredInnerTextHeight.
2008         (WebCore::RenderTextControlSingleLine::layout):
2009         Update m_desiredInnerTextHeight.
2010         (WebCore::RenderTextControlSingleLine::styleDidChange):
2011         Reset m_desiredInnerTextHeight.
2012         (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
2013         Sets the height if m_desiredInnerTextHeight has a concrete value.
2014         * rendering/RenderTextControlSingleLine.h:
2015         Declare m_desiredInnerTextHeight.
2016
2017 2011-07-04  MORITA Hajime  <morrita@google.com>
2018
2019         Accessing ShadowRoot.nodeList causes an assertion failure.
2020         http://webkit.org/b/63798
2021         
2022         The TreeScope destructor did clear the reference to TreeScope, 
2023         then the Node destructor accessing treeScope(), which results 
2024         an inconsistent state during the NodeList cache cleanup.
2025
2026         This change clears NodeList cache during the TreeScope destructor.
2027         The Node destructor no longer does problematic NodeList cache
2028         manipulation.
2029
2030         Test: fast/dom/shadow/shadow-root-node-list.html
2031
2032         Reviewed by Dimitri Glazkov.
2033         
2034         * dom/Node.cpp:
2035         (WebCore::Node::~Node):
2036         (WebCore::Node::clearRareData):
2037         * dom/Node.h:
2038         * dom/TreeScope.cpp:
2039         (WebCore::TreeScope::~TreeScope):
2040
2041 2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>
2042
2043         ResourceLoadNotifier::dispatchWillSendRequest should not compare StringImpl directly
2044         https://bugs.webkit.org/show_bug.cgi?id=63873
2045
2046         Reviewed by Alexey Proskuryakov.
2047
2048         * loader/ResourceLoadNotifier.cpp:
2049         (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
2050
2051 2011-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>
2052
2053         Unreviewed, rolling out r90373.
2054         http://trac.webkit.org/changeset/90373
2055         https://bugs.webkit.org/show_bug.cgi?id=63917
2056
2057         Breaks Qt Linux Release minimal (Requested by vsevik on
2058         #webkit).
2059
2060         * WebCore.exp.in:
2061         * inspector/InspectorController.cpp:
2062         * inspector/InspectorController.h:
2063         * inspector/InspectorInstrumentation.cpp:
2064         (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
2065         * inspector/InspectorInstrumentation.h:
2066         (WebCore::InspectorInstrumentation::didReceiveContentLength):
2067         * inspector/InspectorResourceAgent.cpp:
2068         (WebCore::InspectorResourceAgent::didReceiveResponse):
2069         (WebCore::InspectorResourceAgent::didReceiveContentLength):
2070         (WebCore::InspectorResourceAgent::didFinishLoading):
2071         (WebCore::InspectorResourceAgent::setInitialXHRContent):
2072         (WebCore::InspectorResourceAgent::getResourceContent):
2073         * inspector/InspectorResourceAgent.h:
2074         * inspector/NetworkResourcesData.cpp:
2075         (WebCore::NetworkResourcesData::ResourceData::ResourceData):
2076         (WebCore::NetworkResourcesData::ResourceData::content):
2077         (WebCore::NetworkResourcesData::ResourceData::appendContent):
2078         (WebCore::NetworkResourcesData::ResourceData::purgeContent):
2079         (WebCore::NetworkResourcesData::NetworkResourcesData):
2080         (WebCore::NetworkResourcesData::responseReceived):
2081         (WebCore::NetworkResourcesData::addResourceContent):
2082         (WebCore::NetworkResourcesData::data):
2083         (WebCore::NetworkResourcesData::clear):
2084         (WebCore::NetworkResourcesData::ensureNoDataForIdentifier):
2085         (WebCore::NetworkResourcesData::ensureFreeSpace):
2086         * inspector/NetworkResourcesData.h:
2087         (WebCore::NetworkResourcesData::ResourceData::hasContent):
2088         (WebCore::NetworkResourcesData::ResourceData::setIsContentPurged):
2089         (WebCore::NetworkResourcesData::ResourceData::textEncodingName):
2090         (WebCore::NetworkResourcesData::ResourceData::setTextEncodingName):
2091         * inspector/front-end/Resource.js:
2092         * inspector/front-end/ResourcePreviewView.js:
2093         (WebInspector.ResourcePreviewView.prototype.contentLoaded):
2094         (WebInspector.ResourcePreviewView.prototype._createInnerView):
2095         * inspector/front-end/ResourceView.js:
2096         (WebInspector.ResourceView.hasTextContent):
2097         * loader/DocumentThreadableLoader.cpp:
2098         (WebCore::DocumentThreadableLoader::didReceiveData):
2099         * loader/FrameLoader.cpp:
2100         (WebCore::FrameLoader::willLoadMediaElementURL):
2101         (WebCore::FrameLoader::commitProvisionalLoad):
2102         (WebCore::FrameLoader::loadResourceSynchronously):
2103         (WebCore::FrameLoader::loadedResourceFromMemoryCache):
2104         * loader/ResourceLoadNotifier.cpp:
2105         (WebCore::ResourceLoadNotifier::didReceiveData):
2106         (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
2107         (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
2108         * loader/ResourceLoadNotifier.h:
2109         * loader/appcache/ApplicationCacheGroup.cpp:
2110         (WebCore::ApplicationCacheGroup::didReceiveData):
2111         * testing/Internals.cpp:
2112         * testing/Internals.h:
2113         * testing/Internals.idl:
2114
2115 2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>
2116
2117         Web Inspector: Show content for plugin requests in network panel.
2118         https://bugs.webkit.org/show_bug.cgi?id=30080
2119
2120         Reviewed by Pavel Feldman.
2121
2122         Tests: http/tests/inspector/network/network-content-replacement-embed.html
2123                http/tests/inspector/network/network-content-replacement-xhr.html
2124                http/tests/inspector/network/network-embed.html
2125
2126         * WebCore.exp.in:
2127         * inspector/InspectorController.cpp:
2128         (WebCore::InspectorController::setResourcesDataSizeLimitsFromInternals):
2129         * inspector/InspectorController.h:
2130         * inspector/InspectorInstrumentation.cpp:
2131         (WebCore::InspectorInstrumentation::didReceiveDataImpl):
2132         * inspector/InspectorInstrumentation.h:
2133         (WebCore::InspectorInstrumentation::didReceiveData):
2134         * inspector/InspectorResourceAgent.cpp:
2135         (WebCore::InspectorResourceAgent::didReceiveResponse):
2136         (WebCore::InspectorResourceAgent::didReceiveData):
2137         (WebCore::InspectorResourceAgent::didFinishLoading):
2138         (WebCore::InspectorResourceAgent::setInitialXHRContent):
2139         (WebCore::InspectorResourceAgent::setResourcesDataSizeLimitsFromInternals):
2140         (WebCore::InspectorResourceAgent::getResourceContent):
2141         * inspector/InspectorResourceAgent.h:
2142         * inspector/NetworkResourcesData.cpp:
2143         (WebCore::NetworkResourcesData::ResourceData::ResourceData):
2144         (WebCore::NetworkResourcesData::ResourceData::setContent):
2145         (WebCore::NetworkResourcesData::ResourceData::purgeContent):
2146         (WebCore::NetworkResourcesData::ResourceData::createDecoder):
2147         (WebCore::NetworkResourcesData::ResourceData::dataLength):
2148         (WebCore::NetworkResourcesData::ResourceData::appendData):
2149         (WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
2150         (WebCore::NetworkResourcesData::NetworkResourcesData):
2151         (WebCore::NetworkResourcesData::responseReceived):
2152         (WebCore::NetworkResourcesData::setResourceContent):
2153         (WebCore::NetworkResourcesData::maybeAddResourceData):
2154         (WebCore::NetworkResourcesData::maybeDecodeDataToContent):
2155         (WebCore::NetworkResourcesData::data):
2156         (WebCore::NetworkResourcesData::clear):
2157         (WebCore::NetworkResourcesData::setResourcesDataSizeLimits):
2158         (WebCore::NetworkResourcesData::ensureNoDataForIdentifier):
2159         (WebCore::NetworkResourcesData::ensureFreeSpace):
2160         * inspector/NetworkResourcesData.h:
2161         (WebCore::NetworkResourcesData::ResourceData::hasContent):
2162         (WebCore::NetworkResourcesData::ResourceData::content):
2163         (WebCore::NetworkResourcesData::ResourceData::decoder):
2164         (WebCore::NetworkResourcesData::ResourceData::buffer):
2165         (WebCore::NetworkResourcesData::ResourceData::setBuffer):
2166         (WebCore::NetworkResourcesData::ResourceData::hasData):
2167         * inspector/front-end/Resource.js:
2168         (WebInspector.Resource.prototype.get contentEncoded):
2169         * inspector/front-end/ResourcePreviewView.js:
2170         (WebInspector.ResourcePreviewView.prototype.contentLoaded):
2171         (WebInspector.ResourcePreviewView.prototype._createEmptyView):
2172         (WebInspector.ResourcePreviewView.prototype._createPreviewView):
2173         * inspector/front-end/ResourceView.js:
2174         (WebInspector.ResourceView.hasTextContent):
2175         * loader/DocumentThreadableLoader.cpp:
2176         (WebCore::DocumentThreadableLoader::didReceiveData):
2177         * loader/FrameLoader.cpp:
2178         (WebCore::FrameLoader::willLoadMediaElementURL):
2179         (WebCore::FrameLoader::commitProvisionalLoad):
2180         (WebCore::FrameLoader::loadResourceSynchronously):
2181         (WebCore::FrameLoader::loadedResourceFromMemoryCache):
2182         * loader/ResourceLoadNotifier.cpp:
2183         (WebCore::ResourceLoadNotifier::didReceiveData):
2184         (WebCore::ResourceLoadNotifier::dispatchDidReceiveData):
2185         (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
2186         * loader/ResourceLoadNotifier.h:
2187         * loader/appcache/ApplicationCacheGroup.cpp:
2188         (WebCore::ApplicationCacheGroup::didReceiveData):
2189         * testing/Internals.cpp:
2190         (WebCore::Internals::setInspectorResourcesDataSizeLimits):
2191         * testing/Internals.h:
2192         * testing/Internals.idl:
2193
2194 2011-07-04  Jeff Timanus  <twiz@chromium.org>
2195
2196         Reviewed by Stephen White.
2197
2198         Prevent calls to GrapicsContext3D::deleteTexture with id 0 in DrawingBuffer::clear().
2199         https://bugs.webkit.org/show_bug.cgi?id=63756
2200
2201         * platform/graphics/gpu/DrawingBuffer.cpp:
2202         (WebCore::DrawingBuffer::clear):
2203
2204 2011-07-04  Martin Robinson  <mrobinson@igalia.com>
2205
2206         Reviewed by Andreas Kling.
2207
2208         [GTK] r90148 did not apply to X11 platforms in WebKit1
2209         https://bugs.webkit.org/show_bug.cgi?id=63862
2210
2211         Correct the guard for an X11 specific piece of code. TARGET(X11) not
2212         defined for the GTK+ port.
2213
2214         No new tests. This is covered by an existing test.
2215
2216         * plugins/npapi.cpp: Correct the X11 guard.
2217         (NPN_InvalidateRect):
2218
2219 2011-07-04  Pavel Feldman  <pfeldman@google.com>
2220
2221         Web Inspector: implement settings panel.
2222         https://bugs.webkit.org/show_bug.cgi?id=63907
2223
2224         Reviewed by Yury Semikhatsky.
2225
2226         * English.lproj/localizedStrings.js:
2227         * WebCore.gypi:
2228         * WebCore.vcproj/WebCore.vcproj:
2229         * inspector/front-end/BreakpointsSidebarPane.js:
2230         (WebInspector.XHRBreakpointsSidebarPane.prototype._saveBreakpoints):
2231         (WebInspector.EventListenerBreakpointsSidebarPane.prototype._saveBreakpoints):
2232         * inspector/front-end/ConsoleView.js:
2233         (WebInspector.ConsoleView):
2234         (WebInspector.ConsoleView.prototype._handleContextMenuEvent.monitoringXHRItemAction):
2235         (WebInspector.ConsoleView.prototype._handleContextMenuEvent.get preserveLogItemAction):
2236         (WebInspector.ConsoleView.prototype._monitoringXHREnabledSettingChanged):
2237         (WebInspector.ConsoleView.prototype._registerShortcuts):
2238         * inspector/front-end/DOMBreakpointsSidebarPane.js:
2239         (WebInspector.DOMBreakpointsSidebarPane.prototype._saveBreakpoints):
2240         * inspector/front-end/DebuggerPresentationModel.js:
2241         (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
2242         * inspector/front-end/ElementsPanel.js:
2243         (WebInspector.ElementsPanel.prototype._contextMenuEventFired):
2244         (WebInspector.ElementsPanel.prototype._domWordWrapSettingChanged):
2245         (WebInspector.ElementsPanel.prototype._registerShortcuts):
2246         * inspector/front-end/EventListenersSidebarPane.js:
2247         (WebInspector.EventListenersSidebarPane.prototype):
2248         ():
2249         * inspector/front-end/HelpScreen.js:
2250         (WebInspector.HelpScreen):
2251         (WebInspector.HelpScreen.prototype.show):
2252         (WebInspector.HelpScreen.prototype.hide):
2253         (WebInspector.HelpScreen.prototype._onKeyDown):
2254         * inspector/front-end/NetworkItemView.js:
2255         * inspector/front-end/NetworkPanel.js:
2256         * inspector/front-end/Panel.js:
2257         (WebInspector.Panel.prototype.saveSidebarWidth):
2258         * inspector/front-end/ProfilesPanel.js:
2259         * inspector/front-end/ResourcesPanel.js:
2260         (WebInspector.BaseStorageTreeElement.prototype.onselect):
2261         (WebInspector.StorageCategoryTreeElement.prototype.onexpand):
2262         (WebInspector.StorageCategoryTreeElement.prototype.set oncollapse):
2263         * inspector/front-end/ScriptsPanel.js:
2264         (WebInspector.ScriptsPanel.prototype._sourceFileAdded.get if):
2265         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
2266         (WebInspector.ScriptsPanel.prototype._createSidebarButtonAndRegisterShortcuts):
2267         * inspector/front-end/Settings.js:
2268         (WebInspector.Settings):
2269         (WebInspector.Settings.prototype.installApplicationSetting):
2270         (WebInspector.Setting):
2271         (WebInspector.Setting.prototype.addChangeListener):
2272         (WebInspector.Setting.prototype.removeChangeListener):
2273         (WebInspector.Setting.prototype.get var):
2274         (WebInspector.Setting.prototype):
2275         (WebInspector.Setting.prototype.set if):
2276         * inspector/front-end/SettingsScreen.js: Added.
2277         (WebInspector.SettingsScreen):
2278         (WebInspector.SettingsScreen.prototype._appendSection):
2279         (WebInspector.SettingsScreen.prototype._columnElement):
2280         (WebInspector.SettingsScreen.prototype._createCheckboxSetting.get listener):
2281         (WebInspector.SettingsScreen.prototype._createRadioSetting):
2282         * inspector/front-end/ShortcutsScreen.js: Renamed from Source/WebCore/inspector/front-end/ShortcutsHelp.js.
2283         (WebInspector.ShortcutsScreen):
2284         * inspector/front-end/StylesSidebarPane.js:
2285         (WebInspector.StylesSidebarPane.prototype.registerShortcuts):
2286         * inspector/front-end/WatchExpressionsSidebarPane.js:
2287         * inspector/front-end/WebKit.qrc:
2288         * inspector/front-end/helpScreen.css:
2289         (.help-window-main):
2290         (body.attached .help-window-main):
2291         (.help-window-caption):
2292         (body.attached .help-window-caption):
2293         (.help-content):
2294         (.help-close-button):
2295         (body.attached .help-close-button):
2296         (body.attached .help-content):
2297         (.help-table):
2298         (body.platform-mac .help-key):
2299         (.help-combine-keys):
2300         (.help-content p):
2301         (.help-content fieldset):
2302         (.help-content fieldset p):
2303         (.help-content p.help-section):
2304         (.help-section-title):
2305         (.help-content input[type=checkbox]):
2306         * inspector/front-end/inspector.css:
2307         (button.settings-status-bar-item):
2308         (.settings-status-bar-item .glyph):
2309         * inspector/front-end/inspector.html:
2310         * inspector/front-end/inspector.js:
2311         (WebInspector._createGlobalStatusBarItems):
2312         (WebInspector._toggleAttach):
2313         (WebInspector._toggleSettings):
2314         (WebInspector._registerShortcuts):
2315         (WebInspector.documentKeyDown):
2316
2317 2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>
2318
2319         Web Inspector: Resources loaded to Resources Panel from InspectorPageAgent do not have mime type set.
2320         https://bugs.webkit.org/show_bug.cgi?id=63701
2321
2322         Pass cachedResource/documentLoader mimeType from InspectorPageAgent to frontend.
2323
2324         Reviewed by Yury Semikhatsky.
2325
2326         Test: http/tests/inspector/resource-tree/resource-tree-mimetype.html
2327
2328         * inspector/Inspector.json:
2329         * inspector/InspectorPageAgent.cpp:
2330         (WebCore::InspectorPageAgent::buildObjectForFrame):
2331         (WebCore::InspectorPageAgent::buildObjectForFrameTree):
2332         * inspector/front-end/ResourceTreeModel.js:
2333         (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
2334         (WebInspector.ResourceTreeModel.prototype._createResource):
2335
2336 2011-07-04  Yury Semikhatsky  <yurys@chromium.org>
2337
2338         Web Inspector: repeated message counter should be aligned with other message icons
2339         https://bugs.webkit.org/show_bug.cgi?id=63901
2340
2341         Reviewed by Pavel Feldman.
2342
2343         * inspector/front-end/inspector.css:
2344         (.console-message .bubble):
2345
2346 2011-07-04  Alexander Pavlov  <apavlov@chromium.org>
2347
2348         Reviewed by Pavel Feldman.
2349
2350         Web Inspector: Adding new CSS rules should be more discoverable in the UI
2351         https://bugs.webkit.org/show_bug.cgi?id=63803
2352
2353         * inspector/front-end/StylesSidebarPane.js:
2354         (WebInspector.StylesSidebarPane.prototype._createNewRule):
2355
2356 2011-07-04  Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
2357
2358         [Qt] Fixing build with --media-stream flag enabled
2359         https://bugs.webkit.org/show_bug.cgi?id=63831
2360
2361         Reviewed by Benjamin Poulain.
2362
2363         * features.pri: Adding support to ENABLE_MEDIA_STREAM flag.
2364
2365 2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>
2366
2367         Reviewed by Yury Semikhatsky.
2368
2369         Web Inspector: Update network resource url from response data.
2370         https://bugs.webkit.org/show_bug.cgi?id=63736
2371
2372         * inspector/Inspector.json:
2373         * inspector/InspectorResourceAgent.cpp:
2374         (WebCore::buildObjectForResourceResponse):
2375         * inspector/front-end/NetworkManager.js:
2376         (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
2377
2378 2011-07-04  Andrey Kosyakov  <caseq@chromium.org>
2379
2380         Reviewed by Yury Semikhatsky.
2381
2382         Web Inspector: [Extensions API] audit formatter names should begin with create
2383         https://bugs.webkit.org/show_bug.cgi?id=63802
2384
2385         * inspector/front-end/ExtensionAPI.js:
2386         (WebInspector.injectedExtensionAPI.AuditResultImpl):
2387
2388 2011-07-03  Dominic Cooney  <dominicc@chromium.org>
2389
2390         The value property of an indeterminate progress element should be zero
2391         https://bugs.webkit.org/show_bug.cgi?id=63861
2392
2393         Reviewed by Kent Tamura.
2394
2395         Test: fast/dom/HTMLProgressElement/set-progress-properties.html
2396
2397         * html/HTMLProgressElement.cpp:
2398         (WebCore::HTMLProgressElement::value):
2399
2400 2011-07-03  Robert Hogan  <robert@webkit.org>
2401
2402         Restore scroll position on page reloads scheduled by <meta http-equiv="refresh" content="XX"/>
2403         https://bugs.webkit.org/show_bug.cgi?id=62482
2404
2405         If a <meta http-equiv="refresh"> directive schedules a page reload rather than
2406         a redirect restore the scroll position after the reload. Do the same on location.reload().
2407
2408         Reviewed by Adam Barth.
2409
2410         Tests: http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html
2411                http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html
2412                http/tests/navigation/scrollstate-after-http-equiv-refresh.html
2413                http/tests/navigation/scrollstate-after-location-reload.html
2414
2415         * loader/FrameLoader.cpp:
2416         (WebCore::FrameLoader::loadURL):
2417         Only make the load FrameLoadTypeSame if it has not already been set as FrameLoadTypeReload*.
2418         FrameLoadTypeReload* loads are set through http-equiv refreshes, manual reloads, or location.reload()
2419         and honour the user's scroll position in the frame. A FrameLoadTypeSame is for when the frame is loading
2420         the same page again, e.g. by clicking a link.
2421
2422         * loader/NavigationScheduler.cpp:
2423         (WebCore::ScheduledRedirect::fire): Tell FrameLoader::changeLocation() if this is a reload.
2424
2425 2011-07-03  Dirk Schulze  <krit@webkit.org>
2426
2427         SVGAnimateTransform accumulate=sum restarts on every repeat
2428         https://bugs.webkit.org/show_bug.cgi?id=63876
2429
2430         Reviewed by Nikolas Zimmermann.
2431         
2432         We applied transforms from previous animation repeats to a transform list. The problem is, that we calculated the current
2433         transform based on the percentage of the current repeat count. This causes an animation starting from scale level 0
2434         on every repeat. Now I add the repeat count to the current percentage, so that the distance calculation starts from 100% on
2435         the first repeat, from 200% on the second and so on.
2436
2437         Test: svg/animations/svgtransform-animation-1.html
2438
2439         * svg/SVGAnimateTransformElement.cpp:
2440         (WebCore::SVGAnimateTransformElement::calculateAnimatedValue):
2441
2442 2011-07-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2443
2444         Unreviewed, rolling out r90342.
2445         http://trac.webkit.org/changeset/90342
2446         https://bugs.webkit.org/show_bug.cgi?id=63875
2447
2448         Newly added tests fail on Mac, GTK, and Win7 (Requested by
2449         abarth on #webkit).
2450
2451         * loader/FrameLoader.cpp:
2452         (WebCore::FrameLoader::loadURL):
2453         * loader/NavigationScheduler.cpp:
2454
2455 2011-07-03  Robert Hogan  <robert@webkit.org>
2456
2457         Restore scroll position on page reloads scheduled by <meta http-equiv="refresh" content="XX"/>
2458         https://bugs.webkit.org/show_bug.cgi?id=62482
2459
2460         If a <meta http-equiv="refresh"> directive schedules a page reload rather than
2461         a redirect restore the scroll position after the reload. Do the same on location.reload().
2462
2463         Reviewed by Adam Barth.
2464
2465         Tests: http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html
2466                http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html
2467                http/tests/navigation/scrollstate-after-http-equiv-refresh.html
2468                http/tests/navigation/scrollstate-after-location-reload.html
2469
2470         * loader/FrameLoader.cpp:
2471         (WebCore::FrameLoader::loadURL):
2472         Only make the load FrameLoadTypeSame if it has not already been set as FrameLoadTypeReload*.
2473         FrameLoadTypeReload* loads are set through http-equiv refreshes, manual reloads, or location.reload()
2474         and honour the user's scroll position in the frame. A FrameLoadTypeSame is for when the frame is loading
2475         the same page again, e.g. by clicking a link.
2476
2477         * loader/NavigationScheduler.cpp:
2478         (WebCore::ScheduledRedirect::fire): Tell FrameLoader::changeLocation() if this is a reload.
2479
2480 2011-04-02  Robert Hogan  <robert@webkit.org>
2481
2482         Reviewed by Benjamin Poulain.
2483
2484         [Qt] Support third-party cookie policy for Qt clients
2485         https://bugs.webkit.org/show_bug.cgi?id=45455
2486
2487         Identifying third-party cookies is facilitated by API new to QUrl from
2488         Qt 4.8: QUrl::topLevelDomain(). This API uses the Mozilla public suffix
2489         list to determine the top-level registry-controlled domain of the Url.
2490
2491         See also: http://gitorious.org/qt/qt/merge_requests/1205
2492                    (commit 154402f56dcf8303a6ce601a52215226af8d31ba)
2493                   http://bugreports.qt.nokia.com/browse/QTBUG-13601
2494
2495         Test: http/tests/cookies/strict-third-party-cookie-blocking.html
2496
2497         * WebCore.pro:
2498         * platform/network/qt/ResourceRequestQt.cpp:
2499         (WebCore::ResourceRequest::toNetworkRequest):
2500         * platform/qt/CookieJarQt.cpp:
2501         (WebCore::setCookies):
2502         (WebCore::cookies):
2503         * platform/qt/ThirdPartyCookiesQt.cpp: Added.
2504         (WebCore::cookieJar):
2505         (WebCore::isFirstPartyCookie):
2506         (WebCore::cookieAllowed):
2507         (WebCore::allowThirdPartyCookies):
2508         * platform/qt/ThirdPartyCookiesQt.h: Added.
2509
2510 2011-07-03  Vsevolod Vlasov  <vsevik@chromium.org>
2511
2512         Reviewed by Alexey Proskuryakov.
2513
2514         Web Inspector: Preflight OPTIONS requests are not shown on network panel for asynchronous XHRs.
2515         https://bugs.webkit.org/show_bug.cgi?id=63712
2516
2517         Added InspectorInstrumentation calls to preflight OPTIONS requests callbacks in DocumentThreadableLoader.
2518
2519         * loader/DocumentThreadableLoader.cpp:
2520         (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
2521         (WebCore::DocumentThreadableLoader::didReceiveResponse):
2522         (WebCore::DocumentThreadableLoader::didReceiveData):
2523         (WebCore::DocumentThreadableLoader::didFinishLoading):
2524         (WebCore::DocumentThreadableLoader::didFail):
2525         (WebCore::DocumentThreadableLoader::loadRequest):
2526         * loader/DocumentThreadableLoader.h:
2527
2528 2011-06-23  Robert Hogan  <robert@webkit.org>
2529
2530         Reviewed by Simon Hausmann.
2531
2532         [Qt] Windowless Plugins : <input> cursor blinks even after transferring focus to plugin
2533         https://bugs.webkit.org/show_bug.cgi?id=30355
2534
2535         Test: plugins/mouse-click-plugin-clears-selection.html
2536
2537         PluginView needs to use page->focusController()->setFocusedNode() when focusing a plugin
2538         in order to clear the FrameSelection in the currently focused node. In its platform-specific
2539         code Chromium already does this (WebPluginContainerImpl.cpp).
2540
2541         * WebCore.exp.in: Add symbol for FocusController::setFocusedNode
2542         * plugins/PluginView.cpp:
2543         (WebCore::PluginView::focusPluginElement): Using FocusController::setFocusedNode() makes
2544                                                    the call to FocusController:setFocusedFrame() and Document::setFocusedNode()
2545                                                    redundant, since it calls both.
2546
2547 2011-07-01  Michael Nordman  <michaeln@google.com>
2548
2549         Reviewed by Darin Fisher.
2550
2551         [Chromium] FileSystem API can be used to learn about installed software on the user's computer.
2552         Added a new MIMETypeRegistry method to return a type based on a well known set of mappings
2553         without consulting the OS/registry.
2554         https://bugs.webkit.org/show_bug.cgi?id=63220
2555
2556         No new tests, existing layout tests that invoke file.type apply.
2557
2558         * fileapi/File.cpp: Refactored the factory methods.
2559         (WebCore::createBlobDataForFileWithType):
2560         (WebCore::createBlobDataForFile):
2561         (WebCore::createBlobDataForFileSystemFile):
2562         (WebCore::File::File):
2563         * platform/MIMETypeRegistry.cpp: Added getWellKnownMIMETypeForExtension() method.
2564         (WebCore::mediaMIMETypeMap):
2565         (WebCore::findMimeType):
2566         (WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension):
2567         * platform/MIMETypeRegistry.h:
2568         * platform/chromium/MIMETypeRegistryChromium.cpp: Added getWellKnownMIMETypeForExtension() method.
2569         (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
2570         (WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension):
2571         (WebCore::findMimeType):
2572         * platform/chromium/PlatformBridge.h:
2573
2574 2011-07-01  Tim Horton  <timothy_horton@apple.com>
2575
2576         Reviewed by Darin Adler.
2577
2578         SVG data:image/svg+xml;base64 URLs inside CSS throw mime type warning
2579         https://bugs.webkit.org/show_bug.cgi?id=54325
2580         
2581         Add image/svg+xml to the list of acceptable MIME types for the Image type.
2582
2583         * inspector/front-end/inspector.js:
2584         (WebInspector):
2585
2586 2011-07-01  Tim Horton  <timothy_horton@apple.com>
2587
2588         Reviewed by Darin Adler.
2589
2590         Errors encountered within SVG documents should be reported to the console
2591         https://bugs.webkit.org/show_bug.cgi?id=62599
2592
2593         Add SVGElement::reportAttributeParsingError, which will
2594         write a Web Inspector console message if passed an SVGParsingError
2595         and the attribute which was being applied, only in the case where
2596         there is actually an error.
2597
2598         Include the SVG document's URI when writing to the Web Inspector
2599         console, so that the UI displays both the filename and the line number.
2600
2601         * svg/SVGDocumentExtensions.cpp:
2602         (WebCore::reportMessage):
2603         * svg/SVGElement.cpp:
2604         (WebCore::SVGElement::reportAttributeParsingError):
2605         * svg/SVGElement.h:
2606
2607 2011-07-01  Scott Byer  <scottbyer@chromium.org>
2608
2609         Reviewed by Adam Barth.
2610
2611         Smooth scrolling fixes
2612         https://bugs.webkit.org/show_bug.cgi?id=63770
2613
2614         Tests: Chromium webkit_unit_tests ScrollAnimatorNoneTest.ScrollWheelTrace and .LinuxTrackPadTrace
2615
2616         Fix issues found in manual testing; distill the traces into unit tests. Fix the issues the tests exposed in the
2617         scroll animation code.
2618
2619         * platform/ScrollAnimatorNone.cpp:
2620         (WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
2621         (WebCore::ScrollAnimatorNone::scroll):
2622
2623 2011-07-01  Levi Weintraub  <leviw@chromium.org>
2624
2625         Switch primary virtual layout functions to new layout types
2626         https://bugs.webkit.org/show_bug.cgi?id=63852
2627
2628         Reviewed by Eric Seidel.
2629
2630         Switching the primary overloaded layout functions over to the new layout unit abstraction.
2631
2632         No new tests, no functionality changes.
2633
2634         * html/shadow/MediaControlElements.cpp:
2635         (WebCore::RenderMediaVolumeSliderContainer::layout):
2636         * page/FrameView.cpp:
2637         (WebCore::FrameView::layout):
2638         * rendering/AutoTableLayout.cpp:
2639         (WebCore::AutoTableLayout::layout):
2640         * rendering/FixedTableLayout.cpp:
2641         (WebCore::FixedTableLayout::layout):
2642         * rendering/RenderBox.cpp:
2643         (WebCore::RenderBox::layout):
2644         * rendering/RenderFrameSet.cpp:
2645         (WebCore::RenderFrameSet::layout):
2646         * rendering/RenderMedia.cpp:
2647         (WebCore::RenderMedia::layout):
2648         * rendering/RenderRubyRun.cpp:
2649         (WebCore::RenderRubyRun::layout):
2650         * rendering/RenderScrollbarPart.cpp:
2651         (WebCore::RenderScrollbarPart::layout):
2652         * rendering/RenderSlider.cpp:
2653         (WebCore::RenderSlider::layout):
2654         * rendering/RenderTable.cpp:
2655         (WebCore::RenderTable::layout):
2656         * rendering/RenderTableRow.cpp:
2657         (WebCore::RenderTableRow::layout):
2658         * rendering/RenderTableSection.cpp:
2659         (WebCore::RenderTableSection::layout):
2660         * rendering/RenderTextControlSingleLine.cpp:
2661         (WebCore::RenderTextControlSingleLine::layout):
2662         * rendering/RenderView.cpp:
2663         (WebCore::RenderView::layout):
2664         * rendering/RenderView.h:
2665         (WebCore::RenderView::layoutDelta):
2666         (WebCore::RenderView::addLayoutDelta):
2667         * rendering/mathml/RenderMathMLRoot.cpp:
2668         (WebCore::RenderMathMLRoot::layout):
2669         * rendering/mathml/RenderMathMLRow.cpp:
2670         (WebCore::RenderMathMLRow::layout):
2671         * rendering/mathml/RenderMathMLSquareRoot.cpp:
2672         (WebCore::RenderMathMLSquareRoot::layout):
2673         * rendering/mathml/RenderMathMLSubSup.cpp:
2674         (WebCore::RenderMathMLSubSup::layout):
2675         * rendering/mathml/RenderMathMLUnderOver.cpp:
2676         (WebCore::RenderMathMLUnderOver::layout):
2677
2678 2011-07-01  Sam Weinig  <sam@webkit.org>
2679
2680         Reduce parser nesting cap to 512
2681         https://bugs.webkit.org/show_bug.cgi?id=63856
2682
2683         Reviewed by Dan Bernstein.
2684
2685         Given Firefox's cap of 200, our cap of 2048 seemed a little excessive. Lower
2686         the nesting cap to 512 to cover more cases where rending recursion was biting us.
2687
2688         * page/Settings.h:
2689         Reduce the nesting cap to 512.
2690
2691 2011-07-01  Darin Adler  <darin@apple.com>
2692
2693         Add change accidentally left out of last commit.
2694
2695         * rendering/RenderLayerBacking.cpp:
2696         (WebCore::RenderLayerBacking::updateContentsScale): Multiply in the
2697         backing scale.
2698
2699 2011-07-01  Darin Adler  <darin@apple.com>
2700
2701         Consider backing scale when setting up graphics layers
2702         https://bugs.webkit.org/show_bug.cgi?id=63848
2703
2704         Reviewed by Simon Fraser.
2705
2706         * platform/graphics/ca/GraphicsLayerCA.cpp:
2707         (WebCore::GraphicsLayerCA::clampedContentsScaleForScale):
2708         Increased the maximum scale since scale factor can now include
2709         both page contents scale and backing scale.
2710
2711         * rendering/RenderLayerBacking.cpp:
2712         (WebCore::RenderLayerBacking::createGraphicsLayer): Multiply in the
2713         backing scale as well as the page contents scale.
2714         (WebCore::RenderLayerBacking::updateForegroundLayer): Ditto.
2715         (WebCore::RenderLayerBacking::updateMaskLayer): Ditto.
2716         (WebCore::RenderLayerBacking::pageContentsScale): Added.
2717         (WebCore::RenderLayerBacking::backingScale): Added.
2718         * rendering/RenderLayerBacking.h: Added new private functions.
2719
2720 2011-07-01  Adele Peterson  <adele@apple.com>
2721
2722         Reviewed by Darin Adler.
2723
2724         WebCore part of fix for https://bugs.webkit.org/show_bug.cgi?id=63851
2725         <rdar://problem/8981062> Crash when loading a document in an editable WebView that has a subframe with an unstyled body
2726
2727         No new tests.  I tried to make a test in DumpRenderTree with an editable WebView, 
2728         but was unsuccessful in getting the crash to happen in that instance.
2729
2730         * editing/Editor.cpp: (WebCore::Editor::applyEditingStyleToElement): Add a nil check that exits early, in addition to the ASSERT.
2731
2732 2011-07-01  Levi Weintraub  <leviw@chromium.org>
2733
2734         Switch overflow and collapsedMargins to new layout types
2735         https://bugs.webkit.org/show_bug.cgi?id=63840
2736
2737         Reviewed by Eric Seidel.
2738
2739         Switching overflow and collapsedMargins over to the new layout unit abstraction.
2740
2741         Also removing an unused function: blockDirectionOverflow
2742
2743         No new tests, no functionality changes.
2744
2745         * rendering/RenderBlock.cpp:
2746         (WebCore::RenderBlock::collapsedMarginBeforeForChild):
2747         (WebCore::RenderBlock::collapsedMarginAfterForChild):
2748         * rendering/RenderBlock.h:
2749         (WebCore::RenderBlock::collapsedMarginBefore):
2750         (WebCore::RenderBlock::collapsedMarginAfter):
2751         * rendering/RenderBox.cpp:
2752         (WebCore::RenderBox::addOverflowFromChild):
2753         (WebCore::RenderBox::addLayoutOverflow):
2754         (WebCore::RenderBox::addVisualOverflow):
2755         * rendering/RenderBox.h:
2756         (WebCore::RenderBox::layoutOverflowRect):
2757         (WebCore::RenderBox::minYLayoutOverflow):
2758         (WebCore::RenderBox::maxYLayoutOverflow):
2759         (WebCore::RenderBox::minXLayoutOverflow):
2760         (WebCore::RenderBox::maxXLayoutOverflow):
2761         (WebCore::RenderBox::maxLayoutOverflow):
2762         (WebCore::RenderBox::logicalLeftLayoutOverflow):
2763         (WebCore::RenderBox::logicalRightLayoutOverflow):
2764         (WebCore::RenderBox::visualOverflowRect):
2765         (WebCore::RenderBox::minYVisualOverflow):
2766         (WebCore::RenderBox::maxYVisualOverflow):
2767         (WebCore::RenderBox::minXVisualOverflow):
2768         (WebCore::RenderBox::maxXVisualOverflow):
2769         (WebCore::RenderBox::logicalLeftVisualOverflow):
2770         (WebCore::RenderBox::logicalRightVisualOverflow):
2771         (WebCore::RenderBox::addOverflowFromChild):
2772         (WebCore::RenderBox::collapsedMarginBefore):
2773         (WebCore::RenderBox::collapsedMarginAfter):
2774         * rendering/RenderOverflow.h:
2775         (WebCore::RenderOverflow::RenderOverflow):
2776         (WebCore::RenderOverflow::minYLayoutOverflow):
2777         (WebCore::RenderOverflow::maxYLayoutOverflow):
2778         (WebCore::RenderOverflow::minXLayoutOverflow):
2779         (WebCore::RenderOverflow::maxXLayoutOverflow):
2780         (WebCore::RenderOverflow::minYVisualOverflow):
2781         (WebCore::RenderOverflow::maxYVisualOverflow):
2782         (WebCore::RenderOverflow::minXVisualOverflow):
2783         (WebCore::RenderOverflow::maxXVisualOverflow):
2784         (WebCore::RenderOverflow::setMinYLayoutOverflow):
2785         (WebCore::RenderOverflow::setMaxYLayoutOverflow):
2786         (WebCore::RenderOverflow::setMinXLayoutOverflow):
2787         (WebCore::RenderOverflow::setMaxXLayoutOverflow):
2788         (WebCore::RenderOverflow::setMinYVisualOverflow):
2789         (WebCore::RenderOverflow::setMaxYVisualOverflow):
2790         (WebCore::RenderOverflow::setMinXVisualOverflow):
2791         (WebCore::RenderOverflow::setMaxXVisualOverflow):
2792         (WebCore::RenderOverflow::layoutOverflowRect):
2793         (WebCore::RenderOverflow::visualOverflowRect):
2794         (WebCore::RenderOverflow::move):
2795         (WebCore::RenderOverflow::addLayoutOverflow):
2796         (WebCore::RenderOverflow::addVisualOverflow):
2797         (WebCore::RenderOverflow::setLayoutOverflow):
2798         (WebCore::RenderOverflow::setVisualOverflow):
2799         (WebCore::RenderOverflow::resetLayoutOverflow):
2800
2801 2011-07-01  Nate Chapin  <japhet@chromium.org>
2802
2803         Ensure WorkerScriptLoader::notifyFinished() doesn't re-enter.
2804         https://bugs.webkit.org/show_bug.cgi?id=63835
2805
2806         Reviewed by Dmitry Titov.
2807
2808         Test: fast/workers/worker-finish-crash.html
2809
2810         * workers/WorkerScriptLoader.cpp:
2811         (WebCore::WorkerScriptLoader::WorkerScriptLoader):
2812         (WebCore::WorkerScriptLoader::notifyFinished):
2813         * workers/WorkerScriptLoader.h:
2814
2815 2011-07-01  Adrienne Walker  <enne@google.com>
2816
2817         [chromium] Upload root layer textures first so that it is less likely to be skipped
2818         https://bugs.webkit.org/show_bug.cgi?id=63850
2819
2820         Reviewed by James Robinson.
2821
2822         This is a tiny follow-on patch to bug 63760.  If the root layer is not
2823         uploaded first, then it may not have enough space to fit into texture
2824         memory and might be skipped, leaving a blue background.
2825
2826         * platform/graphics/chromium/LayerRendererChromium.cpp:
2827         (WebCore::LayerRendererChromium::updateLayers):
2828
2829 2011-07-01  Mihai Parparita  <mihaip@chromium.org>
2830
2831         Reviewed by Darin Fisher.
2832
2833         location.replace with a hash change does not update the history entry
2834         https://bugs.webkit.org/show_bug.cgi?id=63777
2835
2836         location.replace('#foo') would not update the HistoryItem with the
2837         new URL, thus navigating back to the page would use the previous
2838         URL, even though it had been replaced. Make
2839         HistoryController::updateForSameDocumentNavigation mirror 
2840         HistoryController::replaceState.
2841
2842         Test: fast/history/location-replace-hash.html
2843
2844         * loader/HistoryController.cpp:
2845         (WebCore::HistoryController::updateForSameDocumentNavigation):
2846
2847 2011-07-01  Ryosuke Niwa  <rniwa@webkit.org>
2848
2849         Reviewed by Ojan Vafai.
2850
2851         Move m_isDirectional from FrameSelection to VisibleSelection
2852         https://bugs.webkit.org/show_bug.cgi?id=63473
2853
2854         Move m_isDirectional from FrameSelection to VisibleSelection.
2855
2856         Also fixed a bug that WebKit does not preserve non-directional selection after undo.
2857
2858         Test: editing/selection/directionality-after-undo-replace.html
2859
2860         * WebCore.exp.in: Updated the signature of setSelection.
2861         * editing/FrameSelection.cpp:
2862         (WebCore::FrameSelection::FrameSelection): Removed the call to setIsDirectional.
2863         (WebCore::shouldAlwaysUseDirectionalSelection): Added.
2864         (WebCore::FrameSelection::setSelection): No longer takes DirectionalityPolicy.
2865         Calls setIsDirectional(true) when the platform doesn't support non-directional selection.
2866         Passes align and granularity to setSelection of the base end point as expected.
2867         No longer updates granularity when updating the selection of a different frame.
2868         (WebCore::FrameSelection::willBeModified): Calls VisibleSelection::isDirectional().
2869         (WebCore::FrameSelection::modify): No longer calls trialFrameSelection.setIsDirectional
2870         because the directionality is passed from m_selection automatically.
2871         Also calls shouldAlwaysUseDirectionalSelection.
2872         * editing/FrameSelection.h: Remove m_isDirectional. Make all boolean bit fields.
2873         (WebCore::FrameSelection::setSelection): No longer takes DirectionalityPolicy.
2874         * editing/VisibleSelection.cpp:
2875         (WebCore::VisibleSelection::VisibleSelection): Initializes m_isDirectional to true.
2876         This should be changed to false to fix the bug 60529.
2877         * editing/VisibleSelection.h:
2878         (WebCore::VisibleSelection::isDirectional): Added.
2879         (WebCore::VisibleSelection::setIsDirectional): Added.
2880         * page/EventHandler.cpp:
2881         (WebCore::setNonDirectionalSelectionIfNeeded): Creates a non-directional selection instead of
2882         calling setSelection with MakeNonDirectionalSelection.
2883         (WebCore::EventHandler::handleMousePressEventSingleClick): Remove the call to setIsDirectional
2884         because it already calls setNonDirectionalSelectionIfNeeded.
2885
2886 2011-07-01  Tony Chang  <tony@chromium.org>
2887
2888         cleanup of flexbox and marquee data naming in StyleRareNonInheritedData
2889         https://bugs.webkit.org/show_bug.cgi?id=63827
2890
2891         Reviewed by Ojan Vafai.
2892
2893         * rendering/style/RenderStyle.cpp:
2894         (WebCore::RenderStyle::RenderStyle):
2895         (WebCore::RenderStyle::diff):
2896         * rendering/style/RenderStyle.h:
2897         (WebCore::InheritedFlags::boxAlign):
2898         (WebCore::InheritedFlags::boxFlex):
2899         (WebCore::InheritedFlags::boxFlexGroup):
2900         (WebCore::InheritedFlags::boxLines):
2901         (WebCore::InheritedFlags::boxOrdinalGroup):
2902         (WebCore::InheritedFlags::boxOrient):
2903         (WebCore::InheritedFlags::boxPack):
2904         (WebCore::InheritedFlags::marqueeIncrement):
2905         (WebCore::InheritedFlags::marqueeSpeed):
2906         (WebCore::InheritedFlags::marqueeLoopCount):
2907         (WebCore::InheritedFlags::marqueeBehavior):
2908         (WebCore::InheritedFlags::marqueeDirection):
2909         (WebCore::InheritedFlags::setBoxAlign):
2910         (WebCore::InheritedFlags::setBoxFlex):
2911         (WebCore::InheritedFlags::setBoxFlexGroup):
2912         (WebCore::InheritedFlags::setBoxLines):
2913         (WebCore::InheritedFlags::setBoxOrdinalGroup):
2914         (WebCore::InheritedFlags::setBoxOrient):
2915         (WebCore::InheritedFlags::setBoxPack):
2916         (WebCore::InheritedFlags::setMarqueeIncrement):
2917         (WebCore::InheritedFlags::setMarqueeSpeed):
2918         (WebCore::InheritedFlags::setMarqueeDirection):
2919         (WebCore::InheritedFlags::setMarqueeBehavior):
2920         (WebCore::InheritedFlags::setMarqueeLoopCount):
2921         * rendering/style/StyleRareNonInheritedData.cpp:
2922         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2923         (WebCore::StyleRareNonInheritedData::operator==):
2924         * rendering/style/StyleRareNonInheritedData.h:
2925             flexibleBox -> m_deprecatedFlexibleBox and marquee to m_marquee
2926
2927 2011-07-01  Mike Reed  <reed@google.com>
2928
2929         Stop using deprecated SkDeviceFactory API
2930         https://bugs.webkit.org/show_bug.cgi?id=63488
2931
2932         Reviewed by James Robinson.
2933
2934         No new tests. Check-point for removing Factory API from Skia
2935
2936         * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
2937         (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
2938         * platform/graphics/skia/PlatformContextSkia.cpp:
2939         (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
2940
2941 2011-07-01  Jeffrey Pfau  <jpfau@apple.com>
2942
2943         Reviewed by Adam Barth.
2944
2945         Move XMLDocumentParser to new folder xml/parser/
2946         https://bugs.webkit.org/show_bug.cgi?id=63666
2947
2948         * CMakeLists.txt:
2949         * GNUmakefile.am:
2950         * GNUmakefile.list.am:
2951         * WebCore.gyp/WebCore.gyp:
2952         * WebCore.gypi:
2953         * WebCore.pri:
2954         * WebCore.pro:
2955         * WebCore.vcproj/WebCore.vcproj:
2956         * WebCore.vcproj/WebCoreCommon.vsprops:
2957         * WebCore.vcproj/copyForwardingHeaders.cmd:
2958         * WebCore.xcodeproj/project.pbxproj:
2959         * xml/parser/XMLDocumentParser.cpp:
2960         (WebCore::XMLDocumentParser::pushCurrentNode):
2961         (WebCore::XMLDocumentParser::popCurrentNode):
2962         (WebCore::XMLDocumentParser::clearCurrentNodeStack):
2963         (WebCore::XMLDocumentParser::insert):
2964         (WebCore::XMLDocumentParser::append):
2965         (WebCore::XMLDocumentParser::handleError):
2966         (WebCore::XMLDocumentParser::enterText):
2967         (WebCore::toString):
2968         (WebCore::XMLDocumentParser::exitText):
2969         (WebCore::XMLDocumentParser::detach):
2970         (WebCore::XMLDocumentParser::end):
2971         (WebCore::XMLDocumentParser::finish):
2972         (WebCore::XMLDocumentParser::finishWasCalled):
2973         (WebCore::createXHTMLParserErrorHeader):
2974         (WebCore::XMLDocumentParser::insertErrorMessageBlock):
2975         (WebCore::XMLDocumentParser::notifyFinished):
2976         (WebCore::XMLDocumentParser::isWaitingForScripts):
2977         (WebCore::XMLDocumentParser::pauseParsing):
2978         (WebCore::XMLDocumentParser::parseDocumentFragment):
2979         * xml/parser/XMLDocumentParser.h:
2980         (WebCore::XMLParserContext::context):
2981         (WebCore::XMLParserContext::XMLParserContext):
2982         (WebCore::XMLDocumentParser::create):
2983         (WebCore::XMLDocumentParser::setIsXHTMLDocument):
2984         (WebCore::XMLDocumentParser::isXHTMLDocument):
2985         (WebCore::XMLDocumentParser::setIsXHTMLMPDocument):
2986         (WebCore::XMLDocumentParser::isXHTMLMPDocument):
2987         (WebCore::XMLDocumentParser::wellFormed):
2988         (WebCore::XMLDocumentParser::context):
2989         * xml/parser/XMLDocumentParserLibxml2.cpp:
2990         (WebCore::PendingCallbacks::~PendingCallbacks):
2991         (WebCore::PendingCallbacks::create):
2992         (WebCore::PendingCallbacks::appendStartElementNSCallback):
2993         (WebCore::PendingCallbacks::appendEndElementNSCallback):
2994         (WebCore::PendingCallbacks::appendCharactersCallback):
2995         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
2996         (WebCore::PendingCallbacks::appendCDATABlockCallback):
2997         (WebCore::PendingCallbacks::appendCommentCallback):
2998         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
2999         (WebCore::PendingCallbacks::appendErrorCallback):
3000         (WebCore::PendingCallbacks::callAndRemoveFirstCallback):
3001         (WebCore::PendingCallbacks::isEmpty):
3002         (WebCore::PendingCallbacks::PendingCallbacks):
3003         (WebCore::PendingCallbacks::PendingCallback::~PendingCallback):
3004         (WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback):
3005         (WebCore::PendingCallbacks::PendingStartElementNSCallback::call):
3006         (WebCore::PendingCallbacks::PendingEndElementNSCallback::call):
3007         (WebCore::PendingCallbacks::PendingCharactersCallback::~PendingCharactersCallback):
3008         (WebCore::PendingCallbacks::PendingCharactersCallback::call):
3009         (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::~PendingProcessingInstructionCallback):
3010         (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::call):
3011         (WebCore::PendingCallbacks::PendingCDATABlockCallback::~PendingCDATABlockCallback):
3012         (WebCore::PendingCallbacks::PendingCDATABlockCallback::call):
3013         (WebCore::PendingCallbacks::PendingCommentCallback::~PendingCommentCallback):
3014         (WebCore::PendingCallbacks::PendingCommentCallback::call):
3015         (WebCore::PendingCallbacks::PendingInternalSubsetCallback::~PendingInternalSubsetCallback):
3016         (WebCore::PendingCallbacks::PendingInternalSubsetCallback::call):
3017         (WebCore::matchFunc):
3018         (WebCore::OffsetBuffer::OffsetBuffer):
3019         (WebCore::OffsetBuffer::readOutBytes):
3020         (WebCore::switchToUTF16):
3021         (WebCore::shouldAllowExternalLoad):
3022         (WebCore::openFunc):
3023         (WebCore::readFunc):
3024         (WebCore::writeFunc):
3025         (WebCore::closeFunc):
3026         (WebCore::errorFunc):
3027         (WebCore::XMLParserContext::createStringParser):
3028         (WebCore::XMLParserContext::createMemoryParser):
3029         (WebCore::XMLDocumentParser::supportsXMLVersion):
3030         (WebCore::XMLDocumentParser::XMLDocumentParser):
3031         (WebCore::XMLParserContext::~XMLParserContext):
3032         (WebCore::XMLDocumentParser::~XMLDocumentParser):
3033         (WebCore::XMLDocumentParser::doWrite):
3034         (WebCore::toString):
3035         (WebCore::toAtomicString):
3036         (WebCore::handleElementNamespaces):
3037         (WebCore::handleElementAttributes):
3038         (WebCore::XMLDocumentParser::startElementNs):
3039         (WebCore::XMLDocumentParser::endElementNs):
3040         (WebCore::XMLDocumentParser::characters):
3041         (WebCore::XMLDocumentParser::error):
3042         (WebCore::XMLDocumentParser::processingInstruction):
3043         (WebCore::XMLDocumentParser::cdataBlock):
3044         (WebCore::XMLDocumentParser::comment):
3045         (WebCore::XMLDocumentParser::startDocument):
3046         (WebCore::XMLDocumentParser::endDocument):
3047         (WebCore::XMLDocumentParser::internalSubset):
3048         (WebCore::getParser):
3049         (WebCore::hackAroundLibXMLEntityBug):
3050         (WebCore::startElementNsHandler):
3051         (WebCore::endElementNsHandler):
3052         (WebCore::charactersHandler):
3053         (WebCore::processingInstructionHandler):
3054         (WebCore::cdataBlockHandler):
3055         (WebCore::commentHandler):
3056         (WebCore::warningHandler):
3057         (WebCore::fatalErrorHandler):
3058         (WebCore::normalErrorHandler):
3059         (WebCore::sharedXHTMLEntity):
3060         (WebCore::getXHTMLEntity):
3061         (WebCore::getEntityHandler):
3062         (WebCore::startDocumentHandler):
3063         (WebCore::endDocumentHandler):
3064         (WebCore::internalSubsetHandler):
3065         (WebCore::externalSubsetHandler):
3066         (WebCore::ignorableWhitespaceHandler):
3067         (WebCore::XMLDocumentParser::initializeParserContext):
3068         (WebCore::XMLDocumentParser::doEnd):
3069         (WebCore::xmlDocPtrForString):
3070         (WebCore::XMLDocumentParser::lineNumber):
3071         (WebCore::XMLDocumentParser::columnNumber):
3072         (WebCore::XMLDocumentParser::textPosition):
3073         (WebCore::XMLDocumentParser::textPositionOneBased):
3074         (WebCore::XMLDocumentParser::stopParsing):
3075         (WebCore::XMLDocumentParser::resumeParsing):
3076         (WebCore::XMLDocumentParser::appendFragmentSource):
3077         (WebCore::attributesStartElementNsHandler):
3078         (WebCore::parseAttributes):
3079         * xml/parser/XMLDocumentParserQt.cpp:
3080         (WebCore::EntityResolver::resolveUndeclaredEntity):
3081         (WebCore::XMLDocumentParser::supportsXMLVersion):
3082         (WebCore::XMLDocumentParser::XMLDocumentParser):
3083         (WebCore::XMLDocumentParser::~XMLDocumentParser):
3084         (WebCore::XMLDocumentParser::doWrite):
3085         (WebCore::XMLDocumentParser::initializeParserContext):
3086         (WebCore::XMLDocumentParser::doEnd):
3087         (WebCore::XMLDocumentParser::lineNumber):
3088         (WebCore::XMLDocumentParser::columnNumber):
3089         (WebCore::XMLDocumentParser::textPosition):
3090         (WebCore::XMLDocumentParser::textPositionOneBased):
3091         (WebCore::XMLDocumentParser::stopParsing):
3092         (WebCore::XMLDocumentParser::resumeParsing):
3093         (WebCore::XMLDocumentParser::appendFragmentSource):
3094         (WebCore::attributesStartElementNsHandler):
3095         (WebCore::parseAttributes):
3096         (WebCore::prefixFromQName):
3097         (WebCore::handleElementNamespaces):
3098         (WebCore::handleElementAttributes):
3099         (WebCore::XMLDocumentParser::parse):
3100         (WebCore::XMLDocumentParser::startDocument):
3101         (WebCore::XMLDocumentParser::parseStartElement):
3102         (WebCore::XMLDocumentParser::parseEndElement):
3103         (WebCore::XMLDocumentParser::parseCharacters):
3104         (WebCore::XMLDocumentParser::parseProcessingInstruction):
3105         (WebCore::XMLDocumentParser::parseCdata):
3106         (WebCore::XMLDocumentParser::parseComment):
3107         (WebCore::XMLDocumentParser::endDocument):
3108         (WebCore::XMLDocumentParser::hasError):
3109         (WebCore::XMLDocumentParser::parseDtd):
3110         * xml/parser/XMLDocumentParserScope.cpp:
3111         (WebCore::XMLDocumentParserScope::XMLDocumentParserScope):
3112         (WebCore::XMLDocumentParserScope::~XMLDocumentParserScope):
3113
3114 2011-07-01  Vangelis Kokkevis  <vangelis@chromium.org>
3115
3116         Reviewed by James Robinson.
3117
3118         [chromium] Reserve all tile textures at layer update time to guarantee
3119         that they will be available at draw time.
3120         https://bugs.webkit.org/show_bug.cgi?id=63760
3121
3122         In addition, this patch unreserves textures used by RenderSurface's
3123         right after the RenderSurface has been used to free up memory for
3124         subsequent RenderSurfaces.
3125         
3126         This patch also "fixes" the pages that display a blue background when
3127         running out of texture memory as the root layer tiles get reserved first
3128         and are guaranteed to get textures.
3129
3130         * platform/graphics/chromium/ContentLayerChromium.cpp:
3131         (WebCore::ContentLayerChromium::ContentLayerChromium):
3132         (WebCore::ContentLayerChromium::visibleLayerRect):
3133         (WebCore::ContentLayerChromium::setIsMask):
3134         * platform/graphics/chromium/ContentLayerChromium.h:
3135         * platform/graphics/chromium/ImageLayerChromium.cpp:
3136         (WebCore::ImageLayerChromium::paintContentsIfDirty):
3137         * platform/graphics/chromium/LayerRendererChromium.cpp:
3138         (WebCore::LayerRendererChromium::paintLayerContents):
3139         (WebCore::LayerRendererChromium::drawLayer):
3140         (WebCore::LayerRendererChromium::initializeSharedObjects):
3141         * platform/graphics/chromium/LayerTexture.cpp:
3142         (WebCore::LayerTexture::unreserve):
3143         * platform/graphics/chromium/LayerTexture.h:
3144         * platform/graphics/chromium/LayerTilerChromium.cpp:
3145         (WebCore::LayerTilerChromium::prepareToUpdate):
3146         (WebCore::LayerTilerChromium::updateRect):
3147         (WebCore::LayerTilerChromium::drawTiles):
3148         * platform/graphics/chromium/RenderSurfaceChromium.cpp:
3149         (WebCore::RenderSurfaceChromium::releaseContentsTexture):
3150         * platform/graphics/chromium/RenderSurfaceChromium.h:
3151         * platform/graphics/chromium/TextureManager.cpp:
3152         (WebCore::TextureManager::unprotectTexture):
3153         * platform/graphics/chromium/TextureManager.h:
3154
3155 2011-07-01  Jungshik Shin  <jshin@chromium.org>
3156
3157         Reviewed by Alexey Proskuryakov.
3158
3159         Allow generic font family settings per script code.
3160         https://bugs.webkit.org/show_bug.cgi?id=20797
3161
3162         Make generic font family getters/setters accept an additional
3163         argument (script code). It has a default value so that if an embedder
3164         does not have/want a per-script font family setting, call-sites
3165         don't have to be changed.
3166         This is to prepare for fixing bug 10874 (font selection is not
3167         language-dependent) and bug 18085.
3168
3169         uscript.h has been updated to that of ICU 3.6 (the version of ICU on
3170         Mac OS 10.5)
3171
3172         There should be no change in layout and no new layout test
3173         is added.
3174
3175         * WebCore.exp.in:
3176         * icu/unicode/uscript.h: updated to ICU 4.6
3177         * page/Settings.cpp:
3178         (WebCore::setGenericFontFamilyMap): helper to set generic family per script
3179         (WebCore::getGenericFontFamilyForScript): helper function used by getters for fooFontFamily.
3180         (WebCore::Settings::standardFontFamily):
3181         (WebCore::Settings::setStandardFontFamily):
3182         (WebCore::Settings::fixedFontFamily):
3183         (WebCore::Settings::setFixedFontFamily):
3184         (WebCore::Settings::serifFontFamily):
3185         (WebCore::Settings::setSerifFontFamily):
3186         (WebCore::Settings::sansSerifFontFamily):
3187         (WebCore::Settings::setSansSerifFontFamily):
3188         (WebCore::Settings::cursiveFontFamily):
3189         (WebCore::Settings::setCursiveFontFamily):
3190         (WebCore::Settings::fantasyFontFamily):
3191         (WebCore::Settings::setFantasyFontFamily):
3192         * page/Settings.h: setter and getter for FooFontFamily have a new optional argument, scriptCode.
3193
3194 2011-07-01  Tony Chang  <tony@chromium.org>
3195
3196         Reviewed by Ojan Vafai.
3197
3198         rename StyleFlexibleBoxData to StyleDeprecatedFlexibleBoxData
3199         https://bugs.webkit.org/show_bug.cgi?id=63773
3200
3201         We will have a similar struct to hold CSS3 flexible box data, so
3202         this makes way for the new class.
3203         I will rename the member variable in RenderStyle.h in a follow up
3204         change.
3205
3206         * CMakeLists.txt:
3207         * GNUmakefile.list.am:
3208         * WebCore.gypi:
3209         * WebCore.order:
3210         * WebCore.pro:
3211         * WebCore.vcproj/WebCore.vcproj:
3212         * WebCore.xcodeproj/project.pbxproj:
3213         * rendering/style/RenderStyle.h:
3214         * rendering/style/StyleAllInOne.cpp:
3215         * rendering/style/StyleDeprecatedFlexibleBoxData.cpp:
3216         (WebCore::StyleDeprecatedFlexibleBoxData::StyleDeprecatedFlexibleBoxData):
3217         (WebCore::StyleDeprecatedFlexibleBoxData::operator==):
3218         * rendering/style/StyleDeprecatedFlexibleBoxData.h:
3219         (WebCore::StyleDeprecatedFlexibleBoxData::create):
3220         (WebCore::StyleDeprecatedFlexibleBoxData::copy):
3221         (WebCore::StyleDeprecatedFlexibleBoxData::operator!=):
3222         * rendering/style/StyleRareNonInheritedData.h:
3223
3224 2011-07-01  Hans Wennborg  <hans@chromium.org>
3225
3226         Reviewed by Tony Chang.
3227
3228         IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY
3229         https://bugs.webkit.org/show_bug.cgi?id=63754
3230
3231         Fix values for the webkitIDBTransaction.READ_WRITE/READ_ONLY
3232         constants. Douglas Stockwell pointed out that these were reverse
3233         of what the spec says.
3234
3235         * storage/IDBTransaction.h:
3236         * storage/IDBTransaction.idl:
3237
3238 2011-07-01  Levi Weintraub  <leviw@chromium.org>
3239
3240         Reviewed by Eric Seidel.
3241
3242         Switch positionForPoint to new layout types
3243         https://bugs.webkit.org/show_bug.cgi?id=63774
3244
3245         Switching positionForPoint functions to new layout unit abstraction.
3246
3247         No new tests, no functionality changes.
3248
3249         * rendering/RenderBR.cpp:
3250         (WebCore::RenderBR::positionForPoint):
3251         * rendering/RenderBR.h:
3252         * rendering/RenderBlock.cpp:
3253         (WebCore::RenderBlock::positionForPoint):
3254         * rendering/RenderBlock.h:
3255         * rendering/RenderBox.cpp:
3256         (WebCore::RenderBox::positionForPoint):
3257         * rendering/RenderBox.h:
3258         * rendering/RenderFileUploadControl.cpp:
3259         (WebCore::RenderFileUploadControl::positionForPoint):
3260         * rendering/RenderFileUploadControl.h:
3261         * rendering/RenderInline.cpp:
3262         (WebCore::RenderInline::positionForPoint):
3263         * rendering/RenderInline.h:
3264         * rendering/RenderObject.cpp:
3265         (WebCore::RenderObject::positionForPoint):
3266         * rendering/RenderReplaced.cpp:
3267         (WebCore::RenderReplaced::positionForPoint):
3268         * rendering/RenderReplaced.h:
3269         * rendering/RenderText.cpp:
3270         (WebCore::RenderText::positionForPoint):
3271         * rendering/RenderText.h:
3272         * rendering/RenderTextControlSingleLine.cpp:
3273         (WebCore::RenderTextControlInnerBlock::positionForPoint):
3274         * rendering/RenderTextControlSingleLine.h:
3275         * rendering/svg/RenderSVGInlineText.cpp:
3276         (WebCore::RenderSVGInlineText::positionForPoint):
3277         * rendering/svg/RenderSVGInlineText.h:
3278         * rendering/svg/RenderSVGText.cpp:
3279         (WebCore::RenderSVGText::positionForPoint):
3280         * rendering/svg/RenderSVGText.h:
3281
3282 2011-07-01  Andrew Scherkus  <scherkus@chromium.org>
3283
3284         Reviewed by Darin Fisher.
3285
3286         Re-enable WTF_USE_WEBAUDIO_FFMPEG for Chromium
3287         https://bugs.webkit.org/show_bug.cgi?id=63783
3288
3289         * WebCore.gyp/WebCore.gyp:
3290
3291 2011-07-01  Patrick Gansterer  <paroga@webkit.org>
3292
3293         Reviewed by Daniel Bates.
3294
3295         [CMake] Don't compile unused bindings
3296         https://bugs.webkit.org/show_bug.cgi?id=63741
3297
3298         * UseJSC.cmake: Added IF (ENABLE_XXX) around files.
3299
3300 2011-07-01  Joone Hur  <joone.hur@collabora.co.uk>
3301
3302         Reviewed by Martin Robinson.
3303
3304         [GTK] Add DeviceOrientation feature
3305         https://bugs.webkit.org/show_bug.cgi?id=63720
3306
3307         Add DeviceMotionClientGtk.cpp and DeviceOrientationClientGtk.cpp to WebKitGtk+ build.
3308
3309         * GNUmakefile.am: Add DeviceMotionClientGtk.cpp, DeviceOrientationClientGtk.cpp.
3310
3311 2011-07-01  Kentaro Hara  <haraken@google.com>
3312
3313         Reviewed by Kent Tamura.
3314
3315         Disallow clicking an [X] button in 'search' input forms when 'disabled' attribute or 'readonly' attribute is set.
3316         https://bugs.webkit.org/show_bug.cgi?id=63709
3317
3318         Ignore a cancel button event on a 'search' input form if 'disabled' attribute or
3319         'readonly' attribute is set to the input form.
3320
3321         Test: fast/forms/search-disabled-readonly.html
3322
3323         * html/shadow/TextControlInnerElements.cpp:
3324         (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
3325
3326 2011-06-30  Mikhail Naganov  <mnaganov@chromium.org>
3327
3328         Reviewed by Yury Semikhatsky.
3329
3330         Web Inspector: [Chromium] Fix heap snapshots in a remote debugging session from Safari.
3331         https://bugs.webkit.org/show_bug.cgi?id=63703
3332
3333         * inspector/front-end/HeapSnapshotWorker.js:
3334         (.Function.prototype.bind.return.bound):
3335         (.Function.prototype.bind):
3336
3337 2011-07-01  Dirk Schulze  <krit@webkit.org>
3338
3339         Reviewed by Nikolas Zimmermann.
3340
3341         SVGAnimatedLengthListAnimator does not take additive="sum" into accout
3342         https://bugs.webkit.org/show_bug.cgi?id=63705
3343
3344         Added support for additive animations to SVGAnimatedLengthListAnimator. Don't clear the animatedList if not
3345         necessary.
3346
3347         SVGLength unit gets animated as well now. We used to take the unit of 'from' all the time.
3348
3349         Tests: svg/animations/svglength-animation-unitType.html
3350                svg/animations/svglengthlist-animation-5.html
3351
3352         * svg/SVGAnimatedLength.cpp:
3353         (WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue): Code clean-up and support for unit animation.
3354         * svg/SVGAnimatedLengthList.cpp: Add support for additive animations.
3355         (WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
3356         * svg/SVGLength.cpp:
3357         (WebCore::SVGLength::SVGLength):
3358         (WebCore::SVGLength::setValue): New setValue that gets the LengthType and UnitType as argument for supporting animations of units as well.
3359         * svg/SVGLength.h:
3360
3361 2011-07-01  Dirk Schulze  <krit@webkit.org>
3362
3363         Reviewed by Nikolas Zimmermann.
3364
3365         SVGAnimatedType should support SVGAnimatedInteger animation
3366         https://bugs.webkit.org/show_bug.cgi?id=63789
3367         
3368         Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
3369         This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedInteger.
3370         
3371         SVGAnimatedInteger is used for some attributes of SVG filter effects. The animation of those attributes work after this patch.
3372
3373         Test: svg/animations/svginteger-animation-1.html
3374
3375         * CMakeLists.txt: Added file to build system.
3376         * GNUmakefile.list.am: Ditto.
3377         * WebCore.gypi: Ditto.
3378         * WebCore.pro: Ditto.
3379         * WebCore.xcodeproj/project.pbxproj: Ditto.
3380         * svg/SVGAllInOne.cpp: Ditto.
3381         * svg/SVGAnimateElement.cpp: Make use of AnimatedInteger.
3382         (WebCore::SVGAnimateElement::determineAnimatedAttributeType):
3383         (WebCore::SVGAnimateElement::calculateAnimatedValue):
3384         (WebCore::SVGAnimateElement::calculateFromAndToValues):
3385         (WebCore::SVGAnimateElement::calculateFromAndByValues):
3386         (WebCore::SVGAnimateElement::resetToBaseValue):
3387         (WebCore::SVGAnimateElement::applyResultsToTarget):
3388         (WebCore::SVGAnimateElement::calculateDistance):
3389         * svg/SVGAnimatedInteger.cpp: Added. The new animator for SVGAnimatedInteger.
3390         (WebCore::SVGAnimatedIntegerAnimator::SVGAnimatedIntegerAnimator):
3391         (WebCore::SVGAnimatedIntegerAnimator::constructFromString):
3392         (WebCore::SVGAnimatedIntegerAnimator::calculateFromAndToValues):
3393         (WebCore::SVGAnimatedIntegerAnimator::calculateFromAndByValues):
3394         (WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedValue):
3395         (WebCore::SVGAnimatedIntegerAnimator::calculateDistance):
3396         * svg/SVGAnimatedInteger.h:
3397         (WebCore::SVGAnimatedIntegerAnimator::~SVGAnimatedIntegerAnimator):
3398         * svg/SVGAnimatedType.cpp: Added handler for AnimatedInteger.
3399         (WebCore::SVGAnimatedType::~SVGAnimatedType):
3400         (WebCore::SVGAnimatedType::createInteger):
3401         (WebCore::SVGAnimatedType::integer):
3402         (WebCore::SVGAnimatedType::valueAsString):
3403         (WebCore::SVGAnimatedType::setValueAsString):
3404         * svg/SVGAnimatedType.h:
3405         * svg/SVGAnimatorFactory.h:
3406         (WebCore::SVGAnimatorFactory::create):
3407
3408 2011-06-30  Eugene Klyuchnikov  <eustas.bug@gmail.com>
3409
3410         Reviewed by Pavel Feldman.
3411
3412         WebInspector: Performance / memory allocation issue in WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded
3413         https://bugs.webkit.org/show_bug.cgi?id=40447
3414
3415         Test: inspector/editor/text-editor-model-replace-tabs.html
3416
3417         * inspector/front-end/TextEditorModel.js:
3418         (WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded): avoid looped production of tail substrings 
3419
3420 2011-06-30  Kent Tamura  <tkent@chromium.org>
3421
3422         Reviewed by Tony Chang.
3423
3424         [Chromium] Input type="range" slider thumb is rendered upside down on Mac OS X.
3425         https://bugs.webkit.org/show_bug.cgi?id=63697
3426
3427         http://trac.webkit.org/changeset/86261 added a thumb flipping code
3428         for Mac-WebKit2. Chromium also needs it.
3429
3430         * rendering/RenderThemeMac.mm:
3431         (WebCore::RenderThemeMac::paintSliderThumb): Always flip vertically on Chromium.
3432
3433 2011-06-30  Kenichi Ishibashi  <bashi@chromium.org>
3434
3435         Reviewed by Simon Fraser.
3436
3437         [Chromium] -webkit-text-stroke doesn't affect with non-zero width border property
3438         https://bugs.webkit.org/show_bug.cgi?id=63698
3439
3440         Restore the stroke style when it is modified in RenderObject::drawLineForBoxSide() to show text stroke correctly.
3441
3442         Test: platform/chromium/fast/text/text-stroke-with-border.html
3443
3444         * rendering/RenderObject.cpp:
3445         (WebCore::RenderObject::drawLineForBoxSide): Save/restore the stroke style.
3446
3447 2011-06-30  Gwang Yoon Hwang  <ryumiel@company100.net>
3448
3449         Reviewed by Nate Chapin.
3450
3451         [V8] Add ENABLE(INSPECTOR) guards around v8 custom bindings.
3452         https://bugs.webkit.org/show_bug.cgi?id=63442
3453
3454         No new tests needed.
3455
3456         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
3457         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
3458
3459 2011-06-30  Levi Weintraub  <leviw@chromium.org>
3460
3461         Reviewed by Eric Seidel.
3462
3463         Remove positionForCoordinates
3464         https://bugs.webkit.org/show_bug.cgi?id=63765
3465
3466         Removing positionForCoordinate. We should always use positionForPoint. Also cleaning up
3467         RenderBox's implementation of positionForPoint.
3468
3469         No new tests, there should be no functionality changes.
3470
3471         * accessibility/AccessibilityRenderObject.cpp:
3472         (WebCore::AccessibilityRenderObject::stringValue): Removing dead, or at least untested, code and
3473         adding an ASSERT_NOT_REACHED.
3474         (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
3475         * rendering/RenderBox.cpp:
3476         (WebCore::RenderBox::positionForPoint): cleaning up some ugly code.
3477         * rendering/RenderInline.cpp:
3478         (WebCore::RenderInline::positionForPoint):
3479         * rendering/RenderObject.cpp:
3480         * rendering/RenderObject.h:
3481
3482 2011-06-30  Zhenyao Mo  <zmo@google.com>
3483
3484         Reviewed by Kenneth Russell.
3485
3486         Improve WebGL object lifetime management in WebGLRenderingContext
3487         https://bugs.webkit.org/show_bug.cgi?id=63635
3488
3489         * html/canvas/WebGLRenderingContext.cpp:
3490         (WebCore::WebGLRenderingContext::getAttachedShaders): Use cached objects instead of querying the underlying GL.
3491         (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Ditto.
3492         (WebCore::WebGLRenderingContext::detachAndRemoveAllObjects): Multiple loop because objects might be removed from the table within an iteration.
3493         * html/canvas/WebGLRenderingContext.h:
3494
3495 2011-06-30  Rafael Brandao  <rafael.lobo@openbossa.org>
3496
3497         Reviewed by Andreas Kling.
3498
3499         [Qt] build-webkit warning: cannot find file ElementShadowPseudoId.h
3500         https://bugs.webkit.org/show_bug.cgi?id=63747
3501
3502         Removed reference to ElementShadowPseudoId.h that no longer exists.
3503
3504         * WebCore.pro:
3505
3506 2011-06-30  Anders Carlsson  <andersca@apple.com>
3507
3508         Fix clang build.
3509
3510         Remove the complete Widget constructor from the .exp.in file; since Widget is an abstract class,
3511         its complete constructor can never be called and clang has stopped emitting it altogether.
3512
3513         * WebCore.exp.in:
3514
3515 2011-06-30  Levi Weintraub  <leviw@chromium.org>
3516
3517         Reviewed by Eric Seidel.
3518
3519         Switch paintingRootRect and RenderObject repaint methods to new layout types
3520         https://bugs.webkit.org/show_bug.cgi?id=63746
3521
3522         Switching paintingRootRect and RenderObject repaint functions over to the
3523         new layout unit abstraction.
3524
3525         No new tests, no functionality changes.
3526
3527         * rendering/RenderBox.cpp:
3528         (WebCore::RenderBox::repaintDuringLayoutIfMoved):
3529         * rendering/RenderBox.h:
3530         * rendering/RenderObject.cpp:
3531         (WebCore::RenderObject::paintingRootRect):
3532         (WebCore::RenderObject::paint):
3533         (WebCore::RenderObject::repaintUsingContainer):
3534         (WebCore::RenderObject::repaintRectangle):
3535         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
3536         (WebCore::RenderObject::repaintDuringLayoutIfMoved):
3537         * rendering/RenderObject.h:
3538
3539 2011-06-30  Cary Clark  <caryclark@google.com>
3540
3541         Reviewed by James Robinson.
3542
3543         Use Skia if Skia on Mac Chrome is enabled
3544         https://bugs.webkit.org/show_bug.cgi?id=62999
3545
3546         No new tests. This does not affect existing
3547         functionality.
3548
3549         * WebCore.gyp/WebCore.gyp:
3550         Include Skia and related files and exclude CG
3551         and related files when building Chromium for Skia
3552         on the Mac.
3553
3554         * loader/cache/CachedFont.cpp:
3555         Rename CHROME to CHROMIUM.
3556
3557         * platform/chromium/DragImageRef.h:
3558         * platform/graphics/FloatPoint.h:
3559         * platform/graphics/FloatRect.h:
3560         * platform/graphics/FloatSize.h:
3561         * platform/graphics/FontPlatformData.h:
3562         (WebCore::FontPlatformData::hash):
3563         * platform/graphics/GlyphBuffer.h:
3564         (WebCore::GlyphBuffer::advanceAt):
3565         (WebCore::GlyphBuffer::add):
3566         (WebCore::GlyphBuffer::expandLastAdvance):
3567         * platform/graphics/IntPoint.h:
3568         * platform/graphics/IntRect.h:
3569         * platform/graphics/IntSize.h:
3570         * platform/graphics/SimpleFontData.h:
3571         * platform/graphics/cg/FloatPointCG.cpp:
3572         * platform/graphics/cg/FloatRectCG.cpp:
3573         * platform/graphics/cg/FloatSizeCG.cpp:
3574         * platform/graphics/cg/IntPointCG.cpp:
3575         * platform/graphics/cg/IntRectCG.cpp:
3576         * platform/graphics/cg/IntSizeCG.cpp:
3577         * platform/graphics/mac/FontCustomPlatformData.cpp:
3578         (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
3579         (WebCore::createFontCustomPlatformData):
3580         * platform/graphics/mac/FontCustomPlatformData.h:
3581         (WebCore::FontCustomPlatformData::FontCustomPlatformData):
3582         Ditto.
3583
3584 2011-06-30  Julien Chaffraix  <jchaffraix@webkit.org>
3585
3586         Reviewed by Nikolas Zimmermann.
3587
3588         Update SVG position values on SVG DOM updates
3589         https://bugs.webkit.org/show_bug.cgi?id=62439
3590
3591         Test: svg/custom/crash-textPath-attributes.html
3592
3593         * rendering/svg/RenderSVGInline.cpp:
3594         (WebCore::RenderSVGInline::destroy): Notify our containing RenderSVGText that it needs
3595         to update its positioning information.
3596
3597         * rendering/svg/SVGInlineFlowBox.cpp:
3598         (WebCore::SVGInlineFlowBox::calculateBoundaries): Check the type of the InlineBox
3599         like the rest of the code (fixes an ASSERT_NOT_REACHED in InlineBox::calculateBoudaries).
3600
3601         * rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
3602         (WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextSubtree): Clear
3603         our cached layout attributes every time we invalidate them. This avoids keeping stale
3604         attribute that have a backpointer to a RenderObject.
3605
3606 2011-06-30  Sreeram Ramachandran  <sreeram@chromium.org>
3607
3608         Reviewed by Adam Barth.
3609
3610         Suppress modal JavaScript/HTML dialogs during unload events
3611         https://bugs.webkit.org/show_bug.cgi?id=56397
3612
3613         Allows clients to specify whether to show alerts during unload handlers.
3614         When checking for whether a page dismissal event is being dispatched,
3615         it's important to check all frames on the page (otherwise it becomes a
3616         loophole easily exploited).
3617
3618         Test: fast/loader/page-dismissal-modal-dialogs.html
3619
3620         * loader/FrameLoader.cpp:
3621         (WebCore::FrameLoader::FrameLoader):
3622         (WebCore::FrameLoader::stopLoading):
3623         (WebCore::FrameLoader::loadURL):
3624         (WebCore::FrameLoader::loadWithDocumentLoader):
3625         (WebCore::FrameLoader::stopAllLoaders):
3626         (WebCore::FrameLoader::fireBeforeUnloadEvent):
3627         * loader/FrameLoader.h:
3628         (WebCore::FrameLoader::pageDismissalEventBeingDispatched):
3629         * loader/cache/CachedResourceLoader.cpp:
3630         (WebCore::CachedResourceLoader::requestImage):
3631         * page/Chrome.cpp:
3632         (WebCore::canRunModalIfDuringPageDismissal):
3633         (WebCore::Chrome::canRunModalNow):
3634         (WebCore::Chrome::runJavaScriptAlert):
3635         (WebCore::Chrome::runJavaScriptConfirm):
3636         (WebCore::Chrome::runJavaScriptPrompt):
3637         * page/Chrome.h:
3638         * page/ChromeClient.h:
3639         (WebCore::ChromeClient::shouldRunModalDialogDuringPageDismissal):
3640         * page/DOMWindow.cpp:
3641         (WebCore::DOMWindow::showModalDialog):
3642
3643 2011-06-30  Julien Chaffraix  <jchaffraix@webkit.org>
3644
3645         Reviewed by Nikolas Zimmermann.
3646
3647         Assertion failure in RenderSVGInlineText::characterStartsNewTextChunk
3648         https://bugs.webkit.org/show_bug.cgi?id=63076
3649
3650         Tests: svg/custom/crash-text-in-textpath.svg
3651                svg/custom/text-node-in-text-invalidated.svg
3652
3653         The problem was that we did not call setNeedsPositionUpdate on RenderSVGText. When
3654         doing our layout, we would not update the attributes on our SVGRenderInlineText as
3655         we would not lay it out.
3656
3657         This was caused by childrenChanged being overridden on SVGTextPositioningElement but
3658         not on SVGTextPathElement.
3659
3660         As both classes shared the same mother class, it made sense to move the logic here.
3661         There should be no other side effects as SVGTextPathElement and SVGTextPositioningElement
3662         are the only classes deriving from SVGTextContentElement.
3663
3664         * svg/SVGTextContentElement.cpp:
3665         (WebCore::SVGTextContentElement::childrenChanged): Moved this method from SVGTextPositioningElement.
3666         * svg/SVGTextContentElement.h:
3667         * svg/SVGTextPositioningElement.cpp:
3668         (WebCore::SVGTextPositioningElement::svgAttributeChanged): Updated after updatePositioningValuesInRenderer
3669         removal, replaced by RenderSVGText::locateRenderSVGTextAncestor.
3670         * svg/SVGTextPositioningElement.h:
3671
3672 2011-06-30  Patrick Gansterer  <paroga@webkit.org>
3673
3674         Unreviewed build fix for !ENABLE(DATABASE) after r84789.
3675
3676         * bindings/js/JSDOMBinding.cpp:
3677
3678 2011-06-30  Anders Carlsson  <andersca@apple.com>
3679
3680         Reviewed by Dan Bernstein.
3681
3682         More ScrollableArea scaffolding
3683         https://bugs.webkit.org/show_bug.cgi?id=63678
3684
3685         Add a way to get the enclosing scrollable area for a given scrollable area.
3686         Also, add ScrollableArea::isPinnedInDirectionOfScrollDelta.
3687
3688         * page/FrameView.cpp:
3689         (WebCore::FrameView::enclosingScrollableArea):
3690         Return 0 for now.
3691
3692         * page/FrameView.h:
3693         Add FrameView::enclosingScrollableArea.
3694
3695         * platform/ScrollableArea.cpp:
3696         (WebCore::ScrollableArea::isPinnedInDirectionOfScrollDelta):
3697         Return whether the area is pinned in the direction of the scroll delta.
3698
3699         * platform/ScrollableArea.h:
3700         Add new member functions.
3701
3702         * platform/chromium/FramelessScrollView.cpp:
3703         (WebCore::FramelessScrollView::enclosingScrollableArea):
3704         * platform/chromium/FramelessScrollView.h:
3705         Add stub.
3706
3707         * platform/win/PopupMenuWin.h:
3708         (WebCore::PopupMenuWin::enclosingScrollableArea):
3709         Always return 0.
3710
3711         * rendering/RenderLayer.cpp:
3712         (WebCore::RenderLayer::enclosingScrollableLayer):
3713         Add helper function.
3714
3715         (WebCore::RenderLayer::scrollByRecursively):
3716         Use the new enclosingScrollableLayer helper function.
3717
3718         (WebCore::RenderLayer::enclosingScrollableArea):
3719         Return the enclosing scrollable area.
3720
3721         * rendering/RenderLayer.h:
3722         Add new member function.
3723
3724         * rendering/RenderListBox.cpp:
3725         (WebCore::RenderListBox::enclosingScrollableArea):
3726         Return 0 for now.
3727         
3728         * rendering/RenderListBox.h:
3729         Add new member function.
3730
3731 2011-06-30  Martin Robinson  <mrobinson@igalia.com>
3732
3733         Reviewed by Anders Carlsson.
3734
3735         [GTK] Crash observed with nspluginwrapper and flash
3736         https://bugs.webkit.org/show_bug.cgi?id=62249
3737
3738         Test: plugins/invalidate-rect-with-null-npp-argument.html
3739
3740         * plugins/npapi.cpp:
3741         (NPN_InvalidateRect): Guard against null instances here.
3742
3743 2011-06-30  Levi Weintraub  <leviw@chromium.org>
3744
3745         Reviewed by Eric Seidel.
3746
3747         Switch availableWidth/Height, logicalLeft/RightOffsetForLine to new layout types
3748         https://bugs.webkit.org/show_bug.cgi?id=63671
3749
3750         Switch availableWidth/Height, logicalLeft/RightOffsetForLine functions over to the
3751         new layout unit abstraction.
3752
3753         No new tests, no functionality changes.
3754
3755         * rendering/RenderBlock.cpp:
3756         (WebCore::RenderBlock::logicalLeftOffsetForLine):
3757         (WebCore::RenderBlock::logicalRightOffsetForLine):
3758         (WebCore::RenderBlock::availableLogicalWidthForLine):
3759         (WebCore::RenderBlock::availableLogicalWidth):
3760         * rendering/RenderBlock.h:
3761         (WebCore::RenderBlock::logicalRightOffsetForLine):
3762         (WebCore::RenderBlock::logicalLeftOffsetForLine):
3763         (WebCore::RenderBlock::startOffsetForLine):
3764         * rendering/RenderBox.cpp:
3765         (WebCore::RenderBox::availableLogicalHeight):
3766         (WebCore::RenderBox::availableLogicalHeightUsing):
3767         * rendering/RenderBox.h:
3768         (WebCore::RenderBox::availableLogicalWidth):
3769         (WebCore::RenderBox::availableWidth):
3770         (WebCore::RenderBox::availableHeight):
3771
3772 2011-06-30  Adam Barth  <abarth@webkit.org>
3773
3774         Remove useless ASSERT that breaks the build.
3775
3776         * dom/StyledElement.cpp:
3777         (WebCore::parseColorStringWithCrazyLegacyRules):
3778
3779 2011-06-30  Tab Atkins  <jackalmage@gmail.com>
3780
3781         Reviewed by Adam Barth.
3782
3783         Fix legacy color attribute parsing to match HTML spec
3784         https://bugs.webkit.org/show_bug.cgi?id=63029
3785
3786         Relevant spec link: http://www.whatwg.org/specs/web-apps/current-work/complete/common-microsyntaxes.html#rules-for-parsing-a-legacy-color-value
3787         Fix legacy color attribute parsing (<body bgcolor>, <font color>, etc.) to match the HTML spec and more closely match other browsers.
3788
3789         Test: fast/dom/attribute-legacy-colors.html
3790
3791         * dom/StyledElement.cpp:
3792         (WebCore::StyledElement::addCSSColor):
3793
3794 2011-06-28  Hans Wennborg  <hans@chromium.org>
3795
3796         Reviewed by Tony Chang.
3797
3798         IndexedDB: Prepare for running layout tests with LevelDB
3799         https://bugs.webkit.org/show_bug.cgi?id=63593
3800
3801         Migration of data from SQLite to LevelDB must be done before the
3802         m_backingStore map is checked for an open LevelDB, because if a
3803         previous layout test has used LevelDB, it will be in the
3804         m_backingStore map.
3805
3806         Covered by existing layout tests.
3807
3808         * storage/IDBFactoryBackendImpl.cpp:
3809         (WebCore::IDBFactoryBackendImpl::open):
3810
3811 2011-06-30  Pavel Feldman  <pfeldman@chromium.org>
3812
3813         Reviewed by Yury Semikhatsky.
3814
3815         Web Inspector: introduce "filter" icons for timeline panel and elements sidebar.
3816         https://bugs.webkit.org/show_bug.cgi?id=63731
3817
3818         * inspector/front-end/EventListenersSidebarPane.js:
3819         * inspector/front-end/Images/paneFilterButtons.png: Added.
3820         * inspector/front-end/Images/statusbarButtonGlyphs.png:
3821         * inspector/front-end/StylesSidebarPane.js:
3822         * inspector/front-end/inspector.css:
3823         (.pane > .title > select):
3824         (.pane > .title > select.select-settings):
3825         (.pane > .title > select.select-filter):
3826         (.timeline-filter-status-bar-item .glyph):
3827
3828 2011-06-28  Hans Wennborg  <hans@chromium.org>
3829
3830         Reviewed by Tony Chang.
3831
3832         IndexedDB: Support for deleteIndex with LevelDB backing store
3833         https://bugs.webkit.org/show_bug.cgi?id=63539
3834
3835         Covered by storage/indexeddb/mozilla/remove-index.html.
3836
3837         * storage/IDBLevelDBBackingStore.cpp:
3838         (WebCore::IDBLevelDBBackingStore::deleteIndex):
3839
3840 2011-06-30  Abhishek Arya  <inferno@chromium.org>
3841
3842         Reviewed by Ryosuke Niwa.
3843
3844         Crash when calling DOMSubtreeModified event when extracting range
3845         contents.
3846         https://bugs.webkit.org/show_bug.cgi?id=63650
3847
3848         Convert a few nodes to RefPtrs and add commonRoot verification checks
3849         for Range::processContents.
3850
3851         Tests: fast/dom/Range/range-extract-contents-event-fire-crash.html
3852                fast/dom/Range/range-extract-contents-event-fire-crash2.html
3853
3854         * dom/Range.cpp:
3855         (WebCore::childOfCommonRootBeforeOffset):
3856         (WebCore::Range::processContents):
3857         (WebCore::Range::processContentsBetweenOffsets):
3858         (WebCore::Range::processAncestorsAndTheirSiblings):
3859
3860 2011-06-30  Dan Bernstein  <mitz@apple.com>
3861
3862         Reviewed by Adele Peterson.
3863
3864         Add +[WebView _allowsRoundingHacks]
3865         https://bugs.webkit.org/show_bug.cgi?id=63734
3866
3867         * WebCore.exp.in: Export TextRun::allowsRoundingHacks().
3868         * platform/graphics/TextRun.cpp:
3869         (WebCore::TextRun::allowsRoundingHacks): Added this accessor.
3870         * platform/graphics/TextRun.h:
3871
3872 2011-06-30  Patrick Gansterer  <paroga@webkit.org>
3873
3874         Reviewed by Adam Roben.
3875
3876         [WIN] Don't redefine the keyboard codes
3877         https://bugs.webkit.org/show_bug.cgi?id=63726
3878
3879         Only define the codes when undefined.
3880         r64957 fixed this problem for COMPILER(MINGW) but not for OS(WINCE).
3881
3882         * platform/WindowsKeyboardCodes.h:
3883
3884 2011-06-30  Yury Semikhatsky  <yurys@chromium.org>
3885
3886         Reviewed by Pavel Feldman.
3887
3888         Web Inspector: hide "Enabled background events collection" option in context menu until the setting is persisted
3889         https://bugs.webkit.org/show_bug.cgi?id=63708
3890
3891         The option has no much sense if it is not preserved between browser restarts.
3892
3893         * inspector/front-end/NetworkPanel.js:
3894         (WebInspector.NetworkPanel.prototype._contextMenu):
3895
3896 2011-06-30  Patrick Gansterer  <paroga@webkit.org>
3897
3898         Reviewed by Darin Adler.
3899
3900         Remove dependnecy on IDL generation for disabled features in JSC bindings
3901         https://bugs.webkit.org/show_bug.cgi?id=63718
3902
3903         Move the #if ENABLE() line directly after #include "config.h".
3904         This enables us to compile all files even when we don't generate the IDL output.
3905
3906         * bindings/js/IDBBindingUtilities.cpp:
3907         * bindings/js/JSConsoleCustom.cpp:
3908         * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
3909         * bindings/js/JSCustomXPathNSResolver.cpp:
3910         * bindings/js/JSDOMApplicationCacheCustom.cpp:
3911         * bindings/js/JSDeviceMotionEventCustom.cpp:
3912         * bindings/js/JSDeviceOrientationEventCustom.cpp:
3913         * bindings/js/JSInjectedScriptHostCustom.cpp:
3914         * bindings/js/JSInjectedScriptManager.cpp:
3915         * bindings/js/JSInspectorFrontendHostCustom.cpp:
3916         * bindings/js/JSJavaScriptCallFrameCustom.cpp:
3917         * bindings/js/JSSQLResultSetRowListCustom.cpp:
3918         * bindings/js/JSSQLTransactionCustom.cpp:
3919         * bindings/js/JSSQLTransactionSyncCustom.cpp:
3920         * bindings/js/JSSVGElementInstanceCustom.cpp:
3921         * bindings/js/JSStorageCustom.cpp:
3922         * bindings/js/JSTouchCustom.cpp:
3923         * bindings/js/JSTouchListCustom.cpp:
3924         * bindings/js/JSXPathResultCustom.cpp:
3925         * bindings/js/JavaScriptCallFrame.cpp:
3926         * bindings/js/PageScriptDebugServer.cpp:
3927         * bindings/js/ScriptDebugServer.cpp:
3928         * bindings/js/ScriptGCEvent.cpp:
3929         * bindings/js/ScriptProfile.cpp:
3930         * bindings/js/WorkerScriptDebugServer.cpp:
3931
3932 2011-06-30  Alexander Pavlov  <apavlov@chromium.org>
3933
3934         Reviewed by Kent Tamura.
3935
3936         [Chromium] Autofill suggestions appear in upper left corner after input change
3937         https://bugs.webkit.org/show_bug.cgi?id=63702
3938
3939         This change fixes a few popup layout issues, some of which have existed for quite a while:
3940         - the absence of the ChromeClientImpl::screenToWindow() implementation (the method used to always return (0, 0));
3941         - the confusion of window and screen coordinates passed into the autofill popup client's setWindowRect() method;
3942         - the use of the current frameRect() width as the target element's width (which was wrong when refreshing
3943           a popup resized during the initial layout (e.g. made wider than the target element)).
3944
3945         No new tests, as this is a change to platform-specific widget code. The test case is provided in the bug description.
3946
3947         * platform/chromium/PopupMenuChromium.cpp:
3948         (WebCore::PopupContainer::layoutAndGetRTLOffset): Use original target element width, not frameRect().width(),
3949         since the latter gets updated if the popup is not the same width as the target element.
3950         (WebCore::PopupContainer::refresh): Restore only the popup bounds rather than its original rectangle,
3951         since it sometimes breaks the invalidation region and layout.
3952
3953 2011-06-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3954
3955         Unreviewed, rolling out r90102.
3956         http://trac.webkit.org/changeset/90102
3957         https://bugs.webkit.org/show_bug.cgi?id=63714
3958
3959         Lots of tests asserting beneath
3960         SVGSMILElement::findInstanceTime (Requested by aroben on
3961         #webkit).
3962
3963         * svg/animation/SVGSMILElement.cpp:
3964         (WebCore::SVGSMILElement::findInstanceTime):
3965
3966 2011-06-30  Andrey Kosyakov  <caseq@chromium.org>
3967
3968         Reviewed by Yury Semikhatsky.
3969
3970         Web Inspector: remove ExtensionAPISchema.json
3971         https://bugs.webkit.org/show_bug.cgi?id=63687
3972
3973         * inspector/front-end/ExtensionAPISchema.json: Removed.
3974
3975 2011-06-30  Ilya Tikhonovsky  <loislo@chromium.org>
3976
3977         Unreviewed build fix for chromium.
3978
3979         * inspector/CodeGeneratorInspector.pm:
3980
3981 2011-06-30  Ilya Tikhonovsky  <loislo@chromium.org>
3982
3983         Unreviewed build fix for mac.
3984
3985         * inspector/CodeGeneratorInspector.pm:
3986
3987 2011-06-30  Ilya Tikhonovsky  <loislo@chromium.org>
3988
3989         Reviewed by Pavel Feldman.
3990
3991         Web Inspector: Protocol: error object needs some improvement.
3992         https://bugs.webkit.org/show_bug.cgi?id=63707
3993
3994         Current implementation is not useful in the code.
3995         We need to have toString implementation with nice formatting
3996         I'd like to use error.message property as the main place for the error's text.
3997
3998         * inspector/CodeGeneratorInspector.pm:
3999
4000 2011-06-30  Mikhail Naganov  <mnaganov@chromium.org>
4001
4002         Reviewed by Yury Semikhatsky.
4003
4004         Web Inspector: [Chromium] Support annotations for arrays in heap profiler.
4005         https://bugs.webkit.org/show_bug.cgi?id=63690
4006
4007         * inspector/front-end/DetailedHeapshotGridNodes.js:
4008         (WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
4009
4010
4011 2011-06-30  Patrick Gansterer  <paroga@webkit.org>
4012
4013         Unreviewed build fix for !ENABLE(SVG_ANIMATION) after r88663, r89187, r89220, r89431 and r89661.
4014
4015         * svg/SVGAnimatedAngle.h:
4016         * svg/SVGAnimatedLength.h:
4017         * svg/SVGAnimatedNumber.h:
4018         * svg/SVGAnimatedRect.h:
4019         * svg/SVGAnimatedString.h:
4020
4021 2011-06-30  Gabor Loki  <loki@webkit.org>
4022
4023         Reviewed by Csaba Osztrogon√°c.
4024
4025         Fixed several style and typo issues after r90091.
4026         https://bugs.webkit.org/show_bug.cgi?id=63692
4027
4028         Rename yStart to extremaStartY during computing extremas
4029
4030         * platform/graphics/filters/FEMorphology.cpp:
4031         (WebCore::FEMorphology::platformApplyGeneric):
4032         * platform/graphics/filters/FEMorphology.h:
4033
4034 2011-06-30  Oliver Varga  <Varga.Oliver@stud.u-szeged.hu>
4035
4036         Reviewed by Nikolas Zimmermann.
4037
4038         Speed up SVGSMILElement::findInstanceTime.
4039         https://bugs.webkit.org/show_bug.cgi?id=61025
4040
4041         Replace the linear search to binary search on ordered list because
4042         the previous searches from the beginning was not efficient.
4043
4044         No new tests this is only a performance tweak.
4045
4046         * svg/animation/SVGSMILElement.cpp:
4047         (WebCore::extractTimeFromVector):
4048         (WebCore::SVGSMILElement::findInstanceTime):
4049
4050 2011-06-30  Kentaro Hara  <haraken@google.com>
4051
4052         Reviewed by Kent Tamura.
4053
4054         Change the label of an HTML5 file chooser button to "Choose Files"
4055         https://bugs.webkit.org/show_bug.cgi?id=49245
4056
4057         We should notify capability of multiple files to users.
4058
4059         Test: fast/forms/input-file-label.html
4060
4061         * English.lproj/Localizable.strings:
4062         * html/FileInputType.cpp:
4063         (WebCore::UploadButtonElement::createForMultiple): Constructs a multiple file chooser button.
4064         (WebCore::FileInputType::createShadowSubtree): Constructs a single/multiple file chooser button depending on 'multiple' attribute.
4065         (WebCore::FileInputType::multipleAttributeChanged): Updates the label of the file chooser button.
4066         * html/FileInputType.h:
4067         * html/HTMLInputElement.cpp:
4068         (WebCore::HTMLInputElement::parseMappedAttribute): Updates the shadow tree of the file chooser button when 'multiple' attribute is set or unset.
4069         * html/InputType.cpp:
4070         (WebCore::InputType::multipleAttributeChanged): Virtual method to be overridden by FileInputType.
4071         * html/InputType.h:
4072         * platform/DefaultLocalizationStrategy.cpp:
4073         (WebCore::DefaultLocalizationStrategy::fileButtonChooseFileLabel): Updated the description for "Choose File".
4074         (WebCore::DefaultLocalizationStrategy::fileButtonChooseMultipleFilesLabel): Returns a string "Choose Files".
4075         * platform/DefaultLocalizationStrategy.h:
4076         * platform/LocalizationStrategy.h:
4077         * platform/LocalizedStrings.cpp:
4078         (WebCore::fileButtonChooseMultipleFilesLabel): Wrapper method for getting the "Choose Files" label.
4079         * platform/LocalizedStrings.h:
4080         * platform/brew/LocalizedStringsBrew.cpp:
4081         (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
4082         * platform/efl/LocalizedStringsEfl.cpp:
4083         (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
4084         * platform/gtk/LocalizedStringsGtk.cpp:
4085         (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
4086         * platform/haiku/LocalizedStringsHaiku.cpp:
4087         (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
4088         * platform/wx/LocalizedStringsWx.cpp:
4089         (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
4090
4091 2011-06-30  Ryosuke Niwa  <rniwa@webkit.org>
4092
4093         Reviewed by Kent Tamura.
4094
4095         Replace isNodeInTextFormControl(Node*) by enclosingTextFormControl(const Position&)
4096         https://bugs.webkit.org/show_bug.cgi?id=63672
4097
4098         Replaced isNodeInTextFormControl(Node*) by enclosingTextFormControl(const Position&).
4099         Also added a safe toTextFormControl to HTMLFormControlElement.h.
4100
4101         * editing/DeleteSelectionCommand.cpp:
4102         (WebCore::DeleteSelectionCommand::doApply): Calls enclosingTextFormControl instead of manually
4103         checking the tag name of shadowAncestorNode.
4104         * editing/Editor.cpp:
4105         (WebCore::Editor::selectionForCommand): Rewritten using enclosingTextFormControl and toTextFormControl.