Fix a regression from r88478.
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-06-09  Dan Bernstein  <mitz@apple.com>
2
3         Reviewed by Darin Adler.
4
5         Fix a regression from r88478.
6
7         * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
8         (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Add the runs
9         in reverse order in the RTL case here, since the whole vector is reversed by collectComplexTextRuns()
10         afterwards.
11
12 2011-06-09  Julien Chaffraix  <jchaffraix@codeaurora.org>
13
14         Reviewed by Antti Koivisto.
15
16         REGRESSION(84329): Stylesheets on some pages do not load
17         https://bugs.webkit.org/show_bug.cgi?id=61400
18
19         Test: fast/css/link-disabled-attr.html
20
21         Fixed r84329: the change did not take into account the fact
22         that HTMLLinkElement did already contain the disabled information
23         and the 2 information were not linked as they should have!
24
25         The new logic pushes the information to the stylesheet as this
26         is what the spec mandates and what FF is doing. Also it keeps
27         one bit of information (that JS enabled the stylesheet) as it
28         is needed for the recalcStyleSelector logic.
29
30         * dom/Document.cpp:
31         (WebCore::Document::recalcStyleSelector): s/isDisabled/disabled.
32
33         * html/HTMLLinkElement.cpp:
34         (WebCore::HTMLLinkElement::HTMLLinkElement): Removed m_disabledState,
35         replaced by m_isEnabledViaScript.
36         (WebCore::HTMLLinkElement::setDisabled): Updated the logic after
37         m_disabledState removal. It also matches the spec by forwarding
38         the disabled state to our stylesheet if we have one.
39         (WebCore::HTMLLinkElement::parseMappedAttribute): Removed harmful
40         handling of the disabledAttr.
41         (WebCore::HTMLLinkElement::process): Updated after m_disabledState removal.
42         * html/HTMLLinkElement.h:
43         (WebCore::HTMLLinkElement::isEnabledViaScript): Ditto.
44         (WebCore::HTMLLinkElement::isAlternate): Ditto.
45
46 2011-06-09  Dan Bernstein  <mitz@apple.com>
47
48         Reviewed by Darin Adler.
49
50         Simplify ComplexTextController::collectComplexTextRuns()
51         https://bugs.webkit.org/show_bug.cgi?id=62387
52
53         No new test, since functionality is unchanged.
54
55         * platform/graphics/mac/ComplexTextController.cpp:
56         (WebCore::ComplexTextController::collectComplexTextRuns): Always iterate characters in logical order,
57         then reverse the run vector for RTL.
58
59 2011-06-09  Dimitri Glazkov  <dglazkov@chromium.org>
60
61         Reviewed by Kent Tamura.
62
63         Fold isShadowBoundary into isShadowRoot.
64         https://bugs.webkit.org/show_bug.cgi?id=62317
65
66         Since there are no longer cases where Node::isShadowBoundary() != Node::isShadowRoot, we can remove this function.
67
68         In one case where isShadowBoundary was also tested to find ShadowContentElemnt, added a new isContentElement function.
69
70         Refactoring, covered by existing tests.
71
72         * css/CSSStyleSelector.cpp:
73         (WebCore::isAtShadowBoundary): Changed to use isShadowRoot.
74         * dom/Element.cpp:
75         (WebCore::Element::isSpellCheckingEnabled): Ditto.
76         * dom/Node.cpp:
77         (WebCore::Node::nonBoundaryShadowTreeRootNode): Ditto.
78         (WebCore::Node::nonShadowBoundaryParentNode): Ditto.
79         * dom/Node.h:
80         (WebCore::Node::isContentElement): Added.
81         * dom/NodeRenderingContext.cpp:
82         (WebCore::NodeRenderingContext::NodeRenderingContext): Changed to use isShadowRoot.
83         * dom/Position.cpp:
84         (WebCore::Position::Position): Ditto.
85         * dom/ShadowContentElement.h:
86         (WebCore::ShadowContentElement::isContentElement): Added.
87         * dom/ShadowRoot.cpp:
88         (WebCore::ShadowRoot::hasContentElement): Changed to use isContentElement.
89         * editing/CompositeEditCommand.cpp:
90         (WebCore::CompositeEditCommand::insertNodeAfter): Changed to use isShadowRoot.
91         * editing/htmlediting.cpp:
92         (WebCore::visiblePositionBeforeNode): Ditto.
93         (WebCore::visiblePositionAfterNode): Ditto.
94         * page/DragController.cpp:
95         (WebCore::asFileInput): Ditto.
96         * rendering/RenderTreeAsText.cpp:
97         (WebCore::nodePosition): Ditto.
98
99 2011-06-09  Simon Fraser  <simon.fraser@apple.com>
100
101         Reviewed by Darin Adler.
102
103         Crashes in RenderLayerBacking::paintingGoesToWindow
104         https://bugs.webkit.org/show_bug.cgi?id=61159
105
106         Speculative fix for unreproducible crash that can occur when RenderObject::repaintUsingContainer()
107         finds a repaintContainer that is not the RenderView, but that is also not
108         composited (for unknown reasons), by checking to see if the layer is
109         compositing before using backing(). An assertion remains to try to catch
110         this in debug builds.
111
112         * rendering/RenderLayer.cpp:
113         (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
114
115 2011-06-09  Julien Chaffraix  <jchaffraix@webkit.org>
116
117         Reviewed by Darin Adler.
118
119         WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
120         https://bugs.webkit.org/show_bug.cgi?id=62384
121
122         Test: fast/css/webkit-keyframes-crash.html
123
124         * css/WebKitCSSKeyframesRule.cpp:
125         (WebCore::WebKitCSSKeyframesRule::setName): stylesheet() is never garanteed
126         to return a non-null pointer. Thus null-check here like the rest of the code.
127
128 2011-06-09  Julien Chaffraix  <jchaffraix@codeaurora.org>
129
130         Reviewed by David Hyatt.
131
132         chrome.dll!WebCore::RenderStyle::fontMetrics ReadAV@NULL (two crashes)
133         https://bugs.webkit.org/show_bug.cgi?id=57756
134
135         Tests: fast/css/fontMetric-border-radius-null-crash.html
136                fast/css/fontMetric-webkit-border-end-width-null-crash.html
137
138         * css/CSSStyleSelector.cpp:
139         (WebCore::CSSStyleSelector::styleForElement): Added a call to Font::update
140         so that our FontFallbackList is allocated if we ever need it when applying our
141         style rules.
142
143 2011-06-09  Cary Clark  <caryclark@google.com>
144
145         Reviewed by Eric Seidel.
146
147         Create local CG context for Mac UI elements when Skia is renderer
148         https://bugs.webkit.org/show_bug.cgi?id=62213
149
150         When building Mac Chrome using Skia as the WebKit renderer,
151         add state to LocalCurrentGraphicsContext to convert the SkCanvas
152         context passed by WebKit into the CGContext needed by UI
153         rendering.
154
155         No new tests.  The define typo in question is
156         not yet enabled, so this change has no functional
157         impact.
158
159         * platform/mac/LocalCurrentGraphicsContext.h:
160         Add SkiaBitLocker to create and release the converted CGContext.
161         Add ContextContainer, a class for Skia to create and release
162         the converted CGContext. If Skia is not used, the class has no effect.
163
164         * platform/mac/LocalCurrentGraphicsContext.mm:
165         (WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext):
166         When building with Skia, create the CGContext before passing it on.
167
168         (WebCore::LocalCurrentGraphicsContext::cgContext):
169         Get the CGContext from the SkiaBitLocker, or the saved context,
170         as appropriate.
171
172         * rendering/RenderThemeMac.mm:
173         Get the CGContext from Skia conversion or native, as appropriate.
174         Use the LocalCurrentGraphicsContext if there is one. Otherwise,
175         add a ContextContainer to house the SkCanvas to CGContext conversion.
176
177         (WebCore::RenderThemeMac::paintCapsLockIndicator):
178         (WebCore::RenderThemeMac::paintProgressBar):
179         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
180         (WebCore::RenderThemeMac::paintSliderTrack):
181         (WebCore::RenderThemeMac::paintMediaFullscreenButton):
182         (WebCore::RenderThemeMac::paintMediaMuteButton):
183         (WebCore::RenderThemeMac::paintMediaPlayButton):
184         (WebCore::RenderThemeMac::paintMediaSeekBackButton):
185         (WebCore::RenderThemeMac::paintMediaSeekForwardButton):
186         (WebCore::RenderThemeMac::paintMediaSliderTrack):
187         (WebCore::RenderThemeMac::paintMediaSliderThumb):
188         (WebCore::RenderThemeMac::paintMediaRewindButton):
189         (WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
190         (WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
191         (WebCore::RenderThemeMac::paintMediaControlsBackground):
192         (WebCore::RenderThemeMac::paintMediaCurrentTime):
193         (WebCore::RenderThemeMac::paintMediaTimeRemaining):
194         (WebCore::RenderThemeMac::paintMediaVolumeSliderContainer):
195         (WebCore::RenderThemeMac::paintMediaVolumeSliderTrack):
196         (WebCore::RenderThemeMac::paintMediaVolumeSliderThumb):
197
198 2011-06-02  Jer Noble  <jer.noble@apple.com>
199
200         Reviewed by Maciej Stachowiak.
201
202         REGRESSION: Page layout messed up after exiting full screen after video ends at jerryseinfeld.com
203         https://bugs.webkit.org/show_bug.cgi?id=61911
204         <rdar://problem/9523017>
205
206         Test: fullscreen/full-screen-video-offset.html
207
208         When the video element is taken full-screen in the new element full-screen API, return the
209         offset width and height of the placeholder renderer which is filling in for the full-screen
210         element.  To do so, override offsetWidth, Height, Left, and Top from Element.  These are
211         non-virtual functions, so make them virtual.
212
213         * dom/Element.cpp:
214         (WebCore::Element::adjustForLocalZoom): Made into a class-static function.
215         * dom/Element.h: Made offset functions virtual.
216         * html/HTMLMediaElement.cpp:
217         (WebCore::elementPlaceholder): Added; utility function.
218         (WebCore::HTMLMediaElement::offsetLeft): Added; virtual override of the 
219             Element function. Will be called directly via javascript.
220         (WebCore::HTMLMediaElement::offsetTop): Ditto.
221         (WebCore::HTMLMediaElement::offsetWidth): Ditto.
222         (WebCore::HTMLMediaElement::offsetHeight): Ditto.
223         * html/HTMLMediaElement.h:
224
225 2011-06-09  Dave Tapuska  <dtapuska@rim.com>
226
227         Reviewed by Daniel Bates.
228
229         PingLoader destructor could dereference 0 if the Resource
230         Handle creation failed.
231
232         https://bugs.webkit.org/show_bug.cgi?id=62304
233
234         * loader/PingLoader.cpp:
235         (WebCore::PingLoader::~PingLoader):
236
237 2011-06-08  Abhishek Arya  <inferno@chromium.org>
238
239         Reviewed by Ryosuke Niwa.
240
241         Make indexForVisiblePosition and isSelectableElement static.
242         https://bugs.webkit.org/show_bug.cgi?id=62329
243
244         This protects us when converting frame->selection->start() or end()
245         to VisiblePosition which blows away the RenderTextControl from
246         underneath (due to layout update).
247
248         Test: fast/forms/text-control-selection-crash.html
249
250         * accessibility/AccessibilityRenderObject.cpp:
251         (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
252         * rendering/RenderTextControl.cpp:
253         (WebCore::RenderTextControl::selectionStart):
254         (WebCore::RenderTextControl::selectionEnd):
255         (WebCore::RenderTextControl::isSelectableElement):
256         (WebCore::RenderTextControl::indexForVisiblePosition):
257         * rendering/RenderTextControl.h:
258
259 2011-06-09  Ben Murdoch  <benm@google.com>
260
261         Reviewed by Yury Semikhatsky.
262
263         Build break in ScriptProfile.cpp and inspector disabled.
264         https://bugs.webkit.org/show_bug.cgi?id=62373
265
266         No new tests - build fix only.
267
268         * bindings/v8/ScriptProfile.cpp: Add necessary guards.
269         * bindings/v8/ScriptProfile.h: ditto.
270
271 2011-06-09  Vsevolod Vlasov  <vsevik@chromium.org>
272
273         Reviewed by Yury Semikhatsky.
274
275         Web Inspector: Network panel preview tab does not reattach SourceFrame when switching between preview and response tabs.
276         https://bugs.webkit.org/show_bug.cgi?id=62298
277
278         * inspector/front-end/ResourcePreviewView.js:
279         (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown.callback):
280         (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown):
281
282 2011-06-09  Csaba Osztrogonác  <ossy@webkit.org>
283
284         [Qt][Mac] Speculative buildfix after r88286.
285
286         * platform/graphics/IntPoint.h:
287
288 2011-06-09  Mike Lawther  <mikelawther@chromium.org>
289
290         Reviewed by Kent Tamura.
291
292         Parsing issue with -webkit-calc
293         https://bugs.webkit.org/show_bug.cgi?id=62276
294
295         Set the CSSParserString for the calc functions.
296
297         Test: css3/calc/regression-62276.html
298
299         * css/CSSParser.cpp:
300         (WebCore::CSSParser::lex):
301
302 2011-06-09  Robert Hogan  <robert@webkit.org>
303
304         Reviewed by Andreas Kling.
305
306         Teach Qt about window.internals
307         https://bugs.webkit.org/show_bug.cgi?id=61074
308
309         A weakness of the Qt DRT setup is that things like JSContextRef are abstracted
310         away from the QtWebKit API so we need DumpRenderTreeSupportQt to access WebCore internals.
311         Since the window.internals object requires JSContextRef we need to implement it in DumpRenderTreeSupportQt
312         where we can access it. DumpRenderTreeSupportQt cannot be compiled outside Qt's WebCore and as it
313         is our only possible route into the WebCoreTestSupport class neither can the new window.internals plumbing.
314         Likewise we can't put the accessor in WebCoreTestSupport because it would then need to know about QWebFrame
315         and others. The only alternative seems like a compile time guard which we would have to teach the bots about.
316
317         * CodeGenerators.pri:
318         * WebCore.pri:
319         * WebCore.pro:
320
321 2011-06-08  Mikołaj Małecki  <m.malecki@samsung.com>
322
323         Reviewed by Pavel Feldman.
324
325         Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
326         https://bugs.webkit.org/show_bug.cgi?id=52791
327
328         No new tests. The problem can be reproduced by trying to create InspectorValue
329         from 1.0e-100 and call ->toJSONString() on this.
330
331         * inspector/InspectorValues.cpp:
332         (WebCore::InspectorBasicValue::writeJSON):
333         Added checking the predicted buffer size and choosing exponential format, or
334         eventually "NaN" if the buffer is too small for decimal format.
335
336 2011-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>
337
338         Unreviewed, rolling out r88387.
339         http://trac.webkit.org/changeset/88387
340         https://bugs.webkit.org/show_bug.cgi?id=62368
341
342         New tests introduced in 88387 fail on Leopard,GTK,Qt bots
343         (Requested by Ossy on #webkit).
344
345         * html/canvas/CanvasRenderingContext.cpp:
346         (WebCore::CanvasRenderingContext::checkOrigin):
347         * html/canvas/CanvasRenderingContext.h:
348         * html/canvas/WebGLRenderingContext.cpp:
349         (WebCore::WebGLRenderingContext::readPixels):
350         (WebCore::WebGLRenderingContext::texImage2D):
351         (WebCore::WebGLRenderingContext::videoFrameToImage):
352         (WebCore::WebGLRenderingContext::texSubImage2D):
353         * html/canvas/WebGLRenderingContext.h:
354
355 2011-06-09  Adam Barth  <abarth@webkit.org>
356
357         Reviewed by Eric Seidel.
358
359         Running script from attach can remove elements from the stack of open elements
360         https://bugs.webkit.org/show_bug.cgi?id=62160
361
362         When the tree build runs script synchronously, that script can remove
363         arbitrary elements from the stack of open elements.  We need to hold a
364         reference to |parent| in attach instead of rely upon the reference in
365         the stack of open elements.
366
367         Test: fast/parser/document-write-onload-clear.html
368
369         * html/parser/HTMLConstructionSite.cpp:
370         (WebCore::HTMLConstructionSite::attach):
371
372 2011-06-08  Luke Macpherson   <macpherson@chromium.org>
373
374         Reviewed by Eric Seidel.
375
376         Make CSSPrimitiveValue support cast to EVerticalAlign.
377         https://bugs.webkit.org/show_bug.cgi?id=62356
378
379         No new tests / refactoring only.
380
381         * css/CSSPrimitiveValueMappings.h:
382         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
383         (WebCore::CSSPrimitiveValue::operator EVerticalAlign):
384         * css/CSSStyleSelector.cpp:
385         (WebCore::CSSStyleSelector::applyProperty):
386
387 2011-06-08  Justin Novosad  <junov@chromium.org>
388
389         Reviewed by James Robinson.
390
391         [Chromium] Crash when closing a tab with accelerated 2d canvas
392         https://bugs.webkit.org/show_bug.cgi?id=62324
393         Upon graphics context destruction, it is important to signal skia
394         to abandon all of its resource handles.  This prevents a crash caused
395         by skia attempting to release resources that were in the destroyed
396         graphics context.
397
398         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
399         (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
400
401 2011-06-08  James Robinson  <jamesr@chromium.org>
402
403         Reviewed by Darin Fisher.
404
405         REGRESSION(88260): 10-50% performance regression across many page cyclers
406         https://bugs.webkit.org/show_bug.cgi?id=62349
407
408         r88260 fixed a font cache resource leak and lowered the inactive font cache threshold.  The latter caused a
409         significant performance regression across many chromium page cyclers, for example
410         http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/moz/report.html?history=50&rev=88279.
411
412         This restores the previous inactive font size thresholds to their previous values, but retains the font cleanup
413         logic.
414
415         * platform/graphics/FontCache.cpp:
416
417 2011-06-08  Hayato Ito  <hayato@chromium.org>
418
419         Reviewed by Dimitri Glazkov.
420
421         A forward/backward tab traversal now visits focusable elements in a shadow root.
422         https://bugs.webkit.org/show_bug.cgi?id=61410
423
424         Test: fast/dom/shadow/tab-order-iframe-and-shadow.html
425
426         Like a iframe element, a shadow host becomes a scope of
427         tabindex. That means all descendant elements in a shadow root are
428         skipped if the host node of the shadow root is not focusable.
429
430         The patch doesn't affect HTMLInputElement and HTMLTextAreaElement,
431         which uses a shadow root and do extra works in their focus()
432         method.
433
434         A shadow root's <content> is not considered in this patch.
435         That will be addressed in a following patch.
436
437         * page/FocusController.cpp:
438         (WebCore::shadowRoot):
439         (WebCore::isTreeScopeOwner):
440         (WebCore::FocusController::deepFocusableNode):
441         (WebCore::FocusController::advanceFocusInDocumentOrder):
442         (WebCore::FocusController::findFocusableNodeAcrossTreeScope):
443         (WebCore::FocusController::findFocusableNode):
444         (WebCore::FocusController::nextFocusableNode):
445         (WebCore::FocusController::previousFocusableNode):
446         (WebCore::FocusController::ownerOfTreeScope):
447         * page/FocusController.h:
448
449 2011-06-08  Hayato Ito  <hayato@chromium.org>
450
451         Reviewed by Hajime Morita.
452
453         Makes sure that document.activeElement won't be an element in shadow root.
454
455         https://bugs.webkit.org/show_bug.cgi?id=61413
456
457         Test: fast/dom/shadow/activeelement-should-be-shadowhost.html
458
459         * html/HTMLDocument.cpp:
460         (WebCore::focusedFrameOwnerElement):
461         (WebCore::HTMLDocument::activeElement):
462
463 2011-06-08  Kent Tamura  <tkent@chromium.org>
464
465         Reviewed by Dimitri Glazkov.
466
467         Allow drawing a slider thumb for any nodes.
468         https://bugs.webkit.org/show_bug.cgi?id=62196
469
470         RenderObject::node() should provide various information which is
471         necessary for rendering. We don't need to refer the parent renderer.
472
473         * dom/Node.cpp:
474         (WebCore::Node::focusDe1egate): Added.
475         * dom/Node.h: Added a declaration.
476         * html/shadow/MediaControlElements.cpp:
477         (WebCore::toParentMediaElement):
478           Added an overload of toParentMediaElement() with Node* parameter.
479         * html/shadow/MediaControlElements.h:
480         (WebCore::toParentMediaElement): ditto.
481         * html/shadow/SliderThumbElement.cpp:
482         (WebCore::SliderThumbElement::isEnabledFormControl):
483           Returns the status of the host node.
484         (WebCore::SliderThumbElement::isReadOnlyFormControl): ditto.
485         (WebCore::SliderThumbElement::focusDe1egate):
486           Returns the host node so that RenderTheme::isFocused() returns true.
487         (WebCore::SliderThumbElement::detach): Style nit.
488         (WebCore::SliderThumbElement::hostInput):
489           Make it const because it is called by const functions.
490         * html/shadow/SliderThumbElement.h:
491           - Remove inDragMode()
492           - Update declarations
493         * platform/qt/RenderThemeQt.cpp:
494         (WebCore::RenderThemeQt::paintMediaSliderThumb):
495           Use Node::shadowAncestorNode() instead of RenderObject::parent() to
496           support deeper thumb nodes.
497         * rendering/RenderMediaControlsChromium.cpp:
498         (WebCore::paintMediaSliderThumb): ditto.
499         (WebCore::paintMediaVolumeSliderThumb): Remove isSlider() check.
500         * rendering/RenderSlider.cpp:
501         (WebCore::RenderSlider::inDragMode):
502           SliderThumbElement::inDragMode() was removed, and Node::active() has
503           the same information.
504         * rendering/RenderTheme.cpp:
505         (WebCore::RenderTheme::paint): Remove isSlider() checks.
506         (WebCore::RenderTheme::isFocused): Apply Node::focusDelegate().
507         * rendering/RenderThemeChromiumLinux.cpp:
508         (WebCore::RenderThemeChromiumLinux::paintSliderThumb):
509           isPressed() is enough.
510         * rendering/RenderThemeChromiumWin.cpp:
511           isEnabled(), isFocused(), and isPressed() are enough.
512         (WebCore::RenderThemeChromiumWin::determineSliderThumbState):
513         (WebCore::RenderThemeChromiumWin::determineClassicState):
514         * rendering/RenderThemeMac.mm:
515         (WebCore::RenderThemeMac::paintSliderThumb):
516           - Remove isSlider() check.
517           - Passing 'o' to udpateFooState functions is enough.
518           - isPressed() is enough.
519         * rendering/RenderThemeSafari.cpp:
520         (WebCore::RenderThemeSafari::paintSliderThumb):
521           We don't need special handling anymore.
522         * rendering/RenderThemeWin.cpp:
523         (WebCore::RenderThemeWin::determineSliderThumbState):
524           isEnabled(), isFocused(), and isPressed() are enough.
525
526 2011-06-08  Adam Barth  <abarth@webkit.org>
527
528         Reviewed by Eric Seidel.
529
530         constructTreeFromToken can re-enter parser, causing ASSERTs
531         https://bugs.webkit.org/show_bug.cgi?id=62160
532
533         This patch clears the HTMLToken before constructing the tree from the
534         token, putting the HTMLDocumentParser in a good state to be re-entered.
535
536         Tests: fast/parser/document-write-onload-nesting.html
537                fast/parser/document-write-onload-ordering.html
538
539         * html/parser/HTMLDocumentParser.cpp:
540         (WebCore::HTMLDocumentParser::pumpTokenizer):
541         * html/parser/HTMLToken.h:
542         (WebCore::HTMLToken::isUninitialized):
543         * html/parser/HTMLTreeBuilder.cpp:
544         (WebCore::HTMLTreeBuilder::constructTreeFromToken):
545
546 2011-06-08  Kent Tamura  <tkent@chromium.org>
547
548         Fix Qt build for r88405.
549         https://bugs.webkit.org/show_bug.cgi?id=62208
550
551         * platform/qt/RenderThemeQt.h:
552
553 2011-06-08  Kent Tamura  <tkent@chromium.org>
554
555         Reviewed by Dimitri Glazkov.
556
557         Change the argument of RenderTheme::adjustSliderThumbSize(): RenderObject* -> RenderStyle*
558         https://bugs.webkit.org/show_bug.cgi?id=62208
559
560         Change the argument type of RenderTheme::adjustSliderThumbSize() and
561         RenderMediaControls::adjustMediaSliderThumbSize() from RenderObject* to RenderStyle*.
562
563         Also, each of adjustSliderThumbStyle() overrides calls RenderTheme::
564         adjustSliderThumbStyle() for future changes.
565
566         No new tests. This is a refactoring and should not change any behavior.
567
568         * html/shadow/SliderThumbElement.cpp:
569         (WebCore::RenderSliderThumb::layout): Passing RenderStyle* and remove a FIXME comment.
570         * platform/efl/RenderThemeEfl.cpp:
571         (WebCore::RenderThemeEfl::adjustSliderThumbStyle): Calls RenderTheme::adjustSliderThumbStyle().
572         * platform/gtk/RenderThemeGtk.cpp:
573         (WebCore::RenderThemeGtk::adjustSliderThumbStyle): ditto.
574         (WebCore::RenderThemeGtk::adjustMediaSliderThumbSize):
575         * platform/gtk/RenderThemeGtk.h:
576         * platform/gtk/RenderThemeGtk2.cpp:
577         (WebCore::RenderThemeGtk::adjustSliderThumbSize):
578         * platform/gtk/RenderThemeGtk3.cpp:
579         (WebCore::RenderThemeGtk::adjustSliderThumbSize):
580         * platform/qt/RenderThemeQt.cpp:
581         (WebCore::RenderThemeQt::adjustSliderThumbStyle): ditto.
582         (WebCore::RenderThemeQt::adjustSliderThumbSize):
583         * rendering/RenderMediaControls.cpp:
584         (WebCore::RenderMediaControls::adjustMediaSliderThumbSize):
585         * rendering/RenderMediaControls.h:
586         * rendering/RenderMediaControlsChromium.cpp:
587         (WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize):
588         * rendering/RenderMediaControlsChromium.h:
589         * rendering/RenderSlider.cpp:
590         (WebCore::RenderSlider::layout): Passing RenderStyle* and remove a FIXME comment.
591         * rendering/RenderTheme.cpp:
592         (WebCore::RenderTheme::adjustSliderThumbStyle): Add a comment.
593         (WebCore::RenderTheme::adjustSliderThumbSize):
594         * rendering/RenderTheme.h:
595         * rendering/RenderThemeChromiumLinux.cpp:
596         (WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
597         * rendering/RenderThemeChromiumLinux.h:
598         * rendering/RenderThemeChromiumMac.h:
599         * rendering/RenderThemeChromiumMac.mm:
600         (WebCore::RenderThemeChromiumMac::adjustMediaSliderThumbSize):
601         * rendering/RenderThemeChromiumSkia.cpp:
602         (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):
603         * rendering/RenderThemeChromiumSkia.h:
604         * rendering/RenderThemeChromiumWin.cpp:
605         (WebCore::RenderThemeChromiumWin::adjustSliderThumbSize):
606         * rendering/RenderThemeChromiumWin.h:
607         * rendering/RenderThemeMac.h:
608         * rendering/RenderThemeMac.mm:
609         (WebCore::RenderThemeMac::adjustSliderThumbStyle): Calls RenderTheme::adjustSliderThumbStyle().
610         (WebCore::RenderThemeMac::adjustSliderThumbSize):
611         (WebCore::RenderThemeMac::adjustMediaSliderThumbSize):
612         * rendering/RenderThemeSafari.cpp:
613         (WebCore::RenderThemeSafari::adjustSliderThumbStyle): Calls RenderTheme::adjustSliderThumbStyle().
614         (WebCore::RenderThemeSafari::adjustSliderThumbSize):
615         * rendering/RenderThemeSafari.h:
616         * rendering/RenderThemeWin.cpp:
617         (WebCore::RenderThemeWin::adjustSliderThumbSize):
618         * rendering/RenderThemeWin.h:
619         * rendering/RenderThemeWinCE.cpp:
620         (WebCore::RenderThemeWinCE::adjustSliderThumbSize):
621         * rendering/RenderThemeWinCE.h:
622
623 2011-06-08  Brian Salomon  <bsalomon@google.com>
624
625         Reviewed by James Robinson.
626
627         Avoid always binding FBO 0 implicitly when deleting FBO in DrawingBuffer code because it invalidates Ganesh's cache of the current FBO.
628         https://bugs.webkit.org/show_bug.cgi?id=62318
629
630         Chromium-only crash
631         Failures takes multiple seconds to occur, relying on JS garbage-collection to occur 
632         http://www.hotbazooka.com/privatejoe-large
633
634         * platform/graphics/gpu/DrawingBuffer.cpp:
635         (WebCore::DrawingBuffer::clear):
636
637 2011-06-08  Emil A Eklund  <eae@chromium.org>
638
639         Reviewed by Eric Seidel.
640
641         RenderEmbeddedObject::getReplacementTextGeometry
642         https://bugs.webkit.org/show_bug.cgi?id=62313
643
644         Replace the last use of tx, ty with IntPoint.
645
646         Covered by existing tests.
647
648         * platform/graphics/FloatRect.h:
649         (WebCore::FloatRect::move):
650         (WebCore::FloatRect::moveBy):
651         * rendering/RenderEmbeddedObject.cpp:
652         (WebCore::RenderEmbeddedObject::paintReplaced):
653         (WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
654         (WebCore::RenderEmbeddedObject::isInMissingPluginIndicator):
655         * rendering/RenderEmbeddedObject.h:
656
657 2011-06-08  Tim Horton  <timothy_horton@apple.com>
658
659         Reviewed by Ryosuke Niwa.
660
661         Use correct CFURLStorageSessionRef definition on Leopard, as
662         we created an inconsistency in const-ness between
663         WebCoreSystemInterface.h and these two files in the case
664         of Leopard only.
665         https://bugs.webkit.org/show_bug.cgi?id=62223
666
667         * platform/network/ResourceHandle.h:
668         * platform/network/cf/ResourceRequest.h:
669
670 2011-06-08  Sailesh Agrawal  <sail@chromium.org>
671
672         Reviewed by Mihai Parparita.
673
674         Chromium Mac: Enable overlay scrollbars
675         https://bugs.webkit.org/show_bug.cgi?id=59756
676
677         Sync ScrollbarThemeChromiumMac.mm/.h with ScrollbarThemeMac.mm to pick up support for overlay scrollbars. The only changes are renaming ScrollbarThemeMac to ScrollbarThemeChromiumMac and using runtime checks instead of #ifdef's.
678
679         No new tests, since this code is only enabled on future versions of Mac OS X.
680
681         * platform/chromium/ScrollAnimatorChromiumMac.mm: All changes to this file except in scroll() were to swap #if USE(WK_SCROLLBAR_PAINTER) with runtime checks.
682         (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac):
683         (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac):
684         (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged):
685         (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint):
686         (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea):
687         (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea):
688         (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea):
689         (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize):
690         (WebCore::ScrollAnimatorChromiumMac::contentsResized):
691         (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize):
692         (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow):
693         (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide):
694         (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture):
695         (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture):
696         (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar):
697         (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar):
698         (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar):
699         (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar):
700         (WebCore::ScrollAnimatorChromiumMac::cancelAnimations):
701         * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
702         (preferredScrollerStyle): Disabled overlay scrollbar styles due to trailing artifacts.
703         (wkScrollbarPainterPaint): Fixed a problem where the scrollbar track wasn't being drawn.
704         (wkScrollbarPainterKnobRect): Implemented a previously unimplemented function.
705         (wkSetScrollbarPainterKnobStyle): Implemented a function that's now supported by the latest Mac OS X seeds.
706         (isScrollbarOverlayAPIAvailable): Enabled new scrollbar code.
707         * platform/chromium/ScrollbarThemeChromiumMac.h:
708         * platform/chromium/ScrollbarThemeChromiumMac.mm: Sync with ScrollbarThemeMac.mm.
709         (WebCore::scrollbarMap):
710         (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
711         (WebCore::updateArrowPlacement):
712         (WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
713         (WebCore::ScrollbarThemeChromiumMac::unregisterScrollbar):
714         (WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
715         (WebCore::ScrollbarThemeChromiumMac::painterForScrollbar):
716         (WebCore::ScrollbarThemeChromiumMac::scrollbarThickness):
717         (WebCore::ScrollbarThemeChromiumMac::usesOverlayScrollbars):
718         (WebCore::ScrollbarThemeChromiumMac::hasButtons):
719         (WebCore::ScrollbarThemeChromiumMac::hasThumb):
720         (WebCore::buttonRepaintRect):
721         (WebCore::ScrollbarThemeChromiumMac::minimumThumbLength):
722         (WebCore::ScrollbarThemeChromiumMac::shouldDragDocumentInsteadOfThumb):
723         (WebCore::toScrollbarPainterKnobStyle):
724         (WebCore::ScrollbarThemeChromiumMac::paint):
725
726 2011-06-06  Nate Chapin  <japhet@chromium.org>
727
728         Reviewed by Adam Barth.
729
730         Remove all knowledge of CachedResourceRequests from
731         CachedResourceLoader. This puts the full burden of
732         canceling these requests on DocumentLoader (via
733         SubresourceLoader), and makes a CachedResourceRequest
734         an OwnPtr in CachedResource.
735
736         https://bugs.webkit.org/show_bug.cgi?id=62308
737
738         * loader/FrameLoader.cpp:
739         (WebCore::FrameLoader::stopLoading):
740         * loader/cache/CachedResource.cpp:
741         (WebCore::CachedResource::CachedResource):
742         (WebCore::CachedResource::load):
743         (WebCore::CachedResource::stopLoading):
744         * loader/cache/CachedResource.h:
745         * loader/cache/CachedResourceLoader.cpp:
746         (WebCore::CachedResourceLoader::~CachedResourceLoader):
747         (WebCore::CachedResourceLoader::loadDone):
748         * loader/cache/CachedResourceLoader.h:
749         * loader/cache/CachedResourceRequest.cpp:
750         (WebCore::CachedResourceRequest::CachedResourceRequest):
751         (WebCore::CachedResourceRequest::~CachedResourceRequest):
752         (WebCore::CachedResourceRequest::load):
753         (WebCore::CachedResourceRequest::didFinishLoading):
754         (WebCore::CachedResourceRequest::didFail):
755         (WebCore::CachedResourceRequest::didReceiveResponse):
756         (WebCore::CachedResourceRequest::end):
757         * loader/cache/CachedResourceRequest.h:
758
759 2011-06-08  Mike Reed  <reed@google.com>
760
761         Reviewed by James Robinson.
762
763         [Skia] check for null-shader from gradient factory
764         https://bugs.webkit.org/show_bug.cgi?id=62319
765
766         * platform/graphics/skia/GradientSkia.cpp:
767         (WebCore::Gradient::platformDestroy):
768         (WebCore::Gradient::platformGradient):
769
770 2011-06-08  Kenneth Russell  <kbr@google.com>
771
772         Reviewed by Adam Barth.
773
774         Disallow use of cross-domain media (images, video) in WebGL
775         https://bugs.webkit.org/show_bug.cgi?id=62257
776
777         Updated WebGL implementation to track recent spec updates in this area.
778
779         Tests: http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html
780                http/tests/security/webgl-remote-read-remote-image-allowed.html
781                http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html
782
783         * html/canvas/CanvasRenderingContext.cpp:
784         (WebCore::CanvasRenderingContext::wouldTaintOrigin):
785         (WebCore::CanvasRenderingContext::checkOrigin):
786         * html/canvas/CanvasRenderingContext.h:
787         (WebCore::CanvasRenderingContext::checkOrigin):
788         * html/canvas/WebGLRenderingContext.cpp:
789         (WebCore::WebGLRenderingContext::readPixels):
790         (WebCore::WebGLRenderingContext::texImage2D):
791         (WebCore::WebGLRenderingContext::videoFrameToImage):
792         (WebCore::WebGLRenderingContext::texSubImage2D):
793         * html/canvas/WebGLRenderingContext.h:
794
795 2011-06-08  John Bauman  <jbauman@chromium.org>
796
797         Reviewed by James Robinson.
798
799         Only draw portions of tiles in contentRect
800         https://bugs.webkit.org/show_bug.cgi?id=62243
801
802         Old garbage data can remain in tiles, so make sure to draw only those
803         portions that are supposed to be drawn.
804
805         Test: compositing/repaint/shrink-layer.html
806
807         * platform/graphics/chromium/LayerTilerChromium.cpp:
808         (WebCore::LayerTilerChromium::draw):
809
810 2011-06-08  Emil A Eklund  <eae@chromium.org>
811
812         Reviewed by Eric Seidel.
813
814         Convert RenderBlock::isPointInOverflowControl to IntPoint
815         https://bugs.webkit.org/show_bug.cgi?id=62312
816
817         Covered by existing tests.
818
819         * rendering/RenderBlock.cpp:
820         (WebCore::RenderBlock::isPointInOverflowControl):
821         (WebCore::RenderBlock::nodeAtPoint):
822         * rendering/RenderBlock.h:
823         * rendering/RenderListBox.cpp:
824         (WebCore::RenderListBox::isPointInOverflowControl):
825         * rendering/RenderListBox.h:
826
827 2011-06-08  James Simonsen  <simonjam@chromium.org>
828
829         Reviewed by Tony Gentilcore.
830
831         Fix clang issue, virtual function const mismatch
832         https://bugs.webkit.org/show_bug.cgi?id=62307
833
834         No new tests. Built with clang & ran layout tests.
835
836         * page/MediaStreamFrameController.h:
837         (WebCore::MediaStreamFrameController::GenericClient::isGenericClient):
838
839 2011-06-08  Chris Rogers  <crogers@google.com>
840
841         Reviewed by Kenneth Russell.
842
843         Implement BiquadFilterNode for filter types: LOWPASS, HIGHPASS, BANDPASS, LOWSHELF, HIGHSHELF, PEAKING, NOTCH, ALLPASS
844         https://bugs.webkit.org/show_bug.cgi?id=62078
845
846         No new tests since audio API is not yet implemented.
847
848         * DerivedSources.make:
849         * WebCore.gypi:
850         * WebCore.xcodeproj/project.pbxproj:
851         * platform/audio/Biquad.cpp:
852         (WebCore::Biquad::Biquad):
853         (WebCore::Biquad::reset):
854         (WebCore::Biquad::setLowpassParams):
855         (WebCore::Biquad::setHighpassParams):
856         (WebCore::Biquad::setNormalizedCoefficients):
857         (WebCore::Biquad::setLowShelfParams):
858         (WebCore::Biquad::setHighShelfParams):
859         (WebCore::Biquad::setPeakingParams):
860         (WebCore::Biquad::setAllpassParams):
861         (WebCore::Biquad::setNotchParams):
862         (WebCore::Biquad::setBandpassParams):
863         (WebCore::Biquad::setZeroPolePairs):
864         (WebCore::Biquad::setAllpassPole):
865         * platform/audio/Biquad.h:
866         * webaudio/AudioContext.cpp:
867         (WebCore::AudioContext::createBiquadFilter):
868         (WebCore::AudioContext::createLowPass2Filter):
869         (WebCore::AudioContext::createHighPass2Filter):
870         * webaudio/AudioContext.h:
871         * webaudio/AudioContext.idl:
872         * webaudio/AudioNode.h:
873         * webaudio/BiquadDSPKernel.cpp:
874         (WebCore::BiquadDSPKernel::process):
875         * webaudio/BiquadFilterNode.cpp: Added.
876         (WebCore::BiquadFilterNode::BiquadFilterNode):
877         * webaudio/BiquadFilterNode.h: Added.
878         (WebCore::BiquadFilterNode::create):
879         (WebCore::BiquadFilterNode::type):
880         (WebCore::BiquadFilterNode::setType):
881         (WebCore::BiquadFilterNode::frequency):
882         (WebCore::BiquadFilterNode::q):
883         (WebCore::BiquadFilterNode::gain):
884         (WebCore::BiquadFilterNode::biquadProcessor):
885         * webaudio/BiquadFilterNode.idl: Added.
886         * webaudio/BiquadProcessor.cpp:
887         (WebCore::BiquadProcessor::BiquadProcessor):
888         * webaudio/BiquadProcessor.h:
889         (WebCore::BiquadProcessor::setType):
890         * webaudio/HighPass2FilterNode.cpp:
891         (WebCore::HighPass2FilterNode::HighPass2FilterNode):
892         * webaudio/LowPass2FilterNode.cpp:
893         (WebCore::LowPass2FilterNode::LowPass2FilterNode):
894
895 2011-06-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
896
897         Reviewed by Kenneth Rohde Christiansen.
898
899         WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
900         https://bugs.webkit.org/show_bug.cgi?id=61694
901
902         No new tests, code path is not activated yet.
903
904         * WebCore.xcodeproj/project.pbxproj: Changed the TransformOperation subclassed from "project" to "private"
905
906 2011-06-08  Tom Sepez  <tsepez@chromium.org>
907
908         Reviewed by Adam Barth.
909
910         Cause checks for insecure content blocking policy to callback to client.
911         https://bugs.webkit.org/show_bug.cgi?id=61946
912         Tests: platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed.html
913                platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked.html
914                platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-allowed.html
915                platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-blocked.html
916
917         * loader/FrameLoader.cpp:
918         (WebCore::FrameLoader::checkIfDisplayInsecureContent):
919         (WebCore::FrameLoader::checkIfRunInsecureContent):
920         * loader/FrameLoaderClient.h:
921         (WebCore::FrameLoaderClient::allowDisplayingInsecureContent):
922         (WebCore::FrameLoaderClient::allowRunningInsecureContent):
923
924 2011-06-08  Kevin Ollivier  <kevino@theolliviers.com>
925
926         [wx] Build fix after introduction of FontCache::ShouldRetain
927
928         * platform/graphics/wx/FontCacheWx.cpp:
929         (WebCore::FontCache::getFontDataForCharacters):
930
931 2011-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
932
933         Unreviewed, rolling out r88365.
934         http://trac.webkit.org/changeset/88365
935         https://bugs.webkit.org/show_bug.cgi?id=62301
936
937         windows bots broken (Requested by loislo_ on #webkit).
938
939         * inspector/InspectorValues.cpp:
940         (WebCore::InspectorBasicValue::writeJSON):
941
942 2011-06-08  Mikołaj Małecki  <m.malecki@samsung.com>
943
944         Reviewed by Pavel Feldman.
945
946         Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
947         https://bugs.webkit.org/show_bug.cgi?id=52791
948
949         No new tests. The problem can be reproduced by trying to create InspectorValue
950         from 1.0e-100 and call ->toJSONString() on this.
951
952         * inspector/InspectorValues.cpp:
953         (WebCore::InspectorBasicValue::writeJSON):
954         Added checking the predicted buffer size and choosing exponential format, or
955         eventually "NaN" if the buffer is too small for decimal format.
956
957 2011-06-08  Nico Weber  <thakis@chromium.org>
958
959         Reviewed by Darin Adler.
960
961         Fix a ?: precedence error in ScrollbarThemeMac and ScrollbarThemeChromium
962         https://bugs.webkit.org/show_bug.cgi?id=62295
963
964         This was found by a new warning recently added to clang's -Wparentheses
965
966         * platform/chromium/ScrollbarThemeChromiumMac.mm:
967         (WebCore::ScrollbarThemeChromiumMac::backButtonRect):
968         * platform/mac/ScrollbarThemeMac.mm:
969         (WebCore::ScrollbarThemeMac::backButtonRect):
970
971 2011-06-08  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
972
973         Reviewed by Andreas Kling.
974
975         [Qt] Remove dead code from our JSC bridge
976         https://bugs.webkit.org/show_bug.cgi?id=62287
977
978         The m_defaultMethod member is not used since r36848 and QtMethod
979         was replaced by QtRuntimeMethod and subclasses in r29729.
980
981         * bridge/qt/qt_instance.cpp:
982         (JSC::Bindings::QtInstance::removeCachedMethod):
983         (JSC::Bindings::QtInstance::visitAggregate):
984         * bridge/qt/qt_instance.h:
985         * bridge/qt/qt_runtime.h:
986
987 2011-06-08  Ryan Sleevi  <rsleevi@chromium.org>
988
989         Reviewed by Tony Chang.
990
991         Suppress C++0x compat warnings when compiling Chromium port with GCC 4.6
992
993         Compiling Chromium port under GCC 4.6 produces warnings about nullptr
994         https://bugs.webkit.org/show_bug.cgi?id=62242
995
996         * WebCore.gyp/WebCore.gyp:
997
998 2011-05-25  Xiaomei Ji  <xji@chromium.org>
999
1000         Reviewed by Ryosuke Niwa.
1001
1002         --webkit-visual-word does not work well in words separated by multiple spaces
1003         https://bugs.webkit.org/show_bug.cgi?id=61324
1004
1005         Remove positionBeforeNextWord and positionAfterPreviousWord short-cuts. They try to find the
1006         right word boundary (before the space or after the space) by using previousWordPosition and
1007         nextWordPosition. But they assume words are separated by single space and are not correct 
1008         for words separated by multiple spaces and words not separated by space.
1009
1010         Consider positionBeforeNextWord() for example, 
1011
1012         First, it checks whether the current position is after the current word by checking current
1013         position's previousWordPosition's nextWordPosition is the same as current position, which is
1014         wrong for words separated by multiple spaces. For example, given words A and B separated by 
1015         3 continuous spaces "A   B", position "A|", "A |", and "A  |" should all be considered as 
1016         position after current word. But for position "A |", its previousWordPosition's 
1017         nextWordPosition is position "A|", which is different from its current position, so the
1018         current position is not considered as a position after current word, consequently,
1019         instead of returning the right position as "A   |B", positionBeforeNextWord returns the
1020         position before next next word, as "A   B |C". Similar happens for position "A  |".
1021
1022         Second, given 3 Chinese words "ABC" that are not segmented by space, when cursor is at 
1023         "A|BC", positionBeforeNextWord() returns the same position after calling current position's
1024         nextWordPosition's previousWordPosition. It should returns position "AB|C".
1025
1026         For those cases, we will have to collect all the word breaks inside the box and look for
1027         the one at left or right of current position.
1028
1029         * editing/visible_units.cpp:
1030         (WebCore::leftWordPosition):
1031         (WebCore::rightWordPosition):
1032
1033 2011-06-08  Greg Simon  <gregsimon@chromium.org>
1034
1035         Reviewed by Dimitri Glazkov.
1036
1037         Control Indexeddb backends from LayoutTestController
1038         https://bugs.webkit.org/show_bug.cgi?id=61000
1039
1040         Test: storage/indexeddb/migrate-basics.html
1041
1042         * storage/IDBBackingStore.h:
1043         * storage/IDBFactoryBackendImpl.cpp:
1044         (WebCore::IDBFactoryBackendImpl::open):
1045         (WebCore::IDBFactoryBackendImpl::migrate):
1046         * storage/IDBFactoryBackendImpl.h:
1047         * storage/IDBFactoryBackendInterface.h:
1048         * storage/IDBLevelDBBackingStore.cpp:
1049         (WebCore::IDBLevelDBBackingStore::backingStoreExists):
1050         * storage/IDBLevelDBBackingStore.h:
1051         (WebCore::IDBLevelDBBackingStore::backingStoreType):
1052         * storage/IDBSQLiteBackingStore.cpp:
1053         (WebCore::IDBSQLiteBackingStore::backingStoreExists):
1054         * storage/IDBSQLiteBackingStore.h:
1055         (WebCore::IDBSQLiteBackingStore::backingStoreType):
1056
1057 2011-06-08  Dmitry Lomov  <dslomov@google.com>
1058
1059         Reviewed by Adam Barth.
1060
1061         https://bugs.webkit.org/show_bug.cgi?id=62164
1062         Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and friends
1063         This functionality is untested and unused:
1064         This is an old code from Lockers-based implementation of WebWorkers in
1065         V8 bindings, to make sure that DOM objects are released on the right thread
1066         even though GC could have happened on any thread. It is currently unused (since
1067         current model is one worker per process) and is being removed because new implementation
1068         of WebWorkers will be using V8 isolates.
1069
1070         * WebCore.gypi:
1071         * WebCore.pro:
1072         * bindings/v8/ChildThreadDOMData.cpp: Removed.
1073         * bindings/v8/ChildThreadDOMData.h: Removed.
1074         * bindings/v8/DOMData.cpp:
1075         (WebCore::DOMData::DOMData):
1076         (WebCore::DOMData::getCurrent):
1077         (WebCore::DOMData::getMainThreadStore):
1078         * bindings/v8/DOMData.h:
1079         (WebCore::DOMData::getStore):
1080         (WebCore::DOMData::getCurrentMainThreadStore):
1081         (WebCore::DOMData::handleWeakObject):
1082         * bindings/v8/DOMDataStore.cpp:
1083         (WebCore::DOMDataStore::DOMDataStore):
1084         (WebCore::DOMDataStore::~DOMDataStore):
1085         (WebCore::DOMDataStore::weakNodeCallback):
1086         * bindings/v8/DOMDataStore.h:
1087         * bindings/v8/MainThreadDOMData.cpp: Removed.
1088         * bindings/v8/MainThreadDOMData.h: Removed.
1089         * bindings/v8/V8DOMMap.cpp:
1090         (WebCore::getDOMDataStore):
1091         (WebCore::removeAllDOMObjects):
1092         (WebCore::visitDOMNodes):
1093         (WebCore::visitDOMObjects):
1094         (WebCore::visitActiveDOMObjects):
1095         (WebCore::visitDOMSVGElementInstances):
1096         * bindings/v8/V8DOMMap.h:
1097         * bindings/v8/V8GCController.cpp:
1098         (WebCore::V8GCController::gcPrologue):
1099         (WebCore::V8GCController::gcEpilogue):
1100         * bindings/v8/WorkerScriptController.cpp:
1101         (WebCore::WorkerScriptController::~WorkerScriptController):
1102
1103 2011-06-08  Yael Aharon  <yael.aharon@nokia.com>
1104
1105         Reviewed by Andreas Kling.
1106
1107         [Qt] Build fix for building QtWebKit inside of Qt.
1108         https://bugs.webkit.org/show_bug.cgi?id=62280
1109
1110         Remove CONFIG=staticlib, because it causes the configure script to add -lwebcore
1111         into QtWebKit.prl.
1112
1113         No new tests, as this is just a build fix.
1114
1115         * WebCore.pri:
1116
1117 2011-06-08  Vsevolod Vlasov  <vsevik@chromium.org>
1118
1119         Reviewed by Pavel Feldman.
1120
1121         Web Inspector: Render non-document HTML resources as HTML
1122         https://bugs.webkit.org/show_bug.cgi?id=58886
1123
1124         * English.lproj/localizedStrings.js:
1125         * WebCore.gypi:
1126         * WebCore.vcproj/WebCore.vcproj:
1127         * inspector/front-end/NetworkItemView.js:
1128         (WebInspector.NetworkItemView):
1129         * inspector/front-end/Resource.js:
1130         (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
1131         (WebInspector.Resource.prototype.hasErrorStatusCode):
1132         * inspector/front-end/ResourceHTMLView.js: Added.
1133         (WebInspector.ResourceHTMLView):
1134         (WebInspector.ResourceHTMLView.prototype.hasContent):
1135         (WebInspector.ResourceHTMLView.prototype.show):
1136         (WebInspector.ResourceHTMLView.prototype.hide):
1137         (WebInspector.ResourceHTMLView.prototype._createIFrame):
1138         * inspector/front-end/ResourcePreviewView.js: Added.
1139         (WebInspector.ResourcePreviewView):
1140         (WebInspector.ResourcePreviewView.prototype.hasContent):
1141         (WebInspector.ResourcePreviewView.prototype.show):
1142         (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown.callback):
1143         (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown):
1144         (WebInspector.ResourcePreviewView.prototype._createInnerView):
1145         * inspector/front-end/Settings.js:
1146         (WebInspector.Settings):
1147         * inspector/front-end/WebKit.qrc:
1148         * inspector/front-end/inspector.css:
1149         (.resource-view.html iframe):
1150         * inspector/front-end/inspector.html:
1151
1152 2011-05-18  Pavel Podivilov  <podivilov@chromium.org>
1153
1154         Reviewed by Yury Semikhatsky.
1155
1156         Web Inspector: hide script location to ui location conversion details from ScriptsPanel.
1157         https://bugs.webkit.org/show_bug.cgi?id=61035
1158
1159         * inspector/front-end/DebuggerPresentationModel.js:
1160         (WebInspector.DebuggerPresentationModel.prototype.sourceFileForScriptURL):
1161         (WebInspector.DebuggerPresentationModel.prototype.scriptLocationToUILocation.didRequestSourceMapping):
1162         (WebInspector.DebuggerPresentationModel.prototype.scriptLocationToUILocation):
1163         * inspector/front-end/ScriptsPanel.js:
1164         (WebInspector.ScriptsPanel.prototype.showAnchorLocation.didGetUILocation):
1165         (WebInspector.ScriptsPanel.prototype.showAnchorLocation):
1166
1167 2011-06-08  Tommy Widenflycht  <tommyw@google.com>
1168
1169         Reviewed by Tony Gentilcore.
1170
1171         StreamEvent
1172
1173         Media Stream PeerConnection API: adding StreamEvent class
1174         https://bugs.webkit.org/show_bug.cgi?id=61537
1175
1176         Tests for the Media Stream API will be provided by the bug 56587.
1177
1178         * CMakeLists.txt:
1179         * CodeGenerators.pri:
1180         * DerivedSources.cpp:
1181         * DerivedSources.make:
1182         * GNUmakefile.list.am:
1183         * WebCore.gypi:
1184         * WebCore.pro:
1185         * WebCore.vcproj/WebCore.vcproj:
1186         * WebCore.xcodeproj/project.pbxproj:
1187         * bindings/js/JSEventCustom.cpp:
1188         (WebCore::toJS):
1189         * bindings/v8/custom/V8EventCustom.cpp:
1190         (WebCore::toV8):
1191         * dom/DOMAllInOne.cpp:
1192         * dom/Event.cpp:
1193         (WebCore::Event::isStreamEvent):
1194         * dom/Event.h:
1195         * dom/StreamEvent.cpp: Added.
1196         (WebCore::StreamEvent::create):
1197         (WebCore::StreamEvent::StreamEvent):
1198         (WebCore::StreamEvent::~StreamEvent):
1199         (WebCore::StreamEvent::initStreamEvent):
1200         (WebCore::StreamEvent::stream):
1201         * dom/StreamEvent.h: Added.
1202         (WebCore::StreamEvent::isStreamEvent):
1203         * dom/StreamEvent.idl: Added.
1204
1205 2011-06-08  Tommy Widenflycht  <tommyw@google.com>
1206
1207         Reviewed by Tony Gentilcore.
1208
1209         Media Stream API: integrate the Track List objects into the existing code.
1210         https://bugs.webkit.org/show_bug.cgi?id=60205
1211
1212         Tests for the Media Stream API will be provided by the bug 56587.
1213
1214         * dom/ExclusiveTrackList.cpp:
1215         (WebCore::ExclusiveTrackList::select):
1216         (WebCore::ExclusiveTrackList::trackFailed):
1217         * dom/ExclusiveTrackList.h:
1218         * dom/GeneratedStream.cpp:
1219         (WebCore::GeneratedStream::create):
1220         (WebCore::GeneratedStream::GeneratedStream):
1221         (WebCore::GeneratedStream::streamEnded):
1222         (WebCore::GeneratedStream::audioTracks):
1223         (WebCore::GeneratedStream::videoTracks):
1224         (WebCore::GeneratedStream::stop):
1225         * dom/GeneratedStream.h:
1226         * dom/GeneratedStream.idl:
1227         * dom/MultipleTrackList.cpp:
1228         (WebCore::MultipleTrackList::trackFailed):
1229         (WebCore::MultipleTrackList::enable):
1230         (WebCore::MultipleTrackList::disable):
1231         * dom/MultipleTrackList.h:
1232         * dom/Stream.h:
1233         * dom/TrackList.cpp:
1234         (WebCore::TrackList::clear):
1235         (WebCore::TrackList::associateStream):
1236         (WebCore::TrackList::associatedStreamLabel):
1237         (WebCore::TrackList::trackFailed):
1238         (WebCore::TrackList::scriptExecutionContext):
1239         * dom/TrackList.h:
1240         * page/MediaStreamClient.h:
1241         * page/MediaStreamController.cpp:
1242         (WebCore::MediaStreamController::enableAudioTrack):
1243         (WebCore::MediaStreamController::disableAudioTrack):
1244         (WebCore::MediaStreamController::selectVideoTrack):
1245         (WebCore::MediaStreamController::streamGenerated):
1246         (WebCore::MediaStreamController::audioTrackFailed):
1247         (WebCore::MediaStreamController::videoTrackFailed):
1248         * page/MediaStreamController.h:
1249         * page/MediaStreamFrameController.cpp:
1250         (WebCore::MediaStreamFrameController::unregister):
1251         (WebCore::MediaStreamFrameController::enterDetachedState):
1252         (WebCore::MediaStreamFrameController::disconnectFrame):
1253         (WebCore::MediaStreamFrameController::enableAudioTrack):
1254         (WebCore::MediaStreamFrameController::disableAudioTrack):
1255         (WebCore::MediaStreamFrameController::selectVideoTrack):
1256         (WebCore::MediaStreamFrameController::streamGenerated):
1257         (WebCore::MediaStreamFrameController::audioTrackFailed):
1258         (WebCore::MediaStreamFrameController::videoTrackFailed):
1259         * page/MediaStreamFrameController.h:
1260         (WebCore::MediaStreamFrameController::ClientBase::isGenericClient):
1261         (WebCore::MediaStreamFrameController::GenericClient::GenericClient):
1262         (WebCore::MediaStreamFrameController::GenericClient::~GenericClient):
1263         (WebCore::MediaStreamFrameController::GenericClient::isGenericClient):
1264         (WebCore::MediaStreamFrameController::GenericClient::unregister):
1265
1266 2011-06-08  Pavel Podivilov  <podivilov@chromium.org>
1267
1268         Reviewed by Yury Semikhatsky.
1269
1270         Web Inspector: [REGRESSION] breakpoints are not persisted.
1271         https://bugs.webkit.org/show_bug.cgi?id=62273
1272
1273         * inspector/front-end/Settings.js:
1274
1275 2011-06-08  Alexander Pavlov  <apavlov@chromium.org>
1276
1277         Reviewed by Yury Semikhatsky.
1278
1279         Web Inspector: node selection is slow in the Elements panel.
1280         https://bugs.webkit.org/show_bug.cgi?id=60813
1281
1282         Schedule full style updates rather than request all node styles from the backend immediately.
1283
1284         * inspector/front-end/StylesSidebarPane.js:
1285         (WebInspector.StylesSidebarPane.prototype.update.reloadAllStyles):
1286         (WebInspector.StylesSidebarPane.prototype.update):
1287
1288 2011-06-08  Andreas Kling  <andreas.kling@nokia.com>
1289
1290         Reviewed by Laszlo Gombos.
1291
1292         [Symbian] Float{32,64}Array and Int16Array fail to build.
1293         https://bugs.webkit.org/show_bug.cgi?id=62219
1294
1295         For some reason, RVCT 2.x is moaning about "class member designated by
1296         a using-declaration must be visible in a direct base class".
1297         Apply same fix as r69122 and r76592.
1298
1299         * html/canvas/Float32Array.h:
1300         (WebCore::Float32Array::set):
1301         * html/canvas/Float64Array.h:
1302         (WebCore::Float64Array::set):
1303         * html/canvas/Int16Array.h:
1304         (WebCore::Int16Array::set):
1305
1306 2011-06-08  Syed Idris Shah  <syed.idris-shah@nokia.com>
1307
1308         Reviewed by Andreas Kling.
1309
1310         [Qt] GL_POINT_SPRITE and GL_VERTEX_PROGRAM_POINT_SIZE should be enabled for desktop WebGL
1311         https://bugs.webkit.org/show_bug.cgi?id=61945
1312
1313         For OpenGL ES we do not need these features. 
1314         These features are available via shaders in OpenGL ES. But for desktop WebGL using QtWebKit they should be enabled.
1315
1316         LayoutTests/fast/canvas/webgl/point-size.html
1317
1318         * platform/graphics/qt/GraphicsContext3DQt.cpp:
1319         (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
1320
1321 2011-06-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1322
1323         Unreviewed. Fix style error.
1324
1325         * platform/efl/RenderThemeEfl.cpp:
1326         * platform/efl/RenderThemeEfl.h:
1327
1328 2011-06-08  Hironori Bono  <hbono@chromium.org>
1329
1330         Reviewed by Brent Fulgham.
1331
1332         Add SpellCheck API
1333         https://bugs.webkit.org/show_bug.cgi?id=59693
1334
1335         This change adds two SpellCheck API functions (addSpellcheckRange and
1336         removeSpellcheckRange) and one attribute (spellcheckRange) discussed in
1337         the public-webapps ML. This change is currently available only on Chromium.
1338
1339         Tests: editing/spelling/spellcheck-api-pixel.html
1340                editing/spelling/spellcheck-api.html
1341
1342         * WebCore.gypi:
1343         * bindings/generic/RuntimeEnabledFeatures.cpp:
1344         * bindings/generic/RuntimeEnabledFeatures.h:
1345         (WebCore::RuntimeEnabledFeatures::spellCheckAPIEnabled):
1346         (WebCore::RuntimeEnabledFeatures::setSpellCheckAPIEnabled):
1347         * dom/DocumentMarker.h:
1348         (WebCore::DocumentMarker::length):
1349         * dom/DocumentMarkerController.cpp:
1350         (WebCore::DocumentMarkerController::userSpellingMarkersForNode):
1351         (WebCore::DocumentMarkerController::addUserSpellingMarker):
1352         (WebCore::DocumentMarkerController::removeUserSpellingMarker):
1353         (WebCore::DocumentMarkerController::userSpellingNode):
1354         * dom/DocumentMarkerController.h:
1355         * html/HTMLDivElement.cpp:
1356         (WebCore::HTMLDivElement::spellcheckRanges):
1357         (WebCore::HTMLDivElement::addSpellcheckRange):
1358         (WebCore::HTMLDivElement::removeSpellcheckRange):
1359         * html/HTMLDivElement.h:
1360         * html/HTMLDivElement.idl:
1361         * html/HTMLInputElement.cpp:
1362         (WebCore::HTMLInputElement::spellcheckRanges):
1363         (WebCore::HTMLInputElement::addSpellcheckRange):
1364         (WebCore::HTMLInputElement::removeSpellcheckRange):
1365         * html/HTMLInputElement.h:
1366         * html/HTMLInputElement.idl:
1367         * html/HTMLTextAreaElement.cpp:
1368         (WebCore::HTMLTextAreaElement::spellcheckRanges):
1369         (WebCore::HTMLTextAreaElement::addSpellcheckRange):
1370         (WebCore::HTMLTextAreaElement::removeSpellcheckRange):
1371         * html/HTMLTextAreaElement.h:
1372         * html/HTMLTextAreaElement.idl:
1373         * html/SpellcheckRange.cpp: Added.
1374         (WebCore::SpellcheckRange::SpellcheckRange):
1375         (WebCore::SpellcheckRange::~SpellcheckRange):
1376         * html/SpellcheckRange.h: Added.
1377         (WebCore::SpellcheckRange::create):
1378         (WebCore::SpellcheckRange::start):
1379         (WebCore::SpellcheckRange::length):
1380         (WebCore::SpellcheckRange::suggestions):
1381         (WebCore::SpellcheckRange::options):
1382         * html/SpellcheckRange.idl: Added.
1383         * html/SpellcheckRangeList.cpp: Added.
1384         (WebCore::SpellcheckRangeList::SpellcheckRangeList):
1385         (WebCore::SpellcheckRangeList::~SpellcheckRangeList):
1386         (WebCore::SpellcheckRangeList::item):
1387         * html/SpellcheckRangeList.h: Added.
1388         (WebCore::SpellcheckRangeList::create):
1389         (WebCore::SpellcheckRangeList::isEmpty):
1390         (WebCore::SpellcheckRangeList::clear):
1391         (WebCore::SpellcheckRangeList::append):
1392         (WebCore::SpellcheckRangeList::remove):
1393         (WebCore::SpellcheckRangeList::length):
1394         * html/SpellcheckRangeList.idl: Added.
1395         * rendering/InlineTextBox.cpp:
1396         (WebCore::textCheckingLineStyleForMarkerType):
1397         (WebCore::InlineTextBox::paintDocumentMarkers):
1398
1399 2011-06-07  Andrey Kosyakov  <caseq@chromium.org>
1400
1401         Reviewed by Pavel Feldman.
1402
1403         Web Inspector: remove shadow dom inspection from Elements panel by default.
1404         https://bugs.webkit.org/show_bug.cgi?id=62188
1405
1406         This reverts r85751
1407
1408         * dom/Element.cpp:
1409         (WebCore::Element::ensureShadowRoot):
1410         (WebCore::Element::removeShadowRoot):
1411         * inspector/Inspector.json:
1412         * inspector/InspectorDOMAgent.cpp:
1413         (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
1414         (WebCore::InspectorDOMAgent::buildObjectForNode):
1415         (WebCore::InspectorDOMAgent::didInsertDOMNode):
1416         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
1417         * inspector/InspectorDOMAgent.h:
1418         * inspector/front-end/DOMAgent.js:
1419         (WebInspector.DOMNode):
1420         (WebInspector.DOMNode.prototype._renumber):
1421         (WebInspector.DOMAgent.prototype._bindNodes):
1422         (WebInspector.DOMAgent.prototype.querySelectorAll):
1423         (WebInspector.DOMDispatcher.prototype.searchResults):
1424         * inspector/front-end/ElementsPanel.js:
1425         (WebInspector.ElementsPanel):
1426         (WebInspector.ElementsPanel.prototype._attributesUpdated):
1427         (WebInspector.ElementsPanel.prototype._characterDataModified):
1428         (WebInspector.ElementsPanel.prototype._nodeInserted):
1429         (WebInspector.ElementsPanel.prototype._nodeRemoved):
1430         (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
1431         (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
1432         * inspector/front-end/ElementsTreeOutline.js:
1433         (WebInspector.ElementsTreeElement):
1434         (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
1435         (WebInspector.ElementsTreeElement.prototype._updateChildren):
1436         ():
1437         * inspector/front-end/inspector.css:
1438         * inspector/front-end/utilities.js:
1439         (Element.prototype.query):
1440
1441 2011-06-08  Mark Rowe  <mrowe@apple.com>
1442
1443         Fix the build.
1444
1445         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
1446         (WebCore::MediaPlayerPrivateAVFoundation::timeChanged):
1447         (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
1448
1449 2011-06-07  Keishi Hattori  <keishi@webkit.org>
1450
1451         Reviewed by Kent Tamura.
1452
1453         Rename HTMLInputElement::m_value to m_valueIfDirty
1454         https://bugs.webkit.org/show_bug.cgi?id=61990
1455
1456         No new tests because no behavior change.
1457
1458         * html/HTMLInputElement.cpp: Replaced m_value with m_valueIfDirty.
1459         (WebCore::HTMLInputElement::tooLong):
1460         (WebCore::HTMLInputElement::updateType):
1461         (WebCore::HTMLInputElement::parseMappedAttribute):
1462         (WebCore::HTMLInputElement::copyNonAttributeProperties):
1463         (WebCore::HTMLInputElement::value):
1464         (WebCore::HTMLInputElement::setValue):
1465         (WebCore::HTMLInputElement::setValueFromRenderer):
1466         (WebCore::HTMLInputElement::updateValueIfNeeded):
1467         * html/HTMLInputElement.h: Renamed m_value to m_valueIfDirty.
1468         (WebCore::HTMLInputElement::hasDirtyValue): Added. Returns the dirty value flag.
1469
1470 2011-06-07  Ian Henderson  <ianh@apple.com>
1471
1472         Reviewed by Dan Bernstein.
1473
1474         (CG) Sub-image drawing clips unnecessarily
1475         https://bugs.webkit.org/show_bug.cgi?id=62258
1476
1477         If destRect completely encompasses the adjustedDestRect into which we
1478         draw, clipping to destRect will do nothing.  Skip the call to
1479         CGContextClipToRect in this case.
1480
1481         * platform/graphics/cg/ImageCG.cpp:
1482         (WebCore::BitmapImage::draw):
1483
1484 2011-06-07  Emil A Eklund  <eae@chromium.org>
1485
1486         Reviewed by Eric Seidel.
1487
1488         Convert nodeAtPoint to IntPoint
1489         https://bugs.webkit.org/show_bug.cgi?id=62145
1490
1491         Convert nodeAtPoint to take an IntPoint instead of a pair of ints for the
1492         accumulated offset.
1493
1494         Covered by existing tests.
1495
1496         * platform/graphics/FloatPoint.h:
1497         (WebCore::FloatPoint::moveBy):
1498         Add moveBy(IntPoint) method
1499         
1500         * rendering/EllipsisBox.cpp:
1501         (WebCore::EllipsisBox::nodeAtPoint):
1502         * rendering/EllipsisBox.h:
1503         * rendering/InlineBox.cpp:
1504         (WebCore::InlineBox::nodeAtPoint):
1505         * rendering/InlineBox.h:
1506         * rendering/InlineFlowBox.cpp:
1507         (WebCore::InlineFlowBox::nodeAtPoint):
1508         * rendering/InlineFlowBox.h:
1509         * rendering/InlineTextBox.cpp:
1510         (WebCore::InlineTextBox::nodeAtPoint):
1511         * rendering/InlineTextBox.h:
1512         * rendering/RenderBlock.cpp:
1513         (WebCore::RenderBlock::nodeAtPoint):
1514         (WebCore::RenderBlock::hitTestContents):
1515         * rendering/RenderBlock.h:
1516         * rendering/RenderBox.cpp:
1517         (WebCore::RenderBox::nodeAtPoint):
1518         * rendering/RenderBox.h:
1519         * rendering/RenderFrameSet.cpp:
1520         (WebCore::RenderFrameSet::nodeAtPoint):
1521         * rendering/RenderFrameSet.h:
1522         * rendering/RenderImage.cpp:
1523         (WebCore::RenderImage::nodeAtPoint):
1524         * rendering/RenderImage.h:
1525         * rendering/RenderInline.cpp:
1526         (WebCore::RenderInline::nodeAtPoint):
1527         * rendering/RenderInline.h:
1528         * rendering/RenderLineBoxList.cpp:
1529         (WebCore::RenderLineBoxList::hitTest):
1530         * rendering/RenderListBox.cpp:
1531         (WebCore::RenderListBox::nodeAtPoint):
1532         * rendering/RenderListBox.h:
1533         * rendering/RenderObject.cpp:
1534         (WebCore::RenderObject::hitTest):
1535         * rendering/RenderObject.h:
1536         * rendering/RenderTable.cpp:
1537         (WebCore::RenderTable::nodeAtPoint):
1538         * rendering/RenderTable.h:
1539         * rendering/RenderTableRow.cpp:
1540         (WebCore::RenderTableRow::nodeAtPoint):
1541         * rendering/RenderTableRow.h:
1542         * rendering/RenderTableSection.cpp:
1543         (WebCore::RenderTableSection::nodeAtPoint):
1544         * rendering/RenderTableSection.h:
1545         * rendering/RenderText.h:
1546         (WebCore::RenderText::nodeAtPoint):
1547         * rendering/RenderTextControlMultiLine.cpp:
1548         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
1549         * rendering/RenderTextControlMultiLine.h:
1550         * rendering/RenderTextControlSingleLine.cpp:
1551         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
1552         * rendering/RenderTextControlSingleLine.h:
1553         * rendering/RenderWidget.cpp:
1554         (WebCore::RenderWidget::nodeAtPoint):
1555         * rendering/RenderWidget.h:
1556         * rendering/RootInlineBox.cpp:
1557         (WebCore::RootInlineBox::nodeAtPoint):
1558         * rendering/RootInlineBox.h:
1559         * rendering/svg/RenderSVGForeignObject.cpp:
1560         (WebCore::RenderSVGForeignObject::nodeAtFloatPoint):
1561         (WebCore::RenderSVGForeignObject::nodeAtPoint):
1562         * rendering/svg/RenderSVGForeignObject.h:
1563         * rendering/svg/RenderSVGModelObject.cpp:
1564         (WebCore::RenderSVGModelObject::nodeAtPoint):
1565         * rendering/svg/RenderSVGModelObject.h:
1566         * rendering/svg/RenderSVGRoot.cpp:
1567         (WebCore::RenderSVGRoot::nodeAtPoint):
1568         * rendering/svg/RenderSVGRoot.h:
1569         * rendering/svg/RenderSVGText.cpp:
1570         (WebCore::RenderSVGText::nodeAtFloatPoint):
1571         (WebCore::RenderSVGText::nodeAtPoint):
1572         * rendering/svg/RenderSVGText.h:
1573
1574 2011-06-07  Yi Shen  <yi.4.shen@nokia.com>
1575
1576         Reviewed by Simon Hausmann.
1577
1578         [Qt] Fix the error code for media resource failures when using QtMobility
1579         https://bugs.webkit.org/show_bug.cgi?id=55901
1580
1581         To indicate the media resource failures, set the network state to
1582         MediaPlayer::FormatError when receives QMediaPlayer::InvalidMedia or
1583         QMediaPlayer::ResourceError.
1584
1585         * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
1586         (WebCore::MediaPlayerPrivateQt::updateStates):
1587
1588 2011-06-07  Emil A Eklund  <eae@chromium.org>
1589
1590         Reviewed by Eric Seidel.
1591
1592         Change RenderBlock::hitTestFloats to IntPoint
1593         https://bugs.webkit.org/show_bug.cgi?id=62176
1594
1595         Covered by existing tests.
1596
1597         * rendering/RenderBlock.cpp:
1598         (WebCore::RenderBlock::nodeAtPoint):
1599         (WebCore::RenderBlock::hitTestFloats):
1600         (WebCore::RenderBlock::hitTestColumns):
1601         * rendering/RenderBlock.h:
1602
1603 2011-06-07  Tim Horton  <timothy_horton@apple.com>
1604
1605         Reviewed by Alexey Proskuryakov.
1606
1607         Use correct CFURLStorageSessionRef definition on Snow Leopard
1608         https://bugs.webkit.org/show_bug.cgi?id=62223
1609
1610         * platform/mac/WebCoreSystemInterface.h:
1611         * platform/network/ResourceHandle.h:
1612         * platform/network/cf/ResourceRequest.h:
1613
1614 2011-06-07  Emil A Eklund  <eae@chromium.org>
1615
1616         Reviewed by Eric Seidel.
1617
1618         Change RenderBlock::hitTestColumns to IntPoint
1619         https://bugs.webkit.org/show_bug.cgi?id=62172
1620
1621         Covered by existing tests.
1622
1623         * rendering/RenderBlock.cpp:
1624         (WebCore::RenderBlock::nodeAtPoint):
1625         (WebCore::RenderBlock::hitTestColumns):
1626         * rendering/RenderBlock.h:
1627
1628 2011-06-07  Simon Fraser  <simon.fraser@apple.com>
1629
1630         Reviewed by Darin Adler.
1631
1632         Opacity transition doesn't work while content property is set.
1633         https://bugs.webkit.org/show_bug.cgi?id=59301
1634         
1635         StyleRareNonInheritedData's copy constructor omitted to copy
1636         the m_content data, which caused us to detach and re-attach the renderer
1637         at the start of the transition, thereby killing the transition.
1638         
1639         Fix by making StyleRareNonInheritedData's copy ctor do the right thing.
1640
1641         Test: transitions/transition-on-element-with-content.html
1642
1643         * rendering/style/ContentData.h:
1644         * rendering/style/ContentData.cpp:
1645         (WebCore::ContentData::clone): New method to do a deep clone. (Can't use a copy
1646         ctor because of the subclasses.)
1647         * rendering/style/CounterDirectives.h: Pack the data members to save space.
1648         Add a clone() function for the HashMap.
1649         * rendering/style/CounterDirectives.cpp:
1650         (WebCore::clone): Make a new HashMap and copy the contents over.
1651         * rendering/style/StyleRareNonInheritedData.cpp:
1652         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Copy
1653         the content and counter directives over.
1654         (WebCore::StyleRareNonInheritedData::operator==): Rather than just comparing
1655         for pointer equality, do a correct check for m_counterDirectives equality.
1656         (WebCore::StyleRareNonInheritedData::counterDataEquivalent):
1657         * rendering/style/StyleRareNonInheritedData.h:
1658
1659 2011-06-07  Robert Kroeger  <rjkroege@chromium.org>
1660
1661         Reviewed by Adam Barth.
1662
1663         [chromium] Add a basic gesture recognizer to the Chromium platform
1664         https://bugs.webkit.org/show_bug.cgi?id=54417
1665
1666         Adds a basic gesture recognizer to the Chromium platform. Adds an entry
1667         point to the GestureRecognizer to reset any internal state on a page reset.
1668         Resetting the gesture recognizer on page load is necesary for reliable
1669         layout test execution and improves gesture recognizer operational
1670         robustness.
1671
1672         Added an additional constructor to permit building a synthetic
1673         PlatformWheelEvent.
1674
1675         Small modifications to the PlatformGestureRecognizer as required to
1676         implement the simple Chromium platform gesture recognizer.
1677
1678         Tests: fast/events/touch/touch-gesture-click.html
1679
1680         * WebCore.gypi:
1681         * page/EventHandler.cpp:
1682         (WebCore::EventHandler::resetGestureRecognizer):
1683         * page/EventHandler.h:
1684         * page/FrameView.cpp:
1685         (WebCore::FrameView::reset):
1686         * platform/PlatformGestureRecognizer.h:
1687         * platform/PlatformWheelEvent.h:
1688         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1689         * platform/chromium/GestureRecognizerChromium.cpp: Added.
1690         (WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
1691         (WebCore::InnerGestureRecognizer::reset):
1692         (WebCore::InnerGestureRecognizer::~InnerGestureRecognizer):
1693         (WebCore::InnerGestureRecognizer::addEdgeFunction):
1694         (WebCore::InnerGestureRecognizer::isInClickTimeWindow):
1695         (WebCore::InnerGestureRecognizer::isInsideManhattanSquare):
1696         (WebCore::InnerGestureRecognizer::dispatchSyntheticClick):
1697         (WebCore::InnerGestureRecognizer::processTouchEventForGesture):
1698         (WebCore::InnerGestureRecognizer::scrollViaTouchMotion):
1699         (WebCore::InnerGestureRecognizer::updateValues):
1700         (WebCore::InnerGestureRecognizer::signature):
1701         (WebCore::touchDown):
1702         (WebCore::noGesture):
1703         (WebCore::click):
1704         (WebCore::isClickOrScroll):
1705         (WebCore::inScroll):
1706         (WebCore::PlatformGestureRecognizer::create):
1707         (WebCore::PlatformGestureRecognizer::PlatformGestureRecognizer):
1708         (WebCore::PlatformGestureRecognizer::~PlatformGestureRecognizer):
1709         (WebCore::GestureRecognizerChromium::GestureRecognizerChromium):
1710         (WebCore::GestureRecognizerChromium::~GestureRecognizerChromium):
1711         * platform/chromium/GestureRecognizerChromium.h: Added.
1712         (WebCore::InnerGestureRecognizer::setState):
1713         (WebCore::InnerGestureRecognizer::state):
1714         (WebCore::GestureRecognizerChromium::reset):
1715         (WebCore::GestureRecognizerChromium::processTouchEventForGesture):
1716
1717 2011-06-07  No'am Rosenthal  <noam.rosenthal@nokia.com>
1718
1719         Reviewed by Andreas Kling.
1720
1721         [Texmap][Qt] Enable TextureMapper by default
1722         https://bugs.webkit.org/show_bug.cgi?id=61740
1723
1724         Enable TextureMapper on Windows+Symbian, disabling the direct OpenGL path. This would mean that
1725         for now QtWebKit on Windows/Symbian would use the Qt backend for TextureMapper.
1726
1727         No new functionality so no new tests.
1728
1729         * WebCore.pri:
1730         * WebCore.pro:
1731         * platform/graphics/qt/GraphicsContext3DQt.cpp:
1732         * platform/graphics/qt/TextureMapperQt.cpp:
1733         (WebCore::TextureMapper::create):
1734
1735 2011-06-07  Emil A Eklund  <eae@chromium.org>
1736
1737         Reviewed by Eric Seidel.
1738
1739         Convert RenderBox::absoluteRects to IntPoint
1740         https://bugs.webkit.org/show_bug.cgi?id=62130
1741
1742         Covered by existing tests.
1743
1744         * dom/Node.cpp:
1745         (WebCore::Node::hasNonEmptyBoundingBox):
1746         * rendering/InlineBox.h:
1747         (WebCore::InlineBox::size):
1748         * rendering/RenderBlock.cpp:
1749         (WebCore::RenderBlock::absoluteRects):
1750         * rendering/RenderBlock.h:
1751         * rendering/RenderBox.cpp:
1752         (WebCore::RenderBox::absoluteRects):
1753         * rendering/RenderBox.h:
1754         * rendering/RenderInline.cpp:
1755         (WebCore::RenderInline::absoluteRects):
1756         * rendering/RenderInline.h:
1757         * rendering/RenderObject.cpp:
1758         (WebCore::RenderObject::absoluteBoundingBoxRect):
1759         * rendering/RenderObject.h:
1760         (WebCore::RenderObject::absoluteRects):
1761         * rendering/RenderText.cpp:
1762         (WebCore::RenderText::absoluteRects):
1763         * rendering/RenderText.h:
1764         * rendering/RenderView.cpp:
1765         (WebCore::RenderView::absoluteRects):
1766         * rendering/RenderView.h:
1767         * rendering/svg/RenderSVGBlock.cpp:
1768         (WebCore::RenderSVGBlock::absoluteRects):
1769         * rendering/svg/RenderSVGBlock.h:
1770         * rendering/svg/RenderSVGModelObject.cpp:
1771         (WebCore::RenderSVGModelObject::absoluteRects):
1772         * rendering/svg/RenderSVGModelObject.h:
1773
1774 2011-06-07  Kent Tamura  <tkent@chromium.org>
1775
1776         Reviewed by Andreas Kling.
1777
1778         [Qt] RenderThemeQt::adjustSliderThumbSize() should not refer to the parent style.
1779         https://bugs.webkit.org/show_bug.cgi?id=62207
1780
1781         * css/mediaControlsQt.css: Add comments.
1782         (audio::-webkit-media-controls-timeline):
1783         (video::-webkit-media-controls-timeline):
1784         (audio::-webkit-media-controls-volume-slider):
1785         (video::-webkit-media-controls-volume-slider):
1786         * platform/qt/RenderThemeQt.cpp: Use fixed values to avoid referring to o->parent().
1787         (WebCore::RenderThemeQt::adjustSliderThumbSize):
1788
1789 2011-06-07  Sailesh Agrawal  <sail@chromium.org>
1790
1791         Reviewed by Mihai Parparita.
1792
1793         Chromium Mac: Fork ScrollAnimatorMac to ScrollAnimatorChromiumMac for overlay scrollbar support
1794         https://bugs.webkit.org/show_bug.cgi?id=59753
1795
1796         No new tests. Just forking ScrollAnimatorMac to ScrollAnimatorChromiumMac.
1797
1798         * WebCore.gyp/WebCore.gyp: Added IntPointMac.mm. This is used by some functions in ScrollAnimatorChromiumMac. Also added filters for conflicting class names in ScrollAnimatorChromiumMac.
1799         * WebCore.gypi: Added ScrollAnimatorChromiumMac.h/mm.
1800         * platform/ScrollAnimator.cpp: Extended the #ifdef around ScrollAnimator::create() so that the chromium version will be created.
1801         * platform/chromium/ScrollAnimatorChromiumMac.h: Added.
1802         (WebCore::ScrollAnimatorChromiumMac::setIsDrawingIntoLayer):
1803         (WebCore::ScrollAnimatorChromiumMac::isDrawingIntoLayer):
1804         (WebCore::ScrollAnimatorChromiumMac::haveScrolledSincePageLoad):
1805         * platform/chromium/ScrollAnimatorChromiumMac.mm: Added. Forked from ScrollAnimatorMac and replaced all instances of ScrollAnimatorMac with ScrollAnimatorChromiumMac and ScrollbarThemeMac with ScrollbarThemeChromiumMac. Removed the ENABLE(SMOOTH_SCROLLING) around the file. Stubbed out ScrollAnimatorChromiumMac::scroll() if smooth scrolling is disabled.
1806         (abs):
1807         (-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]):
1808         (-[ScrollAnimationHelperDelegate scrollAnimatorDestroyed]):
1809         (-[ScrollAnimationHelperDelegate bounds]):
1810         (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]):
1811         (-[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]):
1812         (-[ScrollAnimationHelperDelegate convertSizeToBase:]):
1813         (-[ScrollAnimationHelperDelegate convertSizeFromBase:]):
1814         (-[ScrollAnimationHelperDelegate convertSizeToBacking:]):
1815         (-[ScrollAnimationHelperDelegate convertSizeFromBacking:]):
1816         (-[ScrollAnimationHelperDelegate superview]):
1817         (-[ScrollAnimationHelperDelegate documentView]):
1818         (-[ScrollAnimationHelperDelegate window]):
1819         (-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]):
1820         (-[ScrollbarPainterControllerDelegate initWithScrollAnimator:WebCore::]):
1821         (-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]):
1822         (-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
1823         (-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
1824         (-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
1825         (-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
1826         (-[ScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
1827         (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
1828         (-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):
1829         (-[ScrollbarPartAnimation setCurrentProgress:]):
1830         (-[ScrollbarPartAnimation scrollAnimatorDestroyed]):
1831         (-[ScrollbarPainterDelegate initWithScrollAnimator:WebCore::]):
1832         (-[ScrollbarPainterDelegate cancelAnimations]):
1833         (-[ScrollbarPainterDelegate convertRectToBacking:]):
1834         (-[ScrollbarPainterDelegate convertRectFromBacking:]):
1835         (-[ScrollbarPainterDelegate layer]):
1836         (-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
1837         (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
1838         (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
1839         (-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):
1840         (-[ScrollbarPainterDelegate scrollAnimatorDestroyed]):
1841         (WebCore::ScrollAnimator::create):
1842         (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac):
1843         (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac):
1844         (WebCore::ScrollAnimatorChromiumMac::scroll):
1845         (WebCore::ScrollAnimatorChromiumMac::scrollToOffsetWithoutAnimation):
1846         (WebCore::ScrollAnimatorChromiumMac::adjustScrollXPositionIfNecessary):
1847         (WebCore::ScrollAnimatorChromiumMac::adjustScrollYPositionIfNecessary):
1848         (WebCore::ScrollAnimatorChromiumMac::adjustScrollPositionIfNecessary):
1849         (WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint):
1850         (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX):
1851         (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY):
1852         (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged):
1853         (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint):
1854         (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea):
1855         (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea):
1856         (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea):
1857         (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize):
1858         (WebCore::ScrollAnimatorChromiumMac::contentsResized):
1859         (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize):
1860         (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow):
1861         (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide):
1862         (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture):
1863         (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture):
1864         (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar):
1865         (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar):
1866         (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar):
1867         (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar):
1868         (WebCore::ScrollAnimatorChromiumMac::cancelAnimations):
1869         (WebCore::elasticDeltaForTimeDelta):
1870         (WebCore::elasticDeltaForReboundDelta):
1871         (WebCore::reboundDeltaForElasticDelta):
1872         (WebCore::scrollWheelMultiplier):
1873         (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
1874         (WebCore::ScrollAnimatorChromiumMac::handleGestureEvent):
1875         (WebCore::ScrollAnimatorChromiumMac::pinnedInDirection):
1876         (WebCore::ScrollAnimatorChromiumMac::allowsVerticalStretching):
1877         (WebCore::ScrollAnimatorChromiumMac::allowsHorizontalStretching):
1878         (WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent):
1879         (WebCore::ScrollAnimatorChromiumMac::beginScrollGesture):
1880         (WebCore::ScrollAnimatorChromiumMac::endScrollGesture):
1881         (WebCore::ScrollAnimatorChromiumMac::snapRubberBand):
1882         (WebCore::roundTowardZero):
1883         (WebCore::roundToDevicePixelTowardZero):
1884         (WebCore::ScrollAnimatorChromiumMac::snapRubberBandTimerFired):
1885         (WebCore::ScrollAnimatorChromiumMac::startScrollbarPaintTimer):
1886         (WebCore::ScrollAnimatorChromiumMac::scrollbarPaintTimerIsActive):
1887         (WebCore::ScrollAnimatorChromiumMac::stopScrollbarPaintTimer):
1888         (WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):
1889         (WebCore::ScrollAnimatorChromiumMac::setVisibleScrollerThumbRect):
1890         * platform/graphics/IntPoint.h: Exposed NSPoint conversion routines to chromium mac.
1891
1892 2011-06-07  Sam Weinig  <sam@webkit.org>
1893
1894         Reviewed by Anders Carlsson.
1895
1896         Remove repeated IPC traffic from SetRenderTreeSize message
1897         https://bugs.webkit.org/show_bug.cgi?id=62244
1898
1899         * WebCore.xcodeproj/project.pbxproj:
1900         Make RenderArena.h private so it can be called from WebKit2.
1901
1902         * loader/FrameLoaderClient.h:
1903         (WebCore::FrameLoaderClient::dispatchDidLayout):
1904         Added.
1905
1906         * page/ChromeClient.h:
1907         Remove setRenderTreeSize.
1908
1909         * page/FrameView.cpp:
1910         (WebCore::FrameView::performPostLayoutTasks):
1911         Call dispatchDidLayout for all frames instead of calling setRenderTreeSize
1912         for the main frame.
1913
1914 2011-06-07  Emil A Eklund  <eae@chromium.org>
1915
1916         Reviewed by Eric Seidel.
1917
1918         Change RenderBlock::hitTestContents to IntPoint
1919         https://bugs.webkit.org/show_bug.cgi?id=62170
1920
1921         Covered by existing tests.
1922
1923         * rendering/RenderBlock.cpp:
1924         (WebCore::RenderBlock::nodeAtPoint):
1925         (WebCore::RenderBlock::hitTestColumns):
1926         (WebCore::RenderBlock::hitTestContents):
1927         * rendering/RenderBlock.h:
1928
1929 2011-06-07  Jer Noble  <jer.noble@apple.com>
1930
1931         Reviewed by Eric Carlson.
1932
1933         Video with poster attribute will not display new frames when scrubbing.
1934         https://bugs.webkit.org/show_bug.cgi?id=62036
1935
1936         Remove our "detection" about the end of a scrub now that there is an explicit seek completion
1937         handler available in AVFoundation.  Move what we used to do upon detection in timeChanged()
1938         into seekCompleted().
1939
1940         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
1941         (WebCore::MediaPlayerPrivateAVFoundation::timeChanged): 
1942         (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
1943
1944 2011-06-07  James Simonsen  <simonjam@chromium.org>
1945
1946         Unreviewed, build fix, missing files from r88274.
1947
1948         * bindings/v8/ChildThreadDOMData.cpp: Added.
1949         (WebCore::ChildThreadDOMData::ChildThreadDOMData):
1950         (WebCore::ChildThreadDOMData::getStore):
1951         * bindings/v8/ChildThreadDOMData.h: Added.
1952         * bindings/v8/MainThreadDOMData.cpp: Added.
1953         (WebCore::MainThreadDOMData::MainThreadDOMData):
1954         (WebCore::MainThreadDOMData::getCurrent):
1955         (WebCore::MainThreadDOMData::getMainThreadStore):
1956         (WebCore::MainThreadDOMData::getCurrentMainThreadStore):
1957         * bindings/v8/MainThreadDOMData.h: Added.
1958         (WebCore::MainThreadDOMData::getStore):
1959
1960 2011-06-07  Abhishek Arya  <inferno@chromium.org>
1961
1962         Reviewed by Dan Bernstein.
1963
1964         Replicate WidthIterator.cpp fix from r88139.
1965         https://bugs.webkit.org/show_bug.cgi?id=62238
1966
1967         No new tests. Covered by existing layout tests on XP debug bots.
1968
1969         * platform/graphics/win/UniscribeController.cpp:
1970         (WebCore::UniscribeController::advance):
1971
1972 2011-06-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1973
1974         Unreviewed, rolling out r88221, r88224, and r88231.
1975         http://trac.webkit.org/changeset/88221
1976         http://trac.webkit.org/changeset/88224
1977         http://trac.webkit.org/changeset/88231
1978         https://bugs.webkit.org/show_bug.cgi?id=62233
1979
1980         assert failure on chromium linux debug (Requested by simonjam
1981         on #webkit).
1982
1983         * WebCore.gypi:
1984         * WebCore.pro:
1985         * bindings/v8/ChildThreadDOMData.cpp: Copied from Source/WebCore/bindings/v8/DOMData.cpp.
1986         (WebCore::ChildThreadDOMData::ChildThreadDOMData):
1987         (WebCore::ChildThreadDOMData::getStore):
1988         * bindings/v8/ChildThreadDOMData.h: Copied from Source/WebCore/bindings/v8/DOMData.cpp.
1989         * bindings/v8/DOMData.cpp:
1990         (WebCore::DOMData::DOMData):
1991         (WebCore::DOMData::getCurrent):
1992         * bindings/v8/DOMData.h:
1993         (WebCore::DOMData::owningThread):
1994         (WebCore::DOMData::handleWeakObject):
1995         * bindings/v8/DOMDataStore.cpp:
1996         (WebCore::DOMDataStore::DOMDataStore):
1997         (WebCore::DOMDataStore::~DOMDataStore):
1998         (WebCore::DOMDataStore::allStoresMutex):
1999         (WebCore::DOMDataStore::weakNodeCallback):
2000         * bindings/v8/DOMDataStore.h:
2001         * bindings/v8/MainThreadDOMData.cpp: Copied from Source/WebCore/bindings/v8/DOMData.cpp.
2002         (WebCore::MainThreadDOMData::MainThreadDOMData):
2003         (WebCore::MainThreadDOMData::getCurrent):
2004         (WebCore::MainThreadDOMData::getMainThreadStore):
2005         (WebCore::MainThreadDOMData::getCurrentMainThreadStore):
2006         * bindings/v8/MainThreadDOMData.h: Copied from Source/WebCore/bindings/v8/DOMData.cpp.
2007         (WebCore::MainThreadDOMData::getStore):
2008         * bindings/v8/V8DOMMap.cpp:
2009         (WebCore::getDOMDataStore):
2010         (WebCore::removeAllDOMObjectsInCurrentThread):
2011         (WebCore::visitDOMNodesInCurrentThread):
2012         (WebCore::visitDOMObjectsInCurrentThread):
2013         (WebCore::visitActiveDOMObjectsInCurrentThread):
2014         (WebCore::visitDOMSVGElementInstancesInCurrentThread):
2015         * bindings/v8/V8DOMMap.h:
2016         * bindings/v8/V8GCController.cpp:
2017         (WebCore::V8GCController::gcPrologue):
2018         (WebCore::V8GCController::gcEpilogue):
2019         * bindings/v8/WorkerScriptController.cpp:
2020         (WebCore::WorkerScriptController::~WorkerScriptController):
2021
2022 2011-06-07  Simon Fraser  <simon.fraser@apple.com>
2023
2024         Reviewed by Dave Hyatt.
2025
2026         Clean up ContentData
2027         https://bugs.webkit.org/show_bug.cgi?id=62185
2028
2029         ContentData did manual ref()/deref() and had a lot of awkward
2030         code from using a union to store data.
2031         
2032         Clean this up by adding ContentData subclasses for different
2033         content types, which are then able to use RefPtr and OwnPtr
2034         as appropriate.
2035
2036         * css/CSSComputedStyleDeclaration.cpp:
2037         (WebCore::contentToCSSValue): Cast to different ContentData types as
2038         appropriate.
2039
2040         * css/CSSStyleSelector.cpp: 
2041         (WebCore::CSSStyleSelector::loadPendingImages): Cast to ImageContentData, and do some
2042         const gyrations.
2043
2044         * html/HTMLBRElement.cpp:
2045         (WebCore::HTMLBRElement::createRenderer): Use hasContent().
2046         * html/HTMLFrameSetElement.cpp:
2047         (WebCore::HTMLFrameSetElement::createRenderer): Ditto
2048         * html/HTMLImageElement.cpp:
2049         (WebCore::HTMLImageElement::createRenderer): Ditto
2050         * rendering/RenderObject.cpp:
2051         (WebCore::RenderObject::createObject): Cast to ImageContentData.
2052         * rendering/RenderObjectChildList.cpp:
2053         (WebCore::RenderObjectChildList::updateBeforeAfterContent): Cast to different ContentData types as
2054         appropriate.
2055
2056         * rendering/style/ContentData.h:
2057         (WebCore::ContentData::~ContentData):
2058         (WebCore::ContentData::isCounter):
2059         (WebCore::ContentData::isImage):
2060         (WebCore::ContentData::isQuote):
2061         (WebCore::ContentData::isText):
2062         (WebCore::ContentData::next):
2063         (WebCore::ContentData::setNext):
2064         (WebCore::ImageContentData::image):
2065         (WebCore::ImageContentData::setImage):
2066         (WebCore::ImageContentData::ImageContentData):
2067         (WebCore::ImageContentData::type):
2068         (WebCore::ImageContentData::isImage):
2069         (WebCore::TextContentData::text):
2070         (WebCore::TextContentData::setText):
2071         (WebCore::TextContentData::TextContentData):
2072         (WebCore::TextContentData::type):
2073         (WebCore::TextContentData::isText):
2074         (WebCore::CounterContentData::counter):
2075         (WebCore::CounterContentData::setCounter):
2076         (WebCore::CounterContentData::CounterContentData):
2077         (WebCore::CounterContentData::type):
2078         (WebCore::CounterContentData::isCounter):
2079         (WebCore::QuoteContentData::quote):
2080         (WebCore::QuoteContentData::setQuote):
2081         (WebCore::QuoteContentData::QuoteContentData):
2082         (WebCore::QuoteContentData::type):
2083         (WebCore::QuoteContentData::isQuote):
2084         Add subclasses for different content types, which are created
2085         via overloaded create() methods on the base class.
2086
2087         * rendering/style/ContentData.cpp:
2088         (WebCore::ContentData::create):
2089         (WebCore::operator==): Test for type equality, followed by comparing data.
2090         (WebCore::operator!=):
2091
2092         * rendering/style/RenderStyle.cpp:
2093         (WebCore::RenderStyle::clearContent):
2094         (WebCore::RenderStyle::appendContent): 
2095         (WebCore::RenderStyle::setContent): Replace the overly complex prepareToSetContent()
2096         code with code that either appends, or replaces the content.
2097         This loses an optimization where the existing ContentData object could get reused,
2098         but this seems to be rarely hit in practice.
2099         * rendering/style/RenderStyle.h:
2100         (WebCore::InheritedFlags::hasContent): Convenience method.
2101         * rendering/style/StyleRareNonInheritedData.cpp:
2102         (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Test
2103         that the pointers are non-null, then use the != operator.
2104         * rendering/style/StyleRareNonInheritedData.h: ContentData is a class now.
2105
2106 2011-06-07  Brian Weinstein  <bweinstein@apple.com>
2107
2108         Build fix after r88260.
2109
2110         * platform/graphics/win/FontCacheWin.cpp:
2111         (WebCore::FontCache::getFontDataForCharacters): Update to use enum instead of bool.
2112         * platform/graphics/wince/FontCacheWinCE.cpp:
2113
2114 2011-06-07  Rob Buis  <rbuis@rim.com>
2115
2116         Reviewed by Dirk Schulze.
2117
2118         stroke-dasharray does not handle "none"
2119         https://bugs.webkit.org/show_bug.cgi?id=62203
2120
2121         Use the initial strokeDashArray style for stroke-dasharray="none" to apply to SVGRenderStyle rather than bailing out.
2122
2123         Tests: svg/W3C-SVG-1.1-SE/styling-css-04-f.svg
2124                svg/custom/invalid-dasharray.svg
2125
2126         * css/SVGCSSStyleSelector.cpp:
2127         (WebCore::CSSStyleSelector::applySVGProperty):
2128
2129 2011-06-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2130
2131         Unreviewed, rolling out r88259 and r88263.
2132         http://trac.webkit.org/changeset/88259
2133         http://trac.webkit.org/changeset/88263
2134         https://bugs.webkit.org/show_bug.cgi?id=62228
2135
2136         broke builds (Requested by rniwa on #webkit).
2137
2138         * platform/mac/WebCoreSystemInterface.h:
2139         * platform/network/ResourceHandle.h:
2140         * platform/network/cf/ResourceRequest.h:
2141
2142 2011-06-07  Emil A Eklund  <eae@chromium.org>
2143
2144         Reviewed by Eric Seidel.
2145
2146         Switch ContainerNode to use IntPoint
2147         https://bugs.webkit.org/show_bug.cgi?id=61893
2148
2149         Covered by existing tests.
2150
2151         * dom/ContainerNode.cpp:
2152         (WebCore::ContainerNode::getUpperLeftCorner):
2153         (WebCore::ContainerNode::getLowerRightCorner):
2154         (WebCore::ContainerNode::getRect):
2155         Change to use maxX/maxY instead of x+width/y+height
2156         
2157         * platform/graphics/FloatPoint.h:
2158         (WebCore::FloatPoint::move):
2159         (WebCore::FloatPoint::moveBy):
2160         (WebCore::FloatPoint::expandedTo):
2161         Add move, moveBy and expandedTo mirroring the IntPoint implementation of the same.
2162
2163 2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
2164
2165         Speculative build fix after r88259.
2166
2167         * platform/network/cf/ResourceRequest.h:
2168
2169 2011-06-07  Michael Saboff  <msaboff@apple.com>
2170
2171         Reviewed by Geoffrey Garen.
2172
2173         Need to enable font cache purging in MemoryPressureHandler
2174         https://bugs.webkit.org/show_bug.cgi?id=62060
2175
2176         Improve memory usage under pressure.
2177         Added call to fontCache()->purgeInactiveFontData() in 
2178         MemoryPressureHandler::respondToMemoryPressure().  Added protection to 
2179         MemoryPressureHandler::install() being called multiple times.
2180
2181         No new tests as funtionality wasn't changed.
2182
2183         * platform/MemoryPressureHandler.cpp:
2184         (WebCore::MemoryPressureHandler::MemoryPressureHandler):
2185         * platform/MemoryPressureHandler.h:
2186         * platform/mac/MemoryPressureHandlerMac.mm:
2187         (WebCore::MemoryPressureHandler::install):
2188         (WebCore::MemoryPressureHandler::respondToMemoryPressure):
2189
2190 2011-06-07  Michael Saboff  <msaboff@apple.com>
2191
2192         Reviewed by Geoffrey Garen.
2193
2194         Fonts returned by FontCache::getFontDataForCharacters() are never released
2195         https://bugs.webkit.org/show_bug.cgi?id=61875
2196
2197         This change allows fonts allocated as system fallback fonts to be 
2198         released.  Previously, the reference counts for these fonts grew 
2199         without bound.  This is implemented as an auto release class that wraps
2200         accesses to the cache for system fallback fonts. All such accesses are
2201         via the method FontCache::getFontDataForCharacters. The new class is
2202         called FontCachePurgePreventer. When such an object exists, it protects
2203         these fonts from deletion.
2204
2205         Most accesses to the font cache still use the reference counting
2206         implemented by FontCache::getCacheFontData() and 
2207         FontCache::releaseFontData() and that operation is not affected by
2208         this change.
2209
2210         Added local scoped instance of FontCachePurgePreventer to wrap code
2211         that directly or indirectly accesses fonts via getFontDataForCharacters.
2212         Did a few other miscellaneous bug fixes and changes to allow system
2213         fallback fonts to be pruned from the GlyphPageTree. Changed the
2214         calls to getFontData in the platform specific versions of
2215         Fontcache::getFontDataForCharacters to not increment the reference
2216         count.  Moved the purge font check
2217         outside of FontCache::getCachedFontData() into a separate method, 
2218         purgeInactiveFontDataIfNeeded() since almost all calls to 
2219         getCachedFontData() now happen when purging is not allowed.
2220         purgeInactiveFontDataIfNeeded is invoked in enablePurging() when
2221         m_purgePreventCount is 0.
2222
2223         No new test as the functionality has not changed. Improved font life
2224         cycle management.
2225
2226         * WebCore.exp.in: Added FontCache::purgeInactiveFontDataIfNeeded().
2227         * html/canvas/CanvasRenderingContext2D.cpp:
2228         (WebCore::CanvasRenderingContext2D::measureText):
2229         (WebCore::CanvasRenderingContext2D::drawTextInternal):
2230         Wrapped code accessing fallback fonts with local 
2231         FontCachePurgePreventer in these methods.
2232
2233         * page/FrameView.cpp:
2234         (WebCore::FrameView::layout):
2235         (WebCore::FrameView::paintContents):
2236         Wrapped code accessing fallback fonts with local 
2237         FontCachePurgePreventer in these methods.
2238
2239         * platform/graphics/FontCache.cpp:
2240         (WebCore::FontCache::FontCache):
2241         (WebCore::FontCache::getCachedFontData):
2242         Moved purge check to new method since it likely can't happen here.
2243         (WebCore::FontCache::releaseFontData):
2244         (WebCore::FontCache::purgeInactiveFontDataIfNeeded):
2245         (WebCore::FontCache::purgeInactiveFontData):
2246         Made purging conditional on m_purgePreventCount.  Now some fonts
2247         in the cache are reference counted while other can be purged 
2248         outside of code wrapped by in scope FontCachePurgePreventer objects.
2249
2250         * platform/graphics/FontCache.h:
2251         (WebCore::FontCache::disablePurging):
2252         (WebCore::FontCache::enablePurging):
2253         (WebCore::FontCachePurgePreventer::FontCachePurgePreventer):
2254         (WebCore::FontCachePurgePreventer::~FontCachePurgePreventer):
2255         Added new simple purge prevention wrapper class and methods
2256         that it calls in FontCache actually prevent purging.  The
2257         simple methods inlined to reduce overhead.
2258
2259         * platform/graphics/FontFastPath.cpp:
2260         (WebCore::Font::glyphDataForCharacter): Update level in 
2261         glyph page tree for system fallback fonts so pruning works.
2262
2263         * platform/graphics/GlyphPage.h:
2264         (WebCore::GlyphPage::clearForFontData): New method used for pruning
2265         * platform/graphics/GlyphPageTreeNode.cpp:
2266         (WebCore::GlyphPageTreeNode::pruneFontData):
2267         Now we prune system fallback fonts.
2268
2269         * platform/graphics/chromium/FontCacheChromiumWin.cpp:
2270         (WebCore::FontCache::getFontDataForCharacters):
2271         * platform/graphics/freetype/FontCacheFreeType.cpp:
2272         (WebCore::FontCache::getFontDataForCharacters):
2273         * platform/graphics/haiku/FontCacheHaiku.cpp:
2274         (WebCore::FontCache::getFontDataForCharacters):
2275         * platform/graphics/mac/FontCacheMac.mm:
2276         (WebCore::FontCache::getFontDataForCharacters):
2277         * platform/graphics/qt/FontCacheQt.cpp:
2278         (WebCore::FontCache::getFontDataForCharacters):
2279         * platform/graphics/win/FontCacheWin.cpp:
2280         (WebCore::FontCache::getFontDataForCharacters):
2281         * platform/graphics/wince/FontCacheWinCE.cpp:
2282         * platform/graphics/wx/FontCacheWx.cpp:
2283         (WebCore::FontCache::getFontDataForCharacters):
2284         Changed the calls to getFontData() to not increment the reference
2285         count. The caller of this getFontDataForCharacters() (currently only
2286         Font::glyphDataForCharacter() in fontFastPath.cpp) and it's callers
2287         don't attempt to release the returned fonts so we use the purge
2288         protection described above.
2289
2290         * rendering/InlineTextBox.cpp:
2291         (WebCore::InlineTextBox::selectionRect):
2292         (WebCore::InlineTextBox::offsetForPosition):
2293         (WebCore::InlineTextBox::positionForOffset):
2294         Wrapped code accessing fallback fonts with local
2295         FontCachePurgePreventer in these methods.
2296
2297         * rendering/RenderImage.cpp:
2298         (WebCore::RenderImage::setImageSizeForAltText):
2299         Wrapped code accessing fallback fonts with local
2300         FontCachePurgePreventer in this method.
2301
2302         * rendering/RenderListBox.cpp:
2303         (WebCore::RenderListBox::updateFromElement):
2304         (WebCore::RenderListBox::paintItemForeground):
2305         Wrapped code accessing fallback fonts with local
2306         FontCachePurgePreventer in these methods
2307
2308         * rendering/svg/SVGInlineTextBox.cpp:
2309         (WebCore::SVGInlineTextBox::selectionRectForTextFragment):
2310         Wrapped code accessing fallback fonts with local
2311         FontCachePurgePreventer in this method.
2312
2313 2011-06-07  Tim Horton  <timothy_horton@apple.com>
2314
2315         Reviewed by Alexey Proskuryakov.
2316
2317         Use correct CFURLStorageSessionRef definition on Snow Leopard
2318         https://bugs.webkit.org/show_bug.cgi?id=62223
2319
2320         * platform/mac/WebCoreSystemInterface.h:
2321         * platform/network/ResourceHandle.h:
2322         * platform/network/cf/ResourceRequest.h:
2323
2324 2011-06-07  Alok Priyadarshi  <alokp@chromium.org>
2325
2326         Reviewed by Stephen White.
2327
2328         [chromium] PlatformContextSkia leaks SkDeviceFactory
2329         https://bugs.webkit.org/show_bug.cgi?id=62163
2330
2331         Valgrind tests should have caught this.
2332
2333         * platform/graphics/skia/PlatformContextSkia.cpp:
2334         (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
2335
2336 2011-06-07  Emil A Eklund  <eae@chromium.org>
2337
2338         Reviewed by Eric Seidel.
2339
2340         Convert RenderTextControl::hitInnerTextElement to IntPoint
2341         https://bugs.webkit.org/show_bug.cgi?id=62167
2342
2343         Covered by existing tests.
2344
2345         * rendering/RenderTextControl.cpp:
2346         (WebCore::RenderTextControl::hitInnerTextElement):
2347         * rendering/RenderTextControl.h:
2348         * rendering/RenderTextControlMultiLine.cpp:
2349         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
2350         * rendering/RenderTextControlSingleLine.cpp:
2351         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
2352
2353 2011-06-07  Levi Weintraub  <leviw@chromium.org>
2354
2355         Reviewed by Eric Seidel.
2356
2357         Switch paint to use IntPoint
2358         https://bugs.webkit.org/show_bug.cgi?id=62177
2359
2360         Flipping the switch on the remaining paint functions to have them all
2361         use IntPoint for the paint offset instead of tx/ty.
2362
2363         No new tests since this is just refactoring.
2364
2365         * page/FrameView.cpp:
2366         (WebCore::FrameView::paintScrollCorner):
2367         * rendering/InlineBox.cpp:
2368         (WebCore::InlineBox::paint):
2369         * rendering/RenderBlock.cpp:
2370         (WebCore::RenderBlock::paint):
2371         (WebCore::RenderBlock::paintContents):
2372         (WebCore::RenderBlock::paintChildren):
2373         (WebCore::RenderBlock::paintFloats):
2374         * rendering/RenderBlock.h:
2375         * rendering/RenderBox.cpp:
2376         (WebCore::RenderBox::paint):
2377         * rendering/RenderBox.h:
2378         * rendering/RenderBoxModelObject.cpp:
2379         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
2380         * rendering/RenderDetailsMarker.cpp:
2381         (WebCore::RenderDetailsMarker::paint):
2382         * rendering/RenderDetailsMarker.h:
2383         * rendering/RenderEmbeddedObject.cpp:
2384         (WebCore::RenderEmbeddedObject::paint):
2385         * rendering/RenderEmbeddedObject.h:
2386         * rendering/RenderFrameSet.cpp:
2387         (WebCore::RenderFrameSet::paint):
2388         * rendering/RenderFrameSet.h:
2389         * rendering/RenderImage.cpp:
2390         (WebCore::RenderImage::paint):
2391         * rendering/RenderImage.h:
2392         * rendering/RenderInline.cpp:
2393         (WebCore::RenderInline::paint):
2394         * rendering/RenderInline.h:
2395         * rendering/RenderLayer.cpp:
2396         (WebCore::RenderLayer::paintScrollCorner):
2397         (WebCore::RenderLayer::paintResizer):
2398         (WebCore::RenderLayer::paintLayer):
2399         * rendering/RenderLayerBacking.cpp:
2400         (WebCore::RenderLayerBacking::paintIntoLayer):
2401         * rendering/RenderLineBoxList.cpp:
2402         (WebCore::RenderLineBoxList::paint):
2403         * rendering/RenderLineBoxList.h:
2404         * rendering/RenderListItem.cpp:
2405         (WebCore::RenderListItem::paint):
2406         * rendering/RenderListItem.h:
2407         * rendering/RenderListMarker.cpp:
2408         (WebCore::RenderListMarker::paint):
2409         * rendering/RenderListMarker.h:
2410         * rendering/RenderObject.cpp:
2411         (WebCore::RenderObject::paint):
2412         * rendering/RenderObject.h:
2413         * rendering/RenderReplaced.cpp:
2414         (WebCore::RenderReplaced::paint):
2415         * rendering/RenderReplaced.h:
2416         * rendering/RenderReplica.cpp:
2417         (WebCore::RenderReplica::paint):
2418         * rendering/RenderReplica.h:
2419         * rendering/RenderScrollbar.cpp:
2420         (WebCore::RenderScrollbar::paintPart):
2421         * rendering/RenderScrollbarPart.cpp:
2422         (WebCore::RenderScrollbarPart::paintIntoRect):
2423         * rendering/RenderScrollbarPart.h:
2424         * rendering/RenderTable.cpp:
2425         (WebCore::RenderTable::paint):
2426         (WebCore::RenderTable::paintObject):
2427         * rendering/RenderTable.h:
2428         * rendering/RenderTableCell.cpp:
2429         (WebCore::RenderTableCell::paint):
2430         * rendering/RenderTableCell.h:
2431         * rendering/RenderTableRow.cpp:
2432         (WebCore::RenderTableRow::paint):
2433         * rendering/RenderTableRow.h:
2434         * rendering/RenderTableSection.cpp:
2435         (WebCore::RenderTableSection::paint):
2436         (WebCore::RenderTableSection::paintCell):
2437         * rendering/RenderTableSection.h:
2438         * rendering/RenderText.h:
2439         (WebCore::RenderText::paint):
2440         * rendering/RenderTextControlSingleLine.cpp:
2441         (WebCore::RenderTextControlSingleLine::paint):
2442         * rendering/RenderTextControlSingleLine.h:
2443         * rendering/RenderView.cpp:
2444         (WebCore::RenderView::paint):
2445         * rendering/RenderView.h:
2446         * rendering/RenderWidget.cpp:
2447         (WebCore::RenderWidget::paint):
2448         * rendering/RenderWidget.h:
2449         * rendering/mathml/RenderMathMLBlock.cpp:
2450         (WebCore::RenderMathMLBlock::paint):
2451         * rendering/mathml/RenderMathMLBlock.h:
2452         * rendering/mathml/RenderMathMLFraction.cpp:
2453         (WebCore::RenderMathMLFraction::paint):
2454         * rendering/mathml/RenderMathMLFraction.h:
2455         * rendering/mathml/RenderMathMLRoot.cpp:
2456         (WebCore::RenderMathMLRoot::paint):
2457         * rendering/mathml/RenderMathMLRoot.h:
2458         * rendering/mathml/RenderMathMLSquareRoot.cpp:
2459         (WebCore::RenderMathMLSquareRoot::paint):
2460         * rendering/mathml/RenderMathMLSquareRoot.h:
2461         * rendering/svg/RenderSVGContainer.cpp:
2462         (WebCore::RenderSVGContainer::paint):
2463         * rendering/svg/RenderSVGContainer.h:
2464         * rendering/svg/RenderSVGForeignObject.cpp:
2465         (WebCore::RenderSVGForeignObject::paint):
2466         * rendering/svg/RenderSVGForeignObject.h:
2467         * rendering/svg/RenderSVGHiddenContainer.cpp:
2468         (WebCore::RenderSVGHiddenContainer::paint):
2469         * rendering/svg/RenderSVGHiddenContainer.h:
2470         * rendering/svg/RenderSVGImage.cpp:
2471         (WebCore::RenderSVGImage::paint):
2472         * rendering/svg/RenderSVGImage.h:
2473         * rendering/svg/RenderSVGPath.cpp:
2474         (WebCore::RenderSVGPath::paint):
2475         * rendering/svg/RenderSVGPath.h:
2476         * rendering/svg/RenderSVGResourceMarker.cpp:
2477         (WebCore::RenderSVGResourceMarker::draw):
2478         * rendering/svg/RenderSVGRoot.cpp:
2479         (WebCore::RenderSVGRoot::paint):
2480         * rendering/svg/RenderSVGRoot.h:
2481         * rendering/svg/RenderSVGText.cpp:
2482         (WebCore::RenderSVGText::paint):
2483         * rendering/svg/RenderSVGText.h:
2484         * rendering/svg/SVGImageBufferTools.cpp:
2485         (WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer):
2486
2487 2011-06-07  Young Han Lee  <joybro@company100.net>
2488
2489         Reviewed by Kenneth Rohde Christiansen.
2490
2491         [Texmap][Qt] Accelerated animation is not paused properly.
2492         https://bugs.webkit.org/show_bug.cgi?id=61446
2493
2494         The transform matrix of an accelerated animation shouldn't be synced with the matrix of the GraphicsLayer when the animation is paused.
2495
2496         Test: animations/play-state-paused.html
2497
2498         * platform/graphics/texmap/TextureMapperNode.cpp:
2499         (WebCore::TextureMapperNode::syncCompositingStateSelf):
2500         (WebCore::TextureMapperNode::hasOpacityAnimation):
2501         (WebCore::TextureMapperNode::hasTransformAnimation):
2502         * platform/graphics/texmap/TextureMapperNode.h:
2503
2504 2011-06-07  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2505
2506         Reviewed by Antonio Gomes.
2507
2508         [EFL] Remove Ecore_X bits from PlatformScreenEfl
2509         https://bugs.webkit.org/show_bug.cgi?id=61649
2510
2511         Remove the need for Ecore_X and some X calls by always using
2512         new functions available in EFL to get the screen size.
2513
2514         No new tests since the same functionality are done inside EFL now.
2515
2516         * platform/efl/PlatformScreenEfl.cpp:
2517         (WebCore::screenRect):
2518
2519 2011-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2520
2521         Reviewed by Martin Robinson.
2522
2523         [GTK] Move moduleMixesGtkSymbols() from PluginPackage to PluginView
2524         https://bugs.webkit.org/show_bug.cgi?id=62200
2525
2526         In WebKit2 PluginPackage is used by the UI process to load plugins
2527         in order to get information about them, but it doesn't use any GTK
2528         symbol. So the UI process should be able to load plugins even when
2529         building with GTK3, but we should not allow the plugin view to use
2530         the plugin if it mixes GTK2 and GTK3 symbols.
2531
2532         * plugins/PluginPackage.h:
2533         (WebCore::PluginPackage::module): New method to return the
2534         platform module.
2535         * plugins/gtk/PluginPackageGtk.cpp:
2536         (WebCore::PluginPackage::load): Remove moduleMixesGtkSymbols().
2537         * plugins/gtk/PluginViewGtk.cpp:
2538         (WebCore::PluginView::updatePluginWidget): Check whether plugin
2539         was successfully loaded before trying to create the drawable.
2540         (WebCore::PluginView::paint): Return early if plugin didn't start
2541         or was not successfully loaded.
2542         (WebCore::PluginView::handleKeyboardEvent): Ditto.
2543         (WebCore::PluginView::handleMouseEvent): Ditto.
2544         (WebCore::PluginView::handleFocusInEvent): Ditto.
2545         (WebCore::PluginView::handleFocusOutEvent): Ditto.
2546         (WebCore::moduleMixesGtkSymbols):
2547         (WebCore::PluginView::platformStart): Check whether module is
2548         mixing GTK+ 2 and GTK+ 3 symbols.
2549
2550 2011-06-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2551
2552         Unreviewed, rolling out r88238.
2553         http://trac.webkit.org/changeset/88238
2554         https://bugs.webkit.org/show_bug.cgi?id=62216
2555
2556         Broke a couple of inspector tests (Requested by apavlov on
2557         #webkit).
2558
2559         * inspector/front-end/StylesSidebarPane.js:
2560         (WebInspector.StylesSidebarPane.prototype.update):
2561
2562 2011-06-07  Dinu Jacob  <dinu.jacob@nokia.com>
2563
2564         Reviewed by Dimitri Glazkov.
2565
2566         Inform ChromeClient touch events are not needed by the webpage when navigating away from the page instead of in both Document:detach/CachedFrame
2567         https://bugs.webkit.org/show_bug.cgi?id=61543
2568
2569         Inform chrome client that touch events are not needed by the webpage 
2570         when navigating away from the page only once to avoid the flag being 
2571         overwritten later if a page is removed from the page cache
2572
2573         * dom/Document.cpp:
2574         (WebCore::Document::detach):
2575         * history/CachedFrame.cpp:
2576         (WebCore::CachedFrame::CachedFrame):
2577         * loader/FrameLoader.cpp:
2578         (WebCore::FrameLoader::transitionToCommitted):
2579
2580 2011-06-07  Alexander Pavlov  <apavlov@chromium.org>
2581
2582         Reviewed by Yury Semikhatsky.
2583
2584         Web Inspector: node selection is slow in the Elements panel.
2585         https://bugs.webkit.org/show_bug.cgi?id=60813
2586
2587         Schedule full style updates rather than request all node styles from the backend immediately.
2588
2589         * inspector/front-end/StylesSidebarPane.js:
2590         (WebInspector.StylesSidebarPane.prototype.update.reloadAllStyles):
2591         (WebInspector.StylesSidebarPane.prototype.update):
2592
2593 2011-06-07  Yury Semikhatsky  <yurys@chromium.org>
2594
2595         Reviewed by Pavel Feldman.
2596
2597         Web Inspector: remove duplicate breakpoints from localStorage
2598         https://bugs.webkit.org/show_bug.cgi?id=62206
2599
2600         Perform one-time breakpoint storage cleanup to get rid of duplicate breakpoints in
2601         case when settings version is less than 1. 
2602
2603         * inspector/front-end/Settings.js:
2604         (WebInspector.Settings):
2605         (WebInspector.Settings.prototype._set):
2606         (WebInspector.Settings.prototype._migrateSettings.splitObjects):
2607         (WebInspector.Settings.prototype._migrateSettings.removeDuplicateObjects):
2608         (WebInspector.Settings.prototype._migrateSettings):
2609
2610 2011-06-03  Yury Semikhatsky  <yurys@chromium.org>
2611
2612         Reviewed by Pavel Feldman.
2613
2614         [Chromium] Web Inspector: correctly handle disconnect from worker when script execution is paused
2615         https://bugs.webkit.org/show_bug.cgi?id=62019
2616
2617         Dispatch disconnecFrontend message in debugger task mode to make sure
2618         it is processed even if execution is paused.
2619
2620         * bindings/v8/WorkerScriptDebugServer.cpp:
2621         (WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
2622         (WebCore::WorkerScriptDebugServer::quitMessageLoopOnPause):
2623         * bindings/v8/WorkerScriptDebugServer.h:
2624
2625 2011-06-07  Felician Marton  <marton.felician.zoltan@stud.u-szeged.hu>
2626
2627         Reviewed by Nikolas Zimmermann.
2628
2629         SVG animation beginElement() does not restart the animation after endElement().
2630         https://bugs.webkit.org/show_bug.cgi?id=43452
2631
2632         Test: svg/animations/animate-endElement-beginElement.html
2633
2634         Calling beginElement() after calling endElement() previously does not restarted the animation when animation
2635         element's end attribute doesn't contains a bigger value than the current animation time.
2636
2637         * svg/animation/SVGSMILElement.cpp:
2638         (WebCore::SVGSMILElement::findInstanceTime):
2639
2640 2011-06-07  Naoki Takano  <takano.naoki@gmail.com>
2641
2642         Reviewed by Kent Tamura.
2643
2644         [Chromium] Click event is not fired for a menulist <select>
2645         https://bugs.webkit.org/show_bug.cgi?id=60563
2646
2647         Tests: SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange in webkit_unit_tests.
2648
2649         * platform/chromium/PopupMenuChromium.cpp:
2650         (WebCore::PopupContainer::showPopup): Set m_focusedNode from m_frameView.
2651         (WebCore::PopupListBox::handleMouseReleaseEvent): Call dispatchMouseEvent to forward the event only if select popup.
2652         (WebCore::PopupListBox::acceptIndex): Change to return accepted or not.
2653
2654 2011-06-07  Andras Becsi  <abecsi@webkit.org>
2655
2656         Reviewed by Yury Semikhatsky.
2657  
2658         REGRESSION(r88221): "Chromium debug compilation broken".
2659         https://bugs.webkit.org/show_bug.cgi?id=62197
2660
2661         No new tests needed.
2662
2663         * bindings/v8/V8GCController.cpp: Also rename call-sites.
2664         (WebCore::V8GCController::gcPrologue):
2665         (WebCore::V8GCController::gcEpilogue):
2666
2667 2011-06-07  MORITA Hajime  <morrita@google.com>
2668
2669         Unreviewed, rolling out r88212 and r88219.
2670         http://trac.webkit.org/changeset/88212
2671         http://trac.webkit.org/changeset/88219
2672         https://bugs.webkit.org/show_bug.cgi?id=57439
2673
2674         Tests get timeout at Snow Leopard
2675
2676         * css/html.css:
2677         (html:focus, body:focus, input[readonly]:focus):
2678         * rendering/RenderWidget.cpp:
2679         (WebCore::RenderWidget::paint):
2680
2681 2011-06-07  Andras Becsi  <abecsi@webkit.org>
2682
2683         Rubber-stamped by Csaba Osztrogonác.
2684
2685         [Qt][V8] Fix the build after 88221.
2686
2687         No new tests needed.
2688
2689         * WebCore.pro: Remove non-existing files.
2690         * bindings/v8/V8DOMMap.cpp: 
2691         (WebCore::removeAllDOMObjects): Also rename the definition of the function.
2692
2693 2011-06-06  Dmitry Lomov  <dslomov@google.com>
2694
2695         Reviewed by Adam Barth.
2696
2697         https://bugs.webkit.org/show_bug.cgi?id=62164
2698         Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and friends
2699         This functionality is untested and unused:
2700         This is an old code from Lockers-based implementation of WebWorkers in
2701         V8 bindings, to make sure that DOM objects are released on the right thread
2702         even though GC could have happened on any thread. It is currently unused (since
2703         current model is one worker per process) and is being removed because new implementation
2704         of WebWorkers will be using V8 isolates.
2705
2706         * WebCore.gypi:
2707         * bindings/v8/ChildThreadDOMData.cpp: Removed.
2708         * bindings/v8/ChildThreadDOMData.h: Removed.
2709         * bindings/v8/DOMData.cpp:
2710         (WebCore::DOMData::DOMData):
2711         (WebCore::DOMData::getCurrent):
2712         (WebCore::DOMData::getMainThreadStore):
2713         * bindings/v8/DOMData.h:
2714         (WebCore::DOMData::getStore):
2715         (WebCore::DOMData::getCurrentMainThreadStore):
2716         (WebCore::DOMData::handleWeakObject):
2717         * bindings/v8/DOMDataStore.cpp:
2718         (WebCore::DOMDataStore::DOMDataStore):
2719         (WebCore::DOMDataStore::~DOMDataStore):
2720         (WebCore::DOMDataStore::weakNodeCallback):
2721         * bindings/v8/DOMDataStore.h:
2722         * bindings/v8/MainThreadDOMData.cpp: Removed.
2723         * bindings/v8/MainThreadDOMData.h: Removed.
2724         * bindings/v8/V8DOMMap.cpp:
2725         (WebCore::getDOMDataStore):
2726         (WebCore::visitDOMNodes):
2727         (WebCore::visitDOMObjects):
2728         (WebCore::visitActiveDOMObjects):
2729         (WebCore::visitDOMSVGElementInstances):
2730         * bindings/v8/V8DOMMap.h:
2731         * bindings/v8/V8GCController.cpp:
2732         (WebCore::V8GCController::gcPrologue):
2733         (WebCore::V8GCController::gcEpilogue):
2734         * bindings/v8/WorkerScriptController.cpp:
2735         (WebCore::WorkerScriptController::~WorkerScriptController):
2736
2737 2011-06-06  Nico Weber  <thakis@chromium.org>
2738
2739         Reviewed by Adam Barth.
2740
2741         [chromium] Make VideoFrameChromium's destructor virtual
2742         https://bugs.webkit.org/show_bug.cgi?id=62186
2743
2744         This fixes a real bug, since WebMediaPlayerClientImpl::putCurrentFrame
2745         deletes a VideoFrameChromium subclass type through this interface
2746         class, causing ~VideoFrameChromiumImpl's destructor not to run.
2747         (VideoFrameChroimumImpl happens to not have a destructor or any
2748         non-POD member variables, so it's more a latent bug.)
2749
2750         * platform/graphics/chromium/VideoFrameChromium.cpp:
2751         (WebCore::VideoFrameChromium::~VideoFrameChromium):
2752         * platform/graphics/chromium/VideoFrameChromium.h:
2753
2754 2011-06-06  Simon Fraser  <simon.fraser@apple.com>
2755
2756         Reviewed by Sammy Weinig.
2757
2758         Remove some unnecessary includes from AnimationBase.cpp
2759         https://bugs.webkit.org/show_bug.cgi?id=62183
2760
2761         * page/animation/AnimationBase.cpp:
2762
2763 2011-06-06  Kent Tamura  <tkent@chromium.org>
2764
2765         Unreviewed, a crash fix by a roll out.
2766
2767         REGRESSION(r87980): Null pointer dereference in RenderTextControl::setInnerText()
2768         https://bugs.webkit.org/show_bug.cgi?id=62116
2769
2770         Roll out the WebCore part of r87980.
2771
2772         * html/SearchInputType.cpp:
2773         (WebCore::SearchInputType::SearchInputType):
2774         (WebCore::SearchInputType::createShadowSubtree):
2775         (WebCore::SearchInputType::destroyShadowSubtree):
2776         * html/SearchInputType.h:
2777         (WebCore::SearchInputType::innerBlockElement):
2778         (WebCore::SearchInputType::resultsButtonElement):
2779         (WebCore::SearchInputType::cancelButtonElement):
2780         * html/TextFieldInputType.cpp:
2781         (WebCore::TextFieldInputType::TextFieldInputType):
2782         (WebCore::TextFieldInputType::createShadowSubtree):
2783         (WebCore::TextFieldInputType::destroyShadowSubtree):
2784         * html/TextFieldInputType.h:
2785         (WebCore::TextFieldInputType::innerTextElement):
2786         (WebCore::TextFieldInputType::innerSpinButtonElement):
2787         (WebCore::TextFieldInputType::speechButtonElement):
2788         (WebCore::TextFieldInputType::setInnerTextElement):
2789         (WebCore::TextFieldInputType::setSpeechButtonElement):
2790         * html/shadow/TextControlInnerElements.cpp:
2791         * html/shadow/TextControlInnerElements.h:
2792
2793 2011-06-06  No'am Rosenthal  <noam.rosenthal@nokia.com>
2794
2795         Reviewed by Simon Fraser.
2796
2797         Allow copying of KeyframeValueList.
2798         https://bugs.webkit.org/show_bug.cgi?id=62171
2799
2800         Make a deep copy of KeyframeValueList, copying each of the keyframes with a virtual clone() function.
2801
2802         No new functionality so no new tests.
2803
2804         * platform/graphics/GraphicsLayer.h:
2805         (WebCore::FloatAnimationValue::clone):
2806         (WebCore::TransformAnimationValue::TransformAnimationValue):
2807         (WebCore::TransformAnimationValue::clone):
2808         (WebCore::TransformAnimationValue::value):
2809         (WebCore::KeyframeValueList::KeyframeValueList):
2810
2811 2011-06-06  Simon Fraser  <simon.fraser@apple.com>
2812
2813         Reviewed by Dan Bernstein.
2814
2815         Incorrect rounding of color values during transitions
2816         https://bugs.webkit.org/show_bug.cgi?id=62141
2817         
2818         When blending integers, round to the nearest integer, instead of always rounding down.
2819
2820         Test: transitions/color-transition-rounding.html
2821
2822         * page/animation/AnimationBase.cpp:
2823         (WebCore::blendFunc):
2824
2825 2011-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
2826
2827         Unreviewed, rolling out r88202.
2828         http://trac.webkit.org/changeset/88202
2829         https://bugs.webkit.org/show_bug.cgi?id=62182
2830
2831         This broke the mac clang bot (Requested by koz__ on #webkit).
2832
2833         * dom/Node.cpp:
2834         (WebCore::Node::hasNonEmptyBoundingBox):
2835         * rendering/InlineBox.h:
2836         * rendering/RenderBlock.cpp:
2837         (WebCore::RenderBlock::absoluteRects):
2838         * rendering/RenderBlock.h:
2839         * rendering/RenderBox.cpp:
2840         (WebCore::RenderBox::absoluteRects):
2841         * rendering/RenderBox.h:
2842         * rendering/RenderInline.cpp:
2843         (WebCore::RenderInline::absoluteRects):
2844         * rendering/RenderInline.h:
2845         * rendering/RenderObject.cpp:
2846         (WebCore::RenderObject::absoluteBoundingBoxRect):
2847         * rendering/RenderObject.h:
2848         (WebCore::RenderObject::absoluteRects):
2849         * rendering/RenderText.cpp:
2850         (WebCore::RenderText::absoluteRects):
2851         * rendering/RenderText.h:
2852         * rendering/RenderView.cpp:
2853         (WebCore::RenderView::absoluteRects):
2854         * rendering/RenderView.h:
2855
2856 2011-06-06  Noel Gordon  <noel.gordon@gmail.com>
2857
2858         Reviewed by Hajime Morita.
2859
2860         Draw CSS outline style for render widgets: iframe, embed, object, applet.
2861         https://bugs.webkit.org/show_bug.cgi?id=57439
2862
2863         Draw CSS outlines for render widgets: iframe, embed, object, applet. These elements can
2864         be focused (via clicks or tabIndex) but should not have a visible focus ring by default.
2865
2866         Tests: fast/replaced/no-focus-ring-embed-1.html
2867                fast/replaced/no-focus-ring-embed-2.html
2868                fast/replaced/no-focus-ring-iframe.html
2869                fast/replaced/no-focus-ring-object-1.html
2870                fast/replaced/no-focus-ring-object-2.html
2871                fast/replaced/outline-replaced-elements.html
2872
2873         * css/html.css:
2874         (applet:focus, embed:focus, iframe:focus, object:focus):  Default to no focus ring.
2875         * rendering/RenderWidget.cpp:
2876         (WebCore::RenderWidget::paint): Paint the render widget CSS outline style.
2877
2878 2011-06-06  MORITA Hajime  <morrita@google.com>
2879
2880         Reviewed by Kent Tamura.
2881
2882         Assertion fails in TextCheckingHelper by right-clicking on <input type=search>
2883         https://bugs.webkit.org/show_bug.cgi?id=61991
2884
2885         Added a guard bofore TextCheckingHelper construction sites.
2886
2887         Test: editing/spelling/spellcheck-input-search-crash.html
2888
2889         * editing/Editor.cpp:
2890         (WebCore::Editor::isSelectionUngrammatical):
2891         (WebCore::Editor::guessesForUngrammaticalSelection):
2892         (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection):
2893
2894 2011-06-06  Emil A Eklund  <eae@chromium.org>
2895
2896         Reviewed by Eric Seidel.
2897
2898         Update RenderBlock::paint to use IntPoint internally
2899         https://bugs.webkit.org/show_bug.cgi?id=62140
2900
2901         Covered by existing tests.
2902
2903         * rendering/RenderBlock.cpp:
2904         (WebCore::RenderBlock::paint):
2905
2906 2011-06-06  Emil A Eklund  <eae@chromium.org>
2907
2908         Reviewed by Eric Seidel.
2909
2910         Convert RenderBox::absoluteRects to IntPoint
2911         https://bugs.webkit.org/show_bug.cgi?id=62130
2912
2913         Covered by existing tests.
2914
2915         * dom/Node.cpp:
2916         (WebCore::Node::hasNonEmptyBoundingBox):
2917         * rendering/RenderBlock.cpp:
2918         (WebCore::RenderBlock::absoluteRects):
2919         * rendering/RenderBlock.h:
2920         * rendering/RenderBox.cpp:
2921         (WebCore::RenderBox::absoluteRects):
2922         * rendering/RenderBox.h:
2923         * rendering/RenderInline.cpp:
2924         (WebCore::RenderInline::absoluteRects):
2925         * rendering/RenderInline.h:
2926         * rendering/RenderObject.cpp:
2927         (WebCore::RenderObject::absoluteBoundingBoxRect):
2928         * rendering/RenderObject.h:
2929         (WebCore::RenderObject::absoluteRects):
2930         * rendering/RenderText.cpp:
2931         (WebCore::RenderText::absoluteRects):
2932         * rendering/RenderText.h:
2933         * rendering/RenderView.cpp:
2934         (WebCore::RenderView::absoluteRects):
2935         * rendering/RenderView.h:
2936
2937 2011-06-06  Levi Weintraub  <leviw@chromium.org>
2938
2939         Reviewed by Eric Seidel.
2940
2941         Switch shouldPaint to use IntPoint
2942         https://bugs.webkit.org/show_bug.cgi?id=62158
2943
2944         Switching shouldPaint to take an IntPoint representing the paint offset instead
2945         of a pair of ints.
2946
2947         No new tests as this is simple refactoring.
2948
2949         * rendering/RenderReplaced.cpp:
2950         (WebCore::RenderReplaced::paint):
2951         (WebCore::RenderReplaced::shouldPaint):
2952         * rendering/RenderReplaced.h:
2953         * rendering/RenderWidget.cpp:
2954         (WebCore::RenderWidget::paint):
2955
2956 2011-06-06  James Simonsen  <simonjam@chromium.org>
2957
2958         Reviewed by James Robinson.
2959
2960         Add monotonicallyIncreasingTime() to get monotonically increasing time
2961         https://bugs.webkit.org/show_bug.cgi?id=37743
2962
2963         * platform/chromium/SystemTimeChromium.cpp:
2964         (WebCore::monotonicallyIncreasingTime): Add primitive monotonicallyIncreasingTime() which just wraps currentTime().
2965
2966 2011-06-06  Emil A Eklund  <eae@chromium.org>
2967
2968         Reviewed by Eric Seidel.
2969
2970         Convert RenderBox::pushContentsClip to IntPoint
2971         https://bugs.webkit.org/show_bug.cgi?id=62133
2972
2973         Covered by existing tests.
2974
2975         * rendering/RenderBlock.cpp:
2976         (WebCore::Covered by existing tests.RenderBlock::paint):
2977         * rendering/RenderBox.cpp:
2978         (WebCore::RenderBox::pushContentsClip):
2979         * rendering/RenderBox.h:
2980         * rendering/RenderTable.cpp:
2981         (WebCore::RenderTable::paint):
2982         * rendering/RenderTableSection.cpp:
2983         (WebCore::RenderTableSection::paint):
2984
2985 2011-06-06  Levi Weintraub  <leviw@chromium.org>
2986
2987         Reviewed by Eric Seidel.
2988
2989         Switch InlineFlowBox::paintMask to use IntPoint
2990         https://bugs.webkit.org/show_bug.cgi?id=62156
2991
2992         Switching InlineFlowBox::paintMask to take an IntPoint representing the paint
2993         offset instead of a pair of ints.
2994
2995         No new tests as this is simple refactoring.
2996
2997         * rendering/InlineFlowBox.cpp:
2998         (WebCore::InlineFlowBox::paint):
2999         (WebCore::InlineFlowBox::paintMask):
3000         * rendering/InlineFlowBox.h:
3001
3002 2011-06-06  Emil A Eklund  <eae@chromium.org>
3003
3004         Reviewed by Eric Seidel.
3005
3006         Convert hitTest to IntPoint
3007         https://bugs.webkit.org/show_bug.cgi?id=62144
3008
3009         Covered by existing tests.
3010
3011         * rendering/InlineBox.cpp:
3012         (WebCore::InlineBox::nodeAtPoint):
3013         * rendering/RenderBlock.cpp:
3014         (WebCore::RenderBlock::hitTestFloats):
3015         (WebCore::RenderBlock::hitTestContents):
3016         * rendering/RenderInline.cpp:
3017         (WebCore::RenderInline::nodeAtPoint):
3018         * rendering/RenderLayer.cpp:
3019         (WebCore::RenderLayer::hitTestContents):
3020         * rendering/RenderLayer.h:
3021         (WebCore::RenderLayer::renderBoxLocation):
3022         (WebCore::RenderLayer::renderBoxX):
3023         (WebCore::RenderLayer::renderBoxY):
3024         * rendering/RenderLineBoxList.cpp:
3025         (WebCore::RenderLineBoxList::hitTest):
3026         * rendering/RenderLineBoxList.h:
3027         * rendering/RenderObject.cpp:
3028         (WebCore::RenderObject::hitTest):
3029         * rendering/RenderObject.h:
3030
3031 2011-06-06  Levi Weintraub  <leviw@chromium.org>
3032
3033         Reviewed by Eric Seidel.
3034
3035         Switch paintScrollbar to use IntPoint
3036         https://bugs.webkit.org/show_bug.cgi?id=62151
3037
3038         Switching paintScrollbar to use IntPoint instead of a pair of ints.
3039
3040         No new tests since this is simple refactoring.
3041
3042         * rendering/RenderListBox.cpp:
3043         (WebCore::RenderListBox::paintObject):
3044         (WebCore::RenderListBox::paintScrollbar):
3045         * rendering/RenderListBox.h:
3046
3047 2011-06-06  Daniel Cheng  <dcheng@chromium.org>
3048
3049         Reviewed by Tony Chang.
3050
3051         [chromium] Delete dead clipboard code.
3052         https://bugs.webkit.org/show_bug.cgi?id=62113
3053
3054         No new tests since this change only deleted unused code.
3055
3056         * WebCore.gypi:
3057         * platform/chromium/ChromiumDataObjectLegacy.cpp: Removed.
3058         * platform/chromium/ChromiumDataObjectLegacy.h: Removed.
3059         * platform/chromium/ReadableDataObject.cpp: Removed.
3060         * platform/chromium/ReadableDataObject.h: Removed.
3061         * platform/chromium/WritableDataObject.cpp: Removed.
3062         * platform/chromium/WritableDataObject.h: Removed.
3063
3064 2011-06-06  Levi Weintraub  <leviw@chromium.org>
3065
3066         Reviewed by Eric Seidel.
3067
3068         Switch paintOutline, paintContinuationOutlines, and paintOutlineForLine to use IntPoint
3069         https://bugs.webkit.org/show_bug.cgi?id=62137
3070
3071         Switching paintOutline, paintContinuationOutlines, and paintOutlineForLine to take an IntPoint
3072         representing the paint offset instead of a pair of ints.
3073
3074         No new tests as this is simple refactoring.
3075
3076         * rendering/RenderBlock.cpp:
3077         (WebCore::RenderBlock::paintObject):
3078         (WebCore::RenderBlock::paintContinuationOutlines):
3079         * rendering/RenderBlock.h:
3080         * rendering/RenderInline.cpp:
3081         (WebCore::RenderInline::paintOutline):
3082         (WebCore::RenderInline::paintOutlineForLine):
3083         * rendering/RenderInline.h:
3084         * rendering/RenderLineBoxList.cpp:
3085         (WebCore::RenderLineBoxList::paint):
3086
3087 2011-06-06  Emil A Eklund  <eae@chromium.org>
3088
3089         Reviewed by Eric Seidel.
3090
3091         Convert RenderBox::popContentsClip to IntPoint
3092         https://bugs.webkit.org/show_bug.cgi?id=62132
3093
3094         Covered by existing tests.
3095
3096         * rendering/RenderBlock.cpp:
3097         (WebCore::RenderBlock::paint):
3098         * rendering/RenderBox.cpp:
3099         (WebCore::RenderBox::popContentsClip):
3100         * rendering/RenderBox.h:
3101         * rendering/RenderTable.cpp:
3102         (WebCore::RenderTable::paint):
3103         * rendering/RenderTableSection.cpp:
3104         (WebCore::RenderTableSection::paint):
3105
3106 2011-06-06  Levi Weintraub  <leviw@chromium.org>
3107
3108         Reviewed by Eric Seidel.
3109
3110         Remove tx/ty offset from selectionRect
3111         https://bugs.webkit.org/show_bug.cgi?id=62146
3112
3113         Removing unused offset parameters from selectionRect.
3114
3115         No new tests since this is just cleanup.
3116
3117         * rendering/EllipsisBox.cpp:
3118         (WebCore::EllipsisBox::selectionRect):
3119         * rendering/EllipsisBox.h:
3120         * rendering/InlineTextBox.cpp:
3121         (WebCore::InlineTextBox::selectionRect):
3122         * rendering/InlineTextBox.h:
3123         * rendering/RenderText.cpp:
3124         (WebCore::RenderText::absoluteRectsForRange):
3125         (WebCore::ellipsisRectForBox):
3126         (WebCore::RenderText::absoluteQuadsForRange):
3127         (WebCore::RenderText::selectionRectForRepaint):
3128         * rendering/svg/RenderSVGInlineText.cpp:
3129         (WebCore::RenderSVGInlineText::localCaretRect):
3130         * rendering/svg/SVGInlineTextBox.cpp:
3131         (WebCore::SVGInlineTextBox::selectionRect):
3132         * rendering/svg/SVGInlineTextBox.h:
3133
3134 2011-06-06  Paul Kinlan  <paulkinlan@google.com>
3135
3136         Reviewed by Jeremy Orlow.
3137
3138         Let developers call createEvent("PopStateEvent"), previously it wasn't
3139         exposed and threw an exeception. 
3140         https://bugs.webkit.org/show_bug.cgi?id=62099
3141
3142         * WebCore/dom/Document.cpp:
3143         * WebCore/dom/PopStateEvent.cpp:
3144         * WebCore/dom/PopStateEvent.h:
3145
3146 2011-06-03  Levi Weintraub  <leviw@chromium.org>
3147
3148         Reviewed by Eric Seidel.
3149
3150         Switch paintSelection to use IntPoint
3151         https://bugs.webkit.org/show_bug.cgi?id=62059
3152
3153         Switching paintSelection to use an IntPoint to represent the paint offset
3154         instead of a pair of ints.
3155
3156         No new tests since this is simple refactoring.
3157
3158         * rendering/EllipsisBox.cpp:
3159         (WebCore::EllipsisBox::paint):
3160         (WebCore::EllipsisBox::paintSelection):
3161         * rendering/EllipsisBox.h:
3162         * rendering/RenderBlock.cpp:
3163         (WebCore::RenderBlock::paintObject):
3164         (WebCore::RenderBlock::paintSelection):
3165         * rendering/RenderBlock.h:
3166
3167 2011-06-06  Emil A Eklund  <eae@chromium.org>
3168
3169         Reviewed by Eric Seidel.
3170
3171         Convert RenderBox::clipRect to IntPoint
3172         https://bugs.webkit.org/show_bug.cgi?id=62045
3173
3174         Covered by existing tests.
3175
3176         * rendering/RenderBox.cpp:
3177         (WebCore::RenderBox::clipRect):
3178         * rendering/RenderBox.h:
3179         * rendering/RenderLayer.cpp:
3180         (WebCore::RenderLayer::calculateClipRects):
3181         (WebCore::RenderLayer::calculateRects):
3182         (WebCore::RenderLayer::repaintBlockSelectionGaps):
3183         * rendering/RenderLayerBacking.cpp:
3184         (WebCore::clipBox):
3185
3186 2011-06-06  Peter Kasting  <pkasting@google.com>
3187
3188         Reviewed by Antonio Gomes.
3189
3190         Remove unnecessary args from scroll functions.
3191         https://bugs.webkit.org/show_bug.cgi?id=61648
3192
3193         No behavior change, so no tests.
3194
3195         * WebCore.exp.in:
3196         * WebCore.order:
3197         * dom/Element.cpp:
3198         (WebCore::Element::scrollIntoView):
3199         (WebCore::Element::scrollIntoViewIfNeeded):
3200         * editing/FrameSelection.cpp:
3201         (WebCore::FrameSelection::revealSelection):
3202         * page/EventHandler.cpp:
3203         (WebCore::EventHandler::handleMousePressEvent):
3204         * page/FrameView.cpp:
3205         (WebCore::FrameView::scrollToAnchor):
3206         * rendering/RenderBox.cpp:
3207         (WebCore::RenderBox::canBeScrolledAndHasScrollableArea):
3208         (WebCore::RenderBox::canBeProgramaticallyScrolled):
3209         * rendering/RenderBox.h:
3210         * rendering/RenderLayer.cpp:
3211         (WebCore::RenderLayer::scrollRectToVisible):
3212         (WebCore::RenderLayer::autoscroll):
3213         * rendering/RenderLayer.h:
3214         * rendering/RenderListBox.h:
3215         (WebCore::RenderListBox::canBeProgramaticallyScrolled):
3216         * rendering/RenderTextControl.h:
3217         (WebCore::RenderTextControl::canBeProgramaticallyScrolled):
3218
3219 2011-06-06  Levi Weintraub  <leviw@chromium.org>
3220
3221         Reviewed by Eric Seidel.
3222
3223         Switch paintContents, paintColumnContents, paintColumnRules, and paintSelection to use IntPoint
3224         https://bugs.webkit.org/show_bug.cgi?id=62134
3225
3226         Switching paintContents, paintColumnContents, paintColumnRules, and paintSelection to take an
3227         IntPoint representing the paint offset instead of a pair of ints.
3228
3229         No new tests as this simple refactoring.
3230
3231         * rendering/RenderBlock.cpp:
3232         (WebCore::RenderBlock::paintColumnRules):
3233         (WebCore::RenderBlock::paintColumnContents):
3234         (WebCore::RenderBlock::paintContents):
3235         (WebCore::RenderBlock::paintObject):
3236         (WebCore::RenderBlock::paintSelection):
3237         * rendering/RenderBlock.h:
3238
3239 2011-06-06  Yael Aharon  <yael.aharon@nokia.com>
3240
3241         Reviewed by Eric Seidel.
3242
3243         Inline elements are wrapped prematurely with non-zero border, margin or padding.
3244         https://bugs.webkit.org/show_bug.cgi?id=60459
3245
3246         When an inline element has a right border/margin/padding and it has more than one descendant with no siblings,
3247         the width of the right border/margin/padding should be included in line breaking calculation only once,
3248         and not for each descendant.
3249
3250         Test: fast/inline/inline-wrap-with-parent-padding.html
3251
3252         * rendering/RenderBlockLineLayout.cpp:
3253         (WebCore::RenderBlock::LineBreaker::nextLineBreak):
3254
3255 2011-06-06  Shishir Agrawal  <shishir@chromium.org>
3256
3257         Reviewed by Tony Gentilcore.
3258
3259         Add a "prerender" state for page visibility.
3260         https://bugs.webkit.org/show_bug.cgi?id=62062
3261
3262         * page/PageVisibilityState.cpp:
3263         (WebCore::pageVisibilityStateString):
3264         * page/PageVisibilityState.h:
3265
3266 2011-06-06  Cary Clark  <caryclark@google.com>
3267
3268         Reviewed by Eric Seidel.
3269
3270         Fix typo in CachedFont.cpp #define
3271         https://bugs.webkit.org/show_bug.cgi?id=62127
3272
3273         No new tests. The define typo in question is
3274         not yet enabled, so this change has no functional
3275         impact.
3276
3277         * loader/cache/CachedFont.cpp:
3278         change SKIA_MAC_ON_CHROME to SKIA_ON_MAC_CHROME
3279
3280 2011-06-03  Levi Weintraub  <leviw@chromium.org>
3281
3282         Reviewed by Eric Seidel.
3283
3284         Switch paintFloats, paintChildren, and paintEllipsisBoxes to use IntPoint
3285         https://bugs.webkit.org/show_bug.cgi?id=62058
3286
3287         Switching paintFloats, paintChildren, and paintEllipsisBoxes to take IntPoints representing
3288         their paint offsets instead of pairs of ints.
3289
3290         No new tests since this is simple refactoring.
3291
3292         * rendering/RenderBlock.cpp:
3293         (WebCore::RenderBlock::paintColumnContents):
3294         (WebCore::RenderBlock::paintContents):
3295         (WebCore::RenderBlock::paintChildren):
3296         (WebCore::RenderBlock::paintObject):
3297         (WebCore::RenderBlock::paintFloats):
3298         (WebCore::RenderBlock::paintEllipsisBoxes):
3299         * rendering/RenderBlock.h:
3300
3301 2011-06-06  Steve Block  <steveblock@google.com>
3302
3303         Reviewed by Yury Semikhatsky.
3304
3305         Use of ENABLE(INSPECTOR) is inconsistent
3306         https://bugs.webkit.org/show_bug.cgi?id=62118
3307
3308         Correctly guard implementation of ScriptProfiler.
3309
3310         No new tests, build fix only.
3311
3312         * bindings/v8/ScriptProfiler.cpp:
3313         (WebCore::ScriptProfiler::initialize):
3314
3315 2011-06-04  Dominic Cooney  <dominicc@chromium.org>
3316
3317         Reviewed by Dimitri Glazkov.
3318
3319         Add WebCoreTestSupport project.
3320         https://bugs.webkit.org/show_bug.cgi?id=61076
3321
3322         * WebCore.vcproj/WebCoreCommon.vsprops:
3323         * WebCore.vcproj/WebCoreTestSupport.vcproj: Added.
3324         * WebCore.vcproj/copyForwardingHeaders.cmd: Copy WebCoreTestSupport.h.
3325
3326 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
3327
3328         Reviewed by Kent Tamura.
3329
3330         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
3331         https://bugs.webkit.org/show_bug.cgi?id=61628
3332
3333         This patch modifies only the build system. Therefore,
3334         there are no new tests.
3335
3336         * Configurations/FeatureDefines.xcconfig:
3337
3338 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
3339
3340         Reviewed by Kent Tamura.
3341
3342         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
3343         https://bugs.webkit.org/show_bug.cgi?id=61631
3344         
3345         This patch modifies only the build system. Therefore,
3346         there are no new tests.
3347
3348         * Configurations/FeatureDefines.xcconfig:
3349
3350 2011-06-03  Hans Wennborg  <hans@chromium.org>
3351
3352         Reviewed by Tony Gentilcore.
3353
3354         IndexedDB: Clean-up function prototypes in IDBLevelDBBackingStore.cpp
3355         https://bugs.webkit.org/show_bug.cgi?id=62013
3356
3357         Clean up the prototypes for cursor open functions by introducing the
3358         CursorOptions struct.
3359
3360         Just clean-up, no new functionality so no new tests.
3361
3362         * storage/IDBLevelDBBackingStore.cpp:
3363         (WebCore::CursorOptions::CursorImplCommon::CursorImplCommon):
3364         (WebCore::CursorOptions::CursorImplCommon::firstSeek):
3365         (WebCore::CursorOptions::CursorImplCommon::continueFunction):
3366         (WebCore::CursorOptions::ObjectStoreCursorImpl::create):
3367         (WebCore::CursorOptions::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
3368         (WebCore::CursorOptions::IndexKeyCursorImpl::create):
3369         (WebCore::CursorOptions::IndexKeyCursorImpl::IndexKeyCursorImpl):
3370         (WebCore::CursorOptions::IndexCursorImpl::create):
3371         (WebCore::CursorOptions::IndexCursorImpl::IndexCursorImpl):
3372         (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
3373         (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
3374         (WebCore::IDBLevelDBBackingStore::openIndexCursor):
3375
3376 2011-06-06  Mustafizur Rahaman  <mustaf.here@gmail.com>
3377
3378         Reviewed by Darin Adler.
3379
3380         Fix LayoutTests/canvas/philip/tests/2d.composite.operation.highlight.html
3381         https://bugs.webkit.org/show_bug.cgi?id=48290
3382         
3383         "highlight" is not a valid globalComposite operation
3384         as per http://www.w3.org/TR/2011/WD-2dcontext-20110525/#compositing
3385         Therefore, removed the option from the source code.
3386         
3387         Tests: No new tests required.
3388         LayoutTests\canvas\philip\tests\2d.composite.operation.highlight.html can be used for testing.
3389
3390         * css/CSSPrimitiveValueMappings.h:
3391         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
3392         (WebCore::CSSPrimitiveValue::operator CompositeOperator):
3393         * platform/graphics/GraphicsTypes.cpp:
3394         * platform/graphics/GraphicsTypes.h:
3395         * platform/graphics/cairo/CairoUtilities.cpp:
3396         (WebCore::toCairoOperator):
3397         * platform/graphics/cg/GraphicsContextCG.cpp:
3398         (WebCore::GraphicsContext::setPlatformCompositeOperation):
3399         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
3400         (WebCore::SharedGraphicsContext3D::applyCompositeOperator):
3401         * platform/graphics/openvg/PainterOpenVG.cpp:
3402         (WebCore::PlatformPainterState::applyBlending):
3403         * platform/graphics/qt/GraphicsContextQt.cpp:
3404         (WebCore::toQtCompositionMode):
3405         * platform/graphics/skia/SkiaUtils.cpp:
3406
3407 2011-06-04  Abhishek Arya  <inferno@chromium.org>
3408
3409         Reviewed by Kent Tamura.
3410
3411         Add some asserts for array boundary checks in TextRun. Fix
3412         an integer issue in linux text controller code.
3413         https://bugs.webkit.org/show_bug.cgi?id=62085
3414
3415         Testing ComplexTextControllerLinux change requires a testcase
3416         > 32 kb which is not feasible. All other changes are tested by
3417         existing layouttests.
3418
3419         * platform/graphics/TextRun.h:
3420         (WebCore::TextRun::operator[]): add assert.
3421         (WebCore::TextRun::data): add assert.
3422         * platform/graphics/WidthIterator.cpp:
3423         (WebCore::WidthIterator::advance): bail early and prevent access
3424         to one byte across the text run boundary.
3425         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
3426         (WebCore::ComplexTextController::getNormalizedTextRun): wrong
3427         int16 vs int comparison.
3428         * rendering/svg/SVGTextRunRenderingContext.cpp:
3429         (WebCore::SVGTextRunWalker::walk): bail early when from and to
3430         is outside the text run boundary. this hit easily after adding
3431         the assert when from = to = end and read in run.data(from). 
3432
3433 2011-06-05  Kent Tamura  <tkent@chromium.org>
3434
3435         Reviewed by Dimitri Glazkov.
3436
3437         Rolling out r84528.
3438         http://trac.webkit.org/changeset/84528
3439         https://bugs.webkit.org/show_bug.cgi?id=62100
3440
3441         It made several problems on elements with new shadow DOM.
3442
3443         * dom/Element.cpp:
3444         (WebCore::Element::copyNonAttributeProperties):
3445
3446 2011-06-05  Igor Oliveira  <igor.oliveira@openbossa.org>
3447
3448         Reviewed by Kenneth Rohde Christiansen.
3449
3450         fast/viewport/viewport-45.html fails in GTK+/Qt
3451         https://bugs.webkit.org/show_bug.cgi?id=47481
3452
3453         computeViewportAttributes does many math operations with float point arithmetic
3454         and in some cases there is loss of precision making tests have incorrect values.
3455
3456         * dom/ViewportArguments.cpp:
3457         (WebCore::computeViewportAttributes):
3458
3459 == Rolled over to ChangeLog-2011-06-04 ==