cc536c99218c1f791c9a248fbe1421d76f2f8c3f
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2013-04-24  Benjamin Poulain  <bpoulain@apple.com>
2
3         Do not use static string in DiagnosticLoggingKeys
4         https://bugs.webkit.org/show_bug.cgi?id=115093
5
6         Reviewed by Andreas Kling.
7
8         The code is not hot enough to justify keeping the memory around.
9         This removes 3kb from the binary on x86_64.
10
11         * page/DiagnosticLoggingKeys.cpp:
12         (WebCore::DiagnosticLoggingKeys::mediaLoadedKey):
13         (WebCore::DiagnosticLoggingKeys::mediaLoadingFailedKey):
14         (WebCore::DiagnosticLoggingKeys::pluginLoadedKey):
15         (WebCore::DiagnosticLoggingKeys::pluginLoadingFailedKey):
16         (WebCore::DiagnosticLoggingKeys::pageContainsPluginKey):
17         (WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOnePluginKey):
18         (WebCore::DiagnosticLoggingKeys::pageContainsMediaEngineKey):
19         (WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOneMediaEngineKey):
20         (WebCore::DiagnosticLoggingKeys::passKey):
21         (WebCore::DiagnosticLoggingKeys::failKey):
22         (WebCore::DiagnosticLoggingKeys::noopKey):
23         * page/DiagnosticLoggingKeys.h:
24         (DiagnosticLoggingKeys):
25
26 2013-04-24  Benjamin Poulain  <benjamin@webkit.org>
27
28         Remove wxWebKit #ifdefs from WebCore/platform/graphics
29         https://bugs.webkit.org/show_bug.cgi?id=115081
30
31         Reviewed by Geoffrey Garen.
32
33         * platform/graphics/BitmapImage.h:
34         (BitmapImage):
35         * platform/graphics/Color.h:
36         (Color):
37         * platform/graphics/FloatRect.h:
38         (FloatRect):
39         * platform/graphics/FloatSize.h:
40         (FloatSize):
41         * platform/graphics/FontPlatformData.h:
42         * platform/graphics/GlyphBuffer.h:
43         (WebCore):
44         (WebCore::GlyphBuffer::glyphAt):
45         (WebCore::GlyphBuffer::add):
46         * platform/graphics/Gradient.h:
47         * platform/graphics/GraphicsContext.h:
48         (GraphicsContext):
49         * platform/graphics/Image.cpp:
50         (WebCore::Image::drawTiled):
51         * platform/graphics/ImageBufferData.h:
52         * platform/graphics/IntPoint.h:
53         (IntPoint):
54         * platform/graphics/IntRect.h:
55         * platform/graphics/IntSize.h:
56         (IntSize):
57         * platform/graphics/NativeImagePtr.h:
58         (WebCore):
59         * platform/graphics/Path.h:
60         * platform/graphics/Pattern.h:
61         * platform/graphics/SimpleFontData.h:
62         (SimpleFontData):
63         (WebCore::SimpleFontData::widthForGlyph):
64         * platform/graphics/mac/ComplexTextController.cpp:
65         (WebCore::ComplexTextController::collectComplexTextRuns):
66         * platform/graphics/mac/ComplexTextControllerCoreText.mm:
67         (WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
68         * platform/graphics/transforms/AffineTransform.h:
69         (AffineTransform):
70         * platform/graphics/transforms/TransformationMatrix.h:
71         (TransformationMatrix):
72
73 2013-04-24  Benjamin Poulain  <benjamin@webkit.org>
74
75         Remove wxWebKit #ifdefs from WebCore/plugins
76         https://bugs.webkit.org/show_bug.cgi?id=115080
77
78         Reviewed by Geoffrey Garen.
79
80         * plugins/PluginView.h:
81         (PluginView):
82         * plugins/mac/PluginViewMac.mm:
83         (WebCore::nativeWindowFor):
84         (WebCore::cgHandleFor):
85         (WebCore::topLevelOffsetFor):
86         (WebCore::PluginView::platformStart):
87         * plugins/win/PluginViewWin.cpp:
88         (windowHandleForPageClient):
89         (WebCore::PluginView::handleMouseEvent):
90         (WebCore::PluginView::platformStart):
91         (WebCore::PluginView::snapshot):
92
93 2013-04-24  Benjamin Poulain  <benjamin@webkit.org>
94
95         Remove wxWebKit #ifdefs from WebCore/page
96         https://bugs.webkit.org/show_bug.cgi?id=115079
97
98         Reviewed by Geoffrey Garen.
99
100         * page/FrameView.cpp:
101         (WebCore::FrameView::wheelEvent):
102         * page/Settings.cpp:
103         (WebCore):
104         * page/Settings.h:
105         (Settings):
106
107 2013-04-24  Chris Fleizach  <cfleizach@apple.com>
108
109         AX: WAI-ARIA landmarks no longer speak type of landmark on iOS
110         https://bugs.webkit.org/show_bug.cgi?id=114547
111
112         Reviewed by David Kilzer.
113
114         We want iOS to speak the landmark type.
115         I've moved the landmark role description to the base Mac class and exposed
116         these localized strings to iOS (the ones used to return landmark descriptions).
117
118         I've also updated the accessibilityLabel to account for landmark type, but also
119         handle multiple label sources more gracefully by appending commas, which changed a few
120         tests in minor ways.
121
122         Test: platform/iphone-simulator/accessibility/landmark-type.html
123
124         * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
125         (-[WebAccessibilityObjectWrapper accessibilityLabel]):
126         * accessibility/mac/WebAccessibilityObjectWrapperBase.h:
127         * accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
128         (-[WebAccessibilityObjectWrapperBase ariaLandmarkRoleDescription]):
129         * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
130         (-[WebAccessibilityObjectWrapper roleDescription]):
131         * platform/LocalizedStrings.cpp:
132         (WebCore):
133         (WebCore::AXButtonActionVerb):
134         (WebCore::AXRadioButtonActionVerb):
135         (WebCore::AXTextFieldActionVerb):
136         (WebCore::AXCheckedCheckBoxActionVerb):
137         (WebCore::AXUncheckedCheckBoxActionVerb):
138         (WebCore::AXLinkActionVerb):
139         (WebCore::AXMenuListPopupActionVerb):
140         (WebCore::AXMenuListActionVerb):
141         * platform/LocalizedStrings.h:
142         (WebCore):
143
144 2013-04-24  Andreas Kling  <akling@apple.com>
145
146         CSS attribute selectors cause unnecessary style recalc when setting attribute to same value.
147         <http://webkit.org/b/115116>
148         <rdar://problem/13727709>
149
150         Reviewed by Simon Fraser.
151
152         The logic that dirties the style if there's a relevant attribute selector in the document
153         shouldn't run if the attribute is being overwritten with an identical value.
154         Move this into willModifyAttribute() instead, since we need access to both the old and the new value.
155
156         This reduces unnecessary style recalculation in Mac App Store content.
157
158         * dom/Element.cpp:
159         (WebCore::Element::attributeChanged):
160         (WebCore::Element::willModifyAttribute):
161
162 2013-04-24  Jonathan Feldstein <jfeldstein@blackberry.com>
163
164         [BlackBerry] Fixes the San Angeles demo on khronos.org
165         https://bugs.webkit.org/show_bug.cgi?id=115106
166
167         Reviewed by Rob Buis
168         Internally Reviewed by Jeremy Nicholl and Arvid Nilsson
169
170         Fixes a bug in which the currently bound vertex array object's vertex array
171         state was being modified as opposed to the default vertex array state.
172
173         * platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:
174         (EGLImageLayerWebKitThread::blitToFrontBuffer):
175
176 2013-04-24  Nico Weber  <thakis@chromium.org>
177
178         Fold RenderThemeMacShared into RenderThemeMac
179         https://bugs.webkit.org/show_bug.cgi?id=115086
180
181         Reviewed by Anders Carlsson.
182
183         No intended functionality change.
184
185         * WebCore.xcodeproj/project.pbxproj:
186         * rendering/RenderThemeMac.h:
187         (RenderThemeMac):
188         (WebCore::RenderThemeMac::supportsControlTints):
189         (WebCore::RenderThemeMac::scrollbarControlSizeForPart):
190         (WebCore::RenderThemeMac::supportsSelectionForegroundColors):
191         (WebCore::RenderThemeMac::supportsClosedCaptioning):
192         (WebCore::RenderThemeMac::updateActiveState):
193         * rendering/RenderThemeMac.mm:
194         (-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
195         (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]):
196         (-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:]):
197         (WebCore::RenderThemeMac::RenderThemeMac):
198         (WebCore::RenderThemeMac::~RenderThemeMac):
199         (WebCore::RenderThemeMac::platformActiveSelectionBackgroundColor):
200         (WebCore):
201         (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor):
202         (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor):
203         (WebCore::RenderThemeMac::platformActiveListBoxSelectionForegroundColor):
204         (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor):
205         (WebCore::RenderThemeMac::platformFocusRingColor):
206         (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):
207         (WebCore::toFontWeight):
208         (WebCore::RenderThemeMac::systemFont):
209         (WebCore::convertNSColorToColor):
210         (WebCore::menuBackgroundColor):
211         (WebCore::RenderThemeMac::platformColorsDidChange):
212         (WebCore::RenderThemeMac::systemColor):
213         (WebCore::RenderThemeMac::usesTestModeFocusRingColor):
214         (WebCore::RenderThemeMac::isControlStyled):
215         (WebCore::RenderThemeMac::adjustRepaintRect):
216         (WebCore::RenderThemeMac::inflateRect):
217         (WebCore::RenderThemeMac::convertToPaintingRect):
218         (WebCore::RenderThemeMac::updateCheckedState):
219         (WebCore::RenderThemeMac::updateEnabledState):
220         (WebCore::RenderThemeMac::updateFocusedState):
221         (WebCore::RenderThemeMac::updatePressedState):
222         (WebCore::RenderThemeMac::controlSupportsTints):
223         (WebCore::RenderThemeMac::controlSizeForFont):
224         (WebCore::RenderThemeMac::setControlSize):
225         (WebCore::RenderThemeMac::sizeForFont):
226         (WebCore::RenderThemeMac::sizeForSystemFont):
227         (WebCore::RenderThemeMac::setSizeFromFont):
228         (WebCore::RenderThemeMac::setFontFromControlSize):
229         (WebCore::RenderThemeMac::controlSizeForSystemFont):
230         (WebCore::RenderThemeMac::paintTextField):
231         (WebCore::RenderThemeMac::adjustTextFieldStyle):
232         (WebCore::RenderThemeMac::paintCapsLockIndicator):
233         (WebCore::RenderThemeMac::paintTextArea):
234         (WebCore::RenderThemeMac::adjustTextAreaStyle):
235         (WebCore::RenderThemeMac::popupButtonMargins):
236         (WebCore::RenderThemeMac::popupButtonSizes):
237         (WebCore::RenderThemeMac::popupButtonPadding):
238         (WebCore::RenderThemeMac::paintMenuList):
239         (WebCore::RenderThemeMac::meterSizeForBounds):
240         (WebCore::RenderThemeMac::paintMeter):
241         (WebCore::RenderThemeMac::supportsMeter):
242         (WebCore::RenderThemeMac::levelIndicatorStyleFor):
243         (WebCore::RenderThemeMac::levelIndicatorFor):
244         (WebCore::RenderThemeMac::progressBarSizes):
245         (WebCore::RenderThemeMac::progressBarMargins):
246         (WebCore::RenderThemeMac::minimumProgressBarHeight):
247         (WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar):
248         (WebCore::RenderThemeMac::animationDurationForProgressBar):
249         (WebCore::RenderThemeMac::adjustProgressBarStyle):
250         (WebCore::RenderThemeMac::paintProgressBar):
251         (WebCore::TopGradientInterpolate):
252         (WebCore::BottomGradientInterpolate):
253         (WebCore::MainGradientInterpolate):
254         (WebCore::TrackGradientInterpolate):
255         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
256         (WebCore::RenderThemeMac::paintMenuListButton):
257         (WebCore::menuListButtonSizes):
258         (WebCore::RenderThemeMac::adjustMenuListStyle):
259         (WebCore::RenderThemeMac::popupInternalPaddingLeft):
260         (WebCore::RenderThemeMac::popupInternalPaddingRight):
261         (WebCore::RenderThemeMac::popupInternalPaddingTop):
262         (WebCore::RenderThemeMac::popupInternalPaddingBottom):
263         (WebCore::RenderThemeMac::adjustMenuListButtonStyle):
264         (WebCore::RenderThemeMac::setPopupButtonCellState):
265         (WebCore::RenderThemeMac::menuListSizes):
266         (WebCore::RenderThemeMac::minimumMenuListSize):
267         (WebCore::RenderThemeMac::adjustSliderTrackStyle):
268         (WebCore::RenderThemeMac::paintSliderTrack):
269         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
270         (WebCore::RenderThemeMac::paintSliderThumb):
271         (WebCore::RenderThemeMac::paintSearchField):
272         (WebCore::RenderThemeMac::setSearchCellState):
273         (WebCore::RenderThemeMac::searchFieldSizes):
274         (WebCore::RenderThemeMac::setSearchFieldSize):
275         (WebCore::RenderThemeMac::adjustSearchFieldStyle):
276         (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
277         (WebCore::RenderThemeMac::cancelButtonSizes):
278         (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
279         (WebCore::RenderThemeMac::resultsButtonSizes):
280         (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
281         (WebCore::RenderThemeMac::paintSearchFieldDecoration):
282         (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
283         (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
284         (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
285         (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
286         (WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):
287         (WebCore::RenderThemeMac::sliderTickSize):
288         (WebCore::RenderThemeMac::sliderTickOffsetFromTrackCenter):
289         (WebCore::RenderThemeMac::adjustSliderThumbSize):
290         (WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):
291         (WebCore::RenderThemeMac::popupButton):
292         (WebCore::RenderThemeMac::search):
293         (WebCore::RenderThemeMac::searchMenuTemplate):
294         (WebCore::RenderThemeMac::sliderThumbHorizontal):
295         (WebCore::RenderThemeMac::sliderThumbVertical):
296         (WebCore::RenderThemeMac::textField):
297         (WebCore::RenderThemeMac::fileListNameForWidth):
298         * rendering/RenderThemeMacShared.h: Removed.
299         * rendering/RenderThemeMacShared.mm: Removed.
300
301 2013-04-24  ChangSeok Oh  <changseok.oh@collabora.com>
302
303         [GTK][AC] Visible rect doesn't update after resizing a window.
304         https://bugs.webkit.org/show_bug.cgi?id=115096
305
306         Reviewed by Gustavo Noronha Silva.
307
308         Once we set actor's a clip rect, we should update the rect when resizing the actor.
309
310         No new tests since no new functionality.
311
312         * platform/graphics/clutter/GraphicsLayerClutter.cpp:
313         (WebCore::GraphicsLayerClutter::setSize):
314
315 2013-04-24  ChangSeok Oh  <changseok.oh@collabora.com>
316
317         [GTK][AC] Fix unexpected clear of ClutterContent.
318         https://bugs.webkit.org/show_bug.cgi?id=115099
319
320         Reviewed by Gustavo Noronha Silva.
321
322         adoptGRef doesn't increase a reference count. So if a actor has a valid ClutterContent,
323         it would be cleared unexpectedly by smart pointer when escaping a function.
324
325         No new tests, no functionality changed.
326
327         * platform/graphics/clutter/GraphicsLayerActor.cpp:
328         (graphicsLayerActorUpdateTexture):
329
330 2013-04-24  Alberto Garcia  <agarcia@igalia.com>
331
332         DOMFileSystemBase: fix multiple definitions in the BlackBerry port
333         https://bugs.webkit.org/show_bug.cgi?id=114950
334
335         Reviewed by Xan Lopez.
336
337         The following  methods are already defined in DOMFileSystemBlackBerry.cpp:
338
339         crackFileSystemURL()
340         createFileSystemURL()
341         isValidType()
342         supportsToURL()
343
344         * Modules/filesystem/DOMFileSystemBase.cpp:
345         (WebCore):
346
347 2013-04-24  George Staikos  <gstaikos@rim.com>
348
349         [BlackBerry] Add support for JPEG image quality during encoding.
350         https://bugs.webkit.org/show_bug.cgi?id=105773
351
352         Reviewed by Xan Lopez.
353
354         PR 271611
355         Internally reviewed by Liam Quinn.
356
357         Pass the quality flag into the encoder, with a default of 65
358
359         Covered by existing tests.
360
361         * platform/image-encoders/JPEGImageEncoder.cpp:
362         (WebCore::compressRGBABigEndianToJPEG):
363         * platform/image-encoders/JPEGImageEncoder.h:
364         (WebCore):
365
366 2013-04-24  Csaba Osztrogon√°c  <ossy@webkit.org>
367
368         Fix cast-align WebCore/platform/graphics/GraphicsContext3D.cpp on ARM
369         https://bugs.webkit.org/show_bug.cgi?id=115036
370
371         Reviewed by Benjamin Poulain.
372
373         * platform/graphics/GraphicsContext3D.cpp:
374         (WebCore):
375
376 2013-04-24  Andreas Kling  <akling@apple.com>
377
378         Remove unnecessary MutableStylePropertySet casts.
379         <http://webkit.org/b/115075>
380
381         Reviewed by Geoffrey Garen.
382
383         Get rid of some now-unneeded static_casts that were left from the StylePropertySet
384         refactoring last weekend.
385
386         * css/StylePropertySet.cpp:
387         (WebCore::MutableStylePropertySet::setProperty):
388         * editing/EditingStyle.cpp:
389         (WebCore::EditingStyle::triStateOfStyle):
390         (WebCore::EditingStyle::removeStyleFromRulesAndContext):
391
392 2013-04-24  Kangil Han  <kangil.han@samsung.com>
393
394         [Minor code cleanup] Remove duplicated condition check
395         https://bugs.webkit.org/show_bug.cgi?id=115082
396
397         Reviewed by Andreas Kling.
398
399         areRectsPartiallyAligned() has duplicated condition check, so remove it.
400
401         * page/SpatialNavigation.cpp:
402         (WebCore::areRectsPartiallyAligned):
403
404 2013-04-24  Krzysztof Wolanski  <k.wolanski@samsung.com>
405
406         [EFL] Fix build warnings caused by missing images attributes for default buttons
407         https://bugs.webkit.org/show_bug.cgi?id=114955
408
409         Reviewed by Gyuyoung Kim.
410
411         Added default image for each button from mediacontrol catalog.
412
413         No new tests, because there is no change in behavior.
414
415         * platform/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc:
416         * platform/efl/DefaultTheme/widget/mediacontrol/mutebutton/mute_button.edc:
417         * platform/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playpause_button.edc:
418         * platform/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackward_button.edc:
419         * platform/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforward_button.edc:
420         * platform/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/toggle_captions_button.edc:
421
422 2013-04-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
423
424         Unreviewed build fix with gstreamer 0.10.x after r147555.
425
426         * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
427         (webKitWebAudioSrcLoop):
428
429 == Rolled over to ChangeLog-2013-04-24 ==