Unreviewed build fix for Debug builders.
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-10-05  Ilya Tikhonovsky  <loislo@chromium.org>
2
3         Unreviewed build fix for Debug builders.
4
5         * inspector/WorkerInspectorController.cpp:
6         (WebCore::WorkerInspectorController::restoreInspectorStateFromCookie):
7
8 2011-10-05  Dirk Schulze  <krit@webkit.org>
9
10         SVG 1.1: ineffectual transform attribute for ClipPath
11         https://bugs.webkit.org/show_bug.cgi?id=55361
12
13         Reviewed by Nikolas Zimmermann.
14         
15         Respect 'transform' attribute/property for <clip-path>.
16         If the masking code path is used the mask context gets transformed, otherwise the path itself.
17
18         Tests: svg/clip-path/clip-path-transform-1.svg
19                svg/clip-path/clip-path-transform-2.svg
20                svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting.html
21
22         * rendering/svg/RenderSVGResourceClipper.cpp:
23         (WebCore::RenderSVGResourceClipper::pathOnlyClipping): Transform the clip path.
24         (WebCore::RenderSVGResourceClipper::applyClippingToContext):
25         (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage): Transform the context of the mask image.
26         (WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect): Repaint rect must get concatenated with the current animated transformation.
27         (WebCore::RenderSVGResourceClipper::hitTestClipContent): Point for hit testing must be transformed by the current animated transformation.
28         * rendering/svg/RenderSVGResourceClipper.h:
29
30 2011-10-05  Pavel Feldman  <pfeldman@google.com>
31
32         Web Inspector: move elements panel update semantics from ElementsPanel to ElementsTreeOutline.
33         https://bugs.webkit.org/show_bug.cgi?id=69431
34
35         Reviewed by Yury Semikhatsky.
36
37         * inspector/front-end/ConsoleMessage.js:
38         (WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):
39         * inspector/front-end/ElementsPanel.js:
40         (WebInspector.ElementsPanel.get this):
41         (WebInspector.ElementsPanel):
42         (WebInspector.ElementsPanel.prototype.show):
43         (WebInspector.ElementsPanel.prototype.hide):
44         (WebInspector.ElementsPanel.prototype._selectedNodeChanged):
45         (WebInspector.ElementsPanel.prototype._reset):
46         (WebInspector.ElementsPanel.prototype._nodeRemoved):
47         (WebInspector.ElementsPanel.prototype.updateBreadcrumb.selectCrumbFunction):
48         (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
49         * inspector/front-end/ElementsTreeOutline.js:
50         (WebInspector.ElementsTreeOutline):
51         (WebInspector.ElementsTreeOutline.prototype.wireToDomAgent):
52         (WebInspector.ElementsTreeOutline.prototype.setVisible):
53         (WebInspector.ElementsTreeOutline.prototype.addEventListener):
54         (WebInspector.ElementsTreeOutline.prototype.removeEventListener):
55         (WebInspector.ElementsTreeOutline.prototype.selectDOMNode):
56         (WebInspector.ElementsTreeOutline.prototype.update):
57         (WebInspector.ElementsTreeOutline.prototype._selectedNodeChanged):
58         (WebInspector.ElementsTreeOutline.prototype.findTreeElement.parentNode):
59         (WebInspector.ElementsTreeOutline.prototype.findTreeElement):
60         (WebInspector.ElementsTreeOutline.prototype.createTreeElementFor):
61         (WebInspector.ElementsTreeOutline.prototype._ondrop.callback):
62         (WebInspector.ElementsTreeOutline.prototype._ondrop):
63         (WebInspector.ElementsTreeOutline.prototype.adjustCollapsedRange):
64         (WebInspector.ElementsTreeOutline.prototype._updateModifiedNodes):
65         (WebInspector.ElementsTreeElement.prototype.insertChildElement):
66         (WebInspector.ElementsTreeElement.prototype.selectOnMouseDown):
67         (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.dispose):
68         (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
69         (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded):
70         (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
71         (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.changeTagNameCallback):
72         (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
73         (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted):
74         (WebInspector.ElementsTreeElement.prototype._editingCancelled):
75         ():
76         * inspector/front-end/externs.js:
77         (WebInspector.ElementsTreeOutline):
78         * inspector/front-end/utilities.js:
79
80 2011-10-05  Yury Semikhatsky  <yurys@chromium.org>
81
82         Web Inspector: provide a way for persisting worker inspector state
83         https://bugs.webkit.org/show_bug.cgi?id=69422
84
85         Worker inspector can persist and restore its state. InspectorStateClient is
86         exctracted into a separate interface and has a custom implementation in case
87         of worker inspector.
88
89         Reviewed by Pavel Feldman.
90
91         * GNUmakefile.list.am:
92         * WebCore.gypi:
93         * WebCore.vcproj/WebCore.vcproj:
94         * WebCore.xcodeproj/project.pbxproj:
95         * inspector/InspectorClient.h:
96         * inspector/InspectorState.cpp:
97         (WebCore::InspectorState::InspectorState):
98         * inspector/InspectorState.h:
99         * inspector/InspectorStateClient.h: Copied from Source/WebCore/inspector/InspectorClient.h.
100         (WebCore::InspectorStateClient::~InspectorStateClient):
101         (WebCore::InspectorStateClient::updateInspectorStateCookie):
102         * inspector/WorkerInspectorController.cpp:
103         (WebCore::WorkerInspectorController::WorkerInspectorController):
104         (WebCore::WorkerInspectorController::restoreInspectorStateFromCookie):
105         * inspector/WorkerInspectorController.h:
106         * workers/DefaultSharedWorkerRepository.cpp:
107         (WebCore::SharedWorkerProxy::postMessageToPageInspector):
108         (WebCore::SharedWorkerProxy::updateInspectorStateCookie):
109         * workers/WorkerMessagingProxy.cpp:
110         (WebCore::WorkerMessagingProxy::updateInspectorStateCookie):
111         * workers/WorkerMessagingProxy.h:
112         * workers/WorkerReportingProxy.h:
113
114 2011-10-05  Abhishek Arya  <inferno@chromium.org>
115
116         Crash in SVGTRefElement::updateReferencedText.
117         https://bugs.webkit.org/show_bug.cgi?id=67555
118
119         Reviewed by Rob Buis.
120
121         Test: svg/text/tref-event-listener-crash.svg
122
123         * svg/SVGTRefElement.cpp:
124         (WebCore::SubtreeModificationEventListener::clear): This fixes the
125         crash. there can be cases when our target is removed, but our event
126         listener is alive. when our tref is going away, we need to disable
127         those event listeners by nulling out our tref element.
128         (WebCore::SubtreeModificationEventListener::handleEvent): Adding
129         null check for tref element, which can happen in cases where
130         event listener's clear is called, but we could not remove it from
131         the target.
132         (WebCore::SVGTRefElement::~SVGTRefElement): There are always
133         cases when removedFromDocument is not called. So, important to
134         clear event listener in those cases.
135         (WebCore::SVGTRefElement::svgAttributeChanged): Use common
136         function buildPendingResource.
137         (WebCore::SVGTRefElement::buildPendingResource): Common function
138         to prevent triple duplication of same code. made it more readable.
139         (WebCore::SVGTRefElement::insertedIntoDocument): Use common
140         function buildPendingResource.
141         (WebCore::SVGTRefElement::removedFromDocument): Use new helper
142         removeEventListener.
143         (WebCore::SVGTRefElement::clearEventListener): Helper to clear
144         event listener. Name chosen to not collide with Node::removeEventListener.
145         * svg/SVGTRefElement.h: definition of new helpers.
146         * svg/SVGTextPathElement.cpp:
147         (WebCore::SVGTextPathElement::insertedIntoDocument): Copy same
148         logic as tref and use element. more asserts and easy bailouts.
149
150 2011-10-05  Pavel Feldman  <pfeldman@google.com>
151
152         Not reviewed: restoring : shortcut in inspector.
153
154         * inspector/front-end/ScriptsPanel.js:
155         (WebInspector.ScriptsPanel.prototype._createSidebarButtons):
156
157 2011-10-05  Andreas Kling  <kling@webkit.org>
158
159         Shrink FontDescription.
160         https://bugs.webkit.org/show_bug.cgi?id=69426
161
162         Reviewed by Nikolas Zimmermann.
163
164         Pack FontDescription's members in a bitfield, effectively shrinking
165         the class by two CPU-words. This reduces memory consumption by ~1 MB
166         on 64-bit when loading the full HTML5 spec.
167
168         * platform/graphics/FontDescription.h:
169         (WebCore::FontDescription::orientation):
170         (WebCore::FontDescription::textOrientation):
171         (WebCore::FontDescription::widthVariant):
172
173 2011-10-05  Vsevolod Vlasov  <vsevik@chromium.org>
174
175         Web Inspector: Add support for search in script content.
176         https://bugs.webkit.org/show_bug.cgi?id=69015
177
178         Reviewed by Pavel Feldman.
179
180         Tests: http/tests/inspector/search/search-in-concatenated-script.html
181                http/tests/inspector/search/search-in-script.html
182
183         * inspector/Inspector.json:
184         * inspector/InspectorDebuggerAgent.cpp:
185         (WebCore::InspectorDebuggerAgent::searchInContent):
186         (WebCore::InspectorDebuggerAgent::getScriptSource):
187         * inspector/InspectorDebuggerAgent.h:
188         * inspector/front-end/ContentProviders.js:
189         (WebInspector.ScriptContentProvider.prototype.searchInContent):
190         (WebInspector.ConcatenatedScriptsContentProvider.prototype._sortedScripts.var):
191         (WebInspector.ConcatenatedScriptsContentProvider.prototype._sortedScripts):
192         (WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):
193         (WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.maybeCallback):
194         (WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.searchCallback):
195         (WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent):
196         (WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
197         * inspector/front-end/Script.js:
198         (WebInspector.Script.prototype.requestSource.didGetScriptSource):
199         (WebInspector.Script.prototype.requestSource):
200         (WebInspector.Script.prototype.searchInContent):
201
202 2011-10-05  Alexis Menard  <alexis.menard@openbossa.org>
203
204         [Qt][WK2] Default directories and paths are missing for LocalStorage, Database and IconDatabase.
205         https://bugs.webkit.org/show_bug.cgi?id=69111
206
207         Reviewed by Kenneth Rohde Christiansen.
208
209         Provide default path for LocalStorage, Database and IconDatabase using QDesktopServices.
210
211         No new tests : existing ones should cover.
212
213         * platform/qt/CookieJarQt.cpp:
214         (WebCore::SharedCookieJarQt::SharedCookieJarQt):
215
216 2011-10-05  Patrick Gansterer  <paroga@webkit.org>
217
218         Unreviewed build fix for !ENABLE(FILTERS) after r96203.
219
220         * rendering/svg/SVGResourcesCache.cpp:
221         (WebCore::SVGResourcesCache::clientUpdatedFromElement):
222
223 2011-10-05  Ilya Tikhonovsky  <loislo@chromium.org>
224
225         Unreviewed build fix for windows bots after r96679.
226
227         * html/NumberInputType.h:
228
229 2011-10-04  Pavel Feldman  <pfeldman@google.com>
230
231         Web Inspector: make ResourceView(s) compile
232         https://bugs.webkit.org/show_bug.cgi?id=69351
233
234         Reviewed by Yury Semikhatsky.
235
236         * inspector/compile-front-end.sh:
237         * inspector/front-end/CookiesTable.js:
238         (WebInspector.CookiesTable.prototype._sortCookies):
239         * inspector/front-end/DataGrid.js:
240         * inspector/front-end/EmptyView.js:
241         * inspector/front-end/FontView.js:
242         (WebInspector.FontView.prototype._createContentIfNeeded):
243         * inspector/front-end/ImageView.js:
244         (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
245         (WebInspector.ImageView.prototype._createContentIfNeeded):
246         (WebInspector.ImageView.prototype._openInNewTab):
247         * inspector/front-end/NetworkItemView.js:
248         * inspector/front-end/ResourceCookiesView.js:
249         * inspector/front-end/ResourceHTMLView.js:
250         (WebInspector.ResourceHTMLView.prototype.hide):
251         * inspector/front-end/ResourceHeadersView.js:
252         (WebInspector.ResourceHeadersView.prototype._refreshParms):
253         (WebInspector.ResourceHeadersView.prototype._refreshHeadersTitle):
254         (WebInspector.ResourceHeadersView.prototype._refreshHeaders):
255         (WebInspector.ResourceHeadersView.prototype._refreshHeadersText):
256         * inspector/front-end/ResourceJSONView.js:
257         (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.parseJSONP):
258         * inspector/front-end/ResourcePreviewView.js:
259         * inspector/front-end/ResourceResponseView.js:
260         * inspector/front-end/ResourceTimingView.js:
261         (WebInspector.ResourceTimingView.createTimingTable):
262         * inspector/front-end/ResourceView.js:
263         (WebInspector.ResourceSourceFrame):
264         * inspector/front-end/SourceFrame.js:
265         * inspector/front-end/TabbedPane.js:
266         * inspector/front-end/UIUtils.js:
267         (Number.secondsToString):
268         (Number.bytesToString):
269         * inspector/front-end/inspector.js:
270
271 2011-10-04  Ilya Tikhonovsky  <loislo@chromium.org>
272
273         Web Inspector: debuggerPresentatioModel.linkifyLocation leaks updateAnchor closure instances.
274         https://bugs.webkit.org/show_bug.cgi?id=69146
275
276         In many places we use linkifyLocation function to produce a link node which updates automatically when the source file is changed on the fly.
277         Such changes happen when we use pretty print or another operation that changes the source code somehow.
278         linkifyLocation associates a new instance of updateAnchor closure with the each link node and add the closure to the SourceMappingUpdated event's list.
279         As the result the node<->closure pairs wouldn't be collected until reset the UI and DebuggerPresentationModel.
280
281         Reviewed by Pavel Feldman.
282
283         Test: inspector/debugger/linkifier.html
284
285         * inspector/front-end/ConsoleMessage.js:
286         (WebInspector.ConsoleMessageImpl):
287         (WebInspector.ConsoleMessageImpl.prototype._linkifyLocation):
288         * inspector/front-end/ConsoleView.js:
289         (WebInspector.ConsoleView.prototype._consoleCleared):
290         (WebInspector.ConsoleCommandResult):
291         (WebInspector.ConsoleMessage.create):
292         (WebInspector.ConsoleMessage.createTextMessage):
293         * inspector/front-end/DebuggerPresentationModel.js:
294         (WebInspector.DebuggerPresentationModel.prototype.createLinkifier):
295         (WebInspector.DebuggerPresentationModel.Linkifier):
296         (WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
297         (WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
298         (WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateSourceAnchors):
299         (WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):
300         * inspector/front-end/EventListenersSidebarPane.js:
301         (WebInspector.EventListenersSidebarPane.prototype.update.callback):
302         (WebInspector.EventListenersSidebarPane.prototype.update):
303         ():
304         * inspector/front-end/NetworkPanel.js:
305         (WebInspector.NetworkLogView):
306         (WebInspector.NetworkLogView.prototype._reset):
307         (WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
308         * inspector/front-end/ProfileDataGridTree.js:
309         (WebInspector.ProfileDataGridNode.prototype.createCell):
310         * inspector/front-end/ProfileView.js:
311         (WebInspector.CPUProfileView):
312         (WebInspector.CPUProfileView.prototype._resetClicked):
313         * inspector/front-end/TimelinePanel.js:
314         (WebInspector.TimelinePanel):
315         (WebInspector.TimelinePanel.prototype._linkifyLocation):
316         (WebInspector.TimelinePanel.prototype._linkifyCallFrame):
317         (WebInspector.TimelinePanel.prototype._clearPanel):
318         (WebInspector.TimelinePanel.FormattedRecord):
319         (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
320         (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
321         (WebInspector.TimelinePanel.PopupContentHelper):
322         (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
323         (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
324         * inspector/front-end/inspector.js:
325
326 2011-10-03  Andreas Kling  <kling@webkit.org>
327
328         REGRESSION(r82611) InlineBox has 33 bits of bitset, causing alignment issues and extra memory use.
329         https://bugs.webkit.org/show_bug.cgi?id=64914
330
331         Reviewed by Antti Koivisto.
332
333         Remove InlineBox::prevOnLineExists() and its two accompanying bitfields
334         since nobody is using them anymore. nextOnLineExists() is still used by
335         GTK+ accessibility code.
336
337         Also added a compile-time assertion to guard against future bloating of
338         the InlineBox class.
339
340         * rendering/InlineBox.cpp:
341         (WebCore::SameSizeAsInlineBox::~SameSizeAsInlineBox):
342         * rendering/InlineBox.h:
343         (WebCore::InlineBox::InlineBox):
344
345 2011-10-05  Andreas Kling  <kling@webkit.org>
346
347         Shrink FontFallbackList.
348         https://bugs.webkit.org/show_bug.cgi?id=69093
349
350         Rubber-stamped by Antti Koivisto.
351
352         Workaround MSVC quirk by making enum bitfield "unsigned".
353
354         * platform/graphics/FontFallbackList.h:
355
356 2011-10-05  Andreas Kling  <kling@webkit.org>
357
358         Shrink StyleRareNonInheritedData.
359         https://bugs.webkit.org/show_bug.cgi?id=69331
360
361         Reviewed by Darin Adler.
362
363         Workaround MSVC quirk by making enum bitfields "unsigned".
364
365         * rendering/style/RenderStyle.h:
366         (WebCore::InheritedFlags::regionOverflow):
367         (WebCore::InheritedFlags::transformStyle3D):
368         (WebCore::InheritedFlags::backfaceVisibility):
369         (WebCore::InheritedFlags::pageSizeType):
370         * rendering/style/StyleRareNonInheritedData.h:
371
372 2011-10-05  Pavel Feldman  <pfeldman@chromium.org>
373
374         Web Inspector: add CSS model classes to the compilation.
375         https://bugs.webkit.org/show_bug.cgi?id=69376
376
377         Reviewed by Yury Semikhatsky.
378
379         * inspector/compile-front-end.sh:
380         * inspector/front-end/CSSCompletions.js:
381         * inspector/front-end/CSSKeywordCompletions.js:
382         (WebInspector.CSSKeywordCompletions.forProperty):
383         * inspector/front-end/CSSStyleModel.js:
384         (WebInspector.CSSStyleDeclaration):
385         (WebInspector.CSSStyleModelResourceBinding.prototype.setContent):
386         (WebInspector.CSSStyleModelResourceBinding.prototype.canSetContent):
387         * inspector/front-end/ResourceTreeModel.js:
388         * inspector/front-end/StylesSidebarPane.js:
389         (WebInspector.StylesSidebarPane.prototype._containsInherited):
390         (WebInspector.StylePropertiesSection.prototype.isPropertyInherited):
391         (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):
392         (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
393         * inspector/front-end/externs.js:
394         (Array.prototype.keySet):
395
396 2011-10-05  Kent Tamura  <tkent@chromium.org>
397
398         Input styles are unexpectedly shared regardless of required status difference.
399         https://bugs.webkit.org/show_bug.cgi?id=69402
400
401         Reviewed by Daniel Bates.
402
403         Tests: fast/css/pseudo-required-shared.html
404
405         * css/CSSStyleSelector.cpp:
406         (WebCore::CSSStyleSelector::canShareStyleWithControl): Check the difference of required().
407
408 2011-10-04  Kent Tamura  <tkent@chromium.org>
409
410         Remove Node::willBlur()
411         https://bugs.webkit.org/show_bug.cgi?id=69395
412
413         Reviewed by Ryosuke Niwa.
414
415         Revert the WebCore part of r87371 because
416         FrameSelection::textWillBeReplaced() doesn't set focus anymore.
417         No new tests. Covered by fast/forms/input-number-blur-twice.html.
418
419         * dom/Document.cpp:
420         (WebCore::Document::setFocusedNode): Revert r87371.
421         * dom/Node.cpp: ditto.
422         * dom/Node.h: ditto.
423         * html/HTMLInputElement.cpp:
424         (WebCore::HTMLInputElement::handleBlurEvent): ditto.
425         * html/HTMLInputElement.h: ditto.
426         * html/InputType.cpp:
427         (WebCore::InputType::handleBlurEvent): ditto.
428         * html/InputType.h: ditto.
429         * html/NumberInputType.cpp:
430         (WebCore::NumberInputType::handleBlurEvent): ditto.
431         * html/NumberInputType.h: ditto.
432
433 2011-10-04  Kent Tamura  <tkent@chromium.org>
434
435         Introduce feature flags for incomplete input types
436         https://bugs.webkit.org/show_bug.cgi?id=68971
437
438         Reviewed by Hajime Morita.
439
440         * Configurations/FeatureDefines.xcconfig:
441          Add ENABLE_INPUT_TYPE_* flags. They are enabled only for iOS.
442         * html/DateInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_DATE)
443         * html/DateInputType.h: ditto.
444         * html/DateTimeInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_DATETIME)
445         * html/DateTimeInputType.h: ditto.
446         * html/DateTimeLocalInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_DATETIMELOCAL)
447         * html/DateTimeLocalInputType.h: ditto.
448         * html/InputType.cpp:
449         (WebCore::createInputTypeFactoryMap):
450          Recognizes type attribute value only if it is enabled by ENABLE(INPUT_TYPE_*).
451         * html/MonthInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_MONTH)
452         * html/MonthInputType.h: ditto.
453         * html/TimeInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_TIME)
454         * html/TimeInputType.h: ditto.
455         * html/WeekInputType.cpp: Wrapped with ENABLE(INPUT_TYPE_WEEK)
456         * html/WeekInputType.h: ditto.
457
458 2011-10-04  David Hyatt  <hyatt@apple.com>
459
460         https://bugs.webkit.org/show_bug.cgi?id=69398
461
462         [CSS3 Regions] Support the region-overflow property properly.
463         
464         (1) Change -webkit-break to break, since the -webkit-region-overflow property already has the
465         -webkit- extension.
466         
467         (2) Fix clipping so that it works when overflow is set or when region break is set.
468         
469         (3) Refactor all the pagination spots to check if a next page is available using the new hasNextPage
470         function. This prevents us from paginating if we hit the last region and further breaks are no longer
471         allowed.
472         
473         Reviewed by Dan Bernstein.
474
475         Added new tests in fast/regions.
476
477         * css/CSSParser.cpp:
478         (WebCore::CSSParser::parseValue):
479         * css/CSSPrimitiveValueMappings.h:
480         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
481         (WebCore::CSSPrimitiveValue::operator RegionOverflow):
482         * css/CSSValueKeywords.in:
483         * rendering/RenderBlock.cpp:
484         (WebCore::RenderBlock::collapseMargins):
485         (WebCore::RenderBlock::estimateLogicalTopPosition):
486         (WebCore::RenderBlock::hasNextPage):
487         (WebCore::RenderBlock::nextPageLogicalTop):
488         (WebCore::RenderBlock::applyBeforeBreak):
489         (WebCore::RenderBlock::applyAfterBreak):
490         (WebCore::RenderBlock::pageLogicalHeightForOffset):
491         (WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
492         (WebCore::RenderBlock::adjustForUnsplittableChild):
493         (WebCore::RenderBlock::pushToNextPageWithMinimumLogicalHeight):
494         (WebCore::RenderBlock::adjustLinePositionForPagination):
495         * rendering/RenderBlock.h:
496         * rendering/RenderFlowThread.cpp:
497         (WebCore::RenderFlowThread::layout):
498         (WebCore::RenderFlowThread::repaintRectangleInRegions):
499         (WebCore::RenderFlowThread::regionRemainingLogicalHeightForLine):
500         * rendering/RenderFlowThread.h:
501         * rendering/RenderRegion.cpp:
502         (WebCore::RenderRegion::regionOverflowRect):
503
504 2011-10-04  Mark Hahnenberg  <mhahnenberg@apple.com>
505
506         Add static ClassInfo structs to classes that override JSCell::getCallData
507         https://bugs.webkit.org/show_bug.cgi?id=69311
508
509         Reviewed by Darin Adler.
510
511         No new tests.
512
513         Added ClassInfo structs to each class that defined its own getCallData 
514         function but did not already have its own ClassInfo struct.  This is a 
515         necessary addition for when we switch over to looking up getCallData from 
516         the MethodTable in ClassInfo rather than doing the virtual call (which we 
517         are removing).  These new ClassInfo structs are public because we often 
518         use these structs in other areas of the code to uniquely identify JSC classes and 
519         to enforce runtime invariants based on those class identities using ASSERTs.
520         Also added new createStructure methods to those classes that didn't have 
521         them so that the new ClassInfo structs would be used when creating the Structures 
522         in these classes.
523
524         * bridge/qt/qt_runtime.cpp:
525         * bridge/qt/qt_runtime.h:
526
527 2011-10-03  Geoffrey Garen  <ggaren@apple.com>
528
529         Some JSValue cleanup
530         https://bugs.webkit.org/show_bug.cgi?id=69320
531
532         Reviewed by Darin Adler.
533
534         * bindings/js/JSDOMBinding.cpp:
535         (WebCore::valueToDate):
536         * bindings/js/JSErrorHandler.cpp:
537         (WebCore::JSErrorHandler::handleEvent):
538         * bindings/js/JSEventListener.cpp:
539         (WebCore::JSEventListener::handleEvent):
540         * bindings/js/JSSQLTransactionCustom.cpp:
541         (WebCore::JSSQLTransaction::executeSql):
542         * bindings/js/JSSQLTransactionSyncCustom.cpp:
543         (WebCore::JSSQLTransactionSync::executeSql):
544         * bindings/js/ScriptValue.cpp:
545         (WebCore::jsToInspectorValue):
546         * bindings/js/SerializedScriptValue.cpp:
547         (WebCore::CloneSerializer::dumpIfTerminal):
548         * bindings/objc/WebScriptObject.mm:
549         (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
550         * bridge/jni/jsc/JNIUtilityPrivate.cpp:
551         (JSC::Bindings::convertValueToJValue): Updated for JSC changes.
552
553 2011-10-04  Sadrul Habib Chowdhury  <sadrul@chromium.org>
554
555         Fix FrameView::scrollElementToRect to take already scrolled amount into consideration.
556         https://bugs.webkit.org/show_bug.cgi?id=69220
557
558         Reviewed by Simon Fraser.
559
560         * page/FrameView.cpp:
561         (WebCore::FrameView::scrollElementToRect):
562
563 2011-10-04  Anders Carlsson  <andersca@apple.com>
564
565         Ignore the warning about using 'override'.
566
567         * WebCore.vcproj/WebCore.vcproj:
568
569 2011-10-04  Sam Weinig  <sam@webkit.org>
570
571         Stub out WorkerScriptController::disableEval for v8 to fix the build.
572
573         * bindings/v8/WorkerScriptController.cpp:
574         (WebCore::WorkerScriptController::disableEval):
575         * bindings/v8/WorkerScriptController.h:
576
577 2011-10-04  Sam Weinig  <sam@webkit.org>
578
579         OVERRIDE seems to not be working for Windows. Remove it for now.
580
581         * dom/Document.h:
582         * workers/WorkerContext.h:
583
584 2011-10-04  Sam Weinig  <sam@webkit.org>
585
586         Wean ContentSecurityPolicy from the Document
587         https://bugs.webkit.org/show_bug.cgi?id=69387
588
589         Reviewed by Adam Barth.
590
591         * bindings/js/WorkerScriptController.cpp:
592         (WebCore::WorkerScriptController::disableEval):
593         * bindings/js/WorkerScriptController.h:
594         * dom/Document.cpp:
595         (WebCore::Document::disableEval):
596         * dom/Document.h:
597         * workers/WorkerContext.cpp:
598         (WebCore::WorkerContext::disableEval):
599         * workers/WorkerContext.h:
600         * dom/ScriptExecutionContext.h:
601         Add pure virtual disableEval to ScriptExecutionContext, so that ContentSecurityPolicy
602         can call it for both Documents and WorkerContexts.
603
604         * page/ContentSecurityPolicy.cpp:
605         (WebCore::ContentSecurityPolicy::didReceiveHeader):
606         Call the new ScriptExecutionContext::disableEval() function.
607
608         (WebCore::ContentSecurityPolicy::reportViolation):
609         Use ScriptExecutionContext::addMessage() instead of going directly to the DOMWindow.
610
611 2011-10-04  Anders Carlsson  <andersca@apple.com>
612
613         Move code into ScrollElasticityController::beginScrollGesture()
614         https://bugs.webkit.org/show_bug.cgi?id=69383
615
616         Reviewed by John Sullivan.
617
618         * platform/mac/ScrollAnimatorMac.h:
619         Add new ScrollElasticityControllerClient member functions.
620
621         * platform/mac/ScrollAnimatorMac.mm:
622         (WebCore::ScrollAnimatorMac::isHorizontalScrollerPinnedToMinimumPosition):
623         (WebCore::ScrollAnimatorMac::isHorizontalScrollerPinnedToMaximumPosition):
624         (WebCore::ScrollAnimatorMac::stretchAmount):
625         (WebCore::ScrollAnimatorMac::startSnapRubberbandTimer):
626         (WebCore::ScrollAnimatorMac::stopSnapRubberbandTimer):
627         Implement the new ScrollElasticityControllerClient member functions.
628
629         (WebCore::ScrollAnimatorMac::beginScrollGesture):
630         Move code into ScrollElasticityController::beginScrollGesture and call it directly.
631
632         * platform/mac/ScrollElasticityController.h:
633         Add new ScrollElasticityControllerClient member functions.
634
635         * platform/mac/ScrollElasticityController.mm:
636         (WebCore::reboundDeltaForElasticDelta):
637         (WebCore::ScrollElasticityController::beginScrollGesture):
638         Set up the scroll gesture state.
639
640         (WebCore::ScrollElasticityController::stopSnapRubberbandTimer):
641         New helper function.
642
643 2011-10-04  Scott Graham  <scottmg@chromium.org>
644
645         Add GAMEPAD feature flag
646         https://bugs.webkit.org/show_bug.cgi?id=66859
647
648         Reviewed by Darin Fisher.
649
650         No new tests, as no new functionality yet.
651
652         * Configurations/FeatureDefines.xcconfig:
653         * GNUmakefile.am:
654         * features.pri:
655
656 2011-10-04  Fady Samuel  <fsamuel@chromium.org>
657
658         [Chromium] Moved files towards GTK removal
659         https://bugs.webkit.org/show_bug.cgi?id=69229
660
661         Reviewed by Tony Chang.
662
663         * WebCore.gypi:
664         * platform/chromium/PlatformThemeChromiumLinux.cpp: Renamed from Source/WebCore/platform/chromium/PlatformThemeChromiumGtk.cpp.
665         (WebCore::PlatformThemeChromiumLinux::setScrollbarColors):
666         (WebCore::clamp):
667         (WebCore::PlatformThemeChromiumLinux::saturateAndBrighten):
668         (WebCore::PlatformThemeChromiumLinux::outlineColor):
669         (WebCore::PlatformThemeChromiumLinux::paintArrowButton):
670         * platform/chromium/PlatformThemeChromiumLinux.h: Renamed from Source/WebCore/platform/chromium/PlatformThemeChromiumGtk.h.
671         (WebCore::PlatformThemeChromiumLinux::thumbInactiveColor):
672         (WebCore::PlatformThemeChromiumLinux::thumbActiveColor):
673         (WebCore::PlatformThemeChromiumLinux::trackColor):
674         (WebCore::PlatformThemeChromiumLinux::PlatformThemeChromiumLinux):
675
676 2011-10-04  James Robinson  <jamesr@chromium.org>
677
678         [chromium] Extract scheduling logic from CCThreadProxy to its own class
679         https://bugs.webkit.org/show_bug.cgi?id=69049
680
681         Reviewed by Kenneth Russell.
682
683         This partially extracts the commit/draw scheduling from CCThreadProxy to a separate isolated class. This makes
684         the commit/draw logic easier to test, understand and extend.
685
686         There is one subtle behavior change here to the way that the function formerly known as
687         CCLayerTreeHost::setNeedsCommitAndRedraw works. Previously, this would trigger a begin frame message, if one
688         wasn't pending, and then trigger a redraw if one wasn't pending. This was subtly wrong - the intent of that call
689         is that a redraw should happen after the commit. It isn't useful to draw before the commit occurs. This patch
690         changes the name of the function to setNeedsCommitThenRedraw and only requests a redraw after a commit occurs.
691
692         Covered by new CCSchedulerTest unit tests, CCLayerTreeHostTest unit tests, and compositing/ layout tests.
693
694         * WebCore.gypi:
695         * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
696         (WebCore::CCLayerTreeHost::initialize):
697         (WebCore::CCLayerTreeHost::setZoomAnimatorTransform):
698         (WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
699         (WebCore::CCLayerTreeHost::setViewport):
700         (WebCore::CCLayerTreeHost::setVisible):
701         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
702         * platform/graphics/chromium/cc/CCProxy.h:
703         * platform/graphics/chromium/cc/CCScheduler.cpp: Added.
704         (WebCore::CCScheduler::CCScheduler):
705         (WebCore::CCScheduler::requestCommit):
706         (WebCore::CCScheduler::requestCommitThenRedraw):
707         (WebCore::CCScheduler::requestRedraw):
708         (WebCore::CCScheduler::didCommit):
709         (WebCore::CCScheduler::didDraw):
710         * platform/graphics/chromium/cc/CCScheduler.h: Added.
711         (WebCore::CCSchedulerClient::~CCSchedulerClient):
712         (WebCore::CCScheduler::create):
713         (WebCore::CCScheduler::commitPending):
714         (WebCore::CCScheduler::redrawPending):
715         (WebCore::CCScheduler::redrawAfterCommit):
716         * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
717         (WebCore::CCSingleThreadProxy::setNeedsCommitThenRedraw):
718         (WebCore::CCSingleThreadProxy::setNeedsRedraw):
719         (WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
720         (WebCore::CCSingleThreadProxy::doComposite):
721         * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
722         * platform/graphics/chromium/cc/CCThreadProxy.cpp:
723         (WebCore::CCThreadProxySchedulerClient::create):
724         (WebCore::CCThreadProxySchedulerClient::~CCThreadProxySchedulerClient):
725         (WebCore::CCThreadProxySchedulerClient::scheduleBeginFrameAndCommit):
726         (WebCore::CCThreadProxySchedulerClient::scheduleDrawAndPresent):
727         (WebCore::CCThreadProxySchedulerClient::CCThreadProxySchedulerClient):
728         (WebCore::CCThreadProxy::CCThreadProxy):
729         (WebCore::CCThreadProxy::compositeAndReadback):
730         (WebCore::CCThreadProxy::initializeLayerRenderer):
731         (WebCore::CCThreadProxy::setNeedsCommit):
732         (WebCore::CCThreadProxy::setNeedsCommitOnCCThread):
733         (WebCore::CCThreadProxy::setNeedsCommitThenRedraw):
734         (WebCore::CCThreadProxy::setNeedsCommitThenRedrawOnCCThread):
735         (WebCore::CCThreadProxy::setNeedsRedraw):
736         (WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):
737         (WebCore::CCThreadProxy::finishAllRenderingOnCCThread):
738         (WebCore::CCThreadProxy::obtainBeginFrameAndCommitTaskFromCCThread):
739         (WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
740         (WebCore::CCThreadProxy::beginFrameAndCommit):
741         (WebCore::CCThreadProxy::commitOnCCThread):
742         (WebCore::CCThreadProxy::drawLayersAndPresentOnCCThread):
743         (WebCore::CCThreadProxy::initializeImplOnCCThread):
744         * platform/graphics/chromium/cc/CCThreadProxy.h:
745
746 2011-10-04  Alexey Proskuryakov  <ap@apple.com>
747
748         https://bugs.webkit.org/show_bug.cgi?id=67774
749         PDF in a frameset is not displayed, always downloads
750
751         Reviewed by Darin Adler.
752
753         * WebCore.exp.in:
754         * WebCore.xcodeproj/project.pbxproj:
755         Added exports necessary to subclass a ScrollableArea.
756
757 2011-10-04  Anders Carlsson  <andersca@apple.com>
758
759         ScrollElasticityController should keep track of the rubberband timer state
760         https://bugs.webkit.org/show_bug.cgi?id=69381
761
762         Reviewed by Sam Weinig.
763
764         Add a m_snapRubberbandTimerIsActive member variable to ScrollElasticityController
765         and use it instead of checking whether the m_snapRubberbandTimer is active.
766
767         Eventually, ScrollElasticityControllerClient will have two member functions for starting
768         and stopping the timer, and the ScrollElasticityController will call them at the appropriate times.
769
770         * platform/mac/ScrollAnimatorMac.mm:
771         (WebCore::ScrollAnimatorMac::handleWheelEvent):
772         (WebCore::ScrollAnimatorMac::beginScrollGesture):
773         It's OK to stop the timer unconditionally.
774
775         (WebCore::ScrollAnimatorMac::snapRubberBand):
776         (WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
777         * platform/mac/ScrollElasticityController.h:
778         * platform/mac/ScrollElasticityController.mm:
779         (WebCore::ScrollElasticityController::ScrollElasticityController):
780
781 2011-10-04  Anders Carlsson  <andersca@apple.com>
782
783         Move all rubber-banding related member variables to ScrollElasticityController
784         https://bugs.webkit.org/show_bug.cgi?id=69379
785
786         Reviewed by Dan Bernstein.
787
788         * platform/mac/ScrollAnimatorMac.h:
789         * platform/mac/ScrollAnimatorMac.mm:
790         (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
791         (WebCore::ScrollAnimatorMac::handleWheelEvent):
792         (WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
793         (WebCore::ScrollAnimatorMac::beginScrollGesture):
794         (WebCore::ScrollAnimatorMac::snapRubberBand):
795         (WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
796         * platform/mac/ScrollElasticityController.h:
797         * platform/mac/ScrollElasticityController.mm:
798         (WebCore::ScrollElasticityController::ScrollElasticityController):
799
800 2011-10-04  Anders Carlsson  <andersca@apple.com>
801
802         Build fixes for everyone.
803
804         * platform/chromium/ScrollAnimatorChromiumMac.h:
805         * platform/chromium/ScrollAnimatorChromiumMac.mm:
806         (WebCore::isScrollingLeftAndShouldNotRubberBand):
807         (WebCore::isScrollingRightAndShouldNotRubberBand):
808         (WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent):
809         Fix Chromium build.
810
811         * platform/gtk/PlatformWheelEventGtk.cpp:
812         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
813         Fix GTK+ build.
814
815 2011-10-04  Anders Carlsson  <andersca@apple.com>
816
817         Add a ScrollElasticityController class and move some members over from ScrollAnimatorMac
818         https://bugs.webkit.org/show_bug.cgi?id=69373
819
820         Reviewed by David Hyatt.
821
822         ScrollElasticityController is a new class that will handle the rubber-banding when handling scroll events.
823
824         * WebCore.xcodeproj/project.pbxproj:
825         * platform/mac/ScrollAnimatorMac.h:
826         * platform/mac/ScrollAnimatorMac.mm:
827         (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
828         (WebCore::ScrollAnimatorMac::handleWheelEvent):
829         (WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
830         (WebCore::ScrollAnimatorMac::beginScrollGesture):
831         (WebCore::ScrollAnimatorMac::snapRubberBand):
832         (WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
833         * platform/mac/ScrollElasticityController.h: Added.
834         (WebCore::ScrollElasticityControllerClient::~ScrollElasticityControllerClient):
835         * platform/mac/ScrollElasticityController.mm: Added.
836         (WebCore::ScrollElasticityController::ScrollElasticityController):
837
838 2011-10-04  David Hyatt  <hyatt@apple.com>
839
840         https://bugs.webkit.org/show_bug.cgi?id=69372
841         
842         [CSS3 Regions] Make sure overflow:visible lets content spill out of regions.
843
844         Reviewed by Anders Carlsson.
845
846         No new tests, since plenty of results changed.
847
848         * rendering/RenderFlowThread.cpp:
849         (WebCore::RenderFlowThread::paintIntoRegion):
850         (WebCore::RenderFlowThread::hitTestRegion):
851         (WebCore::RenderFlowThread::repaintRectangleInRegions):
852         (WebCore::RenderFlowThread::firstRegion):
853         (WebCore::RenderFlowThread::lastRegion):
854         * rendering/RenderFlowThread.h:
855         * rendering/RenderRegion.cpp:
856         (WebCore::RenderRegion::regionOverflowRect):
857         (WebCore::RenderRegion::isFirstRegion):
858         (WebCore::RenderRegion::isLastRegion):
859         (WebCore::RenderRegion::layout):
860         * rendering/RenderRegion.h:
861         (WebCore::RenderRegion::setRegionRect):
862         (WebCore::RenderRegion::regionRect):
863
864 2011-10-04  Chris Rogers  <crogers@google.com>
865
866         Avoid unnecessary ASSERT in AudioDSPKernelProcessor::setNumberOfChannels()
867         https://bugs.webkit.org/show_bug.cgi?id=69361
868
869         Reviewed by James Robinson.
870
871         No new tests.  This changes no JavaScript API.
872
873         * platform/audio/AudioDSPKernelProcessor.cpp:
874         (WebCore::AudioDSPKernelProcessor::setNumberOfChannels):
875
876 2011-10-04  Anders Carlsson  <andersca@apple.com>
877
878         Use const PlatformWheelEvent references where possible
879         https://bugs.webkit.org/show_bug.cgi?id=69367
880
881         Reviewed by Sam Weinig.
882
883         * page/EventHandler.cpp:
884         (WebCore::EventHandler::handleWheelEvent):
885         * platform/ScrollAnimator.cpp:
886         (WebCore::ScrollAnimator::handleWheelEvent):
887         * platform/ScrollAnimator.h:
888         * platform/ScrollView.cpp:
889         (WebCore::ScrollView::wheelEvent):
890         * platform/ScrollView.h:
891         * platform/ScrollableArea.cpp:
892         (WebCore::ScrollableArea::handleWheelEvent):
893         * platform/ScrollableArea.h:
894         * platform/chromium/ScrollAnimatorChromiumMac.h:
895         * platform/chromium/ScrollAnimatorChromiumMac.mm:
896         (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
897         * platform/mac/ScrollAnimatorMac.h:
898         * platform/mac/ScrollAnimatorMac.mm:
899         (WebCore::isScrollingLeftAndShouldNotRubberBand):
900         (WebCore::isScrollingRightAndShouldNotRubberBand):
901         (WebCore::ScrollAnimatorMac::handleWheelEvent):
902         (WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
903
904 2011-10-04  Andreas Kling  <kling@webkit.org>
905
906         Shrink HTMLTableCellElement.
907         https://bugs.webkit.org/show_bug.cgi?id=69347
908
909         Reviewed by Antti Koivisto.
910
911         Don't cache the rowspan and colspan attributes on the element.
912         This shrinks HTMLTableCellElement by one CPU word, reducing memory
913         consumption by 80 kB (on 64-bit) when loading the full HTML5 spec.
914
915         * html/HTMLTableCellElement.cpp:
916         (WebCore::HTMLTableCellElement::HTMLTableCellElement):
917         (WebCore::HTMLTableCellElement::colSpan):
918         (WebCore::HTMLTableCellElement::rowSpan):
919         (WebCore::HTMLTableCellElement::parseMappedAttribute):
920         * html/HTMLTableCellElement.h:
921
922 2011-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
923
924         Unreviewed, rolling out r96630.
925         http://trac.webkit.org/changeset/96630
926         https://bugs.webkit.org/show_bug.cgi?id=69368
927
928         Caused assertion failures in validateCell (Requested by
929         mhahnenberg on #webkit).
930
931         * bridge/qt/qt_runtime.cpp:
932         * bridge/qt/qt_runtime.h:
933
934 2011-10-04  Cary Clark  <caryclark@google.com>
935
936         Enable sub pixel text (Skia on Mac)
937         https://bugs.webkit.org/show_bug.cgi?id=69354
938         http://code.google.com/p/chromium/issues/detail?id=98165
939
940         Reviewed by Eric Seidel.
941
942         No new tests. Layout test pixel results have been
943         disabled and will be rebaselined once all Skia on Mac
944         changes are in.
945
946         * platform/graphics/skia/FontSkia.cpp:
947         (WebCore::setupPaint):
948         Enable sub pixel text. This is set by default to enabled
949         by CoreGraphics, but by default disabled on Skia.
950
951 2011-10-04  Anders Carlsson  <andersca@apple.com>
952
953         Remove PlatformWheelEvent::m_isAccepted
954         https://bugs.webkit.org/show_bug.cgi?id=69357
955
956         Reviewed by Darin Adler.
957
958         Remove PlatformWheelEvent::m_isAccepted and all the getters/setters.
959
960         * page/EventHandler.cpp:
961         (WebCore::EventHandler::handleWheelEvent):
962         (WebCore::EventHandler::handleGestureEvent):
963         * page/mac/EventHandlerMac.mm:
964         (WebCore::EventHandler::wheelEvent):
965         * platform/PlatformWheelEvent.h:
966         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
967         * platform/ScrollAnimator.cpp:
968         (WebCore::ScrollAnimator::handleWheelEvent):
969         * platform/chromium/PopupContainer.cpp:
970         (WebCore::PopupContainer::handleGestureEvent):
971         * platform/chromium/ScrollAnimatorChromiumMac.mm:
972         (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
973         * platform/efl/PlatformWheelEventEfl.cpp:
974         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
975         * platform/mac/ScrollAnimatorMac.mm:
976         (WebCore::ScrollAnimatorMac::handleWheelEvent):
977         * platform/mac/WheelEventMac.mm:
978         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
979         * platform/qt/WheelEventQt.cpp:
980         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
981         * platform/win/WheelEventWin.cpp:
982         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
983         * platform/wx/MouseWheelEventWx.cpp:
984         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
985
986 2011-09-21  Cris Neckar  <cdn@chromium.org>
987
988         Hold refptr to identified previous sibling within findPlaceForCounter.
989         https://bugs.webkit.org/show_bug.cgi?id=68563
990
991         Reviewed by Adam Barth.
992
993         Test: fast/css/counters/counter-after-style-crash.html
994
995         * rendering/RenderCounter.cpp:
996         (WebCore::findPlaceForCounter):
997
998 2011-10-04  Joshua Bell  <jsbell@chromium.org>
999
1000         IndexedDB add() should fail if key is NaN
1001         https://bugs.webkit.org/show_bug.cgi?id=62286
1002
1003         Reviewed by Tony Chang.
1004
1005         Test: storage/indexeddb/invalid-keys.html
1006
1007         Implement special case - numbers are valid keys, except for NaN.
1008
1009         * bindings/v8/IDBBindingUtilities.cpp:
1010         (WebCore::createIDBKeyFromValue):
1011
1012 2011-10-04  Mark Hahnenberg  <mhahnenberg@apple.com>
1013
1014         Add static ClassInfo structs to classes that override JSCell::getCallData
1015         https://bugs.webkit.org/show_bug.cgi?id=69311
1016
1017         Reviewed by Darin Adler.
1018
1019         No new tests.
1020
1021         Added ClassInfo structs to each class that defined its own getCallData 
1022         function but did not already have its own ClassInfo struct.  This is a 
1023         necessary addition for when we switch over to looking up getCallData from 
1024         the MethodTable in ClassInfo rather than doing the virtual call (which we 
1025         are removing).  These new ClassInfo structs are public because we often 
1026         use these structs in other areas of the code to uniquely identify JSC classes and 
1027         to enforce runtime invariants based on those class identities using ASSERTs.
1028
1029         * bridge/qt/qt_runtime.cpp:
1030         * bridge/qt/qt_runtime.h:
1031
1032 2011-10-04  Ryosuke Niwa  <rniwa@webkit.org>
1033
1034         REGRESSION(r94274): setting input.value erroneously triggers focus event
1035         https://bugs.webkit.org/show_bug.cgi?id=69315
1036
1037         Reviewed by Kent Tamura.
1038
1039         Fixed the bug by adding a new flag to setSelection to avoid calling setFocusedNodeIfNeeded
1040         when called by nodeWillBeRemoved and textWillBeReplaced.
1041
1042         Added a manual test. Unfortunately, the test always passes in DRT.
1043
1044         * editing/FrameSelection.cpp:
1045         (WebCore::FrameSelection::setSelection):
1046         (WebCore::FrameSelection::respondToNodeModification):
1047         (WebCore::FrameSelection::textWillBeReplaced):
1048         * editing/FrameSelection.h:
1049         * manual-tests/mutate-unfocused-text-with-selection.html: Added.
1050
1051 2011-10-04  Young Han Lee  <joybro201@gmail.com>
1052
1053         HTML canvas strokes with dash and dashOffset
1054         https://bugs.webkit.org/show_bug.cgi?id=63933
1055
1056         Reviewed by Simon Fraser.
1057
1058         Add webkitLineDash and webkitLineDashOffset attributes to CanvasRenderingContext2D for JSC.
1059         These attributes can be used to determine the dash-style of stroke in HTML Canvas.
1060
1061         As this kind of attributes are not specified in the HTML Canvas specification yet,
1062         the 'webkit' prefix is added to its names.
1063
1064         Mozilla already implemented these attributes, mozDash and mozDashOffset [1], and this patch
1065         is created by referring to the implementation. This patch is basically using the specified
1066         behavior of stroke-dasharray and stroke-dashoffset in the SVG specification [2], except
1067         that doesn't support units or percentages, just floating point numbers.
1068
1069         [1] https://bugzilla.mozilla.org/show_bug.cgi?id=662038
1070         [2] http://www.w3.org/TR/SVG/painting.html#StrokeProperties
1071
1072         Tests: fast/canvas/canvas-webkitLineDash-invalid.html
1073                fast/canvas/canvas-webkitLineDash.html
1074
1075         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
1076         (WebCore::JSCanvasRenderingContext2D::webkitLineDash):
1077         (WebCore::JSCanvasRenderingContext2D::setWebkitLineDash):
1078         * html/canvas/CanvasRenderingContext2D.cpp:
1079         (WebCore::CanvasRenderingContext2D::State::State):
1080         (WebCore::CanvasRenderingContext2D::webkitLineDash):
1081         (WebCore::CanvasRenderingContext2D::setWebkitLineDash):
1082         (WebCore::CanvasRenderingContext2D::webkitLineDashOffset):
1083         (WebCore::CanvasRenderingContext2D::setWebkitLineDashOffset):
1084         * html/canvas/CanvasRenderingContext2D.h:
1085         * html/canvas/CanvasRenderingContext2D.idl:
1086
1087 2011-10-04  Matthew Delaney  <mdelaney@apple.com>
1088
1089         Allow canvas backing store to be lazily allocated
1090         https://bugs.webkit.org/show_bug.cgi?id=67054
1091
1092         Reviewed by Darin Adler.
1093
1094         No new tests; doesn't affect behavior.
1095
1096         * html/HTMLCanvasElement.cpp:
1097         (WebCore::HTMLCanvasElement::createImageBuffer): Removed the setting of lineWidth
1098         that caused the eager creation of ImageBuffer to use its GraphicsContext.
1099         * html/canvas/CanvasRenderingContext2D.cpp:
1100         (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): Added in default
1101         line width setting along with other default context settings.
1102
1103 2011-10-04  Sam Weinig  <sam@webkit.org>
1104
1105         Add support for the CSP connect-src directive
1106         https://bugs.webkit.org/show_bug.cgi?id=69353
1107
1108         Reviewed by Adam Barth.
1109
1110         Add CSP support for XMLHttpRequest, WebSockets and EventSource.
1111
1112         Tests: http/tests/security/contentSecurityPolicy/connect-src-eventsource-allowed.html
1113                http/tests/security/contentSecurityPolicy/connect-src-eventsource-blocked.html
1114                http/tests/security/contentSecurityPolicy/connect-src-websocket-allowed.html
1115                http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked.html
1116                http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-allowed.html
1117                http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked.html
1118
1119         * page/ContentSecurityPolicy.cpp:
1120         (WebCore::ContentSecurityPolicy::allowConnectFromSource):
1121         (WebCore::ContentSecurityPolicy::addDirective):
1122         * page/ContentSecurityPolicy.h:
1123         Add connect-src directive parsing and predicate.
1124
1125         * page/EventSource.cpp:
1126         (WebCore::EventSource::create):
1127         * websockets/WebSocket.cpp:
1128         (WebCore::WebSocket::connect):
1129         * xml/XMLHttpRequest.cpp:
1130         (WebCore::XMLHttpRequest::open):
1131         Test allowConnectFromSource when establishing a connection.
1132
1133 2011-10-03  David Hyatt  <hyatt@apple.com>
1134
1135         https://bugs.webkit.org/show_bug.cgi?id=69317
1136         
1137         [CSS3 Regions] Make overflow:hidden/auto/scroll sections behave properly when split across regions. This
1138         includes sizing and positioning independently in each region, clipping independently in each region, and
1139         shifting to avoid floats in each region.
1140
1141         Reviewed by Anders Carlsson.
1142
1143         Added many new tests in fast/regions.
1144
1145         * editing/Editor.cpp:
1146         (WebCore::Editor::insideVisibleArea):
1147         Patching a call to overflowClipRect, which now includes a region argument so that clipping can be adjusted
1148         per-region.
1149
1150         * rendering/RenderBlock.cpp:
1151         (WebCore::RenderBlock::layoutBlock):
1152         Don't clear out the cached region information when the width changes. Instead make a new call to
1153         the flow thread to check if widths changed in any region and set relayoutChildren to true if so.
1154
1155         (WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
1156         This is a new function that has been split out from determineLogicalLeftPositionForChild so that it can
1157         be called by region code to compute offsets independently in each region without altering the overall object's
1158         logical left position.
1159         
1160         (WebCore::RenderBlock::determineLogicalLeftPositionForChild):
1161         Patched to call computeStartPositionDeltaForChildAvoidingFloats instead of doing the work of avoiding the floats
1162         itself.
1163
1164         (WebCore::RenderBlock::computeLogicalLocationForFloat):
1165         Fix the left clamping code to clamp to the left border in the correct region rather than always just clamping
1166         to 0.
1167
1168         (WebCore::RenderBlock::logicalLeftOffsetForContent):
1169         (WebCore::RenderBlock::logicalRightOffsetForContent):
1170         Tweaked to handle the new signature of borderBoxRectInRegion.
1171
1172         (WebCore::RenderBlock::nextFloatLogicalBottomBelow):
1173         Reworked not to return 0 on failure or when done, but to just return the current height. This is a more
1174         fitting answer for the function to return when no more floats remain.
1175
1176         (WebCore::RenderBlock::getClearDelta):
1177         Big changes to this function. It was never patched to support writing modes, so the new code is all
1178         writing-mode-aware now. Also improved the computeLogicalWidth() call to make sure margins didn't get incorrectly changed.
1179         The code computes transient information in each region as the object tries to find a place to fit, so that the
1180         old widths are properly retained when layout of that child later checks to see if it needs to relayout children or not.
1181
1182         (WebCore::RenderBlock::nodeAtPoint):
1183         Patched to call overflowClipRect with the region being hit tested.
1184
1185         (WebCore::inNormalFlow):
1186         Tweaked to not need the initialBlock variable.
1187
1188         (WebCore::RenderBlock::applyBeforeBreak):
1189         (WebCore::RenderBlock::applyAfterBreak):
1190         (WebCore::RenderBlock::pageLogicalHeightForOffset):
1191         (WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
1192         (WebCore::RenderBlock::adjustForUnsplittableChild):
1193         (WebCore::RenderBlock::adjustLinePositionForPagination):
1194         (WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
1195         Tweaked to use inRenderFlowThread() now that it exists. Also removing the regionsHaveUniformLogicalWidth()
1196         optimization, since you can't rely on that when objects size differently depending on floats. In other words,
1197         the future of pagination is variable width objects even in printing/columns.
1198
1199         (WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage):
1200         Renamed to make it more clear what logicalPageOffset() was. It's your offset from the top of the first page.
1201
1202         (WebCore::RenderBlock::regionAtBlockOffset):
1203         New helper function for accessing the region at a given offset within your block.
1204
1205         (WebCore::RenderBlock::logicalWidthChangedInRegions):
1206         New helper function that computes whether or not your logical width information changed in any regions. If so,
1207         relayoutChildren gets set to true (just as it would have when computeLogicalWidth for the overall block changes
1208         values).
1209
1210         (WebCore::RenderBlock::collapsedMarginBeforeForChild):
1211         (WebCore::RenderBlock::collapsedMarginAfterForChild):
1212         (WebCore::RenderBlock::marginBeforeForChild):
1213         (WebCore::RenderBlock::marginAfterForChild):
1214         (WebCore::RenderBlock::marginLogicalLeftForChild):
1215         (WebCore::RenderBlock::marginLogicalRightForChild):
1216         (WebCore::RenderBlock::marginStartForChild):
1217         (WebCore::RenderBlock::marginEndForChild):
1218         Tweaked because of const to take const arguments.
1219         
1220         * rendering/RenderBlock.h:
1221         (WebCore::RenderBlock::availableLogicalWidthForLine):
1222         (WebCore::RenderBlock::logicalRightOffsetForLine):
1223         (WebCore::RenderBlock::logicalLeftOffsetForLine):
1224         (WebCore::RenderBlock::startOffsetForLine):
1225         (WebCore::RenderBlock::logicalWidthForChild):
1226         (WebCore::RenderBlock::logicalHeightForChild):
1227         (WebCore::RenderBlock::logicalTopForChild):
1228         (WebCore::RenderBlock::logicalLeftForChild):
1229         (WebCore::RenderBlock::availableLogicalWidthForContent):
1230         (WebCore::RenderBlock::startOffsetForContent):
1231         (WebCore::RenderBlock::logicalLeftOffsetForContent):
1232         (WebCore::RenderBlock::logicalRightOffsetForContent):
1233         Reworking these functions so versions exist that take regions and page offsets to avoid having to recalculate
1234         where you are over and over again as you walk up a containing block chain.
1235
1236         * rendering/RenderBlockLineLayout.cpp:
1237         (WebCore::LineWidth::fitBelowFloats):
1238         Changed to handle the better return value for nextFloatLogicalBottomBelow.
1239         
1240         (WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
1241         Removing the uniform logical width optimization.
1242
1243         * rendering/RenderBox.cpp:
1244         (WebCore::RenderBox::borderBoxRectInRegion):
1245         Changed to take a region and offset from the first page so that it doesn't have to be recomputed as you recur up
1246         the containing block chain.
1247
1248         (WebCore::RenderBox::clearRenderBoxRegionInfo):
1249         Changed to just use inRenderFlowThread().
1250
1251         (WebCore::RenderBox::pushContentsClip):
1252         Changed for the new region-parameterized overflow clip function.
1253         
1254         (WebCore::RenderBox::overflowClipRect):
1255         Now takes a region so that a specific clip rect can be returned sized to the appropriate border box in that
1256         region.
1257
1258         (WebCore::RenderBox::containingBlockLogicalWidthForContent):
1259         (WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
1260         Objects in flow threads no longer shrink to avoid floats when computing their overall widths. The region-specific
1261         check now does the shrinking. It checks at the point where the region slices the object, or the top of the object if
1262         it begins in the middle of the region.
1263
1264         (WebCore::RenderBox::computeLogicalWidth):
1265         (WebCore::RenderBox::computeLogicalWidthInRegion):
1266         Push all the rest of the computeLogicalWidth code into computeLogicalWidthInRegion.
1267         
1268         (WebCore::RenderBox::renderBoxRegionInfo):
1269         Changed to take the region and the offset from the top of the first page to avoid recomputation.
1270
1271         * rendering/RenderBox.h:
1272         (WebCore::RenderBox::hasRenderOverflow):
1273         (WebCore::RenderBox::hasVisualOverflow):
1274         New helper used by the RenderLayer code to avoid having to check visual overflow when none exists.
1275
1276         * rendering/RenderBoxModelObject.cpp:
1277         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
1278         Use the new region-specific overflow clip.
1279
1280         * rendering/RenderBoxRegionInfo.h:
1281         (WebCore::RenderBoxRegionInfo::shiftLogicalLeft):
1282         Helper used by the region code to shift a box over when floats cause it to move.
1283
1284         * rendering/RenderFlowThread.cpp:
1285         (WebCore::RenderFlowThread::computeLogicalWidth):
1286         Remove the optimization to avoid creating box info for uniform widths.
1287
1288         (WebCore::RenderFlowThread::paintIntoRegion):
1289         Make the clip rects used when painting the flow thread's layer tree temporary in each region.
1290
1291         (WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
1292         Removing the uniform logical width optimization
1293
1294         (WebCore::RenderFlowThread::logicalWidthChangedInRegions):
1295         * rendering/RenderFlowThread.h:
1296         New helper called to see if a block needs to relayout its children because its width changed in some
1297         region.
1298
1299         * rendering/RenderLayer.cpp:
1300         (WebCore::RenderLayer::paint):
1301         (WebCore::RenderLayer::paintLayer):
1302         (WebCore::RenderLayer::hitTestLayer):
1303         (WebCore::RenderLayer::updateClipRects):
1304         (WebCore::RenderLayer::calculateClipRects):
1305         (WebCore::RenderLayer::parentClipRects):
1306         (WebCore::RenderLayer::backgroundClipRect):
1307         (WebCore::RenderLayer::calculateRects):
1308         (WebCore::RenderLayer::childrenClipRect):
1309         (WebCore::RenderLayer::selfClipRect):
1310         (WebCore::RenderLayer::repaintBlockSelectionGaps):
1311         * rendering/RenderLayer.h:
1312         * rendering/RenderLayerBacking.cpp:
1313         (WebCore::RenderLayerBacking::updateCompositedBounds):
1314         (WebCore::clipBox):
1315         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
1316         (WebCore::RenderLayerBacking::paintIntoLayer):
1317         * rendering/RenderLayerCompositor.cpp:
1318         (WebCore::RenderLayerCompositor::addToOverlapMap):
1319         (WebCore::RenderLayerCompositor::clippedByAncestor):
1320         Changing all the layer clipping code to pass regions through to all of the helper functions involved. This is
1321         so overflowClipRect can ultimately take a region. Eventually when we get positioned objects moving independently
1322         in each region, we'll patch the "clip" property as well, and it will be much easier because all the plumbing has
1323         been put in place here for overflow.
1324         
1325         * rendering/RenderObject.cpp:
1326         (WebCore::RenderObject::enclosingRenderFlowThread):
1327         Optimized to not walk up the render tree if we're in layout and a currentRenderFlowThread() exists.
1328
1329         * rendering/RenderRegion.cpp:
1330         (WebCore::RenderRegion::renderBoxRegionInfo):
1331         (WebCore::RenderRegion::setRenderBoxRegionInfo):
1332         (WebCore::RenderRegion::takeRenderBoxRegionInfo):
1333         Removing the optimization for uniform logical width regions. Changed remove to take so that the caller
1334         can examine it before deleting.
1335
1336         (WebCore::RenderRegion::offsetFromLogicalTopOfFirstPage):
1337         * rendering/RenderRegion.h:
1338         Helper function that computes the region's offset from the top of the first page.
1339
1340         * rendering/RenderTable.cpp:
1341         (WebCore::RenderTable::overflowClipRect):
1342         (WebCore::RenderTable::nodeAtPoint):
1343         * rendering/RenderTable.h:
1344         * rendering/RenderTableCell.h:
1345         * rendering/RenderTableSection.cpp:
1346         (WebCore::RenderTableSection::nodeAtPoint):
1347         Changed to pass the region to overflowClipRect.
1348
1349         * rendering/RenderTreeAsText.cpp:
1350         (WebCore::writeLayers):
1351         Modified because the layer clip functions need regions now.
1352
1353         * rendering/RenderView.h:
1354         (WebCore::RenderView::pushLayoutState):
1355         Changed to use inRenderFlowThread over view()->hasRenderFlowThread.
1356         
1357         * rendering/svg/RenderSVGRoot.cpp:
1358         (WebCore::RenderSVGRoot::paint):
1359         Patched to use the new overflowClipRect that is region-specific.
1360
1361 2011-10-04  Anders Carlsson  <andersca@apple.com>
1362
1363         More work towards making PlatformWheelEvent immutable
1364         https://bugs.webkit.org/show_bug.cgi?id=69348
1365
1366         Reviewed by Sam Weinig.
1367
1368         More work on getting rid of m_isAccepted from PlatformWheelEvent. Add more asserts
1369         that the return value of handleWheelEvent is equal to m_isAccepted.
1370
1371         * page/EventHandler.cpp:
1372         (WebCore::EventHandler::handleWheelEvent):
1373         * platform/ScrollAnimator.cpp:
1374         (WebCore::ScrollAnimator::handleWheelEvent):
1375
1376 2011-10-04  Cary Clark  <caryclark@google.com>
1377
1378         Inset focus ring (Skia on Mac)
1379         https://bugs.webkit.org/show_bug.cgi?id=69166
1380         http://code.google.com/p/chromium/issues/detail?id=97956
1381
1382         This focus ring was drawn too large and was left tracks
1383         in subsequent invalidations. Make it more closely match
1384         the CG version.
1385
1386         Reviewed by Adam Barth.
1387
1388         No new tests. This platform is not enabled.
1389
1390         * platform/graphics/skia/GraphicsContextSkia.cpp:
1391         (WebCore::getFocusRingOutset):
1392         (WebCore::GraphicsContext::drawFocusRing):
1393
1394 2011-10-03  Jon Lee  <jonlee@apple.com>
1395
1396         Extend DOM WheelEvent to differentiate between physical and logical scroll directions
1397         https://bugs.webkit.org/show_bug.cgi?id=68959
1398         <rdar://problem/10036688>
1399
1400         Reviewed by Sam Weinig.
1401
1402         Test: fast/events/wheelevent-direction-inverted-from-device.html
1403
1404         * dom/WheelEvent.cpp:
1405         (WebCore::WheelEvent::WheelEvent):
1406         (WebCore::WheelEvent::initWheelEvent):
1407         (WebCore::WheelEventDispatchMediator::WheelEventDispatchMediator):
1408         * dom/WheelEvent.h:
1409         (WebCore::WheelEvent::create):
1410         (WebCore::WheelEvent::webkitDirectionInvertedFromDevice):
1411         * dom/WheelEvent.idl: Added the webkitDirectionInvertedFromDevice idl attribute.
1412         * platform/PlatformWheelEvent.h:
1413         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1414         (WebCore::PlatformWheelEvent::webkitDirectionInvertedFromDevice):
1415         * platform/efl/PlatformWheelEventEfl.cpp:
1416         (WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.
1417         * platform/gtk/PlatformWheelEventGtk.cpp:
1418         (WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.
1419         * platform/mac/WheelEventMac.mm:
1420         (WebCore::PlatformWheelEvent::PlatformWheelEvent): if building on Lion or later, use
1421         [NSEvent isDirectionInvertedFromDevice].
1422         * platform/qt/WheelEventQt.cpp:
1423         (WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.
1424         * platform/win/WheelEventWin.cpp:
1425         (WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.
1426         * platform/wx/MouseWheelEventWx.cpp:
1427         (WebCore::PlatformWheelEvent::PlatformWheelEvent): default to false.
1428
1429 2011-10-04  RĂ©mi Duraffort  <remi.duraffort@st.com>
1430
1431         [EFL] Fix compilation when SQLite and/or libxslt are not installed in /usr/include
1432         https://bugs.webkit.org/show_bug.cgi?id=69338
1433
1434         Unreviewed build fix
1435
1436         * CMakeListsEfl.txt:
1437
1438 2011-10-03 Ken Buchanan <kenrb@chromium.org>
1439
1440         Resource loader should block HTTP redirects to local resources
1441         https://bugs.webkit.org/show_bug.cgi?id=68706
1442
1443         Reviewed by Adam Barth.
1444
1445         Modified MainResourceLoader to add an extra security check on
1446         HTTP redirects. Also, moved isFeedWithNestedProtocolInHTTPFamily
1447         to SecurityOrigin.cpp.
1448
1449         * loader/FrameLoader.cpp:
1450         (WebCore::isFeedWithNestedProtocolInHTTPFamily):
1451         (WebCore::FrameLoader::loadFrameRequest):
1452         * loader/MainResourceLoader.cpp:
1453         (WebCore::MainResourceLoader::willSendRequest):
1454         * page/SecurityOrigin.cpp:
1455         (WebCore::isFeedWithNestedProtocolInHTTPFamily):
1456         (WebCore::SecurityOrigin::canDisplay):
1457
1458 2011-10-04  Cary Clark  <caryclark@google.com>
1459
1460         Apply color profile found to decoded bitmap (Skia on Mac)
1461         https://bugs.webkit.org/show_bug.cgi?id=69144
1462         This fixes http://code.google.com/p/chromium/issues/detail?id=97830
1463
1464         Reviewed by Stephen White.
1465
1466         No new tests. This platform is not enabled.
1467
1468         * platform/image-decoders/ImageDecoder.h:
1469         Add color profile slot to Skia variation.
1470
1471         * platform/image-decoders/skia/ImageDecoderSkia.cpp:
1472         (WebCore::resolveColorSpace):
1473         Adjust the bitmap in place to use the supplied color space.
1474
1475         (WebCore::createColorSpace):
1476         Create a CGColorSpace from a color profile.
1477
1478         (WebCore::ImageFrame::setColorProfile):
1479         Save the image's color profile until the image is complete.
1480
1481         (WebCore::ImageFrame::setStatus):
1482         Apply the color profile, if any, to the image.
1483
1484 2011-10-04  Leandro Pereira  <leandro@profusion.mobi>
1485
1486         [CMake] Unreviewed: pass feature definitions in the right format for the CSS scripts.
1487
1488         The Perl scripts in the css/ directory expect the definitions passed via
1489         --defines to be a string of space-separated entries, however we were passing a
1490         list of semicolon-separated strings, thus making all feature defines actually
1491         be ignored.
1492
1493         Detected after r96433, which checked for some definitions in
1494         CSSPropertyNames.in.
1495
1496         No new tests, this is a build fix.
1497
1498         * CMakeLists.txt:
1499
1500 2011-10-04  Pavel Feldman  <pfeldman@google.com>
1501
1502         Web Inspector: make SourceFrame compile.
1503         https://bugs.webkit.org/show_bug.cgi?id=69345
1504
1505         Reviewed by Yury Semikhatsky.
1506
1507         * inspector/compile-front-end.sh:
1508         * inspector/front-end/DOMAgent.js:
1509         (WebInspector.DOMAgent.prototype.inspectElement):
1510         (WebInspector.DOMDispatcher.prototype.inspectElementRequested):
1511         * inspector/front-end/ElementsPanel.js:
1512         (WebInspector.ElementsPanel.prototype._inspectElementRequested):
1513         * inspector/front-end/ObjectPropertiesSection.js:
1514         (WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired):
1515         (WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
1516         * inspector/front-end/ResourcesPanel.js:
1517         (WebInspector.ResourcesPanel.prototype._applyDiffMarkup):
1518         * inspector/front-end/SourceFrame.js:
1519         (WebInspector.SourceFrame.prototype._onShowPopover.showObjectPopover):
1520         (WebInspector.SourceFrame.prototype._onShowPopover):
1521         (WebInspector.SourceFrame.prototype._editBreakpointCondition):
1522         (WebInspector.SourceFrame.prototype.startEditing):
1523         (WebInspector.SourceFrame.prototype.commitEditing.didEditContent):
1524         (WebInspector.SourceFrame.prototype.commitEditing):
1525         (WebInspector.SourceFrameDelegate.prototype.requestContent):
1526         (WebInspector.SourceFrameDelegate.prototype.debuggingSupported):
1527         (WebInspector.SourceFrameDelegate.prototype.setBreakpoint):
1528         (WebInspector.SourceFrameDelegate.prototype.removeBreakpoint):
1529         (WebInspector.SourceFrameDelegate.prototype.updateBreakpoint):
1530         (WebInspector.SourceFrameDelegate.prototype.findBreakpoint):
1531         (WebInspector.SourceFrameDelegate.prototype.continueToLine):
1532         (WebInspector.SourceFrameDelegate.prototype.canEditScriptSource):
1533         (WebInspector.SourceFrameDelegate.prototype.setScriptSource):
1534         (WebInspector.SourceFrameDelegate.prototype.setScriptSourceIsBeingEdited):
1535         (WebInspector.SourceFrameDelegate.prototype.debuggerPaused):
1536         (WebInspector.SourceFrameDelegate.prototype.evaluateInSelectedCallFrame):
1537         (WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):
1538         (WebInspector.SourceFrameDelegate.prototype.suggestedFileName):
1539         * inspector/front-end/externs.js:
1540         (WebInspector.log):
1541         * inspector/front-end/inspector.js:
1542         (WebInspector.log.logMessage):
1543         (WebInspector.log):
1544         * inspector/front-end/utilities.js:
1545         ():
1546
1547 2011-10-04  Mikhail Naganov  <mnaganov@chromium.org>
1548
1549         Web Inspector: Factor out object properties popup.
1550         https://bugs.webkit.org/show_bug.cgi?id=69234
1551
1552         Also, for HTML elements, show a non-empty id value in the element name.
1553
1554         Reviewed by Pavel Feldman.
1555
1556         * WebCore.gypi:
1557         * WebCore.vcproj/WebCore.vcproj:
1558         * inspector/front-end/ObjectPopoverHelper.js: Added.
1559         * inspector/front-end/SourceFrame.js: Extracted from here.
1560         (WebInspector.SourceFrame.prototype._initializeTextViewer):
1561         (WebInspector.SourceFrame.prototype._mouseDown):
1562         (WebInspector.SourceFrame.prototype._onShowPopover.showObjectPopover):
1563         (WebInspector.SourceFrame.prototype._onShowPopover):
1564         * inspector/front-end/WebKit.qrc:
1565         * inspector/front-end/inspector.html:
1566
1567 2011-10-04  Pavel Feldman  <pfeldman@google.com>
1568
1569         Web Inspector: compile text editor.
1570         https://bugs.webkit.org/show_bug.cgi?id=69339
1571
1572         Drive-by compilation for color, database and dom storage entities.
1573
1574         Reviewed by Yury Semikhatsky.
1575
1576         * inspector/Inspector.json:
1577         * inspector/compile-front-end.sh:
1578         * inspector/front-end/Color.js:
1579         (WebInspector.Color.prototype._individualRGBValueToFloatValue):
1580         * inspector/front-end/KeyboardShortcut.js:
1581         (WebInspector.KeyboardShortcut.makeKey):
1582         (WebInspector.KeyboardShortcut.makeKeyFromEvent):
1583         (WebInspector.KeyboardShortcut.makeDescriptor):
1584         * inspector/front-end/SourceCSSTokenizer.js:
1585         * inspector/front-end/SourceCSSTokenizer.re2js:
1586         * inspector/front-end/SourceHTMLTokenizer.js:
1587         * inspector/front-end/SourceHTMLTokenizer.re2js:
1588         * inspector/front-end/SourceJavaScriptTokenizer.js:
1589         * inspector/front-end/SourceJavaScriptTokenizer.re2js:
1590         * inspector/front-end/SourceTokenizer.js:
1591         (WebInspector.SourceTokenizer.prototype._charAt):
1592         (WebInspector.SourceTokenizer.prototype.createInitialCondition):
1593         (WebInspector.SourceTokenizer.prototype.nextToken):
1594         * inspector/front-end/TextEditorHighlighter.js:
1595         (WebInspector.TextEditorHighlighter.prototype.highlight):
1596         (WebInspector.TextEditorHighlighter.prototype._highlightLines):
1597         * inspector/front-end/TextEditorModel.js:
1598         * inspector/front-end/TextViewer.js:
1599         (WebInspector.TextViewerDelegate.prototype.doubleClick):
1600         (WebInspector.TextViewerDelegate.prototype.beforeTextChanged):
1601         (WebInspector.TextViewerDelegate.prototype.afterTextChanged):
1602         (WebInspector.TextViewerDelegate.prototype.commitEditing):
1603         (WebInspector.TextViewerDelegate.prototype.cancelEditing):
1604         (WebInspector.TextViewerDelegate.prototype.populateLineGutterContextMenu):
1605         (WebInspector.TextViewerDelegate.prototype.populateTextAreaContextMenu):
1606         (WebInspector.TextViewerDelegate.prototype.suggestedFileName):
1607         (WebInspector.TextEditorMainPanel.prototype._enclosingLineRowOrSelf):
1608         (WebInspector.TextEditorMainPanel.prototype._createLink):
1609         (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
1610         (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
1611         * inspector/front-end/externs.js:
1612         (WebInspector.completeURL):
1613         (window.getComputedStyle):
1614         (Event.prototype.initWebKitWheelEvent):
1615         * inspector/front-end/utilities.js:
1616
1617 2011-10-04  Vsevolod Vlasov  <vsevik@chromium.org>
1618
1619         Web Inspector: Timeline panel shortcut for filtering short records should have shorter description.
1620         https://bugs.webkit.org/show_bug.cgi?id=69333
1621
1622         Reviewed by Pavel Feldman.
1623
1624         * English.lproj/localizedStrings.js:
1625         * inspector/front-end/TimelinePanel.js:
1626         (WebInspector.TimelinePanel.prototype._registerShortcuts):
1627
1628 2011-10-04  Andreas Kling  <kling@webkit.org>
1629
1630         Shrink StyleRareNonInheritedData.
1631         https://bugs.webkit.org/show_bug.cgi?id=69331
1632
1633         Reviewed by Antti Koivisto.
1634
1635         Rearrange the members and move all small types into the bitfield.
1636         This shrinks StyleRareNonInheritedData by two CPU words, reducing memory
1637         consumption by 140 kB (on 64-bit) when loading the full HTML5 spec.
1638
1639         * rendering/style/StyleRareNonInheritedData.cpp:
1640         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
1641         * rendering/style/StyleRareNonInheritedData.h:
1642
1643 2011-10-04  Vsevolod Vlasov  <vsevik@chromium.org>
1644
1645         Web Inspector: Remove http/tests/inspector/network/disabled-cache-crash.html.
1646         https://bugs.webkit.org/show_bug.cgi?id=69332
1647
1648         Reviewed by Pavel Feldman.
1649
1650         * WebCore.exp.in:
1651         * testing/Internals.cpp:
1652         * testing/Internals.h:
1653         * testing/Internals.idl:
1654
1655 2011-10-04  Pavel Feldman  <pfeldman@chromium.org>
1656
1657         Web Inspector: make DataGrid compile
1658         https://bugs.webkit.org/show_bug.cgi?id=69334
1659
1660         Reviewed by Yury Semikhatsky.
1661
1662         * inspector/compile-front-end.sh:
1663         * inspector/front-end/DataGrid.js:
1664         (WebInspector.DataGrid):
1665         (WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode):
1666         (WebInspector.DataGrid.prototype._startEditing):
1667         (WebInspector.DataGrid.prototype._startEditingConfig):
1668         (WebInspector.DataGrid.prototype._editingCommitted.moveToNextIfNeeded):
1669         (WebInspector.DataGrid.prototype._editingCommitted):
1670         (WebInspector.DataGrid.prototype._editingCancelled):
1671         (WebInspector.DataGrid.prototype.removeChildrenRecursive):
1672         (WebInspector.DataGrid.prototype._keyDown):
1673         (WebInspector.DataGrid.prototype._startResizerDragging):
1674         (WebInspector.DataGrid.prototype._resizerDragging):
1675         (WebInspector.DataGrid.prototype._endResizerDragging):
1676         (WebInspector.DataGridNode.prototype._attach):
1677         * inspector/front-end/UIUtils.js:
1678         (WebInspector.isBeingEdited):
1679         (WebInspector.markBeingEdited):
1680         (WebInspector.isEditingAnyField):
1681         (WebInspector.EditingConfig):
1682         (WebInspector.startEditing.blurEventListener):
1683         (WebInspector.startEditing.getContent):
1684         (WebInspector.startEditing.cleanUpAfterEditing):
1685         (WebInspector.startEditing.editingCancelled):
1686         (WebInspector.startEditing.editingCommitted):
1687         (WebInspector.startEditing.defaultFinishHandler):
1688         (WebInspector.startEditing):
1689         (WebInspector.startEditing.pasteEventListener):
1690         (WebInspector.startEditing.keyDownEventListener):
1691         * inspector/front-end/externs.js:
1692         (Array.prototype.remove):
1693         (window.getComputedStyle):
1694         * inspector/front-end/inspector.js:
1695
1696 2011-10-04  Andrey Kosyakov  <caseq@chromium.org>
1697
1698         Web Inspector: [Extensions API] extension panel's toolbar icon is incorrect when inspector window is docked
1699         https://bugs.webkit.org/show_bug.cgi?id=69336
1700
1701         Reviewed by Pavel Feldman.
1702
1703         * inspector/front-end/ExtensionPanel.js:
1704         (WebInspector.ExtensionPanel):
1705
1706 2011-10-04  Pavel Podivilov  <podivilov@chromium.org>
1707
1708         Web Inspector: update call frame location when source mapping is changed.
1709         https://bugs.webkit.org/show_bug.cgi?id=68997
1710
1711         Currently we use fake "debugger-paused" event hack to update execution line and call stack placards when source mapping is changed.
1712         - add PresentationCallFrame.createPlacard method to create "live" placards that are updated on source mapping changes.
1713         - remove PresentationCallFrame functionName, isInternalScript, and url getters.
1714         - fire execution-line-changed event when selected call frame or source mapping is changed.
1715
1716         Reviewed by Pavel Feldman.
1717
1718         * inspector/compile-front-end.sh:
1719         * inspector/front-end/CallStackSidebarPane.js:
1720         (WebInspector.CallStackSidebarPane.prototype.update):
1721         * inspector/front-end/CompilerSourceMapping.js:
1722         (WebInspector.ClosureCompilerSourceMappingPayload):
1723         (WebInspector.ClosureCompilerSourceMapping):
1724         (WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):
1725         * inspector/front-end/ContentProviders.js:
1726         (WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent):
1727         (WebInspector.CompilerSourceMappingContentProvider.prototype.searchInContent):
1728         * inspector/front-end/DebuggerPresentationModel.js:
1729         (WebInspector.DebuggerPresentationModel):
1730         (WebInspector.DebuggerPresentationModel.prototype.createPlacard.updatePlacard):
1731         (WebInspector.DebuggerPresentationModel.prototype.createPlacard):
1732         (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
1733         (WebInspector.DebuggerPresentationModel.prototype._debuggerResumed):
1734         (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
1735         (WebInspector.DebuggerPresentationModel.prototype.get selectedCallFrame):
1736         (WebInspector.DebuggerPresentationModel.prototype._dispatchExecutionLineChanged):
1737         (WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
1738         (WebInspector.PresentationCallFrame):
1739         (WebInspector.PresentationCallFrame.prototype.get rawSourceCode):
1740         (WebInspector.PresentationCallFrame.prototype.uiLocation):
1741         * inspector/front-end/ScriptsPanel.js:
1742         (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetUILocation):
1743         (WebInspector.ScriptsPanel.prototype._debuggerPaused):
1744         (WebInspector.ScriptsPanel.prototype._executionLineChanged):
1745         (WebInspector.ScriptsPanel.prototype._callFrameSelected):
1746         * inspector/front-end/externs.js:
1747         (WebInspector.displayNameForURL):
1748
1749 2011-10-04  Pavel Feldman  <pfeldman@chromium.org>
1750
1751         Not reviewed: inspector tests fix.
1752
1753         * inspector/front-end/ExtensionPanel.js:
1754         (WebInspector.ExtensionPanel):
1755         (WebInspector.ExtensionPanel.prototype.get toolbarItemLabel):
1756
1757 2011-09-29  Pavel Podivilov  <podivilov@chromium.org>
1758
1759         Web Inspector: add compiler source mapping support to RawSourceCode.
1760         https://bugs.webkit.org/show_bug.cgi?id=68891
1761
1762         Reviewed by Pavel Feldman.
1763
1764         * WebCore.gypi:
1765         * WebCore.vcproj/WebCore.vcproj:
1766         * inspector/front-end/BreakpointManager.js:
1767         (WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
1768         (WebInspector.BreakpointManager.prototype.setBreakpoint):
1769         (WebInspector.BreakpointManager.prototype._materializeBreakpoint):
1770         * inspector/front-end/CompilerSourceMappingProvider.js: Added.
1771         (WebInspector.CompilerSourceMappingProvider):
1772         (WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping):
1773         (WebInspector.CompilerSourceMappingProvider.prototype.loadSourceCode):
1774         * inspector/front-end/DebuggerPresentationModel.js:
1775         (WebInspector.DebuggerPresentationModel.prototype.continueToLine):
1776         * inspector/front-end/RawSourceCode.js:
1777         (WebInspector.RawSourceCode.prototype.setCompilerSourceMappingProvider):
1778         (WebInspector.RawSourceCode.prototype._resourceFinished):
1779         (WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
1780         (WebInspector.RawSourceCode.prototype._updateSourceMapping):
1781         (WebInspector.RawSourceCode.prototype._createSourceMapping.didLoadSourceMapping):
1782         (WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
1783         (WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
1784         (WebInspector.RawSourceCode.CompilerSourceMapping):
1785         (WebInspector.RawSourceCode.CompilerSourceMapping.prototype.rawLocationToUILocation):
1786         (WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):
1787         (WebInspector.RawSourceCode.CompilerSourceMapping.prototype.get uiSourceCodeList):
1788         (WebInspector.CompilerSourceMappingProvider):
1789         (WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping):
1790         (WebInspector.CompilerSourceMappingProvider.prototype.loadSourceCode):
1791         * inspector/front-end/UISourceCodeContentProviders.js:
1792         (WebInspector.CompilerSourceMappingContentProvider):
1793         (WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent):
1794         * inspector/front-end/WebKit.qrc:
1795         * inspector/front-end/inspector.html:
1796
1797 2011-10-04  Pavel Feldman  <pfeldman@google.com>
1798
1799         Web Inspector: start adding UI components to the compilation process.
1800         https://bugs.webkit.org/show_bug.cgi?id=69319
1801
1802         Reviewed by Yury Semikhatsky.
1803
1804         * WebCore.gypi:
1805         * WebCore.vcproj/WebCore.vcproj:
1806         * inspector/compile-front-end.sh:
1807         * inspector/front-end/Drawer.js:
1808         (WebInspector.Drawer.prototype.show.animationFinished):
1809         (WebInspector.Drawer.prototype.show):
1810         (WebInspector.Drawer.prototype.resize):
1811         * inspector/front-end/ElementsPanel.js:
1812         (WebInspector.ElementsPanel.prototype.statusBarResized):
1813         * inspector/front-end/EmptyView.js:
1814         * inspector/front-end/Panel.js:
1815         (WebInspector.Panel.prototype.set get toolbarItemLabel):
1816         (WebInspector.Panel.prototype.get statusBarItems):
1817         (WebInspector.Panel.prototype.updateMainViewWidth):
1818         (WebInspector.Panel.prototype.statusBarResized):
1819         * inspector/front-end/PropertiesSection.js:
1820         * inspector/front-end/SearchController.js:
1821         (WebInspector.SearchController.prototype._onKeyDown):
1822         * inspector/front-end/Section.js:
1823         (WebInspector.Section.prototype.set populated):
1824         (WebInspector.Section.prototype.onpopulate):
1825         (WebInspector.Section.prototype.expand):
1826         * inspector/front-end/SidebarPane.js:
1827         * inspector/front-end/Toolbar.js:
1828         (WebInspector.Toolbar.createPanelToolbarItem):
1829         (WebInspector.ToolbarDropdown.prototype.show):
1830         * inspector/front-end/UIUtils.js: Added.
1831         (WebInspector.elementDragStart):
1832         (WebInspector.elementDragEnd):
1833         (WebInspector.animateStyle):
1834         (WebInspector.animateStyle.forceComplete):
1835         (WebInspector.animateStyle.cancel):
1836         * inspector/front-end/WebKit.qrc:
1837         * inspector/front-end/externs.js:
1838         (WebInspector.extensionServer.notifyPanelShown):
1839         (WebInspector.extensionServer.notifyPanelHidden):
1840         (WebInspector.currentPanel):
1841         (WebInspector.setCurrentPanel):
1842         * inspector/front-end/inspector.html:
1843         * inspector/front-end/inspector.js:
1844
1845 2011-10-04  Kenichi Ishibashi  <bashi@chromium.org>
1846
1847         [Chromium] Implement font shaping with font-feature-settings on Windows
1848         https://bugs.webkit.org/show_bug.cgi?id=65904
1849
1850         Reviewed by Kenneth Russell.
1851
1852         Use Uniscribe's OpenType APIs to shape complex text to support -webkit-font-feature-settings property.
1853
1854         No new tests. css3/font-feature-settings-rendering.html should pass by this patch.
1855
1856         * platform/graphics/chromium/UniscribeHelper.cpp:
1857         (WebCore::loadOpenTypeFunctions):
1858         (WebCore::UniscribeHelper::UniscribeHelper): Calls loadOpenTypeFunctions if needed.
1859         (WebCore::UniscribeHelper::fillRuns): Uses ScriptItemizeOpenType() if possible.
1860         (WebCore::UniscribeHelper::shape): Uses ScriptShapeOpenType() if possible.
1861         (WebCore::UniscribeHelper::fillShapes): Adds OpenType script tag as an argument.
1862         (WebCore::convertFeatureTag): Added.
1863         (WebCore::UniscribeHelper::setRangeProperties): Added.
1864         * platform/graphics/chromium/UniscribeHelper.h:
1865         * platform/graphics/chromium/UniscribeHelperTextRun.cpp:
1866         (WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun): Calls setRangeProperties().
1867
1868 2011-10-04  Ryuan Choi  <ryuan.choi@samsung.com>
1869
1870         [EFL] Implement declared but missing functions.
1871         https://bugs.webkit.org/show_bug.cgi?id=65368
1872
1873         Unreviewed build fix for WebKit/Efl builds after r96566.
1874
1875         * platform/efl/CursorEfl.cpp:
1876         (WebCore::Cursor::operator=):
1877         * platform/efl/LocalizedStringsEfl.cpp:
1878         (WebCore::localizedString):
1879
1880 2011-10-04  Pavel Feldman  <pfeldman@google.com>
1881
1882         Web Inspector: move abstract panel search logic into the only view that is using it.
1883         https://bugs.webkit.org/show_bug.cgi?id=69328
1884
1885         Reviewed by Yury Semikhatsky.
1886
1887         * inspector/front-end/Panel.js:
1888         (WebInspector.Panel.prototype.searchCanceled):
1889         (WebInspector.Panel.prototype.performSearch):
1890         (WebInspector.Panel.prototype.jumpToNextSearchResult):
1891         (WebInspector.Panel.prototype.jumpToPreviousSearchResult):
1892         * inspector/front-end/ProfilesPanel.js:
1893         (WebInspector.ProfilesPanel.prototype.performSearch.updateMatchesCount):
1894         (WebInspector.ProfilesPanel.prototype.performSearch.updateMatchesCountSoon):
1895         (WebInspector.ProfilesPanel.prototype.performSearch.finishedCallback):
1896         (WebInspector.ProfilesPanel.prototype.performSearch.processChunk):
1897         (WebInspector.ProfilesPanel.prototype.performSearch):
1898         (WebInspector.ProfilesPanel.prototype.jumpToNextSearchResult):
1899         (WebInspector.ProfilesPanel.prototype.jumpToPreviousSearchResult):
1900         (WebInspector.ProfilesPanel.prototype._searchableViews):
1901         (WebInspector.ProfilesPanel.prototype.searchCanceled):
1902
1903 2011-10-04  Pavel Feldman  <pfeldman@google.com>
1904
1905         Not reviewed: fixed poor inspector merge, drive-by front-endcompilation fix.
1906
1907         * inspector/front-end/ContentProviders.js:
1908         (WebInspector.ScriptContentProvider.prototype.requestContent):
1909         (WebInspector.ScriptContentProvider.prototype.searchInContent):
1910         (WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent):
1911         * inspector/front-end/DebuggerPresentationModel.js:
1912
1913 2011-10-04  Pavel Feldman  <pfeldman@google.com>
1914
1915         Web Inspector: remove dependency from GoToLine dialog from Panel.
1916         https://bugs.webkit.org/show_bug.cgi?id=69327
1917
1918         Reviewed by Yury Semikhatsky.
1919
1920         * inspector/front-end/GoToLineDialog.js:
1921         (WebInspector.GoToLineDialog.install):
1922         (WebInspector.GoToLineDialog._show):
1923         * inspector/front-end/NetworkItemView.js:
1924         (WebInspector.NetworkItemView.prototype._tabSelected):
1925         (WebInspector.ResourceContentView.prototype.contentLoaded):
1926         (WebInspector.ResourceContentView.prototype.canHighlightLine):
1927         (WebInspector.ResourceContentView.prototype.highlightLine):
1928         (set WebInspector):
1929         * inspector/front-end/NetworkPanel.js:
1930         (WebInspector.NetworkPanel.viewGetter):
1931         (WebInspector.NetworkPanel):
1932         * inspector/front-end/Panel.js:
1933         (WebInspector.Panel.prototype.registerShortcut):
1934         * inspector/front-end/ResourcesPanel.js:
1935         (WebInspector.ResourcesPanel.viewGetter):
1936         (WebInspector.ResourcesPanel):
1937         (WebInspector.ResourcesPanel.prototype.showResource):
1938         * inspector/front-end/ScriptsPanel.js:
1939         (WebInspector.ScriptsPanel.viewGetter):
1940         * inspector/front-end/SourceFrame.js:
1941         (WebInspector.SourceFrame.prototype.canHighlightLine):
1942         * inspector/front-end/TabbedPane.js:
1943         (WebInspector.TabbedPane.prototype._hideTab):
1944         (WebInspector.TabbedPane.prototype.canHighlightLine):
1945         (WebInspector.TabbedPane.prototype.highlightLine):
1946         * inspector/front-end/View.js:
1947         (WebInspector.View.prototype.canHighlightLine):
1948         (WebInspector.View.prototype.highlightLine):
1949
1950 2011-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
1951
1952         Unreviewed, rolling out r96491.
1953         http://trac.webkit.org/changeset/96491
1954         https://bugs.webkit.org/show_bug.cgi?id=69326
1955
1956         Breaks Slow Leopard inspector tests (Requested by pfeldman on
1957         #webkit).
1958
1959         * inspector/Inspector.json:
1960         * inspector/InspectorDebuggerAgent.cpp:
1961         (WebCore::InspectorDebuggerAgent::getScriptSource):
1962         * inspector/InspectorDebuggerAgent.h:
1963         * inspector/front-end/ContentProviders.js:
1964         (WebInspector.ScriptContentProvider.prototype.requestContent):
1965         * inspector/front-end/Script.js:
1966         (WebInspector.Script.prototype.requestSource.didGetScriptSource):
1967         (WebInspector.Script.prototype.requestSource):
1968
1969 2011-10-03  Pavel Feldman  <pfeldman@google.com>
1970
1971         Web Inspector: add DebuggerPresentationModel and ConsoleView to compilation.
1972         https://bugs.webkit.org/show_bug.cgi?id=69269
1973
1974         Reviewed by Yury Semikhatsky.
1975
1976         * inspector/compile-front-end.sh:
1977         * inspector/front-end/BreakpointManager.js:
1978         (WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
1979         * inspector/front-end/ConsoleView.js:
1980         (WebInspector.ConsoleView.prototype._consoleCleared):
1981         (WebInspector.ConsoleView.prototype._completions.evaluated.getCompletions):
1982         (WebInspector.ConsoleView.prototype._completions.evaluated):
1983         (WebInspector.ConsoleView.prototype._messagesClicked):
1984         * inspector/front-end/ContentProviders.js:
1985         (WebInspector.StaticContentProvider.prototype.requestContent):
1986         (WebInspector.StaticContentProvider.prototype.searchInContent):
1987         * inspector/front-end/ContextMenu.js:
1988         * inspector/front-end/DebuggerPresentationModel.js:
1989         (WebInspector.DebuggerPresentationModel.prototype._addScript):
1990         (WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
1991         (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
1992         (WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
1993         (WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
1994         (WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
1995         (WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
1996         (WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
1997         (WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
1998         * inspector/front-end/HelpScreen.js:
1999         * inspector/front-end/JavaScriptContextManager.js:
2000         (WebInspector.FrameEvaluationContext.prototype.get displayName):
2001         * inspector/front-end/KeyboardShortcut.js:
2002         (WebInspector.KeyboardShortcut):
2003         * inspector/front-end/Resource.js:
2004         (WebInspector.Resource.displayName):
2005         * inspector/front-end/ScriptFormatter.js:
2006         (WebInspector.ScriptFormatter.prototype._didFormatContent):
2007         * inspector/front-end/ShortcutsScreen.js:
2008         * inspector/front-end/StatusBarButton.js:
2009         * inspector/front-end/TextPrompt.js:
2010         * inspector/front-end/externs.js:
2011         (WebInspector.populateHrefContextMenu):
2012         (WebInspector.useLowerCaseMenuTitles):
2013         (WebInspector.ScriptsPanel.this.evaluateInSelectedCallFrame):
2014         (WebInspector.ScriptsPanel.this.getSelectedCallFrameVariables):
2015         (WebInspector.ScriptsPanel):
2016         * inspector/front-end/inspector.js:
2017         * inspector/front-end/utilities.js:
2018
2019 2011-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2020
2021         Mac release build fix after r96561, and Leopard build fix after r96568.
2022
2023         * editing/TextCheckingHelper.h:
2024         (WebCore::TextCheckingParagraph::textCharAt):
2025         * page/mac/EventHandlerMac.mm:
2026         (WebCore::EventHandler::wheelEvent):
2027
2028 2011-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2029
2030         Build fix after r96568.
2031
2032         * accessibility/AccessibilityObject.cpp:
2033         * accessibility/mac/WebAccessibilityObjectWrapper.mm:
2034         * editing/Editor.cpp:
2035
2036 2011-10-03  Shinya Kawanaka  <shinyak@google.com>
2037
2038         Should call checkTextOfParagraph() indirectly to make unifying spell-checking code path easy.
2039         https://bugs.webkit.org/show_bug.cgi?id=69241
2040
2041         Reviewed by Ryosuke Niwa.
2042
2043         WebCore has two different code paths for spell-checking:
2044           1) checkTextOfParagraph() for Snow Leopard or later
2045           2) checkSpellingOfString() for checkGrammarOfString() for other platforms.
2046
2047         At the first step, this patch introduces an indirect wrapper to call
2048         checkTextOfParagraph() in Snow Leopard or later. This is intended to make it easy to
2049         introduce a function for mimicing checkTextOfParagraph() in Chromium platform or
2050         other non-SL or non-Lion platform.
2051
2052         No new tests because this patch does not change a behavior.
2053
2054         * accessibility/AccessibilityObject.cpp:
2055         (WebCore::AccessibilityObject::hasMisspelling): Calling checkTextOfParagraph() indirectly.
2056         * accessibility/mac/WebAccessibilityObjectWrapper.mm:
2057         (AXAttributeStringSetSpelling): ditto.
2058         * editing/Editor.cpp:
2059         (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): ditto.
2060         * editing/TextCheckingHelper.cpp:
2061         (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): ditto.
2062         (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): ditto.
2063         (WebCore::checkTextOfParagraph): Added.
2064         * editing/TextCheckingHelper.h:
2065
2066 2011-10-03  Darin Adler  <darin@apple.com>
2067
2068         Change cursor to hand over missing plug-in message
2069         https://bugs.webkit.org/show_bug.cgi?id=69312
2070
2071         Reviewed by Sam Weinig.
2072
2073         No tests because we currently don't have any test machinery for cursors.
2074
2075         * page/EventHandler.cpp:
2076         (WebCore::OptionalCursor::OptionalCursor): Added. Construct an object
2077         to represent either a cursor, or no cursor change.
2078         (WebCore::OptionalCursor::isCursorChange): Added.
2079         (WebCore::OptionalCursor::cursor): Added.
2080         (WebCore::EventHandler::selectCursor): Changed return type to OptionalCursor,
2081         moved some special cases from handleMouseMoveEvent in here. Moved the logic
2082         for plug-ins and framesets into the specific renderer classes for those.
2083         Added a call to the new getCursor virtual function.
2084         (WebCore::EventHandler::handleMouseMoveEvent): Changed cursor setting code to
2085         just be a call to selectCursor and then setCursor. Plug-in-specific code is now
2086         in RenderWidget.
2087
2088         * page/EventHandler.h: Changed return type of selectCursor.
2089
2090         * page/MouseEventWithHitTestResults.cpp: Made some functions be inline.
2091         * page/MouseEventWithHitTestResults.h:
2092         (WebCore::MouseEventWithHitTestResults::localPoint): Made this inline.
2093         (WebCore::MouseEventWithHitTestResults::scrollbar): Made this inline.
2094         Yes, this has nothing to do with the rest of the patch, but it's good.
2095
2096         * rendering/RenderEmbeddedObject.cpp:
2097         (WebCore::RenderEmbeddedObject::getReplacementTextGeometry): Made const.
2098         (WebCore::RenderEmbeddedObject::isInMissingPluginIndicator): Made const.
2099         Overloaded so it can be called with a point rather than an event.
2100         (WebCore::shouldMissingPluginMessageBeButton): Added. Helps streamline
2101         the logic below.
2102         (WebCore::RenderEmbeddedObject::handleMissingPluginIndicatorEvent):
2103         Changed to use shouldMissingPluginMessageBeButton.
2104         (WebCore::RenderEmbeddedObject::getCursor): Added. Sets the cursor to
2105         a hand when over the missing plug-in message.
2106         * rendering/RenderEmbeddedObject.h: Added getCursor override. Also updated
2107         for other changes above.
2108
2109         * rendering/RenderFrameSet.cpp:
2110         (WebCore::RenderFrameSet::getCursor): Added. Contains the logic that used
2111         to be hardcoded in EventHandler::selectCursor about cursors when over
2112         resizable frame borders.
2113         * rendering/RenderFrameSet.h: Added getCursor.
2114
2115         * rendering/RenderObject.cpp:
2116         (WebCore::RenderObject::getCursor): Added. Returns SetCursorBasedOnStyle.
2117         * rendering/RenderObject.h: Added getCursor.
2118
2119         * rendering/RenderWidget.cpp:
2120         (WebCore::RenderWidget::getCursor): Added. Contains the logic that used
2121         to be hardcoded in EventHandler::handleMouseMoveEvent to prevent setting
2122         the cursor when the pointer is over a plug-in. This new code is much better,
2123         because it only kicks in when there is actually a plug-in present. The old
2124         was based on the HTML tag!
2125         * rendering/RenderWidget.h: Added getCursor.
2126
2127 2011-10-03  Anders Carlsson  <andersca@apple.com>
2128
2129         Work towards making PlatformWheelEvent immutable
2130         https://bugs.webkit.org/show_bug.cgi?id=69306
2131
2132         Reviewed by Sam Weinig.
2133
2134         Currently, PlatformWheelEvent has an m_isAccepted flag that tracks whether
2135         the event has been handled or not. For all other event types, that state is instead
2136         tracked by the return value of the various event handlers.
2137
2138         As a first step, add return values to the various handleWheelEvent functions and
2139         add an assertion in EventHandler::wheelEvent that the return value is the same as
2140         the state of PlatformWheelEvent::isAccepted.
2141
2142         * Configurations/Base.xcconfig:
2143         Don't warn when using C++11 extensions.
2144
2145         * page/mac/EventHandlerMac.mm:
2146         (WebCore::EventHandler::wheelEvent):
2147         Assert that isAccepted matches the return value.
2148
2149         * platform/ScrollAnimator.cpp:
2150         (WebCore::ScrollAnimator::handleWheelEvent):
2151         Return isAccepted.
2152
2153         * platform/ScrollAnimator.h:
2154         HandleWheelEvent now returns a boolean.
2155
2156         * platform/ScrollView.cpp:
2157         (WebCore::ScrollView::wheelEvent):
2158         Return whether the event was handled or not.
2159
2160         * platform/ScrollView.h:
2161         ScrollView::wheelEvent now returns a bool.
2162
2163         * platform/ScrollableArea.cpp:
2164         (WebCore::ScrollableArea::handleWheelEvent):
2165         * platform/ScrollableArea.h:
2166         ScrollableArea::handleWheelEvent now returns a bool.
2167
2168         * platform/chromium/ScrollAnimatorChromiumMac.h:
2169         * platform/chromium/ScrollAnimatorChromiumMac.mm:
2170         (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
2171         Add return values, based on either the base class calls or the state of
2172         PlatformWheelEvent::isAccepted().
2173
2174         * platform/mac/ScrollAnimatorMac.h:
2175         * platform/mac/ScrollAnimatorMac.mm:
2176         (WebCore::ScrollAnimatorMac::handleWheelEvent):
2177         Ditto.
2178
2179 2011-10-03  Dan Bernstein  <mitz@apple.com>
2180
2181         <rdar://problem/9973489> REGRESSION (r66599): -[DOMNode boundingBox] returns the zero rect for SVG elements
2182         https://bugs.webkit.org/show_bug.cgi?id=69305
2183
2184         Reviewed by Simon Fraser.
2185
2186         Test: svg/custom/boundingBox.html
2187
2188         Rather than asserting and returning the zero rect, take the transform-aware code path for computing SVG
2189         bounding rects.
2190
2191         * rendering/svg/RenderSVGForeignObject.cpp:
2192         (WebCore::RenderSVGForeignObject::mapLocalToContainer): Updated for change to SVGRenderSupport::mapLocalToContainer().
2193         * rendering/svg/RenderSVGInline.cpp:
2194         (WebCore::RenderSVGInline::mapLocalToContainer): Ditto.
2195         * rendering/svg/RenderSVGModelObject.cpp:
2196         (WebCore::RenderSVGModelObject::mapLocalToContainer): Ditto.
2197         (WebCore::RenderSVGModelObject::absoluteRects): Replaced an incorrect assertion with code to approximate the bounding
2198         box.
2199         * rendering/svg/RenderSVGText.cpp:
2200         (WebCore::RenderSVGText::mapLocalToContainer): Updated for change to SVGRenderSupport::mapLocalToContainer().
2201         * rendering/svg/SVGRenderSupport.cpp:
2202         (WebCore::SVGRenderSupport::mapLocalToContainer): Removed the fixed and useTransform boolean parameters.
2203         * rendering/svg/SVGRenderSupport.h:
2204
2205 2011-10-03  Michael Nordman  <michaeln@google.com>
2206
2207         A little more WebSQLDatabase thread safety.
2208         https://bugs.webkit.org/show_bug.cgi?id=69277
2209
2210         - switch to using AtomicallyInitializedStatic where appropiate
2211         - avoid using some Strings across threads
2212
2213         Reviewed by David Levin.
2214
2215         Existing tests apply.
2216
2217         * storage/AbstractDatabase.cpp:
2218         (WebCore::guidMutex):
2219         (WebCore::guidToVersionMap):
2220         (WebCore::guidToDatabaseMap):
2221         (WebCore::guidForOriginAndName):
2222         (WebCore::AbstractDatabase::databaseInfoTableName):
2223         (WebCore::AbstractDatabase::AbstractDatabase):
2224         (WebCore::AbstractDatabase::performOpenAndVerify):
2225         (WebCore::AbstractDatabase::getVersionFromDatabase):
2226         (WebCore::AbstractDatabase::setVersionInDatabase):
2227         * storage/AbstractDatabase.h:
2228         * storage/chromium/DatabaseTrackerChromium.cpp:
2229         (WebCore::DatabaseTracker::tracker):
2230         * storage/chromium/QuotaTracker.cpp:
2231         (WebCore::QuotaTracker::instance):
2232
2233 2011-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2234
2235         Replace m_firstNodeInserted and m_lastLeafInserted in ReplaceSelectionCommand by positions
2236         https://bugs.webkit.org/show_bug.cgi?id=68874
2237
2238         Reviewed by Enrica Casucci.
2239
2240         Replaced m_firstNodeInserted and m_lastLeafInserted by m_startOfInsertedContent and m_endOfInsertedContent
2241         respectively. Also removed removeNodePreservingChildren and removeNodeAndPruneAncestors in ReplaceSelectionCommand
2242         because they were not virtual in CompositeEditCommand and implicitly overriding the functions was confusing.
2243         Since each of these two functions is used at exactly one place, just update positions and insertedNodes explicitly.
2244
2245         * editing/CompositeEditCommand.cpp:
2246         * editing/ReplaceSelectionCommand.cpp:
2247         (WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
2248         (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent):
2249         (WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent):
2250         (WebCore::ReplaceSelectionCommand::handleStyleSpans):
2251         (WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Update m_endOfInsertedContent by endingSelection().visibleEnd()
2252         instead of m_lastLeafInserted with destination.previous() because moveParagraph could have removed leading whitespace in
2253         the text node referenced by destination. This is tested by an existing layout test.
2254         (WebCore::ReplaceSelectionCommand::doApply):
2255         (WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace): Update positions as needed. All changes are tested
2256         by the existing layout tests in editing/pasteboard.
2257         (WebCore::ReplaceSelectionCommand::updateNodesInserted):
2258         * editing/ReplaceSelectionCommand.h:
2259         * editing/htmlediting.cpp:
2260         (WebCore::hasARenderedDescendant): Moved from CompositeEditCommand.cpp.
2261         (WebCore::highestNodeToRemoveInPruning): Ditto.
2262         * editing/htmlediting.h:
2263
2264 2011-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2265
2266         REGRESSION(r94274): cloned text input loses value
2267         https://bugs.webkit.org/show_bug.cgi?id=69095
2268
2269         Reviewed by Darin Adler.
2270
2271         The bug was caused by copyNonAttributeProperties not updating inner element text after copying
2272         m_valueIfDirty. Fixed the bug by calling updateInnerTextValue.
2273
2274         Test: fast/forms/clone-input-with-dirty-value.html
2275
2276         * html/HTMLInputElement.cpp:
2277         (WebCore::HTMLInputElement::copyNonAttributeProperties):
2278
2279 2011-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2280
2281         Leopard build fix after r96530.
2282
2283         * rendering/svg/RenderSVGResourcePattern.cpp:
2284         (WebCore::RenderSVGResourcePattern::applyResource):
2285
2286 2011-10-03  Sam Weinig  <sam@webkit.org>
2287
2288         Move ContentSecurityPolicy to the ScriptExecutionContext to prepare it for working with XHR and workers
2289         https://bugs.webkit.org/show_bug.cgi?id=69294
2290
2291         Reviewed by Darin Adler.
2292
2293         * dom/Document.cpp:
2294         (WebCore::Document::initSecurityContext):
2295         Initialize the ContentSecurityPolicy by calling down to the ScriptExecutionContext.
2296
2297         * dom/Document.h:
2298         Move the ContentSecurityPolicy member and getter from here to ScriptExecutionContext.h.
2299
2300         * dom/ScriptExecutionContext.cpp:
2301         (WebCore::ScriptExecutionContext::setContentSecurityPolicy):
2302         * dom/ScriptExecutionContext.h:
2303         (WebCore::ScriptExecutionContext::contentSecurityPolicy):
2304         Add ContentSecurityPolicy member and getter/setter.
2305
2306         * page/ContentSecurityPolicy.cpp:
2307         (WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
2308         (WebCore::ContentSecurityPolicy::didReceiveHeader):
2309         (WebCore::ContentSecurityPolicy::reportViolation):
2310         (WebCore::ContentSecurityPolicy::parseReportURI):
2311         (WebCore::ContentSecurityPolicy::createCSPDirective):
2312         * page/ContentSecurityPolicy.h:
2313         (WebCore::ContentSecurityPolicy::create):
2314         Replace Document with ScriptExecutionContext. Add temporary checked casts to document
2315         where necessary.
2316
2317         * workers/WorkerContext.cpp:
2318         (WebCore::WorkerContext::WorkerContext):
2319         Add initialization of the ContentSecurityPolicy.
2320
2321 2011-10-03  Anders Carlsson  <andersca@apple.com>
2322
2323         Remove custom scrollbar painting hooks
2324         https://bugs.webkit.org/show_bug.cgi?id=69163
2325
2326         Reviewed by Alexey Proskuryakov.
2327
2328         The custom scrollbar and scroll corner painting hooks aren't used by anyone
2329         so go ahead and remove them. This removes the setter/getter and ChromeClient functions.
2330
2331         * page/Chrome.cpp:
2332         * page/ChromeClient.h:
2333         * page/Settings.cpp:
2334         (WebCore::Settings::Settings):
2335         * page/Settings.h:
2336         * platform/ScrollbarThemeComposite.cpp:
2337         (WebCore::ScrollbarThemeComposite::paint):
2338         (WebCore::ScrollbarThemeComposite::paintScrollCorner):
2339
2340 2011-09-22  Darin Adler  <darin@apple.com>
2341
2342         Rename many obviously-correct call sites in WebCore using releaseRef to use it by its new name leakRef
2343         https://bugs.webkit.org/show_bug.cgi?id=68672
2344
2345         Reviewed by Daniel Bates.
2346
2347         * bindings/js/JSDOMWindowBase.cpp:
2348         (WebCore::JSDOMWindowBase::commonJSGlobalData):
2349         * css/CSSInitialValue.h:
2350         (WebCore::CSSInitialValue::createExplicit):
2351         (WebCore::CSSInitialValue::createImplicit):
2352         * css/CSSPrimitiveValue.cpp:
2353         (WebCore::CSSPrimitiveValue::init):
2354         * css/CSSStyleSelector.cpp:
2355         (WebCore::parseUASheet):
2356         (WebCore::CSSStyleSelector::styleForElement):
2357         * platform/ScrollView.cpp:
2358         (WebCore::ScrollView::wheelEvent):
2359         * platform/efl/RenderThemeEfl.cpp:
2360         (WebCore::RenderTheme::themeForPage):
2361         * platform/gtk/RenderThemeGtk.cpp:
2362         (WebCore::RenderTheme::themeForPage):
2363         * platform/haiku/RenderThemeHaiku.cpp:
2364         (WebCore::RenderTheme::themeForPage):
2365         * platform/network/cf/DNSCFNet.cpp:
2366         (WebCore::DNSResolveQueue::resolve):
2367         * platform/network/cf/ResourceHandleCFNet.cpp:
2368         (WebCore::ResourceHandle::releaseConnectionForDownload):
2369         * platform/qt/RenderThemeQt.cpp:
2370         (WebCore::RenderTheme::themeForPage):
2371         (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
2372         * platform/text/BidiContext.cpp:
2373         (WebCore::BidiContext::create):
2374         * platform/wx/RenderThemeWx.cpp:
2375         (WebCore::RenderTheme::themeForPage):
2376         * rendering/RenderThemeChromiumLinux.cpp:
2377         (WebCore::RenderTheme::themeForPage):
2378         * rendering/RenderThemeChromiumMac.mm:
2379         (WebCore::RenderTheme::themeForPage):
2380         * rendering/RenderThemeChromiumSkia.cpp:
2381         (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
2382         (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
2383         (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
2384         * rendering/RenderThemeChromiumWin.cpp:
2385         (WebCore::RenderTheme::themeForPage):
2386         * rendering/RenderThemeMac.mm:
2387         (WebCore::RenderTheme::themeForPage):
2388         * rendering/RenderThemeSafari.cpp:
2389         (WebCore::RenderTheme::themeForPage):
2390         * rendering/RenderThemeWin.cpp:
2391         (WebCore::RenderTheme::themeForPage):
2392         (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
2393         (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
2394         (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
2395         * rendering/RenderThemeWinCE.cpp:
2396         (WebCore::RenderTheme::themeForPage):
2397         * rendering/style/RenderStyle.cpp:
2398         (WebCore::defaultStyle):
2399         Call leakRef instead of releaseRef. I did this only in the cases where
2400         it was obvious to me this was the right way to do it. I'll keep revisiting
2401         sites still calling it releaseRef until they are all gone.
2402
2403 2011-09-27  Ojan Vafai  <ojan@chromium.org>
2404
2405         remove dead code in flipForWritingMode
2406         https://bugs.webkit.org/show_bug.cgi?id=68948
2407
2408         Reviewed by Hajime Morita.
2409
2410         ChildToParentFlippingAdjustment is never used, so the third argument
2411         to flipForWritingMode always has the same value.
2412
2413         In addition, renamed to flipForWritingModeForChild to be more clear
2414         that it's operating on the child and renamed flipFloatForWritingMode to match.
2415
2416         No new tests. This is just a code cleanup. No functional changes. 
2417
2418         * rendering/InlineBox.cpp:
2419         (WebCore::InlineBox::paint):
2420         * rendering/RenderBlock.cpp:
2421         (WebCore::RenderBlock::paintChildren):
2422         (WebCore::RenderBlock::flipFloatForWritingModeForChild):
2423         (WebCore::RenderBlock::paintFloats):
2424         (WebCore::RenderBlock::hitTestFloats):
2425         (WebCore::RenderBlock::hitTestContents):
2426         * rendering/RenderBlock.h:
2427         * rendering/RenderBox.cpp:
2428         (WebCore::RenderBox::flipForWritingModeForChild):
2429         (WebCore::RenderBox::topLeftLocation):
2430         * rendering/RenderBox.h:
2431         * rendering/RenderTable.cpp:
2432         (WebCore::RenderTable::paintObject):
2433         (WebCore::RenderTable::nodeAtPoint):
2434         * rendering/RenderTableRow.cpp:
2435         (WebCore::RenderTableRow::nodeAtPoint):
2436         * rendering/RenderTableSection.cpp:
2437         (WebCore::RenderTableSection::paintCell):
2438         (WebCore::RenderTableSection::nodeAtPoint):
2439
2440 2011-10-03  Jer Noble  <jer.noble@apple.com>
2441
2442         Unreviewed, rolling out r96526.
2443         http://trac.webkit.org/changeset/96526
2444         https://bugs.webkit.org/show_bug.cgi?id=68587
2445
2446         WEB_AUDIO has numerous 64->32 bit casting warnings, causing
2447         build breakages where -Wall is enabled.
2448
2449         * Configurations/FeatureDefines.xcconfig:
2450         * WebCore.xcodeproj/project.pbxproj:
2451
2452 2011-10-03  Joseph Pecoraro  <joepeck@webkit.org>
2453
2454         Web Inspector: rgb() with percentages shows wrong hex/hsl values
2455         https://bugs.webkit.org/show_bug.cgi?id=69152
2456
2457         Reviewed by Pavel Feldman.
2458
2459         Previously we assumed rgb values were always in byte form,
2460         but they could include percentage values. Ex. rgb(100%,0,0).
2461         This patch fixes this, and in the process includes clamping
2462         for invalid percentages, byte values, and alpha values.
2463
2464         Test: inspector/styles/styles-invalid-color-values.html
2465
2466         * inspector/front-end/Color.js:
2467         (WebInspector.Color.prototype._clamp):
2468         (WebInspector.Color.prototype._individualRGBValueToFloatValue):
2469         (WebInspector.Color.prototype._individualRGBValueToHexValue):
2470         (WebInspector.Color.prototype._rgbToHex):
2471         (WebInspector.Color.prototype._rgbToHSL):
2472         An individual rgb value can be either a decimal/float or a
2473         percentage. Rewrite the conversion functions to handle either
2474         input. Regardless of the type of input, always return a clamped
2475         decimal/float value between 0 and 255.
2476
2477         (WebInspector.Color.prototype._rgbaToHSLA):
2478         (WebInspector.Color.prototype._hslaToRGBA):
2479         (WebInspector.Color.prototype._parse):
2480         Clamp the alpha value between 0 and 1.
2481
2482 2011-10-03  Dirk Schulze  <krit@webkit.org>
2483
2484         SVG Pattern tile pixelated on patternTransform
2485         https://bugs.webkit.org/show_bug.cgi?id=69261
2486
2487         Reviewed by Rob Buis.
2488
2489         Scale the SVG pattern tile by the scale level of patternTransform to avoid pixelation.
2490
2491         Test: svg/custom/pattern-scaled-pattern-space.svg
2492
2493         * rendering/svg/RenderSVGResourcePattern.cpp:
2494         (WebCore::RenderSVGResourcePattern::applyResource):
2495
2496 2011-10-03  Jer Noble  <jer.noble@apple.com>
2497
2498         Enable WEB_AUDIO by default in the WebKit/mac port.
2499         https://bugs.webkit.org/show_bug.cgi?id=68587
2500
2501         Reviewed by Simon Fraser.
2502
2503         No new tests; existing webaudio/ layout tests cover this.
2504
2505         * Configurations/FeatureDefines.xcconfig:
2506         * WebCore.xcodeproj/project.pbxproj: Add a build step which copies audio resources to
2507             the WebCore.framework bundle.
2508
2509 2011-10-03  Chris Rogers  <crogers@google.com>
2510
2511         BiquadFilterNode .type attribute is not handled correctly
2512         https://bugs.webkit.org/show_bug.cgi?id=69182
2513
2514         Reviewed by Kenneth Russell.
2515
2516         Test: webaudio/biquadfilternode-basic.html
2517
2518         * platform/audio/AudioDSPKernelProcessor.cpp:
2519         (WebCore::AudioDSPKernelProcessor::initialize):
2520         * webaudio/AudioBufferSourceNode.cpp:
2521         (WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
2522         * webaudio/AudioChannelMerger.cpp:
2523         (WebCore::AudioChannelMerger::AudioChannelMerger):
2524         * webaudio/AudioChannelSplitter.cpp:
2525         (WebCore::AudioChannelSplitter::AudioChannelSplitter):
2526         * webaudio/AudioDestinationNode.cpp:
2527         (WebCore::AudioDestinationNode::AudioDestinationNode):
2528         * webaudio/AudioGainNode.cpp:
2529         (WebCore::AudioGainNode::AudioGainNode):
2530         * webaudio/AudioNode.cpp:
2531         (WebCore::AudioNode::AudioNode):
2532         (WebCore::AudioNode::~AudioNode):
2533         (WebCore::AudioNode::setNodeType):
2534         (WebCore::AudioNode::ref):
2535         (WebCore::AudioNode::finishDeref):
2536         * webaudio/AudioNode.h:
2537         (WebCore::AudioNode::nodeType):
2538         * webaudio/AudioPannerNode.cpp:
2539         (WebCore::AudioPannerNode::AudioPannerNode):
2540         (WebCore::AudioPannerNode::notifyAudioSourcesConnectedToNode):
2541         * webaudio/BiquadFilterNode.cpp:
2542         (WebCore::BiquadFilterNode::BiquadFilterNode):
2543         (WebCore::BiquadFilterNode::setType):
2544         * webaudio/BiquadFilterNode.h:
2545         * webaudio/BiquadFilterNode.idl:
2546         * webaudio/BiquadProcessor.h:
2547         (WebCore::BiquadProcessor::setType):
2548         * webaudio/ConvolverNode.cpp:
2549         (WebCore::ConvolverNode::ConvolverNode):
2550         * webaudio/DelayNode.cpp:
2551         (WebCore::DelayNode::DelayNode):
2552         * webaudio/DynamicsCompressorNode.cpp:
2553         (WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
2554         * webaudio/HighPass2FilterNode.cpp:
2555         (WebCore::HighPass2FilterNode::HighPass2FilterNode):
2556         * webaudio/JavaScriptAudioNode.cpp:
2557         (WebCore::JavaScriptAudioNode::JavaScriptAudioNode):
2558         * webaudio/LowPass2FilterNode.cpp:
2559         (WebCore::LowPass2FilterNode::LowPass2FilterNode):
2560         * webaudio/MediaElementAudioSourceNode.cpp:
2561         (WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
2562         * webaudio/RealtimeAnalyserNode.cpp:
2563         (WebCore::RealtimeAnalyserNode::RealtimeAnalyserNode):
2564         * webaudio/WaveShaperNode.cpp:
2565         (WebCore::WaveShaperNode::WaveShaperNode):
2566
2567 2011-10-03  Chris Fleizach  <cfleizach@apple.com>
2568
2569         AX: support role mapping for HTML5 section elements
2570         https://bugs.webkit.org/show_bug.cgi?id=69150
2571
2572         We need to map these HTML5 elements to appropriate ARIA roles. That mapping is:
2573           article -> Document article
2574           nav -> Landmark navigation
2575           aside -> Landmark complementary
2576           section -> Document region
2577           address -> Landmark content info
2578           header -> Landmark banner (unless it's in an article or section)
2579           footer -> Landmark content info (unless it's in an article or section)
2580
2581         Reviewed by Darin Adler.
2582
2583         Test: platform/mac/accessibility/html-section-elements.html
2584
2585         * accessibility/AccessibilityRenderObject.cpp:
2586         (WebCore::AccessibilityRenderObject::isDescendantOfElementType):
2587         (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
2588         * accessibility/AccessibilityRenderObject.h:
2589
2590 2011-10-03  Chris Fleizach  <cfleizach@apple.com>
2591
2592         AX: click point for AXHeadings often returns point on empty space (results in wrong context menu)
2593         https://bugs.webkit.org/show_bug.cgi?id=69262
2594
2595         When the contextual menu is opened for a heading, often it will open on empty space because
2596         the heading is wider than the content inside. The click point should thus use the content
2597         inside the heading as the click point.
2598
2599         To accomplish this we need to query whether we have children using children() which is a non-const
2600         method, hence the removal of const from clickPoint().
2601
2602         Reviewed by John Sullivan.
2603
2604         Test: platform/mac/accessibility/heading-clickpoint.html
2605
2606         * accessibility/AccessibilityObject.cpp:
2607         (WebCore::AccessibilityObject::clickPoint):
2608         * accessibility/AccessibilityObject.h:
2609         * accessibility/AccessibilityRenderObject.cpp:
2610         (WebCore::AccessibilityRenderObject::clickPoint):
2611         * accessibility/AccessibilityRenderObject.h:
2612
2613 2011-10-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2614
2615         Unreviewed, rolling out r96500.
2616         http://trac.webkit.org/changeset/96500
2617         https://bugs.webkit.org/show_bug.cgi?id=69268
2618
2619         Breaks inspector, change landed with no test. (Requested by
2620         pfeldman on #webkit).
2621
2622         * WebCore.gypi:
2623         * WebCore.vcproj/WebCore.vcproj:
2624         * inspector/front-end/ConsoleMessage.js:
2625         (WebInspector.ConsoleMessageImpl.prototype._linkifyLocation):
2626         * inspector/front-end/ConsoleView.js:
2627         (WebInspector.ConsoleView.prototype._consoleCleared):
2628         * inspector/front-end/DebuggerPresentationModel.js:
2629         (WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
2630         (WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
2631         * inspector/front-end/EventListenersSidebarPane.js:
2632         (WebInspector.EventListenersSidebarPane.prototype.update.callback):
2633         (WebInspector.EventListenersSidebarPane.prototype.update):
2634         ():
2635         * inspector/front-end/Linkifier.js: Removed.
2636         * inspector/front-end/NetworkPanel.js:
2637         (WebInspector.NetworkLogView):
2638         (WebInspector.NetworkLogView.prototype._reset):
2639         (WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
2640         * inspector/front-end/ProfileDataGridTree.js:
2641         (WebInspector.ProfileDataGridNode.prototype.createCell):
2642         * inspector/front-end/ProfileView.js:
2643         (WebInspector.CPUProfileView):
2644         (WebInspector.CPUProfileView.prototype._resetClicked):
2645         * inspector/front-end/TimelinePanel.js:
2646         (WebInspector.TimelinePanel):
2647         (WebInspector.TimelinePanel.prototype._clearPanel):
2648         (WebInspector.TimelinePanel.FormattedRecord):
2649         (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
2650         (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
2651         (WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyLocation):
2652         (WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyCallFrame):
2653         (WebInspector.TimelinePanel.PopupContentHelper):
2654         (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
2655         (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
2656         * inspector/front-end/WebKit.qrc:
2657         * inspector/front-end/inspector.html:
2658         * inspector/front-end/inspector.js:
2659
2660 2011-09-30  Antti Koivisto  <antti@apple.com>
2661
2662         Add exact match attribute selectors to the fast path
2663         https://bugs.webkit.org/show_bug.cgi?id=69159
2664
2665         Reviewed by Sam Weinig.
2666
2667         Attribute selectors are increasingly common and we have them in our default style sheet too.
2668         [foo] and [foo="bar"] type selectors can be resolved quickly and easily in the fast path.
2669         
2670         - Implement fast path checking for simple attribute selectors.
2671         - Get rid of the ill-defined CSSSelector::hasAttribute(), inline CSSSelector::attribute()
2672         
2673         This is ~20% progression in styleForElement() performance loading the full HTML5 spec (~0.8s).
2674
2675         * css/CSSSelector.cpp:
2676         (WebCore::CSSSelector::selectorText):
2677         * css/CSSSelector.h:
2678         (WebCore::CSSSelector::hasTag):
2679         (WebCore::CSSSelector::attribute):
2680         (WebCore::CSSSelector::isAttributeSelector):
2681         * css/CSSSelectorList.cpp:
2682         (WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
2683         * css/CSSStyleSelector.cpp:
2684         (WebCore::CSSStyleSelector::checkSelector):
2685         * css/SelectorChecker.cpp:
2686         (WebCore::SelectorChecker::fastCheckRightmostSelector):
2687         (WebCore::SelectorChecker::fastCheckSelector):
2688         (WebCore::isFastCheckableMatch):
2689         (WebCore::isFastCheckableRightmostSelector):
2690         (WebCore::SelectorChecker::isFastCheckableSelector):
2691         (WebCore::SelectorChecker::checkSelector):
2692         (WebCore::htmlAttributeHasCaseInsensitiveValue):
2693         (WebCore::anyAttributeMatches):
2694         (WebCore::SelectorChecker::checkOneSelector):
2695         * css/SelectorChecker.h:
2696         (WebCore::SelectorChecker::attributeNameMatches):
2697         (WebCore::SelectorChecker::checkExactAttribute):
2698         (WebCore::SelectorChecker::fastCheckRightmostAttributeSelector):
2699
2700 2011-10-03  Mike Reed  <reed@google.com>
2701
2702         respect other paint flags when setting flags for the font. No need to fiddle with DC(0) in paintSkiaText.
2703         https://bugs.webkit.org/show_bug.cgi?id=69172
2704
2705         Reviewed by Stephen White.
2706
2707         No new tests. This is a cleanup/optimization, existing tests apply
2708
2709         * platform/graphics/skia/SkiaFontWin.cpp:
2710         (WebCore::getDefaultGDITextFlags):
2711         (WebCore::setupPaintForFont):
2712         (WebCore::paintSkiaText):
2713
2714 2011-10-03  Andreas Kling  <kling@webkit.org>
2715
2716         FontFallbackList: Glyph pages waste a lot of memory.
2717         https://bugs.webkit.org/show_bug.cgi?id=69260
2718
2719         Reviewed by Dan Bernstein.
2720
2721         Use a minimum hash table size of 16 (down from 64) for FontFallbackList's
2722         glyph pages. This reduces memory consumption by ~900 kB when loading the
2723         full HTML5 spec.
2724
2725         The cost is two additional rehash()es of FontFallbackList::m_pages when
2726         adding the 32nd and 64th pages to the hash map.
2727
2728         * platform/graphics/FontFallbackList.h:
2729
2730 2011-10-03  Konstantin Scheglov  <scheglov@google.com>
2731
2732         Right border missing from table with colspan and collapsing border
2733         https://bugs.webkit.org/show_bug.cgi?id=14274
2734
2735         Reviewed by David Hyatt.
2736
2737         Test: fast/table/border-collapsing/bug14274.html
2738
2739         * rendering/RenderTable.cpp:
2740         (WebCore::RenderTable::RenderTable):
2741         * rendering/RenderTable.h:
2742         (WebCore::RenderTable::colToEffCol):
2743
2744 2011-10-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2745
2746         [GTK] Fix make distcheck build
2747         https://bugs.webkit.org/show_bug.cgi?id=69243
2748
2749         Reviewed by Martin Robinson.
2750
2751         * GNUmakefile.am:
2752         * GNUmakefile.list.am:
2753
2754 2011-10-03  Pierre Rossi  <pierre.rossi@gmail.com>
2755
2756         [Qt] Build fix: Qt::escape is deprecated in Qt5
2757         https://bugs.webkit.org/show_bug.cgi?id=69162
2758
2759         Use QString::toHtmlEscaped in the Qt5 case.
2760
2761         Reviewed by Andreas Kling.
2762
2763         No new tests needed.
2764
2765         * WebCore.pro: adjust the include path accordingly
2766         in the v8 case.
2767
2768 2011-10-03  Ilya Tikhonovsky  <loislo@chromium.org>
2769
2770         Web Inspector: debuggerPresentatioModel.linkifyLocation leaks updateAnchor closure instances.
2771         https://bugs.webkit.org/show_bug.cgi?id=69146
2772
2773         In many places we use linkifyLocation function to produce a link node which updates automatically when the source file is changed on the fly.
2774         Such changes happen when we use pretty print or another operation that changes the source code somehow.
2775         linkifyLocation associates a new instance of updateAnchor closure with the each link node and add the closure to the SourceMappingUpdated event's list.
2776         As the result the node<->closure pairs wouldn't be collected until reset the UI and DebuggerPresentationModel.
2777
2778         Reviewed by Yury Semikhatsky.
2779
2780         Test: inspector/performance/resources/network-append-30-requests.html
2781
2782         * WebCore.gypi:
2783         * WebCore.vcproj/WebCore.vcproj:
2784         * inspector/front-end/ConsoleMessage.js:
2785         (WebInspector.ConsoleMessage.prototype._linkifyLocation):
2786         * inspector/front-end/ConsoleView.js:
2787         (WebInspector.ConsoleView.prototype._consoleCleared):
2788         * inspector/front-end/DebuggerPresentationModel.js:
2789         * inspector/front-end/EventListenersSidebarPane.js:
2790         (WebInspector.EventListenersSidebarPane.prototype.update.callback):
2791         (WebInspector.EventListenersSidebarPane.prototype.update):
2792         ():
2793         * inspector/front-end/Linkifier.js: Added.
2794         (WebInspector.Linkifier):
2795         (WebInspector.Linkifier.prototype.linkifyLocation):
2796         (WebInspector.Linkifier.prototype.reset):
2797         (WebInspector.Linkifier.prototype._updateSourceAnchors):
2798         (WebInspector.Linkifier.prototype._updateAnchor):
2799         * inspector/front-end/NetworkPanel.js:
2800         (WebInspector.NetworkLogView):
2801         (WebInspector.NetworkLogView.prototype._reset):
2802         (WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
2803         * inspector/front-end/ProfileDataGridTree.js:
2804         (WebInspector.ProfileDataGridNode.prototype.createCell):
2805         * inspector/front-end/ProfileView.js:
2806         (WebInspector.CPUProfileView):
2807         (WebInspector.CPUProfileView.prototype._resetClicked):
2808         * inspector/front-end/TimelinePanel.js:
2809         (WebInspector.TimelinePanel):
2810         (WebInspector.TimelinePanel.prototype._linkifyLocation):
2811         (WebInspector.TimelinePanel.prototype._linkifyCallFrame):
2812         (WebInspector.TimelinePanel.prototype._clearPanel):
2813         (WebInspector.TimelinePanel.FormattedRecord):
2814         (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
2815         (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
2816         (WebInspector.TimelinePanel.PopupContentHelper):
2817         (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
2818         (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
2819         * inspector/front-end/WebKit.qrc:
2820         * inspector/front-end/inspector.html:
2821         * inspector/front-end/inspector.js:
2822
2823 2011-10-03  Pavel Feldman  <pfeldman@google.com>
2824
2825         Web Inspector: more compilation fixes including making ConsoleMessage a part of console model.
2826         https://bugs.webkit.org/show_bug.cgi?id=69253
2827
2828         Reviewed by Yury Semikhatsky.
2829
2830         * inspector/Inspector.json:
2831         * inspector/compile-front-end.sh:
2832         * inspector/front-end/ConsoleMessage.js:
2833         (WebInspector.ConsoleMessage.create):
2834         (WebInspector.ConsoleMessage.createTextMessage):
2835         (WebInspector.ConsoleMessageImpl):
2836         * inspector/front-end/ConsoleModel.js:
2837         (WebInspector.ConsoleModel.prototype._messageRepeatCountUpdated):
2838         (WebInspector.ConsoleMessage.create):
2839         (WebInspector.ConsoleMessage.createTextMessage):
2840         (WebInspector.ConsoleDispatcher.prototype.messageAdded):
2841         * inspector/front-end/ConsoleView.js:
2842         (WebInspector.ConsoleCommandResult):
2843         (WebInspector.ConsoleCommandResult.prototype.toMessageElement):
2844         * inspector/front-end/CookieParser.js:
2845         (WebInspector.Cookie.prototype.get path):
2846         (WebInspector.Cookie.prototype.get domain):
2847         (WebInspector.Cookie.prototype.expires):
2848         * inspector/front-end/DOMAgent.js:
2849         * inspector/front-end/ExtensionServer.js:
2850         (WebInspector.ExtensionServer.prototype._onAddConsoleMessage):
2851         * inspector/front-end/NetworkManager.js:
2852         (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
2853         (WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
2854         (WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):
2855         (WebInspector.NetworkDispatcher.prototype.webSocketCreated):
2856         (WebInspector.NetworkDispatcher.prototype._createResource):
2857         * inspector/front-end/Resource.js:
2858         (WebInspector.Resource):
2859         (WebInspector.Resource.prototype.setContent):
2860         (WebInspector.Resource.prototype.searchInContent):
2861         * inspector/front-end/ResourceTreeModel.js:
2862         (WebInspector.ResourceTreeModel.prototype._createResource):
2863         * inspector/front-end/externs.js:
2864         (WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
2865         (WebInspector.extensionServer.notifyResourceContentCommitted):
2866         (WebInspector.resourceForURL):
2867         (WebInspector.debuggerPresentationModel.linkifyLocation):
2868         (WebInspector.ObjectPropertiesSection):
2869         (WebInspector.ElementsTreeOutline):
2870         * inspector/front-end/inspector.html:
2871         * inspector/front-end/inspector.js:
2872         (WebInspector.log.logMessage):
2873         (WebInspector.log):
2874         * inspector/generate-protocol-externs:
2875
2876 2011-10-03  Pavel Feldman  <pfeldman@google.com>
2877
2878         Web Inspector: move console message formatting from ConsoleView.js into ConsoleMessage.js
2879         https://bugs.webkit.org/show_bug.cgi?id=69244
2880
2881         Reviewed by Yury Semikhatsky.
2882
2883         * inspector/front-end/ConsoleMessage.js:
2884         (WebInspector.ConsoleMessage):
2885         (WebInspector.ConsoleMessage.prototype._formatMessage.else.else.linkifier):
2886         (WebInspector.ConsoleMessage.prototype._formatMessage):
2887         (WebInspector.ConsoleMessage.prototype._format):
2888         (WebInspector.ConsoleMessage.prototype._formatParameter):
2889         (WebInspector.ConsoleMessage.prototype._formatParameterAsValue):
2890         (WebInspector.ConsoleMessage.prototype._formatParameterAsObject):
2891         (WebInspector.ConsoleMessage.prototype._formatParameterAsNode):
2892         (WebInspector.ConsoleMessage.prototype._formatParameterAsArray):
2893         (WebInspector.ConsoleMessage.prototype._formatParameterAsString):
2894         (WebInspector.ConsoleMessage.prototype._printArray):
2895         (WebInspector.ConsoleMessage.prototype._formatAsArrayEntry):
2896         (WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString):
2897         * inspector/front-end/ConsoleView.js:
2898
2899 2011-10-03  Dirk Schulze  <krit@webkit.org>
2900
2901         feColorMatrix saturation is not limited to range 0..1 anymore
2902         https://bugs.webkit.org/show_bug.cgi?id=69245
2903
2904         Reviewed by Nikolas Zimmermann.
2905         
2906         Opera doesn't limit the range of values for saturation on feColorMatrix from 0 to 1. The limitation
2907         was also removed from the new Filter Effects 1.0 specification. Values outside this range lead to
2908         under- or oversaturation of the filter input image.
2909         https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/publish/Filters.html#feColorMatrixElement
2910
2911         Test: svg/filters/feColorMatrix-saturate.svg
2912
2913         * svg/SVGFEColorMatrixElement.cpp:
2914         (WebCore::SVGFEColorMatrixElement::build):
2915
2916 2011-10-03  Andreas Kling  <kling@webkit.org>
2917
2918         Shrink HTMLLIElement.
2919         https://bugs.webkit.org/show_bug.cgi?id=69250
2920
2921         Reviewed by Antti Koivisto.
2922
2923         Don't cache the explicit "value" attribute on the HTMLLIElement,
2924         but fetch it with fastGetAttribute when needed.
2925         This shrinks HTMLLIElement by one CPU word.
2926
2927         * html/HTMLLIElement.cpp:
2928         (WebCore::HTMLLIElement::HTMLLIElement):
2929         (WebCore::HTMLLIElement::parseMappedAttribute):
2930         (WebCore::HTMLLIElement::attach):
2931         * html/HTMLLIElement.h:
2932
2933 2011-10-03  Vsevolod Vlasov  <vsevik@chromium.org>
2934
2935         Web Inspector: Add support for backend search in script content.
2936         https://bugs.webkit.org/show_bug.cgi?id=69015
2937
2938         Reviewed by Pavel Feldman.
2939
2940         Tests: http/tests/inspector/search/search-in-concatenated-script.html
2941                http/tests/inspector/search/search-in-script.html
2942
2943         * inspector/Inspector.json:
2944         * inspector/InspectorDebuggerAgent.cpp:
2945         (WebCore::InspectorDebuggerAgent::searchInContent):
2946         (WebCore::InspectorDebuggerAgent::getScriptSource):
2947         * inspector/InspectorDebuggerAgent.h:
2948         * inspector/front-end/ContentProviders.js:
2949         (WebInspector.ScriptContentProvider.prototype.requestContent):
2950         (WebInspector.ScriptContentProvider.prototype.searchInContent):
2951         (WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.maybeCallback):
2952         (WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.searchCallback):
2953         (WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent):
2954         * inspector/front-end/Script.js:
2955         (WebInspector.Script.prototype.requestSource):
2956         (WebInspector.Script.prototype.searchInContent):
2957
2958 2011-10-03  Pavel Feldman  <pfeldman@google.com>
2959
2960         Web Inspector: move console message formatting from ConsoleView.js into ConsoleMessage.js
2961         https://bugs.webkit.org/show_bug.cgi?id=69244
2962
2963         Reviewed by Yury Semikhatsky.
2964
2965         * inspector/front-end/ConsoleMessage.js:
2966         (WebInspector.ConsoleMessage):
2967         (WebInspector.ConsoleMessage.prototype._formatMessage.else.else.linkifier):
2968         (WebInspector.ConsoleMessage.prototype._formatMessage):
2969         (WebInspector.ConsoleMessage.prototype._format):
2970         (WebInspector.ConsoleMessage.prototype._formatParameter):
2971         (WebInspector.ConsoleMessage.prototype._formatParameterAsValue):
2972         (WebInspector.ConsoleMessage.prototype._formatParameterAsObject):
2973         (WebInspector.ConsoleMessage.prototype._formatParameterAsNode):
2974         (WebInspector.ConsoleMessage.prototype._formatParameterAsArray):
2975         (WebInspector.ConsoleMessage.prototype._formatParameterAsString):
2976         (WebInspector.ConsoleMessage.prototype._printArray):
2977         (WebInspector.ConsoleMessage.prototype._formatAsArrayEntry):
2978         (WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString):
2979         * inspector/front-end/ConsoleView.js:
2980
2981 2011-10-03  Pavel Feldman  <pfeldman@chromium.org>
2982
2983         Web Inspector: restore partial front-end compilability
2984         https://bugs.webkit.org/show_bug.cgi?id=69221
2985
2986         Removed unused isWhitespace; introduced missing classes in Inspector.json;
2987         generated externs for the protocol types along with the commands.
2988
2989         Reviewed by Yury Semikhatsky.
2990
2991         * inspector/Inspector.json:
2992         * inspector/compile-front-end.sh:
2993         * inspector/front-end/DOMAgent.js:
2994         (WebInspector.DOMAgent):
2995         (WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable.onDocumentAvailable):
2996         (WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable):
2997         * inspector/front-end/ElementsPanel.js:
2998         (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
2999         * inspector/front-end/ElementsTreeOutline.js:
3000         ():
3001         * inspector/front-end/Object.js:
3002         * inspector/front-end/Popover.js:
3003         (WebInspector.PopoverHelper.prototype._mouseMove):
3004         * inspector/front-end/View.js:
3005         * inspector/front-end/externs.js:
3006         (Array.prototype.remove):
3007         * inspector/generate-protocol-externs:
3008
3009 2011-10-02  Kent Tamura  <tkent@chromium.org>
3010
3011         method/enctype/formMethod/formEnctype properties should be limited to known values.
3012         https://bugs.webkit.org/show_bug.cgi?id=68887
3013
3014         Reviewed by Hajime Morita.
3015
3016         According to the standard and other browser behaviors, the
3017         following IDL properties should be reflected to the corresponding
3018         HTML attributes on setting, but should return normalized values on
3019         getting.
3020         - HTMLFormElement::method
3021         - HTMLFormElement::enctype
3022         - HTMLInputElement::formMethod
3023         - HTMLInputElement::formEnctype
3024         - HTMLButtonElement::formMethod
3025         - HTMLButtonElement::formEnctype
3026
3027         Tests: fast/forms/enctype-attribute.html
3028                fast/forms/method-attribute.html
3029
3030         * html/HTMLButtonElement.idl:
3031         Replace 'Reflect' with 'ConvertNullToNullString' in order to use a
3032         getter function.
3033         * html/HTMLFormControlElement.cpp:
3034         (WebCore::HTMLFormControlElement::formEnctype):
3035         Normalizes the value by parseEncodingType().
3036         (WebCore::HTMLFormControlElement::setFormEnctype):
3037         Simply calls setAttribute()
3038         (WebCore::HTMLFormControlElement::formMethod):
3039         Normalizes the value by parseMethodType().
3040         (WebCore::HTMLFormControlElement::setFormMethod):
3041         Simply calls setAttribute()
3042         * html/HTMLFormControlElement.h:
3043         * html/HTMLFormElement.cpp:
3044         (WebCore::HTMLFormElement::parseMappedAttribute):
3045         Follow the Attributes function renaming.
3046         (WebCore::HTMLFormElement::method):
3047         Normalizes the value by parseMethodType().
3048         * html/HTMLFormElement.idl:
3049         Replace 'Reflect' with 'ConvertNullToNullString' in order to use a
3050         getter function.
3051         * html/HTMLInputElement.idl: ditto.
3052         * loader/FormSubmission.cpp:
3053         (WebCore::FormSubmission::Attributes::parseEncodingType):
3054         New function made from a part of old parseEncodingType().
3055         (WebCore::FormSubmission::Attributes::updateEncodingType):
3056         Renamed from parseEncodingType().
3057         (WebCore::FormSubmission::Attributes::parseMethodType):
3058         New function made from a part of old parseMethodType().
3059         (WebCore::FormSubmission::Attributes::updateMethodType):
3060         Renamed from parseMethodType().
3061         (WebCore::FormSubmission::create):
3062         Follow the Attributes function renaming.
3063         * loader/FormSubmission.h:
3064         (WebCore::FormSubmission::Attributes::methodString):
3065         A helper function to provide normalized strings for FormSubmission::Method.
3066
3067 2011-10-02  Sam Weinig  <sam@webkit.org>
3068
3069         Strength reduce Mac only Frame::searchForLabelsBeforeElement and Frame::matchLabelsAgainstElement into callers
3070         https://bugs.webkit.org/show_bug.cgi?id=69230
3071
3072         Reviewed by Anders Carlsson.
3073
3074         * WebCore.exp.in:
3075         * page/Frame.h:
3076         * page/mac/FrameMac.mm:
3077
3078 2011-10-02  Zeno Albisser  <zeno.albisser@nokia.com>
3079
3080         [Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch.
3081         https://bugs.webkit.org/show_bug.cgi?id=69223
3082
3083         Add a missing import (NSWindow.h) in WebVideoFullscreenHUDWindowController.
3084         Add a missing include path and a missing objective source file to WebCore.pro.
3085
3086         Reviewed by Noam Rosenthal.
3087
3088         No new tests, build fix.
3089
3090         * WebCore.pro:
3091         * platform/mac/WebVideoFullscreenHUDWindowController.h:
3092
3093 2011-10-02  Julien Chaffraix  <jchaffraix@webkit.org>
3094
3095         Remove an unused member in RenderTable::ColumnStruct
3096         https://bugs.webkit.org/show_bug.cgi?id=69119
3097
3098         Reviewed by Darin Adler.
3099
3100         No test as there should be no change in behavior.
3101
3102         The member was added several years ago and its users were removed or changed. The code would
3103         need a refactoring but this would be tricky to get right. This change just removes the member
3104         to reap the short-term benefits.
3105
3106         * rendering/RenderTable.h:
3107         (WebCore::RenderTable::ColumnStruct::ColumnStruct): Remove anything associated with m_width.
3108
3109 2011-10-02  Dan Bernstein  <mitz@apple.com>
3110
3111         REGRESSION (r95502): Assertion failure in CSSPrimitiveValue::computeLengthDouble() when media query specifies unit-less length
3112         https://bugs.webkit.org/show_bug.cgi?id=68760
3113
3114         Reviewed by Antti Koivisto.
3115
3116         Test: fast/media/invalid-lengths.html
3117
3118         Made length-comparison media queries accept only length values. In compatibility mode, numbers
3119         are allowed as well, and they are interpreted as pixels.
3120
3121         * css/MediaQueryEvaluator.cpp:
3122         (WebCore::computeLength): Added this helper function.
3123         (WebCore::device_heightMediaFeatureEval): Changed to use computeLength().
3124         (WebCore::device_widthMediaFeatureEval): Ditto.
3125         (WebCore::heightMediaFeatureEval): Ditto.
3126         (WebCore::widthMediaFeatureEval): Ditto.
3127
3128 2011-10-02  Dirk Schulze  <krit@webkit.org>
3129
3130         SVG Mask should take 'color-interpolation' into account to determine the color space of the mask image
3131         https://bugs.webkit.org/show_bug.cgi?id=69076
3132
3133         Reviewed by Simon Fraser.
3134         
3135         SVG Masks should take 'color-interpolation' into account to determine the color space of the mask image.
3136         The behavior was changed in SVG 1.1 SE. The color space of the mask image gets defined by the computed value of the
3137         'color-interpolation' property. This will switch the default color space from linearRGB to sRGB for mask images and
3138         is a performance improvement for platforms without native support for linearRGB color space. The
3139         color space transformation can be avoided.
3140
3141         Test: svg/custom/grayscale-gradient-mask-2.svg
3142
3143         * rendering/svg/RenderSVGResourceMasker.cpp:
3144         (WebCore::RenderSVGResourceMasker::applyResource):
3145         (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
3146         * rendering/svg/RenderSVGResourceMasker.h:
3147
3148 2011-10-01  Vangelis Kokkevis  <vangelis@chromium.org>
3149
3150         [chromium] Fixing draw matrix for composited layers. This
3151         was a regression introduced by:
3152         http://trac.webkit.org/changeset/96454
3153
3154         https://bugs.webkit.org/show_bug.cgi?id=69217
3155
3156         Reviewed by James Robinson.
3157
3158         Tests: compositor test now pass
3159
3160         * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
3161         (WebCore::CCTiledLayerImpl::draw):
3162         * platform/graphics/chromium/cc/CCTiledLayerImpl.h:
3163
3164 2011-10-01  Geoffrey Garen  <ggaren@apple.com>
3165
3166         Removed redundant helper functions for allocating Strong handles
3167         https://bugs.webkit.org/show_bug.cgi?id=69218
3168
3169         Reviewed by Sam Weinig.
3170
3171         * ForwardingHeaders/heap/StrongInlines.h: Added.
3172         * bindings/js/JSCallbackData.h:
3173         * bindings/js/JSDOMWindowShell.cpp:
3174         * bindings/js/ScheduledAction.h:
3175         * bindings/js/ScriptCachedFrameData.cpp:
3176         * bindings/js/ScriptController.cpp:
3177         * bindings/js/ScriptState.cpp:
3178         * bindings/js/ScriptValue.h:
3179         * bindings/js/WorkerScriptController.cpp:
3180         * bridge/runtime_root.cpp:
3181
3182 2011-10-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3183
3184         Unreviewed, rolling out r96421.
3185         http://trac.webkit.org/changeset/96421
3186         https://bugs.webkit.org/show_bug.cgi?id=69206
3187
3188         It broke Qt-WK2 build (Requested by ossy on #webkit).
3189
3190         * WebCore.pro:
3191
3192 2011-09-30  Adrienne Walker  <enne@google.com>
3193
3194         [chromium] Track separate scroll deltas on the compositor thread
3195         https://bugs.webkit.org/show_bug.cgi?id=69034
3196
3197         Reviewed by James Robinson.
3198
3199         Test: new tests in CCLayerTreeHostImplTest/CCLayerTreeHostTest
3200
3201         Track scroll deltas and maximum scrolls on LayerChromium/CCLayerImpl.
3202         The CCLayerImpl tree is now able to adjust these scroll deltas
3203         independent of the main thread. To push them back to the main thread,
3204         CCLayerTreeHostImpl collects them all and then bakes them into the
3205         scroll position during a begin frame and commit call. This allows new
3206         deltas to be collected while the scroll position containing the old
3207         delta and the old scroll position will be overwritten during the next
3208         commit.
3209
3210         Only the main frame is supported right now for pushing this scroll
3211         delta back into the authoritative WebKit source to keep both sides in
3212         sync.
3213
3214         Move tilingTransform() to the impl tree because drawTransform() is now
3215         updated using scroll deltas and so the results from calculating draw
3216         transforms needs to be dynamic so that children are updated properly.
3217
3218         Also, exposed DebugScopedSetImplThread public because it's used in a
3219         few places.
3220
3221         * platform/graphics/chromium/LayerChromium.cpp:
3222         (WebCore::LayerChromium::pushPropertiesTo):
3223         * platform/graphics/chromium/LayerChromium.h:
3224         (WebCore::LayerChromium::maxScrollPosition):
3225         (WebCore::LayerChromium::setMaxScrollPosition):
3226         (WebCore::LayerChromium::scrollDelta):
3227         (WebCore::LayerChromium::scrollable):
3228         * platform/graphics/chromium/NonCompositedContentHost.cpp:
3229         (WebCore::NonCompositedContentHost::setViewport):
3230         * platform/graphics/chromium/TiledLayerChromium.cpp:
3231         (WebCore::TiledLayerChromium::pushPropertiesTo):
3232         * platform/graphics/chromium/TiledLayerChromium.h:
3233         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
3234         (WebCore::CCLayerImpl::scrollBy):
3235         * platform/graphics/chromium/cc/CCLayerImpl.h:
3236         (WebCore::CCLayerImpl::maxScrollPosition):
3237         (WebCore::CCLayerImpl::setMaxScrollPosition):
3238         (WebCore::CCLayerImpl::scrollDelta):
3239         (WebCore::CCLayerImpl::setScrollDelta):
3240         (WebCore::CCLayerImpl::scrollable):
3241         * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
3242         (WebCore::CCLayerTreeHost::applyScrollDeltas):
3243         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
3244         * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
3245         (WebCore::calculateDrawTransformsAndVisibilityInternal):
3246         * platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
3247         * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
3248         (WebCore::CCLayerTreeHostImpl::scrollRootLayer):
3249         (WebCore::CCLayerTreeHostImpl::processScrollDeltas):
3250         * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
3251         * platform/graphics/chromium/cc/CCProxy.h:
3252         * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
3253         (WebCore::CCSingleThreadProxy::start):
3254         (WebCore::CCSingleThreadProxy::context):
3255         (WebCore::CCSingleThreadProxy::finishAllRendering):
3256         (WebCore::CCSingleThreadProxy::initializeLayerRenderer):
3257         (WebCore::CCSingleThreadProxy::setNeedsCommit):
3258         (WebCore::CCSingleThreadProxy::stop):
3259         (WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
3260         (WebCore::CCSingleThreadProxy::commitIfNeeded):
3261         (WebCore::CCSingleThreadProxy::doComposite):
3262         * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
3263         (WebCore::DebugScopedSetImplThread::DebugScopedSetImplThread):
3264         (WebCore::DebugScopedSetImplThread::~DebugScopedSetImplThread):
3265         * platform/graphics/chromium/cc/CCThreadProxy.cpp:
3266         (WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
3267         (WebCore::CCThreadProxy::beginFrameAndCommit):
3268         * platform/graphics/chromium/cc/CCThreadProxy.h:
3269         * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
3270         (WebCore::CCTiledLayerImpl::tilingTransform):
3271         (WebCore::CCTiledLayerImpl::draw):
3272         * platform/graphics/chromium/cc/CCTiledLayerImpl.h:
3273
3274 2011-09-30  David Hyatt  <hyatt@apple.com>
3275
3276         https://bugs.webkit.org/show_bug.cgi?id=69202
3277         
3278         [CSS3 Regions] Make positioned objects use the first region as the ICB when it
3279         is their containing block. Make sure static distance computations take into
3280         account the current region as well.
3281
3282         Reviewed by Sam Weinig.
3283
3284         Added new tests in fast/regions.
3285
3286         * rendering/RenderBlock.cpp:
3287         (WebCore::RenderBlock::adjustPositionedBlock):
3288         * rendering/RenderBlock.h:
3289         (WebCore::RenderBlock::startOffsetForContent):
3290         * rendering/RenderBox.cpp:
3291         (WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
3292         (WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
3293         (WebCore::computeInlineStaticDistance):
3294         (WebCore::computeLogicalLeftPositionedOffset):
3295         (WebCore::computeLogicalTopPositionedOffset):
3296         * rendering/RenderFlowThread.cpp:
3297         (WebCore::RenderFlowThread::contentLogicalWidthOfFirstRegion):
3298         (WebCore::RenderFlowThread::contentLogicalHeightOfFirstRegion):
3299         (WebCore::RenderFlowThread::contentLogicalLeftOfFirstRegion):
3300         * rendering/RenderFlowThread.h:
3301
3302 2011-09-30  David Barr  <davidbarr@chromium.org>
3303
3304         Implement currentColor support for CSS gradients
3305         https://bugs.webkit.org/show_bug.cgi?id=58730
3306
3307         Reviewed by Adam Barth.
3308
3309         Allow currentColor as a CSS3 gradient color-stop.
3310
3311         Test: fast/css/linear-gradient-currentcolor.html
3312
3313         * css/CSSGradientValue.cpp:
3314         (WebCore::CSSGradientValue::isCacheable): Make currentColor uncacheable since the
3315         background image may be invalidated if currentColor is used as a gradient stop and
3316         the value of the 'color' property changes.
3317         * css/CSSParser.cpp:
3318         (WebCore::parseGradientColorOrKeyword): Accept the currentColor keyword.
3319         * rendering/style/StyleGeneratedImage.cpp:
3320         (WebCore::StyleGeneratedImage::image): Initialize document styleSelector so that
3321         currentColor may be computed for a StyleGeneratedImage.
3322
3323 2011-09-30  Gavin Barraclough  <barraclough@apple.com>
3324
3325         Remove toStrictThisObject, toThisString, toThisJSString
3326         https://bugs.webkit.org/show_bug.cgi?id=69203
3327
3328         Rubber stamped by Sam Weinig
3329
3330         These are no longer used.
3331
3332         * bindings/js/JSDOMWindowBase.cpp:
3333         * bindings/js/JSDOMWindowBase.h:
3334
3335 2011-09-30  Adam Barth  <abarth@webkit.org>
3336
3337         Remove ASSERT introduced in http://trac.webkit.org/changeset/96427
3338         which is triggering all over the place.
3339
3340         Sorting this out is covered in this bug:
3341         https://bugs.webkit.org/show_bug.cgi?id=69200
3342
3343         * rendering/RenderView.cpp:
3344         (WebCore::RenderView::layout):
3345
3346 2011-09-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3347
3348         Unreviewed, rolling out r96426.
3349         http://trac.webkit.org/changeset/96426
3350         https://bugs.webkit.org/show_bug.cgi?id=69199
3351
3352         Broke a zillion image results on Chromium Skia Mac (Requested
3353         by abarth|gardener on #webkit).
3354
3355         * platform/graphics/skia/GraphicsContextSkia.cpp:
3356         (WebCore::getFocusRingOutset):
3357         (WebCore::GraphicsContext::drawFocusRing):
3358
3359 2011-09-30  Ilya Sherman  <isherman@chromium.org>
3360
3361         Fix assertion failure in XSS Auditor
3362         https://bugs.webkit.org/show_bug.cgi?id=69050
3363         https://code.google.com/p/chromium/issues/detail?id=97346
3364
3365         Reviewed by Daniel Bates.
3366
3367         Test: fast/forms/xss-auditor-doesnt-crash.html
3368
3369         * html/parser/XSSAuditor.cpp:
3370         (WebCore::XSSAuditor::init): Don't try to decode the HTML body if it is empty.
3371
3372 2011-09-30  Maciej Stachowiak  <mjs@apple.com>
3373
3374         Loading page on potterybankids causes reproducible assertion failure in debug builds
3375         https://bugs.webkit.org/show_bug.cgi?id=69185
3376         <rdar://problem/10218241>
3377
3378         Reviewed by Simon Fraser.
3379
3380         * rendering/RenderLayer.cpp:
3381         (WebCore::RenderLayer::computeRepaintRects): Remove assert condition that isn't guaranteed
3382         to be true.
3383
3384 2011-09-30  Johnny Ding  <jnd@chromium.org>
3385
3386         Support -webkit-tap-highlight-color when enabling touch events support.
3387         https://bugs.webkit.org/show_bug.cgi?id=48544
3388
3389         Reviewed by Kenneth Rohde Christiansen.
3390
3391         Original code from the iOS WebCore code dump, extracted and modified by tijiang@rim and jnd@chromium.
3392         Supports the new CSS property -webkit-tap-highlight-color on platforms which support touch events.
3393         Platform can override WebCore::RenderTheme::platformTapHighlightColor to use its own platform
3394         specific default tap highlight color. Otherwise RenderTheme::defaultTapHighlightColor will be
3395         used as default tap highlight color.
3396
3397         Test: fast/events/touch/tap-highlight-color.html
3398
3399         * css/CSSComputedStyleDeclaration.cpp:
3400         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3401         * css/CSSParser.cpp:
3402         (WebCore::CSSParser::parseValue):
3403         * css/CSSPropertyNames.in:
3404         * css/CSSStyleSelector.cpp:
3405         (WebCore::CSSStyleSelector::applyProperty):
3406         * rendering/RenderTheme.cpp:
3407         (WebCore::RenderTheme::tapHighlightColor):
3408         * rendering/RenderTheme.h:
3409         (WebCore::RenderTheme::platformTapHighlightColor):
3410         * rendering/style/RenderStyle.cpp:
3411         (WebCore::RenderStyle::initialTapHighlightColor):
3412         * rendering/style/RenderStyle.h:
3413         (WebCore::InheritedFlags::tapHighlightColor):
3414         (WebCore::InheritedFlags::setTapHighlightColor):
3415         * rendering/style/StyleRareInheritedData.cpp:
3416         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3417         (WebCore::StyleRareInheritedData::operator==):
3418         * rendering/style/StyleRareInheritedData.h:
3419
3420 2011-09-30  David Hyatt  <hyatt@apple.com>
3421
3422         https://bugs.webkit.org/show_bug.cgi?id=69173
3423         
3424         RTL/LTR mixtures still not correct in regions. Simplify the loop once I realized it's only
3425         your directionality that matters and not your containing block's.
3426
3427         Reviewed by Dan Bernstein.
3428
3429         Added new test in fast/regions.
3430
3431         * rendering/RenderBox.cpp:
3432         (WebCore::RenderBox::borderBoxRectInRegion):
3433
3434 2011-09-30  Dan Bernstein  <mitz@apple.com>
3435
3436         <rdar://problem/10208291> first-letter in generated before content with display: table is not updated
3437
3438         Reviewed by Sam Weinig.
3439
3440         Test: fast/css-generated-content/first-letter-in-nested-before.html
3441
3442         * rendering/RenderObjectChildList.cpp:
3443         (WebCore::RenderObjectChildList::updateBeforeAfterContent): Preserve the style type of anonymous
3444         containers around the generated content when updating their style. This preserves the first-letter-ness
3445         of the inline wrapping the first letter, which allows updateFirstLetter() to identify it later.
3446
3447 2011-09-30  Cary Clark  <caryclark@google.com>
3448
3449         Inset focus ring (Skia on Mac)
3450         https://bugs.webkit.org/show_bug.cgi?id=69166
3451         http://code.google.com/p/chromium/issues/detail?id=97956
3452
3453         This focus ring was drawn too large and was left tracks
3454         in subsequent invalidations. Make it more closely match
3455         the CG version.
3456
3457         Reviewed by Stephen White.
3458
3459         No new tests. This platform is not enabled.
3460
3461         * platform/graphics/skia/GraphicsContextSkia.cpp:
3462         (WebCore::getFocusRingOutset):
3463         (WebCore::GraphicsContext::drawFocusRing):
3464
3465 2011-09-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3466