c12ec2e0eaf082e633ab7748a25d8d35480fb870
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2013-04-24  Otto Derek Cheung  <otcheung@rim.com>
2
3         Battery API won't return updated battery status until client calls didChangeBatteryStatus
4         https://bugs.webkit.org/show_bug.cgi?id=114891
5
6         Reviewed by Rob Buis.
7
8         The BatteryStatus object in BatteryManager won't get updated until BatteryClient calls
9         didChangeBatteryStatus in BatteryController. Any attempts to call webkitBattery.charged()
10         or other get functions will always return the default values until the next battery status
11         change object gets passed to the controller.
12
13         We need to update the manager when we attach it to the controller, and update all
14         existing managers when the controller receives it's first battery status object.
15
16         * Modules/battery/BatteryController.cpp:
17         (WebCore::BatteryController::addListener):
18         (WebCore::BatteryController::updateBatteryStatus):
19         * Modules/battery/BatteryManager.cpp:
20         (WebCore::BatteryManager::didChangeBatteryStatus):
21         (WebCore::BatteryManager::updateBatteryStatus):
22         (WebCore):
23         * Modules/battery/BatteryManager.h:
24         (BatteryManager):
25
26 2013-04-24  Jacky Jiang  <zhajiang@blackberry.com>
27
28         Clean up unused code in ViewportArguments.h
29         https://bugs.webkit.org/show_bug.cgi?id=115121
30
31         Reviewed by Benjamin Poulain.
32
33         The target-densityDPI emulation implementation has been removed by
34         r147893, so clean up the remaining code as well.
35
36         * dom/ViewportArguments.h:
37
38 2013-04-24  Andreas Kling  <akling@apple.com>
39
40         ElementData should use 'unsigned' attribute indices.
41         <http://webkit.org/b/115103>
42
43         Reviewed by Antti Koivisto.
44
45         Switch to using 'unsigned' for attribute indices. This gives consistent behavior
46         on 32/64-bit, and the underlying storage is already limited by Vector's 32-bit capacity.
47
48         Added an ElementData::attributeNotFound constant (-1) since we can't use WTF::notFound.
49
50         * dom/Element.cpp:
51         (WebCore::Element::detachAttribute):
52         (WebCore::Element::removeAttribute):
53         (WebCore::Element::setAttribute):
54         (WebCore::Element::setSynchronizedLazyAttribute):
55         (WebCore::Element::setAttributeInternal):
56         (WebCore::Element::setAttributeNode):
57         (WebCore::Element::removeAttributeNode):
58         (WebCore::Element::removeAttributeInternal):
59         (WebCore::UniqueElementData::removeAttribute):
60         (WebCore::ElementData::getAttributeItemIndexSlowCase):
61         * dom/Element.h:
62         (ElementData):
63         (UniqueElementData):
64         (Element):
65         (WebCore::Element::getAttributeItemIndex):
66         (WebCore::Element::attributeCount):
67         (WebCore::ElementData::length):
68         (WebCore::ElementData::getAttributeItem):
69         (WebCore::ElementData::getAttributeItemIndex):
70         * dom/NamedNodeMap.cpp:
71         (WebCore::NamedNodeMap::removeNamedItem):
72         (WebCore::NamedNodeMap::removeNamedItemNS):
73         (WebCore::NamedNodeMap::length):
74         * dom/NamedNodeMap.h:
75         (NamedNodeMap):
76
77 2013-04-24  Andreas Kling  <akling@apple.com>
78
79         ElementData::attributeItem() should bounds-check the index.
80         <http://webkit.org/b/115076>
81
82         Reviewed by Antti Koivisto.
83
84         Switch the ASSERT_WITH_SECURITY_IMPLICATION to a RELEASE_ASSERT.
85
86         * dom/Element.h:
87         (WebCore::ElementData::attributeItem):
88
89 2013-04-23  Andreas Kling  <akling@apple.com>
90
91         Setting an inline style property to "" shouldn't cause style recalc unless the property was present.
92         <http://webkit.org/b/115122>
93
94         Reviewed by Antti Koivisto.
95
96         StylePropertySet::setProperty() handles empty strings by removing the property entirely.
97         If there was no property to remove, it shouldn't claim that it changed something, as that
98         will cause the CSSOM wrapper to mark the element for style recalc.
99
100         A common idiom that triggers this is excessive use of { element.style.display = ''; }
101
102         * css/StylePropertySet.cpp:
103         (WebCore::MutableStylePropertySet::setProperty):
104
105 2013-04-23  Ryosuke Niwa  <rniwa@webkit.org>
106
107         Moving word boundaries backwards fails when there is a text node starting with an apostrophe
108         https://bugs.webkit.org/show_bug.cgi?id=115070
109
110         Reviewed by Alexey Proskuryakov.
111
112         The bug was caused by previousBoundary erroneously assuming that we don't need any more context if a word
113         boundary is found at the beginning of a string. For example, when "I'll" is split into two text nodes,
114         "I" and "'ll", there is a word boundary between "'" and "ll" in "'ll" so we need to examine the whole "I'll".
115
116         Fixed the bug by obtaining more context when the character starts exactly at offset 1 in a text node to
117         work around this bug. In the long term, we probably need to provide Foundation of the entire context since in
118         languages like Hebrew and some of European languages, there could be many accents and combining characters
119         between split into multiple text nodes as one variant is seen in the newly added test case.
120
121         Test: editing/selection/previous-word-boundary-across-text-nodes.html
122
123         * editing/VisibleUnits.cpp:
124         (WebCore::previousBoundary):
125
126 2013-04-24  Benjamin Poulain  <bpoulain@apple.com>
127
128         Do not use static string in DiagnosticLoggingKeys
129         https://bugs.webkit.org/show_bug.cgi?id=115093
130
131         Reviewed by Andreas Kling.
132
133         The code is not hot enough to justify keeping the memory around.
134         This removes 3kb from the binary on x86_64.
135
136         * page/DiagnosticLoggingKeys.cpp:
137         (WebCore::DiagnosticLoggingKeys::mediaLoadedKey):
138         (WebCore::DiagnosticLoggingKeys::mediaLoadingFailedKey):
139         (WebCore::DiagnosticLoggingKeys::pluginLoadedKey):
140         (WebCore::DiagnosticLoggingKeys::pluginLoadingFailedKey):
141         (WebCore::DiagnosticLoggingKeys::pageContainsPluginKey):
142         (WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOnePluginKey):
143         (WebCore::DiagnosticLoggingKeys::pageContainsMediaEngineKey):
144         (WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOneMediaEngineKey):
145         (WebCore::DiagnosticLoggingKeys::passKey):
146         (WebCore::DiagnosticLoggingKeys::failKey):
147         (WebCore::DiagnosticLoggingKeys::noopKey):
148         * page/DiagnosticLoggingKeys.h:
149         (DiagnosticLoggingKeys):
150
151 2013-04-24  Benjamin Poulain  <benjamin@webkit.org>
152
153         Remove wxWebKit #ifdefs from WebCore/platform/graphics
154         https://bugs.webkit.org/show_bug.cgi?id=115081
155
156         Reviewed by Geoffrey Garen.
157
158         * platform/graphics/BitmapImage.h:
159         (BitmapImage):
160         * platform/graphics/Color.h:
161         (Color):
162         * platform/graphics/FloatRect.h:
163         (FloatRect):
164         * platform/graphics/FloatSize.h:
165         (FloatSize):
166         * platform/graphics/FontPlatformData.h:
167         * platform/graphics/GlyphBuffer.h:
168         (WebCore):
169         (WebCore::GlyphBuffer::glyphAt):
170         (WebCore::GlyphBuffer::add):
171         * platform/graphics/Gradient.h:
172         * platform/graphics/GraphicsContext.h:
173         (GraphicsContext):
174         * platform/graphics/Image.cpp:
175         (WebCore::Image::drawTiled):
176         * platform/graphics/ImageBufferData.h:
177         * platform/graphics/IntPoint.h:
178         (IntPoint):
179         * platform/graphics/IntRect.h:
180         * platform/graphics/IntSize.h:
181         (IntSize):
182         * platform/graphics/NativeImagePtr.h:
183         (WebCore):
184         * platform/graphics/Path.h:
185         * platform/graphics/Pattern.h:
186         * platform/graphics/SimpleFontData.h:
187         (SimpleFontData):
188         (WebCore::SimpleFontData::widthForGlyph):
189         * platform/graphics/mac/ComplexTextController.cpp:
190         (WebCore::ComplexTextController::collectComplexTextRuns):
191         * platform/graphics/mac/ComplexTextControllerCoreText.mm:
192         (WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
193         * platform/graphics/transforms/AffineTransform.h:
194         (AffineTransform):
195         * platform/graphics/transforms/TransformationMatrix.h:
196         (TransformationMatrix):
197
198 2013-04-24  Benjamin Poulain  <benjamin@webkit.org>
199
200         Remove wxWebKit #ifdefs from WebCore/plugins
201         https://bugs.webkit.org/show_bug.cgi?id=115080
202
203         Reviewed by Geoffrey Garen.
204
205         * plugins/PluginView.h:
206         (PluginView):
207         * plugins/mac/PluginViewMac.mm:
208         (WebCore::nativeWindowFor):
209         (WebCore::cgHandleFor):
210         (WebCore::topLevelOffsetFor):
211         (WebCore::PluginView::platformStart):
212         * plugins/win/PluginViewWin.cpp:
213         (windowHandleForPageClient):
214         (WebCore::PluginView::handleMouseEvent):
215         (WebCore::PluginView::platformStart):
216         (WebCore::PluginView::snapshot):
217
218 2013-04-24  Benjamin Poulain  <benjamin@webkit.org>
219
220         Remove wxWebKit #ifdefs from WebCore/page
221         https://bugs.webkit.org/show_bug.cgi?id=115079
222
223         Reviewed by Geoffrey Garen.
224
225         * page/FrameView.cpp:
226         (WebCore::FrameView::wheelEvent):
227         * page/Settings.cpp:
228         (WebCore):
229         * page/Settings.h:
230         (Settings):
231
232 2013-04-24  Chris Fleizach  <cfleizach@apple.com>
233
234         AX: WAI-ARIA landmarks no longer speak type of landmark on iOS
235         https://bugs.webkit.org/show_bug.cgi?id=114547
236
237         Reviewed by David Kilzer.
238
239         We want iOS to speak the landmark type.
240         I've moved the landmark role description to the base Mac class and exposed
241         these localized strings to iOS (the ones used to return landmark descriptions).
242
243         I've also updated the accessibilityLabel to account for landmark type, but also
244         handle multiple label sources more gracefully by appending commas, which changed a few
245         tests in minor ways.
246
247         Test: platform/iphone-simulator/accessibility/landmark-type.html
248
249         * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
250         (-[WebAccessibilityObjectWrapper accessibilityLabel]):
251         * accessibility/mac/WebAccessibilityObjectWrapperBase.h:
252         * accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
253         (-[WebAccessibilityObjectWrapperBase ariaLandmarkRoleDescription]):
254         * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
255         (-[WebAccessibilityObjectWrapper roleDescription]):
256         * platform/LocalizedStrings.cpp:
257         (WebCore):
258         (WebCore::AXButtonActionVerb):
259         (WebCore::AXRadioButtonActionVerb):
260         (WebCore::AXTextFieldActionVerb):
261         (WebCore::AXCheckedCheckBoxActionVerb):
262         (WebCore::AXUncheckedCheckBoxActionVerb):
263         (WebCore::AXLinkActionVerb):
264         (WebCore::AXMenuListPopupActionVerb):
265         (WebCore::AXMenuListActionVerb):
266         * platform/LocalizedStrings.h:
267         (WebCore):
268
269 2013-04-24  Andreas Kling  <akling@apple.com>
270
271         CSS attribute selectors cause unnecessary style recalc when setting attribute to same value.
272         <http://webkit.org/b/115116>
273         <rdar://problem/13727709>
274
275         Reviewed by Simon Fraser.
276
277         The logic that dirties the style if there's a relevant attribute selector in the document
278         shouldn't run if the attribute is being overwritten with an identical value.
279         Move this into willModifyAttribute() instead, since we need access to both the old and the new value.
280
281         This reduces unnecessary style recalculation in Mac App Store content.
282
283         * dom/Element.cpp:
284         (WebCore::Element::attributeChanged):
285         (WebCore::Element::willModifyAttribute):
286
287 2013-04-24  Jonathan Feldstein <jfeldstein@blackberry.com>
288
289         [BlackBerry] Fixes the San Angeles demo on khronos.org
290         https://bugs.webkit.org/show_bug.cgi?id=115106
291
292         Reviewed by Rob Buis
293         Internally Reviewed by Jeremy Nicholl and Arvid Nilsson
294
295         Fixes a bug in which the currently bound vertex array object's vertex array
296         state was being modified as opposed to the default vertex array state.
297
298         * platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:
299         (EGLImageLayerWebKitThread::blitToFrontBuffer):
300
301 2013-04-24  Nico Weber  <thakis@chromium.org>
302
303         Fold RenderThemeMacShared into RenderThemeMac
304         https://bugs.webkit.org/show_bug.cgi?id=115086
305
306         Reviewed by Anders Carlsson.
307
308         No intended functionality change.
309
310         * WebCore.xcodeproj/project.pbxproj:
311         * rendering/RenderThemeMac.h:
312         (RenderThemeMac):
313         (WebCore::RenderThemeMac::supportsControlTints):
314         (WebCore::RenderThemeMac::scrollbarControlSizeForPart):
315         (WebCore::RenderThemeMac::supportsSelectionForegroundColors):
316         (WebCore::RenderThemeMac::supportsClosedCaptioning):
317         (WebCore::RenderThemeMac::updateActiveState):
318         * rendering/RenderThemeMac.mm:
319         (-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
320         (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]):
321         (-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:]):
322         (WebCore::RenderThemeMac::RenderThemeMac):
323         (WebCore::RenderThemeMac::~RenderThemeMac):
324         (WebCore::RenderThemeMac::platformActiveSelectionBackgroundColor):
325         (WebCore):
326         (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor):
327         (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor):
328         (WebCore::RenderThemeMac::platformActiveListBoxSelectionForegroundColor):
329         (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor):
330         (WebCore::RenderThemeMac::platformFocusRingColor):
331         (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):
332         (WebCore::toFontWeight):
333         (WebCore::RenderThemeMac::systemFont):
334         (WebCore::convertNSColorToColor):
335         (WebCore::menuBackgroundColor):
336         (WebCore::RenderThemeMac::platformColorsDidChange):
337         (WebCore::RenderThemeMac::systemColor):
338         (WebCore::RenderThemeMac::usesTestModeFocusRingColor):
339         (WebCore::RenderThemeMac::isControlStyled):
340         (WebCore::RenderThemeMac::adjustRepaintRect):
341         (WebCore::RenderThemeMac::inflateRect):
342         (WebCore::RenderThemeMac::convertToPaintingRect):
343         (WebCore::RenderThemeMac::updateCheckedState):
344         (WebCore::RenderThemeMac::updateEnabledState):
345         (WebCore::RenderThemeMac::updateFocusedState):
346         (WebCore::RenderThemeMac::updatePressedState):
347         (WebCore::RenderThemeMac::controlSupportsTints):
348         (WebCore::RenderThemeMac::controlSizeForFont):
349         (WebCore::RenderThemeMac::setControlSize):
350         (WebCore::RenderThemeMac::sizeForFont):
351         (WebCore::RenderThemeMac::sizeForSystemFont):
352         (WebCore::RenderThemeMac::setSizeFromFont):
353         (WebCore::RenderThemeMac::setFontFromControlSize):
354         (WebCore::RenderThemeMac::controlSizeForSystemFont):
355         (WebCore::RenderThemeMac::paintTextField):
356         (WebCore::RenderThemeMac::adjustTextFieldStyle):
357         (WebCore::RenderThemeMac::paintCapsLockIndicator):
358         (WebCore::RenderThemeMac::paintTextArea):
359         (WebCore::RenderThemeMac::adjustTextAreaStyle):
360         (WebCore::RenderThemeMac::popupButtonMargins):
361         (WebCore::RenderThemeMac::popupButtonSizes):
362         (WebCore::RenderThemeMac::popupButtonPadding):
363         (WebCore::RenderThemeMac::paintMenuList):
364         (WebCore::RenderThemeMac::meterSizeForBounds):
365         (WebCore::RenderThemeMac::paintMeter):
366         (WebCore::RenderThemeMac::supportsMeter):
367         (WebCore::RenderThemeMac::levelIndicatorStyleFor):
368         (WebCore::RenderThemeMac::levelIndicatorFor):
369         (WebCore::RenderThemeMac::progressBarSizes):
370         (WebCore::RenderThemeMac::progressBarMargins):
371         (WebCore::RenderThemeMac::minimumProgressBarHeight):
372         (WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar):
373         (WebCore::RenderThemeMac::animationDurationForProgressBar):
374         (WebCore::RenderThemeMac::adjustProgressBarStyle):
375         (WebCore::RenderThemeMac::paintProgressBar):
376         (WebCore::TopGradientInterpolate):
377         (WebCore::BottomGradientInterpolate):
378         (WebCore::MainGradientInterpolate):
379         (WebCore::TrackGradientInterpolate):
380         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
381         (WebCore::RenderThemeMac::paintMenuListButton):
382         (WebCore::menuListButtonSizes):
383         (WebCore::RenderThemeMac::adjustMenuListStyle):
384         (WebCore::RenderThemeMac::popupInternalPaddingLeft):
385         (WebCore::RenderThemeMac::popupInternalPaddingRight):
386         (WebCore::RenderThemeMac::popupInternalPaddingTop):
387         (WebCore::RenderThemeMac::popupInternalPaddingBottom):
388         (WebCore::RenderThemeMac::adjustMenuListButtonStyle):
389         (WebCore::RenderThemeMac::setPopupButtonCellState):
390         (WebCore::RenderThemeMac::menuListSizes):
391         (WebCore::RenderThemeMac::minimumMenuListSize):
392         (WebCore::RenderThemeMac::adjustSliderTrackStyle):
393         (WebCore::RenderThemeMac::paintSliderTrack):
394         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
395         (WebCore::RenderThemeMac::paintSliderThumb):
396         (WebCore::RenderThemeMac::paintSearchField):
397         (WebCore::RenderThemeMac::setSearchCellState):
398         (WebCore::RenderThemeMac::searchFieldSizes):
399         (WebCore::RenderThemeMac::setSearchFieldSize):
400         (WebCore::RenderThemeMac::adjustSearchFieldStyle):
401         (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
402         (WebCore::RenderThemeMac::cancelButtonSizes):
403         (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
404         (WebCore::RenderThemeMac::resultsButtonSizes):
405         (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
406         (WebCore::RenderThemeMac::paintSearchFieldDecoration):
407         (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
408         (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
409         (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
410         (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
411         (WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):
412         (WebCore::RenderThemeMac::sliderTickSize):
413         (WebCore::RenderThemeMac::sliderTickOffsetFromTrackCenter):
414         (WebCore::RenderThemeMac::adjustSliderThumbSize):
415         (WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):
416         (WebCore::RenderThemeMac::popupButton):
417         (WebCore::RenderThemeMac::search):
418         (WebCore::RenderThemeMac::searchMenuTemplate):
419         (WebCore::RenderThemeMac::sliderThumbHorizontal):
420         (WebCore::RenderThemeMac::sliderThumbVertical):
421         (WebCore::RenderThemeMac::textField):
422         (WebCore::RenderThemeMac::fileListNameForWidth):
423         * rendering/RenderThemeMacShared.h: Removed.
424         * rendering/RenderThemeMacShared.mm: Removed.
425
426 2013-04-24  ChangSeok Oh  <changseok.oh@collabora.com>
427
428         [GTK][AC] Visible rect doesn't update after resizing a window.
429         https://bugs.webkit.org/show_bug.cgi?id=115096
430
431         Reviewed by Gustavo Noronha Silva.
432
433         Once we set actor's a clip rect, we should update the rect when resizing the actor.
434
435         No new tests since no new functionality.
436
437         * platform/graphics/clutter/GraphicsLayerClutter.cpp:
438         (WebCore::GraphicsLayerClutter::setSize):
439
440 2013-04-24  ChangSeok Oh  <changseok.oh@collabora.com>
441
442         [GTK][AC] Fix unexpected clear of ClutterContent.
443         https://bugs.webkit.org/show_bug.cgi?id=115099
444
445         Reviewed by Gustavo Noronha Silva.
446
447         adoptGRef doesn't increase a reference count. So if a actor has a valid ClutterContent,
448         it would be cleared unexpectedly by smart pointer when escaping a function.
449
450         No new tests, no functionality changed.
451
452         * platform/graphics/clutter/GraphicsLayerActor.cpp:
453         (graphicsLayerActorUpdateTexture):
454
455 2013-04-24  Alberto Garcia  <agarcia@igalia.com>
456
457         DOMFileSystemBase: fix multiple definitions in the BlackBerry port
458         https://bugs.webkit.org/show_bug.cgi?id=114950
459
460         Reviewed by Xan Lopez.
461
462         The following  methods are already defined in DOMFileSystemBlackBerry.cpp:
463
464         crackFileSystemURL()
465         createFileSystemURL()
466         isValidType()
467         supportsToURL()
468
469         * Modules/filesystem/DOMFileSystemBase.cpp:
470         (WebCore):
471
472 2013-04-24  George Staikos  <gstaikos@rim.com>
473
474         [BlackBerry] Add support for JPEG image quality during encoding.
475         https://bugs.webkit.org/show_bug.cgi?id=105773
476
477         Reviewed by Xan Lopez.
478
479         PR 271611
480         Internally reviewed by Liam Quinn.
481
482         Pass the quality flag into the encoder, with a default of 65
483
484         Covered by existing tests.
485
486         * platform/image-encoders/JPEGImageEncoder.cpp:
487         (WebCore::compressRGBABigEndianToJPEG):
488         * platform/image-encoders/JPEGImageEncoder.h:
489         (WebCore):
490
491 2013-04-24  Csaba Osztrogon√°c  <ossy@webkit.org>
492
493         Fix cast-align WebCore/platform/graphics/GraphicsContext3D.cpp on ARM
494         https://bugs.webkit.org/show_bug.cgi?id=115036
495
496         Reviewed by Benjamin Poulain.
497
498         * platform/graphics/GraphicsContext3D.cpp:
499         (WebCore):
500
501 2013-04-24  Andreas Kling  <akling@apple.com>
502
503         Remove unnecessary MutableStylePropertySet casts.
504         <http://webkit.org/b/115075>
505
506         Reviewed by Geoffrey Garen.
507
508         Get rid of some now-unneeded static_casts that were left from the StylePropertySet
509         refactoring last weekend.
510
511         * css/StylePropertySet.cpp:
512         (WebCore::MutableStylePropertySet::setProperty):
513         * editing/EditingStyle.cpp:
514         (WebCore::EditingStyle::triStateOfStyle):
515         (WebCore::EditingStyle::removeStyleFromRulesAndContext):
516
517 2013-04-24  Kangil Han  <kangil.han@samsung.com>
518
519         [Minor code cleanup] Remove duplicated condition check
520         https://bugs.webkit.org/show_bug.cgi?id=115082
521
522         Reviewed by Andreas Kling.
523
524         areRectsPartiallyAligned() has duplicated condition check, so remove it.
525
526         * page/SpatialNavigation.cpp:
527         (WebCore::areRectsPartiallyAligned):
528
529 2013-04-24  Krzysztof Wolanski  <k.wolanski@samsung.com>
530
531         [EFL] Fix build warnings caused by missing images attributes for default buttons
532         https://bugs.webkit.org/show_bug.cgi?id=114955
533
534         Reviewed by Gyuyoung Kim.
535
536         Added default image for each button from mediacontrol catalog.
537
538         No new tests, because there is no change in behavior.
539
540         * platform/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc:
541         * platform/efl/DefaultTheme/widget/mediacontrol/mutebutton/mute_button.edc:
542         * platform/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playpause_button.edc:
543         * platform/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackward_button.edc:
544         * platform/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforward_button.edc:
545         * platform/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/toggle_captions_button.edc:
546
547 2013-04-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
548
549         Unreviewed build fix with gstreamer 0.10.x after r147555.
550
551         * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
552         (webKitWebAudioSrcLoop):
553
554 == Rolled over to ChangeLog-2013-04-24 ==