1 2011-03-08 Xiaomei Ji <xji@chromium.org>
3 Reviewed by David Hyatt.
5 Fix Regression: Content not drawn when scrolling horizontally in an RTL page.
6 https://bugs.webkit.org/show_bug.cgi?id=55077.
8 Inside ScrollView::calculateOverhangAreasForPainting(), when scroll position
9 is negative, should include the position value into overhang rectangle's
12 Tests: fast/dom/scroll-reveal-left-overflow.html
13 fast/dom/scroll-reveal-top-overflow.html
15 * platform/ScrollView.cpp:
16 (WebCore::ScrollView::calculateOverhangAreasForPainting):
18 2011-03-08 Daniel Bates <dbates@rim.com>
20 Reviewed by Darin Adler.
22 Add templatized CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}()
23 https://bugs.webkit.org/show_bug.cgi?id=55351
25 By using some template magic CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}()
26 can be called on an array A without the caller explicitly specifying the size of A.
28 No functionality was changed. So no new tests.
30 * css/CSSMutableStyleDeclaration.cpp:
31 (WebCore::CSSMutableStyleDeclaration::getPropertyValue): Modified to call templatized variants of
32 CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}().
33 (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Renamed second argument from "number" to "size"
34 to better reflect its purpose - to be the size of the passed array.
35 (WebCore::CSSMutableStyleDeclaration::getShorthandValue): Ditto.
36 (WebCore::CSSMutableStyleDeclaration::getCommonValue): Ditto.
37 (WebCore::CSSMutableStyleDeclaration::cssText): Modified to call templatized variant of CSSMutableStyleDeclaration::getShorthandValue().
38 * css/CSSMutableStyleDeclaration.h:
39 (WebCore::CSSMutableStyleDeclaration::getShorthandValue): Added templatized function that can determine
40 the size of a passed array. Changed type of second argument to size_t since it represents the size of
42 (WebCore::CSSMutableStyleDeclaration::getCommonValue): Ditto.
43 (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Ditto.
45 2011-03-08 Enrica Casucci <enrica@apple.com>
47 Reviewed by Darin Adler.
49 REGRESSION: Copied content loses formatting on paste to external apps.
50 https://bugs.webkit.org/show_bug.cgi?id=47615
51 <rdar://problem/9001214>
53 This is a resubmission of a patch that was landed a while ago then rolled
54 back because of a build failure on SnowLeopard and Leopard on the 32-bit builds.
56 This patch adds a way for WebKit2 to create NSAttributedStrings from
57 a DOM range without using the AppKit api initWithDOMRange that internally
58 needs to access the WebView. The NSAttributedString is needed to create
59 RTF formats in the pasteboard.
60 This is to be considered a first step, since in the future we want to have
61 an implementation based on the TextIterator.
62 * WebCore.xcodeproj/project.pbxproj:
63 * platform/mac/HTMLConverter.h: Added.
64 * platform/mac/HTMLConverter.mm: Added.
65 * platform/mac/PasteboardMac.mm:
66 (WebCore::Pasteboard::writeSelection):
68 2011-03-08 James Robinson <jamesr@chromium.org>
70 Reviewed by Kenneth Russell.
72 [chromium] Explicitly copy compositing properties from LayerChromium to CCLayerImpl
73 https://bugs.webkit.org/show_bug.cgi?id=55900
75 This adds an explicit step to synchronize properties from
76 LayerChromiums to their corresponding CCLayerImpls.
78 * platform/graphics/chromium/LayerChromium.cpp:
79 (WebCore::LayerChromium::setBounds):
80 * platform/graphics/chromium/LayerChromium.h:
81 (WebCore::LayerChromium::bounds):
82 (WebCore::LayerChromium::doubleSided):
83 (WebCore::LayerChromium::setDoubleSided):
84 * platform/graphics/chromium/LayerRendererChromium.cpp:
85 (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
86 * platform/graphics/chromium/cc/CCLayerImpl.cpp:
87 (WebCore::CCLayerImpl::CCLayerImpl):
88 (WebCore::CCLayerImpl::updateFromLayer):
89 (WebCore::CCLayerImpl::descendantsDrawsContent):
90 * platform/graphics/chromium/cc/CCLayerImpl.h:
91 (WebCore::CCLayerImpl::anchorPoint):
92 (WebCore::CCLayerImpl::anchorPointZ):
93 (WebCore::CCLayerImpl::masksToBounds):
94 (WebCore::CCLayerImpl::opacity):
95 (WebCore::CCLayerImpl::position):
96 (WebCore::CCLayerImpl::preserves3D):
97 (WebCore::CCLayerImpl::sublayerTransform):
98 (WebCore::CCLayerImpl::transform):
100 2011-03-08 James Robinson <jamesr@chromium.org>
102 Chromium compile fix.
104 * platform/graphics/chromium/SimpleFontDataLinux.cpp:
105 (WebCore::SimpleFontData::platformInit):
107 2011-03-08 Peter Kasting <pkasting@google.com>
109 Reviewed by James Robinson.
111 Unify Windows version checks, part 1.
112 https://bugs.webkit.org/show_bug.cgi?id=55979
114 Make everyone (I hope) pull in SystemInfo.cpp. Eliminate the
115 now-unnecessary WindowsVersion.cpp from Chromium.
118 * WebCore.gyp/WebCore.gyp:
120 * platform/chromium/ScrollbarThemeChromiumWin.cpp:
121 (WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit):
122 (WebCore::ScrollbarThemeChromiumWin::getThemeState):
123 (WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
124 * platform/chromium/WindowsVersion.cpp: Removed.
125 * platform/chromium/WindowsVersion.h: Removed.
126 * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
127 (WebCore::fillBMPGlyphs):
128 * rendering/RenderThemeChromiumWin.cpp:
129 (WebCore::getNonClientMetrics):
131 2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
133 Chromium Linux build fix attempt after r80582.
135 * platform/graphics/chromium/FontLinux.cpp:
136 (WebCore::Font::drawGlyphs):
137 * platform/graphics/chromium/SimpleFontDataLinux.cpp:
138 (WebCore::SimpleFontData::platformInit):
139 * platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
140 (WebCore::GlyphPage::fill):
142 2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
144 Mac build fix attempt for r80582.
146 * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
147 (WebCore::disableLigatures):
149 2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
151 Reviewed by Kent Tamura.
153 Remove calls to deprecatedEditingOffset in SelectionController and VisibleSelection
154 https://bugs.webkit.org/show_bug.cgi?id=54937
156 * editing/SelectionController.cpp:
157 (WebCore::SelectionController::setSelection): Calls anchorNode() instead of deprecatedNode() to obtain
158 the document. Also restrained the lifetime of document variable.
159 (WebCore::removingNodeRemovesPosition): Compare the node with anchorNode() instead of deprecatedNode()
160 to determine whether or not position becomes null after removing a node.
161 (WebCore::SelectionController::directionOfEnclosingBlock): The enclosing block is always a container
162 so call containerNode() instead of deprecatedNode().
163 (WebCore::SelectionController::debugRenderer): Call containerNode() and computeOffsetInContainer()
164 instead of deprecatedNode() and deprecatedEditingOffset() respectively.
165 (WebCore::SelectionController::isInPasswordField): Look for the shadow root from containerNode()
166 instead of deprecatedNode to determine whether or not selection inside a password field. Also assert
167 that the specified position is not before or after the shadow root as it violates our assumption.
168 * editing/VisibleSelection.cpp:
169 (WebCore::makeSearchRange): Call containerNode() and offsetInContainerNode() instead of deprecatedNode()
170 and deprecatedEditingOffset() respectively because start is always parent anchored and therefore
171 guaranteed to be an offset inside an anchor node.
172 (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries): Call containerNode()
173 instead of deprecatedNode() to look for the lowest editable ancestor because position before or after
174 an editable element isn't editable.
175 * page/DOMSelection.cpp: Call containerNode() and offsetInContainerNode() instead of deprecatedNode()
176 and deprecatedEditingOffset() respectively in the following functions because they are exposed to
177 DOM, which doesn't have before/after concept.
178 (WebCore::DOMSelection::anchorNode):
179 (WebCore::DOMSelection::anchorOffset):
180 (WebCore::DOMSelection::focusNode):
181 (WebCore::DOMSelection::focusOffset):
182 (WebCore::DOMSelection::baseNode):
183 (WebCore::DOMSelection::baseOffset):
184 (WebCore::DOMSelection::extentNode):
185 (WebCore::DOMSelection::extentOffset):
187 2011-03-08 Brent Fulgham <bfulgham@webkit.org>
189 Reviewed by Adam Roben.
191 Correct uninitialized variable in PolicyCallback found while
192 running WebKit in BoundsChecker.
193 https://bugs.webkit.org/show_bug.cgi?id=45199.
195 * loader/PolicyCallback.cpp:
196 (WebCore::PolicyCallback::PolicyCallback): Initialize
199 2011-03-08 Brent Fulgham <bfulgham@webkit.org>
201 More build bustage fix.
203 * platform/graphics/win/cairo/FontPlatformData.h:
204 (WebCore::FontPlatformData::setOrientation): Duplicate accessor
205 in WinCairo-local header. This is such a mess!
207 2011-03-08 David Hyatt <hyatt@apple.com>
209 Fix build bustage. Hide orientation setting behind a setter and stub it out in all
210 FontPlatformData classes. (This class really needs to move to a common header with ifdefs.)
212 * platform/graphics/SimpleFontData.cpp:
213 (WebCore::SimpleFontData::verticalRightOrientationFontData):
214 * platform/graphics/cg/FontPlatformData.h:
215 (WebCore::FontPlatformData::setOrientation):
216 * platform/graphics/chromium/FontPlatformDataChromiumWin.h:
217 (WebCore::FontPlatformData::setOrientation):
218 * platform/graphics/chromium/FontPlatformDataLinux.h:
219 (WebCore::FontPlatformData::setOrientation):
220 * platform/graphics/cocoa/FontPlatformData.h:
221 (WebCore::FontPlatformData::setOrientation):
222 * platform/graphics/freetype/FontPlatformData.h:
223 (WebCore::FontPlatformData::setOrientation):
224 * platform/graphics/qt/FontPlatformData.h:
225 (WebCore::FontPlatformData::setOrientation):
226 * platform/graphics/wince/FontPlatformData.h:
227 (WebCore::FontPlatformData::setOrientation):
228 * platform/graphics/wx/FontPlatformData.h:
229 (WebCore::FontPlatformData::setOrientation):
231 2011-03-08 Joe Wild <joseph.wild@nokia.com>
233 Reviewed by Csaba Osztrogonác.
235 [Qt] Missing SVG variables
236 https://bugs.webkit.org/show_bug.cgi?id=32941
238 Basically, this patch just modifies features.pri to the Qt build to
239 pass on the ENABLE_SVG_* flags to the IDL binding generator.
241 Also I had remove global-construtors.html from the skip list and
242 updated the associated expected results files.
245 * page/DOMWindow.idl:
247 2011-03-08 Alok priyadarshi <alokp@chromium.org>
249 Reviewed by Dimitri Glazkov.
251 Plugins needs a way to trigger style recalc
252 https://bugs.webkit.org/show_bug.cgi?id=55242
254 No test needed. A simple get function is added.
256 * platform/graphics/chromium/PluginLayerChromium.h:
257 (WebCore::PluginLayerChromium::getTextureId):
259 2011-03-08 David Hyatt <hyatt@apple.com>
261 Reviewed by Dan Bernstein.
263 https://bugs.webkit.org/show_bug.cgi?id=48540, support the text-orientation CSS property.
265 This patch adds support for two values of the text-orientation property (the ones that actually matter): vertical-right and upright.
266 The TextOrientation is part of the FontDescription and used to look up fonts (similar to FontOrientation).
268 Orientation of non-CJK characters is done using fallback font data of the appropriate orientation type, e.g., verticalRightOrientation and
269 uprightOrientation fallback font data. Vertical right is just implemented as a normal horizontal font. Upright is implemented as a
270 vertically oriented font that rotates all glyphs.
272 The main complication implementing text-orientation is that fonts have "baked-in" vertical glyphs for letters that are hardcoded to
273 a vertical right facing. This means that you can use those special vertical glyphs for vertical-right orientation without having to
274 fall back, but then for upright orientation you have to ignore them and still fall back. As you can see from the test case, this doesn't
275 work very well, but hopefully it won't be all that common. Limitations of CoreText prevent this case from rendering properly in either the
276 simple or complex code paths, although the simple code path at least gets close.
278 Added fast/blockflow/text-orientation-basic.html
281 * WebCore.xcodeproj/project.pbxproj:
282 * css/CSSComputedStyleDeclaration.cpp:
283 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
284 * css/CSSFontFaceSource.cpp:
285 (WebCore::CSSFontFaceSource::getFontData):
287 (WebCore::CSSParser::parseValue):
288 * css/CSSPrimitiveValueMappings.h:
289 (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
290 (WebCore::CSSPrimitiveValue::operator TextOrientation):
291 * css/CSSPropertyNames.in:
292 * css/CSSStyleSelector.cpp:
293 (WebCore::CSSStyleSelector::applyDeclarations):
294 (WebCore::CSSStyleSelector::applyProperty):
295 * css/CSSValueKeywords.in:
296 * loader/cache/CachedFont.cpp:
297 (WebCore::CachedFont::platformDataFromCustomData):
298 * loader/cache/CachedFont.h:
299 * platform/graphics/FontCache.cpp:
300 (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
301 (WebCore::FontPlatformDataCacheKey::operator==):
302 (WebCore::computeHash):
303 (WebCore::FontCache::getCachedFontPlatformData):
304 * platform/graphics/FontDescription.h:
305 (WebCore::FontDescription::FontDescription):
306 (WebCore::FontDescription::textOrientation):
307 (WebCore::FontDescription::setTextOrientation):
308 (WebCore::FontDescription::operator==):
309 * platform/graphics/FontFastPath.cpp:
310 (WebCore::Font::glyphDataForCharacter):
311 (WebCore::offsetToMiddleOfGlyph):
312 * platform/graphics/SimpleFontData.cpp:
313 (WebCore::SimpleFontData::SimpleFontData):
314 (WebCore::SimpleFontData::verticalRightOrientationFontData):
315 (WebCore::SimpleFontData::uprightOrientationFontData):
316 (WebCore::SimpleFontData::brokenIdeographFontData):
317 (WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):
318 * platform/graphics/SimpleFontData.h:
319 (WebCore::SimpleFontData::hasVerticalGlyphs):
320 (WebCore::SimpleFontData::isTextOrientationFallback):
321 * platform/graphics/cairo/FontCustomPlatformData.h:
322 * platform/graphics/cocoa/FontPlatformData.h:
323 (WebCore::FontPlatformData::FontPlatformData):
324 (WebCore::FontPlatformData::textOrientation):
325 (WebCore::FontPlatformData::hash):
326 (WebCore::FontPlatformData::operator==):
327 * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
328 (WebCore::FontPlatformData::FontPlatformData):
329 (WebCore::FontPlatformData::operator=):
330 * platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
331 (WebCore::FontCustomPlatformData::fontPlatformData):
332 * platform/graphics/haiku/FontCustomPlatformData.cpp:
333 (WebCore::FontCustomPlatformData::fontPlatformData):
334 * platform/graphics/haiku/FontCustomPlatformData.h:
335 * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
336 (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
337 * platform/graphics/mac/FontCacheMac.mm:
338 (WebCore::FontCache::createFontPlatformData):
339 * platform/graphics/mac/FontCustomPlatformData.cpp:
340 (WebCore::FontCustomPlatformData::fontPlatformData):
341 * platform/graphics/mac/FontCustomPlatformData.h:
342 * platform/graphics/mac/FontMac.mm:
343 (WebCore::showGlyphsWithAdvances):
344 (WebCore::Font::drawGlyphs):
345 * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
346 (WebCore::shouldUseCoreText):
347 (WebCore::GlyphPage::fill):
348 * platform/graphics/mac/SimpleFontDataCoreText.cpp:
349 (WebCore::SimpleFontData::getCFStringAttributes):
350 * platform/graphics/mac/SimpleFontDataMac.mm:
351 (WebCore::SimpleFontData::platformInit):
352 (WebCore::SimpleFontData::platformBoundsForGlyph):
353 (WebCore::SimpleFontData::platformWidthForGlyph):
354 * platform/graphics/pango/FontCustomPlatformDataPango.cpp:
355 (WebCore::FontCustomPlatformData::fontPlatformData):
356 * platform/graphics/qt/FontCustomPlatformData.h:
357 * platform/graphics/qt/FontCustomPlatformDataQt.cpp:
358 (WebCore::FontCustomPlatformData::fontPlatformData):
359 * platform/graphics/skia/FontCustomPlatformData.cpp:
360 (WebCore::FontCustomPlatformData::fontPlatformData):
361 * platform/graphics/skia/FontCustomPlatformData.h:
362 * platform/graphics/win/FontCustomPlatformData.cpp:
363 (WebCore::FontCustomPlatformData::fontPlatformData):
364 * platform/graphics/win/FontCustomPlatformData.h:
365 * platform/graphics/win/FontCustomPlatformDataCairo.cpp:
366 (WebCore::FontCustomPlatformData::fontPlatformData):
367 * platform/graphics/win/FontCustomPlatformDataCairo.h:
368 * platform/graphics/wince/FontCustomPlatformData.cpp:
369 (WebCore::FontCustomPlatformData::fontPlatformData):
370 * platform/graphics/wince/FontCustomPlatformData.h:
371 * platform/text/TextOrientation.h: Added.
372 * rendering/InlineFlowBox.cpp:
373 (WebCore::InlineFlowBox::requiresIdeographicBaseline):
374 * rendering/style/RenderStyle.h:
375 (WebCore::InheritedFlags::initialTextOrientation):
377 2011-03-08 Ryosuke Niwa <rniwa@webkit.org>
379 Reviewed by Darin Adler.
381 addInlineStyleIfNeeded should take EditingStyle
382 https://bugs.webkit.org/show_bug.cgi?id=55950
384 Deployed EditingStyle in addInlineStyleIfNeeded, StyleChange::StyleChange, and StyleChange::init.
385 Also extracted EditingStyle::styleIsPresentInComputedStyleOfNode from removeStyleFromRunBeforeApplyingStyle.
387 * editing/ApplyStyleCommand.cpp:
388 (WebCore::StyleChange::StyleChange): Takes EditingStyle instead of CSSStyleDeclaration.
389 (WebCore::StyleChange::init): Ditto.
390 (WebCore::ApplyStyleCommand::applyBlockStyle): Instantiates StyleChange.
391 (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Calls addInlineStyleIfNeeded.
392 (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Calls styleIsPresentInComputedStyleOfNode.
393 (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Calls EditingStyle::mergeInlineStyleOfElement
394 instead of manually merging styles.
395 (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Calls addInlineStyleIfNeeded.
396 (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Takes EditingStyle instead of CSSMutableStyleDeclaration.
397 * editing/ApplyStyleCommand.h:
398 * editing/CompositeEditCommand.h:
399 * editing/EditingStyle.cpp:
400 (WebCore::EditingStyle::styleIsPresentInComputedStyleOfNode): Extracted from removeStyleFromRunBeforeApplyingStyle.
401 * editing/EditingStyle.h:
403 2011-03-08 Nico Weber <thakis@chromium.org>
405 Reviewed by James Robinson.
407 Crash on big blur radius with canvas
408 https://bugs.webkit.org/show_bug.cgi?id=55951
410 Move the clamping code out of an if branch, so that it happens in the
413 Test: fast/canvas/shadow-huge-blur.html
415 * platform/graphics/cg/GraphicsContextCG.cpp:
416 (WebCore::GraphicsContext::setPlatformShadow):
418 2011-03-08 Chris Fleizach <cfleizach@apple.com>
420 Reviewed by Sam Weinig.
422 WK2: Cannot set focus on an element when focus is outside of WKView
423 https://bugs.webkit.org/show_bug.cgi?id=55281
425 In WK2, focus cannot be set from the WebProcess side because there's no platformWidget().
426 Instead, the focus/unfocus messages need to be sent to the UIProcess side.
428 * platform/mac/WidgetMac.mm:
429 (WebCore::Widget::setFocus):
431 2011-03-08 Sam Weinig <sam@webkit.org>
433 Reviewed by Anders Carlsson.
435 Overflow: scroll areas should not paint white in scroll corner if the
436 scrollbars are overlay.
437 <rdar://problem/9082871>
439 * rendering/RenderLayer.cpp:
440 (WebCore::RenderLayer::paintScrollCorner):
441 Don't paint the scroll corner white if we have overlay scrollbars.
443 2011-03-08 Chris Marrin <cmarrin@apple.com>
445 Reviewed by Darin Adler.
447 The first time animations are committed they have a bad start time
448 https://bugs.webkit.org/show_bug.cgi?id=55947
450 Do a check for a returned lastCommitTime of <=0 and replace it
454 * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
455 (WebCore::CACFLayerTreeHost::notifyAnimationsStarted):
457 2011-03-08 James Kozianski <koz@chromium.org>
459 Reviewed by David Levin.
461 Expose isValidProtocol() in KURL.h.
462 https://bugs.webkit.org/show_bug.cgi?id=54594
464 This is needed to validate protocols used in calls to
465 navigator.registerProtocolHandler().
469 * platform/KURLGoogle.cpp:
470 (WebCore::isValidProtocol):
472 2011-03-08 Adam Roben <aroben@apple.com>
474 Set svn:mime-type to text/css for all Inspector CSS files
476 This will cause them to be served with the correct MIME type from svn.webkit.org's web
479 Rubber-stamped by Tim Hatcher.
481 * inspector/front-end/audits.css: Added property svn:mime-type.
482 * inspector/front-end/goToLineDialog.css: Added property svn:mime-type.
483 * inspector/front-end/heapProfiler.css: Added property svn:mime-type.
484 * inspector/front-end/helpScreen.css: Added property svn:mime-type.
485 * inspector/front-end/inspector.css: Added property svn:mime-type.
486 * inspector/front-end/inspectorSyntaxHighlight.css: Added property svn:mime-type.
487 * inspector/front-end/networkPanel.css: Added property svn:mime-type.
488 * inspector/front-end/popover.css: Added property svn:mime-type.
489 * inspector/front-end/textViewer.css: Added property svn:mime-type.
491 2011-03-08 Andrei Popescu <andreip@google.com>
493 Reviewed by Steve Block.
495 IDBCallbacks::onsuccess(IDBIndex*) is unused and should be removed.
496 https://bugs.webkit.org/show_bug.cgi?id=55938
498 The IndexedDatabase specification changed and IDBIndex objects are no
499 longer created asynchronously. We therefore no longer need this method.
501 No new tests, just cleanup.
503 * storage/IDBCallbacks.h:
504 * storage/IDBRequest.cpp:
505 * storage/IDBRequest.h:
507 2011-03-08 Sheriff Bot <webkit.review.bot@gmail.com>
509 Unreviewed, rolling out r80551.
510 http://trac.webkit.org/changeset/80551
511 https://bugs.webkit.org/show_bug.cgi?id=55933
513 It broke 285 tests on Qt bot (Requested by Ossy on #webkit).
516 * platform/SharedBuffer.cpp:
517 * platform/SharedBuffer.h:
518 * platform/network/qt/QNetworkReplyHandler.cpp:
519 (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
520 (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
521 (WebCore::QNetworkReplyHandler::forwardData):
522 (WebCore::QNetworkReplyHandler::start):
523 * platform/network/qt/QNetworkReplyHandler.h:
524 * platform/network/qt/ResourceHandleQt.cpp:
525 (WebCore::ResourceHandle::supportsBufferedData):
526 (WebCore::ResourceHandle::bufferedData):
527 * platform/qt/QtByteBlock.cpp: Removed.
528 * platform/qt/QtByteBlock.h: Removed.
529 * platform/qt/SharedBufferQt.cpp:
531 2011-03-08 Andreas Kling <kling@webkit.org>
533 Reviewed by Benjamin Poulain.
535 RenderObject: Pass complex type arguments as const-references.
538 * rendering/RenderObject.h:
539 * rendering/RenderObject.cpp:
540 (WebCore::RenderObject::drawBoxSideFromPath):
541 (WebCore::RenderObject::drawArcForBoxSide):
542 (WebCore::RenderObject::localToAbsolute):
543 (WebCore::RenderObject::absoluteToLocal):
545 2011-03-08 Andreas Kling <kling@webkit.org>
547 Reviewed by Antonio Gomes.
549 Path: Make measurement functions const
550 https://bugs.webkit.org/show_bug.cgi?id=55914
552 * platform/graphics/Path.cpp:
553 (WebCore::Path::length):
554 (WebCore::Path::pointAtLength):
555 (WebCore::Path::normalAngleAtLength):
556 * platform/graphics/Path.h:
557 * platform/graphics/cairo/PathCairo.cpp:
558 (WebCore::Path::strokeBoundingRect):
559 * platform/graphics/cg/PathCG.cpp:
560 (WebCore::Path::strokeBoundingRect):
561 * platform/graphics/openvg/PathOpenVG.cpp:
562 (WebCore::Path::strokeBoundingRect):
563 (WebCore::Path::length):
564 (WebCore::Path::pointAtLength):
565 (WebCore::Path::normalAngleAtLength):
566 * platform/graphics/qt/PathQt.cpp:
567 (WebCore::Path::strokeBoundingRect):
568 (WebCore::Path::length):
569 (WebCore::Path::pointAtLength):
570 (WebCore::Path::normalAngleAtLength):
571 * platform/graphics/skia/PathSkia.cpp:
572 (WebCore::Path::strokeBoundingRect):
573 * platform/graphics/wince/PathWinCE.cpp:
574 (WebCore::Path::strokeBoundingRect):
575 * platform/graphics/wx/PathWx.cpp:
576 (WebCore::Path::strokeBoundingRect):
578 2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
580 Reviewed by Martin Robinson.
582 [GTK] Do not set juntion sides on scrollbar stepper buttons
583 https://bugs.webkit.org/show_bug.cgi?id=55868
585 Fixes rendering of steppers for themes using rounded stepper
586 buttons on scrollbars like Adwaita.
588 * platform/gtk/ScrollbarThemeGtk3.cpp:
589 (WebCore::ScrollbarThemeGtk::paintButton):
591 2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
593 Reviewed by Martin Robinson.
595 [GTK] Use doubles instead of integers for coordinates when rendering arrows
596 https://bugs.webkit.org/show_bug.cgi?id=55866
598 To prevent off-by-one rounding errors.
600 * platform/gtk/RenderThemeGtk3.cpp:
601 (WebCore::RenderThemeGtk::paintMenuList):
602 * platform/gtk/ScrollbarThemeGtk3.cpp:
603 (WebCore::ScrollbarThemeGtk::paintButton):
605 2011-03-08 Markus Goetz <guruz@guruz.de>
607 Reviewed by Kenneth Rohde Christiansen.
609 [Qt] Use the QNetworkAccessManager zerocopy feature
610 https://bugs.webkit.org/show_bug.cgi?id=50082
612 The feature will be introduced in Qt 4.8.
613 This patch is backwards compatible with Qt 4.7.
616 * platform/SharedBuffer.cpp:
617 * platform/SharedBuffer.h:
618 * platform/network/qt/QNetworkReplyHandler.cpp:
619 (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
620 (WebCore::QNetworkReplyHandler::bufferedData):
621 (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
622 (WebCore::QNetworkReplyHandler::downloadProgress):
623 (WebCore::QNetworkReplyHandler::forwardData):
624 (WebCore::QNetworkReplyHandler::start):
625 * platform/network/qt/QNetworkReplyHandler.h:
626 * platform/network/qt/ResourceHandleQt.cpp:
627 (WebCore::ResourceHandle::supportsBufferedData):
628 (WebCore::ResourceHandle::bufferedData):
629 * platform/qt/SharedBufferQt.cpp:
630 (WebCore::SharedBuffer::wrapQtByteBlock):
631 (WebCore::SharedBuffer::hasPlatformData):
632 (WebCore::SharedBuffer::platformData):
633 (WebCore::SharedBuffer::platformDataSize):
634 (WebCore::SharedBuffer::maybeTransferPlatformData):
635 (WebCore::SharedBuffer::clearPlatformData):
637 2011-03-08 Alejandro G. Castro <alex@igalia.com>
639 Reviewed by Martin Robinson.
641 [GTK] Fix compilation warnings after r80429
642 https://bugs.webkit.org/show_bug.cgi?id=55864
644 * platform/gtk/WidgetGtk.cpp:
646 2011-03-08 Philippe Normand <pnormand@igalia.com>
648 Unreviewed, GTK build fix after r80536
652 2011-03-08 Zan Dobersek <zandobersek@gmail.com>
654 Reviewed by Martin Robinson.
656 [Gtk] toDataURL uses incorrect quality value when saving GdkPixbuf to buffer
657 https://bugs.webkit.org/show_bug.cgi?id=55878
659 Multiply the quality parameter by 100 to put it in the range [0, 100] as needed
660 when saving GdkPixbuf to a buffer.
662 * platform/graphics/gtk/ImageBufferGtk.cpp:
663 (WebCore::ImageBuffer::toDataURL):
665 2011-03-07 Daniel Cheng <dcheng@chromium.org>
669 Final build fix for r80536.
671 * DerivedSources.make:
673 2011-03-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
675 Reviewed by Kent Tamura.
677 [EFL] Adjust functions of WebCore's efl port to WebKit coding style
678 https://bugs.webkit.org/show_bug.cgi?id=55924
680 Adjust webkit style to PlatformKeyboardEventEfl, PlatformMouseEventEfl and WidgetEfl files.
682 * platform/efl/PlatformKeyboardEventEfl.cpp:
683 (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
684 * platform/efl/PlatformMouseEventEfl.cpp:
685 (WebCore::PlatformMouseEvent::PlatformMouseEvent):
686 * platform/efl/WidgetEfl.cpp:
687 (WebCore::Widget::frameRectsChanged):
688 (WebCore::Widget::setEvasObject):
690 2011-03-07 Daniel Cheng <dcheng@chromium.org>
694 More build fixes for r80536.
697 * platform/chromium/ClipboardChromium.cpp:
698 * platform/chromium/ClipboardChromium.h:
700 2011-03-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
702 Reviewed by Antonio Gomes.
704 [EFL] Adjust functions of ScrollbarEfl.cpp to WebKit coding style
705 https://bugs.webkit.org/show_bug.cgi?id=55917
707 Adjust webkit style to ScrollbarEfl files.
709 * platform/efl/ScrollbarEfl.cpp:
710 (scrollbarEflEdjeMessage):
711 (ScrollbarEfl::setParent):
712 (ScrollbarEfl::updateThumbPositionAndProportion):
713 (ScrollbarEfl::frameRectsChanged):
714 (ScrollbarEfl::paint):
715 * platform/efl/ScrollbarEfl.h:
717 2011-03-07 Daniel Cheng <dcheng@chromium.org>
721 Build fix for Chromium after r80536.
723 * platform/chromium/DataTransferItemChromium.cpp:
724 * platform/chromium/DataTransferItemsChromium.cpp:
726 2011-03-07 Daniel Cheng <dcheng@chromium.org>
730 More build fixes for r80536.
733 * platform/chromium/ClipboardChromium.cpp:
734 * platform/chromium/ClipboardChromium.h:
736 2011-03-07 Daniel Cheng <dcheng@chromium.org>
738 Reviewed by David Levin.
740 Add support for DataTransferItems
741 https://bugs.webkit.org/show_bug.cgi?id=55115
743 This patch adds stubs for DataTransferItems/DataTransferItem as well as implementing the
744 basic functionality on the Chromium port. With the exception of DataTransferItem::getAsFile,
745 all functionality on the DataTransferItems collection has been implemented.
746 This change does not actually hook up DataTransferItems to reflect the actual contents of a
747 drop/paste operation or to allow mutation of data in a copy/drag start yet. That will be
748 enabled via several followup patches.
750 Test: editing/pasteboard/data-transfer-items.html
754 * CodeGenerators.pri:
755 * DerivedSources.cpp:
756 * DerivedSources.make:
760 * WebCore.vcproj/WebCore.vcproj:
761 * WebCore.xcodeproj/project.pbxproj:
762 * bindings/generic/RuntimeEnabledFeatures.cpp:
763 * bindings/generic/RuntimeEnabledFeatures.h:
764 (WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled):
765 (WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled):
766 * bindings/scripts/CodeGeneratorV8.pm: Do not emit an #include line for DOMString, since it's built-in.
768 (WebCore::Clipboard::policy):
770 * dom/DataTransferItem.cpp: Added.
771 * dom/DataTransferItem.h: Added.
772 (WebCore::DataTransferItem::~DataTransferItem):
773 * dom/DataTransferItem.idl: Added.
774 * dom/DataTransferItems.h: Added.
775 (WebCore::DataTransferItems::~DataTransferItems):
776 * dom/DataTransferItems.idl: Added.
777 * dom/StringCallback.cpp: Added.
778 (WebCore::StringCallback::scheduleCallback):
779 * dom/StringCallback.h: Added.
780 (WebCore::StringCallback::~StringCallback):
781 * dom/StringCallback.idl: Added.
782 * platform/chromium/ClipboardChromium.cpp:
783 (WebCore::ClipboardChromium::items):
784 * platform/chromium/ClipboardChromium.h:
785 * platform/chromium/DataTransferItemChromium.cpp: Added.
786 (WebCore::DataTransferItemChromium::create):
787 (WebCore::DataTransferItemChromium::DataTransferItemChromium):
788 (WebCore::DataTransferItemChromium::kind):
789 (WebCore::DataTransferItemChromium::type):
790 (WebCore::DataTransferItemChromium::getAsString):
791 * platform/chromium/DataTransferItemChromium.h: Added.
792 * platform/chromium/DataTransferItemsChromium.cpp: Added.
793 (WebCore::DataTransferItemsChromium::create):
794 (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
795 (WebCore::DataTransferItemsChromium::length):
796 (WebCore::DataTransferItemsChromium::item):
797 (WebCore::DataTransferItemsChromium::deleteItem):
798 (WebCore::DataTransferItemsChromium::clear):
799 (WebCore::DataTransferItemsChromium::add):
800 * platform/chromium/DataTransferItemsChromium.h: Added.
802 2011-03-07 Ryosuke Niwa <rniwa@webkit.org>
804 Reviewed by Darin Adler.
806 selectionHasStyle and selectionStartHasStyle should use EditingStyle
807 https://bugs.webkit.org/show_bug.cgi?id=55902
809 Deployed EditingStyle in selectionHasStyle and selectionStartHasStyle.
810 This allowed us to move triStateOfStyle from Editor.cpp to EditingStyle.cpp.
812 Also changed the argument lists of selectionHasStyle and selectionStartHasStyle
813 to take a property id and a value instead of a CSSMutableStyleDeclaration to cleanup
814 call sites of these two functions.
816 * WebCore.exp.in: Updated the signature of selectionHasStyle. No longer exports
817 selectionStartHasStyle because it's not called anywhere outside of WebCore.
818 * WebCore.order: Ditto.
819 * editing/EditingStyle.cpp:
820 (WebCore::EditingStyle::EditingStyle): Added a new constructor that takes a property id
821 and a property value.
822 (WebCore::EditingStyle::triStateOfStyle): Moved from Editor.cpp.
823 * editing/EditingStyle.h:
824 (WebCore::EditingStyle::create): Added.
825 * editing/Editor.cpp:
826 (WebCore::Editor::selectionStartHasStyle): Takes a property id and a value instead of
827 a CSSStyleDeclaration.
828 (WebCore::Editor::selectionHasStyle): Ditto.
829 * editing/Editor.h: Updated the signatures of selectionStartHasStyle and selectionHasStyle.
830 * editing/EditorCommand.cpp:
831 (WebCore::executeToggleStyle): Calls selectionStartHasStyle and selectionHasStyle.
832 (WebCore::stateStyle): Ditto.
833 * page/ContextMenuController.cpp:
834 (WebCore::ContextMenuController::checkOrEnableIfNeeded): Ditto.
836 2011-03-07 Alexey Proskuryakov <ap@apple.com>
838 Reviewed by Darin Adler.
840 REGRESSION (HTML5 tree builder): Text selection in a large text document is extremely slow
841 https://bugs.webkit.org/show_bug.cgi?id=55898
843 <rdar://problem/9095839> REGRESSION: Mail hangs with a certain large mail message when
844 linkifying e-mail addresses in in -[DOMCharacterData setData:]
846 Changes render tree of fast/text/large-text-composed-char.html, but not image results.
848 * dom/CharacterData.cpp: (WebCore::CharacterData::parserAppendData):
849 Changed parserAppendData() to accept a maximum length, and moved code from Text::createWithLengthLimit().
851 * dom/CharacterData.h: Moved a constant for maximum length from Text.h.
853 * dom/Text.cpp: (WebCore::Text::createWithLengthLimit):
855 This function was unused in ToT. Moved code around to share with CharacterData.
857 * html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertTextNode):
858 Chnaged to split large text nodes while parsing again.
860 2011-03-07 Alice Boxhall <aboxhall@chromium.org>
862 Reviewed by Adam Barth.
864 Fix platform/image-encoders/JPEGImageEncoder.cpp empty_output_buffer() behaviour
865 https://bugs.webkit.org/show_bug.cgi?id=54522
867 Fix jpegEmptyOutputBuffer() by ignoring free_in_buffer value as required.
869 No new tests, as this code is not yet used in WebKit. Once this code is used to implement canvas.toDataUrl(), the canvas tests will exercise it.
871 * platform/image-encoders/JPEGImageEncoder.cpp:
872 (WebCore::jpegEmptyOutputBuffer):
874 2011-03-07 Sergey Glazunov <serg.glazunov@gmail.com>
876 Reviewed by Eric Seidel.
878 Add the missing insertedIntoDocument() call in SVGVKernElement and SVGHKernElement
879 https://bugs.webkit.org/show_bug.cgi?id=55896
881 Test: svg/dom/vkern-element-crash.html
883 * svg/SVGHKernElement.cpp:
884 (WebCore::SVGHKernElement::insertedIntoDocument):
885 * svg/SVGVKernElement.cpp:
886 (WebCore::SVGVKernElement::insertedIntoDocument):
888 2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>
890 Unreviewed, rolling out r80514.
891 http://trac.webkit.org/changeset/80514
892 https://bugs.webkit.org/show_bug.cgi?id=55915
894 Caused assertion failures (Requested by ukai on #webkit).
896 * platform/graphics/skia/GraphicsContextSkia.cpp:
897 (WebCore::GraphicsContext::setPlatformShadow):
898 * platform/graphics/skia/ImageSkia.cpp:
899 (WebCore::paintSkBitmap):
901 2011-03-07 Cosmin Truta <ctruta@chromium.org>
903 Reviewed by Adam Barth.
905 SVG <image> referenced by <use> is displayed incorrectly
906 https://bugs.webkit.org/show_bug.cgi?id=55750
908 The result of sourceURI must use the URL of the enclosing document as base.
909 Otherwise, the base may sometimes be empty, and, as a consequence,
910 the intermediate KURL object may be invalid.
912 Test: svg/custom/use-image-in-g.svg
914 * svg/SVGImageLoader.cpp:
915 (WebCore::SVGImageLoader::sourceURI):
917 2011-03-07 Helder Correia <helder@sencha.com>
919 Reviewed by Simon Fraser.
921 Shadow is not shown when using strokeRect with a gradient strokeStyle
922 https://bugs.webkit.org/show_bug.cgi?id=52509
924 This happens in CG and is related to bug 51869, this time to be fixed
925 in GraphicsContext::strokeRect(const FloatRect& r, float lineWidth).
926 We need to draw the gradient clipped to the stroke on a CGLayer first,
927 and then draw the layer on the GraphicsContext.
929 Tests: fast/canvas/canvas-strokeRect-gradient-shadow.html
930 svg/css/rect-gradient-stroke-shadow.svg
932 * platform/graphics/cg/GraphicsContextCG.cpp:
933 (WebCore::GraphicsContext::strokeRect):
935 2011-03-07 Justin Novosad <junov@chromium.org>
937 Reviewed by Kenneth Russell.
939 Fix for blurs behind bitmap images in Chromium, and boosting
942 https://bugs.webkit.org/show_bug.cgi?id=55410
943 https://bugs.webkit.org/show_bug.cgi?id=55506
945 No new tests. Covered by existing layout tests.
947 * platform/graphics/skia/GraphicsContextSkia.cpp:
948 (WebCore::GraphicsContext::setPlatformShadow): Turn on high quality shadows and fix shadow color
949 * platform/graphics/skia/ImageSkia.cpp:
950 (WebCore::paintSkBitmap): Propagate the draw looper from context to painter
952 2011-03-07 Andreas Kling <kling@webkit.org>
954 Unreviewed Mac build fix after r80508.
958 2011-03-07 Enrica Casucci <enrica@apple.com>
960 Unreviewed build fix.
962 Rolling back http://trac.webkit.org/changeset/80497 due to the
963 32-bit build failures.
965 * WebCore.xcodeproj/project.pbxproj:
966 * platform/mac/HTMLConverter.h: Removed.
967 * platform/mac/HTMLConverter.mm: Removed.
968 * platform/mac/PasteboardMac.mm:
969 (WebCore::Pasteboard::writeSelection):
971 2011-03-07 Andreas Kling <kling@webkit.org>
973 Reviewed by Benjamin Poulain.
975 FrameView::setBaseBackgroundColor: Pass Color argument as const-reference.
977 * page/FrameView.cpp:
978 (WebCore::FrameView::setBaseBackgroundColor):
981 2011-03-07 Adam Barth <abarth@webkit.org>
983 Reviewed by Dimitri Glazkov.
985 REGRESSION(r78147): Crash on http://gnarf.net/jquery/test/
986 https://bugs.webkit.org/show_bug.cgi?id=55894
988 The m_frame can disappear out from under us, and there's no point in
989 checking whether the load is complete in a non-existant frame.
991 Test: fast/parser/document-write-into-initial-document.html
994 (WebCore::Document::explicitClose):
996 2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>
998 Unreviewed, rolling out r80500.
999 http://trac.webkit.org/changeset/80500
1000 https://bugs.webkit.org/show_bug.cgi?id=55908
1002 Caused mysterious GYP error (Requested by abarth on #webkit).
1004 * WebCore.gyp/WebCore.gyp:
1007 2011-03-07 Adam Barth <abarth@webkit.org>
1009 Fix Chromium Mac build. This header should only be included when the
1012 * platform/cf/RunLoopTimerCF.cpp:
1014 2011-03-07 Adam Barth <abarth@webkit.org>
1016 Reviewed by Dimitri Glazkov.
1018 Add WML files to WebCore.gypi
1019 https://bugs.webkit.org/show_bug.cgi?id=55905
1021 * WebCore.gyp/WebCore.gyp:
1024 2011-03-07 Adrienne Walker <enne@google.com>
1026 Reviewed by James Robinson.
1028 [chromium] Add missing include to #define Skia parameter
1029 https://bugs.webkit.org/show_bug.cgi?id=55885
1031 * platform/graphics/chromium/ShaderChromium.h:
1033 2011-03-07 Chris Fleizach <cfleizach@apple.com>
1035 Reviewed by Beth Dakin.
1037 AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
1038 https://bugs.webkit.org/show_bug.cgi?id=55706
1041 * accessibility/AXObjectCache.cpp:
1042 (WebCore::AXObjectCache::rootObjectForFrame):
1043 * accessibility/AXObjectCache.h:
1044 * accessibility/AccessibilityScrollView.cpp:
1045 (WebCore::AccessibilityScrollView::isAttachment):
1046 (WebCore::AccessibilityScrollView::widgetForAttachmentView):
1047 * accessibility/AccessibilityScrollView.h:
1048 (WebCore::AccessibilityScrollView::firstChild):
1049 * accessibility/mac/AccessibilityObjectWrapper.mm:
1050 (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
1052 2011-03-07 Enrica Casucci <enrica@apple.com>
1054 Reviewed by Darin Adler.
1056 REGRESSION: Copied content loses formatting on paste to external apps.
1057 https://bugs.webkit.org/show_bug.cgi?id=47615
1058 <rdar://problem/9001214>
1060 This is a resubmission of a patch that was landed a while ago then rolled
1061 back because of a build failure on SnowLeopard and Leopard.
1063 This patch adds a way for WebKit2 to create NSAttributedStrings from
1064 a DOM range without using the AppKit api initWithDOMRange that internally
1065 needs to access the WebView. The NSAttributedString is needed to create
1066 RTF formats in the pasteboard.
1067 This is to be considered a first step, since in the future we want to have
1068 an implementation based on the TextIterator.
1070 * WebCore.xcodeproj/project.pbxproj: Added new file.
1071 * platform/mac/HTMLConverter.h: Added.
1072 * platform/mac/HTMLConverter.mm: Added.
1073 * platform/mac/PasteboardMac.mm:
1074 (WebCore::Pasteboard::writeSelection): We now use WebHTMLConverter
1075 class for WebKit2 to create the NSAttributedString from the DOM range.
1077 2011-03-07 Adam Barth <abarth@webkit.org>
1079 Reviewed by Dimitri Glazkov.
1081 Add some missing platform files to WebCore.gypi
1082 https://bugs.webkit.org/show_bug.cgi?id=55897
1084 There are a bunch more, but this is a start.
1086 * WebCore.gyp/WebCore.gyp:
1089 2011-03-07 Steve Block <steveblock@google.com>
1091 Reviewed by Jeremy Orlow.
1093 Rename JNIBridgeV8.cpp/h to JavaFieldV8.cpp/h
1094 https://bugs.webkit.org/show_bug.cgi?id=55879
1096 No new tests, refactoring only.
1098 * Android.v8bindings.mk:
1100 * bridge/jni/v8/JavaClassV8.cpp:
1101 * bridge/jni/v8/JavaClassV8.h:
1102 * bridge/jni/v8/JavaFieldV8.cpp: Renamed from Source/WebCore/bridge/jni/v8/JNIBridgeV8.cpp.
1103 (JavaField::JavaField):
1104 * bridge/jni/v8/JavaFieldV8.h: Renamed from Source/WebCore/bridge/jni/v8/JNIBridgeV8.h.
1105 (JSC::Bindings::JavaField::name):
1106 (JSC::Bindings::JavaField::type):
1107 (JSC::Bindings::JavaField::getJNIType):
1108 * bridge/jni/v8/JavaInstanceV8.cpp:
1109 * bridge/jni/v8/JavaNPObjectV8.cpp:
1111 2011-03-07 Daniel Cheng <dcheng@chromium.org>
1113 Reviewed by Tony Chang.
1115 Add plumbing for paste support to ChromiumDataObject::types()
1116 https://bugs.webkit.org/show_bug.cgi?id=55792
1118 This is a preliminary patch to support event.dataTransfer.items. This
1119 adds plumbing to support retrieving the types in a paste event. It also
1120 moves the check for files in a drag/paste up to ClipboardChromium, since
1121 internal code needs to be able to differentiate between actual files in
1122 a drag and someone that simply decided to use "Files" as a custom type
1125 Test: editing/pasteboard/onpaste-text-html-types.html
1127 * platform/chromium/ChromiumDataObject.cpp:
1128 (WebCore::ChromiumDataObject::types):
1129 (WebCore::ChromiumDataObject::containsFilenames):
1130 * platform/chromium/ChromiumDataObject.h:
1131 * platform/chromium/ClipboardChromium.cpp:
1132 (WebCore::ClipboardChromium::types):
1133 * platform/chromium/ClipboardMimeTypes.cpp:
1134 * platform/chromium/ClipboardMimeTypes.h:
1136 2011-03-07 Takayoshi Kochi <kochi@chromium.org>
1138 Reviewed by Tony Chang.
1140 [chromium] Use preferred locale information when choosing fallback
1141 font using fontconfig on Linux platform.
1142 http://bugs.webkit.org/show_bug.cgi?id=55453
1144 No new tests, as it depends on ICU and locale setting, so it will be
1145 covered by Chromium side.
1147 * platform/chromium/PlatformBridge.h:
1148 * platform/graphics/chromium/FontCacheLinux.cpp:
1150 2011-03-07 Adam Barth <abarth@webkit.org>
1152 Reviewed by Eric Seidel.
1154 Add gobject, cpp, and objc bindings to WebCore.gypi
1155 https://bugs.webkit.org/show_bug.cgi?id=55892
1157 These are also excluded from the Chromium build but needed for various
1160 * WebCore.gyp/WebCore.gyp:
1163 2011-03-07 Sergey Glazunov <serg.glazunov@gmail.com>
1165 Reviewed by Dimitri Glazkov.
1167 Node::checkAddChild and Node::checkReplaceChild shouldn't change the owner document of a node
1168 https://bugs.webkit.org/show_bug.cgi?id=55803
1170 Test: fast/dom/dom-method-document-change.html
1172 * dom/ContainerNode.cpp:
1173 (WebCore::ContainerNode::insertBefore):
1174 (WebCore::ContainerNode::replaceChild):
1175 (WebCore::ContainerNode::appendChild):
1177 (WebCore::Node::checkReplaceChild):
1178 (WebCore::Node::checkAddChild):
1181 2011-03-07 Sheriff Bot <webkit.review.bot@gmail.com>
1183 Unreviewed, rolling out r80484.
1184 http://trac.webkit.org/changeset/80484
1185 https://bugs.webkit.org/show_bug.cgi?id=55891
1187 requires Chromium DEPS roll (Requested by dcheng on #webkit).
1189 * platform/chromium/ChromiumDataObject.cpp:
1190 (WebCore::ChromiumDataObject::types):
1191 * platform/chromium/ChromiumDataObject.h:
1192 (WebCore::ChromiumDataObject::containsFilenames):
1193 * platform/chromium/ClipboardChromium.cpp:
1194 (WebCore::ClipboardChromium::types):
1195 * platform/chromium/ClipboardMimeTypes.cpp:
1196 * platform/chromium/ClipboardMimeTypes.h:
1198 2011-03-07 Adam Barth <abarth@webkit.org>
1200 Reviewed by Dimitri Glazkov.
1202 Add missing bindings/js files to WebCore.gypi
1203 https://bugs.webkit.org/show_bug.cgi?id=55888
1205 These files are excluded from the Chromium build but needed for the Mac
1210 2011-03-07 Daniel Cheng <dcheng@chromium.org>
1212 Reviewed by Tony Chang.
1214 Add plumbing for paste support to ChromiumDataObject::types()
1215 https://bugs.webkit.org/show_bug.cgi?id=55792
1217 This is a preliminary patch to support event.dataTransfer.items. This
1218 adds plumbing to support retrieving the types in a paste event. It also
1219 moves the check for files in a drag/paste up to ClipboardChromium, since
1220 internal code needs to be able to differentiate between actual files in
1221 a drag and someone that simply decided to use "Files" as a custom type
1224 Test: editing/pasteboard/onpaste-text-html-types.html
1226 * platform/chromium/ChromiumDataObject.cpp:
1227 (WebCore::ChromiumDataObject::types):
1228 (WebCore::ChromiumDataObject::containsFilenames):
1229 * platform/chromium/ChromiumDataObject.h:
1230 * platform/chromium/ClipboardChromium.cpp:
1231 (WebCore::ClipboardChromium::types):
1232 * platform/chromium/ClipboardMimeTypes.cpp:
1233 * platform/chromium/ClipboardMimeTypes.h:
1235 2011-03-07 Joseph Pecoraro <joepeck@webkit.org>
1237 Reviewed by Kenneth Rohde Christiansen.
1239 Viewport Warning/Error Messages Are Now Inaccurate
1240 https://bugs.webkit.org/show_bug.cgi?id=53707
1242 Correct and improve the error messages for viewport parsing.
1244 Tests: fast/viewport/viewport-warnings-1.html
1245 fast/viewport/viewport-warnings-2.html
1246 fast/viewport/viewport-warnings-3.html
1247 fast/viewport/viewport-warnings-4.html
1248 fast/viewport/viewport-warnings-5.html
1249 fast/viewport/viewport-warnings-6.html
1251 * dom/ViewportArguments.cpp:
1252 (WebCore::numericPrefix):
1253 (WebCore::findSizeValue): remove incorrect device-width / height tips.
1254 (WebCore::setViewportFeature): report a warning for an unrecognized key.
1255 (WebCore::viewportErrorMessageTemplate): added template for unrecognized key.
1256 (WebCore::viewportErrorMessageLevel): classify an unrecognized key is an error.
1257 * dom/ViewportArguments.h: removed no longer used warnings.
1259 2011-03-07 James Robinson <jamesr@chromium.org>
1261 Reviewed by Kenneth Russell.
1263 [chromium] Separate the update and draw portions of LayerRendererChromium's drawLayers function
1264 https://bugs.webkit.org/show_bug.cgi?id=54047
1266 This splits up LayerRendererChromium::drawLayers() into two phases,
1267 one that updates layers and one that actually draws them. Most of the
1268 patch is moving the bodies of drawLayers() and updateLayersRecursive()
1269 into smaller helper functions.
1271 The main entry point is renamed updateAndDrawLayers(), but otherwise
1272 has the same signature as drawLayers() did. Internally it does the
1275 1.) Updates the root layer's contents
1276 2.) Updates the root layer's scrollbars
1277 3.) Updates the RenderSurface tree and the contents of all child
1279 4.) Draws the root layer and root layer scrollbars
1280 5.) Draws all child layers using the previously updated
1281 CCLayerImpl/RenderSurface data.
1283 A few things still need to be done after this patch to complete the separation
1284 of the update and draw step, but they can happen in later patches:
1285 *) The root layer and root layer scrollbars contents should be
1286 uploaded to textures at draw time, not update time.
1287 *) The RenderSurface tree should be updated at draw time, not update
1290 Covered by the compositing/ tests.
1292 * platform/graphics/chromium/LayerRendererChromium.cpp:
1293 (WebCore::LayerRendererChromium::LayerRendererChromium):
1294 (WebCore::LayerRendererChromium::updateRootLayerContents):
1295 (WebCore::LayerRendererChromium::updateRootLayerScrollbars):
1296 (WebCore::LayerRendererChromium::drawRootLayer):
1297 (WebCore::LayerRendererChromium::updateAndDrawLayers):
1298 (WebCore::LayerRendererChromium::updateLayers):
1299 (WebCore::LayerRendererChromium::drawLayers):
1300 (WebCore::LayerRendererChromium::getFramebufferPixels):
1301 (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
1302 (WebCore::LayerRendererChromium::updateContentsRecursive):
1303 (WebCore::LayerRendererChromium::drawLayer):
1304 * platform/graphics/chromium/LayerRendererChromium.h:
1305 (WebCore::LayerRendererChromium::visibleRectSize):
1306 * platform/graphics/chromium/RenderSurfaceChromium.cpp:
1307 (WebCore::RenderSurfaceChromium::drawSurface):
1308 * platform/graphics/chromium/cc/CCLayerImpl.cpp:
1309 * platform/graphics/chromium/cc/CCLayerImpl.h:
1311 2011-03-07 Adam Barth <abarth@webkit.org>
1313 Reviewed by Eric Seidel.
1316 https://bugs.webkit.org/show_bug.cgi?id=55887
1318 These files should be in order. This is preparation for adding in the
1323 2011-03-07 Csaba Osztrogonác <ossy@webkit.org>
1325 Unreviewed buildfix after r80478.
1327 * dom/Document.cpp: Add suggested parentheses to make GCC happy.
1328 (WebCore::Document::didReceiveTask):
1330 2011-03-07 Yong Li <yoli@rim.com>
1332 Reviewed by Darin Adler.
1334 Defer ScriptExecutionContext::Task's in Document when page loading is deferred.
1335 Schedule them with timer when page loading is resumed. The tasks will be performed
1336 in the original order. This fixes the problem that database callbacks could be missed
1337 when page loading was deferred.
1338 https://bugs.webkit.org/show_bug.cgi?id=49401
1340 Manual test added: manual-tests/database-callback-deferred.html.
1343 (WebCore::Document::Document):
1344 (WebCore::Document::~Document):
1345 (WebCore::Document::didReceiveTask):
1346 (WebCore::Document::postTask):
1347 (WebCore::Document::pendingTasksTimerFired):
1348 (WebCore::Document::willDeferLoading):
1349 (WebCore::Document::didResumeLoading):
1351 * manual-tests/database-callback-deferred.html: Added.
1352 * page/PageGroupLoadDeferrer.cpp:
1353 (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
1354 (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
1356 2011-03-07 Antti Koivisto <antti@apple.com>
1358 Reviewed by Sam Weinig.
1360 Use HashMaps for caching primitive values
1361 https://bugs.webkit.org/show_bug.cgi?id=55873
1363 Most documents use only small subset of cacheable primitive values. By replacing
1364 fixed size cache arrays with HashMaps we can reduce the constant memory usage while also
1365 expanding the range of cacheable values.
1367 * css/CSSPrimitiveValueCache.cpp:
1368 (WebCore::CSSPrimitiveValueCache::CSSPrimitiveValueCache):
1369 (WebCore::CSSPrimitiveValueCache::createIdentifierValue):
1370 (WebCore::CSSPrimitiveValueCache::createColorValue):
1371 (WebCore::CSSPrimitiveValueCache::createValue):
1372 * css/CSSPrimitiveValueCache.h:
1374 2011-03-07 Steve Block <steveblock@google.com>
1376 Reviewed by Jeremy Orlow.
1378 Split JNIBridgeJSC.cpp/h into JavaArrayJSC.cpp/h and JavaFieldJSC.cpp/h
1379 https://bugs.webkit.org/show_bug.cgi?id=55881
1381 No new tests, refactoring only.
1383 * Android.jscbindings.mk:
1385 * WebCore.xcodeproj/project.pbxproj:
1386 * bridge/jni/jsc/JNIBridgeJSC.cpp: Removed.
1387 * bridge/jni/jsc/JNIBridgeJSC.h: Removed.
1388 * bridge/jni/jsc/JNIUtilityPrivate.cpp:
1389 * bridge/jni/jsc/JavaClassJSC.cpp:
1390 * bridge/jni/jsc/JavaClassJSC.h:
1391 * bridge/jni/jsc/JavaInstanceJSC.cpp:
1393 2011-03-07 Sam Weinig <sam@webkit.org>
1395 Reviewed by Anders Carlsson.
1397 Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
1398 https://bugs.webkit.org/show_bug.cgi?id=55827
1400 * loader/EmptyClients.h:
1401 (WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForResponse):
1402 * loader/FrameLoaderClient.h:
1403 * loader/MainResourceLoader.cpp:
1404 (WebCore::MainResourceLoader::didReceiveResponse):
1405 * loader/PolicyChecker.cpp:
1406 (WebCore::PolicyChecker::checkContentPolicy):
1407 * loader/PolicyChecker.h:
1408 Rename FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
1409 and pass the entire response, instead of just the MIMEType.
1411 2011-03-07 Eric Carlson <eric.carlson@apple.com>
1413 Reviewed by Darin Adler.
1415 Add API to enumerate/delete files downloaded for <audio> and <video>
1416 https://bugs.webkit.org/show_bug.cgi?id=55267
1417 <rdar://problem/9049280>
1419 No new tests, this is just more plumbing.
1421 * html/HTMLMediaElement.cpp:
1422 (WebCore::HTMLMediaElement::getSitesInMediaCache): Make static, call MediaPlayer static method.
1423 (WebCore::HTMLMediaElement::clearMediaCache): Ditto.
1424 (WebCore::HTMLMediaElement::clearMediaCacheForSite): Ditto.
1425 * html/HTMLMediaElement.h:
1427 * platform/graphics/MediaPlayer.cpp:
1428 (WebCore::MediaPlayerFactory::MediaPlayerFactory): Add new media engine factory functions.
1429 (WebCore::addMediaEngine): Ditto.
1430 (WebCore::MediaPlayer::getSitesInMediaCache): Call static method on all installed media engines.
1431 (WebCore::MediaPlayer::clearMediaCache): Ditto.
1432 (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
1433 * platform/graphics/MediaPlayer.h:
1435 * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
1436 (WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine): Update for MediaEngineRegistrar change.
1438 * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1439 (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Ditto.
1441 * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
1442 (WebCore::MediaPlayerPrivatePhonon::registerMediaEngine): Ditto.
1444 * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
1445 (WebCore::MediaPlayerPrivateQt::registerMediaEngine): Ditto.
1447 * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
1448 (WebCore::MediaPlayerPrivateQuickTimeVisualContext::registerMediaEngine): Ditto.
1450 * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
1451 (WebCore::MediaPlayerPrivate::registerMediaEngine): Ditto.
1453 2011-03-07 Steve Block <steveblock@google.com>
1455 Reviewed by Jeremy Orlow.
1457 Split JNIBridge.cpp/h into JavaString.h and JavaMethod.cpp/h
1458 https://bugs.webkit.org/show_bug.cgi?id=55774
1460 No new tests, refactoring only.
1462 * Android.jscbindings.mk:
1463 * Android.v8bindings.mk:
1466 * WebCore.xcodeproj/project.pbxproj:
1467 * bridge/jni/JavaMethod.cpp:
1468 (JavaMethod::JavaMethod):
1469 (JavaMethod::~JavaMethod):
1471 (JavaMethod::signature):
1472 (JavaMethod::JNIReturnType):
1473 (JavaMethod::methodID):
1474 * bridge/jni/JavaMethod.h:
1475 (JSC::Bindings::JavaMethod::name):
1476 (JSC::Bindings::JavaMethod::returnType):
1477 (JSC::Bindings::JavaMethod::parameterAt):
1478 (JSC::Bindings::JavaMethod::numParameters):
1479 (JSC::Bindings::JavaMethod::isStatic):
1480 * bridge/jni/JavaString.h:
1481 (JSC::Bindings::JavaString::JavaString):
1482 (JSC::Bindings::JavaString::utf8):
1483 (JSC::Bindings::JavaString::length):
1484 (JSC::Bindings::JavaString::impl):
1485 * bridge/jni/jni_jsobject.mm:
1486 * bridge/jni/jsc/JNIBridgeJSC.h:
1487 * bridge/jni/v8/JNIBridgeV8.h:
1488 * bridge/jni/v8/JavaClassV8.cpp:
1489 * bridge/jni/v8/JavaClassV8.h:
1490 * bridge/jni/v8/JavaInstanceV8.cpp:
1492 2011-03-07 Jeremy Orlow <jorlow@chromium.org>
1494 Reviewed by Steve Block.
1496 Add source to IDBCursor, objectStore to IDBIndex, and remove storeName
1497 https://bugs.webkit.org/show_bug.cgi?id=55812
1499 This brings us in line with what's in the spec:
1500 http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html
1502 * storage/IDBCursor.cpp:
1503 (WebCore::IDBCursor::create):
1504 (WebCore::IDBCursor::IDBCursor):
1505 (WebCore::IDBCursor::source):
1506 * storage/IDBCursor.h:
1507 * storage/IDBCursor.idl:
1508 * storage/IDBCursorWithValue.cpp:
1509 (WebCore::IDBCursorWithValue::create):
1510 (WebCore::IDBCursorWithValue::IDBCursorWithValue):
1511 * storage/IDBCursorWithValue.h:
1512 * storage/IDBIndex.cpp:
1513 (WebCore::IDBIndex::IDBIndex):
1514 * storage/IDBIndex.h:
1515 (WebCore::IDBIndex::create):
1516 (WebCore::IDBIndex::objectStore):
1517 * storage/IDBIndex.idl:
1518 * storage/IDBObjectStore.cpp:
1519 (WebCore::IDBObjectStore::createIndex):
1520 (WebCore::IDBObjectStore::index):
1521 * storage/IDBRequest.cpp:
1522 (WebCore::IDBRequest::onSuccess):
1524 2011-03-07 Chris Fleizach <cfleizach@apple.com>
1526 Reviewed by Beth Dakin.
1528 AX: kAXCellForColumnAndRowParameterizedAttribute doesn't work ARIA grids with colspans
1529 https://bugs.webkit.org/show_bug.cgi?id=55735
1531 The ARIA grid implementation needed to verify the row/column range of a cell instead of
1532 assuming a 1-1 mapping between children and row/column.
1534 Test: platform/mac/accessibility/aria-table-with-colspan-cells.html
1536 * accessibility/AccessibilityARIAGrid.cpp:
1537 (WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
1539 2011-03-07 Andrei Popescu <andreip@google.com>
1541 Reviewed by Steve Block.
1543 IDBRequest::onSuccess(IDBObjectStore*) should be removed as it is unused.
1544 IDBObjectStore objects used to be created asynchronously, so we needed
1545 this method to be invoked, with the new object store as the parameter,
1546 whenever the creation succeeded. The spec has changed so that IDBObjectStore
1547 objects are created synchronously, so this method is no longer needed.
1548 https://bugs.webkit.org/show_bug.cgi?id=55777
1550 No new tests, just refactoring.
1552 * storage/IDBCallbacks.h:
1553 * storage/IDBRequest.cpp:
1554 * storage/IDBRequest.h:
1556 2011-03-04 Steve Block <steveblock@google.com>
1558 Reviewed by Jeremy Orlow.
1560 JavaParameter should be removed
1561 https://bugs.webkit.org/show_bug.cgi?id=55772
1563 No new tests, refactoring only.
1565 * bridge/jni/JNIBridge.cpp:
1566 (JavaMethod::JavaMethod):
1567 (JavaMethod::~JavaMethod):
1568 (JavaMethod::signature):
1569 * bridge/jni/JNIBridge.h:
1570 (JSC::Bindings::JavaMethod::parameterAt):
1571 (JSC::Bindings::JavaMethod::numParameters):
1572 * bridge/jni/JNIUtility.h:
1573 * bridge/jni/jsc/JavaInstanceJSC.cpp:
1574 (JavaInstance::invokeMethod):
1575 * bridge/jni/v8/JNIUtilityPrivate.cpp:
1576 (JSC::Bindings::convertNPVariantToJValue):
1577 * bridge/jni/v8/JNIUtilityPrivate.h:
1578 * bridge/jni/v8/JavaInstanceV8.cpp:
1579 (JavaInstance::invokeMethod):
1581 2011-03-07 Antti Koivisto <antti@apple.com>
1583 Reviewed by Oliver Hunt.
1585 REGRESSION (r79574): fast/dom/global-constructors.html failing on Windows 7 Release (Tests) bots
1586 https://bugs.webkit.org/show_bug.cgi?id=55166
1587 <rdar://problem/9050430>
1589 Make CSS primitive value cache per-document.
1591 Test: http/tests/security/cross-origin-css-primitive.html
1598 * WebCore.vcproj/WebCore.vcproj:
1599 * WebCore.xcodeproj/project.pbxproj:
1600 * css/CSSComputedStyleDeclaration.cpp:
1601 (WebCore::valueForNinePieceImage):
1602 (WebCore::zoomAdjustedPixelValue):
1603 (WebCore::zoomAdjustedNumberValue):
1604 (WebCore::zoomAdjustedPixelValueForLength):
1605 (WebCore::valueForReflection):
1606 (WebCore::getPositionOffsetValue):
1607 (WebCore::CSSComputedStyleDeclaration::currentColorOrValidColor):
1608 (WebCore::getBorderRadiusCornerValue):
1609 (WebCore::computedTransform):
1610 (WebCore::getDelayValue):
1611 (WebCore::getDurationValue):
1612 (WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
1613 (WebCore::CSSComputedStyleDeclaration::valueForShadow):
1614 (WebCore::valueForFamily):
1615 (WebCore::renderTextDecorationFlagsToCSSValue):
1616 (WebCore::fillRepeatToCSSValue):
1617 (WebCore::fillSizeToCSSValue):
1618 (WebCore::contentToCSSValue):
1619 (WebCore::counterToCSSValue):
1620 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1621 * css/CSSParser.cpp:
1622 (WebCore::CSSParser::parseSheet):
1623 (WebCore::CSSParser::parseRule):
1624 (WebCore::CSSParser::parseKeyframeRule):
1625 (WebCore::CSSParser::parseValue):
1626 (WebCore::CSSParser::parseColor):
1627 (WebCore::CSSParser::parseSelector):
1628 (WebCore::CSSParser::parseDeclaration):
1629 (WebCore::CSSParser::setStyleSheet):
1630 (WebCore::CSSParser::parseWCSSInputProperty):
1631 (WebCore::parseBackgroundClip):
1632 (WebCore::CSSParser::parseFillShorthand):
1633 (WebCore::CSSParser::parsePage):
1634 (WebCore::CSSParser::parseSizeParameter):
1635 (WebCore::CSSParser::parseContent):
1636 (WebCore::CSSParser::parseAttr):
1637 (WebCore::CSSParser::parseBackgroundColor):
1638 (WebCore::CSSParser::parseFillPositionXY):
1639 (WebCore::CSSParser::parseFillPosition):
1640 (WebCore::CSSParser::parseFillRepeat):
1641 (WebCore::CSSParser::parseFillSize):
1642 (WebCore::CSSParser::parseFillProperty):
1643 (WebCore::CSSParser::parseAnimationDelay):
1644 (WebCore::CSSParser::parseAnimationDirection):
1645 (WebCore::CSSParser::parseAnimationDuration):
1646 (WebCore::CSSParser::parseAnimationFillMode):
1647 (WebCore::CSSParser::parseAnimationIterationCount):
1648 (WebCore::CSSParser::parseAnimationName):
1649 (WebCore::CSSParser::parseAnimationPlayState):
1650 (WebCore::CSSParser::parseAnimationProperty):
1651 (WebCore::CSSParser::parseTransformOriginShorthand):
1652 (WebCore::CSSParser::parseAnimationTimingFunction):
1653 (WebCore::CSSParser::parseDashboardRegions):
1654 (WebCore::CSSParser::parseCounterContent):
1655 (WebCore::CSSParser::parseShape):
1656 (WebCore::CSSParser::parseFont):
1657 (WebCore::CSSParser::parseFontFamily):
1658 (WebCore::CSSParser::parseFontStyle):
1659 (WebCore::CSSParser::parseFontVariant):
1660 (WebCore::CSSParser::parseFontWeight):
1661 (WebCore::ShadowParseContext::ShadowParseContext):
1662 (WebCore::ShadowParseContext::commitLength):
1663 (WebCore::ShadowParseContext::commitStyle):
1664 (WebCore::CSSParser::parseShadow):
1665 (WebCore::CSSParser::parseReflect):
1666 (WebCore::BorderImageParseContext::BorderImageParseContext):
1667 (WebCore::BorderImageParseContext::commitNumber):
1668 (WebCore::BorderImageParseContext::commitBorderImage):
1669 (WebCore::CSSParser::parseBorderImage):
1670 (WebCore::CSSParser::parseBorderRadius):
1671 (WebCore::CSSParser::parseCounter):
1672 (WebCore::parseDeprecatedGradientPoint):
1673 (WebCore::parseDeprecatedGradientColorStop):
1674 (WebCore::CSSParser::parseDeprecatedGradient):
1675 (WebCore::valueFromSideKeyword):
1676 (WebCore::parseGradientColorOrKeyword):
1677 (WebCore::CSSParser::parseLinearGradient):
1678 (WebCore::CSSParser::parseRadialGradient):
1679 (WebCore::CSSParser::parseGradientColorStops):
1680 (WebCore::CSSParser::parseTransform):
1681 (WebCore::CSSParser::parseTransformOrigin):
1682 (WebCore::CSSParser::parseTextEmphasisStyle):
1684 (WebCore::CSSParser::primitiveValueCache):
1685 * css/CSSPrimitiveValue.cpp:
1686 * css/CSSPrimitiveValue.h:
1687 (WebCore::CSSPrimitiveValue::createIdentifier):
1688 (WebCore::CSSPrimitiveValue::createColor):
1689 (WebCore::CSSPrimitiveValue::create):
1690 * css/CSSPrimitiveValueCache.cpp: Added.
1691 (WebCore::CSSPrimitiveValueCache::CSSPrimitiveValueCache):
1692 (WebCore::CSSPrimitiveValueCache::~CSSPrimitiveValueCache):
1693 (WebCore::CSSPrimitiveValueCache::createIdentifierValue):
1694 (WebCore::CSSPrimitiveValueCache::createColorValue):
1695 (WebCore::CSSPrimitiveValueCache::createValue):
1696 * css/CSSPrimitiveValueCache.h: Added.
1697 (WebCore::CSSPrimitiveValueCache::create):
1698 (WebCore::CSSPrimitiveValueCache::createValue):
1700 (WebCore::Document::cssPrimitiveValueCache):
1703 2011-03-06 Adam Barth <abarth@webkit.org>
1705 Reviewed by Eric Seidel.
1707 Filter sources in WebCore GYP build for Mac
1708 https://bugs.webkit.org/show_bug.cgi?id=55857
1710 This patch removes a large number of files that do not build as part of
1711 the Mac build. I'm not fully sold on this method of
1712 including/excluding files, but it's the "gyp way" so we should probably
1715 This patch also sets xcode_list_excluded_files to 0, which removes the
1716 excluded files from the Xcode project file, which is necessary in order
1717 to prevent the header map feature from including the wrong header file.
1721 2011-03-07 Ryuan Choi <ryuan.choi@samsung.com>
1723 Unreviewed EFL build fix.
1725 [EFL] Build break on Debug build.
1726 https://bugs.webkit.org/show_bug.cgi?id=55858
1728 * platform/efl/RenderThemeEfl.cpp:
1729 (WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):
1731 2011-03-06 Adam Barth <abarth@webkit.org>
1733 Reviewed by Eric Seidel.
1735 Add webcore_derived_source_files to WebCore.gypi
1736 https://bugs.webkit.org/show_bug.cgi?id=55856
1738 This is the list of files generated by the Mac port. It's possible
1739 other ports generate a different list of files.
1744 2011-03-06 Naoki Takano <takano.naoki@gmail.com>
1746 Reviewed by Kent Tamura.
1748 Input type=number spin buttons remain invisible but functional after div changed from hidden to visible.
1749 https://bugs.webkit.org/show_bug.cgi?id=55839
1750 http://crbug.com/73866
1751 http://crbug.com/62527
1753 We also need style change for m_innerSpinButton not only for m_outerSpinBuggon when styleDidChange() is called.
1755 Test: fast/forms/input-appearance-spinbutton-visibility.html
1757 * rendering/RenderTextControlSingleLine.cpp:
1758 (WebCore::RenderTextControlSingleLine::styleDidChange):
1760 2011-03-06 Naoki Takano <takano.naoki@gmail.com>
1762 Reviewed by Kent Tamura.
1764 [Chromium] Autocomplete suggestion extends out of window (and onto second monitor)
1765 https://bugs.webkit.org/show_bug.cgi?id=54795
1767 Implement width clip logic according to browser screen width and popup window width. This fix is enough for Win and Mac, but there is a problem in Linux. Because WebScreenInfoFactory::screenInfo() can get only merged screen size, not the screen size where the browser exists.
1769 Test: manual-tests/popup-width-restriction-within-screen.html
1771 * manual-tests/popup-width-restriction-within-screen.html: Added.
1772 * platform/chromium/PopupMenuChromium.cpp:
1773 (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Implement the width clip logic according to screen width.
1775 2011-03-06 Yuta Kitamura <yutak@chromium.org>
1777 Reviewed by Kent Tamura.
1779 Add SHA-1 for new WebSocket protocol
1780 https://bugs.webkit.org/show_bug.cgi?id=55039
1782 * ForwardingHeaders/wtf/SHA1.h: Added.
1784 2011-03-06 Eric Carlson <eric.carlson@apple.com>
1786 Reviewed by Antti Koivisto.
1788 QuickTime based media engines should respect private browsing mode
1789 https://bugs.webkit.org/show_bug.cgi?id=55848
1791 No new tests, it is only possible to test this by manually deleting and monitoring the
1792 the Quicktime caches.
1794 * html/HTMLMediaElement.cpp:
1795 (WebCore::HTMLMediaElement::privateBrowsingStateDidChange): Add logging.
1797 * platform/graphics/MediaPlayer.cpp:
1798 (WebCore::MediaPlayer::MediaPlayer): Initialize m_privateBrowsing.
1799 (WebCore::MediaPlayer::loadWithNextMediaEngine): Set privacy mode on new media engine.
1800 (WebCore::MediaPlayer::setPrivateBrowsingMode): Stash setting in m_privateBrowsing.
1801 * platform/graphics/MediaPlayer.h:
1802 * platform/graphics/MediaPlayerPrivate.h:
1803 (WebCore::MediaPlayerPrivateInterface::setPrivateBrowsingMode):
1805 * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
1806 * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1807 (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit): Initialize m_privateBrowsing.
1808 (WebCore::MediaPlayerPrivateQTKit::createQTMovie): Pass private browsing attribute when
1810 (WebCore::MediaPlayerPrivateQTKit::setPrivateBrowsingMode): New, store privacy setting in
1811 m_privateBrowsing and set movie attribute.
1813 * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
1814 (WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
1815 Initialize m_privateBrowsing.
1816 (WebCore::MediaPlayerPrivateQuickTimeVisualContext::setPrivateBrowsingMode): New, store
1817 privacy setting in m_privateBrowsing and call QTMovie.
1818 * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
1820 * platform/graphics/win/QTMovie.cpp:
1821 (QTMoviePrivate::QTMoviePrivate): Initialize m_privateBrowsing.
1822 (QTMovie::load):Pass private browsing property when creating new movie.
1823 (QTMovie::setPrivateBrowsingMode): New, store privacy setting in m_privateBrowsing and
1825 * platform/graphics/win/QTMovie.h:
1827 2011-03-06 Daniel Bates <dbates@rim.com>
1829 Reviewed by Darin Adler.
1831 style.borderSpacing always returns empty string
1832 https://bugs.webkit.org/show_bug.cgi?id=54816
1834 Teach CSSMutableStyleDeclaration::getPropertyValue() how to reconstitute
1835 the value for border-spacing from the value of the WebKit internal CSS
1836 property -webkit-border-horizontal-spacing and -webkit-border-vertical-spacing.
1838 The CSS property border-spacing describes the horizontal and vertical border
1839 spacing for an HTML Table element. Notice, WebKit internally represents the value
1840 of this property as two properties: -webkit-border-horizontal-spacing and
1841 -webkit-border-vertical-spacing, for the horizontal and vertical border spacing,
1842 respectively. And WebKit doesn't know to reconstitute these internal properties.
1843 Therefore style.borderSpacing always returns the empty string.
1845 Test: fast/css/table-border-spacing.html
1847 * css/CSSMutableStyleDeclaration.cpp:
1848 (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
1849 (WebCore::CSSMutableStyleDeclaration::borderSpacingValue): Added.
1850 * css/CSSMutableStyleDeclaration.h:
1852 2011-03-06 Dan Bernstein <mitz@apple.com>
1854 Reviewed by Oliver Hunt.
1856 <rdar://problem/9093327> Implement -hyphenate-limit-{before,after}
1857 https://bugs.webkit.org/show_bug.cgi?id=55850
1859 Tests: fast/css/parsing-hyphenate-limit.html
1860 fast/text/hyphenate-limit-before-after.html
1862 * css/CSSComputedStyleDeclaration.cpp:
1863 (WebCore::computedProperties) Updated this array with the new properties and some old properties
1864 that it was missing.
1865 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added
1866 CSSPropertyWebkitHyphenateLimit{Before,After}.
1868 * css/CSSParser.cpp:
1869 (WebCore::CSSParser::parseValue): Parse -webkit-hyphenate-limit-{before,after}, allowing
1870 'auto' and non-negative integers.
1872 * css/CSSPropertyNames.in: Added -webkit-hyphenate-limit-{before,after}.
1874 * css/CSSStyleSelector.cpp:
1875 (WebCore::CSSStyleSelector::applyProperty): Handle CSSPropertyWebkitHyphenateLimit{Before,After}.
1877 * rendering/RenderBlockLineLayout.cpp:
1878 (WebCore::tryHyphenating): Added minimum prefix and suffix length parameters and checks to only
1879 allow hyphenation if the prefix and the suffix are sufficiently long.
1880 (WebCore::RenderBlock::findNextLineBreak): Pass the limits to tryHyphenating().
1882 * rendering/style/RenderStyle.cpp:
1883 (WebCore::RenderStyle::diff): A difference in hyphenation limits is a layout difference.
1885 * rendering/style/RenderStyle.h:
1886 (WebCore::InheritedFlags::hyphenationLimitBefore): Added.
1887 (WebCore::InheritedFlags::hyphenationLimitAfter): Added.
1888 (WebCore::InheritedFlags::setHyphenationLimitBefore): Added.
1889 (WebCore::InheritedFlags::setHyphenationLimitAfter): Added.
1890 (WebCore::InheritedFlags::initialHyphenationLimitBefore): Added. Returns -1, which is the
1891 representation of 'auto'.
1892 (WebCore::InheritedFlags::initialHyphenationLimitAfter): Ditto.
1894 * rendering/style/StyleRareInheritedData.cpp:
1895 (WebCore::StyleRareInheritedData::StyleRareInheritedData): Initialize hyphenation limits.
1896 (WebCore::StyleRareInheritedData::operator==): Compare hyphenation limits.
1897 * rendering/style/StyleRareInheritedData.h:
1899 2011-03-06 Jessie Berlin <jberlin@apple.com>
1901 Reviewed by Sam Weinig.
1903 WebKit2: Use CFNetwork Sessions API.
1904 https://bugs.webkit.org/show_bug.cgi?id=55435.
1906 When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
1907 Private Browsing Storage Session.
1910 Add the new WKSI functions.
1911 * platform/mac/WebCoreSystemInterface.h:
1913 * platform/mac/WebCoreSystemInterface.mm:
1916 * platform/mac/CookieJar.mm:
1918 If USE(CFURLSTORAGESESSIONS) and there is a Private Browsing Cookie Storage, call into WKSI.
1919 Otherwise, behave the same as before.
1920 (WebCore::cookieRequestHeaderFieldValue):
1922 (WebCore::setCookies):
1924 (WebCore::cookiesEnabled):
1926 (WebCore::getRawCookies):
1928 (WebCore::deleteCookie):
1931 * platform/network/CookieStorage.h:
1932 * platform/network/cf/CookieStorageCFNet.cpp:
1933 (WebCore::privateBrowsingCookieStorage):
1934 Keep track of the Private Browsing Cookie Storage in a locally defined static inside a
1935 function instead of at the global scope.
1936 (WebCore::currentCookieStorage):
1937 Use privateBrowsingCookieStorage.
1938 (WebCore::setCurrentCookieStorage):
1940 (WebCore::setCookieStoragePrivateBrowsingEnabled):
1941 If USE(CFURLSTORAGESESSIONS), send the Private Browsing Storage Session to
1942 wkCreatePrivateInMemoryHTTPCookieStorage.
1943 * platform/network/mac/CookieStorageMac.mm:
1944 (WebCore::privateBrowsingCookieStorage):
1945 Keep track of the Private Browsing Cookie Storage.
1946 (WebCore::setCookieStoragePrivateBrowsingEnabled):
1947 If USE(CFURLSTORAGESESSIONS), then set or clear privateBrowsingCookieStorage().
1948 Added a FIXME to observe changes to the Private Browsing Cookie Storage when it is defined.
1950 * platform/network/mac/ResourceHandleMac.mm:
1951 (WebCore::shouldRelaxThirdPartyCookiePolicy):
1952 Refactor the logic to determine whether or not to relax the third party cookie policy here.
1953 If USE(CFURLSTORAGESESSIONS), then get the information from the privateBrowsingCookieStorage.
1954 (WebCore::ResourceHandle::createNSURLConnection):
1955 Use shouldRelaxThirdPartyCookiePolicy.
1956 (WebCore::ResourceHandle::loadResourceSynchronously):
1959 2011-03-05 Sheriff Bot <webkit.review.bot@gmail.com>
1961 Unreviewed, rolling out r80428.
1962 http://trac.webkit.org/changeset/80428
1963 https://bugs.webkit.org/show_bug.cgi?id=55833
1965 Broke SnowLeopard (Requested by xan_ on #webkit).
1967 * plugins/gtk/PluginViewGtk.cpp:
1968 (WebCore::PluginView::handlePostReadFile):
1970 2011-03-01 Martin Robinson <mrobinson@igalia.com>
1972 Reviewed by Xan Lopez.
1974 [GTK] Windowless plugins override the view cursor
1975 https://bugs.webkit.org/show_bug.cgi?id=55531
1977 manual test: manual-tests/plugins/windowless.html
1979 * platform/gtk/WidgetGtk.cpp:
1980 (WebCore::Widget::setCursor): Call into the ChromeClient implementation now.
1981 * plugins/gtk/PluginViewGtk.cpp:
1982 (WebCore::PluginView::initXEvent): Instead of setting the window for windowless
1983 plugin events, set the window value to none. This method is also used to send
1984 focus in / focus out events to windowed plugins, but this is not one of the plugin
1985 types where the window parameter matters. This matches what Mozilla does. Also
1986 pass in the display of the widget itself, not the default display.
1987 (WebCore::PluginView::handleMouseEvent): When the cursor leaves the plugin area,
1989 (WebCore::PluginView::platformGetValue): Clean up this section slightly. Give the
1990 widget the top-level window explicitly. This matches Mozilla.
1992 2011-03-05 Martin Robinson <mrobinson@igalia.com>
1994 Reviewed by Xan Lopez.
1996 [GTK] http/tests/plugins/post-url-file.html fails on GTK+
1997 https://bugs.webkit.org/show_bug.cgi?id=55826
1999 Correct the implementation of handlePostReadFile which uses GIO APIs and
2000 actually resizes the buffer to fit the entire size of the file data. This
2001 was likely leading to memory corruption until now.
2003 * plugins/gtk/PluginViewGtk.cpp:
2004 (WebCore::PluginView::handlePostReadFile): Fix this method.
2006 2011-03-05 Mikhail Naganov <mnaganov@chromium.org>
2008 Reviewed by Pavel Feldman.
2010 Web Inspector: [Chromium] Allow dynamic enabling of detailed heap profiles.
2011 https://bugs.webkit.org/show_bug.cgi?id=55824
2013 Detailed heap profiles can be now enabled by typing "leakz" in Profiles tab.
2015 * inspector/front-end/DetailedHeapshotView.js:
2016 (WebInspector.DetailedHeapshotView.prototype.isDetailedSnapshot):
2017 * inspector/front-end/ProfilesPanel.js:
2018 (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
2019 (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
2020 (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
2021 (WebInspector.ProfilesPanel.prototype.handleShortcut):
2022 (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint.hideHint):
2023 (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint):
2024 (WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles):
2025 (WebInspector.ProfilesPanel.prototype._recognizeKeyboardCombo):
2027 2011-03-05 Qi Zhang <qi.2.zhang@nokia.com>
2029 Reviewed by Laszlo Gombos.
2031 [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
2032 https://bugs.webkit.org/show_bug.cgi?id=48636
2034 Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.
2039 2011-03-05 Pavel Feldman <pfeldman@chromium.org>
2041 Not reviewed: adding null check to prevent inspector tests from failing.
2043 * inspector/front-end/TextViewer.js:
2044 (WebInspector.TextEditorGutterChunk.prototype.get offsetTop):
2045 (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
2047 2011-03-05 Pavel Feldman <pfeldman@chromium.org>
2049 Not reviewed: chromium rebaseline, flaky test fix.
2051 * inspector/front-end/BreakpointManager.js:
2052 (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
2053 (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
2054 (WebInspector.DOMBreakpointView.prototype._format.formatters.s):
2055 (WebInspector.DOMBreakpointView.prototype._format.append):
2056 (WebInspector.DOMBreakpointView.prototype._format):
2058 2011-03-04 Pavel Podivilov <podivilov@chromium.org>
2060 Reviewed by Yury Semikhatsky.
2062 Web Inspector: [chromium] pause when script is running is broken.
2063 https://bugs.webkit.org/show_bug.cgi?id=55762
2065 * inspector/CodeGeneratorInspector.pm:
2067 2011-03-05 Adam Barth <abarth@webkit.org>
2069 Reviewed by Dimitri Glazkov.
2071 Add Derived Sources to WebCore GYP build
2072 https://bugs.webkit.org/show_bug.cgi?id=55813
2074 Adding the derived source action to the GYP file required tweaking
2075 DerivedSources.make. I'm not sure how DerivedSources.make worked
2076 before beause these paths were incorrectly based.
2078 * DerivedSources.make:
2079 * gyp/generate-derived-sources.sh: Added.
2082 2011-03-04 Pavel Feldman <pfeldman@chromium.org>
2084 Reviewed by Yury Semikhatsky.
2086 Web Inspector: fix layout tests flakiness.
2087 https://bugs.webkit.org/show_bug.cgi?id=55816
2089 - Order of issuing of evaluateForTestInFrontend was not guaranteed on the backend side (InspectorAgent side)
2090 - Order of dispatching using timeouts was guaranteed via queueing. Source of all kinds of pains on SnowLeopard Release (inspector.js)
2092 * inspector/CodeGeneratorInspector.pm:
2093 * inspector/InspectorAgent.cpp:
2094 (WebCore::InspectorAgent::InspectorAgent):
2095 (WebCore::InspectorAgent::disconnectFrontend):
2096 (WebCore::InspectorAgent::populateScriptObjects):
2097 (WebCore::InspectorAgent::evaluateForTestInFrontend):
2098 (WebCore::InspectorAgent::issueEvaluateForTestCommands):
2099 * inspector/InspectorAgent.h:
2100 * inspector/front-end/TimelinePanel.js:
2101 (WebInspector.TimelinePanel.FormattedRecord):
2102 * inspector/front-end/inspector.js:
2103 (WebInspector.dispatch):
2105 2011-03-05 Adam Barth <abarth@webkit.org>
2107 Reviewed by Dimitri Glazkov.
2109 WebCore GYP build should generate fewer than 10,000 compile errors per file
2110 https://bugs.webkit.org/show_bug.cgi?id=55810
2112 This patch adds some missing include paths. We need to figure out how
2113 to handle separate include paths per port. It's clear that
2114 ForwardingHeaders are only useful for Mac, but it's less clear how to
2120 2011-03-05 Dan Bernstein <mitz@apple.com>
2122 Reviewed by Cameron Zwarich.
2124 <rdar://problem/9082946> Make the Core Text code path in GlyphPage::fill() more robust
2125 https://bugs.webkit.org/show_bug.cgi?id=55817
2127 * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
2128 (WebCore::GlyphPage::fill): When determining if a CTRun uses the primary font, compare against
2129 a CGFont obtained from Core Text for the primary font. This CGFont may be different from
2130 the CGFont stored in the FontPlatformData.
2132 2011-03-05 Ilya Sherman <isherman@chromium.org>
2134 Reviewed by Darin Adler.
2136 HTMLInputElement::setValue() should schedule change event when the element is focused.
2137 Refactored tracking of "changed since last change event" state from renderer to DOM.In service of https://code.google.com/p/chromium/issues
2138 In service of https://code.google.com/p/chromium/issues/detail?id=42716
2139 https://bugs.webkit.org/show_bug.cgi?id=53160
2141 Test: fast/forms/onchange-change-type.html
2142 Test: fast/forms/onchange-setvalueforuser.html
2146 (WebCore::Document::setFocusedNode):
2148 (WebCore::Element::wasChangedSinceLastFormControlChangeEvent): Added.
2149 (WebCore::Element::setChangedSinceLastFormControlChangeEvent): Added.
2150 * html/HTMLFormControlElement.cpp:
2151 (WebCore::HTMLFormControlElement::HTMLFormControlElement):
2152 (WebCore::HTMLFormControlElement::wasChangedSinceLastFormControlChangeEvent): Added.
2153 (WebCore::HTMLFormControlElement::setChangedSinceLastFormControlChangeEvent): Added.
2154 (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): Also clear the "changed since last change event" flag.
2155 (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): Also set the "changed since last change event" flag.
2156 * html/HTMLFormControlElement.h:
2157 * html/HTMLInputElement.cpp:
2158 (WebCore::HTMLInputElement::updateType): Also clear the "changed since last change event" flag.
2159 (WebCore::HTMLInputElement::setValue):
2160 For a focused text field, dispatch an input event, but delay the change event until the field loses focus.
2161 (WebCore::HTMLInputElement::defaultEventHandler):
2162 (WebCore::HTMLInputElement::stepUpFromRenderer):
2163 * html/shadow/TextControlInnerElements.cpp:
2164 (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
2165 * rendering/RenderTextControl.cpp:
2166 (WebCore::RenderTextControl::RenderTextControl):
2167 (WebCore::RenderTextControl::subtreeHasChanged):
2168 * rendering/RenderTextControl.h:
2169 * rendering/RenderTextControlMultiLine.cpp:
2170 (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
2171 * rendering/RenderTextControlSingleLine.cpp:
2172 (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
2173 * wml/WMLInputElement.cpp:
2174 (WebCore::WMLInputElement::WMLInputElement):
2175 (WebCore::WMLInputElement::defaultEventHandler):
2176 * wml/WMLInputElement.h:
2177 (WebCore::WMLInputElement::wasChangedSinceLastFormControlChangeEvent): Added.
2178 (WebCore::WMLInputElement::setChangedSinceLastFormControlChangeEvent): Added.
2180 2011-03-04 Xianzhu Wang <wangxianzhu@google.com>
2182 Reviewed by Adam Barth.
2184 Remove fake request loading of SVGImage to avoid MainResourceLoader
2185 leak. The frame->init() already ensures initialization of the
2188 https://bugs.webkit.org/show_bug.cgi?id=55017
2190 Test: fast/images/svg-image-leak-loader.html
2192 * svg/graphics/SVGImage.cpp:
2193 (WebCore::SVGImage::dataChanged):
2195 2011-03-04 Mike Reed <reed@google.com>
2197 Reviewed by Mihai Parparita.
2199 [Chromium] fast/canvas/canvas-arc-360-winding.html fails on Linux and Windows
2200 https://bugs.webkit.org/show_bug.cgi?id=49477
2202 * platform/graphics/skia/PathSkia.cpp:
2203 (WebCore::Path::addArc):
2205 2011-03-04 Jia Pu <jpu@apple.com>
2207 Reviewed by Darin Adler.
2209 On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
2210 https://bugs.webkit.org/show_bug.cgi?id=55717
2211 <rdar://problem/9018127>
2213 manual-test: manual-tests/platforms/mac/autocorrection/autocorrection-in-iframe.html
2215 Previously, the bounding box passed into EditorClient::showCorrectionPanel() is in the frame's
2216 coordinate. This is incorrect when the correction occurs in an iframe. This patch added code
2217 to convert the bounding box to window coordinate using ScrollView::contentToWindow().
2220 (WebCore::Range::getBoundingClientRect):
2221 (WebCore::Range::boundingRect):
2223 * editing/Editor.cpp:
2224 (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
2225 (WebCore::Editor::correctionPanelTimerFired):
2226 (WebCore::Editor::windowRectForRange):
2228 * manual-tests/autocorrection/autocorrection-in-iframe.html: Added.
2229 * manual-tests/autocorrection/document-for-iframe-test.html: Added.
2231 2011-03-04 Jia Pu <jpu@apple.com>
2233 Reviewed by Darin Adler.
2235 Those checking in Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited() should be done with VisiblePosition::isNull().
2236 https://bugs.webkit.org/show_bug.cgi?id=55731
2238 No new tests. There's no behavioral change.
2240 This patch improved clarity and readability of Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited().
2242 * editing/Editor.cpp:
2243 (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
2245 2011-03-04 John Bauman <jbauman@chromium.org>
2247 Reviewed by Kenneth Russell.
2249 [chromium] premultipliedAlpha WebGL context attribute is ignored.
2250 https://bugs.webkit.org/show_bug.cgi?id=55411
2252 Update compositor to set the blending of each layer correctly.
2254 Test: compositing/webgl/webgl-nonpremultiplied-blend.html
2256 * platform/graphics/chromium/CanvasLayerChromium.cpp:
2257 (WebCore::CanvasLayerChromium::CanvasLayerChromium):
2258 (WebCore::CanvasLayerChromium::draw):
2259 * platform/graphics/chromium/CanvasLayerChromium.h:
2260 * platform/graphics/chromium/ContentLayerChromium.cpp:
2261 (WebCore::ContentLayerChromium::draw):
2262 * platform/graphics/chromium/LayerRendererChromium.cpp:
2263 (WebCore::LayerRendererChromium::drawLayers):
2264 * platform/graphics/chromium/WebGLLayerChromium.cpp:
2265 (WebCore::WebGLLayerChromium::setContext):
2267 2011-03-04 Adam Barth <abarth@webkit.org>
2269 Reviewed by Eric Seidel.
2271 WebCore GYP build should link with the correct frameworks
2272 https://bugs.webkit.org/show_bug.cgi?id=55804
2276 2011-03-04 Adam Barth <abarth@webkit.org>
2278 Reviewed by Eric Seidel.
2280 WebCore GYP build should Check For Inappropriate Files in Framework
2281 https://bugs.webkit.org/show_bug.cgi?id=55806
2285 2011-03-04 Dimitri Glazkov <dglazkov@chromium.org>
2287 Reviewed by Adam Barth.
2289 Add skeletal WebCore.gyp
2290 https://bugs.webkit.org/show_bug.cgi?id=55802
2292 This doesn't yet build, but the basic structure is there.
2294 * WebCore.gypi: Added headers and include directories variables.
2295 * gyp/WebCore.gyp: Added.
2297 2011-03-04 Adam Barth <abarth@webkit.org>
2299 Reviewed by Dimitri Glazkov.
2301 Remove unneeded round-trips through ../Source in the Chromium GYP build
2302 https://bugs.webkit.org/show_bug.cgi?id=55795
2304 This is just cleanup work, but it was bugging me.
2306 * WebCore.gyp/WebCore.gyp:
2308 2011-03-04 Mike Reed <reed@google.com>
2310 Reviewed by James Robinson.
2312 Option to use skia's native text drawing APIs when drawing text
2313 on Windows, rather than from outlines using drawPath(). This will
2314 only have a significant effect when the skia-gpu backend is enabled.
2315 https://bugs.webkit.org/show_bug.cgi?id=55609
2317 No new tests. This is disabled by default. When enabled, it will draw
2318 essentially the same, but with slightly different antialiased edges, due
2319 to differences between the current scanconverter and GDI's font scaler.
2320 When enabled, we will have to recalibrate layouttest image results.
2322 * platform/graphics/skia/SkiaFontWin.cpp:
2323 (WebCore::skiaDrawText):
2324 (WebCore::setupPaintForFont):
2325 (WebCore::paintSkiaText):
2327 2011-03-04 Adrienne Walker <enne@google.com>
2329 Reviewed by James Robinson.
2331 [chromium] Fix texture stride issues on large content and image layers.
2332 https://bugs.webkit.org/show_bug.cgi?id=55679
2334 This was an error caused during the refactoring in r80081.
2336 Tests: LayoutTests/compositing/tiling/huge-layer-img.html
2338 * platform/graphics/chromium/ContentLayerChromium.cpp:
2339 (WebCore::ContentLayerChromium::updateTexture):
2340 * platform/graphics/chromium/ImageLayerChromium.cpp:
2341 (WebCore::ImageLayerChromium::updateTextureIfNeeded):
2343 2011-03-04 Sheriff Bot <webkit.review.bot@gmail.com>
2345 Unreviewed, rolling out r80379.
2346 http://trac.webkit.org/changeset/80379
2347 https://bugs.webkit.org/show_bug.cgi?id=55799
2349 "Breaks leopard compile (implicit conversion)" (Requested by
2350 tonyg-cr on #webkit).
2352 * css/CSSStyleSelector.cpp:
2353 (WebCore::convertToLength):
2354 (WebCore::CSSStyleSelector::applyProperty):
2355 (WebCore::CSSStyleSelector::createTransformOperations):
2356 * platform/Length.h:
2357 (WebCore::Length::Length):
2358 (WebCore::Length::operator==):
2359 (WebCore::Length::operator!=):
2360 (WebCore::Length::rawValue):
2361 (WebCore::Length::type):
2362 (WebCore::Length::quirk):
2363 (WebCore::Length::setValue):
2364 (WebCore::Length::setRawValue):
2365 (WebCore::Length::calcFloatValue):
2366 (WebCore::Length::isZero):
2367 (WebCore::Length::blend):
2368 * rendering/AutoTableLayout.cpp:
2369 (WebCore::AutoTableLayout::recalcColumn):
2370 (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
2371 * rendering/FixedTableLayout.cpp:
2372 (WebCore::FixedTableLayout::calcWidthArray):
2374 2011-03-04 Jessie Berlin <jberlin@apple.com>
2376 Reviewed by Darin Adler.
2378 WebKit2: Use CFNetwork Sessions API.
2379 https://bugs.webkit.org/show_bug.cgi?id=55435.
2381 Add in the CFURLSTORAGESESSIONS guards that I incorrectly left out because the code was
2382 contained within guards that made USE(CFURLSTORAGESESSIONS) always be true.
2384 * platform/network/cf/ResourceHandleCFNet.cpp:
2385 (WebCore::makeFinalRequest):
2386 (WebCore::ResourceHandle::willSendRequest):
2387 * platform/network/cf/ResourceRequestCFNet.cpp:
2388 * platform/network/mac/ResourceHandleMac.mm:
2389 (WebCore::ResourceHandle::createNSURLConnection):
2390 (WebCore::ResourceHandle::willSendRequest):
2391 * platform/network/mac/ResourceRequestMac.mm:
2393 2011-03-04 Yuqiang Xian <yuqiang.xian@intel.com>
2395 Reviewed by Darin Adler.
2397 improve layout performance by reducing the traversal time of the floating objects
2398 https://bugs.webkit.org/show_bug.cgi?id=55440
2400 We observered large overhead on traversing the floating objects list
2401 in logicalLeftOffsetForLine() and logicalRightOffsetForLine() especially
2402 when the list becomes enormous, for example in the default 30x30 maze test
2403 from http://ie.microsoft.com/testdrive/Performance/MazeSolver/Default.html
2404 there're >3700 floating objects. When placing a new floating object the
2405 entire list (from begin to end) is traversed for multiple times.
2406 There's a low hanging fruit to reduce the chances to do the traversal
2407 which is especially applicable in logicalLeftOffsetForLine and logicalRightOffsetForLine.
2408 As the two routines either cares about FloatLeft objects or FloatRight objects only,
2409 if we know there's no corresponding type floating objects in the list
2410 we can avoid the traversal actually. One thing we could do is to record
2411 the number of FloatLeft objects and the number of FloatRight objects and
2412 add a check before doing the traversal. This can reduce the time by 45%
2413 to resolve the 30x30 Maze measured on N470 Netbook MeeGo using latest
2414 Chromium browser 11 (from 503s to 269s).
2416 No new tests, relying on existing layout tests.
2418 * rendering/RenderBlock.cpp:
2419 (WebCore::RenderBlock::~RenderBlock):
2420 (WebCore::RenderBlock::addOverflowFromFloats):
2421 (WebCore::RenderBlock::repaintOverhangingFloats):
2422 (WebCore::RenderBlock::paintFloats):
2423 (WebCore::RenderBlock::selectionGaps):
2424 (WebCore::RenderBlock::insertFloatingObject):
2425 (WebCore::RenderBlock::removeFloatingObject):
2426 (WebCore::RenderBlock::removeFloatingObjectsBelow):
2427 (WebCore::RenderBlock::positionNewFloats):
2428 (WebCore::RenderBlock::positionNewFloatOnLine):
2429 (WebCore::RenderBlock::logicalLeftOffsetForLine):
2430 (WebCore::RenderBlock::logicalRightOffsetForLine):
2431 (WebCore::RenderBlock::nextFloatLogicalBottomBelow):
2432 (WebCore::RenderBlock::lowestFloatLogicalBottom):
2433 (WebCore::RenderBlock::clearFloats):
2434 (WebCore::RenderBlock::addOverhangingFloats):
2435 (WebCore::RenderBlock::addIntrudingFloats):
2436 (WebCore::RenderBlock::containsFloat):
2437 (WebCore::RenderBlock::hitTestFloats):
2438 (WebCore::RenderBlock::adjustForBorderFit):
2439 (WebCore::RenderBlock::FloatingObjects::clear):
2440 (WebCore::RenderBlock::FloatingObjects::increaseObjectsCount):
2441 (WebCore::RenderBlock::FloatingObjects::decreaseObjectsCount):
2442 * rendering/RenderBlock.h:
2443 (WebCore::RenderBlock::containsFloats):
2444 (WebCore::RenderBlock::FloatingObjects::FloatingObjects):
2445 (WebCore::RenderBlock::FloatingObjects::hasLeftObjects):
2446 (WebCore::RenderBlock::FloatingObjects::hasRightObjects):
2447 (WebCore::RenderBlock::FloatingObjects::set):
2448 * rendering/RenderBlockLineLayout.cpp:
2449 (WebCore::RenderBlock::layoutInlineChildren):
2450 (WebCore::RenderBlock::matchedEndLine):
2452 2011-03-04 Rik Cabanier <cabanier@gmail.com>
2454 Reviewed by David Hyatt.
2456 Fix that allows fixed length values to be floating point
2457 https://bugs.webkit.org/show_bug.cgi?id=52699
2459 * WebCore.xcodeproj/project.pbxproj:
2460 * css/CSSStyleSelector.cpp:
2461 (WebCore::convertToLength):
2462 (WebCore::convertToIntLength):
2463 (WebCore::convertToFloatLength):
2464 (WebCore::CSSStyleSelector::applyProperty):
2465 (WebCore::CSSStyleSelector::createTransformOperations):
2466 * platform/Length.h:
2467 (WebCore::Length::Length):
2468 (WebCore::Length::operator==):
2469 (WebCore::Length::operator!=):
2470 (WebCore::Length::rawValue):
2471 (WebCore::Length::type):
2472 (WebCore::Length::quirk):
2473 (WebCore::Length::setValue):
2474 (WebCore::Length::calcFloatValue):
2475 (WebCore::Length::isZero):
2476 (WebCore::Length::blend):
2477 (WebCore::Length::getIntValue):
2478 (WebCore::Length::getFloatValue):
2479 * rendering/AutoTableLayout.cpp:
2480 (WebCore::AutoTableLayout::recalcColumn):
2481 (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
2482 * rendering/FixedTableLayout.cpp:
2483 (WebCore::FixedTableLayout::calcWidthArray):
2485 2011-03-04 Steve Falkenburg <sfalken@apple.com>
2487 Reviewed by Jon Honeycutt.
2489 Adopt VersionStamper tool for Windows WebKit DLLs
2490 https://bugs.webkit.org/show_bug.cgi?id=55784
2492 We now use a tool to stamp the version number onto the Apple WebKit DLLs
2493 during the post-build step.
2495 * WebCore.vcproj/QTMovieWin.rc: Removed.
2496 * WebCore.vcproj/QTMovieWin.vcproj:
2497 * WebCore.vcproj/QTMovieWinPostBuild.cmd: Stamp version with VersionStamper.
2498 * WebCore.vcproj/QTMovieWinPreBuild.cmd: Don't run auto-version.sh. We don't use autoversion.h in this project.
2499 * WebCore.vcproj/WebCoreMediaQT.vsprops: Remove unnecessary include paths for resource files.
2501 2011-03-04 Cosmin Truta <ctruta@chromium.org>
2503 Reviewed by Adam Barth.
2505 Clarify comment about potential memory leak in SVGImage
2506 https://bugs.webkit.org/show_bug.cgi?id=55362
2508 No functionality change. No new tests.
2510 * svg/graphics/SVGImage.cpp:
2511 (WebCore::SVGImage::dataChanged):
2513 2011-03-04 Jessie Berlin <jberlin@apple.com>
2515 Reviewed by Maciej Stachowiak.
2517 WebKit2: Use CFNetwork Sessions API.
2518 https://bugs.webkit.org/show_bug.cgi?id=55435.
2520 When Private Browsing is enabled, get the cached url response from the cache associated with
2521 the Private Browsing Storage Session.
2524 Export the symbol for ResourceHandle::privateBrowsingStorageSession.
2526 2011-03-04 Steve Block <steveblock@google.com>
2528 Reviewed by Jeremy Orlow.
2530 JSC and V8 versions of Java bridge should share JobjectWrapper
2531 https://bugs.webkit.org/show_bug.cgi?id=55763
2533 No new tests, refactoring only.
2535 * Android.jscbindings.mk:
2536 * Android.v8bindings.mk:
2539 * WebCore.xcodeproj/project.pbxproj:
2540 * bridge/jni/JobjectWrapper.cpp:
2541 (JobjectWrapper::JobjectWrapper):
2542 (JobjectWrapper::~JobjectWrapper):
2543 * bridge/jni/JobjectWrapper.h:
2544 (JSC::Bindings::JobjectWrapper::instance):
2545 (JSC::Bindings::JobjectWrapper::setInstance):
2546 (JSC::Bindings::JobjectWrapper::ref):
2547 (JSC::Bindings::JobjectWrapper::deref):
2548 * bridge/jni/jsc/JNIBridgeJSC.cpp:
2549 (JavaField::JavaField):
2550 (JavaArray::JavaArray):
2551 * bridge/jni/jsc/JNIBridgeJSC.h:
2552 * bridge/jni/jsc/JavaInstanceJSC.cpp:
2553 (JavaInstance::JavaInstance):
2554 * bridge/jni/jsc/JavaInstanceJSC.h:
2556 2011-03-04 Patrick Gansterer <paroga@webkit.org>
2558 Reviewed by Nikolas Zimmermann.
2560 Move shared code into SVGStyledTransformableElement::svgAttributeChanged
2561 https://bugs.webkit.org/show_bug.cgi?id=55771
2563 All sub classes of SVGStyledTransformableElement request a relayout
2564 the same way. So move that code into the common base class.
2566 * svg/SVGCircleElement.cpp:
2567 (WebCore::SVGCircleElement::svgAttributeChanged):
2568 * svg/SVGEllipseElement.cpp:
2569 (WebCore::SVGEllipseElement::svgAttributeChanged):
2570 * svg/SVGForeignObjectElement.cpp:
2571 (WebCore::SVGForeignObjectElement::svgAttributeChanged):
2572 * svg/SVGGElement.cpp:
2573 (WebCore::SVGGElement::svgAttributeChanged):
2574 * svg/SVGImageElement.cpp:
2575 (WebCore::SVGImageElement::svgAttributeChanged):
2576 * svg/SVGLineElement.cpp:
2577 (WebCore::SVGLineElement::svgAttributeChanged):
2578 * svg/SVGPathElement.cpp:
2579 (WebCore::SVGPathElement::svgAttributeChanged):
2580 * svg/SVGPolyElement.cpp:
2581 (WebCore::SVGPolyElement::svgAttributeChanged):
2582 * svg/SVGRectElement.cpp:
2583 (WebCore::SVGRectElement::svgAttributeChanged):
2584 * svg/SVGStyledTransformableElement.cpp:
2585 (WebCore::SVGStyledTransformableElement::svgAttributeChanged):
2586 * svg/SVGStyledTransformableElement.h:
2587 * svg/SVGUseElement.cpp:
2588 (WebCore::SVGUseElement::svgAttributeChanged):
2590 2011-03-03 John Abd-El-Malek <jam@chromium.org>
2592 Reviewed by Dimitri Glazkov.
2594 [chromium] Get rid of IsContentFiltered flags since they're not used anymore
2595 https://bugs.webkit.org/show_bug.cgi?id=55748
2597 * platform/network/chromium/ResourceResponse.cpp:
2598 (WebCore::ResourceResponse::doPlatformCopyData):
2599 (WebCore::ResourceResponse::doPlatformAdopt):
2600 * platform/network/chromium/ResourceResponse.h:
2601 (WebCore::ResourceResponse::ResourceResponse):
2603 2011-03-03 Timothy Hatcher <timothy@apple.com>
2605 Export SerializedScriptValue::create(JSC::ExecState* exec, JSC::JSValue value).
2607 Reviewed by Darin Adler.
2609 * WebCore.exp.in: Added __ZN7WebCore21SerializedScriptValue6createEPN3JSC9ExecStateENS1_7JSValueE.
2611 2011-03-04 Pavel Podivilov <podivilov@chromium.org>
2613 Reviewed by Yury Semikhatsky.
2615 Web Inspector: extract all code that depends on source mapping from SourceFrame.
2616 https://bugs.webkit.org/show_bug.cgi?id=55464
2618 Extract all dependencies on DebuggerModel and ScriptsPanel to a delegate class
2619 to encapsulate source mapping aspects from SourceFrame.
2621 * inspector/front-end/ResourceView.js:
2622 (WebInspector.ResourceView.createResourceView):
2623 (WebInspector.SourceFrameDelegateForResourcesPanel):
2624 (WebInspector.SourceFrameDelegateForResourcesPanel.prototype.requestContent):
2625 * inspector/front-end/ScriptsPanel.js:
2626 (WebInspector.ScriptsPanel.prototype._createSourceFrame):
2627 (WebInspector.SourceFrameDelegateForScriptsPanel):
2628 * inspector/front-end/SourceFrame.js:
2629 (WebInspector.SourceFrame):
2630 (WebInspector.SourceFrame.prototype.show):
2631 (WebInspector.SourceFrame.prototype._createTextViewer):
2632 (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
2633 (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
2634 (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
2635 (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition):
2636 (WebInspector.SourceFrame.prototype._contextMenu.else.setBreakpointEnabled):
2637 (WebInspector.SourceFrame.prototype._contextMenu):
2638 (WebInspector.SourceFrame.prototype._mouseDown):
2639 (WebInspector.SourceFrame.prototype._mouseMove):
2640 (WebInspector.SourceFrame.prototype._hidePopup):
2641 (WebInspector.SourceFrame.prototype._mouseHover):
2642 (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
2643 (WebInspector.SourceFrame.prototype._showPopup):
2644 (WebInspector.SourceFrame.prototype._doubleClick):
2645 (WebInspector.SourceFrame.prototype._didEditLine):
2646 (WebInspector.SourceFrameDelegate):
2647 (WebInspector.SourceFrameDelegate.prototype.requestContent):
2648 (WebInspector.SourceFrameDelegate.prototype.debuggingSupported):
2649 (WebInspector.SourceFrameDelegate.prototype.setBreakpoint):
2650 (WebInspector.SourceFrameDelegate.prototype.removeBreakpoint):
2651 (WebInspector.SourceFrameDelegate.prototype.updateBreakpoint):
2652 (WebInspector.SourceFrameDelegate.prototype.findBreakpoint):
2653 (WebInspector.SourceFrameDelegate.prototype.continueToLine):
2654 (WebInspector.SourceFrameDelegate.prototype.canEditScriptSource):
2655 (WebInspector.SourceFrameDelegate.prototype.editScriptSource):
2656 (WebInspector.SourceFrameDelegate.prototype.debuggerPaused):
2657 (WebInspector.SourceFrameDelegate.prototype.evaluate):
2658 (WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):
2660 2011-03-04 Andrey Kosyakov <caseq@chromium.org>
2662 Reviewed by Pavel Feldman.
2664 Web Inspector: [Extensions API] maintain own, unique & persistent identifiers for resources.
2665 https://bugs.webkit.org/show_bug.cgi?id=55686
2667 - Use internal ids for resources in extension server.
2668 - Log errors in inspector tests.
2670 * inspector/front-end/ExtensionServer.js:
2671 (WebInspector.ExtensionServer):
2672 (WebInspector.ExtensionServer.prototype.resetResources):
2673 (WebInspector.ExtensionServer.prototype._notifyResourceFinished):
2674 (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
2675 (WebInspector.ExtensionServer.prototype._onGetHAR):
2676 (WebInspector.ExtensionServer.prototype._onGetResourceContent):
2677 (WebInspector.ExtensionServer.prototype._resourceId):
2678 (WebInspector.ExtensionServer.prototype._resourceById):
2679 * inspector/front-end/HAREntry.js:
2680 (WebInspector.HARLog):
2681 (WebInspector.HARLog.prototype._convertResource):
2682 * inspector/front-end/NetworkPanel.js:
2683 (WebInspector.NetworkPanel.prototype._reset):
2685 2011-03-04 Andrey Kosyakov <caseq@chromium.org>
2687 Reviewed by Pavel Feldman.
2689 Web Inspector: exceptions when building context menu in network panel
2690 https://bugs.webkit.org/show_bug.cgi?id=55678
2692 * inspector/front-end/DataGrid.js:
2693 (WebInspector.DataGrid.prototype.dataGridNodeFromNode):
2694 (WebInspector.DataGrid.prototype.dataGridNodeFromPoint):
2695 * inspector/front-end/NetworkPanel.js:
2696 (WebInspector.NetworkPanel.prototype._contextMenu):
2698 2011-03-04 Ilya Sherman <isherman@chromium.org>
2700 Reviewed by James Robinson.
2702 Override paintScrollCorner() for FramelessScrollView to forego any custom scrollbar corner rendering.
2703 This was previously done in ScrollbarThemeChromium, but we also need this on the Mac when the ScrollView
2704 is a FramelessScrollView -- which is mostly just for Autofill.
2705 In service of http://crbug.com/73772 (crash)
2706 https://bugs.webkit.org/show_bug.cgi?id=55557
2708 No tests added because this fix is Chromium-specific and the code is currently untestable from within WebKit.
2709 In particular, DRT crashes when trying to render a FramelessScrollView.
2711 * platform/ScrollbarTheme.h:
2712 (WebCore::ScrollbarTheme::paintScrollCorner): Body moved to static function defaultPaintScrollCorner().
2713 (WebCore::ScrollbarTheme::defaultPaintScrollCorner): Added.
2714 * platform/chromium/FramelessScrollView.cpp:
2715 (WebCore::FramelessScrollView::paintContents):
2716 (WebCore::FramelessScrollView::paintScrollCorner): Fix implementation moved to here from ScrollbarThemeChromium
2717 * platform/chromium/FramelessScrollView.h:
2718 * platform/chromium/ScrollbarThemeChromium.cpp:
2719 * platform/chromium/ScrollbarThemeChromium.h:
2721 2011-03-04 Yury Semikhatsky <yurys@chromium.org>
2723 Reviewed by Pavel Feldman.
2725 Web Inspector: move dispatching of didCommitLoad to agents into InspectorInstrumentation
2726 https://bugs.webkit.org/show_bug.cgi?id=55770
2728 * inspector/InspectorAgent.cpp:
2729 (WebCore::InspectorAgent::InspectorAgent):
2730 (WebCore::InspectorAgent::didCommitLoad):
2731 * inspector/InspectorCSSAgent.cpp:
2732 (WebCore::InspectorCSSAgent::InspectorCSSAgent):
2733 (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
2734 * inspector/InspectorCSSAgent.h:
2735 * inspector/InspectorDatabaseAgent.cpp:
2736 (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
2737 * inspector/InspectorInstrumentation.cpp:
2738 (WebCore::InspectorInstrumentation::didCommitLoadImpl):
2739 * inspector/InspectorInstrumentation.h:
2740 (WebCore::InspectorInstrumentation::didCommitLoad):
2741 * inspector/InspectorProfilerAgent.cpp:
2742 (WebCore::InspectorProfilerAgent::create):
2743 (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
2744 (WebCore::InspectorProfilerAgent::~InspectorProfilerAgent):
2745 (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
2746 (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
2747 (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
2748 (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
2749 * inspector/InspectorProfilerAgent.h:
2750 * inspector/InstrumentingAgents.h:
2751 (WebCore::InstrumentingAgents::InstrumentingAgents):
2752 (WebCore::InstrumentingAgents::inspectorCSSAgent):
2753 (WebCore::InstrumentingAgents::setInspectorCSSAgent):
2754 (WebCore::InstrumentingAgents::inspectorDOMStorageAgent):
2755 (WebCore::InstrumentingAgents::setInspectorDOMStorageAgent):
2756 (WebCore::InstrumentingAgents::inspectorDatabaseAgent):
2757 (WebCore::InstrumentingAgents::setInspectorDatabaseAgent):
2758 (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent):
2759 (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
2760 (WebCore::InstrumentingAgents::inspectorDebuggerAgent):
2761 (WebCore::InstrumentingAgents::setInspectorDebuggerAgent):
2762 (WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent):
2763 (WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent):
2764 (WebCore::InstrumentingAgents::inspectorProfilerAgent):
2765 (WebCore::InstrumentingAgents::setInspectorProfilerAgent):
2767 2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>
2769 Reviewed by Yury Semikhatsky.
2771 Web Inspector: rename RuntimeAgent's function from releaseWrapperObjectGroup to releaseObjectGroup.
2772 https://bugs.webkit.org/show_bug.cgi?id=55773
2774 * inspector/CodeGeneratorInspector.pm:
2775 * inspector/InjectedScript.cpp:
2776 (WebCore::InjectedScript::releaseObjectGroup):
2777 * inspector/InjectedScript.h:
2778 * inspector/InjectedScriptHost.cpp:
2779 (WebCore::InjectedScriptHost::releaseObjectGroup):
2780 * inspector/InjectedScriptHost.h:
2781 * inspector/InjectedScriptSource.js:
2783 * inspector/Inspector.idl:
2784 * inspector/InspectorConsoleAgent.cpp:
2785 (WebCore::InspectorConsoleAgent::clearConsoleMessages):
2786 * inspector/InspectorRuntimeAgent.cpp:
2787 (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
2788 * inspector/InspectorRuntimeAgent.h:
2789 * inspector/front-end/ConsoleView.js:
2790 (WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
2791 (WebInspector.ConsoleView.prototype.completions):
2792 * inspector/front-end/PropertiesSidebarPane.js:
2793 * inspector/front-end/SourceFrame.js:
2794 (WebInspector.SourceFrame.prototype._hidePopup):
2795 * inspector/front-end/WatchExpressionsSidebarPane.js:
2796 (WebInspector.WatchExpressionsSection.prototype.update):
2798 2011-03-02 Andrey Adaikin <aandrey@google.com>
2800 Reviewed by Pavel Feldman.
2802 Web Inspector: Gutter height should be 100% when few lines are displayed
2803 https://bugs.webkit.org/show_bug.cgi?id=55574
2805 * inspector/front-end/SourceFrame.js:
2806 (WebInspector.SourceFrame.prototype._startEditing):
2807 * inspector/front-end/TextViewer.js:
2808 (WebInspector.TextViewer.prototype._syncScroll):
2809 (WebInspector.TextEditorGutterPanel.prototype._expandChunks):
2810 (WebInspector.TextEditorGutterPanel.prototype.textChanged):
2811 (WebInspector.TextEditorGutterPanel.prototype.syncClientHeight):
2812 * inspector/front-end/textViewer.css:
2813 (.text-editor-lines):
2814 (.text-editor-contents .inner-container):
2815 (.webkit-line-number):
2817 2011-03-04 Andrey Adaikin <aandrey@google.com>
2819 Reviewed by Pavel Feldman.
2821 Web Inspector: [Text editor] Do bisect to find visible chunks
2822 https://bugs.webkit.org/show_bug.cgi?id=55685
2824 * inspector/front-end/TextViewer.js:
2825 (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine):
2826 (WebInspector.TextEditorChunkedPanel.prototype._findVisibleChunks):
2827 (WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
2828 (WebInspector.TextEditorGutterChunk.prototype.get offsetTop):
2829 (WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
2830 (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
2832 2011-03-04 Andrey Adaikin <aandrey@google.com>
2834 Reviewed by Pavel Feldman.
2836 Web Inspector: [Text editor] DOMNodeRemoved events are missing
2837 https://bugs.webkit.org/show_bug.cgi?id=55769
2839 * inspector/front-end/TextViewer.js:
2840 (WebInspector.TextEditorMainPanel):
2841 (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
2842 (WebInspector.TextEditorMainChunk):
2843 (WebInspector.TextEditorMainChunk.prototype._createRow):
2845 2011-03-04 Ilya Tikhonovsky <loislo@chromium.org>
2847 Reviewed by Yury Semikhatsky.
2849 Web Inspector: Remove unnecessary domain and success flags from the response messages.
2850 https://bugs.webkit.org/show_bug.cgi?id=55768
2852 We have domain property in the response messages but it is not used because we dispatch
2853 the responses on the callback associated with seq.
2855 If we have property 'errors' in the response then success eq false and true in the other case.
2857 * inspector/CodeGeneratorInspector.pm:
2859 2011-03-04 Christian Dywan <christian@lanedo.com>
2861 Reviewed by Gustavo Noronha Silva.
2863 Enable Copy Image Address context menu item in the Gtk port
2864 https://bugs.webkit.org/show_bug.cgi?id=55136
2866 * page/ContextMenuController.cpp:
2867 * platform/ContextMenuItem.h:
2868 * platform/LocalizationStrategy.h:
2869 * platform/LocalizedStrings.cpp:
2870 * platform/LocalizedStrings.h:
2871 * platform/gtk/ContextMenuItemGtk.cpp:
2872 * platform/gtk/LocalizedStringsGtk.cpp:
2874 2011-03-04 Pavel Feldman <pfeldman@chromium.org>
2876 Reviewed by Yury Semikhatsky.
2878 Web Inspector: implement getCompletions via evaluate.
2879 https://bugs.webkit.org/show_bug.cgi?id=55759
2881 * inspector/InjectedScript.cpp:
2882 * inspector/InjectedScript.h:
2883 * inspector/InjectedScriptSource.js:
2884 * inspector/Inspector.idl:
2885 * inspector/InspectorDebuggerAgent.cpp:
2886 * inspector/InspectorDebuggerAgent.h:
2887 * inspector/InspectorRuntimeAgent.cpp:
2888 * inspector/InspectorRuntimeAgent.h:
2889 * inspector/front-end/ConsoleView.js:
2890 (WebInspector.ConsoleView.prototype.completions.evaluated):
2891 (WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
2892 (WebInspector.ConsoleView.prototype.completions):
2893 (WebInspector.ConsoleView.prototype._reportCompletions):
2894 * inspector/front-end/ScriptsPanel.js:
2895 (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper):
2896 (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
2897 * inspector/front-end/SourceFrame.js:
2898 (WebInspector.SourceFrame.prototype._showPopup):
2899 (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
2901 2011-03-04 Steve Block <steveblock@google.com>
2903 Reviewed by Jeremy Orlow.
2905 V8 version of JavaString should obtain string from JNI in UTF-16 encoding
2906 https://bugs.webkit.org/show_bug.cgi?id=55566
2908 We obtain the string from JNI in UTF-16 encoding and convert
2909 to UTF-8 using our own routines as required. This matches the
2910 behaviour of the JSC version of JavaString.
2912 No new tests, no change in behaviour.
2914 * bridge/jni/v8/JavaStringV8.h:
2915 (JSC::Bindings::JavaStringImpl::init):
2916 (JSC::Bindings::JavaStringImpl::utf8):
2917 (JSC::Bindings::JavaStringImpl::impl):
2919 2011-03-03 Pavel Feldman <pfeldman@chromium.org>
2921 Reviewed by Yury Semikhatsky.
2923 Web Inspector: do not push document into front-end, make it request one.
2924 https://bugs.webkit.org/show_bug.cgi?id=55664
2926 * inspector/Inspector.idl:
2927 * inspector/InspectorAgent.cpp:
2928 (WebCore::InspectorAgent::InspectorAgent):
2929 * inspector/InspectorAgent.h:
2930 * inspector/InspectorBrowserDebuggerAgent.cpp:
2931 (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
2932 * inspector/InspectorDOMAgent.cpp:
2933 (WebCore::InspectorDOMAgent::InspectorDOMAgent):
2934 (WebCore::InspectorDOMAgent::clearFrontend):
2935 (WebCore::InspectorDOMAgent::setDocument):
2936 (WebCore::InspectorDOMAgent::getDocument):
2937 (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
2938 (WebCore::InspectorDOMAgent::boundNodeId):
2939 (WebCore::InspectorDOMAgent::resolveNode):
2940 (WebCore::InspectorDOMAgent::mainFrameDOMContentLoaded):
2941 * inspector/InspectorDOMAgent.h:
2942 (WebCore::InspectorDOMAgent::create):
2943 * inspector/front-end/BreakpointManager.js:
2944 (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints):
2945 (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
2946 (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
2947 * inspector/front-end/DOMAgent.js:
2948 (WebInspector.DOMDocument):
2949 (WebInspector.DOMAgent):
2950 (WebInspector.DOMAgent.prototype.requestDocument):
2951 (WebInspector.DOMAgent.prototype.pushNodeToFrontend):
2952 (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
2953 (WebInspector.DOMAgent.prototype._attributesUpdated):
2954 (WebInspector.DOMAgent.prototype._characterDataModified):
2955 (WebInspector.DOMAgent.prototype._documentUpdated):
2956 (WebInspector.DOMAgent.prototype._setDocument):
2957 (WebInspector.DOMAgent.prototype._setDetachedRoot):
2958 (WebInspector.DOMAgent.prototype._setChildNodes):
2959 (WebInspector.DOMAgent.prototype._childNodeInserted):
2960 (WebInspector.DOMAgent.prototype._childNodeRemoved):
2961 (WebInspector.DOMDispatcher.prototype.documentUpdated):
2962 * inspector/front-end/ElementsPanel.js:
2963 (WebInspector.ElementsPanel.prototype.show):
2964 (WebInspector.ElementsPanel.prototype.setDocument):
2965 * inspector/front-end/MetricsSidebarPane.js:
2966 * inspector/front-end/RemoteObject.js:
2967 (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
2969 2011-03-04 Andrey Kosyakov <caseq@chromium.org>
2971 Reviewed by Pavel Feldman.
2973 Web Inspector: summary bar may overlap content of the network item view
2974 https://bugs.webkit.org/show_bug.cgi?id=55656
2976 - drop custom summary bar placement logic, do it with CSS instead.
2978 * inspector/front-end/NetworkPanel.js:
2979 (WebInspector.NetworkPanel.prototype.resize):
2980 (WebInspector.NetworkPanel.prototype._createSummaryBar):
2981 (WebInspector.NetworkPanel.prototype._updateSummaryBar):
2982 (WebInspector.NetworkPanel.prototype._updateFilter):
2983 (WebInspector.NetworkPanel.prototype.show):
2984 (WebInspector.NetworkPanel.prototype.refresh):
2985 (WebInspector.NetworkPanel.prototype._reset):
2986 (WebInspector.NetworkPanel.prototype._setLargerResources):
2987 (WebInspector.NetworkPanel.prototype._updateOffscreenRows):
2988 * inspector/front-end/networkPanel.css:
2989 (.network-sidebar .data-grid td):
2990 (.network-sidebar tr.filler td):
2991 (.network-summary-bar):
2992 (.network-sidebar .data-grid .network-summary-bar td):
2993 (.network-summary-bar img):
2995 2011-03-04 James Su <suzhe@chromium.org>
2997 Reviewed by Dimitri Glazkov.
2999 [Chromium] keycode is always 0 when using non-Latin keyboard layout.
3000 https://bugs.webkit.org/show_bug.cgi?id=54939
3002 Add KeyEventCocoa.{h,mm}, so that we can reuse them in chromium.
3004 No intended functionality change.
3006 * WebCore.gyp/WebCore.gyp:
3009 2011-03-04 Patrick Gansterer <paroga@webkit.org>
3011 Unreviewed EFL build fix for r80324.
3013 * platform/efl/RenderThemeEfl.cpp:
3014 (WebCore::RenderThemeEfl::paintThemePart):
3016 2011-03-04 Patrick Gansterer <paroga@webkit.org>
3018 Unreviewed EFL build fix for r80324.
3020 * platform/efl/RenderThemeEfl.cpp:
3021 (WebCore::RenderThemeEfl::paintThemePart):
3023 2011-03-03 Yury Semikhatsky <yurys@chromium.org>
3025 Reviewed by Pavel Feldman.
3027 Web Inspector: AppCache agent should have same lifetime as InspectorAgent
3028 https://bugs.webkit.org/show_bug.cgi?id=55673
3030 * inspector/InspectorAgent.cpp:
3031 (WebCore::InspectorAgent::InspectorAgent):
3032 (WebCore::InspectorAgent::setFrontend):
3033 (WebCore::InspectorAgent::disconnectFrontend):
3034 (WebCore::InspectorAgent::createFrontendLifetimeAgents):
3035 (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
3036 (WebCore::InspectorAgent::didCommitLoad):
3037 * inspector/InspectorApplicationCacheAgent.cpp:
3038 (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
3039 (WebCore::InspectorApplicationCacheAgent::setFrontend):
3040 (WebCore::InspectorApplicationCacheAgent::clearFrontend):
3041 * inspector/InspectorApplicationCacheAgent.h:
3042 * inspector/InspectorInstrumentation.cpp:
3043 (WebCore::InspectorInstrumentation::networkStateChangedImpl):
3044 (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
3045 * inspector/InstrumentingAgents.h:
3046 (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent):
3047 (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
3049 2011-03-03 Brian Weinstein <bweinstein@apple.com>
3051 Reviewed by Adam Roben.
3053 Cleanup from https://bugs.webkit.org/show_bug.cgi?id=55427.
3055 Call WebCore::startObservingCookieChanges and WebCore::stopObservingCookieChanges
3056 on all platforms, and stub the functions on platforms that don't implement them.
3058 Add startObservingCookieChanges and stopObservingCookieChanges to TemporaryLinkStubs
3059 for platforms that don't implement them.
3061 * platform/android/TemporaryLinkStubs.cpp:
3062 * platform/brew/TemporaryLinkStubs.cpp:
3063 * platform/chromium/TemporaryLinkStubs.cpp:
3064 * platform/efl/TemporaryLinkStubs.cpp:
3065 * platform/gtk/TemporaryLinkStubs.cpp:
3066 * platform/haiku/TemporaryLinkStubs.cpp:
3067 * platform/qt/TemporaryLinkStubsQt.cpp:
3068 * platform/win/TemporaryLinkStubs.cpp:
3070 2011-03-03 Eric Seidel <eric@webkit.org>
3072 Reviewed by Dimitri Glazkov.
3074 Refactor createRendererIfNeeded to avoid premature nextRenderer calculation
3075 https://bugs.webkit.org/show_bug.cgi?id=55720
3077 There are two thing going on here:
3078 1. Delaying nextRenderer calculation until we actually use it,
3079 previously we would always compute nextRenderer (expensive!)
3080 even if no renderer insertion was to occur.
3081 2. Fix fullscreen elements to be inserted into the right place
3082 in the rendering tree. Previously they would always be the last
3083 child in their parent's list, even if that wasn't the right place.
3085 I don't know of any way to trigger the fullscreen bug,
3086 but I tested this with peacekeeper and saw no performance change.
3088 Peacekeeper's domJQueryBasics is now possibly as much as 2% faster
3089 but I don't really trust the stability of peacekeeper to begin with.
3091 This paves the way for further improvement in our nextRenderer calculation.
3094 (WebCore::Node::attach):
3095 (WebCore::Node::previousRenderer):
3096 (WebCore::Node::nextRenderer):
3097 (WebCore::Node::createRendererAndStyle):
3098 (WebCore::wrapWithRenderFullScreen):
3099 (WebCore::Node::createRendererIfNeeded):
3102 2011-03-03 Ryosuke Niwa <rniwa@webkit.org>
3104 Reviewed by Darin Adler.
3106 Remove LOOSE_PASS_OWN_ARRAY_PTR from PassOwnArrayPtr.h
3107 https://bugs.webkit.org/show_bug.cgi?id=55554
3109 * platform/Length.cpp:
3110 (WebCore::newLengthArray): Pass nullptr instead of 0.
3112 2011-03-03 Nat Duca <nduca@chromium.org>
3114 Reviewed by James Robinson.
3116 [chromium] Create a LayerChromium layerTreeAsText. Add HUD to
3117 LayerRendererChromium that draws compositor FPS and, optionally,
3119 https://bugs.webkit.org/show_bug.cgi?id=54710
3122 * platform/graphics/chromium/Canvas2DLayerChromium.h:
3123 (WebCore::Canvas2DLayerChromium::drawsContent):
3124 * platform/graphics/chromium/CanvasLayerChromium.h:
3125 (WebCore::CanvasLayerChromium::layerTypeAsString):
3126 * platform/graphics/chromium/ContentLayerChromium.cpp:
3127 (WebCore::writeIndent):
3128 (WebCore::ContentLayerChromium::dumpLayerProperties):
3129 * platform/graphics/chromium/ContentLayerChromium.h:
3130 (WebCore::ContentLayerChromium::drawsContent):
3131 (WebCore::ContentLayerChromium::layerTypeAsString):
3132 * platform/graphics/chromium/GraphicsLayerChromium.cpp:
3133 (WebCore::GraphicsLayerChromium::setName):
3134 (WebCore::GraphicsLayerChromium::updateNames):
3135 (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
3136 (WebCore::GraphicsLayerChromium::setupContentsLayer):
3137 * platform/graphics/chromium/GraphicsLayerChromium.h:
3138 * platform/graphics/chromium/ImageLayerChromium.h:
3139 (WebCore::ImageLayerChromium::drawsContent):
3140 (WebCore::ImageLayerChromium::layerTypeAsString):
3141 * platform/graphics/chromium/LayerChromium.cpp:
3142 (WebCore::LayerChromium::LayerChromium):
3143 (WebCore::LayerChromium::setName):
3144 (WebCore::LayerChromium::layerTreeAsText):
3145 (WebCore::writeIndent):
3146 (WebCore::LayerChromium::dumpLayer):
3147 (WebCore::LayerChromium::dumpLayerProperties):
3148 * platform/graphics/chromium/LayerChromium.h:
3149 (WebCore::LayerChromium::name):
3150 (WebCore::LayerChromium::drawsContent):
3151 (WebCore::LayerChromium::debugID):
3152 (WebCore::LayerChromium::layerTypeAsString):
3153 * platform/graphics/chromium/LayerRendererChromium.cpp:
3154 (WebCore::LayerRendererChromium::LayerRendererChromium):
3155 (WebCore::LayerRendererChromium::~LayerRendererChromium):
3156 (WebCore::LayerRendererChromium::drawLayers):
3157 (WebCore::LayerRendererChromium::present):
3158 (WebCore::LayerRendererChromium::layerTreeAsText):
3159 (WebCore::LayerRendererChromium::dumpRenderSurfaces):
3160 * platform/graphics/chromium/LayerRendererChromium.h:
3161 (WebCore::LayerRendererChromium::getHeadsUpDisplay):
3162 (WebCore::LayerRendererChromium::rootVisibleRect):
3163 * platform/graphics/chromium/PluginLayerChromium.h:
3164 (WebCore::PluginLayerChromium::drawsContent):
3165 (WebCore::PluginLayerChromium::layerTypeAsString):
3166 * platform/graphics/chromium/RenderSurfaceChromium.cpp:
3167 (WebCore::RenderSurfaceChromium::name):
3168 (WebCore::writeIndent):
3169 (WebCore::RenderSurfaceChromium::dumpSurface):
3170 * platform/graphics/chromium/RenderSurfaceChromium.h:
3171 * platform/graphics/chromium/VideoLayerChromium.h:
3172 (WebCore::VideoLayerChromium::drawsContent):
3173 (WebCore::VideoLayerChromium::layerTypeAsString):
3174 * platform/graphics/chromium/WebGLLayerChromium.h:
3175 (WebCore::WebGLLayerChromium::drawsContent):
3176 (WebCore::WebGLLayerChromium::layerTypeAsString):
3177 * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: Added.
3178 (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
3179 (WebCore::CCHeadsUpDisplay::~CCHeadsUpDisplay):
3180 (WebCore::CCHeadsUpDisplay::draw):
3181 (WebCore::CCHeadsUpDisplay::drawHudContents):
3182 (WebCore::CCHeadsUpDisplay::onPresent):
3183 * platform/graphics/chromium/cc/CCHeadsUpDisplay.h: Added.
3184 (WebCore::CCHeadsUpDisplay::setShowFPSCounter):
3185 (WebCore::CCHeadsUpDisplay::showFPSCounter):
3186 (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
3187 (WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
3188 (WebCore::CCHeadsUpDisplay::enabled):
3189 * platform/graphics/chromium/cc/CCLayerImpl.cpp:
3190 (WebCore::CCLayerImpl::CCLayerImpl):
3191 (WebCore::writeIndent):
3192 (WebCore::CCLayerImpl::dumpLayerProperties):
3193 * platform/graphics/chromium/cc/CCLayerImpl.h:
3194 (WebCore::CCLayerImpl::debugID):
3195 (WebCore::CCLayerImpl::setName):
3196 (WebCore::CCLayerImpl::name):
3198 2011-03-02 Ojan Vafai <ojan@chromium.org>
3200 Reviewed by Darin Adler.
3202 crash in adoptNode with mutation events
3203 https://bugs.webkit.org/show_bug.cgi?id=50046
3205 If the DOM is modified during the removeChild call in adoptNode,
3206 then the setDocument call that follows can leave the DOM in an
3210 (WebCore::Document::adoptNode):
3212 2011-03-03 Dimitri Glazkov <dglazkov@chromium.org>
3214 Reviewed by Darin Adler.
3216 Add audio tag tests to the media controls manual test suite.
3217 https://bugs.webkit.org/show_bug.cgi?id=55722
3219 * manual-tests/media-controls.html: Added 4 audio tests.
3221 2011-03-03 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3223 Reviewed by Eric Seidel.
3225 [EFL] Adjust functions of RenderThemeEfl.cpp to WebKit parameter style
3226 https://bugs.webkit.org/show_bug.cgi?id=54392
3228 Functions of RenderThemeEfl.cpp adhere efl coding style instead of WebKit coding style.
3229 WebCore's functions should adhere WebKit coding style.
3231 * platform/efl/RenderThemeEfl.cpp:
3232 (WebCore::RenderThemeEfl::themePartCacheEntryReset):
3233 (WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):
3234 (WebCore::RenderThemeEfl::cacheThemePartNew):
3235 (WebCore::RenderThemeEfl::cacheThemePartReset):
3236 (WebCore::RenderThemeEfl::cacheThemePartResizeAndReset):
3237 (WebCore::RenderThemeEfl::cacheThemePartGet):
3238 (WebCore::RenderThemeEfl::cacheThemePartFlush):
3239 (WebCore::RenderThemeEfl::applyEdjeStateFromForm):
3240 (WebCore::RenderThemeEfl::paintThemePart):
3241 (WebCore::renderThemeEflColorClassSelectionActive):
3242 (WebCore::renderThemeEflColorClassSelectionInactive):
3243 (WebCore::renderThemeEflColorClassFocusRing):
3244 (WebCore::renderThemeEflColorClassButtonText):
3245 (WebCore::renderThemeEflColorClassComboText):
3246 (WebCore::renderThemeEflColorClassEntryText):
3247 (WebCore::renderThemeEflColorClassSearchText):
3248 (WebCore::RenderThemeEfl::applyPartDescription):
3249 (WebCore::RenderThemeEfl::applyPartDescriptions):
3250 (WebCore::RenderThemeEfl::controlSupportsTints):
3251 (WebCore::RenderThemeEfl::baselinePosition):
3252 (WebCore::RenderThemeEfl::paintSliderTrack):
3253 (WebCore::RenderThemeEfl::adjustSliderTrackStyle):
3254 (WebCore::RenderThemeEfl::adjustSliderThumbStyle):
3255 (WebCore::RenderThemeEfl::paintSliderThumb):
3256 (WebCore::RenderThemeEfl::adjustCheckboxStyle):
3257 (WebCore::RenderThemeEfl::paintCheckbox):
3258 (WebCore::RenderThemeEfl::adjustRadioStyle):
3259 (WebCore::RenderThemeEfl::paintRadio):
3260 (WebCore::RenderThemeEfl::adjustButtonStyle):
3261 (WebCore::RenderThemeEfl::paintButton):
3262 (WebCore::RenderThemeEfl::adjustMenuListStyle):
3263 (WebCore::RenderThemeEfl::paintMenuList):
3264 (WebCore::RenderThemeEfl::adjustTextFieldStyle):
3265 (WebCore::RenderThemeEfl::paintTextField):
3266 (WebCore::RenderThemeEfl::adjustTextAreaStyle):
3267 (WebCore::RenderThemeEfl::paintTextArea):
3268 (WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
3269 (WebCore::RenderThemeEfl::paintSearchFieldDecoration):
3270 (WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
3271 (WebCore::RenderThemeEfl::paintSearchFieldResultsButton):
3272 (WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle):
3273 (WebCore::RenderThemeEfl::paintSearchFieldResultsDecoration):
3274 (WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
3275 (WebCore::RenderThemeEfl::paintSearchFieldCancelButton):
3276 (WebCore::RenderThemeEfl::adjustSearchFieldStyle):
3277 (WebCore::RenderThemeEfl::paintSearchField):
3278 (WebCore::RenderThemeEfl::adjustProgressBarStyle):
3279 (WebCore::RenderThemeEfl::paintProgressBar):
3280 (WebCore::RenderThemeEfl::paintMediaFullscreenButton):
3281 (WebCore::RenderThemeEfl::paintMediaMuteButton):
3282 (WebCore::RenderThemeEfl::paintMediaPlayButton):
3283 (WebCore::RenderThemeEfl::paintMediaSeekBackButton):
3284 (WebCore::RenderThemeEfl::paintMediaSeekForwardButton):
3285 (WebCore::RenderThemeEfl::paintMediaSliderTrack):
3286 (WebCore::RenderThemeEfl::paintMediaSliderThumb):
3287 (WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer):
3288 (WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack):
3289 (WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb):
3290 (WebCore::RenderThemeEfl::paintMediaCurrentTime):
3292 2011-03-03 Andy Estes <aestes@apple.com>
3294 Reviewed by Adam Barth.
3296 Assertion failure in toElement(WebCore::Node*)
3297 https://bugs.webkit.org/show_bug.cgi?id=55697
3299 Test: fast/parser/fragment-foreign-content.html
3301 * html/parser/HTMLTreeBuilder.cpp:
3302 (WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken): The current
3303 element in the HTMLElementStack might be a DocumentFragment if a
3304 fragment is being parsed who's first node is foreign content.
3306 2011-03-03 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
3308 Reviewed by Kenneth Rohde Christiansen.
3310 [QT] Implement mock client-based geolocation for layout testing
3311 https://bugs.webkit.org/show_bug.cgi?id=54334
3313 Implements client() to GeolocationController to re-use geolocationClientMock class
3314 for layout testing purpose.
3316 * page/GeolocationController.h:
3317 (WebCore::GeolocationController::client):
3319 2011-03-03 Ryosuke Niwa <rniwa@webkit.org>
3321 Reviewed by Kent Tamura.
3323 Stop calling deprecatedNode and deprecatedEditingOffset in InsertTextCommand
3324 https://bugs.webkit.org/show_bug.cgi?id=55352
3326 Stopped calling deprecatedNode and deprecatedEditingOffset in the following functions:
3328 * editing/CompositeEditCommand.cpp:
3329 (WebCore::CompositeEditCommand::positionOutsideTabSpan): Takes care of all types of positions and
3330 no longer calls deprecated functions.
3331 * editing/InsertTextCommand.cpp:
3332 (WebCore::InsertTextCommand::positionInsideTextNode): Ditto; renamed from prepareForTextInsertion.
3333 Check if the text node inside a tab span before checking if the container node is a text node
3334 because the position before or after a text node can still be inside a tab span.
3335 (WebCore::InsertTextCommand::input): No longer calls deprecated functions.
3336 * editing/InsertTextCommand.h:
3337 * editing/ModifySelectionListLevel.cpp:
3338 (WebCore::getStartEndListChildren): Call anchorNode() instead of deprecatedNode() because the start
3339 or the end of selection could be an immediate child of a list node (e.g. br inside ul)
3341 2011-03-03 Hans Wennborg <hans@chromium.org>
3343 Reviewed by Jeremy Orlow.
3345 IndexedDB: Move last bits of SQL into IDBBackingStore
3346 https://bugs.webkit.org/show_bug.cgi?id=55668
3348 After this, all SQL code for IndexedDB is in IDBBackingStore.cpp.
3350 No new tests: refactoring only.
3352 * storage/IDBBackingStore.cpp:
3353 (WebCore::IDBBackingStore::createTransaction):
3354 * storage/IDBBackingStore.h:
3355 * storage/IDBCursorBackendImpl.h:
3356 * storage/IDBDatabaseBackendImpl.cpp:
3357 (WebCore::IDBDatabaseBackendImpl::backingStore):
3358 * storage/IDBDatabaseBackendImpl.h:
3359 * storage/IDBIndexBackendImpl.h:
3361 * storage/IDBObjectStoreBackendImpl.h:
3362 * storage/IDBTransactionBackendImpl.cpp:
3363 (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
3364 * storage/IDBTransactionBackendImpl.h:
3365 * storage/IDBTransactionBackendInterface.h:
3366 * storage/IDBTransactionCoordinator.cpp:
3368 2011-03-03 Adam Klein <adamk@chromium.org>
3370 Reviewed by David Levin.
3372 [fileapi] Tighten up ResolveURICallbacks
3373 https://bugs.webkit.org/show_bug.cgi?id=55638
3376 - Retry only on TYPE_MISMATCH_ERR now that Chromium
3377 properly sets that error code.
3378 - Call DirectoryEntry instead of DOMFileSystem methods.
3380 No change in behavior, so no new tests.
3382 * fileapi/FileSystemCallbacks.cpp:
3383 (WebCore::ResolveURICallbacks::didOpenFileSystem):
3385 2011-03-03 Anders Carlsson <andersca@apple.com>
3387 Reviewed by Sam Weinig.
3389 Get rid of Page::globalHistoryItem
3390 https://bugs.webkit.org/show_bug.cgi?id=55738
3392 The m_globalHistoryItem is only used by Mac and Windows WebKit1.
3393 Instead of having WebCore updating this member variable, just call out
3394 to a FrameLoaderClient member function and let WebKit keep it up to date.
3396 * loader/EmptyClients.h:
3397 (WebCore::EmptyFrameLoaderClient::dispatchDidRemoveBackForwardItem):
3398 (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryItemForPage):
3399 * loader/FrameLoader.cpp:
3400 (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
3401 (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
3402 * loader/FrameLoaderClient.h:
3403 (WebCore::FrameLoaderClient::updateGlobalHistoryItemForPage):
3404 * loader/HistoryController.cpp:
3405 (WebCore::HistoryController::goToItem):
3406 (WebCore::HistoryController::updateForStandardLoad):
3407 (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
3411 2011-03-02 Jeremy Orlow <jorlow@chromium.org>
3413 Reviewed by Steve Block.
3415 Cursor.continue with a key param should test less than, not equal to
3416 https://bugs.webkit.org/show_bug.cgi?id=55640
3418 If you supply a param to cursor.continue, we sould guarantee that
3419 the item we continue to is greater than or equal to the parameter.
3420 Right now, we only test equality.
3422 http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBCursor-continue
3423 http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#dfn-steps-for-iterating-a-cursor
3425 Test: storage/indexeddb/cursor-continue.html
3427 * storage/IDBCursorBackendImpl.cpp:
3428 (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
3429 * storage/IDBKey.cpp:
3430 (WebCore::IDBKey::isLessThan):
3431 (WebCore::IDBKey::isEqual):
3434 2011-03-03 Brent Fulgham <bfulgham@webkit.org>
3436 Build fix. Need win/cURL DownloadBundle stub.
3438 * platform/network/curl/DownloadBundle.h: Added.
3440 2011-03-03 Geoffrey Garen <ggaren@apple.com>
3442 Rolled out 80277 and 80280 because they caused event handler layout test
3445 * WebCore.xcodeproj/project.pbxproj:
3446 * bindings/js/JSDOMGlobalObject.cpp:
3447 * bindings/js/JSDOMGlobalObject.h:
3448 * bindings/js/JSDOMWindowBase.cpp:
3449 * bindings/js/JSDOMWindowBase.h:
3450 * bindings/js/JSDOMWindowCustom.h:
3451 * bindings/js/JSWorkerContextBase.cpp:
3453 2011-03-03 Brady Eidson <beidson@apple.com>
3455 Reviewed by Darin Adler.
3457 https://bugs.webkit.org/show_bug.cgi?id=55721
3458 Global IconDatabase should be returned by reference, not as a pointer
3460 * history/HistoryItem.cpp:
3461 (WebCore::HistoryItem::HistoryItem):
3462 (WebCore::HistoryItem::~HistoryItem):
3463 (WebCore::HistoryItem::reset):
3464 (WebCore::HistoryItem::icon):
3465 (WebCore::HistoryItem::setURLString):
3467 * loader/FrameLoader.cpp:
3468 (WebCore::FrameLoader::startIconLoader):
3469 (WebCore::FrameLoader::commitIconURLToIconDatabase):
3471 * loader/archive/cf/LegacyWebArchive.cpp:
3472 (WebCore::LegacyWebArchive::create):
3474 * loader/icon/IconDatabase.cpp:
3475 (WebCore::iconDatabase):
3476 * loader/icon/IconDatabase.h:
3477 * loader/icon/IconDatabaseNone.cpp:
3478 (WebCore::iconDatabase):
3479 * loader/icon/wince/IconDatabaseWinCE.cpp:
3480 (WebCore::iconDatabase):
3482 * loader/icon/IconLoader.cpp:
3483 (WebCore::IconLoader::finishLoading):
3485 2011-03-03 Ryosuke Niwa <rniwa@webkit.org>
3487 Reviewed by Martin Robinson.
3489 Stop instantiating legacy editing positions in FocusController::advanceFocusInDocumentOrder
3490 https://bugs.webkit.org/show_bug.cgi?id=52742
3492 Use firstPositionInOrBeforeNode to instantiate appropriate position.
3494 * page/FocusController.cpp:
3495 (WebCore::FocusController::advanceFocusInDocumentOrder):
3497 2011-03-03 Andy Estes <aestes@apple.com>
3499 Reviewed by Darin Adler.
3501 When displaying the missing plug-in sheet, pass the 'pluginspage'
3502 attribute to the UI process.
3503 https://bugs.webkit.org/show_bug.cgi?id=55553
3505 * WebCore.exp.in: Export __ZN7WebCore9HTMLNames15pluginspageAttrE.
3506 * html/HTMLAttributeNames.in: Add 'pluginspage' as a known content
3509 2011-03-03 Jessie Berlin <jberlin@apple.com>
3511 Reviewed by Adam Roben.
3513 WebKit2: Use CFNetwork Sessions API.
3514 https://bugs.webkit.org/show_bug.cgi?id=55435
3516 Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
3519 Support using WKCopyRequestWithStorageSession in WebCore.
3520 * platform/mac/WebCoreSystemInterface.h:
3522 * platform/mac/WebCoreSystemInterface.mm:
3525 * platform/network/cf/ResourceHandleCFNet.cpp:
3526 (WebCore::makeFinalRequest):
3527 If Private Browsing is enabled, set the Private Browsing Storage Session on the request.
3528 (WebCore::ResourceHandle::willSendRequest):
3530 * platform/network/mac/ResourceHandleMac.mm:
3531 (WebCore::ResourceHandle::createNSURLConnection):
3533 (WebCore::ResourceHandle::willSendRequest):
3536 * platform/network/cf/ResourceRequest.h:
3537 * platform/network/cf/ResourceRequestCFNet.cpp:
3538 (WebCore::ResourceRequest::setStorageSession):
3539 Call through to WKSI.
3540 * platform/network/mac/ResourceRequestMac.mm:
3541 (WebCore::ResourceRequest::setStorageSession):
3544 2011-03-03 Chris Marrin <cmarrin@apple.com>
3546 Reviewed by Simon Fraser.
3548 REGRESSION: Accelerated transitions are jumpy
3549 https://bugs.webkit.org/show_bug.cgi?id=55022
3551 Changed the way default TimingFunction is stored according to Adam Roben's
3554 * platform/animation/TimingFunction.h:
3555 (WebCore::CubicBezierTimingFunction::defaultTimingFunction):
3557 2011-03-03 Dan Bernstein <mitz@apple.com>
3559 Reviewed by Sam Weinig.
3561 Rename -webkit-hyphenate-locale to -webkit-locale
3562 https://bugs.webkit.org/show_bug.cgi?id=55709
3564 * css/CSSComputedStyleDeclaration.cpp:
3565 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3566 * css/CSSParser.cpp:
3567 (WebCore::CSSParser::parseValue):
3568 (WebCore::cssPropertyID):
3569 * css/CSSPropertyNames.in:
3570 * css/CSSStyleSelector.cpp:
3571 (WebCore::CSSStyleSelector::applyProperty):
3572 * rendering/RenderBlockLineLayout.cpp:
3573 (WebCore::RenderBlock::findNextLineBreak):
3574 * rendering/style/RenderStyle.cpp:
3575 (WebCore::RenderStyle::diff):
3576 * rendering/style/RenderStyle.h:
3577 (WebCore::InheritedFlags::locale):
3578 (WebCore::InheritedFlags::setLocale):
3579 (WebCore::InheritedFlags::initialLocale):
3580 * rendering/style/StyleRareInheritedData.cpp:
3581 (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3582 (WebCore::StyleRareInheritedData::operator==):
3583 * rendering/style/StyleRareInheritedData.h:
3585 2011-03-03 Kevin Ollivier <kevino@theolliviers.com>
3587 [wx] Build fixes. Use Font::textMetrics to get ascent value, and add missing include.
3589 * platform/wx/DragDataWx.cpp:
3590 * platform/wx/wxcode/win/non-kerned-drawing.cpp:
3591 (WebCore::drawTextWithSpacing):
3593 2011-03-03 Oliver Hunt <oliver@apple.com>
3595 Reviewed by Geoffrey Garen.
3597 JSVariableObject needs to use WriteBarrier for symboltable property storage
3598 https://bugs.webkit.org/show_bug.cgi?id=55698
3600 Update to pass JSGlobalData for the symbol table write used
3601 to set the document property.
3603 * bindings/js/JSDOMWindowBase.cpp:
3604 (WebCore::JSDOMWindowBase::updateDocument):
3606 2011-03-03 Alexey Proskuryakov <ap@apple.com>
3608 More build fixing. Move WebCoreKeyboardUIMode.h to a cross-platform location.
3610 * WebCore.xcodeproj/project.pbxproj:
3611 * page/WebCoreKeyboardUIMode.h: Copied from WebCore/page/mac/WebCoreKeyboardUIMode.h.
3612 * page/mac/WebCoreKeyboardUIMode.h: Removed.
3614 2011-03-03 Alexey Proskuryakov <ap@apple.com>
3616 Build fix. Should include WebCoreKeyboardUIMode.h on all platforms now.
3618 * page/ChromeClient.h:
3620 2011-03-02 Alexey Proskuryakov <ap@apple.com>
3622 Reviewed by Darin Adler.
3624 REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
3625 https://bugs.webkit.org/show_bug.cgi?id=55633
3626 <rdar://problem/8963023>
3628 * loader/EmptyClients.h: (WebCore::EmptyChromeClient::keyboardUIMode):
3629 * page/ChromeClient.h:
3630 * page/EventHandler.cpp: (WebCore::EventHandler::tabsToLinks):
3631 Merged tabsToLinks() and keyboardUIMode(). The latter returned a superset of information
3634 2011-03-03 Dimitri Glazkov <dglazkov@chromium.org>
3636 Fix Win compile break, caused by r80276.
3638 * rendering/RenderThemeWin.h: Changed signature of volumeSliderOffsetFromMuteButton
3639 to match RenderTheme.h.
3641 2011-03-02 Geoffrey Garen <ggaren@apple.com>
3643 Reviewed by Darin Adler.
3645 Moved all variable object storage inline -- upping the object size limit to 1K
3646 https://bugs.webkit.org/show_bug.cgi?id=55653
3648 * bindings/js/JSDOMGlobalObject.cpp:
3649 * bindings/js/JSDOMGlobalObject.h:
3650 * bindings/js/JSDOMWindowBase.cpp:
3651 * bindings/js/JSDOMWindowBase.h:
3652 * bindings/js/JSDOMWindowCustom.h:
3653 * bindings/js/JSWorkerContextBase.cpp: Removed out-of-line storage. Changed d-> to m_.
3655 2011-03-03 Dimitri Glazkov <dglazkov@chromium.org>
3657 Reviewed by Darin Adler.
3659 Use RenderBox in volumeSliderOffsetFromMuteButton, since that's what is actually being used.
3660 https://bugs.webkit.org/show_bug.cgi?id=55099
3662 Cleanup, no behavior change.
3664 * html/shadow/MediaControls.cpp:
3665 (WebCore::MediaControls::updateVolumeSliderContainer): Changed to pass RenderBox
3667 * rendering/RenderMediaControls.cpp:
3668 (WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton): Changed
3669 to use RenderBox as argument.
3670 * rendering/RenderMediaControls.h: Ditto.
3671 * rendering/RenderTheme.cpp:
3672 (WebCore::RenderTheme::volumeSliderOffsetFromMuteButton): Ditto.
3673 * rendering/RenderTheme.h: Ditto.
3674 * rendering/RenderThemeChromiumMac.h: Ditto.
3675 * rendering/RenderThemeChromiumMac.mm:
3676 (WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton): Ditto.
3677 * rendering/RenderThemeMac.h: Ditto.
3678 * rendering/RenderThemeMac.mm:
3679 (WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton): Ditto.
3680 * rendering/RenderThemeWin.cpp:
3681 (WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton): Ditto.
3683 2011-03-03 Alexis Menard <alexis.menard@openbossa.org>
3685 Reviewed by Andreas Kling.
3687 When building with DEFINES+=USE_GSTREAMER=1 we don't want to define ENABLE_QT_MULTIMEDIA to 1.
3688 Also add the new files added after https://bugs.webkit.org/show_bug.cgi?id=54870 to support GRefPtr
3694 2011-03-03 Anders Carlsson <andersca@apple.com>
3696 Try to fix the Windows build again.
3698 * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
3699 * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
3701 2011-03-03 Mihai Parparita <mihaip@chromium.org>
3703 Reviewed by Dimitri Glazkov.
3705 Add another CRASH() for CSSSelector double frees
3706 https://bugs.webkit.org/show_bug.cgi?id=55693
3708 To help track down bug 53045, add a CRASH call when the the array and/or
3709 CSSSelector member in CSSSelectorList is disposed of more than once.
3711 Just a check, no new tests necessary.
3713 * css/CSSSelectorList.cpp:
3714 (WebCore::CSSSelectorList::deleteSelectors):
3716 2011-03-03 Anders Carlsson <andersca@apple.com>
3718 Yet another attempt at fixing the Windows build.
3720 * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
3721 * platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:
3722 * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
3723 * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
3725 2011-03-02 Chris Marrin <cmarrin@apple.com>
3727 Reviewed by Simon Fraser.
3729 REGRESSION: Accelerated transitions are jumpy
3730 https://bugs.webkit.org/show_bug.cgi?id=55022
3732 Got rid of default TimingFunction values from PlatformCAAnimation*. A TimingFunction
3733 is now always passed in. The TimingFunction class now has a static method to get
3734 a default object which has the 'ease' values in it. I now assert in both Mac and
3735 Win implementations if a null TimingFunction pointer is seen.
3737 * platform/animation/TimingFunction.h:
3738 (WebCore::CubicBezierTimingFunction::create):
3739 (WebCore::CubicBezierTimingFunction::defaultTimingFunction):
3740 (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction):
3741 * platform/graphics/ca/GraphicsLayerCA.cpp:
3742 (WebCore::GraphicsLayerCA::timingFunctionForAnimationValue):
3743 * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
3744 (toCAMediaTimingFunction):
3745 * platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
3746 (toCACFTimingFunction):
3748 2011-03-03 Tony Gentilcore <tonyg@chromium.org>
3750 Unreviewed build fix.
3752 Fix clang compile after r80220
3753 https://bugs.webkit.org/show_bug.cgi?id=55692
3755 * storage/IDBBackingStore.cpp:
3756 (WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
3758 2011-03-03 Anders Carlsson <andersca@apple.com>
3760 Attempt to fix the Windows build.
3762 * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
3763 * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
3765 2011-03-02 Brian Weinstein <bweinstein@apple.com>
3767 Reviewed by Adam Roben.
3769 Rest of WebKit2: Need a way to send notifications to client when cookies change
3770 https://bugs.webkit.org/show_bug.cgi?id=55427
3771 <rdar://problem/9056027>
3773 Add functions to be exported.
3777 2011-03-03 Anders Carlsson <andersca@apple.com>
3779 Reviewed by Darin Adler.
3781 Improve WebCore build time by ~5%
3782 https://bugs.webkit.org/show_bug.cgi?id=55688
3784 Forward declare the CATransform3D and CGAffineTransform structs instead of including
3785 large chunks of QuartzCore and Core Graphics.
3787 On an 8 core Mac Pro, this sped up building WebCore by about 5%.
3789 * platform/graphics/ca/GraphicsLayerCA.cpp:
3790 * platform/graphics/ca/TransformationMatrixCA.cpp:
3791 * platform/graphics/transforms/TransformationMatrix.h:
3793 2011-03-03 Andrey Kosyakov <caseq@chromium.org>
3795 Unreviewed. Adjusted call to a method renamed in r80102.
3797 * inspector/front-end/SourceFrame.js:
3798 (WebInspector.SourceFrame.prototype._startEditing):
3800 2011-03-03 Timothy Hatcher <timothy@apple.com>
3802 Use APIEntryShim instead of JSLock in SerializedScriptValue to allow it to be used
3803 by contexts not created by WebCore.
3805 https://webkit.org/b/55642
3807 Reviewed by Oliver Hunt.
3809 * bindings/js/SerializedScriptValue.cpp:
3810 (WebCore::SerializedScriptValue::create): Use APIEntryShim instead of JSLock.
3811 (WebCore::SerializedScriptValue::deserialize): Ditto.
3813 2011-03-03 Alexey Proskuryakov <ap@apple.com>
3815 Reviewed by Darin Adler.
3817 WebCore should check for "Upgrade" and "Connection" header fields in WebSockets handshake
3818 https://bugs.webkit.org/show_bug.cgi?id=55498
3819 <rdar://problem/8752706>
3821 Tests: http/tests/websocket/tests/handshake-fail-by-no-connection-header.html
3822 http/tests/websocket/tests/handshake-fail-by-no-upgrade-header.html
3824 * websockets/WebSocketHandshake.h: Removed unused and meaningless setters for response
3825 header fields. Removed separate member variables for those, as they were duplicating data
3826 available in response, and there is no reason to squeeze microsecods here.
3828 * websockets/WebSocketHandshake.cpp:
3829 (WebCore::WebSocketHandshake::reset): There are no longer member variables for header field
3830 values to reset here.
3831 (WebCore::WebSocketHandshake::readServerHandshake): Removed a call for processHeaders().
3832 (WebCore::WebSocketHandshake::serverWebSocketOrigin): Changed to get the value from response.
3833 (WebCore::WebSocketHandshake::serverWebSocketLocation): Ditto.
3834 (WebCore::WebSocketHandshake::serverWebSocketProtocol): Ditto.
3835 (WebCore::WebSocketHandshake::serverSetCookie): Ditto.
3836 (WebCore::WebSocketHandshake::serverSetCookie2): Ditto.
3837 (WebCore::WebSocketHandshake::serverUpgrade): Added.
3838 (WebCore::WebSocketHandshake::serverConnection): Added.
3839 (WebCore::WebSocketHandshake::checkResponseHeaders): Added checks for Upgrade and Connection
3840 header field presence and values.
3842 2011-03-03 Helder Correia <helder@sencha.com>
3844 Reviewed by Andreas Kling.
3846 [Qt] fast/canvas/canvas-strokePath-gradient-shadow.html fails
3847 https://bugs.webkit.org/show_bug.cgi?id=55651
3849 When relying on ContextShadow and using a gradient stroke for a path,
3850 the alpha of the shadow is incorrect.
3852 * platform/graphics/qt/GraphicsContextQt.cpp:
3853 (WebCore::GraphicsContext::strokePath):
3855 2011-03-03 Martin Robinson <mrobinson@igalia.com>
3857 XHTMLMP build broken after r78342
3858 https://bugs.webkit.org/show_bug.cgi?id=55286
3860 Fix XHTMLMP build now that the DocumentWriter is a member of DocumentLoader
3861 instead of FrameLoader.
3863 No new tests. This is a build fix.
3866 (WebCore::Document::isXHTMLMPDocument):
3868 2011-03-03 Dimitri Glazkov <dglazkov@chromium.org>
3870 Reviewed by Eric Carlson.
3872 Tweak MediaControlMuteButtonElement class hierarchy.
3873 https://bugs.webkit.org/show_bug.cgi?id=55614
3875 This allows the mute button on the panel to have event handlers that are
3876 different from the mute button in the volume slider.
3878 No change in behavior, covered by existing tests.
3880 * html/shadow/MediaControls.cpp:
3881 (WebCore::MediaControls::createMuteButton): Changed to use MediaControlPanelMuteButtonElement.
3882 * rendering/MediaControlElements.cpp:
3883 (WebCore::MediaControlMuteButtonElement::updateDisplayType):
3884 (WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement): Added.
3885 (WebCore::MediaControlPanelMuteButtonElement::create): Added.
3886 (WebCore::MediaControlPanelMuteButtonElement::shadowPseudoId): Moved.
3887 * rendering/MediaControlElements.h: Added defs.
3889 2011-03-03 Yury Semikhatsky <yurys@chromium.org>
3891 Reviewed by Pavel Feldman.
3893 Web Inspector: Resource agent should have same lifetime as Inspector agent
3894 https://bugs.webkit.org/show_bug.cgi?id=55461
3896 * inspector/Inspector.idl:
3897 * inspector/InspectorAgent.cpp:
3898 (WebCore::InspectorAgent::InspectorAgent):
3899 (WebCore::InspectorAgent::inspectedPageDestroyed): disconnectFrontend is called before the agent is destroyed
3900 to clear frontend reference in all agents.
3901 (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
3902 (WebCore::InspectorAgent::setFrontend):
3903 (WebCore::InspectorAgent::disconnectFrontend):
3904 (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
3905 (WebCore::InspectorAgent::didCommitLoad):
3906 * inspector/InspectorAgent.h:
3907 (WebCore::InspectorAgent::resourceAgent):
3908 * inspector/InspectorBrowserDebuggerAgent.cpp:
3909 (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
3910 * inspector/InspectorDebuggerAgent.cpp:
3911 (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
3912 * inspector/InspectorInstrumentation.cpp:
3913 (WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
3914 (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl):
3915 (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl):
3916 (WebCore::InspectorInstrumentation::didCloseWebSocketImpl):
3917 (WebCore::InspectorInstrumentation::retrieveResourceAgent):
3918 * inspector/InspectorResourceAgent.cpp:
3919 (WebCore::InspectorResourceAgent::setFrontend):
3920 (WebCore::InspectorResourceAgent::clearFrontend):
3921 (WebCore::InspectorResourceAgent::restore):
3922 (WebCore::InspectorResourceAgent::~InspectorResourceAgent):
3923 (WebCore::InspectorResourceAgent::enable):
3924 (WebCore::InspectorResourceAgent::disable):
3925 (WebCore::InspectorResourceAgent::InspectorResourceAgent):
3926 * inspector/InspectorResourceAgent.h:
3927 (WebCore::InspectorResourceAgent::create):
3928 * inspector/InspectorTimelineAgent.cpp:
3929 (WebCore::InspectorTimelineAgent::restore):
3930 * inspector/InspectorTimelineAgent.h:
3931 * inspector/front-end/NetworkManager.js:
3932 (WebInspector.NetworkManager):
3933 (WebInspector.NetworkManager.prototype.frontendReused):
3934 * inspector/front-end/inspector.js:
3935 (WebInspector.frontendReused):
3937 2011-03-03 Andras Becsi <abecsi@webkit.org>
3939 Reviewed by Andreas Kling.
3941 CSS RGBA fast-path color parsing should clamp of out-of-range alpha values
3942 https://bugs.webkit.org/show_bug.cgi?id=55661
3944 Test case originally written by Andreas Kling <andreas.kling@nokia.com>
3946 Test: fast/canvas/rgba-parsing.html
3948 * css/CSSParser.cpp:
3949 (WebCore::isValidDouble): Check whether the given string is a valid double.
3950 (WebCore::parseAlphaValue): Out-of-range alpha values should be clamped to the (0.0, 1.0) range.
3952 2011-03-03 David Holloway <dhollowa@chromium.org>
3954 Reviewed by Dimitri Glazkov.
3956 Changes HTMLTextFormControlElement::placeholderShouldBeVisible to account
3957 for non-empty suggestion text. The visibility of the placeholder text
3958 now turned off when suggestion text is set.
3959 https://bugs.webkit.org/show_bug.cgi?id=55245
3961 No new tests because, by design, the suggestion text is not accessible
3964 * html/HTMLFormControlElement.cpp:
3965 (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
3966 * html/HTMLFormControlElement.h:
3967 (WebCore::HTMLTextFormControlElement::isEmptySuggestedValue):
3968 * html/HTMLInputElement.h:
3969 (WebCore::HTMLInputElement::isEmptySuggestedValue):
3971 2011-03-03 Andy Estes <aestes@apple.com>
3973 Reviewed by Eric Seidel.
3975 HTML5 TreeBuilder regressed a Peacekeeper DOM test by 25% (was 40%)
3976 https://bugs.webkit.org/show_bug.cgi?id=48719
3978 Instead of pushing a fake HTMLHtmlElement onto the open element stack
3979 during fragment parsing only to later remove it and reparent its
3980 children to the DocumentFragment, push the DocumentFragment directly
3981 onto the open element stack as the root node. This requires refactoring
3982 HTMLElementStack to hold ContainerNode pointers rather than Element
3983 pointers, which has implications for HTMLConstructionSite and
3984 HTMLTreeBuilder as well.
3986 With this patch, the regression in Peacekeeper from Safari 5.0.3 to ToT
3987 is ~14%. However, if you discount the 'domDynamicCreationCreateElement'
3988 test, ToT is now ~4% faster than Safari 5.0.3. This indicates that the
3989 regression no longer lies in fragment parsing.
3991 No new tests. No change in behavior.
3994 (WebCore::Node::hasLocalName):
3996 * html/parser/HTMLConstructionSite.cpp:
3997 (WebCore::HTMLNames::hasImpliedEndTag):
3998 (WebCore::HTMLConstructionSite::HTMLConstructionSite):
3999 (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
4000 (WebCore::HTMLConstructionSite::insertComment):
4001 (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
4002 (WebCore::HTMLConstructionSite::attachToCurrent):
4003 (WebCore::HTMLConstructionSite::insertScriptElement):
4004 (WebCore::HTMLConstructionSite::insertTextNode):
4005 (WebCore::HTMLConstructionSite::createElement):
4006 (WebCore::HTMLConstructionSite::createHTMLElement):
4007 (WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
4008 (WebCore::HTMLConstructionSite::generateImpliedEndTags):
4009 (WebCore::HTMLConstructionSite::findFosterSite):
4010 (WebCore::HTMLConstructionSite::shouldFosterParent):
4011 * html/parser/HTMLConstructionSite.h:
4012 (WebCore::HTMLConstructionSite::currentNode):
4013 * html/parser/HTMLElementStack.cpp:
4014 (WebCore::HTMLNames::isNumberedHeaderElement):
4015 (WebCore::HTMLNames::isScopeMarker):
4016 (WebCore::HTMLNames::isListItemScopeMarker):
4017 (WebCore::HTMLNames::isTableScopeMarker):
4018 (WebCore::HTMLNames::isTableBodyScopeMarker):
4019 (WebCore::HTMLNames::isTableRowScopeMarker):
4020 (WebCore::HTMLNames::isButtonScopeMarker):
4021 (WebCore::HTMLNames::isSelectScopeMarker):
4022 (WebCore::HTMLElementStack::ElementRecord::ElementRecord):
4023 (WebCore::HTMLElementStack::ElementRecord::replaceElement):
4024 (WebCore::HTMLElementStack::HTMLElementStack):
4025 (WebCore::HTMLElementStack::secondElementIsHTMLBodyElement):
4026 (WebCore::HTMLElementStack::popAll):
4027 (WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped):
4028 (WebCore::HTMLElementStack::popUntil):
4029 (WebCore::HTMLElementStack::popUntilPopped):
4030 (WebCore::HTMLElementStack::popUntilTableScopeMarker):
4031 (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
4032 (WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
4033 (WebCore::HTMLElementStack::pushHTMLHtmlElement):
4034 (WebCore::HTMLElementStack::push):
4035 (WebCore::HTMLElementStack::insertAbove):
4036 (WebCore::HTMLElementStack::find):
4037 (WebCore::HTMLElementStack::topmost):
4038 (WebCore::HTMLElementStack::contains):
4039 (WebCore::inScopeCommon):
4040 (WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
4041 (WebCore::HTMLElementStack::htmlElement):
4042 (WebCore::HTMLElementStack::rootNode):
4043 (WebCore::HTMLElementStack::pushCommon):
4044 * html/parser/HTMLElementStack.h:
4045 (WebCore::HTMLElementStack::ElementRecord::element):
4046 (WebCore::HTMLElementStack::ElementRecord::node):
4047 (WebCore::HTMLElementStack::topNode):
4048 * html/parser/HTMLTreeBuilder.cpp:
4049 (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
4050 (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
4051 (WebCore::HTMLTreeBuilder::processStartTagForInBody):
4052 (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
4053 (WebCore::HTMLTreeBuilder::processStartTag):
4054 (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
4055 (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
4056 (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
4057 (WebCore::HTMLTreeBuilder::processEndTagForInCell):
4058 (WebCore::HTMLTreeBuilder::processEndTagForInBody):
4059 (WebCore::HTMLTreeBuilder::processEndTag):
4060 (WebCore::HTMLTreeBuilder::processEndOfFile):
4061 (WebCore::HTMLTreeBuilder::finished):
4062 * html/parser/HTMLTreeBuilder.h:
4064 2011-03-02 Yury Semikhatsky <yurys@chromium.org>
4066 Reviewed by Pavel Feldman.
4068 Web Inspector: inspector protocol should allow different domains to have methods with same name
4069 https://bugs.webkit.org/show_bug.cgi?id=55558
4071 * inspector/CodeGeneratorInspector.pm: each command is now identified by domain + command-name(was command-name only).
4073 2011-03-02 Pavel Podivilov <podivilov@chromium.org>
4075 Reviewed by Yury Semikhatsky.
4077 Web Inspector: make selected call frame debugger presentation model property.
4078 https://bugs.webkit.org/show_bug.cgi?id=55582
4080 * inspector/front-end/CallStackSidebarPane.js:
4081 (WebInspector.CallStackSidebarPane):
4082 (WebInspector.CallStackSidebarPane.prototype.update):
4083 (WebInspector.CallStackSidebarPane.prototype.set selectedCallFrame):
4084 (WebInspector.CallStackSidebarPane.prototype._selectedCallFrameIndex):
4085 * inspector/front-end/ConsoleView.js:
4086 (WebInspector.ConsoleView.prototype.completions):
4087 * inspector/front-end/DebuggerPresentationModel.js:
4088 (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
4089 (WebInspector.DebuggerPresentationModel.prototype.get selectedCallFrame):
4090 * inspector/front-end/ScriptsPanel.js:
4091 (WebInspector.ScriptsPanel):
4092 (WebInspector.ScriptsPanel.prototype.getCompletionsOnCallFrame):
4093 (WebInspector.ScriptsPanel.prototype._debuggerResumed):
4094 (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
4095 (WebInspector.ScriptsPanel.prototype._callFrameSelected):
4097 2011-03-03 Jia Pu <jpu@apple.com>
4099 Reviewed by Darin Adler.
4101 On Mac OS X, spelling suggestion panel stops showing up after change set 80121
4102 https://bugs.webkit.org/show_bug.cgi?id=55628
4104 Removed a call to stopCorrectionPanelTimer() to fix a regression introduced by changeset 80121.
4106 * editing/Editor.cpp:
4107 (WebCore::Editor::appliedEditing):
4108 * manual-tests/autocorrection/autocorrection-contraction.html:
4110 2011-03-03 Pavel Podivilov <podivilov@chromium.org>
4112 Reviewed by Pavel Feldman.
4114 Web Inspector: rename "sourceName" to "sourceFileId" in ScriptsPanel.js.
4115 https://bugs.webkit.org/show_bug.cgi?id=55569
4117 sourceFileId better reflects the intention to have unique identifier for each source that is shown in scripts panel.
4119 * inspector/front-end/DebuggerPresentationModel.js:
4120 * inspector/front-end/ScriptsPanel.js:
4122 2011-03-03 Steve Block <steveblock@google.com>
4124 Reviewed by David Levin.
4126 JavaString API should be implementable by both JSC and V8
4127 https://bugs.webkit.org/show