Source/WebCore/ChangeLog

   1 2011-03-06  Jessie Berlin  <jberlin@apple.com>
   2
   3         Reviewed by Sam Weinig.
   4
   5         WebKit2: Use CFNetwork Sessions API.
   6         https://bugs.webkit.org/show_bug.cgi?id=55435.
   7
   8         When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
   9         Private Browsing Storage Session.
  10
  11         * WebCore.exp.in:
  12         Add the new WKSI functions.
  13         * platform/mac/WebCoreSystemInterface.h:
  14         Ditto.
  15         * platform/mac/WebCoreSystemInterface.mm:
  16         Ditto.
  17
  18         * platform/mac/CookieJar.mm:
  19         (WebCore::cookies):
  20         If USE(CFURLSTORAGESESSIONS) and there is a Private Browsing Cookie Storage, call into WKSI.
  21         Otherwise, behave the same as before.
  22         (WebCore::cookieRequestHeaderFieldValue):
  23         Ditto.
  24         (WebCore::setCookies):
  25         Ditto.
  26         (WebCore::cookiesEnabled):
  27         Ditto
  28         (WebCore::getRawCookies):
  29         Ditto.
  30         (WebCore::deleteCookie):
  31         Ditto.
  32
  33         * platform/network/CookieStorage.h:
  34         * platform/network/cf/CookieStorageCFNet.cpp:
  35         (WebCore::privateBrowsingCookieStorage):
  36         Keep track of the Private Browsing Cookie Storage in a locally defined static inside a
  37         function instead of at the global scope.
  38         (WebCore::currentCookieStorage):
  39         Use privateBrowsingCookieStorage.
  40         (WebCore::setCurrentCookieStorage):
  41         Ditto.
  42         (WebCore::setCookieStoragePrivateBrowsingEnabled):
  43         If USE(CFURLSTORAGESESSIONS), send the Private Browsing Storage Session to
  44         wkCreatePrivateInMemoryHTTPCookieStorage.
  45         * platform/network/mac/CookieStorageMac.mm:
  46         (WebCore::privateBrowsingCookieStorage):
  47         Keep track of the Private Browsing Cookie Storage.
  48         (WebCore::setCookieStoragePrivateBrowsingEnabled):
  49         If USE(CFURLSTORAGESESSIONS), then set or clear privateBrowsingCookieStorage().
  50         Added a FIXME to observe changes to the Private Browsing Cookie Storage when it is defined.
  51
  52         * platform/network/mac/ResourceHandleMac.mm:
  53         (WebCore::shouldRelaxThirdPartyCookiePolicy):
  54         Refactor the logic to determine whether or not to relax the third party cookie policy here.
  55         If USE(CFURLSTORAGESESSIONS), then get the information from the privateBrowsingCookieStorage.
  56         (WebCore::ResourceHandle::createNSURLConnection):
  57         Use shouldRelaxThirdPartyCookiePolicy.
  58         (WebCore::ResourceHandle::loadResourceSynchronously):
  59         Ditto.
  60
  61 2011-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
  62
  63         Unreviewed, rolling out r80428.
  64         http://trac.webkit.org/changeset/80428
  65         https://bugs.webkit.org/show_bug.cgi?id=55833
  66
  67         Broke SnowLeopard (Requested by xan_ on #webkit).
  68
  69         * plugins/gtk/PluginViewGtk.cpp:
  70         (WebCore::PluginView::handlePostReadFile):
  71
  72 2011-03-01  Martin Robinson  <mrobinson@igalia.com>
  73
  74         Reviewed by Xan Lopez.
  75
  76         [GTK] Windowless plugins override the view cursor
  77         https://bugs.webkit.org/show_bug.cgi?id=55531
  78
  79         manual test: manual-tests/plugins/windowless.html
  80
  81         * platform/gtk/WidgetGtk.cpp:
  82         (WebCore::Widget::setCursor): Call into the ChromeClient implementation now.
  83         * plugins/gtk/PluginViewGtk.cpp:
  84         (WebCore::PluginView::initXEvent): Instead of setting the window for windowless
  85         plugin events, set the window value to none. This method is also used to send
  86         focus in / focus out events to windowed plugins, but this is not one of the plugin
  87         types where the window parameter matters. This matches what Mozilla does. Also
  88         pass in the display of the widget itself, not the default display.
  89         (WebCore::PluginView::handleMouseEvent): When the cursor leaves the plugin area,
  90         reset the cursor.
  91         (WebCore::PluginView::platformGetValue): Clean up this section slightly. Give the
  92         widget the top-level window explicitly. This matches Mozilla.
  93
  94 2011-03-05  Martin Robinson  <mrobinson@igalia.com>
  95
  96         Reviewed by Xan Lopez.
  97
  98         [GTK] http/tests/plugins/post-url-file.html fails on GTK+
  99         https://bugs.webkit.org/show_bug.cgi?id=55826
 100
 101         Correct the implementation of handlePostReadFile which uses GIO APIs and
 102         actually resizes the buffer to fit the entire size of the file data. This
 103         was likely leading to memory corruption until now.
 104
 105         * plugins/gtk/PluginViewGtk.cpp:
 106         (WebCore::PluginView::handlePostReadFile): Fix this method.
 107
 108 2011-03-05  Mikhail Naganov  <mnaganov@chromium.org>
 109
 110         Reviewed by Pavel Feldman.
 111
 112         Web Inspector: [Chromium] Allow dynamic enabling of detailed heap profiles.
 113         https://bugs.webkit.org/show_bug.cgi?id=55824
 114
 115         Detailed heap profiles can be now enabled by typing "leakz" in Profiles tab.
 116
 117         * inspector/front-end/DetailedHeapshotView.js:
 118         (WebInspector.DetailedHeapshotView.prototype.isDetailedSnapshot):
 119         * inspector/front-end/ProfilesPanel.js:
 120         (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
 121         (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
 122         (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
 123         (WebInspector.ProfilesPanel.prototype.handleShortcut):
 124         (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint.hideHint):
 125         (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint):
 126         (WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles):
 127         (WebInspector.ProfilesPanel.prototype._recognizeKeyboardCombo):
 128
 129 2011-03-05  Qi Zhang  <qi.2.zhang@nokia.com>
 130
 131         Reviewed by Laszlo Gombos.
 132
 133         [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
 134         https://bugs.webkit.org/show_bug.cgi?id=48636
 135
 136         Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.
 137
 138         * WebCore.pri:
 139         * features.pri:
 140
 141 2011-03-05  Pavel Feldman  <pfeldman@chromium.org>
 142
 143         Not reviewed: adding null check to prevent inspector tests from failing.
 144
 145         * inspector/front-end/TextViewer.js:
 146         (WebInspector.TextEditorGutterChunk.prototype.get offsetTop):
 147         (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
 148
 149 2011-03-05  Pavel Feldman  <pfeldman@chromium.org>
 150
 151         Not reviewed: chromium rebaseline, flaky test fix.
 152
 153         * inspector/front-end/BreakpointManager.js:
 154         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
 155         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
 156         (WebInspector.DOMBreakpointView.prototype._format.formatters.s):
 157         (WebInspector.DOMBreakpointView.prototype._format.append):
 158         (WebInspector.DOMBreakpointView.prototype._format):
 159
 160 2011-03-04  Pavel Podivilov  <podivilov@chromium.org>
 161
 162         Reviewed by Yury Semikhatsky.
 163
 164         Web Inspector: [chromium] pause when script is running is broken.
 165         https://bugs.webkit.org/show_bug.cgi?id=55762
 166
 167         * inspector/CodeGeneratorInspector.pm:
 168
 169 2011-03-05  Adam Barth  <abarth@webkit.org>
 170
 171         Reviewed by Dimitri Glazkov.
 172
 173         Add Derived Sources to WebCore GYP build
 174         https://bugs.webkit.org/show_bug.cgi?id=55813
 175
 176         Adding the derived source action to the GYP file required tweaking
 177         DerivedSources.make.  I'm not sure how DerivedSources.make worked
 178         before beause these paths were incorrectly based.
 179
 180         * DerivedSources.make:
 181         * gyp/generate-derived-sources.sh: Added.
 182         * gyp/WebCore.gyp:
 183
 184 2011-03-04  Pavel Feldman  <pfeldman@chromium.org>
 185
 186         Reviewed by Yury Semikhatsky.
 187
 188         Web Inspector: fix layout tests flakiness.
 189         https://bugs.webkit.org/show_bug.cgi?id=55816
 190
 191         - Order of issuing of evaluateForTestInFrontend was not guaranteed on the backend side (InspectorAgent side)
 192         - Order of dispatching using timeouts was guaranteed via queueing. Source of all kinds of pains on SnowLeopard Release (inspector.js)
 193
 194         * inspector/CodeGeneratorInspector.pm:
 195         * inspector/InspectorAgent.cpp:
 196         (WebCore::InspectorAgent::InspectorAgent):
 197         (WebCore::InspectorAgent::disconnectFrontend):
 198         (WebCore::InspectorAgent::populateScriptObjects):
 199         (WebCore::InspectorAgent::evaluateForTestInFrontend):
 200         (WebCore::InspectorAgent::issueEvaluateForTestCommands):
 201         * inspector/InspectorAgent.h:
 202         * inspector/front-end/TimelinePanel.js:
 203         (WebInspector.TimelinePanel.FormattedRecord):
 204         * inspector/front-end/inspector.js:
 205         (WebInspector.dispatch):
 206
 207 2011-03-05  Adam Barth  <abarth@webkit.org>
 208
 209         Reviewed by Dimitri Glazkov.
 210
 211         WebCore GYP build should generate fewer than 10,000 compile errors per file
 212         https://bugs.webkit.org/show_bug.cgi?id=55810
 213
 214         This patch adds some missing include paths.  We need to figure out how
 215         to handle separate include paths per port.  It's clear that
 216         ForwardingHeaders are only useful for Mac, but it's less clear how to
 217         handle the others.
 218
 219         * WebCore.gypi:
 220         * gyp/WebCore.gyp:
 221
 222 2011-03-05  Dan Bernstein  <mitz@apple.com>
 223
 224         Reviewed by Cameron Zwarich.
 225
 226         <rdar://problem/9082946> Make the Core Text code path in GlyphPage::fill() more robust
 227         https://bugs.webkit.org/show_bug.cgi?id=55817
 228
 229         * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
 230         (WebCore::GlyphPage::fill): When determining if a CTRun uses the primary font, compare against
 231         a CGFont obtained from Core Text for the primary font. This CGFont may be different from
 232         the CGFont stored in the FontPlatformData.
 233
 234 2011-03-05  Ilya Sherman  <isherman@chromium.org>
 235
 236         Reviewed by Darin Adler.
 237
 238         HTMLInputElement::setValue() should schedule change event when the element is focused.
 239         Refactored tracking of "changed since last change event" state from renderer to DOM.In service of https://code.google.com/p/chromium/issues
 240         In service of https://code.google.com/p/chromium/issues/detail?id=42716
 241         https://bugs.webkit.org/show_bug.cgi?id=53160
 242
 243         Test: fast/forms/onchange-change-type.html
 244         Test: fast/forms/onchange-setvalueforuser.html
 245
 246         * WebCore.exp.in:
 247         * dom/Document.cpp:
 248         (WebCore::Document::setFocusedNode):
 249         * dom/Element.h:
 250         (WebCore::Element::wasChangedSinceLastFormControlChangeEvent): Added.
 251         (WebCore::Element::setChangedSinceLastFormControlChangeEvent): Added.
 252         * html/HTMLFormControlElement.cpp:
 253         (WebCore::HTMLFormControlElement::HTMLFormControlElement):
 254         (WebCore::HTMLFormControlElement::wasChangedSinceLastFormControlChangeEvent): Added.
 255         (WebCore::HTMLFormControlElement::setChangedSinceLastFormControlChangeEvent): Added.
 256         (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): Also clear the "changed since last change event" flag.
 257         (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): Also set the "changed since last change event" flag.
 258         * html/HTMLFormControlElement.h:
 259         * html/HTMLInputElement.cpp:
 260         (WebCore::HTMLInputElement::updateType): Also clear the "changed since last change event" flag.
 261         (WebCore::HTMLInputElement::setValue):
 262             For a focused text field, dispatch an input event, but delay the change event until the field loses focus.
 263         (WebCore::HTMLInputElement::defaultEventHandler):
 264         (WebCore::HTMLInputElement::stepUpFromRenderer):
 265         * html/shadow/TextControlInnerElements.cpp:
 266         (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
 267         * rendering/RenderTextControl.cpp:
 268         (WebCore::RenderTextControl::RenderTextControl):
 269         (WebCore::RenderTextControl::subtreeHasChanged):
 270         * rendering/RenderTextControl.h:
 271         * rendering/RenderTextControlMultiLine.cpp:
 272         (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
 273         * rendering/RenderTextControlSingleLine.cpp:
 274         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
 275         * wml/WMLInputElement.cpp:
 276         (WebCore::WMLInputElement::WMLInputElement):
 277         (WebCore::WMLInputElement::defaultEventHandler):
 278         * wml/WMLInputElement.h:
 279         (WebCore::WMLInputElement::wasChangedSinceLastFormControlChangeEvent): Added.
 280         (WebCore::WMLInputElement::setChangedSinceLastFormControlChangeEvent): Added.
 281
 282 2011-03-04  Xianzhu Wang  <wangxianzhu@google.com>
 283
 284         Reviewed by Adam Barth.
 285
 286         Remove fake request loading of SVGImage to avoid MainResourceLoader
 287         leak. The frame->init() already ensures initialization of the
 288         document loader.
 289
 290         https://bugs.webkit.org/show_bug.cgi?id=55017
 291
 292         Test: fast/images/svg-image-leak-loader.html
 293
 294         * svg/graphics/SVGImage.cpp:
 295         (WebCore::SVGImage::dataChanged):
 296
 297 2011-03-04  Mike Reed  <reed@google.com>
 298
 299         Reviewed by Mihai Parparita.
 300
 301         [Chromium] fast/canvas/canvas-arc-360-winding.html fails on Linux and Windows
 302         https://bugs.webkit.org/show_bug.cgi?id=49477
 303
 304         * platform/graphics/skia/PathSkia.cpp:
 305         (WebCore::Path::addArc):
 306
 307 2011-03-04  Jia Pu  <jpu@apple.com>
 308
 309         Reviewed by Darin Adler.
 310
 311         On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
 312         https://bugs.webkit.org/show_bug.cgi?id=55717
 313         <rdar://problem/9018127>
 314
 315         manual-test: manual-tests/platforms/mac/autocorrection/autocorrection-in-iframe.html
 316
 317         Previously, the bounding box passed into EditorClient::showCorrectionPanel() is in the frame's
 318         coordinate. This is incorrect when the correction occurs in an iframe. This patch added code
 319         to convert the bounding box to window coordinate using ScrollView::contentToWindow().
 320
 321         * dom/Range.cpp:
 322         (WebCore::Range::getBoundingClientRect):
 323         (WebCore::Range::boundingRect):
 324         * dom/Range.h:
 325         * editing/Editor.cpp:
 326         (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
 327         (WebCore::Editor::correctionPanelTimerFired):
 328         (WebCore::Editor::windowRectForRange):
 329         * editing/Editor.h:
 330         * manual-tests/autocorrection/autocorrection-in-iframe.html: Added.
 331         * manual-tests/autocorrection/document-for-iframe-test.html: Added.
 332
 333 2011-03-04  Jia Pu  <jpu@apple.com>
 334
 335         Reviewed by Darin Adler.
 336
 337         Those checking in Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited() should be done with VisiblePosition::isNull().
 338         https://bugs.webkit.org/show_bug.cgi?id=55731
 339
 340         No new tests. There's no behavioral change.
 341
 342         This patch improved clarity and readability of Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited().
 343
 344         * editing/Editor.cpp:
 345         (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
 346
 347 2011-03-04  John Bauman  <jbauman@chromium.org>
 348
 349         Reviewed by Kenneth Russell.
 350
 351         [chromium] premultipliedAlpha WebGL context attribute is ignored.
 352         https://bugs.webkit.org/show_bug.cgi?id=55411
 353
 354         Update compositor to set the blending of each layer correctly.
 355
 356         Test: compositing/webgl/webgl-nonpremultiplied-blend.html
 357
 358         * platform/graphics/chromium/CanvasLayerChromium.cpp:
 359         (WebCore::CanvasLayerChromium::CanvasLayerChromium):
 360         (WebCore::CanvasLayerChromium::draw):
 361         * platform/graphics/chromium/CanvasLayerChromium.h:
 362         * platform/graphics/chromium/ContentLayerChromium.cpp:
 363         (WebCore::ContentLayerChromium::draw):
 364         * platform/graphics/chromium/LayerRendererChromium.cpp:
 365         (WebCore::LayerRendererChromium::drawLayers):
 366         * platform/graphics/chromium/WebGLLayerChromium.cpp:
 367         (WebCore::WebGLLayerChromium::setContext):
 368
 369 2011-03-04  Adam Barth  <abarth@webkit.org>
 370
 371         Reviewed by Eric Seidel.
 372
 373         WebCore GYP build should link with the correct frameworks
 374         https://bugs.webkit.org/show_bug.cgi?id=55804
 375
 376         * gyp/WebCore.gyp:
 377
 378 2011-03-04  Adam Barth  <abarth@webkit.org>
 379
 380         Reviewed by Eric Seidel.
 381
 382         WebCore GYP build should Check For Inappropriate Files in Framework
 383         https://bugs.webkit.org/show_bug.cgi?id=55806
 384
 385         * gyp/WebCore.gyp:
 386
 387 2011-03-04  Dimitri Glazkov  <dglazkov@chromium.org>
 388
 389         Reviewed by Adam Barth.
 390
 391         Add skeletal WebCore.gyp
 392         https://bugs.webkit.org/show_bug.cgi?id=55802
 393
 394         This doesn't yet build, but the basic structure is there.
 395
 396         * WebCore.gypi: Added headers and include directories variables.
 397         * gyp/WebCore.gyp: Added.
 398
 399 2011-03-04  Adam Barth  <abarth@webkit.org>
 400
 401         Reviewed by Dimitri Glazkov.
 402
 403         Remove unneeded round-trips through ../Source in the Chromium GYP build
 404         https://bugs.webkit.org/show_bug.cgi?id=55795
 405
 406         This is just cleanup work, but it was bugging me.
 407
 408         * WebCore.gyp/WebCore.gyp:
 409
 410 2011-03-04  Mike Reed  <reed@google.com>
 411
 412         Reviewed by James Robinson.
 413
 414         Option to use skia's native text drawing APIs when drawing text
 415         on Windows, rather than from outlines using drawPath(). This will
 416         only have a significant effect when the skia-gpu backend is enabled.
 417         https://bugs.webkit.org/show_bug.cgi?id=55609
 418
 419         No new tests. This is disabled by default. When enabled, it will draw
 420         essentially the same, but with slightly different antialiased edges, due
 421         to differences between the current scanconverter and GDI's font scaler.
 422         When enabled, we will have to recalibrate layouttest image results.
 423
 424         * platform/graphics/skia/SkiaFontWin.cpp:
 425         (WebCore::skiaDrawText):
 426         (WebCore::setupPaintForFont):
 427         (WebCore::paintSkiaText):
 428
 429 2011-03-04  Adrienne Walker  <enne@google.com>
 430
 431         Reviewed by James Robinson.
 432
 433         [chromium] Fix texture stride issues on large content and image layers.
 434         https://bugs.webkit.org/show_bug.cgi?id=55679
 435
 436         This was an error caused during the refactoring in r80081.
 437
 438         Tests: LayoutTests/compositing/tiling/huge-layer-img.html
 439
 440         * platform/graphics/chromium/ContentLayerChromium.cpp:
 441         (WebCore::ContentLayerChromium::updateTexture):
 442         * platform/graphics/chromium/ImageLayerChromium.cpp:
 443         (WebCore::ImageLayerChromium::updateTextureIfNeeded):
 444
 445 2011-03-04  Sheriff Bot  <webkit.review.bot@gmail.com>
 446
 447         Unreviewed, rolling out r80379.
 448         http://trac.webkit.org/changeset/80379
 449         https://bugs.webkit.org/show_bug.cgi?id=55799
 450
 451         "Breaks leopard compile (implicit conversion)" (Requested by
 452         tonyg-cr on #webkit).
 453
 454         * css/CSSStyleSelector.cpp:
 455         (WebCore::convertToLength):
 456         (WebCore::CSSStyleSelector::applyProperty):
 457         (WebCore::CSSStyleSelector::createTransformOperations):
 458         * platform/Length.h:
 459         (WebCore::Length::Length):
 460         (WebCore::Length::operator==):
 461         (WebCore::Length::operator!=):
 462         (WebCore::Length::rawValue):
 463         (WebCore::Length::type):
 464         (WebCore::Length::quirk):
 465         (WebCore::Length::setValue):
 466         (WebCore::Length::setRawValue):
 467         (WebCore::Length::calcFloatValue):
 468         (WebCore::Length::isZero):
 469         (WebCore::Length::blend):
 470         * rendering/AutoTableLayout.cpp:
 471         (WebCore::AutoTableLayout::recalcColumn):
 472         (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
 473         * rendering/FixedTableLayout.cpp:
 474         (WebCore::FixedTableLayout::calcWidthArray):
 475
 476 2011-03-04  Jessie Berlin  <jberlin@apple.com>
 477
 478         Reviewed by Darin Adler.
 479
 480         WebKit2: Use CFNetwork Sessions API.
 481         https://bugs.webkit.org/show_bug.cgi?id=55435.
 482
 483         Add in the CFURLSTORAGESESSIONS guards that I incorrectly left out because the code was
 484         contained within guards that made USE(CFURLSTORAGESESSIONS) always be true.
 485
 486         * platform/network/cf/ResourceHandleCFNet.cpp:
 487         (WebCore::makeFinalRequest):
 488         (WebCore::ResourceHandle::willSendRequest):
 489         * platform/network/cf/ResourceRequestCFNet.cpp:
 490         * platform/network/mac/ResourceHandleMac.mm:
 491         (WebCore::ResourceHandle::createNSURLConnection):
 492         (WebCore::ResourceHandle::willSendRequest):
 493         * platform/network/mac/ResourceRequestMac.mm:
 494
 495 2011-03-04  Yuqiang Xian  <yuqiang.xian@intel.com>
 496
 497         Reviewed by Darin Adler.
 498
 499         improve layout performance by reducing the traversal time of the floating objects
 500         https://bugs.webkit.org/show_bug.cgi?id=55440
 501
 502         We observered large overhead on traversing the floating objects list
 503         in logicalLeftOffsetForLine() and logicalRightOffsetForLine() especially
 504         when the list becomes enormous, for example in the default 30x30 maze test
 505         from http://ie.microsoft.com/testdrive/Performance/MazeSolver/Default.html
 506         there're >3700 floating objects. When placing a new floating object the
 507         entire list (from begin to end) is traversed for multiple times.
 508         There's a low hanging fruit to reduce the chances to do the traversal
 509         which is especially applicable in logicalLeftOffsetForLine and logicalRightOffsetForLine.
 510         As the two routines either cares about FloatLeft objects or FloatRight objects only,
 511         if we know there's no corresponding type floating objects in the list
 512         we can avoid the traversal actually. One thing we could do is to record
 513         the number of FloatLeft objects and the number of FloatRight objects and
 514         add a check before doing the traversal. This can reduce the time by 45%
 515         to resolve the 30x30 Maze measured on N470 Netbook MeeGo using latest
 516         Chromium browser 11 (from 503s to 269s).
 517
 518         No new tests, relying on existing layout tests.
 519
 520         * rendering/RenderBlock.cpp:
 521         (WebCore::RenderBlock::~RenderBlock):
 522         (WebCore::RenderBlock::addOverflowFromFloats):
 523         (WebCore::RenderBlock::repaintOverhangingFloats):
 524         (WebCore::RenderBlock::paintFloats):
 525         (WebCore::RenderBlock::selectionGaps):
 526         (WebCore::RenderBlock::insertFloatingObject):
 527         (WebCore::RenderBlock::removeFloatingObject):
 528         (WebCore::RenderBlock::removeFloatingObjectsBelow):
 529         (WebCore::RenderBlock::positionNewFloats):
 530         (WebCore::RenderBlock::positionNewFloatOnLine):
 531         (WebCore::RenderBlock::logicalLeftOffsetForLine):
 532         (WebCore::RenderBlock::logicalRightOffsetForLine):
 533         (WebCore::RenderBlock::nextFloatLogicalBottomBelow):
 534         (WebCore::RenderBlock::lowestFloatLogicalBottom):
 535         (WebCore::RenderBlock::clearFloats):
 536         (WebCore::RenderBlock::addOverhangingFloats):
 537         (WebCore::RenderBlock::addIntrudingFloats):
 538         (WebCore::RenderBlock::containsFloat):
 539         (WebCore::RenderBlock::hitTestFloats):
 540         (WebCore::RenderBlock::adjustForBorderFit):
 541         (WebCore::RenderBlock::FloatingObjects::clear):
 542         (WebCore::RenderBlock::FloatingObjects::increaseObjectsCount):
 543         (WebCore::RenderBlock::FloatingObjects::decreaseObjectsCount):
 544         * rendering/RenderBlock.h:
 545         (WebCore::RenderBlock::containsFloats):
 546         (WebCore::RenderBlock::FloatingObjects::FloatingObjects):
 547         (WebCore::RenderBlock::FloatingObjects::hasLeftObjects):
 548         (WebCore::RenderBlock::FloatingObjects::hasRightObjects):
 549         (WebCore::RenderBlock::FloatingObjects::set):
 550         * rendering/RenderBlockLineLayout.cpp:
 551         (WebCore::RenderBlock::layoutInlineChildren):
 552         (WebCore::RenderBlock::matchedEndLine):
 553
 554 2011-03-04  Rik Cabanier  <cabanier@gmail.com>
 555
 556         Reviewed by David Hyatt.
 557
 558         Fix that allows fixed length values to be floating point
 559         https://bugs.webkit.org/show_bug.cgi?id=52699
 560
 561         * WebCore.xcodeproj/project.pbxproj:
 562         * css/CSSStyleSelector.cpp:
 563         (WebCore::convertToLength):
 564         (WebCore::convertToIntLength):
 565         (WebCore::convertToFloatLength):
 566         (WebCore::CSSStyleSelector::applyProperty):
 567         (WebCore::CSSStyleSelector::createTransformOperations):
 568         * platform/Length.h:
 569         (WebCore::Length::Length):
 570         (WebCore::Length::operator==):
 571         (WebCore::Length::operator!=):
 572         (WebCore::Length::rawValue):
 573         (WebCore::Length::type):
 574         (WebCore::Length::quirk):
 575         (WebCore::Length::setValue):
 576         (WebCore::Length::calcFloatValue):
 577         (WebCore::Length::isZero):
 578         (WebCore::Length::blend):
 579         (WebCore::Length::getIntValue):
 580         (WebCore::Length::getFloatValue):
 581         * rendering/AutoTableLayout.cpp:
 582         (WebCore::AutoTableLayout::recalcColumn):
 583         (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
 584         * rendering/FixedTableLayout.cpp:
 585         (WebCore::FixedTableLayout::calcWidthArray):
 586
 587 2011-03-04  Steve Falkenburg  <sfalken@apple.com>
 588
 589         Reviewed by Jon Honeycutt.
 590
 591         Adopt VersionStamper tool for Windows WebKit DLLs
 592         https://bugs.webkit.org/show_bug.cgi?id=55784
 593
 594         We now use a tool to stamp the version number onto the Apple WebKit DLLs
 595         during the post-build step.
 596
 597         * WebCore.vcproj/QTMovieWin.rc: Removed.
 598         * WebCore.vcproj/QTMovieWin.vcproj:
 599         * WebCore.vcproj/QTMovieWinPostBuild.cmd: Stamp version with VersionStamper.
 600         * WebCore.vcproj/QTMovieWinPreBuild.cmd: Don't run auto-version.sh. We don't use autoversion.h in this project.
 601         * WebCore.vcproj/WebCoreMediaQT.vsprops: Remove unnecessary include paths for resource files.
 602
 603 2011-03-04  Cosmin Truta  <ctruta@chromium.org>
 604
 605         Reviewed by Adam Barth.
 606
 607         Clarify comment about potential memory leak in SVGImage
 608         https://bugs.webkit.org/show_bug.cgi?id=55362
 609
 610         No functionality change. No new tests.
 611
 612         * svg/graphics/SVGImage.cpp:
 613         (WebCore::SVGImage::dataChanged):
 614
 615 2011-03-04  Jessie Berlin  <jberlin@apple.com>
 616
 617         Reviewed by Maciej Stachowiak.
 618
 619         WebKit2: Use CFNetwork Sessions API.
 620         https://bugs.webkit.org/show_bug.cgi?id=55435.
 621
 622         When Private Browsing is enabled, get the cached url response from the cache associated with
 623         the Private Browsing Storage Session.
 624
 625         * WebCore.exp.in:
 626         Export the symbol for ResourceHandle::privateBrowsingStorageSession.
 627
 628 2011-03-04  Steve Block  <steveblock@google.com>
 629
 630         Reviewed by Jeremy Orlow.
 631
 632         JSC and V8 versions of Java bridge should share JobjectWrapper
 633         https://bugs.webkit.org/show_bug.cgi?id=55763
 634
 635         No new tests, refactoring only.
 636
 637         * Android.jscbindings.mk:
 638         * Android.v8bindings.mk:
 639         * WebCore.gypi:
 640         * WebCore.order:
 641         * WebCore.xcodeproj/project.pbxproj:
 642         * bridge/jni/JobjectWrapper.cpp:
 643         (JobjectWrapper::JobjectWrapper):
 644         (JobjectWrapper::~JobjectWrapper):
 645         * bridge/jni/JobjectWrapper.h:
 646         (JSC::Bindings::JobjectWrapper::instance):
 647         (JSC::Bindings::JobjectWrapper::setInstance):
 648         (JSC::Bindings::JobjectWrapper::ref):
 649         (JSC::Bindings::JobjectWrapper::deref):
 650         * bridge/jni/jsc/JNIBridgeJSC.cpp:
 651         (JavaField::JavaField):
 652         (JavaArray::JavaArray):
 653         * bridge/jni/jsc/JNIBridgeJSC.h:
 654         * bridge/jni/jsc/JavaInstanceJSC.cpp:
 655         (JavaInstance::JavaInstance):
 656         * bridge/jni/jsc/JavaInstanceJSC.h:
 657
 658 2011-03-04  Patrick Gansterer  <paroga@webkit.org>
 659
 660         Reviewed by Nikolas Zimmermann.
 661
 662         Move shared code into SVGStyledTransformableElement::svgAttributeChanged
 663         https://bugs.webkit.org/show_bug.cgi?id=55771
 664
 665         All sub classes of SVGStyledTransformableElement request a relayout
 666         the same way. So move that code into the common base class.
 667
 668         * svg/SVGCircleElement.cpp:
 669         (WebCore::SVGCircleElement::svgAttributeChanged):
 670         * svg/SVGEllipseElement.cpp:
 671         (WebCore::SVGEllipseElement::svgAttributeChanged):
 672         * svg/SVGForeignObjectElement.cpp:
 673         (WebCore::SVGForeignObjectElement::svgAttributeChanged):
 674         * svg/SVGGElement.cpp:
 675         (WebCore::SVGGElement::svgAttributeChanged):
 676         * svg/SVGImageElement.cpp:
 677         (WebCore::SVGImageElement::svgAttributeChanged):
 678         * svg/SVGLineElement.cpp:
 679         (WebCore::SVGLineElement::svgAttributeChanged):
 680         * svg/SVGPathElement.cpp:
 681         (WebCore::SVGPathElement::svgAttributeChanged):
 682         * svg/SVGPolyElement.cpp:
 683         (WebCore::SVGPolyElement::svgAttributeChanged):
 684         * svg/SVGRectElement.cpp:
 685         (WebCore::SVGRectElement::svgAttributeChanged):
 686         * svg/SVGStyledTransformableElement.cpp:
 687         (WebCore::SVGStyledTransformableElement::svgAttributeChanged):
 688         * svg/SVGStyledTransformableElement.h:
 689         * svg/SVGUseElement.cpp:
 690         (WebCore::SVGUseElement::svgAttributeChanged):
 691
 692 2011-03-03  John Abd-El-Malek  <jam@chromium.org>
 693
 694         Reviewed by Dimitri Glazkov.
 695
 696         [chromium] Get rid of IsContentFiltered flags since they&apos;re not used anymore
 697         https://bugs.webkit.org/show_bug.cgi?id=55748
 698
 699         * platform/network/chromium/ResourceResponse.cpp:
 700         (WebCore::ResourceResponse::doPlatformCopyData):
 701         (WebCore::ResourceResponse::doPlatformAdopt):
 702         * platform/network/chromium/ResourceResponse.h:
 703         (WebCore::ResourceResponse::ResourceResponse):
 704
 705 2011-03-03  Timothy Hatcher  <timothy@apple.com>
 706
 707         Export SerializedScriptValue::create(JSC::ExecState* exec, JSC::JSValue value).
 708
 709         Reviewed by Darin Adler.
 710
 711         * WebCore.exp.in: Added __ZN7WebCore21SerializedScriptValue6createEPN3JSC9ExecStateENS1_7JSValueE.
 712
 713 2011-03-04  Pavel Podivilov  <podivilov@chromium.org>
 714
 715         Reviewed by Yury Semikhatsky.
 716
 717         Web Inspector: extract all code that depends on source mapping from SourceFrame.
 718         https://bugs.webkit.org/show_bug.cgi?id=55464
 719
 720         Extract all dependencies on DebuggerModel and ScriptsPanel to a delegate class
 721         to encapsulate source mapping aspects from SourceFrame.
 722
 723         * inspector/front-end/ResourceView.js:
 724         (WebInspector.ResourceView.createResourceView):
 725         (WebInspector.SourceFrameDelegateForResourcesPanel):
 726         (WebInspector.SourceFrameDelegateForResourcesPanel.prototype.requestContent):
 727         * inspector/front-end/ScriptsPanel.js:
 728         (WebInspector.ScriptsPanel.prototype._createSourceFrame):
 729         (WebInspector.SourceFrameDelegateForScriptsPanel):
 730         * inspector/front-end/SourceFrame.js:
 731         (WebInspector.SourceFrame):
 732         (WebInspector.SourceFrame.prototype.show):
 733         (WebInspector.SourceFrame.prototype._createTextViewer):
 734         (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
 735         (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
 736         (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
 737         (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition):
 738         (WebInspector.SourceFrame.prototype._contextMenu.else.setBreakpointEnabled):
 739         (WebInspector.SourceFrame.prototype._contextMenu):
 740         (WebInspector.SourceFrame.prototype._mouseDown):
 741         (WebInspector.SourceFrame.prototype._mouseMove):
 742         (WebInspector.SourceFrame.prototype._hidePopup):
 743         (WebInspector.SourceFrame.prototype._mouseHover):
 744         (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
 745         (WebInspector.SourceFrame.prototype._showPopup):
 746         (WebInspector.SourceFrame.prototype._doubleClick):
 747         (WebInspector.SourceFrame.prototype._didEditLine):
 748         (WebInspector.SourceFrameDelegate):
 749         (WebInspector.SourceFrameDelegate.prototype.requestContent):
 750         (WebInspector.SourceFrameDelegate.prototype.debuggingSupported):
 751         (WebInspector.SourceFrameDelegate.prototype.setBreakpoint):
 752         (WebInspector.SourceFrameDelegate.prototype.removeBreakpoint):
 753         (WebInspector.SourceFrameDelegate.prototype.updateBreakpoint):
 754         (WebInspector.SourceFrameDelegate.prototype.findBreakpoint):
 755         (WebInspector.SourceFrameDelegate.prototype.continueToLine):
 756         (WebInspector.SourceFrameDelegate.prototype.canEditScriptSource):
 757         (WebInspector.SourceFrameDelegate.prototype.editScriptSource):
 758         (WebInspector.SourceFrameDelegate.prototype.debuggerPaused):
 759         (WebInspector.SourceFrameDelegate.prototype.evaluate):
 760         (WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):
 761
 762 2011-03-04  Andrey Kosyakov  <caseq@chromium.org>
 763
 764         Reviewed by Pavel Feldman.
 765
 766         Web Inspector: [Extensions API] maintain own, unique & persistent identifiers for resources.
 767         https://bugs.webkit.org/show_bug.cgi?id=55686
 768
 769         - Use internal ids for resources in extension server.
 770         - Log errors in inspector tests.
 771
 772         * inspector/front-end/ExtensionServer.js:
 773         (WebInspector.ExtensionServer):
 774         (WebInspector.ExtensionServer.prototype.resetResources):
 775         (WebInspector.ExtensionServer.prototype._notifyResourceFinished):
 776         (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
 777         (WebInspector.ExtensionServer.prototype._onGetHAR):
 778         (WebInspector.ExtensionServer.prototype._onGetResourceContent):
 779         (WebInspector.ExtensionServer.prototype._resourceId):
 780         (WebInspector.ExtensionServer.prototype._resourceById):
 781         * inspector/front-end/HAREntry.js:
 782         (WebInspector.HARLog):
 783         (WebInspector.HARLog.prototype._convertResource):
 784         * inspector/front-end/NetworkPanel.js:
 785         (WebInspector.NetworkPanel.prototype._reset):
 786
 787 2011-03-04  Andrey Kosyakov  <caseq@chromium.org>
 788
 789         Reviewed by Pavel Feldman.
 790
 791         Web Inspector: exceptions when building context menu in network panel
 792         https://bugs.webkit.org/show_bug.cgi?id=55678
 793
 794         * inspector/front-end/DataGrid.js:
 795         (WebInspector.DataGrid.prototype.dataGridNodeFromNode):
 796         (WebInspector.DataGrid.prototype.dataGridNodeFromPoint):
 797         * inspector/front-end/NetworkPanel.js:
 798         (WebInspector.NetworkPanel.prototype._contextMenu):
 799
 800 2011-03-04  Ilya Sherman  <isherman@chromium.org>
 801
 802         Reviewed by James Robinson.
 803
 804         Override paintScrollCorner() for FramelessScrollView to forego any custom scrollbar corner rendering.
 805         This was previously done in ScrollbarThemeChromium, but we also need this on the Mac when the ScrollView
 806         is a FramelessScrollView -- which is mostly just for Autofill.
 807         In service of http://crbug.com/73772 (crash)
 808         https://bugs.webkit.org/show_bug.cgi?id=55557
 809
 810         No tests added because this fix is Chromium-specific and the code is currently untestable from within WebKit.
 811         In particular, DRT crashes when trying to render a FramelessScrollView.
 812
 813         * platform/ScrollbarTheme.h:
 814         (WebCore::ScrollbarTheme::paintScrollCorner): Body moved to static function defaultPaintScrollCorner().
 815         (WebCore::ScrollbarTheme::defaultPaintScrollCorner): Added.
 816         * platform/chromium/FramelessScrollView.cpp:
 817         (WebCore::FramelessScrollView::paintContents):
 818         (WebCore::FramelessScrollView::paintScrollCorner): Fix implementation moved to here from ScrollbarThemeChromium
 819         * platform/chromium/FramelessScrollView.h:
 820         * platform/chromium/ScrollbarThemeChromium.cpp:
 821         * platform/chromium/ScrollbarThemeChromium.h:
 822
 823 2011-03-04  Yury Semikhatsky  <yurys@chromium.org>
 824
 825         Reviewed by Pavel Feldman.
 826
 827         Web Inspector: move dispatching of didCommitLoad to agents into InspectorInstrumentation
 828         https://bugs.webkit.org/show_bug.cgi?id=55770
 829
 830         * inspector/InspectorAgent.cpp:
 831         (WebCore::InspectorAgent::InspectorAgent):
 832         (WebCore::InspectorAgent::didCommitLoad):
 833         * inspector/InspectorCSSAgent.cpp:
 834         (WebCore::InspectorCSSAgent::InspectorCSSAgent):
 835         (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
 836         * inspector/InspectorCSSAgent.h:
 837         * inspector/InspectorDatabaseAgent.cpp:
 838         (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
 839         * inspector/InspectorInstrumentation.cpp:
 840         (WebCore::InspectorInstrumentation::didCommitLoadImpl):
 841         * inspector/InspectorInstrumentation.h:
 842         (WebCore::InspectorInstrumentation::didCommitLoad):
 843         * inspector/InspectorProfilerAgent.cpp:
 844         (WebCore::InspectorProfilerAgent::create):
 845         (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
 846         (WebCore::InspectorProfilerAgent::~InspectorProfilerAgent):
 847         (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
 848         (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
 849         (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
 850         (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
 851         * inspector/InspectorProfilerAgent.h:
 852         * inspector/InstrumentingAgents.h:
 853         (WebCore::InstrumentingAgents::InstrumentingAgents):
 854         (WebCore::InstrumentingAgents::inspectorCSSAgent):
 855         (WebCore::InstrumentingAgents::setInspectorCSSAgent):
 856         (WebCore::InstrumentingAgents::inspectorDOMStorageAgent):
 857         (WebCore::InstrumentingAgents::setInspectorDOMStorageAgent):
 858         (WebCore::InstrumentingAgents::inspectorDatabaseAgent):
 859         (WebCore::InstrumentingAgents::setInspectorDatabaseAgent):
 860         (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent):
 861         (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
 862         (WebCore::InstrumentingAgents::inspectorDebuggerAgent):
 863         (WebCore::InstrumentingAgents::setInspectorDebuggerAgent):
 864         (WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent):
 865         (WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent):
 866         (WebCore::InstrumentingAgents::inspectorProfilerAgent):
 867         (WebCore::InstrumentingAgents::setInspectorProfilerAgent):
 868
 869 2011-03-04  Ilya Tikhonovsky  <loislo@chromium.org>
 870
 871         Reviewed by Yury Semikhatsky.
 872
 873         Web Inspector: rename RuntimeAgent's function from releaseWrapperObjectGroup to releaseObjectGroup.
 874         https://bugs.webkit.org/show_bug.cgi?id=55773
 875
 876         * inspector/CodeGeneratorInspector.pm:
 877         * inspector/InjectedScript.cpp:
 878         (WebCore::InjectedScript::releaseObjectGroup):
 879         * inspector/InjectedScript.h:
 880         * inspector/InjectedScriptHost.cpp:
 881         (WebCore::InjectedScriptHost::releaseObjectGroup):
 882         * inspector/InjectedScriptHost.h:
 883         * inspector/InjectedScriptSource.js:
 884         (.):
 885         * inspector/Inspector.idl:
 886         * inspector/InspectorConsoleAgent.cpp:
 887         (WebCore::InspectorConsoleAgent::clearConsoleMessages):
 888         * inspector/InspectorRuntimeAgent.cpp:
 889         (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
 890         * inspector/InspectorRuntimeAgent.h:
 891         * inspector/front-end/ConsoleView.js:
 892         (WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
 893         (WebInspector.ConsoleView.prototype.completions):
 894         * inspector/front-end/PropertiesSidebarPane.js:
 895         * inspector/front-end/SourceFrame.js:
 896         (WebInspector.SourceFrame.prototype._hidePopup):
 897         * inspector/front-end/WatchExpressionsSidebarPane.js:
 898         (WebInspector.WatchExpressionsSection.prototype.update):
 899
 900 2011-03-02  Andrey Adaikin  <aandrey@google.com>
 901
 902         Reviewed by Pavel Feldman.
 903
 904         Web Inspector: Gutter height should be 100% when few lines are displayed
 905         https://bugs.webkit.org/show_bug.cgi?id=55574
 906
 907         * inspector/front-end/SourceFrame.js:
 908         (WebInspector.SourceFrame.prototype._startEditing):
 909         * inspector/front-end/TextViewer.js:
 910         (WebInspector.TextViewer.prototype._syncScroll):
 911         (WebInspector.TextEditorGutterPanel.prototype._expandChunks):
 912         (WebInspector.TextEditorGutterPanel.prototype.textChanged):
 913         (WebInspector.TextEditorGutterPanel.prototype.syncClientHeight):
 914         * inspector/front-end/textViewer.css:
 915         (.text-editor-lines):
 916         (.text-editor-contents .inner-container):
 917         (.webkit-line-number):
 918
 919 2011-03-04  Andrey Adaikin  <aandrey@google.com>
 920
 921         Reviewed by Pavel Feldman.
 922
 923         Web Inspector: [Text editor] Do bisect to find visible chunks
 924         https://bugs.webkit.org/show_bug.cgi?id=55685
 925
 926         * inspector/front-end/TextViewer.js:
 927         (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine):
 928         (WebInspector.TextEditorChunkedPanel.prototype._findVisibleChunks):
 929         (WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
 930         (WebInspector.TextEditorGutterChunk.prototype.get offsetTop):
 931         (WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
 932         (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
 933
 934 2011-03-04  Andrey Adaikin  <aandrey@google.com>
 935
 936         Reviewed by Pavel Feldman.
 937
 938         Web Inspector: [Text editor] DOMNodeRemoved events are missing
 939         https://bugs.webkit.org/show_bug.cgi?id=55769
 940
 941         * inspector/front-end/TextViewer.js:
 942         (WebInspector.TextEditorMainPanel):
 943         (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
 944         (WebInspector.TextEditorMainChunk):
 945         (WebInspector.TextEditorMainChunk.prototype._createRow):
 946
 947 2011-03-04  Ilya Tikhonovsky  <loislo@chromium.org>
 948
 949         Reviewed by Yury Semikhatsky.
 950
 951         Web Inspector: Remove unnecessary domain and success flags from the response messages.
 952         https://bugs.webkit.org/show_bug.cgi?id=55768
 953
 954         We have domain property in the response messages but it is not used because we dispatch
 955         the responses on the callback associated with seq.
 956
 957         If we have property 'errors' in the response then success eq false and true in the other case.
 958
 959         * inspector/CodeGeneratorInspector.pm:
 960
 961 2011-03-04  Christian Dywan  <christian@lanedo.com>
 962
 963         Reviewed by Gustavo Noronha Silva.
 964
 965         Enable Copy Image Address context menu item in the Gtk port
 966         https://bugs.webkit.org/show_bug.cgi?id=55136
 967
 968         * page/ContextMenuController.cpp:
 969         * platform/ContextMenuItem.h:
 970         * platform/LocalizationStrategy.h:
 971         * platform/LocalizedStrings.cpp:
 972         * platform/LocalizedStrings.h:
 973         * platform/gtk/ContextMenuItemGtk.cpp:
 974         * platform/gtk/LocalizedStringsGtk.cpp:
 975
 976 2011-03-04  Pavel Feldman  <pfeldman@chromium.org>
 977
 978         Reviewed by Yury Semikhatsky.
 979
 980         Web Inspector: implement getCompletions via evaluate.
 981         https://bugs.webkit.org/show_bug.cgi?id=55759
 982
 983         * inspector/InjectedScript.cpp:
 984         * inspector/InjectedScript.h:
 985         * inspector/InjectedScriptSource.js:
 986         * inspector/Inspector.idl:
 987         * inspector/InspectorDebuggerAgent.cpp:
 988         * inspector/InspectorDebuggerAgent.h:
 989         * inspector/InspectorRuntimeAgent.cpp:
 990         * inspector/InspectorRuntimeAgent.h:
 991         * inspector/front-end/ConsoleView.js:
 992         (WebInspector.ConsoleView.prototype.completions.evaluated):
 993         (WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
 994         (WebInspector.ConsoleView.prototype.completions):
 995         (WebInspector.ConsoleView.prototype._reportCompletions):
 996         * inspector/front-end/ScriptsPanel.js:
 997         (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper):
 998         (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
 999         * inspector/front-end/SourceFrame.js:
1000         (WebInspector.SourceFrame.prototype._showPopup):
1001         (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
1002
1003 2011-03-04  Steve Block  <steveblock@google.com>
1004
1005         Reviewed by Jeremy Orlow.
1006
1007         V8 version of JavaString should obtain string from JNI in UTF-16 encoding
1008         https://bugs.webkit.org/show_bug.cgi?id=55566
1009
1010         We obtain the string from JNI in UTF-16 encoding and convert
1011         to UTF-8 using our own routines as required. This matches the
1012         behaviour of the JSC version of JavaString.
1013
1014         No new tests, no change in behaviour.
1015
1016         * bridge/jni/v8/JavaStringV8.h:
1017         (JSC::Bindings::JavaStringImpl::init):
1018         (JSC::Bindings::JavaStringImpl::utf8):
1019         (JSC::Bindings::JavaStringImpl::impl):
1020
1021 2011-03-03  Pavel Feldman  <pfeldman@chromium.org>
1022
1023         Reviewed by Yury Semikhatsky.
1024
1025         Web Inspector: do not push document into front-end, make it request one.
1026         https://bugs.webkit.org/show_bug.cgi?id=55664
1027
1028         * inspector/Inspector.idl:
1029         * inspector/InspectorAgent.cpp:
1030         (WebCore::InspectorAgent::InspectorAgent):
1031         * inspector/InspectorAgent.h:
1032         * inspector/InspectorBrowserDebuggerAgent.cpp:
1033         (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
1034         * inspector/InspectorDOMAgent.cpp:
1035         (WebCore::InspectorDOMAgent::InspectorDOMAgent):
1036         (WebCore::InspectorDOMAgent::clearFrontend):
1037         (WebCore::InspectorDOMAgent::setDocument):
1038         (WebCore::InspectorDOMAgent::getDocument):
1039         (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
1040         (WebCore::InspectorDOMAgent::boundNodeId):
1041         (WebCore::InspectorDOMAgent::resolveNode):
1042         (WebCore::InspectorDOMAgent::mainFrameDOMContentLoaded):
1043         * inspector/InspectorDOMAgent.h:
1044         (WebCore::InspectorDOMAgent::create):
1045         * inspector/front-end/BreakpointManager.js:
1046         (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints):
1047         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
1048         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
1049         * inspector/front-end/DOMAgent.js:
1050         (WebInspector.DOMDocument):
1051         (WebInspector.DOMAgent):
1052         (WebInspector.DOMAgent.prototype.requestDocument):
1053         (WebInspector.DOMAgent.prototype.pushNodeToFrontend):
1054         (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
1055         (WebInspector.DOMAgent.prototype._attributesUpdated):
1056         (WebInspector.DOMAgent.prototype._characterDataModified):
1057         (WebInspector.DOMAgent.prototype._documentUpdated):
1058         (WebInspector.DOMAgent.prototype._setDocument):
1059         (WebInspector.DOMAgent.prototype._setDetachedRoot):
1060         (WebInspector.DOMAgent.prototype._setChildNodes):
1061         (WebInspector.DOMAgent.prototype._childNodeInserted):
1062         (WebInspector.DOMAgent.prototype._childNodeRemoved):
1063         (WebInspector.DOMDispatcher.prototype.documentUpdated):
1064         * inspector/front-end/ElementsPanel.js:
1065         (WebInspector.ElementsPanel.prototype.show):
1066         (WebInspector.ElementsPanel.prototype.setDocument):
1067         * inspector/front-end/MetricsSidebarPane.js:
1068         * inspector/front-end/RemoteObject.js:
1069         (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
1070
1071 2011-03-04  Andrey Kosyakov  <caseq@chromium.org>
1072
1073         Reviewed by Pavel Feldman.
1074
1075         Web Inspector: summary bar may overlap content of the network item view
1076         https://bugs.webkit.org/show_bug.cgi?id=55656
1077
1078         - drop custom summary bar placement logic, do it with CSS instead.
1079
1080         * inspector/front-end/NetworkPanel.js:
1081         (WebInspector.NetworkPanel.prototype.resize):
1082         (WebInspector.NetworkPanel.prototype._createSummaryBar):
1083         (WebInspector.NetworkPanel.prototype._updateSummaryBar):
1084         (WebInspector.NetworkPanel.prototype._updateFilter):
1085         (WebInspector.NetworkPanel.prototype.show):
1086         (WebInspector.NetworkPanel.prototype.refresh):
1087         (WebInspector.NetworkPanel.prototype._reset):
1088         (WebInspector.NetworkPanel.prototype._setLargerResources):
1089         (WebInspector.NetworkPanel.prototype._updateOffscreenRows):
1090         * inspector/front-end/networkPanel.css:
1091         (.network-sidebar .data-grid td):
1092         (.network-sidebar tr.filler td):
1093         (.network-summary-bar):
1094         (.network-sidebar .data-grid .network-summary-bar td):
1095         (.network-summary-bar img):
1096
1097 2011-03-04  James Su <suzhe@chromium.org>
1098
1099         Reviewed by Dimitri Glazkov.
1100
1101         [Chromium] keycode is always 0 when using non-Latin keyboard layout.
1102         https://bugs.webkit.org/show_bug.cgi?id=54939
1103
1104         Add KeyEventCocoa.{h,mm}, so that we can reuse them in chromium.
1105
1106         No intended functionality change.
1107
1108         * WebCore.gyp/WebCore.gyp:
1109         * WebCore.gypi:
1110
1111 2011-03-04  Patrick Gansterer  <paroga@webkit.org>
1112
1113         Unreviewed EFL build fix for r80324.
1114
1115         * platform/efl/RenderThemeEfl.cpp:
1116         (WebCore::RenderThemeEfl::paintThemePart):
1117
1118 2011-03-04  Patrick Gansterer  <paroga@webkit.org>
1119
1120         Unreviewed EFL build fix for r80324.
1121
1122         * platform/efl/RenderThemeEfl.cpp:
1123         (WebCore::RenderThemeEfl::paintThemePart):
1124
1125 2011-03-03  Yury Semikhatsky  <yurys@chromium.org>
1126
1127         Reviewed by Pavel Feldman.
1128
1129         Web Inspector: AppCache agent should have same lifetime as InspectorAgent
1130         https://bugs.webkit.org/show_bug.cgi?id=55673
1131
1132         * inspector/InspectorAgent.cpp:
1133         (WebCore::InspectorAgent::InspectorAgent):
1134         (WebCore::InspectorAgent::setFrontend):
1135         (WebCore::InspectorAgent::disconnectFrontend):
1136         (WebCore::InspectorAgent::createFrontendLifetimeAgents):
1137         (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
1138         (WebCore::InspectorAgent::didCommitLoad):
1139         * inspector/InspectorApplicationCacheAgent.cpp:
1140         (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
1141         (WebCore::InspectorApplicationCacheAgent::setFrontend):
1142         (WebCore::InspectorApplicationCacheAgent::clearFrontend):
1143         * inspector/InspectorApplicationCacheAgent.h:
1144         * inspector/InspectorInstrumentation.cpp:
1145         (WebCore::InspectorInstrumentation::networkStateChangedImpl):
1146         (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
1147         * inspector/InstrumentingAgents.h:
1148         (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent):
1149         (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
1150
1151 2011-03-03  Brian Weinstein  <bweinstein@apple.com>
1152
1153         Reviewed by Adam Roben.
1154
1155         Cleanup from https://bugs.webkit.org/show_bug.cgi?id=55427.
1156
1157         Call WebCore::startObservingCookieChanges and WebCore::stopObservingCookieChanges
1158         on all platforms, and stub the functions on platforms that don't implement them.
1159
1160         Add startObservingCookieChanges and stopObservingCookieChanges to TemporaryLinkStubs
1161         for platforms that don't implement them.
1162
1163         * platform/android/TemporaryLinkStubs.cpp:
1164         * platform/brew/TemporaryLinkStubs.cpp:
1165         * platform/chromium/TemporaryLinkStubs.cpp:
1166         * platform/efl/TemporaryLinkStubs.cpp:
1167         * platform/gtk/TemporaryLinkStubs.cpp:
1168         * platform/haiku/TemporaryLinkStubs.cpp:
1169         * platform/qt/TemporaryLinkStubsQt.cpp:
1170         * platform/win/TemporaryLinkStubs.cpp:
1171
1172 2011-03-03  Eric Seidel  <eric@webkit.org>
1173
1174         Reviewed by Dimitri Glazkov.
1175
1176         Refactor createRendererIfNeeded to avoid premature nextRenderer calculation
1177         https://bugs.webkit.org/show_bug.cgi?id=55720
1178
1179         There are two thing going on here:
1180         1. Delaying nextRenderer calculation until we actually use it,
1181            previously we would always compute nextRenderer (expensive!)
1182            even if no renderer insertion was to occur.
1183         2. Fix fullscreen elements to be inserted into the right place
1184            in the rendering tree.  Previously they would always be the last
1185            child in their parent's list, even if that wasn't the right place.
1186
1187         I don't know of any way to trigger the fullscreen bug,
1188         but I tested this with peacekeeper and saw no performance change.
1189
1190         Peacekeeper's domJQueryBasics is now possibly as much as 2% faster
1191         but I don't really trust the stability of peacekeeper to begin with.
1192
1193         This paves the way for further improvement in our nextRenderer calculation.
1194
1195         * dom/Node.cpp:
1196         (WebCore::Node::attach):
1197         (WebCore::Node::previousRenderer):
1198         (WebCore::Node::nextRenderer):
1199         (WebCore::Node::createRendererAndStyle):
1200         (WebCore::wrapWithRenderFullScreen):
1201         (WebCore::Node::createRendererIfNeeded):
1202         * dom/Node.h:
1203
1204 2011-03-03  Ryosuke Niwa  <rniwa@webkit.org>
1205
1206         Reviewed by Darin Adler.
1207
1208         Remove LOOSE_PASS_OWN_ARRAY_PTR from PassOwnArrayPtr.h
1209         https://bugs.webkit.org/show_bug.cgi?id=55554
1210
1211         * platform/Length.cpp:
1212         (WebCore::newLengthArray): Pass nullptr instead of 0.
1213
1214 2011-03-03  Nat Duca  <nduca@chromium.org>
1215
1216         Reviewed by James Robinson.
1217
1218         [chromium] Create a LayerChromium layerTreeAsText. Add HUD to
1219         LayerRendererChromium that draws compositor FPS and, optionally,
1220         the layer tree.
1221         https://bugs.webkit.org/show_bug.cgi?id=54710
1222
1223         * WebCore.gypi:
1224         * platform/graphics/chromium/Canvas2DLayerChromium.h:
1225         (WebCore::Canvas2DLayerChromium::drawsContent):
1226         * platform/graphics/chromium/CanvasLayerChromium.h:
1227         (WebCore::CanvasLayerChromium::layerTypeAsString):
1228         * platform/graphics/chromium/ContentLayerChromium.cpp:
1229         (WebCore::writeIndent):
1230         (WebCore::ContentLayerChromium::dumpLayerProperties):
1231         * platform/graphics/chromium/ContentLayerChromium.h:
1232         (WebCore::ContentLayerChromium::drawsContent):
1233         (WebCore::ContentLayerChromium::layerTypeAsString):
1234         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1235         (WebCore::GraphicsLayerChromium::setName):
1236         (WebCore::GraphicsLayerChromium::updateNames):
1237         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1238         (WebCore::GraphicsLayerChromium::setupContentsLayer):
1239         * platform/graphics/chromium/GraphicsLayerChromium.h:
1240         * platform/graphics/chromium/ImageLayerChromium.h:
1241         (WebCore::ImageLayerChromium::drawsContent):
1242         (WebCore::ImageLayerChromium::layerTypeAsString):
1243         * platform/graphics/chromium/LayerChromium.cpp:
1244         (WebCore::LayerChromium::LayerChromium):
1245         (WebCore::LayerChromium::setName):
1246         (WebCore::LayerChromium::layerTreeAsText):
1247         (WebCore::writeIndent):
1248         (WebCore::LayerChromium::dumpLayer):
1249         (WebCore::LayerChromium::dumpLayerProperties):
1250         * platform/graphics/chromium/LayerChromium.h:
1251         (WebCore::LayerChromium::name):
1252         (WebCore::LayerChromium::drawsContent):
1253         (WebCore::LayerChromium::debugID):
1254         (WebCore::LayerChromium::layerTypeAsString):
1255         * platform/graphics/chromium/LayerRendererChromium.cpp:
1256         (WebCore::LayerRendererChromium::LayerRendererChromium):
1257         (WebCore::LayerRendererChromium::~LayerRendererChromium):
1258         (WebCore::LayerRendererChromium::drawLayers):
1259         (WebCore::LayerRendererChromium::present):
1260         (WebCore::LayerRendererChromium::layerTreeAsText):
1261         (WebCore::LayerRendererChromium::dumpRenderSurfaces):
1262         * platform/graphics/chromium/LayerRendererChromium.h:
1263         (WebCore::LayerRendererChromium::getHeadsUpDisplay):
1264         (WebCore::LayerRendererChromium::rootVisibleRect):
1265         * platform/graphics/chromium/PluginLayerChromium.h:
1266         (WebCore::PluginLayerChromium::drawsContent):
1267         (WebCore::PluginLayerChromium::layerTypeAsString):
1268         * platform/graphics/chromium/RenderSurfaceChromium.cpp:
1269         (WebCore::RenderSurfaceChromium::name):
1270         (WebCore::writeIndent):
1271         (WebCore::RenderSurfaceChromium::dumpSurface):
1272         * platform/graphics/chromium/RenderSurfaceChromium.h:
1273         * platform/graphics/chromium/VideoLayerChromium.h:
1274         (WebCore::VideoLayerChromium::drawsContent):
1275         (WebCore::VideoLayerChromium::layerTypeAsString):
1276         * platform/graphics/chromium/WebGLLayerChromium.h:
1277         (WebCore::WebGLLayerChromium::drawsContent):
1278         (WebCore::WebGLLayerChromium::layerTypeAsString):
1279         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: Added.
1280         (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
1281         (WebCore::CCHeadsUpDisplay::~CCHeadsUpDisplay):
1282         (WebCore::CCHeadsUpDisplay::draw):
1283         (WebCore::CCHeadsUpDisplay::drawHudContents):
1284         (WebCore::CCHeadsUpDisplay::onPresent):
1285         * platform/graphics/chromium/cc/CCHeadsUpDisplay.h: Added.
1286         (WebCore::CCHeadsUpDisplay::setShowFPSCounter):
1287         (WebCore::CCHeadsUpDisplay::showFPSCounter):
1288         (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
1289         (WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
1290         (WebCore::CCHeadsUpDisplay::enabled):
1291         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
1292         (WebCore::CCLayerImpl::CCLayerImpl):
1293         (WebCore::writeIndent):
1294         (WebCore::CCLayerImpl::dumpLayerProperties):
1295         * platform/graphics/chromium/cc/CCLayerImpl.h:
1296         (WebCore::CCLayerImpl::debugID):
1297         (WebCore::CCLayerImpl::setName):
1298         (WebCore::CCLayerImpl::name):
1299
1300 2011-03-02  Ojan Vafai  <ojan@chromium.org>
1301
1302         Reviewed by Darin Adler.
1303
1304         crash in adoptNode with mutation events
1305         https://bugs.webkit.org/show_bug.cgi?id=50046
1306
1307         If the DOM is modified during the removeChild call in adoptNode,
1308         then the setDocument call that follows can leave the DOM in an
1309         inconsistent state.
1310
1311         * dom/Document.cpp:
1312         (WebCore::Document::adoptNode):
1313
1314 2011-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
1315
1316         Reviewed by Darin Adler.
1317
1318         Add audio tag tests to the media controls manual test suite.
1319         https://bugs.webkit.org/show_bug.cgi?id=55722
1320
1321         * manual-tests/media-controls.html: Added 4 audio tests.
1322
1323 2011-03-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1324
1325         Reviewed by Eric Seidel.
1326
1327         [EFL] Adjust functions of RenderThemeEfl.cpp to WebKit parameter style
1328         https://bugs.webkit.org/show_bug.cgi?id=54392
1329
1330         Functions of RenderThemeEfl.cpp adhere efl coding style instead of WebKit coding style.
1331         WebCore's functions should adhere WebKit coding style.
1332
1333         * platform/efl/RenderThemeEfl.cpp:
1334         (WebCore::RenderThemeEfl::themePartCacheEntryReset):
1335         (WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):
1336         (WebCore::RenderThemeEfl::cacheThemePartNew):
1337         (WebCore::RenderThemeEfl::cacheThemePartReset):
1338         (WebCore::RenderThemeEfl::cacheThemePartResizeAndReset):
1339         (WebCore::RenderThemeEfl::cacheThemePartGet):
1340         (WebCore::RenderThemeEfl::cacheThemePartFlush):
1341         (WebCore::RenderThemeEfl::applyEdjeStateFromForm):
1342         (WebCore::RenderThemeEfl::paintThemePart):
1343         (WebCore::renderThemeEflColorClassSelectionActive):
1344         (WebCore::renderThemeEflColorClassSelectionInactive):
1345         (WebCore::renderThemeEflColorClassFocusRing):
1346         (WebCore::renderThemeEflColorClassButtonText):
1347         (WebCore::renderThemeEflColorClassComboText):
1348         (WebCore::renderThemeEflColorClassEntryText):
1349         (WebCore::renderThemeEflColorClassSearchText):
1350         (WebCore::RenderThemeEfl::applyPartDescription):
1351         (WebCore::RenderThemeEfl::applyPartDescriptions):
1352         (WebCore::RenderThemeEfl::controlSupportsTints):
1353         (WebCore::RenderThemeEfl::baselinePosition):
1354         (WebCore::RenderThemeEfl::paintSliderTrack):
1355         (WebCore::RenderThemeEfl::adjustSliderTrackStyle):
1356         (WebCore::RenderThemeEfl::adjustSliderThumbStyle):
1357         (WebCore::RenderThemeEfl::paintSliderThumb):
1358         (WebCore::RenderThemeEfl::adjustCheckboxStyle):
1359         (WebCore::RenderThemeEfl::paintCheckbox):
1360         (WebCore::RenderThemeEfl::adjustRadioStyle):
1361         (WebCore::RenderThemeEfl::paintRadio):
1362         (WebCore::RenderThemeEfl::adjustButtonStyle):
1363         (WebCore::RenderThemeEfl::paintButton):
1364         (WebCore::RenderThemeEfl::adjustMenuListStyle):
1365         (WebCore::RenderThemeEfl::paintMenuList):
1366         (WebCore::RenderThemeEfl::adjustTextFieldStyle):
1367         (WebCore::RenderThemeEfl::paintTextField):
1368         (WebCore::RenderThemeEfl::adjustTextAreaStyle):
1369         (WebCore::RenderThemeEfl::paintTextArea):
1370         (WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
1371         (WebCore::RenderThemeEfl::paintSearchFieldDecoration):
1372         (WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
1373         (WebCore::RenderThemeEfl::paintSearchFieldResultsButton):
1374         (WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle):
1375         (WebCore::RenderThemeEfl::paintSearchFieldResultsDecoration):
1376         (WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
1377         (WebCore::RenderThemeEfl::paintSearchFieldCancelButton):
1378         (WebCore::RenderThemeEfl::adjustSearchFieldStyle):
1379         (WebCore::RenderThemeEfl::paintSearchField):
1380         (WebCore::RenderThemeEfl::adjustProgressBarStyle):
1381         (WebCore::RenderThemeEfl::paintProgressBar):
1382         (WebCore::RenderThemeEfl::paintMediaFullscreenButton):
1383         (WebCore::RenderThemeEfl::paintMediaMuteButton):
1384         (WebCore::RenderThemeEfl::paintMediaPlayButton):
1385         (WebCore::RenderThemeEfl::paintMediaSeekBackButton):
1386         (WebCore::RenderThemeEfl::paintMediaSeekForwardButton):
1387         (WebCore::RenderThemeEfl::paintMediaSliderTrack):
1388         (WebCore::RenderThemeEfl::paintMediaSliderThumb):
1389         (WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer):
1390         (WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack):
1391         (WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb):
1392         (WebCore::RenderThemeEfl::paintMediaCurrentTime):
1393
1394 2011-03-03  Andy Estes  <aestes@apple.com>
1395
1396         Reviewed by Adam Barth.
1397
1398         Assertion failure in toElement(WebCore::Node*)
1399         https://bugs.webkit.org/show_bug.cgi?id=55697
1400
1401         Test: fast/parser/fragment-foreign-content.html
1402
1403         * html/parser/HTMLTreeBuilder.cpp:
1404         (WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken): The current
1405         element in the HTMLElementStack might be a DocumentFragment if a
1406         fragment is being parsed who's first node is foreign content.
1407
1408 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1409
1410         Reviewed by Kenneth Rohde Christiansen.
1411
1412         [QT] Implement mock client-based geolocation for layout testing
1413         https://bugs.webkit.org/show_bug.cgi?id=54334
1414
1415         Implements client() to GeolocationController to re-use geolocationClientMock class
1416         for layout testing purpose.
1417
1418         * page/GeolocationController.h:
1419         (WebCore::GeolocationController::client):
1420
1421 2011-03-03  Ryosuke Niwa  <rniwa@webkit.org>
1422
1423         Reviewed by Kent Tamura.
1424
1425         Stop calling deprecatedNode and deprecatedEditingOffset in InsertTextCommand
1426         https://bugs.webkit.org/show_bug.cgi?id=55352
1427
1428         Stopped calling deprecatedNode and deprecatedEditingOffset in the following functions:
1429
1430         * editing/CompositeEditCommand.cpp:
1431         (WebCore::CompositeEditCommand::positionOutsideTabSpan): Takes care of all types of positions and
1432         no longer calls deprecated functions.
1433         * editing/InsertTextCommand.cpp:
1434         (WebCore::InsertTextCommand::positionInsideTextNode): Ditto; renamed from prepareForTextInsertion.
1435         Check if the text node inside a tab span before checking if the container node is a text node
1436         because the position before or after a text node can still be inside a tab span.
1437         (WebCore::InsertTextCommand::input): No longer calls deprecated functions.
1438         * editing/InsertTextCommand.h:
1439         * editing/ModifySelectionListLevel.cpp:
1440         (WebCore::getStartEndListChildren): Call anchorNode() instead of deprecatedNode() because the start
1441         or the end of selection could be an immediate child of a list node (e.g. br inside ul)
1442
1443 2011-03-03  Hans Wennborg  <hans@chromium.org>
1444
1445         Reviewed by Jeremy Orlow.
1446
1447         IndexedDB: Move last bits of SQL into IDBBackingStore
1448         https://bugs.webkit.org/show_bug.cgi?id=55668
1449
1450         After this, all SQL code for IndexedDB is in IDBBackingStore.cpp.
1451
1452         No new tests: refactoring only.
1453
1454         * storage/IDBBackingStore.cpp:
1455         (WebCore::IDBBackingStore::createTransaction):
1456         * storage/IDBBackingStore.h:
1457         * storage/IDBCursorBackendImpl.h:
1458         * storage/IDBDatabaseBackendImpl.cpp:
1459         (WebCore::IDBDatabaseBackendImpl::backingStore):
1460         * storage/IDBDatabaseBackendImpl.h:
1461         * storage/IDBIndexBackendImpl.h:
1462         * storage/IDBKey.h:
1463         * storage/IDBObjectStoreBackendImpl.h:
1464         * storage/IDBTransactionBackendImpl.cpp:
1465         (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
1466         * storage/IDBTransactionBackendImpl.h:
1467         * storage/IDBTransactionBackendInterface.h:
1468         * storage/IDBTransactionCoordinator.cpp:
1469
1470 2011-03-03  Adam Klein  <adamk@chromium.org>
1471
1472         Reviewed by David Levin.
1473
1474         [fileapi] Tighten up ResolveURICallbacks
1475         https://bugs.webkit.org/show_bug.cgi?id=55638
1476
1477         Two changes:
1478           - Retry only on TYPE_MISMATCH_ERR now that Chromium
1479             properly sets that error code.
1480           - Call DirectoryEntry instead of DOMFileSystem methods.
1481
1482         No change in behavior, so no new tests.
1483
1484         * fileapi/FileSystemCallbacks.cpp:
1485         (WebCore::ResolveURICallbacks::didOpenFileSystem):
1486
1487 2011-03-03  Anders Carlsson  <andersca@apple.com>
1488
1489         Reviewed by Sam Weinig.
1490
1491         Get rid of Page::globalHistoryItem
1492         https://bugs.webkit.org/show_bug.cgi?id=55738
1493
1494         The m_globalHistoryItem is only used by Mac and Windows WebKit1.
1495         Instead of having WebCore updating this member variable, just call out
1496         to a FrameLoaderClient member function and let WebKit keep it up to date.
1497
1498         * loader/EmptyClients.h:
1499         (WebCore::EmptyFrameLoaderClient::dispatchDidRemoveBackForwardItem):
1500         (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryItemForPage):
1501         * loader/FrameLoader.cpp:
1502         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
1503         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
1504         * loader/FrameLoaderClient.h:
1505         (WebCore::FrameLoaderClient::updateGlobalHistoryItemForPage):
1506         * loader/HistoryController.cpp:
1507         (WebCore::HistoryController::goToItem):
1508         (WebCore::HistoryController::updateForStandardLoad):
1509         (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
1510         * page/Page.cpp:
1511         * page/Page.h:
1512
1513 2011-03-02  Jeremy Orlow  <jorlow@chromium.org>
1514
1515         Reviewed by Steve Block.
1516
1517         Cursor.continue with a key param should test less than, not equal to
1518         https://bugs.webkit.org/show_bug.cgi?id=55640
1519
1520         If you supply a param to cursor.continue, we sould guarantee that
1521         the item we continue to is greater than or equal to the parameter.
1522         Right now, we only test equality.
1523
1524         http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBCursor-continue
1525         http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#dfn-steps-for-iterating-a-cursor
1526
1527         Test: storage/indexeddb/cursor-continue.html
1528
1529         * storage/IDBCursorBackendImpl.cpp:
1530         (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
1531         * storage/IDBKey.cpp:
1532         (WebCore::IDBKey::isLessThan):
1533         (WebCore::IDBKey::isEqual):
1534         * storage/IDBKey.h:
1535
1536 2011-03-03  Brent Fulgham  <bfulgham@webkit.org>
1537
1538         Build fix. Need win/cURL DownloadBundle stub.
1539
1540         * platform/network/curl/DownloadBundle.h: Added.
1541
1542 2011-03-03  Geoffrey Garen  <ggaren@apple.com>
1543
1544         Rolled out 80277 and 80280 because they caused event handler layout test
1545         failures.
1546
1547         * WebCore.xcodeproj/project.pbxproj:
1548         * bindings/js/JSDOMGlobalObject.cpp:
1549         * bindings/js/JSDOMGlobalObject.h:
1550         * bindings/js/JSDOMWindowBase.cpp:
1551         * bindings/js/JSDOMWindowBase.h:
1552         * bindings/js/JSDOMWindowCustom.h:
1553         * bindings/js/JSWorkerContextBase.cpp:
1554
1555 2011-03-03  Brady Eidson  <beidson@apple.com>
1556
1557         Reviewed by Darin Adler.
1558
1559         https://bugs.webkit.org/show_bug.cgi?id=55721
1560         Global IconDatabase should be returned by reference, not as a pointer
1561
1562         * history/HistoryItem.cpp:
1563         (WebCore::HistoryItem::HistoryItem):
1564         (WebCore::HistoryItem::~HistoryItem):
1565         (WebCore::HistoryItem::reset):
1566         (WebCore::HistoryItem::icon):
1567         (WebCore::HistoryItem::setURLString):
1568
1569         * loader/FrameLoader.cpp:
1570         (WebCore::FrameLoader::startIconLoader):
1571         (WebCore::FrameLoader::commitIconURLToIconDatabase):
1572
1573         * loader/archive/cf/LegacyWebArchive.cpp:
1574         (WebCore::LegacyWebArchive::create):
1575
1576         * loader/icon/IconDatabase.cpp:
1577         (WebCore::iconDatabase):
1578         * loader/icon/IconDatabase.h:
1579         * loader/icon/IconDatabaseNone.cpp:
1580         (WebCore::iconDatabase):
1581         * loader/icon/wince/IconDatabaseWinCE.cpp:
1582         (WebCore::iconDatabase):
1583
1584         * loader/icon/IconLoader.cpp:
1585         (WebCore::IconLoader::finishLoading):
1586
1587 2011-03-03  Ryosuke Niwa  <rniwa@webkit.org>
1588
1589         Reviewed by Martin Robinson.
1590
1591         Stop instantiating legacy editing positions in FocusController::advanceFocusInDocumentOrder
1592         https://bugs.webkit.org/show_bug.cgi?id=52742
1593
1594         Use firstPositionInOrBeforeNode to instantiate appropriate position.
1595
1596         * page/FocusController.cpp:
1597         (WebCore::FocusController::advanceFocusInDocumentOrder):
1598
1599 2011-03-03  Andy Estes  <aestes@apple.com>
1600
1601         Reviewed by Darin Adler.
1602
1603         When displaying the missing plug-in sheet, pass the 'pluginspage'
1604         attribute to the UI process.
1605         https://bugs.webkit.org/show_bug.cgi?id=55553
1606
1607         * WebCore.exp.in: Export __ZN7WebCore9HTMLNames15pluginspageAttrE.
1608         * html/HTMLAttributeNames.in: Add 'pluginspage' as a known content
1609         attribute.
1610
1611 2011-03-03  Jessie Berlin  <jberlin@apple.com>
1612
1613         Reviewed by Adam Roben.
1614
1615         WebKit2: Use CFNetwork Sessions API.
1616         https://bugs.webkit.org/show_bug.cgi?id=55435
1617
1618         Set the Private Browsing Storage Session on requests when Private Browsing is enabled.
1619
1620         * WebCore.exp.in:
1621         Support using WKCopyRequestWithStorageSession in WebCore.
1622         * platform/mac/WebCoreSystemInterface.h:
1623         Ditto.
1624         * platform/mac/WebCoreSystemInterface.mm:
1625         Ditto.
1626
1627         * platform/network/cf/ResourceHandleCFNet.cpp:
1628         (WebCore::makeFinalRequest):
1629         If Private Browsing is enabled, set the Private Browsing Storage Session on the request.
1630         (WebCore::ResourceHandle::willSendRequest):
1631         Ditto.
1632         * platform/network/mac/ResourceHandleMac.mm:
1633         (WebCore::ResourceHandle::createNSURLConnection):
1634         Ditto.
1635         (WebCore::ResourceHandle::willSendRequest):
1636         Ditto.
1637
1638         * platform/network/cf/ResourceRequest.h:
1639         * platform/network/cf/ResourceRequestCFNet.cpp:
1640         (WebCore::ResourceRequest::setStorageSession):
1641         Call through to WKSI.
1642         * platform/network/mac/ResourceRequestMac.mm:
1643         (WebCore::ResourceRequest::setStorageSession):
1644         Ditto.
1645
1646 2011-03-03  Chris Marrin  <cmarrin@apple.com>
1647
1648         Reviewed by Simon Fraser.
1649
1650         REGRESSION: Accelerated transitions are jumpy
1651         https://bugs.webkit.org/show_bug.cgi?id=55022
1652
1653         Changed the way default TimingFunction is stored according to Adam Roben's
1654         suggestion.
1655
1656         * platform/animation/TimingFunction.h:
1657         (WebCore::CubicBezierTimingFunction::defaultTimingFunction):
1658
1659 2011-03-03  Dan Bernstein  <mitz@apple.com>
1660
1661         Reviewed by Sam Weinig.
1662
1663         Rename -webkit-hyphenate-locale to -webkit-locale
1664         https://bugs.webkit.org/show_bug.cgi?id=55709
1665
1666         * css/CSSComputedStyleDeclaration.cpp:
1667         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1668         * css/CSSParser.cpp:
1669         (WebCore::CSSParser::parseValue):
1670         (WebCore::cssPropertyID):
1671         * css/CSSPropertyNames.in:
1672         * css/CSSStyleSelector.cpp:
1673         (WebCore::CSSStyleSelector::applyProperty):
1674         * rendering/RenderBlockLineLayout.cpp:
1675         (WebCore::RenderBlock::findNextLineBreak):
1676         * rendering/style/RenderStyle.cpp:
1677         (WebCore::RenderStyle::diff):
1678         * rendering/style/RenderStyle.h:
1679         (WebCore::InheritedFlags::locale):
1680         (WebCore::InheritedFlags::setLocale):
1681         (WebCore::InheritedFlags::initialLocale):
1682         * rendering/style/StyleRareInheritedData.cpp:
1683         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
1684         (WebCore::StyleRareInheritedData::operator==):
1685         * rendering/style/StyleRareInheritedData.h:
1686
1687 2011-03-03  Kevin Ollivier  <kevino@theolliviers.com>
1688
1689         [wx] Build fixes. Use Font::textMetrics to get ascent value, and add missing include.
1690
1691         * platform/wx/DragDataWx.cpp:
1692         * platform/wx/wxcode/win/non-kerned-drawing.cpp:
1693         (WebCore::drawTextWithSpacing):
1694
1695 2011-03-03  Oliver Hunt  <oliver@apple.com>
1696
1697         Reviewed by Geoffrey Garen.
1698
1699         JSVariableObject needs to use WriteBarrier for symboltable property storage
1700         https://bugs.webkit.org/show_bug.cgi?id=55698
1701
1702         Update to pass JSGlobalData for the symbol table write used
1703         to set the document property.
1704
1705         * bindings/js/JSDOMWindowBase.cpp:
1706         (WebCore::JSDOMWindowBase::updateDocument):
1707
1708 2011-03-03  Alexey Proskuryakov  <ap@apple.com>
1709
1710         More build fixing. Move WebCoreKeyboardUIMode.h to a cross-platform location.
1711
1712         * WebCore.xcodeproj/project.pbxproj:
1713         * page/WebCoreKeyboardUIMode.h: Copied from WebCore/page/mac/WebCoreKeyboardUIMode.h.
1714         * page/mac/WebCoreKeyboardUIMode.h: Removed.
1715
1716 2011-03-03  Alexey Proskuryakov  <ap@apple.com>
1717
1718         Build fix. Should include WebCoreKeyboardUIMode.h on all platforms now.
1719
1720         * page/ChromeClient.h:
1721
1722 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
1723
1724         Reviewed by Darin Adler.
1725
1726         REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
1727         https://bugs.webkit.org/show_bug.cgi?id=55633
1728         <rdar://problem/8963023>
1729
1730         * loader/EmptyClients.h: (WebCore::EmptyChromeClient::keyboardUIMode):
1731         * page/ChromeClient.h:
1732         * page/EventHandler.cpp: (WebCore::EventHandler::tabsToLinks):
1733         Merged tabsToLinks() and keyboardUIMode(). The latter returned a superset of information
1734         returned by former.
1735
1736 2011-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
1737
1738         Fix Win compile break, caused by r80276.
1739
1740         * rendering/RenderThemeWin.h: Changed signature of volumeSliderOffsetFromMuteButton
1741             to match RenderTheme.h.
1742
1743 2011-03-02  Geoffrey Garen  <ggaren@apple.com>
1744
1745         Reviewed by Darin Adler.
1746
1747         Moved all variable object storage inline -- upping the object size limit to 1K
1748         https://bugs.webkit.org/show_bug.cgi?id=55653
1749
1750         * bindings/js/JSDOMGlobalObject.cpp:
1751         * bindings/js/JSDOMGlobalObject.h:
1752         * bindings/js/JSDOMWindowBase.cpp:
1753         * bindings/js/JSDOMWindowBase.h:
1754         * bindings/js/JSDOMWindowCustom.h:
1755         * bindings/js/JSWorkerContextBase.cpp: Removed out-of-line storage. Changed d-> to m_.
1756
1757 2011-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
1758
1759         Reviewed by Darin Adler.
1760
1761         Use RenderBox in volumeSliderOffsetFromMuteButton, since that's what is actually being used.
1762         https://bugs.webkit.org/show_bug.cgi?id=55099
1763
1764         Cleanup, no behavior change.
1765
1766         * html/shadow/MediaControls.cpp:
1767         (WebCore::MediaControls::updateVolumeSliderContainer): Changed to pass RenderBox
1768             instead of Node.
1769         * rendering/RenderMediaControls.cpp:
1770         (WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton): Changed
1771             to use RenderBox as argument.
1772         * rendering/RenderMediaControls.h: Ditto.
1773         * rendering/RenderTheme.cpp:
1774         (WebCore::RenderTheme::volumeSliderOffsetFromMuteButton): Ditto.
1775         * rendering/RenderTheme.h: Ditto.
1776         * rendering/RenderThemeChromiumMac.h: Ditto.
1777         * rendering/RenderThemeChromiumMac.mm:
1778         (WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton): Ditto.
1779         * rendering/RenderThemeMac.h: Ditto.
1780         * rendering/RenderThemeMac.mm:
1781         (WebCore::RenderThemeMac::volumeSliderOffsetFromMuteButton): Ditto.
1782         * rendering/RenderThemeWin.cpp:
1783         (WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton): Ditto.
1784
1785 2011-03-03  Alexis Menard  <alexis.menard@openbossa.org>
1786
1787         Reviewed by Andreas Kling.
1788
1789         When building with DEFINES+=USE_GSTREAMER=1 we don't want to define ENABLE_QT_MULTIMEDIA to 1.
1790         Also add the new files added after https://bugs.webkit.org/show_bug.cgi?id=54870 to support GRefPtr
1791         for GstElement.
1792
1793         * WebCore.pro:
1794         * features.pri:
1795
1796 2011-03-03  Anders Carlsson  <andersca@apple.com>
1797
1798         Try to fix the Windows build again.
1799
1800         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
1801         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
1802
1803 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
1804
1805         Reviewed by Dimitri Glazkov.
1806
1807         Add another CRASH() for CSSSelector double frees
1808         https://bugs.webkit.org/show_bug.cgi?id=55693
1809
1810         To help track down bug 53045, add a CRASH call when the the array and/or
1811         CSSSelector member in CSSSelectorList is disposed of more than once.
1812
1813         Just a check, no new tests necessary.
1814
1815         * css/CSSSelectorList.cpp:
1816         (WebCore::CSSSelectorList::deleteSelectors):
1817
1818 2011-03-03  Anders Carlsson  <andersca@apple.com>
1819
1820         Yet another attempt at fixing the Windows build.
1821
1822         * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
1823         * platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:
1824         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
1825         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
1826
1827 2011-03-02  Chris Marrin  <cmarrin@apple.com>
1828
1829         Reviewed by Simon Fraser.
1830
1831         REGRESSION: Accelerated transitions are jumpy
1832         https://bugs.webkit.org/show_bug.cgi?id=55022
1833
1834         Got rid of default TimingFunction values from PlatformCAAnimation*. A TimingFunction
1835         is now always passed in. The TimingFunction class now has a static method to get
1836         a default object which has the 'ease' values in it. I now assert in both Mac and
1837         Win implementations if a null TimingFunction pointer is seen.
1838
1839         * platform/animation/TimingFunction.h:
1840         (WebCore::CubicBezierTimingFunction::create):
1841         (WebCore::CubicBezierTimingFunction::defaultTimingFunction):
1842         (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction):
1843         * platform/graphics/ca/GraphicsLayerCA.cpp:
1844         (WebCore::GraphicsLayerCA::timingFunctionForAnimationValue):
1845         * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
1846         (toCAMediaTimingFunction):
1847         * platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
1848         (toCACFTimingFunction):
1849
1850 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
1851
1852         Unreviewed build fix.
1853
1854         Fix clang compile after r80220
1855         https://bugs.webkit.org/show_bug.cgi?id=55692
1856
1857         * storage/IDBBackingStore.cpp:
1858         (WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
1859
1860 2011-03-03  Anders Carlsson  <andersca@apple.com>
1861
1862         Attempt to fix the Windows build.
1863
1864         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
1865         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
1866
1867 2011-03-02  Brian Weinstein  <bweinstein@apple.com>
1868
1869         Reviewed by Adam Roben.
1870
1871         Rest of WebKit2: Need a way to send notifications to client when cookies change
1872         https://bugs.webkit.org/show_bug.cgi?id=55427
1873         <rdar://problem/9056027>
1874
1875         Add functions to be exported.
1876
1877         * WebCore.exp.in:
1878
1879 2011-03-03  Anders Carlsson  <andersca@apple.com>
1880
1881         Reviewed by Darin Adler.
1882
1883         Improve WebCore build time by ~5%
1884         https://bugs.webkit.org/show_bug.cgi?id=55688
1885
1886         Forward declare the CATransform3D and CGAffineTransform structs instead of including
1887         large chunks of QuartzCore and Core Graphics.
1888
1889         On an 8 core Mac Pro, this sped up building WebCore by about 5%.
1890
1891         * platform/graphics/ca/GraphicsLayerCA.cpp:
1892         * platform/graphics/ca/TransformationMatrixCA.cpp:
1893         * platform/graphics/transforms/TransformationMatrix.h:
1894
1895 2011-03-03  Andrey Kosyakov  <caseq@chromium.org>
1896
1897         Unreviewed. Adjusted call to a method renamed in r80102.
1898
1899         * inspector/front-end/SourceFrame.js:
1900         (WebInspector.SourceFrame.prototype._startEditing):
1901
1902 2011-03-03  Timothy Hatcher  <timothy@apple.com>
1903
1904         Use APIEntryShim instead of JSLock in SerializedScriptValue to allow it to be used
1905         by contexts not created by WebCore.
1906
1907         https://webkit.org/b/55642
1908
1909         Reviewed by Oliver Hunt.
1910
1911         * bindings/js/SerializedScriptValue.cpp:
1912         (WebCore::SerializedScriptValue::create): Use APIEntryShim instead of JSLock.
1913         (WebCore::SerializedScriptValue::deserialize): Ditto.
1914
1915 2011-03-03  Alexey Proskuryakov  <ap@apple.com>
1916
1917         Reviewed by Darin Adler.
1918
1919         WebCore should check for "Upgrade" and "Connection" header fields in WebSockets handshake
1920         https://bugs.webkit.org/show_bug.cgi?id=55498
1921         <rdar://problem/8752706>
1922
1923         Tests: http/tests/websocket/tests/handshake-fail-by-no-connection-header.html
1924                http/tests/websocket/tests/handshake-fail-by-no-upgrade-header.html
1925
1926         * websockets/WebSocketHandshake.h: Removed unused and meaningless setters for response
1927         header fields. Removed separate member variables for those, as they were duplicating data
1928         available in response, and there is no reason to squeeze microsecods here.
1929
1930         * websockets/WebSocketHandshake.cpp:
1931         (WebCore::WebSocketHandshake::reset): There are no longer member variables for header field
1932         values to reset here.
1933         (WebCore::WebSocketHandshake::readServerHandshake): Removed a call for processHeaders().
1934         (WebCore::WebSocketHandshake::serverWebSocketOrigin): Changed to get the value from response.
1935         (WebCore::WebSocketHandshake::serverWebSocketLocation): Ditto.
1936         (WebCore::WebSocketHandshake::serverWebSocketProtocol): Ditto.
1937         (WebCore::WebSocketHandshake::serverSetCookie): Ditto.
1938         (WebCore::WebSocketHandshake::serverSetCookie2): Ditto.
1939         (WebCore::WebSocketHandshake::serverUpgrade): Added.
1940         (WebCore::WebSocketHandshake::serverConnection): Added.
1941         (WebCore::WebSocketHandshake::checkResponseHeaders): Added checks for Upgrade and Connection
1942         header field presence and values.
1943
1944 2011-03-03  Helder Correia  <helder@sencha.com>
1945
1946         Reviewed by Andreas Kling.
1947
1948         [Qt] fast/canvas/canvas-strokePath-gradient-shadow.html fails
1949         https://bugs.webkit.org/show_bug.cgi?id=55651
1950
1951         When relying on ContextShadow and using a gradient stroke for a path,
1952         the alpha of the shadow is incorrect.
1953
1954         * platform/graphics/qt/GraphicsContextQt.cpp:
1955         (WebCore::GraphicsContext::strokePath):
1956
1957 2011-03-03  Martin Robinson  <mrobinson@igalia.com>
1958
1959         XHTMLMP build broken after r78342
1960         https://bugs.webkit.org/show_bug.cgi?id=55286
1961
1962         Fix XHTMLMP build now that the DocumentWriter is a member of DocumentLoader
1963         instead of FrameLoader.
1964
1965         No new tests. This is a build fix.
1966
1967         * dom/Document.cpp:
1968         (WebCore::Document::isXHTMLMPDocument):
1969
1970 2011-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
1971
1972         Reviewed by Eric Carlson.
1973
1974         Tweak MediaControlMuteButtonElement class hierarchy.
1975         https://bugs.webkit.org/show_bug.cgi?id=55614
1976
1977         This allows the mute button on the panel to have event handlers that are
1978         different from the mute button in the volume slider.
1979
1980         No change in behavior, covered by existing tests.
1981
1982         * html/shadow/MediaControls.cpp:
1983         (WebCore::MediaControls::createMuteButton): Changed to use MediaControlPanelMuteButtonElement.
1984         * rendering/MediaControlElements.cpp:
1985         (WebCore::MediaControlMuteButtonElement::updateDisplayType):
1986         (WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement): Added.
1987         (WebCore::MediaControlPanelMuteButtonElement::create): Added.
1988         (WebCore::MediaControlPanelMuteButtonElement::shadowPseudoId): Moved.
1989         * rendering/MediaControlElements.h: Added defs.
1990
1991 2011-03-03  Yury Semikhatsky  <yurys@chromium.org>
1992
1993         Reviewed by Pavel Feldman.
1994
1995         Web Inspector: Resource agent should have same lifetime as Inspector agent
1996         https://bugs.webkit.org/show_bug.cgi?id=55461
1997
1998         * inspector/Inspector.idl:
1999         * inspector/InspectorAgent.cpp:
2000         (WebCore::InspectorAgent::InspectorAgent):
2001         (WebCore::InspectorAgent::inspectedPageDestroyed): disconnectFrontend is called before the agent is destroyed
2002         to clear frontend reference in all agents.
2003         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
2004         (WebCore::InspectorAgent::setFrontend):
2005         (WebCore::InspectorAgent::disconnectFrontend):
2006         (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
2007         (WebCore::InspectorAgent::didCommitLoad):
2008         * inspector/InspectorAgent.h:
2009         (WebCore::InspectorAgent::resourceAgent):
2010         * inspector/InspectorBrowserDebuggerAgent.cpp:
2011         (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
2012         * inspector/InspectorDebuggerAgent.cpp:
2013         (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
2014         * inspector/InspectorInstrumentation.cpp:
2015         (WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
2016         (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl):
2017         (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl):
2018         (WebCore::InspectorInstrumentation::didCloseWebSocketImpl):
2019         (WebCore::InspectorInstrumentation::retrieveResourceAgent):
2020         * inspector/InspectorResourceAgent.cpp:
2021         (WebCore::InspectorResourceAgent::setFrontend):
2022         (WebCore::InspectorResourceAgent::clearFrontend):
2023         (WebCore::InspectorResourceAgent::restore):
2024         (WebCore::InspectorResourceAgent::~InspectorResourceAgent):
2025         (WebCore::InspectorResourceAgent::enable):
2026         (WebCore::InspectorResourceAgent::disable):
2027         (WebCore::InspectorResourceAgent::InspectorResourceAgent):
2028         * inspector/InspectorResourceAgent.h:
2029         (WebCore::InspectorResourceAgent::create):
2030         * inspector/InspectorTimelineAgent.cpp:
2031         (WebCore::InspectorTimelineAgent::restore):
2032         * inspector/InspectorTimelineAgent.h:
2033         * inspector/front-end/NetworkManager.js:
2034         (WebInspector.NetworkManager):
2035         (WebInspector.NetworkManager.prototype.frontendReused):
2036         * inspector/front-end/inspector.js:
2037         (WebInspector.frontendReused):
2038
2039 2011-03-03  Andras Becsi  <abecsi@webkit.org>
2040
2041         Reviewed by Andreas Kling.
2042
2043         CSS RGBA fast-path color parsing should clamp of out-of-range alpha values
2044         https://bugs.webkit.org/show_bug.cgi?id=55661
2045
2046         Test case originally written by Andreas Kling <andreas.kling@nokia.com>
2047
2048         Test: fast/canvas/rgba-parsing.html
2049
2050         * css/CSSParser.cpp:
2051         (WebCore::isValidDouble): Check whether the given string is a valid double.
2052         (WebCore::parseAlphaValue): Out-of-range alpha values should be clamped to the (0.0, 1.0) range.
2053
2054 2011-03-03  David Holloway  <dhollowa@chromium.org>
2055
2056         Reviewed by Dimitri Glazkov.
2057
2058         Changes HTMLTextFormControlElement::placeholderShouldBeVisible to account
2059         for non-empty suggestion text.  The visibility of the placeholder text
2060         now turned off when suggestion text is set.
2061         https://bugs.webkit.org/show_bug.cgi?id=55245
2062
2063         No new tests because, by design, the suggestion text is not accessible
2064         through the DOM.
2065
2066         * html/HTMLFormControlElement.cpp:
2067         (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
2068         * html/HTMLFormControlElement.h:
2069         (WebCore::HTMLTextFormControlElement::isEmptySuggestedValue):
2070         * html/HTMLInputElement.h:
2071         (WebCore::HTMLInputElement::isEmptySuggestedValue):
2072
2073 2011-03-03  Andy Estes  <aestes@apple.com>
2074
2075         Reviewed by Eric Seidel.
2076
2077         HTML5 TreeBuilder regressed a Peacekeeper DOM test by 25% (was 40%)
2078         https://bugs.webkit.org/show_bug.cgi?id=48719
2079
2080         Instead of pushing a fake HTMLHtmlElement onto the open element stack
2081         during fragment parsing only to later remove it and reparent its
2082         children to the DocumentFragment, push the DocumentFragment directly
2083         onto the open element stack as the root node. This requires refactoring
2084         HTMLElementStack to hold ContainerNode pointers rather than Element
2085         pointers, which has implications for HTMLConstructionSite and
2086         HTMLTreeBuilder as well.
2087
2088         With this patch, the regression in Peacekeeper from Safari 5.0.3 to ToT
2089         is ~14%. However, if you discount the 'domDynamicCreationCreateElement'
2090         test, ToT is now ~4% faster than Safari 5.0.3. This indicates that the
2091         regression no longer lies in fragment parsing.
2092
2093         No new tests. No change in behavior.
2094
2095         * dom/Element.h:
2096         (WebCore::Node::hasLocalName):
2097         * dom/Node.h:
2098         * html/parser/HTMLConstructionSite.cpp:
2099         (WebCore::HTMLNames::hasImpliedEndTag):
2100         (WebCore::HTMLConstructionSite::HTMLConstructionSite):
2101         (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
2102         (WebCore::HTMLConstructionSite::insertComment):
2103         (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
2104         (WebCore::HTMLConstructionSite::attachToCurrent):
2105         (WebCore::HTMLConstructionSite::insertScriptElement):
2106         (WebCore::HTMLConstructionSite::insertTextNode):
2107         (WebCore::HTMLConstructionSite::createElement):
2108         (WebCore::HTMLConstructionSite::createHTMLElement):
2109         (WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
2110         (WebCore::HTMLConstructionSite::generateImpliedEndTags):
2111         (WebCore::HTMLConstructionSite::findFosterSite):
2112         (WebCore::HTMLConstructionSite::shouldFosterParent):
2113         * html/parser/HTMLConstructionSite.h:
2114         (WebCore::HTMLConstructionSite::currentNode):
2115         * html/parser/HTMLElementStack.cpp:
2116         (WebCore::HTMLNames::isNumberedHeaderElement):
2117         (WebCore::HTMLNames::isScopeMarker):
2118         (WebCore::HTMLNames::isListItemScopeMarker):
2119         (WebCore::HTMLNames::isTableScopeMarker):
2120         (WebCore::HTMLNames::isTableBodyScopeMarker):
2121         (WebCore::HTMLNames::isTableRowScopeMarker):
2122         (WebCore::HTMLNames::isButtonScopeMarker):
2123         (WebCore::HTMLNames::isSelectScopeMarker):
2124         (WebCore::HTMLElementStack::ElementRecord::ElementRecord):
2125         (WebCore::HTMLElementStack::ElementRecord::replaceElement):
2126         (WebCore::HTMLElementStack::HTMLElementStack):
2127         (WebCore::HTMLElementStack::secondElementIsHTMLBodyElement):
2128         (WebCore::HTMLElementStack::popAll):
2129         (WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped):
2130         (WebCore::HTMLElementStack::popUntil):
2131         (WebCore::HTMLElementStack::popUntilPopped):
2132         (WebCore::HTMLElementStack::popUntilTableScopeMarker):
2133         (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
2134         (WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
2135         (WebCore::HTMLElementStack::pushHTMLHtmlElement):
2136         (WebCore::HTMLElementStack::push):
2137         (WebCore::HTMLElementStack::insertAbove):
2138         (WebCore::HTMLElementStack::find):
2139         (WebCore::HTMLElementStack::topmost):
2140         (WebCore::HTMLElementStack::contains):
2141         (WebCore::inScopeCommon):
2142         (WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
2143         (WebCore::HTMLElementStack::htmlElement):
2144         (WebCore::HTMLElementStack::rootNode):
2145         (WebCore::HTMLElementStack::pushCommon):
2146         * html/parser/HTMLElementStack.h:
2147         (WebCore::HTMLElementStack::ElementRecord::element):
2148         (WebCore::HTMLElementStack::ElementRecord::node):
2149         (WebCore::HTMLElementStack::topNode):
2150         * html/parser/HTMLTreeBuilder.cpp:
2151         (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
2152         (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
2153         (WebCore::HTMLTreeBuilder::processStartTagForInBody):
2154         (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
2155         (WebCore::HTMLTreeBuilder::processStartTag):
2156         (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
2157         (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
2158         (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
2159         (WebCore::HTMLTreeBuilder::processEndTagForInCell):
2160         (WebCore::HTMLTreeBuilder::processEndTagForInBody):
2161         (WebCore::HTMLTreeBuilder::processEndTag):
2162         (WebCore::HTMLTreeBuilder::processEndOfFile):
2163         (WebCore::HTMLTreeBuilder::finished):
2164         * html/parser/HTMLTreeBuilder.h:
2165
2166 2011-03-02  Yury Semikhatsky  <yurys@chromium.org>
2167
2168         Reviewed by Pavel Feldman.
2169
2170         Web Inspector: inspector protocol should allow different domains to have methods with same name
2171         https://bugs.webkit.org/show_bug.cgi?id=55558
2172
2173         * inspector/CodeGeneratorInspector.pm: each command is now identified by domain + command-name(was command-name only).
2174
2175 2011-03-02  Pavel Podivilov  <podivilov@chromium.org>
2176
2177         Reviewed by Yury Semikhatsky.
2178
2179         Web Inspector: make selected call frame debugger presentation model property.
2180         https://bugs.webkit.org/show_bug.cgi?id=55582
2181
2182         * inspector/front-end/CallStackSidebarPane.js:
2183         (WebInspector.CallStackSidebarPane):
2184         (WebInspector.CallStackSidebarPane.prototype.update):
2185         (WebInspector.CallStackSidebarPane.prototype.set selectedCallFrame):
2186         (WebInspector.CallStackSidebarPane.prototype._selectedCallFrameIndex):
2187         * inspector/front-end/ConsoleView.js:
2188         (WebInspector.ConsoleView.prototype.completions):
2189         * inspector/front-end/DebuggerPresentationModel.js:
2190         (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
2191         (WebInspector.DebuggerPresentationModel.prototype.get selectedCallFrame):
2192         * inspector/front-end/ScriptsPanel.js:
2193         (WebInspector.ScriptsPanel):
2194         (WebInspector.ScriptsPanel.prototype.getCompletionsOnCallFrame):
2195         (WebInspector.ScriptsPanel.prototype._debuggerResumed):
2196         (WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
2197         (WebInspector.ScriptsPanel.prototype._callFrameSelected):
2198
2199 2011-03-03  Jia Pu  <jpu@apple.com>
2200
2201         Reviewed by Darin Adler.
2202
2203         On Mac OS X, spelling suggestion panel stops showing up after change set 80121
2204         https://bugs.webkit.org/show_bug.cgi?id=55628
2205
2206         Removed a call to stopCorrectionPanelTimer() to fix a regression introduced by changeset 80121.
2207
2208         * editing/Editor.cpp:
2209         (WebCore::Editor::appliedEditing):
2210         * manual-tests/autocorrection/autocorrection-contraction.html:
2211
2212 2011-03-03  Pavel Podivilov  <podivilov@chromium.org>
2213
2214         Reviewed by Pavel Feldman.
2215
2216         Web Inspector: rename "sourceName" to "sourceFileId" in ScriptsPanel.js.
2217         https://bugs.webkit.org/show_bug.cgi?id=55569
2218
2219         sourceFileId better reflects the intention to have unique identifier for each source that is shown in scripts panel.
2220
2221         * inspector/front-end/DebuggerPresentationModel.js:
2222         * inspector/front-end/ScriptsPanel.js:
2223
2224 2011-03-03  Steve Block  <steveblock@google.com>
2225
2226         Reviewed by David Levin.
2227
2228         JavaString API should be implementable by both JSC and V8
2229         https://bugs.webkit.org/show_bug.cgi?id=55567
2230
2231         Remove JavaString's UString operator and replace it with a
2232         script-engine-independent impl() method, which returns a
2233         StringImpl and can be implemented with both JSC and V8.
2234
2235         No new tests, refactoring only.
2236
2237         * bridge/jni/JNIBridge.h:
2238         (JSC::Bindings::JavaString::impl):
2239         * bridge/jni/jni_jsobject.mm:
2240         (JavaJSObject::call):
2241         (JavaJSObject::eval):
2242         (JavaJSObject::getMember):
2243         (JavaJSObject::setMember):
2244         (JavaJSObject::removeMember):
2245         * bridge/jni/jsc/JNIBridgeJSC.cpp:
2246         (JavaField::valueFromInstance):
2247         (JavaField::setValueToInstance):
2248         * bridge/jni/jsc/JavaClassJSC.cpp:
2249         (JavaClass::JavaClass):
2250         * bridge/jni/jsc/JavaInstanceJSC.cpp:
2251         (JavaInstance::invokeMethod):
2252         * bridge/jni/jsc/JavaStringJSC.h:
2253         (JSC::Bindings::JavaStringImpl::impl):
2254         * bridge/jni/v8/JavaStringV8.h:
2255         (JSC::Bindings::JavaStringImpl::impl):
2256
2257 2011-03-03  Benjamin Poulain  <ikipou@gmail.com>
2258
2259         Reviewed by Adam Roben.
2260
2261         REGRESSION (r79817): Lots of leaks of FloatingObjects seen on SnowLeopard Intel Leaks bot
2262         https://bugs.webkit.org/show_bug.cgi?id=55602
2263
2264         Delete the FloatingObject referenced by m_floatingObjects when clearing the floats.
2265
2266         The DeprecatedPtrList was deleting the objects automatically due to its autoDelete behavior. The
2267         objects need to be deleted manually with ListHashSet.
2268
2269         * rendering/RenderBlock.cpp:
2270         (WebCore::RenderBlock::clearFloats):
2271
2272 2011-03-03  Hans Wennborg  <hans@chromium.org>
2273
2274         Reviewed by Jeremy Orlow.
2275
2276         IndexedDB: Move SQL code, especially for cursors, to IDBBackingStore
2277         https://bugs.webkit.org/show_bug.cgi?id=55376
2278
2279         Move SQL code from IDBKey, IDBKeyRange, IDBIndexBackendImpl,
2280         IDBObjectStoreBackendImpl, and especially IDBCursorBackendImpl.
2281
2282         No new functionality, so no new tests.
2283
2284         * storage/IDBBackingStore.cpp:
2285         (WebCore::lowerCursorWhereFragment):
2286         (WebCore::upperCursorWhereFragment):
2287         (WebCore::IDBBackingStore::deleteObjectStoreRecord):
2288         (WebCore::IDBBackingStore::keyExistsInObjectStore):
2289         (WebCore::IDBBackingStore::getObjectViaIndex):
2290         (WebCore::keyFromQuery):
2291         (WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
2292         (WebCore::IDBBackingStore::keyExistsInIndex):
2293         (WebCore::CursorImplCommon::CursorImplCommon::continueInternal):
2294         (WebCore::CursorImplCommon::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
2295         (WebCore::CursorImplCommon::ObjectStoreCursorImpl::objectStoreDataId):
2296         (WebCore::CursorImplCommon::ObjectStoreCursorImpl::key):
2297         (WebCore::CursorImplCommon::ObjectStoreCursorImpl::value):
2298         (WebCore::CursorImplCommon::ObjectStoreCursorImpl::continueFunction):
2299         (WebCore::IDBBackingStore::openObjectStoreCursor):
2300         (WebCore::ObjectStoreCursorImpl::loadCurrentRow):
2301         (WebCore::ObjectStoreCursorImpl::currentRowExists):
2302         (WebCore::IndexKeyCursorImpl::IndexKeyCursorImpl):
2303         (WebCore::IndexKeyCursorImpl::indexDataId):
2304         (WebCore::IndexKeyCursorImpl::key):
2305         (WebCore::IndexKeyCursorImpl::primaryKey):
2306         (WebCore::IndexKeyCursorImpl::continueFunction):
2307         (WebCore::IDBBackingStore::openIndexKeyCursor):
2308         (WebCore::IndexKeyCursorImpl::loadCurrentRow):
2309         (WebCore::IndexKeyCursorImpl::currentRowExists):
2310         (WebCore::IndexCursorImpl::IndexCursorImpl):
2311         (WebCore::IndexCursorImpl::indexDataId):
2312         (WebCore::IndexCursorImpl::key):
2313         (WebCore::IndexCursorImpl::primaryKey):
2314         (WebCore::IndexCursorImpl::value):
2315         (WebCore::IndexCursorImpl::continueFunction):
2316         (WebCore::IDBBackingStore::openIndexCursor):
2317         (WebCore::IndexCursorImpl::loadCurrentRow):
2318         (WebCore::IndexCursorImpl::currentRowExists):
2319         * storage/IDBBackingStore.h:
2320         (WebCore::IDBBackingStore::Cursor::~Cursor):
2321         * storage/IDBCursorBackendImpl.cpp:
2322         (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
2323         (WebCore::IDBCursorBackendImpl::key):
2324         (WebCore::IDBCursorBackendImpl::value):
2325         (WebCore::IDBCursorBackendImpl::update):
2326         (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
2327         (WebCore::IDBCursorBackendImpl::deleteFunction):
2328         * storage/IDBCursorBackendImpl.h:
2329         (WebCore::IDBCursorBackendImpl::create):
2330         * storage/IDBIndexBackendImpl.cpp:
2331         (WebCore::IDBIndexBackendImpl::openCursorInternal):
2332         (WebCore::IDBIndexBackendImpl::getInternal):
2333         (WebCore::IDBIndexBackendImpl::addingKeyAllowed):
2334         * storage/IDBIndexBackendImpl.h:
2335         * storage/IDBKey.cpp:
2336         (WebCore::IDBKey::isEqual):
2337         * storage/IDBKey.h:
2338         * storage/IDBKeyRange.cpp:
2339         * storage/IDBKeyRange.h:
2340         * storage/IDBObjectStoreBackendImpl.cpp:
2341         (WebCore::IDBObjectStoreBackendImpl::putInternal):
2342         (WebCore::IDBObjectStoreBackendImpl::deleteInternal):
2343         (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
2344         * storage/IDBObjectStoreBackendImpl.h:
2345
2346 2011-03-03  Peter Kasting  <pkasting@google.com>
2347
2348         Reviewed by James Robinson.
2349
2350         Drop redundant "Windows; " from the Windows-specific User Agent string.
2351         https://bugs.webkit.org/show_bug.cgi?id=54567
2352
2353         * StringsNotToBeLocalized.txt:
2354
2355 2011-03-03  Mario Sanchez Prada  <msanchez@igalia.com>
2356
2357         Reviewed by Martin Robinson.
2358
2359         [GTK] Combo boxes should emit object:selection-changed even when collapsed
2360         https://bugs.webkit.org/show_bug.cgi?id=53146
2361
2362         Emit the selection-changed signals when the menu list value has changed
2363
2364         Test: platform/gtk/accessibility/combo-box-collapsed-selection-changed.html
2365
2366         * accessibility/gtk/AXObjectCacheAtk.cpp:
2367         (WebCore::getListObject): New, return the right list object for
2368         menu lists and list boxes.
2369         (WebCore::notifyChildrenSelectionChange): Support menu lists.
2370         (WebCore::AXObjectCache::postPlatformNotification): Call function
2371         notifyChildrenSelectionChange for AXMenuListValueChanged.
2372
2373 2011-03-03  Ryosuke Niwa  <rniwa@webkit.org>
2374
2375         Reviewed by Tony Chang.
2376
2377         applyInlineStyleToPushDown and removeInlineStyleFromElement should take EditingStyle
2378         https://bugs.webkit.org/show_bug.cgi?id=55338
2379
2380         Include wtf/Forward.h instead of wtf/text/String.h
2381
2382         * editing/EditingStyle.h:
2383
2384 2011-03-03  Csaba Osztrogonác  <ossy@webkit.org>
2385
2386         Unreviewed trivial fix after r80169.
2387
2388         [Qt][WK2] Memory exhausted when building qtwebkit2 on linux
2389         https://bugs.webkit.org/show_bug.cgi?id=55484
2390
2391         * WebCore.pro: Typo fix. We have to use linux-g++* instead of linux-g++.
2392
2393
2394 2011-03-02  MORITA Hajime  <morrita@google.com>
2395
2396         Reviewed by Kent Tamura.
2397
2398         [Refactoring] Make ScheduledEvent on FrameView abstract out to ScheduleAction
2399         https://bugs.webkit.org/show_bug.cgi?id=54440
2400
2401         - Extracted FrameActionScheduler from FrameView
2402         - Extracted FrameAction abstract class from ScheduledEvent,
2403           which has fire() virtual method.
2404         - Renamed ScheduledEvent EventFrameAction
2405
2406         With this change, Any action can be hooked up to the end of the layout.
2407
2408         No new tests. No behavioral change.
2409
2410         * Android.mk:
2411         * CMakeLists.txt:
2412         * GNUmakefile.am:
2413         * WebCore.gypi:
2414         * WebCore.pro:
2415         * WebCore.vcproj/WebCore.vcproj:
2416         * WebCore.xcodeproj/project.pbxproj:
2417         * page/FrameActionScheduler.cpp: Added.
2418         (WebCore::EventFrameAction::EventFrameAction):
2419         (WebCore::EventFrameAction::fire):
2420         (WebCore::FrameActionScheduler::FrameActionScheduler):
2421         (WebCore::FrameActionScheduler::~FrameActionScheduler):
2422         (WebCore::FrameActionScheduler::isEmpty):
2423         (WebCore::FrameActionScheduler::clear):
2424         (WebCore::FrameActionScheduler::pause):
2425         (WebCore::FrameActionScheduler::resume):
2426         (WebCore::FrameActionScheduler::dispatch):
2427         (WebCore::FrameActionScheduler::scheduleAction):
2428         (WebCore::FrameActionScheduler::scheduleEvent):
2429         * page/FrameActionScheduler.h: Added.
2430         (WebCore::FrameAction::FrameAction):
2431         (WebCore::FrameAction::~FrameAction):
2432         (WebCore::FrameActionScheduler::isScheduled):
2433         * page/FrameView.cpp:
2434         (WebCore::FrameView::FrameView):
2435         (WebCore::FrameView::~FrameView):
2436         (WebCore::FrameView::layout):
2437         (WebCore::FrameView::scheduleEvent):
2438         (WebCore::FrameView::pauseScheduledEvents):
2439         (WebCore::FrameView::resumeScheduledEvents):
2440         (WebCore::FrameView::performPostLayoutTasks):
2441         (WebCore::FrameView::updateOverflowStatus):
2442         * page/FrameView.h:
2443
2444 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2445
2446         Unreviewed, rolling out r80201.
2447         http://trac.webkit.org/changeset/80201
2448         https://bugs.webkit.org/show_bug.cgi?id=55648
2449
2450         "caused tests to crash on several bots" (Requested by rniwa on
2451         #webkit).
2452
2453         * dom/Element.h:
2454         (WebCore::Node::hasTagName):
2455         * dom/Node.h:
2456         * html/parser/HTMLConstructionSite.cpp:
2457         (WebCore::HTMLNames::hasImpliedEndTag):
2458         (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
2459         (WebCore::HTMLConstructionSite::insertComment):
2460         (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
2461         (WebCore::HTMLConstructionSite::attachToCurrent):
2462         (WebCore::HTMLConstructionSite::insertScriptElement):
2463         (WebCore::HTMLConstructionSite::insertTextNode):
2464         (WebCore::HTMLConstructionSite::createElement):
2465         (WebCore::HTMLConstructionSite::createHTMLElement):
2466         (WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
2467         (WebCore::HTMLConstructionSite::generateImpliedEndTags):
2468         (WebCore::HTMLConstructionSite::findFosterSite):
2469         (WebCore::HTMLConstructionSite::shouldFosterParent):
2470         * html/parser/HTMLConstructionSite.h:
2471         * html/parser/HTMLElementStack.cpp:
2472         (WebCore::HTMLNames::isNumberedHeaderElement):
2473         (WebCore::HTMLNames::isScopeMarker):
2474         (WebCore::HTMLNames::isListItemScopeMarker):
2475         (WebCore::HTMLNames::isTableScopeMarker):
2476         (WebCore::HTMLNames::isTableBodyScopeMarker):
2477         (WebCore::HTMLNames::isTableRowScopeMarker):
2478         (WebCore::HTMLNames::isButtonScopeMarker):
2479         (WebCore::HTMLNames::isSelectScopeMarker):
2480         (WebCore::HTMLElementStack::ElementRecord::ElementRecord):
2481         (WebCore::HTMLElementStack::ElementRecord::replaceElement):
2482         (WebCore::HTMLElementStack::HTMLElementStack):
2483         (WebCore::HTMLElementStack::secondElementIsHTMLBodyElement):
2484         (WebCore::HTMLElementStack::popAll):
2485         (WebCore::HTMLElementStack::popUntilTableScopeMarker):
2486         (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
2487         (WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
2488         (WebCore::HTMLElementStack::popUntilForeignContentScopeMarker):
2489         (WebCore::HTMLElementStack::pushHTMLHtmlElement):
2490         (WebCore::HTMLElementStack::push):
2491         (WebCore::HTMLElementStack::insertAbove):
2492         (WebCore::HTMLElementStack::find):
2493         (WebCore::HTMLElementStack::topmost):
2494         (WebCore::inScopeCommon):
2495         (WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
2496         (WebCore::HTMLElementStack::htmlElement):
2497         (WebCore::HTMLElementStack::bodyElement):
2498         (WebCore::HTMLElementStack::pushCommon):
2499         * html/parser/HTMLElementStack.h:
2500         (WebCore::HTMLElementStack::ElementRecord::element):
2501         (WebCore::HTMLElementStack::top):
2502         * html/parser/HTMLTreeBuilder.cpp:
2503         (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
2504         (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
2505         (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
2506         (WebCore::HTMLTreeBuilder::processStartTagForInBody):
2507         (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
2508         (WebCore::HTMLTreeBuilder::processStartTag):
2509         (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
2510         (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
2511         (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
2512         (WebCore::HTMLTreeBuilder::processEndTagForInCell):
2513         (WebCore::HTMLTreeBuilder::processEndTagForInBody):
2514         (WebCore::HTMLTreeBuilder::processEndTag):
2515         (WebCore::HTMLTreeBuilder::processEndOfFile):
2516         (WebCore::HTMLTreeBuilder::finished):
2517         * html/parser/HTMLTreeBuilder.h:
2518
2519 2011-03-02  Yury Semikhatsky  <yurys@chromium.org>
2520
2521         Reviewed by Pavel Feldman.
2522
2523         Web Inspector: break down InspectorFrontend into domain-specific classes
2524         https://bugs.webkit.org/show_bug.cgi?id=55584
2525
2526         * inspector/CodeGeneratorInspector.pm: InspectorFrontend now contains nested classes for
2527         all domains that have event notifications.
2528         * inspector/ConsoleMessage.cpp:
2529         (WebCore::ConsoleMessage::addToFrontend):
2530         (WebCore::ConsoleMessage::updateRepeatCountInConsole):
2531         * inspector/ConsoleMessage.h:
2532         * inspector/InjectedScriptHost.cpp:
2533         (WebCore::InjectedScriptHost::inspectImpl):
2534         * inspector/Inspector.idl:
2535         * inspector/InspectorAgent.cpp:
2536         (WebCore::InspectorAgent::inspectedPageDestroyed):
2537         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
2538         (WebCore::InspectorAgent::setFrontend):
2539         (WebCore::InspectorAgent::disconnectFrontend):
2540         (WebCore::InspectorAgent::populateScriptObjects):
2541         (WebCore::InspectorAgent::pushDataCollectedOffline):
2542         (WebCore::InspectorAgent::didCommitLoad):
2543         (WebCore::InspectorAgent::domContentLoadedEventFired):
2544         (WebCore::InspectorAgent::loadEventFired):
2545         (WebCore::InspectorAgent::postWorkerNotificationToFrontend):
2546         (WebCore::InspectorAgent::evaluateForTestInFrontend):
2547         (WebCore::InspectorAgent::showPanel):
2548         * inspector/InspectorApplicationCacheAgent.cpp:
2549         (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
2550         * inspector/InspectorApplicationCacheAgent.h:
2551         * inspector/InspectorConsoleAgent.cpp:
2552         (WebCore::InspectorConsoleAgent::setFrontend):
2553         * inspector/InspectorConsoleAgent.h:
2554         * inspector/InspectorController.cpp:
2555         (WebCore::InspectorController::show):
2556         (WebCore::InspectorController::close):
2557         * inspector/InspectorDOMAgent.cpp:
2558         (WebCore::InspectorDOMAgent::setFrontend):
2559         * inspector/InspectorDOMAgent.h:
2560         * inspector/InspectorDOMStorageResource.cpp:
2561         (WebCore::InspectorDOMStorageResource::bind):
2562         * inspector/InspectorDOMStorageResource.h:
2563         * inspector/InspectorDatabaseAgent.cpp:
2564         (WebCore::InspectorDatabaseAgent::FrontendProvider::frontend):
2565         (WebCore::InspectorDatabaseAgent::FrontendProvider::FrontendProvider):
2566         (WebCore::InspectorDatabaseAgent::setFrontend):
2567         * inspector/InspectorDatabaseResource.cpp:
2568         (WebCore::InspectorDatabaseResource::bind):
2569         * inspector/InspectorDatabaseResource.h:
2570         * inspector/InspectorDebuggerAgent.cpp:
2571         (WebCore::InspectorDebuggerAgent::setFrontend):
2572         * inspector/InspectorDebuggerAgent.h:
2573         * inspector/InspectorProfilerAgent.cpp:
2574         * inspector/InspectorProfilerAgent.h:
2575         (WebCore::InspectorProfilerAgent::setFrontend):
2576         (WebCore::InspectorProfilerAgent::clearFrontend):
2577         * inspector/InspectorResourceAgent.cpp:
2578         (WebCore::InspectorResourceAgent::InspectorResourceAgent):
2579         * inspector/InspectorResourceAgent.h:
2580         * inspector/InspectorTimelineAgent.cpp:
2581         (WebCore::InspectorTimelineAgent::setFrontend):
2582         * inspector/InspectorTimelineAgent.h:
2583         * inspector/front-end/DOMAgent.js:
2584         (WebInspector.DOMDispatcher.prototype.inspectElementRequested):
2585         (WebInspector.DOMDispatcher.prototype.addNodesToSearchResult):
2586         * inspector/front-end/inspector.js:
2587
2588 2011-03-02  Kent Tamura  <tkent@chromium.org>
2589
2590         Unreviewed, a trivial regression fix.
2591
2592         Fix LocalizedNumberICU regression by r80198 and r80199.
2593         https://bugs.webkit.org/show_bug.cgi?id=55629
2594
2595         * platform/text/LocalizedNumberICU.cpp:
2596           We should use U_SUCCESS().
2597         (WebCore::createFormatterForCurrentLocale):
2598         (WebCore::parseLocalizedNumber):
2599
2600 2011-03-02  Dan Bernstein  <mitz@apple.com>
2601
2602         Let Xcode know that Localizable.strings is UTF-16-encoded.
2603
2604         * WebCore.xcodeproj/project.pbxproj:
2605
2606 2011-03-02  Andy Estes  <aestes@apple.com>
2607
2608         Reviewed by Eric Seidel.
2609
2610         HTML5 TreeBuilder regressed a Peacekeeper DOM test by 25% (was 40%)
2611         https://bugs.webkit.org/show_bug.cgi?id=48719
2612
2613         Instead of pushing a fake HTMLHtmlElement onto the open element stack
2614         during fragment parsing only to later remove it and reparent its
2615         children to the DocumentFragment, push the DocumentFragment directly
2616         onto the open element stack as the root node. This requires refactoring
2617         HTMLElementStack to hold ContainerNode pointers rather than Element
2618         pointers, which has implications for HTMLConstructionSite and
2619         HTMLTreeBuilder as well.
2620
2621         With this patch, the regression in Peacekeeper due to the introduction
2622         of the HTML5 fragment parsing algorithm is ~14%. The regression from
2623         Safari 5.0.3 is ~24%.
2624
2625         No new tests. No change in behavior.
2626
2627         * dom/Element.h:
2628         (WebCore::Node::hasLocalName):
2629         * dom/Node.h:
2630         * html/parser/HTMLConstructionSite.cpp:
2631         (WebCore::HTMLNames::hasImpliedEndTag):
2632         (WebCore::HTMLConstructionSite::HTMLConstructionSite):
2633         (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
2634         (WebCore::HTMLConstructionSite::insertComment):
2635         (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
2636         (WebCore::HTMLConstructionSite::attachToCurrent):
2637         (WebCore::HTMLConstructionSite::insertScriptElement):
2638         (WebCore::HTMLConstructionSite::insertTextNode):
2639         (WebCore::HTMLConstructionSite::createElement):
2640         (WebCore::HTMLConstructionSite::createHTMLElement):
2641         (WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
2642         (WebCore::HTMLConstructionSite::generateImpliedEndTags):
2643         (WebCore::HTMLConstructionSite::findFosterSite):
2644         (WebCore::HTMLConstructionSite::shouldFosterParent):
2645         * html/parser/HTMLConstructionSite.h:
2646         (WebCore::HTMLConstructionSite::currentNode):
2647         * html/parser/HTMLElementStack.cpp:
2648         (WebCore::HTMLNames::isNumberedHeaderElement):
2649         (WebCore::HTMLNames::isScopeMarker):
2650         (WebCore::HTMLNames::isListItemScopeMarker):
2651         (WebCore::HTMLNames::isTableScopeMarker):
2652         (WebCore::HTMLNames::isTableBodyScopeMarker):
2653         (WebCore::HTMLNames::isTableRowScopeMarker):
2654         (WebCore::HTMLNames::isButtonScopeMarker):
2655         (WebCore::HTMLNames::isSelectScopeMarker):
2656         (WebCore::HTMLElementStack::ElementRecord::ElementRecord):
2657         (WebCore::HTMLElementStack::ElementRecord::replaceElement):
2658         (WebCore::HTMLElementStack::HTMLElementStack):
2659         (WebCore::HTMLElementStack::secondElementIsHTMLBodyElement):
2660         (WebCore::HTMLElementStack::popAll):
2661         (WebCore::HTMLElementStack::popUntilNumberedHeaderElementPopped):
2662         (WebCore::HTMLElementStack::popUntil):
2663         (WebCore::HTMLElementStack::popUntilPopped):
2664         (WebCore::HTMLElementStack::popUntilTableScopeMarker):
2665         (WebCore::HTMLElementStack::popUntilTableBodyScopeMarker):
2666         (WebCore::HTMLElementStack::popUntilTableRowScopeMarker):
2667         (WebCore::HTMLElementStack::pushHTMLHtmlElement):
2668         (WebCore::HTMLElementStack::push):
2669         (WebCore::HTMLElementStack::insertAbove):
2670         (WebCore::HTMLElementStack::find):
2671         (WebCore::HTMLElementStack::topmost):
2672         (WebCore::HTMLElementStack::contains):
2673         (WebCore::inScopeCommon):
2674         (WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
2675         (WebCore::HTMLElementStack::htmlElement):
2676         (WebCore::HTMLElementStack::rootNode):
2677         (WebCore::HTMLElementStack::pushCommon):
2678         * html/parser/HTMLElementStack.h:
2679         (WebCore::HTMLElementStack::ElementRecord::element):
2680         (WebCore::HTMLElementStack::ElementRecord::node):
2681         (WebCore::HTMLElementStack::topNode):
2682         * html/parser/HTMLTreeBuilder.cpp:
2683         (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
2684         (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
2685         (WebCore::HTMLTreeBuilder::processStartTagForInBody):
2686         (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
2687         (WebCore::HTMLTreeBuilder::processStartTag):
2688         (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
2689         (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
2690         (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
2691         (WebCore::HTMLTreeBuilder::processEndTagForInCell):
2692         (WebCore::HTMLTreeBuilder::processEndTagForInBody):
2693         (WebCore::HTMLTreeBuilder::processEndTag):
2694         (WebCore::HTMLTreeBuilder::processEndOfFile):
2695         (WebCore::HTMLTreeBuilder::finished):
2696         * html/parser/HTMLTreeBuilder.h:
2697
2698 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2699
2700         Unreviewed, rolling out r80188.
2701         http://trac.webkit.org/changeset/80188
2702         https://bugs.webkit.org/show_bug.cgi?id=55647
2703
2704         Broke the WebKit API tests. (Requested by xenon on #webkit).
2705
2706         * WebCore.exp.in:
2707
2708 2011-03-02  Kent Tamura  <tkent@chromium.org>
2709
2710         Unreviewed, build fix.
2711
2712         * platform/text/LocalizedNumberICU.cpp:
2713         (WebCore::createFormatterForCurrentLocale): Fix a typo.
2714
2715 2011-03-02  Kent Tamura  <tkent@chromium.org>
2716
2717         Reviewed by Darin Adler.
2718
2719         Caching number formatter instances in LocalizedNumber* implementations
2720         https://bugs.webkit.org/show_bug.cgi?id=55629
2721
2722         No new tests. This change doesn't change existing behavior, and is
2723         covered by existing tests.
2724
2725         * platform/text/LocalizedNumberICU.cpp:
2726         (WebCore::createFormatterForCurrentLocale):
2727         (WebCore::numberFormatter): Introduce a function to return a static
2728           instance of NumberFormat.
2729         (WebCore::parseLocalizedNumber): Use numberFormatter().
2730         (WebCore::formatLocalizedNumber): Use numberFormatter().
2731         * platform/text/mac/LocalizedNumberMac.mm:
2732         (WebCore::createFormatterForCurrentLocale):
2733         (WebCore::numberFormatter): Introduce a function to return a static
2734           instance of NSNumberFormatter.
2735         (WebCore::parseLocalizedNumber): Use numberFormatter().
2736         (WebCore::formatLocalizedNumber): Use numberFormatter().
2737
2738 2011-03-02  Levi Weintraub  <leviw@chromium.org>
2739
2740         Reviewed by Ryosuke Niwa.
2741
2742         deprecatedEditingOffset should actually return the expected deprecated value for "after" positions
2743         https://bugs.webkit.org/show_bug.cgi?id=54986
2744
2745         Calls to deprecatedEditingOffset needs to return the expected value for new Before/After positions
2746         until we can update all the call sites to consider the new position types.
2747
2748         No tests. This is intended to simplify the transition to new Positions, not to change behavior.
2749
2750         * dom/Position.cpp:
2751         (WebCore::Position::deprecatedEditingOffset):
2752         (WebCore::Position::offsetForPositionAfterAnchor): Added to do the right thing while ensuring
2753         inline-speed for most calls to deprecatedEditingOffset.
2754         * dom/Position.h:
2755
2756 2011-03-02  Timothy Hatcher  <timothy@apple.com>
2757
2758         Export SerializedScriptValue::create(JSC::ExecState* exec, JSC::JSValue value).
2759
2760         Reviewed by Darin Adler.
2761
2762         * WebCore.exp.in: Added __ZN7WebCore21SerializedScriptValue6createEPN3JSC9ExecStateENS1_7JSValueE.
2763
2764 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
2765
2766         Reviewed by David Levin.
2767
2768         Manually revert ChromiumDataObject changes.
2769         https://bugs.webkit.org/show_bug.cgi?id=55627
2770
2771         No new tests since no functionality should change.
2772
2773         * WebCore.gypi:
2774         * editing/chromium/EditorChromium.cpp:
2775         (WebCore::Editor::newGeneralClipboard):
2776         * page/chromium/EventHandlerChromium.cpp:
2777         (WebCore::EventHandler::createDraggingClipboard):
2778         * platform/chromium/ChromiumDataObject.cpp:
2779         (WebCore::ChromiumDataObject::clearData):
2780         (WebCore::ChromiumDataObject::clearAll):
2781         (WebCore::ChromiumDataObject::clearAllExceptFiles):
2782         (WebCore::ChromiumDataObject::hasData):
2783         (WebCore::ChromiumDataObject::types):
2784         (WebCore::ChromiumDataObject::getData):
2785         (WebCore::ChromiumDataObject::setData):
2786         (WebCore::ChromiumDataObject::ChromiumDataObject):
2787         * platform/chromium/ChromiumDataObject.h:
2788         (WebCore::ChromiumDataObject::create):
2789         (WebCore::ChromiumDataObject::copy):
2790         (WebCore::ChromiumDataObject::urlTitle):
2791         (WebCore::ChromiumDataObject::setUrlTitle):
2792         (WebCore::ChromiumDataObject::htmlBaseUrl):
2793         (WebCore::ChromiumDataObject::setHtmlBaseUrl):
2794         (WebCore::ChromiumDataObject::containsFilenames):
2795         (WebCore::ChromiumDataObject::filenames):
2796         (WebCore::ChromiumDataObject::setFilenames):
2797         (WebCore::ChromiumDataObject::fileExtension):
2798         (WebCore::ChromiumDataObject::setFileExtension):
2799         (WebCore::ChromiumDataObject::fileContentFilename):
2800         (WebCore::ChromiumDataObject::setFileContentFilename):
2801         (WebCore::ChromiumDataObject::fileContent):
2802         (WebCore::ChromiumDataObject::setFileContent):
2803         * platform/chromium/ClipboardChromium.cpp:
2804         * platform/chromium/ClipboardChromium.h:
2805
2806 2011-03-02  David Grogan  <dgrogan@chromium.org>
2807
2808         Reviewed by Jeremy Orlow.
2809
2810         IndexedDB: fire versionchange events when calling setVersion
2811         https://bugs.webkit.org/show_bug.cgi?id=55095
2812
2813         * dom/EventNames.h:
2814         * storage/IDBDatabase.cpp:
2815         (WebCore::IDBDatabase::setVersion):
2816         (WebCore::IDBDatabase::close):
2817         (WebCore::IDBDatabase::onVersionChange):
2818         (WebCore::IDBDatabase::open):
2819         (WebCore::IDBDatabase::enqueueEvent):
2820         (WebCore::IDBDatabase::dispatchEvent):
2821         * storage/IDBDatabase.h:
2822         (WebCore::IDBDatabase::dispatchEvent):
2823         * storage/IDBDatabase.idl:
2824         * storage/IDBDatabaseBackendImpl.cpp:
2825         (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::create):
2826         (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::databaseCallbacks):
2827         (WebCore::IDBDatabaseBackendImpl::PendingSetVersionCall::PendingSetVersionCall):
2828         (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
2829         (WebCore::IDBDatabaseBackendImpl::setVersion):
2830         (WebCore::IDBDatabaseBackendImpl::open):
2831         (WebCore::IDBDatabaseBackendImpl::close):
2832         * storage/IDBDatabaseBackendImpl.h:
2833         * storage/IDBDatabaseBackendInterface.h:
2834         * storage/IDBDatabaseCallbacks.h: Copied from Source/WebCore/storage/IDBVersionChangeEvent.cpp.
2835         (WebCore::IDBDatabaseCallbacks::~IDBDatabaseCallbacks):
2836         * storage/IDBFactoryBackendImpl.cpp:
2837         (WebCore::IDBFactoryBackendImpl::open):
2838         * storage/IDBRequest.cpp:
2839         (WebCore::IDBRequest::onSuccess):
2840         * storage/IDBVersionChangeEvent.cpp:
2841         (WebCore::IDBVersionChangeEvent::create):
2842         (WebCore::IDBVersionChangeEvent::IDBVersionChangeEvent):
2843         * storage/IDBVersionChangeEvent.h:
2844         * storage/IDBVersionChangeRequest.cpp:
2845         (WebCore::IDBVersionChangeRequest::onBlocked):
2846
2847 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
2848
2849         Fix assertion failures on Gtk bot.
2850
2851         * page/EventHandler.cpp: (WebCore::EventHandler::tabsToLinks): Removed an overzealous
2852         assertion. We can get here with non-Tab key events when spatial navigation is enabled.
2853
2854 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2855
2856         Unreviewed, rolling out r80139.
2857         http://trac.webkit.org/changeset/80139
2858         https://bugs.webkit.org/show_bug.cgi?id=55620
2859
2860         failing and crashing tests on Snow Leopard bot (Requested by
2861         mihaip1 on #webkit).
2862
2863         * page/DOMWindow.cpp:
2864         * page/DOMWindow.h:
2865         * page/Frame.cpp:
2866         (WebCore::Frame::pageDestroyed):
2867         (WebCore::Frame::transferChildFrameToNewDocument):
2868         * page/Frame.h:
2869         (WebCore::Frame::detachFromPage):
2870         * page/Geolocation.cpp:
2871         (WebCore::Geolocation::~Geolocation):
2872         (WebCore::Geolocation::disconnectFrame):
2873         (WebCore::Geolocation::lastPosition):
2874         (WebCore::Geolocation::requestPermission):
2875         (WebCore::Geolocation::startUpdating):
2876         (WebCore::Geolocation::stopUpdating):
2877         * page/Geolocation.h:
2878         * page/GeolocationController.cpp:
2879         (WebCore::GeolocationController::~GeolocationController):
2880         * page/Navigator.cpp:
2881         * page/Navigator.h:
2882         * platform/mock/GeolocationClientMock.cpp:
2883         * platform/mock/GeolocationClientMock.h:
2884
2885 2011-03-02  Jessie Berlin  <jberlin@apple.com>
2886
2887         Reviewed by Adam Roben.
2888
2889         WebKit2: Use CFNetwork Sessions API.
2890         https://bugs.webkit.org/show_bug.cgi?id=55435
2891
2892         Add the ability to create a Private Browsing Storage Session.
2893
2894         * WebCore.exp.in:
2895         Export the symbol for ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase.
2896
2897         * page/Settings.cpp:
2898         (WebCore::Settings::setPrivateBrowsingEnabled):
2899         Propagate the private browsing state to the ResourceHandle.
2900
2901         * platform/mac/WebCoreSystemInterface.h:
2902         Add the function declaration for wkCreatePrivateStorageSession.
2903         * platform/mac/WebCoreSystemInterface.mm:
2904
2905         * platform/network/ResourceHandle.cpp:
2906         (WebCore::privateStorageSession):
2907         Since the same Private Browsing Storage Session will need to be accessed throughout the loading
2908         code and will need to be used by all web pages and page groups, make it a global static.
2909         (WebCore::privateBrowsingStorageSessionIdentifierBase):
2910         Ditto, since the identifier is needed to create the Private Browsing Storage Session.
2911         (WebCore::ResourceHandle::setPrivateBrowsingEnabled):
2912         If enabled, create and store the Private Browsing Storage Session.
2913         (WebCore::ResourceHandle::privateBrowsingStorageSession):
2914         (WebCore::ResourceHandle::setPrivateBrowsingStorageSessionIdentifierBase):
2915         * platform/network/ResourceHandle.h:
2916
2917         * platform/network/cf/ResourceHandleCFNet.cpp:
2918         (WebCore::ResourceHandle::createPrivateBrowsingStorageSession):
2919         The call to wkCreatePrivateStorageSession needs to be in a file including the correct
2920         version of WKSI.
2921         (WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase):
2922         Return the bundle identifier.
2923         * platform/network/mac/ResourceHandleMac.mm:
2924         (WebCore::ResourceHandle::createPrivateBrowsingStorageSession):
2925         The call to wkCreatePrivateStorageSession needs to be in a file importing the correct
2926         version of WKSI.
2927         (WebCore::ResourceHandle::privateBrowsingStorageSessionIdentifierDefaultBase):
2928         Return the bundle identifier.
2929
2930 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
2931
2932         Revert frame-specific WebClipboard changes
2933         https://bugs.webkit.org/show_bug.cgi?id=55617
2934
2935         This code is no longer needed since we've decided to use the original
2936         approach to copy/paste drag/drop handling in ClipboardChromium.
2937
2938         No new tests because no functionality changes.
2939
2940         * platform/chromium/ChromiumDataObject.cpp:
2941         (WebCore::ChromiumDataObject::createReadable):
2942         * platform/chromium/ChromiumDataObject.h:
2943         * platform/chromium/ClipboardChromium.cpp:
2944         (WebCore::ClipboardChromium::create):
2945         * platform/chromium/PlatformBridge.h:
2946         * platform/chromium/ReadableDataObject.cpp:
2947         (WebCore::ReadableDataObject::create):
2948         (WebCore::ReadableDataObject::ReadableDataObject):
2949         (WebCore::ReadableDataObject::getData):
2950         (WebCore::ReadableDataObject::urlTitle):
2951         (WebCore::ReadableDataObject::htmlBaseUrl):
2952         (WebCore::ReadableDataObject::filenames):
2953         (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
2954         * platform/chromium/ReadableDataObject.h:
2955
2956 2011-03-02  Tony Chang  <tony@chromium.org>
2957
2958         Unreviewed, rolling chromium DEPS to r76362.
2959
2960         https://bugs.webkit.org/show_bug.cgi?id=55564
2961
2962         * WebCore.gyp/WebCore.gyp: Switch to libjpeg_turbo to match chromium
2963
2964 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
2965
2966         Build fix.
2967
2968         * page/ChromeClient.h: (WebCore::ChromeClient::keyboardUIMode): I didn't mean to commit these
2969         changes yet.
2970
2971 2011-03-02  Alexey Proskuryakov  <ap@apple.com>
2972
2973         Reviewed by John Sullivan.
2974
2975         Clean up WebCore tabsToLinks code a little
2976         https://bugs.webkit.org/show_bug.cgi?id=55606
2977
2978         No change in behavior, so no tests.
2979
2980         * html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::isKeyboardFocusable):
2981         This is the only caller of tabsToAllControls(). Renamed this function to tabsToAllFormControls().
2982
2983         * page/EventHandler.cpp:
2984         (WebCore::EventHandler::isKeyboardOptionTab): Moved from platform specific files. This
2985         function cannot be file static, because EventHandlerMac.mm uses it.
2986         (WebCore::eventInvertsTabsToLinksClientCallResult): Merged implementations from platform
2987         specific files. We can just as well have #if here. Renamed for clarity.
2988         (WebCore::EventHandler::tabsToLinks): Rewrote in a way that makes it clearer how "invert"
2989         works.
2990
2991         * page/EventHandler.h: We no longer need invertSenseOfTabsToLinks() here, it's only used
2992         in EventHandler.cpp.
2993
2994         * page/android/EventHandlerAndroid.cpp: (WebCore::EventHandler::tabsToAllFormControls):
2995         * page/brew/EventHandlerBrew.cpp: (WebCore::EventHandler::tabsToAllFormControls):
2996         * page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::tabsToAllFormControls):
2997         * page/efl/EventHandlerEfl.cpp: (WebCore::EventHandler::tabsToAllFormControls):
2998         * page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::tabsToAllFormControls):
2999         * page/haiku/EventHandlerHaiku.cpp: (WebCore::EventHandler::tabsToAllFormControls):
3000         * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::tabsToAllFormControls):
3001         * page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::tabsToAllFormControls):
3002         * page/win/EventHandlerWin.cpp: (WebCore::EventHandler::tabsToAllFormControls):
3003         * page/wx/EventHandlerWx.cpp: (WebCore::EventHandler::tabsToAllFormControls):
3004         Updating all port files.
3005
3006 2011-02-28  Jeremy Orlow  <jorlow@chromium.org>
3007
3008         Reviewed by James Robinson.
3009
3010         Split IDBCursor.value into IDBCursor.primaryKey and IDBCursor.value
3011         https://bugs.webkit.org/show_bug.cgi?id=55443
3012
3013         Implement http://www.w3.org/Bugs/Public/show_bug.cgi?id=11948
3014
3015         The idea is to have an IDBCursor and an IDBCursorWithValue interface which
3016         inherits from the former.  index.openKeyCursor will return the former and
3017         index/objectStore.openCursor will return the latter.  We'll add a primaryKey
3018         attribute to IDBCursor.  It will always be the key of the associated object
3019         store entry.  For index.openCursor cursors, the key attribute will be the key
3020         of the index.  For objectStore.openCursors, it'll be the same as the
3021         primaryKey.  The value will be the value of the objectStore entry.
3022
3023         * WebCore.gypi:
3024         * bindings/scripts/CodeGeneratorV8.pm:
3025         * bindings/v8/SerializedScriptValue.cpp:
3026         (WebCore::SerializedScriptValue::deserializeAndSetProperty):
3027         * bindings/v8/SerializedScriptValue.h:
3028         * bindings/v8/custom/V8IDBAnyCustom.cpp:
3029         (WebCore::toV8):
3030         * storage/IDBAny.cpp:
3031         (WebCore::IDBAny::idbCursorWithValue):
3032         (WebCore::IDBAny::set):
3033         * storage/IDBAny.h:
3034         * storage/IDBCursor.cpp:
3035         (WebCore::IDBCursor::create):
3036         (WebCore::IDBCursor::primaryKey):
3037         (WebCore::IDBCursor::value):
3038         * storage/IDBCursor.h:
3039         * storage/IDBCursor.idl:
3040         * storage/IDBCursorBackendImpl.cpp:
3041         (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
3042         (WebCore::IDBCursorBackendImpl::primaryKey):
3043         (WebCore::IDBCursorBackendImpl::value):
3044         (WebCore::IDBCursorBackendImpl::update):
3045         (WebCore::IDBCursorBackendImpl::currentRowExists):
3046         (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
3047         (WebCore::IDBCursorBackendImpl::deleteFunction):
3048         (WebCore::IDBCursorBackendImpl::loadCurrentRow):
3049         * storage/IDBCursorBackendImpl.h:
3050         (WebCore::IDBCursorBackendImpl::create):
3051         * storage/IDBCursorBackendInterface.h:
3052         * storage/IDBCursorWithValue.cpp: Copied from Source/WebCore/storage/IDBCursor.idl.
3053         (WebCore::IDBCursorWithValue::create):
3054         (WebCore::IDBCursorWithValue::IDBCursorWithValue):
3055         (WebCore::IDBCursorWithValue::~IDBCursorWithValue):
3056         * storage/IDBCursorWithValue.h: Copied from Source/WebCore/storage/IDBCursorBackendInterface.h.
3057         * storage/IDBCursorWithValue.idl: Copied from Source/WebCore/storage/IDBCursor.idl.
3058         * storage/IDBIndex.cpp:
3059         (WebCore::IDBIndex::openCursor):
3060         (WebCore::IDBIndex::openKeyCursor):
3061         * storage/IDBIndexBackendImpl.cpp:
3062         (WebCore::IDBIndexBackendImpl::openCursorInternal):
3063         (WebCore::IDBIndexBackendImpl::openCursor):
3064         (WebCore::IDBIndexBackendImpl::openKeyCursor):
3065         * storage/IDBIndexBackendImpl.h:
3066         * storage/IDBObjectStore.cpp:
3067         (WebCore::IDBObjectStore::openCursor):
3068         * storage/IDBObjectStoreBackendImpl.cpp:
3069         (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
3070         * storage/IDBRequest.cpp:
3071         (WebCore::IDBRequest::IDBRequest):
3072         (WebCore::IDBRequest::setCursorType):
3073         (WebCore::IDBRequest::onSuccess):
3074         (WebCore::IDBRequest::dispatchEvent):
3075         * storage/IDBRequest.h:
3076
3077 2011-03-02  Aravind Akella  <aravind.akella@nokia.com>
3078
3079          Reviewed by Csaba Osztrogonác.
3080
3081          [Qt][WK2] Memory exhausted when building qtwebkit2 on linux
3082          https://bugs.webkit.org/show_bug.cgi?id=55484
3083
3084          Using AllInOne files to avoid memory exhaustion for debug
3085          builds on 32 bit linux machines.
3086
3087          No new tests. Fixing a build issue.
3088
3089          * WebCore.pro:
3090
3091 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
3092
3093         Reviewed by David Levin.
3094
3095         Add feature define for data transfer items
3096         https://bugs.webkit.org/show_bug.cgi?id=55510
3097
3098         * Configurations/FeatureDefines.xcconfig:
3099         * GNUmakefile.am:
3100         * features.pri:
3101
3102 2011-03-02  Dimitri Glazkov  <dglazkov@chromium.org>
3103
3104         Update location of media-file.js, which was moved in r79630.
3105
3106         * manual-tests/media-controls.html: Updated location.
3107
3108 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3109
3110         Unreviewed, rolling out r80156.
3111         http://trac.webkit.org/changeset/80156
3112         https://bugs.webkit.org/show_bug.cgi?id=55604
3113
3114         "Broke SL compile" (Requested by tonyg-cr on #webkit).
3115
3116         * bridge/jni/JNIBridge.h:
3117         (JSC::Bindings::JavaString::operator UString):
3118         * bridge/jni/jni_jsobject.mm:
3119         (JavaJSObject::call):
3120         (JavaJSObject::eval):
3121         (JavaJSObject::getMember):
3122         (JavaJSObject::setMember):
3123         (JavaJSObject::removeMember):
3124         * bridge/jni/jsc/JavaClassJSC.cpp:
3125         (JavaClass::JavaClass):
3126         * bridge/jni/jsc/JavaStringJSC.h:
3127         (JSC::Bindings::JavaStringImpl::uString):
3128         * bridge/jni/v8/JavaStringV8.h:
3129
3130 2011-03-02  Steve Block  <steveblock@google.com>
3131
3132         Reviewed by Jeremy Orlow.
3133
3134         JavaString API should be implementable by both JSC and V8
3135         https://bugs.webkit.org/show_bug.cgi?id=55567
3136
3137         Remove JavaString's UString operator and replace it with a
3138         script-engine-independent impl() method, which returns a
3139         StringImpl and can be implemented with both JSC and V8.
3140
3141         No new tests, refactoring only.
3142
3143         * bridge/jni/JNIBridge.h:
3144         (JSC::Bindings::JavaString::impl):
3145         * bridge/jni/jni_jsobject.mm:
3146         (JavaJSObject::call):
3147         (JavaJSObject::eval):
3148         (JavaJSObject::getMember):
3149         (JavaJSObject::setMember):
3150         (JavaJSObject::removeMember):
3151         * bridge/jni/jsc/JavaClassJSC.cpp:
3152         (JavaClass::JavaClass):
3153         * bridge/jni/jsc/JavaStringJSC.h:
3154         (JSC::Bindings::JavaStringImpl::impl):
3155         * bridge/jni/v8/JavaStringV8.h:
3156         (JSC::Bindings::JavaStringImpl::impl):
3157
3158 2011-03-02  Mihai Parparita  <mihaip@chromium.org>
3159
3160         Reviewed by Dimitri Glazkov.
3161
3162         Add CRASH() for CSSSelector double frees
3163         https://bugs.webkit.org/show_bug.cgi?id=55596
3164
3165         To help track down bug 53045, add a CRASH call when the CSSSelector
3166         destructor is invoked more than once.
3167
3168         Just a check, no new tests necessary.
3169
3170         * css/CSSSelector.h:
3171         (WebCore::CSSSelector::CSSSelector):
3172         (WebCore::CSSSelector::~CSSSelector):
3173
3174 2011-03-02  Carol Szabo  <carol.szabo@nokia.com>
3175
3176         Reviewed by David Hyatt  <hyatt@apple.com>
3177
3178         content property doesn't support quotes
3179         https://bugs.webkit.org/show_bug.cgi?id=6503
3180
3181         Added full support for quotes as defined by CSS 2.1.
3182
3183         Tests: fast/css/content/content-quotes-01.html
3184                fast/css/content/content-quotes-02.html
3185                fast/css/content/content-quotes-03.html
3186                fast/css/content/content-quotes-04.html
3187                fast/css/content/content-quotes-05.html
3188                fast/css/content/content-quotes-06.html
3189
3190         * Android.mk:
3191         * CMakeLists.txt:
3192         * GNUmakefile.am:
3193         * WebCore.gypi:
3194         * WebCore.pro:
3195         * WebCore.vcproj/WebCore.vcproj:
3196         * WebCore.xcodeproj/project.pbxproj:
3197         Added RenderQuote.cpp/h and QuotesData.cpp/h to the dependency lists
3198         * css/CSSParser.cpp:
3199         (WebCore::CSSParser::parseValue):
3200         (WebCore::CSSParser::parseQuotes):
3201         * css/CSSParser.h:
3202         Added needed stylesheet parsing support for quotes,
3203         (no-)open-quote and (no-)close-quote
3204         * css/CSSStyleSelector.cpp:
3205         (WebCore::CSSStyleSelector::applyProperty):
3206         Handled setting of the new quotes RenderStyle property and added
3207         handling of quotes for the content property.
3208         * css/html.css:
3209         (q:before):
3210         (q:after):
3211         replaced the '"' workaround with open/close-quote
3212         * rendering/RenderBlockLineLayout.cpp:
3213         (WebCore::dirtyLineBoxesForRenderer):
3214         Made RenderQuote behave like RenderCounter.
3215         Needed to ensure that the Quote text is calculated before layout,
3216         just as it is for RenderCounter.
3217         * rendering/RenderObject.h:
3218         (WebCore::RenderObject::isQuote):
3219         * rendering/RenderObjectChildList.cpp:
3220         (WebCore::RenderObjectChildList::removeChildNode):
3221         (WebCore::RenderObjectChildList::appendChildNode):
3222         (WebCore::RenderObjectChildList::insertChildNode):
3223         Handled updating of quote depth when renderers are added and removed
3224         from the tree.
3225         (WebCore::RenderObjectChildList::updateBeforeAfterContent):
3226         Added support for Quote content.
3227         * rendering/RenderQuote.cpp: Added.
3228         (WebCore::adjustDepth):
3229         (WebCore::RenderQuote::RenderQuote):
3230         (WebCore::RenderQuote::~RenderQuote):
3231         (WebCore::RenderQuote::renderName):
3232         (WebCore::RenderQuote::placeQuote):
3233         (WebCore::LanguageData::operator<):
3234         (WebCore::defaultLanguageQuotes):
3235         (WebCore::quotesMap):
3236         (WebCore::quotesForLanguage):
3237         (WebCore::defaultQuotes):
3238         (WebCore::RenderQuote::originalText):
3239         (WebCore::RenderQuote::computePreferredLogicalWidths):
3240         (WebCore::RenderQuote::rendererSubtreeAttached):
3241         (WebCore::RenderQuote::rendererRemovedFromTree):
3242         (WebCore::RenderQuote::styleDidChange):
3243         * rendering/RenderQuote.h: Added.
3244         (WebCore::RenderQuote::isQuote):
3245         (WebCore::toRenderQuote):
3246         * rendering/RenderingAllInOne.cpp:
3247         Included RenderQuote.cpp
3248         * rendering/style/StyleAllInOne.cpp:
3249         Included QuotesData.cpp
3250         * rendering/style/ContentData.cpp:
3251         (WebCore::ContentData::dataEquivalent):
3252         Checked for quotetype identity.
3253         (WebCore::ContentData::deleteContent):
3254         Accounted for the new QUOTE_TYPE.
3255         * rendering/style/ContentData.h:
3256         (WebCore::ContentData::isQuote):
3257         (WebCore::ContentData::quote):
3258         (WebCore::ContentData::setQuote):
3259         * rendering/style/QuotesData.cpp: Added.
3260         (WebCore::QuotesData::create):
3261         (WebCore::QuotesData::operator==):
3262         (WebCore::QuotesData::~QuotesData):
3263         * rendering/style/QuotesData.h: Added.
3264         (WebCore::QuotesData::data):
3265         (WebCore::QuotesData::operator delete):
3266         (WebCore::QuotesData::QuotesData):
3267         * rendering/style/RenderStyle.cpp:
3268         (WebCore::RenderStyle::setContent):
3269         (WebCore::RenderStyle::setQuotes):
3270         * rendering/style/RenderStyle.h:
3271         (WebCore::InheritedFlags::quotes):
3272         (WebCore::InheritedFlags::setQuotes):
3273         * rendering/style/RenderStyleConstants.h:
3274         * rendering/style/StyleAllInOne.cpp:
3275         Added QuotesData.cpp to the included files list.
3276         * rendering/style/StyleRareInheritedData.cpp:
3277         (WebCore::StyleRareInheritedData::operator==):
3278         Included quotes in equality check.
3279         * rendering/style/StyleRareInheritedData.h:
3280         Added quotes
3281
3282 2011-03-02  Antti Koivisto  <antti@apple.com>
3283
3284         Reviewed by Dave Hyatt.
3285
3286         Selector usage flags should not be set by the CSS parser
3287         https://bugs.webkit.org/show_bug.cgi?id=55573
3288
3289         Currently flags like Document::usesSiblingRules() are set directly by the CSS parser. This is wrong as
3290         we may parse stylesheets that are not actually used for document rendering. This is especially bad when
3291         the page uses querySelectorAll(). As a result we may end up in various performance penalty boxes
3292         triggered by complex selectors for no good reason.
3293
3294         - Use the selector traversal in style selector constructor to figure out which flags
3295           are actually needed for the currently active style sheets.
3296         - Remove the selector flag related code from the CSS parser/grammar.
3297         - Remove the usesDescendantRules flag completely. We have descendant rules in the default
3298           style sheet, every document uses them.
3299
3300         * css/CSSGrammar.y:
3301         * css/CSSParser.cpp:
3302         (WebCore::CSSParser::updateSpecifiersWithElementName):
3303         * css/CSSStyleSelector.cpp:
3304         (WebCore::collectSiblingRulesInDefaultStyle):
3305         (WebCore::CSSStyleSelector::CSSStyleSelector):
3306         (WebCore::CSSStyleSelector::Features::Features):
3307         (WebCore::CSSStyleSelector::Features::~Features):
3308         (WebCore::CSSStyleSelector::locateCousinList):
3309         (WebCore::CSSStyleSelector::matchesSiblingRules):
3310         (WebCore::CSSStyleSelector::canShareStyleWithElement):
3311         (WebCore::CSSStyleSelector::locateSharedStyle):
3312         (WebCore::collectFeaturesFromSelector):
3313         (WebCore::collectFeaturesFromList):
3314         (WebCore::RuleSet::collectFeatures):
3315         * css/CSSStyleSelector.h:
3316         (WebCore::CSSStyleSelector::usesSiblingRules):
3317         (WebCore::CSSStyleSelector::usesFirstLineRules):
3318         (WebCore::CSSStyleSelector::usesBeforeAfterRules):
3319         (WebCore::CSSStyleSelector::usesLinkRules):
3320         * dom/Document.cpp:
3321         (WebCore::Document::Document):
3322         (WebCore::Document::recalcStyle):
3323         (WebCore::Document::createStyleSelector):
3324         * dom/Document.h:
3325         (WebCore::Document::usesSiblingRules):
3326         (WebCore::Document::setUsesSiblingRules):
3327         (WebCore::Document::usesFirstLineRules):
3328         (WebCore::Document::usesBeforeAfterRules):
3329         (WebCore::Document::setUsesBeforeAfterRules):
3330         * dom/Element.cpp:
3331         (WebCore::Element::recalcStyle):
3332
3333 2011-03-02  Brian Weinstein  <bweinstein@apple.com>
3334
3335         Fix fallout from a last minute renaming.
3336
3337         * platform/network/cf/CookieStorageCFNet.cpp:
3338         (WebCore::startObservingCookieChanges):
3339         (WebCore::stopObservingCookieChanges):
3340
3341 2011-03-01  Brian Weinstein  <bweinstein@apple.com>
3342
3343         Reviewed by Adam Roben.
3344
3345         Part of WebKit2: Need a way to send notifications to client when cookies change
3346         https://bugs.webkit.org/show_bug.cgi?id=55427
3347         <rdar://problem/9056027>
3348
3349         Add functions on CookieStorage that allow listening for changes in cookies. When
3350         the cookies are changed, they call through to CookiesStrategy::notifyCookiesChanged.
3351
3352         No change in behavior requiring tests.
3353
3354         * platform/CookiesStrategy.h: Added.
3355         (WebCore::CookiesStrategy::~CookiesStrategy):
3356
3357         * platform/PlatformStrategies.h:
3358         (WebCore::PlatformStrategies::cookiesStrategy):
3359         (WebCore::PlatformStrategies::PlatformStrategies):
3360
3361         * platform/network/CookieStorage.h: Add new function declarations.
3362
3363         * platform/network/cf/CookieStorageCFNet.cpp:
3364         (WebCore::notifyCookiesChangedOnMainThread): Call through to CookiesStrategy::notifyCookiesChanged.
3365         (WebCore::notifyCookiesChanged): Call notifyCookiesChangedOnMainThread on the main thread.
3366         (WebCore::beginObservingCookieChanges): Set up cookie observers on the loader run loop.
3367         (WebCore::finishObservingCookieChanges): Remove our cookie observers from the loader run loop.
3368
3369         * platform/network/mac/CookieStorageMac.mm:
3370         (-[CookieStorageObjCAdapter notifyCookiesChangedOnMainThread]): Call through to CookiesStrategy::notifyCookiesChanged.
3371         (-[CookieStorageObjCAdapter cookiesChangedNotificationHandler:]): Call notifyCookiesChangedOnMainThread on
3372             the main thread.
3373         (-[CookieStorageObjCAdapter registerForCookieChangeNotifications]): Set up the observer for cookie change notifications.
3374         (-[CookieStorageObjCAdapter unregisterForCookieChangeNotifications]): Remove the observer for cookie change notifications.
3375         (WebCore::beginObservingCookieChanges): Create our CookieStorageObjCAdapter, and call registerForCookieChangeNotifications.
3376         (WebCore::finishObservingCookieChanges): Call unregisterForCookieChangeNotifications.
3377
3378         Add new file.
3379         * WebCore.vcproj/WebCore.vcproj:
3380         * WebCore.xcodeproj/project.pbxproj: Set role on files we need to include in WebKit to private.
3381
3382 2011-03-02  Sergey Glazunov  <serg.glazunov@gmail.com>
3383
3384         Reviewed by Dimitri Glazkov.
3385
3386         A WebKitCSSKeyframesRule object should set itself as the parent for inserted rules
3387         https://bugs.webkit.org/show_bug.cgi?id=55488
3388
3389         Test: fast/css/css-keyframe-parent.html
3390
3391         * css/WebKitCSSKeyframesRule.cpp:
3392         (WebCore::WebKitCSSKeyframesRule::append):
3393
3394 2011-03-02  Sergio Villar Senin  <svillar@igalia.com>
3395
3396         Reviewed by Martin Robinson.
3397
3398         [GTK] Add support for external protocol handlers
3399         https://bugs.webkit.org/show_bug.cgi?id=55473
3400
3401         Do not unconditionally create and replace the SoupRequester of the
3402         SoupSession if there is already one. No new tests needed as we
3403         just allow clients to create their our SoupRequesters.
3404
3405         * platform/network/soup/ResourceHandleSoup.cpp:
3406         (WebCore::ensureSessionIsInitialized):
3407
3408 2011-03-02  John Knottenbelt  <jknotten@chromium.org>
3409
3410         Reviewed by jknotten@chromium.org.
3411
3412         Fix build-breakage when GEOLOCATION not enabled.
3413         https://bugs.webkit.org/show_bug.cgi?id=55586
3414
3415         Geolocation::reset needs to be defined if ENABLE(GEOLOCATION)
3416         is not true.
3417
3418         * page/Geolocation.cpp:
3419         (WebCore::Geolocation::reset):
3420
3421 2011-03-02  Pavel Feldman  <pfeldman@chromium.org>
3422
3423         Reviewed by Yury Semikhatsky.
3424
3425         Web Inspector: remove InjectedScriptHost -> DOMAgent dependency.
3426         https://bugs.webkit.org/show_bug.cgi?id=55575
3427
3428         * bindings/js/JSInjectedScriptHostCustom.cpp:
3429         (WebCore::JSInjectedScriptHost::inspectedNode):
3430         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
3431         (WebCore::V8InjectedScriptHost::inspectedNodeCallback):
3432         * inspector/ConsoleMessage.cpp:
3433         (WebCore::ConsoleMessage::addToFrontend):
3434         * inspector/InjectedScript.cpp:
3435         (WebCore::InjectedScript::evaluateOn):
3436         (WebCore::InjectedScript::wrapObject):
3437         (WebCore::InjectedScript::wrapNode):
3438         (WebCore::InjectedScript::inspectNode):
3439         (WebCore::InjectedScript::nodeAsScriptValue):
3440         * inspector/InjectedScript.h:
3441         * inspector/InjectedScriptHost.cpp:
3442         (WebCore::InjectedScriptHost::addInspectedNode):
3443         (WebCore::InjectedScriptHost::clearInspectedNodes):
3444         (WebCore::InjectedScriptHost::copyText):
3445         (WebCore::InjectedScriptHost::inspectedNode):
3446         * inspector/InjectedScriptHost.h:
3447         * inspector/InjectedScriptHost.idl:
3448         * inspector/InjectedScriptSource.js:
3449         * inspector/Inspector.idl:
3450         * inspector/InspectorDOMAgent.cpp:
3451         (WebCore::InspectorDOMAgent::discardBindings):
3452         (WebCore::InspectorDOMAgent::addInspectedNode):
3453         (WebCore::InspectorDOMAgent::resolveNode):
3454         (WebCore::InspectorDOMAgent::injectedScriptForNode):
3455         * inspector/InspectorDOMAgent.h:
3456         * inspector/InspectorRuntimeAgent.cpp:
3457         (WebCore::InspectorRuntimeAgent::evaluateOn):
3458         * inspector/InspectorRuntimeAgent.h:
3459         * inspector/front-end/ElementsTreeOutline.js:
3460         (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
3461         (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode):
3462         (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
3463         * inspector/front-end/PropertiesSidebarPane.js:
3464         (WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
3465         (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
3466         (WebInspector.PropertiesSidebarPane.prototype.update.fillSection):
3467         (WebInspector.PropertiesSidebarPane.prototype.update):
3468         * inspector/front-end/RemoteObject.js:
3469         (WebInspector.RemoteObject.resolveNode):
3470         (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
3471         (WebInspector.RemoteObject.prototype.evaluate):
3472
3473 2011-01-21  John Knottenbelt  <jknotten@chromium.org>
3474
3475         Reviewed by Dmitry Titov.
3476
3477         Detach Geolocation from Frame when Page destroyed.
3478         https://bugs.webkit.org/show_bug.cgi?id=52877
3479
3480         On Page destruction, any outstanding Geolocation permission
3481         requests should be cancelled, because the Geolocation can only
3482         access the client indirectly via m_frame->page().
3483
3484         Additionally, if the Frame is reparented to another page, the
3485         Geolocation should cancel watches, single-shots and requests on
3486         the old page.
3487
3488         Page destruction is signalled by a call to the
3489         Frame::pageDestroyed() method. This calls Frame::detachFromPage,
3490         where we extend the call chain to Geolocation::detachFromPage()
3491         where we call Geolocation::reset() which detaches from the
3492         GeolocationController, cancels requests, watches and single shots,
3493         and sets the permission state back to Unknown.
3494
3495         We also now call detachFromPage when the frame reparented in
3496         Frame::transferChildFrameToNewDocument.
3497
3498         Frame::pageDestroyed() is also called by FrameLoader even though