2011-06-10 Lucas De Marchi <lucas.demarchi@profusion.mobi>
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-06-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2
3         Reviewed by Kenneth Rohde Christiansen.
4
5         [CMAKE] Add generic support for building with WebGL
6         https://bugs.webkit.org/show_bug.cgi?id=62376
7
8         Set new THIRDPARTY_DIR variable to compile sources under ThirdParty.
9
10         No change in functionality so no new tests.
11
12         * CMakeLists.txt:
13
14 2011-06-10  Ryuan Choi  <ryuan.choi@samsung.com>
15
16         Reviewed by Andreas Kling.
17
18         [GTK][EFL] m_imageInterpolationQuality is not initialized in PlatformContextCairo::PlatformContextCairo.
19         https://bugs.webkit.org/show_bug.cgi?id=62435
20
21         No new tests required as just fixed warning.
22
23         * platform/graphics/cairo/PlatformContextCairo.cpp:
24         (WebCore::PlatformContextCairo::PlatformContextCairo):
25
26 2011-06-11-06-09  Ilya Tikhonovsky  <loislo@chromium.org>
27
28         Reviewed by Yury Semikhatsky.
29
30         Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
31         https://bugs.webkit.org/show_bug.cgi?id=62377
32
33         * inspector/InspectorValues.cpp:
34
35 2011-06-10  Sheriff Bot  <webkit.review.bot@gmail.com>
36
37         Unreviewed, rolling out r88530.
38         http://trac.webkit.org/changeset/88530
39         https://bugs.webkit.org/show_bug.cgi?id=62440
40
41         qt build was broken (Requested by loislo on #webkit).
42
43         * inspector/InspectorValues.cpp:
44
45 2011-06-09  Ilya Tikhonovsky  <loislo@chromium.org>
46
47         Reviewed by Yury Semikhatsky.
48
49         Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
50         https://bugs.webkit.org/show_bug.cgi?id=62377
51
52         * inspector/InspectorValues.cpp:
53
54 2011-06-09  Jer Noble  <jer.noble@apple.com>
55
56         Reviewed by Darin Adler.
57
58         REGRESSION: Vertical scroll bar appears when taking videos into full screen at jerryseinfeld.com
59         https://bugs.webkit.org/show_bug.cgi?id=62402
60
61         Sites are able to override the "overflow:hidden" rule for root full-screen nodes
62         simply by adding a "html {}" rule.  Make this rule !important, and also make it apply
63         to root nodes who are merely ancestors of full-screen elements, to cover the case of
64         a root node containing an <iframe> whose contents have gone full-screen.
65
66         * css/fullscreen.css:
67         (:root:-webkit-full-screen-document:not(:-webkit-full-screen),
68             :root:-webkit-full-screen-ancestor): Apply the overflow rule to root elements
69             who are full-screen ancestors, and make them !important.
70
71 2011-06-09  Luke Macpherson   <macpherson@chromium.org>
72
73         Reviewed by Eric Seidel.
74
75         Rename RenderStyle visuallyOrdered property and use an enum instead of a bool.
76         https://bugs.webkit.org/show_bug.cgi?id=61495
77
78         No new tests required as no functionality changed.
79
80         * css/CSSPrimitiveValueMappings.h:
81         Support cast to/from Order
82         * css/CSSStyleSelector.cpp:
83         (WebCore::CSSStyleSelector::styleForDocument):
84         Convert from bool to enum type.
85         (WebCore::CSSStyleSelector::applyProperty):
86         Convert to macro that uses the cast defined in CSSPrimitiveValueMappings.
87         * dom/Document.cpp:
88         (WebCore::Document::setVisuallyOrdered):
89         Change call to RenderStyle::setRTLOrdering using enum parameter.
90         * rendering/style/RenderStyle.h:
91         rename visuallyOrdered proerties rtlOrdering and use appropriate enum types.
92         * rendering/style/RenderStyleConstants.h:
93         Define enum type.
94
95 2011-06-09  Luke Macpherson   <macpherson@chromium.org>
96
97         Reviewed by Eric Seidel.
98
99         Implement CSSPropertyOutlineStyle handler in CSSStyleApplyProperty
100         https://bugs.webkit.org/show_bug.cgi?id=61601
101
102         No new tests. No new functionality added / covered by existing tests.
103
104         * css/CSSPrimitiveValueMappings.h:
105         (WebCore::CSSPrimitiveValue::operator EBorderStyle):
106         Support CSSValueAuto as required by outline-style property.
107         (WebCore::CSSPrimitiveValue::operator OutlineIsAuto):
108         Add cast to new OutlineIsAuto enum.
109         * css/CSSStyleApplyProperty.cpp:
110         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
111         Initialize handler for CSSPropertyOutlineStyle.
112         * css/CSSStyleSelector.cpp:
113         (WebCore::CSSStyleSelector::applyProperty):
114         Remove old handler for CSSPropertyOutlineStyle.
115         * rendering/style/OutlineValue.h:
116         Use new OutlineIsAuto enum instead of bool.
117         * rendering/style/RenderStyle.h:
118         Split existing two-parameter setter setOutlineStyle into separate setters for style and auto properties.
119         Use new OutlineIsAuto enum type.
120         * rendering/style/RenderStyleConstants.h:
121         Define new enum OutlineIsAuto.
122
123 2011-06-09  Luke Macpherson   <macpherson@chromium.org>
124
125         Reviewed by Eric Seidel.
126
127         Code cleanup - add wrappers for function pointer dereferences to improve readability in ApplyPropertyDefaultBase and derived classes.
128         https://bugs.webkit.org/show_bug.cgi?id=62418
129
130         No new tests / cleanup only.
131
132         * css/CSSStyleApplyProperty.cpp:
133         (WebCore::ApplyPropertyDefaultBase::applyInheritValue):
134         Use new wrapper functions.
135         (WebCore::ApplyPropertyDefaultBase::applyInitialValue):
136         Use new wrapper functions.
137         (WebCore::ApplyPropertyDefaultBase::setValue):
138         Wrapper for calling m_setter function pointer.
139         (WebCore::ApplyPropertyDefaultBase::value):
140         Wrapper for calling m_getter function pointer.
141         (WebCore::ApplyPropertyDefaultBase::initial):
142         Wrapper for calling m_initial function pointer.
143         (WebCore::ApplyPropertyDefault::applyValue):
144         Use new setValue function.
145         (WebCore::ApplyPropertyLength::applyValue):
146         Use new setValue function.
147         (WebCore::ApplyPropertyWidth::applyValue):
148         Use new setValue function.
149
150 2011-06-09  Hyowon Kim  <hw1008.kim@samsung.com>
151
152         Reviewed by Antonio Gomes.
153
154         [EFL] Make accelerated compositing build in Webkit-EFL
155         https://bugs.webkit.org/show_bug.cgi?id=62361
156
157         Add a new class, GraphicsLayerEfl - not yet implemented.
158         Add ACCELERATED_COMPOSITING related files to CMakeLists.
159
160         * CMakeLists.txt:
161         * CMakeListsEfl.txt:
162         * platform/graphics/efl/GraphicsLayerEfl.cpp: Added.
163         (WebCore::GraphicsLayer::create):
164         (WebCore::GraphicsLayerEfl::GraphicsLayerEfl):
165         (WebCore::GraphicsLayerEfl::~GraphicsLayerEfl):
166         (WebCore::GraphicsLayerEfl::setNeedsDisplay):
167         (WebCore::GraphicsLayerEfl::setNeedsDisplayInRect):
168         * platform/graphics/efl/GraphicsLayerEfl.h: Added.
169
170 2011-06-09  Jian Li  <jianli@chromium.org>
171
172         Reviewed by David Levin.
173
174         Calling WebKitBlobBuilder.append with null argument should not crash
175         https://bugs.webkit.org/show_bug.cgi?id=62419
176
177         Test: fast/files/blob-builder-crash.html
178
179         * fileapi/WebKitBlobBuilder.cpp:
180         (WebCore::WebKitBlobBuilder::append):
181
182 2011-06-09  Jer Noble  <jer.noble@apple.com>
183
184         Reviewed by David Hyatt.
185
186         Roll out r88468, and fix bug #61911 without making Element::offset functions virtual.
187         https://bugs.webkit.org/show_bug.cgi?id=62400
188
189         No new tests; covered by existing fullscreen/full-screen-video-offset.html test.
190
191         * rendering/RenderVideo.cpp:
192         (WebCore::rendererPlaceholder): Added; returns the placeholder block, if it exists.
193         (WebCore::RenderVideo::offsetLeft): Pass the offset request to the placeholder block.
194         (WebCore::RenderVideo::offsetTop): Ditto.
195         (WebCore::RenderVideo::offsetWidth): Ditto.
196         (WebCore::RenderVideo::offsetHeight): Ditto.
197         * rendering/RenderVideo.h: Added virtual overrides for the offset functions.
198
199 2011-06-09  James Robinson  <jamesr@chromium.org>
200
201         Reviewed by Kenneth Russell.
202
203         [chromium] Scissor rect not set for clipping layers set offscreen
204         https://bugs.webkit.org/show_bug.cgi?id=62339
205
206         We set a scissorRect on each layer, but only layers with masksToBounds and their descendants should actually set
207         a scissor.  Layers that didn't need to scissor had empty scissorRects.  Unfortunately layers with masksToBounds
208         and their descendants that are scrolled offscreen also end up with an empty clipped scissor rect.
209
210         This patch sets an explicit bit on each layer that should scissor and then checks that bit instead of checking
211         for an empty scissor rect at draw time.  RenderSurfaceChromiums have different requirements for
212         setScissorToRect, so the old behavior is still available with a flag.  This can probably be cleaned up more.
213
214         Test: platform/chromium/compositing/scissor-out-of-viewport.html
215
216         * platform/graphics/chromium/LayerRendererChromium.cpp:
217         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
218         (WebCore::LayerRendererChromium::drawLayer):
219         (WebCore::LayerRendererChromium::setScissorToRect):
220         * platform/graphics/chromium/LayerRendererChromium.h:
221         * platform/graphics/chromium/RenderSurfaceChromium.cpp:
222         (WebCore::RenderSurfaceChromium::draw):
223         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
224         (WebCore::CCLayerImpl::CCLayerImpl):
225         * platform/graphics/chromium/cc/CCLayerImpl.h:
226         (WebCore::CCLayerImpl::setUsesLayerScissor):
227         (WebCore::CCLayerImpl::usesLayerScissor):
228
229 2011-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>
230
231         Unreviewed, rolling out r88468.
232         http://trac.webkit.org/changeset/88468
233         https://bugs.webkit.org/show_bug.cgi?id=62408
234
235         It broke build if !ENABLE(FULLSCREEN_API) (Requested by Ossy
236         on #webkit).
237
238         * dom/Element.cpp:
239         (WebCore::adjustForLocalZoom):
240         * dom/Element.h:
241         * html/HTMLMediaElement.cpp:
242         * html/HTMLMediaElement.h:
243
244 2011-06-09  Kenneth Russell  <kbr@google.com>
245
246         Reviewed by Adam Barth.
247
248         Disallow use of cross-domain media (images, video) in WebGL
249         https://bugs.webkit.org/show_bug.cgi?id=62257
250
251         Updated WebGL implementation to track recent spec updates in this area.
252
253         Tests: http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html
254                http/tests/security/webgl-remote-read-remote-image-allowed.html
255                http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html
256
257         * html/canvas/CanvasRenderingContext.cpp:
258         (WebCore::CanvasRenderingContext::wouldTaintOrigin):
259         (WebCore::CanvasRenderingContext::checkOrigin):
260         * html/canvas/CanvasRenderingContext.h:
261         (WebCore::CanvasRenderingContext::checkOrigin):
262         * html/canvas/WebGLRenderingContext.cpp:
263         (WebCore::WebGLRenderingContext::readPixels):
264         (WebCore::WebGLRenderingContext::texImage2D):
265         (WebCore::WebGLRenderingContext::videoFrameToImage):
266         (WebCore::WebGLRenderingContext::texSubImage2D):
267         * html/canvas/WebGLRenderingContext.h:
268
269 2011-06-09  Adam Barth  <abarth@webkit.org>
270
271         Reviewed by Eric Seidel.
272
273         Add an ASSERT to HTMLTreeBuilder
274         https://bugs.webkit.org/show_bug.cgi?id=62403
275
276         This ASSERT was useful in investigating a re-entrancy bug.  We should
277         keep it.
278
279         * html/parser/HTMLTreeBuilder.cpp:
280         (WebCore::HTMLTreeBuilder::processEndOfFile):
281
282 2011-06-09  Dan Bernstein  <mitz@apple.com>
283
284         Reviewed by Darin Adler.
285
286         Fix a regression from r88478.
287
288         * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
289         (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Add the runs
290         in reverse order in the RTL case here, since the whole vector is reversed by collectComplexTextRuns()
291         afterwards.
292
293 2011-06-09  Julien Chaffraix  <jchaffraix@codeaurora.org>
294
295         Reviewed by Antti Koivisto.
296
297         REGRESSION(84329): Stylesheets on some pages do not load
298         https://bugs.webkit.org/show_bug.cgi?id=61400
299
300         Test: fast/css/link-disabled-attr.html
301
302         Fixed r84329: the change did not take into account the fact
303         that HTMLLinkElement did already contain the disabled information
304         and the 2 information were not linked as they should have!
305
306         The new logic pushes the information to the stylesheet as this
307         is what the spec mandates and what FF is doing. Also it keeps
308         one bit of information (that JS enabled the stylesheet) as it
309         is needed for the recalcStyleSelector logic.
310
311         * dom/Document.cpp:
312         (WebCore::Document::recalcStyleSelector): s/isDisabled/disabled.
313
314         * html/HTMLLinkElement.cpp:
315         (WebCore::HTMLLinkElement::HTMLLinkElement): Removed m_disabledState,
316         replaced by m_isEnabledViaScript.
317         (WebCore::HTMLLinkElement::setDisabled): Updated the logic after
318         m_disabledState removal. It also matches the spec by forwarding
319         the disabled state to our stylesheet if we have one.
320         (WebCore::HTMLLinkElement::parseMappedAttribute): Removed harmful
321         handling of the disabledAttr.
322         (WebCore::HTMLLinkElement::process): Updated after m_disabledState removal.
323         * html/HTMLLinkElement.h:
324         (WebCore::HTMLLinkElement::isEnabledViaScript): Ditto.
325         (WebCore::HTMLLinkElement::isAlternate): Ditto.
326
327 2011-06-09  Dan Bernstein  <mitz@apple.com>
328
329         Reviewed by Darin Adler.
330
331         Simplify ComplexTextController::collectComplexTextRuns()
332         https://bugs.webkit.org/show_bug.cgi?id=62387
333
334         No new test, since functionality is unchanged.
335
336         * platform/graphics/mac/ComplexTextController.cpp:
337         (WebCore::ComplexTextController::collectComplexTextRuns): Always iterate characters in logical order,
338         then reverse the run vector for RTL.
339
340 2011-06-09  Dimitri Glazkov  <dglazkov@chromium.org>
341
342         Reviewed by Kent Tamura.
343
344         Fold isShadowBoundary into isShadowRoot.
345         https://bugs.webkit.org/show_bug.cgi?id=62317
346
347         Since there are no longer cases where Node::isShadowBoundary() != Node::isShadowRoot, we can remove this function.
348
349         In one case where isShadowBoundary was also tested to find ShadowContentElemnt, added a new isContentElement function.
350
351         Refactoring, covered by existing tests.
352
353         * css/CSSStyleSelector.cpp:
354         (WebCore::isAtShadowBoundary): Changed to use isShadowRoot.
355         * dom/Element.cpp:
356         (WebCore::Element::isSpellCheckingEnabled): Ditto.
357         * dom/Node.cpp:
358         (WebCore::Node::nonBoundaryShadowTreeRootNode): Ditto.
359         (WebCore::Node::nonShadowBoundaryParentNode): Ditto.
360         * dom/Node.h:
361         (WebCore::Node::isContentElement): Added.
362         * dom/NodeRenderingContext.cpp:
363         (WebCore::NodeRenderingContext::NodeRenderingContext): Changed to use isShadowRoot.
364         * dom/Position.cpp:
365         (WebCore::Position::Position): Ditto.
366         * dom/ShadowContentElement.h:
367         (WebCore::ShadowContentElement::isContentElement): Added.
368         * dom/ShadowRoot.cpp:
369         (WebCore::ShadowRoot::hasContentElement): Changed to use isContentElement.
370         * editing/CompositeEditCommand.cpp:
371         (WebCore::CompositeEditCommand::insertNodeAfter): Changed to use isShadowRoot.
372         * editing/htmlediting.cpp:
373         (WebCore::visiblePositionBeforeNode): Ditto.
374         (WebCore::visiblePositionAfterNode): Ditto.
375         * page/DragController.cpp:
376         (WebCore::asFileInput): Ditto.
377         * rendering/RenderTreeAsText.cpp:
378         (WebCore::nodePosition): Ditto.
379
380 2011-06-09  Simon Fraser  <simon.fraser@apple.com>
381
382         Reviewed by Darin Adler.
383
384         Crashes in RenderLayerBacking::paintingGoesToWindow
385         https://bugs.webkit.org/show_bug.cgi?id=61159
386
387         Speculative fix for unreproducible crash that can occur when RenderObject::repaintUsingContainer()
388         finds a repaintContainer that is not the RenderView, but that is also not
389         composited (for unknown reasons), by checking to see if the layer is
390         compositing before using backing(). An assertion remains to try to catch
391         this in debug builds.
392
393         * rendering/RenderLayer.cpp:
394         (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
395
396 2011-06-09  Julien Chaffraix  <jchaffraix@webkit.org>
397
398         Reviewed by Darin Adler.
399
400         WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
401         https://bugs.webkit.org/show_bug.cgi?id=62384
402
403         Test: fast/css/webkit-keyframes-crash.html
404
405         * css/WebKitCSSKeyframesRule.cpp:
406         (WebCore::WebKitCSSKeyframesRule::setName): stylesheet() is never garanteed
407         to return a non-null pointer. Thus null-check here like the rest of the code.
408
409 2011-06-09  Julien Chaffraix  <jchaffraix@codeaurora.org>
410
411         Reviewed by David Hyatt.
412
413         chrome.dll!WebCore::RenderStyle::fontMetrics ReadAV@NULL (two crashes)
414         https://bugs.webkit.org/show_bug.cgi?id=57756
415
416         Tests: fast/css/fontMetric-border-radius-null-crash.html
417                fast/css/fontMetric-webkit-border-end-width-null-crash.html
418
419         * css/CSSStyleSelector.cpp:
420         (WebCore::CSSStyleSelector::styleForElement): Added a call to Font::update
421         so that our FontFallbackList is allocated if we ever need it when applying our
422         style rules.
423
424 2011-06-09  Cary Clark  <caryclark@google.com>
425
426         Reviewed by Eric Seidel.
427
428         Create local CG context for Mac UI elements when Skia is renderer
429         https://bugs.webkit.org/show_bug.cgi?id=62213
430
431         When building Mac Chrome using Skia as the WebKit renderer,
432         add state to LocalCurrentGraphicsContext to convert the SkCanvas
433         context passed by WebKit into the CGContext needed by UI
434         rendering.
435
436         No new tests.  The define typo in question is
437         not yet enabled, so this change has no functional
438         impact.
439
440         * platform/mac/LocalCurrentGraphicsContext.h:
441         Add SkiaBitLocker to create and release the converted CGContext.
442         Add ContextContainer, a class for Skia to create and release
443         the converted CGContext. If Skia is not used, the class has no effect.
444
445         * platform/mac/LocalCurrentGraphicsContext.mm:
446         (WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext):
447         When building with Skia, create the CGContext before passing it on.
448
449         (WebCore::LocalCurrentGraphicsContext::cgContext):
450         Get the CGContext from the SkiaBitLocker, or the saved context,
451         as appropriate.
452
453         * rendering/RenderThemeMac.mm:
454         Get the CGContext from Skia conversion or native, as appropriate.
455         Use the LocalCurrentGraphicsContext if there is one. Otherwise,
456         add a ContextContainer to house the SkCanvas to CGContext conversion.
457
458         (WebCore::RenderThemeMac::paintCapsLockIndicator):
459         (WebCore::RenderThemeMac::paintProgressBar):
460         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
461         (WebCore::RenderThemeMac::paintSliderTrack):
462         (WebCore::RenderThemeMac::paintMediaFullscreenButton):
463         (WebCore::RenderThemeMac::paintMediaMuteButton):
464         (WebCore::RenderThemeMac::paintMediaPlayButton):
465         (WebCore::RenderThemeMac::paintMediaSeekBackButton):
466         (WebCore::RenderThemeMac::paintMediaSeekForwardButton):
467         (WebCore::RenderThemeMac::paintMediaSliderTrack):
468         (WebCore::RenderThemeMac::paintMediaSliderThumb):
469         (WebCore::RenderThemeMac::paintMediaRewindButton):
470         (WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
471         (WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
472         (WebCore::RenderThemeMac::paintMediaControlsBackground):
473         (WebCore::RenderThemeMac::paintMediaCurrentTime):
474         (WebCore::RenderThemeMac::paintMediaTimeRemaining):
475         (WebCore::RenderThemeMac::paintMediaVolumeSliderContainer):
476         (WebCore::RenderThemeMac::paintMediaVolumeSliderTrack):
477         (WebCore::RenderThemeMac::paintMediaVolumeSliderThumb):
478
479 2011-06-02  Jer Noble  <jer.noble@apple.com>
480
481         Reviewed by Maciej Stachowiak.
482
483         REGRESSION: Page layout messed up after exiting full screen after video ends at jerryseinfeld.com
484         https://bugs.webkit.org/show_bug.cgi?id=61911
485         <rdar://problem/9523017>
486
487         Test: fullscreen/full-screen-video-offset.html
488
489         When the video element is taken full-screen in the new element full-screen API, return the
490         offset width and height of the placeholder renderer which is filling in for the full-screen
491         element.  To do so, override offsetWidth, Height, Left, and Top from Element.  These are
492         non-virtual functions, so make them virtual.
493
494         * dom/Element.cpp:
495         (WebCore::Element::adjustForLocalZoom): Made into a class-static function.
496         * dom/Element.h: Made offset functions virtual.
497         * html/HTMLMediaElement.cpp:
498         (WebCore::elementPlaceholder): Added; utility function.
499         (WebCore::HTMLMediaElement::offsetLeft): Added; virtual override of the 
500             Element function. Will be called directly via javascript.
501         (WebCore::HTMLMediaElement::offsetTop): Ditto.
502         (WebCore::HTMLMediaElement::offsetWidth): Ditto.
503         (WebCore::HTMLMediaElement::offsetHeight): Ditto.
504         * html/HTMLMediaElement.h:
505
506 2011-06-09  Dave Tapuska  <dtapuska@rim.com>
507
508         Reviewed by Daniel Bates.
509
510         PingLoader destructor could dereference 0 if the Resource
511         Handle creation failed.
512
513         https://bugs.webkit.org/show_bug.cgi?id=62304
514
515         * loader/PingLoader.cpp:
516         (WebCore::PingLoader::~PingLoader):
517
518 2011-06-08  Abhishek Arya  <inferno@chromium.org>
519
520         Reviewed by Ryosuke Niwa.
521
522         Make indexForVisiblePosition and isSelectableElement static.
523         https://bugs.webkit.org/show_bug.cgi?id=62329
524
525         This protects us when converting frame->selection->start() or end()
526         to VisiblePosition which blows away the RenderTextControl from
527         underneath (due to layout update).
528
529         Test: fast/forms/text-control-selection-crash.html
530
531         * accessibility/AccessibilityRenderObject.cpp:
532         (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
533         * rendering/RenderTextControl.cpp:
534         (WebCore::RenderTextControl::selectionStart):
535         (WebCore::RenderTextControl::selectionEnd):
536         (WebCore::RenderTextControl::isSelectableElement):
537         (WebCore::RenderTextControl::indexForVisiblePosition):
538         * rendering/RenderTextControl.h:
539
540 2011-06-09  Ben Murdoch  <benm@google.com>
541
542         Reviewed by Yury Semikhatsky.
543
544         Build break in ScriptProfile.cpp and inspector disabled.
545         https://bugs.webkit.org/show_bug.cgi?id=62373
546
547         No new tests - build fix only.
548
549         * bindings/v8/ScriptProfile.cpp: Add necessary guards.
550         * bindings/v8/ScriptProfile.h: ditto.
551
552 2011-06-09  Vsevolod Vlasov  <vsevik@chromium.org>
553
554         Reviewed by Yury Semikhatsky.
555
556         Web Inspector: Network panel preview tab does not reattach SourceFrame when switching between preview and response tabs.
557         https://bugs.webkit.org/show_bug.cgi?id=62298
558
559         * inspector/front-end/ResourcePreviewView.js:
560         (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown.callback):
561         (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown):
562
563 2011-06-09  Csaba Osztrogonác  <ossy@webkit.org>
564
565         [Qt][Mac] Speculative buildfix after r88286.
566
567         * platform/graphics/IntPoint.h:
568
569 2011-06-09  Mike Lawther  <mikelawther@chromium.org>
570
571         Reviewed by Kent Tamura.
572
573         Parsing issue with -webkit-calc
574         https://bugs.webkit.org/show_bug.cgi?id=62276
575
576         Set the CSSParserString for the calc functions.
577
578         Test: css3/calc/regression-62276.html
579
580         * css/CSSParser.cpp:
581         (WebCore::CSSParser::lex):
582
583 2011-06-09  Robert Hogan  <robert@webkit.org>
584
585         Reviewed by Andreas Kling.
586
587         Teach Qt about window.internals
588         https://bugs.webkit.org/show_bug.cgi?id=61074
589
590         A weakness of the Qt DRT setup is that things like JSContextRef are abstracted
591         away from the QtWebKit API so we need DumpRenderTreeSupportQt to access WebCore internals.
592         Since the window.internals object requires JSContextRef we need to implement it in DumpRenderTreeSupportQt
593         where we can access it. DumpRenderTreeSupportQt cannot be compiled outside Qt's WebCore and as it
594         is our only possible route into the WebCoreTestSupport class neither can the new window.internals plumbing.
595         Likewise we can't put the accessor in WebCoreTestSupport because it would then need to know about QWebFrame
596         and others. The only alternative seems like a compile time guard which we would have to teach the bots about.
597
598         * CodeGenerators.pri:
599         * WebCore.pri:
600         * WebCore.pro:
601
602 2011-06-08  Mikołaj Małecki  <m.malecki@samsung.com>
603
604         Reviewed by Pavel Feldman.
605
606         Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
607         https://bugs.webkit.org/show_bug.cgi?id=52791
608
609         No new tests. The problem can be reproduced by trying to create InspectorValue
610         from 1.0e-100 and call ->toJSONString() on this.
611
612         * inspector/InspectorValues.cpp:
613         (WebCore::InspectorBasicValue::writeJSON):
614         Added checking the predicted buffer size and choosing exponential format, or
615         eventually "NaN" if the buffer is too small for decimal format.
616
617 2011-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>
618
619         Unreviewed, rolling out r88387.
620         http://trac.webkit.org/changeset/88387
621         https://bugs.webkit.org/show_bug.cgi?id=62368
622
623         New tests introduced in 88387 fail on Leopard,GTK,Qt bots
624         (Requested by Ossy on #webkit).
625
626         * html/canvas/CanvasRenderingContext.cpp:
627         (WebCore::CanvasRenderingContext::checkOrigin):
628         * html/canvas/CanvasRenderingContext.h:
629         * html/canvas/WebGLRenderingContext.cpp:
630         (WebCore::WebGLRenderingContext::readPixels):
631         (WebCore::WebGLRenderingContext::texImage2D):
632         (WebCore::WebGLRenderingContext::videoFrameToImage):
633         (WebCore::WebGLRenderingContext::texSubImage2D):
634         * html/canvas/WebGLRenderingContext.h:
635
636 2011-06-09  Adam Barth  <abarth@webkit.org>
637
638         Reviewed by Eric Seidel.
639
640         Running script from attach can remove elements from the stack of open elements
641         https://bugs.webkit.org/show_bug.cgi?id=62160
642
643         When the tree build runs script synchronously, that script can remove
644         arbitrary elements from the stack of open elements.  We need to hold a
645         reference to |parent| in attach instead of rely upon the reference in
646         the stack of open elements.
647
648         Test: fast/parser/document-write-onload-clear.html
649
650         * html/parser/HTMLConstructionSite.cpp:
651         (WebCore::HTMLConstructionSite::attach):
652
653 2011-06-08  Luke Macpherson   <macpherson@chromium.org>
654
655         Reviewed by Eric Seidel.
656
657         Make CSSPrimitiveValue support cast to EVerticalAlign.
658         https://bugs.webkit.org/show_bug.cgi?id=62356
659
660         No new tests / refactoring only.
661
662         * css/CSSPrimitiveValueMappings.h:
663         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
664         (WebCore::CSSPrimitiveValue::operator EVerticalAlign):
665         * css/CSSStyleSelector.cpp:
666         (WebCore::CSSStyleSelector::applyProperty):
667
668 2011-06-08  Justin Novosad  <junov@chromium.org>
669
670         Reviewed by James Robinson.
671
672         [Chromium] Crash when closing a tab with accelerated 2d canvas
673         https://bugs.webkit.org/show_bug.cgi?id=62324
674         Upon graphics context destruction, it is important to signal skia
675         to abandon all of its resource handles.  This prevents a crash caused
676         by skia attempting to release resources that were in the destroyed
677         graphics context.
678
679         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
680         (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
681
682 2011-06-08  James Robinson  <jamesr@chromium.org>
683
684         Reviewed by Darin Fisher.
685
686         REGRESSION(88260): 10-50% performance regression across many page cyclers
687         https://bugs.webkit.org/show_bug.cgi?id=62349
688
689         r88260 fixed a font cache resource leak and lowered the inactive font cache threshold.  The latter caused a
690         significant performance regression across many chromium page cyclers, for example
691         http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/moz/report.html?history=50&rev=88279.
692
693         This restores the previous inactive font size thresholds to their previous values, but retains the font cleanup
694         logic.
695
696         * platform/graphics/FontCache.cpp:
697
698 2011-06-08  Hayato Ito  <hayato@chromium.org>
699
700         Reviewed by Dimitri Glazkov.
701
702         A forward/backward tab traversal now visits focusable elements in a shadow root.
703         https://bugs.webkit.org/show_bug.cgi?id=61410
704
705         Test: fast/dom/shadow/tab-order-iframe-and-shadow.html
706
707         Like a iframe element, a shadow host becomes a scope of
708         tabindex. That means all descendant elements in a shadow root are
709         skipped if the host node of the shadow root is not focusable.
710
711         The patch doesn't affect HTMLInputElement and HTMLTextAreaElement,
712         which uses a shadow root and do extra works in their focus()
713         method.
714
715         A shadow root's <content> is not considered in this patch.
716         That will be addressed in a following patch.
717
718         * page/FocusController.cpp:
719         (WebCore::shadowRoot):
720         (WebCore::isTreeScopeOwner):
721         (WebCore::FocusController::deepFocusableNode):
722         (WebCore::FocusController::advanceFocusInDocumentOrder):
723         (WebCore::FocusController::findFocusableNodeAcrossTreeScope):
724         (WebCore::FocusController::findFocusableNode):
725         (WebCore::FocusController::nextFocusableNode):
726         (WebCore::FocusController::previousFocusableNode):
727         (WebCore::FocusController::ownerOfTreeScope):
728         * page/FocusController.h:
729
730 2011-06-08  Hayato Ito  <hayato@chromium.org>
731
732         Reviewed by Hajime Morita.
733
734         Makes sure that document.activeElement won't be an element in shadow root.
735
736         https://bugs.webkit.org/show_bug.cgi?id=61413
737
738         Test: fast/dom/shadow/activeelement-should-be-shadowhost.html
739
740         * html/HTMLDocument.cpp:
741         (WebCore::focusedFrameOwnerElement):
742         (WebCore::HTMLDocument::activeElement):
743
744 2011-06-08  Kent Tamura  <tkent@chromium.org>
745
746         Reviewed by Dimitri Glazkov.
747
748         Allow drawing a slider thumb for any nodes.
749         https://bugs.webkit.org/show_bug.cgi?id=62196
750
751         RenderObject::node() should provide various information which is
752         necessary for rendering. We don't need to refer the parent renderer.
753
754         * dom/Node.cpp:
755         (WebCore::Node::focusDe1egate): Added.
756         * dom/Node.h: Added a declaration.
757         * html/shadow/MediaControlElements.cpp:
758         (WebCore::toParentMediaElement):
759           Added an overload of toParentMediaElement() with Node* parameter.
760         * html/shadow/MediaControlElements.h:
761         (WebCore::toParentMediaElement): ditto.
762         * html/shadow/SliderThumbElement.cpp:
763         (WebCore::SliderThumbElement::isEnabledFormControl):
764           Returns the status of the host node.
765         (WebCore::SliderThumbElement::isReadOnlyFormControl): ditto.
766         (WebCore::SliderThumbElement::focusDe1egate):
767           Returns the host node so that RenderTheme::isFocused() returns true.
768         (WebCore::SliderThumbElement::detach): Style nit.
769         (WebCore::SliderThumbElement::hostInput):
770           Make it const because it is called by const functions.
771         * html/shadow/SliderThumbElement.h:
772           - Remove inDragMode()
773           - Update declarations
774         * platform/qt/RenderThemeQt.cpp:
775         (WebCore::RenderThemeQt::paintMediaSliderThumb):
776           Use Node::shadowAncestorNode() instead of RenderObject::parent() to
777           support deeper thumb nodes.
778         * rendering/RenderMediaControlsChromium.cpp:
779         (WebCore::paintMediaSliderThumb): ditto.
780         (WebCore::paintMediaVolumeSliderThumb): Remove isSlider() check.
781         * rendering/RenderSlider.cpp:
782         (WebCore::RenderSlider::inDragMode):
783           SliderThumbElement::inDragMode() was removed, and Node::active() has
784           the same information.
785         * rendering/RenderTheme.cpp:
786         (WebCore::RenderTheme::paint): Remove isSlider() checks.
787         (WebCore::RenderTheme::isFocused): Apply Node::focusDelegate().
788         * rendering/RenderThemeChromiumLinux.cpp:
789         (WebCore::RenderThemeChromiumLinux::paintSliderThumb):
790           isPressed() is enough.
791         * rendering/RenderThemeChromiumWin.cpp:
792           isEnabled(), isFocused(), and isPressed() are enough.
793         (WebCore::RenderThemeChromiumWin::determineSliderThumbState):
794         (WebCore::RenderThemeChromiumWin::determineClassicState):
795         * rendering/RenderThemeMac.mm:
796         (WebCore::RenderThemeMac::paintSliderThumb):
797           - Remove isSlider() check.
798           - Passing 'o' to udpateFooState functions is enough.
799           - isPressed() is enough.
800         * rendering/RenderThemeSafari.cpp:
801         (WebCore::RenderThemeSafari::paintSliderThumb):
802           We don't need special handling anymore.
803         * rendering/RenderThemeWin.cpp:
804         (WebCore::RenderThemeWin::determineSliderThumbState):
805           isEnabled(), isFocused(), and isPressed() are enough.
806
807 2011-06-08  Adam Barth  <abarth@webkit.org>
808
809         Reviewed by Eric Seidel.
810
811         constructTreeFromToken can re-enter parser, causing ASSERTs
812         https://bugs.webkit.org/show_bug.cgi?id=62160
813
814         This patch clears the HTMLToken before constructing the tree from the
815         token, putting the HTMLDocumentParser in a good state to be re-entered.
816
817         Tests: fast/parser/document-write-onload-nesting.html
818                fast/parser/document-write-onload-ordering.html
819
820         * html/parser/HTMLDocumentParser.cpp:
821         (WebCore::HTMLDocumentParser::pumpTokenizer):
822         * html/parser/HTMLToken.h:
823         (WebCore::HTMLToken::isUninitialized):
824         * html/parser/HTMLTreeBuilder.cpp:
825         (WebCore::HTMLTreeBuilder::constructTreeFromToken):
826
827 2011-06-08  Kent Tamura  <tkent@chromium.org>
828
829         Fix Qt build for r88405.
830         https://bugs.webkit.org/show_bug.cgi?id=62208
831
832         * platform/qt/RenderThemeQt.h:
833
834 2011-06-08  Kent Tamura  <tkent@chromium.org>
835
836         Reviewed by Dimitri Glazkov.
837
838         Change the argument of RenderTheme::adjustSliderThumbSize(): RenderObject* -> RenderStyle*
839         https://bugs.webkit.org/show_bug.cgi?id=62208
840
841         Change the argument type of RenderTheme::adjustSliderThumbSize() and
842         RenderMediaControls::adjustMediaSliderThumbSize() from RenderObject* to RenderStyle*.
843
844         Also, each of adjustSliderThumbStyle() overrides calls RenderTheme::
845         adjustSliderThumbStyle() for future changes.
846
847         No new tests. This is a refactoring and should not change any behavior.
848
849         * html/shadow/SliderThumbElement.cpp:
850         (WebCore::RenderSliderThumb::layout): Passing RenderStyle* and remove a FIXME comment.
851         * platform/efl/RenderThemeEfl.cpp:
852         (WebCore::RenderThemeEfl::adjustSliderThumbStyle): Calls RenderTheme::adjustSliderThumbStyle().
853         * platform/gtk/RenderThemeGtk.cpp:
854         (WebCore::RenderThemeGtk::adjustSliderThumbStyle): ditto.
855         (WebCore::RenderThemeGtk::adjustMediaSliderThumbSize):
856         * platform/gtk/RenderThemeGtk.h:
857         * platform/gtk/RenderThemeGtk2.cpp:
858         (WebCore::RenderThemeGtk::adjustSliderThumbSize):
859         * platform/gtk/RenderThemeGtk3.cpp:
860         (WebCore::RenderThemeGtk::adjustSliderThumbSize):
861         * platform/qt/RenderThemeQt.cpp:
862         (WebCore::RenderThemeQt::adjustSliderThumbStyle): ditto.
863         (WebCore::RenderThemeQt::adjustSliderThumbSize):
864         * rendering/RenderMediaControls.cpp:
865         (WebCore::RenderMediaControls::adjustMediaSliderThumbSize):
866         * rendering/RenderMediaControls.h:
867         * rendering/RenderMediaControlsChromium.cpp:
868         (WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize):
869         * rendering/RenderMediaControlsChromium.h:
870         * rendering/RenderSlider.cpp:
871         (WebCore::RenderSlider::layout): Passing RenderStyle* and remove a FIXME comment.
872         * rendering/RenderTheme.cpp:
873         (WebCore::RenderTheme::adjustSliderThumbStyle): Add a comment.
874         (WebCore::RenderTheme::adjustSliderThumbSize):
875         * rendering/RenderTheme.h:
876         * rendering/RenderThemeChromiumLinux.cpp:
877         (WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
878         * rendering/RenderThemeChromiumLinux.h:
879         * rendering/RenderThemeChromiumMac.h:
880         * rendering/RenderThemeChromiumMac.mm:
881         (WebCore::RenderThemeChromiumMac::adjustMediaSliderThumbSize):
882         * rendering/RenderThemeChromiumSkia.cpp:
883         (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):
884         * rendering/RenderThemeChromiumSkia.h:
885         * rendering/RenderThemeChromiumWin.cpp:
886         (WebCore::RenderThemeChromiumWin::adjustSliderThumbSize):
887         * rendering/RenderThemeChromiumWin.h:
888         * rendering/RenderThemeMac.h:
889         * rendering/RenderThemeMac.mm:
890         (WebCore::RenderThemeMac::adjustSliderThumbStyle): Calls RenderTheme::adjustSliderThumbStyle().
891         (WebCore::RenderThemeMac::adjustSliderThumbSize):
892         (WebCore::RenderThemeMac::adjustMediaSliderThumbSize):
893         * rendering/RenderThemeSafari.cpp:
894         (WebCore::RenderThemeSafari::adjustSliderThumbStyle): Calls RenderTheme::adjustSliderThumbStyle().
895         (WebCore::RenderThemeSafari::adjustSliderThumbSize):
896         * rendering/RenderThemeSafari.h:
897         * rendering/RenderThemeWin.cpp:
898         (WebCore::RenderThemeWin::adjustSliderThumbSize):
899         * rendering/RenderThemeWin.h:
900         * rendering/RenderThemeWinCE.cpp:
901         (WebCore::RenderThemeWinCE::adjustSliderThumbSize):
902         * rendering/RenderThemeWinCE.h:
903
904 2011-06-08  Brian Salomon  <bsalomon@google.com>
905
906         Reviewed by James Robinson.
907
908         Avoid always binding FBO 0 implicitly when deleting FBO in DrawingBuffer code because it invalidates Ganesh's cache of the current FBO.
909         https://bugs.webkit.org/show_bug.cgi?id=62318
910
911         Chromium-only crash
912         Failures takes multiple seconds to occur, relying on JS garbage-collection to occur 
913         http://www.hotbazooka.com/privatejoe-large
914
915         * platform/graphics/gpu/DrawingBuffer.cpp:
916         (WebCore::DrawingBuffer::clear):
917
918 2011-06-08  Emil A Eklund  <eae@chromium.org>
919
920         Reviewed by Eric Seidel.
921
922         RenderEmbeddedObject::getReplacementTextGeometry
923         https://bugs.webkit.org/show_bug.cgi?id=62313
924
925         Replace the last use of tx, ty with IntPoint.
926
927         Covered by existing tests.
928
929         * platform/graphics/FloatRect.h:
930         (WebCore::FloatRect::move):
931         (WebCore::FloatRect::moveBy):
932         * rendering/RenderEmbeddedObject.cpp:
933         (WebCore::RenderEmbeddedObject::paintReplaced):
934         (WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
935         (WebCore::RenderEmbeddedObject::isInMissingPluginIndicator):
936         * rendering/RenderEmbeddedObject.h:
937
938 2011-06-08  Tim Horton  <timothy_horton@apple.com>
939
940         Reviewed by Ryosuke Niwa.
941
942         Use correct CFURLStorageSessionRef definition on Leopard, as
943         we created an inconsistency in const-ness between
944         WebCoreSystemInterface.h and these two files in the case
945         of Leopard only.
946         https://bugs.webkit.org/show_bug.cgi?id=62223
947
948         * platform/network/ResourceHandle.h:
949         * platform/network/cf/ResourceRequest.h:
950
951 2011-06-08  Sailesh Agrawal  <sail@chromium.org>
952
953         Reviewed by Mihai Parparita.
954
955         Chromium Mac: Enable overlay scrollbars
956         https://bugs.webkit.org/show_bug.cgi?id=59756
957
958         Sync ScrollbarThemeChromiumMac.mm/.h with ScrollbarThemeMac.mm to pick up support for overlay scrollbars. The only changes are renaming ScrollbarThemeMac to ScrollbarThemeChromiumMac and using runtime checks instead of #ifdef's.
959
960         No new tests, since this code is only enabled on future versions of Mac OS X.
961
962         * platform/chromium/ScrollAnimatorChromiumMac.mm: All changes to this file except in scroll() were to swap #if USE(WK_SCROLLBAR_PAINTER) with runtime checks.
963         (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac):
964         (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac):
965         (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged):
966         (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint):
967         (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea):
968         (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea):
969         (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea):
970         (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize):
971         (WebCore::ScrollAnimatorChromiumMac::contentsResized):
972         (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize):
973         (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow):
974         (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide):
975         (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture):
976         (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture):
977         (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar):
978         (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar):
979         (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar):
980         (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar):
981         (WebCore::ScrollAnimatorChromiumMac::cancelAnimations):
982         * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
983         (preferredScrollerStyle): Disabled overlay scrollbar styles due to trailing artifacts.
984         (wkScrollbarPainterPaint): Fixed a problem where the scrollbar track wasn't being drawn.
985         (wkScrollbarPainterKnobRect): Implemented a previously unimplemented function.
986         (wkSetScrollbarPainterKnobStyle): Implemented a function that's now supported by the latest Mac OS X seeds.
987         (isScrollbarOverlayAPIAvailable): Enabled new scrollbar code.
988         * platform/chromium/ScrollbarThemeChromiumMac.h:
989         * platform/chromium/ScrollbarThemeChromiumMac.mm: Sync with ScrollbarThemeMac.mm.
990         (WebCore::scrollbarMap):
991         (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
992         (WebCore::updateArrowPlacement):
993         (WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
994         (WebCore::ScrollbarThemeChromiumMac::unregisterScrollbar):
995         (WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
996         (WebCore::ScrollbarThemeChromiumMac::painterForScrollbar):
997         (WebCore::ScrollbarThemeChromiumMac::scrollbarThickness):
998         (WebCore::ScrollbarThemeChromiumMac::usesOverlayScrollbars):
999         (WebCore::ScrollbarThemeChromiumMac::hasButtons):
1000         (WebCore::ScrollbarThemeChromiumMac::hasThumb):
1001         (WebCore::buttonRepaintRect):
1002         (WebCore::ScrollbarThemeChromiumMac::minimumThumbLength):
1003         (WebCore::ScrollbarThemeChromiumMac::shouldDragDocumentInsteadOfThumb):
1004         (WebCore::toScrollbarPainterKnobStyle):
1005         (WebCore::ScrollbarThemeChromiumMac::paint):
1006
1007 2011-06-06  Nate Chapin  <japhet@chromium.org>
1008
1009         Reviewed by Adam Barth.
1010
1011         Remove all knowledge of CachedResourceRequests from
1012         CachedResourceLoader. This puts the full burden of
1013         canceling these requests on DocumentLoader (via
1014         SubresourceLoader), and makes a CachedResourceRequest
1015         an OwnPtr in CachedResource.
1016
1017         https://bugs.webkit.org/show_bug.cgi?id=62308
1018
1019         * loader/FrameLoader.cpp:
1020         (WebCore::FrameLoader::stopLoading):
1021         * loader/cache/CachedResource.cpp:
1022         (WebCore::CachedResource::CachedResource):
1023         (WebCore::CachedResource::load):
1024         (WebCore::CachedResource::stopLoading):
1025         * loader/cache/CachedResource.h:
1026         * loader/cache/CachedResourceLoader.cpp:
1027         (WebCore::CachedResourceLoader::~CachedResourceLoader):
1028         (WebCore::CachedResourceLoader::loadDone):
1029         * loader/cache/CachedResourceLoader.h:
1030         * loader/cache/CachedResourceRequest.cpp:
1031         (WebCore::CachedResourceRequest::CachedResourceRequest):
1032         (WebCore::CachedResourceRequest::~CachedResourceRequest):
1033         (WebCore::CachedResourceRequest::load):
1034         (WebCore::CachedResourceRequest::didFinishLoading):
1035         (WebCore::CachedResourceRequest::didFail):
1036         (WebCore::CachedResourceRequest::didReceiveResponse):
1037         (WebCore::CachedResourceRequest::end):
1038         * loader/cache/CachedResourceRequest.h:
1039
1040 2011-06-08  Mike Reed  <reed@google.com>
1041
1042         Reviewed by James Robinson.
1043
1044         [Skia] check for null-shader from gradient factory
1045         https://bugs.webkit.org/show_bug.cgi?id=62319
1046
1047         * platform/graphics/skia/GradientSkia.cpp:
1048         (WebCore::Gradient::platformDestroy):
1049         (WebCore::Gradient::platformGradient):
1050
1051 2011-06-08  Kenneth Russell  <kbr@google.com>
1052
1053         Reviewed by Adam Barth.
1054
1055         Disallow use of cross-domain media (images, video) in WebGL
1056         https://bugs.webkit.org/show_bug.cgi?id=62257
1057
1058         Updated WebGL implementation to track recent spec updates in this area.
1059
1060         Tests: http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html
1061                http/tests/security/webgl-remote-read-remote-image-allowed.html
1062                http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html
1063
1064         * html/canvas/CanvasRenderingContext.cpp:
1065         (WebCore::CanvasRenderingContext::wouldTaintOrigin):
1066         (WebCore::CanvasRenderingContext::checkOrigin):
1067         * html/canvas/CanvasRenderingContext.h:
1068         (WebCore::CanvasRenderingContext::checkOrigin):
1069         * html/canvas/WebGLRenderingContext.cpp:
1070         (WebCore::WebGLRenderingContext::readPixels):
1071         (WebCore::WebGLRenderingContext::texImage2D):
1072         (WebCore::WebGLRenderingContext::videoFrameToImage):
1073         (WebCore::WebGLRenderingContext::texSubImage2D):
1074         * html/canvas/WebGLRenderingContext.h:
1075
1076 2011-06-08  John Bauman  <jbauman@chromium.org>
1077
1078         Reviewed by James Robinson.
1079
1080         Only draw portions of tiles in contentRect
1081         https://bugs.webkit.org/show_bug.cgi?id=62243
1082
1083         Old garbage data can remain in tiles, so make sure to draw only those
1084         portions that are supposed to be drawn.
1085
1086         Test: compositing/repaint/shrink-layer.html
1087
1088         * platform/graphics/chromium/LayerTilerChromium.cpp:
1089         (WebCore::LayerTilerChromium::draw):
1090
1091 2011-06-08  Emil A Eklund  <eae@chromium.org>
1092
1093         Reviewed by Eric Seidel.
1094
1095         Convert RenderBlock::isPointInOverflowControl to IntPoint
1096         https://bugs.webkit.org/show_bug.cgi?id=62312
1097
1098         Covered by existing tests.
1099
1100         * rendering/RenderBlock.cpp:
1101         (WebCore::RenderBlock::isPointInOverflowControl):
1102         (WebCore::RenderBlock::nodeAtPoint):
1103         * rendering/RenderBlock.h:
1104         * rendering/RenderListBox.cpp:
1105         (WebCore::RenderListBox::isPointInOverflowControl):
1106         * rendering/RenderListBox.h:
1107
1108 2011-06-08  James Simonsen  <simonjam@chromium.org>
1109
1110         Reviewed by Tony Gentilcore.
1111
1112         Fix clang issue, virtual function const mismatch
1113         https://bugs.webkit.org/show_bug.cgi?id=62307
1114
1115         No new tests. Built with clang & ran layout tests.
1116
1117         * page/MediaStreamFrameController.h:
1118         (WebCore::MediaStreamFrameController::GenericClient::isGenericClient):
1119
1120 2011-06-08  Chris Rogers  <crogers@google.com>
1121
1122         Reviewed by Kenneth Russell.
1123
1124         Implement BiquadFilterNode for filter types: LOWPASS, HIGHPASS, BANDPASS, LOWSHELF, HIGHSHELF, PEAKING, NOTCH, ALLPASS
1125         https://bugs.webkit.org/show_bug.cgi?id=62078
1126
1127         No new tests since audio API is not yet implemented.
1128
1129         * DerivedSources.make:
1130         * WebCore.gypi:
1131         * WebCore.xcodeproj/project.pbxproj:
1132         * platform/audio/Biquad.cpp:
1133         (WebCore::Biquad::Biquad):
1134         (WebCore::Biquad::reset):
1135         (WebCore::Biquad::setLowpassParams):
1136         (WebCore::Biquad::setHighpassParams):
1137         (WebCore::Biquad::setNormalizedCoefficients):
1138         (WebCore::Biquad::setLowShelfParams):
1139         (WebCore::Biquad::setHighShelfParams):
1140         (WebCore::Biquad::setPeakingParams):
1141         (WebCore::Biquad::setAllpassParams):
1142         (WebCore::Biquad::setNotchParams):
1143         (WebCore::Biquad::setBandpassParams):
1144         (WebCore::Biquad::setZeroPolePairs):
1145         (WebCore::Biquad::setAllpassPole):
1146         * platform/audio/Biquad.h:
1147         * webaudio/AudioContext.cpp:
1148         (WebCore::AudioContext::createBiquadFilter):
1149         (WebCore::AudioContext::createLowPass2Filter):
1150         (WebCore::AudioContext::createHighPass2Filter):
1151         * webaudio/AudioContext.h:
1152         * webaudio/AudioContext.idl:
1153         * webaudio/AudioNode.h:
1154         * webaudio/BiquadDSPKernel.cpp:
1155         (WebCore::BiquadDSPKernel::process):
1156         * webaudio/BiquadFilterNode.cpp: Added.
1157         (WebCore::BiquadFilterNode::BiquadFilterNode):
1158         * webaudio/BiquadFilterNode.h: Added.
1159         (WebCore::BiquadFilterNode::create):
1160         (WebCore::BiquadFilterNode::type):
1161         (WebCore::BiquadFilterNode::setType):
1162         (WebCore::BiquadFilterNode::frequency):
1163         (WebCore::BiquadFilterNode::q):
1164         (WebCore::BiquadFilterNode::gain):
1165         (WebCore::BiquadFilterNode::biquadProcessor):
1166         * webaudio/BiquadFilterNode.idl: Added.
1167         * webaudio/BiquadProcessor.cpp:
1168         (WebCore::BiquadProcessor::BiquadProcessor):
1169         * webaudio/BiquadProcessor.h:
1170         (WebCore::BiquadProcessor::setType):
1171         * webaudio/HighPass2FilterNode.cpp:
1172         (WebCore::HighPass2FilterNode::HighPass2FilterNode):
1173         * webaudio/LowPass2FilterNode.cpp:
1174         (WebCore::LowPass2FilterNode::LowPass2FilterNode):
1175
1176 2011-06-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
1177
1178         Reviewed by Kenneth Rohde Christiansen.
1179
1180         WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
1181         https://bugs.webkit.org/show_bug.cgi?id=61694
1182
1183         No new tests, code path is not activated yet.
1184
1185         * WebCore.xcodeproj/project.pbxproj: Changed the TransformOperation subclassed from "project" to "private"
1186
1187 2011-06-08  Tom Sepez  <tsepez@chromium.org>
1188
1189         Reviewed by Adam Barth.
1190
1191         Cause checks for insecure content blocking policy to callback to client.
1192         https://bugs.webkit.org/show_bug.cgi?id=61946
1193         Tests: platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed.html
1194                platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked.html
1195                platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-allowed.html
1196                platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-blocked.html
1197
1198         * loader/FrameLoader.cpp:
1199         (WebCore::FrameLoader::checkIfDisplayInsecureContent):
1200         (WebCore::FrameLoader::checkIfRunInsecureContent):
1201         * loader/FrameLoaderClient.h:
1202         (WebCore::FrameLoaderClient::allowDisplayingInsecureContent):
1203         (WebCore::FrameLoaderClient::allowRunningInsecureContent):
1204
1205 2011-06-08  Kevin Ollivier  <kevino@theolliviers.com>
1206
1207         [wx] Build fix after introduction of FontCache::ShouldRetain
1208
1209         * platform/graphics/wx/FontCacheWx.cpp:
1210         (WebCore::FontCache::getFontDataForCharacters):
1211
1212 2011-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
1213
1214         Unreviewed, rolling out r88365.
1215         http://trac.webkit.org/changeset/88365
1216         https://bugs.webkit.org/show_bug.cgi?id=62301
1217
1218         windows bots broken (Requested by loislo_ on #webkit).
1219
1220         * inspector/InspectorValues.cpp:
1221         (WebCore::InspectorBasicValue::writeJSON):
1222
1223 2011-06-08  Mikołaj Małecki  <m.malecki@samsung.com>
1224
1225         Reviewed by Pavel Feldman.
1226
1227         Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
1228         https://bugs.webkit.org/show_bug.cgi?id=52791
1229
1230         No new tests. The problem can be reproduced by trying to create InspectorValue
1231         from 1.0e-100 and call ->toJSONString() on this.
1232
1233         * inspector/InspectorValues.cpp:
1234         (WebCore::InspectorBasicValue::writeJSON):
1235         Added checking the predicted buffer size and choosing exponential format, or
1236         eventually "NaN" if the buffer is too small for decimal format.
1237
1238 2011-06-08  Nico Weber  <thakis@chromium.org>
1239
1240         Reviewed by Darin Adler.
1241
1242         Fix a ?: precedence error in ScrollbarThemeMac and ScrollbarThemeChromium
1243         https://bugs.webkit.org/show_bug.cgi?id=62295
1244
1245         This was found by a new warning recently added to clang's -Wparentheses
1246
1247         * platform/chromium/ScrollbarThemeChromiumMac.mm:
1248         (WebCore::ScrollbarThemeChromiumMac::backButtonRect):
1249         * platform/mac/ScrollbarThemeMac.mm:
1250         (WebCore::ScrollbarThemeMac::backButtonRect):
1251
1252 2011-06-08  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1253
1254         Reviewed by Andreas Kling.
1255
1256         [Qt] Remove dead code from our JSC bridge
1257         https://bugs.webkit.org/show_bug.cgi?id=62287
1258
1259         The m_defaultMethod member is not used since r36848 and QtMethod
1260         was replaced by QtRuntimeMethod and subclasses in r29729.
1261
1262         * bridge/qt/qt_instance.cpp:
1263         (JSC::Bindings::QtInstance::removeCachedMethod):
1264         (JSC::Bindings::QtInstance::visitAggregate):
1265         * bridge/qt/qt_instance.h:
1266         * bridge/qt/qt_runtime.h:
1267
1268 2011-06-08  Ryan Sleevi  <rsleevi@chromium.org>
1269
1270         Reviewed by Tony Chang.
1271
1272         Suppress C++0x compat warnings when compiling Chromium port with GCC 4.6
1273
1274         Compiling Chromium port under GCC 4.6 produces warnings about nullptr
1275         https://bugs.webkit.org/show_bug.cgi?id=62242
1276
1277         * WebCore.gyp/WebCore.gyp:
1278
1279 2011-05-25  Xiaomei Ji  <xji@chromium.org>
1280
1281         Reviewed by Ryosuke Niwa.
1282
1283         --webkit-visual-word does not work well in words separated by multiple spaces
1284         https://bugs.webkit.org/show_bug.cgi?id=61324
1285
1286         Remove positionBeforeNextWord and positionAfterPreviousWord short-cuts. They try to find the
1287         right word boundary (before the space or after the space) by using previousWordPosition and
1288         nextWordPosition. But they assume words are separated by single space and are not correct 
1289         for words separated by multiple spaces and words not separated by space.
1290
1291         Consider positionBeforeNextWord() for example, 
1292
1293         First, it checks whether the current position is after the current word by checking current
1294         position's previousWordPosition's nextWordPosition is the same as current position, which is
1295         wrong for words separated by multiple spaces. For example, given words A and B separated by 
1296         3 continuous spaces "A   B", position "A|", "A |", and "A  |" should all be considered as 
1297         position after current word. But for position "A |", its previousWordPosition's 
1298         nextWordPosition is position "A|", which is different from its current position, so the
1299         current position is not considered as a position after current word, consequently,
1300         instead of returning the right position as "A   |B", positionBeforeNextWord returns the
1301         position before next next word, as "A   B |C". Similar happens for position "A  |".
1302
1303         Second, given 3 Chinese words "ABC" that are not segmented by space, when cursor is at 
1304         "A|BC", positionBeforeNextWord() returns the same position after calling current position's
1305         nextWordPosition's previousWordPosition. It should returns position "AB|C".
1306
1307         For those cases, we will have to collect all the word breaks inside the box and look for
1308         the one at left or right of current position.
1309
1310         * editing/visible_units.cpp:
1311         (WebCore::leftWordPosition):
1312         (WebCore::rightWordPosition):
1313
1314 2011-06-08  Greg Simon  <gregsimon@chromium.org>
1315
1316         Reviewed by Dimitri Glazkov.
1317
1318         Control Indexeddb backends from LayoutTestController
1319         https://bugs.webkit.org/show_bug.cgi?id=61000
1320
1321         Test: storage/indexeddb/migrate-basics.html
1322
1323         * storage/IDBBackingStore.h:
1324         * storage/IDBFactoryBackendImpl.cpp:
1325         (WebCore::IDBFactoryBackendImpl::open):
1326         (WebCore::IDBFactoryBackendImpl::migrate):
1327         * storage/IDBFactoryBackendImpl.h:
1328         * storage/IDBFactoryBackendInterface.h:
1329         * storage/IDBLevelDBBackingStore.cpp:
1330         (WebCore::IDBLevelDBBackingStore::backingStoreExists):
1331         * storage/IDBLevelDBBackingStore.h:
1332         (WebCore::IDBLevelDBBackingStore::backingStoreType):
1333         * storage/IDBSQLiteBackingStore.cpp:
1334         (WebCore::IDBSQLiteBackingStore::backingStoreExists):
1335         * storage/IDBSQLiteBackingStore.h:
1336         (WebCore::IDBSQLiteBackingStore::backingStoreType):
1337
1338 2011-06-08  Dmitry Lomov  <dslomov@google.com>
1339
1340         Reviewed by Adam Barth.
1341
1342         https://bugs.webkit.org/show_bug.cgi?id=62164
1343         Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and friends
1344         This functionality is untested and unused:
1345         This is an old code from Lockers-based implementation of WebWorkers in
1346         V8 bindings, to make sure that DOM objects are released on the right thread
1347         even though GC could have happened on any thread. It is currently unused (since
1348         current model is one worker per process) and is being removed because new implementation
1349         of WebWorkers will be using V8 isolates.
1350
1351         * WebCore.gypi:
1352         * WebCore.pro:
1353         * bindings/v8/ChildThreadDOMData.cpp: Removed.
1354         * bindings/v8/ChildThreadDOMData.h: Removed.
1355         * bindings/v8/DOMData.cpp:
1356         (WebCore::DOMData::DOMData):
1357         (WebCore::DOMData::getCurrent):
1358         (WebCore::DOMData::getMainThreadStore):
1359         * bindings/v8/DOMData.h:
1360         (WebCore::DOMData::getStore):
1361         (WebCore::DOMData::getCurrentMainThreadStore):
1362         (WebCore::DOMData::handleWeakObject):
1363         * bindings/v8/DOMDataStore.cpp:
1364         (WebCore::DOMDataStore::DOMDataStore):
1365         (WebCore::DOMDataStore::~DOMDataStore):
1366         (WebCore::DOMDataStore::weakNodeCallback):
1367         * bindings/v8/DOMDataStore.h:
1368         * bindings/v8/MainThreadDOMData.cpp: Removed.
1369         * bindings/v8/MainThreadDOMData.h: Removed.
1370         * bindings/v8/V8DOMMap.cpp:
1371         (WebCore::getDOMDataStore):
1372         (WebCore::removeAllDOMObjects):
1373         (WebCore::visitDOMNodes):
1374         (WebCore::visitDOMObjects):
1375         (WebCore::visitActiveDOMObjects):
1376         (WebCore::visitDOMSVGElementInstances):
1377         * bindings/v8/V8DOMMap.h:
1378         * bindings/v8/V8GCController.cpp:
1379         (WebCore::V8GCController::gcPrologue):
1380         (WebCore::V8GCController::gcEpilogue):
1381         * bindings/v8/WorkerScriptController.cpp:
1382         (WebCore::WorkerScriptController::~WorkerScriptController):
1383
1384 2011-06-08  Yael Aharon  <yael.aharon@nokia.com>
1385
1386         Reviewed by Andreas Kling.
1387
1388         [Qt] Build fix for building QtWebKit inside of Qt.
1389         https://bugs.webkit.org/show_bug.cgi?id=62280
1390
1391         Remove CONFIG=staticlib, because it causes the configure script to add -lwebcore
1392         into QtWebKit.prl.
1393
1394         No new tests, as this is just a build fix.
1395
1396         * WebCore.pri:
1397
1398 2011-06-08  Vsevolod Vlasov  <vsevik@chromium.org>
1399
1400         Reviewed by Pavel Feldman.
1401
1402         Web Inspector: Render non-document HTML resources as HTML
1403         https://bugs.webkit.org/show_bug.cgi?id=58886
1404
1405         * English.lproj/localizedStrings.js:
1406         * WebCore.gypi:
1407         * WebCore.vcproj/WebCore.vcproj:
1408         * inspector/front-end/NetworkItemView.js:
1409         (WebInspector.NetworkItemView):
1410         * inspector/front-end/Resource.js:
1411         (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
1412         (WebInspector.Resource.prototype.hasErrorStatusCode):
1413         * inspector/front-end/ResourceHTMLView.js: Added.
1414         (WebInspector.ResourceHTMLView):
1415         (WebInspector.ResourceHTMLView.prototype.hasContent):
1416         (WebInspector.ResourceHTMLView.prototype.show):
1417         (WebInspector.ResourceHTMLView.prototype.hide):
1418         (WebInspector.ResourceHTMLView.prototype._createIFrame):
1419         * inspector/front-end/ResourcePreviewView.js: Added.
1420         (WebInspector.ResourcePreviewView):
1421         (WebInspector.ResourcePreviewView.prototype.hasContent):
1422         (WebInspector.ResourcePreviewView.prototype.show):
1423         (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown.callback):
1424         (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown):
1425         (WebInspector.ResourcePreviewView.prototype._createInnerView):
1426         * inspector/front-end/Settings.js:
1427         (WebInspector.Settings):
1428         * inspector/front-end/WebKit.qrc:
1429         * inspector/front-end/inspector.css:
1430         (.resource-view.html iframe):
1431         * inspector/front-end/inspector.html:
1432
1433 2011-05-18  Pavel Podivilov  <podivilov@chromium.org>
1434
1435         Reviewed by Yury Semikhatsky.
1436
1437         Web Inspector: hide script location to ui location conversion details from ScriptsPanel.
1438         https://bugs.webkit.org/show_bug.cgi?id=61035
1439
1440         * inspector/front-end/DebuggerPresentationModel.js:
1441         (WebInspector.DebuggerPresentationModel.prototype.sourceFileForScriptURL):
1442         (WebInspector.DebuggerPresentationModel.prototype.scriptLocationToUILocation.didRequestSourceMapping):
1443         (WebInspector.DebuggerPresentationModel.prototype.scriptLocationToUILocation):
1444         * inspector/front-end/ScriptsPanel.js:
1445         (WebInspector.ScriptsPanel.prototype.showAnchorLocation.didGetUILocation):
1446         (WebInspector.ScriptsPanel.prototype.showAnchorLocation):
1447
1448 2011-06-08  Tommy Widenflycht  <tommyw@google.com>
1449
1450         Reviewed by Tony Gentilcore.
1451
1452         StreamEvent
1453
1454         Media Stream PeerConnection API: adding StreamEvent class
1455         https://bugs.webkit.org/show_bug.cgi?id=61537
1456
1457         Tests for the Media Stream API will be provided by the bug 56587.
1458
1459         * CMakeLists.txt:
1460         * CodeGenerators.pri:
1461         * DerivedSources.cpp:
1462         * DerivedSources.make:
1463         * GNUmakefile.list.am:
1464         * WebCore.gypi:
1465         * WebCore.pro:
1466         * WebCore.vcproj/WebCore.vcproj:
1467         * WebCore.xcodeproj/project.pbxproj:
1468         * bindings/js/JSEventCustom.cpp:
1469         (WebCore::toJS):
1470         * bindings/v8/custom/V8EventCustom.cpp:
1471         (WebCore::toV8):
1472         * dom/DOMAllInOne.cpp:
1473         * dom/Event.cpp:
1474         (WebCore::Event::isStreamEvent):
1475         * dom/Event.h:
1476         * dom/StreamEvent.cpp: Added.
1477         (WebCore::StreamEvent::create):
1478         (WebCore::StreamEvent::StreamEvent):
1479         (WebCore::StreamEvent::~StreamEvent):
1480         (WebCore::StreamEvent::initStreamEvent):
1481         (WebCore::StreamEvent::stream):
1482         * dom/StreamEvent.h: Added.
1483         (WebCore::StreamEvent::isStreamEvent):
1484         * dom/StreamEvent.idl: Added.
1485
1486 2011-06-08  Tommy Widenflycht  <tommyw@google.com>
1487
1488         Reviewed by Tony Gentilcore.
1489
1490         Media Stream API: integrate the Track List objects into the existing code.
1491         https://bugs.webkit.org/show_bug.cgi?id=60205
1492
1493         Tests for the Media Stream API will be provided by the bug 56587.
1494
1495         * dom/ExclusiveTrackList.cpp:
1496         (WebCore::ExclusiveTrackList::select):
1497         (WebCore::ExclusiveTrackList::trackFailed):
1498         * dom/ExclusiveTrackList.h:
1499         * dom/GeneratedStream.cpp:
1500         (WebCore::GeneratedStream::create):
1501         (WebCore::GeneratedStream::GeneratedStream):
1502         (WebCore::GeneratedStream::streamEnded):
1503         (WebCore::GeneratedStream::audioTracks):
1504         (WebCore::GeneratedStream::videoTracks):
1505         (WebCore::GeneratedStream::stop):
1506         * dom/GeneratedStream.h:
1507         * dom/GeneratedStream.idl:
1508         * dom/MultipleTrackList.cpp:
1509         (WebCore::MultipleTrackList::trackFailed):
1510         (WebCore::MultipleTrackList::enable):
1511         (WebCore::MultipleTrackList::disable):
1512         * dom/MultipleTrackList.h:
1513         * dom/Stream.h:
1514         * dom/TrackList.cpp:
1515         (WebCore::TrackList::clear):
1516         (WebCore::TrackList::associateStream):
1517         (WebCore::TrackList::associatedStreamLabel):
1518         (WebCore::TrackList::trackFailed):
1519         (WebCore::TrackList::scriptExecutionContext):
1520         * dom/TrackList.h:
1521         * page/MediaStreamClient.h:
1522         * page/MediaStreamController.cpp:
1523         (WebCore::MediaStreamController::enableAudioTrack):
1524         (WebCore::MediaStreamController::disableAudioTrack):
1525         (WebCore::MediaStreamController::selectVideoTrack):
1526         (WebCore::MediaStreamController::streamGenerated):
1527         (WebCore::MediaStreamController::audioTrackFailed):
1528         (WebCore::MediaStreamController::videoTrackFailed):
1529         * page/MediaStreamController.h:
1530         * page/MediaStreamFrameController.cpp:
1531         (WebCore::MediaStreamFrameController::unregister):
1532         (WebCore::MediaStreamFrameController::enterDetachedState):
1533         (WebCore::MediaStreamFrameController::disconnectFrame):
1534         (WebCore::MediaStreamFrameController::enableAudioTrack):
1535         (WebCore::MediaStreamFrameController::disableAudioTrack):
1536         (WebCore::MediaStreamFrameController::selectVideoTrack):
1537         (WebCore::MediaStreamFrameController::streamGenerated):
1538         (WebCore::MediaStreamFrameController::audioTrackFailed):
1539         (WebCore::MediaStreamFrameController::videoTrackFailed):
1540         * page/MediaStreamFrameController.h:
1541         (WebCore::MediaStreamFrameController::ClientBase::isGenericClient):
1542         (WebCore::MediaStreamFrameController::GenericClient::GenericClient):
1543         (WebCore::MediaStreamFrameController::GenericClient::~GenericClient):
1544         (WebCore::MediaStreamFrameController::GenericClient::isGenericClient):
1545         (WebCore::MediaStreamFrameController::GenericClient::unregister):
1546
1547 2011-06-08  Pavel Podivilov  <podivilov@chromium.org>
1548
1549         Reviewed by Yury Semikhatsky.
1550
1551         Web Inspector: [REGRESSION] breakpoints are not persisted.
1552         https://bugs.webkit.org/show_bug.cgi?id=62273
1553
1554         * inspector/front-end/Settings.js:
1555
1556 2011-06-08  Alexander Pavlov  <apavlov@chromium.org>
1557
1558         Reviewed by Yury Semikhatsky.
1559
1560         Web Inspector: node selection is slow in the Elements panel.
1561         https://bugs.webkit.org/show_bug.cgi?id=60813
1562
1563         Schedule full style updates rather than request all node styles from the backend immediately.
1564
1565         * inspector/front-end/StylesSidebarPane.js:
1566         (WebInspector.StylesSidebarPane.prototype.update.reloadAllStyles):
1567         (WebInspector.StylesSidebarPane.prototype.update):
1568
1569 2011-06-08  Andreas Kling  <andreas.kling@nokia.com>
1570
1571         Reviewed by Laszlo Gombos.
1572
1573         [Symbian] Float{32,64}Array and Int16Array fail to build.
1574         https://bugs.webkit.org/show_bug.cgi?id=62219
1575
1576         For some reason, RVCT 2.x is moaning about "class member designated by
1577         a using-declaration must be visible in a direct base class".
1578         Apply same fix as r69122 and r76592.
1579
1580         * html/canvas/Float32Array.h:
1581         (WebCore::Float32Array::set):
1582         * html/canvas/Float64Array.h:
1583         (WebCore::Float64Array::set):
1584         * html/canvas/Int16Array.h:
1585         (WebCore::Int16Array::set):
1586
1587 2011-06-08  Syed Idris Shah  <syed.idris-shah@nokia.com>
1588
1589         Reviewed by Andreas Kling.
1590
1591         [Qt] GL_POINT_SPRITE and GL_VERTEX_PROGRAM_POINT_SIZE should be enabled for desktop WebGL
1592         https://bugs.webkit.org/show_bug.cgi?id=61945
1593
1594         For OpenGL ES we do not need these features. 
1595         These features are available via shaders in OpenGL ES. But for desktop WebGL using QtWebKit they should be enabled.
1596
1597         LayoutTests/fast/canvas/webgl/point-size.html
1598
1599         * platform/graphics/qt/GraphicsContext3DQt.cpp:
1600         (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
1601
1602 2011-06-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1603
1604         Unreviewed. Fix style error.
1605
1606         * platform/efl/RenderThemeEfl.cpp:
1607         * platform/efl/RenderThemeEfl.h:
1608
1609 2011-06-08  Hironori Bono  <hbono@chromium.org>
1610
1611         Reviewed by Brent Fulgham.
1612
1613         Add SpellCheck API
1614         https://bugs.webkit.org/show_bug.cgi?id=59693
1615
1616         This change adds two SpellCheck API functions (addSpellcheckRange and
1617         removeSpellcheckRange) and one attribute (spellcheckRange) discussed in
1618         the public-webapps ML. This change is currently available only on Chromium.
1619
1620         Tests: editing/spelling/spellcheck-api-pixel.html
1621                editing/spelling/spellcheck-api.html
1622
1623         * WebCore.gypi:
1624         * bindings/generic/RuntimeEnabledFeatures.cpp:
1625         * bindings/generic/RuntimeEnabledFeatures.h:
1626         (WebCore::RuntimeEnabledFeatures::spellCheckAPIEnabled):
1627         (WebCore::RuntimeEnabledFeatures::setSpellCheckAPIEnabled):
1628         * dom/DocumentMarker.h:
1629         (WebCore::DocumentMarker::length):
1630         * dom/DocumentMarkerController.cpp:
1631         (WebCore::DocumentMarkerController::userSpellingMarkersForNode):
1632         (WebCore::DocumentMarkerController::addUserSpellingMarker):
1633         (WebCore::DocumentMarkerController::removeUserSpellingMarker):
1634         (WebCore::DocumentMarkerController::userSpellingNode):
1635         * dom/DocumentMarkerController.h:
1636         * html/HTMLDivElement.cpp:
1637         (WebCore::HTMLDivElement::spellcheckRanges):
1638         (WebCore::HTMLDivElement::addSpellcheckRange):
1639         (WebCore::HTMLDivElement::removeSpellcheckRange):
1640         * html/HTMLDivElement.h:
1641         * html/HTMLDivElement.idl:
1642         * html/HTMLInputElement.cpp:
1643         (WebCore::HTMLInputElement::spellcheckRanges):
1644         (WebCore::HTMLInputElement::addSpellcheckRange):
1645         (WebCore::HTMLInputElement::removeSpellcheckRange):
1646         * html/HTMLInputElement.h:
1647         * html/HTMLInputElement.idl:
1648         * html/HTMLTextAreaElement.cpp:
1649         (WebCore::HTMLTextAreaElement::spellcheckRanges):
1650         (WebCore::HTMLTextAreaElement::addSpellcheckRange):
1651         (WebCore::HTMLTextAreaElement::removeSpellcheckRange):
1652         * html/HTMLTextAreaElement.h:
1653         * html/HTMLTextAreaElement.idl:
1654         * html/SpellcheckRange.cpp: Added.
1655         (WebCore::SpellcheckRange::SpellcheckRange):
1656         (WebCore::SpellcheckRange::~SpellcheckRange):
1657         * html/SpellcheckRange.h: Added.
1658         (WebCore::SpellcheckRange::create):
1659         (WebCore::SpellcheckRange::start):
1660         (WebCore::SpellcheckRange::length):
1661         (WebCore::SpellcheckRange::suggestions):
1662         (WebCore::SpellcheckRange::options):
1663         * html/SpellcheckRange.idl: Added.
1664         * html/SpellcheckRangeList.cpp: Added.
1665         (WebCore::SpellcheckRangeList::SpellcheckRangeList):
1666         (WebCore::SpellcheckRangeList::~SpellcheckRangeList):
1667         (WebCore::SpellcheckRangeList::item):
1668         * html/SpellcheckRangeList.h: Added.
1669         (WebCore::SpellcheckRangeList::create):
1670         (WebCore::SpellcheckRangeList::isEmpty):
1671         (WebCore::SpellcheckRangeList::clear):
1672         (WebCore::SpellcheckRangeList::append):
1673         (WebCore::SpellcheckRangeList::remove):
1674         (WebCore::SpellcheckRangeList::length):
1675         * html/SpellcheckRangeList.idl: Added.
1676         * rendering/InlineTextBox.cpp:
1677         (WebCore::textCheckingLineStyleForMarkerType):
1678         (WebCore::InlineTextBox::paintDocumentMarkers):
1679
1680 2011-06-07  Andrey Kosyakov  <caseq@chromium.org>
1681
1682         Reviewed by Pavel Feldman.
1683
1684         Web Inspector: remove shadow dom inspection from Elements panel by default.
1685         https://bugs.webkit.org/show_bug.cgi?id=62188
1686
1687         This reverts r85751
1688
1689         * dom/Element.cpp:
1690         (WebCore::Element::ensureShadowRoot):
1691         (WebCore::Element::removeShadowRoot):
1692         * inspector/Inspector.json:
1693         * inspector/InspectorDOMAgent.cpp:
1694         (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
1695         (WebCore::InspectorDOMAgent::buildObjectForNode):
1696         (WebCore::InspectorDOMAgent::didInsertDOMNode):
1697         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
1698         * inspector/InspectorDOMAgent.h:
1699         * inspector/front-end/DOMAgent.js:
1700         (WebInspector.DOMNode):
1701         (WebInspector.DOMNode.prototype._renumber):
1702         (WebInspector.DOMAgent.prototype._bindNodes):
1703         (WebInspector.DOMAgent.prototype.querySelectorAll):
1704         (WebInspector.DOMDispatcher.prototype.searchResults):
1705         * inspector/front-end/ElementsPanel.js:
1706         (WebInspector.ElementsPanel):
1707         (WebInspector.ElementsPanel.prototype._attributesUpdated):
1708         (WebInspector.ElementsPanel.prototype._characterDataModified):
1709         (WebInspector.ElementsPanel.prototype._nodeInserted):
1710         (WebInspector.ElementsPanel.prototype._nodeRemoved):
1711         (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
1712         (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
1713         * inspector/front-end/ElementsTreeOutline.js:
1714         (WebInspector.ElementsTreeElement):
1715         (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
1716         (WebInspector.ElementsTreeElement.prototype._updateChildren):
1717         ():
1718         * inspector/front-end/inspector.css:
1719         * inspector/front-end/utilities.js:
1720         (Element.prototype.query):
1721
1722 2011-06-08  Mark Rowe  <mrowe@apple.com>
1723
1724         Fix the build.
1725
1726         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
1727         (WebCore::MediaPlayerPrivateAVFoundation::timeChanged):
1728         (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
1729
1730 2011-06-07  Keishi Hattori  <keishi@webkit.org>
1731
1732         Reviewed by Kent Tamura.
1733
1734         Rename HTMLInputElement::m_value to m_valueIfDirty
1735         https://bugs.webkit.org/show_bug.cgi?id=61990
1736
1737         No new tests because no behavior change.
1738
1739         * html/HTMLInputElement.cpp: Replaced m_value with m_valueIfDirty.
1740         (WebCore::HTMLInputElement::tooLong):
1741         (WebCore::HTMLInputElement::updateType):
1742         (WebCore::HTMLInputElement::parseMappedAttribute):
1743         (WebCore::HTMLInputElement::copyNonAttributeProperties):
1744         (WebCore::HTMLInputElement::value):
1745         (WebCore::HTMLInputElement::setValue):
1746         (WebCore::HTMLInputElement::setValueFromRenderer):
1747         (WebCore::HTMLInputElement::updateValueIfNeeded):
1748         * html/HTMLInputElement.h: Renamed m_value to m_valueIfDirty.
1749         (WebCore::HTMLInputElement::hasDirtyValue): Added. Returns the dirty value flag.
1750
1751 2011-06-07  Ian Henderson  <ianh@apple.com>
1752
1753         Reviewed by Dan Bernstein.
1754
1755         (CG) Sub-image drawing clips unnecessarily
1756         https://bugs.webkit.org/show_bug.cgi?id=62258
1757
1758         If destRect completely encompasses the adjustedDestRect into which we
1759         draw, clipping to destRect will do nothing.  Skip the call to
1760         CGContextClipToRect in this case.
1761
1762         * platform/graphics/cg/ImageCG.cpp:
1763         (WebCore::BitmapImage::draw):
1764
1765 2011-06-07  Emil A Eklund  <eae@chromium.org>
1766
1767         Reviewed by Eric Seidel.
1768
1769         Convert nodeAtPoint to IntPoint
1770         https://bugs.webkit.org/show_bug.cgi?id=62145
1771
1772         Convert nodeAtPoint to take an IntPoint instead of a pair of ints for the
1773         accumulated offset.
1774
1775         Covered by existing tests.
1776
1777         * platform/graphics/FloatPoint.h:
1778         (WebCore::FloatPoint::moveBy):
1779         Add moveBy(IntPoint) method
1780         
1781         * rendering/EllipsisBox.cpp:
1782         (WebCore::EllipsisBox::nodeAtPoint):
1783         * rendering/EllipsisBox.h:
1784         * rendering/InlineBox.cpp:
1785         (WebCore::InlineBox::nodeAtPoint):
1786         * rendering/InlineBox.h:
1787         * rendering/InlineFlowBox.cpp:
1788         (WebCore::InlineFlowBox::nodeAtPoint):
1789         * rendering/InlineFlowBox.h:
1790         * rendering/InlineTextBox.cpp:
1791         (WebCore::InlineTextBox::nodeAtPoint):
1792         * rendering/InlineTextBox.h:
1793         * rendering/RenderBlock.cpp:
1794         (WebCore::RenderBlock::nodeAtPoint):
1795         (WebCore::RenderBlock::hitTestContents):
1796         * rendering/RenderBlock.h:
1797         * rendering/RenderBox.cpp:
1798         (WebCore::RenderBox::nodeAtPoint):
1799         * rendering/RenderBox.h:
1800         * rendering/RenderFrameSet.cpp:
1801         (WebCore::RenderFrameSet::nodeAtPoint):
1802         * rendering/RenderFrameSet.h:
1803         * rendering/RenderImage.cpp:
1804         (WebCore::RenderImage::nodeAtPoint):
1805         * rendering/RenderImage.h:
1806         * rendering/RenderInline.cpp:
1807         (WebCore::RenderInline::nodeAtPoint):
1808         * rendering/RenderInline.h:
1809         * rendering/RenderLineBoxList.cpp:
1810         (WebCore::RenderLineBoxList::hitTest):
1811         * rendering/RenderListBox.cpp:
1812         (WebCore::RenderListBox::nodeAtPoint):
1813         * rendering/RenderListBox.h:
1814         * rendering/RenderObject.cpp:
1815         (WebCore::RenderObject::hitTest):
1816         * rendering/RenderObject.h:
1817         * rendering/RenderTable.cpp:
1818         (WebCore::RenderTable::nodeAtPoint):
1819         * rendering/RenderTable.h:
1820         * rendering/RenderTableRow.cpp:
1821         (WebCore::RenderTableRow::nodeAtPoint):
1822         * rendering/RenderTableRow.h:
1823         * rendering/RenderTableSection.cpp:
1824         (WebCore::RenderTableSection::nodeAtPoint):
1825         * rendering/RenderTableSection.h:
1826         * rendering/RenderText.h:
1827         (WebCore::RenderText::nodeAtPoint):
1828         * rendering/RenderTextControlMultiLine.cpp:
1829         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
1830         * rendering/RenderTextControlMultiLine.h:
1831         * rendering/RenderTextControlSingleLine.cpp:
1832         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
1833         * rendering/RenderTextControlSingleLine.h:
1834         * rendering/RenderWidget.cpp:
1835         (WebCore::RenderWidget::nodeAtPoint):
1836         * rendering/RenderWidget.h:
1837         * rendering/RootInlineBox.cpp:
1838         (WebCore::RootInlineBox::nodeAtPoint):
1839         * rendering/RootInlineBox.h:
1840         * rendering/svg/RenderSVGForeignObject.cpp:
1841         (WebCore::RenderSVGForeignObject::nodeAtFloatPoint):
1842         (WebCore::RenderSVGForeignObject::nodeAtPoint):
1843         * rendering/svg/RenderSVGForeignObject.h:
1844         * rendering/svg/RenderSVGModelObject.cpp:
1845         (WebCore::RenderSVGModelObject::nodeAtPoint):
1846         * rendering/svg/RenderSVGModelObject.h:
1847         * rendering/svg/RenderSVGRoot.cpp:
1848         (WebCore::RenderSVGRoot::nodeAtPoint):
1849         * rendering/svg/RenderSVGRoot.h:
1850         * rendering/svg/RenderSVGText.cpp:
1851         (WebCore::RenderSVGText::nodeAtFloatPoint):
1852         (WebCore::RenderSVGText::nodeAtPoint):
1853         * rendering/svg/RenderSVGText.h:
1854
1855 2011-06-07  Yi Shen  <yi.4.shen@nokia.com>
1856
1857         Reviewed by Simon Hausmann.
1858
1859         [Qt] Fix the error code for media resource failures when using QtMobility
1860         https://bugs.webkit.org/show_bug.cgi?id=55901
1861
1862         To indicate the media resource failures, set the network state to
1863         MediaPlayer::FormatError when receives QMediaPlayer::InvalidMedia or
1864         QMediaPlayer::ResourceError.
1865
1866         * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
1867         (WebCore::MediaPlayerPrivateQt::updateStates):
1868
1869 2011-06-07  Emil A Eklund  <eae@chromium.org>
1870
1871         Reviewed by Eric Seidel.
1872
1873         Change RenderBlock::hitTestFloats to IntPoint
1874         https://bugs.webkit.org/show_bug.cgi?id=62176
1875
1876         Covered by existing tests.
1877
1878         * rendering/RenderBlock.cpp:
1879         (WebCore::RenderBlock::nodeAtPoint):
1880         (WebCore::RenderBlock::hitTestFloats):
1881         (WebCore::RenderBlock::hitTestColumns):
1882         * rendering/RenderBlock.h:
1883
1884 2011-06-07  Tim Horton  <timothy_horton@apple.com>
1885
1886         Reviewed by Alexey Proskuryakov.
1887
1888         Use correct CFURLStorageSessionRef definition on Snow Leopard
1889         https://bugs.webkit.org/show_bug.cgi?id=62223
1890
1891         * platform/mac/WebCoreSystemInterface.h:
1892         * platform/network/ResourceHandle.h:
1893         * platform/network/cf/ResourceRequest.h:
1894
1895 2011-06-07  Emil A Eklund  <eae@chromium.org>
1896
1897         Reviewed by Eric Seidel.
1898
1899         Change RenderBlock::hitTestColumns to IntPoint
1900         https://bugs.webkit.org/show_bug.cgi?id=62172
1901
1902         Covered by existing tests.
1903
1904         * rendering/RenderBlock.cpp:
1905         (WebCore::RenderBlock::nodeAtPoint):
1906         (WebCore::RenderBlock::hitTestColumns):
1907         * rendering/RenderBlock.h:
1908
1909 2011-06-07  Simon Fraser  <simon.fraser@apple.com>
1910
1911         Reviewed by Darin Adler.
1912
1913         Opacity transition doesn't work while content property is set.
1914         https://bugs.webkit.org/show_bug.cgi?id=59301
1915         
1916         StyleRareNonInheritedData's copy constructor omitted to copy
1917         the m_content data, which caused us to detach and re-attach the renderer
1918         at the start of the transition, thereby killing the transition.
1919         
1920         Fix by making StyleRareNonInheritedData's copy ctor do the right thing.
1921
1922         Test: transitions/transition-on-element-with-content.html
1923
1924         * rendering/style/ContentData.h:
1925         * rendering/style/ContentData.cpp:
1926         (WebCore::ContentData::clone): New method to do a deep clone. (Can't use a copy
1927         ctor because of the subclasses.)
1928         * rendering/style/CounterDirectives.h: Pack the data members to save space.
1929         Add a clone() function for the HashMap.
1930         * rendering/style/CounterDirectives.cpp:
1931         (WebCore::clone): Make a new HashMap and copy the contents over.
1932         * rendering/style/StyleRareNonInheritedData.cpp:
1933         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Copy
1934         the content and counter directives over.
1935         (WebCore::StyleRareNonInheritedData::operator==): Rather than just comparing
1936         for pointer equality, do a correct check for m_counterDirectives equality.
1937         (WebCore::StyleRareNonInheritedData::counterDataEquivalent):
1938         * rendering/style/StyleRareNonInheritedData.h:
1939
1940 2011-06-07  Robert Kroeger  <rjkroege@chromium.org>
1941
1942         Reviewed by Adam Barth.
1943
1944         [chromium] Add a basic gesture recognizer to the Chromium platform
1945         https://bugs.webkit.org/show_bug.cgi?id=54417
1946
1947         Adds a basic gesture recognizer to the Chromium platform. Adds an entry
1948         point to the GestureRecognizer to reset any internal state on a page reset.
1949         Resetting the gesture recognizer on page load is necesary for reliable
1950         layout test execution and improves gesture recognizer operational
1951         robustness.
1952
1953         Added an additional constructor to permit building a synthetic
1954         PlatformWheelEvent.
1955
1956         Small modifications to the PlatformGestureRecognizer as required to
1957         implement the simple Chromium platform gesture recognizer.
1958
1959         Tests: fast/events/touch/touch-gesture-click.html
1960
1961         * WebCore.gypi:
1962         * page/EventHandler.cpp:
1963         (WebCore::EventHandler::resetGestureRecognizer):
1964         * page/EventHandler.h:
1965         * page/FrameView.cpp:
1966         (WebCore::FrameView::reset):
1967         * platform/PlatformGestureRecognizer.h:
1968         * platform/PlatformWheelEvent.h:
1969         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1970         * platform/chromium/GestureRecognizerChromium.cpp: Added.
1971         (WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
1972         (WebCore::InnerGestureRecognizer::reset):
1973         (WebCore::InnerGestureRecognizer::~InnerGestureRecognizer):
1974         (WebCore::InnerGestureRecognizer::addEdgeFunction):
1975         (WebCore::InnerGestureRecognizer::isInClickTimeWindow):
1976         (WebCore::InnerGestureRecognizer::isInsideManhattanSquare):
1977         (WebCore::InnerGestureRecognizer::dispatchSyntheticClick):
1978         (WebCore::InnerGestureRecognizer::processTouchEventForGesture):
1979         (WebCore::InnerGestureRecognizer::scrollViaTouchMotion):
1980         (WebCore::InnerGestureRecognizer::updateValues):
1981         (WebCore::InnerGestureRecognizer::signature):
1982         (WebCore::touchDown):
1983         (WebCore::noGesture):
1984         (WebCore::click):
1985         (WebCore::isClickOrScroll):
1986         (WebCore::inScroll):
1987         (WebCore::PlatformGestureRecognizer::create):
1988         (WebCore::PlatformGestureRecognizer::PlatformGestureRecognizer):
1989         (WebCore::PlatformGestureRecognizer::~PlatformGestureRecognizer):
1990         (WebCore::GestureRecognizerChromium::GestureRecognizerChromium):
1991         (WebCore::GestureRecognizerChromium::~GestureRecognizerChromium):
1992         * platform/chromium/GestureRecognizerChromium.h: Added.
1993         (WebCore::InnerGestureRecognizer::setState):
1994         (WebCore::InnerGestureRecognizer::state):
1995         (WebCore::GestureRecognizerChromium::reset):
1996         (WebCore::GestureRecognizerChromium::processTouchEventForGesture):
1997
1998 2011-06-07  No'am Rosenthal  <noam.rosenthal@nokia.com>
1999
2000         Reviewed by Andreas Kling.
2001
2002         [Texmap][Qt] Enable TextureMapper by default
2003         https://bugs.webkit.org/show_bug.cgi?id=61740
2004
2005         Enable TextureMapper on Windows+Symbian, disabling the direct OpenGL path. This would mean that
2006         for now QtWebKit on Windows/Symbian would use the Qt backend for TextureMapper.
2007
2008         No new functionality so no new tests.
2009
2010         * WebCore.pri:
2011         * WebCore.pro:
2012         * platform/graphics/qt/GraphicsContext3DQt.cpp:
2013         * platform/graphics/qt/TextureMapperQt.cpp:
2014         (WebCore::TextureMapper::create):
2015
2016 2011-06-07  Emil A Eklund  <eae@chromium.org>
2017
2018         Reviewed by Eric Seidel.
2019
2020         Convert RenderBox::absoluteRects to IntPoint
2021         https://bugs.webkit.org/show_bug.cgi?id=62130
2022
2023         Covered by existing tests.
2024
2025         * dom/Node.cpp:
2026         (WebCore::Node::hasNonEmptyBoundingBox):
2027         * rendering/InlineBox.h:
2028         (WebCore::InlineBox::size):
2029         * rendering/RenderBlock.cpp:
2030         (WebCore::RenderBlock::absoluteRects):
2031         * rendering/RenderBlock.h:
2032         * rendering/RenderBox.cpp:
2033         (WebCore::RenderBox::absoluteRects):
2034         * rendering/RenderBox.h:
2035         * rendering/RenderInline.cpp:
2036         (WebCore::RenderInline::absoluteRects):
2037         * rendering/RenderInline.h:
2038         * rendering/RenderObject.cpp:
2039         (WebCore::RenderObject::absoluteBoundingBoxRect):
2040         * rendering/RenderObject.h:
2041         (WebCore::RenderObject::absoluteRects):
2042         * rendering/RenderText.cpp:
2043         (WebCore::RenderText::absoluteRects):
2044         * rendering/RenderText.h:
2045         * rendering/RenderView.cpp:
2046         (WebCore::RenderView::absoluteRects):
2047         * rendering/RenderView.h:
2048         * rendering/svg/RenderSVGBlock.cpp:
2049         (WebCore::RenderSVGBlock::absoluteRects):
2050         * rendering/svg/RenderSVGBlock.h:
2051         * rendering/svg/RenderSVGModelObject.cpp:
2052         (WebCore::RenderSVGModelObject::absoluteRects):
2053         * rendering/svg/RenderSVGModelObject.h:
2054
2055 2011-06-07  Kent Tamura  <tkent@chromium.org>
2056
2057         Reviewed by Andreas Kling.
2058
2059         [Qt] RenderThemeQt::adjustSliderThumbSize() should not refer to the parent style.
2060         https://bugs.webkit.org/show_bug.cgi?id=62207
2061
2062         * css/mediaControlsQt.css: Add comments.
2063         (audio::-webkit-media-controls-timeline):
2064         (video::-webkit-media-controls-timeline):
2065         (audio::-webkit-media-controls-volume-slider):
2066         (video::-webkit-media-controls-volume-slider):
2067         * platform/qt/RenderThemeQt.cpp: Use fixed values to avoid referring to o->parent().
2068         (WebCore::RenderThemeQt::adjustSliderThumbSize):
2069
2070 2011-06-07  Sailesh Agrawal  <sail@chromium.org>
2071
2072         Reviewed by Mihai Parparita.
2073
2074         Chromium Mac: Fork ScrollAnimatorMac to ScrollAnimatorChromiumMac for overlay scrollbar support
2075         https://bugs.webkit.org/show_bug.cgi?id=59753
2076
2077         No new tests. Just forking ScrollAnimatorMac to ScrollAnimatorChromiumMac.
2078
2079         * WebCore.gyp/WebCore.gyp: Added IntPointMac.mm. This is used by some functions in ScrollAnimatorChromiumMac. Also added filters for conflicting class names in ScrollAnimatorChromiumMac.
2080         * WebCore.gypi: Added ScrollAnimatorChromiumMac.h/mm.
2081         * platform/ScrollAnimator.cpp: Extended the #ifdef around ScrollAnimator::create() so that the chromium version will be created.
2082         * platform/chromium/ScrollAnimatorChromiumMac.h: Added.
2083         (WebCore::ScrollAnimatorChromiumMac::setIsDrawingIntoLayer):
2084         (WebCore::ScrollAnimatorChromiumMac::isDrawingIntoLayer):
2085         (WebCore::ScrollAnimatorChromiumMac::haveScrolledSincePageLoad):
2086         * platform/chromium/ScrollAnimatorChromiumMac.mm: Added. Forked from ScrollAnimatorMac and replaced all instances of ScrollAnimatorMac with ScrollAnimatorChromiumMac and ScrollbarThemeMac with ScrollbarThemeChromiumMac. Removed the ENABLE(SMOOTH_SCROLLING) around the file. Stubbed out ScrollAnimatorChromiumMac::scroll() if smooth scrolling is disabled.
2087         (abs):
2088         (-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]):
2089         (-[ScrollAnimationHelperDelegate scrollAnimatorDestroyed]):
2090         (-[ScrollAnimationHelperDelegate bounds]):
2091         (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]):
2092         (-[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]):
2093         (-[ScrollAnimationHelperDelegate convertSizeToBase:]):
2094         (-[ScrollAnimationHelperDelegate convertSizeFromBase:]):
2095         (-[ScrollAnimationHelperDelegate convertSizeToBacking:]):
2096         (-[ScrollAnimationHelperDelegate convertSizeFromBacking:]):
2097         (-[ScrollAnimationHelperDelegate superview]):
2098         (-[ScrollAnimationHelperDelegate documentView]):
2099         (-[ScrollAnimationHelperDelegate window]):
2100         (-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]):
2101         (-[ScrollbarPainterControllerDelegate initWithScrollAnimator:WebCore::]):
2102         (-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]):
2103         (-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
2104         (-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
2105         (-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
2106         (-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
2107         (-[ScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
2108         (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
2109         (-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):
2110         (-[ScrollbarPartAnimation setCurrentProgress:]):
2111         (-[ScrollbarPartAnimation scrollAnimatorDestroyed]):
2112         (-[ScrollbarPainterDelegate initWithScrollAnimator:WebCore::]):
2113         (-[ScrollbarPainterDelegate cancelAnimations]):
2114         (-[ScrollbarPainterDelegate convertRectToBacking:]):
2115         (-[ScrollbarPainterDelegate convertRectFromBacking:]):
2116         (-[ScrollbarPainterDelegate layer]):
2117         (-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
2118         (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
2119         (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
2120         (-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):
2121         (-[ScrollbarPainterDelegate scrollAnimatorDestroyed]):
2122         (WebCore::ScrollAnimator::create):
2123         (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac):
2124         (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac):
2125         (WebCore::ScrollAnimatorChromiumMac::scroll):
2126         (WebCore::ScrollAnimatorChromiumMac::scrollToOffsetWithoutAnimation):
2127         (WebCore::ScrollAnimatorChromiumMac::adjustScrollXPositionIfNecessary):
2128         (WebCore::ScrollAnimatorChromiumMac::adjustScrollYPositionIfNecessary):
2129         (WebCore::ScrollAnimatorChromiumMac::adjustScrollPositionIfNecessary):
2130         (WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint):
2131         (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX):
2132         (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY):
2133         (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged):
2134         (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint):
2135         (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea):
2136         (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea):
2137         (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea):
2138         (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize):
2139         (WebCore::ScrollAnimatorChromiumMac::contentsResized):
2140         (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize):
2141         (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow):
2142         (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide):
2143         (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture):
2144         (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture):
2145         (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar):
2146         (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar):
2147         (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar):
2148         (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar):
2149         (WebCore::ScrollAnimatorChromiumMac::cancelAnimations):
2150         (WebCore::elasticDeltaForTimeDelta):
2151         (WebCore::elasticDeltaForReboundDelta):
2152         (WebCore::reboundDeltaForElasticDelta):
2153         (WebCore::scrollWheelMultiplier):
2154         (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
2155         (WebCore::ScrollAnimatorChromiumMac::handleGestureEvent):
2156         (WebCore::ScrollAnimatorChromiumMac::pinnedInDirection):
2157         (WebCore::ScrollAnimatorChromiumMac::allowsVerticalStretching):
2158         (WebCore::ScrollAnimatorChromiumMac::allowsHorizontalStretching):
2159         (WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent):
2160         (WebCore::ScrollAnimatorChromiumMac::beginScrollGesture):
2161         (WebCore::ScrollAnimatorChromiumMac::endScrollGesture):
2162         (WebCore::ScrollAnimatorChromiumMac::snapRubberBand):
2163         (WebCore::roundTowardZero):
2164         (WebCore::roundToDevicePixelTowardZero):
2165         (WebCore::ScrollAnimatorChromiumMac::snapRubberBandTimerFired):
2166         (WebCore::ScrollAnimatorChromiumMac::startScrollbarPaintTimer):
2167         (WebCore::ScrollAnimatorChromiumMac::scrollbarPaintTimerIsActive):
2168         (WebCore::ScrollAnimatorChromiumMac::stopScrollbarPaintTimer):
2169         (WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):
2170         (WebCore::ScrollAnimatorChromiumMac::setVisibleScrollerThumbRect):
2171         * platform/graphics/IntPoint.h: Exposed NSPoint conversion routines to chromium mac.
2172
2173 2011-06-07  Sam Weinig  <sam@webkit.org>
2174
2175         Reviewed by Anders Carlsson.
2176
2177         Remove repeated IPC traffic from SetRenderTreeSize message
2178         https://bugs.webkit.org/show_bug.cgi?id=62244
2179
2180         * WebCore.xcodeproj/project.pbxproj:
2181         Make RenderArena.h private so it can be called from WebKit2.
2182
2183         * loader/FrameLoaderClient.h:
2184         (WebCore::FrameLoaderClient::dispatchDidLayout):
2185         Added.
2186
2187         * page/ChromeClient.h:
2188         Remove setRenderTreeSize.
2189
2190         * page/FrameView.cpp:
2191         (WebCore::FrameView::performPostLayoutTasks):
2192         Call dispatchDidLayout for all frames instead of calling setRenderTreeSize
2193         for the main frame.
2194
2195 2011-06-07  Emil A Eklund  <eae@chromium.org>
2196
2197         Reviewed by Eric Seidel.
2198
2199         Change RenderBlock::hitTestContents to IntPoint
2200         https://bugs.webkit.org/show_bug.cgi?id=62170
2201
2202         Covered by existing tests.
2203
2204         * rendering/RenderBlock.cpp:
2205         (WebCore::RenderBlock::nodeAtPoint):
2206         (WebCore::RenderBlock::hitTestColumns):
2207         (WebCore::RenderBlock::hitTestContents):
2208         * rendering/RenderBlock.h:
2209
2210 2011-06-07  Jer Noble  <jer.noble@apple.com>
2211
2212         Reviewed by Eric Carlson.
2213
2214         Video with poster attribute will not display new frames when scrubbing.
2215         https://bugs.webkit.org/show_bug.cgi?id=62036
2216
2217         Remove our "detection" about the end of a scrub now that there is an explicit seek completion
2218         handler available in AVFoundation.  Move what we used to do upon detection in timeChanged()
2219         into seekCompleted().
2220
2221         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
2222         (WebCore::MediaPlayerPrivateAVFoundation::timeChanged): 
2223         (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
2224
2225 2011-06-07  James Simonsen  <simonjam@chromium.org>
2226
2227         Unreviewed, build fix, missing files from r88274.
2228
2229         * bindings/v8/ChildThreadDOMData.cpp: Added.
2230         (WebCore::ChildThreadDOMData::ChildThreadDOMData):
2231         (WebCore::ChildThreadDOMData::getStore):
2232         * bindings/v8/ChildThreadDOMData.h: Added.
2233         * bindings/v8/MainThreadDOMData.cpp: Added.
2234         (WebCore::MainThreadDOMData::MainThreadDOMData):
2235         (WebCore::MainThreadDOMData::getCurrent):
2236         (WebCore::MainThreadDOMData::getMainThreadStore):
2237         (WebCore::MainThreadDOMData::getCurrentMainThreadStore):
2238         * bindings/v8/MainThreadDOMData.h: Added.
2239         (WebCore::MainThreadDOMData::getStore):
2240
2241 2011-06-07  Abhishek Arya  <inferno@chromium.org>
2242
2243         Reviewed by Dan Bernstein.
2244
2245         Replicate WidthIterator.cpp fix from r88139.
2246         https://bugs.webkit.org/show_bug.cgi?id=62238
2247
2248         No new tests. Covered by existing layout tests on XP debug bots.
2249
2250         * platform/graphics/win/UniscribeController.cpp:
2251         (WebCore::UniscribeController::advance):
2252
2253 2011-06-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2254
2255         Unreviewed, rolling out r88221, r88224, and r88231.
2256         http://trac.webkit.org/changeset/88221
2257         http://trac.webkit.org/changeset/88224
2258         http://trac.webkit.org/changeset/88231
2259         https://bugs.webkit.org/show_bug.cgi?id=62233
2260
2261         assert failure on chromium linux debug (Requested by simonjam
2262         on #webkit).
2263
2264         * WebCore.gypi:
2265         * WebCore.pro:
2266         * bindings/v8/ChildThreadDOMData.cpp: Copied from Source/WebCore/bindings/v8/DOMData.cpp.
2267         (WebCore::ChildThreadDOMData::ChildThreadDOMData):
2268         (WebCore::ChildThreadDOMData::getStore):
2269         * bindings/v8/ChildThreadDOMData.h: Copied from Source/WebCore/bindings/v8/DOMData.cpp.
2270         * bindings/v8/DOMData.cpp:
2271         (WebCore::DOMData::DOMData):
2272         (WebCore::DOMData::getCurrent):
2273         * bindings/v8/DOMData.h:
2274         (WebCore::DOMData::owningThread):
2275         (WebCore::DOMData::handleWeakObject):
2276         * bindings/v8/DOMDataStore.cpp:
2277         (WebCore::DOMDataStore::DOMDataStore):
2278         (WebCore::DOMDataStore::~DOMDataStore):
2279         (WebCore::DOMDataStore::allStoresMutex):
2280         (WebCore::DOMDataStore::weakNodeCallback):
2281         * bindings/v8/DOMDataStore.h:
2282         * bindings/v8/MainThreadDOMData.cpp: Copied from Source/WebCore/bindings/v8/DOMData.cpp.
2283         (WebCore::MainThreadDOMData::MainThreadDOMData):
2284         (WebCore::MainThreadDOMData::getCurrent):
2285         (WebCore::MainThreadDOMData::getMainThreadStore):
2286         (WebCore::MainThreadDOMData::getCurrentMainThreadStore):
2287         * bindings/v8/MainThreadDOMData.h: Copied from Source/WebCore/bindings/v8/DOMData.cpp.
2288         (WebCore::MainThreadDOMData::getStore):
2289         * bindings/v8/V8DOMMap.cpp:
2290         (WebCore::getDOMDataStore):
2291         (WebCore::removeAllDOMObjectsInCurrentThread):
2292         (WebCore::visitDOMNodesInCurrentThread):
2293         (WebCore::visitDOMObjectsInCurrentThread):
2294         (WebCore::visitActiveDOMObjectsInCurrentThread):
2295         (WebCore::visitDOMSVGElementInstancesInCurrentThread):
2296         * bindings/v8/V8DOMMap.h:
2297         * bindings/v8/V8GCController.cpp:
2298         (WebCore::V8GCController::gcPrologue):
2299         (WebCore::V8GCController::gcEpilogue):
2300         * bindings/v8/WorkerScriptController.cpp:
2301         (WebCore::WorkerScriptController::~WorkerScriptController):
2302
2303 2011-06-07  Simon Fraser  <simon.fraser@apple.com>
2304
2305         Reviewed by Dave Hyatt.
2306
2307         Clean up ContentData
2308         https://bugs.webkit.org/show_bug.cgi?id=62185
2309
2310         ContentData did manual ref()/deref() and had a lot of awkward
2311         code from using a union to store data.
2312         
2313         Clean this up by adding ContentData subclasses for different
2314         content types, which are then able to use RefPtr and OwnPtr
2315         as appropriate.
2316
2317         * css/CSSComputedStyleDeclaration.cpp:
2318         (WebCore::contentToCSSValue): Cast to different ContentData types as
2319         appropriate.
2320
2321         * css/CSSStyleSelector.cpp: 
2322         (WebCore::CSSStyleSelector::loadPendingImages): Cast to ImageContentData, and do some
2323         const gyrations.
2324
2325         * html/HTMLBRElement.cpp:
2326         (WebCore::HTMLBRElement::createRenderer): Use hasContent().
2327         * html/HTMLFrameSetElement.cpp:
2328         (WebCore::HTMLFrameSetElement::createRenderer): Ditto
2329         * html/HTMLImageElement.cpp:
2330         (WebCore::HTMLImageElement::createRenderer): Ditto
2331         * rendering/RenderObject.cpp:
2332         (WebCore::RenderObject::createObject): Cast to ImageContentData.
2333         * rendering/RenderObjectChildList.cpp:
2334         (WebCore::RenderObjectChildList::updateBeforeAfterContent): Cast to different ContentData types as
2335         appropriate.
2336
2337         * rendering/style/ContentData.h:
2338         (WebCore::ContentData::~ContentData):
2339         (WebCore::ContentData::isCounter):
2340         (WebCore::ContentData::isImage):
2341         (WebCore::ContentData::isQuote):
2342         (WebCore::ContentData::isText):
2343         (WebCore::ContentData::next):
2344         (WebCore::ContentData::setNext):
2345         (WebCore::ImageContentData::image):
2346         (WebCore::ImageContentData::setImage):
2347         (WebCore::ImageContentData::ImageContentData):
2348         (WebCore::ImageContentData::type):
2349         (WebCore::ImageContentData::isImage):
2350         (WebCore::TextContentData::text):
2351         (WebCore::TextContentData::setText):
2352         (WebCore::TextContentData::TextContentData):
2353         (WebCore::TextContentData::type):
2354         (WebCore::TextContentData::isText):
2355         (WebCore::CounterContentData::counter):
2356         (WebCore::CounterContentData::setCounter):
2357         (WebCore::CounterContentData::CounterContentData):
2358         (WebCore::CounterContentData::type):
2359         (WebCore::CounterContentData::isCounter):
2360         (WebCore::QuoteContentData::quote):
2361         (WebCore::QuoteContentData::setQuote):
2362         (WebCore::QuoteContentData::QuoteContentData):
2363         (WebCore::QuoteContentData::type):
2364         (WebCore::QuoteContentData::isQuote):
2365         Add subclasses for different content types, which are created
2366         via overloaded create() methods on the base class.
2367
2368         * rendering/style/ContentData.cpp:
2369         (WebCore::ContentData::create):
2370         (WebCore::operator==): Test for type equality, followed by comparing data.
2371         (WebCore::operator!=):
2372
2373         * rendering/style/RenderStyle.cpp:
2374         (WebCore::RenderStyle::clearContent):
2375         (WebCore::RenderStyle::appendContent): 
2376         (WebCore::RenderStyle::setContent): Replace the overly complex prepareToSetContent()
2377         code with code that either appends, or replaces the content.
2378         This loses an optimization where the existing ContentData object could get reused,
2379         but this seems to be rarely hit in practice.
2380         * rendering/style/RenderStyle.h:
2381         (WebCore::InheritedFlags::hasContent): Convenience method.
2382         * rendering/style/StyleRareNonInheritedData.cpp:
2383         (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Test
2384         that the pointers are non-null, then use the != operator.
2385         * rendering/style/StyleRareNonInheritedData.h: ContentData is a class now.
2386
2387 2011-06-07  Brian Weinstein  <bweinstein@apple.com>
2388
2389         Build fix after r88260.
2390
2391         * platform/graphics/win/FontCacheWin.cpp:
2392         (WebCore::FontCache::getFontDataForCharacters): Update to use enum instead of bool.
2393         * platform/graphics/wince/FontCacheWinCE.cpp:
2394
2395 2011-06-07  Rob Buis  <rbuis@rim.com>
2396
2397         Reviewed by Dirk Schulze.
2398
2399         stroke-dasharray does not handle "none"
2400         https://bugs.webkit.org/show_bug.cgi?id=62203
2401
2402         Use the initial strokeDashArray style for stroke-dasharray="none" to apply to SVGRenderStyle rather than bailing out.
2403
2404         Tests: svg/W3C-SVG-1.1-SE/styling-css-04-f.svg
2405                svg/custom/invalid-dasharray.svg
2406
2407         * css/SVGCSSStyleSelector.cpp:
2408         (WebCore::CSSStyleSelector::applySVGProperty):
2409
2410 2011-06-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2411
2412         Unreviewed, rolling out r88259 and r88263.
2413         http://trac.webkit.org/changeset/88259
2414         http://trac.webkit.org/changeset/88263
2415         https://bugs.webkit.org/show_bug.cgi?id=62228
2416
2417         broke builds (Requested by rniwa on #webkit).
2418
2419         * platform/mac/WebCoreSystemInterface.h:
2420         * platform/network/ResourceHandle.h:
2421         * platform/network/cf/ResourceRequest.h:
2422
2423 2011-06-07  Emil A Eklund  <eae@chromium.org>
2424
2425         Reviewed by Eric Seidel.
2426
2427         Switch ContainerNode to use IntPoint
2428         https://bugs.webkit.org/show_bug.cgi?id=61893
2429
2430         Covered by existing tests.
2431
2432         * dom/ContainerNode.cpp:
2433         (WebCore::ContainerNode::getUpperLeftCorner):
2434         (WebCore::ContainerNode::getLowerRightCorner):
2435         (WebCore::ContainerNode::getRect):
2436         Change to use maxX/maxY instead of x+width/y+height
2437         
2438         * platform/graphics/FloatPoint.h:
2439         (WebCore::FloatPoint::move):
2440         (WebCore::FloatPoint::moveBy):
2441         (WebCore::FloatPoint::expandedTo):
2442         Add move, moveBy and expandedTo mirroring the IntPoint implementation of the same.
2443
2444 2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
2445
2446         Speculative build fix after r88259.
2447
2448         * platform/network/cf/ResourceRequest.h:
2449
2450 2011-06-07  Michael Saboff  <msaboff@apple.com>
2451
2452         Reviewed by Geoffrey Garen.
2453
2454         Need to enable font cache purging in MemoryPressureHandler
2455         https://bugs.webkit.org/show_bug.cgi?id=62060
2456
2457         Improve memory usage under pressure.
2458         Added call to fontCache()->purgeInactiveFontData() in 
2459         MemoryPressureHandler::respondToMemoryPressure().  Added protection to 
2460         MemoryPressureHandler::install() being called multiple times.
2461
2462         No new tests as funtionality wasn't changed.
2463
2464         * platform/MemoryPressureHandler.cpp:
2465         (WebCore::MemoryPressureHandler::MemoryPressureHandler):
2466         * platform/MemoryPressureHandler.h:
2467         * platform/mac/MemoryPressureHandlerMac.mm:
2468         (WebCore::MemoryPressureHandler::install):
2469         (WebCore::MemoryPressureHandler::respondToMemoryPressure):
2470
2471 2011-06-07  Michael Saboff  <msaboff@apple.com>
2472
2473         Reviewed by Geoffrey Garen.
2474
2475         Fonts returned by FontCache::getFontDataForCharacters() are never released
2476         https://bugs.webkit.org/show_bug.cgi?id=61875
2477
2478         This change allows fonts allocated as system fallback fonts to be 
2479         released.  Previously, the reference counts for these fonts grew 
2480         without bound.  This is implemented as an auto release class that wraps
2481         accesses to the cache for system fallback fonts. All such accesses are
2482         via the method FontCache::getFontDataForCharacters. The new class is
2483         called FontCachePurgePreventer. When such an object exists, it protects
2484         these fonts from deletion.
2485
2486         Most accesses to the font cache still use the reference counting
2487         implemented by FontCache::getCacheFontData() and 
2488         FontCache::releaseFontData() and that operation is not affected by
2489         this change.
2490
2491         Added local scoped instance of FontCachePurgePreventer to wrap code
2492         that directly or indirectly accesses fonts via getFontDataForCharacters.
2493         Did a few other miscellaneous bug fixes and changes to allow system
2494         fallback fonts to be pruned from the GlyphPageTree. Changed the
2495         calls to getFontData in the platform specific versions of
2496         Fontcache::getFontDataForCharacters to not increment the reference
2497         count.  Moved the purge font check
2498         outside of FontCache::getCachedFontData() into a separate method, 
2499         purgeInactiveFontDataIfNeeded() since almost all calls to 
2500         getCachedFontData() now happen when purging is not allowed.
2501         purgeInactiveFontDataIfNeeded is invoked in enablePurging() when
2502         m_purgePreventCount is 0.
2503
2504         No new test as the functionality has not changed. Improved font life
2505         cycle management.
2506
2507         * WebCore.exp.in: Added FontCache::purgeInactiveFontDataIfNeeded().
2508         * html/canvas/CanvasRenderingContext2D.cpp:
2509         (WebCore::CanvasRenderingContext2D::measureText):
2510         (WebCore::CanvasRenderingContext2D::drawTextInternal):
2511         Wrapped code accessing fallback fonts with local 
2512         FontCachePurgePreventer in these methods.
2513
2514         * page/FrameView.cpp:
2515         (WebCore::FrameView::layout):
2516         (WebCore::FrameView::paintContents):
2517         Wrapped code accessing fallback fonts with local 
2518         FontCachePurgePreventer in these methods.
2519
2520         * platform/graphics/FontCache.cpp:
2521         (WebCore::FontCache::FontCache):
2522         (WebCore::FontCache::getCachedFontData):
2523         Moved purge check to new method since it likely can't happen here.
2524         (WebCore::FontCache::releaseFontData):
2525         (WebCore::FontCache::purgeInactiveFontDataIfNeeded):
2526         (WebCore::FontCache::purgeInactiveFontData):
2527         Made purging conditional on m_purgePreventCount.  Now some fonts
2528         in the cache are reference counted while other can be purged 
2529         outside of code wrapped by in scope FontCachePurgePreventer objects.
2530
2531         * platform/graphics/FontCache.h:
2532         (WebCore::FontCache::disablePurging):
2533         (WebCore::FontCache::enablePurging):
2534         (WebCore::FontCachePurgePreventer::FontCachePurgePreventer):
2535         (WebCore::FontCachePurgePreventer::~FontCachePurgePreventer):
2536         Added new simple purge prevention wrapper class and methods
2537         that it calls in FontCache actually prevent purging.  The
2538         simple methods inlined to reduce overhead.
2539
2540         * platform/graphics/FontFastPath.cpp:
2541         (WebCore::Font::glyphDataForCharacter): Update level in 
2542         glyph page tree for system fallback fonts so pruning works.
2543
2544         * platform/graphics/GlyphPage.h:
2545         (WebCore::GlyphPage::clearForFontData): New method used for pruning
2546         * platform/graphics/GlyphPageTreeNode.cpp:
2547         (WebCore::GlyphPageTreeNode::pruneFontData):
2548         Now we prune system fallback fonts.
2549
2550         * platform/graphics/chromium/FontCacheChromiumWin.cpp:
2551         (WebCore::FontCache::getFontDataForCharacters):
2552         * platform/graphics/freetype/FontCacheFreeType.cpp:
2553         (WebCore::FontCache::getFontDataForCharacters):
2554         * platform/graphics/haiku/FontCacheHaiku.cpp:
2555         (WebCore::FontCache::getFontDataForCharacters):
2556         * platform/graphics/mac/FontCacheMac.mm:
2557         (WebCore::FontCache::getFontDataForCharacters):
2558         * platform/graphics/qt/FontCacheQt.cpp:
2559         (WebCore::FontCache::getFontDataForCharacters):
2560         * platform/graphics/win/FontCacheWin.cpp:
2561         (WebCore::FontCache::getFontDataForCharacters):
2562         * platform/graphics/wince/FontCacheWinCE.cpp:
2563         * platform/graphics/wx/FontCacheWx.cpp:
2564         (WebCore::FontCache::getFontDataForCharacters):
2565         Changed the calls to getFontData() to not increment the reference
2566         count. The caller of this getFontDataForCharacters() (currently only
2567         Font::glyphDataForCharacter() in fontFastPath.cpp) and it's callers
2568         don't attempt to release the returned fonts so we use the purge
2569         protection described above.
2570
2571         * rendering/InlineTextBox.cpp:
2572         (WebCore::InlineTextBox::selectionRect):
2573         (WebCore::InlineTextBox::offsetForPosition):
2574         (WebCore::InlineTextBox::positionForOffset):
2575         Wrapped code accessing fallback fonts with local
2576         FontCachePurgePreventer in these methods.
2577
2578         * rendering/RenderImage.cpp:
2579         (WebCore::RenderImage::setImageSizeForAltText):
2580         Wrapped code accessing fallback fonts with local
2581         FontCachePurgePreventer in this method.
2582
2583         * rendering/RenderListBox.cpp:
2584         (WebCore::RenderListBox::updateFromElement):
2585         (WebCore::RenderListBox::paintItemForeground):
2586         Wrapped code accessing fallback fonts with local
2587         FontCachePurgePreventer in these methods
2588
2589         * rendering/svg/SVGInlineTextBox.cpp:
2590         (WebCore::SVGInlineTextBox::selectionRectForTextFragment):
2591         Wrapped code accessing fallback fonts with local
2592         FontCachePurgePreventer in this method.
2593
2594 2011-06-07  Tim Horton  <timothy_horton@apple.com>
2595
2596         Reviewed by Alexey Proskuryakov.
2597
2598         Use correct CFURLStorageSessionRef definition on Snow Leopard
2599         https://bugs.webkit.org/show_bug.cgi?id=62223
2600
2601         * platform/mac/WebCoreSystemInterface.h:
2602         * platform/network/ResourceHandle.h:
2603         * platform/network/cf/ResourceRequest.h:
2604
2605 2011-06-07  Alok Priyadarshi  <alokp@chromium.org>
2606
2607         Reviewed by Stephen White.
2608
2609         [chromium] PlatformContextSkia leaks SkDeviceFactory
2610         https://bugs.webkit.org/show_bug.cgi?id=62163
2611
2612         Valgrind tests should have caught this.
2613
2614         * platform/graphics/skia/PlatformContextSkia.cpp:
2615         (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
2616
2617 2011-06-07  Emil A Eklund  <eae@chromium.org>
2618
2619         Reviewed by Eric Seidel.
2620
2621         Convert RenderTextControl::hitInnerTextElement to IntPoint
2622         https://bugs.webkit.org/show_bug.cgi?id=62167
2623
2624         Covered by existing tests.
2625
2626         * rendering/RenderTextControl.cpp:
2627         (WebCore::RenderTextControl::hitInnerTextElement):
2628         * rendering/RenderTextControl.h:
2629         * rendering/RenderTextControlMultiLine.cpp:
2630         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
2631         * rendering/RenderTextControlSingleLine.cpp:
2632         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
2633
2634 2011-06-07  Levi Weintraub  <leviw@chromium.org>
2635
2636         Reviewed by Eric Seidel.
2637
2638         Switch paint to use IntPoint
2639         https://bugs.webkit.org/show_bug.cgi?id=62177
2640
2641         Flipping the switch on the remaining paint functions to have them all
2642         use IntPoint for the paint offset instead of tx/ty.
2643
2644         No new tests since this is just refactoring.
2645
2646         * page/FrameView.cpp:
2647         (WebCore::FrameView::paintScrollCorner):
2648         * rendering/InlineBox.cpp:
2649         (WebCore::InlineBox::paint):
2650         * rendering/RenderBlock.cpp:
2651         (WebCore::RenderBlock::paint):
2652         (WebCore::RenderBlock::paintContents):
2653         (WebCore::RenderBlock::paintChildren):
2654         (WebCore::RenderBlock::paintFloats):
2655         * rendering/RenderBlock.h:
2656         * rendering/RenderBox.cpp:
2657         (WebCore::RenderBox::paint):
2658         * rendering/RenderBox.h:
2659         * rendering/RenderBoxModelObject.cpp:
2660         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
2661         * rendering/RenderDetailsMarker.cpp:
2662         (WebCore::RenderDetailsMarker::paint):
2663         * rendering/RenderDetailsMarker.h:
2664         * rendering/RenderEmbeddedObject.cpp:
2665         (WebCore::RenderEmbeddedObject::paint):
2666         * rendering/RenderEmbeddedObject.h:
2667         * rendering/RenderFrameSet.cpp:
2668         (WebCore::RenderFrameSet::paint):
2669         * rendering/RenderFrameSet.h:
2670         * rendering/RenderImage.cpp:
2671         (WebCore::RenderImage::paint):
2672         * rendering/RenderImage.h:
2673         * rendering/RenderInline.cpp:
2674         (WebCore::RenderInline::paint):
2675         * rendering/RenderInline.h:
2676         * rendering/RenderLayer.cpp:
2677         (WebCore::RenderLayer::paintScrollCorner):
2678         (WebCore::RenderLayer::paintResizer):
2679         (WebCore::RenderLayer::paintLayer):
2680         * rendering/RenderLayerBacking.cpp:
2681         (WebCore::RenderLayerBacking::paintIntoLayer):
2682         * rendering/RenderLineBoxList.cpp:
2683         (WebCore::RenderLineBoxList::paint):
2684         * rendering/RenderLineBoxList.h:
2685         * rendering/RenderListItem.cpp:
2686         (WebCore::RenderListItem::paint):
2687         * rendering/RenderListItem.h:
2688         * rendering/RenderListMarker.cpp:
2689         (WebCore::RenderListMarker::paint):
2690         * rendering/RenderListMarker.h:
2691         * rendering/RenderObject.cpp:
2692         (WebCore::RenderObject::paint):
2693         * rendering/RenderObject.h:
2694         * rendering/RenderReplaced.cpp:
2695         (WebCore::RenderReplaced::paint):
2696         * rendering/RenderReplaced.h:
2697         * rendering/RenderReplica.cpp:
2698         (WebCore::RenderReplica::paint):
2699         * rendering/RenderReplica.h:
2700         * rendering/RenderScrollbar.cpp:
2701         (WebCore::RenderScrollbar::paintPart):
2702         * rendering/RenderScrollbarPart.cpp:
2703         (WebCore::RenderScrollbarPart::paintIntoRect):
2704         * rendering/RenderScrollbarPart.h:
2705         * rendering/RenderTable.cpp:
2706         (WebCore::RenderTable::paint):
2707         (WebCore::RenderTable::paintObject):
2708         * rendering/RenderTable.h:
2709         * rendering/RenderTableCell.cpp:
2710         (WebCore::RenderTableCell::paint):
2711         * rendering/RenderTableCell.h:
2712         * rendering/RenderTableRow.cpp:
2713         (WebCore::RenderTableRow::paint):
2714         * rendering/RenderTableRow.h:
2715         * rendering/RenderTableSection.cpp:
2716         (WebCore::RenderTableSection::paint):
2717         (WebCore::RenderTableSection::paintCell):
2718         * rendering/RenderTableSection.h:
2719         * rendering/RenderText.h:
2720         (WebCore::RenderText::paint):
2721         * rendering/RenderTextControlSingleLine.cpp:
2722         (WebCore::RenderTextControlSingleLine::paint):
2723         * rendering/RenderTextControlSingleLine.h:
2724         * rendering/RenderView.cpp:
2725         (WebCore::RenderView::paint):
2726         * rendering/RenderView.h:
2727         * rendering/RenderWidget.cpp:
2728         (WebCore::RenderWidget::paint):
2729         * rendering/RenderWidget.h:
2730         * rendering/mathml/RenderMathMLBlock.cpp:
2731         (WebCore::RenderMathMLBlock::paint):
2732         * rendering/mathml/RenderMathMLBlock.h:
2733         * rendering/mathml/RenderMathMLFraction.cpp:
2734         (WebCore::RenderMathMLFraction::paint):
2735         * rendering/mathml/RenderMathMLFraction.h:
2736         * rendering/mathml/RenderMathMLRoot.cpp:
2737         (WebCore::RenderMathMLRoot::paint):
2738         * rendering/mathml/RenderMathMLRoot.h:
2739         * rendering/mathml/RenderMathMLSquareRoot.cpp:
2740         (WebCore::RenderMathMLSquareRoot::paint):
2741         * rendering/mathml/RenderMathMLSquareRoot.h:
2742         * rendering/svg/RenderSVGContainer.cpp:
2743         (WebCore::RenderSVGContainer::paint):
2744         * rendering/svg/RenderSVGContainer.h:
2745         * rendering/svg/RenderSVGForeignObject.cpp:
2746         (WebCore::RenderSVGForeignObject::paint):
2747         * rendering/svg/RenderSVGForeignObject.h:
2748         * rendering/svg/RenderSVGHiddenContainer.cpp:
2749         (WebCore::RenderSVGHiddenContainer::paint):
2750         * rendering/svg/RenderSVGHiddenContainer.h:
2751         * rendering/svg/RenderSVGImage.cpp:
2752         (WebCore::RenderSVGImage::paint):
2753         * rendering/svg/RenderSVGImage.h:
2754         * rendering/svg/RenderSVGPath.cpp:
2755         (WebCore::RenderSVGPath::paint):
2756         * rendering/svg/RenderSVGPath.h:
2757         * rendering/svg/RenderSVGResourceMarker.cpp:
2758         (WebCore::RenderSVGResourceMarker::draw):
2759         * rendering/svg/RenderSVGRoot.cpp:
2760         (WebCore::RenderSVGRoot::paint):
2761         * rendering/svg/RenderSVGRoot.h:
2762         * rendering/svg/RenderSVGText.cpp:
2763         (WebCore::RenderSVGText::paint):
2764         * rendering/svg/RenderSVGText.h:
2765         * rendering/svg/SVGImageBufferTools.cpp:
2766         (WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer):
2767
2768 2011-06-07  Young Han Lee  <joybro@company100.net>
2769
2770         Reviewed by Kenneth Rohde Christiansen.
2771
2772         [Texmap][Qt] Accelerated animation is not paused properly.
2773         https://bugs.webkit.org/show_bug.cgi?id=61446
2774
2775         The transform matrix of an accelerated animation shouldn't be synced with the matrix of the GraphicsLayer when the animation is paused.
2776
2777         Test: animations/play-state-paused.html
2778
2779         * platform/graphics/texmap/TextureMapperNode.cpp:
2780         (WebCore::TextureMapperNode::syncCompositingStateSelf):
2781         (WebCore::TextureMapperNode::hasOpacityAnimation):
2782         (WebCore::TextureMapperNode::hasTransformAnimation):
2783         * platform/graphics/texmap/TextureMapperNode.h:
2784
2785 2011-06-07  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2786
2787         Reviewed by Antonio Gomes.
2788
2789         [EFL] Remove Ecore_X bits from PlatformScreenEfl
2790         https://bugs.webkit.org/show_bug.cgi?id=61649
2791
2792         Remove the need for Ecore_X and some X calls by always using
2793         new functions available in EFL to get the screen size.
2794
2795         No new tests since the same functionality are done inside EFL now.
2796
2797         * platform/efl/PlatformScreenEfl.cpp:
2798         (WebCore::screenRect):
2799
2800 2011-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2801
2802         Reviewed by Martin Robinson.
2803
2804         [GTK] Move moduleMixesGtkSymbols() from PluginPackage to PluginView
2805         https://bugs.webkit.org/show_bug.cgi?id=62200
2806
2807         In WebKit2 PluginPackage is used by the UI process to load plugins
2808         in order to get information about them, but it doesn't use any GTK
2809         symbol. So the UI process should be able to load plugins even when
2810         building with GTK3, but we should not allow the plugin view to use
2811         the plugin if it mixes GTK2 and GTK3 symbols.
2812
2813         * plugins/PluginPackage.h:
2814         (WebCore::PluginPackage::module): New method to return the
2815         platform module.
2816         * plugins/gtk/PluginPackageGtk.cpp:
2817         (WebCore::PluginPackage::load): Remove moduleMixesGtkSymbols().
2818         * plugins/gtk/PluginViewGtk.cpp:
2819         (WebCore::PluginView::updatePluginWidget): Check whether plugin
2820         was successfully loaded before trying to create the drawable.
2821         (WebCore::PluginView::paint): Return early if plugin didn't start
2822         or was not successfully loaded.
2823         (WebCore::PluginView::handleKeyboardEvent): Ditto.
2824         (WebCore::PluginView::handleMouseEvent): Ditto.
2825         (WebCore::PluginView::handleFocusInEvent): Ditto.
2826         (WebCore::PluginView::handleFocusOutEvent): Ditto.
2827         (WebCore::moduleMixesGtkSymbols):
2828         (WebCore::PluginView::platformStart): Check whether module is
2829         mixing GTK+ 2 and GTK+ 3 symbols.
2830
2831 2011-06-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2832
2833         Unreviewed, rolling out r88238.
2834         http://trac.webkit.org/changeset/88238
2835         https://bugs.webkit.org/show_bug.cgi?id=62216
2836
2837         Broke a couple of inspector tests (Requested by apavlov on
2838         #webkit).
2839
2840         * inspector/front-end/StylesSidebarPane.js:
2841         (WebInspector.StylesSidebarPane.prototype.update):
2842
2843 2011-06-07  Dinu Jacob  <dinu.jacob@nokia.com>
2844
2845         Reviewed by Dimitri Glazkov.
2846
2847         Inform ChromeClient touch events are not needed by the webpage when navigating away from the page instead of in both Document:detach/CachedFrame
2848         https://bugs.webkit.org/show_bug.cgi?id=61543
2849
2850         Inform chrome client that touch events are not needed by the webpage 
2851         when navigating away from the page only once to avoid the flag being 
2852         overwritten later if a page is removed from the page cache
2853
2854         * dom/Document.cpp:
2855         (WebCore::Document::detach):
2856         * history/CachedFrame.cpp:
2857         (WebCore::CachedFrame::CachedFrame):
2858         * loader/FrameLoader.cpp:
2859         (WebCore::FrameLoader::transitionToCommitted):
2860
2861 2011-06-07  Alexander Pavlov  <apavlov@chromium.org>
2862
2863         Reviewed by Yury Semikhatsky.
2864
2865         Web Inspector: node selection is slow in the Elements panel.
2866         https://bugs.webkit.org/show_bug.cgi?id=60813
2867
2868         Schedule full style updates rather than request all node styles from the backend immediately.
2869
2870         * inspector/front-end/StylesSidebarPane.js:
2871         (WebInspector.StylesSidebarPane.prototype.update.reloadAllStyles):
2872         (WebInspector.StylesSidebarPane.prototype.update):
2873
2874 2011-06-07  Yury Semikhatsky  <yurys@chromium.org>
2875
2876         Reviewed by Pavel Feldman.
2877
2878         Web Inspector: remove duplicate breakpoints from localStorage
2879         https://bugs.webkit.org/show_bug.cgi?id=62206
2880
2881         Perform one-time breakpoint storage cleanup to get rid of duplicate breakpoints in
2882         case when settings version is less than 1. 
2883
2884         * inspector/front-end/Settings.js:
2885         (WebInspector.Settings):
2886         (WebInspector.Settings.prototype._set):
2887         (WebInspector.Settings.prototype._migrateSettings.splitObjects):
2888         (WebInspector.Settings.prototype._migrateSettings.removeDuplicateObjects):
2889         (WebInspector.Settings.prototype._migrateSettings):
2890
2891 2011-06-03  Yury Semikhatsky  <yurys@chromium.org>
2892
2893         Reviewed by Pavel Feldman.
2894
2895         [Chromium] Web Inspector: correctly handle disconnect from worker when script execution is paused
2896         https://bugs.webkit.org/show_bug.cgi?id=62019
2897
2898         Dispatch disconnecFrontend message in debugger task mode to make sure
2899         it is processed even if execution is paused.
2900
2901         * bindings/v8/WorkerScriptDebugServer.cpp:
2902         (WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
2903         (WebCore::WorkerScriptDebugServer::quitMessageLoopOnPause):
2904         * bindings/v8/WorkerScriptDebugServer.h:
2905
2906 2011-06-07  Felician Marton  <marton.felician.zoltan@stud.u-szeged.hu>
2907
2908         Reviewed by Nikolas Zimmermann.
2909
2910         SVG animation beginElement() does not restart the animation after endElement().
2911         https://bugs.webkit.org/show_bug.cgi?id=43452
2912
2913         Test: svg/animations/animate-endElement-beginElement.html
2914
2915         Calling beginElement() after calling endElement() previously does not restarted the animation when animation
2916         element's end attribute doesn't contains a bigger value than the current animation time.
2917
2918         * svg/animation/SVGSMILElement.cpp:
2919         (WebCore::SVGSMILElement::findInstanceTime):
2920
2921 2011-06-07  Naoki Takano  <takano.naoki@gmail.com>
2922
2923         Reviewed by Kent Tamura.
2924
2925         [Chromium] Click event is not fired for a menulist <select>
2926         https://bugs.webkit.org/show_bug.cgi?id=60563
2927
2928         Tests: SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange in webkit_unit_tests.
2929
2930         * platform/chromium/PopupMenuChromium.cpp:
2931         (WebCore::PopupContainer::showPopup): Set m_focusedNode from m_frameView.
2932         (WebCore::PopupListBox::handleMouseReleaseEvent): Call dispatchMouseEvent to forward the event only if select popup.
2933         (WebCore::PopupListBox::acceptIndex): Change to return accepted or not.
2934
2935 2011-06-07  Andras Becsi  <abecsi@webkit.org>
2936
2937         Reviewed by Yury Semikhatsky.
2938  
2939         REGRESSION(r88221): "Chromium debug compilation broken".
2940         https://bugs.webkit.org/show_bug.cgi?id=62197
2941
2942         No new tests needed.
2943
2944         * bindings/v8/V8GCController.cpp: Also rename call-sites.
2945         (WebCore::V8GCController::gcPrologue):
2946         (WebCore::V8GCController::gcEpilogue):
2947
2948 2011-06-07  MORITA Hajime  <morrita@google.com>
2949
2950         Unreviewed, rolling out r88212 and r88219.
2951         http://trac.webkit.org/changeset/88212
2952         http://trac.webkit.org/changeset/88219
2953         https://bugs.webkit.org/show_bug.cgi?id=57439
2954
2955         Tests get timeout at Snow Leopard
2956
2957         * css/html.css:
2958         (html:focus, body:focus, input[readonly]:focus):
2959         * rendering/RenderWidget.cpp:
2960         (WebCore::RenderWidget::paint):
2961
2962 2011-06-07  Andras Becsi  <abecsi@webkit.org>
2963
2964         Rubber-stamped by Csaba Osztrogonác.
2965
2966         [Qt][V8] Fix the build after 88221.
2967
2968         No new tests needed.
2969
2970         * WebCore.pro: Remove non-existing files.
2971         * bindings/v8/V8DOMMap.cpp: 
2972         (WebCore::removeAllDOMObjects): Also rename the definition of the function.
2973
2974 2011-06-06  Dmitry Lomov  <dslomov@google.com>
2975
2976         Reviewed by Adam Barth.
2977
2978         https://bugs.webkit.org/show_bug.cgi?id=62164
2979         Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and friends
2980         This functionality is untested and unused:
2981         This is an old code from Lockers-based implementation of WebWorkers in
2982         V8 bindings, to make sure that DOM objects are released on the right thread
2983         even though GC could have happened on any thread. It is currently unused (since
2984         current model is one worker per process) and is being removed because new implementation
2985         of WebWorkers will be using V8 isolates.
2986
2987         * WebCore.gypi:
2988         * bindings/v8/ChildThreadDOMData.cpp: Removed.
2989         * bindings/v8/ChildThreadDOMData.h: Removed.
2990         * bindings/v8/DOMData.cpp:
2991         (WebCore::DOMData::DOMData):
2992         (WebCore::DOMData::getCurrent):
2993         (WebCore::DOMData::getMainThreadStore):
2994         * bindings/v8/DOMData.h:
2995         (WebCore::DOMData::getStore):
2996         (WebCore::DOMData::getCurrentMainThreadStore):
2997         (WebCore::DOMData::handleWeakObject):
2998         * bindings/v8/DOMDataStore.cpp:
2999         (WebCore::DOMDataStore::DOMDataStore):
3000         (WebCore::DOMDataStore::~DOMDataStore):
3001         (WebCore::DOMDataStore::weakNodeCallback):
3002         * bindings/v8/DOMDataStore.h:
3003         * bindings/v8/MainThreadDOMData.cpp: Removed.
3004         * bindings/v8/MainThreadDOMData.h: Removed.
3005         * bindings/v8/V8DOMMap.cpp:
3006         (WebCore::getDOMDataStore):
3007         (WebCore::visitDOMNodes):
3008         (WebCore::visitDOMObjects):
3009         (WebCore::visitActiveDOMObjects):
3010         (WebCore::visitDOMSVGElementInstances):
3011         * bindings/v8/V8DOMMap.h:
3012         * bindings/v8/V8GCController.cpp:
3013         (WebCore::V8GCController::gcPrologue):
3014         (WebCore::V8GCController::gcEpilogue):
3015         * bindings/v8/WorkerScriptController.cpp:
3016         (WebCore::WorkerScriptController::~WorkerScriptController):
3017
3018 2011-06-06  Nico Weber  <thakis@chromium.org>
3019
3020         Reviewed by Adam Barth.
3021
3022         [chromium] Make VideoFrameChromium's destructor virtual
3023         https://bugs.webkit.org/show_bug.cgi?id=62186
3024
3025         This fixes a real bug, since WebMediaPlayerClientImpl::putCurrentFrame
3026         deletes a VideoFrameChromium subclass type through this interface
3027         class, causing ~VideoFrameChromiumImpl's destructor not to run.
3028         (VideoFrameChroimumImpl happens to not have a destructor or any
3029         non-POD member variables, so it's more a latent bug.)
3030
3031         * platform/graphics/chromium/VideoFrameChromium.cpp:
3032         (WebCore::VideoFrameChromium::~VideoFrameChromium):
3033         * platform/graphics/chromium/VideoFrameChromium.h:
3034
3035 2011-06-06  Simon Fraser  <simon.fraser@apple.com>
3036
3037         Reviewed by Sammy Weinig.
3038
3039         Remove some unnecessary includes from AnimationBase.cpp
3040         https://bugs.webkit.org/show_bug.cgi?id=62183
3041
3042         * page/animation/AnimationBase.cpp:
3043
3044 2011-06-06  Kent Tamura  <tkent@chromium.org>
3045
3046         Unreviewed, a crash fix by a roll out.
3047
3048         REGRESSION(r87980): Null pointer dereference in RenderTextControl::setInnerText()
3049         https://bugs.webkit.org/show_bug.cgi?id=62116
3050
3051         Roll out the WebCore part of r87980.
3052
3053         * html/SearchInputType.cpp:
3054         (WebCore::SearchInputType::SearchInputType):
3055         (WebCore::SearchInputType::createShadowSubtree):
3056         (WebCore::SearchInputType::destroyShadowSubtree):
3057         * html/SearchInputType.h:
3058         (WebCore::SearchInputType::innerBlockElement):
3059         (WebCore::SearchInputType::resultsButtonElement):
3060         (WebCore::SearchInputType::cancelButtonElement):
3061         * html/TextFieldInputType.cpp:
3062         (WebCore::TextFieldInputType::TextFieldInputType):
3063         (WebCore::TextFieldInputType::createShadowSubtree):
3064         (WebCore::TextFieldInputType::destroyShadowSubtree):
3065         * html/TextFieldInputType.h:
3066         (WebCore::TextFieldInputType::innerTextElement):
3067         (WebCore::TextFieldInputType::innerSpinButtonElement):
3068         (WebCore::TextFieldInputType::speechButtonElement):
3069         (WebCore::TextFieldInputType::setInnerTextElement):
3070         (WebCore::TextFieldInputType::setSpeechButtonElement):
3071         * html/shadow/TextControlInnerElements.cpp:
3072         * html/shadow/TextControlInnerElements.h:
3073
3074 2011-06-06  No'am Rosenthal  <noam.rosenthal@nokia.com>
3075
3076         Reviewed by Simon Fraser.
3077
3078         Allow copying of KeyframeValueList.
3079         https://bugs.webkit.org/show_bug.cgi?id=62171
3080
3081         Make a deep copy of KeyframeValueList, copying each of the keyframes with a virtual clone() function.
3082
3083         No new functionality so no new tests.
3084
3085         * platform/graphics/GraphicsLayer.h:
3086         (WebCore::FloatAnimationValue::clone):
3087         (WebCore::TransformAnimationValue::TransformAnimationValue):
3088         (WebCore::TransformAnimationValue::clone):
3089         (WebCore::TransformAnimationValue::value):
3090         (WebCore::KeyframeValueList::KeyframeValueList):
3091
3092 2011-06-06  Simon Fraser  <simon.fraser@apple.com>
3093
3094         Reviewed by Dan Bernstein.
3095
3096         Incorrect rounding of color values during transitions
3097         https://bugs.webkit.org/show_bug.cgi?id=62141
3098         
3099         When blending integers, round to the nearest integer, instead of always rounding down.
3100
3101         Test: transitions/color-transition-rounding.html
3102
3103         * page/animation/AnimationBase.cpp:
3104         (WebCore::blendFunc):
3105
3106 2011-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
3107
3108         Unreviewed, rolling out r88202.
3109         http://trac.webkit.org/changeset/88202
3110         https://bugs.webkit.org/show_bug.cgi?id=62182
3111
3112         This broke the mac clang bot (Requested by koz__ on #webkit).
3113
3114         * dom/Node.cpp:
3115         (WebCore::Node::hasNonEmptyBoundingBox):
3116         * rendering/InlineBox.h:
3117         * rendering/RenderBlock.cpp:
3118         (WebCore::RenderBlock::absoluteRects):
3119         * rendering/RenderBlock.h:
3120         * rendering/RenderBox.cpp:
3121         (WebCore::RenderBox::absoluteRects):
3122         * rendering/RenderBox.h:
3123         * rendering/RenderInline.cpp:
3124         (WebCore::RenderInline::absoluteRects):
3125         * rendering/RenderInline.h:
3126         * rendering/RenderObject.cpp:
3127         (WebCore::RenderObject::absoluteBoundingBoxRect):
3128         * rendering/RenderObject.h:
3129         (WebCore::RenderObject::absoluteRects):
3130         * rendering/RenderText.cpp:
3131         (WebCore::RenderText::absoluteRects):
3132         * rendering/RenderText.h:
3133         * rendering/RenderView.cpp:
3134         (WebCore::RenderView::absoluteRects):
3135         * rendering/RenderView.h:
3136
3137 2011-06-06  Noel Gordon  <noel.gordon@gmail.com>
3138
3139         Reviewed by Hajime Morita.
3140
3141         Draw CSS outline style for render widgets: iframe, embed, object, applet.
3142         https://bugs.webkit.org/show_bug.cgi?id=57439
3143
3144         Draw CSS outlines for render widgets: iframe, embed, object, applet. These elements can
3145         be focused (via clicks or tabIndex) but should not have a visible focus ring by default.
3146
3147         Tests: fast/replaced/no-focus-ring-embed-1.html
3148                fast/replaced/no-focus-ring-embed-2.html
3149                fast/replaced/no-focus-ring-iframe.html
3150                fast/replaced/no-focus-ring-object-1.html
3151                fast/replaced/no-focus-ring-object-2.html
3152                fast/replaced/outline-replaced-elements.html
3153
3154         * css/html.css:
3155         (applet:focus, embed:focus, iframe:focus, object:focus):  Default to no focus ring.
3156         * rendering/RenderWidget.cpp:
3157         (WebCore::RenderWidget::paint): Paint the render widget CSS outline style.
3158
3159 2011-06-06  MORITA Hajime  <morrita@google.com>
3160
3161         Reviewed by Kent Tamura.
3162
3163         Assertion fails in TextCheckingHelper by right-clicking on <input type=search>
3164         https://bugs.webkit.org/show_bug.cgi?id=61991
3165
3166         Added a guard bofore TextCheckingHelper construction sites.
3167
3168         Test: editing/spelling/spellcheck-input-search-crash.html
3169
3170         * editing/Editor.cpp:
3171         (WebCore::Editor::isSelectionUngrammatical):
3172         (WebCore::Editor::guessesForUngrammaticalSelection):
3173         (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection):
3174
3175 2011-06-06  Emil A Eklund  <eae@chromium.org>
3176
3177         Reviewed by Eric Seidel.
3178
3179         Update RenderBlock::paint to use IntPoint internally
3180         https://bugs.webkit.org/show_bug.cgi?id=62140
3181
3182         Covered by existing tests.
3183
3184         * rendering/RenderBlock.cpp:
3185         (WebCore::RenderBlock::paint):
3186
3187 2011-06-06  Emil A Eklund  <eae@chromium.org>
3188
3189         Reviewed by Eric Seidel.
3190
3191         Convert RenderBox::absoluteRects to IntPoint
3192         https://bugs.webkit.org/show_bug.cgi?id=62130
3193
3194         Covered by existing tests.
3195
3196         * dom/Node.cpp:
3197         (WebCore::Node::hasNonEmptyBoundingBox):
3198         * rendering/RenderBlock.cpp:
3199         (WebCore::RenderBlock::absoluteRects):
3200         * rendering/RenderBlock.h:
3201         * rendering/RenderBox.cpp:
3202         (WebCore::RenderBox::absoluteRects):
3203         * rendering/RenderBox.h:
3204         * rendering/RenderInline.cpp:
3205         (WebCore::RenderInline::absoluteRects):
3206         * rendering/RenderInline.h:
3207         * rendering/RenderObject.cpp:
3208         (WebCore::RenderObject::absoluteBoundingBoxRect):
3209         * rendering/RenderObject.h:
3210         (WebCore::RenderObject::absoluteRects):
3211         * rendering/RenderText.cpp:
3212         (WebCore::RenderText::absoluteRects):
3213         * rendering/RenderText.h:
3214         * rendering/RenderView.cpp:
3215         (WebCore::RenderView::absoluteRects):
3216         * rendering/RenderView.h:
3217
3218 2011-06-06  Levi Weintraub  <leviw@chromium.org>
3219
3220         Reviewed by Eric Seidel.
3221
3222         Switch shouldPaint to use IntPoint
3223         https://bugs.webkit.org/show_bug.cgi?id=62158
3224
3225         Switching shouldPaint to take an IntPoint representing the paint offset instead
3226         of a pair of ints.
3227
3228         No new tests as this is simple refactoring.
3229
3230         * rendering/RenderReplaced.cpp:
3231         (WebCore::RenderReplaced::paint):
3232         (WebCore::RenderReplaced::shouldPaint):
3233         * rendering/RenderReplaced.h:
3234         * rendering/RenderWidget.cpp:
3235         (WebCore::RenderWidget::paint):
3236
3237 2011-06-06  James Simonsen  <simonjam@chromium.org>
3238
3239         Reviewed by James Robinson.
3240
3241         Add monotonicallyIncreasingTime() to get monotonically increasing time
3242         https://bugs.webkit.org/show_bug.cgi?id=37743
3243
3244         * platform/chromium/SystemTimeChromium.cpp:
3245         (WebCore::monotonicallyIncreasingTime): Add primitive monotonicallyIncreasingTime() which just wraps currentTime().
3246
3247 2011-06-06  Emil A Eklund  <eae@chromium.org>
3248
3249         Reviewed by Eric Seidel.
3250
3251         Convert RenderBox::pushContentsClip to IntPoint
3252         https://bugs.webkit.org/show_bug.cgi?id=62133
3253
3254         Covered by existing tests.
3255
3256         * rendering/RenderBlock.cpp:
3257         (WebCore::Covered by existing tests.RenderBlock::paint):
3258         * rendering/RenderBox.cpp:
3259         (WebCore::RenderBox::pushContentsClip):
3260         * rendering/RenderBox.h:
3261         * rendering/RenderTable.cpp:
3262         (WebCore::RenderTable::paint):
3263         * rendering/RenderTableSection.cpp:
3264         (WebCore::RenderTableSection::paint):
3265
3266 2011-06-06  Levi Weintraub  <leviw@chromium.org>
3267
3268         Reviewed by Eric Seidel.
3269
3270         Switch InlineFlowBox::paintMask to use IntPoint
3271         https://bugs.webkit.org/show_bug.cgi?id=62156
3272
3273         Switching InlineFlowBox::paintMask to take an IntPoint representing the paint
3274         offset instead of a pair of ints.
3275
3276         No new tests as this is simple refactoring.
3277
3278         * rendering/InlineFlowBox.cpp:
3279         (WebCore::InlineFlowBox::paint):
3280         (WebCore::InlineFlowBox::paintMask):
3281         * rendering/InlineFlowBox.h:
3282
3283 2011-06-06  Emil A Eklund  <eae@chromium.org>
3284
3285         Reviewed by Eric Seidel.
3286
3287         Convert hitTest to IntPoint
3288         https://bugs.webkit.org/show_bug.cgi?id=62144
3289
3290         Covered by existing tests.
3291
3292         * rendering/InlineBox.cpp:
3293         (WebCore::InlineBox::nodeAtPoint):
3294         * rendering/RenderBlock.cpp:
3295         (WebCore::RenderBlock::hitTestFloats):
3296         (WebCore::RenderBlock::hitTestContents):
3297         * rendering/RenderInline.cpp:
3298         (WebCore::RenderInline::nodeAtPoint):
3299         * rendering/RenderLayer.cpp:
3300         (WebCore::RenderLayer::hitTestContents):
3301         * rendering/RenderLayer.h:
3302         (WebCore::RenderLayer::renderBoxLocation):
3303         (WebCore::RenderLayer::renderBoxX):
3304         (WebCore::RenderLayer::renderBoxY):
3305         * rendering/RenderLineBoxList.cpp:
3306         (WebCore::RenderLineBoxList::hitTest):
3307         * rendering/RenderLineBoxList.h:
3308         * rendering/RenderObject.cpp:
3309         (WebCore::RenderObject::hitTest):
3310         * rendering/RenderObject.h:
3311
3312 2011-06-06  Levi Weintraub  <leviw@chromium.org>
3313
3314         Reviewed by Eric Seidel.
3315
3316         Switch paintScrollbar to use IntPoint
3317         https://bugs.webkit.org/show_bug.cgi?id=62151
3318
3319         Switching paintScrollbar to use IntPoint instead of a pair of ints.
3320
3321         No new tests since this is simple refactoring.
3322
3323         * rendering/RenderListBox.cpp:
3324         (WebCore::RenderListBox::paintObject):
3325         (WebCore::RenderListBox::paintScrollbar):
3326         * rendering/RenderListBox.h:
3327
3328 2011-06-06  Daniel Cheng  <dcheng@chromium.org>
3329
3330         Reviewed by Tony Chang.
3331
3332         [chromium] Delete dead clipboard code.
3333         https://bugs.webkit.org/show_bug.cgi?id=62113
3334
3335         No new tests since this change only deleted unused code.
3336
3337         * WebCore.gypi:
3338         * platform/chromium/ChromiumDataObjectLegacy.cpp: Removed.
3339         * platform/chromium/ChromiumDataObjectLegacy.h: Removed.
3340         * platform/chromium/ReadableDataObject.cpp: Removed.
3341         * platform/chromium/ReadableDataObject.h: Removed.
3342         * platform/chromium/WritableDataObject.cpp: Removed.
3343         * platform/chromium/WritableDataObject.h: Removed.
3344
3345 2011-06-06  Levi Weintraub  <leviw@chromium.org>
3346
3347         Reviewed by Eric Seidel.
3348
3349         Switch paintOutline, paintContinuationOutlines, and paintOutlineForLine to use IntPoint
3350         https://bugs.webkit.org/show_bug.cgi?id=62137
3351
3352         Switching paintOutline, paintContinuationOutlines, and paintOutlineForLine to take an IntPoint
3353         representing the paint offset instead of a pair of ints.
3354
3355         No new tests as this is simple refactoring.
3356
3357         * rendering/RenderBlock.cpp:
3358         (WebCore::RenderBlock::paintObject):
3359         (WebCore::RenderBlock::paintContinuationOutlines):
3360         * rendering/RenderBlock.h:
3361         * rendering/RenderInline.cpp:
3362         (WebCore::RenderInline::paintOutline):
3363         (WebCore::RenderInline::paintOutlineForLine):
3364         * rendering/RenderInline.h:
3365         * rendering/RenderLineBoxList.cpp:
3366         (WebCore::RenderLineBoxList::paint):
3367
3368 2011-06-06  Emil A Eklund  <eae@chromium.org>
3369
3370         Reviewed by Eric Seidel.
3371
3372         Convert RenderBox::popContentsClip to IntPoint
3373         https://bugs.webkit.org/show_bug.cgi?id=62132
3374
3375         Covered by existing tests.
3376
3377         * rendering/RenderBlock.cpp:
3378         (WebCore::RenderBlock::paint):
3379         * rendering/RenderBox.cpp:
3380         (WebCore::RenderBox::popContentsClip):
3381         * rendering/RenderBox.h:
3382         * rendering/RenderTable.cpp:
3383         (WebCore::RenderTable::paint):
3384         * rendering/RenderTableSection.cpp:
3385         (WebCore::RenderTableSection::paint):
3386
3387 2011-06-06  Levi Weintraub  <leviw@chromium.org>
3388
3389         Reviewed by Eric Seidel.
3390
3391         Remove tx/ty offset from selectionRect
3392         https://bugs.webkit.org/show_bug.cgi?id=62146
3393
3394         Removing unused offset parameters from selectionRect.
3395
3396         No new tests since this is just cleanup.
3397
3398         * rendering/EllipsisBox.cpp:
3399         (WebCore::EllipsisBox::selectionRect):
3400         * rendering/EllipsisBox.h:
3401         * rendering/InlineTextBox.cpp:
3402         (WebCore::InlineTextBox::selectionRect):
3403         * rendering/InlineTextBox.h:
3404         * rendering/RenderText.cpp:
3405         (WebCore::RenderText::absoluteRectsForRange):
3406         (WebCore::ellipsisRectForBox):
3407         (WebCore::RenderText::absoluteQuadsForRange):
3408         (WebCore::RenderText::selectionRectForRepaint):
3409         * rendering/svg/RenderSVGInlineText.cpp:
3410         (WebCore::RenderSVGInlineText::localCaretRect):
3411         * rendering/svg/SVGInlineTextBox.cpp:
3412         (WebCore::SVGInlineTextBox::selectionRect):
3413         * rendering/svg/SVGInlineTextBox.h:
3414
3415 2011-06-06  Paul Kinlan  <paulkinlan@google.com>
3416
3417         Reviewed by Jeremy Orlow.
3418
3419         Let developers call createEvent("PopStateEvent"), previously it wasn't
3420         exposed and threw an exeception. 
3421         https://bugs.webkit.org/show_bug.cgi?id=62099
3422
3423         * WebCore/dom/Document.cpp:
3424         * WebCore/dom/PopStateEvent.cpp:
3425         * WebCore/dom/PopStateEvent.h:
3426
3427 2011-06-03  Levi Weintraub  <leviw@chromium.org>
3428
3429         Reviewed by Eric Seidel.
3430
3431         Switch paintSelection to use IntPoint
3432         https://bugs.webkit.org/show_bug.cgi?id=62059
3433
3434         Switching paintSelection to use an IntPoint to represent the paint offset
3435         instead of a pair of ints.
3436
3437         No new tests since this is simple refactoring.
3438
3439         * rendering/EllipsisBox.cpp:
3440         (WebCore::EllipsisBox::paint):
3441         (WebCore::EllipsisBox::paintSelection):
3442         * rendering/EllipsisBox.h:
3443         * rendering/RenderBlock.cpp:
3444         (WebCore::RenderBlock::paintObject):
3445         (WebCore::RenderBlock::paintSelection):
3446         * rendering/RenderBlock.h:
3447
3448 2011-06-06  Emil A Eklund  <eae@chromium.org>
3449
3450         Reviewed by Eric Seidel.
3451
3452         Convert RenderBox::clipRect to IntPoint
3453         https://bugs.webkit.org/show_bug.cgi?id=62045
3454
3455         Covered by existing tests.
3456
3457         * rendering/RenderBox.cpp:
3458         (WebCore::RenderBox::clipRect):
3459         * rendering/RenderBox.h:
3460         * rendering/RenderLayer.cpp:
3461         (WebCore::RenderLayer::calculateClipRects):
3462         (WebCore::RenderLayer::calculateRects):
3463         (WebCore::RenderLayer::repaintBlockSelectionGaps):
3464         * rendering/RenderLayerBacking.cpp:
3465         (WebCore::clipBox):
3466
3467 2011-06-06  Peter Kasting  <pkasting@google.com>
3468
3469         Reviewed by Antonio Gomes.
3470
3471         Remove unnecessary args from scroll functions.
3472         https://bugs.webkit.org/show_bug.cgi?id=61648
3473
3474         No behavior change, so no tests.
3475
3476         * WebCore.exp.in:
3477         * WebCore.order:
3478         * dom/Element.cpp:
3479         (WebCore::Element::scrollIntoView):
3480         (WebCore::Element::scrollIntoViewIfNeeded):
3481         * editing/FrameSelection.cpp:
3482         (WebCore::FrameSelection::revealSelection):
3483         * page/EventHandler.cpp:
3484         (WebCore::EventHandler::handleMousePressEvent):
3485         * page/FrameView.cpp:
3486         (WebCore::FrameView::scrollToAnchor):
3487         * rendering/RenderBox.cpp:
3488         (WebCore::RenderBox::canBeScrolledAndHasScrollableArea):
3489         (WebCore::RenderBox::canBeProgramaticallyScrolled):
3490         * rendering/RenderBox.h:
3491         * rendering/RenderLayer.cpp:
3492         (WebCore::RenderLayer::scrollRectToVisible):
3493         (WebCore::RenderLayer::autoscroll):
3494         * rendering/RenderLayer.h:
3495         * rendering/RenderListBox.h:
3496         (WebCore::RenderListBox::canBeProgramaticallyScrolled):
3497         * rendering/RenderTextControl.h:
3498         (WebCore::RenderTextControl::canBeProgramaticallyScrolled):
3499
3500 2011-06-06  Levi Weintraub  <leviw@chromium.org>
3501
3502         Reviewed by Eric Seidel.
3503
3504         Switch paintContents, paintColumnContents, paintColumnRules, and paintSelection to use IntPoint
3505         https://bugs.webkit.org/show_bug.cgi?id=62134
3506
3507         Switching paintContents, paintColumnContents, paintColumnRules, and paintSelection to take an
3508         IntPoint representing the paint offset instead of a pair of ints.
3509
3510         No new tests as this simple refactoring.
3511
3512         * rendering/RenderBlock.cpp:
3513         (WebCore::RenderBlock::paintColumnRules):