Source/WebCore/ChangeLog

   1 2011-01-17  Dan Bernstein  <mitz@apple.com>
   2
   3         Rubber-stamped by Mark Rowe.
   4
   5         Update xcodeproj svn:ignore to include xcuserdata.
   6
   7         * WebCore.xcodeproj: Modified property svn:ignore.
   8         * manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Modified property svn:ignore.
   9
  10 2011-01-17  Alexey Proskuryakov  <ap@apple.com>
  11
  12         Leopard build fix.
  13
  14         * page/PrintContext.cpp: GCC complained about shortening a double value to float.
  15
  16 2011-01-17  Alexey Proskuryakov  <ap@apple.com>
  17
  18         Reviewed by Dan Bernstein.
  19
  20         https://bugs.webkit.org/show_bug.cgi?id=52495
  21
  22         No change in behavior, so no tests.
  23
  24         * WebCore.exp.in: Export additional methods, as I'm going to use more code from PrintContext.
  25
  26         * page/PrintContext.cpp:
  27         (WebCore::PrintContext::~PrintContext): No need to clear m_pageRects, the object is being
  28         destroyed already.
  29         (WebCore::PrintContext::pageCount): Changed page count from int to size_t.
  30         (WebCore::PrintContext::pageRect): Ditto.
  31         (WebCore::PrintContext::computePageRects): Pass allowHorizontalTiling as an argument.
  32         PrintContext already has code to calculate scale factor, so it makes sense to make methods
  33         that contain it universal (allowHorizontalTiling is always true for Safari).
  34         Round page height to an integer, because Mac code does that, and because page height is
  35         treated as integer almost everywhere else in code.
  36         (WebCore::PrintContext::begin): Allow calling this function multiple times. There is no need
  37         to return to screen mode if e.g. "print backgounds" option changes.
  38         (WebCore::PrintContext::computeAutomaticScaleFactor): Expose scale factor computation, so
  39         that clients don't have to copy it.
  40         (WebCore::PrintContext::spoolRect): Add a way to spool a precomputed rect - handy if a request
  41         comes from code that doesn't have page number.
  42         (WebCore::PrintContext::pageNumberForElement): Page number int -> size_t.
  43
  44         * page/PrintContext.h: Added comments and FIXMEs. PrintContext needs cleanup, but that
  45         depends on deciding how it really needs to work (e.g. whether computePageRects() should
  46         cause relayout).
  47
  48 2011-01-17  Pavel Feldman  <pfeldman@chromium.org>
  49
  50         Reviewed by Yury Semikhatsky.
  51
  52         Web Inspector: unify image data source assignment, add image url
  53         to the image view properties list.
  54         https://bugs.webkit.org/show_bug.cgi?id=52584
  55
  56         * English.lproj/localizedStrings.js:
  57         * inspector/front-end/ImageView.js:
  58         (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
  59         (WebInspector.ImageView.prototype._createContentIfNeeded):
  60         * inspector/front-end/NetworkPanel.js:
  61         (WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
  62         * inspector/front-end/Resource.js:
  63         (WebInspector.Resource.prototype.populateImageSource):
  64         (WebInspector.Resource.prototype._contentURL):
  65         * inspector/front-end/ResourcesPanel.js:
  66         (WebInspector.FrameResourceTreeElement.prototype.onattach):
  67
  68 2011-01-17  Andrey Kosyakov  <caseq@chromium.org>
  69
  70         Reviewed by Pavel Feldman.
  71
  72         Web Inspector: [Extensions API] webInspector.resources.onFinished is not fired for redirected resources
  73         Make resource start/finish hanlding more consistent.
  74         https://bugs.webkit.org/show_bug.cgi?id=52452
  75
  76         * inspector/front-end/AuditLauncherView.js: Ignore WebSocket resources when displaying progress indicator
  77         (WebInspector.AuditLauncherView.prototype._resetResourceCount):
  78         (WebInspector.AuditLauncherView.prototype.resourceStarted):
  79         (WebInspector.AuditLauncherView.prototype.resourceFinished):
  80         * inspector/front-end/NetworkManager.js:
  81         (WebInspector.NetworkManager): Factor out resource start/finish logic to _startResource()/_finishResource()
  82         (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
  83         (WebInspector.NetworkManager.prototype.willSendRequest):
  84         (WebInspector.NetworkManager.prototype.markResourceAsCached):
  85         (WebInspector.NetworkManager.prototype.didReceiveResponse):
  86         (WebInspector.NetworkManager.prototype.didReceiveContentLength):
  87         (WebInspector.NetworkManager.prototype.didFinishLoading):
  88         (WebInspector.NetworkManager.prototype.didFailLoading):
  89         (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache):
  90         (WebInspector.NetworkManager.prototype.didCreateWebSocket):
  91         (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest):
  92         (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse):
  93         (WebInspector.NetworkManager.prototype.didCloseWebSocket):
  94         (WebInspector.NetworkManager.prototype._appendRedirect):
  95         (WebInspector.NetworkManager.prototype._startResource):
  96         (WebInspector.NetworkManager.prototype._finishResource):
  97
  98 2011-01-17  Pavel Feldman  <pfeldman@chromium.org>
  99
 100         Reviewed by Yury Semikhatsky.
 101
 102         Web Inspector: restore dom and network state upon frontend reuse.
 103         https://bugs.webkit.org/show_bug.cgi?id=52574
 104
 105         * inspector/Inspector.idl:
 106         * inspector/InspectorController.cpp:
 107         (WebCore::InspectorController::restoreInspectorStateFromCookie):
 108         (WebCore::InspectorController::populateScriptObjects):
 109         (WebCore::InspectorController::pushDataCollectedOffline):
 110         (WebCore::InspectorController::didCommitLoad):
 111         * inspector/InspectorController.h:
 112         * inspector/front-end/NetworkManager.js:
 113         (WebInspector.NetworkManager.prototype.reset):
 114         * inspector/front-end/NetworkPanel.js:
 115         (WebInspector.NetworkPanel.prototype.clear):
 116         (WebInspector.NetworkPanel.prototype.mainResourceChanged):
 117         * inspector/front-end/ResourceTreeModel.js:
 118         (WebInspector.ResourceTreeModel):
 119         (WebInspector.ResourceTreeModel.prototype.reloadCachedResources):
 120         * inspector/front-end/ResourcesPanel.js:
 121         (WebInspector.ResourcesPanel.prototype.clear):
 122         * inspector/front-end/inspector.js:
 123         (WebInspector.frontendReused):
 124
 125 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
 126
 127         Unreviewed buildfix after r75944.
 128
 129         * WebCore.pro:
 130
 131 2011-01-17  Yi Shen  <yi.4.shen@nokia.com>
 132
 133         Reviewed by Andreas Kling.
 134
 135         [Qt] Extend the Platform Plugin to support full screen video handler
 136         https://bugs.webkit.org/show_bug.cgi?id=51249
 137
 138         Make MediaPlayerPrivateQt support a fullscreen player.
 139
 140         No new tests because LayoutTests/media/media-fullscreen-inline.html already exists.
 141         However, this test failed for Qt (QtMediaPlayer) due to durationchange event getting fired twice.
 142         So, still skip it for Qt.
 143
 144         * WebCore.pro:
 145         * features.pri:
 146         * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
 147         (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
 148         (WebCore::MediaPlayerPrivateQt::removeVideoItem):
 149         (WebCore::MediaPlayerPrivateQt::restoreVideoItem):
 150         * platform/graphics/qt/MediaPlayerPrivateQt.h:
 151         (WebCore::MediaPlayerPrivateQt::supportsFullscreen):
 152         (WebCore::MediaPlayerPrivateQt::mediaPlayer):
 153
 154 2011-01-17  Anthony Ricaud  <rik@webkit.org>
 155
 156         Reviewed by Kent Tamura.
 157
 158         [HTML5] Revert display:none on datalist
 159         https://bugs.webkit.org/show_bug.cgi?id=52214
 160
 161         * css/html.css:
 162
 163 2011-01-17  Pavel Feldman  <pfeldman@chromium.org>
 164
 165         Reviewed by Yury Semikhatsky.
 166
 167         Web Inspector: simplify debugger enabling routine.
 168         https://bugs.webkit.org/show_bug.cgi?id=52472
 169
 170         * inspector/Inspector.idl:
 171         * inspector/InspectorController.cpp:
 172         (WebCore::InspectorController::restoreDebugger):
 173         (WebCore::InspectorController::showAndEnableDebugger):
 174         (WebCore::InspectorController::enableDebugger):
 175         * inspector/InspectorController.h:
 176         * inspector/front-end/DebuggerModel.js:
 177         * inspector/front-end/ScriptsPanel.js:
 178         (WebInspector.ScriptsPanel.prototype.show):
 179         (WebInspector.ScriptsPanel.prototype._toggleDebugging):
 180
 181 2011-01-17  Pavel Podivilov  <podivilov@chromium.org>
 182
 183         Reviewed by Pavel Feldman.
 184
 185         Web Inspector: refactoring: encapsulate lazy initialization of SourceFrame.
 186         https://bugs.webkit.org/show_bug.cgi?id=51738
 187
 188         Extract content loading logic from SourceView and ScriptView to ContentProvider implementations.
 189         Pass ContentProvider in SourceFrame constructor to allow SourceFrame manage it's lazy initialization.
 190
 191         * inspector/front-end/ScriptView.js:
 192         (WebInspector.ScriptView):
 193         (WebInspector.SourceFrameContentProviderForScript):
 194         (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent.didRequestSource):
 195         (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent):
 196         (WebInspector.SourceFrameContentProviderForScript.prototype.scripts):
 197         * inspector/front-end/ScriptsPanel.js:
 198         (WebInspector.ScriptsPanel.prototype._addScript):
 199         (WebInspector.ScriptsPanel.prototype.sourceFrameForScript):
 200         (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
 201         * inspector/front-end/SourceFrame.js:
 202         (WebInspector.SourceFrame):
 203         (WebInspector.SourceFrame.prototype.set visible):
 204         (WebInspector.SourceFrame.prototype._createTextViewer):
 205         (WebInspector.SourceFrame.prototype._breakpointAdded):
 206         (WebInspector.SourceFrame.prototype._breakpoints):
 207         (WebInspector.SourceFrame.prototype._sourceIDForLine):
 208         (WebInspector.SourceFrame.prototype._sourceIDSet):
 209         (WebInspector.SourceFrameContentProvider):
 210         (WebInspector.SourceFrameContentProvider.prototype.requestContent):
 211         (WebInspector.SourceFrameContentProvider.prototype.scripts):
 212         * inspector/front-end/SourceView.js:
 213         (WebInspector.SourceView):
 214         (WebInspector.SourceView.prototype.show):
 215         (WebInspector.SourceView.prototype.resize):
 216         (WebInspector.SourceView.prototype.performSearch.didFindSearchMatches):
 217         (WebInspector.SourceView.prototype.performSearch):
 218         (WebInspector.SourceView.prototype.revealLine):
 219         (WebInspector.SourceView.prototype.highlightLine):
 220         (WebInspector.SourceView.prototype._jumpToSearchResult):
 221         (WebInspector.SourceFrameContentProviderForResource):
 222         (WebInspector.SourceFrameContentProviderForResource.prototype.requestContent):
 223         (WebInspector.SourceFrameContentProviderForResource.prototype.scripts):
 224
 225 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
 226
 227         Reviewed by Jeremy Orlow.
 228
 229         GeolocationController should call stopUpdating on destruction
 230         https://bugs.webkit.org/show_bug.cgi?id=52216
 231
 232         Test: fast/dom/Geolocation/window-close-crash.html
 233
 234         * page/GeolocationController.cpp:
 235         (WebCore::GeolocationController::~GeolocationController):
 236
 237 2011-01-17  Pavel Feldman  <pfeldman@chromium.org>
 238
 239         Not reviewed: Qt build fix.
 240
 241         * inspector/InspectorInstrumentation.h:
 242
 243 2011-01-16  Pavel Feldman  <pfeldman@chromium.org>
 244
 245         Reviewed by Yury Semikhatsky.
 246
 247         Web Inspector: make WebCore use InspectorInstrumentation
 248         for instrumentation calls.
 249         https://bugs.webkit.org/show_bug.cgi?id=52532
 250
 251         This change makes WebCore classes issue instrumentation signals
 252         by means of InspectorInstrumentation interface. It covered migration
 253         for Document, FrameLoader, Database, DOMStorage, etc. It fixed
 254         instrumentation handling for Console as well. This all is a part
 255         of story described in the bug 52510.
 256
 257         * dom/Document.cpp:
 258         (WebCore::Document::finishedParsing):
 259         * dom/Document.h:
 260         * dom/ScriptExecutionContext.h:
 261         * inspector/InspectorBrowserDebuggerAgent.cpp:
 262         (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
 263         (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
 264         (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
 265         (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
 266         (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
 267         (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
 268         (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
 269         (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
 270         (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
 271         * inspector/InspectorBrowserDebuggerAgent.h:
 272         (WebCore::InspectorBrowserDebuggerAgent::create):
 273         * inspector/InspectorConsoleAgent.cpp:
 274         (WebCore::InspectorConsoleAgent::stopTiming):
 275         (WebCore::InspectorConsoleAgent::count):
 276         * inspector/InspectorConsoleAgent.h:
 277         * inspector/InspectorController.cpp:
 278         (WebCore::InspectorController::InspectorController):
 279         (WebCore::InspectorController::~InspectorController):
 280         (WebCore::InspectorController::handleMousePress):
 281         (WebCore::InspectorController::didClearWindowObjectInWorld):
 282         (WebCore::PostWorkerNotificationToFrontendTask::performTask):
 283         * inspector/InspectorController.h:
 284         * inspector/InspectorDOMAgent.h:
 285         * inspector/InspectorDOMStorageAgent.h:
 286         * inspector/InspectorDatabaseAgent.cpp:
 287         * inspector/InspectorDatabaseAgent.h:
 288         * inspector/InspectorFrontendHost.cpp:
 289         * inspector/InspectorFrontendHost.h:
 290         * inspector/InspectorInstrumentation.cpp:
 291         (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
 292         (WebCore::InspectorInstrumentation::inspectedPageDestroyedImpl):
 293         (WebCore::InspectorInstrumentation::mouseDidMoveOverElementImpl):
 294         (WebCore::InspectorInstrumentation::handleMousePressImpl):
 295         (WebCore::InspectorInstrumentation::mainResourceFiredLoadEventImpl):
 296         (WebCore::InspectorInstrumentation::mainResourceFiredDOMContentEventImpl):
 297         (WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
 298         (WebCore::InspectorInstrumentation::didCommitLoadImpl):
 299         (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
 300         (WebCore::InspectorInstrumentation::consoleCountImpl):
 301         (WebCore::InspectorInstrumentation::startConsoleTimingImpl):
 302         (WebCore::InspectorInstrumentation::stopConsoleTimingImpl):
 303         (WebCore::InspectorInstrumentation::consoleMarkTimelineImpl):
 304         (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
 305         (WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
 306         (WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
 307         (WebCore::InspectorInstrumentation::didCreateWorkerImpl):
 308         (WebCore::InspectorInstrumentation::didDestroyWorkerImpl):
 309         (WebCore::InspectorInstrumentation::didCreateWebSocketImpl):
 310         (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl):
 311         (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl):
 312         (WebCore::InspectorInstrumentation::didCloseWebSocketImpl):
 313         (WebCore::InspectorInstrumentation::networkStateChangedImpl):
 314         (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
 315         * inspector/InspectorInstrumentation.h:
 316         (WebCore::InspectorInstrumentation::inspectorControllerCreated):
 317         (WebCore::InspectorInstrumentation::inspectorControllerDeleted):
 318         (WebCore::InspectorInstrumentation::didClearWindowObjectInWorld):
 319         (WebCore::InspectorInstrumentation::inspectedPageDestroyed):
 320         (WebCore::InspectorInstrumentation::willInsertDOMNode):
 321         (WebCore::InspectorInstrumentation::didInsertDOMNode):
 322         (WebCore::InspectorInstrumentation::willRemoveDOMNode):
 323         (WebCore::InspectorInstrumentation::willModifyDOMAttr):
 324         (WebCore::InspectorInstrumentation::didModifyDOMAttr):
 325         (WebCore::InspectorInstrumentation::mouseDidMoveOverElement):
 326         (WebCore::InspectorInstrumentation::handleMousePress):
 327         (WebCore::InspectorInstrumentation::characterDataModified):
 328         (WebCore::InspectorInstrumentation::willSendXMLHttpRequest):
 329         (WebCore::InspectorInstrumentation::didScheduleResourceRequest):
 330         (WebCore::InspectorInstrumentation::didInstallTimer):
 331         (WebCore::InspectorInstrumentation::didRemoveTimer):
 332         (WebCore::InspectorInstrumentation::willCallFunction):
 333         (WebCore::InspectorInstrumentation::willChangeXHRReadyState):
 334         (WebCore::InspectorInstrumentation::willDispatchEvent):
 335         (WebCore::InspectorInstrumentation::willDispatchEventOnWindow):
 336         (WebCore::InspectorInstrumentation::willEvaluateScript):
 337         (WebCore::InspectorInstrumentation::willFireTimer):
 338         (WebCore::InspectorInstrumentation::willLayout):
 339         (WebCore::InspectorInstrumentation::willLoadXHR):
 340         (WebCore::InspectorInstrumentation::willPaint):
 341         (WebCore::InspectorInstrumentation::willRecalculateStyle):
 342         (WebCore::InspectorInstrumentation::identifierForInitialRequest):
 343         (WebCore::InspectorInstrumentation::willSendRequest):
 344         (WebCore::InspectorInstrumentation::markResourceAsCached):
 345         (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache):
 346         (WebCore::InspectorInstrumentation::willReceiveResourceData):
 347         (WebCore::InspectorInstrumentation::willReceiveResourceResponse):
 348         (WebCore::InspectorInstrumentation::didReceiveContentLength):
 349         (WebCore::InspectorInstrumentation::didFinishLoading):
 350         (WebCore::InspectorInstrumentation::didFailLoading):
 351         (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequest):
 352         (WebCore::InspectorInstrumentation::scriptImported):
 353         (WebCore::InspectorInstrumentation::mainResourceFiredLoadEvent):
 354         (WebCore::InspectorInstrumentation::mainResourceFiredDOMContentEvent):
 355         (WebCore::InspectorInstrumentation::frameDetachedFromParent):
 356         (WebCore::InspectorInstrumentation::didCommitLoad):
 357         (WebCore::InspectorInstrumentation::willWriteHTML):
 358         (WebCore::InspectorInstrumentation::didOpenDatabase):
 359         (WebCore::InspectorInstrumentation::didUseDOMStorage):
 360         (WebCore::InspectorInstrumentation::didCreateWorker):
 361         (WebCore::InspectorInstrumentation::didDestroyWorker):
 362         (WebCore::InspectorInstrumentation::didCreateWebSocket):
 363         (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
 364         (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
 365         (WebCore::InspectorInstrumentation::didCloseWebSocket):
 366         (WebCore::InspectorInstrumentation::networkStateChanged):
 367         (WebCore::InspectorInstrumentation::updateApplicationCacheStatus):
 368         (WebCore::InspectorInstrumentation::addMessageToConsole):
 369         (WebCore::InspectorInstrumentation::consoleCount):
 370         (WebCore::InspectorInstrumentation::startConsoleTiming):
 371         (WebCore::InspectorInstrumentation::stopConsoleTiming):
 372         (WebCore::InspectorInstrumentation::consoleMarkTimeline):
 373         (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
 374         (WebCore::InspectorInstrumentation::inspectorControllerForContext):
 375         (WebCore::InspectorInstrumentation::inspectorControllerForFrame):
 376         (WebCore::InspectorInstrumentation::inspectorControllerForPage):
 377         (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForContext):
 378         (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForDocument):
 379         (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForFrame):
 380         (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForPage):
 381         * inspector/InspectorState.cpp:
 382         * loader/FrameLoader.cpp:
 383         (WebCore::FrameLoader::detachFromParent):
 384         (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
 385         (WebCore::FrameLoader::dispatchDidCommitLoad):
 386         * page/Chrome.cpp:
 387         (WebCore::Chrome::mouseDidMoveOverElement):
 388         * page/Console.cpp:
 389         (WebCore::Console::addMessage):
 390         (WebCore::Console::count):
 391         (WebCore::Console::markTimeline):
 392         (WebCore::Console::profile):
 393         (WebCore::Console::time):
 394         (WebCore::Console::timeEnd):
 395         (WebCore::Console::group):
 396         (WebCore::Console::groupCollapsed):
 397         (WebCore::Console::groupEnd):
 398         * page/DOMWindow.cpp:
 399         (WebCore::DOMWindow::sessionStorage):
 400         (WebCore::DOMWindow::localStorage):
 401         (WebCore::DOMWindow::dispatchLoadEvent):
 402         * page/EventHandler.cpp:
 403         (WebCore::EventHandler::handleMousePressEvent):
 404         * page/Page.cpp:
 405         (WebCore::Page::~Page):
 406         * storage/Database.cpp:
 407         (WebCore::Database::openDatabase):
 408         * workers/AbstractWorker.cpp:
 409         (WebCore::AbstractWorker::onDestroyWorker):
 410         * workers/SharedWorker.cpp:
 411         (WebCore::SharedWorker::create):
 412         * workers/Worker.cpp:
 413         (WebCore::Worker::create):
 414         * workers/WorkerMessagingProxy.cpp:
 415
 416 2011-01-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 417
 418         Unreviewed, rolling out r75923.
 419
 420         GTK guy rolls out the r75914.
 421
 422         * platform/efl/ScrollViewEfl.cpp:
 423         (WebCore::ScrollView::platformInit):
 424
 425 2011-01-17  Helder Correia  <helder@sencha.com>
 426
 427         Reviewed by Kenneth Rohde Christiansen.
 428
 429         [Qt] fast/canvas/canvas-fillPath-gradient-shadow.html does not pass
 430         https://bugs.webkit.org/show_bug.cgi?id=52556
 431
 432         The shadow color opacity needs to be set on the shadow painter.
 433         Additionally, the gradient brush should be transformed.
 434
 435         * platform/graphics/qt/GraphicsContextQt.cpp:
 436         (WebCore::GraphicsContext::fillPath):
 437
 438 2011-01-17  No'am Rosenthal  <noam.rosenthal@nokia.com>
 439
 440         Reviewed by Kenneth Rohde Christiansen.
 441
 442         [Qt] Background image rendering is slow
 443         https://bugs.webkit.org/show_bug.cgi?id=50527
 444
 445         When tiling a scaled pixmap in Image::drawPattern, scale the tile
 446         first and only then draw it to the target. Do so only when drawing
 447         more than one tile.
 448
 449         Tests in fast/backgrounds/size cover this.
 450
 451         * platform/graphics/qt/ImageQt.cpp:
 452         (WebCore::Image::drawPattern):
 453
 454 2011-01-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 455
 456         Reviewed by Simon Hausmann.
 457
 458         [Qt] [Symbian] Fix building NPAPI support
 459         https://bugs.webkit.org/show_bug.cgi?id=51981
 460
 461         Make sure that npapi.h is always included outside of the extern "C"
 462         linkage declaration block.
 463
 464         No new tests as there is no new functionality.
 465
 466         * bridge/npruntime.h:
 467
 468 2011-01-17  Philippe Normand  <pnormand@igalia.com>
 469
 470         Unreviewed, rolling out r75914.
 471         http://trac.webkit.org/changeset/75914
 472         https://bugs.webkit.org/show_bug.cgi?id=49177
 473
 474         multiple crashes on GTK
 475
 476         * platform/ScrollView.cpp:
 477         (WebCore::ScrollView::removeChild):
 478         (WebCore::ScrollView::wheelEvent):
 479         * platform/gtk/MainFrameScrollbarGtk.cpp:
 480         (MainFrameScrollbarGtk::attachAdjustment):
 481         (MainFrameScrollbarGtk::gtkValueChanged):
 482         * platform/gtk/ScrollViewGtk.cpp:
 483         (WebCore::ScrollView::platformInit):
 484         (WebCore::ScrollView::platformAddChild):
 485         (WebCore::ScrollView::platformRemoveChild):
 486
 487 2011-01-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 488
 489         Unreviewed build fix.
 490
 491         Bug 49177's patch enabled platformInit() in super class(ScrollView).
 492         But, it didn't removed the function in ScrollViewEfl.cpp.
 493
 494         * platform/efl/ScrollViewEfl.cpp:
 495
 496 2011-01-16  Dan Bernstein  <mitz@apple.com>
 497
 498         Reviewed by Sam Weinig.
 499
 500         <rdar://problem/8871903> REGRESSION (r75897): Crash with 0-by-0 iframe in scaled WebView
 501
 502         Avoid use of FloatRect::enclosingBoundingBox(), which can stretch an empty
 503         quad to a non-empty rect.
 504
 505         * rendering/RenderWidget.cpp:
 506         (WebCore::RenderWidget::setWidget):
 507         (WebCore::RenderWidget::updateWidgetPosition):
 508
 509 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
 510
 511         Reviewed by Xan Lopez.
 512
 513         [GTK] fast/events/scroll-after-click-on-tab-index has been failing on the bots
 514         https://bugs.webkit.org/show_bug.cgi?id=49177
 515
 516         * platform/ScrollView.cpp: Move the platform guards around a little. GTK+
 517         now shares the implementation of platformAddChild and platformRemoveChild,
 518         but has its own implementation of removeChild, which knows how to inform
 519         main frame scrollbars that they no longer control the WebCore scrollbar.
 520         * platform/gtk/MainFrameScrollbarGtk.cpp:
 521         (MainFrameScrollbarGtk::attachAdjustment): If we are attaching the same adjustment
 522         that we already have, bail out early. Apply the value changed signal handler
 523         after configuring the adjustment. We don't want our reset of the adjustment to
 524         stomp on WebCore values.
 525         (MainFrameScrollbarGtk::gtkValueChanged): Do not adjust the value if the WebCore
 526         state already matches ours. This prevents some unnecessary recursion
 527         * platform/gtk/ScrollViewGtk.cpp:
 528         (WebCore::ScrollView::removeChild): Added, special cases main frame scrollbars
 529         which need their adjustments detached.
 530
 531 2011-01-13  Yuzo Fujishima  <yuzo@google.com>
 532
 533         Reviewed by Antti Koivisto.
 534
 535         Fix for Bug 52427 - Inconsistent use of m_cache in CachedResourceLoader
 536         https://bugs.webkit.org/show_bug.cgi?id=52427
 537
 538         In constructor/destructor of CachedResourceLoader, m_cache has been
 539         used to call MemoryCache::addCachedResourceLoader/removeCachedResourceLoader
 540         while cache() is used everywhere else.
 541
 542         Actually addCachedResourceLoader/removeCachedResourceLoader need not be called at all.
 543         Remove the call sites and make MemoryCache non-friend of CachedResourceLoader.
 544
 545         No new tests because the behavior remains the same.
 546
 547         * loader/cache/CachedResourceLoader.cpp:
 548         (WebCore::CachedResourceLoader::CachedResourceLoader):
 549         (WebCore::CachedResourceLoader::~CachedResourceLoader):
 550         * loader/cache/CachedResourceLoader.h:
 551         * loader/cache/MemoryCache.cpp:
 552         * loader/cache/MemoryCache.h:
 553
 554 2011-01-16  Adam Barth  <abarth@webkit.org>
 555
 556         Rubber-stamped by Eric Seidel.
 557
 558         Move WebKit into Source
 559         https://bugs.webkit.org/show_bug.cgi?id=52530
 560
 561         * WebCore.gyp/WebCore.gyp:
 562         * WebCore.pri:
 563         * WebCore.pro:
 564
 565 2011-01-16  Simon Fraser  <simon.fraser@apple.com>
 566
 567         Reviewed by Dan Bernstein.
 568
 569         frame-removed-during-resize.html test crashes (shows up as image-map-2.html crash)
 570         https://bugs.webkit.org/show_bug.cgi?id=52549
 571
 572         Fix regression from r75900; m_widget->setFrameRect() can run script that
 573         clears m_widget, so null-check it before calling setBoundsSize().
 574
 575         Tested by fast/replaced/frame-removed-during-resize.html
 576
 577         * rendering/RenderWidget.cpp:
 578         (WebCore::RenderWidget::setWidgetGeometry):
 579
 580 2011-01-16  Simon Fraser  <simon.fraser@apple.com>
 581
 582         Keep Leopard build happy.
 583
 584         * platform/mac/WidgetMac.mm:
 585         (WebCore::Widget::setBoundsSize):
 586
 587 2011-01-16  Robert Hogan  <robert@webkit.org>
 588
 589         Reviewed by Andreas Kling.
 590
 591         [Qt] plugins/keyboard-events.html fails after r72717
 592         https://bugs.webkit.org/show_bug.cgi?id=50050
 593
 594         * plugins/qt/PluginViewQt.cpp:
 595         (WebCore::setXKeyEventSpecificFields): map event text to keycode
 596
 597 2011-01-16  Simon Fraser  <simon.fraser@apple.com>
 598
 599         Reviewed by Dan Bernstein.
 600
 601         Issues with iframes and plugins when the WebView is scaled.
 602         <rdar://problem/6213380>
 603
 604         When _scaleWebView has been called on a WebView, iframes
 605         in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
 606         This is caused by AppKit NSViews not playing nicely with the scale
 607         applied through style.
 608
 609         Work around most of these issues by adjusting the bounds size
 610         of widgets to allow iframe contents to paint with the correct scale,
 611         and fix various places in the code where we relied on coordinate
 612         transforms via NSViews (which ignore CSS transforms).
 613
 614         * WebCore.exp.in:
 615         * platform/Widget.cpp:
 616         (WebCore::Widget::setBoundsSize):
 617         * platform/Widget.h:
 618         * platform/mac/WidgetMac.mm:
 619         (WebCore::Widget::setBoundsSize):
 620         (WebCore::Widget::paint):
 621         * rendering/RenderLayerCompositor.cpp:
 622         (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame):
 623         * rendering/RenderWidget.cpp:
 624         (WebCore::RenderWidget::setWidgetGeometry):
 625         (WebCore::RenderWidget::setWidget):
 626         (WebCore::RenderWidget::updateWidgetPosition):
 627         * rendering/RenderWidget.h:
 628
 629 2011-01-16  Simon Fraser  <simon.fraser@apple.com>
 630
 631         Reviewed by Dan Bernstein.
 632
 633         RenderView needs to take transforms on its layer into account
 634         https://bugs.webkit.org/show_bug.cgi?id=52536
 635
 636         The RenderView's coordinate mapping methods failed to
 637         take into account a transform on the RenderView's layer.
 638
 639         No tests because it's not possible to get a transform
 640         on the RenderView's layer through content.
 641
 642         * rendering/RenderView.cpp:
 643         (WebCore::RenderView::mapLocalToContainer):
 644         (WebCore::RenderView::mapAbsoluteToLocalPoint):
 645
 646 2011-01-15  Sheriff Bot  <webkit.review.bot@gmail.com>
 647
 648         Unreviewed, rolling out r75708.
 649         http://trac.webkit.org/changeset/75708
 650         https://bugs.webkit.org/show_bug.cgi?id=52521
 651
 652         Breaks Qt build if mobility is not installed. (Requested by
 653         benjaminp on #webkit).
 654
 655         * WebCore.pro:
 656         * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
 657         (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
 658         * platform/graphics/qt/MediaPlayerPrivateQt.h:
 659         (WebCore::MediaPlayerPrivateQt::supportsFullscreen):
 660
 661 2011-01-15  David Kilzer  <ddkilzer@apple.com>
 662
 663         <http://webkit.org/b/52512> REGRESSION(r73818): range.cloneContents() ignores end offset
 664
 665         Reviewed by Adele Peterson.
 666
 667         The fix for Bug 50710 in r73799 introduced an off-by-one error
 668         when copying nodes to a local NodeVector for processing.  A fix
 669         was attempted for Bug 50854 in r73818, but instead of stopping
 670         at the end offset, it iterates through all the sibling nodes
 671         because the loop variable (i) is never incremented.  To clean
 672         this up, revert back to the code in r73799 and fix the
 673         off-by-one error.
 674
 675         Test: fast/dom/Range/range-clone-contents.html
 676
 677         * dom/Range.cpp:
 678         (WebCore::Range::processContents): Fix the loop that copies
 679         nodes to a local NodeVector by restoring the code from r73799
 680         and fixing the off-by-one error.
 681
 682 2011-01-15  Adam Barth  <abarth@webkit.org>
 683
 684         Rubber-stamped by Eric Seidel.
 685
 686         Move WebKit2 into Source
 687         https://bugs.webkit.org/show_bug.cgi?id=52438
 688
 689         * WebCore.pro:
 690
 691 2011-01-15  Joone Hur  <joone.hur@collabora.co.uk>
 692
 693         Reviewed by Martin Robinson.
 694
 695         [GTK] Linux build with FileSystem API enabled fails
 696         https://bugs.webkit.org/show_bug.cgi?id=43878
 697
 698         This patch allows WebKitGtk+ to build with FileSystem API option.
 699
 700         No new tests because no new functionality.
 701
 702         * GNUmakefile.am: Included AsyncFileSystem.h,cpp and Excluded duplicated JSFileException.h,cpp.
 703         * bindings/js/JSDirectoryEntryCustom.cpp: Included ExceptionCode.h.
 704
 705 2011-01-14  Sam Magnuson  <smagnuso@gmail.com>
 706
 707         Reviewed by Kenneth Rohde Christiansen.
 708
 709         [Qt] Compile with QT_NO_GRAPHICSVIEW
 710         https://bugs.webkit.org/show_bug.cgi?id=49750
 711
 712         * platform/graphics/qt/GraphicsLayerQt.cpp:
 713         * platform/graphics/qt/GraphicsLayerQt.h:
 714         * platform/qt/PlatformMouseEventQt.cpp:
 715
 716 2011-01-14  Tony Chang  <tony@chromium.org>
 717
 718         Reviewed by Alexey Proskuryakov.
 719
 720         Strip NUL character when copying text on Windows
 721         https://bugs.webkit.org/show_bug.cgi?id=52236
 722
 723         Test: editing/pasteboard/copy-null-characters.html
 724
 725         * editing/Editor.cpp:
 726         (WebCore::Editor::selectedText):
 727         * platform/mac/PasteboardMac.mm:
 728         (WebCore::Pasteboard::writeSelection): Use editor()->selectedText() which matches the other platforms.
 729
 730 2011-01-14  Yuzo Fujishima  <yuzo@google.com>
 731
 732         Reviewed by Antti Koivisto.
 733
 734         Rename cache() to memoryCache()
 735         https://bugs.webkit.org/show_bug.cgi?id=52433
 736
 737         No new tests because the behavior remains the same.
 738
 739         * WebCore.exp.in:
 740         * WebCore.order:
 741         * history/PageCache.cpp:
 742         (WebCore::PageCache::releaseAutoreleasedPagesNow):
 743         * inspector/InspectorResourceAgent.cpp:
 744         (WebCore::InspectorResourceAgent::cachedResource):
 745         * loader/FrameLoader.cpp:
 746         (WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads):
 747         * loader/archive/cf/LegacyWebArchive.cpp:
 748         (WebCore::LegacyWebArchive::create):
 749         * loader/cache/CachedImage.cpp:
 750         (WebCore::CachedImage::allClientsRemoved):
 751         (WebCore::CachedImage::data):
 752         * loader/cache/CachedResource.cpp:
 753         (WebCore::CachedResource::~CachedResource):
 754         (WebCore::CachedResource::addClientToSet):
 755         (WebCore::CachedResource::removeClient):
 756         (WebCore::CachedResource::setDecodedSize):
 757         (WebCore::CachedResource::setEncodedSize):
 758         (WebCore::CachedResource::didAccessDecodedData):
 759         * loader/cache/CachedResourceLoader.cpp:
 760         (WebCore::CachedResourceLoader::CachedResourceLoader):
 761         (WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
 762         (WebCore::CachedResourceLoader::requestResource):
 763         (WebCore::CachedResourceLoader::revalidateResource):
 764         (WebCore::CachedResourceLoader::loadResource):
 765         (WebCore::CachedResourceLoader::clearPreloads):
 766         (WebCore::CachedResourceLoader::printPreloadStats):
 767         * loader/cache/CachedResourceRequest.cpp:
 768         (WebCore::CachedResourceRequest::load):
 769         (WebCore::CachedResourceRequest::didFail):
 770         (WebCore::CachedResourceRequest::didReceiveResponse):
 771         * loader/cache/MemoryCache.cpp:
 772         (WebCore::memoryCache):
 773         * loader/cache/MemoryCache.h:
 774
 775 2011-01-14  Dan Bernstein  <mitz@apple.com>
 776
 777         Reviewed by Simon Fraser.
 778
 779         WebCore part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]
 780
 781         * WebCore.exp.in: Export RenderWidget::suspendWidgetHierarchyUpdates() and
 782         RenderWidget::resumeWidgetHierarchyUpdates().
 783         * manual-tests/plug-in-mutates-NSView-hierarchy-during-resize.html: Added.
 784         * rendering/RenderWidget.cpp:
 785         (WebCore::RenderWidget::setWidgetGeometry): Removed the assertion that widget hierarchy updates
 786         are disabled. When this assertion was added, this condition was a subset of the “calling out to
 787         plug-in code is forbidden” condition, hence the assertion was valid. The WebKit part of this
 788         change now suspends widget hierarchy updates even at times where plug-in code is expected to be
 789         called, which invalidates the assertion.
 790
 791 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
 792
 793         Unreviewed build fix.
 794
 795         Fix Qt build after r75837
 796         https://bugs.webkit.org/show_bug.cgi?id=52494
 797
 798         * rendering/style/StyleRareInheritedData.cpp:
 799         * rendering/style/StyleRareNonInheritedData.cpp:
 800
 801 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
 802
 803         Unreviewed build fix.
 804
 805         Fix Qt build after r75837
 806         https://bugs.webkit.org/show_bug.cgi?id=52494
 807
 808         * rendering/style/RenderStyle.cpp:
 809
 810 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
 811
 812         Unreviewed build fix.
 813
 814         Fix Qt build after r75837
 815         https://bugs.webkit.org/show_bug.cgi?id=52494
 816
 817         * editing/EditorCommand.cpp:
 818
 819 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
 820
 821         Unreviewed build fix.
 822
 823         Fix Qt build after r75837
 824         https://bugs.webkit.org/show_bug.cgi?id=52494
 825
 826         * editing/ApplyStyleCommand.cpp:
 827
 828 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
 829
 830         Unreviewed build fix.
 831
 832         Fix Qt build after r75837
 833         https://bugs.webkit.org/show_bug.cgi?id=52494
 834
 835         * css/CSSStyleSelector.cpp:
 836
 837 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
 838
 839         Unreviewed build fix.
 840
 841         Fix Qt build after r75837
 842         https://bugs.webkit.org/show_bug.cgi?id=52494
 843
 844         * rendering/InlineFlowBox.h:
 845         * rendering/RenderBoxModelObject.h:
 846
 847 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
 848
 849         Reviewed by David Levin.
 850
 851         Do some forward declaration in RenderStyle.h
 852         https://bugs.webkit.org/show_bug.cgi?id=52453
 853
 854         No new tests because no new functionality.
 855
 856         * css/CSSComputedStyleDeclaration.cpp:
 857         * css/CSSStyleSelector.cpp:
 858         * editing/Editor.cpp:
 859         * page/EventHandler.cpp:
 860         * rendering/EllipsisBox.cpp:
 861         * rendering/InlineBox.cpp:
 862         * rendering/InlineTextBox.cpp:
 863         * rendering/RenderBlock.cpp:
 864         * rendering/RenderBlock.h:
 865         * rendering/RenderBox.cpp:
 866         * rendering/RenderBox.h:
 867         * rendering/RenderEmbeddedObject.cpp:
 868         * rendering/RenderFieldset.cpp:
 869         * rendering/RenderFileUploadControl.cpp:
 870         * rendering/RenderFrameSet.cpp:
 871         * rendering/RenderHTMLCanvas.cpp:
 872         * rendering/RenderImageResource.cpp:
 873         * rendering/RenderInputSpeech.cpp:
 874         * rendering/RenderLayer.h:
 875         * rendering/RenderLineBoxList.cpp:
 876         * rendering/RenderListBox.cpp:
 877         * rendering/RenderMediaControlsChromium.cpp:
 878         * rendering/RenderObject.cpp:
 879         * rendering/RenderObject.h:
 880         * rendering/RenderObjectChildList.cpp:
 881         * rendering/RenderProgress.cpp:
 882         * rendering/RenderScrollbarPart.cpp:
 883         * rendering/RenderTable.cpp:
 884         * rendering/RenderTable.h:
 885         * rendering/RenderTableCell.cpp:
 886         * rendering/RenderTableRow.cpp:
 887         * rendering/RenderTableSection.cpp:
 888         * rendering/RenderTheme.cpp:
 889         * rendering/RenderThemeChromiumSkia.cpp:
 890         * rendering/RenderThemeChromiumWin.cpp:
 891         * rendering/RootInlineBox.cpp:
 892         * rendering/style/RenderStyle.cpp:
 893         * rendering/style/RenderStyle.h:
 894         * rendering/style/StyleRareInheritedData.cpp:
 895
 896 2011-01-14  Ryosuke Niwa  <rniwa@webkit.org>
 897
 898         Reviewed by Eric Seidel.
 899
 900         Stop instantiating legacy editing positions in AccessibilityRenderObject.cpp, Element.cpp,
 901         BreakBlockquoteCommand.cpp, CompositeEditCommand.cpp, and DeleteButtonController.cpp
 902         https://bugs.webkit.org/show_bug.cgi?id=52481
 903
 904         Removed instantiation of legacy editing positions.
 905         Calls to Position::Position are replaced by calls to Position's convenience functions.
 906
 907         Also fixed firstPositionInOrBeforeNode and lastPositionInOrAfterNode so that
 908         they instantiate right positions for text nodes.
 909
 910         * accessibility/AccessibilityRenderObject.cpp:
 911         (WebCore::AccessibilityRenderObject::setSelectedTextRange):
 912         * dom/Element.cpp:
 913         (WebCore::Element::updateFocusAppearance):
 914         * editing/BreakBlockquoteCommand.cpp:
 915         (WebCore::BreakBlockquoteCommand::doApply):
 916         * editing/CompositeEditCommand.cpp:
 917         (WebCore::CompositeEditCommand::inputText):
 918         (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
 919         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
 920         (WebCore::CompositeEditCommand::moveParagraphs):
 921         (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
 922         (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
 923         (WebCore::CompositeEditCommand::splitTreeToNode):
 924         * editing/DeleteButtonController.cpp:
 925         (WebCore::enclosingDeletableElement):
 926         * editing/htmlediting.h:
 927         (WebCore::firstPositionInOrBeforeNode): Instantiates firstPositionInNode instead of
 928         positionBeforeNode for a text node.
 929         (WebCore::lastPositionInOrAfterNode): Ditto.
 930
 931 2011-01-14  Helder Correia  <helder@sencha.com>
 932
 933         Reviewed by Simon Fraser.
 934
 935         Shadow is not drawn when filling a path with a gradient
 936         https://bugs.webkit.org/show_bug.cgi?id=51982
 937
 938         This happens in CG and is related to bug 51869, this time to be fixed
 939         in GraphicsContext::fillPath(const Path& path). We need to draw the
 940         gradient clipped to the path on a CGLayer first, and then draw the
 941         layer on the GraphicsContext.
 942
 943         Test: fast/canvas/canvas-fillPath-gradient-shadow.html
 944
 945         * platform/graphics/cg/GraphicsContextCG.cpp:
 946         (WebCore::GraphicsContext::fillPath):
 947
 948 2011-01-14  Simon Fraser  <simon.fraser@apple.com>
 949
 950         Reviewed by Adam Roben.
 951
 952         Layer syncing should go through the compositor
 953         https://bugs.webkit.org/show_bug.cgi?id=52486
 954
 955         Rather than have FrameView go directly to GraphicsLayer to
 956         sync pending changes, route the call through RenderLayerCompositor.
 957
 958         Add a FIXME about an existing issue with flushing and subframes.
 959
 960         No behavior change, so no tests.
 961
 962         * page/FrameView.cpp:
 963         (WebCore::FrameView::syncCompositingStateForThisFrame):
 964         * rendering/RenderLayerBacking.cpp:
 965         (WebCore::RenderLayerBacking::notifySyncRequired):
 966         * rendering/RenderLayerCompositor.cpp:
 967         (WebCore::RenderLayerCompositor::scheduleLayerFlush):
 968         (WebCore::RenderLayerCompositor::flushPendingLayerChanges):
 969         * rendering/RenderLayerCompositor.h:
 970         (WebCore::RenderLayerCompositor::notifySyncRequired):
 971
 972 2011-01-14  Abhishek Arya  <inferno@chromium.org>
 973
 974         Reviewed by David Hyatt.
 975
 976         Fix parent block calculation when trying to find top most node
 977         containing "this" float.
 978         https://bugs.webkit.org/show_bug.cgi?id=51711
 979
 980         Replace use of containingBlock and traverse the parents directly
 981         to check for float existence. containingBlock can skip parents and
 982         jump to the RenderView directly which will cause floats to not get
 983         cleared from intermediate parents.
 984
 985         Test: fast/block/float/floats-not-cleared-crash.html
 986
 987         * rendering/RenderBox.cpp:
 988         (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
 989
 990 2011-01-14  Adam Klein  <adamk@chromium.org>
 991
 992         Reviewed by Darin Fisher.
 993
 994         [Chromium] Replace BackForwardListClient with BackForwardControllerClient/BackForwardList
 995         https://bugs.webkit.org/show_bug.cgi?id=42237
 996
 997         Remove Chromium-specific implementation from WebCore.
 998
 999         No tests added; this refactor should be covered by existing history-exercising tests.
1000
1001         * WebCore.gyp/WebCore.gyp:
1002         * WebCore.gypi:
1003         * history/BackForwardListChromium.cpp: Removed.
1004         * history/BackForwardListImpl.h:
1005
1006 2011-01-12  Satish Sampath  <satish@chromium.org>
1007
1008         Reviewed by Dimitri Glazkov.
1009
1010         Fix a crash when accessing speech input from script.
1011         https://bugs.webkit.org/show_bug.cgi?id=52325
1012
1013         Test: fast/speech/speech-input-scripting.html
1014
1015         * html/HTMLInputElement.cpp:
1016         (WebCore::HTMLInputElement::parseMappedAttribute): Recreate renderer when speech input is enabled/disabled.
1017         * rendering/RenderTextControlSingleLine.cpp: Remove unused code.
1018         * rendering/RenderTextControlSingleLine.h:
1019         * rendering/TextControlInnerElements.cpp: Take self references before firing events and check for renderer validity after.
1020         (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
1021         (WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
1022         (WebCore::InputFieldSpeechButtonElement::detach):
1023
1024 2011-01-14  Abhishek Arya  <inferno@chromium.org>
1025
1026         Reviewed by David Hyatt.
1027
1028         Prevent merging of anonymous blocks if one of them is already getting
1029         destroyed.
1030         https://bugs.webkit.org/show_bug.cgi?id=52402
1031
1032         Test: fast/block/merge-anonymous-block-remove-child-crash2.html
1033
1034         * rendering/RenderBlock.cpp:
1035         (WebCore::RenderBlock::RenderBlock): initialize m_beingDestroyed to false.
1036         (WebCore::RenderBlock::destroy): set m_beingDestroyed to true.
1037         (WebCore::canMergeContiguousAnonymousBlocks): do not merge if any or prev or next is being destroyed.
1038         (WebCore::RenderBlock::removeChild): remove the hack previously done for preventing oldChild merging with nextBlock's next sibling.
1039         * rendering/RenderBlock.h:
1040         (WebCore::RenderBlock::beingDestroyed): public function for m_beingDestroyed.
1041
1042 2011-01-14  Pavel Feldman  <pfeldman@chromium.org>
1043
1044         Not reviewed. Follow up to r75791: fix missing dispatch.
1045         https://bugs.webkit.org/show_bug.cgi?id=52442
1046
1047         * inspector/front-end/DebuggerModel.js:
1048         (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
1049
1050 2011-01-14  Simon Fraser  <simon.fraser@apple.com>
1051
1052         Reviewed by Adam Roben.
1053
1054         Issues with contentsScale in GraphicsLayerCA
1055         https://bugs.webkit.org/show_bug.cgi?id=52463
1056
1057         Fix various issues with the recent contentsScale changes:
1058
1059         * platform/graphics/ca/GraphicsLayerCA.cpp:
1060         (WebCore::GraphicsLayerCA::GraphicsLayerCA): Initialize m_contentsScale to 1.
1061         (WebCore::GraphicsLayerCA::updateContentsScale): Only do a setNeedsDisplay()
1062         if the layer draws content, otherwise we'll create backing store for empty layers.
1063         (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Be sure to set contentsScale
1064         on the new (tiled or untiled) layer.
1065         (WebCore::GraphicsLayerCA::cloneLayer): Clones need contentsScale too.
1066
1067 2011-01-14  Simon Fraser  <simon.fraser@apple.com>
1068
1069         Let Xcode have it's way with the project file.
1070
1071         * WebCore.xcodeproj/project.pbxproj:
1072
1073 2011-01-14  Simon Fraser  <simon.fraser@apple.com>
1074
1075         Reviewed by Anders Carlsson.
1076
1077         Refactor some FrameView::syncCompositingState code
1078         https://bugs.webkit.org/show_bug.cgi?id=52459
1079
1080         Refactor some code in FrameView related to synchronizing
1081         compositing layer state.
1082
1083         * page/FrameView.cpp:
1084         (WebCore::FrameView::syncCompositingStateForThisFrame):
1085         (WebCore::FrameView::syncCompositingStateRecursive):
1086         (WebCore::FrameView::paintContents):
1087         * page/FrameView.h:
1088
1089 2011-01-14  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1090
1091         Reviewed by Eric Seidel.
1092
1093         [Qt] Fix build problem introduced by http://trac.webkit.org/changeset/75713
1094         https://bugs.webkit.org/show_bug.cgi?id=30179
1095
1096         * plugins/symbian/PluginViewSymbian.cpp:
1097
1098 2011-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1099
1100         Reviewed by Martin Robinson.
1101
1102         [GTK] Add volume slider to media player
1103         https://bugs.webkit.org/show_bug.cgi?id=51532
1104
1105         * css/mediaControlsGtk.css:
1106         (audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
1107         (audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
1108         (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
1109         * platform/gtk/RenderThemeGtk.cpp:
1110         (WebCore::RenderThemeGtk::adjustMediaSliderThumbSize):
1111         (WebCore::RenderThemeGtk::paintMediaVolumeSliderContainer):
1112         (WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack):
1113         (WebCore::RenderThemeGtk::paintMediaVolumeSliderThumb):
1114         * platform/gtk/RenderThemeGtk.h:
1115         * platform/gtk/RenderThemeGtk2.cpp:
1116         (WebCore::RenderThemeGtk::paintSliderTrack):
1117         (WebCore::RenderThemeGtk::paintSliderThumb):
1118         (WebCore::RenderThemeGtk::adjustSliderThumbSize):
1119         * platform/gtk/RenderThemeGtk3.cpp:
1120         (WebCore::RenderThemeGtk::paintSliderTrack):
1121         (WebCore::RenderThemeGtk::paintSliderThumb):
1122         (WebCore::RenderThemeGtk::adjustSliderThumbSize):
1123
1124 2011-01-14  Joone Hur  <joone.hur@collabora.co.uk>
1125
1126         Reviewed by David Levin.
1127
1128         [GTK] Convert use of raw pointers to GOwnPtr in FileSystemGtk.cpp
1129         https://bugs.webkit.org/show_bug.cgi?id=52434
1130
1131         No new tests. This code will be tested when an implementation
1132         of beginDragWithFiles is complete.
1133
1134         * platform/gtk/FileSystemGtk.cpp:
1135         (WebCore::filenameToString): Use GOwnPtr instead of gchar pointer.
1136         (WebCore::fileSystemRepresentation): Ditto.
1137         (WebCore::filenameForDisplay): Ditto.
1138         (WebCore::pathGetFileName): Ditto.
1139
1140 2011-01-14  Pavel Podivilov  <podivilov@chromium.org>
1141
1142         Reviewed by Yury Semikhatsky.
1143
1144         Web Inspector: breakpoint text snippet in breakpoints sidebar pane disappears after reload.
1145         https://bugs.webkit.org/show_bug.cgi?id=52215
1146
1147         * inspector/front-end/Breakpoint.js:
1148         (WebInspector.Breakpoint):
1149         (WebInspector.Breakpoint.prototype.populateLabelElement):
1150         * inspector/front-end/Script.js:
1151         (WebInspector.Script.prototype.get linesCount):
1152         (WebInspector.Script.prototype.sourceLine):
1153         (WebInspector.Script.prototype.sourceLine.didRequestSource):
1154         (WebInspector.Script.prototype.set source):
1155         (WebInspector.Script.prototype.requestSource.didGetScriptSource):
1156         (WebInspector.Script.prototype.requestSource):
1157         * inspector/front-end/ScriptView.js:
1158         (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded.didRequestSource):
1159         (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
1160         * inspector/front-end/SourceFrame.js:
1161         (WebInspector.SourceFrame.prototype._addBreakpoint):
1162         * inspector/front-end/utilities.js:
1163         (String.prototype.findAll):
1164
1165 2011-01-14  Pavel Podivilov  <podivilov@chromium.org>
1166
1167         Reviewed by Yury Semikhatsky.
1168
1169         Web Inspector: provide script column offset to frontend.
1170         https://bugs.webkit.org/show_bug.cgi?id=52377
1171
1172         * bindings/js/ScriptDebugServer.cpp:
1173         (WebCore::ScriptDebugServer::dispatchDidParseSource):
1174         * bindings/js/ScriptSourceCode.h:
1175         (WebCore::ScriptSourceCode::ScriptSourceCode):
1176         * bindings/v8/DebuggerScript.js:
1177         ():
1178         * bindings/v8/ScriptDebugServer.cpp:
1179         (WebCore::ScriptDebugServer::dispatchDidParseSource):
1180         * inspector/Inspector.idl:
1181         * inspector/InspectorDebuggerAgent.cpp:
1182         (WebCore::InspectorDebuggerAgent::didParseSource):
1183         * inspector/InspectorDebuggerAgent.h:
1184         * inspector/ScriptDebugListener.h:
1185         * inspector/front-end/DebuggerModel.js:
1186         (WebInspector.DebuggerModel.prototype.parsedScriptSource):
1187         * inspector/front-end/Script.js:
1188         (WebInspector.Script):
1189
1190 2011-01-14  Ilya Tikhonovsky  <loislo@chromium.org>
1191
1192         Unreviewed one line fix for console-xhr-logging test.
1193
1194         The problem was introduced at r75788.
1195
1196         * inspector/InspectorBrowserDebuggerAgent.cpp:
1197         (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
1198
1199 2011-01-13  Yury Semikhatsky  <yurys@chromium.org>
1200
1201         Reviewed by Pavel Feldman.
1202
1203         Web Inspector: extract console related functionality into InspectorConsoleAgent
1204         https://bugs.webkit.org/show_bug.cgi?id=52282
1205
1206         * CMakeLists.txt:
1207         * GNUmakefile.am:
1208         * WebCore.gypi:
1209         * WebCore.pro:
1210         * inspector/CodeGeneratorInspector.pm:
1211         * inspector/ConsoleMessage.cpp:
1212         (WebCore::ConsoleMessage::~ConsoleMessage):
1213         * inspector/ConsoleMessage.h:
1214         * inspector/Inspector.idl:
1215         * inspector/InspectorConsoleAgent.cpp: Added.
1216         (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
1217         (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
1218         (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
1219         (WebCore::InspectorConsoleAgent::clearConsoleMessages):
1220         (WebCore::InspectorConsoleAgent::reset):
1221         (WebCore::InspectorConsoleAgent::setFrontend):
1222         (WebCore::InspectorConsoleAgent::addMessageToConsole):
1223         (WebCore::InspectorConsoleAgent::startTiming):
1224         (WebCore::InspectorConsoleAgent::stopTiming):
1225         (WebCore::InspectorConsoleAgent::count):
1226         (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
1227         (WebCore::InspectorConsoleAgent::didReceiveResponse):
1228         (WebCore::InspectorConsoleAgent::didFailLoading):
1229         (WebCore::InspectorConsoleAgent::addConsoleMessage):
1230         * inspector/InspectorConsoleAgent.h: Added.
1231         * inspector/InspectorController.cpp:
1232         (WebCore::InspectorController::InspectorController):
1233         (WebCore::InspectorController::clearConsoleMessages):
1234         (WebCore::InspectorController::connectFrontend):
1235         (WebCore::InspectorController::disconnectFrontend):
1236         (WebCore::InspectorController::didCommitLoad):
1237         * inspector/InspectorController.h:
1238         (WebCore::InspectorController::consoleAgent):
1239         * inspector/InspectorInstrumentation.cpp:
1240         (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
1241         (WebCore::InspectorInstrumentation::didFailLoadingImpl):
1242         (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
1243         (WebCore::InspectorInstrumentation::addMessageToConsole):
1244         (WebCore::InspectorInstrumentation::count):
1245         (WebCore::InspectorInstrumentation::startTiming):
1246         (WebCore::InspectorInstrumentation::stopTiming):
1247         (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
1248         * inspector/InspectorInstrumentation.h:
1249         * inspector/InspectorProfilerAgent.cpp:
1250         (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
1251         (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
1252         * inspector/front-end/ConsoleView.js:
1253         (WebInspector.ConsoleView):
1254         (WebInspector.ConsoleView.prototype.addConsoleMessage):
1255         (WebInspector.ConsoleView.prototype.updateConsoleMessageExpiredCount):
1256         (WebInspector.ConsoleView.prototype.consoleMessagesCleared):
1257         * inspector/front-end/inspector.js:
1258         * page/Console.cpp:
1259         (WebCore::Console::addMessage):
1260         (WebCore::Console::count):
1261         (WebCore::Console::profile):
1262         (WebCore::Console::time):
1263         (WebCore::Console::timeEnd):
1264         (WebCore::Console::group):
1265         (WebCore::Console::groupCollapsed):
1266         (WebCore::Console::groupEnd):
1267         * page/Console.h:
1268         * page/Console.idl:
1269
1270 2011-01-14  Pavel Feldman  <pfeldman@chromium.org>
1271
1272         Reviewed by Yury Semikhatsky.
1273
1274         Web Inspector: do not use this as protocol message
1275         dispatcher in models / agents.
1276         https://bugs.webkit.org/show_bug.cgi?id=52442
1277
1278         Models should never for InspectorBackend.registerDomainDispatcher("foo", this).
1279         There should be a clear way to tell whether method is being called
1280         from within front-end or by the backend.
1281
1282         * inspector/front-end/DOMAgent.js:
1283         (WebInspector.DOMAgent):
1284         (WebInspector.DOMAgent.prototype.nodeForId):
1285         (WebInspector.DOMAgent.prototype._bindNodes):
1286         (WebInspector.DOMAgent.prototype._removeBreakpoints):
1287         (WebInspector.DOMDispatcher):
1288         (WebInspector.DOMDispatcher.prototype.setDocument):
1289         (WebInspector.DOMDispatcher.prototype.attributesUpdated):
1290         (WebInspector.DOMDispatcher.prototype.characterDataModified):
1291         (WebInspector.DOMDispatcher.prototype.setChildNodes):
1292         (WebInspector.DOMDispatcher.prototype.setDetachedRoot):
1293         (WebInspector.DOMDispatcher.prototype.childNodeCountUpdated):
1294         (WebInspector.DOMDispatcher.prototype.childNodeInserted):
1295         (WebInspector.DOMDispatcher.prototype.childNodeRemoved):
1296         (WebInspector.DOMDispatcher.prototype.didCommitLoad):
1297         (WebInspector.ApplicationCacheDispatcher):
1298         (WebInspector.ApplicationCacheDispatcher.prototype.getApplicationCachesAsync):
1299         (WebInspector.ApplicationCacheDispatcher.prototype.updateApplicationCacheStatus):
1300         (WebInspector.ApplicationCacheDispatcher.prototype.updateNetworkState):
1301         * inspector/front-end/DOMStorage.js:
1302         (WebInspector.DOMStorageDispatcher):
1303         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
1304         (WebInspector.DOMStorageDispatcher.prototype.selectDOMStorage):
1305         (WebInspector.DOMStorageDispatcher.prototype.updateDOMStorage):
1306         * inspector/front-end/Database.js:
1307         (WebInspector.Database.prototype.executeSql):
1308         (WebInspector.DatabaseDispatcher):
1309         (WebInspector.DatabaseDispatcher.prototype.addDatabase):
1310         (WebInspector.DatabaseDispatcher.prototype.selectDatabase):
1311         (WebInspector.DatabaseDispatcher.prototype.sqlTransactionSucceeded):
1312         (WebInspector.DatabaseDispatcher.prototype.sqlTransactionFailed):
1313         * inspector/front-end/DebuggerModel.js:
1314         (WebInspector.DebuggerModel):
1315         (WebInspector.DebuggerModel.prototype._pausedScript):
1316         (WebInspector.DebuggerModel.prototype._resumedScript):
1317         (WebInspector.DebuggerModel.prototype._parsedScriptSource):
1318         (WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
1319         (WebInspector.DebuggerDispatcher):
1320         (WebInspector.DebuggerDispatcher.prototype.pausedScript):
1321         (WebInspector.DebuggerDispatcher.prototype.resumedScript):
1322         (WebInspector.DebuggerDispatcher.prototype.parsedScriptSource):
1323         (WebInspector.DebuggerDispatcher.prototype.failedToParseScriptSource):
1324         * inspector/front-end/FileSystemView.js:
1325         (WebInspector.FileSystemDispatcher):
1326         (WebInspector.FileSystemDispatcher.prototype.getFileSystemPathsAsync):
1327         (WebInspector.FileSystemDispatcher.prototype.didGetFileSystemPath):
1328         (WebInspector.FileSystemDispatcher.prototype.didGetFileSystemError):
1329         (WebInspector.FileSystemDispatcher.prototype.didGetFileSystemDisabled):
1330         * inspector/front-end/ProfilesPanel.js:
1331         (WebInspector.ProfilesPanel):
1332         (WebInspector.ProfilesPanel.prototype._addProfileHeader):
1333         (WebInspector.ProfilesPanel.prototype._removeProfileHeader):
1334         (WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
1335         (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
1336         (WebInspector.ProfilesPanel.prototype._setRecordingProfile):
1337         (WebInspector.ProfilerDispatcher):
1338         (WebInspector.ProfilerDispatcher.prototype.profilerWasEnabled):
1339         (WebInspector.ProfilerDispatcher.prototype.profilerWasDisabled):
1340         (WebInspector.ProfilerDispatcher.prototype.resetProfiles):
1341         (WebInspector.ProfilerDispatcher.prototype.addProfileHeader):
1342         (WebInspector.ProfilerDispatcher.prototype.addHeapSnapshotChunk):
1343         (WebInspector.ProfilerDispatcher.prototype.finishHeapSnapshot):
1344         (WebInspector.ProfilerDispatcher.prototype.setRecordingProfile):
1345         (WebInspector.ProfileSidebarTreeElement.prototype.ondelete):
1346         * inspector/front-end/ResourceTreeModel.js:
1347         (WebInspector.ResourceTreeModel):
1348         * inspector/front-end/TimelinePanel.js:
1349         (WebInspector.TimelinePanel):
1350         (WebInspector.TimelinePanel.prototype._timelineProfilerWasStarted):
1351         (WebInspector.TimelinePanel.prototype._timelineProfilerWasStopped):
1352         (WebInspector.TimelinePanel.prototype._addRecordToTimeline):
1353         (WebInspector.TimelineDispatcher):
1354         (WebInspector.TimelineDispatcher.prototype.timelineProfilerWasStarted):
1355         (WebInspector.TimelineDispatcher.prototype.timelineProfilerWasStopped):
1356         (WebInspector.TimelineDispatcher.prototype.addRecordToTimeline):
1357
1358 2011-01-14  Csaba Osztrogonác  <ossy@webkit.org>
1359
1360         [Qt][V8] Unreviewed buildfix after r75788.
1361
1362         * inspector/InspectorBrowserDebuggerAgent.cpp:
1363
1364 2011-01-12  Ilya Tikhonovsky  <loislo@chromium.org>
1365
1366         Reviewed by Yury Semikhatsky.
1367
1368         Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
1369         We have some methods of Debugger which are related to DOM.
1370         Lets extract these methods to BrowserDebugger agent.
1371
1372         http://bugs.webkit.org/show_bug.cgi?id=52294
1373
1374         * CMakeLists.txt:
1375         * WebCore.gypi:
1376         * WebCore.pro:
1377         * WebCore.vcproj/WebCore.vcproj:
1378         * WebCore.xcodeproj/project.pbxproj:
1379         * inspector/CodeGeneratorInspector.pm:
1380         * inspector/Inspector.idl:
1381         * inspector/InspectorBrowserDebuggerAgent.cpp: Added.
1382         (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
1383         (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
1384         (WebCore::InspectorBrowserDebuggerAgent::discardBindings):
1385         (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
1386         (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
1387         (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
1388         (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
1389         (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
1390         (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
1391         (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
1392         (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
1393         (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
1394         (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
1395         (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
1396         (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
1397         (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
1398         (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
1399         (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
1400         (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
1401         (WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
1402         * inspector/InspectorBrowserDebuggerAgent.h: Added.
1403         (WebCore::InspectorBrowserDebuggerAgent::create):
1404         * inspector/InspectorController.cpp:
1405         (WebCore::InspectorController::InspectorController):
1406         (WebCore::InspectorController::inspectedPageDestroyed):
1407         (WebCore::InspectorController::didCommitLoad):
1408         (WebCore::InspectorController::enableDebuggerFromFrontend):
1409         (WebCore::InspectorController::disableDebugger):
1410         (WebCore::InspectorController::restoreStickyBreakpoints):
1411         (WebCore::InspectorController::restoreStickyBreakpoint):
1412         * inspector/InspectorController.h:
1413         * inspector/InspectorDOMAgent.cpp:
1414         (WebCore::InspectorDOMAgent::discardBindings):
1415         (WebCore::InspectorDOMAgent::didInsertDOMNode):
1416         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
1417         * inspector/InspectorDOMAgent.h:
1418         * inspector/InspectorInstrumentation.cpp:
1419         (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
1420         (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
1421         (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
1422         (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
1423         (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
1424         (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
1425         (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
1426
1427 2011-01-14  Andrey Kosyakov  <caseq@chromium.org>
1428
1429         Reviewed by Pavel Feldman.
1430
1431         Web Inspector: redirected resources not handled properly in Network panel
1432         https://bugs.webkit.org/show_bug.cgi?id=52292
1433
1434         * inspector/Inspector.idl: Do not pass isMainResource to identifierForInitialRequest() (it's useless, as we may hit provisional load)
1435         * inspector/InspectorInstrumentation.cpp: Ditto.
1436         (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
1437         * inspector/InspectorResourceAgent.cpp: Ditto.
1438         (WebCore::InspectorResourceAgent::identifierForInitialRequest):
1439         * inspector/InspectorResourceAgent.h: Ditto.
1440         * inspector/InspectorInstrumentation.cpp: Ditto.
1441         (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl): Fix main resource detection.
1442         * inspector/front-end/AuditsPanel.js: WebInspector.networkResources now returns array, not map.
1443         * inspector/front-end/ConsoleView.js: User WebInspector.resourceById() to get resource
1444         (WebInspector.ConsoleMessage.prototype._formatMessage):
1445         * inspector/front-end/ExtensionServer.js: Ditto.
1446         (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
1447         (WebInspector.ExtensionServer.prototype._onGetResourceContent):
1448         * inspector/front-end/HAREntry.js: WebInspector.networkResources now returns array, not map
1449         (WebInspector.HARLog.prototype.build):
1450         (WebInspector.HARLog.prototype._convertResource):
1451         * inspector/front-end/NetworkManager.js:
1452         (WebInspector.NetworkManager): Use appendResource, not refreshResource, when adding a new resource.
1453         (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
1454         (WebInspector.NetworkManager.prototype.willSendRequest):
1455         (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache):
1456         (WebInspector.NetworkManager.prototype.setInitialContent):
1457         (WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
1458         (WebInspector.NetworkManager.prototype.didCreateWebSocket):
1459         (WebInspector.NetworkManager.prototype._createResource): always register resource URL with ResourceTreeModel
1460         (WebInspector.NetworkManager.prototype._appendRedirect):
1461         * inspector/front-end/NetworkPanel.js:
1462         (WebInspector.NetworkPanel):
1463         (WebInspector.NetworkPanel.prototype.get resources):
1464         (WebInspector.NetworkPanel.prototype.resourceById):
1465         (WebInspector.NetworkPanel.prototype.appendResource): Add resource as new iff appendResource was added.
1466         (WebInspector.NetworkPanel.prototype.refreshResource): ditto.
1467         (WebInspector.NetworkPanel.prototype.mainResourceChanged): Clear console upon arrival of new main resource.
1468         * inspector/front-end/ResourceTreeModel.js: Expose unbindResourceURL, bind resources automatically upon creation.
1469         (WebInspector.ResourceTreeModel.prototype._clearResources):
1470         (WebInspector.ResourceTreeModel.prototype.unbindResourceURL):
1471         (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
1472         (WebInspector.ResourceTreeModel.prototype.createResource):
1473         * inspector/front-end/inspector.js:
1474         (WebInspector.resourceById):
1475
1476 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1477
1478         Unreviewed, rolling out r75783.
1479         http://trac.webkit.org/changeset/75783
1480         https://bugs.webkit.org/show_bug.cgi?id=52439
1481
1482         a bit strange but the same patch have broken mac builds at
1483         linking stage. (Requested by loislo2 on #webkit).
1484
1485         * CMakeLists.txt:
1486         * GNUmakefile.am:
1487         * WebCore.gypi:
1488         * WebCore.pro:
1489         * WebCore.vcproj/WebCore.vcproj:
1490         * WebCore.xcodeproj/project.pbxproj:
1491         * inspector/CodeGeneratorInspector.pm:
1492         * inspector/Inspector.idl:
1493         * inspector/InspectorBrowserDebuggerAgent.cpp: Removed.
1494         * inspector/InspectorBrowserDebuggerAgent.h: Removed.
1495         * inspector/InspectorController.cpp:
1496         (WebCore::InspectorController::InspectorController):
1497         (WebCore::InspectorController::inspectedPageDestroyed):
1498         (WebCore::InspectorController::didCommitLoad):
1499         (WebCore::InspectorController::enableDebuggerFromFrontend):
1500         (WebCore::InspectorController::disableDebugger):
1501         (WebCore::InspectorController::restoreStickyBreakpoints):
1502         (WebCore::InspectorController::restoreStickyBreakpoint):
1503         (WebCore::InspectorController::setEventListenerBreakpoint):
1504         (WebCore::InspectorController::removeEventListenerBreakpoint):
1505         (WebCore::InspectorController::hasEventListenerBreakpoint):
1506         (WebCore::InspectorController::setXHRBreakpoint):
1507         (WebCore::InspectorController::removeXHRBreakpoint):
1508         (WebCore::InspectorController::hasXHRBreakpoint):
1509         * inspector/InspectorController.h:
1510         * inspector/InspectorDOMAgent.cpp:
1511         (WebCore::InspectorDOMAgent::discardBindings):
1512         (WebCore::InspectorDOMAgent::setDOMBreakpoint):
1513         (WebCore::InspectorDOMAgent::removeDOMBreakpoint):
1514         (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion):
1515         (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval):
1516         (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification):
1517         (WebCore::InspectorDOMAgent::descriptionForDOMEvent):
1518         (WebCore::InspectorDOMAgent::didInsertDOMNode):
1519         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
1520         (WebCore::InspectorDOMAgent::hasBreakpoint):
1521         (WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
1522         * inspector/InspectorDOMAgent.h:
1523         * inspector/InspectorInstrumentation.cpp:
1524         (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
1525         (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
1526         (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
1527         (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
1528         (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
1529         (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
1530         (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
1531
1532 2011-01-12  Ilya Tikhonovsky  <loislo@chromium.org>
1533
1534         Reviewed by Yury Semikhatsky.
1535
1536         Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
1537         We have some methods of Debugger which are related to DOM.
1538         Lets extract these methods to BrowserDebugger agent.
1539
1540         http://bugs.webkit.org/show_bug.cgi?id=52294
1541
1542         * CMakeLists.txt:
1543         * WebCore.gypi:
1544         * WebCore.pro:
1545         * WebCore.vcproj/WebCore.vcproj:
1546         * WebCore.xcodeproj/project.pbxproj:
1547         * inspector/CodeGeneratorInspector.pm:
1548         * inspector/Inspector.idl:
1549         * inspector/InspectorBrowserDebuggerAgent.cpp: Added.
1550         (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
1551         (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
1552         (WebCore::InspectorBrowserDebuggerAgent::discardBindings):
1553         (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
1554         (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
1555         (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
1556         (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
1557         (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
1558         (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
1559         (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
1560         (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
1561         (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
1562         (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
1563         (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
1564         (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
1565         (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
1566         (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
1567         (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
1568         (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
1569         (WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
1570         * inspector/InspectorBrowserDebuggerAgent.h: Added.
1571         (WebCore::InspectorBrowserDebuggerAgent::create):
1572         * inspector/InspectorController.cpp:
1573         (WebCore::InspectorController::InspectorController):
1574         (WebCore::InspectorController::inspectedPageDestroyed):
1575         (WebCore::InspectorController::didCommitLoad):
1576         (WebCore::InspectorController::enableDebuggerFromFrontend):
1577         (WebCore::InspectorController::disableDebugger):
1578         (WebCore::InspectorController::restoreStickyBreakpoints):
1579         (WebCore::InspectorController::restoreStickyBreakpoint):
1580         * inspector/InspectorController.h:
1581         * inspector/InspectorDOMAgent.cpp:
1582         (WebCore::InspectorDOMAgent::discardBindings):
1583         (WebCore::InspectorDOMAgent::didInsertDOMNode):
1584         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
1585         * inspector/InspectorDOMAgent.h:
1586         * inspector/InspectorInstrumentation.cpp:
1587         (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
1588         (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
1589         (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
1590         (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
1591         (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
1592         (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
1593         (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
1594
1595 2011-01-14  Pavel Feldman  <pfeldman@chromium.org>
1596
1597         Not reviewed: build fix.
1598
1599         * WebCore.vcproj/WebCore.vcproj:
1600
1601 2011-01-14  Pavel Feldman  <pfeldman@chromium.org>
1602
1603         Reviewed by Yury Semikhatsky.
1604
1605         Web Inspector: extract InspectorSettings from InspectorState,
1606         simplify it.
1607         https://bugs.webkit.org/show_bug.cgi?id=52429
1608
1609         * CMakeLists.txt:
1610         * GNUmakefile.am:
1611         * WebCore.gypi:
1612         * WebCore.pro:
1613         * WebCore.xcodeproj/project.pbxproj:
1614         * inspector/InspectorClient.h:
1615         * inspector/InspectorController.cpp:
1616         (WebCore::InspectorController::InspectorController):
1617         (WebCore::InspectorController::inspectorStartsAttached):
1618         (WebCore::InspectorController::setInspectorStartsAttached):
1619         (WebCore::InspectorController::setInspectorAttachedHeight):
1620         (WebCore::InspectorController::inspectorAttachedHeight):
1621         (WebCore::InspectorController::setMonitoringXHREnabled):
1622         (WebCore::InspectorController::restoreDebugger):
1623         (WebCore::InspectorController::restoreProfiler):
1624         (WebCore::InspectorController::ensureSettingsLoaded):
1625         (WebCore::InspectorController::enableProfiler):
1626         (WebCore::InspectorController::disableProfiler):
1627         (WebCore::InspectorController::enableDebuggerFromFrontend):
1628         (WebCore::InspectorController::disableDebugger):
1629         * inspector/InspectorController.h:
1630         * inspector/InspectorSettings.cpp: Added.
1631         (WebCore::InspectorSettings::InspectorSettings):
1632         (WebCore::InspectorSettings::getBoolean):
1633         (WebCore::InspectorSettings::setBoolean):
1634         (WebCore::InspectorSettings::getLong):
1635         (WebCore::InspectorSettings::setLong):
1636         (WebCore::InspectorSettings::registerBoolean):
1637         (WebCore::InspectorSettings::registerLong):
1638         * inspector/InspectorSettings.h: Added.
1639         * inspector/InspectorState.cpp:
1640         (WebCore::InspectorState::InspectorState):
1641         (WebCore::InspectorState::setValue):
1642         (WebCore::InspectorState::setObject):
1643         (WebCore::InspectorState::registerBoolean):
1644         (WebCore::InspectorState::registerString):
1645         (WebCore::InspectorState::registerLong):
1646         (WebCore::InspectorState::registerObject):
1647         (WebCore::InspectorState::Property::create):
1648         * inspector/InspectorState.h:
1649         (WebCore::InspectorState::setBoolean):
1650         (WebCore::InspectorState::setString):
1651         (WebCore::InspectorState::setLong):
1652
1653 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1654
1655         Unreviewed, rolling out r75774.
1656         http://trac.webkit.org/changeset/75774
1657         https://bugs.webkit.org/show_bug.cgi?id=52431
1658
1659         gtk builds were broken (Requested by loislo2 on #webkit).
1660
1661         * CMakeLists.txt:
1662         * WebCore.gypi:
1663         * WebCore.pro:
1664         * WebCore.vcproj/WebCore.vcproj:
1665         * WebCore.xcodeproj/project.pbxproj:
1666         * inspector/CodeGeneratorInspector.pm:
1667         * inspector/Inspector.idl:
1668         * inspector/InspectorBrowserDebuggerAgent.cpp: Removed.
1669         * inspector/InspectorBrowserDebuggerAgent.h: Removed.
1670         * inspector/InspectorController.cpp:
1671         (WebCore::InspectorController::InspectorController):
1672         (WebCore::InspectorController::inspectedPageDestroyed):
1673         (WebCore::InspectorController::didCommitLoad):
1674         (WebCore::InspectorController::enableDebuggerFromFrontend):
1675         (WebCore::InspectorController::disableDebugger):
1676         (WebCore::InspectorController::restoreStickyBreakpoints):
1677         (WebCore::InspectorController::restoreStickyBreakpoint):
1678         (WebCore::InspectorController::setEventListenerBreakpoint):
1679         (WebCore::InspectorController::removeEventListenerBreakpoint):
1680         (WebCore::InspectorController::hasEventListenerBreakpoint):
1681         (WebCore::InspectorController::setXHRBreakpoint):
1682         (WebCore::InspectorController::removeXHRBreakpoint):
1683         (WebCore::InspectorController::hasXHRBreakpoint):
1684         * inspector/InspectorController.h:
1685         * inspector/InspectorDOMAgent.cpp:
1686         (WebCore::InspectorDOMAgent::discardBindings):
1687         (WebCore::InspectorDOMAgent::setDOMBreakpoint):
1688         (WebCore::InspectorDOMAgent::removeDOMBreakpoint):
1689         (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion):
1690         (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval):
1691         (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification):
1692         (WebCore::InspectorDOMAgent::descriptionForDOMEvent):
1693         (WebCore::InspectorDOMAgent::didInsertDOMNode):
1694         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
1695         (WebCore::InspectorDOMAgent::hasBreakpoint):
1696         (WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
1697         * inspector/InspectorDOMAgent.h:
1698         * inspector/InspectorInstrumentation.cpp:
1699         (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
1700         (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
1701         (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
1702         (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
1703         (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
1704         (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
1705         (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
1706
1707 2011-01-12  Ilya Tikhonovsky  <loislo@chromium.org>
1708
1709         Reviewed by Yury Semikhatsky.
1710
1711         Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
1712         We have some methods of Debugger which are related to DOM.
1713         Lets extract these methods to BrowserDebugger agent.
1714
1715         http://bugs.webkit.org/show_bug.cgi?id=52294
1716
1717         * CMakeLists.txt:
1718         * WebCore.gypi:
1719         * WebCore.pro:
1720         * WebCore.vcproj/WebCore.vcproj:
1721         * WebCore.xcodeproj/project.pbxproj:
1722         * inspector/CodeGeneratorInspector.pm:
1723         * inspector/Inspector.idl:
1724         * inspector/InspectorBrowserDebuggerAgent.cpp: Added.
1725         (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
1726         (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
1727         (WebCore::InspectorBrowserDebuggerAgent::discardBindings):
1728         (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
1729         (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
1730         (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
1731         (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
1732         (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
1733         (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
1734         (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
1735         (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
1736         (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
1737         (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
1738         (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
1739         (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
1740         (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
1741         (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
1742         (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
1743         (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
1744         (WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
1745         * inspector/InspectorBrowserDebuggerAgent.h: Added.
1746         (WebCore::InspectorBrowserDebuggerAgent::create):
1747         * inspector/InspectorController.cpp:
1748         (WebCore::InspectorController::InspectorController):
1749         (WebCore::InspectorController::inspectedPageDestroyed):
1750         (WebCore::InspectorController::didCommitLoad):
1751         (WebCore::InspectorController::enableDebuggerFromFrontend):
1752         (WebCore::InspectorController::disableDebugger):
1753         (WebCore::InspectorController::restoreStickyBreakpoints):
1754         (WebCore::InspectorController::restoreStickyBreakpoint):
1755         * inspector/InspectorController.h:
1756         * inspector/InspectorDOMAgent.cpp:
1757         (WebCore::InspectorDOMAgent::discardBindings):
1758         (WebCore::InspectorDOMAgent::didInsertDOMNode):
1759         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
1760         * inspector/InspectorDOMAgent.h:
1761         * inspector/InspectorInstrumentation.cpp:
1762         (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
1763         (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
1764         (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
1765         (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
1766         (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
1767         (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
1768         (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
1769
1770 2011-01-13  Kent Tamura  <tkent@chromium.org>
1771
1772         Reviewed by Dimitri Glazkov.
1773
1774         Implement form validation message UI
1775         https://bugs.webkit.org/show_bug.cgi?id=48980
1776
1777         * Add four internal pseudo selectors:
1778           - -webkit-validation-bubble
1779           - -webkit-validation-bubble-message
1780           - -webkit-validation-bubble-top-outer-arrow
1781           - -webkit-validation-bubble-top-inner-arrow
1782
1783         * Implement ValidationMessage functions
1784           Show the message for <the number of characters> / 20.0 seconds.
1785
1786         No new tests because the feature is disabled by default for now and the
1787         new behavior is strongly timing-dependent.
1788
1789         * css/CSSStyleSelector.cpp:
1790         (WebCore::CSSStyleSelector::canShareStyleWithElement):
1791           Do not share a style with elements with different shadowPseudoId().
1792         * css/html.css: Define appearance for the internal selectors.
1793         (::-webkit-validation-bubble):
1794         (::-webkit-validation-bubble-message):
1795         (::-webkit-validation-bubble-top-outer-arrow):
1796         (::-webkit-validation-bubble-top-inner-arrow):
1797         * dom/Node.cpp:
1798         (WebCore::Node::createRendererIfNeeded):
1799           Allow to add shadow renderers even if canHaveChildren() returns false.
1800         * html/HTMLFormControlElement.cpp:
1801         (WebCore::HTMLFormControlElement::detach):
1802           Remove m_validationMessage immediately because we can't use
1803           hideVisibleValidationMessage(), which calls a ValidationMessage function later.
1804         (WebCore::HTMLFormControlElement::updateVisibleValidationMessage):
1805           - Don't create ValidationMessage if the message is empty.
1806           - Remove the check for message equality.
1807         (WebCore::HTMLFormControlElement::hideVisibleValidationMessage):
1808           Don't remove m_validationMessage immediately. We shouldn't make the
1809           element needsLayout() state in this context.
1810         * html/ValidationMessage.cpp:
1811         (WebCore::ValidationMessage::~ValidationMessage):
1812           hideMessage() -> deleteBubbleTree() renaming.
1813         (WebCore::ValidationMessage::setMessage): Implemented.
1814         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
1815           Added. This updates the validation message and starts the timer to hide it.
1816         (WebCore::ElementWithPseudoId):
1817           Added to help implementations of styled shadow nodes.
1818         (WebCore::ValidationMessage::buildBubbleTree): Added.
1819         (WebCore::ValidationMessage::requestToHideMessage): Added.
1820         (WebCore::ValidationMessage::deleteBubbleTree):
1821           Renamed from hideMessage(), and implemented.
1822         * html/ValidationMessage.h: Add declarations.
1823
1824 2011-01-13  Dan Bernstein  <mitz@apple.com>
1825
1826         Reviewed by Alexey Proskuryakov.
1827
1828         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1829         https://bugs.webkit.org/show_bug.cgi?id=52419
1830
1831         Test: http/tests/loading/cross-origin-XHR-willLoadRequest.html
1832
1833         * loader/ResourceLoader.cpp:
1834         (WebCore::ResourceLoader::init): Complete r74453 by ensuring that m_request is only set after
1835         willSendRequest(). Otherwise, willSendRequest() ends up calling into
1836         ThreadableDocumentRequest::willSendRequest(), which cancels the request.
1837
1838 2011-01-13  Dan Bernstein  <mitz@apple.com>
1839
1840         Reviewed by Mark Rowe.
1841
1842         Don’t try to compile InjectedScriptSource.js into WebCore.
1843
1844         * WebCore.xcodeproj/project.pbxproj:
1845
1846 2011-01-13  Mike Thole  <mthole@apple.com>
1847
1848         Reviewed by Darin Adler and Brady Eidson.
1849
1850         The pageScaleFactor() should be saved/restored along with the scroll position
1851         https://bugs.webkit.org/show_bug.cgi?id=52406
1852         <rdar://problem/8714412>
1853
1854         * history/HistoryItem.cpp:
1855         (WebCore::HistoryItem::HistoryItem): Initialize m_pageScaleFactor.
1856         (WebCore::HistoryItem::pageScaleFactor): Added getter.
1857         (WebCore::HistoryItem::setPageScaleFactor): Added setter.
1858         (WebCore::HistoryItem::encodeBackForwardTreeNode): Encode m_pageScaleFactor.
1859         (WebCore::HistoryItem::decodeBackForwardTree): Decode m_pageScaleFactor.
1860         * history/HistoryItem.h:
1861         * loader/HistoryController.cpp:
1862         (WebCore::HistoryController::saveScrollPositionAndViewStateToItem): Save the page scale factor...
1863         (WebCore::HistoryController::restoreScrollPositionAndViewState): ...and restore it here.
1864
1865 2011-01-13  Evan Martin  <evan@chromium.org>
1866
1867         Reviewed by Tony Chang.
1868
1869         [chromium] drop backwards iteration in Linux complex text code
1870         https://bugs.webkit.org/show_bug.cgi?id=52403
1871
1872         ComplexTextController previously supported iterating through the text in
1873         both directions, but this resulted in duplicate code for each path.
1874         Instead, by being more careful about flipping signs where appropriate,
1875         we can refactor the code into one code path.
1876
1877         No tests, just a refactoring; should be covered by existing tests.
1878
1879         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
1880         (WebCore::ComplexTextController::ComplexTextController):
1881         (WebCore::ComplexTextController::reset):
1882         (WebCore::ComplexTextController::nextScriptRun):
1883         * platform/graphics/chromium/ComplexTextControllerLinux.h:
1884         * platform/graphics/chromium/FontLinux.cpp:
1885         (WebCore::glyphIndexForXPositionInScriptRun):
1886         (WebCore::Font::selectionRectForComplexText):
1887
1888 2011-01-13  Dimitri Glazkov  <dglazkov@chromium.org>
1889
1890         Reviewed by Darin Adler.
1891
1892         Flip input[type=range] to use the new shadow DOM model.
1893         https://bugs.webkit.org/show_bug.cgi?id=52317
1894
1895         This is a straight-up flip, minimal change to the logic, which will be
1896         refactored in a follow-up patch.
1897
1898         Covered by existing tests.
1899
1900         * css/CSSStyleSelector.cpp:
1901         (WebCore::CSSStyleSelector::initForStyleResolve): Changed to use either
1902             host or parent node to find parent.
1903         * html/HTMLInputElement.cpp:
1904         (WebCore::HTMLInputElement::updateType): Added logic for destroying/creating
1905             shadow DOM subtree.
1906         * html/InputType.cpp:
1907         (WebCore::InputType::createShadowSubtree): Added empty decl.
1908         (WebCore::InputType::destroyShadowSubtree): Added a method to destroy
1909             shadow subtree.
1910         * html/InputType.h: Added defs.
1911         * html/RangeInputType.cpp:
1912         (WebCore::RangeInputType::createShadowSubtree): Added a virtual method to create
1913             slider thumb.
1914         * html/RangeInputType.h: Adde def.
1915         * html/shadow/SliderThumbElement.cpp: Added temporary RenderSliderThumb class
1916             to handle cascading appearance.
1917         (WebCore::RenderSliderThumb::RenderSliderThumb): Added.
1918         (WebCore::RenderSliderThumb::layout): Moved here the logic from
1919             RenderSlider::createThumbStyle.
1920         (WebCore::SliderThumbElement::createRenderer): Added virtual method to
1921             create RenderSliderThumb instance.
1922         (WebCore::SliderThumbElement::defaultEventHandler): Changed to use HTMLDivElement
1923             as base class.
1924         (WebCore::SliderThumbElement::detach): Ditto.
1925         * html/shadow/SliderThumbElement.h:
1926         (WebCore::SliderThumbElement::SliderThumbElement): Ditto.
1927         (WebCore::SliderThumbElement::create): Ditto.
1928         (WebCore::toSliderThumbElement): Added a casting helper.
1929         * rendering/MediaControlElements.cpp:
1930         (WebCore::MediaControlInputElement::attach): Added handling of shadow DOM,
1931             since the whole method is hand-rolled.
1932         (WebCore::MediaControlInputElement::updateStyle): Ditto.
1933         * rendering/RenderSlider.cpp:
1934         (WebCore::RenderSlider::~RenderSlider): Removed unneeded code.
1935         (WebCore::RenderSlider::thumbRect): Changed to use sliderThumbElement helper.
1936         (WebCore::RenderSlider::layout): Ditto.
1937         (WebCore::RenderSlider::sliderThumbElement): Added a temporary helper to access
1938             SliderThumbElement.
1939         (WebCore::RenderSlider::mouseEventIsInThumb): Changed to use sliderThumbElement helper.
1940         (WebCore::RenderSlider::mouseEventOffsetToThumb): Ditto.
1941         (WebCore::RenderSlider::setValueForPosition): Ditto.
1942         (WebCore::RenderSlider::positionForOffset): Ditto.
1943         (WebCore::RenderSlider::currentPosition): Ditto.
1944         (WebCore::RenderSlider::trackSize): Ditto.
1945         (WebCore::RenderSlider::forwardEvent): Ditto.
1946         (WebCore::RenderSlider::inDragMode): Ditto.
1947         * rendering/RenderSlider.h: Added def.
1948
1949 2011-01-13  Adam Barth  <abarth@webkit.org>
1950
1951         Reviewed by Eric Seidel.
1952
1953         Rename RGBA32Buffer to ImageFrame
1954         https://bugs.webkit.org/show_bug.cgi?id=52363
1955
1956         RGBA32Buffer is a terrible misnomer.  ImageFrame is vastly
1957         more accurate.  More cleanup to come.
1958
1959         * WebCore.pro:
1960         * platform/graphics/ImageSource.cpp:
1961         (WebCore::ImageSource::createFrameAtIndex):
1962         (WebCore::ImageSource::frameDurationAtIndex):
1963         (WebCore::ImageSource::frameIsCompleteAtIndex):
1964         * platform/graphics/qt/ImageDecoderQt.cpp:
1965         (WebCore::ImageDecoderQt::frameBufferAtIndex):
1966         (WebCore::ImageDecoderQt::internalReadImage):
1967         (WebCore::ImageDecoderQt::internalHandleCurrentImage):
1968         * platform/graphics/qt/ImageDecoderQt.h:
1969         * platform/graphics/wince/ImageWinCE.cpp:
1970         (WebCore::ImageFrame::asNewNativeImage):
1971         * platform/image-decoders/ImageDecoder.cpp:
1972         (WebCore::ImageFrame::ImageFrame):
1973         (WebCore::ImageFrame::operator=):
1974         (WebCore::ImageFrame::clear):
1975         (WebCore::ImageFrame::zeroFill):
1976         (WebCore::ImageFrame::copyReferenceToBitmapData):
1977         (WebCore::ImageFrame::copyBitmapData):
1978         (WebCore::ImageFrame::setSize):
1979         (WebCore::ImageFrame::hasAlpha):
1980         (WebCore::ImageFrame::setHasAlpha):
1981         (WebCore::ImageFrame::setColorProfile):
1982         (WebCore::ImageFrame::setStatus):
1983         (WebCore::ImageFrame::width):
1984         (WebCore::ImageFrame::height):
1985         * platform/image-decoders/ImageDecoder.h:
1986         (WebCore::ImageFrame::ImageFrame):
1987         * platform/image-decoders/bmp/BMPImageDecoder.cpp:
1988         (WebCore::BMPImageDecoder::frameBufferAtIndex):
1989         (WebCore::BMPImageDecoder::decode):
1990         * platform/image-decoders/bmp/BMPImageDecoder.h:
1991         * platform/image-decoders/bmp/BMPImageReader.cpp:
1992         (WebCore::BMPImageReader::decodeBMP):
1993         * platform/image-decoders/bmp/BMPImageReader.h:
1994         (WebCore::BMPImageReader::setBuffer):
1995         * platform/image-decoders/cairo/ImageDecoderCairo.cpp:
1996         (WebCore::ImageFrame::asNewNativeImage):
1997         * platform/image-decoders/cg/ImageDecoderCG.cpp:
1998         (WebCore::getPtrAsPixelData):
1999         (WebCore::ImageFrame::copyReferenceToBitmapData):
2000         (WebCore::ImageFrame::copyBitmapData):
2001         (WebCore::ImageFrame::setSize):
2002         (WebCore::ImageFrame::asNewNativeImage):
2003         * platform/image-decoders/gif/GIFImageDecoder.cpp:
2004         (WebCore::GIFImageDecoder::frameBufferAtIndex):
2005         (WebCore::GIFImageDecoder::clearFrameBufferCache):
2006         (WebCore::GIFImageDecoder::haveDecodedRow):
2007         (WebCore::GIFImageDecoder::frameComplete):
2008         (WebCore::GIFImageDecoder::initFrameBuffer):
2009         * platform/image-decoders/gif/GIFImageDecoder.h:
2010         * platform/image-decoders/gif/GIFImageReader.cpp:
2011         (GIFImageReader::read):
2012         * platform/image-decoders/gif/GIFImageReader.h:
2013         (GIFFrameReader::GIFFrameReader):
2014         * platform/image-decoders/haiku/ImageDecoderHaiku.cpp:
2015         (WebCore::ImageFrame::asNewNativeImage):
2016         * platform/image-decoders/ico/ICOImageDecoder.cpp:
2017         (WebCore::ICOImageDecoder::frameBufferAtIndex):
2018         (WebCore::ICOImageDecoder::decode):
2019         * platform/image-decoders/ico/ICOImageDecoder.h:
2020         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
2021         (WebCore::JPEGImageDecoder::frameBufferAtIndex):
2022         (WebCore::JPEGImageDecoder::outputScanlines):
2023         (WebCore::JPEGImageDecoder::jpegComplete):
2024         (WebCore::JPEGImageDecoder::decode):
2025         * platform/image-decoders/jpeg/JPEGImageDecoder.h:
2026         * platform/image-decoders/openvg/ImageDecoderOpenVG.cpp:
2027         (WebCore::ImageFrame::asNewNativeImage):
2028         * platform/image-decoders/png/PNGImageDecoder.cpp:
2029         (WebCore::PNGImageDecoder::frameBufferAtIndex):
2030         (WebCore::PNGImageDecoder::rowAvailable):
2031         (WebCore::PNGImageDecoder::pngComplete):
2032         * platform/image-decoders/png/PNGImageDecoder.h:
2033         (WebCore::PNGImageDecoder::isComplete):
2034         * platform/image-decoders/qt/ImageFrameQt.cpp: Copied from Source/WebCore/platform/image-decoders/qt/RGBA32BufferQt.cpp.
2035         (WebCore::ImageFrame::ImageFrame):
2036         (WebCore::ImageFrame::operator=):
2037         (WebCore::ImageFrame::clear):
2038         (WebCore::ImageFrame::zeroFill):
2039         (WebCore::ImageFrame::copyBitmapData):
2040         (WebCore::ImageFrame::setSize):
2041         (WebCore::ImageFrame::asNewNativeImage):
2042         (WebCore::ImageFrame::hasAlpha):
2043         (WebCore::ImageFrame::setHasAlpha):
2044         (WebCore::ImageFrame::setColorProfile):
2045         (WebCore::ImageFrame::setStatus):
2046         (WebCore::ImageFrame::setPixmap):
2047         (WebCore::ImageFrame::width):
2048         (WebCore::ImageFrame::height):
2049         * platform/image-decoders/qt/RGBA32BufferQt.cpp: Removed.
2050         * platform/image-decoders/skia/ImageDecoderSkia.cpp:
2051         (WebCore::ImageFrame::ImageFrame):
2052         (WebCore::ImageFrame::operator=):
2053         (WebCore::ImageFrame::clear):
2054         (WebCore::ImageFrame::zeroFill):
2055         (WebCore::ImageFrame::copyBitmapData):
2056         (WebCore::ImageFrame::setSize):
2057         (WebCore::ImageFrame::asNewNativeImage):
2058         (WebCore::ImageFrame::hasAlpha):
2059         (WebCore::ImageFrame::setHasAlpha):
2060         (WebCore::ImageFrame::setColorProfile):
2061         (WebCore::ImageFrame::setStatus):
2062         (WebCore::ImageFrame::width):
2063         (WebCore::ImageFrame::height):
2064         * platform/image-decoders/webp/WEBPImageDecoder.cpp:
2065         (WebCore::WEBPImageDecoder::frameBufferAtIndex):
2066         (WebCore::WEBPImageDecoder::decode):
2067         * platform/image-decoders/webp/WEBPImageDecoder.h:
2068         * platform/image-decoders/wx/ImageDecoderWx.cpp:
2069         (WebCore::ImageFrame::asNewNativeImage):
2070
2071 2011-01-13  Dimitri Glazkov  <dglazkov@chromium.org>
2072
2073         Reviewed by Darin Adler.
2074
2075         Transferring nodes between documents should be aware of the shadow DOM.
2076         https://bugs.webkit.org/show_bug.cgi?id=52399
2077
2078         No visible change in behavior at the moment.
2079
2080         Once https://bugs.webkit.org/show_bug.cgi?id=52317 lands, the following
2081         tests should no longer crash:
2082         * fast/css/pseudo-in-range-invalid-value.html
2083         * fast/css/pseudo-in-range.html
2084         * fast/forms/form-collection-elements.html
2085         * fast/forms/range-keyoperation.html
2086
2087         * dom/Document.cpp:
2088         (WebCore::Document::adoptNode): Changed to use Node::setDocumentRecursively.
2089         * dom/Node.cpp:
2090         (WebCore::Node::setDocumentRecursively): Added new method, taking existing
2091             logic and adding shadow DOM traversal.
2092         (WebCore::Node::traverseNextNode): Style fix.
2093         (WebCore::Node::traverseNextSibling): Ditto.
2094         (WebCore::Node::traversePreviousNode): Ditto.
2095         (WebCore::Node::traversePreviousNodePostOrder): Ditto.
2096         (WebCore::Node::checkReplaceChild): Changed to use setDocumentRecursively.
2097         (WebCore::Node::checkAddChild): Ditto.
2098         * dom/Node.h: Added def.
2099
2100 2011-01-12  Enrica Casucci  <enrica@apple.com>
2101
2102         Reviewed by Darin Adler.
2103
2104         WebKit2: Add support for drag and drop
2105         https://bugs.webkit.org/show_bug.cgi?id=52343
2106         <rdar://problem/7660558>
2107
2108         This patch contains the changes required to support dropping content
2109         in WebKit on the Mac. The DragData class has been extended to provide
2110         additional context from the application (keyboard state, modal windows, etc.)
2111         as well as information of the drag pasteboard being used.
2112         The support for WebKit as drag source will be added with a separate patch.
2113
2114         * WebCore.exp.in:
2115         * page/DragController.cpp:
2116         (WebCore::DragController::dragIsMove): Added DragData parameter.
2117         (WebCore::DragController::tryDocumentDrag): Modified call to dragIsMove.
2118         (WebCore::DragController::concludeEditDrag): Same as above.
2119         * page/DragController.h: Added parameter to isCopyKeyDown.
2120         * page/mac/DragControllerMac.mm:
2121         The following methods have been modified to use the information stored
2122         in the DragData class.
2123         (WebCore::DragController::isCopyKeyDown):
2124         (WebCore::DragController::dragOperation):
2125         * platform/DragData.h:
2126         (WebCore::DragData::flags):
2127         * platform/DragData.cpp: Added default flags parameter to the constructor.
2128         * platform/mac/DragDataMac.mm:
2129         (WebCore::DragData::DragData): Added constructor that receives the name of the pasteboard to use.
2130         (WebCore::DragData::canSmartReplace):
2131         (WebCore::DragData::containsColor):
2132         (WebCore::DragData::containsFiles):
2133         (WebCore::DragData::asFilenames):
2134         (WebCore::DragData::containsPlainText):
2135         (WebCore::DragData::asPlainText):
2136         (WebCore::DragData::containsCompatibleContent):
2137         (WebCore::DragData::asURL):
2138         (WebCore::DragData::asFragment):
2139         All the following files have been modified to add the DragData
2140         parameter to isCopyKeyDown. I plan to improve this in the future
2141         and make isCopyKeyDown not platform specific.
2142         * page/android/DragControllerAndroid.cpp:
2143         (WebCore::DragController::isCopyKeyDown):
2144         * page/brew/DragControllerBrew.cpp:
2145         (WebCore::DragController::isCopyKeyDown):
2146         * page/chromium/DragControllerChromium.cpp:
2147         (WebCore::DragController::isCopyKeyDown):
2148         * page/efl/DragControllerEfl.cpp:
2149         (WebCore::DragController::isCopyKeyDown):
2150         * page/gtk/DragControllerGtk.cpp:
2151         (WebCore::DragController::isCopyKeyDown):
2152         * page/haiku/DragControllerHaiku.cpp:
2153         (WebCore::DragController::isCopyKeyDown):
2154         * page/mac/DragControllerMac.mm:
2155         (WebCore::DragController::isCopyKeyDown):
2156         (WebCore::DragController::dragOperation):
2157         * page/qt/DragControllerQt.cpp:
2158         (WebCore::DragController::isCopyKeyDown):
2159         * page/win/DragControllerWin.cpp:
2160         (WebCore::DragController::isCopyKeyDown):
2161         * page/wx/DragControllerWx.cpp:
2162         (WebCore::DragController::isCopyKeyDown):
2163
2164 2011-01-13  David Kilzer  <ddkilzer@apple.com>
2165
2166         Add missing MathMLElementFactory.h and MathMLNames.h to Xcode project
2167
2168         Not reviewed.
2169
2170         * WebCore.xcodeproj/project.pbxproj: Add missing headers.  Note
2171         that the corresponding source files were originally added to the
2172         project in r48559.
2173
2174 2011-01-12  Zhenyao Mo  <zmo@google.com>
2175
2176         Reviewed by Kenneth Russell.
2177
2178         Use GC3D types in WebGLRenderingContext and related WebGL classes
2179         https://bugs.webkit.org/show_bug.cgi?id=51908
2180
2181         * html/canvas/WebGLActiveInfo.h:
2182         (WebCore::WebGLActiveInfo::create):
2183         (WebCore::WebGLActiveInfo::type):
2184         (WebCore::WebGLActiveInfo::size):
2185         (WebCore::WebGLActiveInfo::WebGLActiveInfo):
2186         * html/canvas/WebGLBuffer.cpp:
2187         (WebCore::WebGLBuffer::associateBufferDataImpl):
2188         (WebCore::WebGLBuffer::associateBufferData):
2189         (WebCore::WebGLBuffer::associateBufferSubDataImpl):
2190         (WebCore::WebGLBuffer::associateBufferSubData):
2191         (WebCore::WebGLBuffer::byteLength):
2192         (WebCore::WebGLBuffer::getCachedMaxIndex):
2193         (WebCore::WebGLBuffer::setCachedMaxIndex):
2194         (WebCore::WebGLBuffer::setTarget):
2195         * html/canvas/WebGLBuffer.h:
2196         (WebCore::WebGLBuffer::getTarget):
2197         * html/canvas/WebGLFramebuffer.cpp:
2198         (WebCore::WebGLFramebuffer::setAttachment):
2199         (WebCore::WebGLFramebuffer::getAttachment):
2200         (WebCore::WebGLFramebuffer::getWidth):
2201         (WebCore::WebGLFramebuffer::getHeight):
2202         (WebCore::WebGLFramebuffer::getColorBufferFormat):
2203         (WebCore::WebGLFramebuffer::initializeRenderbuffers):
2204         * html/canvas/WebGLFramebuffer.h:
2205         * html/canvas/WebGLProgram.cpp:
2206         (WebCore::WebGLProgram::cacheActiveAttribLocations):
2207         (WebCore::WebGLProgram::numActiveAttribLocations):
2208         (WebCore::WebGLProgram::getActiveAttribLocation):
2209         (WebCore::WebGLProgram::isUsingVertexAttrib0):
2210         * html/canvas/WebGLProgram.h:
2211         (WebCore::WebGLProgram::getLinkCount):
2212         * html/canvas/WebGLRenderbuffer.h:
2213         (WebCore::WebGLRenderbuffer::setInternalFormat):
2214         (WebCore::WebGLRenderbuffer::getInternalFormat):
2215         (WebCore::WebGLRenderbuffer::setSize):
2216         (WebCore::WebGLRenderbuffer::getWidth):
2217         (WebCore::WebGLRenderbuffer::getHeight):
2218         * html/canvas/WebGLRenderingContext.cpp:
2219         (WebCore::WebGLRenderingContext::initializeNewContext):
2220         (WebCore::WebGLRenderingContext::sizeInBytes):
2221         (WebCore::WebGLRenderingContext::activeTexture):
2222         (WebCore::WebGLRenderingContext::bindAttribLocation):
2223         (WebCore::WebGLRenderingContext::bindBuffer):
2224         (WebCore::WebGLRenderingContext::bindFramebuffer):
2225         (WebCore::WebGLRenderingContext::bindRenderbuffer):
2226         (WebCore::WebGLRenderingContext::bindTexture):
2227         (WebCore::WebGLRenderingContext::blendColor):
2228         (WebCore::WebGLRenderingContext::blendEquation):
2229         (WebCore::WebGLRenderingContext::blendEquationSeparate):
2230         (WebCore::WebGLRenderingContext::blendFunc):
2231         (WebCore::WebGLRenderingContext::blendFuncSeparate):
2232         (WebCore::WebGLRenderingContext::bufferData):
2233         (WebCore::WebGLRenderingContext::bufferSubData):
2234         (WebCore::WebGLRenderingContext::checkFramebufferStatus):
2235         (WebCore::WebGLRenderingContext::clear):
2236         (WebCore::WebGLRenderingContext::clearColor):
2237         (WebCore::WebGLRenderingContext::clearDepth):
2238         (WebCore::WebGLRenderingContext::clearStencil):
2239         (WebCore::WebGLRenderingContext::colorMask):
2240         (WebCore::WebGLRenderingContext::copyTexImage2D):
2241         (WebCore::WebGLRenderingContext::copyTexSubImage2D):
2242         (WebCore::WebGLRenderingContext::createShader):
2243         (WebCore::WebGLRenderingContext::cullFace):
2244         (WebCore::WebGLRenderingContext::deleteBuffer):
2245         (WebCore::WebGLRenderingContext::depthFunc):
2246         (WebCore::WebGLRenderingContext::depthMask):
2247         (WebCore::WebGLRenderingContext::depthRange):
2248         (WebCore::WebGLRenderingContext::disable):
2249         (WebCore::WebGLRenderingContext::disableVertexAttribArray):
2250         (WebCore::WebGLRenderingContext::validateElementArraySize):
2251         (WebCore::WebGLRenderingContext::validateIndexArrayConservative):
2252         (WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
2253         (WebCore::WebGLRenderingContext::validateRenderingState):
2254         (WebCore::WebGLRenderingContext::drawArrays):
2255         (WebCore::WebGLRenderingContext::drawElements):
2256         (WebCore::WebGLRenderingContext::enable):
2257         (WebCore::WebGLRenderingContext::enableVertexAttribArray):
2258         (WebCore::WebGLRenderingContext::framebufferRenderbuffer):
2259         (WebCore::WebGLRenderingContext::framebufferTexture2D):
2260         (WebCore::WebGLRenderingContext::frontFace):
2261         (WebCore::WebGLRenderingContext::generateMipmap):
2262         (WebCore::WebGLRenderingContext::getActiveAttrib):
2263         (WebCore::WebGLRenderingContext::getActiveUniform):
2264         (WebCore::WebGLRenderingContext::getAttachedShaders):
2265         (WebCore::WebGLRenderingContext::getAttribLocation):
2266         (WebCore::WebGLRenderingContext::getBufferParameter):
2267         (WebCore::WebGLRenderingContext::getError):
2268         (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):
2269         (WebCore::WebGLRenderingContext::getParameter):
2270         (WebCore::WebGLRenderingContext::getProgramParameter):
2271         (WebCore::WebGLRenderingContext::getRenderbufferParameter):
2272         (WebCore::WebGLRenderingContext::getShaderParameter):
2273         (WebCore::WebGLRenderingContext::getTexParameter):
2274         (WebCore::WebGLRenderingContext::getUniform):
2275         (WebCore::WebGLRenderingContext::getUniformLocation):
2276         (WebCore::WebGLRenderingContext::getVertexAttrib):
2277         (WebCore::WebGLRenderingContext::getVertexAttribOffset):
2278         (WebCore::WebGLRenderingContext::hint):
2279         (WebCore::WebGLRenderingContext::isBuffer):
2280         (WebCore::WebGLRenderingContext::isEnabled):
2281         (WebCore::WebGLRenderingContext::isFramebuffer):
2282         (WebCore::WebGLRenderingContext::isProgram):
2283         (WebCore::WebGLRenderingContext::isRenderbuffer):
2284         (WebCore::WebGLRenderingContext::isShader):
2285         (WebCore::WebGLRenderingContext::isTexture):
2286         (WebCore::WebGLRenderingContext::lineWidth):
2287         (WebCore::WebGLRenderingContext::linkProgram):
2288         (WebCore::WebGLRenderingContext::pixelStorei):
2289         (WebCore::WebGLRenderingContext::polygonOffset):
2290         (WebCore::WebGLRenderingContext::readPixels):
2291         (WebCore::WebGLRenderingContext::renderbufferStorage):
2292         (WebCore::WebGLRenderingContext::sampleCoverage):
2293         (WebCore::WebGLRenderingContext::scissor):
2294         (WebCore::WebGLRenderingContext::stencilFunc):
2295         (WebCore::WebGLRenderingContext::stencilFuncSeparate):
2296         (WebCore::WebGLRenderingContext::stencilMask):
2297         (WebCore::WebGLRenderingContext::stencilMaskSeparate):
2298         (WebCore::WebGLRenderingContext::stencilOp):
2299         (WebCore::WebGLRenderingContext::stencilOpSeparate):
2300         (WebCore::WebGLRenderingContext::texImage2DBase):
2301         (WebCore::WebGLRenderingContext::texImage2DImpl):
2302         (WebCore::WebGLRenderingContext::texImage2D):
2303         (WebCore::WebGLRenderingContext::texParameter):
2304         (WebCore::WebGLRenderingContext::texParameterf):
2305         (WebCore::WebGLRenderingContext::texParameteri):
2306         (WebCore::WebGLRenderingContext::texSubImage2DBase):
2307         (WebCore::WebGLRenderingContext::texSubImage2DImpl):
2308         (WebCore::WebGLRenderingContext::texSubImage2D):
2309         (WebCore::WebGLRenderingContext::uniform1f):
2310         (WebCore::WebGLRenderingContext::uniform1fv):
2311         (WebCore::WebGLRenderingContext::uniform1i):
2312         (WebCore::WebGLRenderingContext::uniform1iv):
2313         (WebCore::WebGLRenderingContext::uniform2f):
2314         (WebCore::WebGLRenderingContext::uniform2fv):
2315         (WebCore::WebGLRenderingContext::uniform2i):
2316         (WebCore::WebGLRenderingContext::uniform2iv):
2317         (WebCore::WebGLRenderingContext::uniform3f):
2318         (WebCore::WebGLRenderingContext::uniform3fv):
2319         (WebCore::WebGLRenderingContext::uniform3i):
2320         (WebCore::WebGLRenderingContext::uniform3iv):
2321         (WebCore::WebGLRenderingContext::uniform4f):
2322         (WebCore::WebGLRenderingContext::uniform4fv):
2323         (WebCore::WebGLRenderingContext::uniform4i):
2324         (WebCore::WebGLRenderingContext::uniform4iv):
2325         (WebCore::WebGLRenderingContext::uniformMatrix2fv):
2326         (WebCore::WebGLRenderingContext::uniformMatrix3fv):
2327         (WebCore::WebGLRenderingContext::uniformMatrix4fv):
2328         (WebCore::WebGLRenderingContext::vertexAttrib1f):
2329         (WebCore::WebGLRenderingContext::vertexAttrib1fv):
2330         (WebCore::WebGLRenderingContext::vertexAttrib2f):
2331         (WebCore::WebGLRenderingContext::vertexAttrib2fv):
2332         (WebCore::WebGLRenderingContext::vertexAttrib3f):
2333         (WebCore::WebGLRenderingContext::vertexAttrib3fv):
2334         (WebCore::WebGLRenderingContext::vertexAttrib4f):
2335         (WebCore::WebGLRenderingContext::vertexAttrib4fv):
2336         (WebCore::WebGLRenderingContext::vertexAttribPointer):
2337         (WebCore::WebGLRenderingContext::viewport):
2338         (WebCore::WebGLRenderingContext::getBooleanParameter):
2339         (WebCore::WebGLRenderingContext::getBooleanArrayParameter):
2340         (WebCore::WebGLRenderingContext::getFloatParameter):
2341         (WebCore::WebGLRenderingContext::getIntParameter):
2342         (WebCore::WebGLRenderingContext::getLongParameter):
2343         (WebCore::WebGLRenderingContext::getUnsignedLongParameter):
2344         (WebCore::WebGLRenderingContext::getWebGLFloatArrayParameter):
2345         (WebCore::WebGLRenderingContext::getWebGLIntArrayParameter):
2346         (WebCore::WebGLRenderingContext::isTexInternalFormatColorBufferCombinationValid):
2347         (WebCore::WebGLRenderingContext::getBoundFramebufferColorFormat):
2348         (WebCore::WebGLRenderingContext::validateTextureBinding):
2349         (WebCore::WebGLRenderingContext::validateSize):
2350         (WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
2351         (WebCore::WebGLRenderingContext::validateTexFuncLevel):
2352         (WebCore::WebGLRenderingContext::validateTexFuncParameters):
2353         (WebCore::WebGLRenderingContext::validateTexFuncData):
2354         (WebCore::WebGLRenderingContext::validateDrawMode):
2355         (WebCore::WebGLRenderingContext::validateStencilFunc):
2356         (WebCore::WebGLRenderingContext::validateFramebufferFuncParameters):
2357         (WebCore::WebGLRenderingContext::validateBlendEquation):
2358         (WebCore::WebGLRenderingContext::validateBlendFuncFactors):
2359         (WebCore::WebGLRenderingContext::validateCapability):
2360         (WebCore::WebGLRenderingContext::validateUniformParameters):
2361         (WebCore::WebGLRenderingContext::validateUniformMatrixParameters):
2362         (WebCore::WebGLRenderingContext::validateBufferDataParameters):
2363         (WebCore::WebGLRenderingContext::vertexAttribfImpl):
2364         (WebCore::WebGLRenderingContext::vertexAttribfvImpl):
2365         (WebCore::WebGLRenderingContext::simulateVertexAttrib0):
2366         * html/canvas/WebGLRenderingContext.h:
2367         (WebCore::WebGLRenderingContext::VertexAttribState::VertexAttribState):
2368         * html/canvas/WebGLShader.cpp:
2369         (WebCore::WebGLShader::create):
2370         (WebCore::WebGLShader::WebGLShader):
2371         * html/canvas/WebGLShader.h:
2372         (WebCore::WebGLShader::getType):
2373         * html/canvas/WebGLTexture.cpp:
2374         (WebCore::WebGLTexture::setTarget):
2375         (WebCore::WebGLTexture::setParameteri):
2376         (WebCore::WebGLTexture::setParameterf):
2377         (WebCore::WebGLTexture::setLevelInfo):
2378         (WebCore::WebGLTexture::generateMipmapLevelInfo):
2379         (WebCore::WebGLTexture::getInternalFormat):
2380         (WebCore::WebGLTexture::getType):
2381         (WebCore::WebGLTexture::getWidth):
2382         (WebCore::WebGLTexture::getHeight):
2383         (WebCore::WebGLTexture::isNPOT):
2384         (WebCore::WebGLTexture::mapTargetToIndex):
2385         (WebCore::WebGLTexture::computeLevelCount):
2386         (WebCore::WebGLTexture::update):
2387         (WebCore::WebGLTexture::getLevelInfo):
2388         * html/canvas/WebGLTexture.h:
2389         (WebCore::WebGLTexture::LevelInfo::setInfo):
2390         * html/canvas/WebGLUniformLocation.cpp:
2391         (WebCore::WebGLUniformLocation::create):
2392         (WebCore::WebGLUniformLocation::WebGLUniformLocation):
2393         (WebCore::WebGLUniformLocation::location):
2394         * html/canvas/WebGLUniformLocation.h:
2395         * platform/graphics/GraphicsContext3D.h: Map GC3Dboolean to bool instead of unsigned char.
2396
2397 2011-01-13  Jian Li  <jianli@chromium.org>
2398
2399         Reviewed by Darin Fisher.
2400
2401         Change createObjectURL and revokeObjectURL to put under webkitURL.
2402         https://bugs.webkit.org/show_bug.cgi?id=52257
2403
2404         Note that we add "webkit" vendor prefix to URL that is introduced in
2405         the latest File API spec.
2406
2407         For the time being, we implement webkitURL as a readonly attribute
2408         instead of a constructor so that we will not expose prototype property,
2409         as required by the spec.
2410
2411         * Android.derived.jscbindings.mk:
2412         * Android.derived.v8bindings.mk:
2413         * Android.mk:
2414         * CMakeLists.txt:
2415         * DerivedSources.cpp:
2416         * DerivedSources.make:
2417         * GNUmakefile.am:
2418         * WebCore.gypi:
2419         * WebCore.pri:
2420         * WebCore.pro:
2421         * WebCore.vcproj/WebCore.vcproj:
2422         * WebCore.xcodeproj/project.pbxproj:
2423         * html/DOMURL.cpp: Added.
2424         * html/DOMURL.h: Added.
2425         * html/DOMURL.idl: Added.
2426         * inspector/front-end/NetworkPanel.js:
2427         * inspector/front-end/utilities.js:
2428         * page/DOMWindow.cpp:
2429         (WebCore::DOMWindow::webkitURL):
2430         * page/DOMWindow.h:
2431         * page/DOMWindow.idl:
2432         * workers/WorkerContext.cpp:
2433         (WebCore::WorkerContext::webkitURL):
2434         * workers/WorkerContext.h:
2435         * workers/WorkerContext.idl:
2436
2437 2011-01-13  Emil Eklund  <eae@chromium.org>
2438
2439         Reviewed by Dimitri Glazkov.
2440
2441         Setting outerText should convert CR/LF to <br>
2442         https://bugs.webkit.org/show_bug.cgi?id=52268
2443
2444         Make set outerText support line breaks (sharing the text to fragment code
2445         with setInnerText) and handle empty text nodes the same way IE does.
2446
2447         Test: fast/dom/set-outer-text.html
2448
2449         * html/HTMLElement.cpp:
2450         (WebCore::HTMLElement::textToFragment): Shared between setInnerText and setOuterText
2451         (WebCore::HTMLElement::setInnerText): Split out text parsing code.
2452         (WebCore::mergeWithNextTextNode): Split out text node merging code.
2453         (WebCore::HTMLElement::setOuterText): Added support for line breaks.
2454         * html/HTMLElement.h:
2455
2456 2011-01-13  Zhenyao Mo  <zmo@google.com>
2457
2458         Reviewed by Kenneth Russell.
2459
2460         Relax the ESSL valid charset a little bit to include " ' `
2461         https://bugs.webkit.org/show_bug.cgi?id=52396
2462
2463         * html/canvas/WebGLRenderingContext.cpp:
2464
2465 >>>>>>> .r75740
2466 2011-01-13  Adrienne Walker  <enne@google.com>
2467
2468         Reviewed by Kenneth Russell.
2469
2470         [chromium] Attempt to fix crash in tiled compositor memcpy
2471         https://bugs.webkit.org/show_bug.cgi?id=52379
2472
2473         * platform/graphics/chromium/LayerTilerChromium.cpp:
2474         (WebCore::LayerTilerChromium::update):
2475
2476 2011-01-13  Dimitri Glazkov  <dglazkov@chromium.org>
2477
2478         Unreviewed, rolling out r75725.
2479         http://trac.webkit.org/changeset/75725
2480         https://bugs.webkit.org/show_bug.cgi?id=52317
2481
2482         Caused crashes in layout tests.
2483
2484         * css/CSSStyleSelector.cpp:
2485         (WebCore::CSSStyleSelector::initForStyleResolve):
2486         * html/HTMLInputElement.cpp:
2487         (WebCore::HTMLInputElement::updateType):
2488         * html/InputType.cpp:
2489         * html/InputType.h:
2490         * html/RangeInputType.cpp:
2491         * html/RangeInputType.h:
2492         * html/shadow/SliderThumbElement.cpp:
2493         (WebCore::SliderThumbElement::defaultEventHandler):
2494         (WebCore::SliderThumbElement::detach):
2495         * html/shadow/SliderThumbElement.h:
2496         (WebCore::SliderThumbElement::SliderThumbElement):
2497         (WebCore::SliderThumbElement::create):
2498         * rendering/MediaControlElements.cpp:
2499         (WebCore::MediaControlInputElement::attach):
2500         (WebCore::MediaControlInputElement::updateStyle):
2501         * rendering/RenderSlider.cpp:
2502         (WebCore::RenderSlider::~RenderSlider):
2503         (WebCore::RenderSlider::styleDidChange):
2504         (WebCore::RenderSlider::createThumbStyle):
2505         (WebCore::RenderSlider::thumbRect):
2506         (WebCore::RenderSlider::layout):
2507         (WebCore::RenderSlider::updateFromElement):
2508         (WebCore::RenderSlider::mouseEventIsInThumb):
2509         (WebCore::RenderSlider::mouseEventOffsetToThumb):
2510         (WebCore::RenderSlider::setValueForPosition):
2511         (WebCore::RenderSlider::positionForOffset):
2512         (WebCore::RenderSlider::currentPosition):
2513         (WebCore::RenderSlider::trackSize):
2514         (WebCore::RenderSlider::forwardEvent):
2515         (WebCore::RenderSlider::inDragMode):
2516         * rendering/RenderSlider.h:
2517
2518 2011-01-12  Dimitri Glazkov  <dglazkov@chromium.org>
2519
2520         Reviewed by Darin Adler.
2521
2522         Flip input[type=range] to use the new shadow DOM model.
2523         https://bugs.webkit.org/show_bug.cgi?id=52317
2524
2525         This is a straight-up flip, minimal change to the logic, which will be
2526         refactored in a follow-up patch.
2527
2528         Covered by existing tests.
2529
2530         * css/CSSStyleSelector.cpp:
2531         (WebCore::CSSStyleSelector::initForStyleResolve): Changed to use either
2532             host or parent node to find parent.
2533         * html/HTMLInputElement.cpp:
2534         (WebCore::HTMLInputElement::updateType): Added logic for destroying/creating
2535             shadow DOM subtree.
2536         * html/InputType.cpp:
2537         (WebCore::InputType::createShadowSubtree): Added empty decl.
2538         (WebCore::InputType::destroyShadowSubtree): Added a method to destroy
2539             shadow subtree.
2540         * html/InputType.h: Added defs.
2541         * html/RangeInputType.cpp:
2542         (WebCore::RangeInputType::createShadowSubtree): Added a virtual method to create
2543             slider thumb.
2544         * html/RangeInputType.h: Adde def.
2545         * html/shadow/SliderThumbElement.cpp: Added temporary RenderSliderThumb class
2546             to handle cascading appearance.
2547         (WebCore::RenderSliderThumb::RenderSliderThumb): Added.
2548         (WebCore::RenderSliderThumb::layout): Moved here the logic from
2549             RenderSlider::createThumbStyle.
2550         (WebCore::SliderThumbElement::createRenderer): Added virtual method to
2551             create RenderSliderThumb instance.
2552         (WebCore::SliderThumbElement::defaultEventHandler): Changed to use HTMLDivElement
2553             as base class.
2554         (WebCore::SliderThumbElement::detach): Ditto.
2555         * html/shadow/SliderThumbElement.h:
2556         (WebCore::SliderThumbElement::SliderThumbElement): Ditto.
2557         (WebCore::SliderThumbElement::create): Ditto.
2558         (WebCore::toSliderThumbElement): Added a casting helper.
2559         * rendering/MediaControlElements.cpp:
2560         (WebCore::MediaControlInputElement::attach): Added handling of shadow DOM,
2561             since the whole method is hand-rolled.
2562         (WebCore::MediaControlInputElement::updateStyle): Ditto.
2563         * rendering/RenderSlider.cpp:
2564         (WebCore::RenderSlider::~RenderSlider): Removed unneeded code.
2565         (WebCore::RenderSlider::thumbRect): Changed to use sliderThumbElement helper.
2566         (WebCore::RenderSlider::layout): Ditto.
2567         (WebCore::RenderSlider::sliderThumbElement): Added a temporary helper to access
2568             SliderThumbElement.
2569         (WebCore::RenderSlider::mouseEventIsInThumb): Changed to use sliderThumbElement helper.
2570         (WebCore::RenderSlider::mouseEventOffsetToThumb): Ditto.
2571         (WebCore::RenderSlider::setValueForPosition): Ditto.
2572         (WebCore::RenderSlider::positionForOffset): Ditto.
2573         (WebCore::RenderSlider::currentPosition): Ditto.
2574         (WebCore::RenderSlider::trackSize): Ditto.
2575         (WebCore::RenderSlider::forwardEvent): Ditto.
2576         (WebCore::RenderSlider::inDragMode): Ditto.
2577         * rendering/RenderSlider.h: Added def.
2578
2579 2011-01-13  Dan Bernstein  <mitz@apple.com>
2580
2581         Reviewed by Simon Fraser.
2582
2583         <rdar://problem/8098442> Crash in Widget::setFrameRect()
2584         https://bugs.webkit.org/show_bug.cgi?id=52375
2585
2586         Test: plugins/destroy-on-setwindow.html
2587
2588         * platform/mac/WidgetMac.mm:
2589         (WebCore::Widget::setFrameRect): Protect the Widget from being deleted as a result of calling
2590         out to the view.
2591         (WebCore::Widget::getOuterView): Coding style fix.
2592         (WebCore::Widget::paint): Protect the Widget from being deleted as a result of calling out to
2593         the views. This is precautionary, since this function does not applear to access member variables
2594         after such calls.
2595         * platform/wx/WidgetWx.cpp:
2596         (WebCore::Widget::setFrameRect): Protect the Widget from being deleted as a result of calling
2597         out to the platform widget.
2598
2599 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2600
2601         Unreviewed buildfix after r75715.
2602
2603         * WebCore.pri:
2604         * WebCore.pro:
2605
2606 2011-01-13  Pavel Feldman  <pfeldman@chromium.org>
2607
2608         Not reviewed: Qt build fix.
2609
2610         * WebCore.pri:
2611
2612 2011-01-12  Pavel Feldman  <pfeldman@chromium.org>
2613
2614         Reviewed by Yury Semikhatsky.
2615
2616         Web Inspector: embed injected script into the backend.
2617         https://bugs.webkit.org/show_bug.cgi?id=52312
2618
2619         InjectedScript belongs to the backend of the system and
2620         should be exposed by means of protocol, not InjectedScriptAccess.
2621         This patch makes injected script a part of the backend.
2622         It introduces single manual generation step (xxd -i) that should be
2623         automated by the build scripts for all the platforms.
2624
2625         * CMakeLists.txt:
2626         * DerivedSources.make:
2627         * GNUmakefile.am:
2628         * WebCore.gyp/WebCore.gyp:
2629         * WebCore.gypi:
2630         * WebCore.pro:
2631         * WebCore.vcproj/WebCore.vcproj:
2632         * WebCore.xcodeproj/project.pbxproj:
2633         * bindings/js/JSInjectedScriptHostCustom.cpp:
2634         (WebCore::InjectedScriptHost::injectedScriptFor):
2635         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
2636         (WebCore::InjectedScriptHost::injectedScriptFor):
2637         * inspector/InjectedScriptHost.cpp:
2638         (WebCore::InjectedScriptHost::injectedScriptSource):
2639         * inspector/InjectedScriptHost.h:
2640         * inspector/Inspector.idl:
2641         * inspector/InspectorController.cpp:
2642         (WebCore::InspectorController::restoreInspectorStateFromCookie):
2643         * inspector/InspectorState.cpp:
2644         (WebCore::InspectorState::InspectorState):
2645         * inspector/InspectorState.h:
2646         * inspector/front-end/InjectedScript.js: Removed.
2647         * inspector/front-end/WebKit.qrc:
2648         * inspector/front-end/inspector.html:
2649         * inspector/front-end/inspector.js:
2650         (WebInspector.doLoadedDone.propertyNamesCallback):
2651         (WebInspector.doLoadedDone):
2652         * inspector/xxd.pl: Added.
2653
2654 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2655
2656         Reviewed by Timothy Hatcher.
2657
2658         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2659         to be passed directly to WebInspector.UIString
2660
2661         https://bugs.webkit.org/show_bug.cgi?id=52365
2662
2663         * English.lproj/localizedStrings.js:
2664         * inspector/front-end/ApplicationCacheItemsView.js:
2665         (WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
2666         (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
2667         * inspector/front-end/AuditRules.js:
2668         (WebInspector.AuditRules.GzipRule.prototype.doRun):
2669         (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
2670         (WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
2671         * inspector/front-end/BreakpointsSidebarPane.js:
2672         (WebInspector.EventListenerBreakpointsSidebarPane):
2673         (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
2674         * inspector/front-end/CookieItemsView.js:
2675         (WebInspector.CookieItemsView.prototype._updateWithCookies):
2676         * inspector/front-end/ImageView.js:
2677         (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
2678         (WebInspector.ImageView.prototype._createContentIfNeeded):
2679         * inspector/front-end/NetworkPanel.js:
2680         (WebInspector.NetworkTimeCalculator.prototype.formatValue):
2681         (WebInspector.NetworkTransferTimeCalculator.prototype.formatValue):
2682         (WebInspector.NetworkTransferDurationCalculator.prototype.formatValue):
2683         * inspector/front-end/ProfileDataGridTree.js:
2684         (WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):
2685         (WebInspector.ProfileDataGridNode.prototype.get data):
2686         * inspector/front-end/Resource.js:
2687         (WebInspector.Resource.Type.toUIString):
2688         (WebInspector.Resource.Type.toString):
2689         * inspector/front-end/TimelineOverviewPane.js:
2690         (WebInspector.TimelineOverviewCalculator.prototype.formatValue):
2691         * inspector/front-end/TimelinePanel.js:
2692         (WebInspector.TimelinePanel):
2693         (WebInspector.TimelineCalculator.prototype.formatValue):
2694         (WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo):
2695         (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
2696         (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
2697         * inspector/front-end/utilities.js:
2698         ():
2699
2700 2011-01-13  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2701
2702         Reviewed by Simon Hausmann.
2703
2704         [Qt] Need a way to inform the application when a Netscape plugin is created.
2705         https://bugs.webkit.org/show_bug.cgi?id=30179
2706
2707         Added "c" style static method for the application to hook up for
2708         receiving notifications when a plugin is created.
2709
2710         * plugins/symbian/PluginViewSymbian.cpp:
2711         (qtwebkit_setPluginCreatedCallback):
2712         (WebCore::PluginView::platformStart):
2713
2714 2011-01-13  Yi Shen  <yi.4.shen@nokia.com>
2715
2716         Reviewed by Eric Seidel.
2717
2718         [Qt] Use a black background color for the video element on Qt Mobile
2719         https://bugs.webkit.org/show_bug.cgi?id=52252
2720
2721         Use black as the background color for the video element on Qt Mobile.
2722
2723         * css/themeQtMobile.css:
2724         (video):
2725
2726 2011-01-13  Yi Shen  <yi.4.shen@nokia.com>
2727
2728         Reviewed by Eric Seidel.
2729
2730         [Qt] Use a big central media play control button for video element
2731         https://bugs.webkit.org/show_bug.cgi?id=52315
2732
2733         When ChromeClient::requiresFullscreenForVideoPlayback() returns true,
2734         all other control buttons for the video element are hidden, except
2735         a big centralized play button.
2736
2737         No new tests because no client implements requiresFullscreenForVideoPlayback yet.
2738
2739         * WebCore.pri:
2740         * css/mediaControlsQtFullscreen.css: Added.
2741         (audio):
2742         (audio::-webkit-media-controls-panel):
2743         (video::-webkit-media-controls-panel):
2744         (video:-webkit-full-page-media::-webkit-media-controls-panel):
2745         (audio::-webkit-media-controls-mute-button):
2746         (video::-webkit-media-controls-mute-button):
2747         (audio::-webkit-media-controls-play-button):
2748         (video::-webkit-media-controls-play-button):
2749         (audio::-webkit-media-controls-timeline-container):
2750         (video::-webkit-media-controls-timeline-container):
2751         (audio::-webkit-media-controls-current-time-display):
2752         (video::-webkit-media-controls-current-time-display):
2753         (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
2754         (audio::-webkit-media-controls-timeline):
2755         (video::-webkit-media-controls-timeline):
2756         (audio::-webkit-media-controls-volume-slider-container):
2757         (video::-webkit-media-controls-volume-slider-container):
2758         (audio::-webkit-media-controls-volume-slider):
2759         (video::-webkit-media-controls-volume-slider):
2760         (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
2761         (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
2762         (audio::-webkit-media-controls-fullscreen-button):
2763         (video::-webkit-media-controls-fullscreen-button):
2764         (audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button):
2765         (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button):
2766         (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
2767         * platform/qt/RenderThemeQt.cpp:
2768         (WebCore::RenderThemeQt::extraMediaControlsStyleSheet):
2769
2770 2011-01-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2771
2772         Reviewed by Xan Lopez.
2773
2774         [GTK] Paint toggle buttons inconsistent when the object state is indeterminate
2775         https://bugs.webkit.org/show_bug.cgi?id=52361
2776
2777         Check whether the object state is indeterminate to set the flag
2778         GTK_STATE_FLAG_INCONSISTENT before rendering check and radio
2779         buttons.
2780
2781         * platform/gtk/RenderThemeGtk3.cpp:
2782         (WebCore::paintToggle):
2783
2784 2011-01-13  Yi Shen  <yi.4.shen@nokia.com>
2785
2786         Reviewed by Simon Hausmann.
2787
2788         [Qt] Extend the Platform Plugin to support full screen video handler
2789         https://bugs.webkit.org/show_bug.cgi?id=51249
2790
2791         Make MediaPlayerPrivateQt support a fullscreen player.
2792
2793         No new tests because LayoutTests/media/media-fullscreen-inline.html already exists.
2794         However, this test failed for Qt (QtMediaPlayer) due to durationchange event getting fired twice.
2795         So, still skip it for Qt.
2796
2797         * WebCore.pro:
2798         * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
2799         (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
2800         (WebCore::MediaPlayerPrivateQt::removeVideoItem):
2801         (WebCore::MediaPlayerPrivateQt::restoreVideoItem):
2802         * platform/graphics/qt/MediaPlayerPrivateQt.h:
2803         (WebCore::MediaPlayerPrivateQt::supportsFullscreen):
2804         (WebCore::MediaPlayerPrivateQt::mediaPlayer):
2805
2806 2011-01-13  Dan Bernstein  <mitz@apple.com>
2807
2808         Reviewed by Dave Hyatt.
2809
2810         <rdar://problem/8858548> Disable inheritance of text emphasis marks to ruby text
2811         https://bugs.webkit.org/show_bug.cgi?id=52359
2812
2813         Test: fast/ruby/text-emphasis.html
2814
2815         * css/html.css:
2816         (rt):
2817
2818 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2819
2820         Rubber-stamped by David Levin.
2821
2822         Trivial fix after r75682.
2823
2824         * loader/FrameLoader.cpp: Remove accidentally committed debug code.
2825         (WebCore::FrameLoader::shouldClose):
2826
2827 2011-01-12  Ryosuke Niwa  <rniwa@webkit.org>
2828
2829         Reviewed by Eric Seidel.
2830
2831         REGRESSION(r69831): focus() in onkeypress discards input (affects chaseonline.chase.com)
2832         https://bugs.webkit.org/show_bug.cgi?id=52241
2833
2834         The bug was caused by RenderTextControl::selection's creating a Range with m_insertText
2835         which is a shadow DOM div as both start and end containers. Fixed the bug by traversing
2836         through the descendents of m_innerText and using the right start and end containers to
2837         create a Range.
2838
2839         Test: fast/forms/focus-change-on-keypress.html
2840
2841         * rendering/RenderTextControl.cpp:
2842         (WebCore::setContainerAndOffsetForRange): Added; a helper function.
2843         (WebCore::RenderTextControl::selection): See above.
2844
2845 2011-01-12  Kenichi Ishibashi  <bashi@google.com>
2846
2847         Reviewed by Kent Tamura.
2848
2849         M_formElementsWithFormAttribute not cleared when FormAssociatedElement is inserted with a null m_form and then removed.
2850         https://bugs.webkit.org/show_bug.cgi?id=51905
2851
2852         Calls unregisterFormElementWithFormAttribute() when 'form' attribute
2853         is removed.
2854
2855         Tests: fast/forms/form-associated-element-crash.html
2856                fast/forms/form-associated-element-crash2.html
2857
2858         * html/FormAssociatedElement.cpp:
2859         (WebCore::FormAssociatedElement::formAttributeChanged):
2860
2861 2011-01-12  Kenichi Ishibashi  <bashi@google.com>
2862
2863         Reviewed by Kent Tamura.
2864
2865         M_formElementsWithFormAttribute not cleared when Node is moved to another document.
2866         https://bugs.webkit.org/show_bug.cgi?id=51418
2867
2868         Calls unregisterFormElementWithFormAttribute() when form associated elements
2869         are moved to another document.
2870
2871         Test: fast/forms/change-form-element-document-crash.html
2872
2873         * html/FormAssociatedElement.cpp:
2874         (WebCore::FormAssociatedElement::willMoveToNewOwnerDocument): Added.
2875         * html/FormAssociatedElement.h: Added willMoveToNewOwnerDocument().
2876         * html/HTMLFormControlElement.cpp:
2877         (WebCore::HTMLFormControlElement::willMoveToNewOwnerDocument): Added.
2878         * html/HTMLFormControlElement.h: Added willMoveToNewOwnerDocument().
2879         * html/HTMLObjectElement.cpp:
2880         (WebCore::HTMLObjectElement::willMoveToNewOwnerDocument): Added.
2881         * html/HTMLObjectElement.h: Added willMoveToNewOwnerDocument().
2882         * html/HTMLPlugInImageElement.h: Moves willMoveToNewOwnerDocument() to protected.
2883
2884 2011-01-12  Ryosuke Niwa  <rniwa@webkit.org>
2885
2886         Reviewed by Eric Seidel.
2887
2888         Stop instantiating legacy editing positions in ApplyBlockElementCommand and ApplyStyleCommand
2889         https://bugs.webkit.org/show_bug.cgi?id=52250
2890
2891         Removed instantiation of legacy editing positions.
2892         Calls to Position::Position are replaced by calls to Position's convenience functions.
2893
2894         Also added firstPositionInOrBeforeNode and lastPositionInOrAfterNode,
2895         which are functions that return firstPositionInNode and lastPositionInNode respectively
2896         when the specified node can have children for editing purpose and return positionBeforeNode
2897         and positionAfterNode respectively otherwise. They can be used to guarantee that we never
2898         create a bogus position like [img, 0] or [br, 0].
2899
2900         No tests are added since this is a cleanup.
2901
2902         * editing/ApplyBlockElementCommand.cpp:
2903         (WebCore::ApplyBlockElementCommand::formatSelection):
2904         * editing/ApplyStyleCommand.cpp:
2905         (WebCore::ApplyStyleCommand::applyBlockStyle):
2906         (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle):
2907         (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle):
2908         (WebCore::ApplyStyleCommand::removeInlineStyle):
2909         (WebCore::ApplyStyleCommand::nodeFullySelected):
2910         (WebCore::ApplyStyleCommand::nodeFullyUnselected):
2911         (WebCore::ApplyStyleCommand::splitTextAtStart):
2912         (WebCore::ApplyStyleCommand::splitTextAtEnd):
2913         (WebCore::ApplyStyleCommand::splitTextElementAtStart):
2914         (WebCore::ApplyStyleCommand::splitTextElementAtEnd):
2915         (WebCore::ApplyStyleCommand::isValidCaretPositionInTextNode):
2916         (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
2917         (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
2918         (WebCore::ApplyStyleCommand::computedFontSize):
2919         (WebCore::ApplyStyleCommand::joinChildTextNodes):
2920         * editing/ApplyStyleCommand.h:
2921         * editing/htmlediting.h:
2922         (WebCore::firstPositionInOrBeforeNode): Added.
2923         (WebCore::lastPositionInOrAfterNode): Added.
2924
2925 2011-01-12  Sam Weinig  <sam@webkit.org>
2926
2927         Another build fix.
2928
2929         * platform/mac/WheelEventMac.mm:
2930         (WebCore::phaseForEvent):
2931
2932 2011-01-12  Sam Weinig  <sam@webkit.org>
2933
2934         Fix build.
2935
2936         * platform/mac/WheelEventMac.mm:
2937         (WebCore::phaseForEvent):
2938
2939 2011-01-12  Adam Barth  <abarth@webkit.org>
2940
2941         Reviewed by Darin Adler.
2942
2943         Remove premature optimization from SchemeRegistry
2944         https://bugs.webkit.org/show_bug.cgi?id=52283
2945
2946         As far as I can tell, this optimization isn't necessary.  I'm slightly
2947         unsure which benchmarks to run to demonstrate this numerically, but
2948         none of the benchmarks Chromium tracks were affected by adding a
2949         similar check for "display-isolated" schemes.
2950
2951         * platform/SchemeRegistry.cpp:
2952         (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
2953
2954 2011-01-12  Beth Dakin  <bdakin@apple.com>
2955
2956         Reviewed by Anders Carlsson.
2957
2958         Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309
2959         Expose fixed layout through WebKit SPI
2960         -and corresponding-
2961         <rdar://problem/8844464>
2962
2963         And now with getters!
2964         * WebCore.exp.in:
2965
2966 2011-01-12  Sam Weinig  <sam@webkit.org>
2967
2968         Reviewed by Anders Carlsson.
2969
2970         https://bugs.webkit.org/show_bug.cgi?id=52337
2971         PlatformWheelEvent should know about the scroll phase on the Mac
2972
2973         Add a phase parameter on Mac PlatformWheelEvents.
2974
2975         * platform/PlatformWheelEvent.h:
2976         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2977         (WebCore::PlatformWheelEvent::phase):
2978         * platform/mac/WheelEventMac.mm:
2979         (WebCore::phaseForEvent):
2980         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2981
2982 2011-01-12  Chris Marrin  <cmarrin@apple.com>
2983
2984         Unreviewed.
2985
2986         A couple of lines of the patch for https://bugs.webkit.org/show_bug.cgi?id=52321
2987         were omitted.
2988
2989         * platform/graphics/ca/GraphicsLayerCA.cpp:
2990         (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
2991
2992 2011-01-12  Chris Marrin  <cmarrin@apple.com>
2993
2994         Unreviewed.
2995
2996         Getting rid of an assert that was causing build failures that turns out not to be needed.
2997
2998         * rendering/RenderLayer.cpp:
2999         (WebCore::RenderLayer::paintsWithTransform):
3000
3001 2011-01-12  Chris Marrin  <cmarrin@apple.com>
3002
3003         Unreviewed.
3004
3005         Another fix for Gtk
3006
3007         * rendering/RenderLayer.cpp:
3008         (WebCore::RenderLayer::paintsWithTransform):
3009
3010 2011-01-12  Chris Marrin  <cmarrin@apple.com>
3011
3012         Unreviewed.
3013
3014         Fix for Gtk and Windows builds
3015
3016         * page/Frame.cpp:
3017         (WebCore::Frame::scalePage):
3018         * page/Frame.h:
3019         * platform/graphics/ca/win/PlatformCALayerWin.cpp:
3020         (PlatformCALayer::contentsScale):
3021         (PlatformCALayer::setContentsScale):
3022
3023 2011-01-12  Chris Marrin  <cmarrin@apple.com>
3024
3025         UNreviewed.
3026
3027         Fix for the Windows build
3028
3029         * platform/graphics/ca/win/PlatformCALayerWin.cpp:
3030         (contentsScale):
3031         (setContentsScale):
3032
3033 2011-01-12  Chris Marrin  <cmarrin@apple.com>
3034
3035         Unreviewed.
3036
3037         Another build fix
3038
3039         * platform/graphics/ca/GraphicsLayerCA.cpp:
3040         (WebCore::GraphicsLayerCA::clampedContentsScaleForScale):
3041         * platform/graphics/ca/mac/PlatformCALayerMac.mm:
3042         (PlatformCALayer::setContentsScale):
3043
3044 2011-01-11  Matthew Delaney  <mdelaney@apple.com>
3045
3046         Reviewed by Simon Fraser.
3047
3048         Max area bound needed in creation of IOSurface in ImageBufferCG.cpp
3049         https://bugs.webkit.org/show_bug.cgi?id=52172
3050
3051         Tests: fast/canvas/canvas-large-dimensions.html
3052
3053         * platform/graphics/cg/ImageBufferCG.cpp:
3054         (WebCore::ImageBuffer::ImageBuffer):
3055
3056 2011-01-12  Daniel Bates  <dbates@rim.com>
3057             And Benjamin C Meyer  <bmeyer@rim.com>
3058
3059         Build fix when building with Inspector disabled
3060         https://bugs.webkit.org/show_bug.cgi?id=52313
3061
3062         After changeset 75604 <http://trac.webkit.org/changeset/75604> it's not
3063         possible to build when the Inspector is disabled.
3064
3065         * inspector/InspectorInstrumentation.h:
3066         (WebCore::InspectorInstrumentation::updateApplicationCacheStatus): Fix build breakage when building
3067         with Inspector disabled and Offline Web Applications enabled by moving macro guard condition
3068         ENABLE(INSPECTOR) && ENABLE(OFFLINE_WEB_APPLICATIONS) into function body. This makes us also
3069         consistent with the form we use for InspectorInstrumentation::networkStateChanged() and other
3070         InspectorInstrumentation functions.
3071         * loader/appcache/ApplicationCacheGroup.cpp:
3072         (WebCore::ApplicationCacheGroup::didReceiveData): Fix build breakage when building with Inspector
3073         disabled by adding ENABLE(INSPECTOR) guard around code that references the instance variable
3074         ApplicationCacheGroup::m_currentResourceIdentifier as this variable only exists when building
3075         with the Inspector.
3076         (WebCore::ApplicationCacheGroup::didFinishLoading): Ditto.
3077         (WebCore::ApplicationCacheGroup::didFail): Ditto.
3078
3079 2011-01-12  Chris Marrin  <cmarrin@apple.com>
3080
3081         Unreviewed.
3082
3083         Fix a build issue from http://trac.webkit.org/changeset/75639.
3084
3085         * platform/graphics/GraphicsLayer.h:
3086         (WebCore::GraphicsLayer::contentsScale):
3087         (WebCore::GraphicsLayer::setContentsScale):
3088
3089 2011-01-12  Chris Marrin  <cmarrin@apple.com>
3090
3091         Reviewed by Kevin Decker.
3092
3093         Pages with accelerated layers lose subpixel-AA and become blurry when a scale factor is applied
3094         rdar://problem/8824974
3095
3096         This prevents the rootLayer (with the WebKit rendered content) from going becoming
3097         a tiled layer when zoomed, and when there is other layered content on the page.
3098         This speeds up zooming a lot and avoids some buggy behavior in CA with a very large
3099         number of layers.
3100
3101         * rendering/RenderLayer.cpp:
3102         (WebCore::RenderLayer::paintsWithTransform):
3103         * rendering/RenderLayer.h:
3104         * rendering/RenderLayerBacking.cpp:
3105         (WebCore::RenderLayerBacking::paintingGoesToWindow):
3106
3107 2011-01-12  Chris Marrin  <cmarrin@apple.com>
3108
3109         Reviewed by Simon Fraser.
3110
3111         Pages with accelerated layers lose subpixel-AA and become blurry when a scale factor is applied
3112         rdar://problem/8824974
3113
3114         When scaled, WebKit renders the page content at the scaled up size, so there are no
3115         scaling artifacts. But content drawn into a layer's backing store does not scale up.
3116         This is made worse by the fact that the root page contents become layered when there
3117         are other accelerated compositing layers present (video, plugins, etc.).
3118
3119         Plumb scaling factor from Frame::scalePage() down into all layers with content. It
3120         eventually calls CALayer::setContentsScale which renders to a backing store whose dimensions
3121         are scaled, causing them to render larger and appear pixel perfect at the scaled
3122         page size.
3123
3124          * page/Frame.cpp:
3125          (WebCore::Frame::updateContentsScale):
3126          (WebCore::Frame::scalePage):
3127          * page/Frame.h:
3128          * platform/graphics/GraphicsLayer.h:
3129          * platform/graphics/ca/GraphicsLayerCA.cpp:
3130          (WebCore::GraphicsLayerCA::setContentsScale):
3131          (WebCore::GraphicsLayerCA::clampedContentsScaleForScale):
3132          * platform/graphics/ca/GraphicsLayerCA.h:
3133          (WebCore::GraphicsLayerCA::contentsScale):
3134          * platform/graphics/ca/PlatformCALayer.h:
3135          * platform/graphics/ca/mac/PlatformCALayerMac.mm:
3136          (PlatformCALayer::contentsScale):
3137          (PlatformCALayer::setContentsScale):
3138          * rendering/RenderLayer.cpp:
3139          (WebCore::RenderLayer::updateContentsScale):
3140          * rendering/RenderLayer.h:
3141          * rendering/RenderLayerBacking.cpp:
3142          (WebCore::RenderLayerBacking::createGraphicsLayer):
3143          (WebCore::RenderLayerBacking::updateForegroundLayer):
3144          (WebCore::RenderLayerBacking::updateMaskLayer):
3145          (WebCore::RenderLayerBacking::updateContentsScale):
3146          * rendering/RenderLayerBacking.h:
3147          * rendering/RenderLayerCompositor.cpp:
3148          (WebCore::RenderLayerCompositor::updateContentsScale):
3149          * rendering/RenderLayerCompositor.h:
3150
3151 2011-01-12  Stephen White  <senorblanco@chromium.org>
3152
3153         Reviewed by James Robinson.
3154
3155         Fix DrawingBuffer issues for depth/stencil, extensions, etc.
3156         https://bugs.webkit.org/show_bug.cgi?id=52310
3157
3158         1)  GL_TEXTURE is not a valid argument to glFramebufferTexture2D()
3159         (should be GL_TEXTURE_2D).
3160         2)  Support for the multisampling extension was being checked after
3161         the DrawingBuffer constructor was called, which calls multisample()
3162         to check for the extension.
3163         3)  If depth or stencil is set, the corresponding framebuffers must
3164         be created in the DrawingBuffer constructor.
3165         4)  GL_DEPTH_STENCIL is not a valid framebuffer internal type in
3166         GLES2.  Must use GL_OES_DEPTH24_STENCIL8, and check for the
3167         OES_packed_depth_stencil extension.
3168
3169         * platform/graphics/chromium/DrawingBufferChromium.cpp:
3170         (WebCore::DrawingBuffer::DrawingBuffer):
3171         Record the extension support in the constructor.  Create all the
3172         secondary drawing buffers (for multisampling, depth/stencil).
3173         * platform/graphics/gpu/DrawingBuffer.cpp:
3174         (WebCore::DrawingBuffer::create):
3175         Check for the extensions before calling the DrawingBuffer constructor.
3176         (WebCore::DrawingBuffer::createSecondaryBuffers):
3177         Refactor creation of the secondary buffers from DrawingBufferMac.mm to
3178         here.
3179         (WebCore::DrawingBuffer::reset):
3180         Use DEPTH24_STENCIL8 format, not DEPTH_STENCIL.  Use
3181         DEPTH_COMPONENT16, not DEPTH_COMPONENT.
3182         Use GL_TEXTURE_2D, not GL_TEXTURE (for glFramebufferTexture2D).
3183         * platform/graphics/gpu/DrawingBuffer.h:
3184         Refactor createSecondaryBuffers().  Add extension support arguments to
3185         constructor.  Add support for packed_depth_stencil extension.
3186         * platform/graphics/gpu/mac/DrawingBufferMac.mm:
3187         (WebCore::DrawingBuffer::DrawingBuffer):
3188         Record extension support in constructor.  Refactor out creation of
3189         secondary buffers.
3190
3191 2011-01-12  Beth Dakin  <bdakin@apple.com>
3192
3193         Reviewed by Anders Carlsson.
3194
3195         Fix for https://bugs.webkit.org/show_bug.cgi?id=52309 Expose
3196         fixed layout through WebKit SPI
3197         -and corresponding-
3198         <rdar://problem/8844464>
3199
3200         Export symbols for ScrollView::setUseFixedLayout() and
3201         ScrollView::setFixedLayoutSize()
3202         * WebCore.exp.in:
3203
3204 2011-01-12  Robert Hogan  <robert@webkit.org>
3205
3206         Reviewed by Kenneth Rohde Christiansen.
3207
3208         [Qt] Search input field doesn't have cancel button
3209
3210         Add a cancel button to the search field and make it customizable
3211         by the client. For now, use the close dialog button associated
3212         with the application's style as the default.
3213
3214         Unskip a bunch of search field related tests that pass now:
3215
3216         fast/forms/search-cancel-button-mouseup.html
3217         fast/forms/search-rtl.html
3218         fast/forms/search-abs-pos-cancel-button.html
3219         fast/forms/search-styled.html
3220         fast/forms/search-transformed.html
3221         fast/forms/search-zoomed.html
3222         fast/forms/search-cancel-button-style-sharing.html
3223         fast/forms/search-display-none-cancel-button.html
3224         fast/forms/search-placeholder-value-changed.html
3225         fast/repaint/search-field-cancel.html
3226         fast/forms/search-cancel-button-events.html
3227
3228         https://bugs.webkit.org/show_bug.cgi?id=42887
3229
3230         * platform/graphics/qt/ImageQt.cpp:
3231         (loadResourcePixmap):
3232         * platform/qt/RenderThemeQt.cpp:
3233         (WebCore::RenderThemeQt::isControlStyled):
3234         (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
3235         (WebCore::RenderThemeQt::paintSearchField):
3236         (WebCore::RenderThemeQt::adjustSearchFieldStyle):
3237         (WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
3238         (WebCore::RenderThemeQt::convertToPaintingRect):
3239         (WebCore::RenderThemeQt::paintSearchFieldCancelButton):
3240         * platform/qt/RenderThemeQt.h:
3241
3242 2011-01-12  Andrey Kosyakov  <caseq@chromium.org>
3243
3244         Reviewed by Pavel Feldman.
3245
3246         Web Inspector: cookie table is multiplied after repeated switching to cookies tab in network item view
3247         Only create cookiesTable is it hasn't been done yet.
3248         https://bugs.webkit.org/show_bug.cgi?id=52303
3249
3250         * inspector/front-end/ResourceCookiesView.js:
3251         (WebInspector.ResourceCookiesView.prototype.show):
3252
3253 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
3254
3255         Reviewed by Martin Robinson.
3256
3257         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
3258         https://bugs.webkit.org/show_bug.cgi?id=50867
3259
3260         * config.h: Don't disallow ctype for (OS(DARWIN) && PLATFORM(GTK))
3261         Many GTK+ related files include <libintl.h> or <glib/gi18n-lib.h>.
3262         On Mac, <libintl.h> includes <xlocale.h>. <xclocale.h> includes
3263         <xlocale/_ctype.h>, which uses isacii().
3264         * platform/UUID.cpp:
3265         (WebCore::createCanonicalUUIDString): For OS(DARWIN) && !PLATFORM(CF)
3266         use the Chromium Linux UUID generation.
3267
3268 2011-01-12  Simon Fraser  <simon.fraser@apple.com>
3269
3270         Reviewed by Eric Seidel.
3271
3272         [CSS Gradients] One color stop should not paint anything for linear-gradient
3273         https://bugs.webkit.org/show_bug.cgi?id=52259
3274
3275         Share color stop parsing code between linear and radial gradients.
3276         Consider the gradient invalid if it has less than two color stops.
3277
3278         * css/CSSParser.cpp:
3279         (WebCore::CSSParser::parseLinearGradient):
3280         (WebCore::CSSParser::parseRadialGradient):
3281         (WebCore::CSSParser::parseGradientColorStops):
3282         * css/CSSParser.h:
3283
3284 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
3285
3286         Reviewed by Pavel Feldman.
3287
3288         Fix inconsistencies in Inspector strings found by the new check-inspector-strings script.
3289
3290         https://bugs.webkit.org/show_bug.cgi?id=52295
3291
3292         * English.lproj/localizedStrings.js:
3293         * inspector/front-end/BreakpointsSidebarPane.js:
3294         (WebInspector.EventListenerBreakpointsSidebarPane):
3295         * inspector/front-end/ProfilesPanel.js:
3296         (WebInspector.ProfilesPanel.prototype.setRecordingProfile):
3297         * inspector/front-end/Resource.js:
3298         (WebInspector.Resource.Type.toString):
3299         * inspector/front-end/ResourcesPanel.js:
3300         (WebInspector.ResourceRevisionTreeElement):
3301         * inspector/front-end/utilities.js:
3302         ():
3303
3304 2011-01-12  Yury Semikhatsky  <yurys@chromium.org>
3305
3306         Unreviewed. Fix WML compilation on Mac.
3307
3308         * wml/WMLInputElement.cpp:
3309         (WebCore::WMLInputElement::setValue):
3310         (WebCore::WMLInputElement::setValueForUser):
3311         (WebCore::WMLInputElement::initialize):
3312         (WebCore::WMLInputElement::validateInputMask):
3313         * wml/WMLSelectElement.cpp:
3314         (WebCore::WMLSelectElement::listBoxSelectItem):
3315
3316 2011-01-12  Justin Schuh  <jschuh@chromium.org>
3317
3318         Unreviewed build fix for debug strict compiles.
3319
3320         Use fprintf for debug statements instead of fwrite, which caused compile failures
3321         in debug strict mode because of failure to check the fwrite return value.
3322
3323         No behavior changed.
3324
3325         * rendering/CounterNode.cpp:
3326         (WebCore::showTreeAndMark):
3327
3328 2010-12-29  Yury Semikhatsky  <yurys@chromium.org>
3329
3330         Reviewed by Pavel Feldman.
3331
3332         inspector/timeline-network-resource.html fails when run twice
3333         https://bugs.webkit.org/show_bug.cgi?id=37394
3334
3335         Send didReceiveResponse notification to the timeline agent from ResourceLoadNotifier
3336         instead of ResourceLoader::didReceiveResponse to cover the cases when resources
3337         are loaded from memory cache.
3338
3339         Network notifications are now sent to InspectorInstrumentation which dispatches
3340         them to interested agents and InspectorController.
3341
3342         * inspector/Inspector.idl:
3343         * inspector/InspectorApplicationCacheAgent.cpp:
3344         (WebCore::InspectorApplicationCacheAgent::didReceiveManifestResponse):
3345         * inspector/InspectorController.cpp:
3346         (WebCore::InspectorController::InspectorController):
3347         (WebCore::InspectorController::didCommitLoad):
3348         (WebCore::InspectorController::willSendRequest):
3349         (WebCore::InspectorController::didReceiveResponse):
3350         (WebCore::InspectorController::didFailLoading):
3351         (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
3352         * inspector/InspectorController.h:
3353         * inspector/InspectorInstrumentation.cpp:
3354         (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
3355         (WebCore::InspectorInstrumentation::willSendRequestImpl):
3356         (WebCore::InspectorInstrumentation::markResourceAsCachedImpl):
3357         (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
3358         (WebCore::InspectorInstrumentation::willReceiveResourceResponseImpl):
3359         (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
3360         (WebCore::InspectorInstrumentation::didFinishLoadingImpl):
3361         (WebCore::InspectorInstrumentation::didFailLoadingImpl):
3362         (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
3363         (WebCore::InspectorInstrumentation::scriptImportedImpl):
3364         (WebCore::InspectorInstrumentation::retrieveResourceAgent):
3365         * inspector/InspectorInstrumentation.h:
3366         (WebCore::InspectorInstrumentation::identifierForInitialRequest):
3367         (WebCore::InspectorInstrumentation::willSendRequest):
3368         (WebCore::InspectorInstrumentation::markResourceAsCached):
3369         (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache):
3370         (WebCore::InspectorInstrumentation::willReceiveResourceResponse):
3371         (WebCore::InspectorInstrumentation::didReceiveContentLength):
3372         (WebCore::InspectorInstrumentation::didFinishLoading):
3373         (WebCore::InspectorInstrumentation::didFailLoading):
3374         (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequest):
3375         (WebCore::InspectorInstrumentation::scriptImported):
3376         * inspector/InspectorResourceAgent.cpp:
3377         (WebCore::InspectorResourceAgent::identifierForInitialRequest):
3378         * inspector/InspectorResourceAgent.h:
3379         * inspector/InspectorTimelineAgent.cpp:
3380         (WebCore::InspectorTimelineAgent::willSendResourceRequest):
3381         * inspector/InspectorTimelineAgent.h:
3382         * inspector/TimelineRecordFactory.cpp:
3383         (WebCore::TimelineRecordFactory::createResourceSendRequestData):
3384         * inspector/TimelineRecordFactory.h:
3385         * inspector/front-end/NetworkManager.js:
3386         (WebInspector.NetworkManager.prototype.identifierForInitialRequest):
3387         * inspector/front-end/TimelinePanel.js:
3388         (WebInspector.TimelinePanel.prototype.addRecordToTimeline):
3389         * loader/FrameLoader.cpp:
3390         (WebCore::FrameLoader::loadedResourceFromMemoryCache):
3391         * loader/ResourceLoadNotifier.cpp:
3392         (WebCore::ResourceLoadNotifier::didReceiveResponse):
3393         (WebCore::ResourceLoadNotifier::didFailToLoad):
3394         (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest):
3395         (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
3396         (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
3397         (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
3398         (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
3399         (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
3400         * loader/ResourceLoader.cpp:
3401         (WebCore::ResourceLoader::didReceiveResponse):
3402         * loader/appcache/ApplicationCacheGroup.cpp:
3403         (WebCore::ApplicationCacheGroup::createResourceHandle):
3404         (WebCore::ApplicationCacheGroup::didReceiveResponse):
3405         (WebCore::ApplicationCacheGroup::didReceiveData):
3406         (WebCore::ApplicationCacheGroup::didFinishLoading):
3407         (WebCore::ApplicationCacheGroup::didFail):
3408         * loader/appcache/ApplicationCacheGroup.h:
3409         * workers/DefaultSharedWorkerRepository.cpp:
3410         (WebCore::SharedWorkerScriptLoader::notifyFinished):
3411         * workers/Worker.cpp:
3412         (WebCore::Worker::notifyFinished):
3413         * workers/WorkerContext.cpp:
3414         (WebCore::WorkerContext::importScripts):
3415         * xml/XMLHttpRequest.cpp:
3416         (WebCore::XMLHttpRequest::didFinishLoading):
3417
3418 2011-01-12  Pavel Podivilov  <podivilov@chromium.org>
3419
3420         Reviewed by Pavel Feldman.
3421
3422         Web Inspector: do not replace all tabs with spaces when editing script source
3423         https://bugs.webkit.org/show_bug.cgi?id=52291
3424
3425         * inspector/front-end/SourceFrame.js:
3426         (WebInspector.SourceFrame.prototype.setContent):
3427         (WebInspector.SourceFrame.prototype._editLine):
3428
3429 2011-01-11  Jeremy Orlow  <jorlow@chromium.org>
3430
3431         Reviewed by Nate Chapin.
3432
3433         Enforce READ_ONLY transactions in IndexedDB
3434         https://bugs.webkit.org/show_bug.cgi?id=52229
3435
3436         Add READ_ONLY_ERR and return it whenever delete or put
3437         are called.  Note that IDBCursor's delete and update
3438         are simply aliases for delete/put, which is why no
3439         extra code is required to handle those cases.
3440
3441         Test: storage/indexeddb/transaction-read-only.html
3442
3443         * dom/ExceptionCode.cpp:
3444         * storage/IDBCursorBackendImpl.cpp:
3445         (WebCore::IDBCursorBackendImpl::deleteFunction):
3446         * storage/IDBDatabase.idl:
3447         * storage/IDBDatabaseException.h:
3448         * storage/IDBDatabaseException.idl:
3449         * storage/IDBObjectStoreBackendImpl.cpp:
3450         (WebCore::IDBObjectStoreBackendImpl::put):
3451         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
3452         (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
3453
3454 2011-01-11  Philippe Normand  <pnormand@igalia.com>
3455
3456         Reviewed by Eric Seidel.
3457
3458         [GTK] minimal build breaks in RenderThemeGtk3
3459         https://bugs.webkit.org/show_bug.cgi?id=52202
3460
3461         * platform/gtk/RenderThemeGtk3.cpp: Added VIDEO guards around
3462         initMediaColors().
3463
3464 2011-01-11  Philippe Normand  <pnormand@igalia.com>
3465
3466         Reviewed by Eric Carlson.