90f8e6b702f0e874bf1135fc7c20058d430b9725
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
2
3         Reviewed by Dimitri Glazkov.
4
5         Teach Gtk build about window.internals
6         https://bugs.webkit.org/show_bug.cgi?id=61071
7
8         * GNUmakefile.am: Add new internals directories to the VPATH
9         (for idl processing) and the include list.
10
11 2011-06-03  Levi Weintraub  <leviw@chromium.org>
12
13         Reviewed by Eric Seidel.
14
15         Switch paintBackgroundsBehindCell to use IntPoint
16         https://bugs.webkit.org/show_bug.cgi?id=62031
17
18         Switching paintBackgroundsBehindCell to take an IntPoint representing
19         the paint offset instead of a pair of ints.
20
21         No new tests as this is simple refactoring.
22
23         * rendering/RenderTableCell.cpp:
24         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
25         (WebCore::RenderTableCell::paintBoxDecorations):
26         * rendering/RenderTableCell.h:
27         * rendering/RenderTableRow.cpp:
28         (WebCore::RenderTableRow::paint):
29         * rendering/RenderTableSection.cpp:
30         (WebCore::RenderTableSection::paintCell):
31
32 2011-06-03  Levi Weintraub  <leviw@chromium.org>
33
34         Reviewed by Eric Seidel.
35
36         Switch paintCaret and paintDragCaret to use IntPoint
37         https://bugs.webkit.org/show_bug.cgi?id=62037
38
39         Switching paintCaret and paintDragCaret to use an IntPoint representing
40         the paint offset instead of a pair of ints.
41
42         No new tests since this is simple refactoring.
43
44         * editing/FrameSelection.cpp:
45         (WebCore::FrameSelection::paintCaret):
46         (WebCore::CaretBase::paintCaret):
47         (WebCore::DragCaretController::paintDragCaret):
48         * editing/FrameSelection.h:
49         * rendering/RenderBlock.cpp:
50         (WebCore::RenderBlock::paintCaret):
51         (WebCore::RenderBlock::paintObject):
52         (WebCore::RenderBlock::positionForPoint):
53         (WebCore::RenderBlock::offsetForContents):
54         * rendering/RenderBlock.h:
55
56 2011-06-03  Levi Weintraub  <leviw@chromium.org>
57
58         Reviewed by Eric Seidel.
59
60         Switch paintItemForeground and paintItemForeground to use IntPoint
61         https://bugs.webkit.org/show_bug.cgi?id=62035
62
63         Switching paintItemFore/Background to use IntPoint instead of a pair of ints.
64
65         No new tests since this is simple refactoring.
66
67         * rendering/RenderListBox.cpp:
68         (WebCore::RenderListBox::paintObject):
69         (WebCore::RenderListBox::paintItemForeground):
70         (WebCore::RenderListBox::paintItemBackground):
71         * rendering/RenderListBox.h:
72
73 2011-06-03  Alexis Menard  <alexis.menard@openbossa.org>
74
75         Reviewed by Andreas Kling.
76
77         To support building namespaced Qt, we require that forward-declarations
78         of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.
79
80         * platform/network/qt/QtMIMETypeSniffer.h:
81
82 2011-06-03  Rob Buis  <rbuis@rim.com>
83
84         Reviewed by Nikolas Zimmermann.
85
86         Cleanup member variable usage in svg/animation classes
87         https://bugs.webkit.org/show_bug.cgi?id=62029
88
89         Cleanup member variables.
90
91         * svg/animation/SMILTimeContainer.cpp:
92         (WebCore::SMILTimeContainer::SMILTimeContainer):
93         (WebCore::SMILTimeContainer::sampleAnimationAtTime):
94         (WebCore::SMILTimeContainer::updateAnimations):
95         * svg/animation/SMILTimeContainer.h:
96         * svg/animation/SVGSMILElement.cpp:
97         (WebCore::SVGSMILElement::SVGSMILElement):
98         * svg/animation/SVGSMILElement.h:
99
100 2011-06-03  Chris Rogers  <crogers@google.com>
101
102         Reviewed by Kenneth Russell.
103
104         Add AudioParam parameter scheduling implementation
105         https://bugs.webkit.org/show_bug.cgi?id=61830
106
107         No new tests since audio API is not yet implemented.
108
109         * WebCore.gypi:
110         * WebCore.xcodeproj/project.pbxproj:
111         * webaudio/AudioParam.cpp:
112         (WebCore::AudioParam::value):
113         (WebCore::AudioParam::smoothedValue):
114         (WebCore::AudioParam::smooth):
115         (WebCore::AudioParam::calculateSampleAccurateValues):
116         * webaudio/AudioParam.h:
117         (WebCore::AudioParam::setContext):
118         (WebCore::AudioParam::context):
119         (WebCore::AudioParam::setValueAtTime):
120         (WebCore::AudioParam::linearRampToValueAtTime):
121         (WebCore::AudioParam::exponentialRampToValueAtTime):
122         (WebCore::AudioParam::setTargetValueAtTime):
123         (WebCore::AudioParam::setValueCurveAtTime):
124         (WebCore::AudioParam::cancelScheduledValues):
125         (WebCore::AudioParam::hasTimelineValues):
126         * webaudio/AudioParam.idl:
127         * webaudio/AudioParamTimeline.cpp: Added.
128         (WebCore::AudioParamTimeline::setValueAtTime):
129         (WebCore::AudioParamTimeline::linearRampToValueAtTime):
130         (WebCore::AudioParamTimeline::exponentialRampToValueAtTime):
131         (WebCore::AudioParamTimeline::setTargetValueAtTime):
132         (WebCore::AudioParamTimeline::setValueCurveAtTime):
133         (WebCore::isValidNumber):
134         (WebCore::AudioParamTimeline::insertEvent):
135         (WebCore::AudioParamTimeline::cancelScheduledValues):
136         (WebCore::AudioParamTimeline::valueForContextTime):
137         (WebCore::AudioParamTimeline::valuesForTimeRange):
138         (WebCore::timeToSampleFrame):
139         (WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
140         * webaudio/AudioParamTimeline.h: Added.
141         (WebCore::AudioParamTimeline::AudioParamTimeline):
142         (WebCore::AudioParamTimeline::hasValues):
143         (WebCore::AudioParamTimeline::ParamEvent::ParamEvent):
144         (WebCore::AudioParamTimeline::ParamEvent::type):
145         (WebCore::AudioParamTimeline::ParamEvent::value):
146         (WebCore::AudioParamTimeline::ParamEvent::time):
147         (WebCore::AudioParamTimeline::ParamEvent::timeConstant):
148         (WebCore::AudioParamTimeline::ParamEvent::duration):
149         (WebCore::AudioParamTimeline::ParamEvent::curve):
150
151 2011-06-01  Jer Noble  <jer.noble@apple.com>
152
153         Reviewed by Simon Fraser.
154
155         Flash of broken page when exiting full screen at jerryseinfeld.com
156         https://bugs.webkit.org/show_bug.cgi?id=61897
157         <rdar://problem/9522985>
158
159         Test: fullscreen/full-screen-placeholder.html
160
161         Entering full-screen mode is causing the page layout to change because the full-screen
162         element is taken out of the normal flow.  To counteract this effect, insert a placeholder
163         block as a parent of the full-screen renderer with the same size and style as the full-screen
164         element pre-full-screen.
165
166         Only create a placeholder for block-level elements; the technique required for inline elements
167         would be vastly more complicated.
168
169         * dom/Document.cpp:
170         (WebCore::Document::webkitWillEnterFullScreenForElement): Create a placeholder
171             based on the size and style of the full-screen element.
172         (WebCore::Document::setFullScreenRenderer): Persist the placeholder size and 
173             style across new renderers.
174         * rendering/RenderFullScreen.cpp:
175         (RenderFullScreen::RenderFullScreen): Added ivar.
176         (RenderFullScreen::destroy): Make sure to safely destroy our placeholder.
177         (RenderFullScreen::createPlaceholder): Added.
178         * rendering/RenderFullScreen.h:
179         (WebCore::RenderFullScreen::placeholder): Ivar accessor.
180
181 2011-06-03  Levi Weintraub  <leviw@chromium.org>
182
183         Reviewed by Eric Seidel.
184
185         Switch paintBoxDecorations to IntPoint
186         https://bugs.webkit.org/show_bug.cgi?id=61968
187
188         Switching paintBoxDecorations to take an IntPoint representing
189         the paint offset instead of a pair of ints. Also cleaning up
190         some duplicated code in InlineFlowBox related to constraining
191         the paint rect to the linetop and linebottom.
192
193         No new tests since this is just refactoring.
194
195         * rendering/InlineFlowBox.cpp:
196         (WebCore::InlineFlowBox::paint):
197         (WebCore::InlineFlowBox::constrainToLineTopAndBottomIfNeeded): Added
198         to remove duplicate code in paintBoxDecorations and paintMask.
199         (WebCore::InlineFlowBox::paintBoxDecorations):
200         (WebCore::InlineFlowBox::paintMask):
201         * rendering/InlineFlowBox.h:
202         * rendering/RenderBlock.cpp:
203         (WebCore::RenderBlock::paintObject):
204         * rendering/RenderBox.cpp:
205         (WebCore::RenderBox::paintBoxDecorations):
206         * rendering/RenderBox.h:
207         * rendering/RenderFieldset.cpp:
208         (WebCore::RenderFieldset::paintBoxDecorations):
209         * rendering/RenderFieldset.h:
210         * rendering/RenderReplaced.cpp:
211         (WebCore::RenderReplaced::paint):
212         * rendering/RenderTable.cpp:
213         (WebCore::RenderTable::paintObject):
214         (WebCore::RenderTable::paintBoxDecorations):
215         * rendering/RenderTable.h:
216         * rendering/RenderTableCell.cpp:
217         (WebCore::RenderTableCell::paintBoxDecorations):
218         * rendering/RenderTableCell.h:
219         * rendering/RenderView.cpp:
220         (WebCore::RenderView::paintBoxDecorations):
221         * rendering/RenderView.h:
222         * rendering/RenderWidget.cpp:
223         (WebCore::RenderWidget::paint):
224         * rendering/svg/RenderSVGRoot.cpp:
225         (WebCore::RenderSVGRoot::paint):
226
227 2011-06-03  Doreen Jiang  <doreen.jiang@nokia.com>
228
229         Reviewed by Benjamin Poulain.
230
231         [Qt]The minimum size of the select menu list is incorrect for qtwebkit
232         https://bugs.webkit.org/show_bug.cgi?id=56752
233
234         The minimum width of the select-box is calculated to be as small as possible 
235         instead of hardcoded value (width of 7 characters) in minimumMenuListSize() function
236         This will avoid overapping the select lists in popular websites.
237
238         Test: fast/forms/selectlist-minsize.html
239
240         * platform/qt/RenderThemeQt.cpp:
241         (WebCore::RenderThemeQt::minimumMenuListSize):
242
243 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
244
245         Reviewed by Darin Adler.
246
247         Prevent event dispatch for events with related target when host is the target.
248         https://bugs.webkit.org/show_bug.cgi?id=61979
249
250         Turns out, even if we trim the ancestor chain to 0, the event is still dispatched during AT_TARGET.
251         So might as well be explicit about what we are trying to do and add a flag to prevent dispatch in these cases.
252
253         * dom/EventDispatcher.cpp:
254         (WebCore::EventDispatcher::adjustToShadowBoundaries): Added preventing dispatch when the ancestor chain is trimmed to nothing.
255         (WebCore::EventDispatcher::EventDispatcher): Added initializer.
256         (WebCore::EventDispatcher::dispatchEvent): Added a check to prevent dispatch.
257         * dom/EventDispatcher.h: Added a def.
258
259 2011-06-03  Dan Bernstein  <mitz@apple.com>
260
261         Mac build fix.
262
263         * WebCore.xcodeproj/project.pbxproj:
264
265 2011-06-03  Naoki Takano  <takano.naoki@gmail.com>
266
267         Reviewed by Eric Seidel.
268
269         [Chromium] Call setToolTipText() in WebPopupMenuImpl mouse move handler to show tool tip in select popup window.
270         https://bugs.webkit.org/show_bug.cgi?id=61260
271         http://code.google.com/p/chromium/issues/detail?id=12721
272
273         Manual test: select-popup-tooltip-test.html
274
275         * manual-tests/select-popup-tooltip-test.html: Added.
276         * platform/chromium/PopupMenuChromium.cpp:
277         (WebCore::PopupContainer::getSelectedItemToolTip): Get selected item tooltip string according to hovering mouse position.
278         * platform/chromium/PopupMenuChromium.h: Add getSelectedItemToolTip() declaration.
279
280 2011-06-03  Rob Buis  <rbuis@rim.com>
281
282         Reviewed by Nikolas Zimmermann.
283
284         Creating <animateMotion> elements via javascript do not execute
285         https://bugs.webkit.org/show_bug.cgi?id=34301
286
287         Enable constructors for SVGMPathElement and SVGAnimateMotionElement.
288
289         * DerivedSources.cpp:
290         * DerivedSources.make:
291         * GNUmakefile.list.am:
292         * WebCore.gypi:
293         * WebCore.vcproj/WebCore.vcproj:
294         * WebCore.xcodeproj/project.pbxproj:
295         * page/DOMWindow.idl:
296
297 2011-06-03  Hans Wennborg  <hans@chromium.org>
298
299         Reviewed by Steve Block.
300
301         IndexedDB: Clean-up use of INT64_MAX in LevelDB back-end
302         https://bugs.webkit.org/show_bug.cgi?id=62009
303
304         This constant should only be needed inside IDBLevelDBCoding.cpp.
305
306         No new functionality, no new tests.
307
308         * storage/IDBLevelDBBackingStore.cpp:
309         (WebCore::getNewDatabaseId):
310         (WebCore::IDBLevelDBBackingStore::getObjectStores):
311         (WebCore::getNewObjectStoreId):
312         (WebCore::IDBLevelDBBackingStore::deleteObjectStore):
313         (WebCore::getNewIndexId):
314         * storage/IDBLevelDBCoding.cpp:
315         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encodeMaxKey):
316         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encodeMaxKey):
317         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encodeMaxKey):
318         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encodeMaxKey):
319         (WebCore::IDBLevelDBCoding::IndexFreeListKey::encodeMaxKey):
320         * storage/IDBLevelDBCoding.h:
321
322 2011-06-03  Siddharth Mathur  <siddharth.mathur@nokia.com>
323
324         Reviewed by Benjamin Poulain.
325
326         [Qt] Build flag for experimental ICU library support
327         https://bugs.webkit.org/show_bug.cgi?id=60786
328
329         Adds a build-time flag (CONFIG+=use_system_icu) that enables experimental 
330         ICU powered Unicode support. 
331
332         No new tests as no new features added.
333
334         * WebCore.pri: Removed text_breaking_with_icu CONFIG flag. 
335         * WebCore.pro: Added TextCodecICU.cpp and qt/TextBreakIteratorInternalICUQt.cpp.
336         * editing/qt/SmartReplaceQt.cpp:
337         * features.pri: Support for use_system_icu CONFIG flag.
338         * platform/text/TextCodecICU.cpp: Guard with USE(ICU_UNICODE). 
339         * platform/text/qt/TextBreakIteratorInternalICUQt.cpp: Added.
340         (WebCore::Q_GLOBAL_STATIC_WITH_INITIALIZER):
341         (WebCore::currentSearchLocaleID):
342         (WebCore::currentTextBreakLocaleID):
343         * platform/text/qt/TextBreakIteratorQt.cpp: Moved out currentTextBreakLocaleID(). 
344         (WebCore::isTextBreak):
345         * platform/text/qt/TextCodecQt.cpp: Guard with USE(QT4_UNICODE). 
346         (WebCore::TextCodecQt::registerEncodingNames):
347         (WebCore::TextCodecQt::registerCodecs):
348
349 2011-06-03  Yael Aharon  <yael.aharon@nokia.com>
350
351         Reviewed by Kenneth Rohde Christiansen.
352
353         Frame flattening is broken with nested frames
354         https://bugs.webkit.org/show_bug.cgi?id=61491
355
356         Do not flatten offscreen iframes during frame flattening, as flattening might make them visible.
357
358         Test: fast/frames/flattening/iframe-flattening-out-of-view.html
359               fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html
360               fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html
361
362         * rendering/RenderIFrame.cpp:
363         (WebCore::RenderIFrame::flattenFrame):
364
365 2011-06-03  Nikolas Zimmermann  <nzimmermann@rim.com>
366
367         Reviewed by Andreas Kling.
368
369         Incorrect embedded document replaced size calculation for box-sizing: border-box
370         https://bugs.webkit.org/show_bug.cgi?id=62007
371
372         When using <object style="box-sizing: border-box" data="foo.svg"/> to embed foo.svg
373         which has an intrinsic width/height, the embedded document intrinsic size is incorrect.
374
375         RenderPart::computeEmbeddedDocumentReplacedWidth/Height has to ask the content renderer for the replaced width/height not ourselves.
376
377         Tests: svg/as-image/img-preserveAspectRatio-support-2.html
378                svg/as-object/object-box-sizing-no-width-height.html
379
380         * rendering/RenderPart.cpp:
381         (WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth):
382         (WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight):
383
384 2011-06-03  Sheriff Bot  <webkit.review.bot@gmail.com>
385
386         Unreviewed, rolling out r88004.
387         http://trac.webkit.org/changeset/88004
388         https://bugs.webkit.org/show_bug.cgi?id=62008
389
390         This patch broke 4 tests in the GTK bots (Requested by
391         msanchez on #webkit).
392
393         * accessibility/gtk/AXObjectCacheAtk.cpp:
394         (WebCore::AXObjectCache::handleScrolledToAnchor):
395
396 2011-06-03  Nikolas Zimmermann  <nzimmermann@rim.com>
397
398         Reviewed by Andreas Kling.
399
400         Zooming <object style="width/height: auto" data="foo.svg"/> doesn't work as expected
401         https://bugs.webkit.org/show_bug.cgi?id=62005
402
403         Zooming an object with auto size, that references a svg with fixed size was broken. The svg size stayed the same.
404         Get rid of the dependency between RenderSVGRoot and SVGSVGElement::currentScale(), always ask for the effective
405         zoom in the RenderStyle instead of asking SVGSVGElement.
406
407         The SVGSVGElement::currentScale()/setCurrentScale() methods are now only used when called from the bindings (eg. JS).
408         They only take effect on the outermost <svg> element in standalone documents, otherwhise they are no-ops.
409
410         Test: svg/zoom/page/zoom-svg-through-object-with-auto-size.html
411
412         * rendering/svg/RenderSVGRoot.cpp:
413         (WebCore::RenderSVGRoot::computeIntrinsicWidth):
414         (WebCore::RenderSVGRoot::computeIntrinsicHeight):
415         (WebCore::RenderSVGRoot::localToBorderBoxTransform):
416         * svg/SVGSVGElement.cpp:
417         (WebCore::SVGSVGElement::SVGSVGElement):
418         (WebCore::SVGSVGElement::currentScale):
419         (WebCore::SVGSVGElement::setCurrentScale):
420         * svg/SVGSVGElement.h:
421
422 2011-06-03  Mario Sanchez Prada  <msanchez@igalia.com>
423
424         Reviewed by Martin Robinson.
425
426         Focus and caret position should be updated when same-page links are followed
427         https://bugs.webkit.org/show_bug.cgi?id=59737
428
429         Update the caret position to the anchor's position after scrolling.
430
431         This behavior is specific to the Gtk port and requested because of
432         accessibility needs, that's why it's implemented in AXObjectCache.
433
434         Test: platform/gtk/accessibility/caret-browsing-anchor-followed.html
435
436         * accessibility/gtk/AXObjectCacheAtk.cpp:
437         (WebCore::AXObjectCache::handleScrolledToAnchor): Make sure the
438         caret is updated to be in the anchor's position after scrolling.
439
440 2011-06-03  Dominic Cooney  <dominicc@chromium.org>
441
442         Reviewed by Kent Tamura.
443
444         Cloned keygen shadows should have -webkit-keygen-select pseudoclass.
445         https://bugs.webkit.org/show_bug.cgi?id=61984
446
447         When cloneNode's tag name-based cloning algorithm clones the
448         KeygenSelectElements of a keygen shadow as select elements. These
449         lack the -webkit-keygen-select pseudoclass.
450
451         Test: fast/html/clone-keygen.html
452
453         * html/HTMLKeygenElement.cpp:
454         (WebCore::KeygenSelectElement::cloneElementWithoutAttributesAndChildren): Create a KeygenSelectElement when being cloned.
455
456 2011-06-02  MORITA Hajime  <morrita@google.com>
457         
458         Unreviewed ChangeLog fix.
459         
460 2011-06-03  Peter Varga  <pvarga@webkit.org>
461
462         Rubber-stamped by Csaba Osztrogonác.
463         
464         [Qt][V8] Buildfix after r87988.
465
466         No new tests needed.
467
468         * bindings/v8/ScheduledAction.cpp: Add missing guards.
469         (WebCore::ScheduledAction::execute):
470         * bindings/v8/V8EventListener.cpp: Ditto.
471         (WebCore::V8EventListener::callListenerFunction):
472
473 2011-06-03  Dominic Cooney  <dominicc@chromium.org>
474
475         Reviewed by Kent Tamura.
476
477         Cloned range input sliders should be SliderThumbElements, not divs.
478         https://bugs.webkit.org/show_bug.cgi?id=61982
479
480         Test: fast/html/clone-range.html
481
482         * html/shadow/SliderThumbElement.h:
483         (WebCore::SliderThumbElement::cloneElementWithoutAttributesAndChildren): Create a SliderThumbElement when being cloned.
484
485 2011-06-02  Yury Semikhatsky  <yurys@chromium.org>
486
487         Reviewed by Pavel Feldman.
488
489         Web Inspector: add an option for automatically attaching to new workers
490         https://bugs.webkit.org/show_bug.cgi?id=61930
491
492         Worker list is extended with a checkbox that makes inspector attach to each
493         new worker. Whenever a new worker context starts a new inspector window will
494         be opened for it.
495
496         Also worker agent and worker list will be updated when worker context is terminated.
497
498         * inspector/Inspector.json:
499         * inspector/InspectorController.cpp:
500         (WebCore::InspectorController::InspectorController):
501         * inspector/InspectorInstrumentation.cpp:
502         (WebCore::InspectorInstrumentation::workerContextTerminatedImpl):
503         * inspector/InspectorInstrumentation.h:
504         (WebCore::InspectorInstrumentation::workerContextTerminated):
505         * inspector/InspectorWorkerAgent.cpp:
506         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
507         (WebCore::InspectorWorkerAgent::create):
508         (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
509         (WebCore::InspectorWorkerAgent::clearFrontend):
510         (WebCore::InspectorWorkerAgent::setAutoconnectToWorkers):
511         (WebCore::InspectorWorkerAgent::didStartWorkerContext):
512         (WebCore::InspectorWorkerAgent::workerContextTerminated):
513         * inspector/InspectorWorkerAgent.h:
514         * inspector/front-end/WorkerManager.js:
515         (WebInspector.WorkerManager.prototype._workerCreated):
516         (WebInspector.WorkerManager.prototype._workerTerminated):
517         (WebInspector.WorkerManager.prototype.openWorkerInspector):
518         (WebInspector.WorkerManager.prototype._openInspectorWindow):
519         (WebInspector.WorkerManager.prototype.reset):
520         (WebInspector.WorkerMessageForwarder.prototype.workerCreated):
521         (WebInspector.WorkerMessageForwarder.prototype.workerTerminated):
522         * inspector/front-end/WorkersSidebarPane.js:
523         (WebInspector.WorkerListSidebarPane):
524         (WebInspector.WorkerListSidebarPane.prototype._workerAdded):
525         (WebInspector.WorkerListSidebarPane.prototype._workerRemoved):
526         (WebInspector.WorkerListSidebarPane.prototype._workersCleared):
527         (WebInspector.WorkerListSidebarPane.prototype._addWorker):
528         (WebInspector.WorkerListSidebarPane.prototype._workerItemClicked):
529         (WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked):
530         * inspector/front-end/inspector.js:
531         (WebInspector.reset):
532
533 2011-06-02  Hayato Ito  <hayato@chromium.org>
534
535         Reviewed by Ryosuke Niwa.
536
537         Show a shadow root node itself in Node::traverseNextNodeAcrossFrame.
538         https://bugs.webkit.org/show_bug.cgi?id=61992
539
540         It's better to show a shadow root node itself for debugging.
541         Skipping it didn't add any values.
542
543         No new tests since the function is only available in debug builds.
544
545         * dom/Node.cpp:
546         (WebCore::traverseNextNodeAcrossFrame):
547
548 2011-06-02  James Robinson  <jamesr@chromium.org>
549
550         Unreviewed, rolling out r87901.
551         http://trac.webkit.org/changeset/87901
552         https://bugs.webkit.org/show_bug.cgi?id=61894
553
554         Might be responsible for performance regression on Chromium page cyclers, reverting to see...
555
556         * loader/DocumentLoader.h:
557         (WebCore::DocumentLoader::didTellClientAboutLoad):
558         (WebCore::DocumentLoader::haveToldClientAboutLoad):
559         * loader/FrameLoader.cpp:
560         (WebCore::FrameLoader::loadedResourceFromMemoryCache):
561         * loader/ResourceLoadNotifier.cpp:
562         (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
563
564 2011-06-02  Levi Weintraub  <leviw@chromium.org>
565
566         Reviewed by Eric Seidel.
567
568         Switch paintReplaced to use IntPoint
569         https://bugs.webkit.org/show_bug.cgi?id=61891
570
571         Switching paintReplaced to use IntPoint to represent the paint offset instead
572         of a pair of ints.
573
574         Also renaming the IntPoint flavor of IntRect::move to moveBy to clear up the
575         fact that the IntPoint is added as an offset as opposed to being relocated
576         to that point.
577
578         No tests because this is just a refactoring.
579
580         * page/FrameView.cpp:
581         (WebCore::FrameView::invalidateScrollbarRect):
582         (WebCore::FrameView::convertFromRenderer):
583         (WebCore::FrameView::convertToRenderer):
584         * platform/ScrollView.cpp:
585         (WebCore::ScrollView::wheelEvent):
586         * platform/ScrollbarThemeComposite.cpp:
587         (WebCore::ScrollbarThemeComposite::invalidatePart):
588         * platform/graphics/gpu/Texture.cpp
589         (WebCore::Texture::updateSubRect)
590         * platform/graphics/IntRect.h:
591         (WebCore::IntRect::moveBy):
592         * platform/mac/WidgetMac.mm:
593         (WebCore::Widget::paint):
594         * rendering/InlineFlowBox.cpp:
595         (WebCore::InlineFlowBox::paint):
596         * rendering/RenderBlock.cpp:
597         (WebCore::RenderBlock::logicalRectToPhysicalRect):
598         (WebCore::RenderBlock::selectionGaps):
599         * rendering/RenderBox.cpp:
600         (WebCore::RenderBox::offsetFromContainer):
601         (WebCore::RenderBox::computeRectForRepaint):
602         (WebCore::RenderBox::localCaretRect):
603         * rendering/RenderDetailsMarker.cpp:
604         (WebCore::RenderDetailsMarker::paint):
605         * rendering/RenderEmbeddedObject.cpp:
606         (WebCore::RenderEmbeddedObject::paintReplaced):
607         * rendering/RenderEmbeddedObject.h:
608         * rendering/RenderHTMLCanvas.cpp:
609         (WebCore::RenderHTMLCanvas::paintReplaced):
610         * rendering/RenderHTMLCanvas.h:
611         * rendering/RenderImage.cpp:
612         (WebCore::RenderImage::paintReplaced):
613         * rendering/RenderImage.h:
614         * rendering/RenderInline.cpp:
615         (WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
616         * rendering/RenderLayer.cpp:
617         (WebCore::expandClipRectForDescendantsAndReflection):
618         (WebCore::RenderLayer::paintScrollCorner):
619         (WebCore::RenderLayer::paintResizer):
620         (WebCore::RenderLayer::paintChildLayerIntoColumns):
621         (WebCore::RenderLayer::hitTestChildLayerColumns):
622         (WebCore::RenderLayer::boundingBox):
623         (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
624         * rendering/RenderLayerBacking.cpp:
625         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
626         (WebCore::paintScrollbar):
627         (WebCore::RenderLayerBacking::paintContents):
628         * rendering/RenderLayerCompositor.cpp:
629         (WebCore::RenderLayerCompositor::calculateCompositedBounds):
630         (WebCore::RenderLayerCompositor::layerWillBeRemoved):
631         (WebCore::paintScrollbar):
632         (WebCore::RenderLayerCompositor::paintContents):
633         * rendering/RenderListBox.cpp:
634         (WebCore::RenderListBox::controlClipRect):
635         * rendering/RenderListItem.cpp:
636         (WebCore::RenderListItem::positionListMarker):
637         * rendering/RenderListMarker.cpp:
638         (WebCore::RenderListMarker::paint):
639         * rendering/RenderReplaced.cpp:
640         (WebCore::RenderReplaced::paint):
641         * rendering/RenderReplaced.h:
642         (WebCore::RenderReplaced::paintReplaced):
643         * rendering/RenderTableCell.cpp:
644         (WebCore::RenderTableCell::computeRectForRepaint):
645         * rendering/RenderTextControlSingleLine.cpp:
646         (WebCore::RenderTextControlSingleLine::controlClipRect):
647         * rendering/RenderVideo.cpp:
648         (WebCore::RenderVideo::paintReplaced):
649         * rendering/RenderVideo.h:
650         * rendering/RenderView.cpp:
651         (WebCore::RenderView::repaintViewRectangle):
652
653 2011-06-02  James Robinson  <jamesr@chromium.org>
654
655         Reviewed by Dimitri Glazkov.
656
657         [chromium][V8] Add trace events for timer fires and event listener dispatches
658         https://bugs.webkit.org/show_bug.cgi?id=61977
659
660         Adds TRACE_EVENT macro around timer and event listener dispatches.  When tracing (a chromium feature) is
661         enabled, this allows correlating these events with painting, compositing, and everything else in chromium that
662         is traced.  When tracing is disabled, this macro does nothing useful.  Trace points are very cheap when tracing
663         is disabled so this should have no performance impact for non-developers.
664
665         * bindings/v8/ScheduledAction.cpp:
666         (WebCore::ScheduledAction::execute):
667         * bindings/v8/V8EventListener.cpp:
668         (WebCore::V8EventListener::callListenerFunction):
669
670 2011-06-02  John Bates  <jbates@google.com>
671
672         Reviewed by James Robinson.
673
674         DrawingBufferChromium cleanup:
675         - Correct FIXME comment about synchronization.
676         - Remove unnecessary DrawingBufferInternal indirection struct
677           and its unused offscreenColorTexture member.
678         https://bugs.webkit.org/show_bug.cgi?id=61953
679
680         * platform/graphics/chromium/DrawingBufferChromium.cpp:
681         (WebCore::DrawingBuffer::DrawingBuffer):
682         (WebCore::DrawingBuffer::~DrawingBuffer):
683         (WebCore::DrawingBuffer::publishToPlatformLayer):
684         (WebCore::DrawingBuffer::didReset):
685         (WebCore::DrawingBuffer::platformLayer):
686         * platform/graphics/gpu/DrawingBuffer.h:
687
688 2011-06-02  Andrey Kosyakov  <caseq@chromium.org>
689
690         Reviewed by Pavel Feldman.
691
692         Web Inspector: ResourceCookiesView.resize() is missing
693         https://bugs.webkit.org/show_bug.cgi?id=61868
694
695         * inspector/front-end/ResourceCookiesView.js:
696         (WebInspector.ResourceCookiesView.prototype.resize):
697
698 2011-06-02  Kent Tamura  <tkent@chromium.org>
699
700         Reviewed by Dimitri Glazkov.
701
702         REGRESSION(r87014): Cloned text <input> doesn't work well.
703         https://bugs.webkit.org/show_bug.cgi?id=61909
704
705         The default implementation of Element::cloneNode() creates a clone
706         node by Document::createElement(). So, if a customized class is used for
707         shadow nodes, cloneNode() doesn't create a node of the correct class.
708         Such custom classes need to override Element::
709         cloneElementWithoutAttributesAndChildren().
710
711         TextFieldInputType and SearchInputType had references to shadow nodes
712         initialized in createShadowSubtree(). However createShadowSubtree() is
713         not called if the host node is cloned. The accessors for shadow nodes
714         should search a shadow tree.
715
716         Test: fast/forms/textfield-clone.html
717
718         * html/SearchInputType.cpp:
719           Remove data members for shadow nodes, and the accessors search the
720           shadow tree for the requested node by TreeScope::getElementById().
721         (WebCore::SearchInputType::SearchInputType):
722         (WebCore::innerBlockId):
723         (WebCore::resultButtonId):
724         (WebCore::cancelButtonId):
725         (WebCore::SearchInputType::createShadowSubtree):
726         (WebCore::SearchInputType::innerBlockElement):
727         (WebCore::SearchInputType::resultsButtonElement):
728         (WebCore::SearchInputType::cancelButtonElement):
729         * html/SearchInputType.h:
730         * html/TextFieldInputType.cpp: ditto.
731         (WebCore::TextFieldInputType::TextFieldInputType):
732         (WebCore::TextFieldInputType::innerTextId):
733         (WebCore::spinButtonId):
734         (WebCore::TextFieldInputType::speechButtonId):
735         (WebCore::TextFieldInputType::appendChildAndSetId):
736         (WebCore::TextFieldInputType::createShadowSubtree):
737         (WebCore::TextFieldInputType::getShadowElementById):
738         (WebCore::TextFieldInputType::innerTextElement):
739         (WebCore::TextFieldInputType::innerSpinButtonElement):
740         (WebCore::TextFieldInputType::speechButtonElement):
741         * html/TextFieldInputType.h:
742         * html/shadow/TextControlInnerElements.cpp:
743           Overrides cloneElementWithoutAttributesAndChildren() in order that cloneNode()
744           produces an instance of the correct class.
745         (WebCore::TextControlInnerElement::cloneElementWithoutAttributesAndChildren):
746         (WebCore::TextControlInnerTextElement::cloneElementWithoutAttributesAndChildren):
747         (WebCore::SearchFieldResultsButtonElement::cloneElementWithoutAttributesAndChildren):
748         (WebCore::SearchFieldCancelButtonElement::cloneElementWithoutAttributesAndChildren):
749         (WebCore::SpinButtonElement::cloneElementWithoutAttributesAndChildren):
750         (WebCore::InputFieldSpeechButtonElement::cloneElementWithoutAttributesAndChildren):
751         * html/shadow/TextControlInnerElements.h:
752
753 2011-05-28  Martin Robinson  <mrobinson@igalia.com>
754
755         Reviewed by Gustavo Noronha Silva.
756
757         [GTK] Remove PasteboardHelperGtk
758         https://bugs.webkit.org/show_bug.cgi?id=61690
759
760         Remove the virtual methods from PasteboardHelper, so that PasteboardHelperGtk
761         can be removed. Since the GtkClipboard IDs are verified to be the same between
762         WebKit and WebCore we no longer need to communicate from WebCore to WebKit to
763         get them.
764
765         No new tests. This is just a code refactor.
766
767         * platform/Pasteboard.h: Remove GTK+ specific methods. They are no longer needed.
768         * platform/gtk/ClipboardGtk.cpp: Remove the m_helper member and access the
769         PasteboardHelper singleton directly.
770         * platform/gtk/ClipboardGtk.h: Ditto.
771         * platform/gtk/PasteboardGtk.cpp: Ditto.
772         * platform/gtk/PasteboardHelper.cpp:
773         (WebCore::removeMarkupPrefix): Remove an extra line.
774         (WebCore::PasteboardHelper::defaultPasteboardHelper): Added this static getter
775         for the singleton.
776         (WebCore::PasteboardHelper::PasteboardHelper): Moved the contents of initTargetList here.
777         (WebCore::PasteboardHelper::getCurrentClipboard): Instead of talking with WebKit to determine
778         whether or not to use the primary selection clipboard, just use our new member.
779         (WebCore::PasteboardHelper::fillSelectionData): Use our local enum to get the ID.
780         (WebCore::PasteboardHelper::targetListForDataObject): Ditto.
781         (WebCore::PasteboardHelper::dropAtomsForContext): Ditto.
782         (WebCore::getClipboardContentsCallback): Ditto.
783         * platform/gtk/PasteboardHelper.h: PasteboardHelper now keeps track of whether or
784         not to use the primary selection clipboard internally.
785         (WebCore::PasteboardHelper::setUsePrimarySelectionClipboard): Added.
786         (WebCore::PasteboardHelper::usePrimarySelectionClipboard): Added.
787
788 2011-06-02  Levi Weintraub  <leviw@chromium.org>
789
790         Reviewed by Eric Seidel.
791
792         Teach InlineBox about FloatPoint
793         https://bugs.webkit.org/show_bug.cgi?id=44412
794
795         Original patch by Eric Seidel. Updated by me.
796
797         This is another step towards more point/size
798         usage throughout the rendering tree.
799
800         Added left(), right(), top(), and bottom() methods
801         to InlineBox. Removed m_x, and m_y and replaced them
802         with a single m_topLeft member.
803
804         No new tests since this is just a refactoring.
805
806         * rendering/EllipsisBox.cpp:
807         (WebCore::EllipsisBox::paint):
808         (WebCore::EllipsisBox::selectionRect):
809         (WebCore::EllipsisBox::paintSelection):
810         (WebCore::EllipsisBox::nodeAtPoint):
811         * rendering/EllipsisBox.h:
812         (WebCore::EllipsisBox::EllipsisBox):
813         * rendering/InlineBox.cpp:
814         (WebCore::InlineBox::adjustPosition):
815         (WebCore::InlineBox::canAccommodateEllipsis):
816         * rendering/InlineBox.h:
817         (WebCore::InlineBox::InlineBox):
818         (WebCore::InlineBox::setX):
819         (WebCore::InlineBox::x):
820         (WebCore::InlineBox::left):
821         (WebCore::InlineBox::setY):
822         (WebCore::InlineBox::y):
823         (WebCore::InlineBox::top):
824         (WebCore::InlineBox::topLeft):
825         (WebCore::InlineBox::right):
826         (WebCore::InlineBox::bottom):
827         (WebCore::InlineBox::logicalLeft):
828         (WebCore::InlineBox::setLogicalLeft):
829         (WebCore::InlineBox::logicalTop):
830         (WebCore::InlineBox::setLogicalTop):
831         (WebCore::InlineBox::logicalFrameRect):
832         * rendering/InlineFlowBox.h:
833         (WebCore::InlineFlowBox::frameRectIncludingLineHeight):
834         * rendering/InlineTextBox.cpp:
835         (WebCore::InlineTextBox::placeEllipsisBox):
836         (WebCore::InlineTextBox::paintTextMatchMarker):
837         (WebCore::InlineTextBox::computeRectForReplacementMarker):
838         * rendering/RenderText.cpp:
839         (WebCore::RenderText::firstRunX):
840         (WebCore::RenderText::firstRunY):
841         * rendering/RenderTreeAsText.cpp:
842         (WebCore::writeTextRun):
843         * rendering/RootInlineBox.cpp:
844         (WebCore::RootInlineBox::placeEllipsis):
845         * rendering/svg/RenderSVGText.cpp:
846         (WebCore::RenderSVGText::positionForPoint):
847         * rendering/svg/SVGInlineTextBox.h:
848         (WebCore::SVGInlineTextBox::selectionTop):
849         * rendering/svg/SVGRootInlineBox.cpp:
850         (WebCore::SVGRootInlineBox::closestLeafChildForPosition):
851
852 2011-06-02  Jian Li  <jianli@chromium.org>
853
854         Reviewed by David Levin.
855
856         Update the behavior of multiple reads for FileReader
857         https://bugs.webkit.org/show_bug.cgi?id=61793
858
859         Changed to throw an OperationNotAllowedException with the NOT_ALLOWED_ERR
860         status code on any of the read methods that occur when readyState = LOADING.
861         Otherwise, calling any of the read methods should work. 
862
863         Test: fast/files/read-file-async.html
864
865         * CodeGenerators.pri:
866         * DerivedSources.cpp:
867         * DerivedSources.make:
868         * GNUmakefile.list.am:
869         * WebCore.gypi:
870         * WebCore.pro:
871         * WebCore.vcproj/WebCore.vcproj:
872         * WebCore.xcodeproj/project.pbxproj:
873         * bindings/js/JSDOMBinding.cpp:
874         (WebCore::setDOMException):
875         * bindings/v8/V8Proxy.cpp:
876         (WebCore::V8Proxy::setDOMException):
877         * dom/ExceptionCode.cpp:
878         (WebCore::getExceptionCodeDescription):
879         * dom/ExceptionCode.h:
880         * fileapi/FileReader.cpp:
881         (WebCore::FileReader::FileReader):
882         (WebCore::FileReader::hasPendingActivity):
883         (WebCore::FileReader::readAsArrayBuffer):
884         (WebCore::FileReader::readAsBinaryString):
885         (WebCore::FileReader::readAsText):
886         (WebCore::FileReader::readAsDataURL):
887         (WebCore::FileReader::readInternal):
888         (WebCore::FileReader::abort):
889         (WebCore::FileReader::doAbort):
890         (WebCore::FileReader::terminate):
891         (WebCore::FileReader::start):
892         (WebCore::FileReader::didStartLoading):
893         (WebCore::FileReader::didFinishLoading):
894         (WebCore::FileReader::didFail):
895         * fileapi/FileReader.h:
896         (WebCore::FileReader::readyState):
897         * fileapi/FileReader.idl:
898         * fileapi/OperationNotAllowedException.h: Added.
899         (WebCore::OperationNotAllowedException::create):
900         (WebCore::OperationNotAllowedException::OperationNotAllowedException):
901         * fileapi/OperationNotAllowedException.idl: Added.
902
903 2011-06-02  Adrienne Walker  <enne@google.com>
904
905         Reviewed by James Robinson.
906
907         [chromium] Compositor HUD should respect mapTexSubImage2D returning NULL
908         https://bugs.webkit.org/show_bug.cgi?id=61954
909
910         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
911         (WebCore::CCHeadsUpDisplay::draw):
912
913 2011-06-02  Brady Eidson  <beidson@apple.com>
914
915         Reviewed by Oliver Hunt.
916
917         <rdar://problem/9539920> and https://bugs.webkit.org/show_bug.cgi?id=61950
918         Repro crash loading certain webarchives after r87566.
919
920         Test: webarchive/loading/javascript-url-iframe-crash.html
921
922         * bindings/ScriptControllerBase.cpp:
923         (WebCore::ScriptController::executeIfJavaScriptURL): DocumentWriter::replaceDocument can
924           cause the DocumentLoader to be destroyed, so protect it with a Ref here.
925
926 2011-06-02  Jay Civelli  <jcivelli@chromium.org>
927
928         Reviewed by Adam Barth.
929
930         Adding MHTML generation support to MHTMLArchive.
931         https://bugs.webkit.org/show_bug.cgi?id=7169
932
933         * loader/archive/mhtml/MHTMLArchive.cpp:
934         (WebCore::generateRandomBoundary):
935         (WebCore::replaceNonPrintableCharacters):
936         (WebCore::MHTMLArchive::generateMHTMLData):
937         * loader/archive/mhtml/MHTMLArchive.h:
938         * page/PageSerializer.cpp:
939         (WebCore::PageSerializer::serializeFrame):
940         (WebCore::PageSerializer::serializeCSSStyleSheet):
941         * platform/SharedBuffer.cpp:
942         (WebCore::SharedBuffer::append):
943         * platform/SharedBuffer.h:
944
945 2011-06-02  Simon Fraser  <simon.fraser@apple.com>
946
947         Reviewed by Andreas Kling.
948
949         Share Path code that uses beziers to construct a rounded rect
950         https://bugs.webkit.org/show_bug.cgi?id=61960
951
952         Have two methods in Path that construct beziers for rounded
953         rects to share the same code.
954         
955         Make gCircleControlPoint a little more precise, and add
956         a comment describing its derivation.
957         
958         Make use of FloatRect::maxX() and maxY().
959
960         * platform/graphics/Path.cpp:
961         (WebCore::Path::addRoundedRect):
962         (WebCore::Path::addBeziersForRoundedRect):
963         * platform/graphics/Path.h:
964
965 2011-06-02  Ryosuke Niwa  <rniwa@webkit.org>
966
967         Reviewed by Enrica Casucci.
968
969         ApplyStyleCommand shouldn't call collapseTextDecorationProperties
970         https://bugs.webkit.org/show_bug.cgi?id=61887
971
972         Removed the call to collapseTextDecorationProperties in ApplyStyleCommand::applyInlineStyle.
973
974         No new tests because this is a code refactoring.
975
976         * editing/ApplyStyleCommand.cpp:
977         (WebCore::ApplyStyleCommand::applyInlineStyle): No loner calls collapseTextDecorationProperties.
978         (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Updated comment.
979         * editing/EditingStyle.cpp:
980         (WebCore::HTMLElementEquivalent::propertyExistsInStyle): Added to check both text-decoration
981         and -webkit-text-decorations-in-effect.
982         (WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent): Added a comment.
983         (WebCore::HTMLTextDecorationEquivalent::propertyExistsInStyle): Checks both text-decoration
984         and -webkit-text-decorations-in-effect.
985         (WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle): Checks if a text decoration
986         is present in -webkit-text-decorations-in-effect or text-decoration preferring the former.
987         (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Merged loops for when conflictingProperties
988         is false and true. Added a support for -webkit-text-decorations-in-effect.
989
990 2011-06-02  Ryosuke Niwa  <rniwa@webkit.org>
991
992         Reviewed by Eric Seidel.
993
994         Make more functions static local in EventHandlers.cpp
995         https://bugs.webkit.org/show_bug.cgi?id=58503
996
997         Removed canHandleDragAndDropForTarget and made focusDirectionForKey local to EventHandler.cpp.
998
999         * page/EventHandler.cpp:
1000         (WebCore::targetIsFrame): Extracted from canHandleDragAndDropForTarget.
1001         (WebCore::EventHandler::updateDragAndDrop): Calls contentFrameForTarget instead of canHandleDragAndDropForTarget.
1002         (WebCore::EventHandler::cancelDragAndDrop): Ditto.
1003         (WebCore::EventHandler::performDragAndDrop): Ditto.
1004         (WebCore::focusDirectionForKey): No longer a member function of EventHandler class.
1005         (WebCore::handleKeyboardSelectionMovement): No longer a member function of EventHandler class; also calls
1006         focusDirectionForKey instead of manually comparing.
1007         * page/EventHandler.h:
1008
1009 2011-06-02  Alok Priyadarshi  <alokp@chromium.org>
1010
1011         Reviewed by James Robinson.
1012
1013         [chromium] Things jump around when selecting anything on the page
1014         https://bugs.webkit.org/show_bug.cgi?id=61639
1015
1016         WebCore::LayerTextureUpdaterSkPicture::updateTextureRect was not updating a tile sub-region properly.
1017         It did not consider dest-rect when selecting the clip and translation required to draw the content-rect into dest-rect.
1018         Also removed clearing of framebuffer because it used to clear the whole tile not just dest-rect.
1019         An appropriate viewport could be set to just clear the dest-rect, but it was debug only code and I did not want to mess
1020         with the viewport set by skia.
1021
1022         No new tests. This case should be covered by most of the layout tests (pixel) targeting selection or hovering when chromium is run in compositing mode.
1023         Here is a non-exhaustive list of existing tests covering this case.
1024         Test: editing/selection/14971.html (existing)
1025               editing/selection/3690703-2.html (existing)
1026               editing/selection/4402375.html (existing)
1027               editing/selection/4818145.html (existing)
1028
1029         * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
1030         (WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
1031         (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
1032         * platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
1033
1034 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
1035
1036         Reviewed by Darin Adler.
1037
1038         Add build logistics and plumbing for window.internals object.
1039         https://bugs.webkit.org/show_bug.cgi?id=60313
1040
1041         Test: fast/harness/internals-object.html
1042
1043         * Configurations/WebCoreTestSupport.xcconfig: Added.
1044         * DerivedSources.make: Added support for generating from Internals.idl.
1045         * WebCore.gyp/WebCore.gyp: Added new webcore_test_support library.
1046         * WebCore.gypi: Ditto.
1047         * WebCore.xcodeproj/project.pbxproj: Added WebCoreTestSupport library.
1048         * testing/Internals.cpp: Added.
1049         * testing/Internals.h: Added.
1050         * testing/Internals.idl: Added.
1051         * testing/js/WebCoreTestSupport.cpp: Added.
1052         * testing/js/WebCoreTestSupport.h: Added.
1053         * testing/v8/WebCoreTestSupport.cpp: Added.
1054         * testing/v8/WebCoreTestSupport.h: Added.
1055
1056 2011-06-01  Adrienne Walker  <enne@google.com>
1057
1058         Reviewed by Eric Seidel.
1059
1060         [chromium] LayerChromium should use a RefPtr for replica layer
1061         https://bugs.webkit.org/show_bug.cgi?id=61898
1062
1063         Having this member variable be a raw pointer is brittle and assumes
1064         that the GraphicsLayer tree keeps this in sync.  There aren't any
1065         known bugs caused by this, but it seems like good sense to do this.
1066
1067         * platform/graphics/chromium/LayerChromium.h:
1068         (WebCore::LayerChromium::replicaLayer):
1069
1070 2011-06-02  Ryosuke Niwa  <rniwa@webkit.org>
1071
1072         Reviewed by Eric Seidel.
1073
1074         REGRESSION: inline style is lost when deleting line break between paragraphs with same style
1075         https://bugs.webkit.org/show_bug.cgi?id=61899
1076
1077         The bug was caused by ReplaceSelectionCommand::doApply's calling handleStyleSpansBeforeInsertion
1078         before insertionPos is adjusted by positionAvoidingPrecedingNodes and positionOutsideTabSpan.
1079
1080         Fixed the bug by calling handleStyleSpansBeforeInsertion after the calls to these two functions.
1081
1082         Test: editing/deleting/delete-line-break-between-paragraphs-with-same-style.html
1083
1084         * editing/ReplaceSelectionCommand.cpp:
1085         (WebCore::ReplaceSelectionCommand::doApply):
1086
1087 2011-06-01  Ryosuke Niwa  <rniwa@webkit.org>
1088
1089         Reviewed by Simon Fraser.
1090
1091         REGRESSION: Text selection broken for text with line-height applied
1092         https://bugs.webkit.org/show_bug.cgi?id=54929
1093
1094         The bug was caused by RenderText::positionForPoint's not considering the case where a point is
1095         above selectionTop and below lineTop of the first root inline box. Fixed the bug by considering
1096         any point between selectionTop and lineTop to be inside a root inline box. This condition is
1097         consistent with the condition we use to determine the bottom of a line.
1098
1099         Test: editing/selection/hit-test-on-text-with-line-height.html
1100
1101         * rendering/RenderBlock.cpp:
1102         (WebCore::RenderBlock::positionForPointWithInlineChildren): Fixed a condition to determine whether
1103         or not a point is above the first root line box. We need to check both selectionTop and logicalTop
1104         for the same reason explained above.
1105         * rendering/RenderText.cpp:
1106         (WebCore::RenderText::positionForPoint): See above.
1107
1108 2011-06-02  Andreas Kling  <kling@webkit.org>
1109
1110         Reviewed by James Robinson.
1111
1112         Canvas/V8: Fix setting strokeStyle or fillStyle to a CSS system color.
1113         https://bugs.webkit.org/show_bug.cgi?id=61944
1114
1115         Call setFillColor/setStrokeColor (instead of setFillStyle/setStrokeStyle)
1116         for string styles. This ensures that system color resolution is performed,
1117         and matches what the JSC bindings do.
1118
1119         Test: canvas/philip/tests/2d.fillStyle.parse.system.html
1120
1121         * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
1122         (WebCore::toCanvasStyle):
1123         (WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorSetter):
1124         (WebCore::V8CanvasRenderingContext2D::fillStyleAccessorSetter):
1125
1126 2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1127
1128         Unreviewed, rolling out r87920.
1129         http://trac.webkit.org/changeset/87920
1130         https://bugs.webkit.org/show_bug.cgi?id=61943
1131
1132         This patch does not build in Win Builder (dbg)(shared)
1133         downstream (Requested by abarth|gardener on #webkit).
1134
1135         * platform/chromium/PopupMenuChromium.cpp:
1136         (WebCore::PopupContainer::showPopup):
1137         (WebCore::PopupListBox::handleMouseReleaseEvent):
1138         (WebCore::PopupListBox::acceptIndex):
1139
1140 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
1141
1142         Unreviewed, rolling out r87926.
1143         http://trac.webkit.org/changeset/87926
1144         https://bugs.webkit.org/show_bug.cgi?id=60313
1145
1146         Fails to find WebCoreTestSupport.dylib on bots.
1147
1148         * Configurations/WebCore.xcconfig:
1149         * Configurations/WebCoreTestSupport.xcconfig: Removed.
1150         * DerivedSources.make:
1151         * WebCore.exp.in:
1152         * WebCore.gyp/WebCore.gyp:
1153         * WebCore.gypi:
1154         * WebCore.xcodeproj/project.pbxproj:
1155         * bindings/js/JSDOMWrapper.cpp:
1156         (WebCore::JSDOMWrapper::~JSDOMWrapper):
1157         * bindings/js/JSDOMWrapper.h:
1158         * testing/Internals.cpp: Removed.
1159         * testing/Internals.h: Removed.
1160         * testing/Internals.idl: Removed.
1161         * testing/js/WebCoreTestSupport.cpp: Removed.
1162         * testing/js/WebCoreTestSupport.h: Removed.
1163         * testing/v8/WebCoreTestSupport.cpp: Removed.
1164         * testing/v8/WebCoreTestSupport.h: Removed.
1165
1166 2011-06-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1167
1168         Reviewed by Martin Robinson.
1169
1170         [GTK] Implement popup menus in Webkit2
1171         https://bugs.webkit.org/show_bug.cgi?id=61854
1172
1173         Move common code into a new class to be used by both WebKit1 and
1174         WebKit2.
1175
1176         * GNUmakefile.list.am: Add new files to compilation.
1177         * platform/gtk/GtkPopupMenu.cpp: Copied from Source/WebCore/platform/gtk/PopupMenuGtk.cpp.
1178         (WebCore::GtkPopupMenu::GtkPopupMenu):
1179         (WebCore::GtkPopupMenu::~GtkPopupMenu):
1180         (WebCore::GtkPopupMenu::clear): Remove all menu items.
1181         (WebCore::GtkPopupMenu::appendSeparator): Add a new separator
1182         item to the menu.
1183         (WebCore::GtkPopupMenu::appendItem): Add a new item to the menu for
1184         the given action.
1185         (WebCore::GtkPopupMenu::popUp): Show the menu.
1186         (WebCore::GtkPopupMenu::popDown): Hide the menu.
1187         (WebCore::GtkPopupMenu::menuRemoveItem):
1188         (WebCore::GtkPopupMenu::menuPositionFunction):
1189         (WebCore::GtkPopupMenu::resetTypeAheadFindState):
1190         (WebCore::GtkPopupMenu::typeAheadFind):
1191         (WebCore::GtkPopupMenu::selectItemCallback):
1192         (WebCore::GtkPopupMenu::keyPressEventCallback):
1193         * platform/gtk/GtkPopupMenu.h: Copied from Source/WebCore/platform/gtk/PopupMenuGtk.h.
1194         (WebCore::GtkPopupMenu::create):
1195         (WebCore::GtkPopupMenu::platformMenu):
1196         * platform/gtk/PopupMenuGtk.cpp:
1197         (WebCore::PopupMenuGtk::PopupMenuGtk):
1198         (WebCore::PopupMenuGtk::~PopupMenuGtk):
1199         (WebCore::PopupMenuGtk::show): Use GtkPopupMenu.
1200         (WebCore::PopupMenuGtk::hide): Ditto.
1201         (WebCore::PopupMenuGtk::menuItemActivated):
1202         (WebCore::PopupMenuGtk::menuUnmapped):
1203         * platform/gtk/PopupMenuGtk.h:
1204
1205 2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
1206
1207         Reviewed by Darin Adler.
1208
1209         Add build logistics and plumbing for window.internals object.
1210         https://bugs.webkit.org/show_bug.cgi?id=60313
1211
1212         Test: fast/harness/internals-object.html
1213
1214         * Configurations/WebCoreTestSupport.xcconfig: Added.
1215         * DerivedSources.make: Added support for generating from Internals.idl.
1216         * WebCore.gyp/WebCore.gyp: Added new webcore_test_support library.
1217         * WebCore.gypi: Ditto.
1218         * WebCore.xcodeproj/project.pbxproj: Added WebCoreTestSupport library.
1219         * testing/Internals.cpp: Added.
1220         * testing/Internals.h: Added.
1221         * testing/Internals.idl: Added.
1222         * testing/js/WebCoreTestSupport.cpp: Added.
1223         * testing/js/WebCoreTestSupport.h: Added.
1224         * testing/v8/WebCoreTestSupport.cpp: Added.
1225         * testing/v8/WebCoreTestSupport.h: Added.
1226
1227 2011-06-02  Naoki Takano  <takano.naoki@gmail.com>
1228
1229         Reviewed by Dimitri Glazkov.
1230
1231         [Chromium] Click event is not fired for a menulist <select>
1232         https://bugs.webkit.org/show_bug.cgi?id=60563
1233
1234         Tests: SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange in webkit_unit_tests.
1235
1236         * platform/chromium/PopupMenuChromium.cpp:
1237         (WebCore::PopupContainer::showPopup): Set m_focusedNode from m_frameView.
1238         (WebCore::PopupListBox::handleMouseReleaseEvent): Call dispatchMouseEvent to forward the event only if select popup.
1239         (WebCore::PopupListBox::acceptIndex): Change to return accepted or not.
1240
1241 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
1242
1243         Reviewed by Darin Adler.
1244
1245         Stop event propagation for cases where relatedTarget is both ancestor of the target and at shadow boundary.
1246         https://bugs.webkit.org/show_bug.cgi?id=61892
1247
1248         In the cases where the relatedTarget of an event is an ancestor of the target, and the relatedTarget is
1249         a shadow host, we should not allow events to escape out of the hosted shadow DOM subtree.
1250
1251         * dom/EventDispatcher.cpp:
1252         (WebCore::EventDispatcher::adjustToShadowBoundaries): Added a check that is valid for both new and old shadow DOM.
1253
1254 2011-06-02  Hans Wennborg  <hans@chromium.org>
1255
1256         Reviewed by Tony Gentilcore.
1257
1258         Fix LevelDBTransaction::clearTree()
1259         https://bugs.webkit.org/show_bug.cgi?id=61917
1260
1261         This was broken in the code I copied it from; we can't delete and walk
1262         the tree at the same time.
1263
1264         No new functionality, no new tests.
1265
1266         * platform/leveldb/LevelDBTransaction.cpp:
1267         (WebCore::LevelDBTransaction::clearTree):
1268
1269 2011-06-02  Andreas Kling  <kling@webkit.org>
1270
1271         Rubber-stamped by Simon Hausmann.
1272
1273         Remove Qt's precompiled header hack as it was broken, and was not even
1274         used unless building WebKit inside a Qt tree.
1275
1276         * WebCore.pri:
1277
1278 2011-06-02  James Robinson  <jamesr@chromium.org>
1279
1280         Reviewed by Brady Eidson.
1281
1282         DocumentLoader keeps a reference to all URL strings ever loaded leading to lots of memory waste
1283         https://bugs.webkit.org/show_bug.cgi?id=61894
1284
1285         DocumentLoader::m_resourcesClientKnowsAbout is a set of all the URLs that have passed through
1286         FrameLoader::dispatchWillSendRequest() and is used by FrameLoader::loadedResourceFromMemoryCached to decide
1287         whether to inform the FrameLoader's m_client about this load.  Unfortunately, this set holds a reference to the
1288         URL string for every resource loaded, so on pages that use data URLs to "load" large amounts of data this leaks
1289         lots of memory.
1290
1291         This set only has an effect on the Mac port, as the only two ports that implement
1292         FrameLoaderClient::dispatchDidLoadResourceFromMemoryCache() are Chromium and Mac and the Chromium implementation
1293         can correctly handle receiving multiple callbacks.  This patch limits the set to only PLATFORM(MAC) so other
1294         ports do not have to pay this memory cost.  It's possible that a better fix exists specifically for the Mac port
1295         implementation, but that would have to determined by someone who works on that port specifically.
1296
1297         * loader/DocumentLoader.h:
1298         (WebCore::DocumentLoader::didTellClientAboutLoad):
1299         (WebCore::DocumentLoader::haveToldClientAboutLoad):
1300
1301 2011-06-02  Aparna Nandyal  <aparna.nand@wipro.com>
1302
1303         Reviewed by Andreas Kling.
1304
1305         [Qt] Multiple drop events when doing DnD of images.
1306         https://bugs.webkit.org/show_bug.cgi?id=61504
1307
1308         Duplicate entries of the url were getting added into drag data
1309         which is removed. The duplicate entries were causing the same image
1310         url to be copied twice. The code changes now match other webkit ports.
1311
1312         * platform/qt/ClipboardQt.cpp:
1313         (WebCore::ClipboardQt::declareAndWriteDragImage):
1314
1315 2011-06-02  Naiem Shaik  <naiem.shaik@gmail.com>
1316
1317         Reviewed by Kent Tamura.
1318         
1319         Fixing invalid value being returned for default checkbox and radio state
1320         https://bugs.webkit.org/show_bug.cgi?id=61674
1321
1322         As per http://www.w3.org/TR/html5/number-state.html#checkbox-state and
1323         http://www.w3.org/TR/html5/number-state.html#radio-button-state:
1324         The value IDL attribute is in mode default/on: 
1325         If the element has a value attribute, it must return that attribute's 
1326         value; otherwise, it must return the string "on".  
1327         Currently default value is empty string;Default value of Radio button 
1328         and checkbox should be "on".Changed fallbackValue function to return the same
1329         This works as per spec in IE9,Firefox and Opera
1330
1331         Tests: fast/forms/checkbox-default-value.html
1332                fast/forms/radio-default-value.html
1333
1334         * html/BaseCheckableInputType.cpp:
1335         (WebCore::BaseCheckableInputType::fallbackValue):
1336
1337 2011-06-02  Kent Tamura  <tkent@chromium.org>
1338
1339         [Chromium/Mac] Fix a wrong merge for r87881
1340         https://bugs.webkit.org/show_bug.cgi?id=61845
1341
1342         * platform/chromium/ThemeChromiumMac.mm:
1343         (WebCore::paintStepper):
1344
1345 2011-06-02  Ian Henderson  <ianh@apple.com>
1346
1347         Reviewed by Simon Fraser.
1348
1349         [CG] GraphicsContext::fillRoundedRect() ignores the gradient fill the CGContextFillEllipseInRect() code path
1350         https://bugs.webkit.org/show_bug.cgi?id=61882
1351
1352         If we have a gradient or pattern fill set, take the slow path, which
1353         handles these cases properly.
1354
1355         No new tests, since we never try to fill a rounded rect with a
1356         gradient or pattern.
1357
1358         * platform/graphics/cg/GraphicsContextCG.cpp:
1359         (WebCore::GraphicsContext::fillRoundedRect):
1360
1361 2011-06-02  MORITA Hajime  <morrita@google.com>
1362
1363         Reviewed by Kent Tamura.
1364
1365         [Refactoring] Node::nextRenderer() and previousRenderer() should be part of NodeRenderingContext
1366         https://bugs.webkit.org/show_bug.cgi?id=61912
1367
1368         Inlined Node::nextRenderer() and previousRenderer() into NodeRenderingContext and
1369         removed original definitions.
1370
1371         No test, no behavioral change.
1372         
1373         * dom/Node.cpp:
1374         * dom/Node.h:
1375         * dom/NodeRenderingContext.cpp:
1376         (WebCore::NodeRenderingContext::nextRenderer):
1377         (WebCore::NodeRenderingContext::previousRenderer):
1378
1379 2011-06-02  Piroska András  <Piroska.Andras@stud.u-szeged.hu>
1380
1381         Rubber-stamped by Gabor Loki.
1382
1383         Trivial buildfix for the ParallelJobs part of FEConvolveMatrix.
1384
1385         * platform/graphics/filters/FEConvolveMatrix.cpp:
1386         (WebCore::FEConvolveMatrix::apply): Rename variable i to job
1387
1388 2011-06-02  Yuta Kitamura  <yutak@chromium.org>
1389
1390         Reviewed by Kent Tamura.
1391
1392         WebSocket: Call WebSocketChannel::fail() when WebSocketHandshake has failed
1393         https://bugs.webkit.org/show_bug.cgi?id=61841
1394
1395         There is no change in behavior except that capitalization of a few error messages
1396         has been changed. No new tests are added.
1397
1398         * websockets/WebSocketChannel.cpp:
1399         (WebCore::WebSocketChannel::processBuffer):
1400         Pass m_handshake.failureReason() to fail() if the handshake has failed.
1401         * websockets/WebSocketHandshake.cpp:
1402         Replace occurrences of m_handle->addMessage() with assignments to m_failureReason.
1403         Change capitalization of a few messages so that all messages start with a capital letter.
1404         (WebCore::WebSocketHandshake::readServerHandshake):
1405         (WebCore::WebSocketHandshake::failureReason):
1406         (WebCore::WebSocketHandshake::readStatusLine):
1407         (WebCore::WebSocketHandshake::readHTTPHeaders):
1408         (WebCore::WebSocketHandshake::checkResponseHeaders):
1409         * websockets/WebSocketHandshake.h:
1410         Add failureReason(), which returns a string that describes why WebSocket handshake
1411         has failed.
1412
1413 2011-06-01  Dan Bernstein  <mitz@apple.com>
1414
1415         Reviewed by Anders Carlsson.
1416
1417         Incorrect UA style when printing a simple document
1418         https://bugs.webkit.org/show_bug.cgi?id=61900
1419
1420         This is not testable in run-webkit-tests because unless the test is the first to run in an instance
1421         of DumpRenderTree, it is not guaranteed that the full default style sheet has not been initialized.
1422
1423         * css/CSSStyleSelector.cpp:
1424         (WebCore::loadFullDefaultStyle): Replace the simple default print style, which is now equal to the
1425         simple default style, with a new RuleSet before adding the style rules from the full default sheet.
1426         (WebCore::loadSimpleDefaultStyle): Set defaultPrintStyle to point to the default style. They are
1427         equal in the simple case.
1428
1429 2011-06-01  Kent Tamura  <tkent@chromium.org>
1430
1431         Reviewed by Dimitri Glazkov.
1432
1433         Remove outer-spin-button
1434         https://bugs.webkit.org/show_bug.cgi?id=61845
1435
1436         Remove outer-spin-button, and render steppers as inner-spin-button.
1437         Outer-spin-button have never worked well with padding and border of
1438         <input>, and the layout code is very tricky and very hard to maintain it.
1439
1440         * css/CSSPrimitiveValueMappings.h:
1441         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1442         * css/CSSValueKeywords.in:
1443         * css/html.css:
1444         * html/HTMLInputElement.cpp:
1445         (WebCore::HTMLInputElement::innerSpinButtonElement):
1446         * html/HTMLInputElement.h:
1447         * html/InputType.h:
1448         * html/TextFieldInputType.cpp:
1449         (WebCore::TextFieldInputType::TextFieldInputType):
1450         (WebCore::TextFieldInputType::createShadowSubtree):
1451         (WebCore::TextFieldInputType::destroyShadowSubtree):
1452         * html/TextFieldInputType.h:
1453         * html/shadow/TextControlInnerElements.cpp:
1454         (WebCore::SpinButtonElement::SpinButtonElement):
1455         (WebCore::SpinButtonElement::create):
1456         (WebCore::SpinButtonElement::shadowPseudoId):
1457         * html/shadow/TextControlInnerElements.h:
1458         * platform/ThemeTypes.h:
1459         * platform/chromium/ThemeChromiumMac.mm:
1460         (WebCore::paintStepper):
1461          Center the stepper drawing area because the specified area can be
1462          larger than the NSStepper sizes.
1463         (WebCore::ThemeChromiumMac::controlSize):
1464         (WebCore::ThemeChromiumMac::minimumControlSize):
1465         (WebCore::ThemeChromiumMac::inflateControlPaintRect):
1466         (WebCore::ThemeChromiumMac::paint):
1467         * platform/mac/ThemeMac.mm:
1468         (WebCore::paintStepper):
1469          Center the stepper drawing area because the specified area can be
1470          larger than the NSStepper sizes.
1471         (WebCore::ThemeMac::controlSize):
1472         (WebCore::ThemeMac::minimumControlSize):
1473         (WebCore::ThemeMac::inflateControlPaintRect):
1474         (WebCore::ThemeMac::paint):
1475         * rendering/RenderBox.cpp:
1476         (WebCore::RenderBox::paintBoxDecorations):
1477         * rendering/RenderBox.h:
1478         * rendering/RenderTextControlSingleLine.cpp:
1479         (WebCore::RenderTextControlSingleLine::layout):
1480         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
1481         (WebCore::RenderTextControlSingleLine::textBlockWidth):
1482         * rendering/RenderTextControlSingleLine.h:
1483         * rendering/RenderTheme.cpp:
1484         (WebCore::RenderTheme::adjustStyle):
1485         (WebCore::RenderTheme::paint):
1486         (WebCore::RenderTheme::adjustInnerSpinButtonStyle):
1487         * rendering/RenderTheme.h:
1488         * rendering/RenderThemeMac.mm:
1489         (WebCore::RenderThemeMac::adjustRepaintRect):
1490
1491 2011-06-01  Emil A Eklund  <eae@chromium.org>
1492
1493         Reviewed by Eric Seidel.
1494
1495         Switch RenderLayer::convertToLayerCoords to use IntPoint
1496         https://bugs.webkit.org/show_bug.cgi?id=61818
1497
1498         Covered by existing tests.
1499
1500         * platform/graphics/FloatPoint.h:
1501         (WebCore::flooredIntSize):
1502         * rendering/RenderLayer.cpp:
1503         (WebCore::RenderLayer::updateLayerPositions):
1504         (WebCore::expandClipRectForDescendantsAndReflection):
1505         (WebCore::transparencyClipBox):
1506         (WebCore::RenderLayer::convertToLayerCoords):
1507         (WebCore::RenderLayer::paintLayer):
1508         (WebCore::RenderLayer::paintChildLayerIntoColumns):
1509         (WebCore::RenderLayer::createLocalTransformState):
1510         (WebCore::RenderLayer::hitTestChildLayerColumns):
1511         (WebCore::RenderLayer::calculateClipRects):
1512         (WebCore::RenderLayer::calculateRects):
1513         (WebCore::RenderLayer::boundingBox):
1514         (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
1515         * rendering/RenderLayer.h:
1516         * rendering/RenderLayerBacking.cpp:
1517         (WebCore::RenderLayerBacking::updateCompositedBounds):
1518         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
1519         * rendering/RenderLayerCompositor.cpp:
1520         (WebCore::RenderLayerCompositor::calculateCompositedBounds):
1521         (WebCore::RenderLayerCompositor::layerWillBeRemoved):
1522         (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
1523
1524 2011-06-01  Roland Steiner  <rolandsteiner@chromium.org>
1525
1526         Reviewed by Kent Tamura.
1527
1528         Remove superfluous renderer() test
1529         https://bugs.webkit.org/show_bug.cgi?id=61907
1530
1531         No new tests. (trivial)
1532
1533         * dom/Document.cpp:
1534         (WebCore::Document::recalcStyle):
1535
1536 2011-06-01  Levi Weintraub  <leviw@chromium.org>
1537
1538         Reviewed by Hajime Morita.
1539
1540         Add IntPoint + IntPoint operator
1541         https://bugs.webkit.org/show_bug.cgi?id=61876
1542
1543         Adding an operator+ convenience method to IntPoint that sums two points
1544         and returns the result as an IntPoint. Changing doImageDrag to use it
1545         as a proof of concept.
1546
1547         No new tests since there is no change in behavior.
1548
1549         * page/DragController.cpp:
1550         (WebCore::DragController::doImageDrag):
1551         * platform/graphics/IntPoint.h:
1552         (WebCore::operator+):
1553
1554 2011-06-01  Jaehun Lim  <ljaehun.lim@samsung.com>
1555
1556         Reviewed by Eric Seidel.
1557
1558         [EFL] Add adjustMenuListButtonStyle and paintMenuListButton functions
1559         https://bugs.webkit.org/show_bug.cgi?id=61836
1560
1561         Add functions for rendering drop-down list when style attributes are applied.
1562
1563         * platform/efl/RenderThemeEfl.cpp:
1564         (WebCore::RenderThemeEfl::adjustMenuListButtonStyle):
1565         (WebCore::RenderThemeEfl::paintMenuListButton):
1566         * platform/efl/RenderThemeEfl.h:
1567
1568 2011-06-01  Yuta Kitamura  <yutak@chromium.org>
1569
1570         Reviewed by Kent Tamura.
1571
1572         WebSocket: WebSocketChannel::fail() should close the connection immediately
1573         https://bugs.webkit.org/show_bug.cgi?id=61851
1574
1575         The effect of this change is almost unobservable. The difference between m_handle->close() and
1576         m_handle->disconnect() is that the former does not close the connection if the handle has
1577         unsent data while the latter immediately closes the connection regardless of unsent data.
1578         Usually a socket stream handle does not have unsent data, and even if it has any, it is hard
1579         for user scripts to observe the difference between close() and disconnect() (it should take some time
1580         for onclose() to be called if there are any unsent data, but there ought to be no other difference
1581         in user scripts' perspective).
1582
1583         No new tests are added, because writing a test for this issue is not feasible due to the above reason.
1584
1585         * websockets/WebSocketChannel.cpp:
1586         (WebCore::WebSocketChannel::fail): Use m_handle->disconnect() instead of m_handle->close().
1587
1588 2011-06-01  Abhishek Arya  <inferno@chromium.org>
1589
1590         Unreviewed.
1591
1592         Coding style nit. Move ec=0 initialization, change
1593         recommended by Alexey in bug.
1594         https://bugs.webkit.org/show_bug.cgi?id=60831
1595
1596         * dom/Document.cpp:
1597         (WebCore::Document::setBody):
1598
1599 2011-06-01  Hayato Ito  <hayato@chromium.org>
1600
1601         Reviewed by Kent Tamura.
1602
1603         Move {Next,Previous}FocusableNode functions from Document to FocusController.
1604         https://bugs.webkit.org/show_bug.cgi?id=61839
1605
1606         There are some member functions in Document which use 'this'
1607         pointer, but we should use TreeScope instead of Document in some
1608         places to handle focus issues nicely. We have to move these
1609         functions out of Document class so that we can give the TreeScope
1610         as a parameter.
1611
1612         No new tests since no functionality was changed.
1613
1614         * dom/Document.cpp:
1615         * dom/Document.h:
1616         * page/FocusController.cpp:
1617         (WebCore::FocusController::deepFocusableNode):
1618         (WebCore::FocusController::advanceFocusInDocumentOrder):
1619         (WebCore::nextNodeWithExactTabIndex):
1620         (WebCore::previousNodeWithExactTabIndex):
1621         (WebCore::nextNodeWithGreaterTabIndex):
1622         (WebCore::previousNodeWithLowerTabIndex):
1623         (WebCore::FocusController::nextFocusableNode):
1624         (WebCore::FocusController::previousFocusableNode):
1625         * page/FocusController.h:
1626
1627 2011-06-01  Adrienne Walker  <enne@google.com>
1628
1629         Reviewed by James Robinson.
1630
1631         [chromium] Fix syncing of removed mask and replica layers
1632         https://bugs.webkit.org/show_bug.cgi?id=61895
1633
1634         * platform/graphics/chromium/TreeSynchronizer.cpp:
1635         (WebCore::TreeSynchronizer::synchronizeTreeRecursive):
1636
1637 2011-06-01  Julien Chaffraix  <jchaffraix@codeaurora.org>
1638
1639         Reviewed by Simon Fraser.
1640
1641         CSSStyleSheet#insertRule doesn't work well with imported stylesheets
1642         https://bugs.webkit.org/show_bug.cgi?id=56981
1643
1644         Test: fast/css/import-and-insert-rule-no-update.html
1645
1646         The bug arises from the fact that <link> element did not know about a programmatically
1647         loading sheet (using insertRule and @import) and would thus never call removePendingSheet.
1648         This is needed to make sure our style selector contains an up-to-date list of stylesheets.
1649
1650         The gist of the patch adds a way for style sheet owner element to know if we are
1651         programmatically loading a style sheet. This is needed as <link> keeps the information
1652         about that last loaded stylesheet.
1653
1654         * css/CSSImportRule.cpp:
1655         (WebCore::CSSImportRule::insertedIntoParent): Call startLoadingDynamicSheet
1656         on our parent style sheet instead of directly adding a pending style sheet.
1657
1658         * css/CSSStyleSheet.cpp:
1659         (WebCore::CSSStyleSheet::startLoadingDynamicSheet): Call startLoadingDynamicSheet
1660         on our owner element if we have one.
1661
1662         * css/CSSStyleSheet.h:
1663         * dom/Node.h:
1664         (WebCore::Node::startLoadingDynamicSheet): Added common implementation of
1665         startLoadingDynamicSheet, which should never be called.
1666
1667         * dom/StyleElement.cpp:
1668         (WebCore::StyleElement::startLoadingDynamicSheet):
1669         * dom/StyleElement.h:
1670         Common implementation of startLoadingDynamicSheet for style elements.
1671
1672         * html/HTMLLinkElement.cpp:
1673         (WebCore::HTMLLinkElement::startLoadingDynamicSheet):
1674         * html/HTMLLinkElement.h:
1675         Use the HTMLLinkElement plumbing to make sure we call addRemovePendingSheet.
1676
1677         * html/HTMLStyleElement.h:
1678         (WebCore::HTMLStyleElement::startLoadingDynamicSheet):
1679         * svg/SVGStyleElement.h:
1680         (WebCore::SVGStyleElement::startLoadingDynamicSheet):
1681         Forward the call to StyleElement.
1682
1683 2011-06-01  Levi Weintraub  <leviw@chromium.org>
1684
1685         Reviewed by Eric Seidel.
1686
1687         Switch paintCustomHighlight to use IntPoint
1688         https://bugs.webkit.org/show_bug.cgi?id=61562
1689
1690         Switching paintCustomHighlight to use an IntPoint for
1691         its paint offset instead of a pair of ints.
1692
1693         No new tests since this is refactoring.
1694
1695         * rendering/InlineTextBox.cpp:
1696         (WebCore::InlineTextBox::paint):
1697         (WebCore::InlineTextBox::paintCustomHighlight):
1698         * rendering/InlineTextBox.h:
1699         * rendering/RenderBox.cpp:
1700         (WebCore::RenderBox::paintCustomHighlight):
1701         * rendering/RenderBox.h:
1702         * rendering/RenderImage.cpp:
1703         (WebCore::RenderImage::paintReplaced):
1704         * rendering/RenderListMarker.cpp:
1705         (WebCore::RenderListMarker::paint):
1706         * rendering/RenderWidget.cpp:
1707         (WebCore::RenderWidget::paint):
1708         * rendering/RootInlineBox.cpp:
1709         (WebCore::RootInlineBox::paintCustomHighlight):
1710         (WebCore::RootInlineBox::paint):
1711         * rendering/RootInlineBox.h:
1712
1713 2011-06-01  Emil A Eklund  <eae@chromium.org>
1714
1715         Reviewed by Eric Seidel.
1716
1717         Switch MouseRelatedEvent to use IntPoint
1718         https://bugs.webkit.org/show_bug.cgi?id=61574
1719
1720         Covered by existing tests.
1721
1722         * dom/MouseEvent.cpp:
1723         (WebCore::MouseEvent::MouseEvent):
1724         (WebCore::MouseEvent::initMouseEvent):
1725         (WebCore::SimulatedMouseEvent::SimulatedMouseEvent):
1726         * dom/MouseRelatedEvent.cpp:
1727         (WebCore::MouseRelatedEvent::MouseRelatedEvent):
1728         (WebCore::contentsScrollOffset):
1729         (WebCore::MouseRelatedEvent::initCoordinates):
1730         (WebCore::MouseRelatedEvent::computeRelativePosition):
1731         (WebCore::MouseRelatedEvent::layerX):
1732         (WebCore::MouseRelatedEvent::layerY):
1733         (WebCore::MouseRelatedEvent::offsetX):
1734         (WebCore::MouseRelatedEvent::offsetY):
1735         (WebCore::MouseRelatedEvent::pageX):
1736         (WebCore::MouseRelatedEvent::pageY):
1737         (WebCore::MouseRelatedEvent::pageLocation):
1738         (WebCore::MouseRelatedEvent::x):
1739         (WebCore::MouseRelatedEvent::y):
1740         * dom/MouseRelatedEvent.h:
1741         (WebCore::MouseRelatedEvent::screenX):
1742         (WebCore::MouseRelatedEvent::screenY):
1743         (WebCore::MouseRelatedEvent::screenLocation):
1744         (WebCore::MouseRelatedEvent::clientX):
1745         (WebCore::MouseRelatedEvent::clientY):
1746         (WebCore::MouseRelatedEvent::clientLocation):
1747         (WebCore::MouseRelatedEvent::absoluteLocation):
1748         * dom/TouchEvent.cpp:
1749         (WebCore::TouchEvent::TouchEvent):
1750         (WebCore::TouchEvent::initTouchEvent):
1751         * dom/WheelEvent.cpp:
1752         (WebCore::WheelEvent::WheelEvent):
1753         (WebCore::WheelEvent::initWheelEvent):
1754         (WebCore::WheelEventDispatchMediator::WheelEventDispatchMediator):
1755         * dom/WheelEvent.h:
1756         (WebCore::WheelEvent::create):
1757         (WebCore::WheelEvent::wheelDelta):
1758         (WebCore::WheelEvent::wheelDeltaX):
1759         (WebCore::WheelEvent::wheelDeltaY):
1760         (WebCore::WheelEvent::rawDeltaX):
1761         (WebCore::WheelEvent::rawDeltaY):
1762         (WebCore::WheelEvent::isHorizontal):
1763         * platform/graphics/IntPoint.h:
1764         (WebCore::IntPoint::scale):
1765
1766 2011-06-01  Levi Weintraub  <leviw@chromium.org>
1767
1768         Reviewed by Eric Seidel.
1769
1770         Switch paintOverflowControls to use IntPoint
1771         https://bugs.webkit.org/show_bug.cgi?id=61884
1772
1773         Switching paintOverflowControls to use an IntPoint instead of a pair of ints.
1774
1775         No new tests since this is simple refactoring.
1776
1777         * rendering/RenderBlock.cpp:
1778         (WebCore::RenderBlock::paint):
1779         * rendering/RenderLayer.cpp:
1780         (WebCore::RenderLayer::paintOverflowControls):
1781         (WebCore::RenderLayer::paintLayer):
1782         * rendering/RenderLayer.h:
1783         * rendering/RenderLayerBacking.cpp:
1784         (WebCore::RenderLayerBacking::paintIntoLayer):
1785
1786 2011-06-01  Abhishek Arya  <inferno@chromium.org>
1787
1788         Reviewed by Alexey Proskuryakov.
1789
1790         Fix setting of document.body
1791         https://bugs.webkit.org/show_bug.cgi?id=60831
1792
1793         1. Only allowing setting to an element if it has a body tag.
1794         2. If element is from another document, import it.
1795
1796         Test: fast/dom/document-set-body.html
1797
1798         * dom/Document.cpp:
1799         (WebCore::Document::setBody):
1800
1801 2011-06-01  Chris Fleizach  <cfleizach@apple.com>
1802
1803         Reviewed by Darin Adler.
1804
1805         Safari always crashes on http://bbc.co.uk when VoiceOver enabled
1806         https://bugs.webkit.org/show_bug.cgi?id=61886
1807
1808         This crash can happen on webpages that remove an element from the DOM when the element receives focus.
1809         When AppKit goes to post a notification to inform VoiceOver the focus has changed, it asks for the AXFocusedUIElement.
1810         However by posting that notification, a render tree update is performed. This causes the element to disappear, but
1811         AppKit still has a handle to it and continues to try to reference it. When the autorelease pool pops, the reference goes bad.
1812
1813         To fix, the root element, the AccessibilityScrollView, needs to implement updateBackingStore(), otherwise this method 
1814         will not be called in time.
1815
1816         No test could be created because to cause it depends on an internal AppKit mechanism
1817         that is only triggered remotely through the accessibility runtime.
1818
1819         * accessibility/AccessibilityObject.cpp:
1820         (WebCore::AccessibilityObject::updateBackingStore):
1821         * accessibility/AccessibilityObject.h:
1822         * accessibility/AccessibilityRenderObject.cpp:
1823         * accessibility/AccessibilityRenderObject.h:
1824
1825 2011-06-01  David Carson  <dacarson@apple.com>
1826
1827         Reviewed by Antti Koivisto.
1828
1829         https://bugs.webkit.org/show_bug.cgi?id=61831
1830         If width and height of an iframe is fixed and should not be visible, then
1831         it shouldn't be flattened.
1832
1833         Test: fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html
1834
1835         * rendering/RenderIFrame.cpp:
1836         (WebCore::RenderIFrame::flattenFrame): add a check for a zero width or height
1837
1838 2011-06-01  Daniel Cheng  <dcheng@chromium.org>
1839
1840         Reviewed by Tony Chang.
1841
1842         [chromium] Use correct file name for dragging out images.
1843         https://bugs.webkit.org/show_bug.cgi?id=24887
1844
1845         We try to guess an appropriate filename when dragging out images. In order, we try to use:
1846         - The filename suggested in the HTTP header.
1847         - The last path component of the source URL.
1848         - The alt text.
1849         This matches the behavior of the other WebKit ports.
1850
1851         Test: fast/events/drag-image-filename.html
1852
1853         * platform/chromium/ClipboardChromium.cpp:
1854         (WebCore::writeImageToDataObject):
1855         * platform/chromium/ClipboardChromiumMac.cpp:
1856         (WebCore::isInvalidFileCharacter):
1857         (WebCore::ClipboardChromium::validateFileName):
1858
1859 2011-06-01  Levi Weintraub  <leviw@chromium.org>
1860
1861         Reviewed by Eric Seidel.
1862
1863         Text is scaled in a stair-step pattern
1864         https://bugs.webkit.org/show_bug.cgi?id=60317
1865
1866         Stop scaling the specified font to the actual on-screen value when font-rendering: 
1867         geometricPrecision is specified, but instead scale the graphics context. This allows
1868         us to scale text up and down smoothly.
1869
1870         Test: svg/text/scaling-font-with-geometric-precision.html
1871
1872         * rendering/svg/RenderSVGInlineText.cpp:
1873         (WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):
1874
1875 2011-06-01  Levi Weintraub  <leviw@chromium.org>
1876
1877         Reviewed by Eric Seidel.
1878
1879         Switch paintResizer to use IntPoint
1880         https://bugs.webkit.org/show_bug.cgi?id=61883
1881
1882         Switch paintResizer to take an IntPoint instead of a pair of ints.
1883
1884         No new tests as this is simple refactoring.
1885
1886         * rendering/RenderLayer.cpp:
1887         (WebCore::RenderLayer::paintOverflowControls):
1888         (WebCore::RenderLayer::paintResizer):
1889         * rendering/RenderLayer.h:
1890         * rendering/RenderLayerBacking.cpp:
1891         (WebCore::RenderLayerBacking::paintContents):
1892
1893 2011-06-01  Jer Noble  <jer.noble@apple.com>
1894
1895         Reviewed by Darin Adler.
1896
1897         Page layout messed up after exiting full screen at Apple trailers page
1898         https://bugs.webkit.org/show_bug.cgi?id=61755
1899         <rdar://problem/9525277>
1900
1901         Test: fullscreen/full-screen-zIndex-after.html
1902
1903         Fix the incomplete implementation of r87660. Make parameters to
1904         setContainsFullScreenElementRecursively() in webkitWillExitFullScreenForElement() match those
1905         in webkitWillEnterFullScreenForElement(), so the ancestors' flags do not become
1906         inconsistent..
1907
1908         * dom/Document.cpp:
1909         (WebCore::Document::webkitWillExitFullScreenForElement):
1910
1911 2011-06-01  Levi Weintraub  <leviw@chromium.org>
1912
1913         Reviewed by Eric Seidel.
1914
1915         Switch paintScrollCorner to use IntPoint
1916         https://bugs.webkit.org/show_bug.cgi?id=61874
1917
1918         Changing paintScrollCorner to take an IntPoint representing the paint
1919         offset instead of a pair of ints.
1920
1921         No new tests as this is simple refactoring.
1922
1923         * rendering/RenderLayer.cpp:
1924         (WebCore::RenderLayer::paintOverflowControls):
1925         (WebCore::RenderLayer::paintScrollCorner):
1926         * rendering/RenderLayer.h:
1927         * rendering/RenderLayerBacking.cpp:
1928         (WebCore::RenderLayerBacking::paintContents):
1929
1930 2011-06-01  Kenneth Russell  <kbr@google.com>
1931
1932         Reviewed by Nate Chapin.
1933
1934         [V8] Optimize fetches of indexed properties in custom bindings
1935         https://bugs.webkit.org/show_bug.cgi?id=61821
1936
1937         Avoid allocating garbage in affected custom bindings. This speeds
1938         up one test case by at least a factor of two. No new tests;
1939         covered by existing layout tests (typed array and otherwise).
1940
1941         * bindings/v8/custom/V8ArrayBufferViewCustom.h:
1942         (WebCore::constructWebGLArray):
1943         (WebCore::setWebGLArrayHelper):
1944         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
1945         (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
1946         * bindings/v8/custom/V8MessagePortCustom.cpp:
1947         (WebCore::getMessagePortArray):
1948         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
1949         (WebCore::jsArrayToFloatArray):
1950         (WebCore::jsArrayToIntArray):
1951
1952 2011-06-01  Andras Becsi  <abecsi@webkit.org>
1953
1954         Reviewed by Csaba Osztrogonác.
1955
1956         [Qt] Fix the Phonon build when logging is disabled
1957         https://bugs.webkit.org/show_bug.cgi?id=61869
1958
1959         No new tests needed.
1960
1961         * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: Add missing guards.
1962         (WebCore::MediaPlayerPrivatePhonon::networkState):
1963         (WebCore::MediaPlayerPrivatePhonon::readyState):
1964         (WebCore::MediaPlayerPrivatePhonon::updateStates):
1965         (WebCore::MediaPlayerPrivatePhonon::stateChanged):
1966
1967 2011-06-01  Abhishek Arya  <inferno@chromium.org>
1968
1969         Reviewed by Antti Koivisto.
1970
1971         Do not use the pushed style selector if it is not equal to the
1972         parent document's style selector. It usually means that it is
1973         in a bad state, e.g. already cleared.
1974         https://bugs.webkit.org/show_bug.cgi?id=61737
1975
1976         * dom/Element.cpp:
1977         (WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
1978
1979 2011-06-01  Levi Weintraub  <leviw@chromium.org>
1980
1981         Reviewed by Eric Seidel.
1982
1983         Switch RenderLineBoxList intersection functions to use IntPoint
1984         https://bugs.webkit.org/show_bug.cgi?id=61794
1985
1986         Switching rangeIntersectsRect, anyLineIntersectsRect, and lineIntersectsDirtyRect
1987         to take IntPoint instead of a tx/ty to represent the offset to be applied match
1988         the rect and lines' coordinates.
1989
1990         No new tests since this is merely refactoring.
1991
1992         * rendering/RenderLineBoxList.cpp:
1993         (WebCore::RenderLineBoxList::rangeIntersectsRect):
1994         (WebCore::RenderLineBoxList::anyLineIntersectsRect):
1995         (WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
1996         (WebCore::RenderLineBoxList::paint):
1997         (WebCore::RenderLineBoxList::hitTest):
1998         * rendering/RenderLineBoxList.h:
1999
2000 2011-05-19  Adrienne Walker  <enne@google.com>
2001
2002         Reviewed by James Robinson.
2003
2004         [chromium] Don't split long, narrow layers into multiple tiles.
2005         https://bugs.webkit.org/show_bug.cgi?id=60821
2006
2007         This changes the heuristic for when we tile layers to be less bad
2008         about wasting texture space.  Long, narrow layers that are tiled with
2009         a large tile size waste texture space.  Now layers are only tiled if
2010         they are above 512px in one dimension and extend into a second tile in
2011         the other.  If they are not tiled, their layer texture will exactly
2012         fit their layer bounds.  In particular, this will help scrollbars.
2013
2014         * platform/graphics/chromium/ContentLayerChromium.cpp:
2015         (WebCore::ContentLayerChromium::updateLayerSize):
2016         * platform/graphics/chromium/LayerRendererChromium.h:
2017         (WebCore::LayerRendererChromium::maxTextureSize):
2018
2019 2011-06-01  Cary Clark  <caryclark@google.com>
2020
2021         Reviewed by Eric Seidel.
2022
2023         Ready Chromium port for Skia on Mac
2024         https://bugs.webkit.org/show_bug.cgi?id=61800
2025
2026         Skia on Mac is not enabled. The executing
2027         code is unchanged, so there are no new tests.
2028
2029         * platform/chromium/DragImageRef.h:
2030         Use Skia for DragImageRef instead of CG.
2031
2032         * platform/chromium/ScrollbarThemeChromiumMac.mm:
2033         (WebCore::ScrollbarThemeChromiumMac::paint):
2034         Get the total matrix from Skia for the scrollbar.
2035         Convert the SkCanvas into a CGContext to draw.
2036
2037         * platform/chromium/ThemeChromiumMac.mm:
2038         (WebCore::paintStepper):
2039         Ditto.
2040
2041 2011-06-01  Yury Semikhatsky  <yurys@chromium.org>
2042
2043         Reviewed by Pavel Feldman.
2044
2045         Web Inspector: allow opening inspector for existing workers
2046         https://bugs.webkit.org/show_bug.cgi?id=61853
2047
2048         Added sidebar pane with a list of all workers. Each worker has a check box
2049         that allows opening inspector for the worker.
2050
2051         * inspector/Inspector.json:
2052         * inspector/InspectorInstrumentation.cpp:
2053         (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
2054         * inspector/InspectorInstrumentation.h:
2055         (WebCore::InspectorInstrumentation::didStartWorkerContext):
2056         * inspector/InspectorWorkerAgent.cpp:
2057         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
2058         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
2059         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::connectToWorkerContext):
2060         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::disconnectFromWorkerContext):
2061         (WebCore::InspectorWorkerAgent::clearFrontend):
2062         (WebCore::InspectorWorkerAgent::connectToWorker):
2063         (WebCore::InspectorWorkerAgent::disconnectFromWorker):
2064         (WebCore::InspectorWorkerAgent::didStartWorkerContext):
2065         * inspector/InspectorWorkerAgent.h:
2066         * inspector/front-end/ScriptsPanel.js:
2067         (WebInspector.ScriptsPanel):
2068         * inspector/front-end/Settings.js:
2069         * inspector/front-end/WorkerManager.js:
2070         (WebInspector.WorkerManager):
2071         (WebInspector.WorkerManager.prototype._workerCreated):
2072         (WebInspector.WorkerManager.prototype._sendMessageToWorkerInspector):
2073         (WebInspector.WorkerManager.prototype.openWorkerInspector):
2074         (WebInspector.WorkerManager.prototype.closeWorkerInspector):
2075         (WebInspector.WorkerManager.prototype._workerInspectorClosing):
2076         (WebInspector.WorkerMessageForwarder):
2077         (WebInspector.WorkerMessageForwarder.prototype.workerCreated):
2078         (WebInspector.WorkerMessageForwarder.prototype.dispatchMessageFromWorker):
2079         * inspector/front-end/WorkersSidebarPane.js:
2080         (WebInspector.WorkersSidebarPane):
2081         (WebInspector.WorkersSidebarPane.prototype.addWorker):
2082         (WebInspector.WorkerListSidebarPane):
2083         (WebInspector.WorkerListSidebarPane.prototype._workerAdded):
2084         (WebInspector.WorkerListSidebarPane.prototype._workerRemoved):
2085         (WebInspector.WorkerListSidebarPane.prototype._workerInspectorClosed):
2086         (WebInspector.WorkerListSidebarPane.prototype._addWorker):
2087         (WebInspector.WorkerListSidebarPane.prototype._createCheckbox):
2088         (WebInspector.WorkerListSidebarPane.prototype._workerItemClicked):
2089         * workers/Worker.cpp:
2090         (WebCore::Worker::notifyFinished):
2091
2092 2011-06-01  Shishir Agrawal  <shishir@chromium.org>
2093
2094         Reviewed by Tony Gentilcore.
2095
2096         Renaming the Page Visibility attributes as per the modified spec draft.
2097         https://bugs.webkit.org/show_bug.cgi?id=61825
2098
2099         Spec draft:
2100         http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html
2101
2102         - Event needs to be webkitVisibilityChange from webkitVisibilityStateChange
2103         - The attribute webkitIsVisible needs to change to webkitHidden
2104
2105         * dom/Document.cpp:
2106         (WebCore::Document::webkitHidden):
2107         (WebCore::Document::dispatchVisibilityStateChangeEvent):
2108         * dom/Document.h:
2109         * dom/Document.idl:
2110         * dom/EventNames.h:
2111
2112 2011-06-01  Nikolas Zimmermann  <nzimmermann@rim.com>
2113
2114         Reviewed by Rob Buis.
2115
2116         Remove duplicated code in various computeReplacedLogical*() functions
2117         https://bugs.webkit.org/show_bug.cgi?id=61860
2118
2119         Centralize this calculation in RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth:
2120         int minLogicalWidth = computeReplacedLogicalWidthUsing(style()->logicalMinWidth());
2121         int maxLogicalWidth = !includeMaxWidth || style()->logicalMaxWidth().isUndefined() ? logicalWidth : computeReplacedLogicalWidthUsing(style()->logicalMaxWidth());
2122         return max(minLogicalWidth, min(logicalWidth, maxLogicalWidth));
2123
2124         Centralize this calculation in RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight:
2125         int minLogicalHeight = computeReplacedLogicalHeightUsing(style()->logicalMinHeight());
2126         int maxLogicalHeight = style()->logicalMaxHeight().isUndefined() ? logicalHeight : computeReplacedLogicalHeightUsing(style()->logicalMaxHeight());
2127         return max(minLogicalHeight, min(logicalHeight, maxLogicalHeight));
2128
2129         Use the new helper methods where possible, deduplicating lots of code.
2130
2131         * rendering/RenderBox.cpp:
2132         (WebCore::RenderBox::computeReplacedLogicalWidth):
2133         (WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth):
2134         (WebCore::RenderBox::computeReplacedLogicalHeight):
2135         (WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight):
2136         * rendering/RenderBox.h:
2137         * rendering/RenderImage.cpp:
2138         (WebCore::RenderImage::computeReplacedLogicalWidth):
2139         (WebCore::RenderImage::computeReplacedLogicalHeight):
2140         * rendering/RenderPart.cpp:
2141         (WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth):
2142         (WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight):
2143         (WebCore::RenderPart::computeReplacedLogicalWidth):
2144         (WebCore::RenderPart::computeReplacedLogicalHeight):
2145         * rendering/RenderPart.h:
2146         * rendering/RenderReplaced.cpp:
2147         (WebCore::RenderReplaced::computeReplacedLogicalWidth):
2148         (WebCore::RenderReplaced::computeReplacedLogicalHeight):
2149         * rendering/svg/RenderSVGRoot.cpp:
2150         (WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
2151         (WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
2152
2153 2011-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2154
2155         Unreviewed, rolling out r87788.
2156         http://trac.webkit.org/changeset/87788
2157         https://bugs.webkit.org/show_bug.cgi?id=61856
2158
2159         breaks windows chromium canary (Requested by jknotten on
2160         #webkit).
2161
2162         * loader/archive/mhtml/MHTMLArchive.cpp:
2163         * loader/archive/mhtml/MHTMLArchive.h:
2164         * page/PageSerializer.cpp:
2165         (WebCore::PageSerializer::serializeFrame):
2166         (WebCore::PageSerializer::serializeCSSStyleSheet):
2167         * platform/SharedBuffer.cpp:
2168         * platform/SharedBuffer.h:
2169
2170 2011-06-01  Joseph Pecoraro  <joepeck@webkit.org>
2171
2172         Reviewed by Pavel Feldman.
2173
2174         Web Inspector: [JSC] JSLock ASSERTs Seen Under eventListenerHandlerBody
2175         https://bugs.webkit.org/show_bug.cgi?id=61835
2176
2177         Add a JSLock call before possible allocations in jsFunction and toString.
2178
2179         * bindings/js/ScriptEventListener.cpp:
2180         (WebCore::eventListenerHandlerBody):
2181
2182 2011-06-01  Jay Civelli  <jcivelli@chromium.org>
2183
2184         Reviewed by Adam Barth.
2185
2186         Adding MHTML generation support to MHTMLArchive.
2187         https://bugs.webkit.org/show_bug.cgi?id=7169
2188
2189         * loader/archive/mhtml/MHTMLArchive.cpp:
2190         (WebCore::generateRandomBoundary):
2191         (WebCore::replaceNonPrintableCharacters):
2192         (WebCore::MHTMLArchive::generateMHTMLData):
2193         * loader/archive/mhtml/MHTMLArchive.h:
2194         * page/PageSerializer.cpp:
2195         (WebCore::PageSerializer::serializeFrame):
2196         (WebCore::PageSerializer::serializeCSSStyleSheet):
2197         * platform/SharedBuffer.cpp:
2198         (WebCore::SharedBuffer::append):
2199         * platform/SharedBuffer.h:
2200
2201 2011-06-01  Dimitri Glazkov  <dglazkov@chromium.org>
2202
2203         Reviewed by Kent Tamura.
2204
2205         Remove ShadowElement and compact remaining used bits into RenderFileUploadControl.
2206         https://bugs.webkit.org/show_bug.cgi?id=61816
2207
2208         This is a near-mechanical move-and-rename of ShadowElement, which is now only
2209         used by input[type=file]. Next step -- switch it over to new shadow DOM.
2210
2211         Refactoring, no change in behavior.
2212
2213         * CMakeLists.txt: Removed ShadowElement.cpp and ShadowElement.h.
2214         * GNUmakefile.list.am: Ditto.
2215         * WebCore.gypi: Ditto.
2216         * WebCore.pro: Ditto.
2217         * WebCore/WebCore.vcproj/WebCore.vcproj: Ditto.
2218         * WebCore.xcodeproj/project.pbxproj: Ditto.
2219         * WebCore/rendering/RenderingAllInOne.cpp: Ditto.
2220         * rendering/RenderFileUploadControl.cpp:
2221         (WebCore::UploadButton::create): Moved from ShadowElement, renamed as UploadButton.
2222         (WebCore::UploadButton::detach): Ditto.
2223         (WebCore::UploadButton::UploadButton): Ditto.
2224         (WebCore::RenderFileUploadControl::updateFromElement): Changed to use UploadButton.
2225         * rendering/RenderMeter.cpp: Removed ShadowElement.h include, which is no longer used.
2226         * rendering/RenderProgress.cpp: Ditto.
2227         * rendering/ShadowElement.cpp: Removed.
2228         * rendering/ShadowElement.h: Removed.
2229
2230 2011-06-01  Nikolas Zimmermann  <nzimmermann@rim.com>
2231
2232         Reviewed by Rob Buis.
2233
2234         SVG fails all 3 of Hixie's CSS intrinsic sizing tests
2235         https://bugs.webkit.org/show_bug.cgi?id=15473
2236
2237         Hixies CSS intrinsic sizing tests cover percentage sizes specified on the target SVG document as width/height attributes
2238         and using width: auto / height: auto on the <object> that hosts the SVG document. Take percentage sizes of the outermost
2239         SVGs width/height attributes into account when determining the intrinsic size of the <object>.
2240
2241         Added several other testcases demonstrating several scenarios. All tests work exactly the same in WebKit and Firefox now.
2242         The *on-target-svg-absolute.xhtml tests look equal to WebKit/FF but Opera fails them, likely a relict of the different
2243         interpretation of the intrinsic size of a SVG document in SVG Tiny 1.2.
2244
2245         Tests: svg/custom/object-sizing-height-50p-on-target-svg-absolute.xhtml
2246                svg/custom/object-sizing-height-50p-on-target-svg.xhtml
2247                svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute.xhtml
2248                svg/custom/object-sizing-width-50p-height-50p-on-target-svg.xhtml
2249                svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml
2250                svg/custom/object-sizing-width-50p-height-75p-on-target-svg.xhtml
2251                svg/custom/object-sizing-width-50p-on-target-svg-absolute.xhtml
2252                svg/custom/object-sizing-width-50p-on-target-svg.xhtml
2253                svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute.xhtml
2254                svg/custom/object-sizing-width-75p-height-50p-on-target-svg.xhtml
2255                svg/hixie/intrinsic/001.html
2256                svg/hixie/intrinsic/002.html
2257                svg/hixie/intrinsic/003.html
2258
2259         * rendering/RenderPart.cpp:
2260         (WebCore::RenderPart::computeReplacedLogicalWidth):
2261         (WebCore::RenderPart::computeReplacedLogicalHeight):
2262         * rendering/svg/RenderSVGRoot.cpp:
2263         (WebCore::RenderSVGRoot::computeIntrinsicRatio):
2264         * rendering/svg/RenderSVGRoot.h:
2265
2266 2011-05-31  Tonis Tiigi  <tonistiigi@gmail.com>
2267
2268         Reviewed by Pavel Feldman.
2269
2270         Web Inspector: Timeline panel improvements for managing current selection
2271         https://bugs.webkit.org/show_bug.cgi?id=61468
2272
2273         Enables X-axis dragging of the selected area.
2274         Double click zoom-out.
2275         Fixes slightly wrong selection area position.
2276
2277         * inspector/front-end/TimelineOverviewPane.js:
2278         (WebInspector.TimelineOverviewPane):
2279         (WebInspector.TimelineOverviewPane.prototype._dragWindow):
2280         (WebInspector.TimelineOverviewPane.prototype._endWindowSelectorDragging):
2281         (WebInspector.TimelineOverviewPane.prototype._resizeWindowRight):
2282         (WebInspector.TimelineOverviewPane.prototype._resizeWindowMaximum):
2283         (WebInspector.TimelineOverviewPane.prototype.scrollWindow):
2284         (WebInspector.TimelineOverviewPane.prototype._createTimelineCategoryStatusBarCheckbox):
2285         * inspector/front-end/TimelinePanel.js:
2286         (WebInspector.TimelinePanel):
2287
2288 2011-05-31  Keishi Hattori  <keishi@webkit.org>
2289
2290         Reviewed by Kent Tamura.
2291
2292         Fix to enable page scroll of select element
2293         https://bugs.webkit.org/show_bug.cgi?id=53628
2294
2295         Manual test: select-page-scroll.html
2296
2297         * manual-tests/select-page-scroll.html: Added.
2298         * rendering/RenderListBox.cpp:
2299         (WebCore::RenderListBox::computeLogicalHeight): Fix min to max.
2300
2301 2011-05-31  Yong Li  <yoli@rim.com>
2302
2303         Reviewed by Eric Seidel.
2304
2305         https://bugs.webkit.org/show_bug.cgi?id=54807
2306         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
2307         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
2308         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
2309         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
2310         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
2311         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
2312         rule we should have in order to make our code independent from compilers and compiler flags.
2313
2314         No new test added because this change is not known to fix any issue.
2315
2316         * css/CSSPrimitiveValue.h:
2317         * css/CSSProperty.h:
2318         * rendering/InlineBox.h:
2319         * rendering/RenderBlock.h:
2320
2321 2011-05-31  Hironori Bono  <hbono@chromium.org>
2322
2323         Reviewed by Eric Seidel.
2324
2325         Send an input event when we change the text direction.
2326         https://bugs.webkit.org/show_bug.cgi?id=50952
2327
2328         Both Safari and Chrome call Editor::setBaseWritingDirection() to change
2329         the text direction of an editable element with their UIs. This change
2330         calls dispatchInputEvent() to send an input event when the function
2331         actually changes the "dir" attribute so we can send an input event as
2332         written in the HTML5 spec.
2333
2334         Test: fast/html/set-text-direction.html
2335
2336         * editing/Editor.cpp:
2337         (WebCore::Editor::setBaseWritingDirection):
2338
2339 2011-05-31  Jer Noble  <jer.noble@apple.com>
2340
2341         Reviewed by Darin Adler.
2342
2343         Flash of black at the end of full screen transition at apple.com product videos
2344         https://bugs.webkit.org/show_bug.cgi?id=61756
2345
2346         Added two new entries to the WebCore exports list.
2347
2348         * WebCore.exp.in:
2349
2350 2011-05-31  Rafael Brandao  <rafael.lobo@openbossa.org>
2351
2352         Reviewed by Andreas Kling.
2353
2354         [Qt] tst_QWebFrame::render() failing
2355         https://bugs.webkit.org/show_bug.cgi?id=60893
2356
2357         Due a problem on QPicture (http://bugreports.qt.nokia.com/browse/QTBUG-19496),
2358         this test was calculating the final geometry incorrectly. As the order between
2359         a translate and a draw operation could be relevant for it, but not for the
2360         final rendered result, they were changed on ScrollbarThemeQt::paint.
2361
2362         * platform/qt/ScrollbarThemeQt.cpp:
2363         (WebCore::ScrollbarThemeQt::paint):
2364
2365 2011-05-27  Adrienne Walker  <enne@google.com>
2366
2367         Reviewed by James Robinson.
2368
2369         [chromium] Fix crash from empty reflections with masks
2370         https://bugs.webkit.org/show_bug.cgi?id=61654
2371
2372         Change the iteration for updateCompositorResources to match that being
2373         done in the paint and draw steps.  This mismatch of iteration style
2374         was causing layers with replica masks to correctly get skipped while
2375         painting but not get skipped during texture upload.
2376
2377         Test: compositing/reflections/empty-reflection-with-mask.html
2378
2379         * platform/graphics/chromium/LayerRendererChromium.cpp:
2380         (WebCore::LayerRendererChromium::updateLayers):
2381         (WebCore::LayerRendererChromium::updateCompositorResources):
2382         * platform/graphics/chromium/LayerRendererChromium.h:
2383
2384 2011-05-31  B.J. Wever  <skylined@chromium.org>
2385
2386         Reviewed by Adam Barth.
2387
2388         requestFileSystem and resolveLocalFileSystemURI are not checking if
2389         errorCallback is NULL before scheduling a callback on error.
2390         https://bugs.webkit.org/show_bug.cgi?id=49539
2391
2392         Test: fast/filesystem/filesystem-no-callback-null-ptr-crash.html
2393
2394         * fileapi/DOMFileSystem.cpp:
2395         (WebCore::DOMFileSystem::scheduleCallback): Only call callback if
2396           one is supplied.
2397
2398 2011-05-31  Brady Eidson  <beidson@apple.com>
2399
2400         Reviewed by Darin Adler.
2401
2402         Another swipe at resolving <rdar://problem/9125145> and https://bugs.webkit.org/show_bug.cgi?id=61494
2403         
2404         Re-land http://trac.webkit.org/changeset/87566 with invalid ASSERTs removed.
2405
2406         No new tests. No change in behavior.
2407
2408         Instead of storing the DocumentLoader at construction and never changing it,
2409         always calculate it based on the FrameLoader's current DocumentLoader:
2410         * dom/Document.cpp:
2411         (WebCore::Document::Document):
2412         (WebCore::Document::suggestedMIMEType):
2413         (WebCore::Document::lastModified):
2414         (WebCore::Document::initSecurityContext):
2415         (WebCore::Document::updateURLForPushOrReplaceState):
2416         (WebCore::Document::loader):
2417         * dom/Document.h:
2418
2419         Null-check or ASSERT that the DocumentLoader exists (or both) depending on the scenario:
2420         * bindings/ScriptControllerBase.cpp:
2421         (WebCore::ScriptController::executeIfJavaScriptURL):
2422         * html/MediaDocument.cpp:
2423         (WebCore::MediaDocument::replaceMediaElementTimerFired):
2424         * html/PluginDocument.cpp:
2425         (WebCore::PluginDocumentParser::createDocumentStructure):
2426         * platform/mac/HTMLConverter.mm:
2427         (fileWrapperForElement):
2428
2429         * WebCore.exp.in:
2430
2431 2011-05-31  Levi Weintraub  <leviw@chromium.org>
2432
2433         Reviewed by Simon Fraser.
2434
2435         Change InlineBox::paint and its overloaded variants to use IntPoint
2436         https://bugs.webkit.org/show_bug.cgi?id=61804
2437
2438         Changing InlineBox::paint, its 7 overloaded variants, and RootInlineBox::paintEllipsisBox
2439         to use IntPoint for their paint offset instead of a pair of ints.
2440
2441         No new tests since this is just a refactoring.
2442
2443         * rendering/EllipsisBox.cpp:
2444         (WebCore::EllipsisBox::paint):
2445         * rendering/EllipsisBox.h:
2446         * rendering/InlineBox.cpp:
2447         (WebCore::InlineBox::paint):
2448         * rendering/InlineBox.h:
2449         * rendering/InlineFlowBox.cpp:
2450         (WebCore::InlineFlowBox::paint):
2451         * rendering/InlineFlowBox.h:
2452         * rendering/InlineTextBox.cpp:
2453         (WebCore::InlineTextBox::paint):
2454         * rendering/InlineTextBox.h:
2455         * rendering/RenderBlock.cpp:
2456         (WebCore::RenderBlock::paintEllipsisBoxes):
2457         * rendering/RenderBoxModelObject.cpp:
2458         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
2459         * rendering/RenderLineBoxList.cpp:
2460         (WebCore::RenderLineBoxList::paint):
2461         * rendering/RootInlineBox.cpp:
2462         (WebCore::RootInlineBox::paintEllipsisBox):
2463         (WebCore::RootInlineBox::paint):
2464         * rendering/RootInlineBox.h:
2465         * rendering/svg/SVGInlineFlowBox.cpp:
2466         (WebCore::SVGInlineFlowBox::paint):
2467         * rendering/svg/SVGInlineFlowBox.h:
2468         * rendering/svg/SVGInlineTextBox.cpp:
2469         (WebCore::SVGInlineTextBox::paint):
2470         * rendering/svg/SVGInlineTextBox.h:
2471         * rendering/svg/SVGRootInlineBox.cpp:
2472         (WebCore::SVGRootInlineBox::paint):
2473         * rendering/svg/SVGRootInlineBox.h:
2474
2475 2011-05-31  James Robinson  <jamesr@chromium.org>
2476
2477         Reviewed by Kenneth Russell.
2478
2479         [chromium] Clear out LayerChromium's m_ccLayerImpl ptr on CCLayerImpl destruction
2480         https://bugs.webkit.org/show_bug.cgi?id=61593
2481
2482         Whenever a CCLayerImpl is being destroyed, clear out its owner's m_ccLayerImpl pointer.
2483         This is extremely defensive and not strictly necessary, but not harmful either.
2484
2485         * platform/graphics/chromium/LayerChromium.h:
2486         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
2487         (WebCore::CCLayerImpl::~CCLayerImpl):
2488
2489 2011-05-31  Stephen White  <senorblanco@chromium.org>
2490
2491         Unreviewed; build fix.
2492
2493         Silence some warnings on the Safari/Mac release build.
2494
2495         * platform/graphics/gpu/TilingData.h:
2496         (WebCore::TilingData::assertTile):
2497
2498 2011-05-31  Justin Novosad  <junov@chromium.org>
2499
2500         Reviewed by Stephen White.
2501
2502         [Chromium] Build fails when ACCELERATED_2D_CANVAS is disabled
2503         https://bugs.webkit.org/show_bug.cgi?id=61790
2504         Changing the build guards in these two files that are required
2505         by the accelerated compositing feature.
2506
2507         * platform/graphics/gpu/LoopBlinnMathUtils.cpp:
2508         * platform/graphics/gpu/TilingData.cpp:
2509
2510 2011-05-31  Justin Novosad  <junov@chromium.org>
2511
2512         Reviewed by Stephen White.
2513
2514         [Chromium] Build fails when ACCELERATED_2D_CANVAS is disabled
2515         https://bugs.webkit.org/show_bug.cgi?id=61790
2516         Changing the build guards in these two files that are required
2517         by the accelerated compositing feature.
2518
2519         * platform/graphics/gpu/LoopBlinnMathUtils.cpp:
2520         * platform/graphics/gpu/TilingData.cpp:
2521
2522 2011-05-31  Rob Buis  <rbuis@rim.com>
2523
2524         Reviewed by Dirk Schulze.
2525
2526         https://bugs.webkit.org/show_bug.cgi?id=34301
2527         Creating <animateMotion> elements via javascript do not execute
2528
2529         https://bugs.webkit.org/show_bug.cgi?id=17043
2530         SVG missing some .idl files
2531
2532         Add missing idl files.
2533
2534         Test: svg/animations/animate-mpath-insert.html
2535
2536         * CMakeLists.txt:
2537         * CodeGenerators.pri:
2538         * WebCore.gypi:
2539         * WebCore.xcodeproj/project.pbxproj:
2540         * svg/SVGAnimateMotionElement.idl: Added.
2541         * svg/SVGMPathElement.idl: Added.
2542
2543 2011-05-31  Robin Dunn  <robin@alldunn.com>
2544
2545         Reviewed by Kevin Ollivier.
2546
2547         [wx] Implement printing support for wxWidgets 2.9.x and above.
2548         
2549         https://bugs.webkit.org/show_bug.cgi?id=61796
2550
2551         * platform/graphics/GraphicsContext.h:
2552         * platform/graphics/wx/FontWx.cpp:
2553         (WebCore::Font::drawGlyphs):
2554         * platform/graphics/wx/GraphicsContextWx.cpp:
2555         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
2556         (WebCore::GraphicsContext::drawRect):
2557         (WebCore::GraphicsContext::drawLine):
2558         (WebCore::GraphicsContext::drawEllipse):
2559         (WebCore::GraphicsContext::strokeArc):
2560         (WebCore::GraphicsContext::drawConvexPolygon):
2561         (WebCore::GraphicsContext::fillRect):
2562         (WebCore::GraphicsContext::drawLineForText):
2563         (WebCore::GraphicsContext::scale):
2564         (WebCore::GraphicsContext::currentScale):
2565         * platform/wx/wxcode/win/non-kerned-drawing.cpp:
2566         (WebCore::drawTextWithSpacing):
2567
2568 2011-05-31  Joseph Pecoraro  <joepeck@webkit.org>
2569
2570         Reviewed by Pavel Feldman.
2571
2572         Web Inspector: Missing InspectorFrontendHost.saveSessionSetting function
2573         https://bugs.webkit.org/show_bug.cgi?id=61751
2574
2575         Add missing stub function causing an error on load.
2576
2577         * inspector/front-end/InspectorFrontendHostStub.js:
2578         (.WebInspector.InspectorFrontendHostStub.prototype.saveSessionSetting):
2579
2580 2011-05-31  Abhishek Arya  <inferno@chromium.org>
2581
2582         Reviewed by Dimitri Glazkov.
2583
2584         Improve hasMediaControls logic to check that node has
2585         media controls. This can be false when cloning nodes.
2586         https://bugs.webkit.org/show_bug.cgi?id=61765
2587
2588         Test: media/media-controls-clone-crash.html
2589
2590         * dom/Node.h:
2591         (WebCore::Node::isMediaControls):
2592         * html/HTMLMediaElement.cpp:
2593         (WebCore::HTMLMediaElement::mediaControls):
2594         (WebCore::HTMLMediaElement::hasMediaControls):
2595         * html/shadow/MediaControls.h:
2596         (WebCore::MediaControls::isMediaControls):
2597         (WebCore::toMediaControls):
2598
2599 2011-05-31  Xan Lopez  <xlopez@igalia.com>
2600
2601         Reviewed by Martin Robinson.
2602
2603         [GTK] Provide custom DOM bindings methods to check if input/textareas have been edited
2604         https://bugs.webkit.org/show_bug.cgi?id=61791
2605
2606         * bindings/gobject/GNUmakefile.am: add new files.
2607         * bindings/gobject/WebKitDOMCustom.cpp: Added.
2608         (webkit_dom_html_text_area_element_is_edited):
2609         (webkit_dom_html_input_element_is_edited):
2610         * bindings/gobject/WebKitDOMCustom.h: Added.
2611
2612 2011-05-31  Noam Rosenthal  <noam.rosenthal@nokia.com>
2613
2614         Unreviewed build fix for Symbian.
2615         Opt-out Symbian for TextureMapper.
2616
2617         No new tests: build fix.
2618
2619         * WebCore.pri:
2620
2621 2011-05-31  Levi Weintraub  <leviw@chromium.org>
2622
2623         Reviewed by Eric Seidel.
2624
2625         Switch paintFocusRing to IntPoint
2626         https://bugs.webkit.org/show_bug.cgi?id=61580
2627
2628         Switching paintFocusRing to take an IntPoint representing the paint offset
2629         instead of a pair of ints.
2630
2631         No new tests as this is just refactoring.
2632
2633         * rendering/RenderInline.cpp:
2634         (WebCore::RenderInline::paintOutline):
2635         * rendering/RenderObject.cpp:
2636         (WebCore::RenderObject::paintFocusRing):
2637         (WebCore::RenderObject::paintOutline):
2638         * rendering/RenderObject.h:
2639
2640 2011-05-31  Abhishek Arya  <inferno@chromium.org>
2641
2642         Reviewed by Dimitri Glazkov.
2643
2644         Convert raw ptr to RefPtr for documentElement.
2645         https://bugs.webkit.org/show_bug.cgi?id=61688
2646
2647         Test: fast/dom/xml-parser-error-message-crash.svg
2648
2649         * dom/XMLDocumentParser.cpp:
2650         (WebCore::XMLDocumentParser::insertErrorMessageBlock):
2651
2652 2011-05-31  Andreas Kling  <kling@webkit.org>
2653
2654         Reviewed by Antti Koivisto.
2655
2656         Canvas/JSC: Auto-generate overloads for setShadow()
2657         https://bugs.webkit.org/show_bug.cgi?id=61786
2658
2659         Move CanvasRenderingContext2D.setShadow() to auto-generated JSC bindings.
2660
2661         There is a subtle difference to the previous behavior: invalid numbers of
2662         arguments now raise TypeError instead of SyntaxError. This is in accordance
2663         with Web IDL, and matches the existing V8 bindings.
2664
2665         Test: fast/canvas/canvas-overloads-setShadow.html
2666
2667         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
2668         * html/canvas/CanvasRenderingContext2D.idl:
2669
2670 2011-05-31  Andreas Kling  <kling@webkit.org>
2671
2672         Reviewed by Antti Koivisto.
2673
2674         Canvas/JSC: Auto-generate overloads for drawImageFromRect()
2675         https://bugs.webkit.org/show_bug.cgi?id=61709
2676
2677         Move CanvasRenderingContext2D.drawImageFromRect() to auto-generated JSC bindings.
2678         Make it [RequiresAllArguments=Raise] to match the old behavior.
2679         Side effect: calling drawImageFromRect() with zero arguments will now raise
2680         SyntaxError instead of TypeError.
2681
2682         Test: fast/canvas/canvas-overloads-drawImageFromRect.html
2683
2684         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
2685         * html/canvas/CanvasRenderingContext2D.h:
2686         * html/canvas/CanvasRenderingContext2D.idl:
2687
2688 2011-05-31  Andreas Kling  <kling@webkit.org>
2689
2690         Reviewed by Antti Koivisto.
2691
2692         Canvas/JSC: Auto-generate overloads for drawImage()
2693         https://bugs.webkit.org/show_bug.cgi?id=61703
2694
2695         Move CanvasRenderingContext2D.drawImage() to auto-generated JSC bindings.
2696
2697         There is a subtle difference to the previous behavior: invalid numbers of
2698         arguments now raise TypeError instead of SyntaxError. This is in accordance
2699         with Web IDL, and matches the existing V8 bindings.
2700
2701         Test: fast/canvas/canvas-overloads-drawImage.html
2702
2703         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
2704         * html/canvas/CanvasRenderingContext2D.idl:
2705
2706 2011-05-31  Andreas Kling  <kling@webkit.org>
2707
2708         Reviewed by Antti Koivisto.
2709
2710         Canvas/JSC: Auto-generate overloads for strokeRect()
2711         https://bugs.webkit.org/show_bug.cgi?id=61641
2712
2713         Move CanvasRenderingContext2D.setStrokeColor() to auto-generated JSC bindings.
2714
2715         No behavioral change.
2716
2717         Test: fast/canvas/canvas-overloads-strokeRect.html
2718
2719         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
2720         * html/canvas/CanvasRenderingContext2D.idl:
2721
2722 2011-05-31  Andreas Kling  <kling@webkit.org>
2723
2724         Reviewed by Antti Koivisto.
2725
2726         Canvas/JSC: Auto-generate overloads for setFillColor()
2727         https://bugs.webkit.org/show_bug.cgi?id=61635
2728
2729         Move CanvasRenderingContext2D.setStrokeColor() to auto-generated JSC bindings.
2730
2731         There is a subtle difference to the previous behavior: invalid numbers of
2732         arguments now raise TypeError instead of SyntaxError. This is in accordance
2733         with Web IDL, but doesn't matter much anyway since this method is WebKit-only.
2734
2735         Test: fast/canvas/canvas-overloads-setFillColor.html
2736
2737         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
2738         * html/canvas/CanvasRenderingContext2D.idl:
2739
2740 2011-05-31  Andreas Kling  <kling@webkit.org>
2741
2742         Reviewed by Antti Koivisto.
2743
2744         Canvas/JSC: Auto-generate overloads for setStrokeColor()
2745         https://bugs.webkit.org/show_bug.cgi?id=61629
2746
2747         Move CanvasRenderingContext2D.setStrokeColor() to auto-generated JSC bindings.
2748
2749         There is a subtle difference to the previous behavior: invalid numbers of
2750         arguments now raise TypeError instead of SyntaxError. This is in accordance
2751         with Web IDL, but doesn't matter much anyway since this method is WebKit-only.
2752
2753         Test: fast/canvas/canvas-overloads-setStrokeColor.html
2754
2755         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
2756         * html/canvas/CanvasRenderingContext2D.idl:
2757
2758 2011-05-31  Andreas Kling  <kling@webkit.org>
2759
2760         Reviewed by Antti Koivisto.
2761
2762         Canvas/JSC: Auto-generate overloads for strokeText()
2763         https://bugs.webkit.org/show_bug.cgi?id=61626
2764
2765         Move CanvasRenderingContext2D.strokeText() to auto-generated JSC bindings.
2766         Make it [RequiresAllArguments=Raise] to match the old behavior.
2767         This has the side-effect of aligning the behaviors of JSC and V8.
2768
2769         Test: fast/canvas/canvas-overloads-strokeText.html
2770
2771         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
2772         * html/canvas/CanvasRenderingContext2D.idl:
2773
2774 2011-05-31  Andreas Kling  <kling@webkit.org>
2775
2776         Reviewed by Antti Koivisto.
2777
2778         Canvas/JSC: Auto-generate overloads for fillText()
2779         https://bugs.webkit.org/show_bug.cgi?id=61623
2780
2781         Move CanvasRenderingContext2D.fillText() to auto-generated JSC bindings.
2782         Make it [RequiresAllArguments=Raise] to match the old behavior.
2783         This has the side-effect of aligning the behaviors of JSC and V8.
2784
2785         Test: fast/canvas/canvas-overloads-fillText.html
2786
2787         * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
2788         * html/canvas/CanvasRenderingContext2D.idl:
2789
2790 2011-05-31  Yael Aharon  <yael.aharon@nokia.com>
2791
2792         Reviewed by Kenneth Rohde Christiansen.
2793
2794         Frame flattening is broken with nested frames
2795         https://bugs.webkit.org/show_bug.cgi?id=61491
2796
2797         After r77988, when frame flattening is enabled, performPostLayoutTasks() is called on a timer for iframes.
2798         This causes layout of nested iframes to sometimes happen asynchronously, but WebCore expects layout to always finish synchronously.
2799         Added a call to updateWidgetPosition() for cases that performPostLayoutTasks() is now happening asynchronously.
2800
2801         Test: fast/frames/flattening/iframe-flattening-nested.html
2802
2803         * page/FrameView.cpp:
2804         (WebCore::FrameView::layout):
2805
2806 2011-05-31  Tommy Widenflycht  <tommyw@google.com>
2807
2808         Reviewed by Tony Gentilcore.
2809
2810         Fix getUserMedia callback bindings for JSC.
2811         https://bugs.webkit.org/show_bug.cgi?id=60174
2812
2813         This patch initializes the exception code variable to 0.
2814
2815         Test: fast/dom/MediaStream/argument-types.html
2816
2817         * bindings/js/JSNavigatorCustom.cpp:
2818         (WebCore::JSNavigator::webkitGetUserMedia):
2819
2820 2011-05-31  Oleg Romashin  <oleg.romashin@nokia.com>
2821
2822         Reviewed by Benjamin Poulain.
2823
2824         Fix compilation with debug enabled, m_lightSource.type is not valid anymore
2825         https://bugs.webkit.org/show_bug.cgi?id=61719
2826
2827         * platform/graphics/filters/arm/FELightingNEON.h:
2828         (WebCore::FELighting::platformApplyNeon):
2829
2830 2011-05-31  Oliver Varga  <Varga.Oliver@stud.u-szeged.hu>
2831
2832         Reviewed by Nikolas Zimmermann.
2833
2834         Invalid color handling is broken for SVG
2835         https://bugs.webkit.org/show_bug.cgi?id=58531
2836
2837         Fix invalid color fallback handling. If the fill/stroke attributes computed
2838         value leads to a an invalid color, inherit the desired color from the parent
2839         style instead. Matches Opera/FF and SVG 1.1 Second Edition (http://www.w3.org/TR/SVG/).
2840
2841         Tests: svg/custom/invalid-stroke-hex.svg
2842                svg/custom/invalid-uri-stroke.svg
2843
2844         * rendering/svg/RenderSVGResource.cpp:
2845         (WebCore::inheritColorFromParentStyleIfNeeded):
2846         (WebCore::requestPaintingResource):
2847
2848 2011-05-31  Vangelis Kokkevis  <vangelis@chromium.org>
2849
2850         Reviewed by Kent Tamura.
2851
2852         [chromium] Avoid double deletion of DrawingBuffer's color buffer
2853         texture.
2854         https://bugs.webkit.org/show_bug.cgi?id=61761
2855
2856         Test: Verified that the DCHECK in GraphicsContext3D implementation
2857         doesn't trigger.
2858
2859         * platform/graphics/chromium/DrawingBufferChromium.cpp:
2860         (WebCore::DrawingBuffer::~DrawingBuffer):
2861
2862 2011-05-30  Hayato Ito  <hayato@chromium.org>
2863
2864         Reviewed by Ryosuke Niwa.
2865
2866         Add a utility function for dumping a tree for the Node, including a document of a frame.
2867         https://bugs.webkit.org/show_bug.cgi?id=61727
2868
2869         No new tests since added functions are only available in debug builds.
2870
2871         * dom/Node.cpp:
2872         (WebCore::parentOrHostOrFrameOwner):
2873         (WebCore::traverseNextNodeAcrossFrame):
2874         (WebCore::Node::showTreeForThisAcrossFrame):
2875         * dom/Node.h:
2876
2877 2011-05-30  James Kozianski  <koz@chromium.org>
2878
2879         Reviewed by Kent Tamura.
2880
2881         [Chromium] Make isValidProtocol() accept protocols with '+'.
2882         https://bugs.webkit.org/show_bug.cgi?id=61759
2883
2884         Also, detect syntax errors before security errors; some syntax errors
2885         will also trigger a security error, but it's more helpful to the
2886         programmer to know if they have a syntax error, which are well-defined
2887         in the spec, rather than a security error, which aren't.
2888
2889         * page/Navigator.cpp:
2890         (WebCore::Navigator::registerProtocolHandler):
2891         Detect syntax errors before security errors.
2892         * platform/KURLGoogle.cpp:
2893         (WebCore::isSchemeChar):
2894         Include '+' in the list of valid characters.
2895
2896 2011-05-30  Andrey Petrov  <andrey.petrov@gmail.com>
2897
2898         Reviewed by Hajime Morita.
2899
2900         Using jQuery to show/hide IMG elements crashes WebKit
2901         https://bugs.webkit.org/show_bug.cgi?id=31721
2902
2903         For platform code, do not assert nodes always have renderer at
2904         the time context menu action is invoked.
2905         Renderer can actually be empty for a given node if it was hidden
2906         or removed from domtree by some non-user generated event (e.g timeout) 
2907         after the popup menu had been created.
2908
2909         Changing Chromium, Gtk, Mac, Qt, Win and WinCE.
2910
2911         Test: editing/pasteboard/copy-standalone-image-crash.html
2912
2913         * platform/chromium/PasteboardChromium.cpp:
2914         (WebCore::Pasteboard::writeImage):
2915         * platform/gtk/PasteboardGtk.cpp:
2916         (WebCore::Pasteboard::writeImage):
2917         * platform/mac/PasteboardMac.mm:
2918         (WebCore::Pasteboard::writeImage):
2919         * platform/qt/PasteboardQt.cpp:
2920         (WebCore::Pasteboard::writeImage):
2921         * platform/win/PasteboardWin.cpp:
2922         (WebCore::Pasteboard::writeImage):
2923         * platform/wince/PasteboardWinCE.cpp:
2924         (WebCore::Pasteboard::writeImage):
2925
2926 2011-05-30  Daniel Bates  <dbates@webkit.org>
2927
2928         Reviewed by Adam Barth.
2929
2930         Rename XSSFilter to XSSAuditor
2931         https://bugs.webkit.org/show_bug.cgi?id=61718
2932
2933         Currently we use the names XSSFilter and XSSAuditor throughout the project.
2934         Instead, we should choose one name for consistency.
2935
2936         No functionality was changed. So, no new tests.
2937
2938         * CMakeLists.txt:
2939         * GNUmakefile.list.am:
2940         * WebCore.gypi:
2941         * WebCore.pro:
2942         * WebCore.vcproj/WebCore.vcproj:
2943         * WebCore.xcodeproj/project.pbxproj:
2944         * html/parser/HTMLDocumentParser.cpp:
2945         (WebCore::HTMLDocumentParser::HTMLDocumentParser):
2946         (WebCore::HTMLDocumentParser::pumpTokenizer):
2947         * html/parser/HTMLDocumentParser.h:
2948         * html/parser/XSSAuditor.cpp: Copied from Source/WebCore/html/parser/XSSFilter.cpp.
2949         (WebCore::XSSAuditor::XSSAuditor):
2950         (WebCore::XSSAuditor::init):
2951         (WebCore::XSSAuditor::filterToken):
2952         (WebCore::XSSAuditor::filterTokenInitial):
2953         (WebCore::XSSAuditor::filterTokenAfterScriptStartTag):
2954         (WebCore::XSSAuditor::filterScriptToken):
2955         (WebCore::XSSAuditor::filterObjectToken):
2956         (WebCore::XSSAuditor::filterParamToken):
2957         (WebCore::XSSAuditor::filterEmbedToken):
2958         (WebCore::XSSAuditor::filterAppletToken):
2959         (WebCore::XSSAuditor::filterIframeToken):
2960         (WebCore::XSSAuditor::filterMetaToken):
2961         (WebCore::XSSAuditor::filterBaseToken):
2962         (WebCore::XSSAuditor::filterFormToken):
2963         (WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
2964         (WebCore::XSSAuditor::eraseAttributeIfInjected):
2965         (WebCore::XSSAuditor::snippetForRange):
2966         (WebCore::XSSAuditor::snippetForAttribute):
2967         (WebCore::XSSAuditor::isContainedInRequest):
2968         (WebCore::XSSAuditor::isSameOriginResource):
2969         * html/parser/XSSAuditor.h: Copied from Source/WebCore/html/parser/XSSFilter.h.
2970         * html/parser/XSSFilter.cpp: Removed.
2971         * html/parser/XSSFilter.h: Removed.
2972
2973 2011-05-30  No'am Rosenthal  <noam.rosenthal@nokia.com>
2974
2975         Reviewed by Simon Hausmann.
2976
2977         WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
2978         https://bugs.webkit.org/show_bug.cgi?id=61694
2979
2980         Expose a public clearAll() function to reset WebCore::Animation.
2981
2982         No new functionality, so no new tests.
2983
2984         * platform/animation/Animation.h:
2985         (WebCore::Animation::clearAll):
2986
2987 2011-05-30  Eric Carlson  <eric.carlson@apple.com>
2988
2989         Reviewed by Alexey Proskuryakov.
2990
2991         Audio and video files saved to the Application Cache should preserve the original file extension
2992         https://bugs.webkit.org/show_bug.cgi?id=61750
2993         <rdar://9524922>
2994
2995         No new tests, it isn't possible to check the name of the file in the cache from within
2996         DRT. Changes verified manually.
2997
2998         * loader/appcache/ApplicationCacheStorage.cpp:
2999         (WebCore::ApplicationCacheStorage::store): Append the original file extension to the cache
3000             file name.
3001         (WebCore::ApplicationCacheStorage::writeDataToUniqueFileInDirectory): Add extension parameter.
3002         * loader/appcache/ApplicationCacheStorage.h:
3003
3004 2011-05-30  Jer Noble  <jer.noble@apple.com>
3005
3006         Reviewed by Dan Bernstein.
3007
3008         Play/Pause button in wrong state when entering full screen on Vimeo
3009         https://bugs.webkit.org/show_bug.cgi?id=61754
3010
3011         Update the play/pause button inside reset().  This ensures the button is in
3012         the correct state when the controls are created after playback has already
3013         started.
3014
3015         * html/shadow/MediaControlRootElement.cpp:
3016         (WebCore::MediaControlRootElement::reset):
3017
3018 2011-05-30  No'am Rosenthal  <noam.rosenthal@nokia.com>
3019
3020         Reviewed by Simon Hausmann.
3021
3022         WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
3023         https://bugs.webkit.org/show_bug.cgi?id=61694
3024
3025         Added a public TimingFunction::type() method.
3026
3027         No new functionality, so no new tests.
3028
3029         * platform/animation/TimingFunction.h:
3030         (WebCore::TimingFunction::type):
3031
3032 2011-05-30  Noam Rosenthal  <noam.rosenthal@nokia.com>
3033
3034         BUILD FIX for r87697 on Windows/Symbian
3035
3036         For now enabling TextureMapper for Mac/Linux only.
3037
3038         * WebCore.pri:
3039
3040 2011-05-30  David Kilzer  <ddkilzer@apple.com>
3041
3042         BUILD FIX for r87692 with !ENABLE(FULLSCREEN_API)
3043
3044         * dom/EventDispatcher.cpp:
3045         (WebCore::EventDispatcher::determineDispatchBehavior): Mark
3046         shadowRoot as an unused parameter with !ENABLE(FULLSCREEN_API).
3047
3048 2011-05-30  No'am Rosenthal  <noam.rosenthal@nokia.com>
3049
3050         Reviewed by Andreas Kling.
3051
3052         [Texmap][Qt] Enable TextureMapper by default
3053         https://bugs.webkit.org/show_bug.cgi?id=61740
3054
3055         Make CONFIG+=texmap an opt-out instead of an opt-in.
3056
3057         No new functionality so no new tests.
3058
3059         * WebCore.pri:
3060
3061 2011-05-30  Martin Robinson  <mrobinson@igalia.com>
3062
3063         Reviewed by Xan Lopez.
3064
3065         [GTK] fast/css/font-face-zero-hash-key.html is crashing on the bots
3066         https://bugs.webkit.org/show_bug.cgi?id=61693
3067
3068         Do not try to read the FT_Face from m_scaledFont if it m_scaledFont is
3069         null. A recent change fixing 0-pixel-size fonts means that m_scaledFont
3070         may now be null.
3071
3072         No new tests. This change should cause fast/css/font-face-zero-hash-key.html
3073         to stop crashing.
3074
3075         * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
3076         (WebCore::FontPlatformData::FontPlatformData): Do a null check before accessing
3077         m_scaledFont.
3078
3079 2011-05-30  Noam Rosenthal  <noam.rosenthal@nokia.com>
3080
3081         Reviewed by Kenneth Rohde Christiansen.
3082
3083         [Texmap][Qt] Disable accelerated plugins/media until they're working.
3084         https://bugs.webkit.org/show_bug.cgi?id=61687
3085
3086         Until this works properly, we should indicate that our media implementation
3087         in texture mapper doesn't support accelerated compositing.
3088
3089         This makes LayoutTests/compositing/video/* work again.
3090
3091         * platform/graphics/qt/MediaPlayerPrivateQt.h:
3092         (WebCore::MediaPlayerPrivateQt::supportsAcceleratedRendering):
3093         (WebCore::MediaPlayerPrivateQt::platformLayer):
3094
3095 2011-05-30  Mikhail Naganov  <mnaganov@chromium.org>
3096
3097         Reviewed by Adam Barth.
3098
3099         [Chromium] Fix regression after r87628.
3100         https://bugs.webkit.org/show_bug.cgi?id=61733
3101
3102         Having r87628 in place, Chrome reliability bot crashes in
3103         WebCore::HTMLLinkElement::onloadTimerFired.
3104
3105         This is because the change makes WebCore::CachedResource::setRequest to
3106         call checkNotify on request reset.  HTMLLinkElement registers itself as
3107         CachedResource client via m_cachedSheet, which can happen even if
3108         m_cachedLinkResource wasn't set.  As a result,
3109         WebCore::HTMLLinkElement::notifyFinished is got called with unset
3110         m_cachedLinkResource, which causes a crash in
3111         HTMLLinkElement::onloadTimerFired
3112
3113         * html/HTMLLinkElement.cpp:
3114         (WebCore::HTMLLinkElement::notifyFinished):
3115
3116 2011-05-30  Jer Noble  <jer.noble@apple.com>
3117
3118         Reviewed by Darin Adler and Simon Fraser.
3119
3120         REGRESSION (r87622): Scrubbing a Vimeo movie when in fullscreen stops playback; no way to make it start again
3121         https://bugs.webkit.org/show_bug.cgi?id=61717
3122         rdar://problem/9522272
3123
3124         May be some good way to test this later. No immediate idea about the best way.
3125
3126         When a media element is taken into full-screen mode, stop events from propagating
3127         outside the media element's shadow DOM, EventDispatcher::determineDispatchBehavior()
3128         has been changed to take a shadow root node. In our full screen media element check,
3129         we check to see if the passed shadow root is the shadow root of the full screen media
3130         element, and if so, specify events should StayInsideShadowDOM. The end result is that
3131         inside EventDispatcher::ensureEventAncestors, an ancestor chain is built up all the
3132         way from the SliderThumb to the video element's shadow root, but no further.
3133
3134         * dom/EventDispatcher.cpp:
3135         (WebCore::EventDispatcher::determineDispatchBehavior): Restrict events to the
3136         shadow DOM when showing a full screen video.
3137
3138         * html/HTMLMediaElement.cpp:
3139         (WebCore::HTMLMediaElement::HTMLMediaElement): Removed code to manage full screen controls.
3140         The events telling us about activity in the shadow DOM no longer bubble out so we need to
3141         handle this inside the shadow DOM on the root element.
3142         (WebCore::HTMLMediaElement::play): Ditto.
3143         (WebCore::HTMLMediaElement::playbackProgressTimerFired): Ditto.
3144         (WebCore::HTMLMediaElement::defaultEventHandler): Ditto.
3145         (WebCore::HTMLMediaElement::enterFullscreen): Ditto.
3146         (WebCore::HTMLMediaElement::exitFullscreen): Ditto.
3147         * html/HTMLMediaElement.h: Added isPlaying function, removed things moved to the root element.
3148
3149         * html/shadow/MediaControlElements.cpp:
3150         (WebCore::MediaControlVolumeSliderContainerElement::defaultEventHandler): Rolled out
3151         changes that tried to make special rules for events using preDispatchEventHandler and such.
3152         This rolls out both r87622 and r87655.
3153         (WebCore::MediaControlMuteButtonElement::defaultEventHandler): Ditto.
3154         (WebCore::MediaControlPanelMuteButtonElement::defaultEventHandler): Ditto.
3155         (WebCore::MediaControlPlayButtonElement::defaultEventHandler): Ditto.
3156         (WebCore::MediaControlSeekButtonElement::defaultEventHandler): Ditto.
3157         (WebCore::MediaControlRewindButtonElement::defaultEventHandler): Ditto.
3158         (WebCore::MediaControlReturnToRealtimeButtonElement::defaultEventHandler): Ditto.
3159         (WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler): Ditto.
3160         (WebCore::MediaControlTimelineElement::defaultEventHandler): Ditto.
3161         (WebCore::MediaControlVolumeSliderElement::defaultEventHandler): Ditto.
3162         (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): Ditto.
3163         (WebCore::MediaControlFullscreenVolumeMinButtonElement::defaultEventHandler): Ditto.
3164         (WebCore::MediaControlFullscreenVolumeMaxButtonElement::defaultEventHandler): Ditto.
3165         * html/shadow/MediaControlElements.h: Ditto.
3166
3167         * html/shadow/MediaControlRootElement.cpp:
3168         (WebCore::MediaControlRootElement::MediaControlRootElement): Initialize new data members.
3169         (WebCore::MediaControlRootElement::playbackStarted): Start the timer so we will consider
3170         hiding the controls later.
3171         (WebCore::MediaControlRootElement::playbackProgressed): Hide the controls if the mouse
3172         is no longer over the controls.
3173         (WebCore::MediaControlRootElement::playbackStopped): Stop the timer since we only hide
3174         automatically if we're playing.
3175         (WebCore::MediaControlRootElement::enteredFullscreen): Start the timer.
3176         (WebCore::MediaControlRootElement::exitedFullscreen): Stop the timer since we only care
3177         if we are full screen.
3178         (WebCore::MediaControlRootElement::containsRelatedTarget): Added. Helper for next function.
3179         (WebCore::MediaControlRootElement::defaultEventHandler): Do the hide/show and timer functions
3180         as the mouse is moved in and out.
3181         (WebCore::MediaControlRootElement::startHideFullscreenControlsTimer): Start the timer if
3182         needed.
3183         (WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired): Hide if the conditions
3184         are met.
3185         (WebCore::MediaControlRootElement::stopHideFullscreenControlsTimer): Stop the timer.
3186
3187         * html/shadow/MediaControlRootElement.h: Added new functions and data members.
3188
3189
3190 2011-05-30  Gavin Peters  <gavinp@chromium.org>
3191
3192         Reviewed by Adam Barth.
3193
3194         prevent HTMLLinkElement from watching multiple CachedResources
3195         https://bugs.webkit.org/show_bug.cgi?id=61686
3196
3197         If we modify an existing link element, stop listening to the previous
3198         cached resource, to prevent double notifications (which crash).
3199
3200         Test: fast/dom/HTMLLinkElement/prefetch-too-many-clients.html
3201
3202         * html/HTMLLinkElement.cpp:
3203         (WebCore::HTMLLinkElement::process):
3204
3205 2011-05-30  Peter Varga  <pvarga@webkit.org>
3206
3207         Unreviewed build fix.
3208
3209         [Qt][V8] Fix debug build.
3210
3211         No new tests needed.
3212
3213         * css/CSSStyleDeclaration.cpp: Add missing header.
3214         * dom/Text.cpp: Ditto.
3215         * rendering/InlineTextBox.cpp: Ditto.
3216
3217 2011-05-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3218
3219         Unreviewed, rolling out r87683.
3220         http://trac.webkit.org/changeset/87683
3221         https://bugs.webkit.org/show_bug.cgi?id=61729
3222
3223         Breaks inspector tests on Chromium (Requested by apavlov on
3224         #webkit).
3225
3226         * inspector/front-end/StylesSidebarPane.js:
3227         (WebInspector.StylesSidebarPane.prototype.update):
3228
3229 2011-05-25  Alexander Pavlov  <apavlov@chromium.org>
3230
3231         Reviewed by Yury Semikhatsky.
3232
3233         Web Inspector: node selection is slow in the Elements panel.
3234         https://bugs.webkit.org/show_bug.cgi?id=60813
3235
3236         Schedule full style updates rather than request all node styles from the backend up front.
3237
3238         * inspector/front-end/StylesSidebarPane.js:
3239         (WebInspector.StylesSidebarPane.prototype.update.reloadAllStyles):
3240         (WebInspector.StylesSidebarPane.prototype.update):
3241
3242 2011-05-30  Andrey Kosyakov  <caseq@chromium.org>
3243
3244         Reviewed by Pavel Feldman.
3245
3246         Web Inspector: do not issue frontendReused for reload or navigation.
3247         https://bugs.webkit.org/show_bug.cgi?id=61192
3248
3249        - only issue frontendReused when inspector is attached after main resource committed load
3250        - upon committing loading main resource, reset agents before sending FrameNavigated to page agent
3251        - Ensure main resource is set early so that abbreviations of URLs in resource tree are consistent after reload
3252        - do not enable agents explicitly in frontendReused (this is done by backend when resotring state from cookie)
3253
3254         * inspector/InspectorAgent.cpp:
3255         (WebCore::InspectorAgent::InspectorAgent):
3256         (WebCore::InspectorAgent::restore):
3257         (WebCore::InspectorAgent::clearFrontend):
3258         (WebCore::InspectorAgent::didCommitLoad):
3259         * inspector/InspectorAgent.h:
3260         * inspector/InspectorInstrumentation.cpp:
3261         (WebCore::InspectorInstrumentation::didCommitLoadImpl):
3262         * inspector/front-end/NetworkManager.js:
3263         * inspector/front-end/ResourceTreeModel.js:
3264         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
3265         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
3266         (WebInspector.ResourceTreeModel.prototype._cleanupFramesAfterNavigation):
3267         (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
3268         * inspector/front-end/ResourcesPanel.js:
3269         (WebInspector.ResourcesPanel.prototype.reset):
3270         (WebInspector.ResourcesPanel.prototype._resetResourcesTree):
3271         (WebInspector.DatabaseTreeElement.prototype.onpopulate):
3272         (WebInspector.SearchResultsTreeElementsTraverser.prototype._lastTreeElement):
3273         * inspector/front-end/inspector.js:
3274         (WebInspector.reset):
3275         (WebInspector.frontendReused):
3276
3277 2011-05-30  Ryan Sleevi  <rsleevi@chromium.org>
3278
3279         Reviewed by Darin Adler.
3280
3281         FEConvolveMatrix::getPixelValue() fails to properly check if y is within bounds, causing it to fail to correctly apply the kernel and edge mode to the first targetY pixels
3282         https://bugs.webkit.org/show_bug.cgi?id=61603
3283
3284         Test: svg/filters/feConvolveFilter-y-bounds.svg
3285
3286         * platform/graphics/filters/FEConvolveMatrix.cpp:
3287         (WebCore::FEConvolveMatrix::getPixelValue):
3288
3289 2011-05-30  Nate Chapin  <japhet@chromium.org>
3290
3291         Reviewed by Antti Koivisto.
3292
3293         Refactor the CachedResourceLoader -> CachedResource -> CachedResourceRequest
3294         flow so it's a little less circular.
3295         https://bugs.webkit.org/show_bug.cgi?id=61666
3296
3297         * loader/cache/CachedFont.cpp:
3298         (WebCore::CachedFont::beginLoadIfNeeded):
3299         * loader/cache/CachedResource.cpp:
3300         (WebCore::CachedResource::load):
3301         * loader/cache/CachedResourceLoader.cpp:
3302         (WebCore::CachedResourceLoader::requestImage):
3303         (WebCore::CachedResourceLoader::setAutoLoadImages):
3304         (WebCore::CachedResourceLoader::loadStarted):
3305         * loader/cache/CachedResourceLoader.h:
3306         * loader/cache/CachedResourceRequest.cpp:
3307         (WebCore::CachedResourceRequest::load):
3308
3309 2011-05-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3310
3311         Unreviewed, rolling out r87618.
3312         http://trac.webkit.org/changeset/87618
3313         https://bugs.webkit.org/show_bug.cgi?id=61720
3314
3315         Causes BrowserFocusTest.FocusOnReload to fail (Requested by
3316         abarth|gardener on #webkit).
3317
3318         * html/HTMLLinkElement.cpp:
3319         (WebCore::HTMLLinkElement::process):
3320
3321 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
3322
3323         Reviewed by Kent Tamura.
3324
3325         WebSocket closing handshake
3326         https://bugs.webkit.org/show_bug.cgi?id=35721
3327
3328         Implement WebSocket closing handshake based on Ian Hickson's
3329         WebSocket protocol draft 76.
3330
3331         Tests: http/tests/websocket/tests/client-close.html
3332                http/tests/websocket/tests/server-close.html
3333
3334         * platform/network/SocketStreamHandleBase.cpp:
3335         (WebCore::SocketStreamHandleBase::send):
3336         Do not send a message if we are in Closing state.
3337         (WebCore::SocketStreamHandleBase::close):
3338         Do not disconnect if we have pending data which have not been sent yet.
3339         In this case, the actual disconnection will happen in sendPendingData().
3340         (WebCore::SocketStreamHandleBase::disconnect):
3341         Renamed from close(). Disconnect the connection immediately.
3342         (WebCore::SocketStreamHandleBase::sendPendingData):
3343         * platform/network/SocketStreamHandleBase.h:
3344         * websockets/ThreadableWebSocketChannelClientWrapper.cpp:
3345         Add didStartClosingHandshake(). Add a function argument (ClosingHandshakeCompletionStatus)
3346         to didClose().
3347         (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake):
3348         (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
3349         (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback):
3350         (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
3351         * websockets/ThreadableWebSocketChannelClientWrapper.h:
3352         * websockets/WebSocket.cpp:
3353         (WebCore::WebSocket::send):
3354         (WebCore::WebSocket::close):
3355         Fail if close() is attempted before the connection is established.
3356         Otherwise, set the state to CLOSING and start the closing handshake.
3357         (WebCore::WebSocket::bufferedAmount):
3358         If the state is CLOSING, we need to consider buffered data in m_channel and sent after close().
3359         (WebCore::WebSocket::didConnect):
3360         (WebCore::WebSocket::didReceiveMessage):
3361         We need to invoke message event in CLOSING state as well as OPEN state.
3362         (WebCore::WebSocket::didReceiveMessageError):
3363         (WebCore::WebSocket::didStartClosingHandshake):
3364         (WebCore::WebSocket::didClose):
3365         * websockets/WebSocket.h:
3366         * websockets/WebSocketChannel.cpp:
3367         (WebCore::WebSocketChannel::WebSocketChannel):
3368         (WebCore::WebSocketChannel::close):
3369         Start the closing handshake.
3370         (WebCore::WebSocketChannel::disconnect):
3371         Disconnect the socket stream, instead of close.
3372         (WebCore::WebSocketChannel::didClose):
3373         (WebCore::WebSocketChannel::didReceiveData): Ditto.
3374         (WebCore::WebSocketChannel::didFail): Ditto.
3375         (WebCore::WebSocketChannel::processBuffer):
3376         Ditto.
3377         Handle 0xFF 0x00 byte sequence, and discard received data once the closing handshake has started.
3378         (WebCore::WebSocketChannel::startClosingHandshake):
3379         Send 0xFF 0x00 byte sequence.
3380         (WebCore::WebSocketChannel::closingTimerFired):
3381         Disconnect the socket stream if the closing handshake has timed out.
3382         * websockets/WebSocketChannel.h:
3383         m_closing is true if "the WebSocket closing handshake has started" (as stated in the protocol
3384         specification).
3385         * websockets/WebSocketChannelClient.h:
3386         (WebCore::WebSocketChannelClient::didStartClosingHandshake): Added.
3387         (WebCore::WebSocketChannelClient::didClose): Add closingHandshakeCompletion parameter.
3388         * websockets/WorkerThreadableWebSocketChannel.cpp:
3389         Add closingHandshakeCompletion parameter to didClose(), and add didStartClosingHandshake().
3390         (WebCore::WorkerThreadableWebSocketChannel::Peer::close):
3391         (WebCore::workerContextDidStartClosingHandshake):
3392         (WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake):
3393         (WebCore::workerContextDidClose):
3394         (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
3395         * websockets/WorkerThreadableWebSocketChannel.h:
3396
3397 2011-05-29  Adam Barth  <abarth@webkit.org>
3398
3399         Attempt to fix build by implementing pure virtual function.
3400
3401         * html/shadow/MediaControlRootElementChromium.cpp:
3402         (WebCore::MediaControlRootElementChromium::shouldHideControls):
3403         * html/shadow/MediaControlRootElementChromium.h:
3404
3405 2011-05-29  Brian Weinstein  <bweinstein@apple.com>
3406
3407         Reviewed by Darin Adler.
3408
3409         Controls never hide in full screen after user stops moving mouse
3410         https://bugs.webkit.org/show_bug.cgi?id=61715
3411         <rdar://problem/9522182>
3412         
3413         When we get a mouse move event in HTMLMediaElement::defaultEventHandler, and we are in full screen,
3414         show the media controls, and then start a timer.
3415         
3416         The timer fires 3 seconds after the user's last mouse movement (timer is restarted on every mouse
3417         move), and hides the controls.
3418
3419         * html/HTMLMediaElement.cpp:
3420         (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize our new timer.
3421         (WebCore::HTMLMediaElement::play): If we are in full screen mode, start our timer to hide the full screen
3422             controls. We don't want the user to have to move the mouse to hide them when they use the spacebar
3423             to play.
3424         (WebCore::HTMLMediaElement::startHideFullscreenControlsTimer): Starts a oneshot timer 3 seconds in the future
3425             if we are in full screen.
3426         (WebCore::HTMLMediaElement::hideFullscreenControlsTimerFired): Make sure that we are currently playing, and
3427             we are in full screen, and hide the controls. We don't want to hide the controls if we are paused.
3428         (WebCore::HTMLMediaElement::stopHideFullscreenControlsTimer): Stops the timer.
3429         (WebCore::HTMLMediaElement::defaultEventHandler): If we get a mouse move event and are in full screen, show the
3430             controls and start a timer to hide them.
3431         (WebCore::HTMLMediaElement::enterFullscreen): Start a timer to hide the full screen controls. The user shouldn't
3432             have the move the mouse once they enter full screen to hide the controls.
3433         (WebCore::HTMLMediaElement::exitFullscreen): Stop the timer to hide the full screen controls.
3434         * html/HTMLMediaElement.h:
3435         * html/shadow/MediaControls.h: Added pure virtual shouldHideControls() method.
3436         * html/shadow/MediaControlRootElement.cpp:
3437         (WebCore::MediaControlRootElement::playbackStopped): Stop the timer to hide the full screen controls.
3438         (WebCore::MediaControlRootElement::shouldHideControls): Added, only report that
3439             the caller should hide the controls if the panel is not hovered.
3440         * html/shadow/MediaControlRootElement.h:
3441
3442 2011-05-29  Jer Noble  <jer.noble@apple.com>
3443
3444         Reviewed by Simon Fraser.
3445
3446         Embedded Vimeo video, when taken fullscreen, is overlapped by content from the enclosing page
3447         https://bugs.webkit.org/show_bug.cgi?id=61712
3448
3449         Tests: fullscreen/full-screen-iframe-zIndex.html
3450
3451         Walk up the ancestor chain for the full-screen element, marking them as full-screen
3452         ancestors. Then, we apply a pseudo-class to those elements, which disable all their
3453         stacking-context-creating styles.  Set the z-index of all full-screen elements (and
3454         the iframes which contain them) to a large value, ensuring they appear above other
3455         sibling elements.
3456
3457         This new behavior replaces the previous "-webkit-full-screen-media-document" behavior
3458         and pesudo-class, so remove it and replace it with the new pseudo-class.
3459
3460         * css/CSSSelector.cpp:
3461         (WebCore::nameToPseudoTypeMap): Add -webkit-full-screen-ancestor and remove
3462             -webkit-full-screen-media-document.
3463         (WebCore::CSSSelector::pseudoId): Add PseudoFullScreenAncestor and remove
3464             PseudoFullScreenMediaDocument
3465         (WebCore::CSSSelector::extractPseudoType): Ditto.
3466         * css/CSSSelector.h: Ditto.
3467         * css/CSSStyleSelector.cpp:
3468         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Remove the
3469             PseudoFullScreenMediaDocument implementation and replace it with
3470             PseudoFullScreenAncestor.
3471         * css/fullscreen.css:
3472         (:-webkit-full-screen): Add a z-index property.
3473         (:-webkit-full-screen-ancestor:not(iframe)): Added.  Reset the z-index to
3474             auto, and reset other stacking-context creating properties.
3475         * dom/Document.cpp:
3476         (WebCore::Document::setContainsFullScreenElementRecursively): Recurse up every element
3477             instead of just the iframe elements.
3478         (WebCore::Document::webkitWillEnterFullScreenForElement): Ditto.
3479         * dom/Element.cpp:
3480         (WebCore::Element::willRemove): Reset our parent's containsFullScreenElement property.
3481         (WebCore::Element::insertedIntoTree): Ditto.
3482         (WebCore::Element::containsFullScreenElement): Moved here from HTMLElementBase.
3483         (WebCore::Element::setContainsFullScreenElement): Ditto.
3484         * dom/Element.h:
3485         * dom/ElementRareData.h:
3486         (WebCore::ElementRareData::ElementRareData): Added ivar and initializer for 
3487             m_containsFullScreenElement.
3488         * html/HTMLFrameElementBase.cpp:
3489         (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Removed ivar and initializer.
3490         (WebCore::HTMLFrameElementBase::setContainsFullScreenElement): Moved into Element.
3491         * html/HTMLFrameElementBase.h:
3492         * rendering/style/RenderStyleConstants.h:
3493
3494 2011-05-29  Dan Bernstein  <mitz@apple.com>
3495
3496         Reviewed by Darin Adler.
3497
3498         <rdar://problem/9515650> 30 second rewind button obscured in fullscreen controller when video uses custom inline controls
3499         https://bugs.webkit.org/show_bug.cgi?id=61714
3500
3501         * dom/Document.cpp:
3502         (WebCore::Document::webkitDidEnterFullScreenForElement): Call didBecomeFullscreenElement() on the
3503         new full screen element.
3504         (WebCore::Document::webkitWillExitFullScreenForElement): Call willStopBeingFullscreenElement() on
3505         the full screen element.
3506         * dom/Element.h:
3507         (WebCore::Element::didBecomeFullscreenElement): Added with a default implementation that does nothing.
3508         (WebCore::Element::willStopBeingFullscreenElement): Ditto.
3509         * html/HTMLMediaElement.cpp:
3510         (WebCore::HTMLMediaElement::didBecomeFullscreenElement): Added this override, which calls
3511         MediaControls::enteredFullscreen().
3512         (WebCore::HTMLMediaElement::willStopBeingFullscreenElement): Added this override, which calls
3513         MediaControls::exitedFullscreen().
3514         * html/HTMLMediaElement.h:
3515         * html/shadow/MediaControlElements.cpp:
3516         (WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Removed calls to
3517         enteredFullscreen() and exitedFullscreen() from here, since they are now called in response to
3518         changes to the fullscreen-ness of the element.
3519
3520 2011-05-29  Darin Adler  <darin@apple.com>
3521
3522         Reviewed by Kevin Decker.
3523
3524         REGRESSION (r87622): In media documents, clicking the full screen button and the play button pauses the video
3525         https://bugs.webkit.org/show_bug.cgi?id=61713
3526
3527         We need to come up with a way to regression-test these changes. Nothing at the moment.
3528
3529         The bug is that we removed calls to preventDefault, but we still do need to prevent
3530         default handling of this event.
3531
3532         * html/shadow/MediaControlElements.cpp:
3533         (WebCore::MediaControlElement::preDispatchEventHandler): Add back the preventDefault
3534         that was in here before r87622 as well as the stopPropagation that was added in r87622.
3535         (WebCore::MediaControlMuteButtonElement::preDispatchEventHandler): Ditto.
3536         (WebCore::MediaControlPlayButtonElement::preDispatchEventHandler): Ditto.
3537         (WebCore::MediaControlSeekButtonElement::preDispatchEventHandler): Ditto.
3538         (WebCore::MediaControlRewindButtonElement::preDispatchEventHandler): Ditto.
3539         (WebCore::MediaControlReturnToRealtimeButtonElement::preDispatchEventHandler): Ditto.
3540         (WebCore::MediaControlToggleClosedCaptionsButtonElement::preDispatchEventHandler): Ditto.
3541         (WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Ditto.
3542         (WebCore::MediaControlFullscreenVolumeMinButtonElement::preDispatchEventHandler): Ditto.
3543         (WebCore::MediaControlFullscreenVolumeMaxButtonElement::preDispatchEventHandler): Ditto.
3544
3545 2011-05-29  Andreas Kling  <kling@webkit.org>
3546
3547         Reviewed by Kenneth Rohde Christiansen.
3548
3549         Element: Micro-cleanup of scroll methods.
3550         https://bugs.webkit.org/show_bug.cgi?id=61705
3551
3552         Do an early return without calculating element boundaries when asked
3553         to scroll an element without a renderer().
3554
3555         * dom/Element.cpp:
3556         (WebCore::Element::scrollIntoView):
3557         (WebCore::Element::scrollIntoViewIfNeeded):
3558         (WebCore::Element::scrollByUnits):
3559
3560 2011-05-29  Darin Adler  <darin@apple.com>
3561
3562         Reviewed by Dan Bernstein.
3563
3564         Fix assertion seen when entering full screen mode for standalone video
3565         https://bugs.webkit.org/show_bug.cgi?id=61708
3566
3567         We don't currently have a way to make a regression test for this.
3568
3569         * dom/Document.cpp:
3570         (WebCore::Document::setAnimatingFullScreen): Call scheduleForcedStyleRecalc,
3571         because scheduleStyleRecalc is intended to only be called when the style
3572         system itself detects recalc is needed.
3573
3574 2011-05-27  Andreas Kling  <kling@webkit.org>
3575
3576         Reviewed by James Robinson.
3577
3578         [Qt] Add area check to ImageBufferData::getImageData()
3579         https://bugs.webkit.org/show_bug.cgi?id=61375
3580
3581         No change in behavior, just a sanity check.
3582
3583         * platform/graphics/qt/ImageBufferQt.cpp:
3584         (WebCore::getImageData):
3585
3586 2011-05-29  Beth Dakin  <bdakin@apple.com>
3587
3588         Reviewed by Darin Adler.
3589
3590         https://bugs.webkit.org/show_bug.cgi?id=61700
3591         Need WebKit2 API to get the size of the render tree
3592         -and corresponding-
3593         <rdar://problem/9512733>
3594
3595         New member variable on RenderArena keeps track of the current amount of memory 
3596         allocated in the arena. The new client function sends this piece of data to 
3597         WebKit.
3598         * page/ChromeClient.h:
3599         (WebCore::ChromeClient::setRenderTreeSize):
3600         * page/FrameView.cpp:
3601         (WebCore::FrameView::performPostLayoutTasks):
3602         * rendering/RenderArena.cpp:
3603         (WebCore::RenderArena::RenderArena):
3604         (WebCore::RenderArena::allocate):
3605         (WebCore::RenderArena::free):
3606         * rendering/RenderArena.h:
3607         (WebCore::RenderArena::totalRenderArenaSize):
3608
3609 2011-05-29  Sheriff Bot  <webkit.review.bot@gmail.com>
3610
3611         Unreviewed, rolling out r87566.
3612         http://trac.webkit.org/changeset/87566
3613         https://bugs.webkit.org/show_bug.cgi?id=61702
3614
3615         It made all tests assert on Qt in debug mode (Requested by
3616         Ossy_weekend on #webkit).
3617
3618         * WebCore.exp.in:
3619         * bindings/ScriptControllerBase.cpp:
3620         (WebCore::ScriptController::executeIfJavaScriptURL):
3621         * dom/Document.cpp:
3622         (WebCore::Document::Document):
3623         (WebCore::Document::suggestedMIMEType):
3624         (WebCore::Document::lastModified):
3625         (WebCore::Document::initSecurityContext):
3626         (WebCore::Document::updateURLForPushOrReplaceState):
3627         * dom/Document.h:
3628         (WebCore::Document::setDocumentLoader):
3629         (WebCore::Document::loader):
3630         * html/MediaDocument.cpp:
3631         (WebCore::MediaDocument::replaceMediaElementTimerFired):
3632         * html/PluginDocument.cpp:
3633         (WebCore::PluginDocumentParser::createDocumentStructure):
3634         * platform/mac/HTMLConverter.mm:
3635         (fileWrapperForElement):
3636
3637 2011-05-28  Steve Falkenburg  <sfalken@apple.com>
3638
3639         Reviewed by Dan Bernstein.
3640
3641         Don't add sub-frames to global history when navigating via back/forward
3642         https://bugs.webkit.org/show_bug.cgi?id=61701
3643         <rdar://problem/9521222>
3644
3645         Instead of just checking whether the load is the first in the frame, we also need to
3646         check to make sure we're loading in the main frame.
3647
3648         Not testable due to lack of global history infrastructure in DRT.
3649
3650         * loader/FrameLoader.cpp:
3651         (WebCore::FrameLoader::transitionToCommitted):
3652
3653 2011-05-28  Alexey Proskuryakov  <ap@apple.com>
3654
3655         Suggested by Simon Fraser.
3656
3657         REGRESSION (r85375): Load event is sometimes lost when multiple image elements use the same URL
3658         https://bugs.webkit.org/show_bug.cgi?id=61692
3659         <rdar://problem/9488628>
3660
3661         * loader/ImageLoader.cpp: (WebCore::ImageLoader::notifyFinished): There was no need to use
3662         ASSERT_UNUSED here.
3663
3664 2011-05-28  Alexey Proskuryakov  <ap@apple.com>
3665
3666         Reviewed by Geoff Garen.
3667
3668         REGRESSION (r85375): Load event is sometimes lost when multiple image elements use the same URL
3669         https://bugs.webkit.org/show_bug.cgi?id=61692
3670         <rdar://problem/9488628>
3671
3672         Test: fast/dom/gc-image-element-2.html
3673
3674         Manually verified that tests from bug 59604 and from bug 40926 still pass.
3675
3676         The problem here was that HTMLImageElement::hasPendingActivity() could return false when
3677         a load (or error) event was still expected to fire.
3678
3679         * loader/cache/CachedResource.cpp:
3680         (WebCore::CachedResource::setRequest):
3681         * loader/cache/CachedResource.h:
3682         (WebCore::CachedResource::wasCanceled):
3683         (WebCore::CachedResource::errorOccurred):
3684         Track whether the load was canceled. We want to always notify clients of load outcome,
3685         as that's the only way they could make intelligent decisions.
3686
3687         * dom/ScriptElement.cpp: (WebCore::ScriptElement::execute): Cached resource clients now
3688         get a notifyFinished call on cancellation. Handle this case, where we don't need the
3689         execute the script, but also don't need to fire an error event.
3690
3691         * html/HTMLImageElement.cpp: Moved hasPendingActivity() to header, since it's just a single
3692         function call now.
3693
3694         * html/HTMLImageElement.h: (WebCore::HTMLImageElement::hasPendingActivity): There is a large
3695         window between when CachedResource::isLoading() becomes false and events are queued.
3696         ImageLoader::haveFiredLoadEvent() is a much better indication of whether we are expecting
3697         an event to fire.
3698
3699         * html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::onloadTimerFired): Again, don't do
3700         anything on cancellation.
3701
3702         * loader/ImageLoader.cpp:
3703         (WebCore::ImageEventSender::hasPendingEvents): Made it debug-only again, and fixed to
3704         give an accurate result while looping over the list of events to dispatch.
3705         (WebCore::ImageLoader::notifyFinished): Don't do anything when cancelled. We don't want to
3706         switch to a broken image icon, or to dispatch events.
3707         (WebCore::ImageEventSender::dispatchPendingEvents): Clear the current loader from dispatching
3708         list, as the event is no longer pending when it's being dispatched.
3709
3710         * loader/ImageLoader.h: Removed unnecessary hasPendingLoadEvent(). We don't care whether one
3711         is already pending, we only care if one is expected at some time in the future, and
3712         !haveFiredLoadEvent() is our best idea of that.
3713
3714         * dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::notifyFinished): Another place to
3715         handle cancellation.
3716
3717 2011-05-28  Adam Barth  <abarth@webkit.org>
3718
3719         Reviewed by Alexey Proskuryakov.
3720
3721         Audit all uses of KURL::prettyURL
3722         https://bugs.webkit.org/show_bug.cgi?id=61201
3723
3724         As far as I can tell, all the callers of this API are confused.  There
3725         seems to be a cargo cult of using the "pretty" version of a URL, but in
3726         reality folks just want the URL itself.  The only case I'm unsure about
3727         is location.href, which could have some compatibility constraints.
3728         I've renamed prettyURL to deprecatedString to discourage folks from
3729         further cargo-culting.
3730
3731         * WebCore.exp.in:
3732         * page/Location.cpp:
3733         (WebCore::Location::href):
3734         (WebCore::Location::toString):
3735         * platform/KURL.cpp:
3736         (WebCore::KURL::deprecatedString):
3737         * platform/KURL.h:
3738         * platform/KURLGoogle.cpp:
3739         (WebCore::KURL::deprecatedString):
3740         * platform/network/soup/ResourceHandleSoup.cpp:
3741         (WebCore::ResourceHandle::prepareForURL):
3742         * workers/WorkerLocation.cpp:
3743         (WebCore::WorkerLocation::href):
3744         (WebCore::WorkerLocation::toString):
3745
3746 2011-05-28  Jer Noble  <jer.noble@apple.com>
3747
3748         Reviewed by Maciej Stachowiak.
3749
3750         Mouse clicks propagate outside full-screen media controls.
3751         https://bugs.webkit.org/show_bug.cgi?id=61689
3752
3753         Mouse click events are propagating out of the media controls, so mouse click
3754         listeners registered on the video element are getting fired when the user
3755         clicks on media controller buttons.  By default, block propagation of click 
3756         events from MediaControlElements by overriding preDispatchEventHandler, and
3757         convert all instances of defaultEventHandler -> preDispatchEventHandler.  Change
3758         all calls of event->setDefaultHandled() to event->stopPropagation().
3759
3760         * html/shadow/MediaControlElements.cpp:
3761         (WebCore::MediaControlElement::preDispatchEventHandler): Added.  Block 
3762             propagation of all mouse click events.
3763         (WebCore::MediaControlVolumeSliderContainerElement::preDispatchEventHandler):
3764             Renamed from setDefaultHandled.
3765         (WebCore::MediaControlMuteButtonElement::preDispatchEventHandler): Ditto.
3766         (WebCore::MediaControlPanelMuteButtonElement::preDispatchEventHandler): Ditto.
3767         (WebCore::MediaControlPlayButtonElement::preDispatchEventHandler): Ditto.
3768         (WebCore::MediaControlSeekButtonElement::preDispatchEventHandler): Ditto.
3769         (WebCore::MediaControlRewindButtonElement::preDispatchEventHandler): Ditto.
3770         (WebCore::MediaControlReturnToRealtimeButtonElement::preDispatchEventHandler): Ditto.
3771         (WebCore::MediaControlToggleClosedCaptionsButtonElement::preDispatchEventHandler): Ditto.
3772         (WebCore::MediaControlTimelineElement::preDispatchEventHandler): Ditto.
3773         (WebCore::MediaControlVolumeSliderElement::preDispatchEventHandler): Ditto.
3774         (WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Ditto.
3775         (WebCore::MediaControlFullscreenVolumeMinButtonElement::preDispatchEventHandler): Ditto.
3776         (WebCore::MediaControlFullscreenVolumeMaxButtonElement::preDispatchEventHandler): Ditto.
3777         * html/shadow/MediaControlElements.h:
3778
3779 2011-05-28  Gavin Peters  <gavinp@chromium.org>
3780
3781         Reviewed by Adam Barth.
3782
3783         prevent HTMLLinkElement from watching multiple CachedResources
3784         https://bugs.webkit.org/show_bug.cgi?id=61686
3785
3786         If we modify an existing link element, stop listening to the previous
3787         cached resource, to prevent double notifications (which crash).
3788
3789         Test: fast/dom/HTMLLinkElement/prefetch-too-many-clients.html
3790
3791         * html/HTMLLinkElement.cpp:
3792         (WebCore::HTMLLinkElement::process):
3793
3794 2011-05-28  Tonis Tiigi  <tonistiigi@gmail.com>
3795
3796         Reviewed by Pavel Feldman.
3797
3798         Web Inspector: there is a problem with computed style properties with wrong values
3799         https://bugs.webkit.org/show_bug.cgi?id=60535
3800
3801         * inspector/front-end/StylesSidebarPane.js:
3802         (WebInspector.StylesSidebarPane.prototype._markUsedProperties):
3803         (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
3804
3805 2011-05-26  Antonio Gomes  <agomes@rim.com>
3806
3807         Reviewed by Andreas Kling.
3808
3809         Logic error in WebCore/Page/SpatialNavigation.cpp::areRectsPartiallyAligned
3810         https://bugs.webkit.org/show_bug.cgi?id=61606
3811
3812         Removed duplicated statement within if condition.
3813
3814         No new tests. Obvious clean up patch.
3815
3816         * page/SpatialNavigation.cpp:
3817         (WebCore::areRectsPartiallyAligned):
3818
3819 2011-05-27  Simon Fraser  <simon.fraser@apple.com>
3820
3821         Reviewed by Dan Bernstein.
3822
3823         CG BitmapImage needs to check for valid CGImage in a couple of places
3824         https://bugs.webkit.org/show_bug.cgi?id=61684
3825         <rdar://problem/9519348>
3826
3827         BitmapImage::getCGImageArray() can throw an exception if frameAtIndex()
3828         returns null, which it may do if the image is corrupted or still
3829         loading. Protect against that here and in getFirstCGImageRefOfSize().
3830
3831         * platform/graphics/cg/ImageCG.cpp:
3832         (WebCore::BitmapImage::getFirstCGImageRefOfSize):
3833         (WebCore::BitmapImage::getCGImageArray):
3834
3835 2011-05-27  Jochen Eisinger  <jochen@chromium.org>
3836
3837         Reviewed by Adam Barth.
3838
3839         Add Frame parameter to all StorageArea methods. The chromium
3840         embedder uses the Frame as context to decide whether or not
3841         to allow usage of the storage API.
3842         https://bugs.webkit.org/show_bug.cgi?id=61581
3843
3844         Test: platform/chromium/permissionclient/storage-permission.html
3845
3846         * storage/Storage.cpp:
3847         (WebCore::Storage::length):
3848         (WebCore::Storage::key):
3849         (WebCore::Storage::getItem):
3850         (WebCore::Storage::contains):
3851         * storage/StorageArea.h:
3852         * storage/StorageAreaImpl.cpp:
3853         (WebCore::StorageAreaImpl::length):
3854         (WebCore::StorageAreaImpl::key):
3855         (WebCore::StorageAreaImpl::getItem):
3856         (WebCore::StorageAreaImpl::contains):
3857         * storage/StorageAreaImpl.h:
3858
3859 2011-05-27  Nate Chapin  <japhet@chromium.org>
3860
3861         Reviewed by Jian Li.
3862
3863         Keep a reference to BlobResourceHandle before calling doNotifyFinish()
3864         asynchronously to ensure it's still safe in the main thread.
3865
3866         https://bugs.webkit.org/show_bug.cgi?id=61669
3867
3868         I triggered this crash in fast/files/file-reader-abort.html during a
3869         refactor that changed timings slightly.
3870
3871         * platform/network/BlobResourceHandle.cpp:
3872         (WebCore::doNotifyFinish):
3873         (WebCore::BlobResourceHandle::notifyFinish):
3874         * platform/network/BlobResourceHandle.h:
3875         (WebCore::BlobResourceHandle::aborted):
3876
3877 2011-05-27  Stephanie Lewis  <slewis@apple.com>
3878
3879         Unreviewed.
3880
3881         Fix a typo in the order_file flag.
3882
3883         * Configurations/Base.xcconfig:
3884
3885 2011-05-27  Anders Carlsson  <andersca@apple.com>
3886
3887         Reviewed by Sam Weinig.
3888
3889         Always use the default localization strategy
3890         https://bugs.webkit.org/show_bug.cgi?id=61670
3891         <rdar://problem/9516130>
3892
3893         Always use the default localization strategy when there's no platform strategy.
3894
3895         * platform/DefaultLocalizationStrategy.cpp:
3896         (WebCore::DefaultLocalizationStrategy::shared):
3897         * platform/DefaultLocalizationStrategy.h:
3898         * platform/LocalizedStrings.cpp:
3899         (WebCore::inputElementAltText):
3900         (WebCore::resetButtonDefaultLabel):
3901         (WebCore::searchableIndexIntroduction):
3902         (WebCore::submitButtonDefaultLabel):
3903         (WebCore::fileButtonChooseFileLabel):
3904         (WebCore::fileButtonNoFileSelectedLabel):
3905         (WebCore::defaultDetailsSummaryText):
3906         (WebCore::copyImageUnknownFileLabel):
3907         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
3908         (WebCore::contextMenuItemTagDownloadLinkToDisk):
3909         (WebCore::contextMenuItemTagCopyLinkToClipboard):
3910         (WebCore::contextMenuItemTagOpenImageInNewWindow):
3911         (WebCore::contextMenuItemTagDownloadImageToDisk):
3912         (WebCore::contextMenuItemTagCopyImageToClipboard):
3913         (WebCore::contextMenuItemTagCopyImageUrlToClipboard):
3914         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
3915         (WebCore::contextMenuItemTagCopy):
3916         (WebCore::contextMenuItemTagGoBack):
3917         (WebCore::contextMenuItemTagGoForward):
3918         (WebCore::contextMenuItemTagStop):
3919         (WebCore::contextMenuItemTagReload):
3920         (WebCore::contextMenuItemTagCut):
3921         (WebCore::contextMenuItemTagPaste):
3922         (WebCore::contextMenuItemTagSelectAll):
3923         (WebCore::contextMenuItemTagNoGuessesFound):
3924         (WebCore::contextMenuItemTagIgnoreSpelling):
3925         (WebCore::contextMenuItemTagLearnSpelling):
3926         (WebCore::contextMenuItemTagSearchInSpotlight):
3927         (WebCore::contextMenuItemTagSearchWeb):
3928         (WebCore::contextMenuItemTagLookUpInDictionary):
3929         (WebCore::contextMenuItemTagOpenLink):
3930         (WebCore::contextMenuItemTagIgnoreGrammar):
3931         (WebCore::contextMenuItemTagSpellingMenu):
3932         (WebCore::contextMenuItemTagShowSpellingPanel):
3933         (WebCore::contextMenuItemTagCheckSpelling):
3934         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
3935         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
3936         (WebCore::contextMenuItemTagFontMenu):
3937         (WebCore::contextMenuItemTagShowFonts):
3938         (WebCore::contextMenuItemTagBold):
3939         (WebCore::contextMenuItemTagItalic):
3940         (WebCore::contextMenuItemTagUnderline):
3941         (WebCore::contextMenuItemTagOutline):
3942         (WebCore::contextMenuItemTagStyles):
3943         (WebCore::contextMenuItemTagShowColors):
3944         (WebCore::contextMenuItemTagSpeechMenu):
3945         (WebCore::contextMenuItemTagStartSpeaking):
3946         (WebCore::contextMenuItemTagStopSpeaking):
3947         (WebCore::contextMenuItemTagWritingDirectionMenu):
3948         (WebCore::contextMenuItemTagTextDirectionMenu):
3949         (WebCore::contextMenuItemTagDefaultDirection):
3950         (WebCore::contextMenuItemTagLeftToRight):
3951         (WebCore::contextMenuItemTagRightToLeft):
3952         (WebCore::contextMenuItemTagCorrectSpellingAutomatically):
3953         (WebCore::contextMenuItemTagSubstitutionsMenu):
3954         (WebCore::contextMenuItemTagShowSubstitutions):
3955         (WebCore::contextMenuItemTagSmartCopyPaste):
3956         (WebCore::contextMenuItemTagSmartQuotes):
3957         (WebCore::contextMenuItemTagSmartDashes):
3958         (WebCore::contextMenuItemTagSmartLinks):
3959         (WebCore::contextMenuItemTagTextReplacement):
3960         (WebCore::contextMenuItemTagTransformationsMenu):
3961         (WebCore::contextMenuItemTagMakeUpperCase):
3962         (WebCore::contextMenuItemTagMakeLowerCase):
3963         (WebCore::contextMenuItemTagCapitalize):
3964         (WebCore::contextMenuItemTagChangeBack):
3965         (WebCore::contextMenuItemTagOpenVideoInNewWindow):
3966         (WebCore::contextMenuItemTagOpenAudioInNewWindow):
3967         (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
3968         (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
3969         (WebCore::contextMenuItemTagToggleMediaControls):
3970         (WebCore::contextMenuItemTagToggleMediaLoop):
3971         (WebCore::contextMenuItemTagEnterVideoFullscreen):
3972         (WebCore::contextMenuItemTagMediaPlay):
3973         (WebCore::contextMenuItemTagMediaPause):
3974         (WebCore::contextMenuItemTagMediaMute):
3975         (WebCore::contextMenuItemTagInspectElement):
3976         (WebCore::searchMenuNoRecentSearchesText):
3977         (WebCore::searchMenuRecentSearchesText):
3978         (WebCore::searchMenuClearRecentSearchesText):
3979         (WebCore::AXWebAreaText):
3980         (WebCore::AXLinkText):
3981         (WebCore::AXListMarkerText):
3982         (WebCore::AXImageMapText):
3983         (WebCore::AXHeadingText):
3984         (WebCore::AXDefinitionListTermText):
3985         (WebCore::AXDefinitionListDefinitionText):
3986         (WebCore::AXARIAContentGroupText):
3987         (WebCore::AXButtonActionVerb):
3988         (WebCore::AXRadioButtonActionVerb):
3989         (WebCore::AXTextFieldActionVerb):
3990         (WebCore::AXCheckedCheckBoxActionVerb):
3991         (WebCore::AXUncheckedCheckBoxActionVerb):
3992         (WebCore::AXLinkActionVerb):
3993         (WebCore::AXMenuListPopupActionVerb):
3994         (WebCore::AXMenuListActionVerb):
3995         (WebCore::missingPluginText):
3996         (WebCore::crashedPluginText):
3997         (WebCore::multipleFileUploadText):
3998         (WebCore::unknownFileSizeText):
3999         (WebCore::uploadFileText):
4000         (WebCore::allFilesText):
4001         (WebCore::keygenMenuItem512):
4002         (WebCore::keygenMenuItem1024):
4003         (WebCore::keygenMenuItem2048):
4004         (WebCore::keygenKeychainItemName):
4005         (WebCore::imageTitle):
4006         (WebCore::mediaElementLoadingStateText):
4007         (WebCore::mediaElementLiveBroadcastStateText):
4008         (WebCore::localizedMediaControlElementString):
4009         (WebCore::localizedMediaControlElementHelpText):
4010         (WebCore::localizedMediaTimeDescription):
4011         (WebCore::validationMessageValueMissingText):
4012         (WebCore::validationMessageValueMissingForCheckboxText):
4013         (WebCore::validationMessageValueMissingForFileText):
4014         (WebCore::validationMessageValueMissingForMultipleFileText):
4015         (WebCore::validationMessageValueMissingForRadioText):
4016         (WebCore::validationMessageValueMissingForSelectText):
4017         (WebCore::validationMessageTypeMismatchText):
4018         (WebCore::validationMessageTypeMismatchForEmailText):
4019         (WebCore::validationMessageTypeMismatchForMultipleEmailText):
4020         (WebCore::validationMessageTypeMismatchForURLText):
4021         (WebCore::validationMessagePatternMismatchText):
4022         (WebCore::validationMessageTooLongText):
4023         (WebCore::validationMessageRangeUnderflowText):
4024         (WebCore::validationMessageRangeOverflowText):
4025         (WebCore::validationMessageStepMismatchText):
4026
4027 2011-05-27  Brady Eidson  <beidson@apple.com>
4028
4029         Reviewed by Darin Adler.
4030
4031         First swipe at resolving <rdar://problem/9125145> and https://bugs.webkit.org/show_bug.cgi?id=61494
4032         
4033         Make the Document be intelligent about returning its DocumentLoader, including the possibility that
4034         the DocumentLoader will be null.
4035
4036         No new tests. No change in behavior.
4037
4038         Instead of storing the DocumentLoader at construction and never changing it,
4039         always calculate it based on the FrameLoader's current DocumentLoader:
4040         * dom/Document.cpp:
4041         (WebCore::Document::Document):
4042         (WebCore::Document::suggestedMIMEType):
4043         (WebCore::Document::lastModified):
4044         (WebCore::Document::initSecurityContext):
4045         (WebCore::Document::updateURLForPushOrReplaceState):
4046         (WebCore::Document::loader):
4047         * dom/Document.h:
4048
4049         Null-check or ASSERT that the DocumentLoader exists (or both) depending on the scenario:
4050         * bindings/ScriptControllerBase.cpp:
4051         (WebCore::ScriptController::executeIfJavaScriptURL):
4052         * html/MediaDocument.cpp:
4053         (WebCore::MediaDocument::replaceMediaElementTimerFired):
4054         * html/PluginDocument.cpp:
4055         (WebCore::PluginDocumentParser::createDocumentStructure):
4056         * platform/mac/HTMLConverter.mm:
4057         (fileWrapperForElement):
4058
4059         * WebCore.exp.in:
4060
4061 2011-05-27  Jer Noble  <jer.noble@apple.com>
4062
4063         Reviewed by Maciej Stachowiak.
4064
4065         30 second rewind button obscured in fullscreen controller
4066         https://bugs.webkit.org/show_bug.cgi?id=61663
4067
4068         If reset() is called while in full-screen mode, make sure to show and hide
4069         the correct controls for that mode.
4070
4071         * html/shadow/MediaControlRootElement.cpp:
4072         (WebCore::MediaControlRootElement::reset):
4073
4074 2011-05-27  James Robinson  <jamesr@chromium.org>
4075
4076         Reviewed by Simon Fraser.
4077
4078         GraphicsLayers for overflow controls on iframe without clipping layer left out of layer tree
4079         https://bugs.webkit.org/show_bug.cgi?id=61590
4080
4081         Adds overflow control layers to the compositor tree for layers without clipping layers regardless of whether the
4082         backing is parented.  This ensures that the scroll corner layer for an iframe without a clipping layer ends up
4083         in the final layer tree.  We don't currently render resizers for iframes, but we will soon and this keeps the
4084         graphics layer tree consistent.
4085
4086         Test: compositing/iframes/resizer.html
4087
4088         * rendering/RenderLayerCompositor.cpp:
4089         (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
4090
4091 2011-05-27  Adam Barth  <abarth@webkit.org>
4092
4093         Reviewed by Eric Seidel.
4094
4095         HTMLVideoElement::currentSrc() should return a KURL
4096         https://bugs.webkit.org/show_bug.cgi?id=61578
4097
4098         I suspect we got into this mess because the author of this code didn't
4099         know about the URL attribute in WebKit IDL, which is super useful!
4100
4101       &nbs