cloneChildNodes looks for deleteButtonController in each level of recursion
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2
3         cloneChildNodes looks for deleteButtonController in each level of recursion
4         https://bugs.webkit.org/show_bug.cgi?id=115146
5
6         Reviewed by Andreas Kling.
7
8         Obtain the delete button controller upfront, and shallow copy descendents of each child
9         so that we don't look for the delete button controller inside cloneNode called on each child.
10
11         Performance Tests: DOM/CloneNodes.html
12
13         * dom/ContainerNode.cpp:
14         (WebCore::cloneChildNodesAvoidingDeleteButon): Extracted.
15         (WebCore::ContainerNode::cloneChildNodes):
16
17 2013-04-25  Ryosuke Niwa  <rniwa@webkit.org>
18
19         HTMLOptionsCollection's namedItem and name getter should return the first item
20         https://bugs.webkit.org/show_bug.cgi?id=115150
21
22         Reviewed by Andreas Kling.
23
24         Following the resolution in http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2012-December/038355.html,
25         the spefication has been updated to only return the first item when there are multiple items of the same name
26         in HTMLOptionsCollection; this new behavior matches that of Firefox and Opera (Presto).
27
28         Implement this new behavior to remove the custom binding code and use the fast path in namedItem and name
29         getter of HTMLOptionsCollection. (Obtaining all items for a given name is expensive!).
30
31         Tests: fast/dom/HTMLSelectElement/named-options.html
32                fast/dom/html-collections-named-getter.html
33
34         * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
35         (WebCore): Removed the custom bindings for name getter and namedItem.
36         * html/HTMLOptionsCollection.idl:
37
38 2013-04-25  Joseph Pecoraro  <pecoraro@apple.com>
39
40         Web Inspector: ConsoleMessage should include line and column number where possible
41         https://bugs.webkit.org/show_bug.cgi?id=114929
42
43           - adds "m_column" to WebCore::ConsoleMessage
44           - adds "column" to Console.ConsoleMessage in the inspector protocol
45           - set the column number for console.* functions (Console.cpp)
46           - set the column number for XSLT errors (XSLTProcessor)
47           - plumb columnNumber everywhere else it is needed, set it to 0 and file
48             bugs for all cases missing columnNumber that could provide it.
49
50         Reviewed by Timothy Hatcher.
51
52         Test: inspector/console/console-url-line-column.html
53               inspector/console/console-messages-stack-traces.html
54
55         * inspector/ConsoleMessage.h:
56         * inspector/ConsoleMessage.cpp:
57         (WebCore::ConsoleMessage::ConsoleMessage):
58         (WebCore::ConsoleMessage::autogenerateMetadata):
59         (WebCore::ConsoleMessage::addToFrontend):
60         (WebCore::ConsoleMessage::isEqual):
61         Add m_column and set it where appropriate.
62
63         * inspector/Inspector.json:
64         Add column property to Console.ConsoleMessage.
65
66         * page/Console.cpp:
67         (WebCore::internalAddMessage):
68         (WebCore::Console::profile):
69         Set columnNumber like lineNumber from the last stack frame.
70         (WebCore::Console::groupEnd):
71         Line and column are unused in this message type, set both to 0.
72
73         * xml/XSLTProcessorLibxslt.cpp:
74         (WebCore::XSLTProcessor::parseErrorFunc):
75         * xml/XSLTProcessorQt.cpp:
76         (WebCore::XSLTMessageHandler::handleMessage):
77         Add real column numbers, the XSLT handlers already had it available.
78
79         * bindings/js/JSCustomXPathNSResolver.cpp:
80         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
81         * css/CSSParser.cpp:
82         (WebCore::CSSParser::logError):
83         * dom/ScriptExecutionContext.h:
84         * dom/ScriptExecutionContext.cpp:
85         (WebCore::ScriptExecutionContext::addConsoleMessage):
86         * dom/Document.cpp:
87         (WebCore::Document::logExceptionToConsole):
88         (WebCore::Document::addMessage):
89         * dom/Document.h:
90         * inspector/InspectorConsoleAgent.cpp:
91         (WebCore::InspectorConsoleAgent::addMessageToConsole):
92         (WebCore::InspectorConsoleAgent::stopTiming):
93         (WebCore::InspectorConsoleAgent::didFinishXHRLoading):
94         (WebCore::InspectorConsoleAgent::didReceiveResponse):
95         (WebCore::InspectorConsoleAgent::didFailLoading):
96         * inspector/InspectorConsoleAgent.h:
97         * inspector/InspectorConsoleInstrumentation.h:
98         (WebCore::InspectorInstrumentation::addMessageToConsole):
99         (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
100         * inspector/InspectorInstrumentation.cpp:
101         (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
102         (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
103         (WebCore::InspectorInstrumentation::addProfileImpl):
104         * inspector/InspectorInstrumentation.h:
105         (InspectorInstrumentation):
106         * inspector/InspectorProfilerAgent.cpp:
107         (WebCore::InspectorProfilerAgent::addProfile):
108         (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
109         (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
110         (WebCore::InspectorProfilerAgent::start):
111         (WebCore::InspectorProfilerAgent::stop):
112         * inspector/InspectorProfilerAgent.h:
113         (InspectorProfilerAgent):
114         * loader/EmptyClients.h:
115         (WebCore::EmptyChromeClient::addMessageToConsole):
116         * page/ChromeClient.h:
117         (WebCore::ChromeClient::addMessageToConsole):
118         * page/ContentSecurityPolicy.cpp:
119         (WebCore::ContentSecurityPolicy::logToConsole):
120         * page/PageConsole.cpp:
121         (WebCore::PageConsole::addMessage):
122         * page/PageConsole.h:
123         * workers/DefaultSharedWorkerRepository.cpp:
124         (SharedWorkerProxy):
125         (WebCore::postExceptionTask):
126         (WebCore::SharedWorkerProxy::postExceptionToWorkerObject):
127         (WebCore::postConsoleMessageTask):
128         (WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
129         * workers/SharedWorkerContext.cpp:
130         (WebCore::SharedWorkerContext::logExceptionToConsole):
131         * workers/WorkerContext.cpp:
132         (WebCore::WorkerContext::logExceptionToConsole):
133         (WebCore::WorkerContext::addConsoleMessage):
134         (WebCore::WorkerContext::addMessage):
135         (WebCore::WorkerContext::addMessageToWorkerConsole):
136         * workers/WorkerContext.h:
137         * workers/WorkerMessagingProxy.cpp:
138         (WebCore::WorkerExceptionTask::create):
139         (WebCore::WorkerExceptionTask::WorkerExceptionTask):
140         (WebCore::WorkerExceptionTask::performTask):
141         (WorkerExceptionTask):
142         (WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
143         (WebCore::postConsoleMessageTask):
144         (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
145         * workers/WorkerMessagingProxy.h:
146         (WorkerMessagingProxy):
147         * workers/WorkerReportingProxy.h:
148         (WorkerReportingProxy):
149         Plumb columnNumber through where appropriate. File bugs where missing.
150
151 2013-04-25  Allan Sandfeld Jensen  <allan.jensen@digia.com>
152
153         [Qt] Animated opacity does not trigger accelerated compositing
154         https://bugs.webkit.org/show_bug.cgi?id=115107
155
156         Reviewed by Simon Fraser.
157
158         Add extra option to also trigger compositing on animated opacity.
159
160         * page/ChromeClient.h:
161         * rendering/RenderLayerCompositor.cpp:
162         (WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
163
164 2013-04-25  Lamarque V. Souza  <Lamarque.Souza@basyskom.com>
165
166         Sec-WebSocket-Extensions header field must not appear more than once in an HTTP response.
167         https://bugs.webkit.org/show_bug.cgi?id=115128
168
169         Reviewed by Alexey Proskuryakov.
170
171         According to WebSocket specification Sec-WebSocket-Extensions header field
172         must not appear more than once in an HTTP response. It is ok if it appears
173         more than once in client request. Also add a check for invalid UTF-8
174         characters when parsing Sec-WebSocket-Extensions quoted string.
175
176         Test: http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header.html
177
178         * Modules/websockets/WebSocketExtensionParser.cpp:
179         (WebCore::WebSocketExtensionParser::consumeQuotedString): Return false if there is
180         invalid character in the quoted string being parsed.
181         * Modules/websockets/WebSocketHandshake.cpp:
182         (WebCore::WebSocketHandshake::readHTTPHeaders): Check if Sec-WebSocket-Extensions
183         appears more than once in header response. Abort handshake if it does.
184
185 2013-04-25  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
186
187         REGRESSION(r148758): Remove WTFLogAlways call from IconLoader.
188         https://bugs.webkit.org/show_bug.cgi?id=115182
189
190         Reviewed by Dan Bernstein.
191
192         The call added in r148758 was apparently a leftover from some debugging
193         session, and it makes the Interactive/window-resize.html performance
194         test randomly fail on Qt and EFL due to WTFLogAlways writing to stderr.
195
196         * loader/icon/IconLoader.cpp:
197         (WebCore::IconLoader::notifyFinished):
198
199 2013-04-25  Christophe Dumez  <ch.dumez@sisa.samsung.com>
200
201         Add support for Web IDL callback interfaces to the bindings generator
202         https://bugs.webkit.org/show_bug.cgi?id=115179
203
204         Reviewed by Kentaro Hara.
205
206         Add support in the bindings generator for Web IDL callback interfaces:
207         http://dev.w3.org/2006/webapi/WebIDL/#dfn-callback-interface
208
209         Drop support for the WebKit-specific [Callback] extended attributes
210         on Web IDL interfaces and update existing IDL files to use proper
211         callback interfaces instead.
212
213         No new tests, no behavior change.
214
215         * Modules/filesystem/EntriesCallback.idl:
216         * Modules/filesystem/EntryCallback.idl:
217         * Modules/filesystem/ErrorCallback.idl:
218         * Modules/filesystem/FileCallback.idl:
219         * Modules/filesystem/FileSystemCallback.idl:
220         * Modules/filesystem/FileWriterCallback.idl:
221         * Modules/filesystem/MetadataCallback.idl:
222         * Modules/geolocation/PositionCallback.idl:
223         * Modules/geolocation/PositionErrorCallback.idl:
224         * Modules/mediastream/NavigatorUserMediaErrorCallback.idl:
225         * Modules/mediastream/NavigatorUserMediaSuccessCallback.idl:
226         * Modules/mediastream/RTCErrorCallback.idl:
227         * Modules/mediastream/RTCSessionDescriptionCallback.idl:
228         * Modules/mediastream/RTCStatsCallback.idl:
229         * Modules/notifications/NotificationPermissionCallback.idl:
230         * Modules/quota/StorageErrorCallback.idl:
231         * Modules/quota/StorageQuotaCallback.idl:
232         * Modules/quota/StorageUsageCallback.idl:
233         * Modules/webaudio/AudioBufferCallback.idl:
234         * Modules/webdatabase/DatabaseCallback.idl:
235         * Modules/webdatabase/SQLStatementCallback.idl:
236         * Modules/webdatabase/SQLStatementErrorCallback.idl:
237         * Modules/webdatabase/SQLTransactionCallback.idl:
238         * Modules/webdatabase/SQLTransactionErrorCallback.idl:
239         * Modules/webdatabase/SQLTransactionSyncCallback.idl:
240         * bindings/scripts/CodeGeneratorJS.pm:
241         (GenerateInterface):
242         * bindings/scripts/IDLParser.pm:
243         (parseCallbackRestOrInterface):
244         * bindings/scripts/test/TestCallback.idl:
245         * dom/RequestAnimationFrameCallback.idl:
246         * dom/StringCallback.idl:
247         * html/VoidCallback.idl:
248
249 2013-04-25  Adrian Perez de Castro  <aperez@igalia.com>
250
251         [GStreamer] Add audio/speex MIME type as supported
252         https://bugs.webkit.org/show_bug.cgi?id=115032
253
254         Reviewed by Philippe Normand.
255
256         GStreamer has support for the Speex codec (http://www.speex.org).
257         Speex streams may be embedded in a Ogg container, or standalone.
258         The case of the Ogg container is already covered by the "*/ogg"
259         MIME types declared as supported by the GStreamer media playing
260         code, but for standalone streams to work, "audio/speex" has to
261         be added.
262
263         With this, and the needed GStreamer plugin installed, the GTK+
264         launcher is able to correctly play Speex streams served with
265         "Content-type: audio/speex".
266
267         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
268
269 2013-04-25  Andreas Kling  <akling@apple.com>
270
271         Add FINAL decorators to the InlineBox class hierarchy.
272         <http://webkit.org/b/115177>
273
274         Reviewed by Antti Koivisto.
275
276         From Blink r148628 by <cevans@chromium.org>:
277
278         FINAL is a macro in wtf/Compiler.h that does the correct thing if the compiler does not support "final")
279         The approach used is as simple as possible whilst being thorough.
280         So, leaf classes have FINAL applied to the whole class whereas intermediary classes have FINAL applied to relevant methods.
281
282         FINAL allows a compiler to devirtualize call sites and turn them into direct calls. As you might expect, this is perf positive:
283         (clang on Linux):
284         - line_layout.html goes from 120 runs/s -> 123 runs/2, +2.5%
285         - html5-full-render.html goes from 3176ms -> 3162ms, +0.4%
286
287         I have confidence that the former result is statistically significant (as the numbers are very very stable) but not the latter.
288
289         * rendering/EllipsisBox.h:
290         * rendering/InlineFlowBox.h:
291         * rendering/InlineTextBox.h:
292         * rendering/RootInlineBox.h:
293         * rendering/TrailingFloatsRootInlineBox.h:
294         * rendering/svg/SVGInlineFlowBox.h:
295         * rendering/svg/SVGInlineTextBox.h:
296         * rendering/svg/SVGRootInlineBox.h:
297
298 2013-04-25  Andreas Kling  <akling@apple.com>
299
300         CSS parser: Add error recovery while parsing @-webkit-keyframes key values.
301         <http://webkit.org/b/115175>
302
303         From Blink r148714 by <apavlov@chromium.org>:
304
305         If not a percentage, "from", or "to" value is used in a key list, the rule is erroneous,
306         and due to the absense of recovery, the parser skips the following, valid CSS rule.
307
308         On a related note, keyframes, whose selectors contain invalid keys, should be discarded
309         altogether, according to <http://www.w3.org/TR/css3-animations/#keyframes>
310
311         Tests: animations/keyframes-invalid-keys.html
312                fast/css/webkit-keyframes-errors.html
313
314         * css/CSSGrammar.y.in:
315         * css/CSSParser.cpp:
316         (WebCore::CSSParser::rewriteSpecifiers):
317
318 2013-04-25  Antti Koivisto  <antti@apple.com>
319
320         REGRESSION (r147797): Animations slideshows of images on www.thesuperficial.com are slow
321         https://bugs.webkit.org/show_bug.cgi?id=115172
322
323         Reviewed by Andreas Kling.
324
325         On this page ads dynamically loaded to subframes on slideshow navigation switch us to state where we throttle layer flushes.
326         
327         Fix by ignoring any subframe-originated loads when determining throttling.
328
329         * loader/FrameLoader.cpp:
330         (WebCore::FrameLoader::loadProgressingStatusChanged):
331         * loader/ProgressTracker.cpp:
332         (WebCore::ProgressTracker::isMainLoadProgressing):
333         
334             Rename, ignore subframe originated loads. Subframe loads that are initiated during the main load still count.
335
336         * loader/ProgressTracker.h:
337         (ProgressTracker):
338         * page/FrameView.cpp:
339         (WebCore::FrameView::updateLayerFlushThrottlingInAllFrames):
340         * page/FrameView.h:
341         (FrameView):
342         * rendering/RenderLayerBacking.cpp:
343         (WebCore::computeTileCoverage):
344
345 2013-04-25  Andreas Kling  <akling@apple.com>
346
347         SVG: Fix viewBox animations on shapes with non-scaling-stroke.
348         <http://webkit.org/b/115173>
349
350         From Blink r149058 by <pdr@chromium.org>:
351
352         Previously hasAttribute() to determine if a viewBox was set in the transform
353         code for non-scaling-strokes. hasAttribute() should not be used in this case,
354         as it will return false if the attribute is not set but the value is animating.
355
356         This patch switches to checking if the viewBox is empty instead of checking for
357         the presence of the attribute.
358
359         Test: svg/stroke/animated-non-scaling-stroke.html
360
361         * svg/SVGSVGElement.cpp:
362         (WebCore::SVGSVGElement::localCoordinateSpaceTransform):
363         * svg/SVGSVGElement.h:
364         (WebCore::SVGSVGElement::hasEmptyViewBox):
365
366 2013-04-25  Andreas Kling  <akling@apple.com>
367
368         Remove isPluginElement hack in Document::setFocusedNode()
369         <http://webkit.org/b/115171>
370
371         From Blink r148800 by <tkent@chromium.org>:
372
373         This hack is no longer necessary because r147591 made isFocusable for plugin
374         elements work correctly.
375
376         * dom/Document.cpp:
377         (WebCore::Document::setFocusedNode):
378
379 2013-04-25  Per-Erik Brodin  <per-erik.brodin@ericsson.com>
380
381         EventSource: Synchronous loader callback not handled properly
382         https://bugs.webkit.org/show_bug.cgi?id=115104
383
384         When attempting a cross-origin request towards a non-HTTP URL, an early verification
385         of the protocol scheme will cause didFailAccessControlCheck to be called synchronously
386         before the loader has even finished being created. This special case was not handled
387         properly, since we tried to cancel a non-existing loader, which resulted in a crash.
388         In addition to checking whether a request is in flight before trying to cancel it,
389         this change also schedules the initial creation of the loader to happen asynchronously
390         when an EventSource is constructed, so that a script can register for the error event
391         before it is dispatched (as a result of passing a non-HTTP URL to the constructor).
392
393         Reviewed by Alexey Proskuryakov.
394
395         Test: http/tests/eventsource/eventsource-cors-non-http.html
396
397         * page/EventSource.cpp:
398         (WebCore::EventSource::EventSource):
399         (WebCore::EventSource::create):
400         (WebCore::EventSource::scheduleInitialConnect):
401         (WebCore):
402         (WebCore::EventSource::scheduleReconnect):
403         (WebCore::EventSource::connectTimerFired):
404         (WebCore::EventSource::close):
405         (WebCore::EventSource::abortConnectionAttempt):
406         * page/EventSource.h:
407         (EventSource):
408
409 2013-04-25  Patrick Gansterer  <paroga@webkit.org>
410
411         Unreviewed WinCE build fix after r148545.
412
413         * page/wince/FrameWinCE.cpp:
414
415 2013-04-24  Kent Tamura  <tkent@chromium.org>
416
417         Back references don't work in pattern attribute
418         https://bugs.webkit.org/show_bug.cgi?id=105875
419
420         Reviewed by Geoffrey Garen.
421
422         This imports a part of Blink r148951.
423
424         Tests: Update fast/forms/ValidityState-patternMismatch.html
425
426         * html/BaseTextInputType.cpp:
427         (WebCore::BaseTextInputType::patternMismatch):
428         Don't use capturing parentheses. They affected back references in
429         pattern attribute values.
430
431 2013-04-24  Tim Horton  <timothy_horton@apple.com>
432
433         PDFPlugin: Cursor should become an i-beam when over selectable text
434         https://bugs.webkit.org/show_bug.cgi?id=115018
435         <rdar://problem/12645012>
436
437         Reviewed by Alexey Proskuryakov.
438
439         * WebCore.exp.in: Export the I-beam and arrow cursors.
440
441 2013-04-24  Simon Fraser  <simon.fraser@apple.com>
442
443         Garbage at the top of http://www.technologyreview.com after scrolling
444         https://bugs.webkit.org/show_bug.cgi?id=114825
445
446         Reviewed by Tim Horton.
447
448         Garbage pixels are caused by GraphicsLayerCA setting a layer to be opaque,
449         but then not painting anything into it. On this page, the element is
450         toggled to be visibility:hidden on scrolling, but RenderLayer::backgroundIsKnownToBeOpaqueInRect()
451         failed to consider that as something that can cause backgrounds not to be opaque.
452         
453         For the bug to happen, some subtle interactions with r142012 come into play
454         for the layer to remain visible, hence the slightly complex testcase.
455         
456         Test: compositing/contents-opaque/visibility-hidden.html
457
458         * rendering/RenderLayer.cpp:
459         (WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):
460
461 2013-04-24  Simon Fraser  <simon.fraser@apple.com>
462
463         Dump layer opaqueness in the Compositing log output
464         https://bugs.webkit.org/show_bug.cgi?id=115132
465
466         Reviewed by Tim Horton.
467
468         It's useful to see whether we consider layers to be opaque in the Compositing
469         log channel output, so dump it.
470
471         * rendering/RenderLayerCompositor.cpp:
472         (WebCore::RenderLayerCompositor::logLayerInfo):
473
474 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
475
476         Add efl to JSInspectorFrontendHost::port()
477         https://bugs.webkit.org/show_bug.cgi?id=115137
478
479         Reviewed by Timothy Hatcher.
480
481         No new tests, because there is no change in behavior.
482
483         * bindings/js/JSInspectorFrontendHostCustom.cpp:
484         (WebCore::JSInspectorFrontendHost::port):
485
486 2013-04-24  Kangil Han  <kangil.han@samsung.com>
487
488         Function parameter quotePair can be passed by reference
489         https://bugs.webkit.org/show_bug.cgi?id=115089
490
491         Reviewed by Alexey Proskuryakov.
492
493         Minor performance patch.
494
495         * rendering/style/QuotesData.cpp:
496         (WebCore::QuotesData::addPair):
497         * rendering/style/QuotesData.h:
498         (QuotesData):
499
500 2013-04-24  Brady Eidson  <beidson@apple.com>
501
502         Implementors of CachedResource subclasses should be forced to decide if encoded data can be replaced.
503         https://bugs.webkit.org/show_bug.cgi?id=115140
504
505         Reviewed by Beth Dakin.
506
507         No new tests (No behavior change).
508
509         This makes mayTryReplaceEncodedData() return false in CachedResource, but overrides to true
510         in all CachedResource subclasses besides CachedFont (which already has an implementation).
511
512         * loader/cache/CachedCSSStyleSheet.h:
513         * loader/cache/CachedImage.h:
514         * loader/cache/CachedRawResource.h:
515         * loader/cache/CachedResource.h:
516         * loader/cache/CachedSVGDocument.h:
517         * loader/cache/CachedScript.h:
518         * loader/cache/CachedShader.h:
519         * loader/cache/CachedTextTrack.h:
520         * loader/cache/CachedXSLStyleSheet.h:
521
522 2013-04-24  Brady Eidson  <beidson@apple.com>
523
524         Once a custom font is cached to disk, it starts failing to render until the page is refreshed.
525         <rdar://problem/13622998> and https://bugs.webkit.org/show_bug.cgi?id=115131
526
527         Reviewed by Alexey Proskuryakov.
528
529         No new tests (Not a tested config, nor are disk cache issues currently testable).
530
531         * loader/cache/CachedResource.h:
532         (WebCore::CachedResource:: mayTryReplaceEncodedData): Allow subclasses to refuse encoded data replacement.
533
534         * loader/cache/CachedResource.cpp:
535         (WebCore::CachedResource::tryReplaceEncodedData): Only try if shouldTryReplaceEncodedData() is true.
536
537         * loader/cache/CachedFont.cpp:
538         (WebCore::CachedFont::CachedFont):
539         (WebCore::CachedFont::ensureCustomFontData):
540         (WebCore::CachedFont::mayTryReplaceEncodedData): Return false if the custom font data has ever been created.
541         * loader/cache/CachedFont.h:
542
543 2013-04-24  Beth Dakin  <bdakin@apple.com>
544
545         Vertical overlay scrollbar in iframes fades in and out rapidly when you scroll in 
546         a circle
547         https://bugs.webkit.org/show_bug.cgi?id=115124
548         -and corresponding-
549         <rdar://problem/13168957>
550
551         Reviewed by Anders Carlsson.
552
553         With http://trac.webkit.org/changeset/119834 we started calling 
554         ScrollbarPainterController's contentAreaScrolled/contentAreaScrolledInDirection 
555         API on a zero-delay timer instead of calling it right away. This prevented some 
556         crashes that we saw whenever this was called during a layout. However, that delay, 
557         combined with the particulars of contentAreaScrolledInDirection cause this bug 
558         where sometimes the scrollbars in an iframe will fade out very noticeably when 
559         scrolling in a circle.
560
561         This change makes it so we will only use the zero-delay timer if the 
562         ScrollableArea is not currently handling a wheel event. If it IS handling a wheel 
563         event, then we will send the notifications to AppKit right away. I confirmed that 
564         this change did not reintroduce the old crashes. 
565
566         Keep track of whether we are currently handling a wheel event with the new member 
567         variable m_isHandlingWheelEvent.
568         * page/EventHandler.cpp:
569         (WebCore::EventHandler::EventHandler):
570         (WebCore::EventHandler::handleWheelEvent):
571         * page/EventHandler.h:
572         (WebCore::EventHandler::isHandlingWheelEvent):
573         (EventHandler):
574
575         To prevent layering violations, the ScrollableArea sub-classes will have to access 
576         this information from the EventHandler.
577         * page/FrameView.cpp:
578         (WebCore::FrameView::isHandlingWheelEvent):
579         * page/FrameView.h:
580         * platform/ScrollableArea.h:
581         (WebCore::ScrollableArea::isHandlingWheelEvent):
582         * rendering/RenderLayer.cpp:
583         (WebCore::RenderLayer::isHandlingWheelEvent):
584         * rendering/RenderLayer.h:
585         (RenderLayer):
586         * rendering/RenderListBox.cpp:
587         (WebCore::RenderListBox::isHandlingWheelEvent):
588         * rendering/RenderListBox.h:
589
590         sendContentAreaScrolledSoon() can be private. Also add new function 
591         sendContentAreaScrolled().
592         * platform/mac/ScrollAnimatorMac.h:
593         (ScrollAnimatorMac):
594
595         If the ScrollableArea is handling a wheel event, call 
596         sendContentAreaScrolled(), otherwise call sendContentAreaScrolledSoon()
597         * platform/mac/ScrollAnimatorMac.mm:
598         (WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
599         (WebCore::ScrollAnimatorMac::sendContentAreaScrolled):
600
601         Re-factored to use sendContentAreaScrolled()
602         (WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):
603
604 2013-04-24  Ryosuke Niwa  <rniwa@webkit.org>
605
606         Fix a merge error in r149007 (was missing a null check added in r148777).
607
608         * rendering/LogicalSelectionOffsetCaches.h:
609         (WebCore::containingBlockForAbsolutePosition):
610
611 2013-04-24  Otto Derek Cheung  <otcheung@rim.com>
612
613         Battery API won't return updated battery status until client calls didChangeBatteryStatus
614         https://bugs.webkit.org/show_bug.cgi?id=114891
615
616         Reviewed by Rob Buis.
617
618         The BatteryStatus object in BatteryManager won't get updated until BatteryClient calls
619         didChangeBatteryStatus in BatteryController. Any attempts to call webkitBattery.charged()
620         or other get functions will always return the default values until the next battery status
621         change object gets passed to the controller.
622
623         We need to update the manager when we attach it to the controller, and update all
624         existing managers when the controller receives it's first battery status object.
625
626         * Modules/battery/BatteryController.cpp:
627         (WebCore::BatteryController::addListener):
628         (WebCore::BatteryController::updateBatteryStatus):
629         * Modules/battery/BatteryManager.cpp:
630         (WebCore::BatteryManager::didChangeBatteryStatus):
631         (WebCore::BatteryManager::updateBatteryStatus):
632         (WebCore):
633         * Modules/battery/BatteryManager.h:
634         (BatteryManager):
635
636 2013-04-24  Jacky Jiang  <zhajiang@blackberry.com>
637
638         Clean up unused code in ViewportArguments.h
639         https://bugs.webkit.org/show_bug.cgi?id=115121
640
641         Reviewed by Benjamin Poulain.
642
643         The target-densityDPI emulation implementation has been removed by
644         r147893, so clean up the remaining code as well.
645
646         * dom/ViewportArguments.h:
647
648 2013-04-24  Andreas Kling  <akling@apple.com>
649
650         ElementData should use 'unsigned' attribute indices.
651         <http://webkit.org/b/115103>
652
653         Reviewed by Antti Koivisto.
654
655         Switch to using 'unsigned' for attribute indices. This gives consistent behavior
656         on 32/64-bit, and the underlying storage is already limited by Vector's 32-bit capacity.
657
658         Added an ElementData::attributeNotFound constant (-1) since we can't use WTF::notFound.
659
660         * dom/Element.cpp:
661         (WebCore::Element::detachAttribute):
662         (WebCore::Element::removeAttribute):
663         (WebCore::Element::setAttribute):
664         (WebCore::Element::setSynchronizedLazyAttribute):
665         (WebCore::Element::setAttributeInternal):
666         (WebCore::Element::setAttributeNode):
667         (WebCore::Element::removeAttributeNode):
668         (WebCore::Element::removeAttributeInternal):
669         (WebCore::UniqueElementData::removeAttribute):
670         (WebCore::ElementData::getAttributeItemIndexSlowCase):
671         * dom/Element.h:
672         (ElementData):
673         (UniqueElementData):
674         (Element):
675         (WebCore::Element::getAttributeItemIndex):
676         (WebCore::Element::attributeCount):
677         (WebCore::ElementData::length):
678         (WebCore::ElementData::getAttributeItem):
679         (WebCore::ElementData::getAttributeItemIndex):
680         * dom/NamedNodeMap.cpp:
681         (WebCore::NamedNodeMap::removeNamedItem):
682         (WebCore::NamedNodeMap::removeNamedItemNS):
683         (WebCore::NamedNodeMap::length):
684         * dom/NamedNodeMap.h:
685         (NamedNodeMap):
686
687 2013-04-24  Andreas Kling  <akling@apple.com>
688
689         ElementData::attributeItem() should bounds-check the index.
690         <http://webkit.org/b/115076>
691
692         Reviewed by Antti Koivisto.
693
694         Switch the ASSERT_WITH_SECURITY_IMPLICATION to a RELEASE_ASSERT.
695
696         * dom/Element.h:
697         (WebCore::ElementData::attributeItem):
698
699 2013-04-23  Andreas Kling  <akling@apple.com>
700
701         Setting an inline style property to "" shouldn't cause style recalc unless the property was present.
702         <http://webkit.org/b/115122>
703
704         Reviewed by Antti Koivisto.
705
706         StylePropertySet::setProperty() handles empty strings by removing the property entirely.
707         If there was no property to remove, it shouldn't claim that it changed something, as that
708         will cause the CSSOM wrapper to mark the element for style recalc.
709
710         A common idiom that triggers this is excessive use of { element.style.display = ''; }
711
712         * css/StylePropertySet.cpp:
713         (WebCore::MutableStylePropertySet::setProperty):
714
715 2013-04-23  Ryosuke Niwa  <rniwa@webkit.org>
716
717         Moving word boundaries backwards fails when there is a text node starting with an apostrophe
718         https://bugs.webkit.org/show_bug.cgi?id=115070
719
720         Reviewed by Alexey Proskuryakov.
721
722         The bug was caused by previousBoundary erroneously assuming that we don't need any more context if a word
723         boundary is found at the beginning of a string. For example, when "I'll" is split into two text nodes,
724         "I" and "'ll", there is a word boundary between "'" and "ll" in "'ll" so we need to examine the whole "I'll".
725
726         Fixed the bug by obtaining more context when the character starts exactly at offset 1 in a text node to
727         work around this bug. In the long term, we probably need to provide Foundation of the entire context since in
728         languages like Hebrew and some of European languages, there could be many accents and combining characters
729         between split into multiple text nodes as one variant is seen in the newly added test case.
730
731         Test: editing/selection/previous-word-boundary-across-text-nodes.html
732
733         * editing/VisibleUnits.cpp:
734         (WebCore::previousBoundary):
735
736 2013-04-24  Benjamin Poulain  <bpoulain@apple.com>
737
738         Do not use static string in DiagnosticLoggingKeys
739         https://bugs.webkit.org/show_bug.cgi?id=115093
740
741         Reviewed by Andreas Kling.
742
743         The code is not hot enough to justify keeping the memory around.
744         This removes 3kb from the binary on x86_64.
745
746         * page/DiagnosticLoggingKeys.cpp:
747         (WebCore::DiagnosticLoggingKeys::mediaLoadedKey):
748         (WebCore::DiagnosticLoggingKeys::mediaLoadingFailedKey):
749         (WebCore::DiagnosticLoggingKeys::pluginLoadedKey):
750         (WebCore::DiagnosticLoggingKeys::pluginLoadingFailedKey):
751         (WebCore::DiagnosticLoggingKeys::pageContainsPluginKey):
752         (WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOnePluginKey):
753         (WebCore::DiagnosticLoggingKeys::pageContainsMediaEngineKey):
754         (WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOneMediaEngineKey):
755         (WebCore::DiagnosticLoggingKeys::passKey):
756         (WebCore::DiagnosticLoggingKeys::failKey):
757         (WebCore::DiagnosticLoggingKeys::noopKey):
758         * page/DiagnosticLoggingKeys.h:
759         (DiagnosticLoggingKeys):
760
761 2013-04-24  Benjamin Poulain  <benjamin@webkit.org>
762
763         Remove wxWebKit #ifdefs from WebCore/platform/graphics
764         https://bugs.webkit.org/show_bug.cgi?id=115081
765
766         Reviewed by Geoffrey Garen.
767
768         * platform/graphics/BitmapImage.h:
769         (BitmapImage):
770         * platform/graphics/Color.h:
771         (Color):
772         * platform/graphics/FloatRect.h:
773         (FloatRect):
774         * platform/graphics/FloatSize.h:
775         (FloatSize):
776         * platform/graphics/FontPlatformData.h:
777         * platform/graphics/GlyphBuffer.h:
778         (WebCore):
779         (WebCore::GlyphBuffer::glyphAt):
780         (WebCore::GlyphBuffer::add):
781         * platform/graphics/Gradient.h:
782         * platform/graphics/GraphicsContext.h:
783         (GraphicsContext):
784         * platform/graphics/Image.cpp:
785         (WebCore::Image::drawTiled):
786         * platform/graphics/ImageBufferData.h:
787         * platform/graphics/IntPoint.h:
788         (IntPoint):
789         * platform/graphics/IntRect.h:
790         * platform/graphics/IntSize.h:
791         (IntSize):
792         * platform/graphics/NativeImagePtr.h:
793         (WebCore):
794         * platform/graphics/Path.h:
795         * platform/graphics/Pattern.h:
796         * platform/graphics/SimpleFontData.h:
797         (SimpleFontData):
798         (WebCore::SimpleFontData::widthForGlyph):
799         * platform/graphics/mac/ComplexTextController.cpp:
800         (WebCore::ComplexTextController::collectComplexTextRuns):
801         * platform/graphics/mac/ComplexTextControllerCoreText.mm:
802         (WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
803         * platform/graphics/transforms/AffineTransform.h:
804         (AffineTransform):
805         * platform/graphics/transforms/TransformationMatrix.h:
806         (TransformationMatrix):
807
808 2013-04-24  Benjamin Poulain  <benjamin@webkit.org>
809
810         Remove wxWebKit #ifdefs from WebCore/plugins
811         https://bugs.webkit.org/show_bug.cgi?id=115080
812
813         Reviewed by Geoffrey Garen.
814
815         * plugins/PluginView.h:
816         (PluginView):
817         * plugins/mac/PluginViewMac.mm:
818         (WebCore::nativeWindowFor):
819         (WebCore::cgHandleFor):
820         (WebCore::topLevelOffsetFor):
821         (WebCore::PluginView::platformStart):
822         * plugins/win/PluginViewWin.cpp:
823         (windowHandleForPageClient):
824         (WebCore::PluginView::handleMouseEvent):
825         (WebCore::PluginView::platformStart):
826         (WebCore::PluginView::snapshot):
827
828 2013-04-24  Benjamin Poulain  <benjamin@webkit.org>
829
830         Remove wxWebKit #ifdefs from WebCore/page
831         https://bugs.webkit.org/show_bug.cgi?id=115079
832
833         Reviewed by Geoffrey Garen.
834
835         * page/FrameView.cpp:
836         (WebCore::FrameView::wheelEvent):
837         * page/Settings.cpp:
838         (WebCore):
839         * page/Settings.h:
840         (Settings):
841
842 2013-04-24  Chris Fleizach  <cfleizach@apple.com>
843
844         AX: WAI-ARIA landmarks no longer speak type of landmark on iOS
845         https://bugs.webkit.org/show_bug.cgi?id=114547
846
847         Reviewed by David Kilzer.
848
849         We want iOS to speak the landmark type.
850         I've moved the landmark role description to the base Mac class and exposed
851         these localized strings to iOS (the ones used to return landmark descriptions).
852
853         I've also updated the accessibilityLabel to account for landmark type, but also
854         handle multiple label sources more gracefully by appending commas, which changed a few
855         tests in minor ways.
856
857         Test: platform/iphone-simulator/accessibility/landmark-type.html
858
859         * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
860         (-[WebAccessibilityObjectWrapper accessibilityLabel]):
861         * accessibility/mac/WebAccessibilityObjectWrapperBase.h:
862         * accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
863         (-[WebAccessibilityObjectWrapperBase ariaLandmarkRoleDescription]):
864         * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
865         (-[WebAccessibilityObjectWrapper roleDescription]):
866         * platform/LocalizedStrings.cpp:
867         (WebCore):
868         (WebCore::AXButtonActionVerb):
869         (WebCore::AXRadioButtonActionVerb):
870         (WebCore::AXTextFieldActionVerb):
871         (WebCore::AXCheckedCheckBoxActionVerb):
872         (WebCore::AXUncheckedCheckBoxActionVerb):
873         (WebCore::AXLinkActionVerb):
874         (WebCore::AXMenuListPopupActionVerb):
875         (WebCore::AXMenuListActionVerb):
876         * platform/LocalizedStrings.h:
877         (WebCore):
878
879 2013-04-24  Andreas Kling  <akling@apple.com>
880
881         CSS attribute selectors cause unnecessary style recalc when setting attribute to same value.
882         <http://webkit.org/b/115116>
883         <rdar://problem/13727709>
884
885         Reviewed by Simon Fraser.
886
887         The logic that dirties the style if there's a relevant attribute selector in the document
888         shouldn't run if the attribute is being overwritten with an identical value.
889         Move this into willModifyAttribute() instead, since we need access to both the old and the new value.
890
891         This reduces unnecessary style recalculation in Mac App Store content.
892
893         * dom/Element.cpp:
894         (WebCore::Element::attributeChanged):
895         (WebCore::Element::willModifyAttribute):
896
897 2013-04-24  Jonathan Feldstein <jfeldstein@blackberry.com>
898
899         [BlackBerry] Fixes the San Angeles demo on khronos.org
900         https://bugs.webkit.org/show_bug.cgi?id=115106
901
902         Reviewed by Rob Buis
903         Internally Reviewed by Jeremy Nicholl and Arvid Nilsson
904
905         Fixes a bug in which the currently bound vertex array object's vertex array
906         state was being modified as opposed to the default vertex array state.
907
908         * platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:
909         (EGLImageLayerWebKitThread::blitToFrontBuffer):
910
911 2013-04-24  Nico Weber  <thakis@chromium.org>
912
913         Fold RenderThemeMacShared into RenderThemeMac
914         https://bugs.webkit.org/show_bug.cgi?id=115086
915
916         Reviewed by Anders Carlsson.
917
918         No intended functionality change.
919
920         * WebCore.xcodeproj/project.pbxproj:
921         * rendering/RenderThemeMac.h:
922         (RenderThemeMac):
923         (WebCore::RenderThemeMac::supportsControlTints):
924         (WebCore::RenderThemeMac::scrollbarControlSizeForPart):
925         (WebCore::RenderThemeMac::supportsSelectionForegroundColors):
926         (WebCore::RenderThemeMac::supportsClosedCaptioning):
927         (WebCore::RenderThemeMac::updateActiveState):
928         * rendering/RenderThemeMac.mm:
929         (-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
930         (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]):
931         (-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:]):
932         (WebCore::RenderThemeMac::RenderThemeMac):
933         (WebCore::RenderThemeMac::~RenderThemeMac):
934         (WebCore::RenderThemeMac::platformActiveSelectionBackgroundColor):
935         (WebCore):
936         (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor):
937         (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor):
938         (WebCore::RenderThemeMac::platformActiveListBoxSelectionForegroundColor):
939         (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor):
940         (WebCore::RenderThemeMac::platformFocusRingColor):
941         (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):
942         (WebCore::toFontWeight):
943         (WebCore::RenderThemeMac::systemFont):
944         (WebCore::convertNSColorToColor):
945         (WebCore::menuBackgroundColor):
946         (WebCore::RenderThemeMac::platformColorsDidChange):
947         (WebCore::RenderThemeMac::systemColor):
948         (WebCore::RenderThemeMac::usesTestModeFocusRingColor):
949         (WebCore::RenderThemeMac::isControlStyled):
950         (WebCore::RenderThemeMac::adjustRepaintRect):
951         (WebCore::RenderThemeMac::inflateRect):
952         (WebCore::RenderThemeMac::convertToPaintingRect):
953         (WebCore::RenderThemeMac::updateCheckedState):
954         (WebCore::RenderThemeMac::updateEnabledState):
955         (WebCore::RenderThemeMac::updateFocusedState):
956         (WebCore::RenderThemeMac::updatePressedState):
957         (WebCore::RenderThemeMac::controlSupportsTints):
958         (WebCore::RenderThemeMac::controlSizeForFont):
959         (WebCore::RenderThemeMac::setControlSize):
960         (WebCore::RenderThemeMac::sizeForFont):
961         (WebCore::RenderThemeMac::sizeForSystemFont):
962         (WebCore::RenderThemeMac::setSizeFromFont):
963         (WebCore::RenderThemeMac::setFontFromControlSize):
964         (WebCore::RenderThemeMac::controlSizeForSystemFont):
965         (WebCore::RenderThemeMac::paintTextField):
966         (WebCore::RenderThemeMac::adjustTextFieldStyle):
967         (WebCore::RenderThemeMac::paintCapsLockIndicator):
968         (WebCore::RenderThemeMac::paintTextArea):
969         (WebCore::RenderThemeMac::adjustTextAreaStyle):
970         (WebCore::RenderThemeMac::popupButtonMargins):
971         (WebCore::RenderThemeMac::popupButtonSizes):
972         (WebCore::RenderThemeMac::popupButtonPadding):
973         (WebCore::RenderThemeMac::paintMenuList):
974         (WebCore::RenderThemeMac::meterSizeForBounds):
975         (WebCore::RenderThemeMac::paintMeter):
976         (WebCore::RenderThemeMac::supportsMeter):
977         (WebCore::RenderThemeMac::levelIndicatorStyleFor):
978         (WebCore::RenderThemeMac::levelIndicatorFor):
979         (WebCore::RenderThemeMac::progressBarSizes):
980         (WebCore::RenderThemeMac::progressBarMargins):
981         (WebCore::RenderThemeMac::minimumProgressBarHeight):
982         (WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar):
983         (WebCore::RenderThemeMac::animationDurationForProgressBar):
984         (WebCore::RenderThemeMac::adjustProgressBarStyle):
985         (WebCore::RenderThemeMac::paintProgressBar):
986         (WebCore::TopGradientInterpolate):
987         (WebCore::BottomGradientInterpolate):
988         (WebCore::MainGradientInterpolate):
989         (WebCore::TrackGradientInterpolate):
990         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
991         (WebCore::RenderThemeMac::paintMenuListButton):
992         (WebCore::menuListButtonSizes):
993         (WebCore::RenderThemeMac::adjustMenuListStyle):
994         (WebCore::RenderThemeMac::popupInternalPaddingLeft):
995         (WebCore::RenderThemeMac::popupInternalPaddingRight):
996         (WebCore::RenderThemeMac::popupInternalPaddingTop):
997         (WebCore::RenderThemeMac::popupInternalPaddingBottom):
998         (WebCore::RenderThemeMac::adjustMenuListButtonStyle):
999         (WebCore::RenderThemeMac::setPopupButtonCellState):
1000         (WebCore::RenderThemeMac::menuListSizes):
1001         (WebCore::RenderThemeMac::minimumMenuListSize):
1002         (WebCore::RenderThemeMac::adjustSliderTrackStyle):
1003         (WebCore::RenderThemeMac::paintSliderTrack):
1004         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
1005         (WebCore::RenderThemeMac::paintSliderThumb):
1006         (WebCore::RenderThemeMac::paintSearchField):
1007         (WebCore::RenderThemeMac::setSearchCellState):
1008         (WebCore::RenderThemeMac::searchFieldSizes):
1009         (WebCore::RenderThemeMac::setSearchFieldSize):
1010         (WebCore::RenderThemeMac::adjustSearchFieldStyle):
1011         (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
1012         (WebCore::RenderThemeMac::cancelButtonSizes):
1013         (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
1014         (WebCore::RenderThemeMac::resultsButtonSizes):
1015         (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
1016         (WebCore::RenderThemeMac::paintSearchFieldDecoration):
1017         (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
1018         (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
1019         (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
1020         (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
1021         (WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):
1022         (WebCore::RenderThemeMac::sliderTickSize):
1023         (WebCore::RenderThemeMac::sliderTickOffsetFromTrackCenter):
1024         (WebCore::RenderThemeMac::adjustSliderThumbSize):
1025         (WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):
1026         (WebCore::RenderThemeMac::popupButton):
1027         (WebCore::RenderThemeMac::search):
1028         (WebCore::RenderThemeMac::searchMenuTemplate):
1029         (WebCore::RenderThemeMac::sliderThumbHorizontal):
1030         (WebCore::RenderThemeMac::sliderThumbVertical):
1031         (WebCore::RenderThemeMac::textField):
1032         (WebCore::RenderThemeMac::fileListNameForWidth):
1033         * rendering/RenderThemeMacShared.h: Removed.
1034         * rendering/RenderThemeMacShared.mm: Removed.
1035
1036 2013-04-24  ChangSeok Oh  <changseok.oh@collabora.com>
1037
1038         [GTK][AC] Visible rect doesn't update after resizing a window.
1039         https://bugs.webkit.org/show_bug.cgi?id=115096
1040
1041         Reviewed by Gustavo Noronha Silva.
1042
1043         Once we set actor's a clip rect, we should update the rect when resizing the actor.
1044
1045         No new tests since no new functionality.
1046
1047         * platform/graphics/clutter/GraphicsLayerClutter.cpp:
1048         (WebCore::GraphicsLayerClutter::setSize):
1049
1050 2013-04-24  ChangSeok Oh  <changseok.oh@collabora.com>
1051
1052         [GTK][AC] Fix unexpected clear of ClutterContent.
1053         https://bugs.webkit.org/show_bug.cgi?id=115099
1054
1055         Reviewed by Gustavo Noronha Silva.
1056
1057         adoptGRef doesn't increase a reference count. So if a actor has a valid ClutterContent,
1058         it would be cleared unexpectedly by smart pointer when escaping a function.
1059
1060         No new tests, no functionality changed.
1061
1062         * platform/graphics/clutter/GraphicsLayerActor.cpp:
1063         (graphicsLayerActorUpdateTexture):
1064
1065 2013-04-24  Alberto Garcia  <agarcia@igalia.com>
1066
1067         DOMFileSystemBase: fix multiple definitions in the BlackBerry port
1068         https://bugs.webkit.org/show_bug.cgi?id=114950
1069
1070         Reviewed by Xan Lopez.
1071
1072         The following  methods are already defined in DOMFileSystemBlackBerry.cpp:
1073
1074         crackFileSystemURL()
1075         createFileSystemURL()
1076         isValidType()
1077         supportsToURL()
1078
1079         * Modules/filesystem/DOMFileSystemBase.cpp:
1080         (WebCore):
1081
1082 2013-04-24  George Staikos  <gstaikos@rim.com>
1083
1084         [BlackBerry] Add support for JPEG image quality during encoding.
1085         https://bugs.webkit.org/show_bug.cgi?id=105773
1086
1087         Reviewed by Xan Lopez.
1088
1089         PR 271611
1090         Internally reviewed by Liam Quinn.
1091
1092         Pass the quality flag into the encoder, with a default of 65
1093
1094         Covered by existing tests.
1095
1096         * platform/image-encoders/JPEGImageEncoder.cpp:
1097         (WebCore::compressRGBABigEndianToJPEG):
1098         * platform/image-encoders/JPEGImageEncoder.h:
1099         (WebCore):
1100
1101 2013-04-24  Csaba Osztrogon√°c  <ossy@webkit.org>
1102
1103         Fix cast-align WebCore/platform/graphics/GraphicsContext3D.cpp on ARM
1104         https://bugs.webkit.org/show_bug.cgi?id=115036
1105
1106         Reviewed by Benjamin Poulain.
1107
1108         * platform/graphics/GraphicsContext3D.cpp:
1109         (WebCore):
1110
1111 2013-04-24  Andreas Kling  <akling@apple.com>
1112
1113         Remove unnecessary MutableStylePropertySet casts.
1114         <http://webkit.org/b/115075>
1115
1116         Reviewed by Geoffrey Garen.
1117
1118         Get rid of some now-unneeded static_casts that were left from the StylePropertySet
1119         refactoring last weekend.
1120
1121         * css/StylePropertySet.cpp:
1122         (WebCore::MutableStylePropertySet::setProperty):
1123         * editing/EditingStyle.cpp:
1124         (WebCore::EditingStyle::triStateOfStyle):
1125         (WebCore::EditingStyle::removeStyleFromRulesAndContext):
1126
1127 2013-04-24  Kangil Han  <kangil.han@samsung.com>
1128
1129         [Minor code cleanup] Remove duplicated condition check
1130         https://bugs.webkit.org/show_bug.cgi?id=115082
1131
1132         Reviewed by Andreas Kling.
1133
1134         areRectsPartiallyAligned() has duplicated condition check, so remove it.
1135
1136         * page/SpatialNavigation.cpp:
1137         (WebCore::areRectsPartiallyAligned):
1138
1139 2013-04-24  Krzysztof Wolanski  <k.wolanski@samsung.com>
1140
1141         [EFL] Fix build warnings caused by missing images attributes for default buttons
1142         https://bugs.webkit.org/show_bug.cgi?id=114955
1143
1144         Reviewed by Gyuyoung Kim.
1145
1146         Added default image for each button from mediacontrol catalog.
1147
1148         No new tests, because there is no change in behavior.
1149
1150         * platform/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc:
1151         * platform/efl/DefaultTheme/widget/mediacontrol/mutebutton/mute_button.edc:
1152         * platform/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playpause_button.edc:
1153         * platform/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackward_button.edc:
1154         * platform/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforward_button.edc:
1155         * platform/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/toggle_captions_button.edc:
1156
1157 2013-04-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1158
1159         Unreviewed build fix with gstreamer 0.10.x after r147555.
1160
1161         * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
1162         (webKitWebAudioSrcLoop):
1163
1164 == Rolled over to ChangeLog-2013-04-24 ==