1 2012-01-02 Kentaro Hara <haraken@chromium.org>
3 REGRESSION(r103919): Remove resolve-supplemental.pl from the WebCore target in Xcode
4 https://bugs.webkit.org/show_bug.cgi?id=75458
6 Reviewed by Adam Barth.
8 At r103919, we added resolve-supplemental.pl to WebCore.framework/Resources,
9 but we should have added it to the project without adding it to any target.
12 No tests. No change in behavior.
14 * WebCore.xcodeproj/project.pbxproj:
16 2012-01-02 Kentaro Hara <haraken@chromium.org>
18 Enable the [Supplemental] IDL on GTK/GObject
19 https://bugs.webkit.org/show_bug.cgi?id=75411
21 Reviewed by Adam Barth.
23 This patch enables the [Supplemental] IDL on GObject bindings of GTK
24 by changing the build flow of bindings/gobject/GNUmakefile.am as follows.
26 - Previous build flow:
27 foreach $idl (all IDL files) {
28 generate-bindings.pl depends on $idl;
29 generate-bindings.pl reads $idl;
30 generate-bindings.pl generates .h and .cpp files for $idl;
33 - New build flow (See the discussions in bug 72138 for more details):
34 resolve-supplemental.pl depends on all IDL files;
35 resolve-supplemental.pl reads all IDL files;
36 resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
37 resolve-supplemental.pl outputs supplemental_dependency.tmp;
38 foreach $idl (all IDL files) {
39 generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
40 generate-bindings.pl reads $idl;
41 generate-bindings.pl reads supplemental_dependency.tmp;
42 generate-bindings.pl generates .h and .cpp files for $idl,
43 including all attributes in the IDL files that are implementing $idl;
46 Tests: Confirm that build succeeds.
47 http/tests/websocket/tests/*
50 * bindings/gobject/GNUmakefile.am:
52 2012-01-02 Kentaro Hara <haraken@chromium.org>
54 Add resolve-supplemental.pl to project.pbxproj
55 https://bugs.webkit.org/show_bug.cgi?id=75426
57 Reviewed by Adam Barth.
59 We should have added "resolve-supplemental.pl" to build scripts of AppleWebKit
60 when we enabled the [Supplemental] IDL on AppleWebKit at r103519.
61 This is a follow-up patch for it.
63 No tests. Just confirm that the AppleWebKit build passes.
65 * WebCore.xcodeproj/project.pbxproj:
67 2012-01-02 Kentaro Hara <haraken@chromium.org>
69 Add resolve-supplemental.pl to build scripts of AppleWin
70 https://bugs.webkit.org/show_bug.cgi?id=75412
72 Reviewed by Adam Barth.
74 We should have added "resolve-supplemental.pl" to build scripts of AppleWin
75 when we enabled the [Supplemental] IDL on AppleWin at r103519.
76 This is a follow-up patch for it.
78 No tests. Just confirm that the AppleWin build passes.
80 * WebCore.vcproj/MigrateScripts:
81 * WebCore.vcproj/WebCore.vcproj:
83 2012-01-02 Sam Weinig <sam@webkit.org>
87 * bindings/scripts/CodeGeneratorJS.pm:
89 2012-01-02 Andy Estes <aestes@apple.com>
91 Fix the Windows build after r103888.
93 * WebCore.vcproj/WebCore.vcproj: Remove CollectionCache.{cpp, h} from
96 2012-01-02 Sam Weinig <sam@webkit.org>
98 REGRESSION(r100517): We're leaking many, many DOM objects!
99 https://bugs.webkit.org/show_bug.cgi?id=75451
101 Reviewed by Mark Rowe.
103 * bindings/scripts/CodeGeneratorJS.pm:
104 Add a temporary workaround to the problem of handle finalizers
105 not getting called by adding back the destructors (or rather
106 their replacement, destroy() functions).
108 2012-01-02 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
110 Fix chromium mac build after r103905
111 https://bugs.webkit.org/show_bug.cgi?id=75436
113 Reviewed by Csaba Osztrogonác.
115 Adding parenthesis to disambiguate because clang gives error
116 "expression is not assignable".
118 * rendering/svg/RenderSVGResourceGradient.cpp:
119 (WebCore::RenderSVGResourceGradient::applyResource):
121 2011-12-29 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
123 Use HashMap<OwnPtr> in RenderSVGResourceGradient
124 https://bugs.webkit.org/show_bug.cgi?id=75364
126 Reviewed by Daniel Bates.
128 * rendering/svg/RenderSVGResourceGradient.cpp:
129 (WebCore::RenderSVGResourceGradient::removeAllClientsFromCache):
130 (WebCore::RenderSVGResourceGradient::removeClientFromCache):
131 (WebCore::RenderSVGResourceGradient::applyResource): avoid looking
132 up the hash twice by using HashMap::add().
133 * rendering/svg/RenderSVGResourceGradient.h: rename m_gradient to m_gradientMap.
135 2012-01-02 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
137 [Qt] Fix qmake warning about unescaped backslashes
141 * DerivedSources.pri:
143 2012-01-02 Carlos Garcia Campos <cgarcia@igalia.com>
145 Unreviewed. Fix make distcheck issue.
147 * GNUmakefile.am: Add resolve-supplemental.pl script to
150 2012-01-01 Andreas Kling <awesomekling@apple.com>
152 Clear HTMLCollection's internal cache on construction.
153 <http://webkit.org/b/75423>
155 Reviewed by Antti Koivisto.
157 * html/HTMLCollection.h:
158 * html/HTMLCollection.cpp:
159 (WebCore::HTMLCollection::HTMLCollection):
160 (WebCore::HTMLCollection::invalidateCacheIfNeeded):
162 2012-01-01 Eunmi Lee <eunmi15.lee@samsung.com>
164 [EFL] Move function to get dpi to the WebCore/platform/efl/EflScreenUtilities.cpp.
165 https://bugs.webkit.org/show_bug.cgi?id=75292
167 Reviewed by Andreas Kling.
169 Move ewk_util_dpi_get() function in the ewk_util.cpp to the
170 WebCore/platform/efl/EflScreenUtilities.cpp in order to use it in the WebKit2.
171 The function's name is changed to getDPI().
174 * platform/efl/EflScreenUtilities.cpp: Added.
176 * platform/efl/EflScreenUtilities.h: Added.
178 2012-01-01 Andreas Kling <awesomekling@apple.com>
180 Merge CollectionCache into HTMLCollection.
181 <http://webkit.org/b/75423>
183 Reviewed by Anders Carlsson.
185 - Move the members of CollectionCache into HTMLCollection.
186 - Renamed resetCollectionInfo() to invalidateCacheIfNeeded().
187 - Removed a bunch of overkill HashMap::checkConsistency() calls.
190 * GNUmakefile.list.am:
193 * WebCore.xcodeproj/project.pbxproj:
194 * html/CollectionCache.cpp: Removed.
195 * html/CollectionCache.h: Removed.
197 Remove CollectionCache.
199 * html/HTMLAllCollection.cpp:
200 (WebCore::HTMLAllCollection::namedItemWithIndex):
201 * html/HTMLCollection.cpp:
202 (WebCore::HTMLCollection::HTMLCollection):
203 (WebCore::HTMLCollection::~HTMLCollection):
204 (WebCore::HTMLCollection::invalidateCacheIfNeeded):
205 (WebCore::HTMLCollection::length):
206 (WebCore::HTMLCollection::item):
207 (WebCore::HTMLCollection::nextItem):
208 (WebCore::HTMLCollection::namedItem):
209 (WebCore::HTMLCollection::updateNameCache):
210 (WebCore::HTMLCollection::hasNamedItem):
211 (WebCore::HTMLCollection::namedItems):
212 (WebCore::HTMLCollection::append):
213 * html/HTMLCollection.h:
214 * html/HTMLFormCollection.cpp:
215 (WebCore::HTMLFormCollection::item):
216 (WebCore::HTMLFormCollection::getNamedItem):
217 (WebCore::HTMLFormCollection::nextItem):
218 (WebCore::HTMLFormCollection::namedItem):
219 (WebCore::HTMLFormCollection::updateNameCache):
221 HTMLCollection's m_info and info() become "struct m_cache" (protected.)
223 * html/HTMLOptionsCollection.cpp:
224 * html/HTMLOptionsCollection.h:
225 * html/HTMLSelectElement.cpp:
226 (WebCore::HTMLSelectElement::setRecalcListItems):
228 Expose HTMLCollection::invalidateCacheIfNeeded() so we can call it from
229 HTMLSelectElement::setRecalcListItems().
231 * html/HTMLFormCollection.h:
233 Remove stale declaration of formCollectionInfo() which no longer exists.
235 2012-01-01 Andreas Kling <awesomekling@apple.com>
237 Move the remaining collections to caching on their respective base nodes.
238 <http://webkit.org/b/75416>
240 Reviewed by Anders Carlsson.
242 Add a (lazily-allocated) array of HTMLCollections to ElementRareData and cache
243 the various collections on their base node rather than recreating them every time.
245 Test: fast/dom/collection-idempotence.html
248 * html/CollectionType.h:
249 * dom/ElementRareData.h:
250 (WebCore::ElementRareData::hasCachedHTMLCollections):
251 (WebCore::ElementRareData::cachedHTMLCollection):
252 (WebCore::ElementRareData::ensureCachedHTMLCollection):
255 (WebCore::Element::ensureCachedHTMLCollection):
257 Plumbing to cache HTMLCollections on ElementRareData.
259 (WebCore::Element::~Element):
261 Detach any cached collections from an element when it's destroyed.
263 * html/HTMLCollection.h:
264 * html/HTMLCollection.cpp:
265 (WebCore::HTMLCollection::HTMLCollection):
266 (WebCore::HTMLCollection::create):
267 (WebCore::HTMLCollection::~HTMLCollection):
268 (WebCore::HTMLCollection::detachFromNode):
269 * html/HTMLTableRowsCollection.cpp:
270 (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
271 * html/HTMLOptionsCollection.cpp:
272 (WebCore::HTMLOptionsCollection::HTMLOptionsCollection):
273 * html/HTMLFormCollection.cpp:
274 (WebCore::HTMLFormCollection::HTMLFormCollection):
276 (WebCore::Document::cachedCollection):
278 Consolidate the HTMLCollection constructors and get rid of the hacks to
279 optionally retain the base node.
281 * html/HTMLDataListElement.cpp:
282 (WebCore::HTMLDataListElement::options):
283 * html/HTMLElement.cpp:
284 (WebCore::HTMLElement::children):
285 * html/HTMLMapElement.cpp:
286 (WebCore::HTMLMapElement::areas):
287 * html/HTMLTableElement.cpp:
288 (WebCore::HTMLTableElement::tBodies):
289 * html/HTMLTableRowElement.cpp:
290 (WebCore::HTMLTableRowElement::cells):
291 * html/HTMLTableSectionElement.cpp:
292 (WebCore::HTMLTableSectionElement::rows):
296 2012-01-01 Raymond Liu <raymond.liu@intel.com>
298 Use overload methods to implement [Optional] parameters in AudioNode.idl
299 https://bugs.webkit.org/show_bug.cgi?id=75402
301 Reviewed by Adam Barth.
303 No new tests required.
305 * GNUmakefile.list.am:
308 * WebCore.xcodeproj/project.pbxproj:
309 * bindings/js/JSAudioNodeCustom.cpp: Removed.
310 * bindings/v8/custom/V8AudioNodeCustom.cpp: Removed.
311 * webaudio/AudioNode.cpp:
312 (WebCore::AudioNode::connect):
313 (WebCore::AudioNode::disconnect):
314 * webaudio/AudioNode.h:
315 * webaudio/AudioNode.idl:
317 2011-12-20 Robert Hogan <robert@webkit.org>
319 CSS 2.1 failure: border-collapse-offset-002.htm fails
320 https://bugs.webkit.org/show_bug.cgi?id=71705
322 Reviewed by Julien Chaffraix.
324 Tests: css2.1/20110323/border-collapse-offset-002-expected.html
325 fast/css/caption-width-absolute-position-offset-top.htm
326 fast/css/caption-width-absolute-position.htm
327 fast/css/caption-width-fixed-position-offset-top.htm
328 fast/css/caption-width-fixed-position.htm
329 fast/css/caption-width-relative-position-offset-top.htm
330 fast/css/caption-width-relative-position.htm
332 Table captions are implemented as children of the table but have a special
333 requirement to expand to the full width of the table rather than just the 'available'
334 width, i.e. the full width minus padding and borders.
336 To accomodate this create a RenderTableCaption object that reimplements containingBlockLogicalWidthForContent()
337 to return the full width of the containing block (i.e. the table) rather than the available width.
340 * CMakeLists.txt: Add RenderTableCaption.[cpp|h]
341 * GNUmakefile.list.am: Add RenderTableCaption.[cpp|h]
342 * Target.pri: Add RenderTableCaption.[cpp|h]
343 * WebCore.gypi: Add RenderTableCaption.[cpp|h]
344 * WebCore.vcproj/WebCore.vcproj: Add RenderTableCaption.[cpp|h]
345 * WebCore.xcodeproj/project.pbxproj: Add RenderTableCaption.[cpp|h]
346 * rendering/RenderBlock.cpp:
347 (WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): Use RenderTableCaption
348 * rendering/RenderObject.cpp:
349 (WebCore::RenderObject::createObject): Add RenderTableCaption.[cpp|h]
350 (WebCore::RenderObject::addChild): ditto
351 * rendering/RenderObject.h:
352 (WebCore::RenderObject::isTableCaption):
353 * rendering/RenderTable.cpp:
354 (WebCore::RenderTable::addChild):
355 * rendering/RenderTable.h:
356 * rendering/RenderTableCaption.cpp: Added.
357 (WebCore::RenderTableCaption::RenderTableCaption): Implement RenderTableCaption
358 (WebCore::RenderTableCaption::~RenderTableCaption):
359 (WebCore::RenderTableCaption::containingBlockLogicalWidthForContent): Return the containing block's full width rather than it's available width.
360 * rendering/RenderTableCaption.h: Added.
361 (WebCore::RenderTableCaption::isTableCaption):
362 (WebCore::toRenderTableCaption):
363 * rendering/RenderingAllInOne.cpp:
365 2012-01-01 Kentaro Hara <haraken@chromium.org>
367 Unreviewed. Rebaselined run-bindings-tests results.
369 * bindings/scripts/test/CPP/WebDOMTestSupplemental.cpp: Added.
370 * bindings/scripts/test/CPP/WebDOMTestSupplemental.h: Added.
371 * bindings/scripts/test/GObject/WebKitDOMTestSupplemental.cpp: Added.
372 * bindings/scripts/test/GObject/WebKitDOMTestSupplemental.h: Added.
373 * bindings/scripts/test/ObjC/DOMTestSupplemental.cpp: Added.
374 * bindings/scripts/test/ObjC/DOMTestSupplemental.h: Added.
376 2012-01-01 Andreas Kling <awesomekling@apple.com>
378 Make HTMLCollections play nice after their base node is gone.
379 <http://webkit.org/b/75410>
381 Reviewed by Anders Carlsson.
383 Added HTMLCollection::detachFromNode() and call that from destructors of nodes
384 with cached collections.
386 Sprinkled checks/assertions where applicable to make sure HTMLCollections are
387 empty after their associated node has been destroyed.
389 This is a slight change in behavior, as collections would previously keep
390 their nodes alive indefinitely. Added a test to document this.
392 Test: fast/dom/htmlcollection-zombies.html
395 (WebCore::Document::~Document):
396 * html/HTMLAllCollection.cpp:
397 (WebCore::HTMLAllCollection::namedItemWithIndex):
398 * html/HTMLCollection.cpp:
399 (WebCore::HTMLCollection::detachFromNode):
400 (WebCore::HTMLCollection::resetCollectionInfo):
401 (WebCore::HTMLCollection::itemAfter):
402 (WebCore::HTMLCollection::calcLength):
403 (WebCore::HTMLCollection::length):
404 (WebCore::HTMLCollection::item):
405 (WebCore::HTMLCollection::nextItem):
406 (WebCore::HTMLCollection::namedItem):
407 (WebCore::HTMLCollection::updateNameCache):
408 (WebCore::HTMLCollection::hasNamedItem):
409 (WebCore::HTMLCollection::namedItems):
410 (WebCore::HTMLCollection::tags):
411 * html/HTMLCollection.h:
412 * html/HTMLFormCollection.cpp:
413 (WebCore::HTMLFormCollection::calcLength):
414 (WebCore::HTMLFormCollection::item):
415 (WebCore::HTMLFormCollection::getNamedItem):
416 (WebCore::HTMLFormCollection::getNamedFormItem):
417 (WebCore::HTMLFormCollection::namedItem):
418 (WebCore::HTMLFormCollection::updateNameCache):
419 * html/HTMLFormElement.cpp:
420 (WebCore::HTMLFormElement::~HTMLFormElement):
421 * html/HTMLNameCollection.cpp:
422 (WebCore::HTMLNameCollection::itemAfter):
423 * html/HTMLOptionsCollection.cpp:
424 (WebCore::HTMLOptionsCollection::add):
425 (WebCore::HTMLOptionsCollection::remove):
426 (WebCore::HTMLOptionsCollection::selectedIndex):
427 (WebCore::HTMLOptionsCollection::setSelectedIndex):
428 (WebCore::HTMLOptionsCollection::setLength):
429 * html/HTMLPropertiesCollection.cpp:
430 (WebCore::HTMLPropertiesCollection::length):
431 (WebCore::HTMLPropertiesCollection::item):
432 (WebCore::HTMLPropertiesCollection::names):
433 * html/HTMLSelectElement.cpp:
434 (WebCore::HTMLSelectElement::~HTMLSelectElement):
435 * html/HTMLSelectElement.h:
436 * html/HTMLTableElement.cpp:
437 (WebCore::HTMLTableElement::~HTMLTableElement):
438 * html/HTMLTableElement.h:
439 * html/HTMLTableRowsCollection.cpp:
440 (WebCore::HTMLTableRowsCollection::itemAfter):
442 2012-01-01 Andreas Kling <awesomekling@apple.com>
444 HTMLCollection: Remove the constructor's custom CollectionCache* argument.
445 <http://webkit.org/b/75414>
447 Reviewed by Anders Carlsson.
449 We no longer need to initialize HTMLCollections with a custom CollectionCache,
450 so remove the argument from the constructor.
452 * html/HTMLCollection.cpp:
453 (WebCore::HTMLCollection::HTMLCollection):
454 * html/HTMLCollection.h:
455 * html/HTMLFormCollection.cpp:
456 (WebCore::HTMLFormCollection::HTMLFormCollection):
457 * html/HTMLNameCollection.cpp:
458 (WebCore::HTMLNameCollection::HTMLNameCollection):
459 * html/HTMLOptionsCollection.cpp:
460 (WebCore::HTMLOptionsCollection::HTMLOptionsCollection):
461 * html/HTMLTableRowsCollection.cpp:
462 (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
464 2011-12-31 Dan Bernstein <mitz@apple.com>
466 WebCore changes for: REGRESSION (WebKit2): Cursor, hover states not updated when page scrolls under stationary mouse pointer
467 https://bugs.webkit.org/show_bug.cgi?id=75405
469 Reviewed by Anders Carlsson.
471 Test: fast/events/frame-scroll-fake-mouse-move.html
473 * page/FrameView.cpp:
474 (WebCore::FrameView::scrollPositionChanged): Added a call to
475 EventHandler::dispatchFakeMouseMoveEventSoon().
477 2012-01-01 Andreas Kling <awesomekling@apple.com>
479 Cache named item collections on Document, not just their caches.
480 <http://webkit.org/b/75403>
482 Reviewed by Anders Carlsson.
484 Keep two maps of name -> RefPtr<HTMLNameCollection> on Document. We already
485 had maps for the CollectionCaches and were creating the HTMLNameCollections
486 every time they were accessed. We now let the collections create and manage
487 the CollectionCaches instead of Document.
489 No new tests since these collections are not exposed to the web.
493 (WebCore::Document::windowNamedItems):
494 (WebCore::Document::documentNamedItems):
496 Replace the name/CollectionCache maps by name/HTMLNameCollection maps.
498 * bindings/js/JSDOMWindowCustom.cpp:
499 (WebCore::namedItemGetter):
500 * bindings/js/JSHTMLDocumentCustom.cpp:
501 (WebCore::JSHTMLDocument::nameGetter):
503 Pass names as AtomicStrings to Document's collection getters.
505 * html/HTMLNameCollection.h:
506 (WebCore::HTMLNameCollection::create):
507 * html/HTMLNameCollection.cpp:
508 (WebCore::HTMLNameCollection::HTMLNameCollection):
510 Store the name in an AtomicString instead of a String, incidentally
511 making traversal of HTMLNameCollections more efficient.
513 * html/CollectionType.h:
515 Remove two now-unneeded constants.
517 2012-01-01 Andreas Kling <awesomekling@apple.com>
519 Remove Document::collectionInfo() and let collections manage their caches.
520 <http://webkit.org/b/75401>
522 Reviewed by Anders Carlsson.
524 Remove the CollectionCaches from Document and have the document's collections
525 create and manage the caches on-demand instead. This is a step towards merging
526 CollectionCache into HTMLCollection.
530 * html/HTMLCollection.cpp:
531 (WebCore::HTMLCollection::HTMLCollection):
532 * html/HTMLOptionsCollection.cpp:
534 2012-01-01 Andreas Kling <awesomekling@apple.com>
536 RenderThemeMac: Avoid double hash lookup in systemColor().
537 <http://webkit.org/b/75409>
539 Reviewed by Anders Carlsson.
541 * rendering/RenderThemeMac.mm:
542 (WebCore::RenderThemeMac::systemColor):
544 2012-01-01 Andreas Kling <awesomekling@apple.com>
546 CSSStyleSelector: Avoid double hash lookup in keyframeStylesForAnimation().
547 <http://webkit.org/b/75408>
549 Reviewed by Anders Carlsson.
551 * css/CSSStyleSelector.cpp:
552 (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
554 2012-01-01 Andreas Kling <awesomekling@apple.com>
556 KeyframeAnimation: Use hash lookups to determine if property is animated.
557 <http://webkit.org/b/75407>
559 Reviewed by Anders Carlsson.
561 Clean out an old FIXME about using hash lookups instead of iterating over
564 * page/animation/KeyframeAnimation.cpp:
565 (WebCore::KeyframeAnimation::hasAnimationForProperty):
566 (WebCore::KeyframeAnimation::affectsProperty):
568 2011-12-31 Dan Bernstein <mitz@apple.com>
570 WebCore change for <rdar://problem/10463059> Cannot print USPS shipping labels
571 http://webkit.org/b/72801
573 Reviewed by Anders Carlsson and Alexey Proskuryakov.
575 * WebCore.exp.in: Exported Chrome::print().
577 2011-12-31 Dan Bernstein <mitz@apple.com>
579 WebCore changes for <rdar://problem/8750356> REGRESSION (WebKit2): Printing a subframe containing a PDF prints the on-screen view instead of the entire PDF document
580 <http://webkit.org/b/75232>
582 Reviewed by Alexey Proskuryakov.
584 * WebCore.exp.in: Exported PluginDocument::pluginWidget().
585 * WebCore.xcodeproj/project.pbxproj: Promoted PluginDocument.h to private.
586 * html/PluginDocument.h: Fixed a typo in a comment.
588 2011-12-30 Andreas Kling <awesomekling@apple.com>
590 Cache and reuse the HTMLTableElement.rows collection.
591 <http://webkit.org/b/75398>
593 Reviewed by Anders Carlsson.
595 Let HTMLTableElement::rows() cache the returned collection and tie it to the
596 lifetime of the form.
598 Test: fast/dom/table-rows-collection-idempotence.html
601 * html/HTMLTableElement.h:
602 * html/HTMLTableElement.cpp:
603 (WebCore::HTMLTableElement::rows):
605 Cache the HTMLTableRowsCollection returned by rows() on the HTMLTableElement.
606 Remove the per-table CollectionCache and let the collection manage that.
608 * html/HTMLTableRowsCollection.h:
609 * html/HTMLTableRowsCollection.cpp:
610 (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
611 (WebCore::HTMLTableRowsCollection::create):
613 Tell the base class constructor to not retain the back-pointer to the table.
615 2011-12-30 Andreas Kling <awesomekling@apple.com>
617 Cache and reuse the HTMLSelectElement.options collection.
618 <http://webkit.org/b/75399>
620 Reviewed by Anders Carlsson.
622 Let HTMLSelectElement::options() cache the returned collection and tie it to the
623 lifetime of the form. This shrinks HTMLSelectElement by sizeof(CollectionCache)
626 Test: fast/dom/select-options-collection-idempotence.html
629 * html/HTMLSelectElement.h:
630 * html/HTMLSelectElement.cpp:
631 (WebCore::HTMLSelectElement::options):
633 Cache the HTMLOptionsCollection returned by options() on the HTMLSelectElement.
634 Remove the per-select CollectionCache and let the collection manage that.
636 * html/HTMLOptionsCollection.h:
637 * html/HTMLOptionsCollection.cpp:
638 (WebCore::HTMLOptionsCollection::create):
639 (WebCore::HTMLOptionsCollection::HTMLOptionsCollection):
641 Tell the base class constructor to not retain the back-pointer to the element.
643 * html/HTMLSelectElement.cpp:
644 (WebCore::HTMLSelectElement::setRecalcListItems):
645 * html/HTMLOptionsCollection.cpp:
646 (WebCore::HTMLOptionsCollection::invalidateCache):
648 Added so HTMLSelectElement can invalidate the collection without triggering
649 unnecessary instantiation of a CollectionCache.
651 2011-12-30 Kentaro Hara <haraken@chromium.org>
653 Enable the [Supplemental] IDL on CMake
654 https://bugs.webkit.org/show_bug.cgi?id=75345
656 Reviewed by Daniel Bates.
658 This patch enables the [Supplemental] IDL on CMake by changing the build
659 flow of CMake as follows.
661 - Previous build flow:
662 foreach $idl (all IDL files) {
663 generate-bindings.pl depends on $idl;
664 generate-bindings.pl reads $idl;
665 generate-bindings.pl generates .h and .cpp files for $idl;
668 - New build flow (See the discussions in bug 72138 for more details):
669 resolve-supplemental.pl depends on all IDL files;
670 resolve-supplemental.pl reads all IDL files;
671 resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
672 resolve-supplemental.pl outputs supplemental_dependency.tmp;
673 foreach $idl (all IDL files) {
674 generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
675 generate-bindings.pl reads $idl;
676 generate-bindings.pl reads supplemental_dependency.tmp;
677 generate-bindings.pl generates .h and .cpp files for $idl,
678 including all attributes in the IDL files that are implementing $idl;
681 Tests: Confirm that build succeeds.
682 http/tests/websocket/tests/*
685 * UseJSC.cmake: Modified to reflect the new build flow as described above.
686 * UseV8.cmake: Ditto.
688 2011-12-30 Robert Hogan <robert@webkit.org>
690 REGRESSION (r94492): Text is shifted to the right in some buttons in the Mac App Store
691 https://bugs.webkit.org/show_bug.cgi?id=74723
693 Reviewed by Dan Bernstein.
695 Tests: fast/css/absolute-inline-alignment-2.html
696 fast/css/absolute-inline-alignment.html
698 Inline positioned elements in the leading spaces of an inline run need to align to
699 adjacent text, so add them to the run as they're encountered.
701 * rendering/RenderBlockLineLayout.cpp:
702 (WebCore::LineInfo::LineInfo): Keep a count of positioned objects encountered when
703 skipping leading whitespace.
704 (WebCore::LineInfo::runsFromLeadingWhitespace):
705 (WebCore::LineInfo::resetRunsFromLeadingWhitespace):
706 (WebCore::LineInfo::incrementRunsFromLeadingWhitespace):
707 (WebCore::RenderBlock::constructLine): Leading positioned objects should not be considered
708 when deciding the number of runs in a line. Otherwise they would contribute towards line
709 height themselves and prevent a free-standing BR following the positioned object from providing a full
711 (WebCore::RenderBlock::layoutRunsAndFloatsInRange): Since a run containing line-breaks will enter
712 skipLeadingWhitespace for each new line we reset the count every time so that the count of positioned
713 objects we encounter only affects the line they appear on. This case is covered by
714 fast/inline/styledEmptyInlinesWithBRs.html
715 (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace): Add a run for each inline positioned object
716 encountered in leading white space. Keep a count of them so that they can be excluded from
717 the total number of runs in constructLine.
719 2011-12-30 Raymond Liu <raymond.liu@intel.com>
721 Remove unnecessary [Custom] attribute in CanvasRenderingContext2D.idl
722 https://bugs.webkit.org/show_bug.cgi?id=75376
724 Reviewed by Adam Barth.
726 No new tests required.
728 * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
729 * html/canvas/CanvasRenderingContext2D.idl:
731 2011-12-30 Andreas Kling <awesomekling@apple.com>
733 Cache and reuse the HTMLFormElement.elements collection.
734 <http://webkit.org/b/75375>
736 Reviewed by Anders Carlsson.
738 Let HTMLFormElement::elements() cache the returned collection and tie it to the
739 lifetime of the form. This reduces memory consumption by ~70 kB (on 64-bit) when
740 viewing your average popular post on reddit.com.
742 Test: fast/dom/form-elements-collection-idempotence.html
745 * html/HTMLFormElement.h:
746 * html/HTMLFormElement.cpp:
747 (WebCore::HTMLFormElement::elements):
749 Cache the HTMLFormCollection returned by elements() on the HTMLFormElement.
750 Remove the per-form CollectionCache and let the collection manage that.
752 * html/HTMLCollection.h:
753 * html/HTMLCollection.cpp:
754 (WebCore::HTMLCollection::HTMLCollection):
755 (WebCore::HTMLCollection::create):
757 Have the HTMLCollection constructor take a bool argument that decides whether
758 we retain the base node pointer or not. This mechanism is a temporary measure
759 until all collection types are owned by their respective base nodes.
761 * html/HTMLFormCollection.h:
762 * html/HTMLFormCollection.cpp:
763 (WebCore::HTMLFormCollection::HTMLFormCollection):
764 (WebCore::HTMLFormCollection::create):
766 Tell the base class constructor to not retain the back-pointer to the form.
768 2011-12-30 Andreas Kling <awesomekling@apple.com>
770 Unreviewed buildfix after r103841.
772 * inspector/InspectorMemoryAgent.cpp:
774 2011-12-30 Andreas Kling <awesomekling@apple.com>
776 CSSStyleDeclaration: Only allow setting parent rule at construction.
777 <http://webkit.org/b/75391>
779 Reviewed by Dan Bernstein.
781 A CSSStyleDeclaration should only ever belong to one CSSRule. Enforce this
782 at compile-time by replacing setParentRule(CSSRule*) with clearParentRule().
784 * css/CSSFontFaceRule.cpp:
785 (WebCore::CSSFontFaceRule::~CSSFontFaceRule):
786 * css/CSSStyleDeclaration.h:
787 (WebCore::CSSStyleDeclaration::clearParentRule):
788 * css/CSSStyleRule.cpp:
789 (WebCore::CSSStyleRule::~CSSStyleRule):
790 * css/WebKitCSSKeyframeRule.cpp:
791 (WebCore::WebKitCSSKeyframeRule::~WebKitCSSKeyframeRule):
793 2011-12-30 Andreas Kling <awesomekling@apple.com>
795 WebKitCSSKeyframeRule.style.parentRule should point to the keyframe rule.
796 <http://webkit.org/b/75336>
798 Reviewed by Antti Koivisto.
800 Let CSS animation keyframe rules .style.parentRule point back to the keyframe
801 board, rather than the keyframes rule containing it.
803 Test: fast/css/css-keyframe-style-parentRule.html
806 (WebCore::CSSParser::createKeyframeRule):
807 * css/WebKitCSSKeyframeRule.cpp:
808 (WebCore::WebKitCSSKeyframeRule::setDeclaration):
810 Set the CSSMutableStyleDeclaration's parent rule when creating it instead
811 of in WebKitCSSKeyframeRule::setDeclaration(). Add assertion to make sure
812 it's only called with declarations already parented to the keyframe rule.
814 * css/WebKitCSSKeyframesRule.cpp:
815 (WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
816 (WebCore::WebKitCSSKeyframesRule::append):
817 (WebCore::WebKitCSSKeyframesRule::deleteRule):
819 Stop reparenting keyframe rules' style declarations to the keyframes rule.
821 2011-12-30 Yury Semikhatsky <yurys@chromium.org>
823 Web Inspector: use typed front-end API in the memory agent
824 https://bugs.webkit.org/show_bug.cgi?id=75382
826 Memory agent now uses generate C++ API for communicating to the front-end.
828 Reviewed by Pavel Feldman.
830 * inspector/InspectorMemoryAgent.cpp:
831 (WebCore::DOMTreeStatistics::CounterVisitor::CounterVisitor):
832 (WebCore::DOMTreeStatistics::CounterVisitor::counters):
833 (WebCore::DOMTreeStatistics::CounterVisitor::visitNode):
835 2011-12-30 Pavel Feldman <pfeldman@google.com>
837 Web Inspector: migrate from "attached" to "compact" styles.
838 https://bugs.webkit.org/show_bug.cgi?id=75381
840 When front-end is docked to right, it should look like "detached", but is still "attached".
841 Use "compact" mode instead of "attached" mode in the styles to mitigate it.
843 Reviewed by Yury Semikhatsky.
845 * inspector/front-end/SearchController.js:
846 (WebInspector.SearchController.prototype.updateSearchLabel):
847 * inspector/front-end/Toolbar.js:
848 (WebInspector.Toolbar.prototype.set compact):
849 (WebInspector.Toolbar.prototype._toolbarDragStart):
850 (WebInspector.Toolbar.prototype._toolbarDrag):
851 * inspector/front-end/helpScreen.css:
852 (body.compact .help-window-outer):
853 (body.compact .help-window-main):
854 (body.compact .help-window-caption):
855 (body.compact .help-close-button):
856 (body.compact .help-content):
857 * inspector/front-end/inspector.css:
858 (body.compact #toolbar):
859 (body.compact.port-qt #toolbar):
860 (body.compact.inactive #toolbar):
861 (body.compact #search-toolbar-label):
862 (body.compact #toolbar-dropdown-arrow):
863 (body.compact #search):
864 (body.compact.port-qt .toolbar-item.close-left, body.compact.port-qt .toolbar-item.close-right):
865 (body.compact #main):
866 * inspector/front-end/inspector.js:
867 (WebInspector.set attached):
868 (WebInspector.get isCompactMode):
869 (WebInspector.get _setCompactMode):
870 (WebInspector._installDockToRight.listener.get if):
871 (WebInspector._installDockToRight.listener):
872 * inspector/front-end/inspectorCommon.css:
873 (body.dock-to-right):
874 (body.dock-to-right.inactive):
876 2011-12-30 Sheriff Bot <webkit.review.bot@gmail.com>
878 Unreviewed, rolling out r103794.
879 http://trac.webkit.org/changeset/103794
880 https://bugs.webkit.org/show_bug.cgi?id=75379
882 the ASSERT is triggered by several tests (Requested by
883 jchaffraix on #webkit).
885 * rendering/RenderTable.cpp:
886 (WebCore::RenderTable::RenderTable):
887 (WebCore::RenderTable::addChild):
888 (WebCore::RenderTable::layout):
889 (WebCore::RenderTable::recalcSections):
890 (WebCore::RenderTable::outerBorderAfter):
891 (WebCore::RenderTable::sectionAbove):
892 (WebCore::RenderTable::sectionBelow):
893 * rendering/RenderTable.h:
894 (WebCore::RenderTable::header):
895 (WebCore::RenderTable::footer):
896 (WebCore::RenderTable::firstBody):
897 (WebCore::RenderTable::hasSections):
898 (WebCore::RenderTable::topSection):
900 2011-12-29 Pavel Feldman <pfeldman@google.com>
902 Web Inspector: enable dock-to-right view (still need embedders to support it).
903 https://bugs.webkit.org/show_bug.cgi?id=75360
905 Reviewed by Yury Semikhatsky.
907 * English.lproj/localizedStrings.js:
908 * inspector/front-end/Settings.js:
909 (WebInspector.Settings):
910 * inspector/front-end/SettingsScreen.js:
911 (WebInspector.SettingsScreen):
912 * inspector/front-end/inspector.js:
913 (WebInspector.set attached):
914 (WebInspector._renderAsAttached.get return):
915 (WebInspector._renderAsAttached):
916 (WebInspector._installDockToRight.updateToolbar):
918 2011-12-29 Raymond Liu <raymond.liu@intel.com>
920 Use IDL overloads in AudioContext.idl for createBuffer
921 https://bugs.webkit.org/show_bug.cgi?id=75293
923 Reviewed by Adam Barth.
925 No new tests required.
927 * bindings/js/JSAudioContextCustom.cpp:
928 * bindings/v8/custom/V8AudioContextCustom.cpp:
929 * webaudio/AudioContext.cpp:
930 (WebCore::AudioContext::createBuffer):
931 * webaudio/AudioContext.h:
932 * webaudio/AudioContext.idl:
934 2011-12-29 Andreas Kling <awesomekling@apple.com>
936 HTMLDivElement: Remove unnecessary variable in parseMappedAttribute().
937 <http://webkit.org/b/75363>
939 Reviewed by Daniel Bates.
941 * html/HTMLDivElement.cpp:
942 (WebCore::HTMLDivElement::parseMappedAttribute):
944 2011-12-29 Andreas Kling <awesomekling@apple.com>
946 HTMLParagraphElement: Remove unnecessary variable in parseMappedAttribute().
947 <http://webkit.org/b/75362>
949 Reviewed by Daniel Bates.
951 * html/HTMLParagraphElement.cpp:
952 (WebCore::HTMLParagraphElement::parseMappedAttribute):
954 2011-12-29 Andreas Kling <awesomekling@apple.com>
956 Use HashMap<OwnPtr> for Document's named item collection caches.
957 <http://webkit.org/b/75335>
959 Reviewed by Daniel Bates.
962 (WebCore::Document::~Document):
964 Remove now-unneeded deleteAllValues() loop.
966 (WebCore::Document::nameCollectionInfo):
968 Use add() instead of find()/add() to avoid one extra hash lookup.
972 Switch the value type of m_nameCollectionInfo to use OwnPtr.
974 2011-12-29 David Barton <dbarton@mathscribe.com>
976 mfenced skips the first separator if the separators attribute contains multiple separators
977 https://bugs.webkit.org/show_bug.cgi?id=57697
979 Reviewed by Dan Bernstein.
983 * rendering/mathml/RenderMathMLFenced.cpp:
984 (WebCore::RenderMathMLFenced::addChild):
985 - Thanks to Xun Sun <xun.sun@intel.com> for the off-by-one error fix.
987 2011-12-29 Alexis Menard <alexis.menard@openbossa.org>
989 Enable the [Supplemental] IDL on Qt.
990 https://bugs.webkit.org/show_bug.cgi?id=75274
992 Reviewed by Andreas Kling.
994 http://trac.webkit.org/changeset/103783 broke the Qt SL bot.
995 This patch fixes the problem by using 'tr' rather than 'sed' which
996 seems to be more consistent between Mac and Linux.
998 * DerivedSources.pri:
1000 2011-12-29 Vsevolod Vlasov <vsevik@chromium.org>
1002 Web Inspector: Scripts navigator should support incremental search by typing.
1003 https://bugs.webkit.org/show_bug.cgi?id=75349
1005 Reviewed by Pavel Feldman.
1007 * inspector/front-end/ScriptsNavigator.js:
1008 (WebInspector.ScriptsNavigator):
1009 (WebInspector.ScriptsNavigator.prototype.get defaultFocusedElement):
1010 (WebInspector.ScriptsNavigator.prototype.show):
1011 (WebInspector.ScriptsNavigator.prototype._reset):
1012 (WebInspector.NavigatorTreeOutline):
1013 (WebInspector.NavigatorTreeOutline.prototype.scriptTreeElements):
1014 (WebInspector.NavigatorTreeOutline.prototype.searchStarted):
1015 (WebInspector.NavigatorTreeOutline.prototype.searchFinished):
1016 (WebInspector.BaseNavigatorTreeElement.prototype.onreveal):
1017 (WebInspector.BaseNavigatorTreeElement.prototype.set titleText):
1018 (WebInspector.BaseNavigatorTreeElement.prototype.matchesSearchText):
1019 * inspector/front-end/inspector.css:
1020 (.outline-disclosure ol.search-match-not-found li.selected .selection):
1021 (.outline-disclosure ol.search-match-found li.selected):
1022 (.outline-disclosure ol.search-match-found li.selected *):
1023 (.outline-disclosure ol.search-match-found li.parent.selected::before):
1024 (.outline-disclosure ol.search-match-found li.parent.expanded.selected::before):
1025 * inspector/front-end/scriptsPanel.css:
1026 (#scripts-navigator-tree-search-box):
1027 (#scripts-navigator-tree-search-box.visible):
1028 (#scripts-navigator-tree-search-box > input):
1029 (.scripts.panel .navigator .search-match-found li.selected .selection):
1030 (.scripts.panel .navigator .search-match-not-found li.selected .selection):
1031 (.scripts.panel .navigator .searching li.selected .selection):
1032 * inspector/front-end/treeoutline.js:
1034 (TreeOutline.prototype._treeKeyPress):
1035 (TreeOutline.prototype._startSearch.focusSearchInput):
1036 (TreeOutline.prototype._startSearch):
1037 (TreeOutline.prototype._searchTextChanged):
1038 (TreeOutline.prototype._showSearchMatchElement):
1039 (TreeOutline.prototype._searchInputKeyDown):
1040 (TreeOutline.prototype._nextSearchMatch):
1041 (TreeOutline.prototype._previousSearchMatch):
1042 (TreeOutline.prototype._searchInputBlur):
1043 (TreeOutline.prototype._searchFinished):
1044 (TreeOutline.prototype.stopSearch):
1046 2011-12-29 Vsevolod Vlasov <vsevik@chromium.org>
1048 Web Inspector: Scripts navigator should trim long file names and show full url in tooltip.
1049 https://bugs.webkit.org/show_bug.cgi?id=75343
1051 Reviewed by Pavel Feldman.
1053 Test: inspector/debugger/ui-source-code-display-name.html
1055 * inspector/front-end/ScriptsNavigator.js:
1056 (WebInspector.ScriptsNavigator.prototype.setScriptSourceIsDirty):
1057 * inspector/front-end/ScriptsPanel.js:
1058 (WebInspector.ScriptsPanel.EditorContainer.prototype.showSourceFrame):
1059 (WebInspector.ScriptsPanel.EditorContainer.prototype.replaceSourceFrames):
1060 (WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.showSourceFrame):
1061 (WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.replaceSourceFrames):
1062 * inspector/front-end/TabbedEditorContainer.js:
1063 (WebInspector.TabbedEditorContainer):
1064 (WebInspector.TabbedEditorContainer.prototype._appendSourceFrameTab):
1065 (WebInspector.TabbedEditorContainer.prototype._tabClosed):
1066 (WebInspector.TabbedEditorContainer.prototype._replaceSourceFrameTab.get if):
1067 (WebInspector.TabbedEditorContainer.prototype._replaceSourceFrameTab):
1068 (WebInspector.TabbedEditorContainer.prototype.get replaceSourceFrames):
1069 (WebInspector.TabbedEditorContainer.prototype.reset):
1070 * inspector/front-end/TabbedPane.js:
1071 (WebInspector.TabbedPane.prototype.appendTab):
1072 (WebInspector.TabbedPane.prototype.changeTabTooltip):
1073 (WebInspector.TabbedPaneTab):
1074 (WebInspector.TabbedPaneTab.prototype.get tooltip):
1075 (WebInspector.TabbedPaneTab.prototype.set tooltip):
1076 (WebInspector.TabbedPaneTab.prototype._createTabElement):
1077 * inspector/front-end/UISourceCode.js:
1078 (WebInspector.UISourceCode.prototype._parseURL):
1079 * inspector/front-end/utilities.js:
1082 2011-12-29 Alexis Menard <alexis.menard@openbossa.org>
1084 getComputedStyle for margin is not implemented.
1085 https://bugs.webkit.org/show_bug.cgi?id=75358
1087 Reviewed by Andreas Kling.
1089 Implement getComputedStyle for margin.
1091 Test: fast/css/getComputedStyle/getComputedStyle-margin-shorthand.html
1093 * css/CSSComputedStyleDeclaration.cpp:
1094 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1096 2011-12-29 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1098 Use HashMap<OwnPtr> in RenderSVGResourcePattern
1099 https://bugs.webkit.org/show_bug.cgi?id=75361
1101 Reviewed by Andreas Kling.
1103 * rendering/svg/RenderSVGResourcePattern.cpp:
1104 (WebCore::RenderSVGResourcePattern::removeAllClientsFromCache):
1105 (WebCore::RenderSVGResourcePattern::removeClientFromCache):
1106 (WebCore::RenderSVGResourcePattern::applyResource): use HashMap::add() to avoid
1107 looking up the hash twice.
1108 * rendering/svg/RenderSVGResourcePattern.h: rename m_pattern to m_patternMap to
1109 improve readability a little bit.
1111 2011-12-29 Alexis Menard <alexis.menard@openbossa.org>
1113 getComputedStyle for padding is not implemented.
1114 https://bugs.webkit.org/show_bug.cgi?id=75352
1116 Reviewed by Andreas Kling.
1118 Implement getComputedStyle for padding shorthand property.
1120 Test: fast/css/getComputedStyle/getComputedStyle-padding-shorthand.html
1122 * css/CSSComputedStyleDeclaration.cpp:
1123 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1125 2011-12-29 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1127 Use HashMap<OwnPtr> in OriginAccessMap
1128 https://bugs.webkit.org/show_bug.cgi?id=75327
1130 Reviewed by Andreas Kling.
1132 * page/SecurityPolicy.cpp:
1133 (WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
1134 (WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):
1135 (WebCore::SecurityPolicy::resetOriginAccessWhitelists):
1137 2011-12-29 Pavel Podivilov <podivilov@chromium.org>
1139 Web Inspector: support sourceMappingURL magic comment.
1140 https://bugs.webkit.org/show_bug.cgi?id=75356
1142 Reviewed by Pavel Feldman.
1144 * inspector/ContentSearchUtils.cpp:
1145 (WebCore::ContentSearchUtils::findSourceMapURL):
1146 * inspector/ContentSearchUtils.h:
1147 * inspector/InspectorDebuggerAgent.cpp:
1148 (WebCore::InspectorDebuggerAgent::sourceMapURLForScript):
1150 2011-12-29 Alexander Pavlov <apavlov@chromium.org>
1152 Web Inspector: Suggest pop-over doesn't hide on tab switch
1153 https://bugs.webkit.org/show_bug.cgi?id=73611
1155 Reviewed by Pavel Feldman.
1157 * inspector/front-end/ConsoleView.js:
1158 (WebInspector.ConsoleView.prototype.willHide):
1159 * inspector/front-end/TextPrompt.js:
1160 (WebInspector.TextPrompt.prototype.complete):
1161 (WebInspector.TextPrompt.prototype._completionsReady):
1162 (WebInspector.TextPrompt.prototype.acceptSuggestion):
1163 (WebInspector.TextPrompt.prototype.hideSuggestBox):
1164 (WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
1166 2011-12-28 Alexander Pavlov <apavlov@chromium.org>
1168 Web Inspector: Implement CSS selector profiler
1169 https://bugs.webkit.org/show_bug.cgi?id=74004
1171 Reviewed by Pavel Feldman.
1173 This implementation of CSS selector profiler measures the total time required to match a certain selector
1174 against DOM nodes and apply the style declaration properties to the particular element,
1175 as well as the number of selector matches (i.e. the number of nodes that matched the selector.)
1176 The results are approximate due to internal matching algorithm optimizations (shared styles et al.)
1177 Multiple selectors with the same selectorText are coalesced into a single record.
1179 * English.lproj/localizedStrings.js:
1181 * WebCore.vcproj/WebCore.vcproj:
1182 * inspector/compile-front-end.sh:
1183 * inspector/front-end/CSSSelectorProfileView.js: Added.
1184 (WebInspector.CSSSelectorDataGridNode):
1185 (WebInspector.CSSSelectorDataGridNode.prototype.get rawData):
1186 (WebInspector.CSSSelectorProfileView):
1187 (WebInspector.CSSSelectorProfileView.prototype.get statusBarItems):
1188 (WebInspector.CSSSelectorProfileView.prototype.get profile):
1189 (WebInspector.CSSSelectorProfileView.prototype.set profile):
1190 (WebInspector.CSSSelectorProfileView.prototype._createProfileNodes):
1191 (WebInspector.CSSSelectorProfileView.prototype.rebuildGridItems):
1192 (WebInspector.CSSSelectorProfileView.prototype.refreshData):
1193 (WebInspector.CSSSelectorProfileView.prototype.refreshShowAsPercents):
1194 (WebInspector.CSSSelectorProfileView.prototype._sortProfile.get selectorComparator):
1195 (WebInspector.CSSSelectorProfileView.prototype._sortProfile.timeComparator):
1196 (WebInspector.CSSSelectorProfileView.prototype._sortProfile.matchesComparator):
1197 (WebInspector.CSSSelectorProfileView.prototype._sortProfile):
1198 (WebInspector.CSSSelectorProfileType):
1199 (WebInspector.CSSSelectorProfileType.prototype.get buttonTooltip):
1200 (WebInspector.CSSSelectorProfileType.prototype.buttonClicked):
1201 (WebInspector.CSSSelectorProfileType.prototype.get treeItemTitle):
1202 (WebInspector.CSSSelectorProfileType.prototype.get description):
1203 (WebInspector.CSSSelectorProfileType.prototype.reset):
1204 (WebInspector.CSSSelectorProfileType.prototype.isRecordingProfile):
1205 (WebInspector.CSSSelectorProfileType.prototype.setRecordingProfile):
1206 (WebInspector.CSSSelectorProfileType.prototype.startRecordingProfile):
1207 (WebInspector.CSSSelectorProfileType.prototype.stopRecordingProfile):
1208 (WebInspector.CSSSelectorProfileType.prototype.createSidebarTreeElementForProfile):
1209 (WebInspector.CSSSelectorProfileType.prototype.createView):
1210 * inspector/front-end/DetailedHeapshotView.js:
1211 * inspector/front-end/ProfileView.js:
1212 * inspector/front-end/ProfilesPanel.js:
1213 (WebInspector.ProfileType.prototype.reset):
1214 (WebInspector.ProfilesPanel.prototype._reset):
1215 (WebInspector.ProfilesPanel.prototype.addProfileHeader):
1216 (WebInspector.ProfilesPanel.prototype._removeTemporaryProfile):
1217 (WebInspector.ProfilesPanel.prototype.setRecordingProfile):
1218 (WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
1219 (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
1220 (WebInspector.ProfilerDispatcher.prototype.addProfileHeader):
1221 * inspector/front-end/WebKit.qrc:
1222 * inspector/front-end/inspector.html:
1223 * inspector/front-end/profilesPanel.css:
1225 2011-12-29 Sheriff Bot <webkit.review.bot@gmail.com>
1227 Unreviewed, rolling out r103798.
1228 http://trac.webkit.org/changeset/103798
1229 https://bugs.webkit.org/show_bug.cgi?id=75353
1231 some small scrollbar differences are making the tests fail on
1232 several platforms (Requested by jchaffraix on #webkit).
1234 * rendering/RenderLayer.cpp:
1235 (WebCore::RenderLayer::updateLayerPositionsAfterScroll):
1237 2011-12-29 Alexander Pavlov <apavlov@chromium.org>
1239 Web Inspector: Focus of the DOM tree is not restored when switching to the Elements panel
1240 https://bugs.webkit.org/show_bug.cgi?id=75351
1242 Reviewed by Yury Semikhatsky.
1244 * inspector/front-end/ElementsPanel.js:
1245 (WebInspector.ElementsPanel.prototype.wasShown):
1247 2011-12-29 Julien Chaffraix <jchaffraix@webkit.org>
1249 REGRESSION (r93614): Safari Reader doesn't repaint correctly when scrolling
1250 https://bugs.webkit.org/show_bug.cgi?id=67100
1252 Reviewed by Dan Bernstein.
1254 Tests: fast/layers/scroll-with-transform-composited-layer-expected.html
1255 fast/layers/scroll-with-transform-composited-layer.html
1256 fast/layers/scroll-with-transform-layer-expected.html
1257 fast/layers/scroll-with-transform-layer.html
1259 The regression came from a previous optimization that was wrongly kept after r93614.
1261 * rendering/RenderLayer.cpp:
1262 (WebCore::RenderLayer::updateLayerPositionsAfterScroll):
1263 Remove the early return for transformed layer. This change worked as we used
1264 to call updateLayerPositions from scrollTo which would call updateLayerPosition on
1265 all our descendants. After r93614, this is no longer the case and we explicitely need
1266 to call updateLayerPosition on our descendants from updateLayerPositionsAfterScroll.
1268 2011-12-29 Alexander Pavlov <apavlov@chromium.org>
1270 Web Inspector: Tree views can be collapsed/hidden using the keyboard arrows
1271 https://bugs.webkit.org/show_bug.cgi?id=46272
1273 Reviewed by Yury Semikhatsky.
1275 WebInspector.SidebarSectionTreeElement which is not selectable has also been made non-collapsible
1276 and expanded by default.
1278 * inspector/front-end/AuditsPanel.js:
1279 (WebInspector.AuditsPanel):
1280 * inspector/front-end/ProfilesPanel.js:
1281 (WebInspector.ProfilesPanel.prototype._registerProfileType):
1282 * inspector/front-end/SidebarTreeElement.js:
1283 (WebInspector.SidebarSectionTreeElement):
1284 (WebInspector.SidebarSectionTreeElement.prototype.selectable.false.collapse):
1285 * inspector/front-end/TimelinePanel.js:
1286 (WebInspector.TimelinePanel):
1288 2011-12-29 Pavel Feldman <pfeldman@google.com>
1290 Web Inspector: [chromium] pass dock to side request to the embedder.
1291 https://bugs.webkit.org/show_bug.cgi?id=75344
1293 Reviewed by Yury Semikhatsky.
1295 I'd like to enable dock-to-right for the front-end window. This is a background work
1296 to pass control flow from the front-end to the front-end host.
1298 * inspector/InspectorFrontendClient.h:
1299 * inspector/InspectorFrontendClientLocal.h:
1300 (WebCore::InspectorFrontendClientLocal::requestSetDockSide):
1301 * inspector/InspectorFrontendHost.cpp:
1302 (WebCore::InspectorFrontendHost::requestSetDockSide):
1303 * inspector/InspectorFrontendHost.h:
1304 * inspector/InspectorFrontendHost.idl:
1305 * inspector/front-end/InspectorFrontendHostStub.js:
1306 (.WebInspector.InspectorFrontendHostStub.prototype.requestAttachWindow):
1307 (.WebInspector.InspectorFrontendHostStub.prototype.requestDetachWindow):
1308 (.WebInspector.InspectorFrontendHostStub.prototype.requestSetDockSide):
1310 2011-12-28 Pavel Podivilov <podivilov@chromium.org>
1312 Web Inspector: add "enable source maps" checkbox setting.
1313 https://bugs.webkit.org/show_bug.cgi?id=75311
1315 Reviewed by Pavel Feldman.
1317 When "enable source maps" is on, all auto detected source maps are silently applied.
1319 * English.lproj/localizedStrings.js:
1320 * inspector/front-end/DebuggerPresentationModel.js:
1321 * inspector/front-end/JavaScriptSourceFrame.js:
1322 (WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):
1323 * inspector/front-end/RawSourceCode.js:
1324 (WebInspector.RawSourceCode):
1325 (WebInspector.RawSourceCode.prototype.setFormatted):
1326 (WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
1327 (WebInspector.RawSourceCode.prototype._updateSourceMapping):
1328 (WebInspector.RawSourceCode.prototype._createUISourceCode):
1329 * inspector/front-end/Settings.js:
1330 (WebInspector.Settings):
1331 * inspector/front-end/SettingsScreen.js:
1332 (WebInspector.SettingsScreen):
1333 * inspector/front-end/UISourceCode.js:
1334 (WebInspector.UISourceCode):
1335 * inspector/front-end/inspector.js:
1336 (WebInspector._toolbarItemClicked):
1338 2011-12-29 Julien Chaffraix <jchaffraix@webkit.org>
1340 Tighten our checks for needsSectionRecalc in RenderTable
1341 https://bugs.webkit.org/show_bug.cgi?id=73972
1343 Reviewed by Adam Barth.
1345 Refactoring covered under the new tests.
1347 Now most of the functions use the header, first body and footer's
1348 getters that checks if we need a section recalculation. The only
1349 exceptions are addChild and recalcSections as they can be called
1352 * rendering/RenderTable.cpp:
1353 (WebCore::RenderTable::layout):
1354 (WebCore::RenderTable::outerBorderAfter):
1355 (WebCore::RenderTable::sectionAbove):
1356 (WebCore::RenderTable::sectionBelow):
1357 Updated the previous functions to use the sections' getters.
1359 (WebCore::RenderTable::RenderTable):
1360 (WebCore::RenderTable::addChild):
1361 (WebCore::RenderTable::recalcSections):
1362 Update the previous functions after the 2 renames
1365 * rendering/RenderTable.h:
1366 (WebCore::RenderTable::header):
1367 (WebCore::RenderTable::footer):
1368 (WebCore::RenderTable::firstBody):
1369 Added some ASSERT here. Also renamed m_head to m_header
1370 and m_foot to m_footer to match the getter and to avoid
1371 unneeded abbreviation.
1373 (WebCore::RenderTable::hasSections):
1374 (WebCore::RenderTable::topSection):
1375 Updated the previous functions to use the section getters.
1377 2011-12-28 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1379 Use HashMap<OwnPtr> for UserScriptMap and UserStyleSheetMap
1380 https://bugs.webkit.org/show_bug.cgi?id=75323
1382 Reviewed by Darin Adler.
1385 (WebCore::Document::pageGroupUserSheets):
1386 * page/PageGroup.cpp:
1387 (WebCore::PageGroup::addUserScriptToWorld):
1388 (WebCore::PageGroup::addUserStyleSheetToWorld):
1389 (WebCore::PageGroup::removeUserScriptFromWorld):
1390 (WebCore::PageGroup::removeUserStyleSheetFromWorld): fix a small mistake in
1391 previous code. Now the entry for world is removed (and deleted) only if its
1392 stylesheet vector is empty.
1393 (WebCore::PageGroup::removeUserScriptsFromWorld):
1394 (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
1395 (WebCore::PageGroup::removeAllUserContent):
1396 * page/UserScriptTypes.h:
1397 * page/UserStyleSheetTypes.h:
1399 2011-12-28 Andreas Kling <awesomekling@apple.com>
1401 Reduce memory used by NamedNodeMap.
1402 <http://webkit.org/b/75333>
1404 Reviewed by Sam Weinig.
1406 Give NamedNodeMap's attribute vector an inline capacity of 4. The vast majority
1407 of elements have <= 4 attributes, and if they don't have any we normally don't
1408 allocate an attribute map at all.
1410 This reduces memory consumption by 1.2MB (on 64-bit) when loading the full HTML5
1411 spec at <http://whatwg.org/c>.
1413 * dom/NamedNodeMap.h:
1415 2011-12-28 Andreas Kling <awesomekling@apple.com>
1417 Reduce memory used by SpaceSplitString.
1418 <http://webkit.org/b/75315>
1420 Reviewed by Sam Weinig.
1422 Split the string upon creation instead of waiting until it's accessed.
1423 This allows us to get rid of all data members except the substring vector.
1424 Since we're storing AtomicStrings, this is way more memory-efficient than
1425 the previous implementation in the majority of cases.
1427 Also reduced the inline capcity of the vector to 2 (from 8), after testing
1428 showed this to cover 90% of the cases on the Alexa top sites.
1430 All in all this reduces memory consumption by 1.1MB (on 64-bit) when
1431 loading the full HTML5 spec at <http://whatwg.org/c>. On that same page,
1432 less than 2ms is spent (on my MBP) splitting the ~20000 strings.
1434 * dom/SpaceSplitString.cpp:
1435 (WebCore::SpaceSplitStringData::createVector):
1436 (WebCore::SpaceSplitStringData::containsAll):
1437 (WebCore::SpaceSplitStringData::remove):
1438 * dom/SpaceSplitString.h:
1439 (WebCore::SpaceSplitStringData::SpaceSplitStringData):
1440 (WebCore::SpaceSplitStringData::contains):
1441 (WebCore::SpaceSplitStringData::size):
1442 (WebCore::SpaceSplitStringData::operator[]):
1444 2011-12-28 ChangSeok Oh <shivamidow@gmail.com>
1446 [GTK] Fix compilation issue when selecting opengl for Accelerated compositing
1447 https://bugs.webkit.org/show_bug.cgi?id=75309
1449 Reviewed by Martin Robinson.
1451 Add TextureMapperGL and TextureMapperGLCairo files.
1452 They define new classes required to implement TextureMapperGL for GTK port.
1454 No new tests required.
1456 * GNUmakefile.list.am:
1457 * platform/graphics/cairo/TextureMapperGLCairo.cpp: Added.
1458 (WebCore::BGRA32PremultimpliedBufferCairo::BGRA32PremultimpliedBufferCairo):
1459 (WebCore::BGRA32PremultimpliedBufferCairo::~BGRA32PremultimpliedBufferCairo):
1460 (WebCore::BGRA32PremultimpliedBufferCairo::beginPaint):
1461 (WebCore::BGRA32PremultimpliedBufferCairo::data):
1462 (WebCore::BGRA32PremultimpliedBufferCairo::endPaint):
1463 (WebCore::uidForImage):
1464 (WebCore::BGRA32PremultimpliedBuffer::create):
1465 * platform/graphics/cairo/TextureMapperGLCairo.h: Added.
1467 2011-12-28 Sheriff Bot <webkit.review.bot@gmail.com>
1469 Unreviewed, rolling out r103782.
1470 http://trac.webkit.org/changeset/103782
1471 https://bugs.webkit.org/show_bug.cgi?id=75328
1473 broke origin-whitelisting-removal.html (Requested by kling on
1476 * page/SecurityPolicy.cpp:
1477 (WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
1478 (WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):
1479 (WebCore::SecurityPolicy::resetOriginAccessWhitelists):
1481 2011-12-28 Kentaro Hara <haraken@chromium.org>
1483 Enable the [Supplemental] IDL on Qt
1484 https://bugs.webkit.org/show_bug.cgi?id=75274
1486 Reviewed by Adam Barth.
1488 This patch enables the [Supplemental] IDL on Qt by changing the build
1489 flow of Qt as follows.
1491 - Previous build flow:
1492 foreach $idl (all IDL files) {
1493 generate-bindings.pl depends on $idl;
1494 generate-bindings.pl reads $idl;
1495 generate-bindings.pl generates .h and .cpp files for $idl;
1498 - New build flow (See the discussions in bug 72138 for more details):
1499 resolve-supplemental.pl depends on all IDL files;
1500 resolve-supplemental.pl reads all IDL files;
1501 resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
1502 resolve-supplemental.pl outputs supplemental_dependency.tmp;
1503 foreach $idl (all IDL files) {
1504 generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
1505 generate-bindings.pl reads $idl;
1506 generate-bindings.pl reads supplemental_dependency.tmp;
1507 generate-bindings.pl generates .h and .cpp files for $idl,
1508 including all attributes in the IDL files that are implementing $idl;
1511 Tests: Confirm that build succeeds.
1512 http/tests/websocket/tests/*
1514 * DerivedSources.pri: Described the above build flow.
1516 2011-12-28 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1518 Use HashMap<OwnPtr> in OriginAccessMap
1519 https://bugs.webkit.org/show_bug.cgi?id=75327
1521 Reviewed by Andreas Kling.
1523 * page/SecurityPolicy.cpp:
1524 (WebCore::SecurityPolicy::addOriginAccessWhitelistEntry):
1525 (WebCore::SecurityPolicy::removeOriginAccessWhitelistEntry):
1526 (WebCore::SecurityPolicy::resetOriginAccessWhitelists):
1528 2011-12-28 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1530 Use HashMap<OwnPtr> for ProgressTracker's items
1531 https://bugs.webkit.org/show_bug.cgi?id=75326
1533 Reviewed by Andreas Kling.
1535 * loader/ProgressTracker.cpp:
1536 (WebCore::ProgressTracker::~ProgressTracker): although is empty, the destructor was
1537 kept so in the header file we can forward declare ProgressItem and use in an OwnPtr.
1538 (WebCore::ProgressTracker::reset):
1539 (WebCore::ProgressTracker::incrementProgress):
1540 (WebCore::ProgressTracker::completeProgress): removed a useless assignment to item
1541 member just before it is deleted.
1542 * loader/ProgressTracker.h:
1544 2011-12-28 Alexis Menard <alexis.menard@openbossa.org>
1546 getComputedStyle for border-color is not implemented.
1547 https://bugs.webkit.org/show_bug.cgi?id=75324
1549 Reviewed by Andreas Kling.
1551 Implement getComputedStyle for border-color.
1553 Test: fast/css/getComputedStyle/getComputedStyle-border-color-shorthand.html
1555 * css/CSSComputedStyleDeclaration.cpp:
1556 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1558 2011-12-28 Darin Adler <darin@apple.com>
1560 Use OwnPtr to handle lifetime and deletion of FontFace objects
1561 https://bugs.webkit.org/show_bug.cgi?id=75221
1563 Reviewed by Daniel Bates.
1565 * css/CSSFontFaceSource.cpp:
1566 (WebCore::CSSFontFaceSource::getFontData): Use add instead of get/set to read and
1567 then later fill a cache. Use new version of registerCustomFont that takes PassOwnPtr.
1568 * css/CSSSegmentedFontFace.cpp:
1569 (WebCore::CSSSegmentedFontFace::getFontData): Ditto.
1572 (WebCore::Document::registerCustomFont): Take a PassOwnPtr instead of raw pointer.
1573 * dom/Document.h: Ditto.
1575 2011-12-28 Adam Barth <abarth@webkit.org>
1577 "Fake" insertion mode in HTMLTreeBuilder doesn't do anything
1578 https://bugs.webkit.org/show_bug.cgi?id=75322
1580 Reviewed by Darin Adler.
1582 This machinery isn't needed anymore now that we're using the new
1583 foreign content hotness.
1585 * html/parser/HTMLTreeBuilder.cpp:
1586 * html/parser/HTMLTreeBuilder.h:
1587 (WebCore::HTMLTreeBuilder::setInsertionMode):
1589 2011-12-28 Alexis Menard <alexis.menard@openbossa.org>
1591 getComputedStyle for border-style is not implemented.
1592 https://bugs.webkit.org/show_bug.cgi?id=75312
1594 Reviewed by Andreas Kling.
1596 Implement getComputedStyle for border-style.
1598 Test: fast/css/getComputedStyle/getComputedStyle-border-style-shorthand.html
1600 * css/CSSComputedStyleDeclaration.cpp:
1601 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1603 2011-12-28 Alexis Menard <alexis.menard@openbossa.org>
1605 getComputedStyle for border-bottom, border-top, border-left, border-right is not implemented.
1606 https://bugs.webkit.org/show_bug.cgi?id=74743
1608 Reviewed by Tony Chang.
1610 Implement getComputedStyle for border-top, border-bottom, border-right, border-left.
1612 Test: fast/css/getComputedStyle/getComputedStyle-border-shorthand.html
1614 * css/CSSComputedStyleDeclaration.cpp:
1615 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1616 (WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForShorthandProperties):
1617 * css/CSSComputedStyleDeclaration.h:
1619 2011-12-28 Robert Hogan <robert@webkit.org>
1621 Inline flow not learning height of all text descendants
1622 https://bugs.webkit.org/show_bug.cgi?id=75305
1624 Reviewed by Dan Bernstein.
1626 Tests: fast/inline/nested-text-descendants-expected.html
1627 fast/inline/nested-text-descendants.html
1629 The root inline box would only learn it had text descendants if its first grandchild
1630 was text. It wasn't informed of subsequent text grandchildren so could not factor them
1631 into its calculation of the line height.
1632 To fix this, propagate the existence of a text descendant to the root inline box
1633 by walking up through the text child's ancestors.
1635 * rendering/InlineFlowBox.cpp:
1636 (WebCore::setHasTextDescendantsOnAncestors):
1637 (WebCore::InlineFlowBox::addToLine):
1638 * rendering/InlineFlowBox.h:
1639 (WebCore::InlineFlowBox::setHasTextDescendants):
1641 2011-12-28 Sheriff Bot <webkit.review.bot@gmail.com>
1643 Unreviewed, rolling out r103620.
1644 http://trac.webkit.org/changeset/103620
1645 https://bugs.webkit.org/show_bug.cgi?id=75316
1647 Causes many crashes (Requested by abarth on #webkit).
1649 * loader/FrameLoaderClient.h:
1650 * page/DOMWindow.cpp:
1651 (WebCore::DOMWindow::postMessageTimerFired):
1653 2011-12-28 Alexander Pavlov <apavlov@chromium.org>
1655 [V8][Chromium] 'randomString' in document.body.style always returns true
1656 https://bugs.webkit.org/show_bug.cgi?id=75313
1658 Reviewed by Adam Barth.
1660 * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
1661 (WebCore::V8CSSStyleDeclaration::namedPropertyQuery):
1663 2011-12-28 Vsevolod Vlasov <vsevik@chromium.org>
1665 Web Inspector: Add domain.png to WebCore.gypi / WebKit.qrc.
1666 https://bugs.webkit.org/show_bug.cgi?id=75310
1668 Reviewed by Pavel Feldman.
1671 * inspector/front-end/WebKit.qrc:
1673 2011-12-28 Vsevolod Vlasov <vsevik@chromium.org>
1675 Web Inspector: ExperimentsSettings causes warning on chromium when reading localizedStrings.
1676 https://bugs.webkit.org/show_bug.cgi?id=75299
1678 Reviewed by Pavel Feldman.
1680 * inspector/front-end/Settings.js:
1681 (WebInspector.ExperimentsSettings):
1682 * inspector/front-end/SettingsScreen.js:
1683 (WebInspector.SettingsScreen.prototype._createExperimentCheckbox):
1685 2011-12-28 Vsevolod Vlasov <vsevik@chromium.org>
1687 Web Inspector: Scripts panel: add debug sidebar resizer to TabbedEditorContainer.
1688 https://bugs.webkit.org/show_bug.cgi?id=75300
1690 Reviewed by Pavel Feldman.
1692 * inspector/front-end/ScriptsPanel.js:
1693 * inspector/front-end/scriptsPanel.css:
1694 (#scripts-debug-sidebar-resizer-widget):
1696 2011-12-28 Alexander Pavlov <apavlov@chromium.org>
1698 Web Inspector: Introduce a Profiler launcher view similar to that in the Audits panel
1699 https://bugs.webkit.org/show_bug.cgi?id=75228
1701 Reviewed by Pavel Feldman.
1703 * English.lproj/localizedStrings.js:
1705 * WebCore.vcproj/WebCore.vcproj:
1706 * inspector/front-end/AuditLauncherView.js:
1707 (WebInspector.AuditLauncherView):
1708 * inspector/front-end/AuditsPanel.js:
1709 (WebInspector.AuditsPanel):
1710 * inspector/front-end/DetailedHeapshotView.js:
1711 (WebInspector.DetailedHeapshotProfileType):
1712 (WebInspector.DetailedHeapshotProfileType.prototype.get treeItemTitle):
1713 (WebInspector.DetailedHeapshotProfileType.prototype.get description):
1714 * inspector/front-end/ProfileLauncherView.js: Added.
1715 (WebInspector.ProfileLauncherView):
1716 (WebInspector.ProfileLauncherView.prototype.setUpEventListeners):
1717 (WebInspector.ProfileLauncherView.prototype.addProfileType):
1718 (WebInspector.ProfileLauncherView.prototype._controlButtonClicked):
1719 (WebInspector.ProfileLauncherView.prototype._updateControls):
1720 (WebInspector.ProfileLauncherView.prototype._profileTypeChanged):
1721 (WebInspector.ProfileLauncherView.prototype._onProfileStarted):
1722 (WebInspector.ProfileLauncherView.prototype._onProfileFinished):
1723 * inspector/front-end/ProfileView.js:
1724 (WebInspector.CPUProfileType):
1725 (WebInspector.CPUProfileType.prototype.get treeItemTitle):
1726 (WebInspector.CPUProfileType.prototype.get description):
1727 * inspector/front-end/ProfilesPanel.js:
1728 (WebInspector.ProfileType.prototype.get treeItemTitle):
1729 (WebInspector.ProfileType.prototype.get description):
1730 (WebInspector.ProfilesPanel.prototype.get statusBarItems):
1731 (WebInspector.ProfilesPanel.prototype.toggleRecordButton):
1732 (WebInspector.ProfilesPanel.prototype._onProfileTypeSelected):
1733 (WebInspector.ProfilesPanel.prototype._reset):
1734 (WebInspector.ProfilesPanel.prototype._showLauncherView):
1735 (WebInspector.ProfilesPanel.prototype._registerProfileType):
1736 (WebInspector.ProfilesPanel.prototype._addProfileHeader):
1737 (WebInspector.ProfilesPanel.prototype._updateInterface):
1738 (WebInspector.ProfileTypeTreeElement):
1739 (WebInspector.ProfileTypeTreeElement.prototype.collapse):
1740 (WebInspector.ProfilesSidebarTreeElement):
1741 (WebInspector.ProfilesSidebarTreeElement.prototype.onattach):
1742 (WebInspector.ProfilesSidebarTreeElement.prototype.onselect):
1743 (WebInspector.ProfilesSidebarTreeElement.prototype.get selectable):
1744 (WebInspector.ProfilesSidebarTreeElement.prototype.refresh):
1745 * inspector/front-end/WebKit.qrc:
1746 * inspector/front-end/WelcomeView.js: Removed.
1747 * inspector/front-end/auditsPanel.css:
1748 (.audit-launcher-view .audit-launcher-view-content):
1749 (.audit-launcher-view div.button-container):
1750 (.panel-enabler-view.audit-launcher-view label):
1751 (.panel-enabler-view.audit-launcher-view label.disabled):
1752 * inspector/front-end/inspector.html:
1753 * inspector/front-end/panelEnablerView.css:
1754 (.panel-enabler-view img):
1755 (.panel-enabler-view .flexible-space):
1756 (.panel-enabler-view button:not(.status-bar-item)):
1757 (body.inactive .panel-enabler-view button, .panel-enabler-view button:disabled):
1758 (.panel-enabler-view input[type="radio"]):
1759 (.panel-enabler-view input[type="radio"]:active:not(:disabled)):
1760 (.panel-enabler-view input[type="radio"]:checked):
1761 (.panel-enabler-view input[type="radio"]:checked:active):
1762 * inspector/front-end/profilesPanel.css:
1763 (.profile-launcher-view-tree-item > .icon):
1764 (.profile-launcher-view-content):
1765 (.profile-launcher-view-content h1):
1766 (.panel-enabler-view.profile-launcher-view form):
1767 (.panel-enabler-view.profile-launcher-view label):
1768 (.profile-launcher-view-content p):
1769 (.panel-enabler-view.profile-launcher-view button:not(.status-bar-item)):
1770 (.profile-launcher-view-content button.running:not(.status-bar-item)):
1771 (body.inactive .profile-launcher-view-content button.running:not(.status-bar-item)):
1773 2011-12-28 Sheriff Bot <webkit.review.bot@gmail.com>
1775 Unreviewed, rolling out r103763.
1776 http://trac.webkit.org/changeset/103763
1777 https://bugs.webkit.org/show_bug.cgi?id=75307
1779 "Compilation fails on Snow Leopard" (Requested by yurys on
1782 * inspector/CodeGeneratorInspector.py:
1784 (create_ad_hoc_type_declaration.Helper):
1785 (CodeGenerator.generate_type_builder):
1786 (get_in_c_type_text):
1788 2011-12-28 Peter Rybin <peter.rybin@gmail.com>
1790 Web Inspector: CodeGeneratorInspector.py: generate enum types.
1791 https://bugs.webkit.org/show_bug.cgi?id=74954
1793 Reviewed by Yury Semikhatsky.
1795 Internal map of string contants is created. C enums are created for
1798 * inspector/CodeGeneratorInspector.py:
1799 (EnumConstants.add_constant):
1801 (EnumConstants.get_enum_constant_code):
1802 (TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):
1803 (TypeBindings.create_type_declaration_.EnumBinding.get_in_c_type_text):
1804 (TypeBindings.create_type_declaration_.EnumBinding.get_setter_value_expression_pattern):
1805 (TypeBindings.create_type_declaration_.PlainString.reduce_to_raw_type):
1806 (TypeBindings.create_type_declaration_.PlainString.get_setter_value_expression_pattern):
1807 (get_in_c_type_text):
1808 (get_setter_value_expression_pattern):
1809 (PlainObjectBinding.get_in_c_type_text):
1810 (PlainObjectBinding.get_setter_value_expression_pattern):
1811 (RawTypesBinding.get_in_c_type_text):
1812 (RawTypesBinding.get_setter_value_expression_pattern):
1813 (get_annotated_type_text):
1814 (MethodGenerateModes.get_modes):
1815 (MethodGenerateModes.StrictParameterMode.get_c_param_type_text):
1816 (MethodGenerateModes.StrictParameterMode):
1817 (MethodGenerateModes.StrictParameterMode.get_setter_value_expression):
1818 (MethodGenerateModes.RawParameterMode.get_c_param_type_text):
1819 (MethodGenerateModes.RawParameterMode):
1820 (MethodGenerateModes.RawParameterMode.get_setter_value_expression):
1821 (MethodGenerateModes.CombinedMode.get_c_param_type_text):
1822 (MethodGenerateModes):
1823 (MethodGenerateModes.CombinedMode):
1824 (MethodGenerateModes.CombinedMode.get_setter_value_expression):
1826 2011-12-28 Hans Wennborg <hans@chromium.org>
1828 IndexedDB: IDBKeyRange constructor should throw when lower > upper
1829 https://bugs.webkit.org/show_bug.cgi?id=74705
1831 Reviewed by Tony Chang.
1833 Make IDBKeyRange throw an exception when lower > upper,
1834 or lower == upper and one or both of the bounds is open.
1836 Tested in storage/indexeddb/keyrange.html.
1838 * storage/IDBKeyRange.cpp:
1839 (WebCore::IDBKeyRange::bound):
1841 2011-12-28 Alexander Pavlov <apavlov@chromium.org>
1843 Web Inspector: [protocol] empty enum constant should be replaced with identifier
1844 https://bugs.webkit.org/show_bug.cgi?id=75273
1846 Reviewed by Yury Semikhatsky.
1848 * inspector/Inspector.json:
1849 * inspector/InspectorCSSAgent.cpp:
1850 (WebCore::InspectorCSSAgent::asInspectorStyleSheet):
1851 (WebCore::InspectorCSSAgent::detectOrigin):
1852 * inspector/InspectorStyleSheet.cpp:
1853 (WebCore::InspectorStyleSheet::buildObjectForRule):
1854 * inspector/front-end/CSSStyleModel.js:
1855 (WebInspector.CSSRule.prototype.get isRegular):
1857 2011-12-27 Pavel Feldman <pfeldman@google.com>
1859 Web Inspector: complete annotating SDK component.
1860 https://bugs.webkit.org/show_bug.cgi?id=75259
1862 Reviewed by Yury Semikhatsky.
1864 * inspector/front-end/DebuggerPresentationModel.js:
1865 (WebInspector.DebuggerPresentationModel.prototype._addScript):
1866 * inspector/front-end/NetworkManager.js:
1867 (WebInspector.NetworkManager.prototype._cacheDisabledSettingChanged):
1868 (WebInspector.NetworkDispatcher.prototype._isNull):
1869 (WebInspector.NetworkDispatcher.prototype.webSocketCreated):
1870 * inspector/front-end/Resource.js:
1871 (WebInspector.Resource.displayName):
1872 * inspector/front-end/ResourceTreeModel.js:
1873 (WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
1874 (WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):
1875 (WebInspector.ResourceTreeFrame.prototype.get name):
1876 * inspector/front-end/TabbedEditorContainer.js:
1878 2011-12-27 Anantanarayanan G Iyengar <ananta@chromium.org>
1880 Crash in the WebKit accessibility code while attempting to retrieve the title UI element.
1881 https://bugs.webkit.org/show_bug.cgi?id=75279
1883 Reviewed by Ryosuke Niwa.
1885 Fix a crash in the the WebKit accessibility code which occurs while retrieving
1886 the title UI clement. The fix is to NULL check the RenderObject::node return value.
1888 No test added as there is no reduction.
1890 * accessibility/AccessibilityRenderObject.cpp:
1891 (WebCore::AccessibilityRenderObject::titleUIElement):
1893 2011-12-27 Dominic Cooney <dominicc@chromium.org>
1895 Remove initWebKitAnimationEvent method
1896 https://bugs.webkit.org/show_bug.cgi?id=71698
1898 Reviewed by Ojan Vafai.
1900 Now that WebKitAnimationEvent has a constructor, we don't need
1902 method. <https://www.w3.org/Bugs/Public/show_bug.cgi?id=15338> is
1903 tracking the change to the CSS Animations spec.
1905 * dom/WebKitAnimationEvent.cpp:
1906 * dom/WebKitAnimationEvent.h:
1907 * dom/WebKitAnimationEvent.idl:
1909 2011-12-27 Dominic Cooney <dominicc@chromium.org>
1911 Remove initWebKitTransitionEvent method
1912 https://bugs.webkit.org/show_bug.cgi?id=71701
1914 Reviewed by Ojan Vafai.
1916 Now that WebKitTransitionEvent has a constructor, we don't need
1918 method. <https://www.w3.org/Bugs/Public/show_bug.cgi?id=15339> is
1919 tracking the change to the CSS Transitions spec.
1921 * dom/WebKitTransitionEvent.cpp:
1922 * dom/WebKitTransitionEvent.h:
1923 * dom/WebKitTransitionEvent.idl:
1925 2011-12-27 Tony Chang <tony@chromium.org>
1927 Move HarfBuzz files into their own directory
1928 https://bugs.webkit.org/show_bug.cgi?id=72780
1930 Reviewed by Daniel Bates.
1932 FontCacheLinux.cpp got moved to platform/graphics/skia/FontCacheSkia.cpp since it wasn't HarfBuzz specific.
1934 I used HarfBuzz in filenames since that seems to be how the name is capitalized on the project home page.
1936 Fixed some style errors caught by the style checker.
1938 * PlatformBlackBerry.cmake:
1939 * WebCore.gyp/WebCore.gyp:
1941 * platform/graphics/chromium/FontPlatformData.h:
1942 * platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp: Renamed from Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp.
1943 * platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.h: Renamed from Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.h.
1944 * platform/graphics/harfbuzz/FontHarfBuzz.cpp: Renamed from Source/WebCore/platform/graphics/chromium/FontLinux.cpp.
1945 * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp: Renamed from Source/WebCore/platform/graphics/chromium/FontPlatformDataLinux.cpp.
1946 * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h: Renamed from Source/WebCore/platform/graphics/chromium/FontPlatformDataLinux.h.
1947 * platform/graphics/harfbuzz/HarfBuzzSkia.cpp: Renamed from Source/WebCore/platform/graphics/chromium/HarfbuzzSkia.cpp.
1948 * platform/graphics/harfbuzz/HarfBuzzSkia.h: Renamed from Source/WebCore/platform/graphics/chromium/HarfbuzzSkia.h.
1949 * platform/graphics/harfbuzz/SimpleFontDataSkia.cpp: Renamed from Source/WebCore/platform/graphics/chromium/SimpleFontDataLinux.cpp.
1950 * platform/graphics/skia/FontCacheSkia.cpp: Renamed from Source/WebCore/platform/graphics/chromium/FontCacheLinux.cpp.
1951 * platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
1953 2011-12-27 Huang Dongsung <luxtella@company100.net>
1955 [TexMap][QT] The fragment shader in OpenGL ES2 requires the default precision
1957 https://bugs.webkit.org/show_bug.cgi?id=75168
1959 Reviewed by Noam Rosenthal.
1961 No new functionality so no new tests.
1963 * platform/graphics/opengl/TextureMapperGL.cpp:
1964 (WebCore::TextureMapperGL::initializeShaders):
1966 2011-12-27 Ryosuke Niwa <rniwa@webkit.org>
1968 [Chromium] uninitialized variable in fakeMouseMoveEventTimerFired
1969 https://bugs.webkit.org/show_bug.cgi?id=75263
1971 Reviewed by Tony Chang.
1973 The failure was caused by PlatformKeyboardEvent::getCurrentModifierState in PlatformKeyboardEventChromium.cpp
1974 not initializing arguments on Linux. Fixed the failure by always assigning false to the arguments.
1976 But we should really fix this function for Linux. Not recognizing any modifier isn't great.
1978 * platform/chromium/PlatformKeyboardEventChromium.cpp:
1979 (WebCore::PlatformKeyboardEvent::getCurrentModifierState):
1981 2011-12-27 Kentaro Hara <haraken@chromium.org>
1983 WIP: Enable the [Supplemental] IDL on Gtk
1984 https://bugs.webkit.org/show_bug.cgi?id=74972
1986 Reviewed by Adam Barth.
1988 This patch enables the [Supplemental] IDL on Gtk by changing the build
1989 flow of Gtk as follows.
1991 - Previous build flow:
1992 foreach $idl (all IDL files) {
1993 generate-bindings.pl depends on $idl;
1994 generate-bindings.pl reads $idl;
1995 generate-bindings.pl generates .h and .cpp files for $idl;
1998 - New build flow (See the discussions in bug 72138 for more details):
1999 resolve-supplemental.pl depends on all IDL files;
2000 resolve-supplemental.pl reads all IDL files;
2001 resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX];
2002 resolve-supplemental.pl outputs supplemental_dependency.tmp;
2003 foreach $idl (all IDL files) {
2004 generate-bindings.pl depends on $idl and supplemental_dependency.tmp;
2005 generate-bindings.pl reads $idl;
2006 generate-bindings.pl reads supplemental_dependency.tmp;
2007 generate-bindings.pl generates .h and .cpp files for $idl,
2008 including all attributes in the IDL files that are implementing $idl;
2011 Tests: Confirm that build succeeds.
2012 http/tests/websocket/tests/*
2014 * GNUmakefile.am: Described the above build flow.
2015 * GNUmakefile.list.am: Added a list of IDL files. Instead, removed a list of JS*.h and JS*.cpp
2016 that are generated by the IDL files.
2018 2011-12-27 Tony Chang <tony@chromium.org>
2020 [chromium] When building with clang, enable -Wglobal-constructors
2021 https://bugs.webkit.org/show_bug.cgi?id=74365
2023 Reviewed by Adam Barth.
2025 * WebCore.gyp/WebCore.gyp:
2027 2011-12-27 Tony Chang <tony@chromium.org>
2029 [chromium] really enable wpo for WebCore libs and for WTF
2030 https://bugs.webkit.org/show_bug.cgi?id=75264
2032 Reviewed by Adam Barth.
2034 * WebCore.gyp/WebCore.gyp: The variable was getting clobbered by the
2035 value set in common.gypi. Use a target_defaults instead to set the
2036 variable. I tested manually on my Windows machine and
2037 WholeProgramOptimization is getting set when buildtype is Official.
2039 2011-12-27 Tony Chang <tony@chromium.org>
2041 [chromium] remove references to files no longer in the tree
2042 https://bugs.webkit.org/show_bug.cgi?id=75262
2044 Reviewed by Adam Barth.
2046 * WebCore.gypi: platform/mac/PlatformMouseEventMac.mm and platform/mac/WheelEventMac.mm
2047 were removed in r103652.
2049 2011-12-27 Vsevolod Vlasov <vsevik@chromium.org>
2051 Unreviewed web inspector localizedStrings.js fix.
2053 * English.lproj/localizedStrings.js:
2055 2011-12-27 Vsevolod Vlasov <vsevik@chromium.org>
2057 Web Inspector: Introduce support for experimental settings.
2058 https://bugs.webkit.org/show_bug.cgi?id=75250
2060 Reviewed by Pavel Feldman.
2062 * English.lproj/localizedStrings.js:
2063 * inspector/front-end/ScriptsPanel.js:
2064 * inspector/front-end/Settings.js:
2065 (WebInspector.ExperimentsSettings):
2066 (WebInspector.ExperimentsSettings.prototype.get experiments):
2067 (WebInspector.ExperimentsSettings.prototype.get experimentsEnabled):
2068 (WebInspector.ExperimentsSettings.prototype._createExperiment):
2069 (WebInspector.ExperimentsSettings.prototype.set _cleanUpSetting.get var):
2070 (WebInspector.ExperimentsSettings.prototype.set _cleanUpSetting):
2071 (set WebInspector.Experiment):
2072 (WebInspector.Experiment.prototype.get name):
2073 (WebInspector.Experiment.prototype.get title):
2074 (WebInspector.Experiment.prototype.isEnabled):
2075 (WebInspector.Experiment.prototype.setEnabled):
2077 * inspector/front-end/SettingsScreen.js:
2078 (WebInspector.SettingsScreen):
2079 (WebInspector.SettingsScreen.prototype._createExperimentsWarningSubsection):
2080 (WebInspector.SettingsScreen.prototype._createExperimentCheckbox.listener):
2081 (WebInspector.SettingsScreen.prototype._createExperimentCheckbox):
2082 * inspector/front-end/helpScreen.css:
2083 (.settings-experiments-warning-subsection-warning):
2084 (.settings-experiments-warning-subsection-message):
2086 2011-12-27 Alexander Pavlov <apavlov@chromium.org>
2088 Web Inspector: exception when scrolling in JavaScriptOutline dialog with empty query
2089 https://bugs.webkit.org/show_bug.cgi?id=75255
2091 Reviewed by Pavel Feldman.
2093 * inspector/front-end/JavaScriptOutlineDialog.js:
2094 (WebInspector.JavaScriptOutlineDialog.prototype._onScroll):
2096 2011-12-27 Pavel Feldman <pfeldman@google.com>
2098 Web Inspector: add more annotations on SDK classes.
2099 https://bugs.webkit.org/show_bug.cgi?id=75247
2101 Reviewed by Yury Semikhatsky.
2103 * inspector/Inspector.json:
2104 * inspector/compile-front-end.sh:
2105 * inspector/front-end/ApplicationCacheModel.js:
2106 (WebInspector.ApplicationCacheDispatcher.prototype.networkStateUpdated):
2107 * inspector/front-end/BreakpointManager.js:
2108 (WebInspector.BreakpointManager.prototype._breakpoint):
2109 * inspector/front-end/Color.js:
2110 (WebInspector.Color.prototype.get shorthex):
2111 (WebInspector.Color.prototype.get hex):
2112 (WebInspector.Color.prototype.get rgb):
2113 (WebInspector.Color.prototype.get hsl):
2114 (WebInspector.Color.prototype.get nickname):
2115 (WebInspector.Color.prototype.hasShortHex):
2116 (WebInspector.Color.prototype._individualRGBValueToFloatValue):
2117 (WebInspector.Color.prototype._rgbStringsToHex):
2118 (WebInspector.Color.prototype._parse.this.nickname.set 2):
2119 (WebInspector.Color.prototype._parse.this.hsla.set 1):
2120 (WebInspector.Color.prototype._parse.this.rgba.set 0):
2121 (WebInspector.Color.prototype._parse.set WebInspector):
2122 (WebInspector.Color.prototype._parse):
2123 * inspector/front-end/CompilerSourceMapping.js:
2124 * inspector/front-end/ConsoleModel.js:
2125 * inspector/front-end/ContentProviders.js:
2126 (WebInspector.ScriptContentProvider):
2127 (WebInspector.ConcatenatedScriptsContentProvider):
2128 (WebInspector.CompilerSourceMappingContentProvider):
2129 (WebInspector.StaticContentProvider):
2130 * inspector/front-end/CookieParser.js:
2131 (WebInspector.CookieParser.KeyValue):
2132 (WebInspector.CookieParser.prototype.parseCookie):
2133 (WebInspector.CookieParser.prototype.parseSetCookie):
2134 (WebInspector.CookieParser.prototype._extractKeyValue):
2135 * inspector/front-end/DOMStorage.js:
2136 * inspector/front-end/Database.js:
2137 (WebInspector.DatabaseDispatcher.prototype.sqlTransactionSucceeded):
2138 (WebInspector.DatabaseDispatcher.prototype.sqlTransactionFailed):
2139 * inspector/front-end/DebuggerModel.js:
2140 (WebInspector.DebuggerModel.Location):
2141 (WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
2142 * inspector/front-end/DebuggerPresentationModel.js:
2143 (WebInspector.DebuggerPresentationModelResourceBinding.prototype._setContentWithInitialContent):
2144 * inspector/front-end/ElementsTreeOutline.js:
2145 * inspector/front-end/HAREntry.js:
2146 * inspector/front-end/NetworkLog.js:
2147 (WebInspector.NetworkLog.prototype._mainFrameNavigated):
2148 * inspector/front-end/Placard.js:
2149 * inspector/front-end/RawSourceCode.js:
2150 (WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation):
2151 (WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):
2152 * inspector/front-end/RemoteObject.js:
2153 (WebInspector.RemoteObject.fromPrimitiveValue):
2154 (WebInspector.RemoteObject.prototype.setPropertyValue.propertySetCallback):
2155 (WebInspector.RemoteObject.prototype.setPropertyValue):
2156 (WebInspector.LocalJSONObject.prototype.get hasChildren):
2157 (WebInspector.LocalJSONObject.prototype._children):
2158 * inspector/front-end/Resource.js:
2159 (WebInspector.Resource.restoreRevisions):
2160 (WebInspector.Resource.prototype.get queryParameters):
2161 (WebInspector.Resource.prototype.get formParameters):
2162 (WebInspector.Resource.prototype.isHttpFamily):
2163 * inspector/front-end/ResourceCategory.js:
2164 * inspector/front-end/ResourceUtils.js:
2165 * inspector/front-end/ScopeChainSidebarPane.js:
2166 (WebInspector.ScopeChainSidebarPane.prototype.update):
2167 * inspector/front-end/Script.js:
2168 (WebInspector.Script.prototype.isInlineScript):
2169 * inspector/front-end/ScriptFormatter.js:
2170 (WebInspector.ScriptFormatter.positionToLocation):
2171 * inspector/front-end/WelcomeView.js:
2172 (WebInspector.WelcomeView.prototype.addMessage):
2173 * inspector/front-end/externs.js:
2174 (Array.prototype.upperBound):
2176 2011-12-27 Vsevolod Vlasov <vsevik@chromium.org>
2178 Web Inspector: Scripts panel tabbed editor does not reopen closed tabs.
2179 https://bugs.webkit.org/show_bug.cgi?id=75245
2181 Reviewed by Pavel Feldman.
2183 * inspector/front-end/NetworkItemView.js:
2184 (WebInspector.NetworkItemView):
2185 * inspector/front-end/TabbedEditorContainer.js:
2186 (WebInspector.TabbedEditorContainer):
2187 (WebInspector.TabbedEditorContainer.prototype._tabClosed):
2188 * inspector/front-end/TabbedPane.js:
2189 (WebInspector.TabbedPane.prototype.closeTab):
2190 (WebInspector.TabbedPane.prototype.selectTab):
2192 2011-12-27 Yury Semikhatsky <yurys@chromium.org>
2194 Web Inspector: report per document JS event listener count
2195 https://bugs.webkit.org/show_bug.cgi?id=74298
2197 This patch adds JS event listener count to the memory agent
2200 Reviewed by Pavel Feldman.
2202 Test: inspector/dom-statistics.html
2204 * inspector/Inspector.json:
2205 * inspector/InspectorMemoryAgent.cpp:
2207 2011-12-27 Alexander Pavlov <apavlov@chromium.org>
2209 Web Inspector: [REGRESSION] Go to Function dialog always has a minimal height
2210 https://bugs.webkit.org/show_bug.cgi?id=75254
2212 Reviewed by Yury Semikhatsky.
2214 * inspector/front-end/scriptsPanel.css:
2217 2011-12-26 Vsevolod Vlasov <vsevik@chromium.org>
2219 Web Inspector: Create tabbed editor for scripts panel.
2220 https://bugs.webkit.org/show_bug.cgi?id=75230
2222 Reviewed by Pavel Feldman.
2225 * WebCore.vcproj/WebCore.vcproj:
2226 * inspector/compile-front-end.sh:
2227 * inspector/front-end/ScriptsNavigator.js:
2228 (WebInspector.ScriptsNavigator.prototype.replaceUISourceCodes.get if):
2229 (WebInspector.ScriptsNavigator.prototype.replaceUISourceCodes):
2230 (WebInspector.NavigatorScriptTreeElement.prototype.ondblclick):
2231 (WebInspector.NavigatorScriptTreeElement.prototype.onenter):
2232 * inspector/front-end/ScriptsPanel.js:
2233 * inspector/front-end/TabbedEditorContainer.js: Added.
2234 * inspector/front-end/TabbedPane.js:
2235 (WebInspector.TabbedPane.prototype.get visibleView):
2236 (WebInspector.TabbedPane.prototype.get selectedTabId):
2237 (WebInspector.TabbedPane.prototype.closeAllTabs):
2238 (WebInspector.TabbedPane.prototype.changeTabTitle):
2239 (WebInspector.TabbedPane.prototype.changeTabView):
2240 (WebInspector.TabbedPaneTab):
2241 (WebInspector.TabbedPaneTab.prototype.get title):
2242 (WebInspector.TabbedPaneTab.prototype.set title):
2243 (WebInspector.TabbedPaneTab.prototype.get view):
2244 (WebInspector.TabbedPaneTab.prototype.set view):
2245 (WebInspector.TabbedPaneTab.prototype._createTabElement):
2246 * inspector/front-end/WebKit.qrc:
2247 * inspector/front-end/inspector.html:
2248 * inspector/front-end/scriptsPanel.css:
2249 (.scripts-views-container):
2251 (#scripts-editor-container-tabbed-pane .tabbed-pane-header):
2252 (#scripts-editor-container-tabbed-pane .tabbed-pane-header-contents):
2253 (#scripts-editor-container-tabbed-pane .tabbed-pane-content):
2255 2011-12-27 Pavel Feldman <pfeldman@google.com>
2257 Not reviewed: Rolling out r103703 for breaking Canvas2DLayerChromiumTest.testFullLifecycle.
2259 * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
2260 (WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
2261 (WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
2262 (WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
2263 (WebCore::Canvas2DLayerChromium::setTextureManager):
2264 (WebCore::Canvas2DLayerChromium::updateCompositorResources):
2265 (WebCore::Canvas2DLayerChromium::pushPropertiesTo):
2266 (WebCore::Canvas2DLayerChromium::unreserveContentsTexture):
2267 (WebCore::Canvas2DLayerChromium::cleanupResources):
2268 * platform/graphics/chromium/Canvas2DLayerChromium.h:
2270 2011-12-22 Vangelis Kokkevis <vangelis@chromium.org>
2272 [chromium] Bypass the shadow texture copy for accelerated
2273 canvas when running the compositor in single threaded mode.
2274 https://bugs.webkit.org/show_bug.cgi?id=75146
2276 The texture copy fails on Windows as glCopyTexImage2D() doesn't
2277 support BGRA source textures.
2278 This change also modified Canvas2DLayerChromium::updateCompositorResources
2279 to call glCopyTexSubImage2D() instead of glCopyTexImage2D() so that
2280 the copy can work with texture allocated via the glTexStorage2D
2283 Reviewed by James Robinson.
2286 * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
2287 (WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium):
2288 (WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
2289 (WebCore::Canvas2DLayerChromium::paintContentsIfDirty):
2290 (WebCore::Canvas2DLayerChromium::setTextureManager):
2291 (WebCore::Canvas2DLayerChromium::updateCompositorResources):
2292 (WebCore::Canvas2DLayerChromium::pushPropertiesTo):
2293 (WebCore::Canvas2DLayerChromium::unreserveContentsTexture):
2294 (WebCore::Canvas2DLayerChromium::cleanupResources):
2295 * platform/graphics/chromium/Canvas2DLayerChromium.h:
2297 2011-12-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2299 [EFL][WK2] Implement context menu for EFL port.
2300 https://bugs.webkit.org/show_bug.cgi?id=74995
2302 Reviewed by Anders Carlsson.
2304 Implement missing ContextMenuEfl class in order to support WK2's context menu.
2305 Because WK2's context menu still needs WebCore's context menu implementation.
2306 And of course, this patch also can be used for WK1 without CROSS_PLATFORM_CONTEXT_MENU
2309 * platform/ContextMenu.h:
2310 * platform/ContextMenuItem.h:
2311 * platform/PlatformMenuDescription.h:
2312 * platform/efl/ContextMenuEfl.cpp:
2313 (WebCore::ContextMenu::~ContextMenu):
2314 (WebCore::ContextMenu::appendItem):
2315 (WebCore::ContextMenu::insertItem):
2316 (WebCore::ContextMenu::itemCount):
2317 (WebCore::ContextMenu::setPlatformDescription):
2318 (WebCore::ContextMenu::platformDescription):
2319 (WebCore::ContextMenu::releasePlatformDescription):
2320 (WebCore::platformMenuDescription):
2321 (WebCore::contextMenuItemVector):
2322 * platform/efl/ContextMenuItemEfl.cpp:
2323 (WebCore::ContextMenuItem::ContextMenuItem):
2324 (WebCore::ContextMenuItem::~ContextMenuItem):
2325 (WebCore::ContextMenuItem::setType):
2326 (WebCore::ContextMenuItem::type):
2327 (WebCore::ContextMenuItem::setAction):
2328 (WebCore::ContextMenuItem::action):
2329 (WebCore::ContextMenuItem::setTitle):
2330 (WebCore::ContextMenuItem::title):
2331 (WebCore::ContextMenuItem::setChecked):
2332 (WebCore::ContextMenuItem::checked):
2333 (WebCore::ContextMenuItem::setEnabled):
2334 (WebCore::ContextMenuItem::enabled):
2336 2011-12-26 Hajime Morrita <morrita@chromium.org>
2338 [Refactoring] Node::setTreeScopeRecursively() doesn't need includeRoot parameter
2339 https://bugs.webkit.org/show_bug.cgi?id=75240
2341 Reviewed by Anders Carlsson.
2343 No new tests. No behavior change.
2346 (WebCore::Node::setTreeScopeRecursively):
2349 2011-12-26 Darin Adler <darin@apple.com>
2351 Use OwnPtr and OwnArrayPtr in a couple more places
2352 https://bugs.webkit.org/show_bug.cgi?id=75211
2354 Reviewed by Andreas Kling.
2356 I had a patch with some changes from a while back from going through all sorts of
2357 classes and changing code to use adoptPtr. Most were landed long ago, these are the
2358 ones that still apply.
2360 There are six pieces here that could each be landed separately.
2361 The big one is CSSParser.
2363 * css/CSSGrammar.y: Update for members and functions that now
2364 return PassOwnPtr instead of raw pointers.
2365 * css/CSSParser.cpp:
2366 (WebCore::CSSParser::CSSParser): Remove explicit construction
2367 for m_valueList and m_data since OwnPtr and OwnArrayPtr initialize
2369 (WebCore::CSSParser::~CSSParser): Removed delete m_valueList and
2370 fastFree(m_data) since OwnPtr and OwnArrayPtr handle that.
2371 (WebCore::CSSParser::setupParser): Use adoptArrayPtr and new for
2372 the character array instead of fastFree/fastMalloc. Added get
2373 function calls as needed.
2374 (WebCore::CSSParser::parseValue): Added get function calls as needed.
2375 (WebCore::CSSParser::parseContent): Ditto.
2376 (WebCore::CSSParser::parseFillProperty): Ditto.
2377 (WebCore::CSSParser::parseTransformOriginShorthand): Ditto.
2378 (WebCore::CSSParser::parseBorderImage): Ditto.
2379 (WebCore::CSSParser::parseTransformOrigin): Ditto.
2380 (WebCore::CSSParser::parsePerspectiveOrigin): Ditto.
2381 (WebCore::CSSParser::sinkFloatingValueList): Changed to return PassOwnPtr.
2382 The adoptPtr call is here.
2383 (WebCore::CSSParser::sinkFloatingFunction): Ditto.
2384 (WebCore::CSSParser::markSelectorListStart): Added get function calls as needed.
2385 (WebCore::CSSParser::markSelectorListEnd): Ditto.
2386 (WebCore::CSSParser::markRuleBodyStart): Ditto.
2387 (WebCore::CSSParser::markRuleBodyEnd): Ditto.
2388 (WebCore::CSSParser::markPropertyStart): Ditto.
2389 (WebCore::CSSParser::markPropertyEnd): Ditto.
2390 * css/CSSParser.h: Moved conditional includes to their own paragraph.
2391 Made sinkFloatingValueList and sinkFloatingFunction return PassOwnPtr.
2392 Made m_valueList an OwnPtr and m_data an OwnArrayPtr.
2393 * css/SVGCSSParser.cpp:
2394 (WebCore::CSSParser::parseSVGValue): Added a call to the get function.
2396 * html/PluginDocument.h: Made isPluginDocument private. Also marked all the
2397 functions that are overriding here as OVERRIDE since I was touching the header.
2399 * html/parser/HTMLToken.h:
2400 (WebCore::HTMLTokenTypes::DoctypeData::DoctypeData): Removed an unneeded line
2401 explicitly initializing the base class.
2403 * page/animation/AnimationBase.cpp:
2404 (WebCore::RefCountedPropertyWrapper::RefCountedPropertyWrapper): Fixed indent.
2406 * rendering/style/RenderStyle.h: Moved conditional includes to their own paragraph.
2408 * xml/parser/MarkupTokenBase.h:
2409 (WebCore::MarkupTokenBase::beginDOCTYPE): Removed unneeded parentheses.
2411 2011-12-26 Vsevolod Vlasov <vsevik@chromium.org>
2413 Web Inspector: Extract FileEditor from ScriptsPanel.
2414 https://bugs.webkit.org/show_bug.cgi?id=75229
2416 Reviewed by Pavel Feldman.
2418 * inspector/front-end/JavaScriptSourceFrame.js:
2419 (WebInspector.JavaScriptSourceFrame.prototype.suggestedFileName):
2420 * inspector/front-end/ScriptsNavigator.js:
2421 * inspector/front-end/ScriptsPanel.js:
2422 (WebInspector.ScriptsPanel.prototype._reset):
2423 (WebInspector.ScriptsPanel.prototype.get visibleView):
2424 (WebInspector.ScriptsPanel.prototype._updateScriptViewStatusBarItems):
2425 (WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced.get if):
2426 (WebInspector.ScriptsPanel.EditorContainer):
2427 (WebInspector.ScriptsPanel.EditorContainer.prototype.get currentSourceFrame):
2428 (WebInspector.ScriptsPanel.EditorContainer.prototype.show):
2429 (WebInspector.ScriptsPanel.EditorContainer.prototype.showSourceFrame):
2430 (WebInspector.ScriptsPanel.EditorContainer.prototype.isSourceFrameOpen):
2431 (WebInspector.ScriptsPanel.EditorContainer.prototype.replaceSourceFrames):
2432 (WebInspector.ScriptsPanel.EditorContainer.prototype.setSourceFrameIsDirty):
2433 (WebInspector.ScriptsPanel.EditorContainer.prototype.reset):
2434 (WebInspector.ScriptsPanel.SingleFileEditorContainer):
2435 (WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.get currentSourceFrame):
2436 (WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.show):
2437 (WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.showSourceFrame):
2438 (WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.isSourceFrameOpen):
2439 (WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.replaceSourceFrames):
2440 (WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.setSourceFrameIsDirty):
2441 (WebInspector.ScriptsPanel.SingleFileEditorContainer.prototype.reset):
2442 * inspector/front-end/UISourceCode.js:
2443 (WebInspector.UISourceCode.prototype.get domain):
2444 (WebInspector.UISourceCode.prototype.get folderName):
2445 (WebInspector.UISourceCode.prototype.get fileName):
2446 (WebInspector.UISourceCode.prototype.get displayName):
2447 (WebInspector.UISourceCode.prototype._parseURL):
2449 2011-12-26 Darin Adler <darin@apple.com>
2451 Fix mutation observer build after didMoveToNewDocument change
2452 https://bugs.webkit.org/show_bug.cgi?id=75224
2454 Reviewed by Hajime Morita.
2457 (WebCore::willCallDidMoveToNewDocument): Added.
2458 (WebCore::didMoveToNewDocumentWasCalled): Added.
2459 (WebCore::Node::setDocument): Call new debugging function.
2460 (WebCore::Node::didMoveToNewDocument): Ditto. Also use ASSERT_UNUSED
2461 unconditionally rather than UNUSED_PARAM inside and #if. Also added
2462 a new assertion that checks that hte old document was passed through
2465 2011-12-26 Alexander Pavlov <apavlov@chromium.org>
2467 Web Inspector: [Scripts] Implement iterative match highlighting in the "Go to Function" dialog item list
2468 https://bugs.webkit.org/show_bug.cgi?id=75226
2470 Reviewed by Pavel Feldman.
2472 * inspector/front-end/JavaScriptOutlineDialog.js:
2473 (WebInspector.JavaScriptOutlineDialog):
2474 (WebInspector.JavaScriptOutlineDialog.prototype._createSearchRegExp):
2475 (WebInspector.JavaScriptOutlineDialog.prototype._filterFunctions):
2476 (WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown.previousItem):
2477 (WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown.nextItem):
2478 (WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown):
2479 (WebInspector.JavaScriptOutlineDialog.prototype._updateSelection):
2480 (WebInspector.JavaScriptOutlineDialog.prototype._onScroll):
2481 (WebInspector.JavaScriptOutlineDialog.MatchHighlighter):
2482 (WebInspector.JavaScriptOutlineDialog.MatchHighlighter.prototype.highlightViewportItems):
2483 (WebInspector.JavaScriptOutlineDialog.MatchHighlighter.prototype.clearHighlight):
2484 (WebInspector.JavaScriptOutlineDialog.MatchHighlighter.prototype._highlightItem):
2485 (WebInspector.JavaScriptOutlineDialog.MatchHighlighter.prototype._viewportRowRange):
2486 * inspector/front-end/javaScriptOutlineDialog.css:
2487 (.js-outline-dialog > .container > div.item > span.highlight):
2489 2011-12-26 Vsevolod Vlasov <vsevik@chromium.org>
2491 Web Inspector: Extract FileSelector from ScriptsPanel.
2492 https://bugs.webkit.org/show_bug.cgi?id=75173
2494 Reviewed by Pavel Feldman.
2496 * inspector/front-end/ScriptsNavigator.js:
2497 (WebInspector.ScriptsNavigator):
2498 (WebInspector.ScriptsNavigator.prototype.get defaultFocusedElement):
2499 (WebInspector.ScriptsNavigator.prototype.show):
2500 (WebInspector.ScriptsNavigator.prototype.setScriptSourceIsDirty):
2501 (WebInspector.ScriptsNavigator.prototype.replaceUISourceCodes):
2502 (WebInspector.ScriptsNavigator.prototype.scriptSelected):
2503 * inspector/front-end/ScriptsPanel.js:
2504 (WebInspector.ScriptsPanel.prototype.get defaultFocusedElement):
2505 (WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded.get if):
2506 (WebInspector.ScriptsPanel.prototype.setScriptSourceIsBeingEdited):
2507 (WebInspector.ScriptsPanel.prototype._reset):
2508 (WebInspector.ScriptsPanel.prototype._showSourceLine):
2509 (WebInspector.ScriptsPanel.prototype._showAndRevealInFileSelector):
2510 (WebInspector.ScriptsPanel.prototype._createSourceFrame):
2511 (WebInspector.ScriptsPanel.prototype._updateExecutionLine):
2512 (WebInspector.ScriptsPanel.prototype._scriptSelected):
2513 (WebInspector.ScriptsPanel.FileSelector):
2514 (WebInspector.ScriptsPanel.FileSelector.prototype.get defaultFocusedElement):
2515 (WebInspector.ScriptsPanel.FileSelector.prototype.show):
2516 (WebInspector.ScriptsPanel.FileSelector.prototype.addUISourceCode):
2517 (WebInspector.ScriptsPanel.FileSelector.prototype.isScriptSourceAdded):
2518 (WebInspector.ScriptsPanel.FileSelector.prototype.revealUISourceCode):
2519 (WebInspector.ScriptsPanel.FileSelector.prototype.setScriptSourceIsDirty):
2520 (WebInspector.ScriptsPanel.FileSelector.prototype.replaceUISourceCodes):
2521 (WebInspector.ScriptsPanel.ComboBoxFileSelector):
2522 (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.get defaultFocusedElement):
2523 (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.show):
2524 (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.showDebugSidebarResizeWidget):
2525 (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.addUISourceCode):
2526 (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.isScriptSourceAdded):
2527 (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.revealUISourceCode):
2528 (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._innerRevealUISourceCode):
2529 (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addToHistory):
2530 (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.replaceUISourceCodes):
2531 (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._showScriptFoldersSettingChanged):
2532 (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._reset):
2533 (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype.setScriptSourceIsDirty):
2534 (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._createEditorToolbar):
2535 (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addOptionToFilesSelect.get var):
2536 (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
2537 (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addOptionToFilesSelect.insertOrdered):
2538 (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._addOptionToFilesSelect):
2539 (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._resetFilesSelect):
2540 (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._updateBackAndForwardButtons):
2541 (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._goBack):
2542 (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._goForward):
2543 (WebInspector.ScriptsPanel.ComboBoxFileSelector.prototype._filesSelectChanged):
2544 * inspector/front-end/inspector.html:
2545 * inspector/front-end/utilities.js:
2548 2011-12-26 Alexander Pavlov <apavlov@chromium.org>
2550 Web Inspector: Implement "Go to Function" dialog for JavaScript
2551 https://bugs.webkit.org/show_bug.cgi?id=75092
2553 Reviewed by Pavel Feldman.
2555 * English.lproj/localizedStrings.js:
2557 * WebCore.vcproj/WebCore.vcproj:
2558 * inspector/compile-front-end.sh:
2559 * inspector/front-end/JavaScriptOutlineDialog.js: Added.
2560 (WebInspector.JavaScriptOutlineDialog.onMouseDown):
2561 (WebInspector.JavaScriptOutlineDialog):
2562 (WebInspector.JavaScriptOutlineDialog.didAddChunk):
2563 (WebInspector.JavaScriptOutlineDialog.install):
2564 (WebInspector.JavaScriptOutlineDialog._show):
2565 (WebInspector.JavaScriptOutlineDialog.createShortcut):
2566 (WebInspector.JavaScriptOutlineDialog.prototype._resizeWindow):
2567 (WebInspector.JavaScriptOutlineDialog.prototype._appendItemElements):
2568 (WebInspector.JavaScriptOutlineDialog.prototype._createSearchRegExp):
2569 (WebInspector.JavaScriptOutlineDialog.prototype._filterFunctions):
2570 (WebInspector.JavaScriptOutlineDialog.prototype._selectFirstItem):
2571 (WebInspector.JavaScriptOutlineDialog.prototype._hide):
2572 (WebInspector.JavaScriptOutlineDialog.prototype._onBlur):
2573 (WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown.previousItem):
2574 (WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown.nextItem):
2575 (WebInspector.JavaScriptOutlineDialog.prototype._onKeyDown):
2576 (WebInspector.JavaScriptOutlineDialog.prototype._scheduleFilter):
2577 (WebInspector.JavaScriptOutlineDialog.prototype._updateSelection):
2578 (WebInspector.JavaScriptOutlineDialog.prototype._onClick):
2579 (WebInspector.JavaScriptOutlineDialog.prototype._onMouseMove):
2580 (WebInspector.JavaScriptOutlineDialog.prototype._highlightFunctionLine):
2581 * inspector/front-end/JavaScriptSourceFrame.js:
2582 (WebInspector.JavaScriptSourceFrame.prototype.get uiSourceCode):
2583 * inspector/front-end/ScriptsPanel.js:
2584 (WebInspector.ScriptsPanel.prototype._didBuildOutlineChunk):
2585 (WebInspector.ScriptsPanel.prototype._reset):
2586 (WebInspector.ScriptsPanel.prototype.requestVisibleScriptOutline):
2587 (WebInspector.ScriptsPanel.prototype._createEditorToolbar):
2588 * inspector/front-end/WebKit.qrc:
2589 * inspector/front-end/inspector.html:
2590 * inspector/front-end/javaScriptOutlineDialog.css: Added.
2591 (.js-outline-dialog):
2592 (.js-outline-dialog > input):
2593 (.js-outline-dialog > div.progress):
2594 (.js-outline-dialog > div.container):
2595 (.js-outline-dialog > .container > div.item):
2596 (.js-outline-dialog > .container > div.item.selected):
2598 2011-12-26 Pavel Feldman <pfeldman@google.com>
2600 Web Inspector: make SDK compilation component self-contained.
2601 https://bugs.webkit.org/show_bug.cgi?id=75172
2603 Reviewed by Yury Semikhatsky.
2605 * inspector/compile-front-end.sh:
2606 * inspector/front-end/ConsoleMessage.js:
2607 (WebInspector.ConsoleMessageImpl):
2608 (WebInspector.ConsoleMessageImpl.prototype.get stackTrace):
2609 (WebInspector.ConsoleMessageImpl.prototype.clone):
2610 * inspector/front-end/ConsoleModel.js:
2611 (WebInspector.ConsoleModel.prototype._messageRepeatCountUpdated):
2612 (WebInspector.ConsoleMessage):
2613 (WebInspector.ConsoleMessage.prototype.isErrorOrWarning):
2614 (WebInspector.ConsoleMessage.prototype.updateRepeatCount):
2615 (WebInspector.ConsoleMessage.prototype.clone):
2616 * inspector/front-end/DebuggerPresentationModel.js:
2617 (WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
2618 * inspector/front-end/ResourceUtils.js:
2619 * inspector/front-end/UIUtils.js:
2620 (WebInspector.resetToolbarColors):
2621 (WebInspector.populateHrefContextMenu):
2623 2011-12-26 Hajime Morrita <morrita@google.com>
2625 Unreviewed bad merge fix.
2627 * svg/SVGSVGElement.cpp:
2628 (WebCore::SVGSVGElement::didMoveToNewDocument):
2630 2011-12-25 Hajime Morrita <morrita@chromium.org>
2632 https://bugs.webkit.org/show_bug.cgi?id=74067
2633 Refactoring: Unitfy willMoveToNewDocument() and didMoveToNewDocument()
2635 Reviewed by Darin Adler.
2637 No new tests. No behavior change.
2639 This change combines two method Node::willMoveToNewOwnerDocument() and Node::didMoveToNewOwnerDocument()
2640 into Node::didMoveToNewDocument(Document* oldDocument).
2642 The intention of this change is:
2643 - Making upcoming refactoring (Bug 59816) possible. The refactoring will turn Node::m_document into
2644 Node::m_treeScope, and we will no longer have Node::setDocument() where we can invoke both
2645 willMoveToNewDocument() and didMoveToNewDocument() at once.
2646 - Killing one extra virtual method call.
2647 - Making the concept of "move" clearer by keeping such an operation into the single method.
2650 (WebCore::setWillMoveToNewDocumentWasCalled):
2651 (WebCore::setDidMoveToNewDocumentWasCalled):
2652 (WebCore::Node::setDocument):
2653 (WebCore::Node::didMoveToNewDocument):
2655 * dom/StyledElement.cpp:
2656 (WebCore::StyledElement::attributeChanged):
2657 * html/FormAssociatedElement.cpp:
2658 (WebCore::FormAssociatedElement::didMoveToNewDocument):
2659 * html/FormAssociatedElement.h:
2660 * html/HTMLFormControlElement.cpp:
2661 (WebCore::HTMLFormControlElement::didMoveToNewDocument):
2662 (WebCore::HTMLFormControlElementWithState::didMoveToNewDocument):
2663 * html/HTMLFormControlElement.h:
2664 * html/HTMLFormElement.cpp:
2665 (WebCore::HTMLFormElement::didMoveToNewDocument):
2666 * html/HTMLFormElement.h:
2667 * html/HTMLImageElement.cpp:
2668 (WebCore::HTMLImageElement::didMoveToNewDocument):
2669 * html/HTMLImageElement.h:
2670 * html/HTMLInputElement.cpp:
2671 (WebCore::HTMLInputElement::didMoveToNewDocument):
2672 * html/HTMLInputElement.h:
2673 * html/HTMLMediaElement.cpp:
2674 (WebCore::HTMLMediaElement::didMoveToNewDocument):
2675 * html/HTMLMediaElement.h:
2676 * html/HTMLObjectElement.cpp:
2677 (WebCore::HTMLObjectElement::didMoveToNewDocument):
2678 * html/HTMLObjectElement.h:
2679 * html/HTMLPlugInImageElement.cpp:
2680 (WebCore::HTMLPlugInImageElement::didMoveToNewDocument):
2681 * html/HTMLPlugInImageElement.h:
2682 * html/HTMLVideoElement.cpp:
2683 (WebCore::HTMLVideoElement::didMoveToNewDocument):
2684 * html/HTMLVideoElement.h:
2685 * html/ImageDocument.cpp:
2686 (WebCore::ImageDocumentElement::didMoveToNewDocument):
2687 * html/ImageInputType.cpp:
2688 (WebCore::ImageInputType::willMoveToNewDocument):
2689 * loader/ImageLoader.cpp:
2690 (WebCore::ImageLoader::elementDidMoveToNewDocument):
2691 * loader/ImageLoader.h:
2692 * svg/SVGImageElement.cpp:
2693 (WebCore::SVGImageElement::didMoveToNewDocument):
2694 * svg/SVGImageElement.h:
2695 * svg/SVGSVGElement.cpp:
2696 (WebCore::SVGSVGElement::didMoveToNewDocument):
2697 * svg/SVGSVGElement.h:
2699 2011-12-25 Kentaro Hara <haraken@chromium.org>
2701 REGRESSION(r102987): Fix the filename prefix of the generated empty .h
2702 and .cpp files for [Supplemental] IDLs
2703 https://bugs.webkit.org/show_bug.cgi?id=75082
2705 Reviewed by Darin Adler.
2707 In bug 74481, we changed generate-bindings.pl so that it generates empty .h
2708 and .cpp files for the [Supplemental] IDLs. However, the filename prefixes of
2709 those .h and .cpp files are wrong. This patch fixes the prefixes as follows:
2711 generator=JS => JS*.h, JS*.cpp
2712 generator=V8 => V8*.h, V8*.cpp
2713 generator=ObjC => DOM*.h, DOM*.cpp
2714 generator=GObject => WebKitDOM*.h, WebKitDOM*.cpp
2715 generator=CPP => WebDOM*.h, WebDOM*.cpp
2717 No new tests. No change in behavior.
2718 I confirmed that the names of generated .h and .cpp files are correct.
2720 * bindings/scripts/CodeGenerator.pm:
2721 (FileNamePrefix): Returns the prefix of file names.
2722 * bindings/scripts/CodeGeneratorCPP.pm:
2723 (GenerateInterface): Uses CodeGenerator::FileNamePrefix.
2724 * bindings/scripts/CodeGeneratorGObject.pm:
2725 (GenerateInterface): Ditto.
2726 * bindings/scripts/CodeGeneratorJS.pm:
2727 (GenerateInterface): Ditto.
2728 * bindings/scripts/CodeGeneratorObjC.pm:
2729 (GenerateInterface): Ditto.
2730 * bindings/scripts/CodeGeneratorV8.pm:
2731 (GenerateInterface): Ditto.
2732 * bindings/scripts/generate-bindings.pl:
2733 (generateEmptyHeaderAndCpp): Ditto.
2735 2011-12-25 Dan Bernstein <mitz@apple.com>
2737 WebCore changes for: Find indicators overlap when a match spans multiple text boxes
2738 https://bugs.webkit.org/show_bug.cgi?id=75220
2740 Reviewed by Darin Adler.
2742 * WebCore.exp.in: Exported new unionRect(const Vector<FloatRect>&) and existing
2743 FloatRect::intersects().
2744 * platform/graphics/FloatRect.cpp:
2745 (WebCore::unionRect): Added.
2746 * platform/graphics/FloatRect.h:
2748 2011-12-25 Darin Adler <darin@apple.com>
2750 Use OwnPtr for CSSFontFace::m_sources
2751 https://bugs.webkit.org/show_bug.cgi?id=75219
2753 Reviewed by Dan Bernstein.
2755 * css/CSSFontFace.cpp:
2756 (WebCore::CSSFontFace::isLoaded): Use the same size_t idiom here as in the rest
2758 (WebCore::CSSFontFace::isValid): Ditto. Also removed unneeded empty special casing.
2759 (WebCore::CSSFontFace::addSource): Changed to take a PassOwnPtr. Reordered so the
2760 PassOwnPtr zeroing does not cause trouble.
2761 (WebCore::CSSFontFace::getFontData): Added call to get.
2762 (WebCore::CSSFontFace::hasSVGFontFaceSource): Use the same size_t idiom here as in
2763 the rest of the functions.
2765 * css/CSSFontFace.h: Use PassOwnPtr for addSource argument, and Vector<OwnPtr> for
2766 the m_sources vector.
2768 * css/CSSFontSelector.cpp:
2769 (WebCore::CSSFontSelector::addFontFaceRule): Use OwnPtr and PassOwnPtr for font face
2770 sources that are passed to addSource.
2772 * css/CSSSegmentedFontFace.cpp: Added a now-needed include.
2774 2011-12-24 Jarred Nicholls <jarred@sencha.com>
2776 Allow XMLHttpRequest responseType to be set at any state up to and including HEADERS_RECEIVED
2777 https://bugs.webkit.org/show_bug.cgi?id=75190
2779 XMLHttpRequest.responseType should be modifiable at any state up to and including the
2780 HEADERS_RECEIVED state. Therefore, subsequent calls to open() should not reset responseType
2781 to its default value, and calls to open() must follow the same spec mandate set forth in
2782 setResponseType() for synchronous HTTP(S) requests made from the window context.
2784 Reviewed by Alexey Proskuryakov.
2786 Tests: fast/xmlhttprequest/xmlhttprequest-responsetype-before-open-sync-request.html
2787 fast/xmlhttprequest/xmlhttprequest-responsetype-before-open.html
2788 fast/xmlhttprequest/xmlhttprequest-responsetype-set-at-headers-received.html
2790 * xml/XMLHttpRequest.cpp:
2791 (WebCore::XMLHttpRequest::setResponseType):
2792 Prevent setting the value only when in LOADING and DONE states. No longer check if
2793 m_loader is present, which is instantiated on a call to send(), because responseType
2794 can be safely changed after a request is sent.
2795 (WebCore::XMLHttpRequest::open):
2796 Do not reset m_responseTypeCode to the default value, and prevent calls to open()
2797 for synchronous HTTP(S) requests made from the window context when m_responseTypeCode
2798 is not the default value.
2800 2011-12-25 Sam Weinig <sam@webkit.org>
2802 Fix tests failing as a result of r103643
2803 https://bugs.webkit.org/show_bug.cgi?id=75209
2805 Reviewed by Dan Bernstein.
2807 Switch accidental switch of default scroll granularity from
2808 ScrollByPageWheelEvent back to ScrollByPixelWheelEvent.
2810 * platform/mac/PlatformEventFactory.mm:
2811 (WebCore::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
2813 2011-12-25 Darin Adler <darin@apple.com>
2815 Change CSS canvas code that does HashMap get/set to use the more efficient add idiom
2816 https://bugs.webkit.org/show_bug.cgi?id=75204
2818 Reviewed by Dan Bernstein.
2821 (WebCore::Document::getCSSCanvasContext): Change local variable name of element to
2822 element; it's not the function result, so not good to name it result.
2823 (WebCore::Document::getCSSCanvasElement): Use add instead of get/set so we only do
2824 one hash table lookup.
2826 2011-12-24 Andreas Kling <awesomekling@apple.com>
2828 CSSElementStyleDeclarations should never move between elements.
2829 <http://webkit.org/b/75198>
2831 Reviewed by Anders Carlsson.
2833 Have the CSSElementStyleDeclaration subclasses take a StyledElement* in
2834 the constructor and replace setElement(StyledElement*) by clearElement().
2836 No behavior change, just enforcing the current behavior at compile-time.
2838 * css/CSSElementStyleDeclaration.h:
2839 (WebCore::CSSElementStyleDeclaration::clearElement):
2840 (WebCore::CSSElementStyleDeclaration::CSSElementStyleDeclaration):
2841 * css/CSSInlineStyleDeclaration.h:
2842 (WebCore::CSSInlineStyleDeclaration::create):
2843 (WebCore::CSSInlineStyleDeclaration::CSSInlineStyleDeclaration):
2844 * dom/StyledElement.cpp:
2845 (WebCore::StyledElement::createInlineStyleDecl):
2846 (WebCore::StyledElement::destroyInlineStyleDecl):
2847 * svg/SVGFontFaceElement.cpp:
2848 (WebCore::FontFaceStyleDeclaration::FontFaceStyleDeclaration):
2850 2011-12-23 Andreas Kling <awesomekling@apple.com>
2852 Decouple CSSMappedAttributeDeclaration from element completely.
2853 <http://webkit.org/b/75187>
2855 Reviewed by Darin Adler.
2857 Let CSSMappedAttributeDeclaration inherit from CSSMutableDeclaration instead
2858 of CSSElementStyleDeclaration. Add methods to CSSMappedAttributeDeclaration
2859 for setting properties that also take a StyledElement* and use that mechanism
2860 instead of temporarily associating an element with the declaration.
2862 This reduces the size of mapped attributes by 4/8 bytes, but more importantly
2863 opens a number of ways to simplify style declarations in future patches.
2865 * css/CSSMutableStyleDeclaration.h:
2866 * dom/CSSMappedAttributeDeclaration.cpp:
2867 (WebCore::CSSMappedAttributeDeclaration::setNeedsStyleRecalc):
2868 (WebCore::CSSMappedAttributeDeclaration::setMappedImageProperty):
2869 (WebCore::CSSMappedAttributeDeclaration::setMappedLengthProperty):
2870 (WebCore::CSSMappedAttributeDeclaration::setMappedProperty):
2871 (WebCore::CSSMappedAttributeDeclaration::removeMappedProperty):
2872 * dom/CSSMappedAttributeDeclaration.h:
2873 (WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):
2875 Add/move methods to CSSMappedAttributeDeclaration for setting/removing
2876 properties that also take a StyledElement*. That element is used for
2877 scheduling style recalc and passing the right document to CSSParser.
2880 * css/CSSParser.cpp:
2881 (WebCore::parseColorValue):
2882 (WebCore::parseSimpleLengthValue):
2883 (WebCore::CSSParser::parseValue):
2884 (WebCore::CSSParser::parseMappedAttributeValue):
2886 Added a parsedMappedAttributeValue() alternative to parseValue() that
2887 takes a StyledElement*.
2889 * dom/StyledElement.h:
2890 * html/HTMLElement.cpp:
2891 (WebCore::HTMLElement::setContentEditable):
2893 Add (and use) a StyledElement::removeCSSProperty() complement to the
2894 addCSS*() functions.
2896 * dom/StyledElement.cpp:
2897 (WebCore::StyledElement::attributeChanged):
2898 (WebCore::StyledElement::removeCSSProperty):
2899 (WebCore::StyledElement::addCSSProperty):
2900 (WebCore::StyledElement::addCSSImageProperty):
2901 (WebCore::StyledElement::addCSSLength):
2902 (WebCore::StyledElement::addCSSColor):
2903 (WebCore::StyledElement::createMappedDecl):
2904 * html/HTMLTableElement.cpp:
2905 (WebCore::HTMLTableElement::additionalAttributeStyleDecls):
2906 (WebCore::HTMLTableElement::addSharedCellBordersDecl):
2907 (WebCore::HTMLTableElement::addSharedCellPaddingDecl):
2908 (WebCore::HTMLTableElement::addSharedGroupDecls):
2910 Use the setMapped*Property() functions to plumb the element through.
2912 * css/CSSElementStyleDeclaration.h:
2914 Update comment about CSSElementStyleDeclaration's subclasses.
2916 2011-12-24 Jarred Nicholls <jarred@sencha.com>
2918 Allow XMLHttpRequest withCredentials to be set prior to a call to open()
2919 https://bugs.webkit.org/show_bug.cgi?id=75194
2921 XMLHttpRequest.withCredentials attribute should be modifiable prior to the OPENED state per
2922 the W3C spec. See http://dvcs.w3.org/hg/xhr/raw-file/tip/Overview.html#the-withcredentials-attribute
2924 Reviewed by Alexey Proskuryakov.
2926 Test: fast/xmlhttprequest/xmlhttprequest-withcredentials-before-open.html
2928 * xml/XMLHttpRequest.cpp:
2929 (WebCore::XMLHttpRequest::setWithCredentials):
2930 Prevent setting the value only after the OPENED state.
2932 2011-12-24 Andreas Kling <awesomekling@apple.com>
2934 Remove empty inline RenderStyle destructor.
2935 <http://webkit.org/b/75188>
2937 Rubber-stamped by Anders "Ordvits" Carlsson.
2939 * rendering/style/RenderStyle.h:
2941 2011-12-24 Andreas Kling <awesomekling@apple.com>
2943 RenderStyle: Inline the destructor.
2944 <http://webkit.org/b/75188>
2946 Reviewed by Kenneth Rohde Christiansen.
2948 The (empty) RenderStyle destructor gets a little hot sometimes, reaching up
2949 to 0.4% when loading the full HTML5 spec. Inline it to remove the pointless
2952 * rendering/style/RenderStyle.cpp:
2953 * rendering/style/RenderStyle.h:
2954 (WebCore::RenderStyleBitfields::~RenderStyle):
2956 2011-12-23 Noel Gordon <noel.gordon@gmail.com>
2958 JPEG decoders should only save color profile markers if color management is enabled
2959 https://bugs.webkit.org/show_bug.cgi?id=75182
2961 Reviewed by Adam Barth.
2963 No new tests. Covered by existing tests.
2964 fast/images/ycbcr-with-cmyk-color-profile.html
2965 fast/images/gray-scale-jpeg-with-color-profile.html
2966 fast/images/cmyk-jpeg-with-color-profile.html
2967 fast/images/color-jpeg-with-color-profile.html
2969 * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
2970 (WebCore::JPEGImageReader::JPEGImageReader): Store color profile (JPEG_APP0 + 2) markers
2971 using the iccjpeg helper setup_read_icc_profile() if color management is enabled.
2973 2011-12-23 Alice Boxhall <aboxhall@chromium.org>
2975 Fix crash when adding paragraph in contenteditable with role=textbox.
2976 https://bugs.webkit.org/show_bug.cgi?id=75159
2978 Reviewed by Ryosuke Niwa.
2980 Test: accessibility/textbox-role-on-contenteditable-crash.html
2982 * accessibility/AccessibilityRenderObject.cpp:
2983 (WebCore::AccessibilityRenderObject::childrenChanged): Use rendererIsEditable() rather than isContentEditable()
2984 as this method is called during render layouts, and isContentEditable() triggers a layout update, which crashes.
2986 2011-12-23 Noel Gordon <noel.gordon@gmail.com>
2988 [chromium] JPEG image with CMYK ICC color profile renders color-inverted and squashed
2989 https://bugs.webkit.org/show_bug.cgi?id=74400
2991 Reviewed by Adam Barth.
2993 Use color profiles for GRAYSCALE, RGB, YCbCr, CMYK and YCCK jpeg images only if their
2994 embedded color profile is from an RGB color space input device.
2997 fast/images/ycbcr-with-cmyk-color-profile.html
2998 - YCbCr image, with CMYK output device color profile.
3000 fast/images/gray-scale-jpeg-with-color-profile.html
3001 - YCbCr image, with GRAY input device color profile.
3002 fast/images/cmyk-jpeg-with-color-profile.html
3003 - YCCK image, with CMYK output device color profile.
3004 fast/images/color-jpeg-with-color-profile.html
3005 - YCbCr image, with RGB input device color profile.
3007 * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
3008 (WebCore::rgbColorProfile): Return true if the profile has an RGB color space.
3009 (WebCore::inputDeviceColorProfile): Return true if the profile is from an input device.
3010 (WebCore::readColorProfile): Ignore the embedded color profile unless if it is from
3011 an RGB color space input device.
3012 (WebCore::JPEGImageReader::decode):
3014 2011-12-23 Dan Bernstein <mitz@apple.com>
3016 Print dlerror() when dyld functions fail unexpectedly
3017 https://bugs.webkit.org/show_bug.cgi?id=75185
3019 Reviewed by Sam Weinig.
3021 * platform/mac/SoftLinking.h:
3023 2011-12-23 Sam Weinig <sam@webkit.org>
3025 Start extracting platform specific bits out of PlatformEvents
3026 https://bugs.webkit.org/show_bug.cgi?id=75063
3028 Reviewed by Anders Carlsson.
3033 * WebCore.xcodeproj/project.pbxproj:
3034 Add factory, remove implementation files for mac PlatformWheelEvent
3035 and PlatformMouseEvent.
3037 * page/mac/EventHandlerMac.mm:
3038 (WebCore::EventHandler::wheelEvent):
3039 (WebCore::EventHandler::keyEvent):
3040 (WebCore::EventHandler::currentPlatformMouseEvent):
3041 Switch to use the factory.
3043 * platform/PlatformEvent.h:
3044 (WebCore::PlatformEvent::shiftKey):
3045 (WebCore::PlatformEvent::ctrlKey):
3046 (WebCore::PlatformEvent::altKey):
3047 (WebCore::PlatformEvent::metaKey):
3048 (WebCore::PlatformEvent::modifiers):
3049 (WebCore::PlatformEvent::PlatformEvent):
3050 Switch to storing the modifiers as bits on an unsigned
3051 instead of as individual bools.
3053 * platform/PlatformGestureEvent.h:
3054 Remove unused timestamp member.
3056 * platform/PlatformKeyboardEvent.h:
3057 (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
3058 (WebCore::PlatformKeyboardEvent::keyIdentifier):
3059 (WebCore::PlatformKeyboardEvent::macCharCode):
3060 (WebCore::PlatformKeyboardEvent::isSystemKey):
3061 Give this class a more consistent interface across platforms,
3062 and remove constructor that took an NSEvent.
3064 * platform/PlatformMouseEvent.h:
3065 Remove constructor that took an NSEvent (and an unused constructor that took
3066 many arguments) as well as some free functions for point conversion.
3068 * platform/PlatformWheelEvent.h:
3069 Remove constructor that took an NSEvent and an unnecessary override of the timestamp()
3072 * platform/mac/KeyEventMac.mm:
3073 Removed constructor and moved helpers to PlatformEventFactory.
3075 * platform/mac/PlatformEventFactory.h: Added.
3076 * platform/mac/PlatformEventFactory.mm: Added.
3077 (WebCore::globalPoint):
3078 (WebCore::globalPointForEvent):
3079 (WebCore::pointForEvent):
3080 (WebCore::mouseButtonForEvent):
3081 (WebCore::mouseEventTypeForEvent):
3082 (WebCore::clickCountForEvent):
3083 (WebCore::momentumPhaseForEvent):
3084 (WebCore::phaseForEvent):
3085 (WebCore::gestureEventTypeForEvent):
3086 (WebCore::textFromEvent):
3087 (WebCore::unmodifiedTextFromEvent):
3088 (WebCore::keyIdentifierForKeyEvent):
3089 (WebCore::isKeypadEvent):
3090 (WebCore::windowsKeyCodeForKeyEvent):
3091 (WebCore::isKeyUpEvent):
3092 (WebCore::modifiersForEvent):
3093 (WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
3094 (WebCore::PlatformEventFactory::createPlatformMouseEvent):
3095 (WebCore::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
3096 (WebCore::PlatformEventFactory::createPlatformWheelEvent):
3097 (WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
3098 (WebCore::PlatformEventFactory::createPlatformKeyboardEvent):
3099 (WebCore::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
3100 (WebCore::PlatformEventFactory::createPlatformGestureEvent):
3101 Consolidate platform event creation logic and add factory functions.
3103 * platform/mac/PlatformMouseEventMac.mm: Removed.
3104 * platform/mac/WheelEventMac.mm: Removed.
3106 * platform/mac/WebCoreSystemInterface.h:
3107 * platform/mac/WebCoreSystemInterface.mm:
3108 Expose wkGetNSEventKeyChar in WebCore.
3110 * platform/gtk/PlatformKeyboardEventGtk.cpp:
3111 (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
3112 * platform/gtk/PlatformMouseEventGtk.cpp:
3113 (WebCore::PlatformMouseEvent::PlatformMouseEvent):
3114 * platform/gtk/PlatformWheelEventGtk.cpp:
3115 (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3116 * platform/qt/PlatformKeyboardEventQt.cpp:
3117 (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
3118 * platform/qt/PlatformMouseEventQt.cpp:
3119 (WebCore::mouseEventModifiersFromQtKeyboardModifiers):
3120 (WebCore::PlatformMouseEvent::PlatformMouseEvent):
3121 * platform/qt/PlatformTouchEventQt.cpp:
3122 (WebCore::PlatformTouchEvent::PlatformTouchEvent):
3123 * platform/win/KeyEventWin.cpp:
3124 (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
3125 * platform/win/WheelEventWin.cpp:
3126 (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3127 Update for new variables/names.
3129 2011-12-22 Andreas Kling <kling@webkit.org>
3131 CSSParser: Avoid creating dummy declaration in parseColor() slow path.
3132 <http://webkit.org/b/75104>
3134 Reviewed by Darin Adler.
3136 We only needed the dummy declaration to trigger the instantiation of
3137 a CSSValuePool. Added an ensureCSSValuePool() method and have parseColor()
3140 Also renamed the fast-path parseColor() to fastParseColor() and reordered
3141 the arguments for consistency with the slow-path parseColor().
3143 * css/CSSParser.cpp:
3144 (WebCore::parseColorValue):
3145 (WebCore::CSSParser::parseColor):
3146 (WebCore::CSSParser::ensureCSSValuePool):
3147 (WebCore::CSSParser::fastParseColor):
3148 (WebCore::CSSParser::parseColorFromValue):
3151 2011-12-21 Andreas Kling <kling@webkit.org>
3153 Automate elements' registration as document namedItem/extraNamedItem.
3154 <http://webkit.org/b/74991>
3156 Reviewed by Antti Koivisto.
3158 Remove caching of the "id" and "name" attributes on applet, embed, form,
3159 image and object elements. We were caching them to keep the document's
3160 map of named and "extra named" (named by id) item counts in sync.
3162 Instead, add a hook to Element::willModifyAttribute() that detects when
3163 the attributes are being changed and handle the registration/unregistration
3164 automatically if the element returns true for shouldRegisterAsNamedItem()
3165 or shouldRegisterAsExtraNamedItem() respectively.
3167 This shrinks the elements by two AtomicStrings (8 or 16 bytes) each.
3169 IFrame elements retain the old mechanism for now, as there are some subtle
3170 differences to how that's handled.
3173 (WebCore::Node::hasName):
3174 (WebCore::Node::setHasName):
3176 Cache whether we have a "name" attribute or not (1 bit on Node.)
3177 This is done in order to minimize the overhead added to Element's
3178 insertedIntoDocument() and removeFromDocument().
3180 * dom/StyledElement.cpp:
3181 (WebCore::StyledElement::attributeChanged):
3183 Update the Node's has-name flag as appropriate.
3186 (WebCore::Element::updateNamedItemRegistration):
3187 (WebCore::Element::updateExtraNamedItemRegistration):
3189 Added. Called when the "name" and "id" attributes are changed.
3190 Updates the document's named item maps accordingly.
3192 (WebCore::Element::insertedIntoDocument):
3193 (WebCore::Element::removedFromDocument):
3195 Make sure updateName() is called in addition to updateId() when applicable.
3198 (WebCore::Element::shouldRegisterAsNamedItem):
3199 (WebCore::Element::shouldRegisterAsExtraNamedItem):
3201 Added. If an element returns true for these, it will be automatically
3202 registered with the document when the name/id attribute changes.
3204 (WebCore::Element::updateId):
3205 (WebCore::Element::updateName):
3207 Register/unregister from the document's named item maps as appropriate.
3209 (WebCore::Element::willModifyAttribute):
3211 Add updateName() hook in addition to the existing updateId() hook.
3213 * dom/NamedNodeMap.cpp:
3214 (WebCore::NamedNodeMap::setAttributes):
3216 Make sure updateName() is called when we're cloning the attributes
3217 from another element.
3219 * html/HTMLAppletElement.cpp:
3220 (WebCore::HTMLAppletElement::parseMappedAttribute):
3221 * html/HTMLAppletElement.h:
3222 * html/HTMLEmbedElement.cpp:
3223 (WebCore::HTMLEmbedElement::parseMappedAttribute):
3224 (WebCore::HTMLEmbedElement::insertedIntoDocument):
3225 * html/HTMLEmbedElement.h:
3226 * html/HTMLFormElement.cpp:
3227 (WebCore::HTMLFormElement::insertedIntoDocument):
3228 (WebCore::HTMLFormElement::removedFromDocument):
3229 (WebCore::HTMLFormElement::parseMappedAttribute):
3230 * html/HTMLFormElement.h:
3231 * html/HTMLImageElement.cpp:
3232 (WebCore::HTMLImageElement::parseMappedAttribute):
3233 (WebCore::HTMLImageElement::insertedIntoDocument):
3234 * html/HTMLImageElement.h:
3235 * html/HTMLObjectElement.cpp:
3236 (WebCore::HTMLObjectElement::parseMappedAttribute):
3237 (WebCore::HTMLObjectElement::insertedIntoDocument):
3238 (WebCore::HTMLObjectElement::removedFromDocument):
3239 * html/HTMLObjectElement.h:
3240 * html/HTMLPlugInElement.h:
3242 Remove duplicated code that is now handled by Element.
3244 * html/HTMLObjectElement.cpp:
3245 (WebCore::HTMLObjectElement::updateDocNamedItem):
3246 (WebCore::HTMLObjectElement::formControlName):
3248 Use fastGetAttribute() since we no longer cache the name.
3250 2011-12-23 Anders Carlsson <andersca@apple.com>
3252 Add two (currently unused) new member functions to ScrollElasticityControllerClient
3253 https://bugs.webkit.org/show_bug.cgi?id=75179
3255 Reviewed by Dan Bernstein.
3257 This is so we'll be able to move more code to ScrollElasticityController.
3259 * platform/mac/ScrollAnimatorMac.h:
3260 * platform/mac/ScrollAnimatorMac.mm:
3261 (WebCore::ScrollAnimatorMac::pinnedInDirection):
3262 (WebCore::ScrollAnimatorMac::immediateScrollByWithoutContentEdgeConstraints):
3263 * platform/mac/ScrollElasticityController.h:
3265 2011-12-23 Simon Fraser <simon.fraser@apple.com>
3267 Blur filter doesn't invalidate enough
3268 https://bugs.webkit.org/show_bug.cgi?id=74891
3270 Reviewed by Darin Adler.
3272 Take the effects of filters into account for repainting; we need
3273 to inflate the repaint rect by the outsets provided by the filter.
3275 Test: css3/filters/filter-repaint.html
3277 * rendering/RenderBox.cpp:
3278 (WebCore::RenderBox::computeRectForRepaint):
3279 * rendering/RenderInline.cpp:
3280 (WebCore::RenderInline::computeRectForRepaint):
3282 2011-12-23 Simon Fraser <simon.fraser@apple.com>
3284 Filters should apply to inline elements
3285 https://bugs.webkit.org/show_bug.cgi?id=75152
3287 Reviewed by Darin Adler.
3289 Filters need to cause creation of RenderLayers for inlines, just like
3290 opacity and masks do.
3292 Test: css3/filters/filtered-inline.html
3294 * rendering/RenderInline.h:
3295 (WebCore::RenderInline::requiresLayer):
3296 * rendering/RenderTableRow.h: Remove an obviously incorrect comment.
3298 2011-12-23 Jarred Nicholls <jarred@sencha.com>
3300 Synchronous XHR in window context should not support new XHR responseTypes for HTTP(S) requests
3301 https://bugs.webkit.org/show_bug.cgi?id=72154
3303 Per the latest W3C editor draft: http://dvcs.w3.org/hg/xhr/raw-file/tip/Overview.html
3304 This is a spec-mandated attempt to thwart and otherwise discourage the use of synchronous XHR
3305 in the window context by deliberately not exposing newer functionality. Here we are disabling
3306 the use of responseType in synchronous HTTP(S) XHR requests from the window context.
3308 When a user attempts this action, an InvalidAccessError exception is thrown and a message is
3309 printed to the console to further explain.
3311 Renamed reportUnsafeUsage to a more generic name, and hoisted it up so it would be defined
3312 earlier and thus referenceable by setResponseType.
3314 Reviewed by Alexey Proskuryakov.
3316 Test: fast/xmlhttprequest/xmlhttprequest-responsetype-sync-request.html
3318 * xml/XMLHttpRequest.cpp:
3319 (WebCore::logConsoleError):
3320 reportUnsafeUsage -> logConsoleError
3321 (WebCore::XMLHttpRequest::setResponseType):
3322 (WebCore::XMLHttpRequest::setRequestHeader):
3323 reportUnsafeUsage -> logConsoleError
3324 (WebCore::XMLHttpRequest::getResponseHeader):
3325 reportUnsafeUsage -> logConsoleError
3326 (WebCore::XMLHttpRequest::didFail):
3327 reportUnsafeUsage -> logConsoleError
3329 2011-12-23 Alexander Pavlov <apavlov@chromium.org>
3331 Web Inspector: Implement a worker for parsing out JavaScript function data
3332 https://bugs.webkit.org/show_bug.cgi?id=75166
3334 Reviewed by Pavel Feldman.
3336 Test: inspector/debugger/script-extract-outline.html
3338 * inspector/front-end/ScriptFormatter.js:
3339 (WebInspector.ScriptFormatter.prototype.formatContent):
3340 * inspector/front-end/ScriptFormatterWorker.js:
3345 (Array.prototype.keySet):
3347 2011-12-23 Ilya Tikhonovsky <loislo@chromium.org>
3349 Unreviewed, rolling out r103624.
3350 http://trac.webkit.org/changeset/103624
3351 https://bugs.webkit.org/show_bug.cgi?id=68916
3353 Broke Snow Leopard builders
3356 * DerivedSources.cpp:
3357 * DerivedSources.pri:
3358 * GNUmakefile.list.am:
3360 * WebCore.xcodeproj/project.pbxproj:
3361 * bindings/js/JSDirectoryEntryCustom.cpp:
3362 (WebCore::JSDirectoryEntry::getFile):
3363 (WebCore::JSDirectoryEntry::getDirectory):
3364 * bindings/js/JSDirectoryEntrySyncCustom.cpp:
3365 (WebCore::getFlags):
3366 * bindings/v8/custom/V8DirectoryEntryCustom.cpp:
3367 (WebCore::V8DirectoryEntry::getDirectoryCallback):
3368 (WebCore::V8DirectoryEntry::getFileCallback):
3369 * bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:
3370 (WebCore::getFlags):
3371 * fileapi/WebKitFlags.idl: Added.
3372 * page/DOMWindow.idl:
3373 * workers/WorkerContext.idl:
3375 2011-12-23 Eric Uhrhane <ericu@chromium.org>
3377 [fileapi] WebKitFlags should not be constructable per Directories & System spec
3378 https://bugs.webkit.org/show_bug.cgi?id=68916
3380 Reviewed by Eric Seidel.
3382 Remove IDL for the object and all DOM references to it.
3383 * fileapi/WebKitFlags.idl: Removed.
3384 * page/DOMWindow.idl:
3385 * workers/WorkerContext.idl:
3386 Remove references to the JSC/V8 objects compiled from the IDL.
3387 * bindings/js/JSDirectoryEntryCustom.cpp:
3388 (WebCore::JSDirectoryEntry::getFile):
3389 (WebCore::JSDirectoryEntry::getDirectory):
3390 * bindings/js/JSDirectoryEntrySyncCustom.cpp:
3391 (WebCore::getFlags):
3392 * bindings/v8/custom/V8DirectoryEntryCustom.cpp:
3393 (WebCore::V8DirectoryEntry::getDirectoryCallback):
3394 (WebCore::V8DirectoryEntry::getFileCallback):
3395 * bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:
3396 (WebCore::getFlags):
3399 * WebCore.vcproj/WebCore.vcproj:
3400 * WebCore.xcodeproj/project.pbxproj:
3401 * WebCore/CMakeLists.txt:
3402 * WebCore/CodeGenerators.pri:
3403 * WebCore/DerivedSources.cpp:
3404 * WebCore/GNUmakefile.list.am:
3406 2011-12-23 Pavel Feldman <pfeldman@google.com>
3408 Web Inspector: Migrate to native Function.prototype.bind; fix front-end compilation with the
3409 version of compiler that respects Function.prototype.bind.
3410 https://bugs.webkit.org/show_bug.cgi?id=75170
3412 Reviewed by Yury Semikhatsky.
3414 * inspector/front-end/ApplicationCacheModel.js:
3415 * inspector/front-end/CSSKeywordCompletions.js:
3416 (WebInspector.CSSKeywordCompletions.colors):
3417 * inspector/front-end/CSSStyleModel.js:
3418 * inspector/front-end/CompilerSourceMapping.js:
3419 * inspector/front-end/DOMAgent.js:
3420 (WebInspector.DOMAgent.prototype.pushNodeToFrontend):
3421 (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
3422 (WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable.onDocumentAvailable):
3423 (WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable):
3424 (WebInspector.DOMAgent.prototype._loadNodeAttributes):
3425 (WebInspector.DOMAgent.prototype.querySelector):
3426 (WebInspector.DOMAgent.prototype.querySelectorAll):
3427 * inspector/front-end/DebuggerModel.js:
3428 * inspector/front-end/DebuggerPresentationModel.js:
3429 * inspector/front-end/ExtensionAPI.js:
3430 (injectedExtensionAPI.InspectorExtensionAPI):
3431 (injectedExtensionAPI):
3432 * inspector/front-end/ExtensionPanel.js:
3433 * inspector/front-end/NetworkManager.js:
3434 (WebInspector.NetworkManager.prototype.enableResourceTracking):
3435 (WebInspector.NetworkManager.prototype.disableResourceTracking):
3436 * inspector/front-end/Script.js:
3437 * inspector/front-end/Settings.js:
3438 * inspector/front-end/TextPrompt.js:
3439 (WebInspector.TextPrompt.prototype.complete):
3440 * inspector/front-end/utilities.js:
3442 2011-12-23 Leo Yang <leo.yang@torchmobile.com.cn>
3444 [BlackBerry] Add the BlackBerry specific pauseLoad(bool) to ResourceHandle
3445 https://bugs.webkit.org/show_bug.cgi?id=75162
3447 Reviewed by George Staikos.
3449 The porting can be built now, no new tests so far.
3451 * platform/network/ResourceHandle.h:
3453 2011-12-23 Karl Koscher <supersat@chromium.org>
3455 Give embedders a chance to handle postMessage calls
3456 https://bugs.webkit.org/show_bug.cgi?id=73883
3458 To support cross-process postMessage calls in Chromium (bug 73337), we need to intercept
3459 postMessage calls to proxy windows. Originally we were just going to add a native event
3460 listener on the Chromium side, but that required more changes to WebKit and was a bit of
3461 a hack. See bug 73359 for a discuss about moving to this approach.
3463 Reviewed by Adam Barth.
3465 Test: platform/chromium/fast/events/intercept-postmessage.html
3467 * loader/FrameLoaderClient.h:
3468 (WebCore::FrameLoaderClient::willCheckAndDispatchPostMessage): new method to allow the
3469 embedder to intercept postMessage calls
3470 * page/DOMWindow.cpp:
3471 (WebCore::DOMWindow::postMessageTimerFired): add a call to
3472 FrameLoaderClient::willCheckAndDispatchPostMessage
3474 2011-12-23 Tom Sepez <tsepez@chromium.org>
3476 XSLT-created HTML documents do not inherit content-security-policy from originally loaded XML.
3477 https://bugs.webkit.org/show_bug.cgi?id=75043
3479 Reviewed by Adam Barth.
3481 Test: http/tests/security/contentSecurityPolicy/xsl-img-blocked.php
3483 * page/ContentSecurityPolicy.cpp:
3484 (WebCore::ContentSecurityPolicy::copyStateFrom):
3485 (WebCore::ContentSecurityPolicy::didReceiveHeader):
3486 * page/ContentSecurityPolicy.h:
3487 * xml/XSLTProcessor.cpp:
3488 (WebCore::XSLTProcessor::createDocumentFromSource):
3490 2011-12-23 Darin Adler <darin@apple.com&