Simplify ComplexTextController::collectComplexTextRuns()
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-06-09  Dan Bernstein  <mitz@apple.com>
2
3         Reviewed by Darin Adler.
4
5         Simplify ComplexTextController::collectComplexTextRuns()
6         https://bugs.webkit.org/show_bug.cgi?id=62387
7
8         No new test, since functionality is unchanged.
9
10         * platform/graphics/mac/ComplexTextController.cpp:
11         (WebCore::ComplexTextController::collectComplexTextRuns): Always iterate characters in logical order,
12         then reverse the run vector for RTL.
13
14 2011-06-09  Dimitri Glazkov  <dglazkov@chromium.org>
15
16         Reviewed by Kent Tamura.
17
18         Fold isShadowBoundary into isShadowRoot.
19         https://bugs.webkit.org/show_bug.cgi?id=62317
20
21         Since there are no longer cases where Node::isShadowBoundary() != Node::isShadowRoot, we can remove this function.
22
23         In one case where isShadowBoundary was also tested to find ShadowContentElemnt, added a new isContentElement function.
24
25         Refactoring, covered by existing tests.
26
27         * css/CSSStyleSelector.cpp:
28         (WebCore::isAtShadowBoundary): Changed to use isShadowRoot.
29         * dom/Element.cpp:
30         (WebCore::Element::isSpellCheckingEnabled): Ditto.
31         * dom/Node.cpp:
32         (WebCore::Node::nonBoundaryShadowTreeRootNode): Ditto.
33         (WebCore::Node::nonShadowBoundaryParentNode): Ditto.
34         * dom/Node.h:
35         (WebCore::Node::isContentElement): Added.
36         * dom/NodeRenderingContext.cpp:
37         (WebCore::NodeRenderingContext::NodeRenderingContext): Changed to use isShadowRoot.
38         * dom/Position.cpp:
39         (WebCore::Position::Position): Ditto.
40         * dom/ShadowContentElement.h:
41         (WebCore::ShadowContentElement::isContentElement): Added.
42         * dom/ShadowRoot.cpp:
43         (WebCore::ShadowRoot::hasContentElement): Changed to use isContentElement.
44         * editing/CompositeEditCommand.cpp:
45         (WebCore::CompositeEditCommand::insertNodeAfter): Changed to use isShadowRoot.
46         * editing/htmlediting.cpp:
47         (WebCore::visiblePositionBeforeNode): Ditto.
48         (WebCore::visiblePositionAfterNode): Ditto.
49         * page/DragController.cpp:
50         (WebCore::asFileInput): Ditto.
51         * rendering/RenderTreeAsText.cpp:
52         (WebCore::nodePosition): Ditto.
53
54 2011-06-09  Simon Fraser  <simon.fraser@apple.com>
55
56         Reviewed by Darin Adler.
57
58         Crashes in RenderLayerBacking::paintingGoesToWindow
59         https://bugs.webkit.org/show_bug.cgi?id=61159
60
61         Speculative fix for unreproducible crash that can occur when RenderObject::repaintUsingContainer()
62         finds a repaintContainer that is not the RenderView, but that is also not
63         composited (for unknown reasons), by checking to see if the layer is
64         compositing before using backing(). An assertion remains to try to catch
65         this in debug builds.
66
67         * rendering/RenderLayer.cpp:
68         (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
69
70 2011-06-09  Julien Chaffraix  <jchaffraix@webkit.org>
71
72         Reviewed by Darin Adler.
73
74         WebCore::WebKitCSSKeyframesRuleInternal::nameAttrSetter() - crash
75         https://bugs.webkit.org/show_bug.cgi?id=62384
76
77         Test: fast/css/webkit-keyframes-crash.html
78
79         * css/WebKitCSSKeyframesRule.cpp:
80         (WebCore::WebKitCSSKeyframesRule::setName): stylesheet() is never garanteed
81         to return a non-null pointer. Thus null-check here like the rest of the code.
82
83 2011-06-09  Julien Chaffraix  <jchaffraix@codeaurora.org>
84
85         Reviewed by David Hyatt.
86
87         chrome.dll!WebCore::RenderStyle::fontMetrics ReadAV@NULL (two crashes)
88         https://bugs.webkit.org/show_bug.cgi?id=57756
89
90         Tests: fast/css/fontMetric-border-radius-null-crash.html
91                fast/css/fontMetric-webkit-border-end-width-null-crash.html
92
93         * css/CSSStyleSelector.cpp:
94         (WebCore::CSSStyleSelector::styleForElement): Added a call to Font::update
95         so that our FontFallbackList is allocated if we ever need it when applying our
96         style rules.
97
98 2011-06-09  Cary Clark  <caryclark@google.com>
99
100         Reviewed by Eric Seidel.
101
102         Create local CG context for Mac UI elements when Skia is renderer
103         https://bugs.webkit.org/show_bug.cgi?id=62213
104
105         When building Mac Chrome using Skia as the WebKit renderer,
106         add state to LocalCurrentGraphicsContext to convert the SkCanvas
107         context passed by WebKit into the CGContext needed by UI
108         rendering.
109
110         No new tests.  The define typo in question is
111         not yet enabled, so this change has no functional
112         impact.
113
114         * platform/mac/LocalCurrentGraphicsContext.h:
115         Add SkiaBitLocker to create and release the converted CGContext.
116         Add ContextContainer, a class for Skia to create and release
117         the converted CGContext. If Skia is not used, the class has no effect.
118
119         * platform/mac/LocalCurrentGraphicsContext.mm:
120         (WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext):
121         When building with Skia, create the CGContext before passing it on.
122
123         (WebCore::LocalCurrentGraphicsContext::cgContext):
124         Get the CGContext from the SkiaBitLocker, or the saved context,
125         as appropriate.
126
127         * rendering/RenderThemeMac.mm:
128         Get the CGContext from Skia conversion or native, as appropriate.
129         Use the LocalCurrentGraphicsContext if there is one. Otherwise,
130         add a ContextContainer to house the SkCanvas to CGContext conversion.
131
132         (WebCore::RenderThemeMac::paintCapsLockIndicator):
133         (WebCore::RenderThemeMac::paintProgressBar):
134         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
135         (WebCore::RenderThemeMac::paintSliderTrack):
136         (WebCore::RenderThemeMac::paintMediaFullscreenButton):
137         (WebCore::RenderThemeMac::paintMediaMuteButton):
138         (WebCore::RenderThemeMac::paintMediaPlayButton):
139         (WebCore::RenderThemeMac::paintMediaSeekBackButton):
140         (WebCore::RenderThemeMac::paintMediaSeekForwardButton):
141         (WebCore::RenderThemeMac::paintMediaSliderTrack):
142         (WebCore::RenderThemeMac::paintMediaSliderThumb):
143         (WebCore::RenderThemeMac::paintMediaRewindButton):
144         (WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
145         (WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
146         (WebCore::RenderThemeMac::paintMediaControlsBackground):
147         (WebCore::RenderThemeMac::paintMediaCurrentTime):
148         (WebCore::RenderThemeMac::paintMediaTimeRemaining):
149         (WebCore::RenderThemeMac::paintMediaVolumeSliderContainer):
150         (WebCore::RenderThemeMac::paintMediaVolumeSliderTrack):
151         (WebCore::RenderThemeMac::paintMediaVolumeSliderThumb):
152
153 2011-06-02  Jer Noble  <jer.noble@apple.com>
154
155         Reviewed by Maciej Stachowiak.
156
157         REGRESSION: Page layout messed up after exiting full screen after video ends at jerryseinfeld.com
158         https://bugs.webkit.org/show_bug.cgi?id=61911
159         <rdar://problem/9523017>
160
161         Test: fullscreen/full-screen-video-offset.html
162
163         When the video element is taken full-screen in the new element full-screen API, return the
164         offset width and height of the placeholder renderer which is filling in for the full-screen
165         element.  To do so, override offsetWidth, Height, Left, and Top from Element.  These are
166         non-virtual functions, so make them virtual.
167
168         * dom/Element.cpp:
169         (WebCore::Element::adjustForLocalZoom): Made into a class-static function.
170         * dom/Element.h: Made offset functions virtual.
171         * html/HTMLMediaElement.cpp:
172         (WebCore::elementPlaceholder): Added; utility function.
173         (WebCore::HTMLMediaElement::offsetLeft): Added; virtual override of the 
174             Element function. Will be called directly via javascript.
175         (WebCore::HTMLMediaElement::offsetTop): Ditto.
176         (WebCore::HTMLMediaElement::offsetWidth): Ditto.
177         (WebCore::HTMLMediaElement::offsetHeight): Ditto.
178         * html/HTMLMediaElement.h:
179
180 2011-06-09  Dave Tapuska  <dtapuska@rim.com>
181
182         Reviewed by Daniel Bates.
183
184         PingLoader destructor could dereference 0 if the Resource
185         Handle creation failed.
186
187         https://bugs.webkit.org/show_bug.cgi?id=62304
188
189         * loader/PingLoader.cpp:
190         (WebCore::PingLoader::~PingLoader):
191
192 2011-06-08  Abhishek Arya  <inferno@chromium.org>
193
194         Reviewed by Ryosuke Niwa.
195
196         Make indexForVisiblePosition and isSelectableElement static.
197         https://bugs.webkit.org/show_bug.cgi?id=62329
198
199         This protects us when converting frame->selection->start() or end()
200         to VisiblePosition which blows away the RenderTextControl from
201         underneath (due to layout update).
202
203         Test: fast/forms/text-control-selection-crash.html
204
205         * accessibility/AccessibilityRenderObject.cpp:
206         (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
207         * rendering/RenderTextControl.cpp:
208         (WebCore::RenderTextControl::selectionStart):
209         (WebCore::RenderTextControl::selectionEnd):
210         (WebCore::RenderTextControl::isSelectableElement):
211         (WebCore::RenderTextControl::indexForVisiblePosition):
212         * rendering/RenderTextControl.h:
213
214 2011-06-09  Ben Murdoch  <benm@google.com>
215
216         Reviewed by Yury Semikhatsky.
217
218         Build break in ScriptProfile.cpp and inspector disabled.
219         https://bugs.webkit.org/show_bug.cgi?id=62373
220
221         No new tests - build fix only.
222
223         * bindings/v8/ScriptProfile.cpp: Add necessary guards.
224         * bindings/v8/ScriptProfile.h: ditto.
225
226 2011-06-09  Vsevolod Vlasov  <vsevik@chromium.org>
227
228         Reviewed by Yury Semikhatsky.
229
230         Web Inspector: Network panel preview tab does not reattach SourceFrame when switching between preview and response tabs.
231         https://bugs.webkit.org/show_bug.cgi?id=62298
232
233         * inspector/front-end/ResourcePreviewView.js:
234         (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown.callback):
235         (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown):
236
237 2011-06-09  Csaba Osztrogonác  <ossy@webkit.org>
238
239         [Qt][Mac] Speculative buildfix after r88286.
240
241         * platform/graphics/IntPoint.h:
242
243 2011-06-09  Mike Lawther  <mikelawther@chromium.org>
244
245         Reviewed by Kent Tamura.
246
247         Parsing issue with -webkit-calc
248         https://bugs.webkit.org/show_bug.cgi?id=62276
249
250         Set the CSSParserString for the calc functions.
251
252         Test: css3/calc/regression-62276.html
253
254         * css/CSSParser.cpp:
255         (WebCore::CSSParser::lex):
256
257 2011-06-09  Robert Hogan  <robert@webkit.org>
258
259         Reviewed by Andreas Kling.
260
261         Teach Qt about window.internals
262         https://bugs.webkit.org/show_bug.cgi?id=61074
263
264         A weakness of the Qt DRT setup is that things like JSContextRef are abstracted
265         away from the QtWebKit API so we need DumpRenderTreeSupportQt to access WebCore internals.
266         Since the window.internals object requires JSContextRef we need to implement it in DumpRenderTreeSupportQt
267         where we can access it. DumpRenderTreeSupportQt cannot be compiled outside Qt's WebCore and as it
268         is our only possible route into the WebCoreTestSupport class neither can the new window.internals plumbing.
269         Likewise we can't put the accessor in WebCoreTestSupport because it would then need to know about QWebFrame
270         and others. The only alternative seems like a compile time guard which we would have to teach the bots about.
271
272         * CodeGenerators.pri:
273         * WebCore.pri:
274         * WebCore.pro:
275
276 2011-06-08  Mikołaj Małecki  <m.malecki@samsung.com>
277
278         Reviewed by Pavel Feldman.
279
280         Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
281         https://bugs.webkit.org/show_bug.cgi?id=52791
282
283         No new tests. The problem can be reproduced by trying to create InspectorValue
284         from 1.0e-100 and call ->toJSONString() on this.
285
286         * inspector/InspectorValues.cpp:
287         (WebCore::InspectorBasicValue::writeJSON):
288         Added checking the predicted buffer size and choosing exponential format, or
289         eventually "NaN" if the buffer is too small for decimal format.
290
291 2011-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>
292
293         Unreviewed, rolling out r88387.
294         http://trac.webkit.org/changeset/88387
295         https://bugs.webkit.org/show_bug.cgi?id=62368
296
297         New tests introduced in 88387 fail on Leopard,GTK,Qt bots
298         (Requested by Ossy on #webkit).
299
300         * html/canvas/CanvasRenderingContext.cpp:
301         (WebCore::CanvasRenderingContext::checkOrigin):
302         * html/canvas/CanvasRenderingContext.h:
303         * html/canvas/WebGLRenderingContext.cpp:
304         (WebCore::WebGLRenderingContext::readPixels):
305         (WebCore::WebGLRenderingContext::texImage2D):
306         (WebCore::WebGLRenderingContext::videoFrameToImage):
307         (WebCore::WebGLRenderingContext::texSubImage2D):
308         * html/canvas/WebGLRenderingContext.h:
309
310 2011-06-09  Adam Barth  <abarth@webkit.org>
311
312         Reviewed by Eric Seidel.
313
314         Running script from attach can remove elements from the stack of open elements
315         https://bugs.webkit.org/show_bug.cgi?id=62160
316
317         When the tree build runs script synchronously, that script can remove
318         arbitrary elements from the stack of open elements.  We need to hold a
319         reference to |parent| in attach instead of rely upon the reference in
320         the stack of open elements.
321
322         Test: fast/parser/document-write-onload-clear.html
323
324         * html/parser/HTMLConstructionSite.cpp:
325         (WebCore::HTMLConstructionSite::attach):
326
327 2011-06-08  Luke Macpherson   <macpherson@chromium.org>
328
329         Reviewed by Eric Seidel.
330
331         Make CSSPrimitiveValue support cast to EVerticalAlign.
332         https://bugs.webkit.org/show_bug.cgi?id=62356
333
334         No new tests / refactoring only.
335
336         * css/CSSPrimitiveValueMappings.h:
337         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
338         (WebCore::CSSPrimitiveValue::operator EVerticalAlign):
339         * css/CSSStyleSelector.cpp:
340         (WebCore::CSSStyleSelector::applyProperty):
341
342 2011-06-08  Justin Novosad  <junov@chromium.org>
343
344         Reviewed by James Robinson.
345
346         [Chromium] Crash when closing a tab with accelerated 2d canvas
347         https://bugs.webkit.org/show_bug.cgi?id=62324
348         Upon graphics context destruction, it is important to signal skia
349         to abandon all of its resource handles.  This prevents a crash caused
350         by skia attempting to release resources that were in the destroyed
351         graphics context.
352
353         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
354         (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
355
356 2011-06-08  James Robinson  <jamesr@chromium.org>
357
358         Reviewed by Darin Fisher.
359
360         REGRESSION(88260): 10-50% performance regression across many page cyclers
361         https://bugs.webkit.org/show_bug.cgi?id=62349
362
363         r88260 fixed a font cache resource leak and lowered the inactive font cache threshold.  The latter caused a
364         significant performance regression across many chromium page cyclers, for example
365         http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/moz/report.html?history=50&rev=88279.
366
367         This restores the previous inactive font size thresholds to their previous values, but retains the font cleanup
368         logic.
369
370         * platform/graphics/FontCache.cpp:
371
372 2011-06-08  Hayato Ito  <hayato@chromium.org>
373
374         Reviewed by Dimitri Glazkov.
375
376         A forward/backward tab traversal now visits focusable elements in a shadow root.
377         https://bugs.webkit.org/show_bug.cgi?id=61410
378
379         Test: fast/dom/shadow/tab-order-iframe-and-shadow.html
380
381         Like a iframe element, a shadow host becomes a scope of
382         tabindex. That means all descendant elements in a shadow root are
383         skipped if the host node of the shadow root is not focusable.
384
385         The patch doesn't affect HTMLInputElement and HTMLTextAreaElement,
386         which uses a shadow root and do extra works in their focus()
387         method.
388
389         A shadow root's <content> is not considered in this patch.
390         That will be addressed in a following patch.
391
392         * page/FocusController.cpp:
393         (WebCore::shadowRoot):
394         (WebCore::isTreeScopeOwner):
395         (WebCore::FocusController::deepFocusableNode):
396         (WebCore::FocusController::advanceFocusInDocumentOrder):
397         (WebCore::FocusController::findFocusableNodeAcrossTreeScope):
398         (WebCore::FocusController::findFocusableNode):
399         (WebCore::FocusController::nextFocusableNode):
400         (WebCore::FocusController::previousFocusableNode):
401         (WebCore::FocusController::ownerOfTreeScope):
402         * page/FocusController.h:
403
404 2011-06-08  Hayato Ito  <hayato@chromium.org>
405
406         Reviewed by Hajime Morita.
407
408         Makes sure that document.activeElement won't be an element in shadow root.
409
410         https://bugs.webkit.org/show_bug.cgi?id=61413
411
412         Test: fast/dom/shadow/activeelement-should-be-shadowhost.html
413
414         * html/HTMLDocument.cpp:
415         (WebCore::focusedFrameOwnerElement):
416         (WebCore::HTMLDocument::activeElement):
417
418 2011-06-08  Kent Tamura  <tkent@chromium.org>
419
420         Reviewed by Dimitri Glazkov.
421
422         Allow drawing a slider thumb for any nodes.
423         https://bugs.webkit.org/show_bug.cgi?id=62196
424
425         RenderObject::node() should provide various information which is
426         necessary for rendering. We don't need to refer the parent renderer.
427
428         * dom/Node.cpp:
429         (WebCore::Node::focusDe1egate): Added.
430         * dom/Node.h: Added a declaration.
431         * html/shadow/MediaControlElements.cpp:
432         (WebCore::toParentMediaElement):
433           Added an overload of toParentMediaElement() with Node* parameter.
434         * html/shadow/MediaControlElements.h:
435         (WebCore::toParentMediaElement): ditto.
436         * html/shadow/SliderThumbElement.cpp:
437         (WebCore::SliderThumbElement::isEnabledFormControl):
438           Returns the status of the host node.
439         (WebCore::SliderThumbElement::isReadOnlyFormControl): ditto.
440         (WebCore::SliderThumbElement::focusDe1egate):
441           Returns the host node so that RenderTheme::isFocused() returns true.
442         (WebCore::SliderThumbElement::detach): Style nit.
443         (WebCore::SliderThumbElement::hostInput):
444           Make it const because it is called by const functions.
445         * html/shadow/SliderThumbElement.h:
446           - Remove inDragMode()
447           - Update declarations
448         * platform/qt/RenderThemeQt.cpp:
449         (WebCore::RenderThemeQt::paintMediaSliderThumb):
450           Use Node::shadowAncestorNode() instead of RenderObject::parent() to
451           support deeper thumb nodes.
452         * rendering/RenderMediaControlsChromium.cpp:
453         (WebCore::paintMediaSliderThumb): ditto.
454         (WebCore::paintMediaVolumeSliderThumb): Remove isSlider() check.
455         * rendering/RenderSlider.cpp:
456         (WebCore::RenderSlider::inDragMode):
457           SliderThumbElement::inDragMode() was removed, and Node::active() has
458           the same information.
459         * rendering/RenderTheme.cpp:
460         (WebCore::RenderTheme::paint): Remove isSlider() checks.
461         (WebCore::RenderTheme::isFocused): Apply Node::focusDelegate().
462         * rendering/RenderThemeChromiumLinux.cpp:
463         (WebCore::RenderThemeChromiumLinux::paintSliderThumb):
464           isPressed() is enough.
465         * rendering/RenderThemeChromiumWin.cpp:
466           isEnabled(), isFocused(), and isPressed() are enough.
467         (WebCore::RenderThemeChromiumWin::determineSliderThumbState):
468         (WebCore::RenderThemeChromiumWin::determineClassicState):
469         * rendering/RenderThemeMac.mm:
470         (WebCore::RenderThemeMac::paintSliderThumb):
471           - Remove isSlider() check.
472           - Passing 'o' to udpateFooState functions is enough.
473           - isPressed() is enough.
474         * rendering/RenderThemeSafari.cpp:
475         (WebCore::RenderThemeSafari::paintSliderThumb):
476           We don't need special handling anymore.
477         * rendering/RenderThemeWin.cpp:
478         (WebCore::RenderThemeWin::determineSliderThumbState):
479           isEnabled(), isFocused(), and isPressed() are enough.
480
481 2011-06-08  Adam Barth  <abarth@webkit.org>
482
483         Reviewed by Eric Seidel.
484
485         constructTreeFromToken can re-enter parser, causing ASSERTs
486         https://bugs.webkit.org/show_bug.cgi?id=62160
487
488         This patch clears the HTMLToken before constructing the tree from the
489         token, putting the HTMLDocumentParser in a good state to be re-entered.
490
491         Tests: fast/parser/document-write-onload-nesting.html
492                fast/parser/document-write-onload-ordering.html
493
494         * html/parser/HTMLDocumentParser.cpp:
495         (WebCore::HTMLDocumentParser::pumpTokenizer):
496         * html/parser/HTMLToken.h:
497         (WebCore::HTMLToken::isUninitialized):
498         * html/parser/HTMLTreeBuilder.cpp:
499         (WebCore::HTMLTreeBuilder::constructTreeFromToken):
500
501 2011-06-08  Kent Tamura  <tkent@chromium.org>
502
503         Fix Qt build for r88405.
504         https://bugs.webkit.org/show_bug.cgi?id=62208
505
506         * platform/qt/RenderThemeQt.h:
507
508 2011-06-08  Kent Tamura  <tkent@chromium.org>
509
510         Reviewed by Dimitri Glazkov.
511
512         Change the argument of RenderTheme::adjustSliderThumbSize(): RenderObject* -> RenderStyle*
513         https://bugs.webkit.org/show_bug.cgi?id=62208
514
515         Change the argument type of RenderTheme::adjustSliderThumbSize() and
516         RenderMediaControls::adjustMediaSliderThumbSize() from RenderObject* to RenderStyle*.
517
518         Also, each of adjustSliderThumbStyle() overrides calls RenderTheme::
519         adjustSliderThumbStyle() for future changes.
520
521         No new tests. This is a refactoring and should not change any behavior.
522
523         * html/shadow/SliderThumbElement.cpp:
524         (WebCore::RenderSliderThumb::layout): Passing RenderStyle* and remove a FIXME comment.
525         * platform/efl/RenderThemeEfl.cpp:
526         (WebCore::RenderThemeEfl::adjustSliderThumbStyle): Calls RenderTheme::adjustSliderThumbStyle().
527         * platform/gtk/RenderThemeGtk.cpp:
528         (WebCore::RenderThemeGtk::adjustSliderThumbStyle): ditto.
529         (WebCore::RenderThemeGtk::adjustMediaSliderThumbSize):
530         * platform/gtk/RenderThemeGtk.h:
531         * platform/gtk/RenderThemeGtk2.cpp:
532         (WebCore::RenderThemeGtk::adjustSliderThumbSize):
533         * platform/gtk/RenderThemeGtk3.cpp:
534         (WebCore::RenderThemeGtk::adjustSliderThumbSize):
535         * platform/qt/RenderThemeQt.cpp:
536         (WebCore::RenderThemeQt::adjustSliderThumbStyle): ditto.
537         (WebCore::RenderThemeQt::adjustSliderThumbSize):
538         * rendering/RenderMediaControls.cpp:
539         (WebCore::RenderMediaControls::adjustMediaSliderThumbSize):
540         * rendering/RenderMediaControls.h:
541         * rendering/RenderMediaControlsChromium.cpp:
542         (WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize):
543         * rendering/RenderMediaControlsChromium.h:
544         * rendering/RenderSlider.cpp:
545         (WebCore::RenderSlider::layout): Passing RenderStyle* and remove a FIXME comment.
546         * rendering/RenderTheme.cpp:
547         (WebCore::RenderTheme::adjustSliderThumbStyle): Add a comment.
548         (WebCore::RenderTheme::adjustSliderThumbSize):
549         * rendering/RenderTheme.h:
550         * rendering/RenderThemeChromiumLinux.cpp:
551         (WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
552         * rendering/RenderThemeChromiumLinux.h:
553         * rendering/RenderThemeChromiumMac.h:
554         * rendering/RenderThemeChromiumMac.mm:
555         (WebCore::RenderThemeChromiumMac::adjustMediaSliderThumbSize):
556         * rendering/RenderThemeChromiumSkia.cpp:
557         (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):
558         * rendering/RenderThemeChromiumSkia.h:
559         * rendering/RenderThemeChromiumWin.cpp:
560         (WebCore::RenderThemeChromiumWin::adjustSliderThumbSize):
561         * rendering/RenderThemeChromiumWin.h:
562         * rendering/RenderThemeMac.h:
563         * rendering/RenderThemeMac.mm:
564         (WebCore::RenderThemeMac::adjustSliderThumbStyle): Calls RenderTheme::adjustSliderThumbStyle().
565         (WebCore::RenderThemeMac::adjustSliderThumbSize):
566         (WebCore::RenderThemeMac::adjustMediaSliderThumbSize):
567         * rendering/RenderThemeSafari.cpp:
568         (WebCore::RenderThemeSafari::adjustSliderThumbStyle): Calls RenderTheme::adjustSliderThumbStyle().
569         (WebCore::RenderThemeSafari::adjustSliderThumbSize):
570         * rendering/RenderThemeSafari.h:
571         * rendering/RenderThemeWin.cpp:
572         (WebCore::RenderThemeWin::adjustSliderThumbSize):
573         * rendering/RenderThemeWin.h:
574         * rendering/RenderThemeWinCE.cpp:
575         (WebCore::RenderThemeWinCE::adjustSliderThumbSize):
576         * rendering/RenderThemeWinCE.h:
577
578 2011-06-08  Brian Salomon  <bsalomon@google.com>
579
580         Reviewed by James Robinson.
581
582         Avoid always binding FBO 0 implicitly when deleting FBO in DrawingBuffer code because it invalidates Ganesh's cache of the current FBO.
583         https://bugs.webkit.org/show_bug.cgi?id=62318
584
585         Chromium-only crash
586         Failures takes multiple seconds to occur, relying on JS garbage-collection to occur 
587         http://www.hotbazooka.com/privatejoe-large
588
589         * platform/graphics/gpu/DrawingBuffer.cpp:
590         (WebCore::DrawingBuffer::clear):
591
592 2011-06-08  Emil A Eklund  <eae@chromium.org>
593
594         Reviewed by Eric Seidel.
595
596         RenderEmbeddedObject::getReplacementTextGeometry
597         https://bugs.webkit.org/show_bug.cgi?id=62313
598
599         Replace the last use of tx, ty with IntPoint.
600
601         Covered by existing tests.
602
603         * platform/graphics/FloatRect.h:
604         (WebCore::FloatRect::move):
605         (WebCore::FloatRect::moveBy):
606         * rendering/RenderEmbeddedObject.cpp:
607         (WebCore::RenderEmbeddedObject::paintReplaced):
608         (WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
609         (WebCore::RenderEmbeddedObject::isInMissingPluginIndicator):
610         * rendering/RenderEmbeddedObject.h:
611
612 2011-06-08  Tim Horton  <timothy_horton@apple.com>
613
614         Reviewed by Ryosuke Niwa.
615
616         Use correct CFURLStorageSessionRef definition on Leopard, as
617         we created an inconsistency in const-ness between
618         WebCoreSystemInterface.h and these two files in the case
619         of Leopard only.
620         https://bugs.webkit.org/show_bug.cgi?id=62223
621
622         * platform/network/ResourceHandle.h:
623         * platform/network/cf/ResourceRequest.h:
624
625 2011-06-08  Sailesh Agrawal  <sail@chromium.org>
626
627         Reviewed by Mihai Parparita.
628
629         Chromium Mac: Enable overlay scrollbars
630         https://bugs.webkit.org/show_bug.cgi?id=59756
631
632         Sync ScrollbarThemeChromiumMac.mm/.h with ScrollbarThemeMac.mm to pick up support for overlay scrollbars. The only changes are renaming ScrollbarThemeMac to ScrollbarThemeChromiumMac and using runtime checks instead of #ifdef's.
633
634         No new tests, since this code is only enabled on future versions of Mac OS X.
635
636         * platform/chromium/ScrollAnimatorChromiumMac.mm: All changes to this file except in scroll() were to swap #if USE(WK_SCROLLBAR_PAINTER) with runtime checks.
637         (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac):
638         (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac):
639         (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged):
640         (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint):
641         (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea):
642         (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea):
643         (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea):
644         (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize):
645         (WebCore::ScrollAnimatorChromiumMac::contentsResized):
646         (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize):
647         (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow):
648         (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide):
649         (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture):
650         (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture):
651         (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar):
652         (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar):
653         (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar):
654         (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar):
655         (WebCore::ScrollAnimatorChromiumMac::cancelAnimations):
656         * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
657         (preferredScrollerStyle): Disabled overlay scrollbar styles due to trailing artifacts.
658         (wkScrollbarPainterPaint): Fixed a problem where the scrollbar track wasn't being drawn.
659         (wkScrollbarPainterKnobRect): Implemented a previously unimplemented function.
660         (wkSetScrollbarPainterKnobStyle): Implemented a function that's now supported by the latest Mac OS X seeds.
661         (isScrollbarOverlayAPIAvailable): Enabled new scrollbar code.
662         * platform/chromium/ScrollbarThemeChromiumMac.h:
663         * platform/chromium/ScrollbarThemeChromiumMac.mm: Sync with ScrollbarThemeMac.mm.
664         (WebCore::scrollbarMap):
665         (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
666         (WebCore::updateArrowPlacement):
667         (WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
668         (WebCore::ScrollbarThemeChromiumMac::unregisterScrollbar):
669         (WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
670         (WebCore::ScrollbarThemeChromiumMac::painterForScrollbar):
671         (WebCore::ScrollbarThemeChromiumMac::scrollbarThickness):
672         (WebCore::ScrollbarThemeChromiumMac::usesOverlayScrollbars):
673         (WebCore::ScrollbarThemeChromiumMac::hasButtons):
674         (WebCore::ScrollbarThemeChromiumMac::hasThumb):
675         (WebCore::buttonRepaintRect):
676         (WebCore::ScrollbarThemeChromiumMac::minimumThumbLength):
677         (WebCore::ScrollbarThemeChromiumMac::shouldDragDocumentInsteadOfThumb):
678         (WebCore::toScrollbarPainterKnobStyle):
679         (WebCore::ScrollbarThemeChromiumMac::paint):
680
681 2011-06-06  Nate Chapin  <japhet@chromium.org>
682
683         Reviewed by Adam Barth.
684
685         Remove all knowledge of CachedResourceRequests from
686         CachedResourceLoader. This puts the full burden of
687         canceling these requests on DocumentLoader (via
688         SubresourceLoader), and makes a CachedResourceRequest
689         an OwnPtr in CachedResource.
690
691         https://bugs.webkit.org/show_bug.cgi?id=62308
692
693         * loader/FrameLoader.cpp:
694         (WebCore::FrameLoader::stopLoading):
695         * loader/cache/CachedResource.cpp:
696         (WebCore::CachedResource::CachedResource):
697         (WebCore::CachedResource::load):
698         (WebCore::CachedResource::stopLoading):
699         * loader/cache/CachedResource.h:
700         * loader/cache/CachedResourceLoader.cpp:
701         (WebCore::CachedResourceLoader::~CachedResourceLoader):
702         (WebCore::CachedResourceLoader::loadDone):
703         * loader/cache/CachedResourceLoader.h:
704         * loader/cache/CachedResourceRequest.cpp:
705         (WebCore::CachedResourceRequest::CachedResourceRequest):
706         (WebCore::CachedResourceRequest::~CachedResourceRequest):
707         (WebCore::CachedResourceRequest::load):
708         (WebCore::CachedResourceRequest::didFinishLoading):
709         (WebCore::CachedResourceRequest::didFail):
710         (WebCore::CachedResourceRequest::didReceiveResponse):
711         (WebCore::CachedResourceRequest::end):
712         * loader/cache/CachedResourceRequest.h:
713
714 2011-06-08  Mike Reed  <reed@google.com>
715
716         Reviewed by James Robinson.
717
718         [Skia] check for null-shader from gradient factory
719         https://bugs.webkit.org/show_bug.cgi?id=62319
720
721         * platform/graphics/skia/GradientSkia.cpp:
722         (WebCore::Gradient::platformDestroy):
723         (WebCore::Gradient::platformGradient):
724
725 2011-06-08  Kenneth Russell  <kbr@google.com>
726
727         Reviewed by Adam Barth.
728
729         Disallow use of cross-domain media (images, video) in WebGL
730         https://bugs.webkit.org/show_bug.cgi?id=62257
731
732         Updated WebGL implementation to track recent spec updates in this area.
733
734         Tests: http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html
735                http/tests/security/webgl-remote-read-remote-image-allowed.html
736                http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html
737
738         * html/canvas/CanvasRenderingContext.cpp:
739         (WebCore::CanvasRenderingContext::wouldTaintOrigin):
740         (WebCore::CanvasRenderingContext::checkOrigin):
741         * html/canvas/CanvasRenderingContext.h:
742         (WebCore::CanvasRenderingContext::checkOrigin):
743         * html/canvas/WebGLRenderingContext.cpp:
744         (WebCore::WebGLRenderingContext::readPixels):
745         (WebCore::WebGLRenderingContext::texImage2D):
746         (WebCore::WebGLRenderingContext::videoFrameToImage):
747         (WebCore::WebGLRenderingContext::texSubImage2D):
748         * html/canvas/WebGLRenderingContext.h:
749
750 2011-06-08  John Bauman  <jbauman@chromium.org>
751
752         Reviewed by James Robinson.
753
754         Only draw portions of tiles in contentRect
755         https://bugs.webkit.org/show_bug.cgi?id=62243
756
757         Old garbage data can remain in tiles, so make sure to draw only those
758         portions that are supposed to be drawn.
759
760         Test: compositing/repaint/shrink-layer.html
761
762         * platform/graphics/chromium/LayerTilerChromium.cpp:
763         (WebCore::LayerTilerChromium::draw):
764
765 2011-06-08  Emil A Eklund  <eae@chromium.org>
766
767         Reviewed by Eric Seidel.
768
769         Convert RenderBlock::isPointInOverflowControl to IntPoint
770         https://bugs.webkit.org/show_bug.cgi?id=62312
771
772         Covered by existing tests.
773
774         * rendering/RenderBlock.cpp:
775         (WebCore::RenderBlock::isPointInOverflowControl):
776         (WebCore::RenderBlock::nodeAtPoint):
777         * rendering/RenderBlock.h:
778         * rendering/RenderListBox.cpp:
779         (WebCore::RenderListBox::isPointInOverflowControl):
780         * rendering/RenderListBox.h:
781
782 2011-06-08  James Simonsen  <simonjam@chromium.org>
783
784         Reviewed by Tony Gentilcore.
785
786         Fix clang issue, virtual function const mismatch
787         https://bugs.webkit.org/show_bug.cgi?id=62307
788
789         No new tests. Built with clang & ran layout tests.
790
791         * page/MediaStreamFrameController.h:
792         (WebCore::MediaStreamFrameController::GenericClient::isGenericClient):
793
794 2011-06-08  Chris Rogers  <crogers@google.com>
795
796         Reviewed by Kenneth Russell.
797
798         Implement BiquadFilterNode for filter types: LOWPASS, HIGHPASS, BANDPASS, LOWSHELF, HIGHSHELF, PEAKING, NOTCH, ALLPASS
799         https://bugs.webkit.org/show_bug.cgi?id=62078
800
801         No new tests since audio API is not yet implemented.
802
803         * DerivedSources.make:
804         * WebCore.gypi:
805         * WebCore.xcodeproj/project.pbxproj:
806         * platform/audio/Biquad.cpp:
807         (WebCore::Biquad::Biquad):
808         (WebCore::Biquad::reset):
809         (WebCore::Biquad::setLowpassParams):
810         (WebCore::Biquad::setHighpassParams):
811         (WebCore::Biquad::setNormalizedCoefficients):
812         (WebCore::Biquad::setLowShelfParams):
813         (WebCore::Biquad::setHighShelfParams):
814         (WebCore::Biquad::setPeakingParams):
815         (WebCore::Biquad::setAllpassParams):
816         (WebCore::Biquad::setNotchParams):
817         (WebCore::Biquad::setBandpassParams):
818         (WebCore::Biquad::setZeroPolePairs):
819         (WebCore::Biquad::setAllpassPole):
820         * platform/audio/Biquad.h:
821         * webaudio/AudioContext.cpp:
822         (WebCore::AudioContext::createBiquadFilter):
823         (WebCore::AudioContext::createLowPass2Filter):
824         (WebCore::AudioContext::createHighPass2Filter):
825         * webaudio/AudioContext.h:
826         * webaudio/AudioContext.idl:
827         * webaudio/AudioNode.h:
828         * webaudio/BiquadDSPKernel.cpp:
829         (WebCore::BiquadDSPKernel::process):
830         * webaudio/BiquadFilterNode.cpp: Added.
831         (WebCore::BiquadFilterNode::BiquadFilterNode):
832         * webaudio/BiquadFilterNode.h: Added.
833         (WebCore::BiquadFilterNode::create):
834         (WebCore::BiquadFilterNode::type):
835         (WebCore::BiquadFilterNode::setType):
836         (WebCore::BiquadFilterNode::frequency):
837         (WebCore::BiquadFilterNode::q):
838         (WebCore::BiquadFilterNode::gain):
839         (WebCore::BiquadFilterNode::biquadProcessor):
840         * webaudio/BiquadFilterNode.idl: Added.
841         * webaudio/BiquadProcessor.cpp:
842         (WebCore::BiquadProcessor::BiquadProcessor):
843         * webaudio/BiquadProcessor.h:
844         (WebCore::BiquadProcessor::setType):
845         * webaudio/HighPass2FilterNode.cpp:
846         (WebCore::HighPass2FilterNode::HighPass2FilterNode):
847         * webaudio/LowPass2FilterNode.cpp:
848         (WebCore::LowPass2FilterNode::LowPass2FilterNode):
849
850 2011-06-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
851
852         Reviewed by Kenneth Rohde Christiansen.
853
854         WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
855         https://bugs.webkit.org/show_bug.cgi?id=61694
856
857         No new tests, code path is not activated yet.
858
859         * WebCore.xcodeproj/project.pbxproj: Changed the TransformOperation subclassed from "project" to "private"
860
861 2011-06-08  Tom Sepez  <tsepez@chromium.org>
862
863         Reviewed by Adam Barth.
864
865         Cause checks for insecure content blocking policy to callback to client.
866         https://bugs.webkit.org/show_bug.cgi?id=61946
867         Tests: platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed.html
868                platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked.html
869                platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-allowed.html
870                platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-blocked.html
871
872         * loader/FrameLoader.cpp:
873         (WebCore::FrameLoader::checkIfDisplayInsecureContent):
874         (WebCore::FrameLoader::checkIfRunInsecureContent):
875         * loader/FrameLoaderClient.h:
876         (WebCore::FrameLoaderClient::allowDisplayingInsecureContent):
877         (WebCore::FrameLoaderClient::allowRunningInsecureContent):
878
879 2011-06-08  Kevin Ollivier  <kevino@theolliviers.com>
880
881         [wx] Build fix after introduction of FontCache::ShouldRetain
882
883         * platform/graphics/wx/FontCacheWx.cpp:
884         (WebCore::FontCache::getFontDataForCharacters):
885
886 2011-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
887
888         Unreviewed, rolling out r88365.
889         http://trac.webkit.org/changeset/88365
890         https://bugs.webkit.org/show_bug.cgi?id=62301
891
892         windows bots broken (Requested by loislo_ on #webkit).
893
894         * inspector/InspectorValues.cpp:
895         (WebCore::InspectorBasicValue::writeJSON):
896
897 2011-06-08  Mikołaj Małecki  <m.malecki@samsung.com>
898
899         Reviewed by Pavel Feldman.
900
901         Web Inspector: Crash by buffer overrun crash when serializing inspector object tree.
902         https://bugs.webkit.org/show_bug.cgi?id=52791
903
904         No new tests. The problem can be reproduced by trying to create InspectorValue
905         from 1.0e-100 and call ->toJSONString() on this.
906
907         * inspector/InspectorValues.cpp:
908         (WebCore::InspectorBasicValue::writeJSON):
909         Added checking the predicted buffer size and choosing exponential format, or
910         eventually "NaN" if the buffer is too small for decimal format.
911
912 2011-06-08  Nico Weber  <thakis@chromium.org>
913
914         Reviewed by Darin Adler.
915
916         Fix a ?: precedence error in ScrollbarThemeMac and ScrollbarThemeChromium
917         https://bugs.webkit.org/show_bug.cgi?id=62295
918
919         This was found by a new warning recently added to clang's -Wparentheses
920
921         * platform/chromium/ScrollbarThemeChromiumMac.mm:
922         (WebCore::ScrollbarThemeChromiumMac::backButtonRect):
923         * platform/mac/ScrollbarThemeMac.mm:
924         (WebCore::ScrollbarThemeMac::backButtonRect):
925
926 2011-06-08  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
927
928         Reviewed by Andreas Kling.
929
930         [Qt] Remove dead code from our JSC bridge
931         https://bugs.webkit.org/show_bug.cgi?id=62287
932
933         The m_defaultMethod member is not used since r36848 and QtMethod
934         was replaced by QtRuntimeMethod and subclasses in r29729.
935
936         * bridge/qt/qt_instance.cpp:
937         (JSC::Bindings::QtInstance::removeCachedMethod):
938         (JSC::Bindings::QtInstance::visitAggregate):
939         * bridge/qt/qt_instance.h:
940         * bridge/qt/qt_runtime.h:
941
942 2011-06-08  Ryan Sleevi  <rsleevi@chromium.org>
943
944         Reviewed by Tony Chang.
945
946         Suppress C++0x compat warnings when compiling Chromium port with GCC 4.6
947
948         Compiling Chromium port under GCC 4.6 produces warnings about nullptr
949         https://bugs.webkit.org/show_bug.cgi?id=62242
950
951         * WebCore.gyp/WebCore.gyp:
952
953 2011-05-25  Xiaomei Ji  <xji@chromium.org>
954
955         Reviewed by Ryosuke Niwa.
956
957         --webkit-visual-word does not work well in words separated by multiple spaces
958         https://bugs.webkit.org/show_bug.cgi?id=61324
959
960         Remove positionBeforeNextWord and positionAfterPreviousWord short-cuts. They try to find the
961         right word boundary (before the space or after the space) by using previousWordPosition and
962         nextWordPosition. But they assume words are separated by single space and are not correct 
963         for words separated by multiple spaces and words not separated by space.
964
965         Consider positionBeforeNextWord() for example, 
966
967         First, it checks whether the current position is after the current word by checking current
968         position's previousWordPosition's nextWordPosition is the same as current position, which is
969         wrong for words separated by multiple spaces. For example, given words A and B separated by 
970         3 continuous spaces "A   B", position "A|", "A |", and "A  |" should all be considered as 
971         position after current word. But for position "A |", its previousWordPosition's 
972         nextWordPosition is position "A|", which is different from its current position, so the
973         current position is not considered as a position after current word, consequently,
974         instead of returning the right position as "A   |B", positionBeforeNextWord returns the
975         position before next next word, as "A   B |C". Similar happens for position "A  |".
976
977         Second, given 3 Chinese words "ABC" that are not segmented by space, when cursor is at 
978         "A|BC", positionBeforeNextWord() returns the same position after calling current position's
979         nextWordPosition's previousWordPosition. It should returns position "AB|C".
980
981         For those cases, we will have to collect all the word breaks inside the box and look for
982         the one at left or right of current position.
983
984         * editing/visible_units.cpp:
985         (WebCore::leftWordPosition):
986         (WebCore::rightWordPosition):
987
988 2011-06-08  Greg Simon  <gregsimon@chromium.org>
989
990         Reviewed by Dimitri Glazkov.
991
992         Control Indexeddb backends from LayoutTestController
993         https://bugs.webkit.org/show_bug.cgi?id=61000
994
995         Test: storage/indexeddb/migrate-basics.html
996
997         * storage/IDBBackingStore.h:
998         * storage/IDBFactoryBackendImpl.cpp:
999         (WebCore::IDBFactoryBackendImpl::open):
1000         (WebCore::IDBFactoryBackendImpl::migrate):
1001         * storage/IDBFactoryBackendImpl.h:
1002         * storage/IDBFactoryBackendInterface.h:
1003         * storage/IDBLevelDBBackingStore.cpp:
1004         (WebCore::IDBLevelDBBackingStore::backingStoreExists):
1005         * storage/IDBLevelDBBackingStore.h:
1006         (WebCore::IDBLevelDBBackingStore::backingStoreType):
1007         * storage/IDBSQLiteBackingStore.cpp:
1008         (WebCore::IDBSQLiteBackingStore::backingStoreExists):
1009         * storage/IDBSQLiteBackingStore.h:
1010         (WebCore::IDBSQLiteBackingStore::backingStoreType):
1011
1012 2011-06-08  Dmitry Lomov  <dslomov@google.com>
1013
1014         Reviewed by Adam Barth.
1015
1016         https://bugs.webkit.org/show_bug.cgi?id=62164
1017         Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and friends
1018         This functionality is untested and unused:
1019         This is an old code from Lockers-based implementation of WebWorkers in
1020         V8 bindings, to make sure that DOM objects are released on the right thread
1021         even though GC could have happened on any thread. It is currently unused (since
1022         current model is one worker per process) and is being removed because new implementation
1023         of WebWorkers will be using V8 isolates.
1024
1025         * WebCore.gypi:
1026         * WebCore.pro:
1027         * bindings/v8/ChildThreadDOMData.cpp: Removed.
1028         * bindings/v8/ChildThreadDOMData.h: Removed.
1029         * bindings/v8/DOMData.cpp:
1030         (WebCore::DOMData::DOMData):
1031         (WebCore::DOMData::getCurrent):
1032         (WebCore::DOMData::getMainThreadStore):
1033         * bindings/v8/DOMData.h:
1034         (WebCore::DOMData::getStore):
1035         (WebCore::DOMData::getCurrentMainThreadStore):
1036         (WebCore::DOMData::handleWeakObject):
1037         * bindings/v8/DOMDataStore.cpp:
1038         (WebCore::DOMDataStore::DOMDataStore):
1039         (WebCore::DOMDataStore::~DOMDataStore):
1040         (WebCore::DOMDataStore::weakNodeCallback):
1041         * bindings/v8/DOMDataStore.h:
1042         * bindings/v8/MainThreadDOMData.cpp: Removed.
1043         * bindings/v8/MainThreadDOMData.h: Removed.
1044         * bindings/v8/V8DOMMap.cpp:
1045         (WebCore::getDOMDataStore):
1046         (WebCore::removeAllDOMObjects):
1047         (WebCore::visitDOMNodes):
1048         (WebCore::visitDOMObjects):
1049         (WebCore::visitActiveDOMObjects):
1050         (WebCore::visitDOMSVGElementInstances):
1051         * bindings/v8/V8DOMMap.h:
1052         * bindings/v8/V8GCController.cpp:
1053         (WebCore::V8GCController::gcPrologue):
1054         (WebCore::V8GCController::gcEpilogue):
1055         * bindings/v8/WorkerScriptController.cpp:
1056         (WebCore::WorkerScriptController::~WorkerScriptController):
1057
1058 2011-06-08  Yael Aharon  <yael.aharon@nokia.com>
1059
1060         Reviewed by Andreas Kling.
1061
1062         [Qt] Build fix for building QtWebKit inside of Qt.
1063         https://bugs.webkit.org/show_bug.cgi?id=62280
1064
1065         Remove CONFIG=staticlib, because it causes the configure script to add -lwebcore
1066         into QtWebKit.prl.
1067
1068         No new tests, as this is just a build fix.
1069
1070         * WebCore.pri:
1071
1072 2011-06-08  Vsevolod Vlasov  <vsevik@chromium.org>
1073
1074         Reviewed by Pavel Feldman.
1075
1076         Web Inspector: Render non-document HTML resources as HTML
1077         https://bugs.webkit.org/show_bug.cgi?id=58886
1078
1079         * English.lproj/localizedStrings.js:
1080         * WebCore.gypi:
1081         * WebCore.vcproj/WebCore.vcproj:
1082         * inspector/front-end/NetworkItemView.js:
1083         (WebInspector.NetworkItemView):
1084         * inspector/front-end/Resource.js:
1085         (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
1086         (WebInspector.Resource.prototype.hasErrorStatusCode):
1087         * inspector/front-end/ResourceHTMLView.js: Added.
1088         (WebInspector.ResourceHTMLView):
1089         (WebInspector.ResourceHTMLView.prototype.hasContent):
1090         (WebInspector.ResourceHTMLView.prototype.show):
1091         (WebInspector.ResourceHTMLView.prototype.hide):
1092         (WebInspector.ResourceHTMLView.prototype._createIFrame):
1093         * inspector/front-end/ResourcePreviewView.js: Added.
1094         (WebInspector.ResourcePreviewView):
1095         (WebInspector.ResourcePreviewView.prototype.hasContent):
1096         (WebInspector.ResourcePreviewView.prototype.show):
1097         (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown.callback):
1098         (WebInspector.ResourcePreviewView.prototype._ensureInnerViewShown):
1099         (WebInspector.ResourcePreviewView.prototype._createInnerView):
1100         * inspector/front-end/Settings.js:
1101         (WebInspector.Settings):
1102         * inspector/front-end/WebKit.qrc:
1103         * inspector/front-end/inspector.css:
1104         (.resource-view.html iframe):
1105         * inspector/front-end/inspector.html:
1106
1107 2011-05-18  Pavel Podivilov  <podivilov@chromium.org>
1108
1109         Reviewed by Yury Semikhatsky.
1110
1111         Web Inspector: hide script location to ui location conversion details from ScriptsPanel.
1112         https://bugs.webkit.org/show_bug.cgi?id=61035
1113
1114         * inspector/front-end/DebuggerPresentationModel.js:
1115         (WebInspector.DebuggerPresentationModel.prototype.sourceFileForScriptURL):
1116         (WebInspector.DebuggerPresentationModel.prototype.scriptLocationToUILocation.didRequestSourceMapping):
1117         (WebInspector.DebuggerPresentationModel.prototype.scriptLocationToUILocation):
1118         * inspector/front-end/ScriptsPanel.js:
1119         (WebInspector.ScriptsPanel.prototype.showAnchorLocation.didGetUILocation):
1120         (WebInspector.ScriptsPanel.prototype.showAnchorLocation):
1121
1122 2011-06-08  Tommy Widenflycht  <tommyw@google.com>
1123
1124         Reviewed by Tony Gentilcore.
1125
1126         StreamEvent
1127
1128         Media Stream PeerConnection API: adding StreamEvent class
1129         https://bugs.webkit.org/show_bug.cgi?id=61537
1130
1131         Tests for the Media Stream API will be provided by the bug 56587.
1132
1133         * CMakeLists.txt:
1134         * CodeGenerators.pri:
1135         * DerivedSources.cpp:
1136         * DerivedSources.make:
1137         * GNUmakefile.list.am:
1138         * WebCore.gypi:
1139         * WebCore.pro:
1140         * WebCore.vcproj/WebCore.vcproj:
1141         * WebCore.xcodeproj/project.pbxproj:
1142         * bindings/js/JSEventCustom.cpp:
1143         (WebCore::toJS):
1144         * bindings/v8/custom/V8EventCustom.cpp:
1145         (WebCore::toV8):
1146         * dom/DOMAllInOne.cpp:
1147         * dom/Event.cpp:
1148         (WebCore::Event::isStreamEvent):
1149         * dom/Event.h:
1150         * dom/StreamEvent.cpp: Added.
1151         (WebCore::StreamEvent::create):
1152         (WebCore::StreamEvent::StreamEvent):
1153         (WebCore::StreamEvent::~StreamEvent):
1154         (WebCore::StreamEvent::initStreamEvent):
1155         (WebCore::StreamEvent::stream):
1156         * dom/StreamEvent.h: Added.
1157         (WebCore::StreamEvent::isStreamEvent):
1158         * dom/StreamEvent.idl: Added.
1159
1160 2011-06-08  Tommy Widenflycht  <tommyw@google.com>
1161
1162         Reviewed by Tony Gentilcore.
1163
1164         Media Stream API: integrate the Track List objects into the existing code.
1165         https://bugs.webkit.org/show_bug.cgi?id=60205
1166
1167         Tests for the Media Stream API will be provided by the bug 56587.
1168
1169         * dom/ExclusiveTrackList.cpp:
1170         (WebCore::ExclusiveTrackList::select):
1171         (WebCore::ExclusiveTrackList::trackFailed):
1172         * dom/ExclusiveTrackList.h:
1173         * dom/GeneratedStream.cpp:
1174         (WebCore::GeneratedStream::create):
1175         (WebCore::GeneratedStream::GeneratedStream):
1176         (WebCore::GeneratedStream::streamEnded):
1177         (WebCore::GeneratedStream::audioTracks):
1178         (WebCore::GeneratedStream::videoTracks):
1179         (WebCore::GeneratedStream::stop):
1180         * dom/GeneratedStream.h:
1181         * dom/GeneratedStream.idl:
1182         * dom/MultipleTrackList.cpp:
1183         (WebCore::MultipleTrackList::trackFailed):
1184         (WebCore::MultipleTrackList::enable):
1185         (WebCore::MultipleTrackList::disable):
1186         * dom/MultipleTrackList.h:
1187         * dom/Stream.h:
1188         * dom/TrackList.cpp:
1189         (WebCore::TrackList::clear):
1190         (WebCore::TrackList::associateStream):
1191         (WebCore::TrackList::associatedStreamLabel):
1192         (WebCore::TrackList::trackFailed):
1193         (WebCore::TrackList::scriptExecutionContext):
1194         * dom/TrackList.h:
1195         * page/MediaStreamClient.h:
1196         * page/MediaStreamController.cpp:
1197         (WebCore::MediaStreamController::enableAudioTrack):
1198         (WebCore::MediaStreamController::disableAudioTrack):
1199         (WebCore::MediaStreamController::selectVideoTrack):
1200         (WebCore::MediaStreamController::streamGenerated):
1201         (WebCore::MediaStreamController::audioTrackFailed):
1202         (WebCore::MediaStreamController::videoTrackFailed):
1203         * page/MediaStreamController.h:
1204         * page/MediaStreamFrameController.cpp:
1205         (WebCore::MediaStreamFrameController::unregister):
1206         (WebCore::MediaStreamFrameController::enterDetachedState):
1207         (WebCore::MediaStreamFrameController::disconnectFrame):
1208         (WebCore::MediaStreamFrameController::enableAudioTrack):
1209         (WebCore::MediaStreamFrameController::disableAudioTrack):
1210         (WebCore::MediaStreamFrameController::selectVideoTrack):
1211         (WebCore::MediaStreamFrameController::streamGenerated):
1212         (WebCore::MediaStreamFrameController::audioTrackFailed):
1213         (WebCore::MediaStreamFrameController::videoTrackFailed):
1214         * page/MediaStreamFrameController.h:
1215         (WebCore::MediaStreamFrameController::ClientBase::isGenericClient):
1216         (WebCore::MediaStreamFrameController::GenericClient::GenericClient):
1217         (WebCore::MediaStreamFrameController::GenericClient::~GenericClient):
1218         (WebCore::MediaStreamFrameController::GenericClient::isGenericClient):
1219         (WebCore::MediaStreamFrameController::GenericClient::unregister):
1220
1221 2011-06-08  Pavel Podivilov  <podivilov@chromium.org>
1222
1223         Reviewed by Yury Semikhatsky.
1224
1225         Web Inspector: [REGRESSION] breakpoints are not persisted.
1226         https://bugs.webkit.org/show_bug.cgi?id=62273
1227
1228         * inspector/front-end/Settings.js:
1229
1230 2011-06-08  Alexander Pavlov  <apavlov@chromium.org>
1231
1232         Reviewed by Yury Semikhatsky.
1233
1234         Web Inspector: node selection is slow in the Elements panel.
1235         https://bugs.webkit.org/show_bug.cgi?id=60813
1236
1237         Schedule full style updates rather than request all node styles from the backend immediately.
1238
1239         * inspector/front-end/StylesSidebarPane.js:
1240         (WebInspector.StylesSidebarPane.prototype.update.reloadAllStyles):
1241         (WebInspector.StylesSidebarPane.prototype.update):
1242
1243 2011-06-08  Andreas Kling  <andreas.kling@nokia.com>
1244
1245         Reviewed by Laszlo Gombos.
1246
1247         [Symbian] Float{32,64}Array and Int16Array fail to build.
1248         https://bugs.webkit.org/show_bug.cgi?id=62219
1249
1250         For some reason, RVCT 2.x is moaning about "class member designated by
1251         a using-declaration must be visible in a direct base class".
1252         Apply same fix as r69122 and r76592.
1253
1254         * html/canvas/Float32Array.h:
1255         (WebCore::Float32Array::set):
1256         * html/canvas/Float64Array.h:
1257         (WebCore::Float64Array::set):
1258         * html/canvas/Int16Array.h:
1259         (WebCore::Int16Array::set):
1260
1261 2011-06-08  Syed Idris Shah  <syed.idris-shah@nokia.com>
1262
1263         Reviewed by Andreas Kling.
1264
1265         [Qt] GL_POINT_SPRITE and GL_VERTEX_PROGRAM_POINT_SIZE should be enabled for desktop WebGL
1266         https://bugs.webkit.org/show_bug.cgi?id=61945
1267
1268         For OpenGL ES we do not need these features. 
1269         These features are available via shaders in OpenGL ES. But for desktop WebGL using QtWebKit they should be enabled.
1270
1271         LayoutTests/fast/canvas/webgl/point-size.html
1272
1273         * platform/graphics/qt/GraphicsContext3DQt.cpp:
1274         (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
1275
1276 2011-06-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1277
1278         Unreviewed. Fix style error.
1279
1280         * platform/efl/RenderThemeEfl.cpp:
1281         * platform/efl/RenderThemeEfl.h:
1282
1283 2011-06-08  Hironori Bono  <hbono@chromium.org>
1284
1285         Reviewed by Brent Fulgham.
1286
1287         Add SpellCheck API
1288         https://bugs.webkit.org/show_bug.cgi?id=59693
1289
1290         This change adds two SpellCheck API functions (addSpellcheckRange and
1291         removeSpellcheckRange) and one attribute (spellcheckRange) discussed in
1292         the public-webapps ML. This change is currently available only on Chromium.
1293
1294         Tests: editing/spelling/spellcheck-api-pixel.html
1295                editing/spelling/spellcheck-api.html
1296
1297         * WebCore.gypi:
1298         * bindings/generic/RuntimeEnabledFeatures.cpp:
1299         * bindings/generic/RuntimeEnabledFeatures.h:
1300         (WebCore::RuntimeEnabledFeatures::spellCheckAPIEnabled):
1301         (WebCore::RuntimeEnabledFeatures::setSpellCheckAPIEnabled):
1302         * dom/DocumentMarker.h:
1303         (WebCore::DocumentMarker::length):
1304         * dom/DocumentMarkerController.cpp:
1305         (WebCore::DocumentMarkerController::userSpellingMarkersForNode):
1306         (WebCore::DocumentMarkerController::addUserSpellingMarker):
1307         (WebCore::DocumentMarkerController::removeUserSpellingMarker):
1308         (WebCore::DocumentMarkerController::userSpellingNode):
1309         * dom/DocumentMarkerController.h:
1310         * html/HTMLDivElement.cpp:
1311         (WebCore::HTMLDivElement::spellcheckRanges):
1312         (WebCore::HTMLDivElement::addSpellcheckRange):
1313         (WebCore::HTMLDivElement::removeSpellcheckRange):
1314         * html/HTMLDivElement.h:
1315         * html/HTMLDivElement.idl:
1316         * html/HTMLInputElement.cpp:
1317         (WebCore::HTMLInputElement::spellcheckRanges):
1318         (WebCore::HTMLInputElement::addSpellcheckRange):
1319         (WebCore::HTMLInputElement::removeSpellcheckRange):
1320         * html/HTMLInputElement.h:
1321         * html/HTMLInputElement.idl:
1322         * html/HTMLTextAreaElement.cpp:
1323         (WebCore::HTMLTextAreaElement::spellcheckRanges):
1324         (WebCore::HTMLTextAreaElement::addSpellcheckRange):
1325         (WebCore::HTMLTextAreaElement::removeSpellcheckRange):
1326         * html/HTMLTextAreaElement.h:
1327         * html/HTMLTextAreaElement.idl:
1328         * html/SpellcheckRange.cpp: Added.
1329         (WebCore::SpellcheckRange::SpellcheckRange):
1330         (WebCore::SpellcheckRange::~SpellcheckRange):
1331         * html/SpellcheckRange.h: Added.
1332         (WebCore::SpellcheckRange::create):
1333         (WebCore::SpellcheckRange::start):
1334         (WebCore::SpellcheckRange::length):
1335         (WebCore::SpellcheckRange::suggestions):
1336         (WebCore::SpellcheckRange::options):
1337         * html/SpellcheckRange.idl: Added.
1338         * html/SpellcheckRangeList.cpp: Added.
1339         (WebCore::SpellcheckRangeList::SpellcheckRangeList):
1340         (WebCore::SpellcheckRangeList::~SpellcheckRangeList):
1341         (WebCore::SpellcheckRangeList::item):
1342         * html/SpellcheckRangeList.h: Added.
1343         (WebCore::SpellcheckRangeList::create):
1344         (WebCore::SpellcheckRangeList::isEmpty):
1345         (WebCore::SpellcheckRangeList::clear):
1346         (WebCore::SpellcheckRangeList::append):
1347         (WebCore::SpellcheckRangeList::remove):
1348         (WebCore::SpellcheckRangeList::length):
1349         * html/SpellcheckRangeList.idl: Added.
1350         * rendering/InlineTextBox.cpp:
1351         (WebCore::textCheckingLineStyleForMarkerType):
1352         (WebCore::InlineTextBox::paintDocumentMarkers):
1353
1354 2011-06-07  Andrey Kosyakov  <caseq@chromium.org>
1355
1356         Reviewed by Pavel Feldman.
1357
1358         Web Inspector: remove shadow dom inspection from Elements panel by default.
1359         https://bugs.webkit.org/show_bug.cgi?id=62188
1360
1361         This reverts r85751
1362
1363         * dom/Element.cpp:
1364         (WebCore::Element::ensureShadowRoot):
1365         (WebCore::Element::removeShadowRoot):
1366         * inspector/Inspector.json:
1367         * inspector/InspectorDOMAgent.cpp:
1368         (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
1369         (WebCore::InspectorDOMAgent::buildObjectForNode):
1370         (WebCore::InspectorDOMAgent::didInsertDOMNode):
1371         (WebCore::InspectorDOMAgent::didRemoveDOMNode):
1372         * inspector/InspectorDOMAgent.h:
1373         * inspector/front-end/DOMAgent.js:
1374         (WebInspector.DOMNode):
1375         (WebInspector.DOMNode.prototype._renumber):
1376         (WebInspector.DOMAgent.prototype._bindNodes):
1377         (WebInspector.DOMAgent.prototype.querySelectorAll):
1378         (WebInspector.DOMDispatcher.prototype.searchResults):
1379         * inspector/front-end/ElementsPanel.js:
1380         (WebInspector.ElementsPanel):
1381         (WebInspector.ElementsPanel.prototype._attributesUpdated):
1382         (WebInspector.ElementsPanel.prototype._characterDataModified):
1383         (WebInspector.ElementsPanel.prototype._nodeInserted):
1384         (WebInspector.ElementsPanel.prototype._nodeRemoved):
1385         (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
1386         (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
1387         * inspector/front-end/ElementsTreeOutline.js:
1388         (WebInspector.ElementsTreeElement):
1389         (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
1390         (WebInspector.ElementsTreeElement.prototype._updateChildren):
1391         ():
1392         * inspector/front-end/inspector.css:
1393         * inspector/front-end/utilities.js:
1394         (Element.prototype.query):
1395
1396 2011-06-08  Mark Rowe  <mrowe@apple.com>
1397
1398         Fix the build.
1399
1400         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
1401         (WebCore::MediaPlayerPrivateAVFoundation::timeChanged):
1402         (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
1403
1404 2011-06-07  Keishi Hattori  <keishi@webkit.org>
1405
1406         Reviewed by Kent Tamura.
1407
1408         Rename HTMLInputElement::m_value to m_valueIfDirty
1409         https://bugs.webkit.org/show_bug.cgi?id=61990
1410
1411         No new tests because no behavior change.
1412
1413         * html/HTMLInputElement.cpp: Replaced m_value with m_valueIfDirty.
1414         (WebCore::HTMLInputElement::tooLong):
1415         (WebCore::HTMLInputElement::updateType):
1416         (WebCore::HTMLInputElement::parseMappedAttribute):
1417         (WebCore::HTMLInputElement::copyNonAttributeProperties):
1418         (WebCore::HTMLInputElement::value):
1419         (WebCore::HTMLInputElement::setValue):
1420         (WebCore::HTMLInputElement::setValueFromRenderer):
1421         (WebCore::HTMLInputElement::updateValueIfNeeded):
1422         * html/HTMLInputElement.h: Renamed m_value to m_valueIfDirty.
1423         (WebCore::HTMLInputElement::hasDirtyValue): Added. Returns the dirty value flag.
1424
1425 2011-06-07  Ian Henderson  <ianh@apple.com>
1426
1427         Reviewed by Dan Bernstein.
1428
1429         (CG) Sub-image drawing clips unnecessarily
1430         https://bugs.webkit.org/show_bug.cgi?id=62258
1431
1432         If destRect completely encompasses the adjustedDestRect into which we
1433         draw, clipping to destRect will do nothing.  Skip the call to
1434         CGContextClipToRect in this case.
1435
1436         * platform/graphics/cg/ImageCG.cpp:
1437         (WebCore::BitmapImage::draw):
1438
1439 2011-06-07  Emil A Eklund  <eae@chromium.org>
1440
1441         Reviewed by Eric Seidel.
1442
1443         Convert nodeAtPoint to IntPoint
1444         https://bugs.webkit.org/show_bug.cgi?id=62145
1445
1446         Convert nodeAtPoint to take an IntPoint instead of a pair of ints for the
1447         accumulated offset.
1448
1449         Covered by existing tests.
1450
1451         * platform/graphics/FloatPoint.h:
1452         (WebCore::FloatPoint::moveBy):
1453         Add moveBy(IntPoint) method
1454         
1455         * rendering/EllipsisBox.cpp:
1456         (WebCore::EllipsisBox::nodeAtPoint):
1457         * rendering/EllipsisBox.h:
1458         * rendering/InlineBox.cpp:
1459         (WebCore::InlineBox::nodeAtPoint):
1460         * rendering/InlineBox.h:
1461         * rendering/InlineFlowBox.cpp:
1462         (WebCore::InlineFlowBox::nodeAtPoint):
1463         * rendering/InlineFlowBox.h:
1464         * rendering/InlineTextBox.cpp:
1465         (WebCore::InlineTextBox::nodeAtPoint):
1466         * rendering/InlineTextBox.h:
1467         * rendering/RenderBlock.cpp:
1468         (WebCore::RenderBlock::nodeAtPoint):
1469         (WebCore::RenderBlock::hitTestContents):
1470         * rendering/RenderBlock.h:
1471         * rendering/RenderBox.cpp:
1472         (WebCore::RenderBox::nodeAtPoint):
1473         * rendering/RenderBox.h:
1474         * rendering/RenderFrameSet.cpp:
1475         (WebCore::RenderFrameSet::nodeAtPoint):
1476         * rendering/RenderFrameSet.h:
1477         * rendering/RenderImage.cpp:
1478         (WebCore::RenderImage::nodeAtPoint):
1479         * rendering/RenderImage.h:
1480         * rendering/RenderInline.cpp:
1481         (WebCore::RenderInline::nodeAtPoint):
1482         * rendering/RenderInline.h:
1483         * rendering/RenderLineBoxList.cpp:
1484         (WebCore::RenderLineBoxList::hitTest):
1485         * rendering/RenderListBox.cpp:
1486         (WebCore::RenderListBox::nodeAtPoint):
1487         * rendering/RenderListBox.h:
1488         * rendering/RenderObject.cpp:
1489         (WebCore::RenderObject::hitTest):
1490         * rendering/RenderObject.h:
1491         * rendering/RenderTable.cpp:
1492         (WebCore::RenderTable::nodeAtPoint):
1493         * rendering/RenderTable.h:
1494         * rendering/RenderTableRow.cpp:
1495         (WebCore::RenderTableRow::nodeAtPoint):
1496         * rendering/RenderTableRow.h:
1497         * rendering/RenderTableSection.cpp:
1498         (WebCore::RenderTableSection::nodeAtPoint):
1499         * rendering/RenderTableSection.h:
1500         * rendering/RenderText.h:
1501         (WebCore::RenderText::nodeAtPoint):
1502         * rendering/RenderTextControlMultiLine.cpp:
1503         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
1504         * rendering/RenderTextControlMultiLine.h:
1505         * rendering/RenderTextControlSingleLine.cpp:
1506         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
1507         * rendering/RenderTextControlSingleLine.h:
1508         * rendering/RenderWidget.cpp:
1509         (WebCore::RenderWidget::nodeAtPoint):
1510         * rendering/RenderWidget.h:
1511         * rendering/RootInlineBox.cpp:
1512         (WebCore::RootInlineBox::nodeAtPoint):
1513         * rendering/RootInlineBox.h:
1514         * rendering/svg/RenderSVGForeignObject.cpp:
1515         (WebCore::RenderSVGForeignObject::nodeAtFloatPoint):
1516         (WebCore::RenderSVGForeignObject::nodeAtPoint):
1517         * rendering/svg/RenderSVGForeignObject.h:
1518         * rendering/svg/RenderSVGModelObject.cpp:
1519         (WebCore::RenderSVGModelObject::nodeAtPoint):
1520         * rendering/svg/RenderSVGModelObject.h:
1521         * rendering/svg/RenderSVGRoot.cpp:
1522         (WebCore::RenderSVGRoot::nodeAtPoint):
1523         * rendering/svg/RenderSVGRoot.h:
1524         * rendering/svg/RenderSVGText.cpp:
1525         (WebCore::RenderSVGText::nodeAtFloatPoint):
1526         (WebCore::RenderSVGText::nodeAtPoint):
1527         * rendering/svg/RenderSVGText.h:
1528
1529 2011-06-07  Yi Shen  <yi.4.shen@nokia.com>
1530
1531         Reviewed by Simon Hausmann.
1532
1533         [Qt] Fix the error code for media resource failures when using QtMobility
1534         https://bugs.webkit.org/show_bug.cgi?id=55901
1535
1536         To indicate the media resource failures, set the network state to
1537         MediaPlayer::FormatError when receives QMediaPlayer::InvalidMedia or
1538         QMediaPlayer::ResourceError.
1539
1540         * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
1541         (WebCore::MediaPlayerPrivateQt::updateStates):
1542
1543 2011-06-07  Emil A Eklund  <eae@chromium.org>
1544
1545         Reviewed by Eric Seidel.
1546
1547         Change RenderBlock::hitTestFloats to IntPoint
1548         https://bugs.webkit.org/show_bug.cgi?id=62176
1549
1550         Covered by existing tests.
1551
1552         * rendering/RenderBlock.cpp:
1553         (WebCore::RenderBlock::nodeAtPoint):
1554         (WebCore::RenderBlock::hitTestFloats):
1555         (WebCore::RenderBlock::hitTestColumns):
1556         * rendering/RenderBlock.h:
1557
1558 2011-06-07  Tim Horton  <timothy_horton@apple.com>
1559
1560         Reviewed by Alexey Proskuryakov.
1561
1562         Use correct CFURLStorageSessionRef definition on Snow Leopard
1563         https://bugs.webkit.org/show_bug.cgi?id=62223
1564
1565         * platform/mac/WebCoreSystemInterface.h:
1566         * platform/network/ResourceHandle.h:
1567         * platform/network/cf/ResourceRequest.h:
1568
1569 2011-06-07  Emil A Eklund  <eae@chromium.org>
1570
1571         Reviewed by Eric Seidel.
1572
1573         Change RenderBlock::hitTestColumns to IntPoint
1574         https://bugs.webkit.org/show_bug.cgi?id=62172
1575
1576         Covered by existing tests.
1577
1578         * rendering/RenderBlock.cpp:
1579         (WebCore::RenderBlock::nodeAtPoint):
1580         (WebCore::RenderBlock::hitTestColumns):
1581         * rendering/RenderBlock.h:
1582
1583 2011-06-07  Simon Fraser  <simon.fraser@apple.com>
1584
1585         Reviewed by Darin Adler.
1586
1587         Opacity transition doesn't work while content property is set.
1588         https://bugs.webkit.org/show_bug.cgi?id=59301
1589         
1590         StyleRareNonInheritedData's copy constructor omitted to copy
1591         the m_content data, which caused us to detach and re-attach the renderer
1592         at the start of the transition, thereby killing the transition.
1593         
1594         Fix by making StyleRareNonInheritedData's copy ctor do the right thing.
1595
1596         Test: transitions/transition-on-element-with-content.html
1597
1598         * rendering/style/ContentData.h:
1599         * rendering/style/ContentData.cpp:
1600         (WebCore::ContentData::clone): New method to do a deep clone. (Can't use a copy
1601         ctor because of the subclasses.)
1602         * rendering/style/CounterDirectives.h: Pack the data members to save space.
1603         Add a clone() function for the HashMap.
1604         * rendering/style/CounterDirectives.cpp:
1605         (WebCore::clone): Make a new HashMap and copy the contents over.
1606         * rendering/style/StyleRareNonInheritedData.cpp:
1607         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Copy
1608         the content and counter directives over.
1609         (WebCore::StyleRareNonInheritedData::operator==): Rather than just comparing
1610         for pointer equality, do a correct check for m_counterDirectives equality.
1611         (WebCore::StyleRareNonInheritedData::counterDataEquivalent):
1612         * rendering/style/StyleRareNonInheritedData.h:
1613
1614 2011-06-07  Robert Kroeger  <rjkroege@chromium.org>
1615
1616         Reviewed by Adam Barth.
1617
1618         [chromium] Add a basic gesture recognizer to the Chromium platform
1619         https://bugs.webkit.org/show_bug.cgi?id=54417
1620
1621         Adds a basic gesture recognizer to the Chromium platform. Adds an entry
1622         point to the GestureRecognizer to reset any internal state on a page reset.
1623         Resetting the gesture recognizer on page load is necesary for reliable
1624         layout test execution and improves gesture recognizer operational
1625         robustness.
1626
1627         Added an additional constructor to permit building a synthetic
1628         PlatformWheelEvent.
1629
1630         Small modifications to the PlatformGestureRecognizer as required to
1631         implement the simple Chromium platform gesture recognizer.
1632
1633         Tests: fast/events/touch/touch-gesture-click.html
1634
1635         * WebCore.gypi:
1636         * page/EventHandler.cpp:
1637         (WebCore::EventHandler::resetGestureRecognizer):
1638         * page/EventHandler.h:
1639         * page/FrameView.cpp:
1640         (WebCore::FrameView::reset):
1641         * platform/PlatformGestureRecognizer.h:
1642         * platform/PlatformWheelEvent.h:
1643         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
1644         * platform/chromium/GestureRecognizerChromium.cpp: Added.
1645         (WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
1646         (WebCore::InnerGestureRecognizer::reset):
1647         (WebCore::InnerGestureRecognizer::~InnerGestureRecognizer):
1648         (WebCore::InnerGestureRecognizer::addEdgeFunction):
1649         (WebCore::InnerGestureRecognizer::isInClickTimeWindow):
1650         (WebCore::InnerGestureRecognizer::isInsideManhattanSquare):
1651         (WebCore::InnerGestureRecognizer::dispatchSyntheticClick):
1652         (WebCore::InnerGestureRecognizer::processTouchEventForGesture):
1653         (WebCore::InnerGestureRecognizer::scrollViaTouchMotion):
1654         (WebCore::InnerGestureRecognizer::updateValues):
1655         (WebCore::InnerGestureRecognizer::signature):
1656         (WebCore::touchDown):
1657         (WebCore::noGesture):
1658         (WebCore::click):
1659         (WebCore::isClickOrScroll):
1660         (WebCore::inScroll):
1661         (WebCore::PlatformGestureRecognizer::create):
1662         (WebCore::PlatformGestureRecognizer::PlatformGestureRecognizer):
1663         (WebCore::PlatformGestureRecognizer::~PlatformGestureRecognizer):
1664         (WebCore::GestureRecognizerChromium::GestureRecognizerChromium):
1665         (WebCore::GestureRecognizerChromium::~GestureRecognizerChromium):
1666         * platform/chromium/GestureRecognizerChromium.h: Added.
1667         (WebCore::InnerGestureRecognizer::setState):
1668         (WebCore::InnerGestureRecognizer::state):
1669         (WebCore::GestureRecognizerChromium::reset):
1670         (WebCore::GestureRecognizerChromium::processTouchEventForGesture):
1671
1672 2011-06-07  No'am Rosenthal  <noam.rosenthal@nokia.com>
1673
1674         Reviewed by Andreas Kling.
1675
1676         [Texmap][Qt] Enable TextureMapper by default
1677         https://bugs.webkit.org/show_bug.cgi?id=61740
1678
1679         Enable TextureMapper on Windows+Symbian, disabling the direct OpenGL path. This would mean that
1680         for now QtWebKit on Windows/Symbian would use the Qt backend for TextureMapper.
1681
1682         No new functionality so no new tests.
1683
1684         * WebCore.pri:
1685         * WebCore.pro:
1686         * platform/graphics/qt/GraphicsContext3DQt.cpp:
1687         * platform/graphics/qt/TextureMapperQt.cpp:
1688         (WebCore::TextureMapper::create):
1689
1690 2011-06-07  Emil A Eklund  <eae@chromium.org>
1691
1692         Reviewed by Eric Seidel.
1693
1694         Convert RenderBox::absoluteRects to IntPoint
1695         https://bugs.webkit.org/show_bug.cgi?id=62130
1696
1697         Covered by existing tests.
1698
1699         * dom/Node.cpp:
1700         (WebCore::Node::hasNonEmptyBoundingBox):
1701         * rendering/InlineBox.h:
1702         (WebCore::InlineBox::size):
1703         * rendering/RenderBlock.cpp:
1704         (WebCore::RenderBlock::absoluteRects):
1705         * rendering/RenderBlock.h:
1706         * rendering/RenderBox.cpp:
1707         (WebCore::RenderBox::absoluteRects):
1708         * rendering/RenderBox.h:
1709         * rendering/RenderInline.cpp:
1710         (WebCore::RenderInline::absoluteRects):
1711         * rendering/RenderInline.h:
1712         * rendering/RenderObject.cpp:
1713         (WebCore::RenderObject::absoluteBoundingBoxRect):
1714         * rendering/RenderObject.h:
1715         (WebCore::RenderObject::absoluteRects):
1716         * rendering/RenderText.cpp:
1717         (WebCore::RenderText::absoluteRects):
1718         * rendering/RenderText.h:
1719         * rendering/RenderView.cpp:
1720         (WebCore::RenderView::absoluteRects):
1721         * rendering/RenderView.h:
1722         * rendering/svg/RenderSVGBlock.cpp:
1723         (WebCore::RenderSVGBlock::absoluteRects):
1724         * rendering/svg/RenderSVGBlock.h:
1725         * rendering/svg/RenderSVGModelObject.cpp:
1726         (WebCore::RenderSVGModelObject::absoluteRects):
1727         * rendering/svg/RenderSVGModelObject.h:
1728
1729 2011-06-07  Kent Tamura  <tkent@chromium.org>
1730
1731         Reviewed by Andreas Kling.
1732
1733         [Qt] RenderThemeQt::adjustSliderThumbSize() should not refer to the parent style.
1734         https://bugs.webkit.org/show_bug.cgi?id=62207
1735
1736         * css/mediaControlsQt.css: Add comments.
1737         (audio::-webkit-media-controls-timeline):
1738         (video::-webkit-media-controls-timeline):
1739         (audio::-webkit-media-controls-volume-slider):
1740         (video::-webkit-media-controls-volume-slider):
1741         * platform/qt/RenderThemeQt.cpp: Use fixed values to avoid referring to o->parent().
1742         (WebCore::RenderThemeQt::adjustSliderThumbSize):
1743
1744 2011-06-07  Sailesh Agrawal  <sail@chromium.org>
1745
1746         Reviewed by Mihai Parparita.
1747
1748         Chromium Mac: Fork ScrollAnimatorMac to ScrollAnimatorChromiumMac for overlay scrollbar support
1749         https://bugs.webkit.org/show_bug.cgi?id=59753
1750
1751         No new tests. Just forking ScrollAnimatorMac to ScrollAnimatorChromiumMac.
1752
1753         * WebCore.gyp/WebCore.gyp: Added IntPointMac.mm. This is used by some functions in ScrollAnimatorChromiumMac. Also added filters for conflicting class names in ScrollAnimatorChromiumMac.
1754         * WebCore.gypi: Added ScrollAnimatorChromiumMac.h/mm.
1755         * platform/ScrollAnimator.cpp: Extended the #ifdef around ScrollAnimator::create() so that the chromium version will be created.
1756         * platform/chromium/ScrollAnimatorChromiumMac.h: Added.
1757         (WebCore::ScrollAnimatorChromiumMac::setIsDrawingIntoLayer):
1758         (WebCore::ScrollAnimatorChromiumMac::isDrawingIntoLayer):
1759         (WebCore::ScrollAnimatorChromiumMac::haveScrolledSincePageLoad):
1760         * platform/chromium/ScrollAnimatorChromiumMac.mm: Added. Forked from ScrollAnimatorMac and replaced all instances of ScrollAnimatorMac with ScrollAnimatorChromiumMac and ScrollbarThemeMac with ScrollbarThemeChromiumMac. Removed the ENABLE(SMOOTH_SCROLLING) around the file. Stubbed out ScrollAnimatorChromiumMac::scroll() if smooth scrolling is disabled.
1761         (abs):
1762         (-[ScrollAnimationHelperDelegate initWithScrollAnimator:WebCore::]):
1763         (-[ScrollAnimationHelperDelegate scrollAnimatorDestroyed]):
1764         (-[ScrollAnimationHelperDelegate bounds]):
1765         (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]):
1766         (-[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]):
1767         (-[ScrollAnimationHelperDelegate convertSizeToBase:]):
1768         (-[ScrollAnimationHelperDelegate convertSizeFromBase:]):
1769         (-[ScrollAnimationHelperDelegate convertSizeToBacking:]):
1770         (-[ScrollAnimationHelperDelegate convertSizeFromBacking:]):
1771         (-[ScrollAnimationHelperDelegate superview]):
1772         (-[ScrollAnimationHelperDelegate documentView]):
1773         (-[ScrollAnimationHelperDelegate window]):
1774         (-[ScrollAnimationHelperDelegate _recursiveRecomputeToolTips]):
1775         (-[ScrollbarPainterControllerDelegate initWithScrollAnimator:WebCore::]):
1776         (-[ScrollbarPainterControllerDelegate scrollAnimatorDestroyed]):
1777         (-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
1778         (-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
1779         (-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
1780         (-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
1781         (-[ScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
1782         (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
1783         (-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):
1784         (-[ScrollbarPartAnimation setCurrentProgress:]):
1785         (-[ScrollbarPartAnimation scrollAnimatorDestroyed]):
1786         (-[ScrollbarPainterDelegate initWithScrollAnimator:WebCore::]):
1787         (-[ScrollbarPainterDelegate cancelAnimations]):
1788         (-[ScrollbarPainterDelegate convertRectToBacking:]):
1789         (-[ScrollbarPainterDelegate convertRectFromBacking:]):
1790         (-[ScrollbarPainterDelegate layer]):
1791         (-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
1792         (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
1793         (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
1794         (-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):
1795         (-[ScrollbarPainterDelegate scrollAnimatorDestroyed]):
1796         (WebCore::ScrollAnimator::create):
1797         (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac):
1798         (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac):
1799         (WebCore::ScrollAnimatorChromiumMac::scroll):
1800         (WebCore::ScrollAnimatorChromiumMac::scrollToOffsetWithoutAnimation):
1801         (WebCore::ScrollAnimatorChromiumMac::adjustScrollXPositionIfNecessary):
1802         (WebCore::ScrollAnimatorChromiumMac::adjustScrollYPositionIfNecessary):
1803         (WebCore::ScrollAnimatorChromiumMac::adjustScrollPositionIfNecessary):
1804         (WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint):
1805         (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX):
1806         (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY):
1807         (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged):
1808         (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint):
1809         (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea):
1810         (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea):
1811         (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea):
1812         (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize):
1813         (WebCore::ScrollAnimatorChromiumMac::contentsResized):
1814         (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize):
1815         (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow):
1816         (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide):
1817         (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture):
1818         (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture):
1819         (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar):
1820         (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar):
1821         (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar):
1822         (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar):
1823         (WebCore::ScrollAnimatorChromiumMac::cancelAnimations):
1824         (WebCore::elasticDeltaForTimeDelta):
1825         (WebCore::elasticDeltaForReboundDelta):
1826         (WebCore::reboundDeltaForElasticDelta):
1827         (WebCore::scrollWheelMultiplier):
1828         (WebCore::ScrollAnimatorChromiumMac::handleWheelEvent):
1829         (WebCore::ScrollAnimatorChromiumMac::handleGestureEvent):
1830         (WebCore::ScrollAnimatorChromiumMac::pinnedInDirection):
1831         (WebCore::ScrollAnimatorChromiumMac::allowsVerticalStretching):
1832         (WebCore::ScrollAnimatorChromiumMac::allowsHorizontalStretching):
1833         (WebCore::ScrollAnimatorChromiumMac::smoothScrollWithEvent):
1834         (WebCore::ScrollAnimatorChromiumMac::beginScrollGesture):
1835         (WebCore::ScrollAnimatorChromiumMac::endScrollGesture):
1836         (WebCore::ScrollAnimatorChromiumMac::snapRubberBand):
1837         (WebCore::roundTowardZero):
1838         (WebCore::roundToDevicePixelTowardZero):
1839         (WebCore::ScrollAnimatorChromiumMac::snapRubberBandTimerFired):
1840         (WebCore::ScrollAnimatorChromiumMac::startScrollbarPaintTimer):
1841         (WebCore::ScrollAnimatorChromiumMac::scrollbarPaintTimerIsActive):
1842         (WebCore::ScrollAnimatorChromiumMac::stopScrollbarPaintTimer):
1843         (WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):
1844         (WebCore::ScrollAnimatorChromiumMac::setVisibleScrollerThumbRect):
1845         * platform/graphics/IntPoint.h: Exposed NSPoint conversion routines to chromium mac.
1846
1847 2011-06-07  Sam Weinig  <sam@webkit.org>
1848
1849         Reviewed by Anders Carlsson.
1850
1851         Remove repeated IPC traffic from SetRenderTreeSize message
1852         https://bugs.webkit.org/show_bug.cgi?id=62244
1853
1854         * WebCore.xcodeproj/project.pbxproj:
1855         Make RenderArena.h private so it can be called from WebKit2.
1856
1857         * loader/FrameLoaderClient.h:
1858         (WebCore::FrameLoaderClient::dispatchDidLayout):
1859         Added.
1860
1861         * page/ChromeClient.h:
1862         Remove setRenderTreeSize.
1863
1864         * page/FrameView.cpp:
1865         (WebCore::FrameView::performPostLayoutTasks):
1866         Call dispatchDidLayout for all frames instead of calling setRenderTreeSize
1867         for the main frame.
1868
1869 2011-06-07  Emil A Eklund  <eae@chromium.org>
1870
1871         Reviewed by Eric Seidel.
1872
1873         Change RenderBlock::hitTestContents to IntPoint
1874         https://bugs.webkit.org/show_bug.cgi?id=62170
1875
1876         Covered by existing tests.
1877
1878         * rendering/RenderBlock.cpp:
1879         (WebCore::RenderBlock::nodeAtPoint):
1880         (WebCore::RenderBlock::hitTestColumns):
1881         (WebCore::RenderBlock::hitTestContents):
1882         * rendering/RenderBlock.h:
1883
1884 2011-06-07  Jer Noble  <jer.noble@apple.com>
1885
1886         Reviewed by Eric Carlson.
1887
1888         Video with poster attribute will not display new frames when scrubbing.
1889         https://bugs.webkit.org/show_bug.cgi?id=62036
1890
1891         Remove our "detection" about the end of a scrub now that there is an explicit seek completion
1892         handler available in AVFoundation.  Move what we used to do upon detection in timeChanged()
1893         into seekCompleted().
1894
1895         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
1896         (WebCore::MediaPlayerPrivateAVFoundation::timeChanged): 
1897         (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
1898
1899 2011-06-07  James Simonsen  <simonjam@chromium.org>
1900
1901         Unreviewed, build fix, missing files from r88274.
1902
1903         * bindings/v8/ChildThreadDOMData.cpp: Added.
1904         (WebCore::ChildThreadDOMData::ChildThreadDOMData):
1905         (WebCore::ChildThreadDOMData::getStore):
1906         * bindings/v8/ChildThreadDOMData.h: Added.
1907         * bindings/v8/MainThreadDOMData.cpp: Added.
1908         (WebCore::MainThreadDOMData::MainThreadDOMData):
1909         (WebCore::MainThreadDOMData::getCurrent):
1910         (WebCore::MainThreadDOMData::getMainThreadStore):
1911         (WebCore::MainThreadDOMData::getCurrentMainThreadStore):
1912         * bindings/v8/MainThreadDOMData.h: Added.
1913         (WebCore::MainThreadDOMData::getStore):
1914
1915 2011-06-07  Abhishek Arya  <inferno@chromium.org>
1916
1917         Reviewed by Dan Bernstein.
1918
1919         Replicate WidthIterator.cpp fix from r88139.
1920         https://bugs.webkit.org/show_bug.cgi?id=62238
1921
1922         No new tests. Covered by existing layout tests on XP debug bots.
1923
1924         * platform/graphics/win/UniscribeController.cpp:
1925         (WebCore::UniscribeController::advance):
1926
1927 2011-06-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1928
1929         Unreviewed, rolling out r88221, r88224, and r88231.
1930         http://trac.webkit.org/changeset/88221
1931         http://trac.webkit.org/changeset/88224
1932         http://trac.webkit.org/changeset/88231
1933         https://bugs.webkit.org/show_bug.cgi?id=62233
1934
1935         assert failure on chromium linux debug (Requested by simonjam
1936         on #webkit).
1937
1938         * WebCore.gypi:
1939         * WebCore.pro:
1940         * bindings/v8/ChildThreadDOMData.cpp: Copied from Source/WebCore/bindings/v8/DOMData.cpp.
1941         (WebCore::ChildThreadDOMData::ChildThreadDOMData):
1942         (WebCore::ChildThreadDOMData::getStore):
1943         * bindings/v8/ChildThreadDOMData.h: Copied from Source/WebCore/bindings/v8/DOMData.cpp.
1944         * bindings/v8/DOMData.cpp:
1945         (WebCore::DOMData::DOMData):
1946         (WebCore::DOMData::getCurrent):
1947         * bindings/v8/DOMData.h:
1948         (WebCore::DOMData::owningThread):
1949         (WebCore::DOMData::handleWeakObject):
1950         * bindings/v8/DOMDataStore.cpp:
1951         (WebCore::DOMDataStore::DOMDataStore):
1952         (WebCore::DOMDataStore::~DOMDataStore):
1953         (WebCore::DOMDataStore::allStoresMutex):
1954         (WebCore::DOMDataStore::weakNodeCallback):
1955         * bindings/v8/DOMDataStore.h:
1956         * bindings/v8/MainThreadDOMData.cpp: Copied from Source/WebCore/bindings/v8/DOMData.cpp.
1957         (WebCore::MainThreadDOMData::MainThreadDOMData):
1958         (WebCore::MainThreadDOMData::getCurrent):
1959         (WebCore::MainThreadDOMData::getMainThreadStore):
1960         (WebCore::MainThreadDOMData::getCurrentMainThreadStore):
1961         * bindings/v8/MainThreadDOMData.h: Copied from Source/WebCore/bindings/v8/DOMData.cpp.
1962         (WebCore::MainThreadDOMData::getStore):
1963         * bindings/v8/V8DOMMap.cpp:
1964         (WebCore::getDOMDataStore):
1965         (WebCore::removeAllDOMObjectsInCurrentThread):
1966         (WebCore::visitDOMNodesInCurrentThread):
1967         (WebCore::visitDOMObjectsInCurrentThread):
1968         (WebCore::visitActiveDOMObjectsInCurrentThread):
1969         (WebCore::visitDOMSVGElementInstancesInCurrentThread):
1970         * bindings/v8/V8DOMMap.h:
1971         * bindings/v8/V8GCController.cpp:
1972         (WebCore::V8GCController::gcPrologue):
1973         (WebCore::V8GCController::gcEpilogue):
1974         * bindings/v8/WorkerScriptController.cpp:
1975         (WebCore::WorkerScriptController::~WorkerScriptController):
1976
1977 2011-06-07  Simon Fraser  <simon.fraser@apple.com>
1978
1979         Reviewed by Dave Hyatt.
1980
1981         Clean up ContentData
1982         https://bugs.webkit.org/show_bug.cgi?id=62185
1983
1984         ContentData did manual ref()/deref() and had a lot of awkward
1985         code from using a union to store data.
1986         
1987         Clean this up by adding ContentData subclasses for different
1988         content types, which are then able to use RefPtr and OwnPtr
1989         as appropriate.
1990
1991         * css/CSSComputedStyleDeclaration.cpp:
1992         (WebCore::contentToCSSValue): Cast to different ContentData types as
1993         appropriate.
1994
1995         * css/CSSStyleSelector.cpp: 
1996         (WebCore::CSSStyleSelector::loadPendingImages): Cast to ImageContentData, and do some
1997         const gyrations.
1998
1999         * html/HTMLBRElement.cpp:
2000         (WebCore::HTMLBRElement::createRenderer): Use hasContent().
2001         * html/HTMLFrameSetElement.cpp:
2002         (WebCore::HTMLFrameSetElement::createRenderer): Ditto
2003         * html/HTMLImageElement.cpp:
2004         (WebCore::HTMLImageElement::createRenderer): Ditto
2005         * rendering/RenderObject.cpp:
2006         (WebCore::RenderObject::createObject): Cast to ImageContentData.
2007         * rendering/RenderObjectChildList.cpp:
2008         (WebCore::RenderObjectChildList::updateBeforeAfterContent): Cast to different ContentData types as
2009         appropriate.
2010
2011         * rendering/style/ContentData.h:
2012         (WebCore::ContentData::~ContentData):
2013         (WebCore::ContentData::isCounter):
2014         (WebCore::ContentData::isImage):
2015         (WebCore::ContentData::isQuote):
2016         (WebCore::ContentData::isText):
2017         (WebCore::ContentData::next):
2018         (WebCore::ContentData::setNext):
2019         (WebCore::ImageContentData::image):
2020         (WebCore::ImageContentData::setImage):
2021         (WebCore::ImageContentData::ImageContentData):
2022         (WebCore::ImageContentData::type):
2023         (WebCore::ImageContentData::isImage):
2024         (WebCore::TextContentData::text):
2025         (WebCore::TextContentData::setText):
2026         (WebCore::TextContentData::TextContentData):
2027         (WebCore::TextContentData::type):
2028         (WebCore::TextContentData::isText):
2029         (WebCore::CounterContentData::counter):
2030         (WebCore::CounterContentData::setCounter):
2031         (WebCore::CounterContentData::CounterContentData):
2032         (WebCore::CounterContentData::type):
2033         (WebCore::CounterContentData::isCounter):
2034         (WebCore::QuoteContentData::quote):
2035         (WebCore::QuoteContentData::setQuote):
2036         (WebCore::QuoteContentData::QuoteContentData):
2037         (WebCore::QuoteContentData::type):
2038         (WebCore::QuoteContentData::isQuote):
2039         Add subclasses for different content types, which are created
2040         via overloaded create() methods on the base class.
2041
2042         * rendering/style/ContentData.cpp:
2043         (WebCore::ContentData::create):
2044         (WebCore::operator==): Test for type equality, followed by comparing data.
2045         (WebCore::operator!=):
2046
2047         * rendering/style/RenderStyle.cpp:
2048         (WebCore::RenderStyle::clearContent):
2049         (WebCore::RenderStyle::appendContent): 
2050         (WebCore::RenderStyle::setContent): Replace the overly complex prepareToSetContent()
2051         code with code that either appends, or replaces the content.
2052         This loses an optimization where the existing ContentData object could get reused,
2053         but this seems to be rarely hit in practice.
2054         * rendering/style/RenderStyle.h:
2055         (WebCore::InheritedFlags::hasContent): Convenience method.
2056         * rendering/style/StyleRareNonInheritedData.cpp:
2057         (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Test
2058         that the pointers are non-null, then use the != operator.
2059         * rendering/style/StyleRareNonInheritedData.h: ContentData is a class now.
2060
2061 2011-06-07  Brian Weinstein  <bweinstein@apple.com>
2062
2063         Build fix after r88260.
2064
2065         * platform/graphics/win/FontCacheWin.cpp:
2066         (WebCore::FontCache::getFontDataForCharacters): Update to use enum instead of bool.
2067         * platform/graphics/wince/FontCacheWinCE.cpp:
2068
2069 2011-06-07  Rob Buis  <rbuis@rim.com>
2070
2071         Reviewed by Dirk Schulze.
2072
2073         stroke-dasharray does not handle "none"
2074         https://bugs.webkit.org/show_bug.cgi?id=62203
2075
2076         Use the initial strokeDashArray style for stroke-dasharray="none" to apply to SVGRenderStyle rather than bailing out.
2077
2078         Tests: svg/W3C-SVG-1.1-SE/styling-css-04-f.svg
2079                svg/custom/invalid-dasharray.svg
2080
2081         * css/SVGCSSStyleSelector.cpp:
2082         (WebCore::CSSStyleSelector::applySVGProperty):
2083
2084 2011-06-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2085
2086         Unreviewed, rolling out r88259 and r88263.
2087         http://trac.webkit.org/changeset/88259
2088         http://trac.webkit.org/changeset/88263
2089         https://bugs.webkit.org/show_bug.cgi?id=62228
2090
2091         broke builds (Requested by rniwa on #webkit).
2092
2093         * platform/mac/WebCoreSystemInterface.h:
2094         * platform/network/ResourceHandle.h:
2095         * platform/network/cf/ResourceRequest.h:
2096
2097 2011-06-07  Emil A Eklund  <eae@chromium.org>
2098
2099         Reviewed by Eric Seidel.
2100
2101         Switch ContainerNode to use IntPoint
2102         https://bugs.webkit.org/show_bug.cgi?id=61893
2103
2104         Covered by existing tests.
2105
2106         * dom/ContainerNode.cpp:
2107         (WebCore::ContainerNode::getUpperLeftCorner):
2108         (WebCore::ContainerNode::getLowerRightCorner):
2109         (WebCore::ContainerNode::getRect):
2110         Change to use maxX/maxY instead of x+width/y+height
2111         
2112         * platform/graphics/FloatPoint.h:
2113         (WebCore::FloatPoint::move):
2114         (WebCore::FloatPoint::moveBy):
2115         (WebCore::FloatPoint::expandedTo):
2116         Add move, moveBy and expandedTo mirroring the IntPoint implementation of the same.
2117
2118 2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
2119
2120         Speculative build fix after r88259.
2121
2122         * platform/network/cf/ResourceRequest.h:
2123
2124 2011-06-07  Michael Saboff  <msaboff@apple.com>
2125
2126         Reviewed by Geoffrey Garen.
2127
2128         Need to enable font cache purging in MemoryPressureHandler
2129         https://bugs.webkit.org/show_bug.cgi?id=62060
2130
2131         Improve memory usage under pressure.
2132         Added call to fontCache()->purgeInactiveFontData() in 
2133         MemoryPressureHandler::respondToMemoryPressure().  Added protection to 
2134         MemoryPressureHandler::install() being called multiple times.
2135
2136         No new tests as funtionality wasn't changed.
2137
2138         * platform/MemoryPressureHandler.cpp:
2139         (WebCore::MemoryPressureHandler::MemoryPressureHandler):
2140         * platform/MemoryPressureHandler.h:
2141         * platform/mac/MemoryPressureHandlerMac.mm:
2142         (WebCore::MemoryPressureHandler::install):
2143         (WebCore::MemoryPressureHandler::respondToMemoryPressure):
2144
2145 2011-06-07  Michael Saboff  <msaboff@apple.com>
2146
2147         Reviewed by Geoffrey Garen.
2148
2149         Fonts returned by FontCache::getFontDataForCharacters() are never released
2150         https://bugs.webkit.org/show_bug.cgi?id=61875
2151
2152         This change allows fonts allocated as system fallback fonts to be 
2153         released.  Previously, the reference counts for these fonts grew 
2154         without bound.  This is implemented as an auto release class that wraps
2155         accesses to the cache for system fallback fonts. All such accesses are
2156         via the method FontCache::getFontDataForCharacters. The new class is
2157         called FontCachePurgePreventer. When such an object exists, it protects
2158         these fonts from deletion.
2159
2160         Most accesses to the font cache still use the reference counting
2161         implemented by FontCache::getCacheFontData() and 
2162         FontCache::releaseFontData() and that operation is not affected by
2163         this change.
2164
2165         Added local scoped instance of FontCachePurgePreventer to wrap code
2166         that directly or indirectly accesses fonts via getFontDataForCharacters.
2167         Did a few other miscellaneous bug fixes and changes to allow system
2168         fallback fonts to be pruned from the GlyphPageTree. Changed the
2169         calls to getFontData in the platform specific versions of
2170         Fontcache::getFontDataForCharacters to not increment the reference
2171         count.  Moved the purge font check
2172         outside of FontCache::getCachedFontData() into a separate method, 
2173         purgeInactiveFontDataIfNeeded() since almost all calls to 
2174         getCachedFontData() now happen when purging is not allowed.
2175         purgeInactiveFontDataIfNeeded is invoked in enablePurging() when
2176         m_purgePreventCount is 0.
2177
2178         No new test as the functionality has not changed. Improved font life
2179         cycle management.
2180
2181         * WebCore.exp.in: Added FontCache::purgeInactiveFontDataIfNeeded().
2182         * html/canvas/CanvasRenderingContext2D.cpp:
2183         (WebCore::CanvasRenderingContext2D::measureText):
2184         (WebCore::CanvasRenderingContext2D::drawTextInternal):
2185         Wrapped code accessing fallback fonts with local 
2186         FontCachePurgePreventer in these methods.
2187
2188         * page/FrameView.cpp:
2189         (WebCore::FrameView::layout):
2190         (WebCore::FrameView::paintContents):
2191         Wrapped code accessing fallback fonts with local 
2192         FontCachePurgePreventer in these methods.
2193
2194         * platform/graphics/FontCache.cpp:
2195         (WebCore::FontCache::FontCache):
2196         (WebCore::FontCache::getCachedFontData):
2197         Moved purge check to new method since it likely can't happen here.
2198         (WebCore::FontCache::releaseFontData):
2199         (WebCore::FontCache::purgeInactiveFontDataIfNeeded):
2200         (WebCore::FontCache::purgeInactiveFontData):
2201         Made purging conditional on m_purgePreventCount.  Now some fonts
2202         in the cache are reference counted while other can be purged 
2203         outside of code wrapped by in scope FontCachePurgePreventer objects.
2204
2205         * platform/graphics/FontCache.h:
2206         (WebCore::FontCache::disablePurging):
2207         (WebCore::FontCache::enablePurging):
2208         (WebCore::FontCachePurgePreventer::FontCachePurgePreventer):
2209         (WebCore::FontCachePurgePreventer::~FontCachePurgePreventer):
2210         Added new simple purge prevention wrapper class and methods
2211         that it calls in FontCache actually prevent purging.  The
2212         simple methods inlined to reduce overhead.
2213
2214         * platform/graphics/FontFastPath.cpp:
2215         (WebCore::Font::glyphDataForCharacter): Update level in 
2216         glyph page tree for system fallback fonts so pruning works.
2217
2218         * platform/graphics/GlyphPage.h:
2219         (WebCore::GlyphPage::clearForFontData): New method used for pruning
2220         * platform/graphics/GlyphPageTreeNode.cpp:
2221         (WebCore::GlyphPageTreeNode::pruneFontData):
2222         Now we prune system fallback fonts.
2223
2224         * platform/graphics/chromium/FontCacheChromiumWin.cpp:
2225         (WebCore::FontCache::getFontDataForCharacters):
2226         * platform/graphics/freetype/FontCacheFreeType.cpp:
2227         (WebCore::FontCache::getFontDataForCharacters):
2228         * platform/graphics/haiku/FontCacheHaiku.cpp:
2229         (WebCore::FontCache::getFontDataForCharacters):
2230         * platform/graphics/mac/FontCacheMac.mm:
2231         (WebCore::FontCache::getFontDataForCharacters):
2232         * platform/graphics/qt/FontCacheQt.cpp:
2233         (WebCore::FontCache::getFontDataForCharacters):
2234         * platform/graphics/win/FontCacheWin.cpp:
2235         (WebCore::FontCache::getFontDataForCharacters):
2236         * platform/graphics/wince/FontCacheWinCE.cpp:
2237         * platform/graphics/wx/FontCacheWx.cpp:
2238         (WebCore::FontCache::getFontDataForCharacters):
2239         Changed the calls to getFontData() to not increment the reference
2240         count. The caller of this getFontDataForCharacters() (currently only
2241         Font::glyphDataForCharacter() in fontFastPath.cpp) and it's callers
2242         don't attempt to release the returned fonts so we use the purge
2243         protection described above.
2244
2245         * rendering/InlineTextBox.cpp:
2246         (WebCore::InlineTextBox::selectionRect):
2247         (WebCore::InlineTextBox::offsetForPosition):
2248         (WebCore::InlineTextBox::positionForOffset):
2249         Wrapped code accessing fallback fonts with local
2250         FontCachePurgePreventer in these methods.
2251
2252         * rendering/RenderImage.cpp:
2253         (WebCore::RenderImage::setImageSizeForAltText):
2254         Wrapped code accessing fallback fonts with local
2255         FontCachePurgePreventer in this method.
2256
2257         * rendering/RenderListBox.cpp:
2258         (WebCore::RenderListBox::updateFromElement):
2259         (WebCore::RenderListBox::paintItemForeground):
2260         Wrapped code accessing fallback fonts with local
2261         FontCachePurgePreventer in these methods
2262
2263         * rendering/svg/SVGInlineTextBox.cpp:
2264         (WebCore::SVGInlineTextBox::selectionRectForTextFragment):
2265         Wrapped code accessing fallback fonts with local
2266         FontCachePurgePreventer in this method.
2267
2268 2011-06-07  Tim Horton  <timothy_horton@apple.com>
2269
2270         Reviewed by Alexey Proskuryakov.
2271
2272         Use correct CFURLStorageSessionRef definition on Snow Leopard
2273         https://bugs.webkit.org/show_bug.cgi?id=62223
2274
2275         * platform/mac/WebCoreSystemInterface.h:
2276         * platform/network/ResourceHandle.h:
2277         * platform/network/cf/ResourceRequest.h:
2278
2279 2011-06-07  Alok Priyadarshi  <alokp@chromium.org>
2280
2281         Reviewed by Stephen White.
2282
2283         [chromium] PlatformContextSkia leaks SkDeviceFactory
2284         https://bugs.webkit.org/show_bug.cgi?id=62163
2285
2286         Valgrind tests should have caught this.
2287
2288         * platform/graphics/skia/PlatformContextSkia.cpp:
2289         (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
2290
2291 2011-06-07  Emil A Eklund  <eae@chromium.org>
2292
2293         Reviewed by Eric Seidel.
2294
2295         Convert RenderTextControl::hitInnerTextElement to IntPoint
2296         https://bugs.webkit.org/show_bug.cgi?id=62167
2297
2298         Covered by existing tests.
2299
2300         * rendering/RenderTextControl.cpp:
2301         (WebCore::RenderTextControl::hitInnerTextElement):
2302         * rendering/RenderTextControl.h:
2303         * rendering/RenderTextControlMultiLine.cpp:
2304         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
2305         * rendering/RenderTextControlSingleLine.cpp:
2306         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
2307
2308 2011-06-07  Levi Weintraub  <leviw@chromium.org>
2309
2310         Reviewed by Eric Seidel.
2311
2312         Switch paint to use IntPoint
2313         https://bugs.webkit.org/show_bug.cgi?id=62177
2314
2315         Flipping the switch on the remaining paint functions to have them all
2316         use IntPoint for the paint offset instead of tx/ty.
2317
2318         No new tests since this is just refactoring.
2319
2320         * page/FrameView.cpp:
2321         (WebCore::FrameView::paintScrollCorner):
2322         * rendering/InlineBox.cpp:
2323         (WebCore::InlineBox::paint):
2324         * rendering/RenderBlock.cpp:
2325         (WebCore::RenderBlock::paint):
2326         (WebCore::RenderBlock::paintContents):
2327         (WebCore::RenderBlock::paintChildren):
2328         (WebCore::RenderBlock::paintFloats):
2329         * rendering/RenderBlock.h:
2330         * rendering/RenderBox.cpp:
2331         (WebCore::RenderBox::paint):
2332         * rendering/RenderBox.h:
2333         * rendering/RenderBoxModelObject.cpp:
2334         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
2335         * rendering/RenderDetailsMarker.cpp:
2336         (WebCore::RenderDetailsMarker::paint):
2337         * rendering/RenderDetailsMarker.h:
2338         * rendering/RenderEmbeddedObject.cpp:
2339         (WebCore::RenderEmbeddedObject::paint):
2340         * rendering/RenderEmbeddedObject.h:
2341         * rendering/RenderFrameSet.cpp:
2342         (WebCore::RenderFrameSet::paint):
2343         * rendering/RenderFrameSet.h:
2344         * rendering/RenderImage.cpp:
2345         (WebCore::RenderImage::paint):
2346         * rendering/RenderImage.h:
2347         * rendering/RenderInline.cpp:
2348         (WebCore::RenderInline::paint):
2349         * rendering/RenderInline.h:
2350         * rendering/RenderLayer.cpp:
2351         (WebCore::RenderLayer::paintScrollCorner):
2352         (WebCore::RenderLayer::paintResizer):
2353         (WebCore::RenderLayer::paintLayer):
2354         * rendering/RenderLayerBacking.cpp:
2355         (WebCore::RenderLayerBacking::paintIntoLayer):
2356         * rendering/RenderLineBoxList.cpp:
2357         (WebCore::RenderLineBoxList::paint):
2358         * rendering/RenderLineBoxList.h:
2359         * rendering/RenderListItem.cpp:
2360         (WebCore::RenderListItem::paint):
2361         * rendering/RenderListItem.h:
2362         * rendering/RenderListMarker.cpp:
2363         (WebCore::RenderListMarker::paint):
2364         * rendering/RenderListMarker.h:
2365         * rendering/RenderObject.cpp:
2366         (WebCore::RenderObject::paint):
2367         * rendering/RenderObject.h:
2368         * rendering/RenderReplaced.cpp:
2369         (WebCore::RenderReplaced::paint):
2370         * rendering/RenderReplaced.h:
2371         * rendering/RenderReplica.cpp:
2372         (WebCore::RenderReplica::paint):
2373         * rendering/RenderReplica.h:
2374         * rendering/RenderScrollbar.cpp:
2375         (WebCore::RenderScrollbar::paintPart):
2376         * rendering/RenderScrollbarPart.cpp:
2377         (WebCore::RenderScrollbarPart::paintIntoRect):
2378         * rendering/RenderScrollbarPart.h:
2379         * rendering/RenderTable.cpp:
2380         (WebCore::RenderTable::paint):
2381         (WebCore::RenderTable::paintObject):
2382         * rendering/RenderTable.h:
2383         * rendering/RenderTableCell.cpp:
2384         (WebCore::RenderTableCell::paint):
2385         * rendering/RenderTableCell.h:
2386         * rendering/RenderTableRow.cpp:
2387         (WebCore::RenderTableRow::paint):
2388         * rendering/RenderTableRow.h:
2389         * rendering/RenderTableSection.cpp:
2390         (WebCore::RenderTableSection::paint):
2391         (WebCore::RenderTableSection::paintCell):
2392         * rendering/RenderTableSection.h:
2393         * rendering/RenderText.h:
2394         (WebCore::RenderText::paint):
2395         * rendering/RenderTextControlSingleLine.cpp:
2396         (WebCore::RenderTextControlSingleLine::paint):
2397         * rendering/RenderTextControlSingleLine.h:
2398         * rendering/RenderView.cpp:
2399         (WebCore::RenderView::paint):
2400         * rendering/RenderView.h:
2401         * rendering/RenderWidget.cpp:
2402         (WebCore::RenderWidget::paint):
2403         * rendering/RenderWidget.h:
2404         * rendering/mathml/RenderMathMLBlock.cpp:
2405         (WebCore::RenderMathMLBlock::paint):
2406         * rendering/mathml/RenderMathMLBlock.h:
2407         * rendering/mathml/RenderMathMLFraction.cpp:
2408         (WebCore::RenderMathMLFraction::paint):
2409         * rendering/mathml/RenderMathMLFraction.h:
2410         * rendering/mathml/RenderMathMLRoot.cpp:
2411         (WebCore::RenderMathMLRoot::paint):
2412         * rendering/mathml/RenderMathMLRoot.h:
2413         * rendering/mathml/RenderMathMLSquareRoot.cpp:
2414         (WebCore::RenderMathMLSquareRoot::paint):
2415         * rendering/mathml/RenderMathMLSquareRoot.h:
2416         * rendering/svg/RenderSVGContainer.cpp:
2417         (WebCore::RenderSVGContainer::paint):
2418         * rendering/svg/RenderSVGContainer.h:
2419         * rendering/svg/RenderSVGForeignObject.cpp:
2420         (WebCore::RenderSVGForeignObject::paint):
2421         * rendering/svg/RenderSVGForeignObject.h:
2422         * rendering/svg/RenderSVGHiddenContainer.cpp:
2423         (WebCore::RenderSVGHiddenContainer::paint):
2424         * rendering/svg/RenderSVGHiddenContainer.h:
2425         * rendering/svg/RenderSVGImage.cpp:
2426         (WebCore::RenderSVGImage::paint):
2427         * rendering/svg/RenderSVGImage.h:
2428         * rendering/svg/RenderSVGPath.cpp:
2429         (WebCore::RenderSVGPath::paint):
2430         * rendering/svg/RenderSVGPath.h:
2431         * rendering/svg/RenderSVGResourceMarker.cpp:
2432         (WebCore::RenderSVGResourceMarker::draw):
2433         * rendering/svg/RenderSVGRoot.cpp:
2434         (WebCore::RenderSVGRoot::paint):
2435         * rendering/svg/RenderSVGRoot.h:
2436         * rendering/svg/RenderSVGText.cpp:
2437         (WebCore::RenderSVGText::paint):
2438         * rendering/svg/RenderSVGText.h:
2439         * rendering/svg/SVGImageBufferTools.cpp:
2440         (WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer):
2441
2442 2011-06-07  Young Han Lee  <joybro@company100.net>
2443
2444         Reviewed by Kenneth Rohde Christiansen.
2445
2446         [Texmap][Qt] Accelerated animation is not paused properly.
2447         https://bugs.webkit.org/show_bug.cgi?id=61446
2448
2449         The transform matrix of an accelerated animation shouldn't be synced with the matrix of the GraphicsLayer when the animation is paused.
2450
2451         Test: animations/play-state-paused.html
2452
2453         * platform/graphics/texmap/TextureMapperNode.cpp:
2454         (WebCore::TextureMapperNode::syncCompositingStateSelf):
2455         (WebCore::TextureMapperNode::hasOpacityAnimation):
2456         (WebCore::TextureMapperNode::hasTransformAnimation):
2457         * platform/graphics/texmap/TextureMapperNode.h:
2458
2459 2011-06-07  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2460
2461         Reviewed by Antonio Gomes.
2462
2463         [EFL] Remove Ecore_X bits from PlatformScreenEfl
2464         https://bugs.webkit.org/show_bug.cgi?id=61649
2465
2466         Remove the need for Ecore_X and some X calls by always using
2467         new functions available in EFL to get the screen size.
2468
2469         No new tests since the same functionality are done inside EFL now.
2470
2471         * platform/efl/PlatformScreenEfl.cpp:
2472         (WebCore::screenRect):
2473
2474 2011-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2475
2476         Reviewed by Martin Robinson.
2477
2478         [GTK] Move moduleMixesGtkSymbols() from PluginPackage to PluginView
2479         https://bugs.webkit.org/show_bug.cgi?id=62200
2480
2481         In WebKit2 PluginPackage is used by the UI process to load plugins
2482         in order to get information about them, but it doesn't use any GTK
2483         symbol. So the UI process should be able to load plugins even when
2484         building with GTK3, but we should not allow the plugin view to use
2485         the plugin if it mixes GTK2 and GTK3 symbols.
2486
2487         * plugins/PluginPackage.h:
2488         (WebCore::PluginPackage::module): New method to return the
2489         platform module.
2490         * plugins/gtk/PluginPackageGtk.cpp:
2491         (WebCore::PluginPackage::load): Remove moduleMixesGtkSymbols().
2492         * plugins/gtk/PluginViewGtk.cpp:
2493         (WebCore::PluginView::updatePluginWidget): Check whether plugin
2494         was successfully loaded before trying to create the drawable.
2495         (WebCore::PluginView::paint): Return early if plugin didn't start
2496         or was not successfully loaded.
2497         (WebCore::PluginView::handleKeyboardEvent): Ditto.
2498         (WebCore::PluginView::handleMouseEvent): Ditto.
2499         (WebCore::PluginView::handleFocusInEvent): Ditto.
2500         (WebCore::PluginView::handleFocusOutEvent): Ditto.
2501         (WebCore::moduleMixesGtkSymbols):
2502         (WebCore::PluginView::platformStart): Check whether module is
2503         mixing GTK+ 2 and GTK+ 3 symbols.
2504
2505 2011-06-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2506
2507         Unreviewed, rolling out r88238.
2508         http://trac.webkit.org/changeset/88238
2509         https://bugs.webkit.org/show_bug.cgi?id=62216
2510
2511         Broke a couple of inspector tests (Requested by apavlov on
2512         #webkit).
2513
2514         * inspector/front-end/StylesSidebarPane.js:
2515         (WebInspector.StylesSidebarPane.prototype.update):
2516
2517 2011-06-07  Dinu Jacob  <dinu.jacob@nokia.com>
2518
2519         Reviewed by Dimitri Glazkov.
2520
2521         Inform ChromeClient touch events are not needed by the webpage when navigating away from the page instead of in both Document:detach/CachedFrame
2522         https://bugs.webkit.org/show_bug.cgi?id=61543
2523
2524         Inform chrome client that touch events are not needed by the webpage 
2525         when navigating away from the page only once to avoid the flag being 
2526         overwritten later if a page is removed from the page cache
2527
2528         * dom/Document.cpp:
2529         (WebCore::Document::detach):
2530         * history/CachedFrame.cpp:
2531         (WebCore::CachedFrame::CachedFrame):
2532         * loader/FrameLoader.cpp:
2533         (WebCore::FrameLoader::transitionToCommitted):
2534
2535 2011-06-07  Alexander Pavlov  <apavlov@chromium.org>
2536
2537         Reviewed by Yury Semikhatsky.
2538
2539         Web Inspector: node selection is slow in the Elements panel.
2540         https://bugs.webkit.org/show_bug.cgi?id=60813
2541
2542         Schedule full style updates rather than request all node styles from the backend immediately.
2543
2544         * inspector/front-end/StylesSidebarPane.js:
2545         (WebInspector.StylesSidebarPane.prototype.update.reloadAllStyles):
2546         (WebInspector.StylesSidebarPane.prototype.update):
2547
2548 2011-06-07  Yury Semikhatsky  <yurys@chromium.org>
2549
2550         Reviewed by Pavel Feldman.
2551
2552         Web Inspector: remove duplicate breakpoints from localStorage
2553         https://bugs.webkit.org/show_bug.cgi?id=62206
2554
2555         Perform one-time breakpoint storage cleanup to get rid of duplicate breakpoints in
2556         case when settings version is less than 1. 
2557
2558         * inspector/front-end/Settings.js:
2559         (WebInspector.Settings):
2560         (WebInspector.Settings.prototype._set):
2561         (WebInspector.Settings.prototype._migrateSettings.splitObjects):
2562         (WebInspector.Settings.prototype._migrateSettings.removeDuplicateObjects):
2563         (WebInspector.Settings.prototype._migrateSettings):
2564
2565 2011-06-03  Yury Semikhatsky  <yurys@chromium.org>
2566
2567         Reviewed by Pavel Feldman.
2568
2569         [Chromium] Web Inspector: correctly handle disconnect from worker when script execution is paused
2570         https://bugs.webkit.org/show_bug.cgi?id=62019
2571
2572         Dispatch disconnecFrontend message in debugger task mode to make sure
2573         it is processed even if execution is paused.
2574
2575         * bindings/v8/WorkerScriptDebugServer.cpp:
2576         (WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
2577         (WebCore::WorkerScriptDebugServer::quitMessageLoopOnPause):
2578         * bindings/v8/WorkerScriptDebugServer.h:
2579
2580 2011-06-07  Felician Marton  <marton.felician.zoltan@stud.u-szeged.hu>
2581
2582         Reviewed by Nikolas Zimmermann.
2583
2584         SVG animation beginElement() does not restart the animation after endElement().
2585         https://bugs.webkit.org/show_bug.cgi?id=43452
2586
2587         Test: svg/animations/animate-endElement-beginElement.html
2588
2589         Calling beginElement() after calling endElement() previously does not restarted the animation when animation
2590         element's end attribute doesn't contains a bigger value than the current animation time.
2591
2592         * svg/animation/SVGSMILElement.cpp:
2593         (WebCore::SVGSMILElement::findInstanceTime):
2594
2595 2011-06-07  Naoki Takano  <takano.naoki@gmail.com>
2596
2597         Reviewed by Kent Tamura.
2598
2599         [Chromium] Click event is not fired for a menulist <select>
2600         https://bugs.webkit.org/show_bug.cgi?id=60563
2601
2602         Tests: SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange in webkit_unit_tests.
2603
2604         * platform/chromium/PopupMenuChromium.cpp:
2605         (WebCore::PopupContainer::showPopup): Set m_focusedNode from m_frameView.
2606         (WebCore::PopupListBox::handleMouseReleaseEvent): Call dispatchMouseEvent to forward the event only if select popup.
2607         (WebCore::PopupListBox::acceptIndex): Change to return accepted or not.
2608
2609 2011-06-07  Andras Becsi  <abecsi@webkit.org>
2610
2611         Reviewed by Yury Semikhatsky.
2612  
2613         REGRESSION(r88221): "Chromium debug compilation broken".
2614         https://bugs.webkit.org/show_bug.cgi?id=62197
2615
2616         No new tests needed.
2617
2618         * bindings/v8/V8GCController.cpp: Also rename call-sites.
2619         (WebCore::V8GCController::gcPrologue):
2620         (WebCore::V8GCController::gcEpilogue):
2621
2622 2011-06-07  MORITA Hajime  <morrita@google.com>
2623
2624         Unreviewed, rolling out r88212 and r88219.
2625         http://trac.webkit.org/changeset/88212
2626         http://trac.webkit.org/changeset/88219
2627         https://bugs.webkit.org/show_bug.cgi?id=57439
2628
2629         Tests get timeout at Snow Leopard
2630
2631         * css/html.css:
2632         (html:focus, body:focus, input[readonly]:focus):
2633         * rendering/RenderWidget.cpp:
2634         (WebCore::RenderWidget::paint):
2635
2636 2011-06-07  Andras Becsi  <abecsi@webkit.org>
2637
2638         Rubber-stamped by Csaba Osztrogonác.
2639
2640         [Qt][V8] Fix the build after 88221.
2641
2642         No new tests needed.
2643
2644         * WebCore.pro: Remove non-existing files.
2645         * bindings/v8/V8DOMMap.cpp: 
2646         (WebCore::removeAllDOMObjects): Also rename the definition of the function.
2647
2648 2011-06-06  Dmitry Lomov  <dslomov@google.com>
2649
2650         Reviewed by Adam Barth.
2651
2652         https://bugs.webkit.org/show_bug.cgi?id=62164
2653         Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and friends
2654         This functionality is untested and unused:
2655         This is an old code from Lockers-based implementation of WebWorkers in
2656         V8 bindings, to make sure that DOM objects are released on the right thread
2657         even though GC could have happened on any thread. It is currently unused (since
2658         current model is one worker per process) and is being removed because new implementation
2659         of WebWorkers will be using V8 isolates.
2660
2661         * WebCore.gypi:
2662         * bindings/v8/ChildThreadDOMData.cpp: Removed.
2663         * bindings/v8/ChildThreadDOMData.h: Removed.
2664         * bindings/v8/DOMData.cpp:
2665         (WebCore::DOMData::DOMData):
2666         (WebCore::DOMData::getCurrent):
2667         (WebCore::DOMData::getMainThreadStore):
2668         * bindings/v8/DOMData.h:
2669         (WebCore::DOMData::getStore):
2670         (WebCore::DOMData::getCurrentMainThreadStore):
2671         (WebCore::DOMData::handleWeakObject):
2672         * bindings/v8/DOMDataStore.cpp:
2673         (WebCore::DOMDataStore::DOMDataStore):
2674         (WebCore::DOMDataStore::~DOMDataStore):
2675         (WebCore::DOMDataStore::weakNodeCallback):
2676         * bindings/v8/DOMDataStore.h:
2677         * bindings/v8/MainThreadDOMData.cpp: Removed.
2678         * bindings/v8/MainThreadDOMData.h: Removed.
2679         * bindings/v8/V8DOMMap.cpp:
2680         (WebCore::getDOMDataStore):
2681         (WebCore::visitDOMNodes):
2682         (WebCore::visitDOMObjects):
2683         (WebCore::visitActiveDOMObjects):
2684         (WebCore::visitDOMSVGElementInstances):
2685         * bindings/v8/V8DOMMap.h:
2686         * bindings/v8/V8GCController.cpp:
2687         (WebCore::V8GCController::gcPrologue):
2688         (WebCore::V8GCController::gcEpilogue):
2689         * bindings/v8/WorkerScriptController.cpp:
2690         (WebCore::WorkerScriptController::~WorkerScriptController):
2691
2692 2011-06-06  Nico Weber  <thakis@chromium.org>
2693
2694         Reviewed by Adam Barth.
2695
2696         [chromium] Make VideoFrameChromium's destructor virtual
2697         https://bugs.webkit.org/show_bug.cgi?id=62186
2698
2699         This fixes a real bug, since WebMediaPlayerClientImpl::putCurrentFrame
2700         deletes a VideoFrameChromium subclass type through this interface
2701         class, causing ~VideoFrameChromiumImpl's destructor not to run.
2702         (VideoFrameChroimumImpl happens to not have a destructor or any
2703         non-POD member variables, so it's more a latent bug.)
2704
2705         * platform/graphics/chromium/VideoFrameChromium.cpp:
2706         (WebCore::VideoFrameChromium::~VideoFrameChromium):
2707         * platform/graphics/chromium/VideoFrameChromium.h:
2708
2709 2011-06-06  Simon Fraser  <simon.fraser@apple.com>
2710
2711         Reviewed by Sammy Weinig.
2712
2713         Remove some unnecessary includes from AnimationBase.cpp
2714         https://bugs.webkit.org/show_bug.cgi?id=62183
2715
2716         * page/animation/AnimationBase.cpp:
2717
2718 2011-06-06  Kent Tamura  <tkent@chromium.org>
2719
2720         Unreviewed, a crash fix by a roll out.
2721
2722         REGRESSION(r87980): Null pointer dereference in RenderTextControl::setInnerText()
2723         https://bugs.webkit.org/show_bug.cgi?id=62116
2724
2725         Roll out the WebCore part of r87980.
2726
2727         * html/SearchInputType.cpp:
2728         (WebCore::SearchInputType::SearchInputType):
2729         (WebCore::SearchInputType::createShadowSubtree):
2730         (WebCore::SearchInputType::destroyShadowSubtree):
2731         * html/SearchInputType.h:
2732         (WebCore::SearchInputType::innerBlockElement):
2733         (WebCore::SearchInputType::resultsButtonElement):
2734         (WebCore::SearchInputType::cancelButtonElement):
2735         * html/TextFieldInputType.cpp:
2736         (WebCore::TextFieldInputType::TextFieldInputType):
2737         (WebCore::TextFieldInputType::createShadowSubtree):
2738         (WebCore::TextFieldInputType::destroyShadowSubtree):
2739         * html/TextFieldInputType.h:
2740         (WebCore::TextFieldInputType::innerTextElement):
2741         (WebCore::TextFieldInputType::innerSpinButtonElement):
2742         (WebCore::TextFieldInputType::speechButtonElement):
2743         (WebCore::TextFieldInputType::setInnerTextElement):
2744         (WebCore::TextFieldInputType::setSpeechButtonElement):
2745         * html/shadow/TextControlInnerElements.cpp:
2746         * html/shadow/TextControlInnerElements.h:
2747
2748 2011-06-06  No'am Rosenthal  <noam.rosenthal@nokia.com>
2749
2750         Reviewed by Simon Fraser.
2751
2752         Allow copying of KeyframeValueList.
2753         https://bugs.webkit.org/show_bug.cgi?id=62171
2754
2755         Make a deep copy of KeyframeValueList, copying each of the keyframes with a virtual clone() function.
2756
2757         No new functionality so no new tests.
2758
2759         * platform/graphics/GraphicsLayer.h:
2760         (WebCore::FloatAnimationValue::clone):
2761         (WebCore::TransformAnimationValue::TransformAnimationValue):
2762         (WebCore::TransformAnimationValue::clone):
2763         (WebCore::TransformAnimationValue::value):
2764         (WebCore::KeyframeValueList::KeyframeValueList):
2765
2766 2011-06-06  Simon Fraser  <simon.fraser@apple.com>
2767
2768         Reviewed by Dan Bernstein.
2769
2770         Incorrect rounding of color values during transitions
2771         https://bugs.webkit.org/show_bug.cgi?id=62141
2772         
2773         When blending integers, round to the nearest integer, instead of always rounding down.
2774
2775         Test: transitions/color-transition-rounding.html
2776
2777         * page/animation/AnimationBase.cpp:
2778         (WebCore::blendFunc):
2779
2780 2011-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
2781
2782         Unreviewed, rolling out r88202.
2783         http://trac.webkit.org/changeset/88202
2784         https://bugs.webkit.org/show_bug.cgi?id=62182
2785
2786         This broke the mac clang bot (Requested by koz__ on #webkit).
2787
2788         * dom/Node.cpp:
2789         (WebCore::Node::hasNonEmptyBoundingBox):
2790         * rendering/InlineBox.h:
2791         * rendering/RenderBlock.cpp:
2792         (WebCore::RenderBlock::absoluteRects):
2793         * rendering/RenderBlock.h:
2794         * rendering/RenderBox.cpp:
2795         (WebCore::RenderBox::absoluteRects):
2796         * rendering/RenderBox.h:
2797         * rendering/RenderInline.cpp:
2798         (WebCore::RenderInline::absoluteRects):
2799         * rendering/RenderInline.h:
2800         * rendering/RenderObject.cpp:
2801         (WebCore::RenderObject::absoluteBoundingBoxRect):
2802         * rendering/RenderObject.h:
2803         (WebCore::RenderObject::absoluteRects):
2804         * rendering/RenderText.cpp:
2805         (WebCore::RenderText::absoluteRects):
2806         * rendering/RenderText.h:
2807         * rendering/RenderView.cpp:
2808         (WebCore::RenderView::absoluteRects):
2809         * rendering/RenderView.h:
2810
2811 2011-06-06  Noel Gordon  <noel.gordon@gmail.com>
2812
2813         Reviewed by Hajime Morita.
2814
2815         Draw CSS outline style for render widgets: iframe, embed, object, applet.
2816         https://bugs.webkit.org/show_bug.cgi?id=57439
2817
2818         Draw CSS outlines for render widgets: iframe, embed, object, applet. These elements can
2819         be focused (via clicks or tabIndex) but should not have a visible focus ring by default.
2820
2821         Tests: fast/replaced/no-focus-ring-embed-1.html
2822                fast/replaced/no-focus-ring-embed-2.html
2823                fast/replaced/no-focus-ring-iframe.html
2824                fast/replaced/no-focus-ring-object-1.html
2825                fast/replaced/no-focus-ring-object-2.html
2826                fast/replaced/outline-replaced-elements.html
2827
2828         * css/html.css:
2829         (applet:focus, embed:focus, iframe:focus, object:focus):  Default to no focus ring.
2830         * rendering/RenderWidget.cpp:
2831         (WebCore::RenderWidget::paint): Paint the render widget CSS outline style.
2832
2833 2011-06-06  MORITA Hajime  <morrita@google.com>
2834
2835         Reviewed by Kent Tamura.
2836
2837         Assertion fails in TextCheckingHelper by right-clicking on <input type=search>
2838         https://bugs.webkit.org/show_bug.cgi?id=61991
2839
2840         Added a guard bofore TextCheckingHelper construction sites.
2841
2842         Test: editing/spelling/spellcheck-input-search-crash.html
2843
2844         * editing/Editor.cpp:
2845         (WebCore::Editor::isSelectionUngrammatical):
2846         (WebCore::Editor::guessesForUngrammaticalSelection):
2847         (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection):
2848
2849 2011-06-06  Emil A Eklund  <eae@chromium.org>
2850
2851         Reviewed by Eric Seidel.
2852
2853         Update RenderBlock::paint to use IntPoint internally
2854         https://bugs.webkit.org/show_bug.cgi?id=62140
2855
2856         Covered by existing tests.
2857
2858         * rendering/RenderBlock.cpp:
2859         (WebCore::RenderBlock::paint):
2860
2861 2011-06-06  Emil A Eklund  <eae@chromium.org>
2862
2863         Reviewed by Eric Seidel.
2864
2865         Convert RenderBox::absoluteRects to IntPoint
2866         https://bugs.webkit.org/show_bug.cgi?id=62130
2867
2868         Covered by existing tests.
2869
2870         * dom/Node.cpp:
2871         (WebCore::Node::hasNonEmptyBoundingBox):
2872         * rendering/RenderBlock.cpp:
2873         (WebCore::RenderBlock::absoluteRects):
2874         * rendering/RenderBlock.h:
2875         * rendering/RenderBox.cpp:
2876         (WebCore::RenderBox::absoluteRects):
2877         * rendering/RenderBox.h:
2878         * rendering/RenderInline.cpp:
2879         (WebCore::RenderInline::absoluteRects):
2880         * rendering/RenderInline.h:
2881         * rendering/RenderObject.cpp:
2882         (WebCore::RenderObject::absoluteBoundingBoxRect):
2883         * rendering/RenderObject.h:
2884         (WebCore::RenderObject::absoluteRects):
2885         * rendering/RenderText.cpp:
2886         (WebCore::RenderText::absoluteRects):
2887         * rendering/RenderText.h:
2888         * rendering/RenderView.cpp:
2889         (WebCore::RenderView::absoluteRects):
2890         * rendering/RenderView.h:
2891
2892 2011-06-06  Levi Weintraub  <leviw@chromium.org>
2893
2894         Reviewed by Eric Seidel.
2895
2896         Switch shouldPaint to use IntPoint
2897         https://bugs.webkit.org/show_bug.cgi?id=62158
2898
2899         Switching shouldPaint to take an IntPoint representing the paint offset instead
2900         of a pair of ints.
2901
2902         No new tests as this is simple refactoring.
2903
2904         * rendering/RenderReplaced.cpp:
2905         (WebCore::RenderReplaced::paint):
2906         (WebCore::RenderReplaced::shouldPaint):
2907         * rendering/RenderReplaced.h:
2908         * rendering/RenderWidget.cpp:
2909         (WebCore::RenderWidget::paint):
2910
2911 2011-06-06  James Simonsen  <simonjam@chromium.org>
2912
2913         Reviewed by James Robinson.
2914
2915         Add monotonicallyIncreasingTime() to get monotonically increasing time
2916         https://bugs.webkit.org/show_bug.cgi?id=37743
2917
2918         * platform/chromium/SystemTimeChromium.cpp:
2919         (WebCore::monotonicallyIncreasingTime): Add primitive monotonicallyIncreasingTime() which just wraps currentTime().
2920
2921 2011-06-06  Emil A Eklund  <eae@chromium.org>
2922
2923         Reviewed by Eric Seidel.
2924
2925         Convert RenderBox::pushContentsClip to IntPoint
2926         https://bugs.webkit.org/show_bug.cgi?id=62133
2927
2928         Covered by existing tests.
2929
2930         * rendering/RenderBlock.cpp:
2931         (WebCore::Covered by existing tests.RenderBlock::paint):
2932         * rendering/RenderBox.cpp:
2933         (WebCore::RenderBox::pushContentsClip):
2934         * rendering/RenderBox.h:
2935         * rendering/RenderTable.cpp:
2936         (WebCore::RenderTable::paint):
2937         * rendering/RenderTableSection.cpp:
2938         (WebCore::RenderTableSection::paint):
2939
2940 2011-06-06  Levi Weintraub  <leviw@chromium.org>
2941
2942         Reviewed by Eric Seidel.
2943
2944         Switch InlineFlowBox::paintMask to use IntPoint
2945         https://bugs.webkit.org/show_bug.cgi?id=62156
2946
2947         Switching InlineFlowBox::paintMask to take an IntPoint representing the paint
2948         offset instead of a pair of ints.
2949
2950         No new tests as this is simple refactoring.
2951
2952         * rendering/InlineFlowBox.cpp:
2953         (WebCore::InlineFlowBox::paint):
2954         (WebCore::InlineFlowBox::paintMask):
2955         * rendering/InlineFlowBox.h:
2956
2957 2011-06-06  Emil A Eklund  <eae@chromium.org>
2958
2959         Reviewed by Eric Seidel.
2960
2961         Convert hitTest to IntPoint
2962         https://bugs.webkit.org/show_bug.cgi?id=62144
2963
2964         Covered by existing tests.
2965
2966         * rendering/InlineBox.cpp:
2967         (WebCore::InlineBox::nodeAtPoint):
2968         * rendering/RenderBlock.cpp:
2969         (WebCore::RenderBlock::hitTestFloats):
2970         (WebCore::RenderBlock::hitTestContents):
2971         * rendering/RenderInline.cpp:
2972         (WebCore::RenderInline::nodeAtPoint):
2973         * rendering/RenderLayer.cpp:
2974         (WebCore::RenderLayer::hitTestContents):
2975         * rendering/RenderLayer.h:
2976         (WebCore::RenderLayer::renderBoxLocation):
2977         (WebCore::RenderLayer::renderBoxX):
2978         (WebCore::RenderLayer::renderBoxY):
2979         * rendering/RenderLineBoxList.cpp:
2980         (WebCore::RenderLineBoxList::hitTest):
2981         * rendering/RenderLineBoxList.h:
2982         * rendering/RenderObject.cpp:
2983         (WebCore::RenderObject::hitTest):
2984         * rendering/RenderObject.h:
2985
2986 2011-06-06  Levi Weintraub  <leviw@chromium.org>
2987
2988         Reviewed by Eric Seidel.
2989
2990         Switch paintScrollbar to use IntPoint
2991         https://bugs.webkit.org/show_bug.cgi?id=62151
2992
2993         Switching paintScrollbar to use IntPoint instead of a pair of ints.
2994
2995         No new tests since this is simple refactoring.
2996
2997         * rendering/RenderListBox.cpp:
2998         (WebCore::RenderListBox::paintObject):
2999         (WebCore::RenderListBox::paintScrollbar):
3000         * rendering/RenderListBox.h:
3001
3002 2011-06-06  Daniel Cheng  <dcheng@chromium.org>
3003
3004         Reviewed by Tony Chang.
3005
3006         [chromium] Delete dead clipboard code.
3007         https://bugs.webkit.org/show_bug.cgi?id=62113
3008
3009         No new tests since this change only deleted unused code.
3010
3011         * WebCore.gypi:
3012         * platform/chromium/ChromiumDataObjectLegacy.cpp: Removed.
3013         * platform/chromium/ChromiumDataObjectLegacy.h: Removed.
3014         * platform/chromium/ReadableDataObject.cpp: Removed.
3015         * platform/chromium/ReadableDataObject.h: Removed.
3016         * platform/chromium/WritableDataObject.cpp: Removed.
3017         * platform/chromium/WritableDataObject.h: Removed.
3018
3019 2011-06-06  Levi Weintraub  <leviw@chromium.org>
3020
3021         Reviewed by Eric Seidel.
3022
3023         Switch paintOutline, paintContinuationOutlines, and paintOutlineForLine to use IntPoint
3024         https://bugs.webkit.org/show_bug.cgi?id=62137
3025
3026         Switching paintOutline, paintContinuationOutlines, and paintOutlineForLine to take an IntPoint
3027         representing the paint offset instead of a pair of ints.
3028
3029         No new tests as this is simple refactoring.
3030
3031         * rendering/RenderBlock.cpp:
3032         (WebCore::RenderBlock::paintObject):
3033         (WebCore::RenderBlock::paintContinuationOutlines):
3034         * rendering/RenderBlock.h:
3035         * rendering/RenderInline.cpp:
3036         (WebCore::RenderInline::paintOutline):
3037         (WebCore::RenderInline::paintOutlineForLine):
3038         * rendering/RenderInline.h:
3039         * rendering/RenderLineBoxList.cpp:
3040         (WebCore::RenderLineBoxList::paint):
3041
3042 2011-06-06  Emil A Eklund  <eae@chromium.org>
3043
3044         Reviewed by Eric Seidel.
3045
3046         Convert RenderBox::popContentsClip to IntPoint
3047         https://bugs.webkit.org/show_bug.cgi?id=62132
3048
3049         Covered by existing tests.
3050
3051         * rendering/RenderBlock.cpp:
3052         (WebCore::RenderBlock::paint):
3053         * rendering/RenderBox.cpp:
3054         (WebCore::RenderBox::popContentsClip):
3055         * rendering/RenderBox.h:
3056         * rendering/RenderTable.cpp:
3057         (WebCore::RenderTable::paint):
3058         * rendering/RenderTableSection.cpp:
3059         (WebCore::RenderTableSection::paint):
3060
3061 2011-06-06  Levi Weintraub  <leviw@chromium.org>
3062
3063         Reviewed by Eric Seidel.
3064
3065         Remove tx/ty offset from selectionRect
3066         https://bugs.webkit.org/show_bug.cgi?id=62146
3067
3068         Removing unused offset parameters from selectionRect.
3069
3070         No new tests since this is just cleanup.
3071
3072         * rendering/EllipsisBox.cpp:
3073         (WebCore::EllipsisBox::selectionRect):
3074         * rendering/EllipsisBox.h:
3075         * rendering/InlineTextBox.cpp:
3076         (WebCore::InlineTextBox::selectionRect):
3077         * rendering/InlineTextBox.h:
3078         * rendering/RenderText.cpp:
3079         (WebCore::RenderText::absoluteRectsForRange):
3080         (WebCore::ellipsisRectForBox):
3081         (WebCore::RenderText::absoluteQuadsForRange):
3082         (WebCore::RenderText::selectionRectForRepaint):
3083         * rendering/svg/RenderSVGInlineText.cpp:
3084         (WebCore::RenderSVGInlineText::localCaretRect):
3085         * rendering/svg/SVGInlineTextBox.cpp:
3086         (WebCore::SVGInlineTextBox::selectionRect):
3087         * rendering/svg/SVGInlineTextBox.h:
3088
3089 2011-06-06  Paul Kinlan  <paulkinlan@google.com>
3090
3091         Reviewed by Jeremy Orlow.
3092
3093         Let developers call createEvent("PopStateEvent"), previously it wasn't
3094         exposed and threw an exeception. 
3095         https://bugs.webkit.org/show_bug.cgi?id=62099
3096
3097         * WebCore/dom/Document.cpp:
3098         * WebCore/dom/PopStateEvent.cpp:
3099         * WebCore/dom/PopStateEvent.h:
3100
3101 2011-06-03  Levi Weintraub  <leviw@chromium.org>
3102
3103         Reviewed by Eric Seidel.
3104
3105         Switch paintSelection to use IntPoint
3106         https://bugs.webkit.org/show_bug.cgi?id=62059
3107
3108         Switching paintSelection to use an IntPoint to represent the paint offset
3109         instead of a pair of ints.
3110
3111         No new tests since this is simple refactoring.
3112
3113         * rendering/EllipsisBox.cpp:
3114         (WebCore::EllipsisBox::paint):
3115         (WebCore::EllipsisBox::paintSelection):
3116         * rendering/EllipsisBox.h:
3117         * rendering/RenderBlock.cpp:
3118         (WebCore::RenderBlock::paintObject):
3119         (WebCore::RenderBlock::paintSelection):
3120         * rendering/RenderBlock.h:
3121
3122 2011-06-06  Emil A Eklund  <eae@chromium.org>
3123
3124         Reviewed by Eric Seidel.
3125
3126         Convert RenderBox::clipRect to IntPoint
3127         https://bugs.webkit.org/show_bug.cgi?id=62045
3128
3129         Covered by existing tests.
3130
3131         * rendering/RenderBox.cpp:
3132         (WebCore::RenderBox::clipRect):
3133         * rendering/RenderBox.h:
3134         * rendering/RenderLayer.cpp:
3135         (WebCore::RenderLayer::calculateClipRects):
3136         (WebCore::RenderLayer::calculateRects):
3137         (WebCore::RenderLayer::repaintBlockSelectionGaps):
3138         * rendering/RenderLayerBacking.cpp:
3139         (WebCore::clipBox):
3140
3141 2011-06-06  Peter Kasting  <pkasting@google.com>
3142
3143         Reviewed by Antonio Gomes.
3144
3145         Remove unnecessary args from scroll functions.
3146         https://bugs.webkit.org/show_bug.cgi?id=61648
3147
3148         No behavior change, so no tests.
3149
3150         * WebCore.exp.in:
3151         * WebCore.order:
3152         * dom/Element.cpp:
3153         (WebCore::Element::scrollIntoView):
3154         (WebCore::Element::scrollIntoViewIfNeeded):
3155         * editing/FrameSelection.cpp:
3156         (WebCore::FrameSelection::revealSelection):
3157         * page/EventHandler.cpp:
3158         (WebCore::EventHandler::handleMousePressEvent):
3159         * page/FrameView.cpp:
3160         (WebCore::FrameView::scrollToAnchor):
3161         * rendering/RenderBox.cpp:
3162         (WebCore::RenderBox::canBeScrolledAndHasScrollableArea):
3163         (WebCore::RenderBox::canBeProgramaticallyScrolled):
3164         * rendering/RenderBox.h:
3165         * rendering/RenderLayer.cpp:
3166         (WebCore::RenderLayer::scrollRectToVisible):
3167         (WebCore::RenderLayer::autoscroll):
3168         * rendering/RenderLayer.h:
3169         * rendering/RenderListBox.h:
3170         (WebCore::RenderListBox::canBeProgramaticallyScrolled):
3171         * rendering/RenderTextControl.h:
3172         (WebCore::RenderTextControl::canBeProgramaticallyScrolled):
3173
3174 2011-06-06  Levi Weintraub  <leviw@chromium.org>
3175
3176         Reviewed by Eric Seidel.
3177
3178         Switch paintContents, paintColumnContents, paintColumnRules, and paintSelection to use IntPoint
3179         https://bugs.webkit.org/show_bug.cgi?id=62134
3180
3181         Switching paintContents, paintColumnContents, paintColumnRules, and paintSelection to take an
3182         IntPoint representing the paint offset instead of a pair of ints.
3183
3184         No new tests as this simple refactoring.
3185
3186         * rendering/RenderBlock.cpp:
3187         (WebCore::RenderBlock::paintColumnRules):
3188         (WebCore::RenderBlock::paintColumnContents):
3189         (WebCore::RenderBlock::paintContents):
3190         (WebCore::RenderBlock::paintObject):
3191         (WebCore::RenderBlock::paintSelection):
3192         * rendering/RenderBlock.h:
3193
3194 2011-06-06  Yael Aharon  <yael.aharon@nokia.com>
3195
3196         Reviewed by Eric Seidel.
3197
3198         Inline elements are wrapped prematurely with non-zero border, margin or padding.
3199         https://bugs.webkit.org/show_bug.cgi?id=60459
3200
3201         When an inline element has a right border/margin/padding and it has more than one descendant with no siblings,
3202         the width of the right border/margin/padding should be included in line breaking calculation only once,
3203         and not for each descendant.
3204
3205         Test: fast/inline/inline-wrap-with-parent-padding.html
3206
3207         * rendering/RenderBlockLineLayout.cpp:
3208         (WebCore::RenderBlock::LineBreaker::nextLineBreak):
3209
3210 2011-06-06  Shishir Agrawal  <shishir@chromium.org>
3211
3212         Reviewed by Tony Gentilcore.
3213
3214         Add a "prerender" state for page visibility.
3215         https://bugs.webkit.org/show_bug.cgi?id=62062
3216
3217         * page/PageVisibilityState.cpp:
3218         (WebCore::pageVisibilityStateString):
3219         * page/PageVisibilityState.h:
3220
3221 2011-06-06  Cary Clark  <caryclark@google.com>
3222
3223         Reviewed by Eric Seidel.
3224
3225         Fix typo in CachedFont.cpp #define
3226         https://bugs.webkit.org/show_bug.cgi?id=62127
3227
3228         No new tests. The define typo in question is
3229         not yet enabled, so this change has no functional
3230         impact.
3231
3232         * loader/cache/CachedFont.cpp:
3233         change SKIA_MAC_ON_CHROME to SKIA_ON_MAC_CHROME
3234
3235 2011-06-03  Levi Weintraub  <leviw@chromium.org>
3236
3237         Reviewed by Eric Seidel.
3238
3239         Switch paintFloats, paintChildren, and paintEllipsisBoxes to use IntPoint
3240         https://bugs.webkit.org/show_bug.cgi?id=62058
3241
3242         Switching paintFloats, paintChildren, and paintEllipsisBoxes to take IntPoints representing
3243         their paint offsets instead of pairs of ints.
3244
3245         No new tests since this is simple refactoring.
3246
3247         * rendering/RenderBlock.cpp:
3248         (WebCore::RenderBlock::paintColumnContents):
3249         (WebCore::RenderBlock::paintContents):
3250         (WebCore::RenderBlock::paintChildren):
3251         (WebCore::RenderBlock::paintObject):
3252         (WebCore::RenderBlock::paintFloats):
3253         (WebCore::RenderBlock::paintEllipsisBoxes):
3254         * rendering/RenderBlock.h:
3255
3256 2011-06-06  Steve Block  <steveblock@google.com>
3257
3258         Reviewed by Yury Semikhatsky.
3259
3260         Use of ENABLE(INSPECTOR) is inconsistent
3261         https://bugs.webkit.org/show_bug.cgi?id=62118
3262
3263         Correctly guard implementation of ScriptProfiler.
3264
3265         No new tests, build fix only.
3266
3267         * bindings/v8/ScriptProfiler.cpp:
3268         (WebCore::ScriptProfiler::initialize):
3269
3270 2011-06-04  Dominic Cooney  <dominicc@chromium.org>
3271
3272         Reviewed by Dimitri Glazkov.
3273
3274         Add WebCoreTestSupport project.
3275         https://bugs.webkit.org/show_bug.cgi?id=61076
3276
3277         * WebCore.vcproj/WebCoreCommon.vsprops:
3278         * WebCore.vcproj/WebCoreTestSupport.vcproj: Added.
3279         * WebCore.vcproj/copyForwardingHeaders.cmd: Copy WebCoreTestSupport.h.
3280
3281 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
3282
3283         Reviewed by Kent Tamura.
3284
3285         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
3286         https://bugs.webkit.org/show_bug.cgi?id=61628
3287
3288         This patch modifies only the build system. Therefore,
3289         there are no new tests.
3290
3291         * Configurations/FeatureDefines.xcconfig:
3292
3293 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
3294
3295         Reviewed by Kent Tamura.
3296
3297         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
3298         https://bugs.webkit.org/show_bug.cgi?id=61631
3299         
3300         This patch modifies only the build system. Therefore,
3301         there are no new tests.
3302
3303         * Configurations/FeatureDefines.xcconfig:
3304
3305 2011-06-03  Hans Wennborg  <hans@chromium.org>
3306
3307         Reviewed by Tony Gentilcore.
3308
3309         IndexedDB: Clean-up function prototypes in IDBLevelDBBackingStore.cpp
3310         https://bugs.webkit.org/show_bug.cgi?id=62013
3311
3312         Clean up the prototypes for cursor open functions by introducing the
3313         CursorOptions struct.
3314
3315         Just clean-up, no new functionality so no new tests.
3316
3317         * storage/IDBLevelDBBackingStore.cpp:
3318         (WebCore::CursorOptions::CursorImplCommon::CursorImplCommon):
3319         (WebCore::CursorOptions::CursorImplCommon::firstSeek):
3320         (WebCore::CursorOptions::CursorImplCommon::continueFunction):
3321         (WebCore::CursorOptions::ObjectStoreCursorImpl::create):
3322         (WebCore::CursorOptions::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
3323         (WebCore::CursorOptions::IndexKeyCursorImpl::create):
3324         (WebCore::CursorOptions::IndexKeyCursorImpl::IndexKeyCursorImpl):
3325         (WebCore::CursorOptions::IndexCursorImpl::create):
3326         (WebCore::CursorOptions::IndexCursorImpl::IndexCursorImpl):
3327         (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
3328         (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
3329         (WebCore::IDBLevelDBBackingStore::openIndexCursor):
3330
3331 2011-06-06  Mustafizur Rahaman  <mustaf.here@gmail.com>
3332
3333         Reviewed by Darin Adler.
3334
3335         Fix LayoutTests/canvas/philip/tests/2d.composite.operation.highlight.html
3336         https://bugs.webkit.org/show_bug.cgi?id=48290
3337         
3338         "highlight" is not a valid globalComposite operation
3339         as per http://www.w3.org/TR/2011/WD-2dcontext-20110525/#compositing
3340         Therefore, removed the option from the source code.
3341         
3342         Tests: No new tests required.
3343         LayoutTests\canvas\philip\tests\2d.composite.operation.highlight.html can be used for testing.
3344
3345         * css/CSSPrimitiveValueMappings.h:
3346         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
3347         (WebCore::CSSPrimitiveValue::operator CompositeOperator):
3348         * platform/graphics/GraphicsTypes.cpp:
3349         * platform/graphics/GraphicsTypes.h:
3350         * platform/graphics/cairo/CairoUtilities.cpp:
3351         (WebCore::toCairoOperator):
3352         * platform/graphics/cg/GraphicsContextCG.cpp:
3353         (WebCore::GraphicsContext::setPlatformCompositeOperation):
3354         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
3355         (WebCore::SharedGraphicsContext3D::applyCompositeOperator):
3356         * platform/graphics/openvg/PainterOpenVG.cpp:
3357         (WebCore::PlatformPainterState::applyBlending):
3358         * platform/graphics/qt/GraphicsContextQt.cpp:
3359         (WebCore::toQtCompositionMode):
3360         * platform/graphics/skia/SkiaUtils.cpp:
3361
3362 2011-06-04  Abhishek Arya  <inferno@chromium.org>
3363
3364         Reviewed by Kent Tamura.
3365
3366         Add some asserts for array boundary checks in TextRun. Fix
3367         an integer issue in linux text controller code.
3368         https://bugs.webkit.org/show_bug.cgi?id=62085
3369
3370         Testing ComplexTextControllerLinux change requires a testcase
3371         > 32 kb which is not feasible. All other changes are tested by
3372         existing layouttests.
3373
3374         * platform/graphics/TextRun.h:
3375         (WebCore::TextRun::operator[]): add assert.
3376         (WebCore::TextRun::data): add assert.
3377         * platform/graphics/WidthIterator.cpp:
3378         (WebCore::WidthIterator::advance): bail early and prevent access
3379         to one byte across the text run boundary.
3380         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
3381         (WebCore::ComplexTextController::getNormalizedTextRun): wrong
3382         int16 vs int comparison.
3383         * rendering/svg/SVGTextRunRenderingContext.cpp:
3384         (WebCore::SVGTextRunWalker::walk): bail early when from and to
3385         is outside the text run boundary. this hit easily after adding
3386         the assert when from = to = end and read in run.data(from). 
3387
3388 2011-06-05  Kent Tamura  <tkent@chromium.org>
3389
3390         Reviewed by Dimitri Glazkov.
3391
3392         Rolling out r84528.
3393         http://trac.webkit.org/changeset/84528
3394         https://bugs.webkit.org/show_bug.cgi?id=62100
3395
3396         It made several problems on elements with new shadow DOM.
3397
3398         * dom/Element.cpp:
3399         (WebCore::Element::copyNonAttributeProperties):
3400
3401 2011-06-05  Igor Oliveira  <igor.oliveira@openbossa.org>
3402
3403         Reviewed by Kenneth Rohde Christiansen.
3404
3405         fast/viewport/viewport-45.html fails in GTK+/Qt
3406         https://bugs.webkit.org/show_bug.cgi?id=47481
3407
3408         computeViewportAttributes does many math operations with float point arithmetic
3409         and in some cases there is loss of precision making tests have incorrect values.
3410
3411         * dom/ViewportArguments.cpp:
3412         (WebCore::computeViewportAttributes):
3413
3414 == Rolled over to ChangeLog-2011-06-04 ==