<rdar://problem/9737435> Re-enable -webkit-column-break-inside: avoid
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-07-07  Dan Bernstein  <mitz@apple.com>
2
3         <rdar://problem/9737435> Re-enable -webkit-column-break-inside: avoid
4         https://bugs.webkit.org/show_bug.cgi?id=64102
5
6         Reviewed by Simon Fraser.
7
8         * rendering/RenderBlock.cpp:
9         (WebCore::RenderBlock::adjustForUnsplittableChild): Treat the child as unsplittable if
10         '-webkit-column-break-inside: avoid' was specified.
11
12 2011-07-07  Andrey Kosyakov  <caseq@chromium.org>
13
14         Web Inspector: visual regressions in network panel
15         https://bugs.webkit.org/show_bug.cgi?id=64089
16
17         Reviewed by Pavel Feldman.
18
19         * inspector/front-end/networkPanel.css:
20         (.data-grid.network-log-grid tr.filler td):
21         (.network.panel .sidebar):
22
23 2011-07-07  Julien Chaffraix  <jchaffraix@webkit.org>
24
25         Reviewed by David Hyatt.
26
27         Partial layout when a flex-box has visibility: collapse
28         https://bugs.webkit.org/show_bug.cgi?id=63776
29
30         Tests: fast/flexbox/crash-button-input-autofocus.html
31                fast/flexbox/crash-button-keygen.html
32                fast/flexbox/crash-button-relayout.html
33
34         The issue is that FlexBoxIterator would skip any child if it has visibility: collapsed.
35         However if one of the child is anonymous, it may wrap some other child that would be skipped.
36         Now FlexBoxIterator is called during the layout phase and thus some nodes would not relayouted
37         as expected.
38
39         * rendering/RenderDeprecatedFlexibleBox.cpp:
40         (WebCore::FlexBoxIterator::next): When iterating, don't skip anonymous content as there may
41         be real content hiding below.
42
43 2011-07-07  Vsevolod Vlasov  <vsevik@chromium.org>
44
45         Web Inspector: URL links in styles open new tab instead of showing resources panel.
46         https://bugs.webkit.org/show_bug.cgi?id=64090
47
48         Reviewed by Pavel Feldman.
49
50         * inspector/front-end/StylesSidebarPane.js:
51         (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
52
53 2011-07-07  Andrey Kosyakov  <caseq@chromium.org>
54
55         Web Inspector: active panel does not receive resize event when drawer is resized
56         https://bugs.webkit.org/show_bug.cgi?id=64094
57
58         Reviewed by Pavel Feldman.
59
60         * inspector/front-end/Drawer.js:
61         (WebInspector.Drawer.prototype._statusBarDragging):
62
63 2011-07-07  Pavel Feldman  <pfeldman@chromium.org>
64
65         Web Inspector: prevent default action during drag'n'drop in the Elements panel.
66         https://bugs.webkit.org/show_bug.cgi?id=64081
67
68         Reviewed by Yury Semikhatsky.
69
70         * inspector/front-end/ElementsTreeOutline.js:
71         (WebInspector.ElementsTreeOutline):
72         (WebInspector.ElementsTreeOutline.prototype._ondragstart):
73         (WebInspector.ElementsTreeOutline.prototype._ondragover):
74         (WebInspector.ElementsTreeOutline.prototype._ondragend):
75         * inspector/front-end/treeoutline.js:
76         (TreeOutline.prototype.treeElementFromPoint):
77
78 2011-07-07  Nikolas Zimmermann  <nzimmermann@rim.com>
79
80         Move remaining enums out of SVG*Element classes
81         https://bugs.webkit.org/show_bug.cgi?id=64075
82
83         Reviewed by Dirk Schulze.
84
85         Move remaining enums out of SVG*Element classes. This is a preparation patch for bug 63797.
86         Also move the SVGPropertyTraits template specializations for enum types before the class
87         definition in the header, otherwhise we can't use SVGPropertyTraits<FooType>::fromString/toString
88         in the DECLARE_ANIMATED* macros, which is needed soon.
89
90         No new tests, just refactoring.
91
92         * rendering/svg/RenderSVGResourceGradient.cpp:
93         (WebCore::RenderSVGResourceGradient::applyResource):
94         * rendering/svg/RenderSVGResourceGradient.h:
95         * rendering/svg/RenderSVGResourceMarker.cpp:
96         (WebCore::RenderSVGResourceMarker::angle):
97         (WebCore::RenderSVGResourceMarker::markerTransformation):
98         * rendering/svg/RenderSVGResourceMarker.h:
99         (WebCore::RenderSVGResourceMarker::markerUnits):
100         * rendering/svg/RenderSVGTextPath.cpp:
101         (WebCore::RenderSVGTextPath::RenderSVGTextPath):
102         (WebCore::RenderSVGTextPath::exactAlignment):
103         (WebCore::RenderSVGTextPath::stretchMethod):
104         * rendering/svg/SVGRenderTreeAsText.cpp:
105         (WebCore::operator<<):
106         (WebCore::writeCommonGradientProperties):
107         * rendering/svg/SVGTextChunkBuilder.cpp:
108         (WebCore::SVGTextChunkBuilder::addTextChunk):
109         * rendering/svg/SVGTextLayoutEngine.cpp:
110         (WebCore::SVGTextLayoutEngine::parentDefinesTextLength):
111         (WebCore::SVGTextLayoutEngine::beginTextPathLayout):
112         * svg/GradientAttributes.h:
113         (WebCore::GradientAttributes::GradientAttributes):
114         (WebCore::GradientAttributes::spreadMethod):
115         (WebCore::GradientAttributes::setSpreadMethod):
116         * svg/SVGComponentTransferFunctionElement.h:
117         * svg/SVGFEBlendElement.h:
118         * svg/SVGFEColorMatrixElement.h:
119         * svg/SVGFECompositeElement.h:
120         * svg/SVGFEConvolveMatrixElement.h:
121         * svg/SVGFEDisplacementMapElement.h:
122         * svg/SVGFEMorphologyElement.h:
123         * svg/SVGFETurbulenceElement.h:
124         * svg/SVGGradientElement.cpp:
125         (WebCore::SVGGradientElement::SVGGradientElement):
126         * svg/SVGGradientElement.h:
127         * svg/SVGMarkerElement.cpp:
128         (WebCore::SVGMarkerElement::SVGMarkerElement):
129         (WebCore::SVGMarkerElement::parseMappedAttribute):
130         (WebCore::SVGMarkerElement::setOrientToAuto):
131         (WebCore::SVGMarkerElement::setOrientToAngle):
132         (WebCore::SVGMarkerElement::synchronizeOrientType):
133         (WebCore::SVGMarkerElement::orientTypeAnimated):
134         * svg/SVGMarkerElement.h:
135         * svg/SVGTextContentElement.cpp:
136         (WebCore::SVGTextContentElement::SVGTextContentElement):
137         * svg/SVGTextContentElement.h:
138         * svg/SVGTextPathElement.cpp:
139         (WebCore::SVGTextPathElement::SVGTextPathElement):
140         * svg/SVGTextPathElement.h:
141
142 2011-07-07  Ilya Tikhonovsky  <loislo@chromium.org>
143
144         Web Inspector: Protocol: pointers to optional "in" parameters passing to the
145         backend methods should be NULL if they are not specified in the message.
146         https://bugs.webkit.org/show_bug.cgi?id=64083
147
148         Reviewed by Pavel Feldman.
149
150         * inspector/CodeGeneratorInspector.pm:
151         (generateBackendFunction):
152         (generateArgumentGetters):
153         * inspector/InspectorCSSAgent.cpp:
154         (WebCore::InspectorCSSAgent::getStylesForNode):
155
156 2011-07-07  Ilya Tikhonovsky  <loislo@chromium.org>
157
158         Web Inspector: Searching on the Network panel doesn't do anything?
159         https://bugs.webkit.org/show_bug.cgi?id=55489
160
161         This is initial implementation of search in Network panel.
162         It is pretty simple search only for names and paths.
163
164         Reviewed by Pavel Feldman.
165
166         * inspector/front-end/NetworkPanel.js:
167         (WebInspector.NetworkPanel.prototype.refresh):
168         (WebInspector.NetworkPanel.prototype._reset):
169         (WebInspector.NetworkPanel.prototype._updateOffscreenRows):
170         (WebInspector.NetworkPanel.prototype._matchResource):
171         (WebInspector.NetworkPanel.prototype._clearSearchMatchedList):
172         (WebInspector.NetworkPanel.prototype._highlightNthMatchedResource):
173         (WebInspector.NetworkPanel.prototype.performSearch):
174         (WebInspector.NetworkDataGridNode.prototype.createCells):
175         * inspector/front-end/utilities.js:
176         (String.prototype.escapeHTML):
177         ():
178
179 2011-07-07  Vsevolod Vlasov  <vsevik@chromium.org>
180
181         Web Inspector: Resources panel shows only one resource when multiple resources have the same url.
182         https://bugs.webkit.org/show_bug.cgi?id=63936
183
184         Reviewed by Pavel Feldman.
185
186         Test: http/tests/inspector/resource-tree/resource-tree-non-unique-url.html
187
188         * inspector/front-end/ResourcesPanel.js:
189         (WebInspector.FrameTreeElement.prototype.appendResource):
190
191 2011-07-07  Vsevolod Vlasov  <vsevik@chromium.org>
192
193         Web Inspector: Add support for clearing cache and cookies from network panel.
194         https://bugs.webkit.org/show_bug.cgi?id=63999
195
196         Reviewed by Pavel Feldman.
197
198         * English.lproj/localizedStrings.js:
199         * inspector/Inspector.json:
200         * inspector/InspectorClient.h:
201         (WebCore::InspectorClient::clearBrowserCache):
202         (WebCore::InspectorClient::clearBrowserCookies):
203         * inspector/InspectorController.cpp:
204         (WebCore::InspectorController::InspectorController):
205         * inspector/InspectorResourceAgent.cpp:
206         (WebCore::InspectorResourceAgent::clearBrowserCache):
207         (WebCore::InspectorResourceAgent::clearBrowserCookies):
208         (WebCore::InspectorResourceAgent::InspectorResourceAgent):
209         * inspector/InspectorResourceAgent.h:
210         (WebCore::InspectorResourceAgent::create):
211         * inspector/front-end/NetworkPanel.js:
212         (WebInspector.NetworkPanel.prototype._contextMenu):
213         (WebInspector.NetworkPanel.prototype._clearBrowserCache):
214         (WebInspector.NetworkPanel.prototype._clearBrowserCookies):
215         * inspector/front-end/Settings.js:
216
217 2011-07-07  Shinya Kawanaka  <shinyak@google.com>
218
219         Added more key bindings for input[type=range].
220         https://bugs.webkit.org/show_bug.cgi?id=52262
221
222         Added PageUp/PageDown/Home/End key bindings for input[type=range].
223         PageUp/PageDown change value by about 10%.
224         Home/End change value to minimum/maximum.
225
226         Reviewed by Kent Tamura.
227
228         * html/RangeInputType.cpp:
229         (WebCore::RangeInputType::handleKeydownEvent):
230           Added key bindings.
231
232 2011-07-07  Oleg Romashin  <romaxa@gmail.com>
233
234         Fix InspectorInstrumentation compilation.
235         https://bugs.webkit.org/show_bug.cgi?id=64033
236
237         Reviewed by Yury Semikhatsky.
238
239         No new tests. just compile fix.
240
241         * inspector/InspectorInstrumentation.cpp:
242         (WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl):
243
244 2011-07-06  Mihnea Ovidenie  <mihnea@adobe.com>
245
246         Reviewed by David Hyatt.
247
248         [CSSRegions] Parse flow property
249         https://bugs.webkit.org/show_bug.cgi?id=61730
250
251         Test: fast/regions/webkit-flow-parsing.html
252
253         * css/CSSComputedStyleDeclaration.cpp:
254         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
255         * css/CSSParser.cpp:
256         (WebCore::CSSParser::parseValue):
257         (WebCore::CSSParser::parseFlowThread):
258         * css/CSSParser.h:
259         * css/CSSPropertyNames.in:
260         * css/CSSStyleSelector.cpp:
261         (WebCore::CSSStyleSelector::applyProperty):
262         * rendering/style/RenderStyle.cpp:
263         (WebCore::RenderStyle::diff):
264         * rendering/style/RenderStyle.h:
265         (WebCore::InheritedFlags::flowThread):
266         (WebCore::InheritedFlags::setFlowThread):
267         (WebCore::InheritedFlags::initialFlowThread):
268         * rendering/style/StyleRareNonInheritedData.cpp:
269         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
270         (WebCore::StyleRareNonInheritedData::operator==):
271         * rendering/style/StyleRareNonInheritedData.h:
272
273 2011-07-06  MORITA Hajime  <morrita@google.com>
274
275         [ShadowContentElement] Redundant RenderText objects are created on the content boundaries.
276         https://bugs.webkit.org/show_bug.cgi?id=63977
277
278         Reviewed by Dimitri Glazkov.
279
280         NodeRenderingContext::nextRenderer() and previousRenderer() didn't work well
281         when it crosses content elements:
282         - It doesn't step into forwarded children of ShadowContentElement.
283         - It doesn't step out from traversing forwarded children to
284           neighbors of the content element of that forwarded chidren.
285         
286         This change makes it to step into and out from content element.
287         
288         Test: fast/dom/shadow/content-element-renderers.html
289
290         * dom/NodeRenderingContext.cpp:
291         (WebCore::firstRendererOf): Added
292         (WebCore::lastRendererOf): Added
293         (WebCore::NodeRenderingContext::nextRenderer):
294         (WebCore::NodeRenderingContext::previousRenderer):
295
296 2011-07-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
297
298         [EFL] Add Fullscreen API feature
299         https://bugs.webkit.org/show_bug.cgi?id=63975
300
301         Add needed files for enabling ENABLE_FULLSCREEN_API feature.
302
303         Reviewed by Adam Barth.
304
305         * CMakeLists.txt: Add RenderFullScreen.cpp, fullscreen.css
306
307 2011-07-06  Emil A Eklund  <eae@chromium.org>
308
309         Switch absoluteRects to to new layout types
310         https://bugs.webkit.org/show_bug.cgi?id=64035
311
312         Reviewed by Eric Seidel.
313
314         Move absoluteRects over to new layout unit abstraction.
315         Add flooredLayoutPoint, mapped to flooredIntPoint.
316
317         No new tests, no functionality changes.
318
319         * rendering/LayoutTypes.h:
320         (WebCore::flooredLayoutPoint):
321         * rendering/RenderBlock.cpp:
322         (WebCore::RenderBlock::absoluteRects):
323         * rendering/RenderBlock.h:
324         * rendering/RenderBox.cpp:
325         (WebCore::RenderBox::absoluteRects):
326         * rendering/RenderInline.cpp:
327         (WebCore::RenderInline::absoluteRects):
328         * rendering/RenderInline.h:
329         * rendering/RenderObject.cpp:
330         (WebCore::RenderObject::absoluteBoundingBoxRect):
331         * rendering/RenderObject.h:
332         (WebCore::RenderObject::absoluteRects):
333         * rendering/RenderText.cpp:
334         (WebCore::RenderText::absoluteRects):
335         * rendering/RenderText.h:
336         * rendering/RenderView.cpp:
337         (WebCore::RenderView::absoluteRects):
338         * rendering/RenderView.h:
339         * rendering/svg/RenderSVGBlock.cpp:
340         (WebCore::RenderSVGBlock::absoluteRects):
341         * rendering/svg/RenderSVGBlock.h:
342         * rendering/svg/RenderSVGModelObject.cpp:
343         (WebCore::RenderSVGModelObject::absoluteRects):
344         * rendering/svg/RenderSVGModelObject.h:
345
346 2011-07-06  Emil A Eklund  <eae@chromium.org>
347
348         Reviewed by Eric Seidel.
349
350         Switch offsetFromContainer and related to to new layout types
351         https://bugs.webkit.org/show_bug.cgi?id=63659
352
353         Switch offsetFromContainer and related mapping methods to new layout unit
354         abstraction.
355
356         No new tests, no functionality changes.
357
358         * rendering/LayoutTypes.h:
359         (WebCore::enclosingLayoutRect):
360         (WebCore::roundedLayoutPoint):
361         (WebCore::roundedLayoutUnit):
362         Add LayoutUnit versions of enclosingIntRect, roundedIntPoint and lroundf.
363         For now these map to their int counterpart but once we switch to float or
364         fixed point they'll be no-ops and eventually will be removed. 
365         
366         * rendering/RenderBox.cpp:
367         (WebCore::RenderBox::mapLocalToContainer):
368         (WebCore::RenderBox::mapAbsoluteToLocalPoint):
369         (WebCore::RenderBox::offsetFromContainer):
370         * rendering/RenderBox.h:
371         * rendering/RenderInline.cpp:
372         (WebCore::RenderInline::linesBoundingBox):
373         (WebCore::RenderInline::offsetFromContainer):
374         (WebCore::RenderInline::mapLocalToContainer):
375         (WebCore::RenderInline::mapAbsoluteToLocalPoint):
376         (WebCore::RenderInline::relativePositionedInlineOffset):
377         * rendering/RenderInline.h:
378         * rendering/RenderObject.cpp:
379         (WebCore::RenderObject::offsetFromContainer):
380         (WebCore::RenderObject::offsetFromAncestorContainer):
381         * rendering/RenderObject.h:
382         * rendering/RenderTableCell.cpp:
383         (WebCore::RenderTableCell::offsetFromContainer):
384         * rendering/RenderTableCell.h:
385         * rendering/RenderThemeMac.mm:
386         (WebCore::RenderThemeMac::convertToPaintingRect):
387
388 2011-07-06  Levi Weintraub  <leviw@chromium.org>
389
390         Switch FrameSelection to new Layout Types
391         https://bugs.webkit.org/show_bug.cgi?id=64043
392
393         Reviewed by Eric Seidel.
394
395         Switching the selection classes to the new layout types. Changing
396         NoXPosForVerticalArrowNavigation to a static inline since as it stood it violated
397         our global initializer rule when converted to numeric_limits from INT_MIN.
398
399         No new tests, no functionality changes.
400
401         * editing/FrameSelection.cpp:
402         (WebCore::FrameSelection::modify):
403         (WebCore::absoluteCaretY):
404         (WebCore::FrameSelection::lineDirectionPointForBlockDirectionNavigation):
405         (WebCore::CaretBase::clearCaretRect):
406         (WebCore::CaretBase::updateCaretRect):
407         (WebCore::FrameSelection::localCaretRect):
408         (WebCore::CaretBase::absoluteBoundsForLocalRect):
409         (WebCore::FrameSelection::absoluteCaretBounds):
410         (WebCore::repaintRectForCaret):
411         (WebCore::CaretBase::caretRepaintRect):
412         (WebCore::FrameSelection::recomputeCaretRect):
413         (WebCore::FrameSelection::paintCaret):
414         (WebCore::CaretBase::paintCaret):
415         (WebCore::FrameSelection::contains):
416         (WebCore::DragCaretController::paintDragCaret):
417         (WebCore::FrameSelection::bounds):
418         (WebCore::FrameSelection::revealSelection):
419         * editing/FrameSelection.h:
420         (WebCore::CaretBase::localCaretRectWithoutUpdate):
421
422 2011-07-06  Levi Weintraub  <leviw@chromium.org>
423
424         Switch Overflow and FrameRect methods in InlineBox to Layout Units
425         https://bugs.webkit.org/show_bug.cgi?id=64034
426
427         Reviewed by Eric Seidel.
428
429         Switching Overflow and FrameRect methods on InlineBox to new Layout Unit abstraction and
430         cleaning up some compilation errors that crop up when building with floating point layout units.
431
432         No new tests, no functionality changes.
433
434         * css/CSSComputedStyleDeclaration.cpp:
435         (WebCore::sizingBox):
436         * dom/Document.h:
437         * editing/DeleteButtonController.cpp:
438         (WebCore::isDeletableElement):
439         * inspector/DOMNodeHighlighter.cpp:
440         (WebCore::DOMNodeHighlighter::drawNodeHighlight):
441         * page/animation/AnimationBase.cpp:
442         (WebCore::blendFunc):
443         * platform/ScrollView.h:
444         (WebCore::ScrollView::visibleWidth):
445         (WebCore::ScrollView::visibleHeight):
446         * platform/ScrollableArea.h:
447         (WebCore::ScrollableArea::visibleHeight):
448         (WebCore::ScrollableArea::visibleWidth):
449         * platform/graphics/FloatPoint.h: Adding FloatPoint and FloatSize move[By] functions
450         (WebCore::FloatPoint::move):
451         (WebCore::FloatPoint::moveBy):
452         * rendering/AutoTableLayout.cpp:
453         (WebCore::AutoTableLayout::computePreferredLogicalWidths):
454         (WebCore::AutoTableLayout::layout):
455         * rendering/InlineFlowBox.h:
456         (WebCore::InlineFlowBox::layoutOverflowRect):
457         (WebCore::InlineFlowBox::logicalLeftLayoutOverflow):
458         (WebCore::InlineFlowBox::logicalRightLayoutOverflow):
459         (WebCore::InlineFlowBox::logicalTopLayoutOverflow):
460         (WebCore::InlineFlowBox::logicalBottomLayoutOverflow):
461         (WebCore::InlineFlowBox::logicalLayoutOverflowRect):
462         (WebCore::InlineFlowBox::visualOverflowRect):
463         (WebCore::InlineFlowBox::logicalLeftVisualOverflow):
464         (WebCore::InlineFlowBox::logicalRightVisualOverflow):
465         (WebCore::InlineFlowBox::logicalTopVisualOverflow):
466         (WebCore::InlineFlowBox::logicalBottomVisualOverflow):
467         (WebCore::InlineFlowBox::logicalVisualOverflowRect):
468         (WebCore::InlineFlowBox::frameRectIncludingLineHeight):
469         (WebCore::InlineFlowBox::logicalFrameRectIncludingLineHeight):
470         * rendering/RenderBlock.h:
471         (WebCore::RenderBlock::RenderBlockRareData::positiveMarginBeforeDefault):
472         (WebCore::RenderBlock::RenderBlockRareData::negativeMarginBeforeDefault):
473         (WebCore::RenderBlock::RenderBlockRareData::positiveMarginAfterDefault):
474         (WebCore::RenderBlock::RenderBlockRareData::negativeMarginAfterDefault):
475
476 2011-07-06  Emil A Eklund  <eae@chromium.org>
477
478         Reviewed by Eric Seidel.
479         
480         Switch nodeAtPoint to to new layout types
481         https://bugs.webkit.org/show_bug.cgi?id=63663
482
483         No new tests, no functionality changes.
484
485         * rendering/EllipsisBox.cpp:
486         (WebCore::EllipsisBox::nodeAtPoint):
487         * rendering/EllipsisBox.h:
488         * rendering/InlineBox.cpp:
489         (WebCore::InlineBox::nodeAtPoint):
490         * rendering/InlineBox.h:
491         * rendering/InlineFlowBox.cpp:
492         (WebCore::InlineFlowBox::nodeAtPoint):
493         * rendering/InlineFlowBox.h:
494         * rendering/InlineTextBox.cpp:
495         (WebCore::InlineTextBox::nodeAtPoint):
496         * rendering/InlineTextBox.h:
497         * rendering/LayoutTypes.h:
498         (WebCore::toLayoutSize):
499         (WebCore::toLayoutPoint):
500         (WebCore::roundedLayoutPoint):
501         (WebCore::roundedLayoutUnit):
502         * rendering/RenderBlock.cpp:
503         (WebCore::RenderBlock::nodeAtPoint):
504         * rendering/RenderBlock.h:
505         * rendering/RenderBox.cpp:
506         (WebCore::RenderBox::nodeAtPoint):
507         * rendering/RenderBox.h:
508         * rendering/RenderFrameSet.cpp:
509         (WebCore::RenderFrameSet::nodeAtPoint):
510         * rendering/RenderFrameSet.h:
511         * rendering/RenderImage.cpp:
512         (WebCore::RenderImage::nodeAtPoint):
513         * rendering/RenderImage.h:
514         * rendering/RenderInline.cpp:
515         (WebCore::RenderInline::nodeAtPoint):
516         * rendering/RenderInline.h:
517         * rendering/RenderListBox.cpp:
518         (WebCore::RenderListBox::nodeAtPoint):
519         * rendering/RenderListBox.h:
520         * rendering/RenderObject.cpp:
521         (WebCore::RenderObject::nodeAtPoint):
522         * rendering/RenderObject.h:
523         * rendering/RenderTable.cpp:
524         (WebCore::RenderTable::nodeAtPoint):
525         * rendering/RenderTable.h:
526         * rendering/RenderTableRow.cpp:
527         (WebCore::RenderTableRow::nodeAtPoint):
528         * rendering/RenderTableRow.h:
529         * rendering/RenderTableSection.cpp:
530         (WebCore::RenderTableSection::nodeAtPoint):
531         * rendering/RenderTableSection.h:
532         * rendering/RenderText.h:
533         (WebCore::RenderText::nodeAtPoint):
534         * rendering/RenderTextControlMultiLine.cpp:
535         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
536         * rendering/RenderTextControlMultiLine.h:
537         * rendering/RenderTextControlSingleLine.cpp:
538         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
539         * rendering/RenderTextControlSingleLine.h:
540         * rendering/RenderWidget.cpp:
541         (WebCore::RenderWidget::nodeAtPoint):
542         * rendering/RenderWidget.h:
543         * rendering/RootInlineBox.cpp:
544         (WebCore::RootInlineBox::nodeAtPoint):
545         * rendering/RootInlineBox.h:
546         * rendering/svg/RenderSVGForeignObject.cpp:
547         (WebCore::RenderSVGForeignObject::nodeAtFloatPoint):
548         (WebCore::RenderSVGForeignObject::nodeAtPoint):
549         * rendering/svg/RenderSVGForeignObject.h:
550         * rendering/svg/RenderSVGModelObject.cpp:
551         (WebCore::RenderSVGModelObject::nodeAtPoint):
552         * rendering/svg/RenderSVGModelObject.h:
553         * rendering/svg/RenderSVGRoot.cpp:
554         (WebCore::RenderSVGRoot::nodeAtPoint):
555         * rendering/svg/RenderSVGRoot.h:
556         * rendering/svg/RenderSVGText.cpp:
557         (WebCore::RenderSVGText::nodeAtPoint):
558         * rendering/svg/RenderSVGText.h:
559         * rendering/svg/SVGInlineTextBox.cpp:
560         (WebCore::SVGInlineTextBox::nodeAtPoint):
561         * rendering/svg/SVGInlineTextBox.h:
562
563 2011-07-06  Adrienne Walker  <enne@google.com>
564
565         [chromium] Add compositor texture manager soft limits and lost focus reclaiming
566         https://bugs.webkit.org/show_bug.cgi?id=64009
567
568         Reviewed by James Robinson.
569
570         Add a soft limit for texture memory. Unprotected textures will get
571         reclaimed when above this limit. Increase the hard limit for maximum
572         texture memory as well, now that there is a better heuristic and
573         textures are reclaimed from tabs without focus.
574
575         Landing this for vangelis@chromium.org.
576
577         * platform/graphics/chromium/LayerRendererChromium.cpp:
578         (WebCore::LayerRendererChromium::releaseTextures):
579         (WebCore::LayerRendererChromium::initializeSharedObjects):
580         * platform/graphics/chromium/LayerRendererChromium.h:
581         * platform/graphics/chromium/LayerTilerChromium.cpp:
582         (WebCore::LayerTilerChromium::protectTileTextures):
583         * platform/graphics/chromium/LayerTilerChromium.h:
584         * platform/graphics/chromium/TextureManager.cpp:
585         (WebCore::TextureManager::TextureManager):
586         (WebCore::TextureManager::requestTexture):
587         * platform/graphics/chromium/TextureManager.h:
588         (WebCore::TextureManager::create):
589
590 2011-07-06  Pavel Feldman  <pfeldman@chromium.org>
591
592         Not reviewed: Web Inspector: fixing typo introduced in the r90397.
593
594         * inspector/front-end/StylesSidebarPane.js:
595
596 2011-07-06  Mike Reed  <reed@google.com>
597
598         [skia] don't include deprecated header
599         https://bugs.webkit.org/show_bug.cgi?id=64025
600
601         Reviewed by James Robinson.
602
603         No new tests. Just removing #include of an unused header that will be gone soon
604
605         * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
606         * platform/graphics/skia/PlatformContextSkia.cpp:
607
608 2011-06-30  Cris Neckar  <cdn@chromium.org>
609
610         Reviewed by Darin Fisher.
611
612         Add versioning to Chromium clipboard and prevent polling from inside events.
613         https://bugs.webkit.org/show_bug.cgi?id=63738
614
615         * platform/chromium/ChromiumDataObject.cpp:
616         (WebCore::ChromiumDataObject::getSequenceNumber):
617         * platform/chromium/ChromiumDataObject.h:
618         * platform/chromium/ClipboardChromium.cpp:
619         (WebCore::ClipboardChromium::ClipboardChromium):
620         (WebCore::ClipboardChromium::getData):
621         (WebCore::ClipboardChromium::platformClipboardChanged):
622         * platform/chromium/ClipboardChromium.h:
623         * platform/chromium/DataTransferItemChromium.cpp:
624         (WebCore::DataTransferItemChromium::getAsString):
625         (WebCore::DataTransferItemChromium::getAsFile):
626         * platform/chromium/PlatformBridge.h:
627         * svg/SVGAnimationElement.cpp:
628         (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
629
630 2011-07-01  James Robinson  <jamesr@chromium.org>
631
632         Reviewed by Stephen White.
633
634         [chromium] Externalize layer visibility calculation
635         https://bugs.webkit.org/show_bug.cgi?id=63847
636
637         This moves the layer visibility calculation from the layer itself out to LayerRendererChromium, like the other
638         calculated properties.  Previously, we were doing this calculating at paint time and again at draw time and
639         relying on the fact that this produced the same value.  This avoids the redundant calculation.
640
641         Covered by existing compositing/ layout tests.
642
643         * platform/graphics/chromium/ContentLayerChromium.cpp:
644         (WebCore::ContentLayerChromium::ContentLayerChromium):
645         (WebCore::ContentLayerChromium::paintContentsIfDirty):
646         (WebCore::ContentLayerChromium::tilingTransform):
647         (WebCore::ContentLayerChromium::contentBounds):
648         (WebCore::ContentLayerChromium::updateLayerSize):
649         (WebCore::ContentLayerChromium::draw):
650         (WebCore::ContentLayerChromium::setTilingOption):
651         (WebCore::ContentLayerChromium::setIsMask):
652         * platform/graphics/chromium/ContentLayerChromium.h:
653         * platform/graphics/chromium/ImageLayerChromium.cpp:
654         (WebCore::ImageLayerChromium::paintContentsIfDirty):
655         (WebCore::ImageLayerChromium::contentBounds):
656         * platform/graphics/chromium/ImageLayerChromium.h:
657         * platform/graphics/chromium/LayerChromium.cpp:
658         (WebCore::LayerChromium::pushPropertiesTo):
659         * platform/graphics/chromium/LayerChromium.h:
660         (WebCore::LayerChromium::contentBounds):
661         (WebCore::LayerChromium::visibleLayerRect):
662         (WebCore::LayerChromium::setVisibleLayerRect):
663         (WebCore::LayerChromium::draw):
664         * platform/graphics/chromium/LayerRendererChromium.cpp:
665         (WebCore::calculateVisibleLayerRect):
666         (WebCore::LayerRendererChromium::paintLayerContents):
667         (WebCore::LayerRendererChromium::drawLayer):
668         * platform/graphics/chromium/RenderSurfaceChromium.cpp:
669         (WebCore::RenderSurfaceChromium::draw):
670         * platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
671         (WebCore::CCCanvasLayerImpl::draw):
672         * platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
673         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
674         (WebCore::CCLayerImpl::draw):
675         * platform/graphics/chromium/cc/CCLayerImpl.h:
676         (WebCore::CCLayerImpl::contentBounds):
677         (WebCore::CCLayerImpl::setContentBounds):
678         (WebCore::CCLayerImpl::visibleLayerRect):
679         (WebCore::CCLayerImpl::setVisibleLayerRect):
680         (WebCore::CCLayerImpl::doubleSided):
681         (WebCore::CCLayerImpl::setDoubleSided):
682         * platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
683         (WebCore::CCPluginLayerImpl::draw):
684         * platform/graphics/chromium/cc/CCPluginLayerImpl.h:
685         * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
686         (WebCore::CCVideoLayerImpl::draw):
687         * platform/graphics/chromium/cc/CCVideoLayerImpl.h:
688
689 2011-07-06  John Sullivan  <sullivan@apple.com>
690
691         IconDatabase::synchronousIconForPageURL() has inconsistent API when no custom icon is available
692         <https://bugs.webkit.org/show_bug.cgi?id=64015>
693         <rdar://problem/9706277>
694
695         For some URLs it would return a particular size of default icon; for other
696         URLs it would return 0.
697
698         Reviewed by Ada Chan.
699
700         * loader/icon/IconDatabase.cpp:
701         (WebCore::IconDatabase::synchronousIconForPageURL):
702         Return 0 in all cases where there is no custom icon.
703
704 2011-07-06  Emil A Eklund  <eae@chromium.org>
705
706         Reviewed by Eric Seidel.
707
708         Switch RenderLayer::hitTest* to to new layout types
709         https://bugs.webkit.org/show_bug.cgi?id=63640
710
711         Switch hit testing and supporting methods for RenderLayer over to the new
712         layout unit abstraction.
713         
714         No new tests, no functionality changes.
715
716         * rendering/LayoutTypes.h:
717         (WebCore::roundedLayoutPoint):
718         Add roundedLayoutPoint abstraction, calls roundedIntPoint now but will be a
719         no-op (and eventually go away) once we switch to float or fixed point.
720         
721         * rendering/RenderLayer.cpp:
722         (WebCore::RenderLayer::createLocalTransformState):
723         (WebCore::RenderLayer::hitTestLayer):
724         (WebCore::RenderLayer::hitTestList):
725         (WebCore::RenderLayer::hitTestPaginatedChildLayer):
726         (WebCore::RenderLayer::hitTestChildLayerColumns):
727         (WebCore::RenderLayer::calculateRects):
728         * rendering/RenderLayer.h:
729
730 2011-07-06  Simon Fraser  <simon.fraser@apple.com>
731
732         Have RenderLayerCompositor take care of clearing backing store when entering the page cache
733         https://bugs.webkit.org/show_bug.cgi?id=64018
734
735         Reviewed by Joseph Pecoraro.
736
737         Move responsibility for tearing down all RenderLayer backing stores from
738         RenderLayer itself to RenderLayerCompositor, since RenderLayerCompositor 
739         manages backing store creation and destruction in general.
740
741         * page/FrameView.cpp:
742         (WebCore::FrameView::clearBackingStores):
743         * rendering/RenderLayer.cpp:
744         * rendering/RenderLayer.h:
745         * rendering/RenderLayerCompositor.cpp:
746         (WebCore::RenderLayerCompositor::clearBackingForLayerIncludingDescendants):
747         (WebCore::RenderLayerCompositor::clearBackingForAllLayers):
748         * rendering/RenderLayerCompositor.h:
749
750 2011-07-06  Ryuan Choi  <ryuan.choi@samsung.com>
751
752         [Performance] Only call sendContentResizeNotification when the scrollbar actually did change
753         https://bugs.webkit.org/show_bug.cgi?id=47320
754
755         Reviewed by Eric Seidel.
756
757         Move avoidScrollbarCreation checking code from setHasHorizontalScrollbar
758         and setHasVerticalScrollbar to their caller in order to keep sendContentResizedNotification
759         false in case scrollbar is not really changed.
760         As a result, it will remove unnecessary relayout in the above case.
761
762         No new tests as this is very hard to write tests for. The bug only
763         occured when scrolling the sites which contain frame in browser with
764         frameFlattening. This should not change functionality in other case.
765
766         * platform/ScrollView.cpp:
767         (WebCore::ScrollView::setHasHorizontalScrollbar):
768         (WebCore::ScrollView::setHasVerticalScrollbar):
769         (WebCore::ScrollView::updateScrollbars):
770
771 2011-07-06  Nate Chapin  <japhet@chromium.org>
772
773         Don't let all subresources keep isLoadingInAPISense() from
774         returning false, only requests that affect
775         CachedResourceRequest::requestCount().
776         https://bugs.webkit.org/show_bug.cgi?id=62066
777
778         Reviewed by Adam Barth.
779
780         * dom/Document.cpp:
781         (WebCore::Document::Document):
782         (WebCore::Document::dispatchWindowLoadEvent):
783         * dom/Document.h:
784         (WebCore::Document::loadEventFinished):
785         * loader/DocumentLoader.cpp:
786         (WebCore::DocumentLoader::isLoadingInAPISense):
787
788 2011-07-06  Pavel Feldman  <pfeldman@google.com>
789
790         Web Inspector: implement drag'n'drop in the elements panel for reordering nodes.
791         https://bugs.webkit.org/show_bug.cgi?id=63990
792
793         Reviewed by Yury Semikhatsky.
794
795         * inspector/Inspector.json:
796         * inspector/InspectorDOMAgent.cpp:
797         (WebCore::InspectorDOMAgent::moveTo):
798         * inspector/InspectorDOMAgent.h:
799         * inspector/front-end/DOMAgent.js:
800         (WebInspector.DOMNode.prototype._removeChild):
801         (WebInspector.DOMNode.prototype.ownerDocumentElement):
802         (WebInspector.DOMNode.prototype.moveTo):
803         (WebInspector.DOMAgent.prototype._childNodeRemoved):
804         * inspector/front-end/ElementsTreeOutline.js:
805         (WebInspector.ElementsTreeOutline):
806         (WebInspector.ElementsTreeOutline.prototype._ondragstart):
807         (WebInspector.ElementsTreeOutline.prototype._ondragover):
808         (WebInspector.ElementsTreeOutline.prototype._ondragleave):
809         (WebInspector.ElementsTreeOutline.prototype._isValidDragSourceOrTarget):
810         (WebInspector.ElementsTreeOutline.prototype._ondragend.callback):
811         (WebInspector.ElementsTreeOutline.prototype._ondragend):
812         (WebInspector.ElementsTreeOutline.prototype._clearDragOverTreeElementMarker):
813         (WebInspector.ElementsTreeOutline.prototype.populateContextMenu.focusElement):
814         (WebInspector.ElementsTreeOutline.prototype.populateContextMenu):
815         (WebInspector.ElementsTreeElement.prototype.onattach):
816         * inspector/front-end/inspector.css:
817         (.outline-disclosure li.elements-drag-over .selection):
818         * inspector/front-end/treeoutline.js:
819         (TreeOutline.prototype.treeElementFromEvent):
820
821 2011-07-06  Andras Becsi  <abecsi@webkit.org>
822
823         Fix "warning: a `;' might be needed at the end of action code"
824
825         Unreviewed gardening.
826
827         No new tests needed.
828
829         * css/CSSGrammar.y: Future versions of Bison will not add the ';' so add it.
830
831 2011-07-06  Andras Becsi  <abecsi@webkit.org>
832
833         [Qt] Revome unused but set shadowBlur variable after r90406.
834
835         Unreviewed build fix.
836
837         No new tests needed.
838
839         * platform/graphics/qt/GraphicsContextQt.cpp:
840         (WebCore::GraphicsContext::fillPath): Use the GraphicsContext brush.
841
842 2011-07-06  Andras Becsi  <abecsi@webkit.org>
843
844         [Qt] Remove duplicate entries of ShadowBlur sources from project file.
845
846         Rubber-stamped by Csaba Osztrogon√°c.
847
848         No new tests needed.
849
850         * WebCore.pro: These files were already added in r84410.
851
852 2011-07-05  Kentaro Hara  <haraken@google.com>
853
854         Trigger a 'change' event whenever selected files are changed
855         https://bugs.webkit.org/show_bug.cgi?id=63929
856
857         Reviewed by Kent Tamura.
858
859         Record previously selected files and then compare them with newly selected files.
860         If the previously selected files and their order are not equal to those of
861         the newly selected files, we trigger the 'change' event.
862
863         Test: fast/forms/file-input-change-event.html
864
865         * html/FileInputType.cpp:
866         (WebCore::FileInputType::filesChosen): Calls dispathChangeEvent() only when the previously selected files are different from the newly selected files
867
868 2011-06-29  Kent Tamura  <tkent@chromium.org>
869
870         Reviewed by Alexey Proskuryakov.
871
872         [Mac] REGRESSION (r88415): Range slider doesn't have focus appearance.
873         https://bugs.webkit.org/show_bug.cgi?id=63573
874
875         * rendering/RenderThemeMac.mm:
876         (WebCore::RenderThemeMac::paintSliderThumb):
877         Need to pass the RenderObject of the owner <input> because
878         updateFocusedState() checks the outline style of the specified
879         renderer, and we'd like to make a slider thumb reflect the owner
880         focus style.
881
882 2011-07-05  Hans Wennborg  <hans@chromium.org>
883
884         [V8][Chromium] Remove use of OwnHandle from V8LocalContext
885         https://bugs.webkit.org/show_bug.cgi?id=63925
886
887         Reviewed by Adam Barth.
888
889         Replace the OwnHandle<> member in V8LocalContext with
890         v8::Persistent<v8::Context>.
891         The code that used OwnHandle<> would not correctly Dispose
892         of the Context, which would cause the memory to fill up when creating
893         and destructing many V8LocalContext objects, such as in the case
894         of IndexedDB.
895
896         * bindings/v8/V8Utilities.cpp:
897         (WebCore::V8LocalContext::V8LocalContext):
898         (WebCore::V8LocalContext::~V8LocalContext):
899         * bindings/v8/V8Utilities.h:
900
901 2011-07-05  Igor Oliveira  <igor.oliveira@openbossa.org>
902
903         [Qt] Add ShadowBlur support
904         https://bugs.webkit.org/show_bug.cgi?id=62997
905
906         Use ShadowBlur instead of ContextShadow to handle canvas and css shadows. ShadowBlur is
907         a newer and platform independent shadow implementation.
908         Qt QPainter does not have support for shadows so is necessary to create a layer support
909         to draw complex shapes and fonts. The beginShadowLayer creates a temporary shadow buffer
910         where the canvas can draw onto and endShadowLayer applies the blur filter, colors the
911         shadow buffer and draw the final shadow to the graphics context.
912
913         Reviewed by Andreas Kling.
914
915         * WebCore.pro:
916         * platform/graphics/GraphicsContext.cpp:
917         * platform/graphics/GraphicsContext.h:
918         * platform/graphics/ShadowBlur.cpp:
919         (WebCore::ShadowBlur::ShadowBlur):
920         (WebCore::ShadowBlur::setShadowValues):
921         (WebCore::ShadowBlur::updateShadowBlurValues):
922         (WebCore::ShadowBlur::clear):
923         (WebCore::ShadowBlur::blurAndColorShadowBuffer):
924         (WebCore::ShadowBlur::beginShadowLayer):
925         (WebCore::ShadowBlur::endShadowLayer):
926         * platform/graphics/ShadowBlur.h:
927         (WebCore::ShadowBlur::type):
928         * platform/graphics/qt/ContextShadowQt.cpp: Removed.
929         * platform/graphics/qt/FontQt.cpp:
930         (WebCore::drawTextCommon):
931         (WebCore::Font::drawGlyphs):
932         * platform/graphics/qt/GraphicsContextQt.cpp:
933         (WebCore::GraphicsContextPlatformPrivate::mustUseShadowBlur):
934         (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
935         (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
936         (WebCore::GraphicsContext::savePlatformState):
937         (WebCore::GraphicsContext::restorePlatformState):
938         (WebCore::GraphicsContext::fillPath):
939         (WebCore::GraphicsContext::strokePath):
940         (WebCore::GraphicsContext::fillRect):
941         (WebCore::GraphicsContext::fillRoundedRect):
942         (WebCore::GraphicsContext::shadowBlur):
943         (WebCore::GraphicsContext::clipBounds):
944         (WebCore::GraphicsContext::setPlatformShadow):
945         (WebCore::GraphicsContext::clearPlatformShadow):
946         * platform/graphics/qt/ImageQt.cpp:
947         (WebCore::BitmapImage::draw):
948         * platform/graphics/qt/StillImageQt.cpp:
949         (WebCore::StillImage::draw):
950
951 2011-07-05  Sam Weinig  <sam@webkit.org>
952
953         Null deref accessing CustomEvent.detail
954         <rdar://problem/9724577>
955         https://bugs.webkit.org/show_bug.cgi?id=63885
956
957         Reviewed by Anders Carlsson.
958
959         Test: fast/events/custom-event-uninitialized.html
960
961         * bindings/scripts/CodeGeneratorJS.pm:
962         Guard against uninitialized script value.
963
964 2011-07-05  Pratik Solanki  <psolanki@apple.com>
965
966         Reviewed by Dan Bernstein.
967
968         Coalesce data array into one NSData before calling didReceiveData
969         https://bugs.webkit.org/show_bug.cgi?id=63916
970         <rdar://problem/9715181>
971
972         Instead of calling didReceiveData multiple times with smaller chunks of data, we merge the
973         data buffers into one and call it once.
974
975         No new tests because the flag isn't enabled yet.
976
977         * platform/network/mac/ResourceHandleMac.mm:
978         (-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]):
979
980 2011-07-05  Tamas Czene  <Czene.Tamas@stud.u-szeged.hu>
981
982         Reviewed by Simon Fraser.
983
984         Remove virtual functions from StyleImage.
985         https://bugs.webkit.org/show_bug.cgi?id=63909
986
987         We can remove the virtual "isChachedImage, isPendingImage, isGeneratedImage" functions to speed up the StyleImage.
988         Some profile data shows this part is significant, especially in small CSS-based sites.
989         Removing the virtual functions - removing the calls - makes a small performance progression on this part.
990
991         * rendering/style/StyleCachedImage.h:
992         (WebCore::StyleCachedImage::StyleCachedImage):
993         * rendering/style/StyleGeneratedImage.h:
994         (WebCore::StyleGeneratedImage::StyleGeneratedImage):
995         * rendering/style/StyleImage.h:
996         (WebCore::StyleImage::isCachedImage):
997         (WebCore::StyleImage::isPendingImage):
998         (WebCore::StyleImage::isGeneratedImage):
999         (WebCore::StyleImage::StyleImage):
1000         * rendering/style/StylePendingImage.h:
1001         (WebCore::StylePendingImage::StylePendingImage):
1002
1003 2011-07-05  Pavel Feldman  <pfeldman@google.com>
1004
1005         Web Inspector: add "element state" setting to the styles section title.
1006         https://bugs.webkit.org/show_bug.cgi?id=63932
1007
1008         Reviewed by Yury Semikhatsky.
1009
1010         * English.lproj/localizedStrings.js:
1011         * WebCore.gypi:
1012         * inspector/front-end/Images/paneElementStateButtons.png: Added.
1013         * inspector/front-end/StylesSidebarPane.js:
1014         (WebInspector.StylesSidebarPane.muteEventListener):
1015         (WebInspector.StylesSidebarPane):
1016         (WebInspector.StylesSidebarPane.prototype.update):
1017         (WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
1018         (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
1019         (WebInspector.StylesSidebarPane.prototype.addBlankSection):
1020         (WebInspector.StylesSidebarPane.prototype.registerShortcuts):
1021         (WebInspector.StylesSidebarPane.prototype._toggleElementStatePane):
1022         (WebInspector.StylesSidebarPane.prototype._createElementStatePane.clickListener):
1023         (WebInspector.StylesSidebarPane.prototype._createElementStatePane.createCheckbox):
1024         (WebInspector.StylesSidebarPane.prototype._createElementStatePane):
1025         * inspector/front-end/WebKit.qrc:
1026         * inspector/front-end/inspector.css:
1027         (.pane > .title > .pane-title-button:active, .pane > .title > .pane-title-button.toggled):
1028         (.pane > .title > .pane-title-button.element-state):
1029         (.styles-element-state-pane):
1030         (.styles-element-state-pane.expanded):
1031         (.styles-element-state-pane > table):
1032         (.styles-element-state-pane input):
1033
1034 2011-06-22  Pavel Podivilov  <podivilov@chromium.org>
1035
1036         Reviewed by Yury Semikhatsky.
1037
1038         Web Inspector: extract duplicated code that deals with source mappings.
1039         https://bugs.webkit.org/show_bug.cgi?id=63139
1040
1041         * inspector/front-end/ConsoleView.js:
1042         (WebInspector.ConsoleMessage.prototype.isEqual):
1043         (WebInspector.ConsoleMessage.prototype.get stackTrace):
1044         * inspector/front-end/DebuggerPresentationModel.js:
1045         (WebInspector.DebuggerPresentationModel.prototype._uiLocationToScriptLocation):
1046         (WebInspector.DebuggerPresentationModel.prototype._updateAnchor):
1047         (WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage.didGetUILocation):
1048         (WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage):
1049         (WebInspector.DebuggerPresentationModel.prototype.continueToLine):
1050         (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didGetScriptLocation):
1051         (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
1052         (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.updateSourceFileBreakpointsAndDispatchEvent):
1053         (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didGetUILocation):
1054         (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
1055         (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
1056         (WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
1057         (WebInspector.PresenationCallFrame):
1058         (WebInspector.PresenationCallFrame.prototype.sourceLine):
1059
1060 2011-07-05  Ilya Tikhonovsky  <loislo@chromium.org>
1061
1062         Web Inspector: WebInspector frontend reports a protocol error in remote debugging mode.
1063         https://bugs.webkit.org/show_bug.cgi?id=63935
1064
1065         it was error generated for obsolete message "loaded" which was sent from frontend to backend.
1066
1067         Reviewed by Yury Semikhatsky.
1068
1069         * inspector/CodeGeneratorInspector.pm:
1070         * inspector/front-end/inspector.js:
1071         (WebInspector.loaded.WebInspector.socket.onopen):
1072         (WebInspector.loaded):
1073
1074 2011-07-05  Andrey Kosyakov  <caseq@chromium.org>
1075
1076         Web Inspector: [refactoring] remove network-sidebar style, add network-log-grid
1077         https://bugs.webkit.org/show_bug.cgi?id=63913
1078
1079         Reviewed by Yury Semikhatsky.
1080
1081         * inspector/front-end/NetworkPanel.js:
1082         (WebInspector.NetworkPanel):
1083         (WebInspector.NetworkPanel.prototype._createTable):
1084         * inspector/front-end/networkPanel.css:
1085         (.network-log-grid):
1086         (.network-log-grid table.data):
1087         (.network-log-grid.small table.data):
1088         (.network-log-grid td):
1089         (.network-log-grid.small td):
1090         (.network-log-grid th):
1091         (.network-log-grid.small th):
1092         (.network-log-grid th, .network.panel .data-grid th.sort-descending, .network.panel .data-grid th.sort-ascending):
1093         (.network-log-grid .data-container):
1094         (.network-log-grid.small .data-container):
1095         (.network-log-grid select):
1096         (.network-log-grid.small tr.offscreen):
1097         (.network-log-grid tr.offscreen):
1098         (.network-log-grid tr.offscreen td):
1099         (.network-log-grid tr.filler):
1100         (.network-log-grid tr:not(.filler) td.name-column):
1101         (.network.panel:not(.viewing-resource) .network-log-grid td.name-column:hover):
1102         (.network-log-grid td.time-column):
1103         (.network-log-grid.small .network-graph-side):
1104         (.network-log-grid th.sortable:active):
1105         (.network-log-grid tr.selected .network-cell-subtitle):
1106         (.network-log-grid .icon):
1107         (.network-log-grid.small .icon):
1108         (.network-log-grid .network-category-scripts .icon):
1109         (.network-log-grid.small .network-category-scripts .icon):
1110         (.network-log-grid .network-category-documents .icon):
1111         (.network-log-grid.small .network-category-documents .icon):
1112         (.network-log-grid .network-category-stylesheets .icon):
1113         (.network-log-grid.small .network-category-stylesheets .icon):
1114         (.network-log-grid .network-category-images .icon):
1115         (.network-log-grid.small .network-category-images .icon):
1116         (.network-log-grid .image-network-icon-preview):
1117         (.network-log-grid.small .image-network-icon-preview):
1118         (.network-timeline-grid.small .network-event-divider):
1119         (.network-log-grid .resources-dividers):
1120         (.network-log-grid .resources-dividers-label-bar):
1121         (.network-timeline-grid.small .resources-dividers-label-bar):
1122         (.network-timeline-grid .resources-divider-label):
1123         (.network-timeline-grid .resources-dividers-label-bar .resources-divider):
1124         (.network-timeline-grid.small .resources-dividers-label-bar .resources-divider):
1125         (.network-timeline-grid .resources-divider.first .resources-divider-label):
1126         (.network-timeline-grid .resources-dividers-label-bar .resources-divider.first):
1127         (.network-timeline-grid tr.filler td):
1128         (.network-summary-bar td):
1129         (.network.panel.viewing-resource .network-log-grid th):
1130         (.network-log-grid.full-grid-mode .viewer-column):
1131         (.network-log-grid.brief-grid-mode .time-column):
1132         (.network-log-grid.viewing-resource-mode .timeline-column):
1133         (.network.panel .sidebar):
1134         (.network.panel.viewing-resource .network-log-grid .data-grid-resizer):
1135
1136 2011-07-05  Alexandru Chiculita  <achicu@adobe.com>
1137
1138         Reviewed by Simon Hausmann.
1139
1140         [Qt] "cat" is not available when building.
1141         https://bugs.webkit.org/show_bug.cgi?id=63924
1142
1143         Changed 'cat' to 'perl -ne \"print $1\"' because 'cat' is not available on Windows with
1144         MSVC toolchain. It passed the Qt buildbots, because they run with cygwin.
1145
1146         Project file change. No tests needed.
1147
1148         * CodeGenerators.pri:
1149 2011-07-05  Vsevolod Vlasov  <vsevik@chromium.org>
1150
1151         Unreviewed; Qt Linux Release minimal compile fix.
1152
1153         * testing/Internals.h:
1154         (WebCore::Internals::setInspectorResourcesDataSizeLimits):
1155         * testing/Internals.idl:
1156
1157 2011-07-05  Vsevolod Vlasov  <vsevik@chromium.org>
1158
1159         Web Inspector: Show content for plugin requests in network panel.
1160         https://bugs.webkit.org/show_bug.cgi?id=30080
1161
1162         Now the data from didReceiveData callback is passed to inspector.
1163         It is then saved in NetworkResourcesData structure for plugin requests.
1164         Added window.internals.setInspectorResourcesDataSizeLimits() method
1165         for testing replacement logic.
1166
1167         Reviewed by Pavel Feldman.
1168
1169         Tests: http/tests/inspector/network/network-content-replacement-embed.html
1170                http/tests/inspector/network/network-content-replacement-xhr.html
1171                http/tests/inspector/network/network-embed.html
1172
1173         * WebCore.exp.in:
1174         * inspector/InspectorController.cpp:
1175         (WebCore::InspectorController::setResourcesDataSizeLimitsFromInternals):
1176         * inspector/InspectorController.h:
1177         * inspector/InspectorInstrumentation.cpp:
1178         (WebCore::InspectorInstrumentation::didReceiveDataImpl):
1179         * inspector/InspectorInstrumentation.h:
1180         (WebCore::InspectorInstrumentation::didReceiveData):
1181         * inspector/InspectorResourceAgent.cpp:
1182         (WebCore::InspectorResourceAgent::didReceiveResponse):
1183         (WebCore::InspectorResourceAgent::didReceiveData):
1184         (WebCore::InspectorResourceAgent::didFinishLoading):
1185         (WebCore::InspectorResourceAgent::setInitialXHRContent):
1186         (WebCore::InspectorResourceAgent::setResourcesDataSizeLimitsFromInternals):
1187         (WebCore::InspectorResourceAgent::getResourceContent):
1188         * inspector/InspectorResourceAgent.h:
1189         * inspector/NetworkResourcesData.cpp:
1190         (WebCore::NetworkResourcesData::ResourceData::ResourceData):
1191         (WebCore::NetworkResourcesData::ResourceData::setContent):
1192         (WebCore::NetworkResourcesData::ResourceData::purgeContent):
1193         (WebCore::NetworkResourcesData::ResourceData::createDecoder):
1194         (WebCore::NetworkResourcesData::ResourceData::dataLength):
1195         (WebCore::NetworkResourcesData::ResourceData::appendData):
1196         (WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
1197         (WebCore::NetworkResourcesData::NetworkResourcesData):
1198         (WebCore::NetworkResourcesData::responseReceived):
1199         (WebCore::NetworkResourcesData::setResourceContent):
1200         (WebCore::NetworkResourcesData::maybeAddResourceData):
1201         (WebCore::NetworkResourcesData::maybeDecodeDataToContent):
1202         (WebCore::NetworkResourcesData::data):
1203         (WebCore::NetworkResourcesData::clear):
1204         (WebCore::NetworkResourcesData::setResourcesDataSizeLimits):
1205         (WebCore::NetworkResourcesData::ensureNoDataForIdentifier):
1206         (WebCore::NetworkResourcesData::ensureFreeSpace):
1207         * inspector/NetworkResourcesData.h:
1208         (WebCore::NetworkResourcesData::ResourceData::hasContent):
1209         (WebCore::NetworkResourcesData::ResourceData::content):
1210         (WebCore::NetworkResourcesData::ResourceData::decoder):
1211         (WebCore::NetworkResourcesData::ResourceData::buffer):
1212         (WebCore::NetworkResourcesData::ResourceData::setBuffer):
1213         (WebCore::NetworkResourcesData::ResourceData::hasData):
1214         * inspector/front-end/Resource.js:
1215         (WebInspector.Resource.prototype.get contentEncoded):
1216         * inspector/front-end/ResourcePreviewView.js:
1217         (WebInspector.ResourcePreviewView.prototype.contentLoaded):
1218         (WebInspector.ResourcePreviewView.prototype._createEmptyView):
1219         (WebInspector.ResourcePreviewView.prototype._createPreviewView):
1220         * inspector/front-end/ResourceView.js:
1221         (WebInspector.ResourceView.hasTextContent):
1222         * loader/DocumentThreadableLoader.cpp:
1223         (WebCore::DocumentThreadableLoader::didReceiveData):
1224         * loader/FrameLoader.cpp:
1225         (WebCore::FrameLoader::willLoadMediaElementURL):
1226         (WebCore::FrameLoader::commitProvisionalLoad):
1227         (WebCore::FrameLoader::loadResourceSynchronously):
1228         (WebCore::FrameLoader::loadedResourceFromMemoryCache):
1229         * loader/ResourceLoadNotifier.cpp:
1230         (WebCore::ResourceLoadNotifier::didReceiveData):
1231         (WebCore::ResourceLoadNotifier::dispatchDidReceiveData):
1232         (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
1233         * loader/ResourceLoadNotifier.h:
1234         * loader/appcache/ApplicationCacheGroup.cpp:
1235         (WebCore::ApplicationCacheGroup::didReceiveData):
1236         * testing/Internals.cpp:
1237         (WebCore::Internals::setInspectorResourcesDataSizeLimits):
1238         * testing/Internals.h:
1239         * testing/Internals.idl:
1240
1241 2011-07-05  Kent Tamura  <tkent@chromium.org>
1242
1243         Add an assertion that percent height box is unregistered correctly.
1244         https://bugs.webkit.org/show_bug.cgi?id=62792
1245
1246         Reviewed by Hajime Morita.
1247
1248         No new tests. This won't change behavior.
1249
1250         * rendering/RenderBlock.cpp:
1251         (WebCore::RenderBlock::hasPercentHeightDescendant): Added.
1252         * rendering/RenderBlock.h: Declare hasPercentHeightDescendant().
1253         * rendering/RenderBox.cpp:
1254         (WebCore::RenderBox::destroy): Assert !hasPercentHeightDescendant().
1255
1256 2011-07-04  Pavel Feldman  <pfeldman@google.com>
1257
1258         Web Inspector: Enable settings screen with settings for console and elements panels.
1259         https://bugs.webkit.org/show_bug.cgi?id=62853
1260
1261         Reviewed by Yury Semikhatsky.
1262
1263         * English.lproj/localizedStrings.js:
1264         * inspector/front-end/HelpScreen.js:
1265         (WebInspector.HelpScreen.prototype.hide):
1266         * inspector/front-end/SettingsScreen.js:
1267         (WebInspector.SettingsScreen):
1268         (WebInspector.SettingsScreen.prototype._createRadioSetting.clickListener):
1269         (WebInspector.SettingsScreen.prototype._createRadioSetting.get for):
1270         * inspector/front-end/ShortcutsScreen.js:
1271         (WebInspector.ShortcutsScreen.prototype.hide):
1272         * inspector/front-end/StylesSidebarPane.js:
1273         (WebInspector.StylesSidebarPane.prototype._colorFormatSettingChanged):
1274         (WebInspector.StylesSidebarPane.prototype._updateColorFormatFilter.get var):
1275         (WebInspector.StylesSidebarPane.prototype._updateColorFormatFilter):
1276         (WebInspector.StylesSidebarPane.prototype._changeSetting):
1277         (WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
1278         * inspector/front-end/inspector.css:
1279         (#counters):
1280         * inspector/front-end/inspector.js:
1281         (WebInspector._createGlobalStatusBarItems):
1282         (WebInspector._toggleSettings):
1283         (WebInspector._showShortcutsScreen):
1284         (WebInspector._hideShortcutsScreen):
1285         (WebInspector._showSettingsScreen.onhide):
1286         (WebInspector._showSettingsScreen):
1287         (WebInspector._hideSettingsScreen):
1288         (WebInspector.documentKeyDown):
1289
1290 2011-07-05  Shinya Kawanaka  <shinyak@google.com>
1291
1292         Reviewed by Kent Tamura.
1293
1294         The default step is used when attribute step of input[type='number'] is "any".
1295         https://bugs.webkit.org/show_bug.cgi?id=57723
1296
1297         When step is "any", 0 was chosen as step, but this is not intuitive.
1298         So changed to use the default step.
1299
1300         * html/HTMLInputElement.cpp:
1301         (WebCore::HTMLInputElement::getAllowedValueStep):
1302           Calls getAllowedValueStepWithDecimalPlaces with RejectAny.
1303         (WebCore::HTMLInputElement::getAllowedValueStepWithDecimalPlaces):
1304           Takes a new arugument AnyStepHandling. If it is AnyIsDefaultStep, this method
1305           allows "step" attribute to take a value "any" to use the default step as step value.
1306           Otherwise, INVALID_STATE_ERR will be returned if "step" is "any".
1307         (WebCore::HTMLInputElement::applyStep): ditto.
1308         (WebCore::HTMLInputElement::stepUp):
1309           Calls applyStep with RejectAny.
1310         (WebCore::HTMLInputElement::stepDown): ditto.
1311         (WebCore::HTMLInputElement::stepUpFromRenderer):
1312           Removes a check that step is "any". It is checked in getAllowedValueStepWithDecimalPlaces.
1313         * html/HTMLInputElement.h:
1314
1315 2011-07-04  Dominic Cooney   <dominicc@chromium.org>
1316
1317         Simplify <progress> element's isDeterminate logic.
1318         https://bugs.webkit.org/show_bug.cgi?id=63889
1319
1320         Reviewed by Hajime Morita.
1321
1322         Covered by existing tests
1323         fast/dom/HTMLProgressElement/indeterminate-progress-*.html
1324
1325         * html/HTMLProgressElement.cpp:
1326         (WebCore::HTMLProgressElement::position): don't duplicate isDeterminate
1327         (WebCore::HTMLProgressElement::isDeterminate): remove redundant tests
1328         (WebCore::HTMLProgressElement::didElementStateChange): fix formatting
1329         * html/HTMLProgressElement.h:
1330
1331 2011-07-04  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1332
1333         Reviewed by Kent Tamura.
1334
1335         [EFL] Add hasOwnDisabledStateHandlingFor() to RenderThemeEfl
1336         https://bugs.webkit.org/show_bug.cgi?id=63884
1337
1338         As MediaControlRootElement decides whether it will display timeline
1339         according to the return value of RenderTheme's hasOwnDisabledStateHandlingFor(),
1340         RenderThemeEfl has to implement this function.
1341
1342         Existing tests cover the visibility of the controls.
1343
1344         * platform/efl/RenderThemeEfl.h:
1345         (WebCore::RenderThemeEfl::hasOwnDisabledStateHandlingFor):
1346
1347 2011-07-04  Kent Tamura  <tkent@chromium.org>
1348
1349         REGRESSION (r87067): Text overflows from short height text field.
1350         https://bugs.webkit.org/show_bug.cgi?id=61768
1351
1352         Reviewed by Dimitri Glazkov.
1353
1354         Since r87067, the RenderStyle for the inner text element is reset
1355         by the value update, but the renderer for the inner text element
1356         keeps to have metrics calculated by the previous style. So
1357         RenderTextControlSingleLine::layout() didn't set a desired height
1358         to the renderer for the inner text element.
1359
1360         This patch changes the style creation code so that it has the
1361         desired height initially.
1362
1363         Test: fast/forms/textfield-overflow-by-value-update.html
1364
1365         * rendering/RenderTextControlSingleLine.cpp:
1366         (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
1367         Initialize m_desiredInnerTextHeight.
1368         (WebCore::RenderTextControlSingleLine::layout):
1369         Update m_desiredInnerTextHeight.
1370         (WebCore::RenderTextControlSingleLine::styleDidChange):
1371         Reset m_desiredInnerTextHeight.
1372         (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
1373         Sets the height if m_desiredInnerTextHeight has a concrete value.
1374         * rendering/RenderTextControlSingleLine.h:
1375         Declare m_desiredInnerTextHeight.
1376
1377 2011-07-04  MORITA Hajime  <morrita@google.com>
1378
1379         Accessing ShadowRoot.nodeList causes an assertion failure.
1380         http://webkit.org/b/63798
1381         
1382         The TreeScope destructor did clear the reference to TreeScope, 
1383         then the Node destructor accessing treeScope(), which results 
1384         an inconsistent state during the NodeList cache cleanup.
1385
1386         This change clears NodeList cache during the TreeScope destructor.
1387         The Node destructor no longer does problematic NodeList cache
1388         manipulation.
1389
1390         Test: fast/dom/shadow/shadow-root-node-list.html
1391
1392         Reviewed by Dimitri Glazkov.
1393         
1394         * dom/Node.cpp:
1395         (WebCore::Node::~Node):
1396         (WebCore::Node::clearRareData):
1397         * dom/Node.h:
1398         * dom/TreeScope.cpp:
1399         (WebCore::TreeScope::~TreeScope):
1400
1401 2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>
1402
1403         ResourceLoadNotifier::dispatchWillSendRequest should not compare StringImpl directly
1404         https://bugs.webkit.org/show_bug.cgi?id=63873
1405
1406         Reviewed by Alexey Proskuryakov.
1407
1408         * loader/ResourceLoadNotifier.cpp:
1409         (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
1410
1411 2011-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>
1412
1413         Unreviewed, rolling out r90373.
1414         http://trac.webkit.org/changeset/90373
1415         https://bugs.webkit.org/show_bug.cgi?id=63917
1416
1417         Breaks Qt Linux Release minimal (Requested by vsevik on
1418         #webkit).
1419
1420         * WebCore.exp.in:
1421         * inspector/InspectorController.cpp:
1422         * inspector/InspectorController.h:
1423         * inspector/InspectorInstrumentation.cpp:
1424         (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl):
1425         * inspector/InspectorInstrumentation.h:
1426         (WebCore::InspectorInstrumentation::didReceiveContentLength):
1427         * inspector/InspectorResourceAgent.cpp:
1428         (WebCore::InspectorResourceAgent::didReceiveResponse):
1429         (WebCore::InspectorResourceAgent::didReceiveContentLength):
1430         (WebCore::InspectorResourceAgent::didFinishLoading):
1431         (WebCore::InspectorResourceAgent::setInitialXHRContent):
1432         (WebCore::InspectorResourceAgent::getResourceContent):
1433         * inspector/InspectorResourceAgent.h:
1434         * inspector/NetworkResourcesData.cpp:
1435         (WebCore::NetworkResourcesData::ResourceData::ResourceData):
1436         (WebCore::NetworkResourcesData::ResourceData::content):
1437         (WebCore::NetworkResourcesData::ResourceData::appendContent):
1438         (WebCore::NetworkResourcesData::ResourceData::purgeContent):
1439         (WebCore::NetworkResourcesData::NetworkResourcesData):
1440         (WebCore::NetworkResourcesData::responseReceived):
1441         (WebCore::NetworkResourcesData::addResourceContent):
1442         (WebCore::NetworkResourcesData::data):
1443         (WebCore::NetworkResourcesData::clear):
1444         (WebCore::NetworkResourcesData::ensureNoDataForIdentifier):
1445         (WebCore::NetworkResourcesData::ensureFreeSpace):
1446         * inspector/NetworkResourcesData.h:
1447         (WebCore::NetworkResourcesData::ResourceData::hasContent):
1448         (WebCore::NetworkResourcesData::ResourceData::setIsContentPurged):
1449         (WebCore::NetworkResourcesData::ResourceData::textEncodingName):
1450         (WebCore::NetworkResourcesData::ResourceData::setTextEncodingName):
1451         * inspector/front-end/Resource.js:
1452         * inspector/front-end/ResourcePreviewView.js:
1453         (WebInspector.ResourcePreviewView.prototype.contentLoaded):
1454         (WebInspector.ResourcePreviewView.prototype._createInnerView):
1455         * inspector/front-end/ResourceView.js:
1456         (WebInspector.ResourceView.hasTextContent):
1457         * loader/DocumentThreadableLoader.cpp:
1458         (WebCore::DocumentThreadableLoader::didReceiveData):
1459         * loader/FrameLoader.cpp:
1460         (WebCore::FrameLoader::willLoadMediaElementURL):
1461         (WebCore::FrameLoader::commitProvisionalLoad):
1462         (WebCore::FrameLoader::loadResourceSynchronously):
1463         (WebCore::FrameLoader::loadedResourceFromMemoryCache):
1464         * loader/ResourceLoadNotifier.cpp:
1465         (WebCore::ResourceLoadNotifier::didReceiveData):
1466         (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
1467         (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
1468         * loader/ResourceLoadNotifier.h:
1469         * loader/appcache/ApplicationCacheGroup.cpp:
1470         (WebCore::ApplicationCacheGroup::didReceiveData):
1471         * testing/Internals.cpp:
1472         * testing/Internals.h:
1473         * testing/Internals.idl:
1474
1475 2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>
1476
1477         Web Inspector: Show content for plugin requests in network panel.
1478         https://bugs.webkit.org/show_bug.cgi?id=30080
1479
1480         Reviewed by Pavel Feldman.
1481
1482         Tests: http/tests/inspector/network/network-content-replacement-embed.html
1483                http/tests/inspector/network/network-content-replacement-xhr.html
1484                http/tests/inspector/network/network-embed.html
1485
1486         * WebCore.exp.in:
1487         * inspector/InspectorController.cpp:
1488         (WebCore::InspectorController::setResourcesDataSizeLimitsFromInternals):
1489         * inspector/InspectorController.h:
1490         * inspector/InspectorInstrumentation.cpp:
1491         (WebCore::InspectorInstrumentation::didReceiveDataImpl):
1492         * inspector/InspectorInstrumentation.h:
1493         (WebCore::InspectorInstrumentation::didReceiveData):
1494         * inspector/InspectorResourceAgent.cpp:
1495         (WebCore::InspectorResourceAgent::didReceiveResponse):
1496         (WebCore::InspectorResourceAgent::didReceiveData):
1497         (WebCore::InspectorResourceAgent::didFinishLoading):
1498         (WebCore::InspectorResourceAgent::setInitialXHRContent):
1499         (WebCore::InspectorResourceAgent::setResourcesDataSizeLimitsFromInternals):
1500         (WebCore::InspectorResourceAgent::getResourceContent):
1501         * inspector/InspectorResourceAgent.h:
1502         * inspector/NetworkResourcesData.cpp:
1503         (WebCore::NetworkResourcesData::ResourceData::ResourceData):
1504         (WebCore::NetworkResourcesData::ResourceData::setContent):
1505         (WebCore::NetworkResourcesData::ResourceData::purgeContent):
1506         (WebCore::NetworkResourcesData::ResourceData::createDecoder):
1507         (WebCore::NetworkResourcesData::ResourceData::dataLength):
1508         (WebCore::NetworkResourcesData::ResourceData::appendData):
1509         (WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
1510         (WebCore::NetworkResourcesData::NetworkResourcesData):
1511         (WebCore::NetworkResourcesData::responseReceived):
1512         (WebCore::NetworkResourcesData::setResourceContent):
1513         (WebCore::NetworkResourcesData::maybeAddResourceData):
1514         (WebCore::NetworkResourcesData::maybeDecodeDataToContent):
1515         (WebCore::NetworkResourcesData::data):
1516         (WebCore::NetworkResourcesData::clear):
1517         (WebCore::NetworkResourcesData::setResourcesDataSizeLimits):
1518         (WebCore::NetworkResourcesData::ensureNoDataForIdentifier):
1519         (WebCore::NetworkResourcesData::ensureFreeSpace):
1520         * inspector/NetworkResourcesData.h:
1521         (WebCore::NetworkResourcesData::ResourceData::hasContent):
1522         (WebCore::NetworkResourcesData::ResourceData::content):
1523         (WebCore::NetworkResourcesData::ResourceData::decoder):
1524         (WebCore::NetworkResourcesData::ResourceData::buffer):
1525         (WebCore::NetworkResourcesData::ResourceData::setBuffer):
1526         (WebCore::NetworkResourcesData::ResourceData::hasData):
1527         * inspector/front-end/Resource.js:
1528         (WebInspector.Resource.prototype.get contentEncoded):
1529         * inspector/front-end/ResourcePreviewView.js:
1530         (WebInspector.ResourcePreviewView.prototype.contentLoaded):
1531         (WebInspector.ResourcePreviewView.prototype._createEmptyView):
1532         (WebInspector.ResourcePreviewView.prototype._createPreviewView):
1533         * inspector/front-end/ResourceView.js:
1534         (WebInspector.ResourceView.hasTextContent):
1535         * loader/DocumentThreadableLoader.cpp:
1536         (WebCore::DocumentThreadableLoader::didReceiveData):
1537         * loader/FrameLoader.cpp:
1538         (WebCore::FrameLoader::willLoadMediaElementURL):
1539         (WebCore::FrameLoader::commitProvisionalLoad):
1540         (WebCore::FrameLoader::loadResourceSynchronously):
1541         (WebCore::FrameLoader::loadedResourceFromMemoryCache):
1542         * loader/ResourceLoadNotifier.cpp:
1543         (WebCore::ResourceLoadNotifier::didReceiveData):
1544         (WebCore::ResourceLoadNotifier::dispatchDidReceiveData):
1545         (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
1546         * loader/ResourceLoadNotifier.h:
1547         * loader/appcache/ApplicationCacheGroup.cpp:
1548         (WebCore::ApplicationCacheGroup::didReceiveData):
1549         * testing/Internals.cpp:
1550         (WebCore::Internals::setInspectorResourcesDataSizeLimits):
1551         * testing/Internals.h:
1552         * testing/Internals.idl:
1553
1554 2011-07-04  Jeff Timanus  <twiz@chromium.org>
1555
1556         Reviewed by Stephen White.
1557
1558         Prevent calls to GrapicsContext3D::deleteTexture with id 0 in DrawingBuffer::clear().
1559         https://bugs.webkit.org/show_bug.cgi?id=63756
1560
1561         * platform/graphics/gpu/DrawingBuffer.cpp:
1562         (WebCore::DrawingBuffer::clear):
1563
1564 2011-07-04  Martin Robinson  <mrobinson@igalia.com>
1565
1566         Reviewed by Andreas Kling.
1567
1568         [GTK] r90148 did not apply to X11 platforms in WebKit1
1569         https://bugs.webkit.org/show_bug.cgi?id=63862
1570
1571         Correct the guard for an X11 specific piece of code. TARGET(X11) not
1572         defined for the GTK+ port.
1573
1574         No new tests. This is covered by an existing test.
1575
1576         * plugins/npapi.cpp: Correct the X11 guard.
1577         (NPN_InvalidateRect):
1578
1579 2011-07-04  Pavel Feldman  <pfeldman@google.com>
1580
1581         Web Inspector: implement settings panel.
1582         https://bugs.webkit.org/show_bug.cgi?id=63907
1583
1584         Reviewed by Yury Semikhatsky.
1585
1586         * English.lproj/localizedStrings.js:
1587         * WebCore.gypi:
1588         * WebCore.vcproj/WebCore.vcproj:
1589         * inspector/front-end/BreakpointsSidebarPane.js:
1590         (WebInspector.XHRBreakpointsSidebarPane.prototype._saveBreakpoints):
1591         (WebInspector.EventListenerBreakpointsSidebarPane.prototype._saveBreakpoints):
1592         * inspector/front-end/ConsoleView.js:
1593         (WebInspector.ConsoleView):
1594         (WebInspector.ConsoleView.prototype._handleContextMenuEvent.monitoringXHRItemAction):
1595         (WebInspector.ConsoleView.prototype._handleContextMenuEvent.get preserveLogItemAction):
1596         (WebInspector.ConsoleView.prototype._monitoringXHREnabledSettingChanged):
1597         (WebInspector.ConsoleView.prototype._registerShortcuts):
1598         * inspector/front-end/DOMBreakpointsSidebarPane.js:
1599         (WebInspector.DOMBreakpointsSidebarPane.prototype._saveBreakpoints):
1600         * inspector/front-end/DebuggerPresentationModel.js:
1601         (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
1602         * inspector/front-end/ElementsPanel.js:
1603         (WebInspector.ElementsPanel.prototype._contextMenuEventFired):
1604         (WebInspector.ElementsPanel.prototype._domWordWrapSettingChanged):
1605         (WebInspector.ElementsPanel.prototype._registerShortcuts):
1606         * inspector/front-end/EventListenersSidebarPane.js:
1607         (WebInspector.EventListenersSidebarPane.prototype):
1608         ():
1609         * inspector/front-end/HelpScreen.js:
1610         (WebInspector.HelpScreen):
1611         (WebInspector.HelpScreen.prototype.show):
1612         (WebInspector.HelpScreen.prototype.hide):
1613         (WebInspector.HelpScreen.prototype._onKeyDown):
1614         * inspector/front-end/NetworkItemView.js:
1615         * inspector/front-end/NetworkPanel.js:
1616         * inspector/front-end/Panel.js:
1617         (WebInspector.Panel.prototype.saveSidebarWidth):
1618         * inspector/front-end/ProfilesPanel.js:
1619         * inspector/front-end/ResourcesPanel.js:
1620         (WebInspector.BaseStorageTreeElement.prototype.onselect):
1621         (WebInspector.StorageCategoryTreeElement.prototype.onexpand):
1622         (WebInspector.StorageCategoryTreeElement.prototype.set oncollapse):
1623         * inspector/front-end/ScriptsPanel.js:
1624         (WebInspector.ScriptsPanel.prototype._sourceFileAdded.get if):
1625         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
1626         (WebInspector.ScriptsPanel.prototype._createSidebarButtonAndRegisterShortcuts):
1627         * inspector/front-end/Settings.js:
1628         (WebInspector.Settings):
1629         (WebInspector.Settings.prototype.installApplicationSetting):
1630         (WebInspector.Setting):
1631         (WebInspector.Setting.prototype.addChangeListener):
1632         (WebInspector.Setting.prototype.removeChangeListener):
1633         (WebInspector.Setting.prototype.get var):
1634         (WebInspector.Setting.prototype):
1635         (WebInspector.Setting.prototype.set if):
1636         * inspector/front-end/SettingsScreen.js: Added.
1637         (WebInspector.SettingsScreen):
1638         (WebInspector.SettingsScreen.prototype._appendSection):
1639         (WebInspector.SettingsScreen.prototype._columnElement):
1640         (WebInspector.SettingsScreen.prototype._createCheckboxSetting.get listener):
1641         (WebInspector.SettingsScreen.prototype._createRadioSetting):
1642         * inspector/front-end/ShortcutsScreen.js: Renamed from Source/WebCore/inspector/front-end/ShortcutsHelp.js.
1643         (WebInspector.ShortcutsScreen):
1644         * inspector/front-end/StylesSidebarPane.js:
1645         (WebInspector.StylesSidebarPane.prototype.registerShortcuts):
1646         * inspector/front-end/WatchExpressionsSidebarPane.js:
1647         * inspector/front-end/WebKit.qrc:
1648         * inspector/front-end/helpScreen.css:
1649         (.help-window-main):
1650         (body.attached .help-window-main):
1651         (.help-window-caption):
1652         (body.attached .help-window-caption):
1653         (.help-content):
1654         (.help-close-button):
1655         (body.attached .help-close-button):
1656         (body.attached .help-content):
1657         (.help-table):
1658         (body.platform-mac .help-key):
1659         (.help-combine-keys):
1660         (.help-content p):
1661         (.help-content fieldset):
1662         (.help-content fieldset p):
1663         (.help-content p.help-section):
1664         (.help-section-title):
1665         (.help-content input[type=checkbox]):
1666         * inspector/front-end/inspector.css:
1667         (button.settings-status-bar-item):
1668         (.settings-status-bar-item .glyph):
1669         * inspector/front-end/inspector.html:
1670         * inspector/front-end/inspector.js:
1671         (WebInspector._createGlobalStatusBarItems):
1672         (WebInspector._toggleAttach):
1673         (WebInspector._toggleSettings):
1674         (WebInspector._registerShortcuts):
1675         (WebInspector.documentKeyDown):
1676
1677 2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>
1678
1679         Web Inspector: Resources loaded to Resources Panel from InspectorPageAgent do not have mime type set.
1680         https://bugs.webkit.org/show_bug.cgi?id=63701
1681
1682         Pass cachedResource/documentLoader mimeType from InspectorPageAgent to frontend.
1683
1684         Reviewed by Yury Semikhatsky.
1685
1686         Test: http/tests/inspector/resource-tree/resource-tree-mimetype.html
1687
1688         * inspector/Inspector.json:
1689         * inspector/InspectorPageAgent.cpp:
1690         (WebCore::InspectorPageAgent::buildObjectForFrame):
1691         (WebCore::InspectorPageAgent::buildObjectForFrameTree):
1692         * inspector/front-end/ResourceTreeModel.js:
1693         (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
1694         (WebInspector.ResourceTreeModel.prototype._createResource):
1695
1696 2011-07-04  Yury Semikhatsky  <yurys@chromium.org>
1697
1698         Web Inspector: repeated message counter should be aligned with other message icons
1699         https://bugs.webkit.org/show_bug.cgi?id=63901
1700
1701         Reviewed by Pavel Feldman.
1702
1703         * inspector/front-end/inspector.css:
1704         (.console-message .bubble):
1705
1706 2011-07-04  Alexander Pavlov  <apavlov@chromium.org>
1707
1708         Reviewed by Pavel Feldman.
1709
1710         Web Inspector: Adding new CSS rules should be more discoverable in the UI
1711         https://bugs.webkit.org/show_bug.cgi?id=63803
1712
1713         * inspector/front-end/StylesSidebarPane.js:
1714         (WebInspector.StylesSidebarPane.prototype._createNewRule):
1715
1716 2011-07-04  Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
1717
1718         [Qt] Fixing build with --media-stream flag enabled
1719         https://bugs.webkit.org/show_bug.cgi?id=63831
1720
1721         Reviewed by Benjamin Poulain.
1722
1723         * features.pri: Adding support to ENABLE_MEDIA_STREAM flag.
1724
1725 2011-07-04  Vsevolod Vlasov  <vsevik@chromium.org>
1726
1727         Reviewed by Yury Semikhatsky.
1728
1729         Web Inspector: Update network resource url from response data.
1730         https://bugs.webkit.org/show_bug.cgi?id=63736
1731
1732         * inspector/Inspector.json:
1733         * inspector/InspectorResourceAgent.cpp:
1734         (WebCore::buildObjectForResourceResponse):
1735         * inspector/front-end/NetworkManager.js:
1736         (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
1737
1738 2011-07-04  Andrey Kosyakov  <caseq@chromium.org>
1739
1740         Reviewed by Yury Semikhatsky.
1741
1742         Web Inspector: [Extensions API] audit formatter names should begin with create
1743         https://bugs.webkit.org/show_bug.cgi?id=63802
1744
1745         * inspector/front-end/ExtensionAPI.js:
1746         (WebInspector.injectedExtensionAPI.AuditResultImpl):
1747
1748 2011-07-03  Dominic Cooney  <dominicc@chromium.org>
1749
1750         The value property of an indeterminate progress element should be zero
1751         https://bugs.webkit.org/show_bug.cgi?id=63861
1752
1753         Reviewed by Kent Tamura.
1754
1755         Test: fast/dom/HTMLProgressElement/set-progress-properties.html
1756
1757         * html/HTMLProgressElement.cpp:
1758         (WebCore::HTMLProgressElement::value):
1759
1760 2011-07-03  Robert Hogan  <robert@webkit.org>
1761
1762         Restore scroll position on page reloads scheduled by <meta http-equiv="refresh" content="XX"/>
1763         https://bugs.webkit.org/show_bug.cgi?id=62482
1764
1765         If a <meta http-equiv="refresh"> directive schedules a page reload rather than
1766         a redirect restore the scroll position after the reload. Do the same on location.reload().
1767
1768         Reviewed by Adam Barth.
1769
1770         Tests: http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html
1771                http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html
1772                http/tests/navigation/scrollstate-after-http-equiv-refresh.html
1773                http/tests/navigation/scrollstate-after-location-reload.html
1774
1775         * loader/FrameLoader.cpp:
1776         (WebCore::FrameLoader::loadURL):
1777         Only make the load FrameLoadTypeSame if it has not already been set as FrameLoadTypeReload*.
1778         FrameLoadTypeReload* loads are set through http-equiv refreshes, manual reloads, or location.reload()
1779         and honour the user's scroll position in the frame. A FrameLoadTypeSame is for when the frame is loading
1780         the same page again, e.g. by clicking a link.
1781
1782         * loader/NavigationScheduler.cpp:
1783         (WebCore::ScheduledRedirect::fire): Tell FrameLoader::changeLocation() if this is a reload.
1784
1785 2011-07-03  Dirk Schulze  <krit@webkit.org>
1786
1787         SVGAnimateTransform accumulate=sum restarts on every repeat
1788         https://bugs.webkit.org/show_bug.cgi?id=63876
1789
1790         Reviewed by Nikolas Zimmermann.
1791         
1792         We applied transforms from previous animation repeats to a transform list. The problem is, that we calculated the current
1793         transform based on the percentage of the current repeat count. This causes an animation starting from scale level 0
1794         on every repeat. Now I add the repeat count to the current percentage, so that the distance calculation starts from 100% on
1795         the first repeat, from 200% on the second and so on.
1796
1797         Test: svg/animations/svgtransform-animation-1.html
1798
1799         * svg/SVGAnimateTransformElement.cpp:
1800         (WebCore::SVGAnimateTransformElement::calculateAnimatedValue):
1801
1802 2011-07-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1803
1804         Unreviewed, rolling out r90342.
1805         http://trac.webkit.org/changeset/90342
1806         https://bugs.webkit.org/show_bug.cgi?id=63875
1807
1808         Newly added tests fail on Mac, GTK, and Win7 (Requested by
1809         abarth on #webkit).
1810
1811         * loader/FrameLoader.cpp:
1812         (WebCore::FrameLoader::loadURL):
1813         * loader/NavigationScheduler.cpp:
1814
1815 2011-07-03  Robert Hogan  <robert@webkit.org>
1816
1817         Restore scroll position on page reloads scheduled by <meta http-equiv="refresh" content="XX"/>
1818         https://bugs.webkit.org/show_bug.cgi?id=62482
1819
1820         If a <meta http-equiv="refresh"> directive schedules a page reload rather than
1821         a redirect restore the scroll position after the reload. Do the same on location.reload().
1822
1823         Reviewed by Adam Barth.
1824
1825         Tests: http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier-2.html
1826                http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html
1827                http/tests/navigation/scrollstate-after-http-equiv-refresh.html
1828                http/tests/navigation/scrollstate-after-location-reload.html
1829
1830         * loader/FrameLoader.cpp:
1831         (WebCore::FrameLoader::loadURL):
1832         Only make the load FrameLoadTypeSame if it has not already been set as FrameLoadTypeReload*.
1833         FrameLoadTypeReload* loads are set through http-equiv refreshes, manual reloads, or location.reload()
1834         and honour the user's scroll position in the frame. A FrameLoadTypeSame is for when the frame is loading
1835         the same page again, e.g. by clicking a link.
1836
1837         * loader/NavigationScheduler.cpp:
1838         (WebCore::ScheduledRedirect::fire): Tell FrameLoader::changeLocation() if this is a reload.
1839
1840 2011-04-02  Robert Hogan  <robert@webkit.org>
1841
1842         Reviewed by Benjamin Poulain.
1843
1844         [Qt] Support third-party cookie policy for Qt clients
1845         https://bugs.webkit.org/show_bug.cgi?id=45455
1846
1847         Identifying third-party cookies is facilitated by API new to QUrl from
1848         Qt 4.8: QUrl::topLevelDomain(). This API uses the Mozilla public suffix
1849         list to determine the top-level registry-controlled domain of the Url.
1850
1851         See also: http://gitorious.org/qt/qt/merge_requests/1205
1852                    (commit 154402f56dcf8303a6ce601a52215226af8d31ba)
1853                   http://bugreports.qt.nokia.com/browse/QTBUG-13601
1854
1855         Test: http/tests/cookies/strict-third-party-cookie-blocking.html
1856
1857         * WebCore.pro:
1858         * platform/network/qt/ResourceRequestQt.cpp:
1859         (WebCore::ResourceRequest::toNetworkRequest):
1860         * platform/qt/CookieJarQt.cpp:
1861         (WebCore::setCookies):
1862         (WebCore::cookies):
1863         * platform/qt/ThirdPartyCookiesQt.cpp: Added.
1864         (WebCore::cookieJar):
1865         (WebCore::isFirstPartyCookie):
1866         (WebCore::cookieAllowed):
1867         (WebCore::allowThirdPartyCookies):
1868         * platform/qt/ThirdPartyCookiesQt.h: Added.
1869
1870 2011-07-03  Vsevolod Vlasov  <vsevik@chromium.org>
1871
1872         Reviewed by Alexey Proskuryakov.
1873
1874         Web Inspector: Preflight OPTIONS requests are not shown on network panel for asynchronous XHRs.
1875         https://bugs.webkit.org/show_bug.cgi?id=63712
1876
1877         Added InspectorInstrumentation calls to preflight OPTIONS requests callbacks in DocumentThreadableLoader.
1878
1879         * loader/DocumentThreadableLoader.cpp:
1880         (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
1881         (WebCore::DocumentThreadableLoader::didReceiveResponse):
1882         (WebCore::DocumentThreadableLoader::didReceiveData):
1883         (WebCore::DocumentThreadableLoader::didFinishLoading):
1884         (WebCore::DocumentThreadableLoader::didFail):
1885         (WebCore::DocumentThreadableLoader::loadRequest):
1886         * loader/DocumentThreadableLoader.h:
1887
1888 2011-06-23  Robert Hogan  <robert@webkit.org>
1889
1890         Reviewed by Simon Hausmann.
1891
1892         [Qt] Windowless Plugins : <input> cursor blinks even after transferring focus to plugin
1893         https://bugs.webkit.org/show_bug.cgi?id=30355
1894
1895         Test: plugins/mouse-click-plugin-clears-selection.html
1896
1897         PluginView needs to use page->focusController()->setFocusedNode() when focusing a plugin
1898         in order to clear the FrameSelection in the currently focused node. In its platform-specific
1899         code Chromium already does this (WebPluginContainerImpl.cpp).
1900
1901         * WebCore.exp.in: Add symbol for FocusController::setFocusedNode
1902         * plugins/PluginView.cpp:
1903         (WebCore::PluginView::focusPluginElement): Using FocusController::setFocusedNode() makes
1904                                                    the call to FocusController:setFocusedFrame() and Document::setFocusedNode()
1905                                                    redundant, since it calls both.
1906
1907 2011-07-01  Michael Nordman  <michaeln@google.com>
1908
1909         Reviewed by Darin Fisher.
1910
1911         [Chromium] FileSystem API can be used to learn about installed software on the user's computer.
1912         Added a new MIMETypeRegistry method to return a type based on a well known set of mappings
1913         without consulting the OS/registry.
1914         https://bugs.webkit.org/show_bug.cgi?id=63220
1915
1916         No new tests, existing layout tests that invoke file.type apply.
1917
1918         * fileapi/File.cpp: Refactored the factory methods.
1919         (WebCore::createBlobDataForFileWithType):
1920         (WebCore::createBlobDataForFile):
1921         (WebCore::createBlobDataForFileSystemFile):
1922         (WebCore::File::File):
1923         * platform/MIMETypeRegistry.cpp: Added getWellKnownMIMETypeForExtension() method.
1924         (WebCore::mediaMIMETypeMap):
1925         (WebCore::findMimeType):
1926         (WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension):
1927         * platform/MIMETypeRegistry.h:
1928         * platform/chromium/MIMETypeRegistryChromium.cpp: Added getWellKnownMIMETypeForExtension() method.
1929         (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
1930         (WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension):
1931         (WebCore::findMimeType):
1932         * platform/chromium/PlatformBridge.h:
1933
1934 2011-07-01  Tim Horton  <timothy_horton@apple.com>
1935
1936         Reviewed by Darin Adler.
1937
1938         SVG data:image/svg+xml;base64 URLs inside CSS throw mime type warning
1939         https://bugs.webkit.org/show_bug.cgi?id=54325
1940         
1941         Add image/svg+xml to the list of acceptable MIME types for the Image type.
1942
1943         * inspector/front-end/inspector.js:
1944         (WebInspector):
1945
1946 2011-07-01  Tim Horton  <timothy_horton@apple.com>
1947
1948         Reviewed by Darin Adler.
1949
1950         Errors encountered within SVG documents should be reported to the console
1951         https://bugs.webkit.org/show_bug.cgi?id=62599
1952
1953         Add SVGElement::reportAttributeParsingError, which will
1954         write a Web Inspector console message if passed an SVGParsingError
1955         and the attribute which was being applied, only in the case where
1956         there is actually an error.
1957
1958         Include the SVG document's URI when writing to the Web Inspector
1959         console, so that the UI displays both the filename and the line number.
1960
1961         * svg/SVGDocumentExtensions.cpp:
1962         (WebCore::reportMessage):
1963         * svg/SVGElement.cpp:
1964         (WebCore::SVGElement::reportAttributeParsingError):
1965         * svg/SVGElement.h:
1966
1967 2011-07-01  Scott Byer  <scottbyer@chromium.org>
1968
1969         Reviewed by Adam Barth.
1970
1971         Smooth scrolling fixes
1972         https://bugs.webkit.org/show_bug.cgi?id=63770
1973
1974         Tests: Chromium webkit_unit_tests ScrollAnimatorNoneTest.ScrollWheelTrace and .LinuxTrackPadTrace
1975
1976         Fix issues found in manual testing; distill the traces into unit tests. Fix the issues the tests exposed in the
1977         scroll animation code.
1978
1979         * platform/ScrollAnimatorNone.cpp:
1980         (WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
1981         (WebCore::ScrollAnimatorNone::scroll):
1982
1983 2011-07-01  Levi Weintraub  <leviw@chromium.org>
1984
1985         Switch primary virtual layout functions to new layout types
1986         https://bugs.webkit.org/show_bug.cgi?id=63852
1987
1988         Reviewed by Eric Seidel.
1989
1990         Switching the primary overloaded layout functions over to the new layout unit abstraction.
1991
1992         No new tests, no functionality changes.
1993
1994         * html/shadow/MediaControlElements.cpp:
1995         (WebCore::RenderMediaVolumeSliderContainer::layout):
1996         * page/FrameView.cpp:
1997         (WebCore::FrameView::layout):
1998         * rendering/AutoTableLayout.cpp:
1999         (WebCore::AutoTableLayout::layout):
2000         * rendering/FixedTableLayout.cpp:
2001         (WebCore::FixedTableLayout::layout):
2002         * rendering/RenderBox.cpp:
2003         (WebCore::RenderBox::layout):
2004         * rendering/RenderFrameSet.cpp:
2005         (WebCore::RenderFrameSet::layout):
2006         * rendering/RenderMedia.cpp:
2007         (WebCore::RenderMedia::layout):
2008         * rendering/RenderRubyRun.cpp:
2009         (WebCore::RenderRubyRun::layout):
2010         * rendering/RenderScrollbarPart.cpp:
2011         (WebCore::RenderScrollbarPart::layout):
2012         * rendering/RenderSlider.cpp:
2013         (WebCore::RenderSlider::layout):
2014         * rendering/RenderTable.cpp:
2015         (WebCore::RenderTable::layout):
2016         * rendering/RenderTableRow.cpp:
2017         (WebCore::RenderTableRow::layout):
2018         * rendering/RenderTableSection.cpp:
2019         (WebCore::RenderTableSection::layout):
2020         * rendering/RenderTextControlSingleLine.cpp:
2021         (WebCore::RenderTextControlSingleLine::layout):
2022         * rendering/RenderView.cpp:
2023         (WebCore::RenderView::layout):
2024         * rendering/RenderView.h:
2025         (WebCore::RenderView::layoutDelta):
2026         (WebCore::RenderView::addLayoutDelta):
2027         * rendering/mathml/RenderMathMLRoot.cpp:
2028         (WebCore::RenderMathMLRoot::layout):
2029         * rendering/mathml/RenderMathMLRow.cpp:
2030         (WebCore::RenderMathMLRow::layout):
2031         * rendering/mathml/RenderMathMLSquareRoot.cpp:
2032         (WebCore::RenderMathMLSquareRoot::layout):
2033         * rendering/mathml/RenderMathMLSubSup.cpp:
2034         (WebCore::RenderMathMLSubSup::layout):
2035         * rendering/mathml/RenderMathMLUnderOver.cpp:
2036         (WebCore::RenderMathMLUnderOver::layout):
2037
2038 2011-07-01  Sam Weinig  <sam@webkit.org>
2039
2040         Reduce parser nesting cap to 512
2041         https://bugs.webkit.org/show_bug.cgi?id=63856
2042
2043         Reviewed by Dan Bernstein.
2044
2045         Given Firefox's cap of 200, our cap of 2048 seemed a little excessive. Lower
2046         the nesting cap to 512 to cover more cases where rending recursion was biting us.
2047
2048         * page/Settings.h:
2049         Reduce the nesting cap to 512.
2050
2051 2011-07-01  Darin Adler  <darin@apple.com>
2052
2053         Add change accidentally left out of last commit.
2054
2055         * rendering/RenderLayerBacking.cpp:
2056         (WebCore::RenderLayerBacking::updateContentsScale): Multiply in the
2057         backing scale.
2058
2059 2011-07-01  Darin Adler  <darin@apple.com>
2060
2061         Consider backing scale when setting up graphics layers
2062         https://bugs.webkit.org/show_bug.cgi?id=63848
2063
2064         Reviewed by Simon Fraser.
2065
2066         * platform/graphics/ca/GraphicsLayerCA.cpp:
2067         (WebCore::GraphicsLayerCA::clampedContentsScaleForScale):
2068         Increased the maximum scale since scale factor can now include
2069         both page contents scale and backing scale.
2070
2071         * rendering/RenderLayerBacking.cpp:
2072         (WebCore::RenderLayerBacking::createGraphicsLayer): Multiply in the
2073         backing scale as well as the page contents scale.
2074         (WebCore::RenderLayerBacking::updateForegroundLayer): Ditto.
2075         (WebCore::RenderLayerBacking::updateMaskLayer): Ditto.
2076         (WebCore::RenderLayerBacking::pageContentsScale): Added.
2077         (WebCore::RenderLayerBacking::backingScale): Added.
2078         * rendering/RenderLayerBacking.h: Added new private functions.
2079
2080 2011-07-01  Adele Peterson  <adele@apple.com>
2081
2082         Reviewed by Darin Adler.
2083
2084         WebCore part of fix for https://bugs.webkit.org/show_bug.cgi?id=63851
2085         <rdar://problem/8981062> Crash when loading a document in an editable WebView that has a subframe with an unstyled body
2086
2087         No new tests.  I tried to make a test in DumpRenderTree with an editable WebView, 
2088         but was unsuccessful in getting the crash to happen in that instance.
2089
2090         * editing/Editor.cpp: (WebCore::Editor::applyEditingStyleToElement): Add a nil check that exits early, in addition to the ASSERT.
2091
2092 2011-07-01  Levi Weintraub  <leviw@chromium.org>
2093
2094         Switch overflow and collapsedMargins to new layout types
2095         https://bugs.webkit.org/show_bug.cgi?id=63840
2096
2097         Reviewed by Eric Seidel.
2098
2099         Switching overflow and collapsedMargins over to the new layout unit abstraction.
2100
2101         Also removing an unused function: blockDirectionOverflow
2102
2103         No new tests, no functionality changes.
2104
2105         * rendering/RenderBlock.cpp:
2106         (WebCore::RenderBlock::collapsedMarginBeforeForChild):
2107         (WebCore::RenderBlock::collapsedMarginAfterForChild):
2108         * rendering/RenderBlock.h:
2109         (WebCore::RenderBlock::collapsedMarginBefore):
2110         (WebCore::RenderBlock::collapsedMarginAfter):
2111         * rendering/RenderBox.cpp:
2112         (WebCore::RenderBox::addOverflowFromChild):
2113         (WebCore::RenderBox::addLayoutOverflow):
2114         (WebCore::RenderBox::addVisualOverflow):
2115         * rendering/RenderBox.h:
2116         (WebCore::RenderBox::layoutOverflowRect):
2117         (WebCore::RenderBox::minYLayoutOverflow):
2118         (WebCore::RenderBox::maxYLayoutOverflow):
2119         (WebCore::RenderBox::minXLayoutOverflow):
2120         (WebCore::RenderBox::maxXLayoutOverflow):
2121         (WebCore::RenderBox::maxLayoutOverflow):
2122         (WebCore::RenderBox::logicalLeftLayoutOverflow):
2123         (WebCore::RenderBox::logicalRightLayoutOverflow):
2124         (WebCore::RenderBox::visualOverflowRect):
2125         (WebCore::RenderBox::minYVisualOverflow):
2126         (WebCore::RenderBox::maxYVisualOverflow):
2127         (WebCore::RenderBox::minXVisualOverflow):
2128         (WebCore::RenderBox::maxXVisualOverflow):
2129         (WebCore::RenderBox::logicalLeftVisualOverflow):
2130         (WebCore::RenderBox::logicalRightVisualOverflow):
2131         (WebCore::RenderBox::addOverflowFromChild):
2132         (WebCore::RenderBox::collapsedMarginBefore):
2133         (WebCore::RenderBox::collapsedMarginAfter):
2134         * rendering/RenderOverflow.h:
2135         (WebCore::RenderOverflow::RenderOverflow):
2136         (WebCore::RenderOverflow::minYLayoutOverflow):
2137         (WebCore::RenderOverflow::maxYLayoutOverflow):
2138         (WebCore::RenderOverflow::minXLayoutOverflow):
2139         (WebCore::RenderOverflow::maxXLayoutOverflow):
2140         (WebCore::RenderOverflow::minYVisualOverflow):
2141         (WebCore::RenderOverflow::maxYVisualOverflow):
2142         (WebCore::RenderOverflow::minXVisualOverflow):
2143         (WebCore::RenderOverflow::maxXVisualOverflow):
2144         (WebCore::RenderOverflow::setMinYLayoutOverflow):
2145         (WebCore::RenderOverflow::setMaxYLayoutOverflow):
2146         (WebCore::RenderOverflow::setMinXLayoutOverflow):
2147         (WebCore::RenderOverflow::setMaxXLayoutOverflow):
2148         (WebCore::RenderOverflow::setMinYVisualOverflow):
2149         (WebCore::RenderOverflow::setMaxYVisualOverflow):
2150         (WebCore::RenderOverflow::setMinXVisualOverflow):
2151         (WebCore::RenderOverflow::setMaxXVisualOverflow):
2152         (WebCore::RenderOverflow::layoutOverflowRect):
2153         (WebCore::RenderOverflow::visualOverflowRect):
2154         (WebCore::RenderOverflow::move):
2155         (WebCore::RenderOverflow::addLayoutOverflow):
2156         (WebCore::RenderOverflow::addVisualOverflow):
2157         (WebCore::RenderOverflow::setLayoutOverflow):
2158         (WebCore::RenderOverflow::setVisualOverflow):
2159         (WebCore::RenderOverflow::resetLayoutOverflow):
2160
2161 2011-07-01  Nate Chapin  <japhet@chromium.org>
2162
2163         Ensure WorkerScriptLoader::notifyFinished() doesn't re-enter.
2164         https://bugs.webkit.org/show_bug.cgi?id=63835
2165
2166         Reviewed by Dmitry Titov.
2167
2168         Test: fast/workers/worker-finish-crash.html
2169
2170         * workers/WorkerScriptLoader.cpp:
2171         (WebCore::WorkerScriptLoader::WorkerScriptLoader):
2172         (WebCore::WorkerScriptLoader::notifyFinished):
2173         * workers/WorkerScriptLoader.h:
2174
2175 2011-07-01  Adrienne Walker  <enne@google.com>
2176
2177         [chromium] Upload root layer textures first so that it is less likely to be skipped
2178         https://bugs.webkit.org/show_bug.cgi?id=63850
2179
2180         Reviewed by James Robinson.
2181
2182         This is a tiny follow-on patch to bug 63760.  If the root layer is not
2183         uploaded first, then it may not have enough space to fit into texture
2184         memory and might be skipped, leaving a blue background.
2185
2186         * platform/graphics/chromium/LayerRendererChromium.cpp:
2187         (WebCore::LayerRendererChromium::updateLayers):
2188
2189 2011-07-01  Mihai Parparita  <mihaip@chromium.org>
2190
2191         Reviewed by Darin Fisher.
2192
2193         location.replace with a hash change does not update the history entry
2194         https://bugs.webkit.org/show_bug.cgi?id=63777
2195
2196         location.replace('#foo') would not update the HistoryItem with the
2197         new URL, thus navigating back to the page would use the previous
2198         URL, even though it had been replaced. Make
2199         HistoryController::updateForSameDocumentNavigation mirror 
2200         HistoryController::replaceState.
2201
2202         Test: fast/history/location-replace-hash.html
2203
2204         * loader/HistoryController.cpp:
2205         (WebCore::HistoryController::updateForSameDocumentNavigation):
2206
2207 2011-07-01  Ryosuke Niwa  <rniwa@webkit.org>
2208
2209         Reviewed by Ojan Vafai.
2210
2211         Move m_isDirectional from FrameSelection to VisibleSelection
2212         https://bugs.webkit.org/show_bug.cgi?id=63473
2213
2214         Move m_isDirectional from FrameSelection to VisibleSelection.
2215
2216         Also fixed a bug that WebKit does not preserve non-directional selection after undo.
2217
2218         Test: editing/selection/directionality-after-undo-replace.html
2219
2220         * WebCore.exp.in: Updated the signature of setSelection.
2221         * editing/FrameSelection.cpp:
2222         (WebCore::FrameSelection::FrameSelection): Removed the call to setIsDirectional.
2223         (WebCore::shouldAlwaysUseDirectionalSelection): Added.
2224         (WebCore::FrameSelection::setSelection): No longer takes DirectionalityPolicy.
2225         Calls setIsDirectional(true) when the platform doesn't support non-directional selection.
2226         Passes align and granularity to setSelection of the base end point as expected.
2227         No longer updates granularity when updating the selection of a different frame.
2228         (WebCore::FrameSelection::willBeModified): Calls VisibleSelection::isDirectional().
2229         (WebCore::FrameSelection::modify): No longer calls trialFrameSelection.setIsDirectional
2230         because the directionality is passed from m_selection automatically.
2231         Also calls shouldAlwaysUseDirectionalSelection.
2232         * editing/FrameSelection.h: Remove m_isDirectional. Make all boolean bit fields.
2233         (WebCore::FrameSelection::setSelection): No longer takes DirectionalityPolicy.
2234         * editing/VisibleSelection.cpp:
2235         (WebCore::VisibleSelection::VisibleSelection): Initializes m_isDirectional to true.
2236         This should be changed to false to fix the bug 60529.
2237         * editing/VisibleSelection.h:
2238         (WebCore::VisibleSelection::isDirectional): Added.
2239         (WebCore::VisibleSelection::setIsDirectional): Added.
2240         * page/EventHandler.cpp:
2241         (WebCore::setNonDirectionalSelectionIfNeeded): Creates a non-directional selection instead of
2242         calling setSelection with MakeNonDirectionalSelection.
2243         (WebCore::EventHandler::handleMousePressEventSingleClick): Remove the call to setIsDirectional
2244         because it already calls setNonDirectionalSelectionIfNeeded.
2245
2246 2011-07-01  Tony Chang  <tony@chromium.org>
2247
2248         cleanup of flexbox and marquee data naming in StyleRareNonInheritedData
2249         https://bugs.webkit.org/show_bug.cgi?id=63827
2250
2251         Reviewed by Ojan Vafai.
2252
2253         * rendering/style/RenderStyle.cpp:
2254         (WebCore::RenderStyle::RenderStyle):
2255         (WebCore::RenderStyle::diff):
2256         * rendering/style/RenderStyle.h:
2257         (WebCore::InheritedFlags::boxAlign):
2258         (WebCore::InheritedFlags::boxFlex):
2259         (WebCore::InheritedFlags::boxFlexGroup):
2260         (WebCore::InheritedFlags::boxLines):
2261         (WebCore::InheritedFlags::boxOrdinalGroup):
2262         (WebCore::InheritedFlags::boxOrient):
2263         (WebCore::InheritedFlags::boxPack):
2264         (WebCore::InheritedFlags::marqueeIncrement):
2265         (WebCore::InheritedFlags::marqueeSpeed):
2266         (WebCore::InheritedFlags::marqueeLoopCount):
2267         (WebCore::InheritedFlags::marqueeBehavior):
2268         (WebCore::InheritedFlags::marqueeDirection):
2269         (WebCore::InheritedFlags::setBoxAlign):
2270         (WebCore::InheritedFlags::setBoxFlex):
2271         (WebCore::InheritedFlags::setBoxFlexGroup):
2272         (WebCore::InheritedFlags::setBoxLines):
2273         (WebCore::InheritedFlags::setBoxOrdinalGroup):
2274         (WebCore::InheritedFlags::setBoxOrient):
2275         (WebCore::InheritedFlags::setBoxPack):
2276         (WebCore::InheritedFlags::setMarqueeIncrement):
2277         (WebCore::InheritedFlags::setMarqueeSpeed):
2278         (WebCore::InheritedFlags::setMarqueeDirection):
2279         (WebCore::InheritedFlags::setMarqueeBehavior):
2280         (WebCore::InheritedFlags::setMarqueeLoopCount):
2281         * rendering/style/StyleRareNonInheritedData.cpp:
2282         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2283         (WebCore::StyleRareNonInheritedData::operator==):
2284         * rendering/style/StyleRareNonInheritedData.h:
2285             flexibleBox -> m_deprecatedFlexibleBox and marquee to m_marquee
2286
2287 2011-07-01  Mike Reed  <reed@google.com>
2288
2289         Stop using deprecated SkDeviceFactory API
2290         https://bugs.webkit.org/show_bug.cgi?id=63488
2291
2292         Reviewed by James Robinson.
2293
2294         No new tests. Check-point for removing Factory API from Skia
2295
2296         * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
2297         (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
2298         * platform/graphics/skia/PlatformContextSkia.cpp:
2299         (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
2300
2301 2011-07-01  Jeffrey Pfau  <jpfau@apple.com>
2302
2303         Reviewed by Adam Barth.
2304
2305         Move XMLDocumentParser to new folder xml/parser/
2306         https://bugs.webkit.org/show_bug.cgi?id=63666
2307
2308         * CMakeLists.txt:
2309         * GNUmakefile.am:
2310         * GNUmakefile.list.am:
2311         * WebCore.gyp/WebCore.gyp:
2312         * WebCore.gypi:
2313         * WebCore.pri:
2314         * WebCore.pro:
2315         * WebCore.vcproj/WebCore.vcproj:
2316         * WebCore.vcproj/WebCoreCommon.vsprops:
2317         * WebCore.vcproj/copyForwardingHeaders.cmd:
2318         * WebCore.xcodeproj/project.pbxproj:
2319         * xml/parser/XMLDocumentParser.cpp:
2320         (WebCore::XMLDocumentParser::pushCurrentNode):
2321         (WebCore::XMLDocumentParser::popCurrentNode):
2322         (WebCore::XMLDocumentParser::clearCurrentNodeStack):
2323         (WebCore::XMLDocumentParser::insert):
2324         (WebCore::XMLDocumentParser::append):
2325         (WebCore::XMLDocumentParser::handleError):
2326         (WebCore::XMLDocumentParser::enterText):
2327         (WebCore::toString):
2328         (WebCore::XMLDocumentParser::exitText):
2329         (WebCore::XMLDocumentParser::detach):
2330         (WebCore::XMLDocumentParser::end):
2331         (WebCore::XMLDocumentParser::finish):
2332         (WebCore::XMLDocumentParser::finishWasCalled):
2333         (WebCore::createXHTMLParserErrorHeader):
2334         (WebCore::XMLDocumentParser::insertErrorMessageBlock):
2335         (WebCore::XMLDocumentParser::notifyFinished):
2336         (WebCore::XMLDocumentParser::isWaitingForScripts):
2337         (WebCore::XMLDocumentParser::pauseParsing):
2338         (WebCore::XMLDocumentParser::parseDocumentFragment):
2339         * xml/parser/XMLDocumentParser.h:
2340         (WebCore::XMLParserContext::context):
2341         (WebCore::XMLParserContext::XMLParserContext):
2342         (WebCore::XMLDocumentParser::create):
2343         (WebCore::XMLDocumentParser::setIsXHTMLDocument):
2344         (WebCore::XMLDocumentParser::isXHTMLDocument):
2345         (WebCore::XMLDocumentParser::setIsXHTMLMPDocument):
2346         (WebCore::XMLDocumentParser::isXHTMLMPDocument):
2347         (WebCore::XMLDocumentParser::wellFormed):
2348         (WebCore::XMLDocumentParser::context):
2349         * xml/parser/XMLDocumentParserLibxml2.cpp:
2350         (WebCore::PendingCallbacks::~PendingCallbacks):
2351         (WebCore::PendingCallbacks::create):
2352         (WebCore::PendingCallbacks::appendStartElementNSCallback):
2353         (WebCore::PendingCallbacks::appendEndElementNSCallback):
2354         (WebCore::PendingCallbacks::appendCharactersCallback):
2355         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
2356         (WebCore::PendingCallbacks::appendCDATABlockCallback):
2357         (WebCore::PendingCallbacks::appendCommentCallback):
2358         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
2359         (WebCore::PendingCallbacks::appendErrorCallback):
2360         (WebCore::PendingCallbacks::callAndRemoveFirstCallback):
2361         (WebCore::PendingCallbacks::isEmpty):
2362         (WebCore::PendingCallbacks::PendingCallbacks):
2363         (WebCore::PendingCallbacks::PendingCallback::~PendingCallback):
2364         (WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback):
2365         (WebCore::PendingCallbacks::PendingStartElementNSCallback::call):
2366         (WebCore::PendingCallbacks::PendingEndElementNSCallback::call):
2367         (WebCore::PendingCallbacks::PendingCharactersCallback::~PendingCharactersCallback):
2368         (WebCore::PendingCallbacks::PendingCharactersCallback::call):
2369         (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::~PendingProcessingInstructionCallback):
2370         (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::call):
2371         (WebCore::PendingCallbacks::PendingCDATABlockCallback::~PendingCDATABlockCallback):
2372         (WebCore::PendingCallbacks::PendingCDATABlockCallback::call):
2373         (WebCore::PendingCallbacks::PendingCommentCallback::~PendingCommentCallback):
2374         (WebCore::PendingCallbacks::PendingCommentCallback::call):
2375         (WebCore::PendingCallbacks::PendingInternalSubsetCallback::~PendingInternalSubsetCallback):
2376         (WebCore::PendingCallbacks::PendingInternalSubsetCallback::call):
2377         (WebCore::matchFunc):
2378         (WebCore::OffsetBuffer::OffsetBuffer):
2379         (WebCore::OffsetBuffer::readOutBytes):
2380         (WebCore::switchToUTF16):
2381         (WebCore::shouldAllowExternalLoad):
2382         (WebCore::openFunc):
2383         (WebCore::readFunc):
2384         (WebCore::writeFunc):
2385         (WebCore::closeFunc):
2386         (WebCore::errorFunc):
2387         (WebCore::XMLParserContext::createStringParser):
2388         (WebCore::XMLParserContext::createMemoryParser):
2389         (WebCore::XMLDocumentParser::supportsXMLVersion):
2390         (WebCore::XMLDocumentParser::XMLDocumentParser):
2391         (WebCore::XMLParserContext::~XMLParserContext):
2392         (WebCore::XMLDocumentParser::~XMLDocumentParser):
2393         (WebCore::XMLDocumentParser::doWrite):
2394         (WebCore::toString):
2395         (WebCore::toAtomicString):
2396         (WebCore::handleElementNamespaces):
2397         (WebCore::handleElementAttributes):
2398         (WebCore::XMLDocumentParser::startElementNs):
2399         (WebCore::XMLDocumentParser::endElementNs):
2400         (WebCore::XMLDocumentParser::characters):
2401         (WebCore::XMLDocumentParser::error):
2402         (WebCore::XMLDocumentParser::processingInstruction):
2403         (WebCore::XMLDocumentParser::cdataBlock):
2404         (WebCore::XMLDocumentParser::comment):
2405         (WebCore::XMLDocumentParser::startDocument):
2406         (WebCore::XMLDocumentParser::endDocument):
2407         (WebCore::XMLDocumentParser::internalSubset):
2408         (WebCore::getParser):
2409         (WebCore::hackAroundLibXMLEntityBug):
2410         (WebCore::startElementNsHandler):
2411         (WebCore::endElementNsHandler):
2412         (WebCore::charactersHandler):
2413         (WebCore::processingInstructionHandler):
2414         (WebCore::cdataBlockHandler):
2415         (WebCore::commentHandler):
2416         (WebCore::warningHandler):
2417         (WebCore::fatalErrorHandler):
2418         (WebCore::normalErrorHandler):
2419         (WebCore::sharedXHTMLEntity):
2420         (WebCore::getXHTMLEntity):
2421         (WebCore::getEntityHandler):
2422         (WebCore::startDocumentHandler):
2423         (WebCore::endDocumentHandler):
2424         (WebCore::internalSubsetHandler):
2425         (WebCore::externalSubsetHandler):
2426         (WebCore::ignorableWhitespaceHandler):
2427         (WebCore::XMLDocumentParser::initializeParserContext):
2428         (WebCore::XMLDocumentParser::doEnd):
2429         (WebCore::xmlDocPtrForString):
2430         (WebCore::XMLDocumentParser::lineNumber):
2431         (WebCore::XMLDocumentParser::columnNumber):
2432         (WebCore::XMLDocumentParser::textPosition):
2433         (WebCore::XMLDocumentParser::textPositionOneBased):
2434         (WebCore::XMLDocumentParser::stopParsing):
2435         (WebCore::XMLDocumentParser::resumeParsing):
2436         (WebCore::XMLDocumentParser::appendFragmentSource):
2437         (WebCore::attributesStartElementNsHandler):
2438         (WebCore::parseAttributes):
2439         * xml/parser/XMLDocumentParserQt.cpp:
2440         (WebCore::EntityResolver::resolveUndeclaredEntity):
2441         (WebCore::XMLDocumentParser::supportsXMLVersion):
2442         (WebCore::XMLDocumentParser::XMLDocumentParser):
2443         (WebCore::XMLDocumentParser::~XMLDocumentParser):
2444         (WebCore::XMLDocumentParser::doWrite):
2445         (WebCore::XMLDocumentParser::initializeParserContext):
2446         (WebCore::XMLDocumentParser::doEnd):
2447         (WebCore::XMLDocumentParser::lineNumber):
2448         (WebCore::XMLDocumentParser::columnNumber):
2449         (WebCore::XMLDocumentParser::textPosition):
2450         (WebCore::XMLDocumentParser::textPositionOneBased):
2451         (WebCore::XMLDocumentParser::stopParsing):
2452         (WebCore::XMLDocumentParser::resumeParsing):
2453         (WebCore::XMLDocumentParser::appendFragmentSource):
2454         (WebCore::attributesStartElementNsHandler):
2455         (WebCore::parseAttributes):
2456         (WebCore::prefixFromQName):
2457         (WebCore::handleElementNamespaces):
2458         (WebCore::handleElementAttributes):
2459         (WebCore::XMLDocumentParser::parse):
2460         (WebCore::XMLDocumentParser::startDocument):
2461         (WebCore::XMLDocumentParser::parseStartElement):
2462         (WebCore::XMLDocumentParser::parseEndElement):
2463         (WebCore::XMLDocumentParser::parseCharacters):
2464         (WebCore::XMLDocumentParser::parseProcessingInstruction):
2465         (WebCore::XMLDocumentParser::parseCdata):
2466         (WebCore::XMLDocumentParser::parseComment):
2467         (WebCore::XMLDocumentParser::endDocument):
2468         (WebCore::XMLDocumentParser::hasError):
2469         (WebCore::XMLDocumentParser::parseDtd):
2470         * xml/parser/XMLDocumentParserScope.cpp:
2471         (WebCore::XMLDocumentParserScope::XMLDocumentParserScope):
2472         (WebCore::XMLDocumentParserScope::~XMLDocumentParserScope):
2473
2474 2011-07-01  Vangelis Kokkevis  <vangelis@chromium.org>
2475
2476         Reviewed by James Robinson.
2477
2478         [chromium] Reserve all tile textures at layer update time to guarantee
2479         that they will be available at draw time.
2480         https://bugs.webkit.org/show_bug.cgi?id=63760
2481
2482         In addition, this patch unreserves textures used by RenderSurface's
2483         right after the RenderSurface has been used to free up memory for
2484         subsequent RenderSurfaces.
2485         
2486         This patch also "fixes" the pages that display a blue background when
2487         running out of texture memory as the root layer tiles get reserved first
2488         and are guaranteed to get textures.
2489
2490         * platform/graphics/chromium/ContentLayerChromium.cpp:
2491         (WebCore::ContentLayerChromium::ContentLayerChromium):
2492         (WebCore::ContentLayerChromium::visibleLayerRect):
2493         (WebCore::ContentLayerChromium::setIsMask):
2494         * platform/graphics/chromium/ContentLayerChromium.h:
2495         * platform/graphics/chromium/ImageLayerChromium.cpp:
2496         (WebCore::ImageLayerChromium::paintContentsIfDirty):
2497         * platform/graphics/chromium/LayerRendererChromium.cpp:
2498         (WebCore::LayerRendererChromium::paintLayerContents):
2499         (WebCore::LayerRendererChromium::drawLayer):
2500         (WebCore::LayerRendererChromium::initializeSharedObjects):
2501         * platform/graphics/chromium/LayerTexture.cpp:
2502         (WebCore::LayerTexture::unreserve):
2503         * platform/graphics/chromium/LayerTexture.h:
2504         * platform/graphics/chromium/LayerTilerChromium.cpp:
2505         (WebCore::LayerTilerChromium::prepareToUpdate):
2506         (WebCore::LayerTilerChromium::updateRect):
2507         (WebCore::LayerTilerChromium::drawTiles):
2508         * platform/graphics/chromium/RenderSurfaceChromium.cpp:
2509         (WebCore::RenderSurfaceChromium::releaseContentsTexture):
2510         * platform/graphics/chromium/RenderSurfaceChromium.h:
2511         * platform/graphics/chromium/TextureManager.cpp:
2512         (WebCore::TextureManager::unprotectTexture):
2513         * platform/graphics/chromium/TextureManager.h:
2514
2515 2011-07-01  Jungshik Shin  <jshin@chromium.org>
2516
2517         Reviewed by Alexey Proskuryakov.
2518
2519         Allow generic font family settings per script code.
2520         https://bugs.webkit.org/show_bug.cgi?id=20797
2521
2522         Make generic font family getters/setters accept an additional
2523         argument (script code). It has a default value so that if an embedder
2524         does not have/want a per-script font family setting, call-sites
2525         don't have to be changed.
2526         This is to prepare for fixing bug 10874 (font selection is not
2527         language-dependent) and bug 18085.
2528
2529         uscript.h has been updated to that of ICU 3.6 (the version of ICU on
2530         Mac OS 10.5)
2531
2532         There should be no change in layout and no new layout test
2533         is added.
2534
2535         * WebCore.exp.in:
2536         * icu/unicode/uscript.h: updated to ICU 4.6
2537         * page/Settings.cpp:
2538         (WebCore::setGenericFontFamilyMap): helper to set generic family per script
2539         (WebCore::getGenericFontFamilyForScript): helper function used by getters for fooFontFamily.
2540         (WebCore::Settings::standardFontFamily):
2541         (WebCore::Settings::setStandardFontFamily):
2542         (WebCore::Settings::fixedFontFamily):
2543         (WebCore::Settings::setFixedFontFamily):
2544         (WebCore::Settings::serifFontFamily):
2545         (WebCore::Settings::setSerifFontFamily):
2546         (WebCore::Settings::sansSerifFontFamily):
2547         (WebCore::Settings::setSansSerifFontFamily):
2548         (WebCore::Settings::cursiveFontFamily):
2549         (WebCore::Settings::setCursiveFontFamily):
2550         (WebCore::Settings::fantasyFontFamily):
2551         (WebCore::Settings::setFantasyFontFamily):
2552         * page/Settings.h: setter and getter for FooFontFamily have a new optional argument, scriptCode.
2553
2554 2011-07-01  Tony Chang  <tony@chromium.org>
2555
2556         Reviewed by Ojan Vafai.
2557
2558         rename StyleFlexibleBoxData to StyleDeprecatedFlexibleBoxData
2559         https://bugs.webkit.org/show_bug.cgi?id=63773
2560
2561         We will have a similar struct to hold CSS3 flexible box data, so
2562         this makes way for the new class.
2563         I will rename the member variable in RenderStyle.h in a follow up
2564         change.
2565
2566         * CMakeLists.txt:
2567         * GNUmakefile.list.am:
2568         * WebCore.gypi:
2569         * WebCore.order:
2570         * WebCore.pro:
2571         * WebCore.vcproj/WebCore.vcproj:
2572         * WebCore.xcodeproj/project.pbxproj:
2573         * rendering/style/RenderStyle.h:
2574         * rendering/style/StyleAllInOne.cpp:
2575         * rendering/style/StyleDeprecatedFlexibleBoxData.cpp:
2576         (WebCore::StyleDeprecatedFlexibleBoxData::StyleDeprecatedFlexibleBoxData):
2577         (WebCore::StyleDeprecatedFlexibleBoxData::operator==):
2578         * rendering/style/StyleDeprecatedFlexibleBoxData.h:
2579         (WebCore::StyleDeprecatedFlexibleBoxData::create):
2580         (WebCore::StyleDeprecatedFlexibleBoxData::copy):
2581         (WebCore::StyleDeprecatedFlexibleBoxData::operator!=):
2582         * rendering/style/StyleRareNonInheritedData.h:
2583
2584 2011-07-01  Hans Wennborg  <hans@chromium.org>
2585
2586         Reviewed by Tony Chang.
2587
2588         IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY
2589         https://bugs.webkit.org/show_bug.cgi?id=63754
2590
2591         Fix values for the webkitIDBTransaction.READ_WRITE/READ_ONLY
2592         constants. Douglas Stockwell pointed out that these were reverse
2593         of what the spec says.
2594
2595         * storage/IDBTransaction.h:
2596         * storage/IDBTransaction.idl:
2597
2598 2011-07-01  Levi Weintraub  <leviw@chromium.org>
2599
2600         Reviewed by Eric Seidel.
2601
2602         Switch positionForPoint to new layout types
2603         https://bugs.webkit.org/show_bug.cgi?id=63774
2604
2605         Switching positionForPoint functions to new layout unit abstraction.
2606
2607         No new tests, no functionality changes.
2608
2609         * rendering/RenderBR.cpp:
2610         (WebCore::RenderBR::positionForPoint):
2611         * rendering/RenderBR.h:
2612         * rendering/RenderBlock.cpp:
2613         (WebCore::RenderBlock::positionForPoint):
2614         * rendering/RenderBlock.h:
2615         * rendering/RenderBox.cpp:
2616         (WebCore::RenderBox::positionForPoint):
2617         * rendering/RenderBox.h:
2618         * rendering/RenderFileUploadControl.cpp:
2619         (WebCore::RenderFileUploadControl::positionForPoint):
2620         * rendering/RenderFileUploadControl.h:
2621         * rendering/RenderInline.cpp:
2622         (WebCore::RenderInline::positionForPoint):
2623         * rendering/RenderInline.h:
2624         * rendering/RenderObject.cpp:
2625         (WebCore::RenderObject::positionForPoint):
2626         * rendering/RenderReplaced.cpp:
2627         (WebCore::RenderReplaced::positionForPoint):
2628         * rendering/RenderReplaced.h:
2629         * rendering/RenderText.cpp:
2630         (WebCore::RenderText::positionForPoint):
2631         * rendering/RenderText.h:
2632         * rendering/RenderTextControlSingleLine.cpp:
2633         (WebCore::RenderTextControlInnerBlock::positionForPoint):
2634         * rendering/RenderTextControlSingleLine.h:
2635         * rendering/svg/RenderSVGInlineText.cpp:
2636         (WebCore::RenderSVGInlineText::positionForPoint):
2637         * rendering/svg/RenderSVGInlineText.h:
2638         * rendering/svg/RenderSVGText.cpp:
2639         (WebCore::RenderSVGText::positionForPoint):
2640         * rendering/svg/RenderSVGText.h:
2641
2642 2011-07-01  Andrew Scherkus  <scherkus@chromium.org>
2643
2644         Reviewed by Darin Fisher.
2645
2646         Re-enable WTF_USE_WEBAUDIO_FFMPEG for Chromium
2647         https://bugs.webkit.org/show_bug.cgi?id=63783
2648
2649         * WebCore.gyp/WebCore.gyp:
2650
2651 2011-07-01  Patrick Gansterer  <paroga@webkit.org>
2652
2653         Reviewed by Daniel Bates.
2654
2655         [CMake] Don't compile unused bindings
2656         https://bugs.webkit.org/show_bug.cgi?id=63741
2657
2658         * UseJSC.cmake: Added IF (ENABLE_XXX) around files.
2659
2660 2011-07-01  Joone Hur  <joone.hur@collabora.co.uk>
2661
2662         Reviewed by Martin Robinson.
2663
2664         [GTK] Add DeviceOrientation feature
2665         https://bugs.webkit.org/show_bug.cgi?id=63720
2666
2667         Add DeviceMotionClientGtk.cpp and DeviceOrientationClientGtk.cpp to WebKitGtk+ build.
2668
2669         * GNUmakefile.am: Add DeviceMotionClientGtk.cpp, DeviceOrientationClientGtk.cpp.
2670
2671 2011-07-01  Kentaro Hara  <haraken@google.com>
2672
2673         Reviewed by Kent Tamura.
2674
2675         Disallow clicking an [X] button in 'search' input forms when 'disabled' attribute or 'readonly' attribute is set.
2676         https://bugs.webkit.org/show_bug.cgi?id=63709
2677
2678         Ignore a cancel button event on a 'search' input form if 'disabled' attribute or
2679         'readonly' attribute is set to the input form.
2680
2681         Test: fast/forms/search-disabled-readonly.html
2682
2683         * html/shadow/TextControlInnerElements.cpp:
2684         (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
2685
2686 2011-06-30  Mikhail Naganov  <mnaganov@chromium.org>
2687
2688         Reviewed by Yury Semikhatsky.
2689
2690         Web Inspector: [Chromium] Fix heap snapshots in a remote debugging session from Safari.
2691         https://bugs.webkit.org/show_bug.cgi?id=63703
2692
2693         * inspector/front-end/HeapSnapshotWorker.js:
2694         (.Function.prototype.bind.return.bound):
2695         (.Function.prototype.bind):
2696
2697 2011-07-01  Dirk Schulze  <krit@webkit.org>
2698
2699         Reviewed by Nikolas Zimmermann.
2700
2701         SVGAnimatedLengthListAnimator does not take additive="sum" into accout
2702         https://bugs.webkit.org/show_bug.cgi?id=63705
2703
2704         Added support for additive animations to SVGAnimatedLengthListAnimator. Don't clear the animatedList if not
2705         necessary.
2706
2707         SVGLength unit gets animated as well now. We used to take the unit of 'from' all the time.
2708
2709         Tests: svg/animations/svglength-animation-unitType.html
2710                svg/animations/svglengthlist-animation-5.html
2711
2712         * svg/SVGAnimatedLength.cpp:
2713         (WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue): Code clean-up and support for unit animation.
2714         * svg/SVGAnimatedLengthList.cpp: Add support for additive animations.
2715         (WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
2716         * svg/SVGLength.cpp:
2717         (WebCore::SVGLength::SVGLength):
2718         (WebCore::SVGLength::setValue): New setValue that gets the LengthType and UnitType as argument for supporting animations of units as well.
2719         * svg/SVGLength.h:
2720
2721 2011-07-01  Dirk Schulze  <krit@webkit.org>
2722
2723         Reviewed by Nikolas Zimmermann.
2724
2725         SVGAnimatedType should support SVGAnimatedInteger animation
2726         https://bugs.webkit.org/show_bug.cgi?id=63789
2727         
2728         Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
2729         This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGAnimatedInteger.
2730         
2731         SVGAnimatedInteger is used for some attributes of SVG filter effects. The animation of those attributes work after this patch.
2732
2733         Test: svg/animations/svginteger-animation-1.html
2734
2735         * CMakeLists.txt: Added file to build system.
2736         * GNUmakefile.list.am: Ditto.
2737         * WebCore.gypi: Ditto.
2738         * WebCore.pro: Ditto.
2739         * WebCore.xcodeproj/project.pbxproj: Ditto.
2740         * svg/SVGAllInOne.cpp: Ditto.
2741         * svg/SVGAnimateElement.cpp: Make use of AnimatedInteger.
2742         (WebCore::SVGAnimateElement::determineAnimatedAttributeType):
2743         (WebCore::SVGAnimateElement::calculateAnimatedValue):
2744         (WebCore::SVGAnimateElement::calculateFromAndToValues):
2745         (WebCore::SVGAnimateElement::calculateFromAndByValues):
2746         (WebCore::SVGAnimateElement::resetToBaseValue):
2747         (WebCore::SVGAnimateElement::applyResultsToTarget):
2748         (WebCore::SVGAnimateElement::calculateDistance):
2749         * svg/SVGAnimatedInteger.cpp: Added. The new animator for SVGAnimatedInteger.
2750         (WebCore::SVGAnimatedIntegerAnimator::SVGAnimatedIntegerAnimator):
2751         (WebCore::SVGAnimatedIntegerAnimator::constructFromString):
2752         (WebCore::SVGAnimatedIntegerAnimator::calculateFromAndToValues):
2753         (WebCore::SVGAnimatedIntegerAnimator::calculateFromAndByValues):
2754         (WebCore::SVGAnimatedIntegerAnimator::calculateAnimatedValue):
2755         (WebCore::SVGAnimatedIntegerAnimator::calculateDistance):
2756         * svg/SVGAnimatedInteger.h:
2757         (WebCore::SVGAnimatedIntegerAnimator::~SVGAnimatedIntegerAnimator):
2758         * svg/SVGAnimatedType.cpp: Added handler for AnimatedInteger.
2759         (WebCore::SVGAnimatedType::~SVGAnimatedType):
2760         (WebCore::SVGAnimatedType::createInteger):
2761         (WebCore::SVGAnimatedType::integer):
2762         (WebCore::SVGAnimatedType::valueAsString):
2763         (WebCore::SVGAnimatedType::setValueAsString):
2764         * svg/SVGAnimatedType.h:
2765         * svg/SVGAnimatorFactory.h:
2766         (WebCore::SVGAnimatorFactory::create):
2767
2768 2011-06-30  Eugene Klyuchnikov  <eustas.bug@gmail.com>
2769
2770         Reviewed by Pavel Feldman.
2771
2772         WebInspector: Performance / memory allocation issue in WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded
2773         https://bugs.webkit.org/show_bug.cgi?id=40447
2774
2775         Test: inspector/editor/text-editor-model-replace-tabs.html
2776
2777         * inspector/front-end/TextEditorModel.js:
2778         (WebInspector.TextEditorModel.prototype._replaceTabsIfNeeded): avoid looped production of tail substrings 
2779
2780 2011-06-30  Kent Tamura  <tkent@chromium.org>
2781
2782         Reviewed by Tony Chang.
2783
2784         [Chromium] Input type="range" slider thumb is rendered upside down on Mac OS X.
2785         https://bugs.webkit.org/show_bug.cgi?id=63697
2786
2787         http://trac.webkit.org/changeset/86261 added a thumb flipping code
2788         for Mac-WebKit2. Chromium also needs it.
2789
2790         * rendering/RenderThemeMac.mm:
2791         (WebCore::RenderThemeMac::paintSliderThumb): Always flip vertically on Chromium.
2792
2793 2011-06-30  Kenichi Ishibashi  <bashi@chromium.org>
2794
2795         Reviewed by Simon Fraser.
2796
2797         [Chromium] -webkit-text-stroke doesn't affect with non-zero width border property
2798         https://bugs.webkit.org/show_bug.cgi?id=63698
2799
2800         Restore the stroke style when it is modified in RenderObject::drawLineForBoxSide() to show text stroke correctly.
2801
2802         Test: platform/chromium/fast/text/text-stroke-with-border.html
2803
2804         * rendering/RenderObject.cpp:
2805         (WebCore::RenderObject::drawLineForBoxSide): Save/restore the stroke style.
2806
2807 2011-06-30  Gwang Yoon Hwang  <ryumiel@company100.net>
2808
2809         Reviewed by Nate Chapin.
2810
2811         [V8] Add ENABLE(INSPECTOR) guards around v8 custom bindings.
2812         https://bugs.webkit.org/show_bug.cgi?id=63442
2813
2814         No new tests needed.
2815
2816         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
2817         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
2818
2819 2011-06-30  Levi Weintraub  <leviw@chromium.org>
2820
2821         Reviewed by Eric Seidel.
2822
2823         Remove positionForCoordinates
2824         https://bugs.webkit.org/show_bug.cgi?id=63765
2825
2826         Removing positionForCoordinate. We should always use positionForPoint. Also cleaning up
2827         RenderBox's implementation of positionForPoint.
2828
2829         No new tests, there should be no functionality changes.
2830
2831         * accessibility/AccessibilityRenderObject.cpp:
2832         (WebCore::AccessibilityRenderObject::stringValue): Removing dead, or at least untested, code and
2833         adding an ASSERT_NOT_REACHED.
2834         (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
2835         * rendering/RenderBox.cpp:
2836         (WebCore::RenderBox::positionForPoint): cleaning up some ugly code.
2837         * rendering/RenderInline.cpp:
2838         (WebCore::RenderInline::positionForPoint):
2839         * rendering/RenderObject.cpp:
2840         * rendering/RenderObject.h:
2841
2842 2011-06-30  Zhenyao Mo  <zmo@google.com>
2843
2844         Reviewed by Kenneth Russell.
2845
2846         Improve WebGL object lifetime management in WebGLRenderingContext
2847         https://bugs.webkit.org/show_bug.cgi?id=63635
2848
2849         * html/canvas/WebGLRenderingContext.cpp:
2850         (WebCore::WebGLRenderingContext::getAttachedShaders): Use cached objects instead of querying the underlying GL.
2851         (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Ditto.
2852         (WebCore::WebGLRenderingContext::detachAndRemoveAllObjects): Multiple loop because objects might be removed from the table within an iteration.
2853         * html/canvas/WebGLRenderingContext.h:
2854
2855 2011-06-30  Rafael Brandao  <rafael.lobo@openbossa.org>
2856
2857         Reviewed by Andreas Kling.
2858
2859         [Qt] build-webkit warning: cannot find file ElementShadowPseudoId.h
2860         https://bugs.webkit.org/show_bug.cgi?id=63747
2861
2862         Removed reference to ElementShadowPseudoId.h that no longer exists.
2863
2864         * WebCore.pro:
2865
2866 2011-06-30  Anders Carlsson  <andersca@apple.com>
2867
2868         Fix clang build.
2869
2870         Remove the complete Widget constructor from the .exp.in file; since Widget is an abstract class,
2871         its complete constructor can never be called and clang has stopped emitting it altogether.
2872
2873         * WebCore.exp.in:
2874
2875 2011-06-30  Levi Weintraub  <leviw@chromium.org>
2876
2877         Reviewed by Eric Seidel.
2878
2879         Switch paintingRootRect and RenderObject repaint methods to new layout types
2880         https://bugs.webkit.org/show_bug.cgi?id=63746
2881
2882         Switching paintingRootRect and RenderObject repaint functions over to the
2883         new layout unit abstraction.
2884
2885         No new tests, no functionality changes.
2886
2887         * rendering/RenderBox.cpp:
2888         (WebCore::RenderBox::repaintDuringLayoutIfMoved):
2889         * rendering/RenderBox.h:
2890         * rendering/RenderObject.cpp:
2891         (WebCore::RenderObject::paintingRootRect):
2892         (WebCore::RenderObject::paint):
2893         (WebCore::RenderObject::repaintUsingContainer):
2894         (WebCore::RenderObject::repaintRectangle):
2895         (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
2896         (WebCore::RenderObject::repaintDuringLayoutIfMoved):
2897         * rendering/RenderObject.h:
2898
2899 2011-06-30  Cary Clark  <caryclark@google.com>
2900
2901         Reviewed by James Robinson.
2902
2903         Use Skia if Skia on Mac Chrome is enabled
2904         https://bugs.webkit.org/show_bug.cgi?id=62999
2905
2906         No new tests. This does not affect existing
2907         functionality.
2908
2909         * WebCore.gyp/WebCore.gyp:
2910         Include Skia and related files and exclude CG
2911         and related files when building Chromium for Skia
2912         on the Mac.
2913
2914         * loader/cache/CachedFont.cpp:
2915         Rename CHROME to CHROMIUM.
2916
2917         * platform/chromium/DragImageRef.h:
2918         * platform/graphics/FloatPoint.h:
2919         * platform/graphics/FloatRect.h:
2920         * platform/graphics/FloatSize.h:
2921         * platform/graphics/FontPlatformData.h:
2922         (WebCore::FontPlatformData::hash):
2923         * platform/graphics/GlyphBuffer.h:
2924         (WebCore::GlyphBuffer::advanceAt):
2925         (WebCore::GlyphBuffer::add):
2926         (WebCore::GlyphBuffer::expandLastAdvance):
2927         * platform/graphics/IntPoint.h:
2928         * platform/graphics/IntRect.h:
2929         * platform/graphics/IntSize.h:
2930         * platform/graphics/SimpleFontData.h:
2931         * platform/graphics/cg/FloatPointCG.cpp:
2932         * platform/graphics/cg/FloatRectCG.cpp:
2933         * platform/graphics/cg/FloatSizeCG.cpp:
2934         * platform/graphics/cg/IntPointCG.cpp:
2935         * platform/graphics/cg/IntRectCG.cpp:
2936         * platform/graphics/cg/IntSizeCG.cpp:
2937         * platform/graphics/mac/FontCustomPlatformData.cpp:
2938         (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
2939         (WebCore::createFontCustomPlatformData):
2940         * platform/graphics/mac/FontCustomPlatformData.h:
2941         (WebCore::FontCustomPlatformData::FontCustomPlatformData):
2942         Ditto.
2943
2944 2011-06-30  Julien Chaffraix  <jchaffraix@webkit.org>
2945
2946         Reviewed by Nikolas Zimmermann.
2947
2948         Update SVG position values on SVG DOM updates
2949         https://bugs.webkit.org/show_bug.cgi?id=62439
2950
2951         Test: svg/custom/crash-textPath-attributes.html
2952
2953         * rendering/svg/RenderSVGInline.cpp:
2954         (WebCore::RenderSVGInline::destroy): Notify our containing RenderSVGText that it needs
2955         to update its positioning information.
2956
2957         * rendering/svg/SVGInlineFlowBox.cpp:
2958         (WebCore::SVGInlineFlowBox::calculateBoundaries): Check the type of the InlineBox
2959         like the rest of the code (fixes an ASSERT_NOT_REACHED in InlineBox::calculateBoudaries).
2960
2961         * rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
2962         (WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextSubtree): Clear
2963         our cached layout attributes every time we invalidate them. This avoids keeping stale
2964         attribute that have a backpointer to a RenderObject.
2965
2966 2011-06-30  Sreeram Ramachandran  <sreeram@chromium.org>
2967
2968         Reviewed by Adam Barth.
2969
2970         Suppress modal JavaScript/HTML dialogs during unload events
2971         https://bugs.webkit.org/show_bug.cgi?id=56397
2972
2973         Allows clients to specify whether to show alerts during unload handlers.
2974         When checking for whether a page dismissal event is being dispatched,
2975         it's important to check all frames on the page (otherwise it becomes a
2976         loophole easily exploited).
2977
2978         Test: fast/loader/page-dismissal-modal-dialogs.html
2979
2980         * loader/FrameLoader.cpp:
2981         (WebCore::FrameLoader::FrameLoader):
2982         (WebCore::FrameLoader::stopLoading):
2983         (WebCore::FrameLoader::loadURL):
2984         (WebCore::FrameLoader::loadWithDocumentLoader):
2985         (WebCore::FrameLoader::stopAllLoaders):
2986         (WebCore::FrameLoader::fireBeforeUnloadEvent):
2987         * loader/FrameLoader.h:
2988         (WebCore::FrameLoader::pageDismissalEventBeingDispatched):
2989         * loader/cache/CachedResourceLoader.cpp:
2990         (WebCore::CachedResourceLoader::requestImage):
2991         * page/Chrome.cpp:
2992         (WebCore::canRunModalIfDuringPageDismissal):
2993         (WebCore::Chrome::canRunModalNow):
2994         (WebCore::Chrome::runJavaScriptAlert):
2995         (WebCore::Chrome::runJavaScriptConfirm):
2996         (WebCore::Chrome::runJavaScriptPrompt):
2997         * page/Chrome.h:
2998         * page/ChromeClient.h:
2999         (WebCore::ChromeClient::shouldRunModalDialogDuringPageDismissal):
3000         * page/DOMWindow.cpp:
3001         (WebCore::DOMWindow::showModalDialog):
3002
3003 2011-06-30  Julien Chaffraix  <jchaffraix@webkit.org>
3004
3005         Reviewed by Nikolas Zimmermann.
3006
3007         Assertion failure in RenderSVGInlineText::characterStartsNewTextChunk
3008         https://bugs.webkit.org/show_bug.cgi?id=63076
3009
3010         Tests: svg/custom/crash-text-in-textpath.svg
3011                svg/custom/text-node-in-text-invalidated.svg
3012
3013         The problem was that we did not call setNeedsPositionUpdate on RenderSVGText. When
3014         doing our layout, we would not update the attributes on our SVGRenderInlineText as
3015         we would not lay it out.
3016
3017         This was caused by childrenChanged being overridden on SVGTextPositioningElement but
3018         not on SVGTextPathElement.
3019
3020         As both classes shared the same mother class, it made sense to move the logic here.
3021         There should be no other side effects as SVGTextPathElement and SVGTextPositioningElement
3022         are the only classes deriving from SVGTextContentElement.
3023
3024         * svg/SVGTextContentElement.cpp:
3025         (WebCore::SVGTextContentElement::childrenChanged): Moved this method from SVGTextPositioningElement.
3026         * svg/SVGTextContentElement.h:
3027         * svg/SVGTextPositioningElement.cpp:
3028         (WebCore::SVGTextPositioningElement::svgAttributeChanged): Updated after updatePositioningValuesInRenderer
3029         removal, replaced by RenderSVGText::locateRenderSVGTextAncestor.
3030         * svg/SVGTextPositioningElement.h:
3031
3032 2011-06-30  Patrick Gansterer  <paroga@webkit.org>
3033
3034         Unreviewed build fix for !ENABLE(DATABASE) after r84789.
3035
3036         * bindings/js/JSDOMBinding.cpp:
3037
3038 2011-06-30  Anders Carlsson  <andersca@apple.com>
3039
3040         Reviewed by Dan Bernstein.
3041
3042         More ScrollableArea scaffolding
3043         https://bugs.webkit.org/show_bug.cgi?id=63678
3044
3045         Add a way to get the enclosing scrollable area for a given scrollable area.
3046         Also, add ScrollableArea::isPinnedInDirectionOfScrollDelta.
3047
3048         * page/FrameView.cpp:
3049         (WebCore::FrameView::enclosingScrollableArea):
3050         Return 0 for now.
3051
3052         * page/FrameView.h:
3053         Add FrameView::enclosingScrollableArea.
3054
3055         * platform/ScrollableArea.cpp:
3056         (WebCore::ScrollableArea::isPinnedInDirectionOfScrollDelta):
3057         Return whether the area is pinned in the direction of the scroll delta.
3058
3059         * platform/ScrollableArea.h:
3060         Add new member functions.
3061
3062         * platform/chromium/FramelessScrollView.cpp:
3063         (WebCore::FramelessScrollView::enclosingScrollableArea):
3064         * platform/chromium/FramelessScrollView.h:
3065         Add stub.
3066
3067         * platform/win/PopupMenuWin.h:
3068         (WebCore::PopupMenuWin::enclosingScrollableArea):
3069         Always return 0.
3070
3071         * rendering/RenderLayer.cpp:
3072         (WebCore::RenderLayer::enclosingScrollableLayer):
3073         Add helper function.
3074
3075         (WebCore::RenderLayer::scrollByRecursively):
3076         Use the new enclosingScrollableLayer helper function.
3077
3078         (WebCore::RenderLayer::enclosingScrollableArea):
3079         Return the enclosing scrollable area.
3080
3081         * rendering/RenderLayer.h:
3082         Add new member function.
3083
3084         * rendering/RenderListBox.cpp:
3085         (WebCore::RenderListBox::enclosingScrollableArea):
3086         Return 0 for now.
3087         
3088         * rendering/RenderListBox.h:
3089         Add new member function.
3090
3091 2011-06-30  Martin Robinson  <mrobinson@igalia.com>
3092
3093         Reviewed by Anders Carlsson.
3094
3095         [GTK] Crash observed with nspluginwrapper and flash
3096         https://bugs.webkit.org/show_bug.cgi?id=62249
3097
3098         Test: plugins/invalidate-rect-with-null-npp-argument.html
3099
3100         * plugins/npapi.cpp:
3101         (NPN_InvalidateRect): Guard against null instances here.
3102
3103 2011-06-30  Levi Weintraub  <leviw@chromium.org>
3104
3105         Reviewed by Eric Seidel.
3106
3107         Switch availableWidth/Height, logicalLeft/RightOffsetForLine to new layout types
3108         https://bugs.webkit.org/show_bug.cgi?id=63671
3109
3110         Switch availableWidth/Height, logicalLeft/RightOffsetForLine functions over to the
3111         new layout unit abstraction.
3112
3113         No new tests, no functionality changes.
3114
3115         * rendering/RenderBlock.cpp:
3116         (WebCore::RenderBlock::logicalLeftOffsetForLine):
3117         (WebCore::RenderBlock::logicalRightOffsetForLine):
3118         (WebCore::RenderBlock::availableLogicalWidthForLine):
3119         (WebCore::RenderBlock::availableLogicalWidth):
3120         * rendering/RenderBlock.h:
3121         (WebCore::RenderBlock::logicalRightOffsetForLine):
3122         (WebCore::RenderBlock::logicalLeftOffsetForLine):
3123         (WebCore::RenderBlock::startOffsetForLine):
3124         * rendering/RenderBox.cpp:
3125         (WebCore::RenderBox::availableLogicalHeight):
3126         (WebCore::RenderBox::availableLogicalHeightUsing):
3127         * rendering/RenderBox.h:
3128         (WebCore::RenderBox::availableLogicalWidth):
3129         (WebCore::RenderBox::availableWidth):
3130         (WebCore::RenderBox::availableHeight):
3131
3132 2011-06-30  Adam Barth  <abarth@webkit.org>
3133
3134         Remove useless ASSERT that breaks the build.
3135
3136         * dom/StyledElement.cpp:
3137         (WebCore::parseColorStringWithCrazyLegacyRules):
3138
3139 2011-06-30  Tab Atkins  <jackalmage@gmail.com>
3140
3141         Reviewed by Adam Barth.
3142
3143         Fix legacy color attribute parsing to match HTML spec
3144         https://bugs.webkit.org/show_bug.cgi?id=63029
3145
3146         Relevant spec link: http://www.whatwg.org/specs/web-apps/current-work/complete/common-microsyntaxes.html#rules-for-parsing-a-legacy-color-value
3147         Fix legacy color attribute parsing (<body bgcolor>, <font color>, etc.) to match the HTML spec and more closely match other browsers.
3148
3149         Test: fast/dom/attribute-legacy-colors.html
3150
3151         * dom/StyledElement.cpp:
3152         (WebCore::StyledElement::addCSSColor):
3153
3154 2011-06-28  Hans Wennborg  <hans@chromium.org>
3155
3156         Reviewed by Tony Chang.
3157
3158         IndexedDB: Prepare for running layout tests with LevelDB
3159         https://bugs.webkit.org/show_bug.cgi?id=63593
3160
3161         Migration of data from SQLite to LevelDB must be done before the
3162         m_backingStore map is checked for an open LevelDB, because if a
3163         previous layout test has used LevelDB, it will be in the
3164         m_backingStore map.
3165
3166         Covered by existing layout tests.
3167
3168         * storage/IDBFactoryBackendImpl.cpp:
3169         (WebCore::IDBFactoryBackendImpl::open):
3170
3171 2011-06-30  Pavel Feldman  <pfeldman@chromium.org>
3172
3173         Reviewed by Yury Semikhatsky.
3174
3175         Web Inspector: introduce "filter" icons for timeline panel and elements sidebar.
3176         https://bugs.webkit.org/show_bug.cgi?id=63731
3177
3178         * inspector/front-end/EventListenersSidebarPane.js:
3179         * inspector/front-end/Images/paneFilterButtons.png: Added.
3180         * inspector/front-end/Images/statusbarButtonGlyphs.png:
3181         * inspector/front-end/StylesSidebarPane.js:
3182         * inspector/front-end/inspector.css:
3183         (.pane > .title > select):
3184         (.pane > .title > select.select-settings):
3185         (.pane > .title > select.select-filter):
3186         (.timeline-filter-status-bar-item .glyph):
3187
3188 2011-06-28  Hans Wennborg  <hans@chromium.org>
3189
3190         Reviewed by Tony Chang.
3191
3192         IndexedDB: Support for deleteIndex with LevelDB backing store
3193         https://bugs.webkit.org/show_bug.cgi?id=63539
3194
3195         Covered by storage/indexeddb/mozilla/remove-index.html.
3196
3197         * storage/IDBLevelDBBackingStore.cpp:
3198         (WebCore::IDBLevelDBBackingStore::deleteIndex):
3199
3200 2011-06-30  Abhishek Arya  <inferno@chromium.org>
3201
3202         Reviewed by Ryosuke Niwa.
3203
3204         Crash when calling DOMSubtreeModified event when extracting range
3205         contents.
3206         https://bugs.webkit.org/show_bug.cgi?id=63650
3207
3208         Convert a few nodes to RefPtrs and add commonRoot verification checks
3209         for Range::processContents.
3210
3211         Tests: fast/dom/Range/range-extract-contents-event-fire-crash.html
3212                fast/dom/Range/range-extract-contents-event-fire-crash2.html
3213
3214         * dom/Range.cpp:
3215         (WebCore::childOfCommonRootBeforeOffset):
3216         (WebCore::Range::processContents):
3217         (WebCore::Range::processContentsBetweenOffsets):
3218         (WebCore::Range::processAncestorsAndTheirSiblings):
3219
3220 2011-06-30  Dan Bernstein  <mitz@apple.com>
3221
3222         Reviewed by Adele Peterson.
3223
3224         Add +[WebView _allowsRoundingHacks]
3225         https://bugs.webkit.org/show_bug.cgi?id=63734
3226
3227         * WebCore.exp.in: Export TextRun::allowsRoundingHacks().
3228         * platform/graphics/TextRun.cpp:
3229         (WebCore::TextRun::allowsRoundingHacks): Added this accessor.
3230         * platform/graphics/TextRun.h:
3231
3232 2011-06-30  Patrick Gansterer  <paroga@webkit.org>
3233
3234         Reviewed by Adam Roben.
3235
3236         [WIN] Don't redefine the keyboard codes
3237         https://bugs.webkit.org/show_bug.cgi?id=63726
3238
3239         Only define the codes when undefined.
3240         r64957 fixed this problem for COMPILER(MINGW) but not for OS(WINCE).
3241
3242         * platform/WindowsKeyboardCodes.h:
3243
3244 2011-06-30  Yury Semikhatsky  <yurys@chromium.org>
3245
3246         Reviewed by Pavel Feldman.
3247
3248         Web Inspector: hide "Enabled background events collection" option in context menu until the setting is persisted
3249         https://bugs.webkit.org/show_bug.cgi?id=63708
3250
3251         The option has no much sense if it is not preserved between browser restarts.
3252
3253         * inspector/front-end/NetworkPanel.js:
3254         (WebInspector.NetworkPanel.prototype._contextMenu):
3255
3256 2011-06-30  Patrick Gansterer  <paroga@webkit.org>
3257
3258         Reviewed by Darin Adler.
3259
3260         Remove dependnecy on IDL generation for disabled features in JSC bindings
3261         https://bugs.webkit.org/show_bug.cgi?id=63718
3262
3263         Move the #if ENABLE() line directly after #include "config.h".
3264         This enables us to compile all files even when we don't generate the IDL output.
3265
3266         * bindings/js/IDBBindingUtilities.cpp:
3267         * bindings/js/JSConsoleCustom.cpp:
3268         * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
3269         * bindings/js/JSCustomXPathNSResolver.cpp:
3270         * bindings/js/JSDOMApplicationCacheCustom.cpp:
3271         * bindings/js/JSDeviceMotionEventCustom.cpp:
3272         * bindings/js/JSDeviceOrientationEventCustom.cpp:
3273         * bindings/js/JSInjectedScriptHostCustom.cpp:
3274         * bindings/js/JSInjectedScriptManager.cpp:
3275         * bindings/js/JSInspectorFrontendHostCustom.cpp:
3276         * bindings/js/JSJavaScriptCallFrameCustom.cpp:
3277         * bindings/js/JSSQLResultSetRowListCustom.cpp:
3278         * bindings/js/JSSQLTransactionCustom.cpp:
3279         * bindings/js/JSSQLTransactionSyncCustom.cpp:
3280         * bindings/js/JSSVGElementInstanceCustom.cpp:
3281         * bindings/js/JSStorageCustom.cpp:
3282         * bindings/js/JSTouchCustom.cpp:
3283         * bindings/js/JSTouchListCustom.cpp:
3284         * bindings/js/JSXPathResultCustom.cpp:
3285         * bindings/js/JavaScriptCallFrame.cpp:
3286         * bindings/js/PageScriptDebugServer.cpp:
3287         * bindings/js/ScriptDebugServer.cpp:
3288         * bindings/js/ScriptGCEvent.cpp:
3289         * bindings/js/ScriptProfile.cpp:
3290         * bindings/js/WorkerScriptDebugServer.cpp:
3291
3292 2011-06-30  Alexander Pavlov  <apavlov@chromium.org>
3293
3294         Reviewed by Kent Tamura.
3295
3296         [Chromium] Autofill suggestions appear in upper left corner after input change
3297         https://bugs.webkit.org/show_bug.cgi?id=63702
3298
3299         This change fixes a few popup layout issues, some of which have existed for quite a while:
3300         - the absence of the ChromeClientImpl::screenToWindow() implementation (the method used to always return (0, 0));
3301         - the confusion of window and screen coordinates passed into the autofill popup client's setWindowRect() method;
3302         - the use of the current frameRect() width as the target element's width (which was wrong when refreshing
3303           a popup resized during the initial layout (e.g. made wider than the target element)).
3304
3305         No new tests, as this is a change to platform-specific widget code. The test case is provided in the bug description.
3306
3307         * platform/chromium/PopupMenuChromium.cpp:
3308         (WebCore::PopupContainer::layoutAndGetRTLOffset): Use original target element width, not frameRect().width(),
3309         since the latter gets updated if the popup is not the same width as the target element.
3310         (WebCore::PopupContainer::refresh): Restore only the popup bounds rather than its original rectangle,
3311         since it sometimes breaks the invalidation region and layout.
3312
3313 2011-06-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3314
3315         Unreviewed, rolling out r90102.
3316         http://trac.webkit.org/changeset/90102
3317         https://bugs.webkit.org/show_bug.cgi?id=63714
3318
3319         Lots of tests asserting beneath
3320         SVGSMILElement::findInstanceTime (Requested by aroben on
3321         #webkit).
3322
3323         * svg/animation/SVGSMILElement.cpp:
3324         (WebCore::SVGSMILElement::findInstanceTime):
3325
3326 2011-06-30  Andrey Kosyakov  <caseq@chromium.org>
3327
3328         Reviewed by Yury Semikhatsky.
3329
3330         Web Inspector: remove ExtensionAPISchema.json
3331         https://bugs.webkit.org/show_bug.cgi?id=63687
3332
3333         * inspector/front-end/ExtensionAPISchema.json: Removed.
3334
3335 2011-06-30  Ilya Tikhonovsky  <loislo@chromium.org>
3336
3337         Unreviewed build fix for chromium.
3338
3339         * inspector/CodeGeneratorInspector.pm:
3340
3341 2011-06-30  Ilya Tikhonovsky  <loislo@chromium.org>
3342
3343         Unreviewed build fix for mac.
3344
3345         * inspector/CodeGeneratorInspector.pm:
3346
3347 2011-06-30  Ilya Tikhonovsky  <loislo@chromium.org>
3348
3349         Reviewed by Pavel Feldman.
3350
3351         Web Inspector: Protocol: error object needs some improvement.
3352         https://bugs.webkit.org/show_bug.cgi?id=63707
3353
3354         Current implementation is not useful in the code.
3355         We need to have toString implementation with nice formatting
3356         I'd like to use error.message property as the main place for the error's text.
3357
3358         * inspector/CodeGeneratorInspector.pm:
3359
3360 2011-06-30  Mikhail Naganov  <mnaganov@chromium.org>
3361
3362         Reviewed by Yury Semikhatsky.
3363
3364         Web Inspector: [Chromium] Support annotations for arrays in heap profiler.
3365         https://bugs.webkit.org/show_bug.cgi?id=63690
3366
3367         * inspector/front-end/DetailedHeapshotGridNodes.js:
3368         (WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
3369
3370
3371 2011-06-30  Patrick Gansterer  <paroga@webkit.org>
3372
3373         Unreviewed build fix for !ENABLE(SVG_ANIMATION) after r88663, r89187, r89220, r89431 and r89661.
3374
3375         * svg/SVGAnimatedAngle.h:
3376         * svg/SVGAnimatedLength.h:
3377         * svg/SVGAnimatedNumber.h:
3378         * svg/SVGAnimatedRect.h:
3379         * svg/SVGAnimatedString.h:
3380
3381 2011-06-30  Gabor Loki  <loki@webkit.org>
3382
3383         Reviewed by Csaba Osztrogon√°c.
3384
3385         Fixed several style and typo issues after r90091.
3386         https://bugs.webkit.org/show_bug.cgi?id=63692
3387
3388         Rename yStart to extremaStartY during computing extremas
3389
3390         * platform/graphics/filters/FEMorphology.cpp:
3391         (WebCore::FEMorphology::platformApplyGeneric):
3392         * platform/graphics/filters/FEMorphology.h:
3393
3394 2011-06-30  Oliver Varga  <Varga.Oliver@stud.u-szeged.hu>
3395
3396         Reviewed by Nikolas Zimmermann.
3397
3398         Speed up SVGSMILElement::findInstanceTime.
3399         https://bugs.webkit.org/show_bug.cgi?id=61025
3400
3401         Replace the linear search to binary search on ordered list because
3402         the previous searches from the beginning was not efficient.
3403
3404         No new tests this is only a performance tweak.
3405
3406         * svg/animation/SVGSMILElement.cpp:
3407         (WebCore::extractTimeFromVector):
3408         (WebCore::SVGSMILElement::findInstanceTime):
3409
3410 2011-06-30  Kentaro Hara  <haraken@google.com>
3411
3412         Reviewed by Kent Tamura.
3413
3414         Change the label of an HTML5 file chooser button to "Choose Files"
3415         https://bugs.webkit.org/show_bug.cgi?id=49245
3416
3417         We should notify capability of multiple files to users.
3418
3419         Test: fast/forms/input-file-label.html
3420
3421         * English.lproj/Localizable.strings:
3422         * html/FileInputType.cpp:
3423         (WebCore::UploadButtonElement::createForMultiple): Constructs a multiple file chooser button.
3424         (WebCore::FileInputType::createShadowSubtree): Constructs a single/multiple file chooser button depending on 'multiple' attribute.
3425         (WebCore::FileInputType::multipleAttributeChanged): Updates the label of the file chooser button.
3426         * html/FileInputType.h:
3427         * html/HTMLInputElement.cpp:
3428         (WebCore::HTMLInputElement::parseMappedAttribute): Updates the shadow tree of the file chooser button when 'multiple' attribute is set or unset.
3429         * html/InputType.cpp:
3430         (WebCore::InputType::multipleAttributeChanged): Virtual method to be overridden by FileInputType.
3431         * html/InputType.h:
3432         * platform/DefaultLocalizationStrategy.cpp:
3433         (WebCore::DefaultLocalizationStrategy::fileButtonChooseFileLabel): Updated the description for "Choose File".
3434         (WebCore::DefaultLocalizationStrategy::fileButtonChooseMultipleFilesLabel): Returns a string "Choose Files".
3435         * platform/DefaultLocalizationStrategy.h:
3436         * platform/LocalizationStrategy.h:
3437         * platform/LocalizedStrings.cpp:
3438         (WebCore::fileButtonChooseMultipleFilesLabel): Wrapper method for getting the "Choose Files" label.
3439         * platform/LocalizedStrings.h:
3440         * platform/brew/LocalizedStringsBrew.cpp:
3441         (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
3442         * platform/efl/LocalizedStringsEfl.cpp:
3443         (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
3444         * platform/gtk/LocalizedStringsGtk.cpp:
3445         (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
3446         * platform/haiku/LocalizedStringsHaiku.cpp:
3447         (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
3448         * platform/wx/LocalizedStringsWx.cpp:
3449         (WebCore::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
3450
3451 2011-06-30  Ryosuke Niwa  <rniwa@webkit.org>
3452
3453         Reviewed by Kent Tamura.
3454
3455         Replace isNodeInTextFormControl(Node*) by enclosingTextFormControl(const Position&)
3456         https://bugs.webkit.org/show_bug.cgi?id=63672
3457
3458         Replaced isNodeInTextFormControl(Node*) by enclosingTextFormControl(const Position&).
3459         Also added a safe toTextFormControl to HTMLFormControlElement.h.
3460
3461         * editing/DeleteSelectionCommand.cpp:
3462         (WebCore::DeleteSelectionCommand::doApply): Calls enclosingTextFormControl instead of manually
3463         checking the tag name of shadowAncestorNode.
3464         * editing/Editor.cpp:
3465         (WebCore::Editor::selectionForCommand): Rewritten using enclosingTextFormControl and toTextFormControl.
3466         (WebCore::Editor::cut): Calls enclosingTextFormControl instead of isNodeInTextFormControl.
3467         (WebCore::Editor::copy): Ditto.
3468         (WebCore::Editor::setBaseWritingDirection): Calls toTextFormControl instead of manually checking tag name.
3469         * editing/FrameSelection.cpp:
3470         (WebCore::FrameSelection::isInPasswordField): Calls enclosingTextFormControl.
3471         * editing/ReplaceSelectionCommand.cpp:
3472         (WebCore::ReplaceSelectionCommand::doApply): Ditto.
3473         * editing/htmlediting.cpp:
3474         (WebCore::enclosingTextFormControl): Added.
3475         * editing/htmlediting.h:
3476         * html/HTMLFormControlElement.h:
3477         (WebCore::toTextFormControl): Added.
3478         * page/DragController.cpp:
3479         (WebCore::DragController::startDrag): Calls enclosingTextFormControl instead of isNodeInTextFormControl.
3480
3481 2011-06-27  Pavel Podivilov  <podivilov@chromium.org>
3482
3483         Reviewed by Pavel Feldman.
3484
3485         Web Inspector: source code is not highlighted after drawer height animations.
3486         https://bugs.webkit.org/show_bug.cgi?id=62860
3487
3488         * inspector/front-end/Drawer.js:
3489         (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):
3490         (WebInspector.Drawer.prototype._animateDrawerHeight):
3491
3492 2011-06-30  MORITA Hajime  <morrita@google.com>
3493
3494         Reviewed by Dimitri Glazkov.
3495