Crash in WebCore::RenderTableSection::addChild due to assert failure
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-10-25  Fady Samuel  <fsamuel@chromium.org>
2
3         Crash in WebCore::RenderTableSection::addChild due to assert failure
4         https://bugs.webkit.org/show_bug.cgi?id=70678
5
6         Reviewed by David Hyatt.
7
8         Tests: fast/table/table-anonymous-cell-bug.html
9                fast/table/table-anonymous-row-bug.html
10                fast/table/table-anonymous-section-bug.html
11
12         If the child being added is not a Section/Row/Cell, and the previous sibling is not anonymous, 
13         we need to create a new anonymous Section/Row/Cell respectively, instead of failing an
14         assert.
15
16         * rendering/RenderTable.cpp:
17         (WebCore::RenderTable::addChild):
18         * rendering/RenderTableRow.cpp:
19         (WebCore::RenderTableRow::addChild):
20         * rendering/RenderTableSection.cpp:
21         (WebCore::RenderTableSection::addChild):
22
23 2011-10-25  Mark Hahnenberg  <mhahnenberg@apple.com>
24
25         Add getOwnPropertySlot to MethodTable
26         https://bugs.webkit.org/show_bug.cgi?id=69807
27
28         Reviewed by Oliver Hunt.
29
30         No new tests.
31
32         * bridge/runtime_method.h: Changed getOwnPropertySlot to be protected so 
33         subclasses can reference it in their MethodTables.
34
35 2011-10-25  Simon Fraser  <simon.fraser@apple.com>
36
37         REGRESSION (r88580): Cursor fails to change to pointer on embedded Google maps popups
38         https://bugs.webkit.org/show_bug.cgi?id=62797
39
40         Reviewed by Chris Marrin.
41         
42         When hit testing through transformed layers, RenderLayer would simply use
43         the composited bounds of the layer as the localHitTestRect for hit testing sublayers.
44         However, this broke hit testing on pages that have a composited, non-transformed layer
45         which falls outside the bounds of its parent, composited-transformed layer, like Google
46         Maps.
47         
48         Fix by mapping the hitTestRect through transforms. However this is tricky, because
49         mapping a rect into the coordinate system of a layer can result in invalid rectangles
50         when point projection results in a negative w component. Fix TransformationMatrix::projectPoint()
51         to detect this case and replace X and Y with large values, and add boundsOfProjectedQuad(), which 
52         maps rectangles with possibly-infinite location or bounds into rects which are representable
53         in an IntRect.
54
55         Tests: transforms/3d/hit-testing/composited-hit-test.html
56                transforms/3d/hit-testing/rotated-hit-test-with-child.html
57                transforms/3d/hit-testing/rotated-hit-test2.html
58
59         * platform/graphics/transforms/TransformationMatrix.cpp:
60         (WebCore::TransformationMatrix::projectPoint):
61         (WebCore::TransformationMatrix::projectQuad):
62         (WebCore::clampEdgeValue):
63         (WebCore::TransformationMatrix::boundsOfProjectedQuad):
64         * platform/graphics/transforms/TransformationMatrix.h:
65         * rendering/HitTestingTransformState.cpp:
66         (WebCore::HitTestingTransformState::boundsOfMappedQuad):
67         * rendering/HitTestingTransformState.h:
68         * rendering/RenderLayer.cpp:
69         (WebCore::RenderLayer::hitTestLayer):
70
71 2011-10-25  Adrienne Walker  <enne@google.com>
72
73         [chromium] Batch up texture uploads so that they can be updated incrementally
74         https://bugs.webkit.org/show_bug.cgi?id=70454
75
76         Reviewed by James Robinson.
77
78         Because texture uploads can sometimes take more than a frame to
79         complete, collect all the uploads that need to occur in a
80         CCTextureUpdater so that we can easily incrementally upload some of
81         them, interleaving input and drawing so that the compositor thread
82         continues to appear responsive during a commit.
83
84         This change doesn't actually interleave the commits, it just pushes
85         the infrastructure for doing so up to the CCProxy level so that a
86         future scheduler can make this decision.
87
88         VideoLayerChromium is the only layer type to not use this system. It
89         needs to be converted to use a texture updater first and it is less of
90         a priority than the tiled layers.
91
92         * WebCore.gypi:
93         * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
94         (WebCore::Canvas2DLayerChromium::updateCompositorResources):
95         * platform/graphics/chromium/Canvas2DLayerChromium.h:
96         * platform/graphics/chromium/LayerChromium.h:
97         (WebCore::LayerChromium::updateCompositorResources):
98         * platform/graphics/chromium/TiledLayerChromium.cpp:
99         (WebCore::TiledLayerChromium::updateCompositorResources):
100         * platform/graphics/chromium/TiledLayerChromium.h:
101         * platform/graphics/chromium/VideoLayerChromium.cpp:
102         (WebCore::VideoLayerChromium::updateCompositorResources):
103         * platform/graphics/chromium/VideoLayerChromium.h:
104         * platform/graphics/chromium/WebGLLayerChromium.cpp:
105         (WebCore::WebGLLayerChromium::updateCompositorResources):
106         * platform/graphics/chromium/WebGLLayerChromium.h:
107         * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
108         (WebCore::CCLayerTreeHost::beginCommitOnImplThread):
109         (WebCore::CCLayerTreeHost::finishCommitOnImplThread):
110         (WebCore::CCLayerTreeHost::updateCompositorResources):
111         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
112         * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
113         (WebCore::CCSingleThreadProxy::setNeedsCommit):
114         (WebCore::CCSingleThreadProxy::doCommit):
115         (WebCore::CCSingleThreadProxy::commitIfNeeded):
116         * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
117         * platform/graphics/chromium/cc/CCTextureUpdater.cpp: Added.
118         (WebCore::CCTextureUpdater::CCTextureUpdater):
119         (WebCore::CCTextureUpdater::~CCTextureUpdater):
120         (WebCore::CCTextureUpdater::append):
121         (WebCore::CCTextureUpdater::update):
122         (WebCore::CCTextureUpdater::clear):
123         * platform/graphics/chromium/cc/CCTextureUpdater.h: Added.
124         (WebCore::CCTextureUpdater::allocator):
125         * platform/graphics/chromium/cc/CCThreadProxy.cpp:
126         (WebCore::CCThreadProxy::commitOnImplThread):
127
128 2011-10-24  Jer Noble  <jer.noble@apple.com>
129
130         compositing/video tests time out on Lion
131         https://bugs.webkit.org/show_bug.cgi?id=70448
132
133         Reviewed by Simon Fraser.
134
135         AVFoundation will not begin loading or decoding media until a consumer for that media is present.
136         For video-only media, this means that an AVPlayerLayer must be created and attached to the 
137         AVPlayer before the load state will ever reach "canPlayThrough". Once the metadata for a media
138         is loaded, create a AVPlayerLayer if the media has a video track.
139
140         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
141         (WebCore::MediaPlayerPrivateAVFoundation::updateStates):
142
143 2011-10-24  Ryosuke Niwa  <rniwa@webkit.org>
144
145         Merge endOfLine with logicalEndOfLine and startOfLine with logicalStartOfLine
146         https://bugs.webkit.org/show_bug.cgi?id=70755
147
148         Reviewed by Chang Shu.
149
150         Merged endOfLine with logicalEndOfLine, and startOfLine with logicalStartOfLine
151         to reduce the code duplication.
152
153         * editing/visible_units.cpp:
154         (WebCore::startPositionForLine):
155         (WebCore::startOfLine):
156         (WebCore::logicalStartOfLine):
157         (WebCore::endPositionForLine):
158         (WebCore::inSameLogicalLine):
159         (WebCore::endOfLine):
160         (WebCore::logicalEndOfLine):
161         * editing/visible_units.h:
162
163 2011-10-25  Arko Saha  <arko@motorola.com>
164
165         Microdata: itemtype attribute should be space-separated list to allow multiple types.
166         https://bugs.webkit.org/show_bug.cgi?id=70501
167
168         Reviewed by Ryosuke Niwa.
169
170         Tests: fast/dom/MicroData/getitems-multiple-itemtypes.html
171                fast/dom/MicroData/itemtype-add-remove-tokens.html
172                fast/dom/MicroData/itemtype-attribute-test.html
173
174         * dom/MicroDataItemList.cpp:
175         (WebCore::MicroDataItemList::nodeMatches):
176         * html/DOMSettableTokenList.h:
177         (WebCore::DOMSettableTokenList::tokens):
178         * html/HTMLElement.cpp:
179         (WebCore::HTMLElement::parseMappedAttribute):
180         (WebCore::HTMLElement::setItemValueText):
181         (WebCore::HTMLElement::itemType):
182         (WebCore::HTMLElement::setItemType):
183         * html/HTMLElement.h:
184         * html/HTMLElement.idl:
185
186 2011-10-25  Dan Bernstein  <mitz@apple.com>
187
188         <rdar://problem/10337033> DOMRangeOfString:relativeTo:options has problems with -webkit-user-select: none
189
190         Reviewed by Adam Roben.
191
192         Test: added to TestWebKitAPI/Tests/mac/DOMRangeOfString.mm
193
194         * page/Page.cpp:
195         (WebCore::Page::rangeOfString): This function was incorrectly adding the StartInSelection option to
196         the initial search.
197
198 2011-10-25  Yury Semikhatsky  <yurys@chromium.org>
199
200         Web Inspector: redesign workers sidebar pane
201         https://bugs.webkit.org/show_bug.cgi?id=70815
202
203         Changed workers sidebar pane design.
204
205         Now there is a link to worker inspector for each dedicated worker created
206         by inspected page. The sidebar display a link to a page with list of all
207         shared workers if there one is supported by the WebKit port. Also there
208         is a checkbox that allows pause all new workers on first statements.
209
210         Reviewed by Pavel Feldman.
211
212         * inspector/front-end/Settings.js:
213         * inspector/front-end/StylesSidebarPane.js:
214         (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
215         * inspector/front-end/WorkerManager.js:
216         (WebInspector.WorkerManager.prototype.openWorkerInspector):
217         (WebInspector.WorkerManager.prototype._workerInspectorClosing):
218         * inspector/front-end/WorkersSidebarPane.js:
219         (WebInspector.WorkerListSidebarPane):
220         (WebInspector.WorkerListSidebarPane.prototype._workerRemoved):
221         (WebInspector.WorkerListSidebarPane.prototype._workersCleared):
222         (WebInspector.WorkerListSidebarPane.prototype._addWorker):
223         (WebInspector.WorkerListSidebarPane.prototype._workerItemClicked):
224         (WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked):
225         (WebInspector.WorkerListSidebarPane.prototype._createSharedWorkersLink.link.onclick):
226         (WebInspector.WorkerListSidebarPane.prototype._createSharedWorkersLink):
227         * inspector/front-end/elementsPanel.css:
228         * inspector/front-end/inspectorCommon.css:
229         (.sidebar-separator):
230         (.sidebar-label):
231         * inspector/front-end/scriptsPanel.css:
232         (.dedicated-worker-item):
233         (#shared-workers-list):
234         (#pause-workers-checkbox > input):
235
236 2011-10-25  Nico Weber  <thakis@chromium.org>
237
238         [chromium/mac] Fix an ODR violation.
239         https://bugs.webkit.org/show_bug.cgi?id=70753
240
241         Reviewed by Anders Carlsson.
242
243         Both ScrollAnimatorNone and ScrollAnimatorMac define ScrollAnimator::create() on OS X.
244         Remove the unused one.
245
246         * WebCore.gyp/WebCore.gyp:
247
248 2011-10-25  Vsevolod Vlasov  <vsevik@chromium.org>
249
250         Web Inspector: Debugger fails when there is an invalid watch expression.
251         https://bugs.webkit.org/show_bug.cgi?id=70718
252
253         Reviewed by Pavel Feldman.
254
255         Test: inspector/debugger/watch-expressions-panel-switch.html
256
257         * inspector/front-end/ScriptsPanel.js:
258         (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
259
260 2011-10-24  Pavel Podivilov  <podivilov@chromium.org>
261
262         Web Inspector: fix empty line handling in source maps.
263         https://bugs.webkit.org/show_bug.cgi?id=70726
264
265         Reviewed by Yury Semikhatsky.
266
267         * inspector/front-end/CompilerSourceMapping.js:
268         (WebInspector.ClosureCompilerSourceMapping.prototype._parseMappings):
269
270 2011-10-25  Justin Schuh  <jschuh@chromium.org>
271
272         Check for empty string in parseArcFlag
273         https://bugs.webkit.org/show_bug.cgi?id=70763
274
275         Reviewed by Dirk Schulze.
276
277         Test: svg/path-invalid.html
278
279         * svg/SVGParserUtilities.cpp:
280         (WebCore::parseArcFlag):
281
282 2011-10-24  Pavel Podivilov  <podivilov@chromium.org>
283
284         Web Inspector: keep old source mapping when new one could not be loaded.
285         https://bugs.webkit.org/show_bug.cgi?id=70729
286
287         Reviewed by Yury Semikhatsky.
288
289         * inspector/front-end/RawSourceCode.js:
290         (WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
291         (WebInspector.RawSourceCode.prototype._updateSourceMapping):
292         (WebInspector.RawSourceCode.prototype._createSourceMapping.didLoadSourceMapping):
293
294 2011-10-25  Sachin Puranik  <sachin.puranik@motorola.com>
295
296         Double number step=.5 should be considered valid in <input type="number" step=".5">
297         https://bugs.webkit.org/show_bug.cgi?id=70320
298
299         Reviewed by Kent Tamura.
300
301         Test: fast/forms/input-step-as-double.html
302
303         * html/parser/HTMLParserIdioms.cpp:
304         (WebCore::parseToDoubleForNumberType): Changed the function to consider
305         step as valid even if it starts with "."
306
307 2011-10-25  Alexander Pavlov  <apavlov@chromium.org>
308
309         Web Inspector: [Chromium] Audits panel context menu for links not working properly
310         https://bugs.webkit.org/show_bug.cgi?id=70813
311
312         Reviewed by Pavel Feldman.
313
314         * inspector/front-end/AuditResultView.js:
315         (WebInspector.AuditResultView):
316         (WebInspector.AuditResultView.prototype._contextMenuEventFired):
317
318 2011-10-25  Vsevolod Vlasov  <vsevik@chromium.org>
319
320         Web Inspector: Resources panel: display the current search match index in the toolbar.
321         https://bugs.webkit.org/show_bug.cgi?id=66050
322
323         Reviewed by Pavel Feldman.
324
325         Test: http/tests/inspector/search/resources-search-match-index.html
326
327         * inspector/front-end/ResourcesPanel.js:
328         (WebInspector.ResourcesPanel.prototype.performSearch.callback):
329         (WebInspector.ResourcesPanel.prototype.performSearch):
330         (WebInspector.ResourcesPanel.prototype._showSearchResult.callback):
331         (WebInspector.ResourcesPanel.prototype._showSearchResult):
332         (WebInspector.BaseStorageTreeElement.prototype.get searchMatchesCount):
333         (WebInspector.ResourcesSearchController):
334         (WebInspector.ResourcesSearchController.prototype.nextSearchResult):
335         (WebInspector.ResourcesSearchController.prototype.previousSearchResult):
336         (WebInspector.ResourcesSearchController.prototype._searchResult):
337         (WebInspector.SearchResultsTreeElementsTraverser.prototype.next):
338         (WebInspector.SearchResultsTreeElementsTraverser.prototype.previous):
339         (WebInspector.SearchResultsTreeElementsTraverser.prototype.matchIndex):
340         (WebInspector.SearchResultsTreeElementsTraverser.prototype._elementSearchMatchesCount):
341         (WebInspector.SearchResultsTreeElementsTraverser.prototype._traverseNext):
342         (WebInspector.SearchResultsTreeElementsTraverser.prototype._traversePrevious):
343         * inspector/front-end/treeoutline.js:
344
345 2011-10-25  Andrey Kosyakov  <caseq@chromium.org>
346
347         Web Inspector: JS exception in JavaScriptSourceFrame.onShowPopover/showObjectPopover()
348         https://bugs.webkit.org/show_bug.cgi?id=70812
349
350         Reviewed by Pavel Feldman.
351
352         Check if highlighted element is present while displaying object popover.
353
354         * inspector/front-end/JavaScriptSourceFrame.js:
355         (WebInspector.JavaScriptSourceFrame.prototype.onShowPopover.showObjectPopover):
356         (WebInspector.JavaScriptSourceFrame.prototype.onShowPopover):
357
358 2011-10-21  Nat Duca  <nduca@chromium.org>
359
360         [chromium] Route Console::time and Console::timeEnd to trace_event
361         https://bugs.webkit.org/show_bug.cgi?id=70620
362
363         Reviewed by Pavel Feldman.
364
365         * page/Console.cpp:
366         (WebCore::Console::time):
367         (WebCore::Console::timeEnd):
368
369 2011-10-21  Andrey Kosyakov  <caseq@chromium.org>
370
371         Web Inspector: [Extensions API] allow extensions to specify script to be injected on reload
372         https://bugs.webkit.org/show_bug.cgi?id=70600
373
374         Reviewed by Pavel Feldman.
375
376         - change webInspector.inspectedPage.reload() to accept multiple options in an object
377         - add an ability to inject a script upon a page reload
378         - return script id in addScriptToEvaluateOnLoad()
379         - provide removeScriptToEvaluateOnLoad()
380         - store scripts to evaluate on load in inspector state cookie
381
382         Test: inspector/extensions/extensions-reload.html
383
384         * inspector/Inspector.json:
385         * inspector/InspectorPageAgent.cpp:
386         (WebCore::InspectorPageAgent::InspectorPageAgent):
387         (WebCore::InspectorPageAgent::restore):
388         (WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
389         (WebCore::InspectorPageAgent::removeScriptToEvaluateOnLoad):
390         (WebCore::InspectorPageAgent::removeAllScriptsToEvaluateOnLoad):
391         (WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
392         (WebCore::InspectorPageAgent::frameNavigated):
393         * inspector/InspectorPageAgent.h:
394         * inspector/front-end/ExtensionAPI.js:
395         (injectedExtensionAPI.InspectedWindow.prototype.reload):
396         * inspector/front-end/ExtensionServer.js:
397         (WebInspector.ExtensionServer.prototype._onReload):
398         * inspector/front-end/WorkersSidebarPane.js:
399         (WebInspector.WorkersSidebarPane.prototype.setInstrumentation.callback):
400         (WebInspector.WorkersSidebarPane.prototype.setInstrumentation):
401
402 2011-10-24  Pavel Feldman  <pfeldman@google.com>
403
404         Web Inspector: print expired message count before remaining messages.
405         https://bugs.webkit.org/show_bug.cgi?id=70736
406
407         Reviewed by Yury Semikhatsky.
408
409         * inspector/Inspector-0.1.json:
410         * inspector/Inspector.json:
411         * inspector/InspectorConsoleAgent.cpp:
412         (WebCore::InspectorConsoleAgent::enable):
413         (WebCore::InspectorConsoleAgent::restore):
414         * inspector/InspectorConsoleAgent.h:
415         * inspector/front-end/ConsoleModel.js:
416
417 2011-10-25  Sheriff Bot  <webkit.review.bot@gmail.com>
418
419         Unreviewed, rolling out r98309.
420         http://trac.webkit.org/changeset/98309
421         https://bugs.webkit.org/show_bug.cgi?id=70801
422
423         Test fails on mac (Requested by benwells on #webkit).
424
425         * html/canvas/CanvasRenderingContext2D.cpp:
426         (WebCore::CanvasRenderingContext2D::fill):
427         (WebCore::CanvasRenderingContext2D::fillRect):
428         (WebCore::CanvasRenderingContext2D::drawImage):
429         (WebCore::CanvasRenderingContext2D::shouldDisplayTransparencyElsewhere):
430         (WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):
431         * html/canvas/CanvasRenderingContext2D.h:
432
433 2011-10-24  Geoffrey Garen  <ggaren@apple.com>
434
435         Chromium build fix: #include window.h for HANDLE.
436
437         * platform/graphics/opentype/OpenTypeUtilities.h:
438
439 2011-10-24  Ryosuke Niwa  <rniwa@webkit.org>
440
441         Include ThreadSafeRefCounted.h since the class declared in this header file
442         inherits from ThreadSafeRefCounted.
443
444         * storage/IDBIndexBackendInterface.h:
445
446 2011-10-24  Ryosuke Niwa  <rniwa@webkit.org>
447
448         Fix a typo.
449
450         * bindings/v8/JavaScriptCallFrame.h:
451
452 2011-10-24  Geoffrey Garen  <ggaren@apple.com>
453
454         Removed SharedUChar and tightened language around its previous uses
455         https://bugs.webkit.org/show_bug.cgi?id=70698
456
457         Reviewed by David Levin.
458
459         - Renamed "threadSafeCopy" and "crossThreadCopy" to "isolatedCopy" because
460         the former names gave the dangerous misimpression that the resulting object
461         was thread-safe, which is not true.
462         
463         - Updated a bunch of files for header dependency changes, now that
464         CrossThreadRefCounted is gone.
465
466         * ForwardingHeaders/wtf/CrossThreadRefCounted.h: Removed.
467         * WebCore.exp.in:
468         * bindings/js/ScriptHeapSnapshot.h:
469         * bindings/v8/SerializedScriptValue.cpp:
470         (WebCore::SerializedScriptValue::release):
471         (WebCore::SerializedScriptValue::SerializedScriptValue):
472         * css/CSSPropertySourceData.h:
473         * css/CSSValue.h:
474         * css/StyleMedia.h:
475         * css/WebKitCSSMatrix.h:
476         * dom/QualifiedName.h:
477         * fileapi/LocalFileSystem.h:
478         (WebCore::LocalFileSystem::SystemBasePath::operator String):
479         * history/CachedFrame.h:
480         * history/CachedPage.h:
481         * history/HistoryItem.h:
482         * html/canvas/CanvasStyle.h:
483         * inspector/InspectorResourceAgent.h:
484         * loader/FormState.h:
485         * loader/TextResourceDecoder.h:
486         * loader/WorkerThreadableLoader.cpp:
487         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
488         * loader/icon/IconDatabase.cpp:
489         (WebCore::IconDatabase::open):
490         (WebCore::IconDatabase::synchronousIconForPageURL):
491         (WebCore::IconDatabase::synchronousIconURLForPageURL):
492         (WebCore::IconDatabase::retainIconForPageURL):
493         (WebCore::IconDatabase::releaseIconForPageURL):
494         (WebCore::IconDatabase::setIconDataForIconURL):
495         (WebCore::IconDatabase::setIconURLForPageURL):
496         (WebCore::IconDatabase::databasePath):
497         (WebCore::IconDatabase::defaultDatabaseFilename):
498         (WebCore::ImportedIconURLForPageURLWorkItem::ImportedIconURLForPageURLWorkItem):
499         (WebCore::ImportedIconDataForPageURLWorkItem::ImportedIconDataForPageURLWorkItem):
500         * page/ContentSecurityPolicy.h:
501         * page/Coordinates.h:
502         (WebCore::Coordinates::isolatedCopy):
503         * page/Geoposition.h:
504         (WebCore::Geoposition::isolatedCopy):
505         * page/SecurityOrigin.cpp:
506         (WebCore::SecurityOrigin::SecurityOrigin):
507         (WebCore::SecurityOrigin::isolatedCopy):
508         * page/SecurityOrigin.h:
509         * page/animation/AnimationBase.h:
510         * platform/CrossThreadCopier.cpp:
511         (WebCore::::copy):
512         * platform/FileChooser.h:
513         * platform/KURL.cpp:
514         (WebCore::KURL::copy):
515         * platform/cf/SchedulePair.h:
516         * platform/network/BlobData.cpp:
517         (WebCore::BlobDataItem::detachFromCurrentThread):
518         (WebCore::BlobData::detachFromCurrentThread):
519         * platform/network/HTTPHeaderMap.cpp:
520         (WebCore::HTTPHeaderMap::copyData):
521         * platform/network/MIMEHeader.h:
522         * platform/network/ResourceErrorBase.cpp:
523         (WebCore::ResourceErrorBase::copy):
524         * platform/network/ResourceLoadInfo.h:
525         * platform/network/ResourceRequestBase.cpp:
526         (WebCore::ResourceRequestBase::copyData):
527         * platform/network/ResourceResponseBase.cpp:
528         (WebCore::ResourceResponseBase::copyData):
529         * platform/sql/SQLValue.cpp:
530         (WebCore::SQLValue::SQLValue):
531         (WebCore::SQLValue::string):
532         * rendering/style/QuotesData.h:
533         * storage/AbstractDatabase.cpp:
534         (WebCore::updateGuidVersionMap):
535         (WebCore::AbstractDatabase::AbstractDatabase):
536         (WebCore::AbstractDatabase::performOpenAndVerify):
537         (WebCore::AbstractDatabase::stringIdentifier):
538         (WebCore::AbstractDatabase::displayName):
539         (WebCore::AbstractDatabase::fileName):
540         (WebCore::AbstractDatabase::setExpectedVersion):
541         (WebCore::AbstractDatabase::getCachedVersion):
542         * storage/ChangeVersionWrapper.cpp:
543         (WebCore::ChangeVersionWrapper::ChangeVersionWrapper):
544         * storage/Database.cpp:
545         (WebCore::Database::Database):
546         (WebCore::Database::tableNames):
547         * storage/DatabaseDetails.h:
548         * storage/DatabaseTracker.cpp:
549         (WebCore::DatabaseTracker::setDatabaseDirectoryPath):
550         (WebCore::DatabaseTracker::databaseDirectoryPath):
551         (WebCore::DatabaseTracker::trackerDatabasePath):
552         (WebCore::DatabaseTracker::canEstablishDatabase):
553         (WebCore::DatabaseTracker::originPath):
554         (WebCore::DatabaseTracker::fullPathForDatabase):
555         (WebCore::DatabaseTracker::populateOrigins):
556         (WebCore::DatabaseTracker::databaseNamesForOrigin):
557         (WebCore::DatabaseTracker::addOpenDatabase):
558         (WebCore::DatabaseTracker::setQuota):
559         (WebCore::DatabaseTracker::recordCreatingDatabase):
560         (WebCore::DatabaseTracker::recordDeletingDatabase):
561         (WebCore::DatabaseTracker::recordDeletingOrigin):
562         (WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged):
563         * storage/OriginQuotaManager.cpp:
564         (WebCore::OriginQuotaManager::trackOrigin):
565         (WebCore::OriginQuotaManager::addDatabase):
566         * storage/SQLError.h:
567         (WebCore::SQLError::message):
568         (WebCore::SQLError::SQLError):
569         * storage/SQLResultSetRowList.h:
570         * storage/SQLStatement.cpp:
571         (WebCore::SQLStatement::SQLStatement):
572         * storage/StorageAreaSync.cpp:
573         (WebCore::StorageAreaSync::StorageAreaSync):
574         (WebCore::StorageAreaSync::syncTimerFired):
575         * storage/StorageAreaSync.h:
576         * storage/StorageMap.cpp:
577         (WebCore::StorageMap::importItem):
578         * storage/StorageNamespaceImpl.cpp:
579         (WebCore::StorageNamespaceImpl::StorageNamespaceImpl):
580         * storage/StorageSyncManager.cpp:
581         (WebCore::StorageSyncManager::StorageSyncManager):
582         * storage/StorageTracker.cpp:
583         (WebCore::StorageTracker::StorageTracker):
584         (WebCore::StorageTracker::syncImportOriginIdentifiers):
585         (WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
586         (WebCore::StorageTracker::setOriginDetails):
587         (WebCore::StorageTracker::willDeleteAllOrigins):
588         * svg/SVGPathSeg.h:
589         * workers/DefaultSharedWorkerRepository.cpp:
590         (WebCore::SharedWorkerProxy::url):
591         (WebCore::SharedWorkerProxy::name):
592         (WebCore::SharedWorkerProxy::SharedWorkerProxy):
593         (WebCore::DefaultSharedWorkerRepository::getProxy):
594         * workers/SharedWorkerThread.cpp:
595         (WebCore::SharedWorkerThread::SharedWorkerThread):
596         * workers/WorkerMessagingProxy.cpp:
597         (WebCore::WorkerExceptionTask::WorkerExceptionTask):
598         (WebCore::PostMessageToPageInspectorTask::PostMessageToPageInspectorTask):
599         * workers/WorkerRunLoop.cpp:
600         (WebCore::WorkerRunLoop::postTaskForMode):
601         (WebCore::WorkerRunLoop::Task::Task):
602         * workers/WorkerThread.cpp:
603         (WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
604
605 2011-10-24  Adam Barth  <abarth@webkit.org>
606
607         Remove empty directory.
608
609         * p2p: Removed.
610
611 2011-10-24  Shawn Singh  <shawnsingh@chromium.org>
612
613         [chromium] Refactor painting/updating/drawing code.
614         https://bugs.webkit.org/show_bug.cgi?id=70057
615
616         Reviewed by James Robinson.
617
618         This refactoring separates the "early exits" from the actual loop
619         that draws layers. As part of this, it was also appropriate to
620         clean up the way that masks and replicas are dealt with when
621         painting and updating. The purpose of all this is to make things
622         easier to test, and for a scissoring optimization that needs to
623         know exatly what gets drawn. Existing layout tests were able to
624         verify the refactoring did not change behavior.
625
626         * platform/graphics/chromium/LayerRendererChromium.cpp:
627         (WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
628         (WebCore::LayerRendererChromium::drawLayersInternal):
629         (WebCore::LayerRendererChromium::drawLayer):
630         * platform/graphics/chromium/LayerRendererChromium.h:
631         * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
632         (WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
633         (WebCore::CCLayerTreeHost::paintLayerContents):
634         (WebCore::CCLayerTreeHost::updateCompositorResources):
635         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
636         * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
637         (WebCore::layerShouldBeAppended):
638         (WebCore::calculateDrawTransformsAndVisibilityInternal):
639         * platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
640         (WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):
641
642 2011-10-24  Luke Macpherson   <macpherson@chromium.org>
643
644         REGRESSION(80893): HTML5 spec takes 2s longer to load due to time spent in CSSStyleSelector
645         https://bugs.webkit.org/show_bug.cgi?id=68944
646
647         Reviewed by Antti Koivisto.
648
649         No new tests / Covered by existing tests.
650
651         Removes all virtual dispatch from CSSStyleApplyProperty by converting to use static function pointers for dispatch.
652         Uses class templates instead of function templates to allow default parameters and also to share parameter declarations across static functions.
653         All constructor parameters become template parameters. This improves the level of compiler optimization that can be achieved.
654         Overall this achieved a ~2% overall speedup on run-safari PerformanceTests/Parser/html5-full-render.html,
655         and profiling showed a reduction in the time spent inside CSSStyleSelector::applyProperty().
656
657         * css/CSSStyleApplyProperty.cpp:
658         (WebCore::ApplyPropertyExpanding::applyInheritValue):
659         (WebCore::ApplyPropertyExpanding::applyInitialValue):
660         (WebCore::ApplyPropertyExpanding::applyValue):
661         (WebCore::ApplyPropertyExpanding::createHandler):
662         (WebCore::ApplyPropertyDefaultBase::setValue):
663         (WebCore::ApplyPropertyDefaultBase::value):
664         (WebCore::ApplyPropertyDefaultBase::initial):
665         (WebCore::ApplyPropertyDefaultBase::applyInheritValue):
666         (WebCore::ApplyPropertyDefaultBase::applyInitialValue):
667         (WebCore::ApplyPropertyDefaultBase::applyValue):
668         (WebCore::ApplyPropertyDefaultBase::createHandler):
669         (WebCore::ApplyPropertyDefault::setValue):
670         (WebCore::ApplyPropertyDefault::applyValue):
671         (WebCore::ApplyPropertyDefault::createHandler):
672         (WebCore::ApplyPropertyStyleImage::applyValue):
673         (WebCore::ApplyPropertyStyleImage::createHandler):
674         (WebCore::ApplyPropertyAuto::setValue):
675         (WebCore::ApplyPropertyAuto::value):
676         (WebCore::ApplyPropertyAuto::hasAuto):
677         (WebCore::ApplyPropertyAuto::setAuto):
678         (WebCore::ApplyPropertyAuto::applyInheritValue):
679         (WebCore::ApplyPropertyAuto::applyInitialValue):
680         (WebCore::ApplyPropertyAuto::applyValue):
681         (WebCore::ApplyPropertyAuto::createHandler):
682         (WebCore::defaultInitialColor):
683         (WebCore::ApplyPropertyColor::applyInheritValue):
684         (WebCore::ApplyPropertyColor::applyInitialValue):
685         (WebCore::ApplyPropertyColor::applyValue):
686         (WebCore::ApplyPropertyColor::createHandler):
687         (WebCore::ApplyPropertyDirection::applyValue):
688         (WebCore::ApplyPropertyDirection::createHandler):
689         (WebCore::ApplyPropertyLength::setValue):
690         (WebCore::ApplyPropertyLength::applyValue):
691         (WebCore::ApplyPropertyLength::createHandler):
692         (WebCore::ApplyPropertyString::setValue):
693         (WebCore::ApplyPropertyString::applyValue):
694         (WebCore::ApplyPropertyString::createHandler):
695         (WebCore::ApplyPropertyBorderRadius::setValue):
696         (WebCore::ApplyPropertyBorderRadius::applyValue):
697         (WebCore::ApplyPropertyBorderRadius::createHandler):
698         (WebCore::ApplyPropertyFillLayer::applyInheritValue):
699         (WebCore::ApplyPropertyFillLayer::applyInitialValue):
700         (WebCore::ApplyPropertyFillLayer::applyValue):
701         (WebCore::ApplyPropertyFillLayer::createHandler):
702         (WebCore::ApplyPropertyComputeLength::setValue):
703         (WebCore::ApplyPropertyComputeLength::applyValue):
704         (WebCore::ApplyPropertyComputeLength::createHandler):
705         (WebCore::ApplyPropertyFont::applyInheritValue):
706         (WebCore::ApplyPropertyFont::applyInitialValue):
707         (WebCore::ApplyPropertyFont::applyValue):
708         (WebCore::ApplyPropertyFont::createHandler):
709         (WebCore::ApplyPropertyFontWeight::applyValue):
710         (WebCore::ApplyPropertyFontWeight::createHandler):
711         (WebCore::ApplyPropertyCounter::emptyFunction):
712         (WebCore::ApplyPropertyCounter::applyValue):
713         (WebCore::ApplyPropertyCounter::createHandler):
714         (WebCore::ApplyPropertyCursor::applyInheritValue):
715         (WebCore::ApplyPropertyCursor::applyInitialValue):
716         (WebCore::ApplyPropertyCursor::applyValue):
717         (WebCore::ApplyPropertyCursor::createHandler):
718         (WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
719         (WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
720         (WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
721         (WebCore::ApplyPropertyTextEmphasisStyle::createHandler):
722         (WebCore::ApplyPropertyAnimation::setValue):
723         (WebCore::ApplyPropertyAnimation::value):
724         (WebCore::ApplyPropertyAnimation::test):
725         (WebCore::ApplyPropertyAnimation::clear):
726         (WebCore::ApplyPropertyAnimation::initial):
727         (WebCore::ApplyPropertyAnimation::map):
728         (WebCore::ApplyPropertyAnimation::accessAnimations):
729         (WebCore::ApplyPropertyAnimation::animations):
730         (WebCore::ApplyPropertyAnimation::applyInheritValue):
731         (WebCore::ApplyPropertyAnimation::applyInitialValue):
732         (WebCore::ApplyPropertyAnimation::applyValue):
733         (WebCore::ApplyPropertyAnimation::createHandler):
734         (WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
735         (WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
736         (WebCore::ApplyPropertyOutlineStyle::applyValue):
737         (WebCore::ApplyPropertyOutlineStyle::createHandler):
738         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
739         * css/CSSStyleApplyProperty.h:
740         (WebCore::PropertyHandler::PropertyHandler):
741         (WebCore::PropertyHandler::applyInheritValue):
742         (WebCore::PropertyHandler::applyInitialValue):
743         (WebCore::PropertyHandler::applyValue):
744         (WebCore::PropertyHandler::isValid):
745         (WebCore::PropertyHandler::inheritFunction):
746         (WebCore::PropertyHandler::initialFunction):
747         (WebCore::PropertyHandler::applyFunction):
748         (WebCore::CSSStyleApplyProperty::propertyHandler):
749         (WebCore::CSSStyleApplyProperty::setPropertyHandler):
750         * css/CSSStyleSelector.cpp:
751         (WebCore::CSSStyleSelector::applyProperty):
752         * rendering/style/RenderStyle.h:
753         (WebCore::InheritedFlags::invalidColor):
754
755 2011-10-24  Ben Wells  <benwells@chromium.org>
756
757         Canvas drawImage with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
758         https://bugs.webkit.org/show_bug.cgi?id=66920
759
760         Reviewed by James Robinson.
761
762         Test: fast/canvas/canvas-composite-image.html
763
764         Use the same method as fills to handle composited drawImage calls that will affect the whole
765         canvas. To do this code used when doing fills has been factored into seperate functions and
766         used by drawImage. Some functions used to do these types of operations have also been renamed.
767
768         * html/canvas/CanvasRenderingContext2D.cpp:
769         (WebCore::isFullCanvasCompositeMode):
770         (WebCore::CanvasRenderingContext2D::fill):
771         (WebCore::CanvasRenderingContext2D::fillRect):
772         (WebCore::CanvasRenderingContext2D::drawImage):
773         (WebCore::CanvasRenderingContext2D::calculateCompositingBufferRect):
774         (WebCore::CanvasRenderingContext2D::createCompositingBuffer):
775         (WebCore::CanvasRenderingContext2D::compositeBuffer):
776         (WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):
777         (WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill):
778         * html/canvas/CanvasRenderingContext2D.h:
779
780 2011-10-24  Sheriff Bot  <webkit.review.bot@gmail.com>
781
782         Unreviewed, rolling out r98294 and r98306.
783         http://trac.webkit.org/changeset/98294
784         http://trac.webkit.org/changeset/98306
785         https://bugs.webkit.org/show_bug.cgi?id=70790
786
787         the first patch broke chromium-mac and the second gclient
788         (Requested by jchaffraix on #webkit).
789
790         * WebCore.gyp/WebCore.gyp:
791
792 2011-10-24  Ryosuke Niwa  <rniwa@webkit.org>
793
794         Build fix after r98300.
795
796         * WebCore.gypi:
797         * WebCore.pro:
798
799 2011-10-24  Anders Carlsson  <andersca@apple.com>
800
801         It should be possible for Widget subclasses to control whether transforms affect the frame rect
802         https://bugs.webkit.org/show_bug.cgi?id=70787
803
804         Reviewed by Sam Weinig.
805
806         Currently RenderWidget sets the frame rect of it's hosted widget to the bounding box of the transformed
807         content box rect (unless the Widget is a frame view). It should be possible for Widget subclasses to override
808         this behavior and have the frame rect set to the absolute content box without any transforms applied.
809
810         * platform/Widget.h:
811         (WebCore::Widget::transformsAffectFrameRect):
812         Add new member function.
813
814         * rendering/RenderWidget.cpp:
815         (WebCore::RenderWidget::updateWidgetGeometry):
816         Move shared code from setWidget and updateWidgetPosition out into a new function. If transformsAffectFrameRect returns 
817         false, just set the frame rect to the absolute content box.
818
819         (WebCore::RenderWidget::setWidget):
820         (WebCore::RenderWidget::updateWidgetPosition):
821         Call updateWidgetGeometry.
822
823         * rendering/RenderWidget.h:
824
825 2011-10-24  Arko Saha  <arko@motorola.com>
826
827         Microdata: Add itemprop, itemref, itemvalue attributes.
828         https://bugs.webkit.org/show_bug.cgi?id=69839
829
830         Reviewed by Ryosuke Niwa.
831
832         Tests: fast/dom/MicroData/itemprop-add-remove-tokens.html
833                fast/dom/MicroData/itemprop-for-an-element-must-be-correct.html
834                fast/dom/MicroData/itemprop-must-be-read-only.html
835                fast/dom/MicroData/itemprop-reflected-by-itemProp-property.html
836                fast/dom/MicroData/itemref-add-remove-tokens.html
837                fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property.html
838                fast/dom/MicroData/itemref-for-an-element-must-be-correct.html
839                fast/dom/MicroData/itemref-must-be-read-only.html
840                fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element.html
841                fast/dom/MicroData/itemvalue-reflects-href-attr.html
842                fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element.html
843                fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element.html
844                fast/dom/MicroData/itemvalue-reflects-the-src-attr.html
845                fast/dom/MicroData/itemvalue-returns-element-itself.html
846                fast/dom/MicroData/itemvalue-returns-null.html
847                fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001.html
848                fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002.html
849
850         * CMakeLists.txt:
851         * GNUmakefile.list.am:
852         * WebCore.gypi:
853         * WebCore.pro:
854         * WebCore.vcproj/WebCore.vcproj:
855         * bindings/js/JSHTMLElementCustom.cpp:
856         (WebCore::toJS):
857         (WebCore::JSHTMLElement::itemValue):
858         (WebCore::JSHTMLElement::setItemValue):
859         * bindings/v8/custom/V8HTMLElementCustom.cpp:
860         (WebCore::toV8Object):
861         (WebCore::V8HTMLElement::itemValueAccessorGetter):
862         (WebCore::V8HTMLElement::itemValueAccessorSetter):
863         * dom/MicroDataItemList.cpp:
864         * html/HTMLAnchorElement.cpp:
865         (WebCore::HTMLAnchorElement::itemValueText):
866         (WebCore::HTMLAnchorElement::setItemValueText):
867         * html/HTMLAnchorElement.h:
868         * html/HTMLAreaElement.cpp:
869         (WebCore::HTMLAreaElement::itemValueText):
870         (WebCore::HTMLAreaElement::setItemValueText):
871         * html/HTMLAreaElement.h:
872         * html/HTMLAttributeNames.in:
873         * html/HTMLElement.cpp:
874         (WebCore::HTMLElement::parseMappedAttribute):
875         (WebCore::HTMLElement::itemProp): Returns element's itemprop content attribute.
876         (WebCore::HTMLElement::setItemProp): Sets itemprop value on changing elemet's
877         itemprop attribute.
878         (WebCore::HTMLElement::itemRef): Returns element's itemref content attribute.
879         (WebCore::HTMLElement::setItemRef): Sets itemref value on changing elemet's
880         itemref attribute.
881         (WebCore::HTMLElement::setItemValue): Sets element's itemvalue. If the element has no
882         itemprop attribute or if element has an itemscope attribute, it throws INVALID_ACCESS_ERR
883         exception.
884         (WebCore::HTMLElement::itemValue): Returns the elements itemvalue.
885
886         If the element has no itemprop attribute it returns null.
887         If the element has an itemscope attribute, it returns the element itself.
888         If the element is a meta element: It acts as it would if it was reflecting the element's
889         content content attribute.
890         If the element is an audio, embed, iframe, img, source, track, or video element: It acts
891         as it would if it was reflecting the element's src content attribute.
892         If the element is an a, area, or link element: It act as it would if it was reflecting the
893         href content attribute.
894         If the element is an object element: It acts as  it would if it was reflecting the element's
895         data content attribute.
896
897         (WebCore::HTMLElement::itemValueText):
898         (WebCore::HTMLElement::setItemValueText):
899         * html/HTMLElement.h:
900         * html/HTMLElement.idl:
901         * html/HTMLEmbedElement.cpp:
902         (WebCore::HTMLEmbedElement::itemValueText):
903         (WebCore::HTMLEmbedElement::setItemValueText):
904         * html/HTMLEmbedElement.h:
905         * html/HTMLIFrameElement.cpp:
906         (WebCore::HTMLIFrameElement::itemValueText):
907         (WebCore::HTMLIFrameElement::setItemValueText):
908         * html/HTMLIFrameElement.h:
909         * html/HTMLImageElement.cpp:
910         (WebCore::HTMLImageElement::itemValueText):
911         (WebCore::HTMLImageElement::setItemValueText):
912         * html/HTMLImageElement.h:
913         * html/HTMLLinkElement.cpp:
914         (WebCore::HTMLLinkElement::itemValueText):
915         (WebCore::HTMLLinkElement::setItemValueText):
916         * html/HTMLLinkElement.h:
917         * html/HTMLMediaElement.cpp:
918         (WebCore::HTMLMediaElement::itemValueText):
919         (WebCore::HTMLMediaElement::setItemValueText):
920         * html/HTMLMediaElement.h:
921         * html/HTMLMetaElement.cpp:
922         (WebCore::HTMLMetaElement::itemValueText):
923         (WebCore::HTMLMetaElement::setItemValueText):
924         * html/HTMLMetaElement.h:
925         * html/HTMLObjectElement.cpp:
926         (WebCore::HTMLObjectElement::itemValueText):
927         (WebCore::HTMLObjectElement::setItemValueText):
928         * html/HTMLObjectElement.h:
929         * html/HTMLSourceElement.cpp:
930         (WebCore::HTMLSourceElement::itemValueText):
931         (WebCore::HTMLSourceElement::setItemValueText):
932         * html/HTMLSourceElement.h:
933         * html/HTMLTrackElement.cpp:
934         (WebCore::HTMLTrackElement::itemValueText):
935         (WebCore::HTMLTrackElement::setItemValueText):
936         * html/HTMLTrackElement.h:
937         * html/MicroDataItemValue.cpp: Added.
938         (WebCore::MicroDataItemValue::MicroDataItemValue):
939         (WebCore::MicroDataItemValue::createFromString):
940         (WebCore::MicroDataItemValue::createFromNode):
941         * html/MicroDataItemValue.h: Added.
942         (WebCore::MicroDataItemValue::isNode):
943         (WebCore::MicroDataItemValue::getNode):
944         (WebCore::MicroDataItemValue::getString):
945
946 2011-10-24  Joseph Pecoraro  <joepeck@webkit.org>
947
948         Remove unused instance variable
949         https://bugs.webkit.org/show_bug.cgi?id=70750
950
951         Reviewed by Dimitri Glazkov.
952
953         * rendering/RenderTextControl.h:
954
955 2011-10-24  Nico Weber  <thakis@chromium.org>
956
957         [chromium/mac] Fix an ODR violation.
958         https://bugs.webkit.org/show_bug.cgi?id=70753
959
960         Reviewed by Anders Carlsson.
961
962         Both ScrollAnimatorNone and ScrollAnimatorMac define ScrollAnimator::create() on OS X.
963         Remove the unused one.
964
965         * WebCore.gyp/WebCore.gyp:
966
967 2011-10-24  Tim Horton  <timothy_horton@apple.com>
968
969         feColorMatrix doesn't use the correct default "matrix" type when no type attribute is specified
970         https://bugs.webkit.org/show_bug.cgi?id=70035
971         <rdar://problem/10280177>
972
973         Reviewed by Nikolas Zimmermann.
974
975         Make feColorMatrix's type attribute be "matrix" by default.
976
977         Test: svg/filters/feColorMatrix-default-type.svg
978
979         * svg/SVGFEColorMatrixElement.cpp:
980         (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
981
982 2011-10-24  Joshua Bell  <jsbell@chromium.org>
983
984         Unbreak binding generation tests
985         https://bugs.webkit.org/show_bug.cgi?id=70768
986
987         Reviewed by Darin Adler.
988
989         Update the expected output of V8 binding tests to match
990         results c/o https://bugs.webkit.org/show_bug.cgi?id=70065
991
992         * bindings/scripts/test/V8/V8TestObj.cpp:
993         (WebCore::TestObjInternal::idbKeyCallback):
994
995 2011-10-21  Nat Duca  <nduca@chromium.org>
996
997         [chromium] Add isTraceEventEnabled to PlatformSupport.
998         https://bugs.webkit.org/show_bug.cgi?id=70618
999
1000         Reviewed by Darin Fisher.
1001
1002         * platform/chromium/PlatformSupport.h:
1003
1004 2011-10-24  Mihnea Ovidenie  <mihnea@adobe.com>
1005
1006         Use StringBuilder in CSSRuleList::rulesText()/CSSSelectorList::selectorsText()
1007         https://bugs.webkit.org/show_bug.cgi?id=70746
1008
1009         Reviewed by Tony Chang.
1010
1011         Covered by existing tests.
1012
1013         * css/CSSRuleList.cpp:
1014         (WebCore::CSSRuleList::rulesText):
1015         * css/CSSSelectorList.cpp:
1016         (WebCore::CSSSelectorList::selectorsText):
1017         * css/WebKitCSSKeyframesRule.cpp:
1018         (WebCore::WebKitCSSKeyframesRule::cssText): Use CSSRuleList::rulesText() method instead of explicit loop.
1019
1020 2011-10-24  Michael Saboff  <msaboff@apple.com>
1021
1022         WebKit doesn't build with recent changes to libdispatch
1023         https://bugs.webkit.org/show_bug.cgi?id=70737
1024
1025         Added initialization for new WebKitSystemInterface function 
1026         CreateVMPressureDispatchOnMainQueue.  Changed MemoryPressureHandler::install
1027         to use new function.
1028
1029         Reviewed by Geoffrey Garen.
1030
1031         No new tests.  Moved functionality to WebKitSystemInterface.
1032
1033         * WebCore.exp.in:
1034         * platform/mac/MemoryPressureHandlerMac.mm:
1035         (WebCore::MemoryPressureHandler::install):
1036         * platform/mac/WebCoreSystemInterface.h:
1037         * platform/mac/WebCoreSystemInterface.mm:
1038
1039 2011-10-24  Joshua Bell  <jsbell@chromium.org>
1040
1041         IndexedDB: Throw DATA_ERR on invalid keys, remove null key support
1042         https://bugs.webkit.org/show_bug.cgi?id=70065
1043
1044         Reviewed by Tony Chang.
1045
1046         Part 1 of a two-sided commit. Renames IDBKey::NullType to
1047         IDBKey::InvalidType. JS binding yields this type rather
1048         than throwing immediately so the correct exception type can
1049         be raised. Checks for invalid keys added to front-end classes.
1050
1051         * bindings/js/JSIDBKeyCustom.cpp:
1052         (WebCore::toJS):
1053         * bindings/scripts/CodeGeneratorV8.pm:
1054         (TypeCanFailConversion):
1055         * bindings/v8/IDBBindingUtilities.cpp:
1056         (WebCore::createIDBKeyFromValue):
1057         * bindings/v8/custom/V8IDBKeyCustom.cpp:
1058         (WebCore::toV8):
1059         * storage/IDBCursor.cpp:
1060         (WebCore::IDBCursor::continueFunction):
1061         * storage/IDBFactory.cpp:
1062         (WebCore::IDBFactory::cmp):
1063         * storage/IDBIndex.cpp:
1064         (WebCore::IDBIndex::get):
1065         (WebCore::IDBIndex::getKey):
1066         * storage/IDBKey.cpp:
1067         (WebCore::IDBKey::IDBKey):
1068         (WebCore::IDBKey::compare):
1069         * storage/IDBKey.h:
1070         (WebCore::IDBKey::createInvalid):
1071         * storage/IDBKeyRange.cpp:
1072         (WebCore::IDBKeyRange::only):
1073         (WebCore::IDBKeyRange::lowerBound):
1074         (WebCore::IDBKeyRange::upperBound):
1075         (WebCore::IDBKeyRange::bound):
1076         * storage/IDBKeyRange.h:
1077         (WebCore::IDBKeyRange::lowerBound):
1078         (WebCore::IDBKeyRange::upperBound):
1079         (WebCore::IDBKeyRange::bound):
1080         * storage/IDBKeyRange.idl:
1081         * storage/IDBLevelDBCoding.cpp:
1082         (WebCore::IDBLevelDBCoding::encodeIDBKey):
1083         (WebCore::IDBLevelDBCoding::decodeIDBKey):
1084         * storage/IDBObjectStore.cpp:
1085         (WebCore::IDBObjectStore::get):
1086         (WebCore::IDBObjectStore::add):
1087         (WebCore::IDBObjectStore::put):
1088         (WebCore::IDBObjectStore::deleteFunction):
1089         * storage/IDBObjectStoreBackendImpl.cpp:
1090         (WebCore::IDBObjectStoreBackendImpl::put):
1091         (WebCore::IDBObjectStoreBackendImpl::putInternal):
1092         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
1093         * storage/IDBSQLiteBackingStore.cpp:
1094         (WebCore::whereSyntaxForKey):
1095         (WebCore::bindKeyToQuery):
1096         (WebCore::lowerCursorWhereFragment):
1097         (WebCore::upperCursorWhereFragment):
1098         (WebCore::bindKeyToQueryWithNulls):
1099         (WebCore::keyFromQuery):
1100
1101 2011-10-24  Alok Priyadarshi  <alokp@chromium.org>
1102
1103         [chromium] Make accelerated drawing work with threaded compositing
1104         https://bugs.webkit.org/show_bug.cgi?id=70656
1105
1106         Reviewed by James Robinson.
1107
1108         Make sure that the compositor context is not used outside LayerTextureUpdater::updateTextureRect().
1109         Created a FrameBuffer class that wraps skia gpu canvas and manages GL resources.
1110
1111         * platform/graphics/chromium/ContentLayerChromium.cpp:
1112         (WebCore::ContentLayerChromium::createTextureUpdater):
1113         * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
1114         (WebCore::FrameBuffer::FrameBuffer::FrameBuffer):
1115         (WebCore::FrameBuffer::FrameBuffer::~FrameBuffer):
1116         (WebCore::FrameBuffer::FrameBuffer::initialize):
1117         (WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
1118         (WebCore::LayerTextureUpdaterSkPicture::~LayerTextureUpdaterSkPicture):
1119         (WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate):
1120         (WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
1121         * platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
1122         * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
1123         (WebCore::CCLayerTreeHost::initialize):
1124
1125 2011-10-24  Adam Klein  <adamk@chromium.org>
1126
1127         Optimize Node::isInShadowTree to execute in constant-time
1128         https://bugs.webkit.org/show_bug.cgi?id=67686
1129
1130         Reviewed by Dimitri Glazkov.
1131
1132         No expected change in behavior, so no new tests.
1133
1134         * dom/Node.cpp:
1135         (WebCore::Node::isInShadowTree):
1136
1137 2011-10-24  Nat Duca  <nduca@chromium.org>
1138
1139         [chromium] Expose WebThread::postDelayedTask to CCThread
1140         https://bugs.webkit.org/show_bug.cgi?id=70712
1141
1142         Reviewed by James Robinson.
1143
1144         * platform/graphics/chromium/cc/CCThread.h:
1145
1146 2011-10-24  Levi Weintraub  <leviw@chromium.org>
1147
1148         <svg> fails to use explicit width and height inside <html> inside IFRAME
1149         https://bugs.webkit.org/show_bug.cgi?id=64823
1150
1151         Reviewed by Nikolas Zimmermann.
1152
1153         Checking that embedded SVG is in an SVG document before negotiating size
1154         with the host document.
1155
1156         Test: svg/as-object/svg-embedded-in-html-in-iframe.html
1157
1158         * rendering/svg/RenderSVGRoot.cpp:
1159         (WebCore::isEmbeddedThroughFrameContainingSVGDocument):
1160         (WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
1161         (WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
1162
1163 2011-10-24  Rafael Weinstein  <rafaelw@chromium.org>
1164
1165         Node::registeredMutationObserversOfType should be prefixed by "get"
1166         https://bugs.webkit.org/show_bug.cgi?id=70359
1167
1168         Reviewed by Ojan Vafai.
1169
1170         This change renames Node::registeredMutationObserversOfType to
1171         Node::getRegisteredMutationObserversOfType per the WebKit style guide.
1172
1173         No tests needed as the change is only method renaming.
1174
1175         * dom/CharacterData.cpp:
1176         (WebCore::CharacterData::dispatchModifiedEvent):
1177         * dom/ChildListMutationScope.cpp:
1178         (WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel):
1179         * dom/Element.cpp:
1180         (WebCore::enqueueAttributesMutationRecord):
1181         * dom/Node.cpp:
1182         (WebCore::Node::getRegisteredMutationObserversOfType):
1183         * dom/Node.h:
1184
1185 2011-10-24  Mark Hahnenberg  <mhahnenberg@apple.com>
1186
1187         Rename static getOwnPropertySlot to getOwnPropertySlotByIndex
1188         https://bugs.webkit.org/show_bug.cgi?id=70271
1189
1190         Reviewed by Darin Adler.
1191
1192         No new tests.
1193
1194         Renaming versions of getOwnPropertySlot that use an unsigned as the property
1195         name to "getOwnPropertySlotByIndex" in preparation for adding them to the 
1196         MethodTable, which requires unique names for each method.
1197
1198         * bindings/js/SerializedScriptValue.cpp:
1199         (WebCore::CloneSerializer::getSparseIndex):
1200         * bindings/scripts/CodeGeneratorJS.pm:
1201         (GenerateHeader):
1202         (GenerateImplementation):
1203         * bridge/runtime_array.cpp:
1204         (JSC::RuntimeArray::getOwnPropertySlotVirtual):
1205         (JSC::RuntimeArray::getOwnPropertySlotByIndex):
1206         * bridge/runtime_array.h:
1207
1208 2011-10-24  Joshua Bell  <jsbell@chromium.org>
1209
1210         IndexedDB add should fail adding an inline and passed key simultaneously
1211         https://bugs.webkit.org/show_bug.cgi?id=58598
1212
1213         Reviewed by Tony Chang.
1214
1215         Test: storage/indexeddb/mozilla/key-requirements-inline-and-passed.html
1216
1217         Implement the spec clause: passing a key into add() or put() when
1218         the object store has a key path ("inline key") is an error.
1219
1220         * storage/IDBObjectStoreBackendImpl.cpp:
1221         (WebCore::IDBObjectStoreBackendImpl::put):
1222
1223 2011-10-24  Simon Fraser  <simon.fraser@apple.com>
1224
1225         Improve debug compositing border colors
1226         https://bugs.webkit.org/show_bug.cgi?id=70742
1227
1228         Reviewed by Dean Jackson.
1229
1230         Improve the appearance of the debug borders used to indicate compositing:
1231         1. Use green for normal layers, orange for tiled layers
1232         2. Make the repaint counter translucent
1233         3. Change the color of the repaint counter to show when accelerated drawing is enabled.
1234
1235         * platform/graphics/GraphicsLayer.cpp:
1236         (WebCore::GraphicsLayer::updateDebugIndicators):
1237         * platform/graphics/mac/WebLayer.mm:
1238         (drawLayerContents):
1239
1240 2011-10-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1241
1242         [GTK] Fix make distcheck build
1243         https://bugs.webkit.org/show_bug.cgi?id=69745
1244
1245         Reviewed by Martin Robinson.
1246
1247         * GNUmakefile.am:
1248         * GNUmakefile.list.am:
1249
1250 2011-10-24  Alexander Pavlov  <apavlov@chromium.org>
1251
1252         Web Inspector: [Styles] Adding a new style rule breaks things
1253         https://bugs.webkit.org/show_bug.cgi?id=70721
1254
1255         Reviewed by Pavel Feldman.
1256
1257         We had used to swap BlankStylePropertiesSection prototype and recently got rid of this hack,
1258         but still had dependencies on the old behavior.
1259
1260         * inspector/front-end/StylesSidebarPane.js:
1261         (WebInspector.StylesSidebarPane.prototype._refreshStyleRules):
1262         (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
1263         (WebInspector.BlankStylePropertiesSection.prototype.get isBlank):
1264         (WebInspector.BlankStylePropertiesSection.prototype.expand):
1265         (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
1266         (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):
1267         (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCancelled):
1268         (WebInspector.BlankStylePropertiesSection.prototype.makeNormal):
1269
1270 2011-10-24  Pavel Feldman  <pfeldman@google.com>
1271
1272         Web Inspector: do not force document loading on reload (should happen on demand).
1273         https://bugs.webkit.org/show_bug.cgi?id=70724
1274
1275         Reviewed by Yury Semikhatsky.
1276
1277         * inspector/front-end/ConsoleMessage.js:
1278         (WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):
1279         * inspector/front-end/DOMAgent.js:
1280         (WebInspector.DOMAgent.prototype._documentUpdated):
1281         * inspector/front-end/ElementsPanel.js:
1282         (WebInspector.ElementsPanel.prototype.wasShown):
1283         * inspector/front-end/ElementsTreeOutline.js:
1284         (WebInspector.ElementsTreeOutline.prototype.setVisible):
1285
1286 2011-10-24  Eric Carlson  <eric.carlson@apple.com>
1287
1288         Drop MutableTextTrack and make TextTrack always mutable
1289         https://bugs.webkit.org/show_bug.cgi?id=62890
1290
1291         The MutableTextTrack type was removed from the spec, all text tracks are now mutable.
1292
1293         Reviewed by Sam Weinig.
1294
1295         No new tests needed, the changes just refactor existing code.
1296
1297         * CMakeLists.txt: Remove all traces of MutableTextTrack.
1298         * CodeGenerators.pri: Ditto.
1299         * DerivedSources.cpp: Ditto.
1300         * DerivedSources.make: Ditto.
1301         * GNUmakefile.list.am: Ditto.
1302         * WebCore.gypi: Ditto.
1303         * WebCore.pro: Ditto.
1304         * WebCore.xcodeproj/project.pbxproj: Ditto.
1305         * bindings/gobject/GNUmakefile.am: Ditto.
1306         * bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Ditto.
1307         * bindings/js/JSBindingsAllInOne.cpp: Ditto.
1308
1309         * bindings/js/JSTextTrackCustom.cpp: Removed.
1310
1311         * html/HTMLMediaElement.cpp:
1312         (WebCore::HTMLMediaElement::addTrack): Return a TextTrack instead of a MutableTextTrack.
1313         * html/HTMLMediaElement.h:
1314         * html/HTMLMediaElement.idl:
1315
1316         * html/LoadableTextTrack.cpp:
1317         (WebCore::LoadableTextTrack::LoadableTextTrack): Return a TextTrack instead of a MutableTextTrack.
1318
1319         * html/MutableTextTrack.cpp: Removed.
1320         * html/MutableTextTrack.h: Removed.
1321         * html/MutableTextTrack.idl: Removed.
1322
1323         * html/TextTrack.cpp:
1324         (WebCore::TextTrack::TextTrack): Remove Type parameter.
1325         (WebCore::TextTrack::addCue): New, moved from MutableTextTrack.
1326         (WebCore::TextTrack::removeCue): Ditto.
1327         (WebCore::TextTrack::newCuesLoaded): Ditto.
1328         (WebCore::TextTrack::fetchNewestCues): Ditto.
1329         * html/TextTrack.h:
1330         (WebCore::TextTrack::create): Remove Type parameter
1331         * html/TextTrack.idl: Add addCue and removeCue.
1332
1333 2011-10-24  Yury Semikhatsky  <yurys@chromium.org>
1334
1335         Web Inspector: allow debugging dedicated worker initialization
1336         https://bugs.webkit.org/show_bug.cgi?id=70723
1337
1338         Now it is possible to pause each new dedicated worker on start. The user
1339         needs to select a checkbox and then each newly created dedicated worker
1340         will be paused on the first statement until the user resumes it explicitely.
1341
1342         Reviewed by Pavel Feldman.
1343
1344         * inspector/Inspector.json: resume command is added. It is similar to GDB's run
1345         command, i.e. worker execution will be paused until explicit "resume" command is
1346         received.
1347         * inspector/InspectorInstrumentation.cpp:
1348         (WebCore::InspectorInstrumentation::shouldPauseDedicatedWorkerOnStartImpl):
1349         * inspector/InspectorInstrumentation.h:
1350         (WebCore::InspectorInstrumentation::shouldPauseDedicatedWorkerOnStart):
1351         * inspector/InspectorRuntimeAgent.cpp:
1352         (WebCore::InspectorRuntimeAgent::resume):
1353         (WebCore::InspectorRuntimeAgent::pauseWorkerContext):
1354         * inspector/InspectorRuntimeAgent.h:
1355         * inspector/InspectorWorkerAgent.cpp:
1356         (WebCore::InspectorWorkerAgent::shouldPauseDedicatedWorkerOnStart): returns true
1357         if the user chose to automatically pause all new workers.
1358         * inspector/InspectorWorkerAgent.h:
1359         * inspector/WorkerInspectorController.cpp:
1360         (WebCore::WorkerInspectorController::resume):
1361         * inspector/front-end/WorkerManager.js:
1362         (WebInspector.WorkerManager.loaded):
1363         (WebInspector.WorkerManager.loadCompleted):
1364         (WebInspector.WorkerManager.prototype._workerCreated):
1365         (WebInspector.WorkerManager.prototype.openWorkerInspector):
1366         (WebInspector.WorkerManager.prototype._openInspectorWindow):
1367         * inspector/front-end/inspector.js:
1368         (WebInspector.loaded):
1369         * workers/Worker.cpp:
1370         (WebCore::Worker::notifyFinished):
1371         * workers/WorkerContextProxy.h:
1372         * workers/WorkerMessagingProxy.cpp:
1373         (WebCore::WorkerMessagingProxy::startWorkerContext): additional flag specifying
1374         worker initial state(paused/not paused) is added to the factory method. The flag
1375         will be carried to the corresponding WorkerThread.
1376         (WebCore::WorkerMessagingProxy::connectToInspector):
1377         * workers/WorkerMessagingProxy.h:
1378
1379 2011-10-21  Nikita Vasilyev  <me@elv1s.ru>
1380
1381         Web Inspector: Make indent configurable
1382         https://bugs.webkit.org/show_bug.cgi?id=69986
1383
1384         Add a setting to choose an indent from "8 spaces", "4 spaces" (default), "2 spaces", or "Tab character".
1385
1386         Reviewed by Pavel Feldman.
1387
1388         * English.lproj/localizedStrings.js:
1389         * inspector/front-end/SettingsScreen.js:
1390         (WebInspector.SettingsScreen):
1391         (WebInspector.SettingsScreen.prototype._createSelectSetting.get p):
1392         (WebInspector.SettingsScreen.prototype._createSelectSetting.changeListener):
1393         * inspector/front-end/TextEditorModel.js:
1394         (WebInspector.TextEditorModel):
1395         * inspector/front-end/TextViewer.js:
1396
1397 2011-10-17  Andrey Kosyakov  <caseq@chromium.org>
1398
1399         Web Inspector: add "Add to Watch" option to context menu on selection in source frame
1400         https://bugs.webkit.org/show_bug.cgi?id=69924
1401
1402         Reviewed by Pavel Feldman.
1403
1404         - added 'Add to Watch' context menu item in scripts panel;
1405         - include both default and custom items into a context menu if selection is present;
1406
1407         * inspector/front-end/ScriptsPanel.js:
1408         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
1409         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.addToWatch):
1410         * inspector/front-end/SourceFrame.js:
1411         (WebInspector.SourceFrame.prototype.populateSelectionContextMenu):
1412         (WebInspector.TextViewerDelegateForSourceFrame.prototype.populateSelectionContextMenu):
1413         (WebInspector.SourceFrameDelegate.prototype.suggestedFileName):
1414         (WebInspector.SourceFrameDelegate.prototype.addToWatch):
1415         * inspector/front-end/TextViewer.js:
1416         (WebInspector.TextViewer.prototype._contextMenu):
1417         (WebInspector.TextViewerDelegate.prototype.populateSelectionContextMenu):
1418         * inspector/front-end/WatchExpressionsSidebarPane.js:
1419         (WebInspector.WatchExpressionsSidebarPane.prototype.addExpression):
1420         (WebInspector.WatchExpressionsSidebarPane.prototype._addButtonClicked):
1421         (WebInspector.WatchExpressionsSection.prototype.addExpression):
1422         (WebInspector.WatchExpressionsSection.prototype.addNewExpressionAndEdit):
1423         * page/ContextMenuController.cpp:
1424         (WebCore::ContextMenuController::showContextMenu):
1425
1426 2011-10-21  Alexander Pavlov  <apavlov@chromium.org>
1427
1428         Web Inspector: Audits hang on pages without img[src] elements
1429         https://bugs.webkit.org/show_bug.cgi?id=70604
1430
1431         Reviewed by Pavel Feldman.
1432
1433         Test: inspector/audits/audits-panel-noimages-functional.html
1434
1435         * inspector/front-end/AuditRules.js:
1436         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
1437
1438 2011-10-24  Deepak Sherveghar  <bpwv64@motorola.com>
1439
1440         [Qt] fast/events/media-focus-in-standalone-media-document.html fails
1441         https://bugs.webkit.org/show_bug.cgi?id=70110
1442
1443         Reviewed by Simon Hausmann.
1444
1445         ExtensionMap should also include media files mapping.
1446
1447         * platform/qt/MIMETypeRegistryQt.cpp: Added media files mapping.
1448
1449 2011-10-24  Pavel Feldman  <pfeldman@google.com>
1450
1451         Not reviewed: [chromium] follow up to 98228 - added missing css.
1452
1453         * WebCore.gypi:
1454
1455 2011-10-24  Pavel Feldman  <pfeldman@chromium.org>
1456
1457         Web Inspector: Make CSS files load upon View demand; split inspector.css into views.
1458         https://bugs.webkit.org/show_bug.cgi?id=70694
1459
1460         Reviewed by Yury Semikhatsky.
1461
1462         * WebCore.gypi:
1463         * WebCore.vcproj/WebCore.vcproj:
1464         * inspector/front-end/AuditsPanel.js:
1465         (WebInspector.AuditsPanel):
1466         * inspector/front-end/DataGrid.js:
1467         (WebInspector.DataGrid):
1468         * inspector/front-end/ElementsPanel.js:
1469         * inspector/front-end/NetworkPanel.js:
1470         (WebInspector.NetworkLogView):
1471         * inspector/front-end/PanelEnablerView.js:
1472         * inspector/front-end/ProfilesPanel.js:
1473         * inspector/front-end/ResourceView.js:
1474         (WebInspector.ResourceView):
1475         * inspector/front-end/ResourcesPanel.js:
1476         * inspector/front-end/ScriptsPanel.js:
1477         * inspector/front-end/TextViewer.js:
1478         * inspector/front-end/TimelinePanel.js:
1479         (WebInspector.TimelinePanel):
1480         * inspector/front-end/WebKit.qrc:
1481         * inspector/front-end/WelcomeView.js:
1482         (WebInspector.WelcomeView):
1483         * inspector/front-end/auditsPanel.css: Renamed from Source/WebCore/inspector/front-end/audits.css.
1484
1485 2011-10-24  Pavel Feldman  <pfeldman@chromium.org>
1486
1487         Web Inspector: make view load CSS files upon show.
1488         https://bugs.webkit.org/show_bug.cgi?id=70696
1489
1490         Reviewed by Yury Semikhatsky.
1491
1492         Test: inspector/view-css.html
1493
1494         * inspector/front-end/View.js:
1495         (WebInspector.View):
1496         (WebInspector.View.prototype._callOnVisibleChildren):
1497         (WebInspector.View.prototype._processWillShow):
1498         (WebInspector.View.prototype._processWasShown):
1499         (WebInspector.View.prototype._processWillHide):
1500         (WebInspector.View.prototype._processWasHidden):
1501         (WebInspector.View.prototype._processOnResize):
1502         (WebInspector.View.prototype.show):
1503         (WebInspector.View.prototype.detach):
1504         (WebInspector.View.prototype.registerRequiredCSS):
1505         (WebInspector.View.prototype._loadCSSIfNeeded):
1506         (WebInspector.View.prototype._doLoadCSS):
1507         (WebInspector.View.prototype._disableCSSIfNeeded):
1508         (WebInspector.View.prototype._doUnloadCSS):
1509
1510 2011-10-24  Pavel Feldman  <pfeldman@chromium.org>
1511
1512         Web Inspector: make DataGrid a view
1513         https://bugs.webkit.org/show_bug.cgi?id=70695
1514
1515         Reviewed by Yury Semikhatsky.
1516
1517         * inspector/front-end/ApplicationCacheItemsView.js:
1518         (WebInspector.ApplicationCacheItemsView.prototype._createDataGrid):
1519         * inspector/front-end/CookieItemsView.js:
1520         (WebInspector.CookieItemsView.prototype._updateWithCookies):
1521         (WebInspector.SimpleCookiesTable):
1522         (WebInspector.SimpleCookiesTable.prototype.setCookies):
1523         * inspector/front-end/CookiesTable.js:
1524         (WebInspector.CookiesTable):
1525         * inspector/front-end/DOMStorageItemsView.js:
1526         (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
1527         * inspector/front-end/DataGrid.js:
1528         (WebInspector.DataGrid):
1529         (WebInspector.DataGrid.prototype.onResize):
1530         * inspector/front-end/DatabaseQueryView.js:
1531         (WebInspector.DatabaseQueryView.prototype._queryFinished):
1532         (WebInspector.DatabaseQueryView.prototype._queryError):
1533         (WebInspector.DatabaseQueryView.prototype._appendViewQueryResult):
1534         (WebInspector.DatabaseQueryView.prototype._appendErrorQueryResult):
1535         (WebInspector.DatabaseQueryView.prototype._appendQueryResult):
1536         * inspector/front-end/DatabaseTableView.js:
1537         (WebInspector.DatabaseTableView.prototype._queryFinished):
1538         * inspector/front-end/DetailedHeapshotView.js:
1539         (WebInspector.DetailedHeapshotView.prototype.wasShown.profileCallback2):
1540         (WebInspector.DetailedHeapshotView.prototype.wasShown):
1541         (WebInspector.DetailedHeapshotView.prototype.onResize):
1542         * inspector/front-end/NetworkPanel.js:
1543         (WebInspector.NetworkLogView.prototype.onResize):
1544         (WebInspector.NetworkLogView.prototype._createTable):
1545         * inspector/front-end/ProfileView.js:
1546         * inspector/front-end/ResourceCookiesView.js:
1547         (WebInspector.ResourceCookiesView.prototype._buildCookiesTable):
1548         * inspector/front-end/ResourceView.js:
1549         (WebInspector.ResourceView):
1550
1551 2011-10-24  Yosifumi Inoue  <yosin@chromium.org>
1552
1553         [Forms] Setting defaultValue should hide an input placeholder.
1554         https://bugs.webkit.org/show_bug.cgi?id=70586
1555
1556         Reviewed by Kent Tamura.
1557
1558         Tests: fast/forms/placeholder-and-default-value-expected.html
1559                fast/forms/placeholder-and-default-value.html
1560
1561         When input element has default value, we should not display
1562         placeholder. Changing default value should tell rendering engine about
1563         changing display of input element.
1564
1565         * html/HTMLInputElement.cpp:
1566         (WebCore::HTMLInputElement::parseMappedAttribute): Calls updatePlaceholderVisibility for valueAttr if it doesn't have dirty value.
1567
1568 2011-10-23  Darin Adler  <darin@apple.com>
1569
1570         Eliminate OptionElement (second and final part)
1571         https://bugs.webkit.org/show_bug.cgi?id=70710
1572
1573         Reviewed by Kent Tamura.
1574
1575         * CMakeLists.txt: Removed OptionElement.h and OptionElement.cpp.
1576         * GNUmakefile.list.am: Ditto.
1577         * WebCore.gypi: Ditto.
1578         * WebCore.pro: Ditto.
1579         * WebCore.vcproj/WebCore.vcproj: Ditto.
1580         * WebCore.xcodeproj/project.pbxproj: Ditto.
1581         * dom/DOMAllInOne.cpp: Ditto.
1582
1583         * dom/OptionElement.cpp: Removed.
1584         * dom/OptionElement.h: Removed.
1585
1586         * html/HTMLSelectElement.cpp:
1587         (WebCore::HTMLSelectElement::saveLastSelection): Eliminate use of the
1588         toOptionElement function. Use hasTagName and toHTMLOptionElement instead.
1589         (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): Ditto.
1590         (WebCore::HTMLSelectElement::updateListBoxSelection): Ditto.
1591         (WebCore::HTMLSelectElement::listBoxOnChange): Ditto.
1592         (WebCore::HTMLSelectElement::recalcListItems): Ditto.
1593         (WebCore::HTMLSelectElement::selectedIndex): Ditto.
1594         (WebCore::HTMLSelectElement::setSelectedIndex): Ditto.
1595         (WebCore::HTMLSelectElement::deselectItemsWithoutValidation): Ditto.
1596         (WebCore::HTMLSelectElement::saveFormControlState): Ditto.
1597         (WebCore::HTMLSelectElement::restoreFormControlState): Ditto.
1598         (WebCore::HTMLSelectElement::appendFormData): Ditto.
1599         (WebCore::HTMLSelectElement::reset): Ditto.
1600         (WebCore::HTMLSelectElement::updateSelectedState): Ditto.
1601         (WebCore::HTMLSelectElement::lastSelectedListIndex): Ditto.
1602         (WebCore::HTMLSelectElement::typeAheadFind): Ditto.
1603         (WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Ditto.
1604
1605         * html/HTMLSelectElement.h: Changed the argument type of the
1606         deselectItemsWithoutValidation function to HTMLElement* since that's
1607         the type of an item in our items vector now.
1608
1609 2011-10-23  Yuzo Fujishima  <yuzo@google.com>
1610
1611         [chromium] Attempt to fix compilation error for Chromium OS.
1612
1613         Unreviewed.
1614
1615         * mediastream/MediaStreamTrack.cpp:
1616         (WebCore::MediaStreamTrack::kind):
1617
1618 2011-10-23  Adam Barth  <abarth@webkit.org>
1619
1620         <img crossorigin> should fail to load when CORS check fails
1621         https://bugs.webkit.org/show_bug.cgi?id=69732
1622
1623         Reviewed by Darin Adler.
1624
1625         When loading an image with the crossorigin attribute, the spec says
1626         that we're not supposed to load the image if the CORS check fails.
1627         This "fails fast" behavior is intended to help developers understand
1628         whether they've configured CORS correctly (instead of only catching the
1629         error later when trying to read back the canvas).
1630
1631         Our new behavior matches the spec and Firefox.
1632
1633         Test: http/tests/security/img-with-failed-cors-check-fails-to-load.html
1634
1635         * loader/ImageLoader.cpp:
1636         (WebCore::ImageLoader::notifyFinished):
1637
1638 2011-10-23  Noel Gordon  <noel.gordon@gmail.com>
1639
1640         [chromium] Remove GeolocationServiceGtk.{h,cpp} from the gyp projects
1641         https://bugs.webkit.org/show_bug.cgi?id=70702
1642
1643         Reviewed by Kent Tamura.
1644
1645         platform/gtk/GeolocationServiceGtk.{h,cpp} were removed in r97746, so
1646         remove references to these files from the gyp files.
1647
1648         * WebCore.gypi:
1649
1650 2011-10-23  Andreas Kling  <kling@webkit.org>
1651
1652         Move StyleSheet::addSubresourceStyleURLs() to CSSStyleSheet.
1653         https://bugs.webkit.org/show_bug.cgi?id=70690
1654
1655         Reviewed by Antti Koivisto.
1656
1657         This method isn't part of the StyleSheet DOM interface, nor is it used by
1658         XSLStyleSheet, so move it down to CSSStyleSheet and make it non-virtual.
1659         Also remove some nearby unneeded casts from CSSStyleSheet* to StyleSheet*.
1660
1661         * css/CSSStyleSheet.h:
1662         * css/StyleSheet.h:
1663         * html/HTMLLinkElement.cpp:
1664         (WebCore::HTMLLinkElement::isLoading):
1665         (WebCore::HTMLLinkElement::addSubresourceAttributeURLs):
1666         * html/HTMLStyleElement.cpp:
1667         (WebCore::HTMLStyleElement::addSubresourceAttributeURLs):
1668         (WebCore::HTMLStyleElement::disabled):
1669         (WebCore::HTMLStyleElement::setDisabled):
1670
1671 2011-10-23  Andreas Kling  <kling@webkit.org>
1672
1673         Remove style sheet constructors that take a style sheet parent.
1674         https://bugs.webkit.org/show_bug.cgi?id=70692
1675
1676         Reviewed by Antti Koivisto.
1677
1678         Style sheets are never directly parented by other style sheets, they always
1679         go via a rule (such as @import.)
1680
1681         * css/CSSStyleSheet.cpp:
1682         * css/CSSStyleSheet.h:
1683         (WebCore::CSSStyleSheet::create):
1684         * css/StyleSheet.cpp:
1685         * css/StyleSheet.h:
1686
1687 2011-10-23  Mark Hahnenberg  <mhahnenberg@apple.com>
1688
1689         Add deleteProperty to the MethodTable
1690         https://bugs.webkit.org/show_bug.cgi?id=70162
1691
1692         Reviewed by Sam Weinig.
1693
1694         No new tests.
1695
1696         * WebCore.exp.in:
1697
1698 2011-10-23  Adam Barth  <abarth@webkit.org>
1699
1700         Update baselines for run-bindings-tests.
1701
1702         * bindings/scripts/test/JS/JSTestInterface.cpp:
1703         * bindings/scripts/test/JS/JSTestInterface.h:
1704         * bindings/scripts/test/JS/JSTestObj.cpp:
1705
1706 2011-10-23  Mark Hahnenberg  <mhahnenberg@apple.com>
1707
1708         Remove getConstructDataVirtual
1709         https://bugs.webkit.org/show_bug.cgi?id=70638
1710
1711         Reviewed by Darin Adler.
1712
1713         No new tests.
1714
1715         Removed all declarations and definitions of getConstructDataVirtual.
1716         Also replaced all call sites to getConstructDataVirtual with a 
1717         corresponding lookup in the MethodTable.
1718
1719         * WebCore.exp.in:
1720         * bindings/js/JSAudioConstructor.cpp:
1721         * bindings/js/JSAudioConstructor.h:
1722         * bindings/js/JSImageConstructor.cpp:
1723         * bindings/js/JSImageConstructor.h:
1724         * bindings/js/JSOptionConstructor.cpp:
1725         * bindings/js/JSOptionConstructor.h:
1726         * bindings/js/ScriptFunctionCall.cpp:
1727         (WebCore::ScriptFunctionCall::construct):
1728         * bindings/scripts/CodeGeneratorJS.pm:
1729         (GenerateConstructorDeclaration):
1730         (GenerateConstructorDefinition):
1731         * bridge/runtime_object.cpp:
1732         * bridge/runtime_object.h:
1733
1734 2011-10-22  Geoffrey Garen  <ggaren@apple.com>
1735
1736         Separated string lifetime bits from character buffer state bits
1737         https://bugs.webkit.org/show_bug.cgi?id=70673
1738
1739         Reviewed by Anders Carlsson.
1740
1741         * bindings/scripts/CodeGeneratorJS.pm:
1742         (GenerateHashValue): Updated for string hashing changes in JavaScriptCore.
1743
1744 2011-10-22  Pratik Solanki  <psolanki@apple.com>
1745
1746         HTTPBodyStream in NSURLRequest gets lost when using CFNetwork loader
1747         https://bugs.webkit.org/show_bug.cgi?id=70583
1748         <rdar://problem/10281227>
1749
1750         Reviewed by Darin Adler.
1751
1752         Call WebCore::setHTTPBody() only if we actually have a FormData. Unconditionally calling it
1753         results in us passing 0 to wkCFURLRequestSetHTTPRequestBodyParts() which resets any input
1754         stream specified by the user on the NSURLRequest. This code matches the behavior in the
1755         Foundation version of doUpdatePlatformRequest().
1756
1757         * platform/network/cf/ResourceRequestCFNet.cpp:
1758         (WebCore::ResourceRequest::doUpdatePlatformRequest):
1759
1760 2011-10-22  Adam Bergkvist  <adam.bergkvist@ericsson.com>
1761
1762         Move all MediaStream and PeerConnection related non-platform files to WebCore/mediastream
1763         https://bugs.webkit.org/show_bug.cgi?id=70233
1764
1765         Reviewed by Adam Barth.
1766
1767         Removed affected files from build systems that don't have a MEDIA_STREAM build flag.
1768
1769         No new tests since we're just moving files.
1770
1771         * CMakeLists.txt:
1772         * CodeGenerators.pri:
1773         * DerivedSources.cpp:
1774         * DerivedSources.make:
1775         * GNUmakefile.am:
1776         * GNUmakefile.list.am:
1777         * UseJSC.cmake:
1778         * WebCore.gyp/WebCore.gyp:
1779         * WebCore.gypi:
1780         * WebCore.pro:
1781         * WebCore.vcproj/WebCore.vcproj:
1782         * WebCore.xcodeproj/project.pbxproj:
1783         * bindings/js/JSBindingsAllInOne.cpp:
1784         * dom/DOMAllInOne.cpp:
1785         * dom/DispatchTask.h: Removed unused file.
1786         * dom/ScriptExecutionContext.cpp:
1787         * mediastream/LocalMediaStream.cpp: Renamed from Source/WebCore/dom/LocalMediaStream.cpp.
1788         (WebCore::LocalMediaStream::create):
1789         (WebCore::LocalMediaStream::LocalMediaStream):
1790         (WebCore::LocalMediaStream::stop):
1791         (WebCore::LocalMediaStream::stopTimerFired):
1792         (WebCore::LocalMediaStream::~LocalMediaStream):
1793         (WebCore::LocalMediaStream::toLocalMediaStream):
1794         * mediastream/LocalMediaStream.h: Renamed from Source/WebCore/dom/LocalMediaStream.h.
1795         * mediastream/LocalMediaStream.idl: Renamed from Source/WebCore/dom/LocalMediaStream.idl.
1796         * mediastream/MediaStream.cpp: Renamed from Source/WebCore/dom/MediaStream.cpp.
1797         (WebCore::MediaStream::create):
1798         (WebCore::MediaStream::MediaStream):
1799         (WebCore::MediaStream::~MediaStream):
1800         (WebCore::MediaStream::readyState):
1801         (WebCore::MediaStream::toMediaStream):
1802         (WebCore::MediaStream::streamEnded):
1803         (WebCore::MediaStream::scriptExecutionContext):
1804         (WebCore::MediaStream::eventTargetData):
1805         (WebCore::MediaStream::ensureEventTargetData):
1806         * mediastream/MediaStream.h: Renamed from Source/WebCore/dom/MediaStream.h.
1807         (WebCore::MediaStream::label):
1808         (WebCore::MediaStream::tracks):
1809         (WebCore::MediaStream::descriptor):
1810         (WebCore::MediaStream::refEventTarget):
1811         (WebCore::MediaStream::derefEventTarget):
1812         * mediastream/MediaStream.idl: Renamed from Source/WebCore/dom/MediaStream.idl.
1813         * mediastream/MediaStreamClient.h: Renamed from Source/WebCore/page/MediaStreamClient.h.
1814         (WebCore::MediaStreamClient::~MediaStreamClient):
1815         * mediastream/MediaStreamController.cpp: Renamed from Source/WebCore/page/MediaStreamController.cpp.
1816         (WebCore::MediaStreamController::Request::Request):
1817         (WebCore::MediaStreamController::Request::localId):
1818         (WebCore::MediaStreamController::Request::frameController):
1819         (WebCore::MediaStreamController::MediaStreamController):
1820         (WebCore::MediaStreamController::~MediaStreamController):
1821         (WebCore::MediaStreamController::isClientAvailable):
1822         (WebCore::MediaStreamController::unregisterFrameController):
1823         (WebCore::MediaStreamController::registerRequest):
1824         (WebCore::MediaStreamController::generateStream):
1825         (WebCore::MediaStreamController::streamGenerated):
1826         (WebCore::MediaStreamController::streamGenerationFailed):
1827         * mediastream/MediaStreamController.h: Renamed from Source/WebCore/page/MediaStreamController.h.
1828         * mediastream/MediaStreamEvent.cpp: Renamed from Source/WebCore/p2p/MediaStreamEvent.cpp.
1829         (WebCore::MediaStreamEvent::create):
1830         (WebCore::MediaStreamEvent::MediaStreamEvent):
1831         (WebCore::MediaStreamEvent::~MediaStreamEvent):
1832         (WebCore::MediaStreamEvent::initMediaStreamEvent):
1833         (WebCore::MediaStreamEvent::stream):
1834         * mediastream/MediaStreamEvent.h: Renamed from Source/WebCore/p2p/MediaStreamEvent.h.
1835         (WebCore::MediaStreamEvent::isMediaStreamEvent):
1836         * mediastream/MediaStreamEvent.idl: Renamed from Source/WebCore/p2p/MediaStreamEvent.idl.
1837         * mediastream/MediaStreamFrameController.cpp: Renamed from Source/WebCore/page/MediaStreamFrameController.cpp.
1838         (WebCore::MediaStreamFrameController::Request::~Request):
1839         (WebCore::MediaStreamFrameController::Request::scriptExecutionContext):
1840         (WebCore::MediaStreamFrameController::Request::isGenerateStreamRequest):
1841         (WebCore::MediaStreamFrameController::Request::Request):
1842         (WebCore::MediaStreamFrameController::GenerateStreamRequest::create):
1843         (WebCore::MediaStreamFrameController::GenerateStreamRequest::~GenerateStreamRequest):
1844         (WebCore::MediaStreamFrameController::GenerateStreamRequest::isGenerateStreamRequest):
1845         (WebCore::MediaStreamFrameController::GenerateStreamRequest::abort):
1846         (WebCore::MediaStreamFrameController::GenerateStreamRequest::successCallback):
1847         (WebCore::MediaStreamFrameController::GenerateStreamRequest::errorCallback):
1848         (WebCore::MediaStreamFrameController::GenerateStreamRequest::GenerateStreamRequest):
1849         (WebCore::MediaStreamFrameController::RequestMap::abort):
1850         (WebCore::MediaStreamFrameController::RequestMap::abortAll):
1851         (WebCore::MediaStreamFrameController::MediaStreamFrameController):
1852         (WebCore::MediaStreamFrameController::~MediaStreamFrameController):
1853         (WebCore::MediaStreamFrameController::securityOrigin):
1854         (WebCore::MediaStreamFrameController::scriptExecutionContext):
1855         (WebCore::MediaStreamFrameController::pageController):
1856         (WebCore::MediaStreamFrameController::enterDetachedState):
1857         (WebCore::MediaStreamFrameController::isClientAvailable):
1858         (WebCore::MediaStreamFrameController::disconnectPage):
1859         (WebCore::MediaStreamFrameController::disconnectFrame):
1860         (WebCore::MediaStreamFrameController::transferToNewPage):
1861         (WebCore::MediaStreamFrameController::parseGenerateStreamOptions):
1862         (WebCore::MediaStreamFrameController::generateStream):
1863         (WebCore::MediaStreamFrameController::streamGenerated):
1864         (WebCore::MediaStreamFrameController::streamGenerationFailed):
1865         * mediastream/MediaStreamFrameController.h: Renamed from Source/WebCore/page/MediaStreamFrameController.h.
1866         (WebCore::MediaStreamFrameController::IdGenerator::IdGenerator):
1867         (WebCore::MediaStreamFrameController::IdGenerator::getNextId):
1868         * mediastream/MediaStreamList.cpp: Renamed from Source/WebCore/dom/MediaStreamList.cpp.
1869         (WebCore::MediaStreamList::create):
1870         (WebCore::MediaStreamList::MediaStreamList):
1871         (WebCore::MediaStreamList::~MediaStreamList):
1872         (WebCore::MediaStreamList::length):
1873         (WebCore::MediaStreamList::item):
1874         (WebCore::MediaStreamList::append):
1875         (WebCore::MediaStreamList::remove):
1876         (WebCore::MediaStreamList::contains):
1877         * mediastream/MediaStreamList.h: Renamed from Source/WebCore/dom/MediaStreamList.h.
1878         * mediastream/MediaStreamList.idl: Renamed from Source/WebCore/dom/MediaStreamList.idl.
1879         * mediastream/MediaStreamRegistry.cpp: Renamed from Source/WebCore/platform/MediaStreamRegistry.cpp.
1880         (WebCore::MediaStreamRegistry::registry):
1881         (WebCore::MediaStreamRegistry::registerMediaStreamURL):
1882         (WebCore::MediaStreamRegistry::unregisterMediaStreamURL):
1883         (WebCore::MediaStreamRegistry::mediaStream):
1884         * mediastream/MediaStreamRegistry.h: Renamed from Source/WebCore/platform/MediaStreamRegistry.h.
1885         * mediastream/MediaStreamTrack.cpp: Renamed from Source/WebCore/dom/MediaStreamTrack.cpp.
1886         (WebCore::MediaStreamTrack::create):
1887         (WebCore::MediaStreamTrack::MediaStreamTrack):
1888         (WebCore::MediaStreamTrack::~MediaStreamTrack):
1889         (WebCore::MediaStreamTrack::kind):
1890         (WebCore::MediaStreamTrack::label):
1891         (WebCore::MediaStreamTrack::enabled):
1892         (WebCore::MediaStreamTrack::setEnabled):
1893         * mediastream/MediaStreamTrack.h: Renamed from Source/WebCore/dom/MediaStreamTrack.h.
1894         * mediastream/MediaStreamTrack.idl: Renamed from Source/WebCore/dom/MediaStreamTrack.idl.
1895         * mediastream/MediaStreamTrackList.cpp: Renamed from Source/WebCore/dom/MediaStreamTrackList.cpp.
1896         (WebCore::MediaStreamTrackList::create):
1897         (WebCore::MediaStreamTrackList::MediaStreamTrackList):
1898         (WebCore::MediaStreamTrackList::~MediaStreamTrackList):
1899         (WebCore::MediaStreamTrackList::length):
1900         (WebCore::MediaStreamTrackList::item):
1901         * mediastream/MediaStreamTrackList.h: Renamed from Source/WebCore/dom/MediaStreamTrackList.h.
1902         * mediastream/MediaStreamTrackList.idl: Renamed from Source/WebCore/dom/MediaStreamTrackList.idl.
1903         * mediastream/PeerConnection.cpp: Renamed from Source/WebCore/p2p/PeerConnection.cpp.
1904         (WebCore::PeerConnection::create):
1905         (WebCore::PeerConnection::PeerConnection):
1906         (WebCore::PeerConnection::~PeerConnection):
1907         (WebCore::PeerConnection::processSignalingMessage):
1908         (WebCore::PeerConnection::readyState):
1909         (WebCore::PeerConnection::send):
1910         (WebCore::PeerConnection::addStream):
1911         (WebCore::PeerConnection::removeStream):
1912         (WebCore::PeerConnection::localStreams):
1913         (WebCore::PeerConnection::remoteStreams):
1914         (WebCore::PeerConnection::close):
1915         (WebCore::PeerConnection::iceProcessingCompleted):
1916         (WebCore::PeerConnection::sdpGenerated):
1917         (WebCore::PeerConnection::dataStreamMessageReceived):
1918         (WebCore::PeerConnection::remoteStreamAdded):
1919         (WebCore::PeerConnection::remoteStreamRemoved):
1920         (WebCore::PeerConnection::toPeerConnection):
1921         (WebCore::PeerConnection::scriptExecutionContext):
1922         (WebCore::PeerConnection::stop):
1923         (WebCore::PeerConnection::eventTargetData):
1924         (WebCore::PeerConnection::ensureEventTargetData):
1925         (WebCore::PeerConnection::scheduleInitialNegotiation):
1926         (WebCore::PeerConnection::initialNegotiationTimerFired):
1927         (WebCore::PeerConnection::ensureStreamChangeScheduled):
1928         (WebCore::PeerConnection::streamChangeTimerFired):
1929         (WebCore::PeerConnection::scheduleReadyStateChange):
1930         (WebCore::PeerConnection::readyStateChangeTimerFired):
1931         (WebCore::PeerConnection::changeReadyState):
1932         * mediastream/PeerConnection.h: Renamed from Source/WebCore/p2p/PeerConnection.h.
1933         (WebCore::PeerConnection::refEventTarget):
1934         (WebCore::PeerConnection::derefEventTarget):
1935         * mediastream/PeerConnection.idl: Renamed from Source/WebCore/p2p/PeerConnection.idl.
1936         * mediastream/SignalingCallback.h: Renamed from Source/WebCore/p2p/SignalingCallback.h.
1937         (WebCore::SignalingCallback::~SignalingCallback):
1938         * mediastream/SignalingCallback.idl: Renamed from Source/WebCore/p2p/SignalingCallback.idl.
1939         * page/Frame.cpp:
1940         * page/Navigator.cpp:
1941         * page/Page.cpp:
1942
1943 2011-10-20  Pavel Feldman  <pfeldman@google.com>
1944
1945         Web Inspector: get rid of View::hide, View::set visible, View::attach,
1946         View::set visible.
1947         https://bugs.webkit.org/show_bug.cgi?id=70523
1948
1949         This change also introduces assetions that forces view attach / detach operations
1950         to be performed explicitly.
1951
1952         Reviewed by Yury Semikhatsky.
1953
1954         * inspector/front-end/ApplicationCacheItemsView.js:
1955         (WebInspector.ApplicationCacheItemsView.prototype.wasShown):
1956         (WebInspector.ApplicationCacheItemsView.prototype.willHide):
1957         (WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
1958         * inspector/front-end/AuditsPanel.js:
1959         (WebInspector.AuditsPanel.prototype.wasShown):
1960         * inspector/front-end/ConsolePanel.js:
1961         (WebInspector.ConsolePanel.prototype.wasShown):
1962         (WebInspector.ConsolePanel.prototype.willHide):
1963         * inspector/front-end/ConsoleView.js:
1964         (WebInspector.ConsoleView.prototype.wasShown):
1965         * inspector/front-end/CookieItemsView.js:
1966         (WebInspector.CookieItemsView.prototype.wasShown):
1967         (WebInspector.CookieItemsView.prototype.willHide):
1968         (WebInspector.CookieItemsView.prototype._updateWithCookies):
1969         * inspector/front-end/DOMStorageItemsView.js:
1970         (WebInspector.DOMStorageItemsView.prototype.wasShown):
1971         (WebInspector.DOMStorageItemsView.prototype.willHide):
1972         * inspector/front-end/DatabaseQueryView.js:
1973         * inspector/front-end/DatabaseTableView.js:
1974         (WebInspector.DatabaseTableView.prototype.wasShown):
1975         * inspector/front-end/DetailedHeapshotView.js:
1976         (WebInspector.DetailedHeapshotView.prototype.willHide):
1977         (WebInspector.DetailedHeapshotView.prototype._changeView):
1978         * inspector/front-end/Drawer.js:
1979         (WebInspector.Drawer.prototype.hide):
1980         * inspector/front-end/ElementsPanel.js:
1981         (WebInspector.ElementsPanel.prototype.wasShown):
1982         (WebInspector.ElementsPanel.prototype.willHide):
1983         * inspector/front-end/EmptyView.js:
1984         (WebInspector.EmptyView.prototype.wasShown):
1985         * inspector/front-end/FontView.js:
1986         (WebInspector.FontView.prototype.wasShown):
1987         * inspector/front-end/IFrameView.js:
1988         (WebInspector.IFrameView):
1989         * inspector/front-end/ImageView.js:
1990         (WebInspector.ImageView.prototype.wasShown):
1991         * inspector/front-end/NetworkItemView.js:
1992         (WebInspector.NetworkItemView.prototype.wasShown):
1993         (WebInspector.ResourceContentView.prototype.wasShown):
1994         * inspector/front-end/NetworkPanel.js:
1995         (WebInspector.NetworkLogView.prototype.wasShown):
1996         (WebInspector.NetworkLogView.prototype.willHide):
1997         (WebInspector.NetworkPanel.prototype.wasShown):
1998         * inspector/front-end/Panel.js:
1999         (WebInspector.Panel):
2000         (WebInspector.Panel.prototype.show):
2001         (WebInspector.Panel.prototype.wasShown):
2002         (WebInspector.Panel.prototype.willHide):
2003         * inspector/front-end/PanelEnablerView.js:
2004         * inspector/front-end/ProfileView.js:
2005         (WebInspector.CPUProfileView.prototype.willHide):
2006         * inspector/front-end/ProfilesPanel.js:
2007         (WebInspector.ProfilesPanel.prototype.wasShown):
2008         (WebInspector.ProfilesPanel.prototype._addProfileHeader):
2009         (WebInspector.ProfilesPanel.prototype._updateInterface):
2010         (WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles):
2011         * inspector/front-end/ResourceCookiesView.js:
2012         (WebInspector.ResourceCookiesView.prototype.wasShown):
2013         * inspector/front-end/ResourceHTMLView.js:
2014         (WebInspector.ResourceHTMLView.prototype.wasShown):
2015         (WebInspector.ResourceHTMLView.prototype.willHide):
2016         * inspector/front-end/ResourceJSONView.js:
2017         (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype.wasShown):
2018         * inspector/front-end/ResourceTimingView.js:
2019         (WebInspector.ResourceTimingView.prototype.wasShown):
2020         * inspector/front-end/ResourcesPanel.js:
2021         (WebInspector.ResourcesPanel.prototype.wasShown):
2022         * inspector/front-end/ScriptsPanel.js:
2023         (WebInspector.ScriptsPanel.prototype.wasShown):
2024         (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
2025         * inspector/front-end/SourceFrame.js:
2026         (WebInspector.SourceFrame.prototype.wasShown):
2027         * inspector/front-end/TimelinePanel.js:
2028         (WebInspector.TimelinePanel.prototype.wasShown):
2029         (WebInspector.TimelinePanel.prototype.willHide):
2030         * inspector/front-end/View.js:
2031         (WebInspector.View):
2032         (WebInspector.View.prototype.get visible):
2033         (WebInspector.View.prototype.setHideOnDetach):
2034         (WebInspector.View.prototype._wasShown):
2035         (WebInspector.View.prototype._willHide):
2036         (WebInspector.View.prototype._onResize):
2037         (WebInspector.View.prototype.wasShown):
2038         (WebInspector.View.prototype.willHide):
2039         (WebInspector.View.prototype.onResize):
2040         (WebInspector.View.prototype.show):
2041         (WebInspector.View.prototype.detach):
2042         (WebInspector.View.prototype.doResize):
2043         (WebInspector.View.prototype.dispatchToSelfAndChildren):
2044         (WebInspector.View.prototype.dispatchToChildren):
2045         (WebInspector.View.prototype._handleInsertedIntoDocument):
2046
2047 2011-10-22  Kent Tamura  <tkent@chromium.org>
2048
2049         REGRESSION(r92480): Passing uninitialized variable in HTMLElement::calculateAndAdjustDirectionality()
2050         https://bugs.webkit.org/show_bug.cgi?id=70582
2051
2052         Reviewed by Darin Adler.
2053
2054         No new tests. It's very hard to make a reliable test.
2055
2056         * html/HTMLElement.cpp:
2057         (WebCore::HTMLElement::directionality):
2058         Clear *strongDirectionalityTextNode even if hasStrongDirectionality is false.
2059
2060 2011-10-21  Dan Bernstein  <mitz@apple.com>
2061
2062         Caret is drawn in the wrong place in multi-column blocks
2063         https://bugs.webkit.org/show_bug.cgi?id=70662
2064
2065         Reviewed by Gavin Barraclough.
2066
2067         * manual-tests/caret-in-columns.html: Added.
2068         * rendering/RenderBlock.cpp:
2069         (WebCore::RenderBlock::paintCaret): Removed the call to offsetForContents(). That function takes
2070         a point in local coordinates, whereas this function was applying it to a point in painting root
2071         coordinates. The desired effect was only to undo the scroll adjustment done by the caller,
2072         paintObject().
2073         (WebCore::RenderBlock::paintObject): Pass the original, rather than scroll-adjusted, paint offset
2074         to paintCaret().
2075
2076 2011-10-21  Nat Duca  <nduca@chromium.org>
2077
2078         [chromium] Make setVisibility extension- and thread-correct
2079         https://bugs.webkit.org/show_bug.cgi?id=70635
2080
2081         Reviewed by Kenneth Russell.
2082
2083         * platform/graphics/chromium/Extensions3DChromium.h:
2084         * platform/graphics/chromium/LayerRendererChromium.cpp:
2085         (WebCore::LayerRendererChromium::initialize):
2086         (WebCore::LayerRendererChromium::setVisible):
2087         * platform/graphics/chromium/LayerRendererChromium.h:
2088         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
2089         (WebCore::LayerRendererCapabilities::LayerRendererCapabilities):
2090         * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
2091         (WebCore::CCLayerTreeHostImpl::setVisible):
2092
2093 2011-10-21  Beth Dakin  <bdakin@apple.com>
2094
2095         https://bugs.webkit.org/show_bug.cgi?id=70647
2096         Common but unreproducible crash under [ScrollbarPartAnimation setCurrentProgress:]
2097         -and corresponding-
2098         <rdar://problem/9542018>
2099
2100         Reviewed by Sam Weinig.
2101
2102         This patch implements two speculative fixes for this crash.
2103
2104         First, block exceptions around all of the code responsible for calling 
2105         stopAnimation. If that code throws any exceptions, we want to make sure the other 
2106         animations are still stopped.
2107         * platform/mac/ScrollAnimatorMac.mm:
2108         (-[WebScrollbarPartAnimation scrollAnimatorDestroyed]):
2109         (-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]):
2110         (WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
2111
2112         Only send AppKit these notifications for active pages. I originally made these 
2113         assertions, and I found that they were hit a surprising number of times. If we 
2114         only send notifications for active pages, then we should greatly reduce and 
2115         possibly eliminate our chances of hitting this crash.
2116         (WebCore::ScrollAnimatorMac::notifyPositionChanged):
2117         (WebCore::ScrollAnimatorMac::contentAreaWillPaint):
2118         (WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
2119         (WebCore::ScrollAnimatorMac::mouseExitedContentArea):
2120         (WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
2121         (WebCore::ScrollAnimatorMac::willStartLiveResize):
2122         (WebCore::ScrollAnimatorMac::contentsResized):
2123         (WebCore::ScrollAnimatorMac::willEndLiveResize):
2124         (WebCore::ScrollAnimatorMac::contentAreaDidShow):
2125         (WebCore::ScrollAnimatorMac::contentAreaDidHide):
2126         (WebCore::ScrollAnimatorMac::didBeginScrollGesture):
2127         (WebCore::ScrollAnimatorMac::didEndScrollGesture):
2128
2129 2011-10-21  Mark Hahnenberg  <mhahnenberg@apple.com>
2130
2131         Add put to the MethodTable
2132         https://bugs.webkit.org/show_bug.cgi?id=70439
2133
2134         Reviewed by Oliver Hunt.
2135
2136         No new tests.
2137
2138         * WebCore.exp.in:
2139         * bindings/js/JSDOMWindowCustom.cpp: Added static put since it was overlooked in 
2140         previous patches.
2141         (WebCore::JSDOMWindow::putVirtual):
2142         (WebCore::JSDOMWindow::put):
2143         * bindings/js/JSDOMWindowShell.cpp: Ditto.
2144         (WebCore::JSDOMWindowShell::putVirtual):
2145         (WebCore::JSDOMWindowShell::put):
2146         * bindings/js/JSDOMWindowShell.h:
2147
2148 2011-10-21  Dmitry Lomov  <dslomov@google.com>
2149
2150         https://bugs.webkit.org/show_bug.cgi?id=70580
2151         [Chromium] Implement MessagePort transfer in chromium port of webkit.
2152
2153         Reviewed by David Levin.
2154
2155         * bindings/v8/SerializedScriptValue.cpp:
2156         (WebCore::V8ObjectMap::Writer::writeTransferredMessagePort):
2157         (WebCore::V8ObjectMap::Serializer::Serializer):
2158         (WebCore::V8ObjectMap::Serializer::doSerialize):
2159         (WebCore::V8ObjectMap::Reader::read):
2160         (WebCore::V8ObjectMap::Deserializer::Deserializer):
2161         (WebCore::V8ObjectMap::Deserializer::tryGetTransferredMessagePort):
2162         (WebCore::SerializedScriptValue::SerializedScriptValue):
2163         (WebCore::SerializedScriptValue::deserialize):
2164
2165 2011-10-21  Ojan Vafai  <ojan@chromium.org>
2166
2167         r97693 caused 42 failures on the chromium mac bots
2168         https://bugs.webkit.org/show_bug.cgi?id=70300
2169
2170         Can't test this until https://bugs.webkit.org/show_bug.cgi?id=70660
2171         is fixed. The fix for that bug will test this codepath as well though.
2172
2173         * rendering/RenderBlock.cpp:
2174         (WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
2175
2176 2011-10-21  Vineet Chaudhary  <vineet.chaudhary@motorola.com>
2177
2178         Setting form.enctype reflected attribute behaves strangely.
2179         https://bugs.webkit.org/show_bug.cgi?id=44879
2180
2181         Reviewed by Darin Adler.
2182
2183         The spec says form.enctype should be application/x-www-form-urlencoded,
2184         So as "text", "plain", "multipart" or "form-data" these are not a valid value so must be ignored.
2185
2186         * loader/FormSubmission.cpp:
2187         (WebCore::FormSubmission::Attributes::parseEncodingType):
2188
2189 2011-10-21  Matthew Delaney  <mdelaney@apple.com>
2190
2191         Ensure periodic flushing of canvas drawing context
2192         https://bugs.webkit.org/show_bug.cgi?id=70646
2193
2194         Reviewed by Simon Fraser.
2195
2196         No new tests. No current way to track tests that cause hangs or
2197         non-deterministic drops in performance.
2198
2199         * platform/graphics/cg/ImageBufferDataCG.h: Adds a timestamp of last tracked flush.
2200         * platform/graphics/cg/ImageBufferCG.cpp: Ensures periodic flushes on the drawing context.
2201         (WebCore::ImageBuffer::ImageBuffer):
2202         (WebCore::ImageBuffer::context): Flushes context if we're beyond flush interval.
2203         (WebCore::ImageBuffer::copyNativeImage): Updates last flush timestamp.
2204         (WebCore::ImageBuffer::getUnmultipliedImageData): Updates last flush timestamp.
2205         (WebCore::ImageBuffer::getPremultipliedImageData): Updates last flush timestamp.
2206         (WebCore::ImageBuffer::putUnmultipliedImageData): Updates last flush timestamp.
2207         (WebCore::ImageBuffer::putPremultipliedImageData): Updates last flush timestamp.
2208
2209 2011-10-21  Adam Barth  <abarth@webkit.org>
2210
2211         Introduce Event::hasInterface to make uses of interfaceName more readable
2212         https://bugs.webkit.org/show_bug.cgi?id=70652
2213
2214         Reviewed by Eric Seidel.
2215
2216         Eric felt that this approach would be more readable because it requires
2217         less syntax at each callsite.
2218
2219         * bindings/js/JSErrorHandler.cpp:
2220         (WebCore::JSErrorHandler::handleEvent):
2221         * bindings/objc/DOMEvents.mm:
2222         (kitClass):
2223         * bindings/v8/V8WindowErrorHandler.cpp:
2224         (WebCore::V8WindowErrorHandler::callListenerFunction):
2225         * bindings/v8/V8WorkerContextErrorHandler.cpp:
2226         (WebCore::V8WorkerContextErrorHandler::callListenerFunction):
2227         * dom/Event.cpp:
2228         (WebCore::Event::hasInterface):
2229         * dom/Event.h:
2230         * dom/EventDispatcher.cpp:
2231         (WebCore::EventDispatcher::determineDispatchBehavior):
2232         * dom/Node.cpp:
2233         (WebCore::Node::defaultEventHandler):
2234         * html/HTMLInputElement.cpp:
2235         (WebCore::HTMLInputElement::defaultEventHandler):
2236         * html/HTMLTextAreaElement.cpp:
2237         (WebCore::HTMLTextAreaElement::defaultEventHandler):
2238         * html/TextFieldInputType.cpp:
2239         (WebCore::TextFieldInputType::forwardEvent):
2240         (WebCore::TextFieldInputType::shouldSubmitImplicitly):
2241         * inspector/InspectorDOMStorageResource.cpp:
2242         (WebCore::InspectorDOMStorageResource::handleEvent):
2243
2244 2011-10-21  Adam Klein  <adamk@chromium.org>
2245
2246         [MutationObservers] Implement basic subtree observation
2247         https://bugs.webkit.org/show_bug.cgi?id=70436
2248
2249         Reviewed by Ryosuke Niwa.
2250
2251         Note that this patch only implements "basic" subtree semantics,
2252         not the fully robust semantics described in
2253         http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html.
2254         Most importantly, this change does not handle the case where mutations
2255         occur in a temporarily detached subtree.
2256
2257         The plan is to implement those semantics in a followup to avoid
2258         blocking other parts of the MutationObserver spec that rely on
2259         the existence of subtree observation but not its specific
2260         implementation.
2261
2262         Test: fast/mutation/observe-subtree.html
2263
2264         * dom/Node.cpp:
2265         (WebCore::addMatchingObservers): Static helper method for registeredMutationObserversOfType().
2266         (WebCore::Node::registeredMutationObserversOfType): Walk up the tree looking for observers.
2267         * dom/NodeRareData.h:
2268         (WebCore::MutationObserverEntry::hasAllOptions): A stricter, renamed from matches().
2269
2270 2011-10-21  Joshua Bell  <jsbell@chromium.org>
2271
2272         IndexedDB: objectStore.transaction property should be readonly
2273         https://bugs.webkit.org/show_bug.cgi?id=62395
2274
2275         Reviewed by Tony Chang.
2276
2277         Implement the IDBObjectStore.transaction property defined by the spec.
2278
2279         Test: storage/indexeddb/readonly-properties.html
2280
2281         * storage/IDBObjectStore.cpp:
2282         (WebCore::IDBObjectStore::transaction):
2283         * storage/IDBObjectStore.h:
2284         * storage/IDBObjectStore.idl:
2285
2286 2011-10-21  Adam Barth  <abarth@webkit.org>
2287
2288         Event.h has too many virtual isMumbleEvent() functions
2289         https://bugs.webkit.org/show_bug.cgi?id=70636
2290
2291         Reviewed by Dimitri Glazkov.
2292
2293         We should use the new interfaceName() way of doing run-time type inference.
2294
2295         * bindings/js/JSErrorHandler.cpp:
2296         (WebCore::JSErrorHandler::handleEvent):
2297         * bindings/js/JSEventCustom.cpp:
2298         (WebCore::JSEvent::clipboardData):
2299         * bindings/objc/DOMEvents.mm:
2300         (kitClass):
2301         * bindings/v8/V8WindowErrorHandler.cpp:
2302         (WebCore::V8WindowErrorHandler::callListenerFunction):
2303         * bindings/v8/V8WorkerContextErrorHandler.cpp:
2304         (WebCore::V8WorkerContextErrorHandler::callListenerFunction):
2305         * bindings/v8/custom/V8EventCustom.cpp:
2306         (WebCore::V8Event::clipboardDataAccessorGetter):
2307         * dom/BeforeLoadEvent.h:
2308         (WebCore::BeforeLoadEvent::interfaceName):
2309         * dom/BeforeTextInsertedEvent.h:
2310         * dom/ClipboardEvent.cpp:
2311         * dom/ClipboardEvent.h:
2312         * dom/CompositionEvent.cpp:
2313         * dom/CompositionEvent.h:
2314         * dom/ErrorEvent.cpp:
2315         * dom/ErrorEvent.h:
2316         * dom/Event.cpp:
2317         (WebCore::Event::storesResultAsString):
2318         (WebCore::Event::storeResult):
2319         (WebCore::Event::clipboardData):
2320         * dom/Event.h:
2321         * dom/Event.idl:
2322             - Remove this interface from the CPP bindings because this function
2323               no longer exists.  It's unclear to me how strong our API
2324               commitments are in the CPP bindings.
2325         * dom/EventDispatcher.cpp:
2326         (WebCore::EventDispatcher::determineDispatchBehavior):
2327         * dom/MessageEvent.cpp:
2328         * dom/MessageEvent.h:
2329         * dom/MutationEvent.cpp:
2330         * dom/MutationEvent.h:
2331         * dom/Node.cpp:
2332         (WebCore::Node::defaultEventHandler):
2333         * dom/OverflowEvent.cpp:
2334         * dom/OverflowEvent.h:
2335         * dom/PageTransitionEvent.h:
2336         * dom/ProgressEvent.h:
2337         * dom/TextEvent.cpp:
2338         * dom/TextEvent.h:
2339         * dom/WheelEvent.cpp:
2340         * dom/WheelEvent.h:
2341         * html/HTMLInputElement.cpp:
2342         (WebCore::HTMLInputElement::defaultEventHandler):
2343         * html/HTMLTextAreaElement.cpp:
2344         (WebCore::HTMLTextAreaElement::defaultEventHandler):
2345         * html/TextFieldInputType.cpp:
2346         (WebCore::TextFieldInputType::forwardEvent):
2347         (WebCore::TextFieldInputType::shouldSubmitImplicitly):
2348         * html/shadow/TextControlInnerElements.cpp:
2349         (WebCore::TextControlInnerTextElement::defaultEventHandler):
2350         * svg/SVGZoomEvent.cpp:
2351         * svg/SVGZoomEvent.h:
2352
2353 2011-10-21  Raymond Toy  <rtoy@google.com>
2354
2355         Flush denormals in Biquad, ZeroPole, and DynamicsCompressor.
2356
2357         We only flush when saving the state variables instead of in the
2358         loops so that we don't impact performance too much when there are
2359         no denormals.  This will at least not propagate the denormals any
2360         further within the class.
2361         
2362         https://bugs.webkit.org/show_bug.cgi?id=70626
2363
2364         Reviewed by Kenneth Russell.
2365
2366         * platform/audio/Biquad.cpp:
2367         (WebCore::Biquad::process):
2368         Flush denormals when storing the filter state back in to class
2369         filter state.  
2370         * platform/audio/DynamicsCompressorKernel.cpp:
2371         (WebCore::DynamicsCompressorKernel::process):
2372         Ditto.
2373         * platform/audio/ZeroPole.cpp:
2374         (WebCore::ZeroPole::process):
2375         Ditto.
2376
2377 2011-10-21  Vsevolod Vlasov  <vsevik@chromium.org>
2378
2379         Web Inspector: Advanced search results should be cleared on navigation.
2380         https://bugs.webkit.org/show_bug.cgi?id=70627
2381
2382         Reviewed by Pavel Feldman.
2383
2384         * inspector/front-end/AdvancedSearchController.js:
2385         (WebInspector.AdvancedSearchController):
2386         (WebInspector.AdvancedSearchController.prototype._frameNavigated):
2387
2388 2011-10-21  Rafael Weinstein  <rafaelw@chromium.org>
2389
2390         [MutationObservers] Implement WebKitMutationObserver.observe for childList changes
2391         https://bugs.webkit.org/show_bug.cgi?id=68955
2392
2393         Reviewed by Ryosuke Niwa.
2394
2395         This patch adds a ChildListMutationScope object which manages the coalescing of
2396         multiple child removals and additions within DOM operations into single childList
2397         mutation records.
2398
2399         Note that this patch doesn't cover all the cases which can be coalesced (it only
2400         covers ContainerNode.*, and Node.innerHTML/innerText). A separate bug,
2401         https://bugs.webkit.org/show_bug.cgi?id=70385, has been opened to track the
2402         remaining cases.
2403
2404         Test: fast/mutation/observe-childList.html
2405
2406         * CMakeLists.txt:
2407         * GNUmakefile.list.am:
2408         * WebCore.gypi:
2409         * WebCore.pro:
2410         * WebCore.vcproj/WebCore.vcproj:
2411         * WebCore.xcodeproj/project.pbxproj:
2412         * dom/ChildListMutationScope.cpp: Added.
2413         (WebCore::ChildListAccumulation::ChildListAccumulation::ChildListAccumulation):
2414         (WebCore::ChildListAccumulation::ChildListAccumulation::~ChildListAccumulation):
2415         (WebCore::ChildListAccumulation::ChildListAccumulation::childAdded):
2416         (WebCore::ChildListAccumulation::ChildListAccumulation::willRemoveChild):
2417         (WebCore::ChildListAccumulation::ChildListAccumulation::dispatch):
2418         (WebCore::ChildListAccumulation::ChildListAccumulation::clear):
2419         (WebCore::ChildListAccumulation::ChildListAccumulation::isEmpty):
2420         (WebCore::ChildListAccumulation::ChildListAccumulator::ChildListAccumulator):
2421         (WebCore::ChildListAccumulation::ChildListAccumulator::~ChildListAccumulator):
2422         (WebCore::ChildListAccumulation::ChildListAccumulator::initialize):
2423         (WebCore::ChildListAccumulation::ChildListAccumulator::instance):
2424         (WebCore::ChildListAccumulation::ChildListAccumulator::childAdded):
2425         (WebCore::ChildListAccumulation::ChildListAccumulator::willRemoveChild):
2426         (WebCore::ChildListAccumulation::ChildListAccumulator::incrementScopingLevel):
2427         (WebCore::ChildListAccumulation::ChildListAccumulator::decrementScopingLevel):
2428         (WebCore::ChildListMutationScope::ChildListMutationScope):
2429         (WebCore::ChildListMutationScope::~ChildListMutationScope):
2430         (WebCore::ChildListMutationScope::childAdded):
2431         (WebCore::ChildListMutationScope::willRemoveChild):
2432         * dom/ChildListMutationScope.h: Added.
2433         * dom/ContainerNode.cpp:
2434         (WebCore::ContainerNode::insertBefore):
2435         (WebCore::ContainerNode::replaceChild):
2436         (WebCore::willRemoveChildren):
2437         (WebCore::dispatchChildInsertionEvents):
2438         (WebCore::dispatchChildRemovalEvents):
2439         * dom/Element.cpp:
2440         (WebCore::enqueueAttributesMutationRecord):
2441         * dom/Node.cpp:
2442         (WebCore::Node::setTextContent):
2443         (WebCore::Node::registeredMutationObserversOfType):
2444         * dom/WebKitMutationObserver.cpp:
2445         (WebCore::WebKitMutationObserver::disconnect):
2446         * html/HTMLElement.cpp:
2447         (WebCore::replaceChildrenWithFragment):
2448         (WebCore::replaceChildrenWithText):
2449
2450 2011-10-21  Sheriff Bot  <webkit.review.bot@gmail.com>
2451
2452         Unreviewed, rolling out r98079.
2453         http://trac.webkit.org/changeset/98079
2454         https://bugs.webkit.org/show_bug.cgi?id=70624
2455
2456         The extensions tests enabled are failing on the Chromium Win
2457         Dbg bot (Requested by jchaffraix on #webkit).
2458
2459         * inspector/front-end/ExtensionAPI.js:
2460         (buildExtensionAPIInjectedScript):
2461
2462 2011-10-21  Dan Bernstein  <mitz@apple.com>
2463
2464         Column rules positioned incorrectly in vertical-rl block with horizontal border or padding
2465         https://bugs.webkit.org/show_bug.cgi?id=70622
2466
2467         Reviewed by Beth Dakin.
2468
2469         Tests: fast/multicol/vertical-lr/rules-with-border-before.html
2470                fast/multicol/vertical-rl/rules-with-border-before.html
2471
2472         * rendering/RenderBlock.cpp:
2473         (WebCore::RenderBlock::paintColumnRules): Changed to use the physical left border and padding for the
2474         left edge of the horizontal column rule.
2475
2476 2011-10-21  Simon Fraser  <simon.fraser@apple.com>
2477
2478         Fix Windows build.
2479
2480         * rendering/RenderLayerCompositor.cpp:
2481         (WebCore::RenderLayerCompositor::hasAnyAdditionalCompositedLayers):
2482
2483 2011-10-21  Devdatta Deshpande  <pwjd73@motorola.com>
2484
2485         [Gtk] mousemove event always has metaKey == true
2486         https://bugs.webkit.org/show_bug.cgi?id=35299
2487
2488         Reviewed by Martin Robinson.
2489
2490         GDK_MOD2_MASK doesn't always mean meta so we can't use it to identify
2491         the meta key state. Use GDK_META_MASK instead.
2492
2493         Test: platform/gtk/fast/events/event-sender-metakey.html
2494
2495         * platform/gtk/PlatformMouseEventGtk.cpp:
2496         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
2497
2498 2011-10-21  Andreas Kling  <kling@webkit.org>
2499
2500         Style and Link elements' sheet() should return CSSStyleSheet.
2501         https://bugs.webkit.org/show_bug.cgi?id=70608
2502
2503         Reviewed by Antti Koivisto.
2504
2505         Return a CSSStyleSheet* instead of a StyleSheet* in these functions
2506         since we know they are always CSSStyleSheets.
2507         Also remove some now-unnecessary isCSSStyleSheet() checks.
2508
2509         * dom/StyleElement.h:
2510         (WebCore::StyleElement::sheet):
2511         * html/HTMLLinkElement.cpp:
2512         * html/HTMLLinkElement.h:
2513         (WebCore::HTMLLinkElement::sheet):
2514         * page/PageSerializer.cpp:
2515         (WebCore::PageSerializer::serializeFrame):
2516
2517 2011-10-21  Vsevolod Vlasov  <vsevik@chromium.org>
2518
2519         Web Inspector: Advanced search is working very slowly and does not show searching progress.
2520         https://bugs.webkit.org/show_bug.cgi?id=70611
2521
2522         Search implementation changed so that we do not start searching in the next file unless
2523         the previous one was already searched. This allows to interrupt search.
2524         Not all search matches are added on UI by default now, only first 20 for each file.
2525         Search progress information and search stop button were added to drawer status bar.
2526
2527         Reviewed by Pavel Feldman.
2528
2529         * English.lproj/localizedStrings.js:
2530         * inspector/ContentSearchUtils.cpp:
2531         (WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines):
2532         (WebCore::ContentSearchUtils::countRegularExpressionMatches):
2533         * inspector/front-end/AdvancedSearchController.js:
2534         (WebInspector.AdvancedSearchController.prototype._onSearchResult):
2535         (WebInspector.AdvancedSearchController.prototype._onSearchFinished):
2536         (WebInspector.AdvancedSearchController.prototype.startSearch):
2537         (WebInspector.AdvancedSearchController.prototype.resetSearch):
2538         (WebInspector.AdvancedSearchController.prototype.stopSearch):
2539         (WebInspector.SearchView):
2540         (WebInspector.SearchView.prototype.get statusBarItems):
2541         (WebInspector.SearchView.prototype.get counterElement):
2542         (WebInspector.SearchView.prototype.set resultsPane):
2543         (WebInspector.SearchView.prototype.searchStarted):
2544         (WebInspector.SearchView.prototype._updateSearchResultsMessage):
2545         (WebInspector.SearchView.prototype._updateSearchProgress):
2546         (WebInspector.SearchView.prototype.resetResults):
2547         (WebInspector.SearchView.prototype._resetCounters):
2548         (WebInspector.SearchView.prototype.nothingFound):
2549         (WebInspector.SearchView.prototype.addSearchResult):
2550         (WebInspector.SearchView.prototype.searchFinished):
2551         (WebInspector.SearchView.prototype._searchStopButtonPressed):
2552         (WebInspector.SearchResultsPane):
2553         (WebInspector.FileBasedSearchResultsPane):
2554         (WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):
2555         (WebInspector.FileBasedSearchResultsPane.prototype._fileTreeElementExpanded):
2556         (WebInspector.FileBasedSearchResultsPane.prototype._appendSearchMatches):
2557         (WebInspector.FileBasedSearchResultsPane.prototype._appendShowMoreMatchesElement):
2558         (WebInspector.FileBasedSearchResultsPane.prototype._showMoreMatchesElementSelected):
2559         (WebInspector.FileBasedSearchResultsPane.prototype._addFileTreeElement):
2560         (WebInspector.FileBasedSearchResultsPane.prototype._regexMatchRanges):
2561         * inspector/front-end/Drawer.js:
2562         (WebInspector.Drawer.prototype.hide):
2563         * inspector/front-end/Images/statusbarButtonGlyphs.png:
2564         * inspector/front-end/ScriptsSearchScope.js:
2565         (WebInspector.ScriptsSearchScope):
2566         (WebInspector.ScriptsSearchScope.prototype.performSearch.filterOutContentScripts):
2567         (WebInspector.ScriptsSearchScope.prototype.performSearch.continueSearch):
2568         (WebInspector.ScriptsSearchScope.prototype.performSearch.searchCallbackWrapper):
2569         (WebInspector.ScriptsSearchScope.prototype.performSearch):
2570         (WebInspector.ScriptsSearchScope.prototype.stopSearch):
2571         * inspector/front-end/TimelinePanel.js:
2572         (WebInspector.TimelinePanel.prototype._registerShortcuts):
2573         * inspector/front-end/inspector.css:
2574         (#drawer-status-bar .search-status-bar-item):
2575         (#drawer-status-bar .search-status-bar-message):
2576         (#drawer-status-bar .search-status-bar-progress):
2577         (#drawer-status-bar .search-status-bar-stop-button-item):
2578         (#drawer-status-bar .search-status-bar-stop-button .glyph):
2579         (#drawer-status-bar .search-results-status-bar-message):
2580         (.search-view .search-results):
2581         (#search-results-pane-file-based .search-results-outline-disclosure):
2582         (#search-results-pane-file-based .search-result):
2583         (#search-results-pane-file-based .search-result:hover):
2584         (#search-results-pane-file-based .show-more-matches):
2585         (#search-results-pane-file-based .show-more-matches:hover):
2586         (#search-results-pane-file-based .search-match:hover):
2587         * inspector/front-end/utilities.js:
2588         ():
2589
2590 2011-10-20  Zhenyao Mo  <zmo@google.com>
2591
2592         Implement mechanism to enable privileged webgl extensions
2593         https://bugs.webkit.org/show_bug.cgi?id=70538
2594
2595         Reviewed by Darin Fisher.
2596
2597         * html/canvas/WebGLRenderingContext.cpp:
2598         (WebCore::WebGLRenderingContext::allowPrivilegedExtensions): check page/Settings flag.
2599         * page/Settings.cpp: Add the flag.
2600         (WebCore::Settings::Settings):
2601         (WebCore::Settings::setPrivilegedWebGLExtensionsEnabled):
2602         * page/Settings.h: Ditto.
2603         (WebCore::Settings::privilegedWebGLExtensionsEnabled):
2604
2605 2011-10-20  Pavel Podivilov  <podivilov@chromium.org>
2606
2607         Web Inspector: first line in file is not highlighted.
2608         https://bugs.webkit.org/show_bug.cgi?id=70504
2609
2610         Reviewed by Pavel Feldman.
2611
2612         * inspector/front-end/SourceFrame.js:
2613         (WebInspector.SourceFrame.prototype._initializeTextViewer):
2614
2615 2011-10-21  Andreas Kling  <kling@webkit.org>
2616
2617         Simplify CSSStyleRule::setSelectorText().
2618         https://bugs.webkit.org/show_bug.cgi?id=70607
2619
2620         Reviewed by Antti Koivisto.
2621
2622         Remove unnecessary isCSSStyleSheet() check and redundant Document finding
2623         logic (CSSStyleSheet::document() will return the owner node's Document just
2624         like this code would.)
2625
2626         * css/CSSStyleRule.cpp:
2627         (WebCore::CSSStyleRule::setSelectorText):
2628
2629 2011-10-21  Alejandro G. Castro  <alex@igalia.com>
2630
2631         [cairo] Forward declaration of GraphicsContextState uses class instead of struct
2632         https://bugs.webkit.org/show_bug.cgi?id=70522
2633
2634         The type is a struct not a class, replace the definition in the
2635         forward declaration.
2636
2637         Reviewed by Martin Robinson.
2638
2639         * platform/graphics/cairo/PlatformContextCairo.h:
2640
2641 2011-10-20  Andrey Kosyakov  <caseq@chromium.org>
2642
2643         Web Inspector: make extension tests pass on chromium
2644         https://bugs.webkit.org/show_bug.cgi?id=70334
2645
2646         Reviewed by Pavel Feldman.
2647
2648         * inspector/front-end/ExtensionAPI.js:
2649         (buildExtensionAPIInjectedScript):
2650
2651 2011-10-20  Peter Rybin  <peter.rybin@gmail.com>
2652
2653         Web Inspector: reimplement protocol backend/frontend source generator
2654         https://bugs.webkit.org/show_bug.cgi?id=69295
2655
2656         Reviewed by Pavel Feldman.
2657
2658         Old 2-stage python+perf generator that uses intermediate IDL output is
2659         being replaced with a solid python script. This is for simplicity and
2660         as a base for the future JSON validator.
2661
2662         * CMakeLists.txt:
2663         * CodeGenerators.pri:
2664         * DerivedSources.make:
2665         * GNUmakefile.am:
2666         * WebCore.gyp/WebCore.gyp:
2667         * inspector/CodeGeneratorInspector.pm: Removed.
2668         * inspector/CodeGeneratorInspector.py: Added.
2669         * inspector/Inspector.json:
2670         * inspector/generate-inspector-idl: Removed.
2671
2672 2011-10-20  Adam Barth  <abarth@webkit.org>
2673
2674         Attemp to fix a bunch of tests PLATFORM(MAC).  We can't use a static
2675         map because that's shared between threads (and events exist in worker
2676         threads).  It migh be better to add a thread-specific map, but we can
2677         do that in another patch.
2678
2679         * bindings/js/JSEventCustom.cpp:
2680         (WebCore::toJS):
2681         * bindings/v8/custom/V8EventCustom.cpp:
2682         (WebCore::toV8):
2683
2684 2011-10-20  Simon Fraser  <simon.fraser@apple.com>
2685
2686         Hidden composited iframes cause infinite loop
2687         https://bugs.webkit.org/show_bug.cgi?id=52655
2688
2689         Reviewed by Darin Adler.
2690         
2691         visibility:hidden is problematic for compositing, because it causes
2692         RenderLayers to be removed from the z-order layer tree. This confuses
2693         RenderLayerCompositor in several ways; it never sees these layers
2694         when traversing the tree as it computes compositing requirements, or
2695         rebuilds the layer tree.
2696         
2697         This is a particular problem with composited iframes. When an iframe
2698         becomes composited, scheduleSetNeedsStyleRecalc() is called on that
2699         iframe's ownerElement in the parent document. If this happens inside
2700         Document::updateStyleForAllDocuments(), we get into an infinite loop
2701         because notifyIFramesOfCompositingChange() queues up style update as we
2702         bounce in and out of compositing mode, so documentsThatNeedStyleRecalc
2703         never empties out.
2704         
2705         This is an initial, conservative fix that doesn't attempt to fix all
2706         the issues with visibility. It changes RenderLayerCompositor to count
2707         the number of compositing RenderLayers, and to not leave compositing
2708         mode if there are any (even if they are hidden, so not hit while
2709         traversing the z-order tree). This avoids the infinite loop.
2710
2711         Test: compositing/visibility/hidden-iframe.html
2712
2713         * rendering/RenderLayer.cpp:
2714         (WebCore::RenderLayer::ensureBacking):
2715         (WebCore::RenderLayer::clearBacking):
2716         * rendering/RenderLayerCompositor.cpp:
2717         (WebCore::RenderLayerCompositor::RenderLayerCompositor):
2718         (WebCore::RenderLayerCompositor::hasAnyAdditionalCompositedLayers):
2719         (WebCore::RenderLayerCompositor::updateCompositingLayers):
2720         (WebCore::RenderLayerCompositor::computeCompositingRequirements):
2721         * rendering/RenderLayerCompositor.h:
2722         (WebCore::RenderLayerCompositor::layerBecameComposited):
2723         (WebCore::RenderLayerCompositor::layerBecameNonComposited):
2724
2725 2011-10-20  Antoine Labour  <piman@chromium.org>
2726
2727         Make WebCore depend on translator_glsl instead of translator_common
2728         https://bugs.webkit.org/show_bug.cgi?id=70548
2729
2730         Reviewed by Kenneth Russell.
2731
2732         This is a build-only fix. Tested by checking WebKit still compiles and
2733         link.
2734
2735         * WebCore.gyp/WebCore.gyp:
2736
2737 2011-10-20  Dana Jansens  <danakj@chromium.org>
2738
2739         [Chromium] Fix opaque flag default and for ImageLayerChromium
2740         https://bugs.webkit.org/show_bug.cgi?id=70554
2741
2742         Reviewed by James Robinson.
2743
2744         Covered by layout tests.
2745
2746         * platform/graphics/chromium/ImageLayerChromium.cpp:
2747         (WebCore::ImageLayerChromium::setContents): Set opaque flag based on if the image claims to have alpha.
2748         * platform/graphics/chromium/LayerChromium.cpp:
2749         (WebCore::LayerChromium::LayerChromium): Match the default opaque value in GraphicsLayerChromium.
2750
2751 2011-10-20  Yosifumi Inoue  <yosin@chromium.org>
2752
2753         [Forms][File] Add tooltip to "No file selected" text
2754         https://bugs.webkit.org/show_bug.cgi?id=70474
2755
2756         Reviewed by Kent Tamura.
2757
2758         No new tests. Existing tests cover all changes.
2759
2760         This patch provides tooltip for text portion of upload file control
2761         tell users to know actual text of truncated text of file name and
2762         "No file selected" text. Tooltip is always displayed even if user
2763         select only one file for truncated displayed file name.
2764
2765         * html/FileInputType.cpp:
2766         (WebCore::FileInputType::defaultToolTip): Implement default tooltip logic.
2767         * html/FileInputType.h: declaration of new method defaultToolTip.
2768         * html/HTMLInputElement.cpp:
2769         (WebCore::HTMLInputElement::defaultToolTip): Impelement new method defaultToolTip.
2770         * html/HTMLInputElement.h: declaration of new method defaultToolTip.
2771         * html/InputType.cpp:
2772         (WebCore::InputType::defaultToolTip): Implement default method of defaultToolTip method.
2773         * html/InputType.h: declaration of new method defaultToolTip.
2774         * page/Chrome.cpp:
2775         (WebCore::Chrome::setToolTip): Use new method HTMLInputElement::defaultToolTip and move default tooltip logic to FileInputType::defaultToolTip method.
2776
2777 2011-10-20  Darin Adler  <darin@apple.com>
2778
2779         Remove OptionElement (first half)
2780         https://bugs.webkit.org/show_bug.cgi?id=70276
2781
2782         Reviewed by Kent Tamura.
2783
2784         Refactoring that does not require new tests.
2785
2786         * css/SelectorChecker.cpp:
2787         (WebCore::SelectorChecker::checkOneSelector): Use hasTagName
2788         and toHTMLOptionElement instead of toOptionElement.
2789
2790         * dom/OptionElement.cpp: Deleted contents. Remove file later.
2791         * dom/OptionElement.h: Ditto.
2792
2793         * html/HTMLOptionElement.cpp:
2794         (WebCore::HTMLOptionElement::HTMLOptionElement): Initialize m_isSelected.
2795         (WebCore::HTMLOptionElement::createForJSConstructor): Initialize the
2796         selected attribute rather than calling setDefaultSelected.
2797         (WebCore::HTMLOptionElement::text): Moved the code here from
2798         OptionElement::collectOptionLabelOrText.
2799         (WebCore::HTMLOptionElement::index): Moved the code here from
2800         OptionElement::optionIndex.
2801         (WebCore::HTMLOptionElement::parseMappedAttribute): Removed unneeded
2802         code to call setValue and setLabel. Changed the code that called
2803         setSelected to instead set m_isSelected and added a FIXME about why
2804         that's probably wrong, but same behavior as before.
2805         (WebCore::HTMLOptionElement::value): Moved the code here from
2806         OptionElement::collectOptionValue. Added a FIXME about incorrect
2807         whitespace stripping.
2808         (WebCore::HTMLOptionElement::selected): Use m_isSelected.
2809         (WebCore::HTMLOptionElement::setSelected): Use m_isSelected and
2810         call setSelectedState instead of OptionElement::setSelectedState.
2811         (WebCore::HTMLOptionElement::setSelectedState): Moved the code
2812         here from OptionElement::setSelectedState.
2813         (WebCore::HTMLOptionElement::label): Streamlined the code.
2814         (WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
2815         Moved the code here from OptionElement::collectOptionTextRespectingGroupLabel.
2816         (WebCore::HTMLOptionElement::insertedIntoTree): Use m_isSelected
2817         and rewrote comment for clarity.
2818         (WebCore::HTMLOptionElement::collectOptionInnerText): Moved this
2819         here from OptionElement, and changed to use StringBuilder.
2820         (WebCore::toHTMLOptionElement): Added.
2821
2822         * html/HTMLOptionElement.h: Removed OptionElement.h include.
2823         Removed OptionElement base class. Removed unneeded friend declarations.
2824         Made value and selected functions non-virtual. Removed unneeded
2825         defaultSelected and setDefaultSelected functions. Made the
2826         textIndentedToRespectGroupLabel and setSelectedState functions
2827         be non-virtual and public. Added a collectOptionInnerText function.
2828         Replaced m_data with m_value, m_label, and m_selected.
2829
2830         * html/HTMLSelectElement.cpp:
2831         (WebCore::toOptionElement): Added. Helper to keep existing code
2832         close to the same.
2833         (WebCore::HTMLSelectElement::nextValidIndex): Use hasTagName
2834         instead of isOptionElement.
2835         (WebCore::HTMLSelectElement::saveLastSelection): Use HTMLOptionElement
2836         type instead of OptionElement.
2837         (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): Ditto.
2838         (WebCore::HTMLSelectElement::updateListBoxSelection): Ditto.
2839         (WebCore::HTMLSelectElement::listBoxOnChange): Ditto.
2840         (WebCore::HTMLSelectElement::recalcListItems): Ditto.
2841         (WebCore::HTMLSelectElement::selectedIndex): Ditto.
2842         (WebCore::HTMLSelectElement::setSelectedIndex): Ditto.
2843         (WebCore::HTMLSelectElement::optionToListIndex): Ditto.
2844         (WebCore::HTMLSelectElement::listToOptionIndex): Ditto.
2845         (WebCore::HTMLSelectElement::deselectItemsWithoutValidation): Ditto.
2846         (WebCore::HTMLSelectElement::saveFormControlState): Ditto.
2847         (WebCore::HTMLSelectElement::restoreFormControlState): Ditto.
2848         (WebCore::HTMLSelectElement::appendFormData): Ditto.
2849         (WebCore::HTMLSelectElement::reset): Ditto.
2850         (WebCore::HTMLSelectElement::updateSelectedState): Ditto.
2851         (WebCore::HTMLSelectElement::lastSelectedListIndex): Ditto.
2852         (WebCore::HTMLSelectElement::typeAheadFind): Ditto.
2853         (WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Ditto.
2854         (WebCore::HTMLSelectElement::length): Ditto.
2855
2856         * rendering/RenderListBox.cpp:
2857         (WebCore::RenderListBox::updateFromElement): Use HTMLOptionElement,
2858         hasTagName, and toHTMLOptionElement.
2859         (WebCore::RenderListBox::addFocusRingRects): Ditto.
2860         (WebCore::RenderListBox::paintItemForeground): Ditto.
2861         (WebCore::RenderListBox::paintItemBackground): Ditto.
2862         * rendering/RenderMenuList.cpp:
2863         (WebCore::RenderMenuList::updateOptionsWidth): Ditto.
2864         (WebCore::RenderMenuList::setTextFromOption): Ditto.
2865         (WebCore::RenderMenuList::itemText): Ditto.
2866         (WebCore::RenderMenuList::itemIsSelected): Ditto.
2867
2868 2011-10-20  Adam Barth  <abarth@webkit.org>
2869
2870         Attempt to fix crash for infinite recursion.
2871
2872         * bindings/v8/custom/V8EventCustom.cpp:
2873         (WebCore::toV8):
2874
2875 2011-10-20  Dirk Pranke  <dpranke@chromium.org>
2876
2877         Still lots of crashes in the chromium debug bots.
2878
2879         Unreviewed, rolling out r97982.
2880         http://trac.webkit.org/changeset/97982
2881         https://bugs.webkit.org/show_bug.cgi?id=70328
2882
2883         crashing in asserts in chromium debug builds
2884
2885         * dom/DeviceMotionController.cpp:
2886         (WebCore::DeviceMotionController::timerFired):
2887         (WebCore::DeviceMotionController::addListener):
2888         (WebCore::DeviceMotionController::removeListener):
2889         (WebCore::DeviceMotionController::removeAllListeners):
2890         * dom/DeviceMotionController.h:
2891         * dom/DeviceOrientationController.cpp:
2892         * dom/DeviceOrientationController.h:
2893         * dom/Document.cpp:
2894         * dom/Document.h:
2895         * dom/ScriptExecutionContext.h:
2896         * page/GeolocationController.cpp:
2897         * page/GeolocationController.h:
2898
2899 2011-10-20  Adam Barth  <abarth@webkit.org>
2900
2901         Attempt to fix the GTK build.
2902
2903         * GNUmakefile.am:
2904
2905 2011-10-20  Adam Barth  <abarth@webkit.org>
2906
2907         CloseEvent.idl isn't conditional on WebSockets.
2908
2909         * dom/EventFactory.in:
2910
2911 2011-10-20  Adam Barth  <abarth@webkit.org>
2912
2913         Event.h shouldn't need to know about every ifdef and feature that uses events
2914         https://bugs.webkit.org/show_bug.cgi?id=70483
2915
2916         Reviewed by Eric Seidel.
2917
2918         This patch expands make_event_factory.pl to create a
2919         DOM_EVENT_INTERFACES_FOR_EACH macro that we can use to generate code
2920         for each Event interface.  We then apply that macro to removing a large
2921         number of virtual functions on Event.  Instead of having a Boolean
2922         virtual function for each subclass of Event, we have a single virtual
2923         interfaceName function, which returns an AtomicString.  We then use the
2924         AtomicString to jump through a HashMap to find the appropriate
2925         JavaScript wrapper type.
2926
2927         This patch does not remove all of the Boolean virtual functions because
2928         I got exhausted making all of these edits, but I did remove all the
2929         ones that involve ifdefs.  A future patch will remove more.
2930
2931         * WebCore.xcodeproj/project.pbxproj:
2932         * bindings/js/JSEventCustom.cpp:
2933         (WebCore::toJS):
2934         * bindings/v8/custom/V8EventCustom.cpp:
2935         (WebCore::toV8):
2936         * dom/BeforeLoadEvent.h:
2937         (WebCore::BeforeLoadEvent::interfaceName):
2938         (WebCore::BeforeLoadEvent::isBeforeLoadEvent):
2939         * dom/BeforeTextInsertedEvent.cpp:
2940         (WebCore::BeforeTextInsertedEvent::interfaceName):
2941         * dom/BeforeTextInsertedEvent.h:
2942         * dom/ClipboardEvent.cpp:
2943         (WebCore::ClipboardEvent::interfaceName):
2944         * dom/ClipboardEvent.h:
2945         * dom/CompositionEvent.cpp:
2946         (WebCore::CompositionEvent::interfaceName):
2947         * dom/CompositionEvent.h:
2948         * dom/CustomEvent.cpp:
2949         (WebCore::CustomEvent::interfaceName):
2950         * dom/CustomEvent.h:
2951         * dom/DeviceMotionEvent.cpp:
2952         (WebCore::DeviceMotionEvent::interfaceName):
2953         * dom/DeviceMotionEvent.h:
2954         * dom/DeviceOrientationEvent.cpp:
2955         (WebCore::DeviceOrientationEvent::interfaceName):
2956         * dom/DeviceOrientationEvent.h:
2957         * dom/ErrorEvent.cpp:
2958         (WebCore::ErrorEvent::interfaceName):
2959         * dom/ErrorEvent.h:
2960         * dom/Event.cpp:
2961         (WebCore::Event::interfaceName):
2962         * dom/Event.h:
2963         * dom/EventNames.cpp:
2964         (WebCore::EventNames::EventNames):
2965         * dom/EventNames.h:
2966         * dom/HashChangeEvent.h:
2967         (WebCore::HashChangeEvent::interfaceName):
2968         * dom/KeyboardEvent.cpp:
2969         (WebCore::KeyboardEvent::interfaceName):
2970         * dom/KeyboardEvent.h:
2971         * dom/MessageEvent.cpp:
2972         (WebCore::MessageEvent::interfaceName):
2973         * dom/MessageEvent.h:
2974         * dom/MouseEvent.cpp:
2975         (WebCore::MouseEvent::interfaceName):
2976         * dom/MouseEvent.h:
2977         * dom/MutationEvent.cpp:
2978         (WebCore::MutationEvent::interfaceName):
2979         * dom/MutationEvent.h:
2980         * dom/OverflowEvent.cpp:
2981         (WebCore::OverflowEvent::interfaceName):
2982         * dom/OverflowEvent.h:
2983         * dom/PageTransitionEvent.cpp:
2984         (WebCore::PageTransitionEvent::interfaceName):
2985         * dom/PageTransitionEvent.h:
2986         * dom/PopStateEvent.cpp:
2987         (WebCore::PopStateEvent::interfaceName):
2988         * dom/PopStateEvent.h:
2989         * dom/ProgressEvent.cpp:
2990         (WebCore::ProgressEvent::interfaceName):
2991         * dom/ProgressEvent.h:
2992         * dom/TextEvent.cpp:
2993         (WebCore::TextEvent::interfaceName):
2994         * dom/TextEvent.h:
2995         * dom/TouchEvent.cpp:
2996         (WebCore::TouchEvent::interfaceName):
2997         * dom/TouchEvent.h:
2998         * dom/UIEvent.h:
2999         * dom/WebKitAnimationEvent.cpp:
3000         (WebCore::WebKitAnimationEvent::interfaceName):
3001         * dom/WebKitAnimationEvent.h:
3002         * dom/WebKitTransitionEvent.cpp:
3003         (WebCore::WebKitTransitionEvent::interfaceName):
3004         * dom/WebKitTransitionEvent.h:
3005         * dom/WheelEvent.cpp:
3006         (WebCore::WheelEvent::interfaceName):
3007         * dom/WheelEvent.h:
3008         * dom/make_event_factory.pl:
3009         (printFactoryFile):
3010         (printMacroFile):
3011         (printHeadersFile):
3012         * html/canvas/WebGLContextEvent.cpp:
3013         (WebCore::WebGLContextEvent::interfaceName):
3014         * html/canvas/WebGLContextEvent.h:
3015         * inspector/InspectorDOMStorageResource.cpp:
3016         (WebCore::InspectorDOMStorageResource::handleEvent):
3017         * p2p/MediaStreamEvent.cpp:
3018         (WebCore::MediaStreamEvent::interfaceName):
3019         * p2p/MediaStreamEvent.h:
3020         * page/SpeechInputEvent.cpp:
3021         (WebCore::SpeechInputEvent::interfaceName):
3022         * page/SpeechInputEvent.h:
3023         * storage/IDBVersionChangeEvent.cpp:
3024         (WebCore::IDBVersionChangeEvent::interfaceName):
3025         * storage/IDBVersionChangeEvent.h:
3026         * storage/StorageEvent.cpp:
3027         (WebCore::StorageEvent::interfaceName):
3028         * storage/StorageEvent.h:
3029         * svg/SVGZoomEvent.cpp:
3030         (WebCore::SVGZoomEvent::interfaceName):
3031         * svg/SVGZoomEvent.h:
3032         * webaudio/AudioProcessingEvent.cpp:
3033         (WebCore::AudioProcessingEvent::interfaceName):
3034         * webaudio/AudioProcessingEvent.h:
3035         * webaudio/OfflineAudioCompletionEvent.cpp:
3036         (WebCore::OfflineAudioCompletionEvent::interfaceName):
3037         * webaudio/OfflineAudioCompletionEvent.h:
3038         * websockets/CloseEvent.h:
3039         (WebCore::CloseEvent::interfaceName):
3040         * xml/XMLHttpRequestProgressEvent.h:
3041         (WebCore::XMLHttpRequestProgressEvent::interfaceName):
3042
3043 2011-10-20  Nat Duca  <nduca@chromium.org>
3044
3045         [chromium] Route onSwapBuffersComplete from LayerRenderer to CCScheduler.
3046
3047         Reviewed by James Robinson.
3048
3049         * platform/graphics/chromium/LayerRendererChromium.cpp:
3050         (WebCore::LayerRendererSwapBuffersCompleteCallbackAdapter::create):
3051         (WebCore::LayerRendererSwapBuffersCompleteCallbackAdapter::~LayerRendererSwapBuffersCompleteCallbackAdapter):
3052         (WebCore::LayerRendererSwapBuffersCompleteCallbackAdapter::onSwapBuffersComplete):
3053         (WebCore::LayerRendererSwapBuffersCompleteCallbackAdapter::LayerRendererSwapBuffersCompleteCallbackAdapter):
3054         (WebCore::LayerRendererChromium::initialize):
3055         (WebCore::LayerRendererChromium::~LayerRendererChromium):
3056         (WebCore::LayerRendererChromium::swapBuffers):
3057         (WebCore::LayerRendererChromium::onSwapBuffersComplete):
3058         * platform/graphics/chromium/LayerRendererChromium.h:
3059         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
3060         (WebCore::CCHeadsUpDisplay::onSwapBuffers):
3061         * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
3062         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
3063         (WebCore::LayerRendererCapabilities::LayerRendererCapabilities):
3064         * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
3065         (WebCore::CCLayerTreeHostImpl::swapBuffers):
3066         (WebCore::CCLayerTreeHostImpl::onSwapBuffersComplete):
3067         * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
3068         * platform/graphics/chromium/cc/CCScheduler.cpp:
3069         (WebCore::CCScheduler::requestRedraw):
3070         (WebCore::CCScheduler::didDrawAndSwap):
3071         (WebCore::CCScheduler::didSwapBuffersComplete):
3072         (WebCore::CCScheduler::didSwapBuffersAbort):
3073         * platform/graphics/chromium/cc/CCScheduler.h:
3074         * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
3075         (WebCore::CCSingleThreadProxy::compositeImmediately):
3076         * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
3077         (WebCore::CCSingleThreadProxy::onSwapBuffersCompleteOnImplThread):
3078         * platform/graphics/chromium/cc/CCThreadProxy.cpp:
3079         (WebCore::CCThreadProxySchedulerClient::scheduleDrawAndSwap):
3080         (WebCore::CCThreadProxy::drawLayersAndReadbackOnImplThread):
3081         (WebCore::CCThreadProxy::onSwapBuffersCompleteOnImplThread):
3082         (WebCore::CCThreadProxy::finishAllRenderingOnImplThread):
3083         (WebCore::CCThreadProxy::drawLayersAndSwapOnImplThread):
3084         (WebCore::CCThreadProxy::drawLayersOnImplThread):
3085         * platform/graphics/chromium/cc/CCThreadProxy.h:
3086
3087 2011-10-20  Julien Chaffraix  <jchaffraix@webkit.org>
3088
3089         RenderDeprecatedFlexibleBox does not call its children's layout method
3090         https://bugs.webkit.org/show_bug.cgi?id=64842
3091
3092         Reviewed by David Hyatt.
3093
3094         Tests: fast/flexbox/021-vertical.html
3095                fast/flexbox/crash-flexbox-no-layout-child.html
3096
3097         The FlexBoxIterator would skip any child with visibility: collapsed. However those child
3098         would need layout but their layout() function would never be called.
3099
3100         This change refactors the way flexible box handles visibility: collapsed child and mark sure
3101         their layout() function is called but makes sure that they don't participate in the flex box
3102         dimensions.
3103
3104         * rendering/RenderDeprecatedFlexibleBox.cpp:
3105         (WebCore::FlexBoxIterator::next): Do not skip visibility: collapsed child.
3106         (WebCore::childDoesNotAffectWidthOrFlexing): Helper function.
3107
3108         (WebCore::RenderDeprecatedFlexibleBox::calcHorizontalPrefWidths):
3109         (WebCore::RenderDeprecatedFlexibleBox::calcVerticalPrefWidths):
3110         (WebCore::gatherFlexChildrenInfo):
3111         (WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
3112         (WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
3113         (WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
3114         (WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):
3115         Updated to skip the now seen visibility: collapsed child during the
3116         iteration.
3117
3118 2011-10-20  Raymond Toy  <rtoy@google.com>
3119
3120         Implement SSE denormal disabler for windows.
3121
3122         https://bugs.webkit.org/show_bug.cgi?id=70517
3123
3124         Reviewed by Kenneth Russell.
3125
3126         * platform/audio/DenormalDisabler.h:
3127         (WebCore::DenormalDisabler::DenormalDisabler):
3128         Add implementation for Windows.
3129         (WebCore::DenormalDisabler::~DenormalDisabler):
3130         Ditto.
3131         (WebCore::DenormalDisabler::flushDenormalFloatToZero):
3132         Unify Windows with mac/linux.
3133         (WebCore::DenormalDisabler::getCSR):
3134         Define only if we're not on Windows.
3135         (WebCore::DenormalDisabler::setCSR):
3136         Ditto.
3137
3138 2011-10-20  Alexey Proskuryakov  <ap@apple.com>
3139
3140         REGRESSION (r96823): Contextual menu closes immediately when control-clicking in Flash plug-in
3141         https://bugs.webkit.org/show_bug.cgi?id=70534
3142         <rdar://problem/10308827>
3143
3144         Reviewed by Darin Adler.
3145
3146         * plugins/PluginView.cpp: (WebCore::PluginView::handleEvent): Return true for contextmenu
3147         event, so that plug-ins won't get a default WebKit context menu. We can't know if the
3148         plug-in is handling mousedown (or even mouseup) by displaying a menu.
3149
3150 2011-10-17  Nat Duca  <nduca@chromium.org>
3151
3152         [chromium] Allow CCLayerTreeHostImpl to call back to proxy via CCLayerTreeHostImplClient
3153         https://bugs.webkit.org/show_bug.cgi?id=70291
3154
3155         Reviewed by James Robinson.
3156
3157         * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
3158         (WebCore::CCLayerTreeHost::createLayerTreeHostImpl):
3159         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
3160         * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
3161         (WebCore::CCLayerTreeHostImpl::create):
3162         (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
3163         (WebCore::CCLayerTreeHostImpl::scrollRootLayer):
3164         * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
3165         * platform/graphics/chromium/cc/CCScrollController.h:
3166         * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
3167         (WebCore::CCSingleThreadProxy::start):
3168         * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
3169         (WebCore::CCSingleThreadProxy::setNeedsRedrawOnImplThread):
3170         (WebCore::CCSingleThreadProxy::setNeedsCommitOnImplThread):
3171         * platform/graphics/chromium/cc/CCThreadProxy.cpp:
3172         (WebCore::CCThreadProxy::scrollRootLayerOnImplThread):
3173         (WebCore::CCThreadProxy::initializeImplOnCCThread):
3174         (WebCore::CCThreadProxy::initializeLayerRendererOnCCThread):
3175         (WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):
3176         * platform/graphics/chromium/cc/CCThreadProxy.h:
3177         (WebCore::CCThreadProxy::setNeedsRedrawOnImplThread):
3178         (WebCore::CCThreadProxy::setNeedsCommitOnImplThread):
3179
3180 2011-10-20  Tony Chang  <tony@chromium.org>
3181
3182         fix repaint bugs in new flexbox
3183         https://bugs.webkit.org/show_bug.cgi?id=70450
3184
3185         Reviewed by David Hyatt.
3186
3187         Test: css3/flexbox/repaint.html
3188               css3/flexbox/repaint-rtl-column.html
3189
3190         * rendering/RenderFlexibleBox.cpp:
3191         (WebCore::RenderFlexibleBox::layoutBlock): Use LayoutRepainter and LayoutStateMaintainer
3192             to repaint the flexbox.
3193         (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
3194         (WebCore::RenderFlexibleBox::adjustLocationLogicalTopForChild): Use repaintDuringLayoutIfMoved
3195             when changing the alignment of a child to handle the child moving.
3196
3197 2011-10-20  Dan Bernstein  <mitz@apple.com>
3198
3199         Flipped-blocks writing mode blocks do not hit test their overflow
3200         https://bugs.webkit.org/show_bug.cgi?id=70546
3201
3202         Reviewed by Sam Weinig.
3203
3204         Test: fast/writing-mode/flipped-blocks-hit-test-overflow.html
3205
3206         * rendering/RenderBlock.cpp:
3207         (WebCore::RenderBlock::nodeAtPoint): Flip the overflow rect if necessary.
3208
3209 2011-10-20  David Hyatt  <hyatt@apple.com>
3210
3211         https://bugs.webkit.org/show_bug.cgi?id=70539
3212         
3213         Make the 'clip' property work in variable width regions.
3214
3215         Reviewed by Dan Bernstein.
3216
3217         Added new test in fast/regions.
3218
3219         * rendering/RenderBox.cpp:
3220         (WebCore::RenderBox::clipRect):
3221         * rendering/RenderBox.h:
3222         * rendering/RenderLayer.cpp:
3223         (WebCore::RenderLayer::calculateClipRects):
3224         (WebCore::RenderLayer::calculateRects):
3225         (WebCore::RenderLayer::repaintBlockSelectionGaps):
3226         * rendering/RenderLayerBacking.cpp:
3227         (WebCore::clipBox):
3228
3229 2011-10-20  Simon Fraser  <simon.fraser@apple.com>
3230
3231         Fix build breakage on some platforms after r98008.
3232
3233         * page/FrameTree.cpp:
3234
3235 2011-10-20  Vincent Scheib  <scheib@chromium.org>
3236
3237         MouseLock compile and run time flags.
3238         https://bugs.webkit.org/show_bug.cgi?id=70530
3239
3240         Reviewed by Darin Fisher.
3241
3242         No new tests.
3243
3244         * bindings/generic/RuntimeEnabledFeatures.cpp:
3245         * bindings/generic/RuntimeEnabledFeatures.h:
3246         (WebCore::RuntimeEnabledFeatures::webkitMouseLockAPIEnabled):
3247         (WebCore::RuntimeEnabledFeatures::setWebkitMouseLockAPIEnabled):
3248         (WebCore::RuntimeEnabledFeatures::webkitLockMouseEnabled):
3249         (WebCore::RuntimeEnabledFeatures::webkitUnlockMouseEnabled):
3250         (WebCore::RuntimeEnabledFeatures::webkitMouseLockedEnabled):
3251         * page/Settings.cpp:
3252         (WebCore::Settings::Settings):
3253         * page/Settings.h:
3254         (WebCore::Settings::setMouseLockEnabled):
3255         (WebCore::Settings::mouseLockEnabled):
3256
3257 2011-10-20  Tony Chang  <tony@chromium.org>
3258
3259         Fix a compiler warning in MediaStreamTrack.cpp:
3260         ../../third_party/WebKit/Source/WebCore/dom/MediaStreamTrack.cpp: In member function 'WTF::String WebCore::MediaStreamTrack::kind() const':
3261         ../../third_party/WebKit/Source/WebCore/dom/MediaStreamTrack.cpp:61:1: error: control reaches end of non-void function [-Werror=return-type]
3262
3263         Unreviewed build fix.
3264
3265         * dom/MediaStreamTrack.cpp:
3266         (WebCore::MediaStreamTrack::kind):
3267
3268 2011-10-20  Gustavo Noronha Silva  <gns@gnome.org>
3269
3270         One more GTK+ build fix. Remove CueLoader files from the build.
3271
3272         * GNUmakefile.list.am:
3273
3274 2011-10-20  Ken Buchanan <kenrb@chromium.org>
3275
3276         Crash in updateFirstLetter on :after generated content
3277         https://bugs.webkit.org/show_bug.cgi?id=70031
3278
3279         Reviewed by David Hyatt.
3280
3281         Preventing findBeforeAfterParent() from returning a first-letter block and overwriting its style.
3282         Instead, it returns the block's parent.
3283
3284         * rendering/RenderBlock.cpp:
3285         (WebCore::RenderBlock::updateFirstLetter):
3286         * rendering/RenderObjectChildList.cpp:
3287         (WebCore::findBeforeAfterParent)
3288         (WebCore::RenderObjectChildList::updateBeforeAfterContent): First-letter siblings now already have style applied, so this clause is redundant
3289
3290 2011-10-20  Simon Fraser  <simon.fraser@apple.com>
3291
3292         Add a way to print the Frame tree from the debugger.
3293
3294         Reviewed by Sam Weinig.
3295         
3296         Add a showFrameTree(frame) method, callable from gdb,
3297         which dumps the Frame tree, including the frame's view,
3298         document, owner element and URI.
3299
3300         * page/FrameTree.cpp:
3301         (printIndent):
3302         (printFrames):
3303         (showFrameTree):
3304         * page/FrameTree.h:
3305         * rendering/RenderLayer.cpp:
3306         (WebCore::RenderLayer::updateClipRects):
3307         * rendering/RenderLayerCompositor.cpp:
3308         (WebCore::RenderLayerCompositor::requiresCompositingForFrame):
3309
3310 2011-10-20  Andreas Kling  <kling@webkit.org>
3311
3312         Remove StyleBase::cssText().
3313         https://bugs.webkit.org/show_bug.cgi?id=70521
3314
3315         Reviewed by Antti Koivisto.
3316
3317         * css/StyleBase.cpp:
3318         * css/StyleBase.h:
3319
3320 2011-10-20  Eugene Nalimov  <enal@chromium.org>
3321
3322         Playing HTMLAudioElement can be garbage collected
3323         https://bugs.webkit.org/show_bug.cgi?id=66878
3324
3325         Reviewed by Adam Barth.
3326
3327         Make HTMLAudioElement an 'active' one, meaning that it cannot be
3328         garbage collected if it has panding activity. Had to make
3329         HTMLMediaElement::hasPendingActivity() and
3330         HTMLAudioElement::hasPendingActivity() public, otherwise automatically
3331         generated code would not compile. 
3332
3333         Test: no test, as automatic test is blocked by
3334         https://bugs.webkit.org/show_bug.cgi?id=70421
3335         You don't want to sit down and listen if audio stream played completely,
3336         and cannot rely on 'ended' event because events are lost when events
3337         listener is collected. 
3338
3339         * html/HTMLAudioElement.idl:
3340         * html/HTMLAudioElement.h:
3341         (WebCore::HTMLAudioElement::hasPendingActivity):
3342         * html/HTMLMediaElement.h:
3343
3344 2011-10-20  Mark Hahnenberg  <mhahnenberg@apple.com>
3345
3346         Rename static deleteProperty to deletePropertyByIndex
3347         https://bugs.webkit.org/show_bug.cgi?id=70257
3348
3349         Reviewed by Geoffrey Garen.
3350
3351         No new tests.
3352
3353         Renaming versions of deleteProperty that use an unsigned as the property
3354         name to "deletePropertyByIndex" in preparation for adding them to the 
3355         MethodTable, which requires unique names for each method.
3356
3357         * bridge/runtime_array.cpp:
3358         (JSC::RuntimeArray::deletePropertyVirtual):
3359         (JSC::RuntimeArray::deletePropertyByIndex):
3360         * bridge/runtime_array.h:
3361
3362 2011-10-20  Eric Carlson  <eric.carlson@apple.com>
3363
3364         Rename some Cue classes to TextTrack
3365         https://bugs.webkit.org/show_bug.cgi?id=70346
3366
3367         Rename CueLoader -> TextTrackLoader, CachedCues -> CachedTextTrack, and CueIndex -> TextTrackIndex.
3368
3369         Reviewed by Darin Adler.
3370
3371         No new tests, renames only.
3372
3373         * CMakeLists.txt:
3374         * GNUmakefile.list.am:
3375         * WebCore.gypi:
3376         * WebCore.pro:
3377         * WebCore.xcodeproj/project.pbxproj:
3378         * html/CueIndex.cpp: Removed.
3379         * html/CueIndex.h: Removed.
3380         * html/LoadableTextTrack.cpp:
3381         (WebCore::LoadableTextTrack::load):
3382         (WebCore::LoadableTextTrack::newCuesAvailable):
3383         (WebCore::LoadableTextTrack::cueLoadingStarted):
3384         (WebCore::LoadableTextTrack::cueLoadingCompleted):
3385         * html/LoadableTextTrack.h:
3386         (WebCore::LoadableTextTrack::shouldLoadCues):
3387         * html/MutableTextTrack.h:
3388         * html/TextTrackIndex.cpp: Copied from Source/WebCore/html/CueIndex.cpp.
3389         (WebCore::TextTrackCueSet::difference):
3390         (WebCore::TextTrackCueSet::unionSet):
3391         (WebCore::TextTrackCueSet::add):
3392         (WebCore::TextTrackCueSet::contains):
3393         (WebCore::TextTrackCueSet::remove):
3394         (WebCore::TextTrackCueSet::isEmpty):
3395         (WebCore::TextTrackCueSet::size):
3396         (WebCore::TextTrackIndex::fetchNewCuesFromLoader):
3397         (WebCore::TextTrackIndex::removeCuesFromIndex):
3398         (WebCore::TextTrackIndex::visibleCuesAtTime):
3399         (WebCore::TextTrackIndex::add):
3400         (WebCore::TextTrackIndex::remove):
3401         * html/TextTrackIndex.h: Copied from Source/WebCore/html/CueIndex.h.
3402         (WebCore::TextTrackCueSet::TextTrackCueSet):
3403         (WebCore::TextTrackCueSet::~TextTrackCueSet):
3404         * loader/CueLoader.cpp: Removed.
3405         * loader/CueLoader.h: Removed.
3406         * loader/TextTrackLoader.cpp: Copied from Source/WebCore/loader/CueLoader.cpp.
3407         (WebCore::TextTrackLoader::TextTrackLoader):
3408         (WebCore::TextTrackLoader::~TextTrackLoader):
3409         (WebCore::TextTrackLoader::cueLoadTimerFired):
3410         (WebCore::TextTrackLoader::processNewCueData):
3411         (WebCore::TextTrackLoader::didReceiveData):
3412         (WebCore::TextTrackLoader::notifyFinished):
3413         (WebCore::TextTrackLoader::load):
3414         (WebCore::TextTrackLoader::newCuesParsed):
3415         (WebCore::TextTrackLoader::getNewCues):
3416         * loader/TextTrackLoader.h: Copied from Source/WebCore/loader/CueLoader.h.
3417         (WebCore::TextTrackLoaderClient::~TextTrackLoaderClient):
3418         (WebCore::TextTrackLoader::create):
3419         * loader/cache/CachedCues.cpp: Removed.
3420         * loader/cache/CachedCues.h: Removed.
3421         * loader/cache/CachedResourceLoader.cpp:
3422         (WebCore::createResource):
3423         (WebCore::CachedResourceLoader::requestCues):
3424         * loader/cache/CachedResourceLoader.h:
3425         * loader/cache/CachedTextTrack.cpp: Copied from Source/WebCore/loader/cache/CachedCues.cpp.
3426         (WebCore::CachedTextTrack::CachedTextTrack):
3427         (WebCore::CachedTextTrack::~CachedTextTrack):
3428         (WebCore::CachedTextTrack::data):
3429         * loader/cache/CachedTextTrack.h: Copied from Source/WebCore/loader/cache/CachedCues.h.
3430
3431 2011-10-20  Joseph Pecoraro  <joepeck@webkit.org>
3432
3433         Remove Now Unused FileChooserSettings.deprecatedAcceptTypes
3434         https://bugs.webkit.org/show_bug.cgi?id=70473
3435
3436         Reviewed by Dan Bernstein.
3437
3438         * html/FileInputType.cpp:
3439         (WebCore::FileInputType::handleDOMActivateEvent):
3440         (WebCore::FileInputType::receiveDropForDirectoryUpload):
3441         * platform/FileChooser.h:
3442
3443 2011-10-20  Andreas Kling  <kling@webkit.org>
3444
3445         Simplify CSSParser::document().
3446         https://bugs.webkit.org/show_bug.cgi?id=70518
3447
3448         Reviewed by Antti Koivisto.
3449
3450         We don't need to climb up the entire parent chain here to find the
3451         Document, just grab it from m_styleSheet (which will do the climbing
3452         for us if necessary.)
3453
3454         * css/CSSParser.cpp:
3455         (WebCore::CSSParser::document):
3456
3457 2011-10-20  Pierre Rossi  <pierre.rossi@gmail.com>
3458
3459         [Qt] FontCache::createFontPlatformData() is broken, a default font is returned
3460         even if the family does not match.
3461         https://bugs.webkit.org/show_bug.cgi?id=55036
3462
3463         The problem here was that a FontPlatformData
3464         object is always created, regardless of whether
3465         the request for a given font family can be
3466         satisfied or not.
3467
3468         Reviewed by Andreas Kling.
3469
3470         Covered by existing tests.
3471
3472         * platform/graphics/qt/FontCacheQt.cpp:
3473         (WebCore::FontCache::createFontPlatformData):
3474
3475 2011-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3476
3477         When user is panning with the tiled backing store, the page
3478         isn't notified about the scroll position change
3479         https://bugs.webkit.org/show_bug.cgi?id=70495
3480
3481      &nbs