Unreviewed, rolling out r97954.
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-10-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2
3         Unreviewed, rolling out r97954.
4         http://trac.webkit.org/changeset/97954
5         https://bugs.webkit.org/show_bug.cgi?id=70486
6
7         clean build failed on chromium.mac: File
8         "../inspector/CodeGeneratorInspector.py", line 34, in <module>
9         import json (Requested by loislo on #webkit).
10
11         * CMakeLists.txt:
12         * CodeGenerators.pri:
13         * DerivedSources.make:
14         * GNUmakefile.am:
15         * WebCore.gyp/WebCore.gyp:
16         * inspector/CodeGeneratorInspector.pm: Added.
17         (new):
18         (GenerateModule):
19         (GenerateInterface):
20         (generateAgentDeclaration):
21         (generateFrontendConstructorImpl):
22         (generateFunctions):
23         (generateFrontendFunction):
24         (camelCase):
25         (generateBackendFunction):
26         (generateBackendSendResponse):
27         (generateBackendReportProtocolError):
28         (generateArgumentGetters):
29         (generateBackendDispatcher):
30         (generateBackendMessageParser):
31         (collectBackendJSStubFunctions):
32         (collectBackendJSStubEvents):
33         (generateBackendStubJS):
34         (generateHeader):
35         (generateSource):
36         (typeTraits):
37         (paramTypeTraits):
38         (generateBackendAgentFieldsAndConstructor):
39         (finish):
40         * inspector/CodeGeneratorInspector.py: Removed.
41         * inspector/Inspector.json:
42         * inspector/generate-inspector-idl: Added.
43
44 2011-10-20  Adenilson Cavalcanti  <adenilson.silva@openbossa.org>
45
46         Enable geolocation client based flag for Qt5
47         https://bugs.webkit.org/show_bug.cgi?id=70330
48
49         Reviewed by Kenneth Rohde Christiansen.
50
51         This will enable client based geolocation for Qt5.
52
53         No new tests, this enables flags for Qt5.
54
55         * features.pri:
56
57 2011-10-20  Kentaro Hara  <haraken@chromium.org>
58
59         Implement a MessageEvent constructor for V8
60         https://bugs.webkit.org/show_bug.cgi?id=70296
61
62         Reviewed by Adam Barth.
63
64         Test: fast/events/constructors/message-event-constructor.html
65
66         * bindings/v8/OptionsObject.cpp:
67         (WebCore::OptionsObject::getKeyValue): Returns RefPtr<DOMWindow> corresponding to a given key.
68         (WebCore::OptionsObject::getKeyValue): Returns MessagePortArray corresponding to a given key.
69         * bindings/v8/OptionsObject.h:
70         * bindings/v8/custom/V8EventConstructors.cpp: Added a MessageEvent constructor.
71         * dom/MessageEvent.idl: Makes MessageEvent constructible for V8.
72
73 2011-10-20  Peter Rybin  <peter.rybin@gmail.com>
74
75         Web Inspector: reimplement protocol backend/frontend source generator
76         https://bugs.webkit.org/show_bug.cgi?id=69295
77
78         Reviewed by Pavel Feldman.
79
80         Old 2-stage python+perf generator that uses intermediate IDL output is
81         being replaced with a solid python script. This is for simplicity and
82         as a base for the future JSON validator.
83
84         * CMakeLists.txt:
85         * CodeGenerators.pri:
86         * DerivedSources.make:
87         * GNUmakefile.am:
88         * WebCore.gyp/WebCore.gyp:
89         * inspector/CodeGeneratorInspector.pm: Removed.
90         * inspector/CodeGeneratorInspector.py: Added.
91         * inspector/Inspector.json:
92         * inspector/generate-inspector-idl: Removed.
93
94 2011-10-18  Pavel Podivilov  <podivilov@chromium.org>
95
96         Web Inspector: encode source map url as source map page url query parameter.
97         https://bugs.webkit.org/show_bug.cgi?id=70327
98
99         Reviewed by Pavel Feldman.
100
101         * inspector/front-end/CompilerSourceMappingProvider.js:
102         (WebInspector.CompilerSourceMappingProvider):
103         (WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping.frameLoaded):
104         (WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping):
105         (WebInspector.CompilerSourceMappingProvider.prototype.loadSourceCode):
106         (WebInspector.CompilerSourceMappingProvider.prototype._sendRequest):
107         * inspector/front-end/RawSourceCode.js:
108         (WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiSourceCodeList):
109
110 2011-10-19  Alexander Pavlov  <apavlov@chromium.org>
111
112         Web Inspector: The "x" in "980px x 36px" looks weird in the inspector node callout
113         https://bugs.webkit.org/show_bug.cgi?id=69857
114
115         Reviewed by Pavel Feldman.
116
117         * inspector/DOMNodeHighlighter.cpp:
118
119 2011-10-20  Sheriff Bot  <webkit.review.bot@gmail.com>
120
121         Unreviewed, rolling out r97917.
122         http://trac.webkit.org/changeset/97917
123         https://bugs.webkit.org/show_bug.cgi?id=70475
124
125         number of crashes on Snow Leopard/Lion tests bots
126         http://build.webkit.org/results/Lion%20Intel%20Release%20(Tests)/r97917%20(2020)/http/tests/inspector
127         /extensions-network-redirect-crash-log.txt (Requested by
128         loislo on #webkit).
129
130         * css/SelectorChecker.cpp:
131         (WebCore::SelectorChecker::checkOneSelector):
132         * dom/OptionElement.cpp:
133         (WebCore::OptionElement::setSelectedState):
134         (WebCore::OptionElement::optionIndex):
135         (WebCore::OptionElement::collectOptionLabelOrText):
136         (WebCore::OptionElement::collectOptionInnerText):
137         (WebCore::OptionElement::normalizeText):
138         (WebCore::OptionElement::collectOptionTextRespectingGroupLabel):
139         (WebCore::OptionElementData::OptionElementData):
140         (WebCore::OptionElementData::~OptionElementData):
141         (WebCore::toOptionElement):
142         (WebCore::isOptionElement):
143         * dom/OptionElement.h:
144         (WebCore::OptionElement::~OptionElement):
145         (WebCore::OptionElementData::value):
146         (WebCore::OptionElementData::setValue):
147         (WebCore::OptionElementData::label):
148         (WebCore::OptionElementData::setLabel):
149         (WebCore::OptionElementData::selected):
150         (WebCore::OptionElementData::setSelected):
151         * html/HTMLOptionElement.cpp:
152         (WebCore::HTMLOptionElement::HTMLOptionElement):
153         (WebCore::HTMLOptionElement::createForJSConstructor):
154         (WebCore::HTMLOptionElement::text):
155         (WebCore::HTMLOptionElement::index):
156         (WebCore::HTMLOptionElement::parseMappedAttribute):
157         (WebCore::HTMLOptionElement::value):
158         (WebCore::HTMLOptionElement::selected):
159         (WebCore::HTMLOptionElement::setSelected):
160         (WebCore::HTMLOptionElement::setSelectedState):
161         (WebCore::HTMLOptionElement::defaultSelected):
162         (WebCore::HTMLOptionElement::setDefaultSelected):
163         (WebCore::HTMLOptionElement::label):
164         (WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
165         (WebCore::HTMLOptionElement::insertedIntoTree):
166         * html/HTMLOptionElement.h:
167         * html/HTMLSelectElement.cpp:
168         (WebCore::HTMLSelectElement::nextValidIndex):
169         (WebCore::HTMLSelectElement::saveLastSelection):
170         (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
171         (WebCore::HTMLSelectElement::updateListBoxSelection):
172         (WebCore::HTMLSelectElement::listBoxOnChange):
173         (WebCore::HTMLSelectElement::recalcListItems):
174         (WebCore::HTMLSelectElement::selectedIndex):
175         (WebCore::HTMLSelectElement::setSelectedIndex):
176         (WebCore::HTMLSelectElement::optionToListIndex):
177         (WebCore::HTMLSelectElement::listToOptionIndex):
178         (WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
179         (WebCore::HTMLSelectElement::saveFormControlState):
180         (WebCore::HTMLSelectElement::restoreFormControlState):
181         (WebCore::HTMLSelectElement::appendFormData):
182         (WebCore::HTMLSelectElement::reset):
183         (WebCore::HTMLSelectElement::updateSelectedState):
184         (WebCore::HTMLSelectElement::lastSelectedListIndex):
185         (WebCore::HTMLSelectElement::typeAheadFind):
186         (WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
187         (WebCore::HTMLSelectElement::length):
188         * platform/graphics/cg/ImageBufferCG.cpp:
189         (WebCore::ImageBuffer::copyImage):
190         * rendering/RenderListBox.cpp:
191         (WebCore::RenderListBox::updateFromElement):
192         (WebCore::RenderListBox::addFocusRingRects):
193         (WebCore::RenderListBox::paintItemForeground):
194         (WebCore::RenderListBox::paintItemBackground):
195         * rendering/RenderMenuList.cpp:
196         (WebCore::RenderMenuList::updateOptionsWidth):
197         (WebCore::RenderMenuList::setTextFromOption):
198         (WebCore::RenderMenuList::itemText):
199         (WebCore::RenderMenuList::itemIsSelected):
200
201 2011-10-20  Carol Szabo  <carol@webkit.org>
202
203         Tiled Backing Store does not regenerate tiles when it should
204         https://bugs.webkit.org/show_bug.cgi?id=57798
205
206         Reviewed by Darin Adler.
207
208         Changed TiledBackingStore::adjustVisibleRect to take into account
209         contentsSize, the same way as it is done when tiles are generated.
210
211         This is an issue that requires a certain sequence of API calls which
212         may not be easily simulated from DumpRenderTree, but which is 
213         easily reproduced with QtTest. This is why I have provided only
214         a Qt specific test despite this being a generic problem.
215
216         * platform/graphics/TiledBackingStore.cpp:
217         (WebCore::TiledBackingStore::adjustVisibleRect):
218         Changed to take into account ContentsSize.
219         (WebCore::TiledBackingStore::visibleContentsRect):
220         Added to return the intersection of the viewport's visible rect with
221         the ContentsRect.
222         (WebCore::TiledBackingStore::createTiles):
223         Changed to take into account the ContentsSize when calculating the
224         previously visible rect.
225         * platform/graphics/TiledBackingStore.h:
226
227 2011-10-19  Jer Noble  <jer.noble@apple.com>
228
229         compositing/video tests time out on Lion
230         https://bugs.webkit.org/show_bug.cgi?id=70448
231
232         Reviewed by Eric Carlson.
233
234         Covered by existing tests.
235
236         AVFoundation will occasionally fill it's playback buffers before collecting enough
237         statistical information to answer YES to isLikelyToKeepUp.  In this situation, set the
238         ready state to HAVE_ENOUGH_DATA, on the presumption that if the playback buffers are
239         full, playback will probably not stall.
240
241         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
242         (WebCore::MediaPlayerPrivateAVFoundation::updateStates):
243
244 2011-10-19  Kentaro Hara  <haraken@chromium.org>
245
246         MessageEvent.data can be stored as ScriptValue.
247         https://bugs.webkit.org/show_bug.cgi?id=68978
248
249         Reviewed by Hajime Morita.
250
251         Currently, the following test cases fail or crash:
252
253         - shouldBe("new MessageEvent('eventType', { data: test_object }).data", "test_object") -> FAIL
254         - new MessageEvent('eventType', { data: document }).data -> CRASH
255
256         This is because MessageEvent.data is implemented just as SerializedScriptValue
257         and it cannot keep ScriptValue passed by JavaScript. This patch makes the following changes:
258
259         - If MessageEvent is constructed with ScriptValue, it is stored as ScriptValue internally.
260         When MessageEvent.data is called, the ScriptValue is returned.
261         - If MessageEvent is constructed with SerializedScriptValue, it is stored as
262         SerializedScriptValue internally (since we cannot deserialize it into ScriptValue
263         at this point because of lack of ExecState). When MessageEvent.data is called,
264         the SerializedScriptValue is deserialized into the corresponding ScriptValue,
265         and the ScriptValue is returned.
266
267         This patch does not make a fix for ObjC bindings code, since we need to first fix
268         the bug 28774, as commented in dom/MessageEvent.h and dom/MessageEvent.cpp.
269
270         Test: fast/events/constructors/message-event-constructor.html
271               fast/dom/message-port-deleted-by-accessor.html
272               fast/events/init-events.html
273               fast/eventsource/eventsource-attribute-listeners.html
274
275         * bindings/js/JSMessageEventCustom.cpp:
276         (WebCore::JSMessageEvent::data): Custom getter for MessageEvent.data. Supported ScriptValue.
277         (WebCore::JSMessageEvent::handleInitMessageEvent): Changed SerializedScriptValue to ScriptValue. Removed a 'doTransfer' parameter.
278         (WebCore::JSMessageEvent::initMessageEvent): Removed a 'doTransfer' parameter.
279         (WebCore::JSMessageEvent::webkitInitMessageEvent): Ditto.
280         * bindings/v8/custom/V8MessageEventCustom.cpp:
281         (WebCore::V8MessageEvent::dataAccessorGetter): Custom getter for MessageEvent.data. Supported ScriptValue.
282         (WebCore::V8MessageEvent::portsAccessorGetter): Removed extra spaces.
283         (WebCore::V8MessageEvent::initMessageEventCallback): Changed SerializedScriptValue to ScriptValue.
284         * dom/MessageEvent.cpp:
285         (WebCore::MessageEvent::MessageEvent): Supported ScriptValue.
286         (WebCore::MessageEvent::initMessageEvent): Supported ScriptValue.
287         (WebCore::MessageEvent::isMessageEvent): Removed extra spaces.
288         * dom/MessageEvent.h: Added DataType::DataTypeScriptValue.
289         (WebCore::MessageEvent::create): Supported ScriptValue.
290         (WebCore::MessageEvent::dataAsScriptValue): Getter for data. Insert ASSERT() to guarantee that this accessor is not called for unintended type of data.
291         (WebCore::MessageEvent::dataAsSerializedScriptValue): Ditto.
292         (WebCore::MessageEvent::dataAsString): Ditto.
293         (WebCore::MessageEvent::dataAsBlob): Ditto.
294         (WebCore::MessageEvent::dataAsArrayBuffer): Ditto.
295         * dom/MessageEvent.idl: Changed SerializedScriptValue to DOMObject (i.e. ScriptValue). This patch does not touch an ObjC part. Removed [CachedAttribute] from MessageEvent.data, since it is now a DOMObject and needs not to be cached.
296
297 2011-10-19  Adam Barth  <abarth@webkit.org>
298
299         Attempt to fix GTK build.
300
301         * GNUmakefile.am:
302
303 == Rolled over to ChangeLog-2011-10-19 ==