69ea28ef4eb82464ab93bb8df9a3d6287c67d272
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-04-05  Nikolas Zimmermann  <nzimmermann@rim.com>
2
3         Reviewed by Andreas Kling.
4
5         Switch from Vector<UChar> to StringBuilder in bindings/
6         https://bugs.webkit.org/show_bug.cgi?id=57838
7
8         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
9         (WebCore::cssPropertyName):
10         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
11         (WebCore::cssPropertyInfo):
12
13 2011-04-05  Nikolas Zimmermann  <nzimmermann@rim.com>
14
15         Reviewed by Andreas Kling.
16
17         Switch from Vector<UChar> to StringBuilder in accessibility/
18         https://bugs.webkit.org/show_bug.cgi?id=57837
19
20         * accessibility/AccessibilityObject.cpp:
21         (WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition):
22         (WebCore::AccessibilityObject::stringForVisiblePositionRange):
23         * accessibility/AccessibilityRenderObject.cpp:
24         (WebCore::AccessibilityRenderObject::accessibilityDescriptionForElements):
25
26 2011-04-05  Andrey Adaikin  <aandrey@google.com>
27
28         Reviewed by Pavel Feldman.
29
30         Web Inspector: Scripts with syntax errors are cropped in the UI
31         https://bugs.webkit.org/show_bug.cgi?id=57828
32
33         * inspector/front-end/SourceFrame.js:
34         (WebInspector.SourceFrame.prototype.addMessageToSource):
35
36 2011-04-05  Alexey Proskuryakov  <ap@apple.com>
37
38         Reviewed by Darin Adler.
39
40         Remove onformchange and onforminput events/event handlers
41         https://bugs.webkit.org/show_bug.cgi?id=55755
42         <rdar://problem/9087969>
43
44         Covered by existing tests.
45
46         * dom/Document.h:
47         * dom/Document.idl:
48         * dom/Element.h:
49         * dom/Element.idl:
50         * dom/Event.cpp:
51         (WebCore::Event::fromUserGesture):
52         * dom/EventNames.h:
53         * html/FormAssociatedElement.h:
54         * html/HTMLAttributeNames.in:
55         * html/HTMLElement.cpp:
56         (WebCore::HTMLElement::parseMappedAttribute):
57         * html/HTMLElement.h:
58         * html/HTMLFormControlElement.h:
59         (WebCore::HTMLFormControlElement::isEnumeratable):
60         * html/HTMLFormElement.cpp:
61         * html/HTMLFormElement.h:
62         * html/HTMLFormElement.idl:
63         * html/HTMLInputElement.h:
64         * html/HTMLKeygenElement.h:
65         * html/HTMLObjectElement.h:
66         (WebCore::HTMLObjectElement::isEnumeratable):
67         * html/HTMLOutputElement.h:
68         (WebCore::HTMLOutputElement::isEnumeratable):
69         * html/HTMLSelectElement.h:
70         (WebCore::HTMLSelectElement::isEnumeratable):
71         * html/HTMLTextAreaElement.h:
72         (WebCore::HTMLTextAreaElement::isEnumeratable):
73         * page/DOMWindow.h:
74         * page/DOMWindow.idl:
75
76 2011-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
77
78         Unreviewed, rolling out r82915.
79         http://trac.webkit.org/changeset/82915
80         https://bugs.webkit.org/show_bug.cgi?id=57825
81
82         Broke 270 chromium tests on win and linux (Requested by
83         podivilov on #webkit).
84
85         * rendering/RenderThemeChromiumSkia.cpp:
86         (WebCore::RenderThemeChromiumSkia::defaultGUIFont):
87
88 2011-04-05  James Simonsen  <simonjam@chromium.org>
89
90         Reviewed by Adam Barth.
91
92         Stop preload scanning CSS when it&apos;s impossible to have another @import.
93         https://bugs.webkit.org/show_bug.cgi?id=57664
94
95         @import statements are only allowed at the beginning of a CSS file.
96         Only comments or @charset can precede them. After seeing anything else,
97         abort early so that we:
98         - don't have to parse the rest of the CSS.
99         - don't preload something that the regular parser won't load.
100
101         * html/parser/CSSPreloadScanner.cpp:
102         (WebCore::CSSPreloadScanner::scan): Terminate early if we're done with @imports.
103         (WebCore::CSSPreloadScanner::tokenize): Terminate early if we see a {} or any style rule.
104         (WebCore::CSSPreloadScanner::emitRule): Only @charset or @import are allowed to precede @import.
105         * html/parser/CSSPreloadScanner.h: Add DoneParsingImportRules state.
106
107 2011-04-05  Takayoshi Kochi <kochi@chromium.org>
108
109         Reviewed by Tony Chang.
110
111         [chromium] Specify 'sans-serif' as a fallback to the default UI font
112         'Arial' for non-latin UI scripts (e.g. CJK).
113         https://bugs.webkit.org/show_bug.cgi?id=55035
114
115         No new tests, because it may still fail if the system is not configured
116         properly to resolve 'sans-serif' to existing real font file, thus even
117         manual test is hard to systematically tell it is working properly.
118
119         * rendering/RenderThemeChromiumSkia.cpp
120
121 2011-04-05  Kent Tamura  <tkent@chromium.org>
122
123         Reviewed by Dimitri Glazkov.
124
125         Setting defaultValue on a textarea with a modified value still clobbers the value
126         https://bugs.webkit.org/show_bug.cgi?id=57636
127
128         If the dirty flag is true, we shouldn't update the value when the
129         defaultValue is updated
130
131         Test: fast/forms/textarea-set-defaultvalue-after-value.html
132
133         * html/HTMLTextAreaElement.cpp:
134         (WebCore::HTMLTextAreaElement::childrenChanged):
135         (WebCore::HTMLTextAreaElement::setDefaultValue):
136
137 2011-04-04  Kent Tamura  <tkent@chromium.org>
138
139         Add a case label which was unexpectedly removed in r82899.
140         https://bugs.webkit.org/show_bug.cgi?id=50661
141
142         * css/CSSSelector.cpp:
143         (WebCore::CSSSelector::extractPseudoType):
144
145 2011-04-04  Dan Bernstein  <mitz@apple.com>
146
147         Reviewed by Simon Fraser.
148
149         <rdar://problem/7709452> Implement Default Ruby Overhang Behavior
150         https://bugs.webkit.org/show_bug.cgi?id=49334
151
152         Tests: fast/ruby/overhang-horizontal.html
153                fast/ruby/overhang-vertical.html
154
155         This is a first cut at ruby overhang. It allows ruby text to hang over other
156         text of equal or smaller size. Two notable omissions are that max preferred
157         width computation was not patched, so it will overshoot, and that overhang
158         ignores the width of the adjoining text runs.
159
160         * rendering/RenderBlock.h:
161         * rendering/RenderBlockLineLayout.cpp:
162         (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Adjust margins
163         of ruby runs for overhang.
164         (WebCore::RenderBlock::fitBelowFloats): Maintain the increase in line width to
165         compensate for overhang.
166         (WebCore::RenderBlock::findNextLineBreak): When encountering
167         a ruby run, increase the line width to account for the fact that overhang will be
168         collapsed.
169         * rendering/RenderRubyRun.cpp:
170         (WebCore::RenderRubyRun::getOverhang): Added. Allows ruby to overhang if
171         the adjoining renderer is text with equal or smaller font size.
172         * rendering/RenderRubyRun.h:
173         (WebCore::toRenderRubyRun):
174
175 2011-04-04  David Kilzer  <ddkilzer@apple.com>
176
177         <http://webkit.org/b/57384> CFNetwork and WebCore load priorities should match
178
179         Reviewed by Alexey Proskuryakov.
180
181         * WebCore.exp.in: Export wkSetHTTPPipeliningMaximumPriority().
182         * platform/mac/WebCoreSystemInterface.h:
183         (wkSetHTTPPipeliningMaximumPriority): Added function pointer
184         declaration.
185         * platform/mac/WebCoreSystemInterface.mm:
186         (wkSetHTTPPipeliningMaximumPriority): Added function pointer.
187         * platform/network/cf/ResourceRequestCFNet.cpp:
188         (WebCore::initializeMaximumHTTPConnectionCountPerHost): Call
189         wkSetHTTPPipeliningMaximumPriority() to set the maximum HTTP
190         pipelining priority.
191         * platform/network/cf/ResourceRequestCFNet.h:
192         (WebCore::toResourceLoadPriority): Renamed from
193         mapHTTPPipeliningPriorityToResourceLoadPriority().  Updated to
194         to handle Unresolved case.
195         (WebCore::toHTTPPipeliningPriority): Renamed from
196         mapResourceLoadPriorityToHTTPPipeliningPriority().  Updated to
197         handle Unresolved case.
198         * platform/network/mac/ResourceRequestMac.mm:
199         (WebCore::ResourceRequest::doUpdateResourceRequest): Switched to
200         use toResourceLoadPriority().
201         (WebCore::ResourceRequest::doUpdatePlatformRequest): Switched to
202         use toHTTPPipeliningPriority().  Moved
203         shouldForceHTTPPipeliningPriorityHigh() check into the argument
204         of toHTTPPipeliningPriority() instead of hard-coding a
205         now-incorrect value.
206
207 2011-04-04  MORITA Hajime  <morrita@google.com>
208
209         Reviewed by Kent Tamura.
210
211         Convert <meter> shadow DOM to a DOM-based shadow.
212         https://bugs.webkit.org/show_bug.cgi?id=50661
213         
214         Eliminated a large part of <meter> custom layout code,
215         which is replaced by a shadow tree.
216         Note that the shadow tree is created on construction time and
217         will remain during the host HTMLMeterElement lifecycle.
218         
219         * Android.mk:
220         * CMakeLists.txt:
221         * GNUmakefile.am:
222         * WebCore.gypi:
223         * WebCore.pro:
224         * WebCore.vcproj/WebCore.vcproj:
225         * WebCore.xcodeproj/project.pbxproj:
226         * css/CSSMutableStyleDeclaration.cpp:
227         (WebCore::CSSMutableStyleDeclaration::setProperty):
228         * css/CSSMutableStyleDeclaration.h:
229         * css/CSSSelector.cpp:
230         (WebCore::CSSSelector::pseudoId):
231         (WebCore::nameToPseudoTypeMap):
232         (WebCore::CSSSelector::extractPseudoType):
233         * css/CSSSelector.h:
234         * css/html.css:
235         (meter):
236         (meter::-webkit-meter-bar):
237         (meter::-webkit-meter-optimum-value):
238         (meter::-webkit-meter-suboptimum-value):
239         (meter::-webkit-meter-even-less-good-value):
240         * html/HTMLMeterElement.cpp:
241         (WebCore::HTMLMeterElement::~HTMLMeterElement):
242         (WebCore::HTMLMeterElement::parseMappedAttribute):
243         (WebCore::HTMLMeterElement::attach):
244         (WebCore::HTMLMeterElement::valueRatio):
245         (WebCore::HTMLMeterElement::didElementStateChange):
246         (WebCore::HTMLMeterElement::createShadowSubtree):
247         * html/HTMLMeterElement.h:
248         * html/shadow/MeterShadowElement.cpp: Added.
249         (WebCore::MeterShadowElement::MeterShadowElement):        
250         (WebCore::MeterShadowElement::meterElement):
251         (WebCore::MeterShadowElement::rendererIsNeeded):
252         (WebCore::MeterBarElement::shadowPseudoId):
253         (WebCore::MeterValueElement::shadowPseudoId):
254         (WebCore::MeterValueElement::setWidthPercentage):
255         * html/shadow/MeterShadowElement.h: Added.
256         (WebCore::MeterBarElement::MeterBarElement):
257         (WebCore::MeterBarElement::create):
258         (WebCore::MeterValueElement::MeterValueElement):
259         (WebCore::MeterValueElement::create):
260         * rendering/RenderMeter.cpp:
261         (WebCore::RenderMeter::RenderMeter):
262         (WebCore::RenderMeter::~RenderMeter):
263         (WebCore::RenderMeter::valueRatio):
264         * rendering/RenderMeter.h:
265         (WebCore::RenderMeter::renderName):
266         (WebCore::RenderMeter::isMeter):
267         (WebCore::RenderMeter::requiresForcedStyleRecalcPropagation):
268         (WebCore::RenderMeter::canHaveChildren):
269
270 2011-04-04  Dimitri Glazkov  <dglazkov@chromium.org>
271
272         Reviewed by Adam Barth.
273
274         Introduce EventDispatchMediator abstraction, which encapsulate all
275         non-trivial logic around firing a specific type of an event.
276         https://bugs.webkit.org/show_bug.cgi?id=57562
277
278         Refactoring, covered by existing tests.
279
280         * dom/Event.cpp:
281         (WebCore::EventDispatchMediator::EventDispatchMediator): Added.
282         (WebCore::EventDispatchMediator::~EventDispatchMediator): Added.
283         (WebCore::EventDispatchMediator::dispatchEvent): Added.
284         (WebCore::EventDispatchMediator::event): Added.
285         * dom/Event.h: Added decl.
286         * dom/EventDispatcher.cpp:
287         (WebCore::EventDispatcher::dispatchEvent): Changed to use EventDispatchMediator.
288         * dom/EventDispatcher.h: Updated decls.
289         * dom/KeyboardEvent.cpp:
290         (WebCore::KeyboardEventDispatchMediator::KeyboardEventDispatchMediator): Added.
291         (WebCore::KeyboardEventDispatchMediator::dispatchEvent): Added.
292         * dom/KeyboardEvent.h: Updated decls
293         * dom/Node.cpp:
294         (WebCore::Node::dispatchEvent): Changed to use EventDispatchMediator.
295         (WebCore::Node::dispatchKeyEvent): Changed to use KeyboardEventDispatchMediator.
296
297 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
298
299         Reviewed by Xan Lopez.
300
301         [Cairo] Memory leak in RefPtrCairo
302         https://bugs.webkit.org/show_bug.cgi?id=57758
303
304         No new tests. This just fixes a memory leak.
305
306         * platform/graphics/cairo/RefPtrCairo.cpp:
307         (WTF::derefIfNotNull): Deref should unref the cairo_font_fact_t, not reference it.
308
309 2011-04-04  Adrienne Walker  <enne@google.com>
310
311         Unreviewed, rolling out r82880.
312         http://trac.webkit.org/changeset/82880
313         https://bugs.webkit.org/show_bug.cgi?id=50661
314
315         Meter elements not rendered in Chromium Linux layout tests
316
317         * Android.mk:
318         * CMakeLists.txt:
319         * GNUmakefile.am:
320         * WebCore.gypi:
321         * WebCore.pro:
322         * WebCore.vcproj/WebCore.vcproj:
323         * WebCore.xcodeproj/project.pbxproj:
324         * css/CSSMutableStyleDeclaration.cpp:
325         * css/CSSMutableStyleDeclaration.h:
326         * css/CSSSelector.cpp:
327         (WebCore::CSSSelector::pseudoId):
328         (WebCore::nameToPseudoTypeMap):
329         (WebCore::CSSSelector::extractPseudoType):
330         * css/CSSSelector.h:
331         * css/html.css:
332         (meter):
333         (meter::-webkit-meter):
334         (meter::-webkit-meter-bar):
335         (meter::-webkit-meter-optimum-value):
336         (meter::-webkit-meter-suboptimal-value):
337         (meter::-webkit-meter-even-less-good-value):
338         * html/HTMLMeterElement.cpp:
339         (WebCore::HTMLMeterElement::create):
340         (WebCore::HTMLMeterElement::parseMappedAttribute):
341         (WebCore::HTMLMeterElement::attach):
342         * html/HTMLMeterElement.h:
343         * html/shadow/MeterShadowElement.cpp: Removed.
344         * html/shadow/MeterShadowElement.h: Removed.
345         * rendering/RenderMeter.cpp:
346         (WebCore::RenderMeter::RenderMeter):
347         (WebCore::RenderMeter::~RenderMeter):
348         (WebCore::RenderMeter::createPart):
349         (WebCore::RenderMeter::updateFromElement):
350         (WebCore::RenderMeter::layoutParts):
351         (WebCore::RenderMeter::styleDidChange):
352         (WebCore::RenderMeter::shouldHaveParts):
353         (WebCore::RenderMeter::valueRatio):
354         (WebCore::RenderMeter::barPartRect):
355         (WebCore::RenderMeter::valuePartRect):
356         (WebCore::RenderMeter::valuePseudoId):
357         (WebCore::RenderMeter::barPseudoId):
358         (WebCore::RenderMeter::detachShadows):
359         (WebCore::RenderMeter::updateShadows):
360         * rendering/RenderMeter.h:
361         (WebCore::RenderMeter::renderName):
362         (WebCore::RenderMeter::isMeter):
363         (WebCore::RenderMeter::shadowAttached):
364
365 2011-04-04  Chang Shu  <cshu@webkit.org>
366
367         Reviewed by Ryosuke Niwa.
368
369         setContentEditable with true/false/inherit string is not working properly
370         https://bugs.webkit.org/show_bug.cgi?id=52058
371
372         Move isContentEditable from HTMLElement to Node. Thus, Node provides two functions for
373         checking editability: rendererIsEditable and isContentEdiable. The former is a fast path,
374         which does NOT trigger layout and only checks the render style of usermodify. The latter
375         updates the layout first to make sure the render style syncs with DOM contenteditable 
376         attribute. Certain call sites that need to call isContentEditable rather than rendererIsEditable
377         are also updated in the patch. But a complete fix will follow up in bug 57244.
378
379         This patch fixes all the failed layout tests related to set contenteditable.
380
381         * accessibility/AccessibilityRenderObject.cpp:
382         (WebCore::AccessibilityRenderObject::isReadOnly):
383         * dom/Node.cpp:
384         (WebCore::Node::isContentEditable):
385         (WebCore::Node::shouldUseInputMethod):
386         * dom/Node.h:
387         * html/HTMLElement.cpp:
388         * html/HTMLElement.h:
389
390 2011-04-04  Roland Steiner  <rolandsteiner@chromium.org>
391
392         Reviewed by Dimitri Glazkov.
393
394         Bug 57689 - Extract scoping functionality from Document
395         https://bugs.webkit.org/show_bug.cgi?id=57689
396
397         Moved selfOnlyRef (renamed to guardRef), element ID, image map
398         and accesss key functionalities from Document to a new base
399         class TreeScope.
400
401         TreeShared: made removedLastRef protected
402
403         No new tests. (refactoring)
404
405         * Android.mk:
406         * CMakeLists.txt:
407         * GNUmakefile.am:
408         * WebCore.gypi:
409         * WebCore.pro:
410         * WebCore.vcproj/WebCore.vcproj:
411         * WebCore.xcodeproj/project.pbxproj:
412         * dom/Document.cpp:
413         (WebCore::Document::Document):
414         (WebCore::Document::destroyScope):
415         (WebCore::Document::getElementById):
416         (WebCore::Document::childrenChanged):
417         (WebCore::Document::scheduleStyleRecalc):
418         (WebCore::Document::attach):
419         (WebCore::Document::detach):
420         * dom/Document.h:
421         (WebCore::Node::Node):
422         * dom/DocumentOrderedMap.cpp:
423         (WebCore::DocumentOrderedMap::get):
424         (WebCore::DocumentOrderedMap::getElementById):
425         (WebCore::DocumentOrderedMap::getElementByMapName):
426         (WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
427         * dom/DocumentOrderedMap.h:
428         * dom/DOMAllInOne.cpp:
429         * dom/Node.cpp:
430         (WebCore::Node::~Node):
431         (WebCore::Node::setDocument):
432         * dom/Node.h:
433         * dom/TreeScope.cpp: Added.
434         * dom/TreeScope.h: Added.
435         * platform/TreeShared.h:
436         (WebCore::TreeShared::removedLastRef): made protected
437
438 2011-04-04  MORITA Hajime  <morrita@google.com>
439
440         Reviewed by Dimitri Glazkov.
441
442         Convert <meter> shadow DOM to a DOM-based shadow.
443         https://bugs.webkit.org/show_bug.cgi?id=50661
444         
445         Eliminated a large part of <meter> custom layout code,
446         which is replaced by a shadow tree.
447         Note that the shadow tree is created on construction time and
448         will remain during the host HTMLMeterElement lifecycle.
449         
450         * Android.mk:
451         * CMakeLists.txt:
452         * GNUmakefile.am:
453         * WebCore.gypi:
454         * WebCore.pro:
455         * WebCore.vcproj/WebCore.vcproj:
456         * WebCore.xcodeproj/project.pbxproj:
457         * css/CSSMutableStyleDeclaration.cpp:
458         (WebCore::CSSMutableStyleDeclaration::setProperty):
459         * css/CSSMutableStyleDeclaration.h:
460         * css/CSSSelector.cpp:
461         (WebCore::CSSSelector::pseudoId):
462         (WebCore::nameToPseudoTypeMap):
463         (WebCore::CSSSelector::extractPseudoType):
464         * css/CSSSelector.h:
465         * css/html.css:
466         (meter):
467         (meter::-webkit-meter-bar):
468         (meter::-webkit-meter-optimum-value):
469         (meter::-webkit-meter-suboptimum-value):
470         (meter::-webkit-meter-even-less-good-value):
471         * html/HTMLMeterElement.cpp:
472         (WebCore::HTMLMeterElement::~HTMLMeterElement):
473         (WebCore::HTMLMeterElement::parseMappedAttribute):
474         (WebCore::HTMLMeterElement::attach):
475         (WebCore::HTMLMeterElement::valueRatio):
476         (WebCore::HTMLMeterElement::didElementStateChange):
477         (WebCore::HTMLMeterElement::createShadowSubtree):
478         * html/HTMLMeterElement.h:
479         * html/shadow/MeterShadowElement.cpp: Added.
480         (WebCore::MeterShadowElement::MeterShadowElement):        
481         (WebCore::MeterShadowElement::meterElement):
482         (WebCore::MeterShadowElement::rendererIsNeeded):
483         (WebCore::MeterBarElement::shadowPseudoId):
484         (WebCore::MeterValueElement::shadowPseudoId):
485         (WebCore::MeterValueElement::setWidthPercentage):
486         * html/shadow/MeterShadowElement.h: Added.
487         (WebCore::MeterBarElement::MeterBarElement):
488         (WebCore::MeterBarElement::create):
489         (WebCore::MeterValueElement::MeterValueElement):
490         (WebCore::MeterValueElement::create):
491         * rendering/RenderMeter.cpp:
492         (WebCore::RenderMeter::RenderMeter):
493         (WebCore::RenderMeter::~RenderMeter):
494         (WebCore::RenderMeter::valueRatio):
495         * rendering/RenderMeter.h:
496         (WebCore::RenderMeter::renderName):
497         (WebCore::RenderMeter::isMeter):
498         (WebCore::RenderMeter::requiresForcedStyleRecalcPropagation):
499         (WebCore::RenderMeter::canHaveChildren):
500
501 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
502
503         Reviewed by Gustavo Noronha Silva.
504
505         [GTK] WebGL support
506         https://bugs.webkit.org/show_bug.cgi?id=31517
507
508         Add WebGL support for the GTK+ bits of WebCore.
509
510         No new tests. This will be covered by the existing WebGL tests once
511         the bots are capable of running WebGL tests.
512
513         * GNUmakefile.am: Added new files required for WebGL support.
514         * html/HTMLCanvasElement.cpp:
515         (WebCore::HTMLCanvasElement::getContext): Extend #ifdef to cover GTK+ as well, which does not
516         yet support accelerated compositing.
517         * platform/graphics/ANGLEWebKitBridge.h: Update to reflect the fact that ANGLE isn't compiled as
518         a framework for GTK+.
519         * platform/graphics/GraphicsContext3D.h:
520         (WebCore::GraphicsContext3D::platformTexture): Added a declaration of this method for Cairo.
521         (WebCore::GraphicsContext3D::paintsIntoCanvasBuffer): Ditto.
522         * platform/graphics/cairo/GraphicsContext3DCairo.cpp: Added.
523         (WebCore::GraphicsContext3D::getImageData): Added.
524         (WebCore::GraphicsContext3D::paintToCanvas): Added.
525         * platform/graphics/cairo/OpenGLShims.cpp: Added. This file controls loading of GL extension
526         functions dynamically. They have different names across the different vendors' GL implementations.
527         (WebCore::lookupOpenGLFunctionAddress): Added
528         (WebCore::openGLFunctionTable): Added
529         (WebCore::initializeOpenGLShims): Added
530         * platform/graphics/cairo/OpenGLShims.h: Added.
531         * platform/graphics/gtk/DrawingBufferGtk.cpp: Added.
532         (WebCore::DrawingBuffer::DrawingBuffer): Very generic implementation for Cairo.
533         (WebCore::DrawingBuffer::~DrawingBuffer): Ditto.
534         (WebCore::DrawingBuffer::didReset): Ditto.
535         (WebCore::DrawingBuffer::platformColorBuffer): Ditto.
536         * platform/graphics/gtk/GraphicsContext3DGtk.cpp: Added.
537         (WebCore::GraphicsContext3D::create): Initial implementation.
538         (WebCore::GraphicsContext3D::GraphicsContext3D): Ditto.
539         (WebCore::GraphicsContext3D::~GraphicsContext3D): Ditto.
540         (WebCore::GraphicsContext3D::makeContextCurrent): Ditto.
541         (WebCore::GraphicsContext3D::platformGraphicsContext3D): Ditto.
542         (WebCore::GraphicsContext3D::isGLES2Compliant): Ditto.
543         * platform/graphics/gtk/GraphicsContext3DInternal.cpp: Added.
544         (sharedDisplay): Added this shared display which is required by some
545         display drivers.
546         (WebCore::activeGraphicsContexts): This method keeps track of all active GraphicsContext3D
547         contexts, in order to clean them up at exit. This prevents crashes on certain OpenGL drivers.
548         (WebCore::GraphicsContext3DInternal::addActiveGraphicsContext): Ditto.
549         (WebCore::GraphicsContext3DInternal::removeActiveGraphicsContext): Ditto.
550         (WebCore::GraphicsContext3DInternal::cleanupActiveContextsAtExit): Ditto.
551         (WebCore::GraphicsContext3DInternal::create): Figure out the best way to create an OpenGL
552         context given the current environment.
553         (WebCore::GraphicsContext3DInternal::createPbufferContext): Pbuffer context initializer.
554         (WebCore::GraphicsContext3DInternal::createPixmapContext): Pixmap context initializer.
555         (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): Initial implementation.
556         (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): Ditto.
557         (WebCore::GraphicsContext3DInternal::makeContextCurrent): Ditto.
558         * platform/graphics/gtk/GraphicsContext3DInternal.h: Added.
559         * platform/graphics/opengl/Extensions3DOpenGL.cpp: Added generic implementation.
560         (WebCore::Extensions3DOpenGL::ensureEnabled): Ditto.
561         * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
562         (WebCore::GraphicsContext3D::reshape): Test for the context using the public API rather than
563         the private bits that are specific to the Apple port.
564
565 2011-04-04  Alexey Proskuryakov  <ap@apple.com>
566
567         Reviewed by Dan Bernstein.
568
569         REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
570         https://bugs.webkit.org/show_bug.cgi?id=51230
571         <rdar://problem/8780989>
572
573         <rdar://problem/9015250> REGRESSION (WebKit2): Key events not fired for modifier keys
574
575         * page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Moved Caps Lock handling from
576         WebKits to WebCore, because WebKit shouldn't be smart.
577
578 2011-04-04  Steve Falkenburg  <sfalken@apple.com>
579
580         Fix Windows build warning.
581
582         * WebCore.vcproj/WebCore.vcproj: Exclude EventQueue.cpp in Debug_All build.
583
584 2011-04-04  Adam Roben  <aroben@apple.com>
585
586         Attempted Mac build fix, part III
587
588         * WebCore.exp.in: Export PlatformCALayer::setGeometryFlipped. Also resorted some symbols.
589
590 2011-04-04  Andy Estes  <aestes@apple.com>
591
592         Fix the Mac build.
593
594         * WebCore.exp.in:
595
596 2011-04-04  David Dorwin  <ddorwin@chromium.org>
597
598         Reviewed by David Levin.
599
600         Chromium Mac crashes when entering fullscreen
601         https://bugs.webkit.org/show_bug.cgi?id=57483
602
603         Override extraFullScreenStyleSheet in RenderThemeChromiumMac to avoid hitting the ASSERT_NOT_REACHED in RenderThemeMac.
604
605         * WebCore.gyp/WebCore.gyp:
606         * rendering/RenderThemeChromiumMac.h:
607         * rendering/RenderThemeChromiumMac.mm:
608         (WebCore::RenderThemeChromiumMac::extraFullScreenStyleSheet):
609
610 2011-04-04  Adam Roben  <aroben@apple.com>
611
612         Attempted Mac build fix, part II
613
614         * WebCore.xcodeproj/project.pbxproj: Marked PlatformCALayerClient.h and
615         PlatformCAAnimation.h as private so that WebKit2 can #include them (transitively).
616
617 2011-04-04  Steve Falkenburg  <sfalken@apple.com>
618
619         Reviewed by Adam Roben.
620
621         Remove unused AnalyzeWithLargeStack code from Windows build files
622         https://bugs.webkit.org/show_bug.cgi?id=57771
623         
624         This was used for us to build with prefast automatically,
625         but it is out-of-date and hasn't been used for some time.
626         Removing completely for now.
627
628         * WebCore.vcproj/WebCore.vcproj:
629         * WebCore.vcproj/WebCorePreBuild.cmd:
630
631 2011-04-01  Matthew Delaney  <mdelaney@apple.com>
632
633         Reviewed by Simon Fraser.
634
635         [CG] Do not accelerate small canvases
636         https://bugs.webkit.org/show_bug.cgi?id=57596
637
638         No new tests. No outward behavior changes.
639
640         * platform/graphics/cg/ImageBufferCG.cpp:
641
642 2011-04-04  Adam Roben  <aroben@apple.com>
643
644         Attempted Mac build fix
645
646         * WebCore.xcodeproj/project.pbxproj: Marked PlatformCALayer.h and GraphicsLayerCA.h private
647         so that WebKit can #include them.
648
649 2011-04-04  Malcolm MacLeod  <mmacleod@webmail.co.za>
650
651         Reviewed by Kevin Ollivier.
652
653         [wx] Implement support for temporary files.
654         
655         https://bugs.webkit.org/show_bug.cgi?id=57772
656
657         * platform/FileSystem.h:
658         * platform/wx/FileSystemWx.cpp:
659         (WebCore::getFileModificationTime):
660         (WebCore::openTemporaryFile):
661         (WebCore::closeFile):
662         (WebCore::writeToFile):
663
664 2011-04-01  Oliver Hunt  <oliver@apple.com>
665
666         Reviewed by Geoffrey Garen.
667
668         Make StructureChain GC allocated
669         https://bugs.webkit.org/show_bug.cgi?id=56695
670
671         Update for new Structure marking function
672
673         * bindings/js/JSDOMGlobalObject.cpp:
674         (WebCore::JSDOMGlobalObject::markChildren):
675
676 2011-04-04  Pavel Feldman  <pfeldman@google.com>
677
678         Reviewed by Yury Semikhatsky.
679
680         Web Inspector: add support for the enumerated types in the protocol.
681         https://bugs.webkit.org/show_bug.cgi?id=57761
682
683         * inspector/Inspector.json:
684         * inspector/InspectorDebuggerAgent.cpp:
685         (WebCore::InspectorDebuggerAgent::setPauseOnExceptions):
686         * inspector/InspectorDebuggerAgent.h:
687         * inspector/InspectorInstrumentation.cpp:
688         (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
689         (WebCore::InspectorInstrumentation::scriptImportedImpl):
690         * inspector/InspectorResourceAgent.cpp:
691         (WebCore::cachedResourceTypeString):
692         (WebCore::InspectorResourceAgent::didReceiveResponse):
693         (WebCore::InspectorResourceAgent::setInitialScriptContent):
694         (WebCore::InspectorResourceAgent::setInitialXHRContent):
695         * inspector/InspectorResourceAgent.h:
696         * inspector/front-end/ScriptsPanel.js:
697         * inspector/generate-inspector-idl:
698
699 2011-04-04  Yury Semikhatsky  <yurys@chromium.org>
700
701         Reviewed by Pavel Feldman.
702
703         Web Inspector: InspectorRuntimeAgent should not depend on Page
704         https://bugs.webkit.org/show_bug.cgi?id=57759
705
706         Descendants of InspectorRuntimeAgent should implement a method providing access to the default
707         inspected state used for console evaluations.
708
709         * inspector/InspectorAgent.cpp:
710         (WebCore::InspectorAgent::InspectorAgent): runtime agent is created and deleted along with other agents.
711         (WebCore::InspectorAgent::setFrontend):
712         * inspector/InspectorAgent.h:
713         * inspector/InspectorRuntimeAgent.cpp:
714         (WebCore::InspectorRuntimeAgent::create):
715         (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
716         (WebCore::InspectorRuntimeAgent::evaluate):
717         * inspector/InspectorRuntimeAgent.h:
718         (WebCore::InspectorRuntimeAgent::InspectedStateProvider::~InspectedStateProvider):
719
720 2011-04-04  Yong Li  <yoli@rim.com>
721
722         Reviewed by Antonio Gomes.
723
724         https://bugs.webkit.org/show_bug.cgi?id=55969
725         Fix the issue that document state is not saved when
726         going backward and ending up with error page.
727
728         Test: platform/qt/fast/history/back-to-unreachable-url-then-forward.html
729
730         (For manual test, load a non-existent html first, then load
731         fast/history/resources/check-scroll-position.html, then go
732         back and go forward. If it doesn't show "SUCCESS" at the bottom
733         of the page, your browser has failed the test)
734
735         * loader/FrameLoader.cpp:
736         (WebCore::FrameLoader::load):
737
738 2011-04-04  Sergio Villar Senin  <svillar@igalia.com>
739
740         Reviewed by Martin Robinson.
741
742         [GTK] Fix make distcheck for 1.4.0
743         https://bugs.webkit.org/show_bug.cgi?id=57750
744
745         Added a missing header file to the Makefile
746
747         * GNUmakefile.am:
748
749 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
750
751         Reviewed by Xan Lopez.
752
753         [GTK] http/tests/plugins/post-url-file.html fails on GTK+
754         https://bugs.webkit.org/show_bug.cgi?id=55826
755
756         Correct the implementation of handlePostReadFile which uses GIO APIs and
757         actually resizes the buffer to fit the entire size of the file data. This
758         was likely leading to memory corruption until now.
759
760         * plugins/gtk/PluginViewGtk.cpp:
761         (WebCore::PluginView::handlePostReadFile): Fix this method.
762
763 2011-04-04  Andrey Kosyakov  <caseq@chromium.org>
764
765         Reviewed by Yury Semikhatsky.
766
767         Web Inspector: [Extensions API] add notifications on panels shown/hidden
768         https://bugs.webkit.org/show_bug.cgi?id=57752
769
770         * inspector/front-end/ExtensionAPI.js:
771         (WebInspector.injectedExtensionAPI.PanelImpl):
772         * inspector/front-end/ExtensionServer.js:
773         (WebInspector.ExtensionServer.prototype.notifyPanelShown):
774         (WebInspector.ExtensionServer.prototype.notifyPanelHidden):
775         * inspector/front-end/Panel.js:
776         (WebInspector.Panel.prototype.show):
777         (WebInspector.Panel.prototype.hide):
778
779 2011-04-04  Pavel Podivilov  <podivilov@chromium.org>
780
781         Reviewed by Yury Semikhatsky.
782
783         Web Inspector: search in resources panel is broken.
784         https://bugs.webkit.org/show_bug.cgi?id=57631
785
786         Search in resources panel should trigger source frame content load.
787
788         * inspector/front-end/Panel.js:
789         (WebInspector.Panel.prototype.jumpToNextSearchResult):
790         (WebInspector.Panel.prototype.jumpToPreviousSearchResult):
791         * inspector/front-end/ResourcesPanel.js:
792         * inspector/front-end/SearchController.js:
793         (WebInspector.SearchController.prototype.handleShortcut):
794         (WebInspector.SearchController.prototype.focusSearchField):
795         * inspector/front-end/SourceFrame.js:
796         (WebInspector.SourceFrame.prototype.show):
797         (WebInspector.SourceFrame.prototype._ensureContentLoaded):
798         (WebInspector.SourceFrame.prototype.performSearch):
799
800 2011-04-03  Eric Seidel  <eric@webkit.org>
801
802         Reviewed by Ryosuke Niwa.
803
804         Split out UnicodeBidi enum into its own header (to allow use in platform)
805         https://bugs.webkit.org/show_bug.cgi?id=57722
806
807         unicode-bidi is a CSS concept.  However the same concept is really needed throughout
808         the bidi code in platform as well.  So I'm moving the enum to platform.
809         The only part of the enum which doesn't make much sense to platform/ is "normal".
810
811         * WebCore.xcodeproj/project.pbxproj:
812         * css/CSSPrimitiveValueMappings.h:
813         * platform/text/UnicodeBidi.h: Added.
814         * rendering/style/RenderStyle.h:
815         * rendering/style/RenderStyleConstants.h:
816
817 2011-04-04  Andrey Adaikin  <aandrey@google.com>
818
819         Reviewed by Yury Semikhatsky.
820
821         Web Inspector: Highlighted search tokens would not be shown on long lines in the text viewer
822         https://bugs.webkit.org/show_bug.cgi?id=57749
823
824         * inspector/front-end/TextViewer.js:
825         (WebInspector.TextEditorMainPanel.prototype.markAndRevealRange):
826         (WebInspector.TextEditorMainPanel.prototype._paintLine):
827
828 2011-04-04  Alexander Pavlov  <apavlov@chromium.org>
829
830         Reviewed by Yury Semikhatsky.
831
832         Web Inspector: Incorrectly reports warning on missing/incorrect content-type for 304s
833         https://bugs.webkit.org/show_bug.cgi?id=48525
834
835         * inspector/front-end/Resource.js:
836         (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
837
838 2011-04-01  Alexander Pavlov  <apavlov@chromium.org>
839
840         Reviewed by Yury Semikhatsky.
841
842         Web Inspector: appropriateSelectorForNode() invokes the "localName" getter on DOMNode rather than function
843         https://bugs.webkit.org/show_bug.cgi?id=57632
844
845         Moved the affected method onto the DOMNode.prototype as "appropriateSelectorFor".
846
847         * inspector/front-end/DOMAgent.js:
848         (WebInspector.DOMNode.prototype.appropriateSelectorFor):
849         * inspector/front-end/EventListenersSidebarPane.js:
850         ():
851         * inspector/front-end/StylesSidebarPane.js:
852         (WebInspector.StylesSidebarPane.prototype.addBlankSection):
853         * inspector/front-end/utilities.js:
854
855 2011-04-04  Andrey Kosyakov  <caseq@chromium.org>
856
857         Unreviewed. Followup to an incomplete commit in r82806.
858
859         * inspector/front-end/ExtensionAPI.js:
860         (WebInspector.injectedExtensionAPI.PanelWithSidebarImpl.prototype.createSidebarPane):
861         (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl):
862         (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setHeight):
863         (WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpression):
864         (WebInspector.injectedExtensionAPI):
865         * inspector/front-end/ExtensionPanel.js:
866         (WebInspector.ExtensionSidebarPane):
867         (WebInspector.ExtensionSidebarPane.prototype.setPage):
868         (WebInspector.ExtensionSidebarPane.prototype._setObject):
869         * inspector/front-end/ExtensionServer.js:
870         (WebInspector.ExtensionServer):
871         (WebInspector.ExtensionServer.prototype.notifyExtensionSidebarUpdated):
872         (WebInspector.ExtensionServer.prototype._onCreatePanel):
873         (WebInspector.ExtensionServer.prototype._onCreateSidebarPane):
874         (WebInspector.ExtensionServer.prototype.createClientIframe):
875         (WebInspector.ExtensionServer.prototype._onSetSidebarContent):
876
877 2011-04-04  Yury Semikhatsky  <yurys@chromium.org>
878
879         Unreviewed. Fix Qt minimal build.
880
881         * inspector/InspectorFrontendChannel.h:
882
883 2011-04-01  Sergey Vorobyev  <sergeyvorobyev@google.com>
884
885         Reviewed by Yury Semikhatsky.
886
887         Web Inspector: Separate sendMessageToFrontend function
888         from InspectorClient to individual interface.
889         https://bugs.webkit.org/show_bug.cgi?id=57548
890
891         Refactoring - covered with existing inspector tests.
892
893         * GNUmakefile.am:
894         * WebCore.gypi:
895         * WebCore.vcproj/WebCore.vcproj:
896         * WebCore.xcodeproj/project.pbxproj:
897         * inspector/CodeGeneratorInspector.pm:
898         * inspector/InspectorClient.h:
899         * inspector/InspectorFrontendChannel.h: Added.
900         (WebCore::InspectorFrontendChannel::~InspectorFrontendChannel):
901
902 2011-04-04  Nico Weber  <thakis@chromium.org>
903
904         Reviewed by Eric Seidel.
905
906         Prefer a using directive over qualified names in LocalizedNumberICU.cpp
907         https://bugs.webkit.org/show_bug.cgi?id=57742
908
909         Requested by ap in https://bugs.webkit.org/show_bug.cgi?id=57715
910
911         * platform/text/LocalizedNumberICU.cpp:
912         (WebCore::createFormatterForCurrentLocale):
913         (WebCore::numberFormatter):
914         (WebCore::parseLocalizedNumber):
915         (WebCore::formatLocalizedNumber):
916
917 2011-04-04  Andrey Adaikin  <aandrey@google.com>
918
919         Reviewed by Yury Semikhatsky.
920
921         Web Inspector: Breakpoints in the gutter stay static while editing the text
922         https://bugs.webkit.org/show_bug.cgi?id=57616
923
924         * inspector/front-end/SourceFrame.js:
925         (WebInspector.SourceFrame):
926         (WebInspector.SourceFrame.prototype._saveViewerState):
927         (WebInspector.SourceFrame.prototype._restoreViewerState):
928         (WebInspector.SourceFrame.prototype._endEditing):
929         (WebInspector.SourceFrame.prototype._lineNumberAfterEditing):
930         (WebInspector.SourceFrame.prototype.addBreakpoint):
931         (WebInspector.SourceFrame.prototype.removeBreakpoint):
932         * inspector/front-end/TextViewer.js:
933         (WebInspector.TextViewer.prototype._syncDecorationsForLine):
934         (WebInspector):
935         (WebInspector.TextEditorChunkedPanel.prototype.removeDecoration):
936         (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
937         (WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine):
938         (WebInspector.TextEditorMainPanel.prototype._splitChunkOnALine):
939
940 2011-04-04  Ilya Tikhonovsky  <loislo@chromium.org>
941
942         Reviewed by Yury Semikhatsky.
943
944         Web Inspector: remove obsolete doc generating code from CodeGenerator.
945         https://bugs.webkit.org/show_bug.cgi?id=57748
946
947         * inspector/CodeGeneratorInspector.pm:
948
949 2011-04-04  Andrey Kosyakov  <caseq@chromium.org>
950
951         Reviewed by Yury Semikhatsky.
952
953         Web Inspector: [Extensions API] Merge WatchExpressionSidebarPane into ExtensionSidebarPane
954         https://bugs.webkit.org/show_bug.cgi?id=57622
955
956         Merged WatchExpressionSidebarPane into ExtensionSidebarPane, added setPage(url).
957         Fixed wrong getter in schema (scripts -> elements)
958
959         * inspector/front-end/ExtensionAPI.js:
960         (WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl.prototype.setObject):
961         (WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl.prototype.setPage):
962         * inspector/front-end/ExtensionAPISchema.json:
963         * inspector/front-end/ExtensionServer.js:
964         (WebInspector.ExtensionServer.prototype._onSetSidebarPage):
965
966 2011-04-04  Ilya Tikhonovsky  <loislo@chromium.org>
967
968         Reviewed by Pavel Feldman.
969
970         Web Inspector: introduce support of 'optional' flag for command arguments.
971         https://bugs.webkit.org/show_bug.cgi?id=57698
972
973         * inspector/CodeGeneratorInspector.pm:
974         * inspector/Inspector.json:
975         * inspector/InspectorDebuggerAgent.cpp:
976         (WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
977         (WebCore::InspectorDebuggerAgent::setBreakpoint):
978         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
979         * inspector/InspectorDebuggerAgent.h:
980         * inspector/InspectorPageAgent.cpp:
981         (WebCore::InspectorPageAgent::reloadPage):
982         * inspector/InspectorPageAgent.h:
983         * inspector/InspectorResourceAgent.cpp:
984         (WebCore::InspectorResourceAgent::getResourceContent):
985         * inspector/InspectorResourceAgent.h:
986         * inspector/InspectorRuntimeAgent.cpp:
987         (WebCore::InspectorRuntimeAgent::evaluate):
988         * inspector/InspectorRuntimeAgent.h:
989         * inspector/generate-inspector-idl:
990
991 2011-04-04  Yury Semikhatsky  <yurys@chromium.org>
992
993         Reviewed by Pavel Feldman.
994
995         Web Inspector: InjectedScriptManager should not try to access inspected window in case of workers
996         https://bugs.webkit.org/show_bug.cgi?id=57637
997
998         * bindings/js/JSInjectedScriptManager.cpp:
999         (WebCore::InjectedScriptManager::injectedScriptFor):
1000         * bindings/v8/custom/V8InjectedScriptManager.cpp:
1001         (WebCore::InjectedScriptManager::injectedScriptFor):
1002         * inspector/InjectedScript.cpp:
1003         (WebCore::InjectedScript::InjectedScript):
1004         (WebCore::InjectedScript::canAccessInspectedWindow):
1005         * inspector/InjectedScript.h:
1006         * inspector/InjectedScriptManager.cpp:
1007         (WebCore::InjectedScriptManager::createForPage):
1008         (WebCore::InjectedScriptManager::createForWorker):
1009         (WebCore::InjectedScriptManager::InjectedScriptManager): access check function is passed as a parameter to the constructor
1010         and it depends on which type of context we're inspecting(worker or page).
1011         (WebCore::InjectedScriptManager::canAccessInspectedWorkerContext):
1012         * inspector/InjectedScriptManager.h:
1013         * inspector/InspectorController.cpp:
1014         (WebCore::InspectorController::InspectorController):
1015
1016 2011-04-04  Ryuan Choi  <ryuan.choi@samsung.com>
1017
1018         Reviewed by Eric Seidel.
1019
1020         V8StringCallback.cpp requires V8Binding.h
1021         https://bugs.webkit.org/show_bug.cgi?id=57699
1022
1023         No new tests required because of just adding header file.
1024
1025         * bindings/scripts/CodeGeneratorV8.pm:
1026
1027 2011-04-03  Ryuan Choi  <ryuan.choi@samsung.com>
1028
1029         Reviewed by Eric Seidel.
1030
1031         [CMAKE] Clean duplicated files in WebCore_Sources
1032         https://bugs.webkit.org/show_bug.cgi?id=57741
1033
1034         No new tests, Only duplicated files were removed.
1035
1036         * CMakeLists.txt:
1037
1038 2011-04-03  Luke Macpherson   <macpherson@chromium.org>
1039
1040         Reviewed by Darin Adler.
1041
1042         Fix 2-space indentation introduced in bug 54706.
1043         https://bugs.webkit.org/show_bug.cgi?id=57740
1044
1045         No new tests - whitespace changes only.
1046
1047         * css/CSSStyleSelector.cpp:
1048         (WebCore::CSSStyleSelector::applyProperty):
1049         Convert 2-space indentation to 4-space indentation.
1050
1051 2011-04-03  Luke Macpherson   <macpherson@chromium.org>
1052
1053         Reviewed by Dimitri Glazkov.
1054
1055         Make CSSStyleApplyProperty non-copyable
1056         https://bugs.webkit.org/show_bug.cgi?id=57738
1057
1058         No new functionality added so no new tests required.
1059
1060         * css/CSSStyleApplyProperty.h:
1061         Added WTF_MAKE_NONCOPYABLE(CSSStyleApplyProperty) to ensure singleton stays single.
1062
1063 2011-04-03  Dan Bernstein  <mitz@apple.com>
1064
1065         Reviewed by Maciej Stachowiak.
1066
1067         fast/images/extra-image-in-image-document.html crashes when run after embed-image.html
1068         https://bugs.webkit.org/show_bug.cgi?id=57733
1069
1070         The crash happens because resetting the page scale as part of preparing the WebView for the
1071         next test triggered layout, which in turn caused a plug-in to make a resource request, and
1072         DumpRenderTree's delegate to be dispatched. The delegate doesn’t expect to be called between
1073         tests, and it references the layout test controller, which is null.
1074
1075         * page/Frame.cpp:
1076         (WebCore::Frame::scalePage): Avoid an unnecessary layout if the page scale isn’t changing. This
1077         is more efficient, and has the side effect of avoiding the crash in DumpRenderTree, although
1078         DumpRenderTree could still crash when after a test with disabled plug-ins and a non-1 page scale.
1079         I think there are currently no such tests, so I am not fixing DumpRenderTree.
1080
1081 2011-04-03  Eric Seidel  <eric@webkit.org>
1082
1083         Reviewed by Ryosuke Niwa.
1084
1085         Teach InlineIterator how to work from any root, not just a RenderBlock
1086         https://bugs.webkit.org/show_bug.cgi?id=57726
1087
1088         For implementing bidi-unicode: isolate, we need to be able to run the
1089         bidi algorithm over a subtree of inlines, not just from a block root.
1090         This is the first step in making this possible.
1091
1092         * rendering/InlineIterator.h:
1093         (WebCore::InlineIterator::InlineIterator):
1094         (WebCore::InlineIterator::root):
1095         (WebCore::bidiNext):
1096         (WebCore::bidiFirst):
1097         (WebCore::InlineIterator::increment):
1098         (WebCore::InlineBidiResolver::appendRun):
1099         * rendering/RenderBlockLineLayout.cpp:
1100         (WebCore::RenderBlock::findNextLineBreak):
1101
1102 2011-04-03  Eric Seidel  <eric@webkit.org>
1103
1104         Reviewed by Dan Bernstein.
1105
1106         Split out handling of trailing spaces from layoutInlineChildren
1107         https://bugs.webkit.org/show_bug.cgi?id=57432
1108
1109         There is much more we could split out from this function, but this is a start.
1110
1111         I suspect this is very hot code.  Hopefully the compiler will do the right thing.
1112         If it doesn't the Chromium PLT bots will tell us.
1113
1114         * rendering/RenderBlock.h:
1115         * rendering/RenderBlockLineLayout.cpp:
1116         (WebCore::RenderBlock::handleTrailingSpaces):
1117         (WebCore::RenderBlock::layoutInlineChildren):
1118
1119 2011-03-21  Ryosuke Niwa  <rniwa@webkit.org>
1120
1121         Reviewed by Eric Seidel.
1122
1123         editing commands shouldn't run when there's no body
1124         https://bugs.webkit.org/show_bug.cgi?id=56771
1125
1126         The bug was caused by WebKit's not checking the existence of root editable element
1127         in enabled* functions. Although isContentEditable returns true whenever we're in design mode,
1128         we should not run editing commands in a document without a body element editable because
1129         doing so results in appending a non-body element to the document node.
1130
1131         Fixed the bug by modifying various enabled* functions to ensure we have a root editable element.
1132         New behavior tries to match that of Firefox except StyleWithCSS, which Firefox seems to ignore
1133         when there are no body element. Since StyleWithCSS is a document's state or property, we allow
1134         execCommand('StyleWithCSS') even in a document without a body element.
1135
1136         WebKit's and Firefox's behaviors also deviate in insert-image-with-selecting-document.html.
1137         Whereas WebKit respects selection set by script and ignores execCommand, Firefox modifies
1138         the selection when document.write("x") is ran and successfully inserts image.
1139
1140         Thus, empty-document-delete.html and empty-document-justify-right.html both pass on Firefox
1141         while empty-document-stylewithcss.html and insert-image-with-selecting-document.html both fail.
1142
1143         Since Internet Explorer does not allow execCommand to run under design mode properly, we could
1144         not test its behavior.
1145
1146         Tests: editing/editability/empty-document-delete.html
1147                editing/editability/empty-document-justify-right.html
1148                editing/editability/empty-document-stylewithcss.html
1149                editing/execCommand/insert-image-with-selecting-document.html
1150
1151         * editing/Editor.cpp:
1152         (WebCore::Editor::canEdit): Verify that the root editable element exists
1153         instead of just checking that selection endpoints are editable because
1154         selection endpoints could be document node without a body element in design mode
1155         and we don't want to consider such a document editable.
1156         (WebCore::Editor::canDelete): Ditto.
1157         * editing/EditorCommand.cpp:
1158         (WebCore::enabledInEditableText): Ditto.
1159         (WebCore::enabledInRichlyEditableText): Ditto.
1160         (WebCore::enabledDelete): Call enabledCut and enabledInEditableText instead
1161         of duplicating the code in order to fix the same bug.
1162
1163 2011-04-02  Dan Bernstein  <mitz@apple.com>
1164
1165         Reviewed by Maciej Stachowiak.
1166
1167         REGRESSION (r82786): Media controls render incorrectly on GTK and Qt
1168         https://bugs.webkit.org/show_bug.cgi?id=57719
1169
1170         r82786 exposed an incorrect assumption inRenderMediaControlTimeDisplay::layout()
1171         that the timeline container is the parent of the time display. This is not true
1172         with the GTK media style, where the current time display is an inline box, and
1173         thus wrapped in an anonymous flexible box. The code was incorrectly considering
1174         the width of the anonymous box and deciding to hide the time display. Prior to
1175         r82786, this mistake was corrected by the call to computeLogicalWidth() in line layout.
1176
1177         * rendering/MediaControlElements.cpp:
1178         (WebCore::RenderMediaControlTimeDisplay::layout): Changed to skip past anonymous ancestors.
1179
1180 2011-04-02  Nico Weber  <thakis@chromium.org>
1181
1182         Reviewed by Adam Barth.
1183
1184         Explicitly use icu namespace for ports building with U_USING_ICU_NAMESPACE=0
1185
1186         By default, ICU includes |using namespace icu;| in its header files
1187         for backwards compatibility. Clients can define
1188         U_USING_ICU_NAMESPACE=0 to tell ICU to not do this. Prefixing all ICU
1189         classes with |icu::| makes this file compile no matter what
1190         U_USING_ICU_NAMESPACE is set to.
1191
1192         https://bugs.webkit.org/show_bug.cgi?id=57715
1193
1194         * platform/text/LocalizedNumberICU.cpp:
1195         (WebCore::createFormatterForCurrentLocale):
1196         (WebCore::numberFormatter):
1197         (WebCore::parseLocalizedNumber):
1198         (WebCore::formatLocalizedNumber):
1199
1200 2011-04-02  Dan Bernstein  <mitz@apple.com>
1201
1202         Reviewed by Dave Hyatt.
1203
1204         Remove an unnecessary extra computeLogicalWidth() from line layout
1205         https://bugs.webkit.org/show_bug.cgi?id=57711
1206
1207         Changes in behavior (MathML progression) covered by existing layout tests.
1208
1209         * rendering/RenderBlockLineLayout.cpp:
1210         (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Removed a
1211         call to computeLogicalWidth(). Because of <http://webkit.org/b/57700>, this
1212         actually prevents MathML rows from reverting to an incorrect width.
1213
1214 2011-04-02  Dan Bernstein  <mitz@apple.com>
1215
1216         Reviewed by Beth Dakin.
1217
1218         <details> marker loses its margin
1219         https://bugs.webkit.org/show_bug.cgi?id=57713
1220
1221         * rendering/RenderDetails.cpp:
1222         (WebCore::RenderDetails::computePreferredLogicalWidths): Override to update
1223         the marker location.
1224         * rendering/RenderDetails.h:
1225         (WebCore::RenderDetails::renderName): Made private.
1226         (WebCore::RenderDetails::isDetails): Ditto.
1227         * rendering/RenderDetailsMarker.cpp:
1228         (WebCore::RenderDetailsMarker::computePreferredLogicalWidths): Set the margins
1229         in the style, like RenderListMarker does.
1230         (WebCore::RenderDetailsMarker::layout): Set the margins from the style.
1231
1232 2011-04-02  Andy Estes  <aestes@apple.com>
1233
1234         Reviewed by Oliver Hunt.
1235
1236         REGRESSION (r69237): Black border around map elements while using an image map on Mac platform
1237         https://bugs.webkit.org/show_bug.cgi?id=52518
1238
1239         Test: fast/images/imagemap-focus-ring-zero-outline-width.html
1240
1241         * rendering/RenderImage.cpp:
1242         (WebCore::RenderImage::paintAreaElementFocusRing): Return early if outlineWidth is 0.
1243
1244 2011-04-02  Beth Dakin  <bdakin@apple.com>
1245
1246         Reviewed by Sam Weinig.
1247
1248         https://bugs.webkit.org/show_bug.cgi?id=57605
1249         Frame::pageScaleFactor() should not affect getBoundingClientRect() or 
1250         getClientRects()
1251         -and corresponding-
1252         <rdar://problem/9194541>
1253
1254         New functions adjust*ForPageScale() are analogous to adjust*ForAbsoluteZoom().
1255         * dom/Element.cpp:
1256         (WebCore::Element::getClientRects):
1257         (WebCore::Element::getBoundingClientRect):
1258         * dom/Range.cpp:
1259         (WebCore::adjustFloatQuadsForScrollAndAbsoluteZoomAndPageScale):
1260         (WebCore::Range::getBorderAndTextQuads):
1261         * rendering/RenderObject.h:
1262         (WebCore::adjustFloatPointForPageScale):
1263         (WebCore::adjustFloatQuadForPageScale):
1264         (WebCore::adjustFloatRectForPageScale):
1265
1266 2011-04-02  Dan Bernstein  <mitz@apple.com>
1267
1268         Reverted r82775 due to changes in <details> test results, which are
1269         likely progressions.
1270
1271         * rendering/RenderBlockLineLayout.cpp:
1272         (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Removed a
1273
1274 2011-04-02  Dan Bernstein  <mitz@apple.com>
1275
1276         Reviewed by Dave Hyatt.
1277
1278         Remove an unnecessary extra computeLogicalWidth() from line layout
1279         https://bugs.webkit.org/show_bug.cgi?id=57711
1280
1281         Changes in behavior (MathML progression) covered by existing layout tests.
1282
1283         * rendering/RenderBlockLineLayout.cpp:
1284         (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Removed a
1285         call to computeLogicalWidth(). Because of <http://webkit.org/b/57700>, this
1286         actually prevents MathML rows from reverting to an incorrect width.
1287
1288 2011-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
1289
1290         Reviewed by Martin Robinson.
1291
1292         [GTK] Fix leaked pointer in FontGtk.cpp
1293         https://bugs.webkit.org/show_bug.cgi?id=57307
1294
1295         Fix a memory leak.
1296
1297         No new functionality, so no new tests.
1298
1299         * platform/graphics/gtk/FontGtk.cpp:
1300         (WebCore::utf16ToUtf8): Rename utf16_to_utf8 and fix indentation.
1301         (WebCore::convertUniCharToUTF8):
1302
1303 2011-04-02  Ilya Tikhonovsky  <loislo@chromium.org>
1304
1305         Reviewed by Pavel Feldman.
1306
1307         Web Inspector: we should be able to have in and out arguments of a command with same name.
1308         https://bugs.webkit.org/show_bug.cgi?id=57701
1309
1310         * inspector/CodeGeneratorInspector.pm:
1311         * inspector/Inspector.json:
1312
1313 2011-04-01  Ilya Tikhonovsky  <loislo@chromium.org>
1314
1315         Not reviewed trivial change.
1316
1317         Web Inspector: The page agent should be enabled even if JAVASCRIPT_DEBUGGER is off.
1318         Followup change for r82281.
1319         https://bugs.webkit.org/show_bug.cgi?id=57327
1320
1321         * inspector/InspectorPageAgent.cpp:
1322         * inspector/InspectorPageAgent.h:
1323
1324 2011-04-01  Michael Saboff  <msaboff@apple.com>
1325
1326         Reviewed by Darin Adler.
1327
1328         Cached Resource Overhead Space Usage and Accounting Inaccurate
1329         https://bugs.webkit.org/show_bug.cgi?id=57488
1330
1331         Fixed windows test failures.
1332         Changed the fixed overhead value for ResourceResponse to 3800 bytes.
1333         Modified ResourceResponse::platformLazyInit() to handle "base" level
1334         attributes or all attributes.  The base attributes, like URL, status
1335         code, mime type and a few header fields (mostly cache related) are
1336         suitable for most resources.  This reduces the per resource memory
1337         needs by over 1K bytes per resource thus saving memory in the cache.
1338         Collectively, these two changes bring the overhead memory calculation
1339         in line with reality.
1340
1341         No new tests added due to existing tests cover areas of change and
1342         there is no functional change.  The change is limited to reducing 
1343         memory usage along existing paths.
1344
1345         * loader/cache/CachedResource.cpp:
1346         (WebCore::CachedResource::canUseCacheValidator):
1347         * platform/network/ResourceResponseBase.cpp:
1348         (WebCore::ResourceResponseBase::adopt):
1349         (WebCore::ResourceResponseBase::isHTTP):
1350         (WebCore::ResourceResponseBase::url):
1351         (WebCore::ResourceResponseBase::setURL):
1352         (WebCore::ResourceResponseBase::mimeType):
1353         (WebCore::ResourceResponseBase::setMimeType):
1354         (WebCore::ResourceResponseBase::expectedContentLength):
1355         (WebCore::ResourceResponseBase::setExpectedContentLength):
1356         (WebCore::ResourceResponseBase::textEncodingName):
1357         (WebCore::ResourceResponseBase::setTextEncodingName):
1358         (WebCore::ResourceResponseBase::suggestedFilename):
1359         (WebCore::ResourceResponseBase::setSuggestedFilename):
1360         (WebCore::ResourceResponseBase::httpStatusCode):
1361         (WebCore::ResourceResponseBase::setHTTPStatusCode):
1362         (WebCore::ResourceResponseBase::httpStatusText):
1363         (WebCore::ResourceResponseBase::setHTTPStatusText):
1364         (WebCore::ResourceResponseBase::httpHeaderField):
1365         (WebCore::ResourceResponseBase::setHTTPHeaderField):
1366         (WebCore::ResourceResponseBase::httpHeaderFields):
1367         (WebCore::ResourceResponseBase::parseCacheControlDirectives):
1368         (WebCore::ResourceResponseBase::hasCacheValidatorFields):
1369         (WebCore::ResourceResponseBase::date):
1370         (WebCore::ResourceResponseBase::age):
1371         (WebCore::ResourceResponseBase::expires):
1372         (WebCore::ResourceResponseBase::lastModified):
1373         (WebCore::ResourceResponseBase::isAttachment):
1374         (WebCore::ResourceResponseBase::setLastModifiedDate):
1375         (WebCore::ResourceResponseBase::lastModifiedDate):
1376         (WebCore::ResourceResponseBase::wasCached):
1377         (WebCore::ResourceResponseBase::connectionReused):
1378         (WebCore::ResourceResponseBase::setConnectionReused):
1379         (WebCore::ResourceResponseBase::connectionID):
1380         (WebCore::ResourceResponseBase::setConnectionID):
1381         (WebCore::ResourceResponseBase::resourceLoadTiming):
1382         (WebCore::ResourceResponseBase::setResourceLoadTiming):
1383         (WebCore::ResourceResponseBase::resourceLoadInfo):
1384         (WebCore::ResourceResponseBase::setResourceLoadInfo):
1385         (WebCore::ResourceResponseBase::lazyInit):
1386         * platform/network/ResourceResponseBase.h:
1387         (WebCore::ResourceResponseBase::platformLazyInit):
1388         * platform/network/cf/ResourceResponse.h:
1389         (WebCore::ResourceResponse::ResourceResponse):
1390         (WebCore::ResourceResponse::memoryUsage):
1391         * platform/network/cf/ResourceResponseCFNet.cpp:
1392         (WebCore::ResourceResponse::platformLazyInit):
1393         * platform/network/mac/ResourceResponseMac.mm:
1394         (WebCore::ResourceResponse::platformLazyInit):
1395
1396 2011-04-01  Anantanarayanan G Iyengar  <ananta@chromium.org>
1397
1398         Reviewed by Adam Barth.
1399
1400         https://bugs.webkit.org/show_bug.cgi?id=45855
1401         Windowless plugins added dynamically to the DOM should receive paint events.
1402         This is done by ensuring that the plugin widget is marked for painting when
1403         it is added.
1404
1405         Test: plugins/windowless_plugin_paint_test.html
1406
1407         * rendering/RenderWidget.cpp:
1408         (WebCore::RenderWidget::setWidget):
1409
1410 2011-04-01  Mike Reed  <reed@google.com>
1411
1412         Reviewed by James Robinson.
1413
1414         always use native font rendering on skia_gpu
1415         fixes a crash when SKIA_GPU is enabled, as we can't call getTopPlatformDevice()
1416         https://bugs.webkit.org/show_bug.cgi?id=57663
1417
1418         No new tests. existing rendering tests will exercise this
1419
1420         * platform/graphics/skia/PlatformContextSkia.cpp:
1421         (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
1422
1423 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1424
1425         Unreviewed, rolling out r82712, r82729, and r82746.
1426         http://trac.webkit.org/changeset/82712
1427         http://trac.webkit.org/changeset/82729
1428         http://trac.webkit.org/changeset/82746
1429         https://bugs.webkit.org/show_bug.cgi?id=57682
1430
1431         fast/frames/frame-programmatic-noresize.html is failing on
1432         Windows bots. Will look into this offline. (Requested by dydx
1433         on #webkit).
1434
1435         * html/HTMLFrameElement.cpp:
1436         (WebCore::HTMLFrameElement::HTMLFrameElement):
1437         (WebCore::HTMLFrameElement::attach):
1438         (WebCore::HTMLFrameElement::parseMappedAttribute):
1439         * html/HTMLFrameElement.h:
1440         (WebCore::HTMLFrameElement::noResize):
1441         * rendering/RenderFrame.cpp:
1442         * rendering/RenderFrame.h:
1443         * rendering/RenderFrameSet.cpp:
1444         * rendering/RenderFrameSet.h:
1445
1446 2011-04-01  Adam Barth  <abarth@webkit.org>
1447
1448         Reviewed by Tony Chang.
1449
1450         Valgrind error in _ZN7WebCore8Document11updateTitleERKNS_19StringWithDirectionE
1451         https://bugs.webkit.org/show_bug.cgi?id=57656
1452
1453         We should initialize memory when constructing objects.
1454
1455         * platform/text/StringWithDirection.h:
1456         (WebCore::StringWithDirection::StringWithDirection):
1457
1458 2011-04-01  Jer Noble  <jer.noble@apple.com>
1459
1460         Reviewed by Darin Adler.
1461
1462         WebKit2: Link from PDF opens in a new tab instead of in the same tab
1463         https://bugs.webkit.org/show_bug.cgi?id=57528
1464
1465         * WebCore.exp.in: Export MouseEvent::create().
1466
1467 2011-04-01  John Bauman  <jbauman@chromium.org>
1468
1469         Reviewed by Kenneth Russell.
1470
1471         Avoid decoding images twice in texImage2D
1472         https://bugs.webkit.org/show_bug.cgi?id=51498
1473
1474         Make sure to redecode the image only if it's not opaque and texImage2D
1475         wouldn't premultiply it anyway.
1476
1477         * platform/graphics/BitmapImage.h:
1478         * platform/graphics/cg/GraphicsContext3DCG.cpp:
1479         (WebCore::GraphicsContext3D::getImageData):
1480         * platform/graphics/skia/GraphicsContext3DSkia.cpp:
1481         (WebCore::GraphicsContext3D::getImageData):
1482
1483 2011-04-01  Alexey Proskuryakov  <ap@apple.com>
1484
1485         32-bit Mac build fix.
1486
1487         * dom/KeyboardEvent.h: (WebCore::KeypressCommand::KeypressCommand): Use 0U to index a String
1488         to avoid ambiguity.
1489
1490 2011-04-01  Alexey Proskuryakov  <ap@apple.com>
1491
1492         Reviewed by Darin Adler.
1493
1494         Make WebKit2 text input handling more like WebKit1
1495         https://bugs.webkit.org/show_bug.cgi?id=57649
1496
1497         * dom/KeyboardEvent.h: (WebCore::KeypressCommand::KeypressCommand): Put back the assertions
1498         we used to have. It is dangerous to confuse editor commands and selector names - besides the
1499         presence of a semicolon, they sometimes have different names, and WebKit2 failed to map those.
1500
1501 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1502
1503         Unreviewed, rolling out r82711.
1504         http://trac.webkit.org/changeset/82711
1505         https://bugs.webkit.org/show_bug.cgi?id=57657
1506
1507         Made every test crash on XP and Win7 (Requested by
1508         abarth|gardening on #webkit).
1509
1510         * loader/cache/CachedResource.cpp:
1511         (WebCore::CachedResource::canUseCacheValidator):
1512         * platform/network/ResourceResponseBase.cpp:
1513         (WebCore::ResourceResponseBase::adopt):
1514         (WebCore::ResourceResponseBase::isHTTP):
1515         (WebCore::ResourceResponseBase::url):
1516         (WebCore::ResourceResponseBase::setURL):
1517         (WebCore::ResourceResponseBase::mimeType):
1518         (WebCore::ResourceResponseBase::setMimeType):
1519         (WebCore::ResourceResponseBase::expectedContentLength):
1520         (WebCore::ResourceResponseBase::setExpectedContentLength):
1521         (WebCore::ResourceResponseBase::textEncodingName):
1522         (WebCore::ResourceResponseBase::setTextEncodingName):
1523         (WebCore::ResourceResponseBase::suggestedFilename):
1524         (WebCore::ResourceResponseBase::setSuggestedFilename):
1525         (WebCore::ResourceResponseBase::httpStatusCode):
1526         (WebCore::ResourceResponseBase::setHTTPStatusCode):
1527         (WebCore::ResourceResponseBase::httpStatusText):
1528         (WebCore::ResourceResponseBase::setHTTPStatusText):
1529         (WebCore::ResourceResponseBase::httpHeaderField):
1530         (WebCore::ResourceResponseBase::setHTTPHeaderField):
1531         (WebCore::ResourceResponseBase::httpHeaderFields):
1532         (WebCore::ResourceResponseBase::parseCacheControlDirectives):
1533         (WebCore::ResourceResponseBase::date):
1534         (WebCore::ResourceResponseBase::age):
1535         (WebCore::ResourceResponseBase::expires):
1536         (WebCore::ResourceResponseBase::lastModified):
1537         (WebCore::ResourceResponseBase::isAttachment):
1538         (WebCore::ResourceResponseBase::setLastModifiedDate):
1539         (WebCore::ResourceResponseBase::lastModifiedDate):
1540         (WebCore::ResourceResponseBase::wasCached):
1541         (WebCore::ResourceResponseBase::connectionReused):
1542         (WebCore::ResourceResponseBase::setConnectionReused):
1543         (WebCore::ResourceResponseBase::connectionID):
1544         (WebCore::ResourceResponseBase::setConnectionID):
1545         (WebCore::ResourceResponseBase::resourceLoadTiming):
1546         (WebCore::ResourceResponseBase::setResourceLoadTiming):
1547         (WebCore::ResourceResponseBase::resourceLoadInfo):
1548         (WebCore::ResourceResponseBase::setResourceLoadInfo):
1549         (WebCore::ResourceResponseBase::lazyInit):
1550         * platform/network/ResourceResponseBase.h:
1551         (WebCore::ResourceResponseBase::platformLazyInit):
1552         * platform/network/cf/ResourceResponse.h:
1553         (WebCore::ResourceResponse::ResourceResponse):
1554         (WebCore::ResourceResponse::memoryUsage):
1555         * platform/network/cf/ResourceResponseCFNet.cpp:
1556         (WebCore::ResourceResponse::platformLazyInit):
1557         * platform/network/mac/ResourceResponseMac.mm:
1558         (WebCore::ResourceResponse::platformLazyInit):
1559
1560 2011-04-01  Matthew Delaney  <mdelaney@apple.com>
1561
1562         Reviewed by Simon Fraser.
1563
1564         Behavior of isAccelerated() for a IOSurface-backed canvas should be consistent with accelerated status of its ImageBuffer
1565         https://bugs.webkit.org/show_bug.cgi?id=57651
1566
1567         No new tests. This patch does not affect outward behavior.
1568
1569         * html/canvas/CanvasRenderingContext2D.cpp:
1570         (WebCore::CanvasRenderingContext2D::isAccelerated):
1571         * platform/graphics/ImageBuffer.h:
1572         (WebCore::ImageBuffer::isAccelerated):
1573
1574 2011-04-01  Daniel Bates  <dbates@rim.com>
1575
1576         Reviewed by Darin Adler.
1577
1578         Frame's noResize attribute can not be set by JavaScript
1579         https://bugs.webkit.org/show_bug.cgi?id=14845
1580
1581         Tests: fast/frames/frame-inherit-noresize-from-frameset.html
1582                fast/frames/frame-programmatic-noresize.html
1583                fast/frames/frame-with-noresize-can-be-resized-after-removal-of-noresize.html
1584                fast/frames/frame-with-noresize-can-be-resized-after-setting-noResize-to-false.html
1585
1586         Implements support to programmatically allow and disallow frame resizing.
1587
1588         Currently, HTMLFrameElement::parseMappedAttribute() is hardcoded to disallow frame resize (i.e.
1589         m_noResize = true) when either the noresize DOM attribute is specified (or existed at some
1590         point in time) or the value of the noResize attribute is modified. Instead we should allow/disallow
1591         frame resize depending on the presence of the noresize DOM attribute/the value of the noResize
1592         attribute.
1593
1594         * html/HTMLFrameElement.cpp:
1595         (WebCore::HTMLFrameElement::HTMLFrameElement):
1596         (WebCore::HTMLFrameElement::noResize): Made this a non-inline function since this
1597         code path isn't performance critical.
1598         (WebCore::HTMLFrameElement::attach): Removed code to inherit noresize attribute from
1599         parent <frameset> since this functionality is part of RenderFrameSet::computeEdgeInfo().
1600         (WebCore::HTMLFrameElement::parseMappedAttribute):
1601         * html/HTMLFrameElement.h:
1602         * rendering/RenderFrame.cpp:
1603         (WebCore::RenderFrame::updateFromElement): Added.
1604         * rendering/RenderFrame.h:
1605         * rendering/RenderFrameSet.cpp:
1606         (WebCore::RenderFrameSet::notifyFrameEdgeInfoChanged): Added.
1607         * rendering/RenderFrameSet.h:
1608
1609 2011-04-01  Michael Saboff  <msaboff@apple.com>
1610
1611         Reviewed by Darin Adler.
1612
1613         Cached Resource Overhead Space Usage and Accounting Inaccurate
1614         https://bugs.webkit.org/show_bug.cgi?id=57488
1615
1616         Changed the fixed overhead value for ResourceResponse to 3800 bytes.
1617         Modified ResourceResponse::platformLazyInit() to handle "base" level
1618         attributes or all attributes.  The base attributes, like URL, status
1619         code, mime type and a few header fields (mostly cache related) are
1620         suitable for most resources.  This reduces the per resource memory
1621         needs by over 1K bytes per resource thus saving memory in the cache.
1622         Collectively, these two changes bring the overhead memory calculation
1623         in line with reality.
1624
1625         No new tests added due to existing tests cover areas of change and
1626         there is no functional change.  The change is limited to reducing 
1627         memory usage along existing paths.
1628
1629         * loader/cache/CachedResource.cpp:
1630         (WebCore::CachedResource::canUseCacheValidator):
1631         * platform/network/ResourceResponseBase.cpp:
1632         (WebCore::ResourceResponseBase::isHTTP):
1633         (WebCore::ResourceResponseBase::url):
1634         (WebCore::ResourceResponseBase::setURL):
1635         (WebCore::ResourceResponseBase::mimeType):
1636         (WebCore::ResourceResponseBase::setMimeType):
1637         (WebCore::ResourceResponseBase::expectedContentLength):
1638         (WebCore::ResourceResponseBase::setExpectedContentLength):
1639         (WebCore::ResourceResponseBase::textEncodingName):
1640         (WebCore::ResourceResponseBase::setTextEncodingName):
1641         (WebCore::ResourceResponseBase::suggestedFilename):
1642         (WebCore::ResourceResponseBase::setSuggestedFilename):
1643         (WebCore::ResourceResponseBase::httpStatusCode):
1644         (WebCore::ResourceResponseBase::setHTTPStatusCode):
1645         (WebCore::ResourceResponseBase::httpHeaderField):
1646         (WebCore::ResourceResponseBase::setHTTPHeaderField):
1647         (WebCore::ResourceResponseBase::parseCacheControlDirectives):
1648         (WebCore::ResourceResponseBase::hasCacheValidatorFields):
1649         (WebCore::ResourceResponseBase::date):
1650         (WebCore::ResourceResponseBase::age):
1651         (WebCore::ResourceResponseBase::expires):
1652         (WebCore::ResourceResponseBase::lastModified):
1653         (WebCore::ResourceResponseBase::lazyInit):
1654         * platform/network/ResourceResponseBase.h:
1655         (WebCore::ResourceResponseBase::platformLazyInit):
1656         * platform/network/cf/ResourceResponse.h:
1657         (WebCore::ResourceResponse::ResourceResponse):
1658         (WebCore::ResourceResponse::memoryUsage):
1659         * platform/network/cf/ResourceResponseCFNet.cpp:
1660         * platform/network/mac/ResourceResponseMac.mm:
1661         (WebCore::ResourceResponse::platformLazyInit):
1662
1663 2011-04-01  Timothy Hatcher  <timothy@apple.com>
1664
1665         Make momentum scroll event latching work in WebKit2 on Mac.
1666
1667         <rdar://problem/8751861>
1668
1669         Reviewed by Darin Adler.
1670
1671         * WebCore.exp.in: Remove _wkIsLatchingWheelEvent, add _wkGetNSEventMomentumPhase.
1672         * page/EventHandler.cpp:
1673         (WebCore::EventHandler::handleWheelEvent): Set m_useLatchedWheelEventNode based on the
1674         event's momentumPhase.
1675         * page/mac/EventHandlerMac.mm:
1676         (WebCore::EventHandler::wheelEvent): Remove the setting of m_useLatchedWheelEventNode.
1677         It is now done in EventHandler::handleWheelEvent.
1678         * platform/mac/WebCoreSystemInterface.h: Remove wkIsLatchingWheelEvent, add wkGetNSEventMomentumPhase.
1679         * platform/mac/WebCoreSystemInterface.mm: Ditto.
1680         * platform/mac/WheelEventMac.mm:
1681         (WebCore::momentumPhaseForEvent): Return a phase on older Mac system by using wkGetNSEventMomentumPhase.
1682
1683 2011-04-01  Steve Block  <steveblock@google.com>
1684
1685         Reviewed by Jeremy Orlow.
1686
1687         JavaClass should be an interface and free of JNI types
1688         https://bugs.webkit.org/show_bug.cgi?id=57533
1689
1690         This patch fixes JavaClass for V8 only.
1691
1692         It factors out a JavaClass interface which does not use JNI types.
1693         This will allow the Java bridge to be used with objects that
1694         don't use JNI directly. The existing jobject-backed
1695         implementation is moved to a new JavaClassJobject class which
1696         implements the interface.
1697
1698         No new tests, refactoring only.
1699
1700         * Android.v8bindings.mk:
1701         * WebCore.gypi:
1702         * bridge/jni/v8/JavaClassJobjectV8.cpp:
1703         (JavaClassJobject::JavaClassJobject):
1704         (JavaClassJobject::~JavaClassJobject):
1705         (JavaClassJobject::methodsNamed):
1706         (JavaClassJobject::fieldNamed):
1707         * bridge/jni/v8/JavaClassJobjectV8.h: Copied from Source/WebCore/bridge/jni/v8/JavaClassV8.h.
1708         * bridge/jni/v8/JavaClassV8.h:
1709         (JSC::Bindings::JavaClass::~JavaClass):
1710         * bridge/jni/v8/JavaInstanceV8.cpp:
1711         (JavaInstance::getClass):
1712
1713 2011-04-01  Jaehun Lim  <ljaehun.lim@samsung.com>
1714
1715         Unreviewed build fix.
1716
1717         Fix build break when font backend is Pango.
1718         Pango is missed in changeset 80589.
1719
1720         https://bugs.webkit.org/show_bug.cgi?id=57609
1721
1722         * platform/graphics/pango/FontPlatformData.h:
1723         (WebCore::FontPlatformData::setOrientation):
1724
1725 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1726
1727         Unreviewed, rolling out r82687.
1728         http://trac.webkit.org/changeset/82687
1729         https://bugs.webkit.org/show_bug.cgi?id=57643
1730
1731         This patch broke accessibility aria-treegrid test in Mac
1732         (Requested by msanchez on #webkit).
1733
1734         * accessibility/AccessibilityARIAGrid.cpp:
1735         * accessibility/AccessibilityARIAGrid.h:
1736         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1737         (atkRole):
1738         * accessibility/mac/AccessibilityObjectWrapper.mm:
1739
1740 2011-03-31  Abhishek Arya  <inferno@chromium.org>
1741
1742         Reviewed by Andreas Kling.
1743
1744         Whenever a relayout is trigger for SVGPath, make sure
1745         to clear its previous marker layout info. This helps
1746         to prevent removed markers from being used.
1747         https://bugs.webkit.org/show_bug.cgi?id=57492
1748
1749         Test: svg/dom/path-marker-removed-crash.svg
1750
1751         * rendering/svg/RenderSVGPath.cpp:
1752         (WebCore::RenderSVGPath::layout):
1753         * rendering/svg/SVGMarkerLayoutInfo.cpp:
1754         (WebCore::SVGMarkerLayoutInfo::clear):
1755         * rendering/svg/SVGMarkerLayoutInfo.h:
1756
1757 2011-04-01  Rob Buis  <rwlbuis@gmail.com>
1758
1759         Reviewed by Nikolas Zimmermann.
1760
1761         https://bugs.webkit.org/show_bug.cgi?id=55750
1762         SVG <image> referenced by <use> is displayed incorrectly
1763
1764         Reintroduce old behaviour for valid base URI, for invalid
1765         keep using document base URI.
1766         Fixes regression of W3C-SVG-1.1/struct-image-07-t.svg.
1767
1768         Test: svg/custom/image-base-uri.svg
1769
1770         * svg/SVGImageLoader.cpp:
1771         (WebCore::SVGImageLoader::sourceURI):
1772
1773 2011-04-01  Mario Sanchez Prada  <msanchez@igalia.com>
1774
1775         Reviewed by Chris Fleizach.
1776
1777         ARIA Grid tables should return GridRole in roleValue() method
1778         https://bugs.webkit.org/show_bug.cgi?id=57614
1779
1780         This change does not need any test since it doesn't change anything
1781         from the point of view of the consumers (Assistive Technoglogies).
1782         It's just an internal change to simplify identifying HTML and ARIA
1783         tables by calling to the AccessibilityObject::roleValue method.
1784
1785         * accessibility/AccessibilityARIAGrid.h:
1786         * accessibility/AccessibilityARIAGrid.cpp:
1787         (WebCore::AccessibilityARIAGrid::roleValue): Return GridRole.
1788
1789         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1790         (atkRole): Removed unneeded comment.
1791
1792         * accessibility/mac/AccessibilityObjectWrapper.mm: Map GridRole to
1793         NSAccessibilityTableRole, to keep the same behaviour.
1794
1795 2011-04-01  MORITA Hajime  <morrita@google.com>
1796
1797         Reviewed by Dimitri Glazkov.
1798
1799         <meter> can only support horizontal indicator
1800         https://bugs.webkit.org/show_bug.cgi?id=56001
1801
1802         - Removed code which deals with the direction and
1803           left the horizontal path.
1804         - Removed "horizontal" from related names which is now
1805           redundant.
1806         
1807         * css/CSSSelector.cpp:
1808         (WebCore::CSSSelector::pseudoId):
1809         (WebCore::nameToPseudoTypeMap):
1810         (WebCore::CSSSelector::extractPseudoType):
1811         * css/CSSSelector.h:
1812         * css/html.css:
1813         (meter::-webkit-meter-bar):
1814         (meter::-webkit-meter-optimum-value):
1815         (meter::-webkit-meter-suboptimal-value):
1816         (meter::-webkit-meter-even-less-good-value):
1817         * rendering/RenderMeter.cpp:
1818         (WebCore::RenderMeter::~RenderMeter):
1819         (WebCore::RenderMeter::createPart):
1820         (WebCore::RenderMeter::updateFromElement):
1821         (WebCore::RenderMeter::layoutParts):
1822         (WebCore::RenderMeter::styleDidChange):
1823         (WebCore::RenderMeter::shouldHaveParts):
1824         (WebCore::RenderMeter::valuePartRect):
1825         (WebCore::RenderMeter::valuePseudoId):
1826         (WebCore::RenderMeter::barPseudoId):
1827         (WebCore::RenderMeter::detachShadows):
1828         (WebCore::RenderMeter::updateShadows):
1829         * rendering/RenderMeter.h:
1830         (WebCore::RenderMeter::shadowAttached):
1831         * rendering/RenderTheme.cpp:
1832         (WebCore::RenderTheme::supportsMeter):
1833         * rendering/RenderTheme.h:
1834         * rendering/RenderThemeMac.h:
1835         * rendering/RenderThemeMac.mm:
1836         (WebCore::RenderThemeMac::paintMeter):
1837         (WebCore::RenderThemeMac::supportsMeter):
1838         * rendering/style/RenderStyleConstants.h:
1839
1840 2011-03-23  Pavel Podivilov  <podivilov@chromium.org>
1841
1842         Reviewed by Pavel Feldman.
1843
1844         Web Inspector: fix reveal line in formatted script.
1845         https://bugs.webkit.org/show_bug.cgi?id=56941
1846
1847         * inspector/front-end/BreakpointsSidebarPane.js:
1848         (WebInspector.JavaScriptBreakpointsSidebarPane):
1849         (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointClicked):
1850         * inspector/front-end/DebuggerPresentationModel.js:
1851         (WebInspector.DebuggerPresentationModel.prototype.sourceFileForScriptURL):
1852         * inspector/front-end/NetworkPanel.js:
1853         (WebInspector.NetworkPanel.prototype.canShowAnchorLocation):
1854         (WebInspector.NetworkPanel.prototype.showAnchorLocation):
1855         * inspector/front-end/Panel.js:
1856         (WebInspector.Panel.prototype.canShowAnchorLocation):
1857         (WebInspector.Panel.prototype.showAnchorLocation):
1858         * inspector/front-end/ResourcesPanel.js:
1859         (WebInspector.ResourcesPanel.prototype.canShowAnchorLocation):
1860         (WebInspector.ResourcesPanel.prototype.showAnchorLocation):
1861         (WebInspector.ResourcesPanel.prototype.showResource):
1862         * inspector/front-end/ScriptsPanel.js:
1863         (WebInspector.ScriptsPanel):
1864         (WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
1865         (WebInspector.ScriptsPanel.prototype.showAnchorLocation):
1866         (WebInspector.ScriptsPanel.prototype._showSourceLine):
1867         * inspector/front-end/SourceFrame.js:
1868         (WebInspector.SourceFrame.prototype.highlightLine):
1869         (WebInspector.SourceFrame.prototype._createTextViewer):
1870         * inspector/front-end/inspector.js:
1871         (WebInspector.documentClick.followLink):
1872         (WebInspector.documentClick):
1873         (WebInspector._showAnchorLocation):
1874
1875 2011-04-01  Pavel Podivilov  <podivilov@chromium.org>
1876
1877         Reviewed by Yury Semikhatsky.
1878
1879         Web Inspector: make editScriptSource a Script's method.
1880         https://bugs.webkit.org/show_bug.cgi?id=57615
1881
1882         * inspector/front-end/DebuggerModel.js:
1883         (WebInspector.DebuggerModel.prototype.editScriptSource):
1884         (WebInspector.DebuggerModel.prototype._didEditScriptSource):
1885         * inspector/front-end/Script.js:
1886         (WebInspector.Script.prototype.requestSource):
1887         (WebInspector.Script.prototype.editSource):
1888
1889 2011-04-01  Pavel Feldman  <pfeldman@google.com>
1890
1891         Reviewed by Yury Semikhatsky.
1892
1893         Web Inspector: event should have "data" attribute, not "body"
1894         https://bugs.webkit.org/show_bug.cgi?id=57628
1895
1896         * inspector/CodeGeneratorInspector.pm:
1897
1898 2011-04-01  Pavel Podivilov  <podivilov@chromium.org>
1899
1900         Reviewed by Yury Semikhatsky.
1901
1902         Web Inspector: checkboxes are broken in xhr breakpoints sidebar pane.
1903         https://bugs.webkit.org/show_bug.cgi?id=57610
1904
1905         * inspector/front-end/BreakpointsSidebarPane.js:
1906         (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
1907
1908 2011-04-01  Alexander Pavlov  <apavlov@chromium.org>
1909
1910         Reviewed by Yury Semikhatsky.
1911
1912         Web Inspector: up/down keys are not treating hex numbers properly while editing styles.
1913         https://bugs.webkit.org/show_bug.cgi?id=40522
1914
1915         Drive-by: fix inc/dec for numbers like ".5"
1916
1917         Test: inspector/styles/up-down-numerics-and-colors.html
1918
1919         * inspector/front-end/StylesSidebarPane.js:
1920         (WebInspector.StylePropertyTreeElement.prototype):
1921
1922 2011-03-30  Pavel Podivilov  <podivilov@chromium.org>
1923
1924         Reviewed by Pavel Feldman.
1925
1926         Web Inspector: remove dead code from Script.js.
1927         https://bugs.webkit.org/show_bug.cgi?id=57454
1928
1929         * inspector/front-end/DebuggerModel.js:
1930         (WebInspector.DebuggerModel.prototype._parsedScriptSource):
1931         (WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
1932         * inspector/front-end/Script.js:
1933         (WebInspector.Script):
1934         (WebInspector.Script.prototype.requestSource.didGetScriptSource):
1935         (WebInspector.Script.prototype.requestSource):
1936
1937 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1938
1939         Unreviewed, rolling out r82667.
1940         http://trac.webkit.org/changeset/82667
1941         https://bugs.webkit.org/show_bug.cgi?id=57612
1942
1943         Breaks Leopard layout tests (Requested by podivilov on
1944         #webkit).
1945
1946         * GNUmakefile.am:
1947         * inspector/front-end/DebuggerPresentationModel.js:
1948         (WebInspector.DebuggerPresentationModel):
1949         (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
1950
1951 2011-03-30  Pavel Podivilov  <podivilov@chromium.org>
1952
1953         Reviewed by Pavel Feldman.
1954
1955         Web Inspector: remove unused SourceFrameContent class.
1956         https://bugs.webkit.org/show_bug.cgi?id=57453
1957
1958         * WebCore.gypi:
1959         * WebCore.vcproj/WebCore.vcproj:
1960         * inspector/front-end/ResourceView.js:
1961         (WebInspector.SourceFrameDelegateForResourcesPanel.prototype.requestContent):
1962         * inspector/front-end/ScriptsPanel.js:
1963         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
1964         * inspector/front-end/SourceFrame.js:
1965         (WebInspector.SourceFrame.prototype._createTextViewer):
1966         * inspector/front-end/SourceFrameContent.js: Removed.
1967         * inspector/front-end/WebKit.qrc:
1968         * inspector/front-end/inspector.html:
1969
1970 2011-03-30  Pavel Podivilov  <podivilov@chromium.org>
1971
1972         Reviewed by Pavel Feldman.
1973
1974         Web Inspector: add test for script formatter worker.
1975         https://bugs.webkit.org/show_bug.cgi?id=57447
1976
1977         Test: inspector/debugger/script-formatter.html
1978
1979         * GNUmakefile.am:
1980         * inspector/front-end/DebuggerPresentationModel.js:
1981         (WebInspector.DebuggerPresentationModel):
1982         (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
1983
1984 2011-03-30  Pavel Podivilov  <podivilov@chromium.org>
1985
1986         Reviewed by Pavel Feldman.
1987
1988         Web Inspector: [chromium] script formatting doesn't work when all scripts are concatenated.
1989         https://bugs.webkit.org/show_bug.cgi?id=57446
1990
1991         * inspector/front-end/ScriptFormatterWorker.js:
1992
1993 2011-04-01  Pavel Podivilov  <podivilov@chromium.org>
1994
1995         Reviewed by Pavel Feldman.
1996
1997         Web Inspector: allow file access from inspector page so inspector can use workers.
1998         https://bugs.webkit.org/show_bug.cgi?id=57339
1999
2000         * inspector/InspectorFrontendClientLocal.cpp:
2001         (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
2002
2003 2011-03-31  Yury Semikhatsky  <yurys@chromium.org>
2004
2005         Reviewed by Pavel Feldman.
2006
2007         Web Inspector: inspected page crashes on attempt to log object with broken .toString
2008         https://bugs.webkit.org/show_bug.cgi?id=57557
2009
2010         If ScriptValue.toString causes a JavaScript exception, the exception is cleared
2011         before returning from the toString method.
2012
2013         Test: inspector/console/console-log-toString-object.html
2014
2015         * bindings/js/ScriptValue.cpp:
2016         (WebCore::ScriptValue::toString):
2017         * bindings/js/ScriptValue.h:
2018         * bindings/v8/ScriptValue.cpp:
2019         (WebCore::ScriptValue::toString):
2020
2021 2011-03-31  Andrey Kosyakov  <caseq@chromium.org>
2022
2023         Reviewed by Pavel Feldman.
2024
2025         - removed documentWide parameter to querySelector[All]() (user document node id instead)
2026         - factor out document request logic within DOMAgent into separate method
2027         - add querySelector() and querySelectorAll() to DOMAgent.js, assure we have document before calling back-end
2028         - use the above wrappers for querySelector() and querySelectorAll(), do not call backend directly
2029         - minor style fixes in Inspector.json
2030         - more error logging
2031
2032         Web Inspector: provide front-end wrappers for DOMAgent.querySelector[All]() that take care of fetching the document
2033         https://bugs.webkit.org/show_bug.cgi?id=57466
2034
2035         * inspector/Inspector.json:
2036         * inspector/InspectorDOMAgent.cpp:
2037         (WebCore::InspectorDOMAgent::querySelector):
2038         (WebCore::InspectorDOMAgent::querySelectorAll):
2039         * inspector/InspectorDOMAgent.h:
2040         * inspector/front-end/AuditRules.js:
2041         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
2042         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
2043         * inspector/front-end/CSSStyleModel.js:
2044         (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
2045         (WebInspector.CSSStyleModel.prototype.setRuleSelector):
2046         (WebInspector.CSSStyleModel.prototype.addRule.callback):
2047         (WebInspector.CSSStyleModel.prototype.addRule):
2048         * inspector/front-end/DOMAgent.js:
2049         (WebInspector.DOMAgent.prototype.requestDocument.onDocumentAvailable):
2050         (WebInspector.DOMAgent.prototype.requestDocument):
2051         (WebInspector.DOMAgent.prototype.pushNodeToFrontend):
2052         (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
2053         (WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable.onDocumentAvailable):
2054         (WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable):
2055         (WebInspector.DOMAgent.prototype.cancelSearch):
2056         (WebInspector.DOMAgent.prototype.querySelector):
2057         (WebInspector.DOMAgent.prototype.querySelectorAll):
2058
2059 2011-04-01  Kent Tamura  <tkent@chromium.org>
2060
2061         Apply sort-Xcode-project-file.
2062
2063         * WebCore.xcodeproj/project.pbxproj:
2064
2065 2011-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
2066
2067         Unreviewed, rolling out r82652.
2068         http://trac.webkit.org/changeset/82652
2069         https://bugs.webkit.org/show_bug.cgi?id=57603
2070
2071         Test still fails (Requested by abarth|gardener on #webkit).
2072
2073         * rendering/RenderWidget.cpp:
2074         (WebCore::RenderWidget::setWidget):
2075
2076 2011-03-31  Naoki Takano  <takano.naoki@gmail.com>
2077
2078         Reviewed by Kent Tamura.
2079
2080         REGRESSION (r64712): Safari removes the first blank line in a textarea
2081         https://bugs.webkit.org/show_bug.cgi?id=56434
2082
2083         Test: fast/forms/textarea-newline.html
2084
2085         A linefeed removal after a textarea tag is originally processed in WebCore::HTMLTextAreaElement::defaultValue().
2086         But HTML5 tree builder now removes the linefeed. It means linefeed removal happens twice.
2087         And devalutValue() removal is not needed anymore.
2088
2089         * html/HTMLTextAreaElement.cpp:
2090         (WebCore::HTMLTextAreaElement::setDefaultValue): Remove an extra linefeed insertion at the beginning.
2091         (WebCore::HTMLTextAreaElement::defaultValue): Remove linefeed removal check in default value creation function.
2092
2093 2011-03-31  Luke Macpherson   <macpherson@chromium.org>
2094
2095         Reviewed by Dimitri Glazkov.
2096
2097         Remove refcounting of CSSStyleApplyProperty singleton
2098         https://bugs.webkit.org/show_bug.cgi?id=57592
2099
2100         No new tests required as no functionality changes.
2101
2102         * css/CSSStyleApplyProperty.h:
2103
2104 2011-03-31  Anantanarayanan G Iyengar  <ananta@chromium.org>
2105
2106         Reviewed by Adam Barth.
2107
2108         https://bugs.webkit.org/show_bug.cgi?id=45855
2109         Windowless plugins added dynamically to the DOM should receive paint events.
2110         This is done by ensuring that the plugin widget is marked for painting when
2111         it is added.
2112
2113         Test: plugins/windowless_plugin_paint_test.html
2114
2115         * rendering/RenderWidget.cpp:
2116         (WebCore::RenderWidget::setWidget):
2117
2118 2011-03-31  Adam Roben  <aroben@apple.com>
2119
2120         Add a new AbstractCACFLayerTreeHost base class
2121
2122         This class exposes the interface that LayerChangesFlusher and PlatformCALayer rely on.
2123         CACFLayerTreeHost now derives from AbstractCACFLayerTreeHost. In the future, WebKit2's
2124         LayerTreeHostCA will also derive from it (on Windows).
2125
2126         This should cause no change in behavior.
2127
2128         Fixes <http://webkit.org/b/57598> Coupling between CACFLayerTreeHost and other CACF-related
2129         code is too high
2130
2131         Reviewed by Anders Carlsson.
2132
2133         * WebCore.vcproj/WebCore.vcproj: Added AbstractCACFLayerTreeHost, and let VS reorder files.
2134
2135         * platform/graphics/ca/win/AbstractCACFLayerTreeHost.h: Added.
2136
2137         * platform/graphics/ca/win/CACFLayerTreeHost.h: Changed to derive from
2138         AbstractCACFLayerTreeHost, and annotated the overrides of its functions.
2139         AbstractCACFLayerTreeHost also allows us to get rid of the friend relationship with
2140         PlatformCALayer.
2141
2142         * platform/graphics/ca/win/LayerChangesFlusher.cpp:
2143         (WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon):
2144         (WebCore::LayerChangesFlusher::cancelPendingFlush):
2145         (WebCore::LayerChangesFlusher::hookFired):
2146         * platform/graphics/ca/win/LayerChangesFlusher.h:
2147         * platform/graphics/ca/win/PlatformCALayerWin.cpp:
2148         (layerTreeHostForLayer):
2149         (PlatformCALayer::rootLayer):
2150         (PlatformCALayer::setNeedsCommit):
2151         (PlatformCALayer::addAnimationForKey):
2152         (PlatformCALayer::removeAnimationForKey):
2153         Changed to use AbstractCACFLayerTreeHost instead of using CACFLayerTreeHost directly.
2154
2155 2011-03-31  Andy Estes  <aestes@apple.com>
2156
2157         Reviewed by Alexey Proskuryakov.
2158
2159         REGRESSION: Java applet fails to load when <object> has a classid attribute.
2160         https://bugs.webkit.org/show_bug.cgi?id=52703
2161         
2162         Java applets embedded with the object element sometimes use classid to
2163         specify their main resource. When this is done, the classid is prefixed
2164         with "java:". Treat these as supported classids in WebKit.
2165
2166         Test: java/embedding-java-with-object.html
2167
2168         * html/HTMLObjectElement.cpp:
2169         (WebCore::HTMLObjectElement::hasValidClassId): If the MIME type is a
2170         Java Applet type and the classid starts with "java:", the classid
2171         should be considered valid.
2172
2173 2011-03-31  Brent Fulgham  <bfulgham@webkit.org>
2174
2175         Reviewed Adam Roben.
2176
2177         [WinCairo] Implement Missing drawWindowsBitmap method.
2178         https://bugs.webkit.org/show_bug.cgi?id=57409
2179
2180         * WebCore.vcproj/WebCore.vcproj: Add new DIBPixelData files.
2181         * platform/graphics/GraphicsContext.h:
2182         (WebCore::GraphicsContext::WindowsBitmap::buffer):
2183         (WebCore::GraphicsContext::WindowsBitmap::bufferLength):
2184         (WebCore::GraphicsContext::WindowsBitmap::size):
2185         (WebCore::GraphicsContext::WindowsBitmap::bytesPerRow):
2186         (WebCore::GraphicsContext::WindowsBitmap::bitsPerPixel):
2187         (WebCore::GraphicsContext::WindowsBitmap::windowsDIB):
2188         * platform/graphics/win/GraphicsContextCGWin.cpp:
2189         (WebCore::CGContextWithHDC):
2190         (WebCore::GraphicsContext::releaseWindowsContext): Modified to use
2191         new common routines.
2192         * platform/graphics/win/GraphicsContextCairoWin.cpp:
2193         (WebCore::drawBitmapToContext): New common drawing implementation.
2194         (WebCore::GraphicsContext::releaseWindowsContext): Modified to use
2195         new common routines.
2196         (WebCore::GraphicsContext::drawWindowsBitmap):
2197         * platform/graphics/win/GraphicsContextWin.cpp:
2198         (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap): Modified
2199         to use new DIBPixelData data type.
2200         * platform/graphics/win/DIBPixelData.cpp: Added.
2201         (WebCore::DIBPixelData::DIBPixelData):
2202         (WebCore::DIBPixelData::initialize):
2203         * platform/graphics/win/DIBPixelData.h: Added.
2204         (WebCore::DIBPixelData::DIBPixelData):
2205         (WebCore::DIBPixelData::buffer):
2206         (WebCore::DIBPixelData::bufferLength):
2207         (WebCore::DIBPixelData::size):
2208         (WebCore::DIBPixelData::bytesPerRow):
2209         (WebCore::DIBPixelData::bitsPerPixel):
2210
2211 2011-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
2212
2213         Unreviewed, rolling out r81849.
2214         http://trac.webkit.org/changeset/81849
2215         https://bugs.webkit.org/show_bug.cgi?id=57588
2216
2217         CSS Parsing broke with -webkit-calc and introduced crashes
2218         (Requested by inferno-sec on #webkit).
2219
2220         * css/CSSGrammar.y:
2221         * css/CSSParserValues.cpp:
2222         * css/CSSParserValues.h:
2223         * css/tokenizer.flex:
2224
2225 2011-03-31  Adam Roben  <aroben@apple.com>
2226
2227         Don't ref CACFLayerTreeHosts when telling them to flush layer changes
2228
2229         LayerChangesFlusher was reffing CACFLayerTreeHosts before calling out to them. This would
2230         have protected us if calling out to one CACFLayerTreeHost could cause a different
2231         CACFLayerTreeHost to be destroyed. But that isn't possible; each CACFLayerTreeHost is
2232         associated with its own page, and flushing layer changes doesn't touch any other page. So it
2233         isn't possible for a CACFLayerTreeHost to be deleted while another one is flushing layer
2234         changes.
2235
2236         One benefit of this change is that it will make it easier to make LayerChangesFlusher
2237         interact with a forthcoming abstract base class, rather than with CACFLayerTreeHost itself.
2238
2239         This should cause no change in behavior.
2240
2241         Fixes <http://webkit.org/b/57590> LayerChangesFlusher unnecessarily refs CACFLayerTreeHost
2242         before calling out to it
2243
2244         Reviewed by Darin Adler.
2245
2246         * platform/graphics/ca/win/LayerChangesFlusher.cpp:
2247         (WebCore::LayerChangesFlusher::hookFired): Just store bare pointers to the
2248         CACFLayerTreeHosts.
2249
2250 2011-03-31  Antti Koivisto  <antti@apple.com>
2251
2252         Reviewed by Oliver Hunt.
2253
2254         https://bugs.webkit.org/show_bug.cgi?id=57574
2255         Preload scanner fails to pick up resources from document.write() output
2256
2257         - Scan script inserted source using a separate preload scanner.
2258         - Make the main preload scanner correctly process the remaining source if script execution blocked the parser.
2259
2260         Tests: fast/preloader/document-write-2.html
2261                fast/preloader/document-write.html
2262
2263         * html/parser/HTMLDocumentParser.cpp:
2264         (WebCore::HTMLDocumentParser::insert):
2265         (WebCore::HTMLDocumentParser::appendCurrentInputStreamToPreloadScannerAndScan):
2266         * html/parser/HTMLDocumentParser.h:
2267         (WebCore::HTMLDocumentParser::hasPreloadScanner):
2268         * html/parser/HTMLScriptRunner.cpp:
2269         (WebCore::HTMLScriptRunner::execute):
2270         * html/parser/HTMLScriptRunnerHost.h:
2271
2272 2011-03-31  Tony Gentilcore  <tonyg@chromium.org>
2273
2274         Build fix: Add missing include
2275         https://bugs.webkit.org/show_bug.cgi?id=57587
2276
2277         * loader/cache/CachedResourceLoader.cpp:
2278
2279 2011-03-31  Tony Gentilcore  <tonyg@chromium.org>
2280
2281         Reviewed by Antti Koivisto.
2282
2283         PreloadScanner doesn&apos;t find image while executing script in head
2284         https://bugs.webkit.org/show_bug.cgi?id=45072
2285
2286         Previously, while parsing the head, no resources in the body would be
2287         preloaded. After this patch, we will preload scripts and styles in the
2288         body, although we continue to hold off on all images until the page is 
2289         first rendered.
2290
2291         To evaluate this change, I've recorded a sampling of 45 of alexa's top
2292         sites and replayed them under simulated bandwidth conditions, loading
2293         each 5-15 times until stddev is small enough.
2294
2295         Time to the load event improved at the overall average by 3%.
2296         Most sites are unchanged, but sites with certain blocking patterns had
2297         big wins -- ebay 19% (331ms), microsoft 15% (226ms), conduit 15% (277ms)
2298         nytimes 7% (182ms).
2299
2300         Time to DOM content loaded event improved by 6% with some even bigger
2301         individual wins.
2302
2303         First paint time held steady.
2304
2305         Note that I originally wanted to allow preloading of images while in the
2306         head, but that regressed first paint time (even though it was better for
2307         overall load time).
2308
2309         Test: fast/preloader/scan-body-from-head.html
2310
2311         * loader/cache/CachedResourceLoader.cpp:
2312         (WebCore::CachedResourceLoader::preload):
2313
2314 2011-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
2315
2316         Unreviewed, rolling out r82616.
2317         http://trac.webkit.org/changeset/82616
2318         https://bugs.webkit.org/show_bug.cgi?id=57585
2319
2320         New test does not pass on Gtk, chromium-mac, chromium-linux
2321         and possibly elsewhere (Requested by abarth|gardener on
2322         #webkit).
2323
2324         * rendering/RenderWidget.cpp:
2325         (WebCore::RenderWidget::setWidget):
2326
2327 2011-03-31  Adrienne Walker  <enne@google.com>
2328
2329         Reviewed by James Robinson.
2330
2331         [chromium] Fix ownership semantics for LayerChromium/CCLayerImpl
2332         https://bugs.webkit.org/show_bug.cgi?id=57577
2333
2334         LayerRendererChromium now uses a RefPtr to preserve ownership of all
2335         of the CCLayerImpl layers that it is using during the update/draw
2336         pass.  Addtionally, when a LayerChromium is destroyed, the weak
2337         owner pointer from its CCLayerImpl is correctly unset.
2338
2339         * platform/graphics/chromium/LayerRendererChromium.cpp:
2340         (WebCore::LayerRendererChromium::compareLayerZ):
2341         (WebCore::LayerRendererChromium::updateAndDrawLayers):
2342         (WebCore::LayerRendererChromium::updateLayers):
2343         (WebCore::LayerRendererChromium::drawLayers):
2344         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
2345         (WebCore::LayerRendererChromium::drawLayer):
2346         * platform/graphics/chromium/LayerRendererChromium.h:
2347         * platform/graphics/chromium/RenderSurfaceChromium.h:
2348         * platform/graphics/chromium/VideoLayerChromium.cpp:
2349         (WebCore::VideoLayerChromium::updateCompositorResources):
2350         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
2351         (WebCore::CCLayerImpl::drawsContent):
2352         (WebCore::CCLayerImpl::cleanupResources):
2353
2354 2011-03-31  Sam Weinig  <sam@webkit.org>
2355
2356         Reviewed by Anders Carlsson.
2357
2358         Rename WebCore's UI_STRING to WEB_UI_STRING to not overlap with WebKit API
2359         https://bugs.webkit.org/show_bug.cgi?id=57582
2360
2361         * platform/DefaultLocalizationStrategy.cpp:
2362         * platform/LocalizedStrings.h:
2363
2364 2011-03-31  Eric Seidel  <eric@webkit.org>
2365
2366         Reviewed by Ryosuke Niwa.
2367
2368         Rename BidiResolver::lastBeforeET to m_lastBeforeET to match modern style
2369         https://bugs.webkit.org/show_bug.cgi?id=57550
2370
2371         * platform/text/BidiResolver.h:
2372         (WebCore::::createBidiRunsForLine):
2373
2374 2011-03-31  Anantanarayanan G Iyengar  <ananta@chromium.org>
2375
2376         Reviewed by James Robinson.
2377
2378         https://bugs.webkit.org/show_bug.cgi?id=45855
2379         Windowless plugins added dynamically to the DOM should receive paint events.
2380         This is done by ensuring that the plugin widget is marked for painting when
2381         it is added.
2382
2383         Test: plugins/windowless_plugin_paint_test.html
2384
2385         * rendering/RenderWidget.cpp:
2386         (WebCore::RenderWidget::setWidget):
2387
2388 2011-03-31  Stephen White  <senorblanco@chromium.org>
2389
2390         Reviewed by Kenneth Russell.
2391
2392         Speed up accelerated path drawing.
2393         https://bugs.webkit.org/show_bug.cgi?id=57371
2394         This CL does three things:  re-uses the same vertex and index buffer
2395         for all path draws, converts all vertex layouts from vec3 to vec2, and
2396         does a convexity check for polygons before passing them to the
2397         tesselator.
2398
2399         Covered by canvas/philip/tests/2d.path.bezierCurveTo.*, and others.
2400
2401         * platform/graphics/chromium/GLES2Canvas.cpp:
2402         Replace the Vector<double> for interpolated curves with a
2403         Vector<FloatPoint>.
2404         (WebCore::Cubic::evaluate):
2405         Inline the evaluation function (as Quadratic does).
2406         (WebCore::GLES2Canvas::GLES2Canvas):
2407         Initialize the m_pathIndexBuffer.
2408         (WebCore::GLES2Canvas::~GLES2Canvas):
2409         Delete the path vertex and index buffers on destruction.
2410         (WebCore::interpolateQuadratic):
2411         (WebCore::interpolateCubic):
2412         Interpolate directly to a Vector<FloatPoint>, rather than
2413         Vector<double>.
2414         (WebCore::PolygonData::PolygonData):
2415         (WebCore::combineData):
2416         Replace the DoubleVector with a FloatPointVector.
2417         (WebCore::GLES2Canvas::tesselateAndFillPath):
2418         Move curve drawing into this function, and rename it to reflect the
2419         new behaviour.  Re-use the common vertex and index buffers.  If the
2420         curve consists of a single convex polygon, draw the curve as a single
2421         triangle fan.  Otherwise, convert it to doubles and pass it to the
2422         tesselator.
2423         (WebCore::GLES2Canvas::fillPathInternal):
2424         * platform/graphics/chromium/GLES2Canvas.h:
2425         Rename createVertexBufferFromPath() -> tesselateAndFillPath().
2426         Add a persistent index buffer for all path draws.
2427         * platform/graphics/gpu/BicubicShader.cpp:
2428         (WebCore::BicubicShader::create):
2429         (WebCore::BicubicShader::use):
2430         * platform/graphics/gpu/ConvolutionShader.cpp:
2431         (WebCore::ConvolutionShader::create):
2432         (WebCore::ConvolutionShader::use):
2433         Use vec2s instead of vec3s for all vertex data.
2434         * platform/graphics/gpu/LoopBlinnMathUtils.cpp:
2435         (WebCore::LoopBlinnMathUtils::convexCompare):
2436         (WebCore::LoopBlinnMathUtils::convexCross):
2437         (WebCore::LoopBlinnMathUtils::convexCheckTriple):
2438         (WebCore::LoopBlinnMathUtils::isConvex):
2439         * platform/graphics/gpu/LoopBlinnMathUtils.h:
2440         Implement a convexity check, based on the code in Graphics Gems IV.
2441         * platform/graphics/gpu/Shader.cpp:
2442         (WebCore::Shader::generateVertex):
2443         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
2444         (WebCore::SharedGraphicsContext3D::useQuadVertices):
2445         * platform/graphics/gpu/SolidFillShader.cpp:
2446         (WebCore::SolidFillShader::use):
2447         * platform/graphics/gpu/TexShader.cpp:
2448         (WebCore::TexShader::use):
2449         Use vec2s instead of vec3s for all vertex data.
2450
2451 2011-03-31  David Hyatt  <hyatt@apple.com>
2452
2453         Reviewed by Simon Fraser.
2454
2455         https://bugs.webkit.org/show_bug.cgi?id=57565
2456
2457         Optimize overflow computations on lines to avoid allocating RenderOverflows in nearly all cases and to avoid even having
2458         to check the line for overflow in the first place.
2459         
2460         For the purposes of overflow computation, an inline object's default containment box for overflow is now assumed to extend
2461         all the way from lineTop to lineBottom instead of snugly fitting the inline object's own block dimensions. This allows
2462         replaced objects to be inside spans without triggering overflow allocation.
2463         
2464         The overflow accessors on InlineFlowBox have been changed to require passing in the lineTop and lineBottom so that the block
2465         dimensions can be forced to those values. Because these values are checked during painting and hit testing of lines, the
2466         lineTop and lineBottom are now passed as arguments to the painting and hit testing functions to avoid repeatedly crawling
2467         back up to the root box to fetch them.
2468         
2469         Added a new boolean flag to all InlineBoxes, knownToHaveNoOverflow(), and optimized for common cases where no overflow can
2470         possibly be present.  When the bit is set, computeOverflow will just immediately return.
2471  
2472         This change speeds up line layout by ~10%.
2473
2474         * rendering/EllipsisBox.cpp:
2475         (WebCore::EllipsisBox::paint):
2476         (WebCore::EllipsisBox::nodeAtPoint):
2477         * rendering/EllipsisBox.h:
2478         * rendering/InlineBox.cpp:
2479         (WebCore::InlineBox::paint):
2480         (WebCore::InlineBox::nodeAtPoint):
2481         (WebCore::InlineBox::clearKnownToHaveNoOverflow):
2482         * rendering/InlineBox.h:
2483         (WebCore::InlineBox::InlineBox):
2484         (WebCore::InlineBox::logicalFrameRect):
2485         (WebCore::InlineBox::knownToHaveNoOverflow):
2486         * rendering/InlineFlowBox.cpp:
2487         (WebCore::InlineFlowBox::addToLine):
2488         (WebCore::InlineFlowBox::placeBoxesInInlineDirection):
2489         (WebCore::InlineFlowBox::placeBoxesInBlockDirection):
2490         (WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
2491         (WebCore::InlineFlowBox::addTextBoxVisualOverflow):
2492         (WebCore::InlineFlowBox::addReplacedChildOverflow):
2493         (WebCore::InlineFlowBox::computeOverflow):
2494         (WebCore::InlineFlowBox::setLayoutOverflow):
2495         (WebCore::InlineFlowBox::setVisualOverflow):
2496         (WebCore::InlineFlowBox::setOverflowFromLogicalRects):
2497         (WebCore::InlineFlowBox::nodeAtPoint):
2498         (WebCore::InlineFlowBox::paint):
2499         * rendering/InlineFlowBox.h:
2500         (WebCore::InlineFlowBox::layoutOverflowRect):
2501         (WebCore::InlineFlowBox::logicalLeftLayoutOverflow):
2502         (WebCore::InlineFlowBox::logicalRightLayoutOverflow):
2503         (WebCore::InlineFlowBox::logicalTopLayoutOverflow):
2504         (WebCore::InlineFlowBox::logicalBottomLayoutOverflow):
2505         (WebCore::InlineFlowBox::logicalLayoutOverflowRect):
2506         (WebCore::InlineFlowBox::visualOverflowRect):
2507         (WebCore::InlineFlowBox::logicalLeftVisualOverflow):
2508         (WebCore::InlineFlowBox::logicalRightVisualOverflow):
2509         (WebCore::InlineFlowBox::logicalTopVisualOverflow):
2510         (WebCore::InlineFlowBox::logicalBottomVisualOverflow):
2511         (WebCore::InlineFlowBox::logicalVisualOverflowRect):
2512         (WebCore::InlineFlowBox::frameRectIncludingLineHeight):
2513         (WebCore::InlineFlowBox::logicalFrameRectIncludingLineHeight):
2514         * rendering/InlineTextBox.cpp:
2515         (WebCore::InlineTextBox::nodeAtPoint):
2516         (WebCore::InlineTextBox::paint):
2517         * rendering/InlineTextBox.h:
2518         * rendering/RenderBlock.cpp:
2519         (WebCore::RenderBlock::simplifiedNormalFlowLayout):
2520         (WebCore::RenderBlock::paintEllipsisBoxes):
2521         (WebCore::RenderBlock::adjustLinePositionForPagination):
2522         * rendering/RenderBlock.h:
2523         * rendering/RenderBlockLineLayout.cpp:
2524         (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
2525         (WebCore::RenderBlock::layoutInlineChildren):
2526         (WebCore::RenderBlock::determineStartPosition):
2527         (WebCore::RenderBlock::matchedEndLine):
2528         (WebCore::RenderBlock::addOverflowFromInlineChildren):
2529         * rendering/RenderBox.h:
2530         (WebCore::RenderBox::hasRenderOverflow):
2531         * rendering/RenderBoxModelObject.cpp:
2532         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
2533         * rendering/RenderInline.cpp:
2534         (WebCore::RenderInline::linesVisualOverflowBoundingBox):
2535         * rendering/RenderLineBoxList.cpp:
2536         (WebCore::RenderLineBoxList::anyLineIntersectsRect):
2537         (WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
2538         (WebCore::RenderLineBoxList::paint):
2539         (WebCore::RenderLineBoxList::hitTest):
2540         * rendering/RenderListItem.cpp:
2541         (WebCore::RenderListItem::positionListMarker):
2542         * rendering/RootInlineBox.cpp:
2543         (WebCore::RootInlineBox::paintEllipsisBox):
2544         (WebCore::RootInlineBox::addHighlightOverflow):
2545         (WebCore::RootInlineBox::paint):
2546         (WebCore::RootInlineBox::nodeAtPoint):
2547         (WebCore::RootInlineBox::paddedLayoutOverflowRect):
2548         * rendering/RootInlineBox.h:
2549         (WebCore::RootInlineBox::logicalTopVisualOverflow):
2550         (WebCore::RootInlineBox::logicalBottomVisualOverflow):
2551         (WebCore::RootInlineBox::logicalTopLayoutOverflow):
2552         (WebCore::RootInlineBox::logicalBottomLayoutOverflow):
2553         * rendering/svg/SVGInlineFlowBox.cpp:
2554         (WebCore::SVGInlineFlowBox::paint):
2555         * rendering/svg/SVGInlineFlowBox.h:
2556         * rendering/svg/SVGInlineTextBox.cpp:
2557         (WebCore::SVGInlineTextBox::paint):
2558         * rendering/svg/SVGInlineTextBox.h:
2559         * rendering/svg/SVGRootInlineBox.cpp:
2560         (WebCore::SVGRootInlineBox::paint):
2561         * rendering/svg/SVGRootInlineBox.h:
2562
2563 2011-03-31  Pavel Feldman  <pfeldman@chromium.org>
2564
2565         Reviewed by Yury Semikhatsky.
2566
2567         Web Inspector: disable properties abbreviation.
2568         https://bugs.webkit.org/show_bug.cgi?id=57525
2569
2570         * inspector/InjectedScript.cpp:
2571         (WebCore::InjectedScript::getProperties):
2572         * inspector/InjectedScript.h:
2573         * inspector/InjectedScriptSource.js:
2574         (.):
2575         ():
2576         * inspector/Inspector.json:
2577         * inspector/InspectorRuntimeAgent.cpp:
2578         (WebCore::InspectorRuntimeAgent::getProperties):
2579         * inspector/InspectorRuntimeAgent.h:
2580         * inspector/front-end/ConsoleView.js:
2581         (WebInspector.ConsoleView.prototype.completions.evaluated):
2582         (WebInspector.ConsoleView.prototype._formatarray):
2583         * inspector/front-end/ObjectPropertiesSection.js:
2584         (WebInspector.ObjectPropertiesSection.prototype.update.callback):
2585         (WebInspector.ObjectPropertiesSection.prototype.update):
2586         (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
2587         (WebInspector.ObjectPropertyTreeElement.prototype.update):
2588         (WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
2589         * inspector/front-end/PropertiesSidebarPane.js:
2590         (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
2591         * inspector/front-end/RemoteObject.js:
2592         (WebInspector.RemoteObject.prototype.getOwnProperties):
2593         (WebInspector.RemoteObject.prototype.getAllProperties):
2594         (WebInspector.RemoteObject.prototype._getProperties):
2595         (WebInspector.LocalJSONObject.prototype.getOwnProperties):
2596         (WebInspector.LocalJSONObject.prototype.getAllProperties):
2597         * inspector/front-end/inspector.css:
2598         (.console-formatted-string, .console-formatted-regexp):
2599
2600 2011-03-31  Adam Roben  <aroben@apple.com>
2601
2602         Update WKCACFViewLayerTreeHost for changes to WKCACFView API
2603
2604         This should not result in any change in behavior.
2605
2606         Fixes <http://webkit.org/b/57560> WKCACFViewLayerTreeHost needs to tell WKCACFView where to
2607         render
2608
2609         Reviewed by Darin Adler.
2610
2611         * platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp: Updated API declarations.
2612         (WebCore::WKCACFViewLayerTreeHost::WKCACFViewLayerTreeHost): Tell WKCACFView it should
2613         render into the window we give it.
2614
2615 2011-03-31  Marius Storm-Olsen  <marius.storm-olsen@nokia.com>
2616
2617         Reviewed by Kenneth Rohde Christiansen.
2618
2619         [Qt] Properly detect phonon include, and avoid double qtLibraryTarget() call
2620         https://bugs.webkit.org/show_bug.cgi?id=57017
2621
2622         Build fix. No new tests.
2623
2624         * WebCore.pri:
2625
2626 2011-03-31  Vsevolod Vlasov  <vsevik@chromium.org>
2627
2628         Reviewed by Pavel Feldman.
2629
2630         XML viewer is not shown when frame has non-null opener
2631         https://bugs.webkit.org/show_bug.cgi?id=56384
2632
2633         Removed opener check in XML viewer
2634
2635         Test: http/tests/xmlviewer/extensions-api.html
2636
2637         * xml/XMLTreeViewer.cpp:
2638         (WebCore::XMLTreeViewer::hasNoStyleInformation):
2639         * xml/XMLViewer.js:
2640
2641 2011-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
2642
2643         Unreviewed, rolling out r82589.
2644         http://trac.webkit.org/changeset/82589
2645         https://bugs.webkit.org/show_bug.cgi?id=57564
2646
2647         This patch requires many more updated results than it contains
2648         (Requested by abarth|gardener on #webkit).
2649
2650         * css/CSSSelector.cpp:
2651         (WebCore::CSSSelector::pseudoId):
2652         (WebCore::nameToPseudoTypeMap):
2653         (WebCore::CSSSelector::extractPseudoType):
2654         * css/CSSSelector.h:
2655         * css/html.css:
2656         (meter::-webkit-meter-horizontal-bar):
2657         (meter::-webkit-meter-vertical-bar):
2658         (meter::-webkit-meter-horizontal-optimum-value):
2659         (meter::-webkit-meter-horizontal-suboptimal-value):
2660         (meter::-webkit-meter-horizontal-even-less-good-value):
2661         (meter::-webkit-meter-vertical-optimum-value):
2662         (meter::-webkit-meter-vertical-suboptimal-value):
2663         (meter::-webkit-meter-vertical-even-less-good-value):
2664         * rendering/RenderMeter.cpp:
2665         (WebCore::MeterPartElement::MeterPartElement):
2666         (WebCore::MeterPartElement::createForPart):
2667         (WebCore::MeterPartElement::hide):
2668         (WebCore::MeterPartElement::restoreVisibility):
2669         (WebCore::MeterPartElement::updateStyleForPart):
2670         (WebCore::MeterPartElement::saveVisibility):
2671         (WebCore::RenderMeter::~RenderMeter):
2672         (WebCore::RenderMeter::createPart):
2673         (WebCore::RenderMeter::updateFromElement):
2674         (WebCore::RenderMeter::layoutParts):
2675         (WebCore::RenderMeter::shouldHaveParts):
2676         (WebCore::RenderMeter::valuePartRect):
2677         (WebCore::RenderMeter::orientation):
2678         (WebCore::RenderMeter::valuePseudoId):
2679         (WebCore::RenderMeter::barPseudoId):
2680         * rendering/RenderMeter.h:
2681         (WebCore::RenderMeter::shadowAttached):
2682         * rendering/RenderTheme.cpp:
2683         (WebCore::RenderTheme::supportsMeter):
2684         * rendering/RenderTheme.h:
2685         * rendering/RenderThemeMac.h:
2686         * rendering/RenderThemeMac.mm:
2687         (WebCore::RenderThemeMac::paintMeter):
2688         (WebCore::RenderThemeMac::supportsMeter):
2689         * rendering/style/RenderStyleConstants.h:
2690
2691 2011-03-31  Xan Lopez  <xlopez@igalia.com>
2692
2693         Reviewed by Martin Robinson.
2694
2695         [GTK] Link explicitly with XRender on Linux/Unix
2696         https://bugs.webkit.org/show_bug.cgi?id=57558
2697
2698         * GNUmakefile.am: add XRender CFLAGS.
2699
2700 2011-03-31  Eric Seidel  <eric@webkit.org>
2701
2702         Reviewed by Ryosuke Niwa.
2703
2704         Rename BidiResolver::emptyRun to m_emtpyRun to match modern style
2705         https://bugs.webkit.org/show_bug.cgi?id=57549
2706
2707         * platform/text/BidiResolver.h:
2708         (WebCore::BidiResolver::BidiResolver):
2709         (WebCore::::appendRun):
2710         (WebCore::::lowerExplicitEmbeddingLevel):
2711         (WebCore::::raiseExplicitEmbeddingLevel):
2712         (WebCore::::deleteRuns):
2713         (WebCore::::createBidiRunsForLine):
2714         * rendering/InlineIterator.h:
2715         (WebCore::InlineBidiResolver::appendRun):
2716
2717 2011-03-31  Tom Sepez  <tsepez@chromium.org>
2718
2719         Reviewed by Eric Seidel.
2720
2721         Make ContainerNode::insertIntoDocument() collect all nodes before
2722         operating on any of them.  Add small helper function and use it
2723         througout the file where this action is already taking place.
2724         https://bugs.webkit.org/show_bug.cgi?id=57265
2725         
2726         Test: svg/dom/range-delete.html
2727
2728         * dom/ContainerNode.cpp:
2729         (WebCore::collectNodes):
2730         (WebCore::collectTargetNodes):
2731         (WebCore::ContainerNode::takeAllChildrenFrom):
2732         (WebCore::willRemoveChildren):
2733         (WebCore::ContainerNode::insertedIntoDocument):
2734
2735 2011-03-31  Satish Sampath  <satish@chromium.org>
2736
2737         Reviewed by Steve Block.
2738
2739         While drawing a speech input button, validate that the node is really a speech input button.
2740         https://bugs.webkit.org/show_bug.cgi?id=57469
2741
2742         Test: fast/speech/speech-style-on-non-speech-elements.html
2743
2744         * dom/Element.h:
2745         (WebCore::Element::isInputFieldSpeechButtonElement):
2746         * html/shadow/TextControlInnerElements.h:
2747         (WebCore::InputFieldSpeechButtonElement::isInputFieldSpeechButtonElement):
2748         (WebCore::toInputFieldSpeechButtonElement):
2749         * rendering/RenderInputSpeech.cpp:
2750         (WebCore::RenderInputSpeech::paintInputFieldSpeechButton):
2751
2752 2011-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2753
2754         Build fix after r82588. Reverted unintentional change.
2755
2756         * editing/SelectionController.cpp:
2757         (WebCore::SelectionController::modifyMovingLeft):
2758
2759 2011-03-31  Mario Sanchez Prada  <msanchez@igalia.com>
2760
2761         Reviewed by Xan Lopez.
2762
2763         [GTK] Warnings happening because of unhandled switch cases in AccessibilityObjectWrapperAtk
2764         https://bugs.webkit.org/show_bug.cgi?id=57534
2765
2766         Fix compilation warnings.
2767
2768         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2769         (getAttributeSetForAccessibilityObject): Add unhandled cases.
2770
2771 2011-03-30  Pavel Podivilov  <podivilov@chromium.org>
2772
2773         Reviewed by Pavel Feldman.
2774
2775         Web Inspector: remove unnecessary newBody output parameter from editScriptSource protocol method.
2776         https://bugs.webkit.org/show_bug.cgi?id=57444
2777
2778         * bindings/js/ScriptDebugServer.cpp:
2779         (WebCore::ScriptDebugServer::editScriptSource):
2780         * bindings/js/ScriptDebugServer.h:
2781         * bindings/v8/ScriptDebugServer.cpp:
2782         (WebCore::ScriptDebugServer::editScriptSource):
2783         * bindings/v8/ScriptDebugServer.h:
2784         * inspector/Inspector.json:
2785         * inspector/InspectorDebuggerAgent.cpp:
2786         (WebCore::InspectorDebuggerAgent::editScriptSource):
2787         * inspector/InspectorDebuggerAgent.h:
2788         * inspector/front-end/DebuggerModel.js:
2789         (WebInspector.DebuggerModel.prototype.editScriptSource):
2790         (WebInspector.DebuggerModel.prototype._didEditScriptSource):
2791         * inspector/front-end/DebuggerPresentationModel.js:
2792         (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource):
2793         (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
2794         * inspector/front-end/SourceFrame.js:
2795         (WebInspector.SourceFrame.prototype._handleSave.didEditScriptSource):
2796         (WebInspector.SourceFrame.prototype._handleSave):
2797
2798 2011-03-30  MORITA Hajime <morrita@google.com>
2799
2800         Reviewed by Dimitri Glazkov.
2801
2802         <meter> can only support horizontal indicator
2803         https://bugs.webkit.org/show_bug.cgi?id=56001
2804
2805         - Removed code which deals with the direction and
2806           left the horizontal path.
2807         - Removed "horizontal" from related names which is now
2808           redundant.
2809         
2810         * css/CSSSelector.cpp:
2811         (WebCore::CSSSelector::pseudoId):
2812         (WebCore::nameToPseudoTypeMap):
2813         (WebCore::CSSSelector::extractPseudoType):
2814         * css/CSSSelector.h:
2815         * css/html.css:
2816         (meter::-webkit-meter-bar):
2817         (meter::-webkit-meter-optimum-value):
2818         (meter::-webkit-meter-suboptimal-value):
2819         (meter::-webkit-meter-even-less-good-value):
2820         * rendering/RenderMeter.cpp:
2821         (WebCore::RenderMeter::~RenderMeter):
2822         (WebCore::RenderMeter::createPart):
2823         (WebCore::RenderMeter::updateFromElement):
2824         (WebCore::RenderMeter::layoutParts):
2825         (WebCore::RenderMeter::styleDidChange):
2826         (WebCore::RenderMeter::shouldHaveParts):
2827         (WebCore::RenderMeter::valuePartRect):
2828         (WebCore::RenderMeter::valuePseudoId):
2829         (WebCore::RenderMeter::barPseudoId):
2830         (WebCore::RenderMeter::detachShadows):
2831         (WebCore::RenderMeter::updateShadows):
2832         * rendering/RenderMeter.h:
2833         (WebCore::RenderMeter::shadowAttached):
2834         * rendering/RenderTheme.cpp:
2835         (WebCore::RenderTheme::supportsMeter):
2836         * rendering/RenderTheme.h:
2837         * rendering/RenderThemeMac.h:
2838         * rendering/RenderThemeMac.mm:
2839         (WebCore::RenderThemeMac::paintMeter):
2840         (WebCore::RenderThemeMac::supportsMeter):
2841         * rendering/style/RenderStyleConstants.h:
2842
2843 2011-03-30  Xiaomei Ji  <xji@chromium.org>
2844
2845         Reviewed by Ryosuke Niwa.
2846
2847         Experiment with moving caret by word in visual order.
2848         https://bugs.webkit.org/show_bug.cgi?id=57336
2849
2850         Follow Firefox's convention in Windows, 
2851         In LTR block, word break visually moves cursor to the left boundary of words,
2852         In RTL block, word break visually moves cursor to the right boundary of words.
2853
2854         This is the 1st version of implementing "move caret by word in visual order".
2855         It only works in the following situation:
2856         1. For a LTR box in a LTR block or a RTL box in RTL block, 
2857         when caret is at the left boundary of the box and we are looking for 
2858         the word boundary in right.
2859         2. For a LTR or RTL box in a LTR block, when caret is at the left boundary
2860         of the box and we are looking for the word boundary in left and 
2861         previous box is a LTR box.
2862         3. For a LTR or RTL box in a RTL block, when the caret is at the right 
2863         boundary of the box and we are looking for the word boundary in right and next box is RTL box.
2864
2865         An experimental granularity is introduced, as a side effect, functions having switch statements
2866         to handle those granularities have to add more one case to handle this new granularity.
2867         The experimental granularity is exposed though JS by '-webkit-visual-word".
2868
2869         The overall algorithm is looping through inline boxes visually and looking
2870         for the visually nearest word break position. 
2871
2872         Test: editing/selection/move-by-word-visually.html
2873
2874         * editing/SelectionController.cpp:
2875         (WebCore::SelectionController::modifyExtendingRight):
2876         (WebCore::SelectionController::modifyExtendingForward):
2877         (WebCore::SelectionController::modifyMovingRight):
2878         (WebCore::SelectionController::modifyMovingForward):
2879         (WebCore::SelectionController::modifyExtendingLeft):
2880         (WebCore::SelectionController::modifyExtendingBackward):
2881         (WebCore::SelectionController::modifyMovingLeft):
2882         (WebCore::SelectionController::modifyMovingBackward):
2883         * editing/TextGranularity.h:
2884         * editing/VisibleSelection.cpp:
2885         (WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
2886         * editing/visible_units.cpp:
2887         (WebCore::previousWordBreakInBoxInsideBlockWithSameDirectionality):
2888         (WebCore::wordBoundaryInBox):
2889         (WebCore::wordBoundaryInAdjacentBoxes):
2890         (WebCore::leftWordBoundary):
2891         (WebCore::rightWordBoundary):
2892         (WebCore::leftWordPosition):
2893         (WebCore::rightWordPosition):
2894         * editing/visible_units.h:
2895         * page/DOMSelection.cpp:
2896         (WebCore::DOMSelection::modify):
2897
2898 2011-03-31  Dimitri Glazkov  <dglazkov@chromium.org>
2899
2900         Reviewed by Darin Adler.
2901
2902         Move coordinate-computing logic into MouseRelatedEvent.
2903         https://bugs.webkit.org/show_bug.cgi?id=57521
2904
2905         Refactoring, covered by existing tests.
2906
2907         * dom/EventDispatcher.cpp:
2908         (WebCore::EventDispatcher::dispatchWheelEvent): Yank calculation of
2909             coordinates out.
2910         (WebCore::EventDispatcher::dispatchMouseEvent): Ditto.
2911         * dom/MouseEvent.cpp:
2912         (WebCore::MouseEvent::create): Add coordinate-computing logic.
2913         * dom/MouseEvent.h: Adjust decl to reflect new meaning of params.
2914         * dom/MouseRelatedEvent.cpp:
2915         (WebCore::MouseRelatedEvent::MouseRelatedEvent): Ditto.
2916         * page/EventHandler.cpp:
2917         (WebCore::EventHandler::dispatchDragEvent): Ditto.
2918
2919 2011-03-30  Alexander Pavlov  <apavlov@chromium.org>
2920
2921         Reviewed by Pavel Feldman.
2922
2923         Web Inspector: document CSS agent.
2924         https://bugs.webkit.org/show_bug.cgi?id=57435
2925
2926         * inspector/Inspector.json:
2927
2928 2011-03-31  Andrey Kosyakov  <caseq@chromium.org>
2929
2930         Reviewed by Yury Semikhatsky.
2931
2932         Web Inspector: remove periods at the end of error messages
2933         https://bugs.webkit.org/show_bug.cgi?id=57544
2934
2935         * inspector/InjectedScript.cpp:
2936         (WebCore::InjectedScript::getProperties):
2937         (WebCore::InjectedScript::makeObjectCall):
2938         * inspector/InspectorCSSAgent.cpp:
2939         (WebCore::InspectorCSSAgent::elementForId):
2940         (WebCore::InspectorCSSAgent::styleSheetForId):
2941         * inspector/InspectorDOMAgent.cpp:
2942         (WebCore::InspectorDOMAgent::assertNode):
2943         (WebCore::InspectorDOMAgent::assertElement):
2944         (WebCore::InspectorDOMAgent::assertHTMLElement):
2945         (WebCore::InspectorDOMAgent::querySelector):
2946         (WebCore::InspectorDOMAgent::querySelectorAll):
2947         (WebCore::InspectorDOMAgent::setAttribute):
2948         (WebCore::InspectorDOMAgent::removeAttribute):
2949         (WebCore::InspectorDOMAgent::removeNode):
2950         (WebCore::InspectorDOMAgent::setNodeValue):
2951         * inspector/InspectorDebuggerAgent.cpp:
2952         (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
2953         * inspector/InspectorResourceAgent.cpp:
2954         (WebCore::InspectorResourceAgent::resourceContent):
2955         (WebCore::InspectorResourceAgent::resourceContentBase64):
2956         (WebCore::InspectorResourceAgent::getResourceContent):
2957         * inspector/InspectorRuntimeAgent.cpp:
2958         (WebCore::InspectorRuntimeAgent::setPropertyValue):
2959
2960 2011-03-31  Evan Martin  <evan@chromium.org>
2961
2962         Reviewed by Eric Seidel.
2963
2964         <title> should support dir attribute
2965         https://bugs.webkit.org/show_bug.cgi?id=50961
2966
2967         Introduce a new StringWithDirection object that carries a String along
2968         with the TextDirection associated with the String.  Use this object for
2969         document titles used within WebCore, because in HTML the direction of
2970         a title can be set with the 'dir' attribute.
2971
2972         Put FIXMEs at the WebKit level to expose the new direction information
2973         to clients.
2974
2975         No behavioral change intended, so no new tests.  A follow-up will expose
2976         the title direction and hopefully can be accompanied by tests that
2977         verify it is correct.
2978
2979         * dom/Document.cpp:
2980         (WebCore::Document::Document):
2981         (WebCore::Document::updateTitle):
2982         (WebCore::Document::setTitle):
2983         (WebCore::Document::removeTitle):
2984         * dom/Document.h:
2985         (WebCore::Document::title):
2986         * html/HTMLTitleElement.cpp:
2987         (WebCore::HTMLTitleElement::HTMLTitleElement):
2988         (WebCore::HTMLTitleElement::childrenChanged):
2989         (WebCore::HTMLTitleElement::text):
2990         (WebCore::HTMLTitleElement::textWithDirection):
2991         * html/HTMLTitleElement.h:
2992         * loader/DocumentLoader.cpp:
2993         (WebCore::DocumentLoader::setTitle):
2994         * loader/DocumentLoader.h:
2995         (WebCore::DocumentLoader::title):
2996         * loader/EmptyClients.h:
2997         (WebCore::EmptyFrameLoaderClient::dispatchDidReceiveTitle):
2998         (WebCore::EmptyFrameLoaderClient::setTitle):
2999         * loader/FrameLoader.cpp:
3000         (WebCore::FrameLoader::receivedFirstData):
3001         (WebCore::FrameLoader::commitProvisionalLoad):
3002         (WebCore::FrameLoader::setTitle):
3003         * loader/FrameLoader.h:
3004         * loader/FrameLoaderClient.h:
3005         * loader/HistoryController.cpp:
3006         (WebCore::HistoryController::updateForBackForwardNavigation):
3007         (WebCore::HistoryController::updateForReload):
3008         (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
3009         (WebCore::HistoryController::updateForClientRedirect):
3010         (WebCore::HistoryController::updateForCommit):
3011         (WebCore::HistoryController::setCurrentItemTitle):
3012         (WebCore::HistoryController::initializeItem):
3013         * loader/HistoryController.h:
3014         * platform/text/StringWithDirection.h: Added.
3015         (WebCore::StringWithDirection::StringWithDirection):
3016         (WebCore::StringWithDirection::operator==):
3017         (WebCore::StringWithDirection::operator!=):
3018         * svg/SVGTitleElement.cpp:
3019         (WebCore::SVGTitleElement::insertedIntoDocument):
3020         (WebCore::SVGTitleElement::childrenChanged):
3021
3022 2011-03-31  Alexander Pavlov  <apavlov@chromium.org>
3023
3024         Reviewed by Yury Semikhatsky.
3025
3026         Web Inspector: CSS domain - make a "range" object, get rid of "properties" object for Style objects
3027         https://bugs.webkit.org/show_bug.cgi?id=57538
3028
3029         * inspector/InspectorStyleSheet.cpp:
3030         (WebCore::buildSourceRangeObject):
3031         (WebCore::InspectorStyle::buildObjectForStyle):
3032         (WebCore::InspectorStyle::populateObjectWithStyleProperties):
3033         * inspector/front-end/AuditRules.js:
3034         (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
3035         * inspector/front-end/CSSStyleModel.js:
3036         (WebInspector.CSSStyleDeclaration):
3037
3038 2011-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
3039
3040         Unreviewed, rolling out r82565.
3041         http://trac.webkit.org/changeset/82565
3042         https://bugs.webkit.org/show_bug.cgi?id=57541
3043
3044         Caused assertion failures. (Requested by bbandix on #webkit).
3045
3046         * platform/graphics/filters/FEFlood.cpp:
3047         (WebCore::FEFlood::setFloodColor):
3048         (WebCore::FEFlood::setFloodOpacity):
3049         * platform/graphics/filters/FEFlood.h:
3050         * platform/graphics/filters/FESpecularLighting.cpp:
3051         (WebCore::FESpecularLighting::setLightingColor):
3052         * platform/graphics/filters/FESpecularLighting.h:
3053         * rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
3054         * rendering/svg/RenderSVGResourceFilterPrimitive.h:
3055         * rendering/svg/SVGResourcesCache.cpp:
3056         (WebCore::SVGResourcesCache::clientStyleChanged):
3057         * svg/SVGFEDiffuseLightingElement.cpp:
3058         (WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
3059         * svg/SVGFEFloodElement.cpp:
3060         * svg/SVGFEFloodElement.h:
3061         * svg/SVGFESpecularLightingElement.cpp:
3062         (WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute):
3063
3064 2011-03-31  Renata Hodovan  <reni@webkit.org>
3065
3066         Reviewed by Dirk Schulze.
3067
3068         CSS related SVG*Element changes doesn't require relayout
3069         https://bugs.webkit.org/show_bug.cgi?id=56906
3070
3071         The changes of some CSS related SVGFilter properties e.g. lighting-color, flood-color, flood-opacity
3072         need only repaint. To avoid the default invalidation of filters in SVGResourceCache::clientStyleChange()
3073         we need an early return. So RenderSVGResourceFilterPrimitive::styleDidChange() can handle these properties
3074         via RenderSVGResourceFilter::primitiveAttributeChanged() the same way like we do it for the other SVGAttributes.
3075
3076         Tests: svg/dynamic-updates/SVGFEDiffuseLightingElement-inherit-lighting-color-css-prop.html
3077                svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color.html
3078                svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop.html
3079                svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop.html
3080
3081         * platform/graphics/filters/FEFlood.cpp:
3082         (WebCore::FEFlood::setFloodColor):
3083         (WebCore::FEFlood::setFloodOpacity):
3084         * platform/graphics/filters/FEFlood.h:
3085         * platform/graphics/filters/FESpecularLighting.cpp:
3086         (WebCore::FESpecularLighting::setLightingColor):
3087         * platform/graphics/filters/FESpecularLighting.h:
3088         * rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
3089         (WebCore::RenderSVGResourceFilterPrimitive::styleDidChange):
3090         * rendering/svg/RenderSVGResourceFilterPrimitive.h:
3091         * rendering/svg/SVGResourcesCache.cpp:
3092         (WebCore::SVGResourcesCache::clientStyleChanged):
3093         * svg/SVGFEDiffuseLightingElement.cpp:
3094         (WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
3095         * svg/SVGFEFloodElement.cpp:
3096         (WebCore::SVGFEFloodElement::setFilterEffectAttribute):
3097         * svg/SVGFEFloodElement.h:
3098         * svg/SVGFESpecularLightingElement.cpp:
3099         (WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute):
3100
3101 2011-03-29  Vsevolod Vlasov  <vsevik@chromium.org>
3102
3103         Reviewed by Pavel Feldman.
3104
3105         XML Viewer: declared namespaces are not rendered.
3106         https://bugs.webkit.org/show_bug.cgi?id=56262
3107
3108         XML viewer rewritten on javascript.
3109
3110         * CMakeLists.txt:
3111         * DerivedSources.make:
3112         * GNUmakefile.am:
3113         * WebCore.gyp/WebCore.gyp:
3114         * WebCore.gypi:
3115         * WebCore.vcproj/WebCore.vcproj:
3116         * WebCore.xcodeproj/project.pbxproj:
3117         * dom/XMLDocumentParserLibxml2.cpp:
3118         (WebCore::XMLDocumentParser::doEnd):
3119         * xml/XMLTreeViewer.cpp:
3120         (WebCore::XMLTreeViewer::transformDocumentToTreeView):
3121         * xml/XMLViewer.css: Added.
3122         * xml/XMLViewer.js: Added.
3123         * xml/XMLViewer.xsl: Removed.
3124         * xml/XSLStyleSheet.h:
3125
3126 2011-03-31  Jaehun Lim  <ljaehun.lim@samsung.com>
3127
3128         Unreviewed build fix.
3129
3130         Fix build break after rolling out r82496
3131         https://bugs.webkit.org/show_bug.cgi?id=57536
3132
3133         * platform/efl/RenderThemeEfl.cpp:
3134
3135 2011-03-31  Andrey Adaikin  <aandrey@google.com>
3136
3137         Reviewed by Pavel Feldman.
3138
3139         Web Inspector: execution line is displayed incorrectly after source editing.
3140         https://bugs.webkit.org/show_bug.cgi?id=57229
3141
3142         * inspector/front-end/SourceFrame.js:
3143         (WebInspector.SourceFrame.prototype._saveViewerState):
3144         (WebInspector.SourceFrame.prototype._restoreViewerState):
3145         (WebInspector.SourceFrame.prototype._startEditing):
3146         (WebInspector.SourceFrame.prototype._endEditing):
3147         (WebInspector.SourceFrame.prototype._createTextViewer):
3148         (WebInspector.SourceFrame.prototype.setExecutionLine):
3149         (WebInspector.SourceFrame.prototype._handleSave.didEditScriptSource):
3150         (WebInspector.SourceFrame.prototype._handleSave):
3151         (WebInspector.SourceFrame.prototype._handleRevertEditing):
3152         * inspector/front-end/TextViewer.js:
3153         (WebInspector.TextEditorChunkedPanel.prototype.addDecoration):
3154         (WebInspector.TextEditorChunkedPanel.prototype.removeDecoration):
3155         (WebInspector.TextEditorMainPanel.prototype.makeLineAChunk):
3156         (WebInspector.TextEditorMainPanel.prototype._positionToSelection):
3157
3158 2011-03-30  Alexander Pavlov  <apavlov@chromium.org>
3159
3160         Reviewed by Pavel Feldman.
3161
3162         Web Inspector: Make the CSStyle "shorthandValues" name-value map an array
3163         https://bugs.webkit.org/show_bug.cgi?id=57452
3164
3165         No new tests, as this is a refactoring.
3166
3167         * inspector/InspectorCSSAgent.cpp:
3168         * inspector/InspectorStyleSheet.cpp:
3169         (WebCore::InspectorStyle::populateObjectWithStyleProperties):
3170         * inspector/front-end/CSSStyleModel.js:
3171         (WebInspector.CSSStyleDeclaration):
3172         (WebInspector.CSSStyleDeclaration.buildShorthandValueMap):
3173
3174 2011-03-30  Steve Block  <steveblock@google.com>
3175
3176         Reviewed by Jeremy Orlow.
3177
3178         JavaField should not expose JavaString in its API
3179         https://bugs.webkit.org/show_bug.cgi?id=55766
3180
3181         This patch fixes JavaField for V8 only.
3182         - Factors out a JavaField interface which does not use JNI types.
3183           This will allow the Java bridge to be used with objects that
3184           don't use JNI directly. The existing jobject-backed
3185           implementation is moved to a new JavaFieldJobject class which
3186           implements the interface.
3187         - Use WTF::String in place of JavaString in the API, as JavaString
3188           exposes JNI types in its interface.
3189
3190         No new tests, refactoring only.
3191
3192         * Android.v8bindings.mk:
3193         * WebCore.gypi:
3194         * bridge/jni/JavaMethod.h:
3195         (JSC::Bindings::JavaMethod::~JavaMethod):
3196         * bridge/jni/JobjectWrapper.h:
3197         * bridge/jni/v8/JavaClassV8.cpp:
3198         (JavaClass::JavaClass):
3199         * bridge/jni/v8/JavaFieldJobjectV8.cpp:
3200         (JavaFieldJobject::JavaFieldJobject):
3201         * bridge/jni/v8/JavaFieldJobjectV8.h:
3202         (JSC::Bindings::JavaFieldJobject::name):
3203         (JSC::Bindings::JavaFieldJobject::typeClassName):
3204         (JSC::Bindings::JavaFieldJobject::type):
3205         * bridge/jni/v8/JavaFieldV8.h:
3206         (JSC::Bindings::JavaField::~JavaField):
3207         * bridge/jni/v8/JavaInstanceV8.cpp:
3208         (JavaInstance::getField):
3209
3210 2011-03-31  Levi Weintraub  <leviw@chromium.org>
3211
3212         Reviewed by Ryosuke Niwa.
3213
3214         Clean up from r82447.
3215         https://bugs.webkit.org/attachment.cgi?bugid=57532
3216
3217         No new tests since this doesn't change behavior.
3218
3219         * rendering/RenderBlock.cpp: Removing unnecessary visible_units.h include.
3220         * rendering/RootInlineBox.cpp:
3221         (WebCore::RootInlineBox::getLogicalStartBoxWithNode): Making const.
3222         (WebCore::RootInlineBox::getLogicalEndBoxWithNode): Ditto.
3223         * rendering/RootInlineBox.h:
3224
3225 2011-03-31  Benjamin Kalman  <kalman@chromium.org>
3226
3227         Reviewed by Ojan Vafai.
3228
3229         DeleteSelectionCommand::removeNode tries to insert block placeholder in non-editable table cell positions
3230         https://bugs.webkit.org/show_bug.cgi?id=57079
3231
3232         Test: editing/execCommand/delete-table-with-empty-contents.html
3233
3234         This bug results in an ASSERT fail in CompositeEditCommand::insertNodeAt, so is only observable in debug builds
3235         of WebKit.
3236
3237         * editing/DeleteSelectionCommand.cpp:
3238         (WebCore::firstEditablePositionInNode):
3239         (WebCore::DeleteSelectionCommand::removeNode): Use firstEditablePositionInNode rather than firstPositionInNode
3240         to find anchor node for the placeholder's position, if any.
3241
3242 2011-03-30  Ojan Vafai  <ojan@chromium.org>
3243
3244         Reviewed by Adam Roben.
3245
3246         REGRESSION (r82400): Leaks seen beneath CSSParser::createFloatingVectorSelector when parsing UA stylesheet
3247         https://bugs.webkit.org/show_bug.cgi?id=57478
3248
3249         * css/CSSGrammar.y:
3250         * css/CSSParser.cpp:
3251         (WebCore::CSSParser::sinkFloatingSelectorVector):
3252         * css/CSSParser.h:
3253
3254 2011-03-30  Dominic Cooney  <dominicc@google.com>
3255
3256         Reviewed by Dimitri Glazkov.
3257
3258         Adds layoutTestController.shadowRoot accessor to Mac DRT.
3259         https://bugs.webkit.org/show_bug.cgi?id=57415
3260
3261         * WebCore.exp.in: DRT needs to link WebCore::Element::shadowRoot
3262
3263 2011-03-30  Kent Tamura  <tkent@chromium.org>
3264
3265         Reviewed by Dimitri Glazkov.
3266
3267         Simplify HTMLFormElement::validateInteractively() for asynchronous scroll event
3268         https://bugs.webkit.org/show_bug.cgi?id=57424
3269
3270         r75555 made 'scroll' event asynchronous. So we don't need to worry about
3271         deleting or moving a target node in scrollIntoViewIfNeeded().
3272
3273         * html/HTMLFormElement.cpp:
3274         (WebCore::HTMLFormElement::validateInteractively): Remove unnecessary code.
3275
3276 2011-03-30  Kent Tamura  <tkent@chromium.org>
3277
3278         Reviewed by Darin Adler.
3279
3280         REGRESSION (r74895): Crash if input.type = 'file' twice
3281         https://bugs.webkit.org/show_bug.cgi?id=57343
3282
3283         * html/HTMLInputElement.cpp:
3284         (WebCore::HTMLInputElement::updateType):
3285           Don't call setAttribute() if the type is not changed.
3286
3287 2011-03-30  Jia Pu  <jpu@apple.com>
3288
3289         Reviewed by Darin Adler.
3290
3291         Autocorrection panel isn't positioned correctly in Safari (mac) when the zooming is not 1x.
3292         https://bugs.webkit.org/show_bug.cgi?id=57353
3293         <rdar://problem/9163983>
3294
3295         We use Range::textQuads() instead of Range::boundingRect() to compute the position of correction
3296         panel. The latter function compensates for zooming, which we don't need in this case. We also
3297         dismiss correction panel when zooming factor is changed. This is done in Frame::setPageAndTextZoomFactors().
3298
3299         * WebCore.exp.in:
3300         * dom/Range.cpp:
3301         (WebCore::Range::textQuads):
3302         * dom/Range.h:
3303         * editing/Editor.cpp:
3304         (WebCore::Editor::windowRectForRange):
3305         * editing/Editor.h:
3306         * page/Frame.cpp:
3307         (WebCore::Frame::setPageAndTextZoomFactors):
3308
3309 2011-03-30  Chris Guillory  <chris.guillory@google.com>
3310
3311         Reviewed by Dimitri Glazkov.
3312
3313         Render fonts using skia when requested by platform context.
3314         https://bugs.webkit.org/show_bug.cgi?id=56441
3315
3316         * platform/graphics/skia/PlatformContextSkia.cpp:
3317         (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
3318         * platform/graphics/skia/PlatformContextSkia.h:
3319         * platform/graphics/skia/SkiaFontWin.cpp:
3320         (WebCore::windowsCanHandleTextDrawing):
3321         (WebCore::skiaDrawText):
3322         (WebCore::setupPaintForFont):
3323         (WebCore::paintSkiaText):
3324
3325 2011-03-30  Dan Bernstein  <mitz@apple.com>
3326
3327         Reviewed by Darin Adler.
3328
3329         <rdar://problem/9199518> Crash when focusing a styled editable element
3330
3331         Test: editing/deleting/delete-button-background-image-none.html
3332
3333         * editing/DeleteButtonController.cpp:
3334         (WebCore::isDeletableElement): Check all background layers for background images.
3335         * rendering/style/RenderStyle.h: Removed backgroundImage() as it was only used, incorrectly,
3336         in the above function.
3337
3338 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
3339
3340         Try once more to fix the EFL build.
3341
3342         * platform/efl/RenderThemeEfl.cpp:
3343
3344 2011-03-30  Chris Fleizach  <cfleizach@apple.com>
3345
3346         Reviewed by Darin Adler.
3347
3348         Regression: VO cursor doesn't follow KB focus back into HTML view
3349         https://bugs.webkit.org/show_bug.cgi?id=57509
3350
3351         In WK2, because the web area never believes focus leave the area, sending the initial
3352         focus change when moving back into the web area, does not trigger a notification.
3353
3354         That behavior needs to be overridden by explicitly posting a focused UI element change
3355         at the appropriate time. This is only used in WK2, hence the absence of a layout test for now.
3356
3357         * page/FocusController.cpp:
3358         (WebCore::FocusController::setInitialFocus):
3359
3360 2011-03-30  MORITA Hajime  <morrita@google.com>
3361
3362         Reviewed by Simon Fraser.
3363
3364         box-shadow radii stays the same regardless of any spread set
3365         https://bugs.webkit.org/show_bug.cgi?id=49726
3366
3367         - Removed special shadowSpread handling path
3368         - Fixed broken multple inset shadow border computation.
3369
3370         Test: fast/box-shadow/spread-multiple-inset.html
3371
3372         * rendering/RenderBoxModelObject.cpp:
3373         (WebCore::RenderBoxModelObject::paintBoxShadow):
3374
3375 2011-03-29  Matthew Delaney  <mdelaney@apple.com>
3376
3377         Reviewed by Simon Fraser.
3378
3379         Use the Accelerate vImage vectorized (un)premultiplyImageData functions for ImageBufferCG
3380
3381         https://bugs.webkit.org/show_bug.cgi?id=53134
3382
3383         Test: fast/canvas/getPutImageDataPairTest.html
3384
3385         * platform/graphics/cg/ImageBufferCG.cpp:
3386
3387 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
3388
3389         Reviewed by Adam Roben.
3390
3391         Share most vsprops between Release and Production builds in releaseproduction.vsprops
3392         https://bugs.webkit.org/show_bug.cgi?id=57508
3393
3394         * WebCore.vcproj/QTMovieWinProduction.vsprops:
3395         * WebCore.vcproj/QTMovieWinRelease.vsprops:
3396         * WebCore.vcproj/QTMovieWinReleaseCairoCFLite.vsprops:
3397         * WebCore.vcproj/WebCoreProduction.vsprops:
3398         * WebCore.vcproj/WebCoreRelease.vsprops:
3399         * WebCore.vcproj/WebCoreReleaseCairoCFLite.vsprops:
3400
3401 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
3402
3403         Reviewed by Alexey Proskuryakov.
3404
3405         Add some dynamic annotations to JavaScriptCore/wtf
3406         https://bugs.webkit.org/show_bug.cgi?id=53747
3407
3408         By using these annotations we can improve the precision of finding
3409         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
3410         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
3411
3412         These files don't add new functionality, so don't need extra tests.
3413
3414         * ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
3415
3416 2011-03-30  Abhishek Arya  <inferno@chromium.org>
3417
3418         Reviewed by Simon Fraser.
3419
3420         Fix wrong type assumptions in editing code. Move code
3421         from ASSERTs to hard checks.
3422         https://bugs.webkit.org/show_bug.cgi?id=57348
3423
3424         Test: editing/execCommand/remove-format-non-html-element-crash.html
3425
3426         * css/CSSStyleSelector.cpp:
3427         (WebCore::CSSStyleSelector::applyProperty):
3428         * editing/ApplyStyleCommand.cpp:
3429         (WebCore::getRGBAFontColor):
3430         (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
3431         * editing/DeleteButtonController.cpp:
3432         (WebCore::enclosingDeletableElement):
3433         * editing/EditingStyle.cpp:
3434         (WebCore::EditingStyle::textDirection):
3435         (WebCore::EditingStyle::prepareToApplyAt):
3436         * editing/Editor.cpp:
3437         (WebCore::Editor::textDirectionForSelection):
3438         * editing/FormatBlockCommand.cpp:
3439         (WebCore::FormatBlockCommand::elementForFormatBlockCommand):
3440
3441 2011-03-30  Stephen White  <senorblanco@chromium.org>
3442
3443         Reviewed by Kenneth Russell.
3444
3445         Speed up clipping in accelerated 2D canvas.
3446         https://bugs.webkit.org/show_bug.cgi?id=57464
3447
3448         Instead of clearing the entire stencil buffer when removing clipping paths, we erase the path with a DECR stencil operation.
3449         Covered by canvas/philip/tests/2d.path.clip.intersect.html, and others.
3450
3451         * platform/graphics/chromium/GLES2Canvas.cpp:
3452         (WebCore::PathAndTransform::PathAndTransform):
3453         New structure to keep track of the CTM at the time the clipping path was added.
3454         (WebCore::GLES2Canvas::State::State):
3455         Replace m_clippingEnabled with a count of total clipping paths.
3456         (WebCore::GLES2Canvas::clearRect):
3457         Check the total clipping path count, instead of m_clippingEnabled.
3458         (WebCore::GLES2Canvas::fillPath):
3459         (WebCore::GLES2Canvas::fillRect):
3460         Perform state application after doing shadows.  This is necessary
3461         since restore() may now leave clipping enabled.
3462         (WebCore::GLES2Canvas::clipPath):
3463         Explicitly specify the stencil operation as INCR.  Store the current
3464         transformation when saving clipping paths.
3465         (WebCore::GLES2Canvas::restore):
3466         Don't clear the stencil buffer and re-draw active paths on each restore.
3467         Erase the old paths with DECR.
3468         (WebCore::GLES2Canvas::drawTexturedRect):
3469         Check m_numClippingPaths instead of m_clippingEnabled.
3470         (WebCore::GLES2Canvas::beginShadowDraw):
3471         Perform state application when drawing hard shadows.
3472         (WebCore::GLES2Canvas::endShadowDraw):
3473         Check m_numClippingPaths instead of m_clippingEnabled.
3474         (WebCore::GLES2Canvas::beginStencilDraw):
3475         Make the stencil op a parameter to beginShadowDraw().
3476         (WebCore::GLES2Canvas::applyClipping):
3477         Compare against the total number of stencil paths, not just the ones in
3478         the current state.
3479         * platform/graphics/chromium/GLES2Canvas.h:
3480         Make the stencil op a parameter to beginShadowDraw().
3481
3482 2011-03-29  Dimitri Glazkov  <dglazkov@chromium.org>
3483
3484         Reviewed by Darin Adler.
3485
3486         Move factory-like things in EventDispatcher::dispatchMouseEvent to a factory, clean up names and ordering.
3487         https://bugs.webkit.org/show_bug.cgi?id=57419
3488
3489         Refactoring, covered by existing tests.
3490
3491         * dom/EventDispatcher.cpp:
3492         (WebCore::EventDispatcher::dispatchMouseEvent): Reordered and clarified names.
3493         * dom/MouseEvent.cpp:
3494         (WebCore::MouseEvent::create): Added a new factory method that takes PlatformMouseEvent.
3495         * dom/MouseEvent.h: Added decl.
3496
3497 2011-03-30  Erik Arvidsson  <arv@chromium.org>
3498
3499         Reviewed by Alexey Proskuryakov.
3500
3501         Missing DOM bindings for a ping
3502         https://bugs.webkit.org/show_bug.cgi?id=51955
3503
3504         Test: fast/dom/ping-attribute-dom-binding.html
3505
3506         * html/HTMLAnchorElement.idl:
3507         * html/HTMLAreaElement.idl:
3508
3509 2011-03-30  Patrick Gansterer  <paroga@webkit.org>
3510
3511         Unreviewed WinCE build fix for r82465.
3512
3513         * CMakeListsWinCE.txt:
3514
3515 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
3516
3517         Reviewed by Adam Roben.
3518
3519         Update Windows production build logic for new production configurations
3520         https://bugs.webkit.org/show_bug.cgi?id=57494
3521
3522         * WebCore.vcproj/QTMovieWinProduction.vsprops:
3523         * WebCore.vcproj/WebCore.make:
3524         * WebCore.vcproj/WebCoreProduction.vsprops:
3525
3526 2011-03-30  Sam Weinig  <sam@webkit.org>
3527
3528         Reviewed by Brady Eidson.
3529
3530         WebKit2: Attempting to view css file from url causes it to download
3531         <rdar://problem/9102611>
3532         https://bugs.webkit.org/show_bug.cgi?id=57501
3533
3534         * WebCore.exp.in:
3535         * platform/MIMETypeRegistry.cpp:
3536         (WebCore::initializeUnsupportedTextMIMETypes):
3537         (WebCore::initializeMIMETypeRegistry):
3538         (WebCore::MIMETypeRegistry::isUnsupportedTextMIMEType):
3539         (WebCore::MIMETypeRegistry::getUnsupportedTextMIMETypes):
3540         * platform/MIMETypeRegistry.h:
3541         Add set of unsupported text MIME types, taken from WebKit/mac.
3542
3543 2011-03-30  Brian Weinstein  <bweinstein@apple.com>
3544
3545         Reviewed by Darin Adler.
3546         
3547         Crash when closing "Add Bookmark" dialog using the Enter Key
3548         https://bugs.webkit.org/show_bug.cgi?id=57294
3549         <rdar://problem/9044756>
3550
3551         Protect the FrameView in EventHandler::keyEvent, like we do in other EventHandler
3552         functions that could destroy the frame.
3553
3554         * page/EventHandler.cpp:
3555         (WebCore::EventHandler::keyEvent):
3556
3557 2011-03-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3558
3559         Unreviewed, rolling out r82463.
3560         http://trac.webkit.org/changeset/82463
3561         https://bugs.webkit.org/show_bug.cgi?id=57482
3562
3563         Assertion failure in Node::rendererIsEditable on multiple
3564         editing tests (Requested by aroben|meeting on #webkit).
3565
3566         * css/CSSParser.cpp:
3567         (WebCore::CSSParser::parseValue):
3568         * css/CSSPrimitiveValueMappings.h:
3569         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
3570         (WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
3571         * css/CSSValueKeywords.in:
3572         * rendering/style/RenderStyle.h:
3573         * rendering/style/RenderStyleConstants.h:
3574
3575 2011-03-24  Luiz Agostini  <luiz.agostini@openbossa.org>
3576
3577         Reviewed by Kenneth Rohde Christiansen.
3578
3579         [Qt] QNetworkReplyHandler refactoring: signal sequence.
3580         https://bugs.webkit.org/show_bug.cgi?id=57049
3581
3582         This is the first step in QNetworkReplyHandler. The main objective here is to create simple invariants:
3583
3584             1 - that the signals metadatachanged, readyRead and finished will come in this order.
3585             2 - that signals metadatachanged and finished will be called exactly once.
3586
3587         Having these invariants further simplifications will be possible and will come in future patches.
3588
3589         Class QNetworkReplyWrapper was created to handle QNetworkReply object. To connect to the signals of it
3590         instead of connecting to the signals of QNetworkReply is what guarantees the sequence of the signals.
3591         QNetworkReplyWrapper will be used in future to perform mime type sniffing before sending
3592         metadatachanged signal.
3593
3594         * platform/network/qt/QNetworkReplyHandler.cpp:
3595         (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
3596         (WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper):
3597         (WebCore::QNetworkReplyWrapper::release):
3598         (WebCore::QNetworkReplyWrapper::resetConnections):
3599         (WebCore::QNetworkReplyWrapper::receiveMetaData):
3600         (WebCore::QNetworkReplyWrapper::didReceiveFinished):
3601         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
3602         (WebCore::QNetworkReplyHandler::resetState):
3603         (WebCore::QNetworkReplyHandler::release):
3604         (WebCore::QNetworkReplyHandler::finish):
3605         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
3606         (WebCore::QNetworkReplyHandler::redirect):
3607         (WebCore::QNetworkReplyHandler::forwardData):
3608         (WebCore::QNetworkReplyHandler::sendNetworkRequest):
3609         (WebCore::QNetworkReplyHandler::start):
3610         * platform/network/qt/QNetworkReplyHandler.h:
3611         (WebCore::QNetworkReplyWrapper::reply):
3612         (WebCore::QNetworkReplyWrapper::redirectionTargetUrl):
3613         (WebCore::QNetworkReplyWrapper::encoding):
3614         (WebCore::QNetworkReplyWrapper::advertisedMimeType):
3615         (WebCore::QNetworkReplyHandler::reply):
3616
3617 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
3618
3619         Reviewed by Adam Roben.
3620
3621         Rename Windows configuration Release_LTCG to Production for clarity
3622         https://bugs.webkit.org/show_bug.cgi?id=57465
3623
3624         * WebCore.vcproj/QTMovieWin.vcproj:
3625         * WebCore.vcproj/QTMovieWinProduction.vsprops: Copied from Source/WebCore/WebCore.vcproj/QTMovieWinReleaseLTCG.vsprops.
3626         * WebCore.vcproj/QTMovieWinReleaseLTCG.vsprops: Removed.
3627         * WebCore.vcproj/WebCore.sln:
3628         * WebCore.vcproj/WebCore.submit.sln:
3629         * WebCore.vcproj/WebCore.vcproj:
3630         * WebCore.vcproj/WebCoreGenerated.vcproj:
3631         * WebCore.vcproj/WebCoreProduction.vsprops: Copied from Source/WebCore/WebCore.vcproj/WebCoreReleaseLTCG.vsprops.
3632         * WebCore.vcproj/WebCoreReleaseLTCG.vsprops: Removed.
3633
3634 2011-03-30  Brian Weinstein  <bweinstein@apple.com>
3635
3636         Reviewed by Anders Carlsson.
3637         
3638         ASSERT(cookieStorageAdapter) when calling stopObservingCookieChanges after WebProcess has crashed
3639         https://bugs.webkit.org/show_bug.cgi?id=57477
3640         <rdar://problem/9178751>
3641         
3642         If someone has called startObservingCookieChanges, and the WebProcess crashes and restarts, the UIProcess
3643         will call stopObservingCookieChanges when cookieStorageAdapter is nil.
3644         
3645         The assert is wrong when the web process crashes, and there is no harm in dispatching a message to nil,
3646         so remove the assert.
3647         
3648         * platform/network/mac/CookieStorageMac.mm:
3649         (WebCore::stopObservingCookieChanges):
3650
3651 2011-03-30  Sam Weinig  <sam@webkit.org>
3652
3653         Fix Leopard build.
3654
3655         * platform/DefaultLocalizationStrategy.cpp:
3656         (WebCore::DefaultLocalizationStrategy::contextMenuItemTagLookUpInDictionary):
3657
3658 2011-03-30  Sam Weinig  <sam@webkit.org>
3659
3660         Reviewed by Anders Carlsson.
3661
3662         Add default localization strategy that can be shared by WebKit1 and WebKit2
3663         https://bugs.webkit.org/show_bug.cgi?id=57406
3664
3665         Currently, only WebKit2 uses this default strategy, but WebKit1 should be able
3666         to adopt it soon.
3667
3668         * platform/DefaultLocalizationStrategy.cpp: Copied from Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp.
3669         (WebCore::DefaultLocalizationStrategy::DefaultLocalizationStrategy):
3670         * platform/DefaultLocalizationStrategy.h: Copied from Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h.
3671         Copy the implementation of the Localization strategy from WebKit2 into a shared default strategy.
3672
3673         * platform/LocalizedStrings.cpp:
3674         (WebCore::localizedString):
3675         Add default implementation of localization bottleneck function.
3676
3677         * platform/LocalizedStrings.h:
3678         Add localization macros here, instead of defining them in the above layer.
3679
3680         * platform/PlatformStrategies.cpp:
3681         (WebCore::PlatformStrategies::createLocalizationStrategy):
3682         * platform/PlatformStrategies.h:
3683         Add default implementation of strategy creation function which creates the default strategy.
3684
3685         * platform/win/LocalizedStringsWin.cpp: Copied from Source/WebCore/platform/mac/LocalizedStringsMac.mm.
3686         (WebCore::localizedString):
3687         Add stub for windows, this will be update to pull from the bundle in a follow up patch.
3688
3689         * Android.mk:
3690         * CMakeLists.txt:
3691         * GNUmakefile.am:
3692         * WebCore.exp.in:
3693         * WebCore.gypi:
3694         * WebCore.pro:
3695         * WebCore.vcproj/WebCore.vcproj:
3696         * WebCore.xcodeproj/project.pbxproj:
3697         Add new files.
3698
3699 2011-03-30  Andras Becsi  <abecsi@webkit.org>
3700
3701         Reviewed by Darin Adler.
3702
3703         CSS: Slow parsing of rgb() with percent values
3704         https://bugs.webkit.org/show_bug.cgi?id=16708
3705
3706         Implement fast-path parsing for percentage color values.
3707
3708         Gain ~30% speedup on  http://canvex.lazyilluminati.com/misc/3d.html
3709
3710         Relanding with rounding fix after it was rolled out in r82315.
3711
3712         * css/CSSParser.cpp:
3713         (WebCore::checkForValidDouble): Extend to return the number of characters forming a valid double.
3714         (WebCore::parseDouble): Function for parsing double values if they are valid.
3715         (WebCore::parseColorIntOrPercentage): Extend parseColorInt to deal with percentage values.
3716         (WebCore::parseAlphaValue): Use the new functions.
3717         (WebCore::CSSParser::parseColor): Ditto.
3718
3719 2011-03-30  Ofri Wolfus  <ofri@dhcp-172-28-40-178.tlv.corp.google.com>
3720
3721         Reviewed by Eric Seidel.
3722
3723         Add support for parsing unicode-bidi: -webkit-plaintext.
3724         https://bugs.webkit.org/show_bug.cgi?id=57457
3725
3726         Test: css3/unicode-bidi-plaintext-parse.html
3727
3728         * css/CSSParser.cpp:
3729         (WebCore::CSSParser::parseValue):
3730         * css/CSSPrimitiveValueMappings.h:
3731         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
3732         (WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
3733         * css/CSSValueKeywords.in:
3734         * rendering/style/RenderStyle.h:
3735         * rendering/style/RenderStyleConstants.h:
3736
3737 2011-03-30  Andreas Kling  <kling@webkit.org>
3738
3739         Reviewed by Benjamin Poulain.
3740
3741         [Qt] Remove unused variables in GraphicsContext::fillRect()
3742
3743         * platform/graphics/qt/GraphicsContextQt.cpp:
3744         (WebCore::GraphicsContext::fillRect):
3745
3746 2011-03-30  Yael Aharon  <yael.aharon@nokia.com>
3747
3748         Reviewed by Eric Seidel.
3749
3750         REGRESSION(r82419): New pixel test failure fast/box-shadow/basic-shadows.html
3751         https://bugs.webkit.org/show_bug.cgi?id=57442
3752
3753         When checking the position of the inline iterator in the logicallyLastRun, we should not consider BR as text.
3754
3755         No new tests as existing test covers this case.
3756
3757         * rendering/RenderBlockLineLayout.cpp:
3758         (WebCore::reachedEndOfTextRenderer):
3759
3760 2011-03-30  Mario Sanchez Prada  <msanchez@igalia.com>
3761
3762         Reviewed by Chris Fleizach.
3763
3764         AX: GTK: ARIA role is not respected on <p> <label> <div> and <form>
3765         https://bugs.webkit.org/show_bug.cgi?id=47636
3766
3767         Define new roles in WebCore and map them to ATK accordingly.
3768
3769         Test: platform/gtk/accessibility/aria-roles-unignored.html
3770
3771         * accessibility/AccessibilityObject.h: Added new roles to
3772         represent paragraphs, labels, forms and div sections.
3773         * accessibility/AccessibilityRenderObject.cpp:
3774         (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
3775         Return ParagraphRole, LabelRole, FormRole and DivRole when needed
3776         for the GTK platform only.
3777         * accessibility/gtk/AccessibilityObjectAtk.cpp:
3778         (WebCore::AccessibilityObject::allowsTextRanges): Consider the new
3779         roles now that those kind of nodes won't return true to isGroup().
3780         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3781         (atkRole): Map new WebCore roles to ATK Roles.
3782         (webkit_accessible_get_role): Remove code to define roles for
3783         paragraphs, labels, forms and divs based on node's tag name.
3784
3785         Update mappings for the Mac platform.
3786
3787         * accessibility/mac/AccessibilityObjectWrapper.mm:
3788         (createAccessibilityRoleMap): Add explicit mappings from the new
3789         roles introduced to NSAccessibilityGroupRole.
3790
3791 2011-03-30  Yury Semikhatsky  <yurys@chromium.org>
3792
3793         Unreviewed. Build fix for Efl and Qt Win.
3794
3795         * inspector/PageDebuggerAgent.cpp: removed ENABLE(WORKERS) guard from code that has nothing to do with workers.
3796
3797 2011-03-30  Andrey Kosyakov  <caseq@chromium.org>
3798
3799         Reviewed by Pavel Feldman.
3800
3801         Web Inspector: audit run never completes, fails in DOMAgent.js
3802         https://bugs.webkit.org/show_bug.cgi?id=57349
3803
3804         - assure document is present before calling DOMAgent.querySelectAll()
3805
3806         * inspector/front-end/AuditRules.js:
3807         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
3808
3809 2011-03-30  Yury Semikhatsky  <yurys@chromium.org>
3810
3811         Unreviewed. Build fix.
3812
3813         * UseJSC.cmake: fix typo PageDebugServer -> PageScriptDebugServer
3814
3815 2011-03-30  Yury Semikhatsky  <yurys@chromium.org>
3816
3817         Reviewed by Pavel Feldman.
3818
3819         Web Inspector: split debugger agent into Page and Worker-specific ones
3820         https://bugs.webkit.org/show_bug.cgi?id=57345
3821
3822         ScriptDebugServer and InspectorDebuggerAgent contain only functionality common
3823         for Worker and Page debugger. All specifics is moved into Page/WorkerScriptDebugServer
3824         and Page/WorkerDebuggerAgent.
3825
3826         * CMakeLists.txt:
3827         * GNUmakefile.am:
3828         * UseJSC.cmake:
3829         * WebCore.gypi:
3830         * WebCore.pro:
3831         * WebCore.vcproj/WebCore.vcproj:
3832         * WebCore.xcodeproj/project.pbxproj:
3833         * bindings/js/JSBindingsAllInOne.cpp:
3834         * bindings/js/JSInjectedScriptHostCustom.cpp:
3835         (WebCore::JSInjectedScriptHost::currentCallFrame):
3836         * bindings/js/PageScriptDebugServer.cpp: Added.
3837         (WebCore::toPage):
3838         (WebCore::PageScriptDebugServer::shared):
3839         (WebCore::PageScriptDebugServer::PageScriptDebugServer):
3840         (WebCore::PageScriptDebugServer::~PageScriptDebugServer):
3841         (WebCore::PageScriptDebugServer::addListener):
3842         (WebCore::PageScriptDebugServer::removeListener):
3843         (WebCore::PageScriptDebugServer::recompileAllJSFunctions):
3844         (WebCore::PageScriptDebugServer::getListenersForGlobalObject):
3845         (WebCore::PageScriptDebugServer::didPause):
3846         (WebCore::PageScriptDebugServer::didContinue):
3847         (WebCore::PageScriptDebugServer::didRemoveLastListener):
3848         (WebCore::PageScriptDebugServer::setJavaScriptPaused):
3849         * bindings/js/PageScriptDebugServer.h: Added.
3850         * bindings/js/ScriptDebugServer.cpp:
3851         (WebCore::ScriptDebugServer::ScriptDebugServer):
3852         (WebCore::ScriptDebugServer::sourceParsed):
3853         (WebCore::ScriptDebugServer::dispatchFunctionToListeners):
3854         (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
3855         (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
3856         (WebCore::ScriptDebugServer::pauseIfNeeded):
3857         * bindings/js/ScriptDebugServer.h:
3858         * bindings/js/WorkerScriptDebugServer.cpp: Added.
3859         (WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
3860         (WebCore::WorkerScriptDebugServer::addListener):
3861         (WebCore::WorkerScriptDebugServer::removeListener):
3862         * bindings/js/WorkerScriptDebugServer.h: Added.
3863         (WebCore::WorkerScriptDebugServer::~WorkerScriptDebugServer):
3864         (WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
3865         (WebCore::WorkerScriptDebugServer::getListenersForGlobalObject):
3866         (WebCore::WorkerScriptDebugServer::didPause):
3867         (WebCore::WorkerScriptDebugServer::didContinue):
3868         * bindings/v8/PageScriptDebugServer.cpp: Added.
3869         (WebCore::retrieveFrame):
3870         (WebCore::PageScriptDebugServer::shared):
3871         (WebCore::PageScriptDebugServer::PageScriptDebugServer):
3872         (WebCore::PageScriptDebugServer::addListener):
3873         (WebCore::PageScriptDebugServer::removeListener):
3874         (WebCore::PageScriptDebugServer::setClientMessageLoop):
3875         (WebCore::PageScriptDebugServer::getDebugListenerForContext):
3876         (WebCore::PageScriptDebugServer::runMessageLoopOnPause):
3877         (WebCore::PageScriptDebugServer::quitMessageLoopOnPause):
3878         * bindings/v8/PageScriptDebugServer.h: Added.
3879         (WebCore::PageScriptDebugServer::setEnabled):
3880         (WebCore::PageScriptDebugServer::ClientMessageLoop::~ClientMessageLoop):
3881         (WebCore::PageScriptDebugServer::~PageScriptDebugServer):
3882         * bindings/v8/ScriptDebugServer.cpp:
3883         (WebCore::ScriptDebugServer::ScriptDebugServer):
3884         (WebCore::ScriptDebugServer::setPauseOnNextStatement):
3885         (WebCore::ScriptDebugServer::breakProgram):
3886         (WebCore::ScriptDebugServer::continueProgram):
3887         (WebCore::ScriptDebugServer::stepIntoStatement):
3888         (WebCore::ScriptDebugServer::stepOverStatement):
3889         (WebCore::ScriptDebugServer::stepOutOfFunction):
3890         (WebCore::ScriptDebugServer::editScriptSource):
3891         (WebCore::toScriptDebugServer):
3892         (WebCore::ScriptDebugServer::breakProgramCallback):
3893         (WebCore::ScriptDebugServer::v8DebugEventCallback):
3894         (WebCore::ScriptDebugServer::handleV8DebugEvent):
3895         (WebCore::ScriptDebugServer::isPaused):
3896         * bindings/v8/ScriptDebugServer.h:
3897         * bindings/v8/WorkerScriptDebugServer.cpp: Added.
3898         (WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
3899         (WebCore::WorkerScriptDebugServer::addListener):
3900         (WebCore::WorkerScriptDebugServer::removeListener):
3901         * bindings/v8/WorkerScriptDebugServer.h: Added.
3902         (WebCore::WorkerScriptDebugServer::~WorkerScriptDebugServer):
3903         (WebCore::WorkerScriptDebugServer::getDebugListenerForContext):
3904         (WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
3905         (WebCore::WorkerScriptDebugServer::quitMessageLoopOnPause):
3906         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
3907         (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
3908         * inspector/InjectedScriptHost.h:
3909         (WebCore::InjectedScriptHost::init):
3910         (WebCore::InjectedScriptHost::debuggerAgent):
3911         * inspector/InspectorAgent.cpp:
3912         (WebCore::InspectorAgent::InspectorAgent):
3913         * inspector/InspectorDebuggerAgent.cpp:
3914         (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
3915         (WebCore::InspectorDebuggerAgent::enable):
3916         (WebCore::InspectorDebuggerAgent::disable):
3917         (WebCore::InspectorDebuggerAgent::setBreakpointsActive):
3918         (WebCore::InspectorDebuggerAgent::removeBreakpoint):
3919         (WebCore::InspectorDebuggerAgent::continueToLocation):
3920         (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
3921         (WebCore::InspectorDebuggerAgent::editScriptSource):
3922         (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
3923         (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement):
3924         (WebCore::InspectorDebuggerAgent::resume):
3925         (WebCore::InspectorDebuggerAgent::stepOver):
3926         (WebCore::InspectorDebuggerAgent::stepInto):
3927         (WebCore::InspectorDebuggerAgent::stepOut):
3928         (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
3929         (WebCore::InspectorDebuggerAgent::didPause):
3930         (WebCore::InspectorDebuggerAgent::breakProgram):
3931         * inspector/InspectorDebuggerAgent.h:
3932         * inspector/InspectorProfilerAgent.cpp:
3933         (WebCore::InspectorProfilerAgent::disable):
3934         (WebCore::InspectorProfilerAgent::enable):
3935         (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
3936         * inspector/PageDebuggerAgent.cpp: Added.
3937         (WebCore::PageDebuggerAgent::create):
3938         (WebCore::PageDebuggerAgent::PageDebuggerAgent):
3939         (WebCore::PageDebuggerAgent::~PageDebuggerAgent):
3940         (WebCore::PageDebuggerAgent::startListeningScriptDebugServer):
3941         (WebCore::PageDebuggerAgent::stopListeningScriptDebugServer):
3942         (WebCore::PageDebuggerAgent::scriptDebugServer):
3943         * inspector/PageDebuggerAgent.h: Added.
3944         * inspector/WorkerDebuggerAgent.cpp: Added.
3945         (WebCore::WorkerDebuggerAgent::create):
3946         (WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
3947         (WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent):
3948         (WebCore::WorkerDebuggerAgent::startListeningScriptDebugServer):
3949         (WebCore::WorkerDebuggerAgent::stopListeningScriptDebugServer):
3950         (WebCore::WorkerDebuggerAgent::scriptDebugServer):
3951         * inspector/WorkerDebuggerAgent.h: Added.
3952
3953 2011-03-30  Levi Weintraub  <leviw@chromium.org>
3954
3955         Reviewed by Ryosuke Niwa.
3956
3957         Clicking below last line of right-to-left editable text that puts caret in the wrong place
3958         https://bugs.webkit.org/show_bug.cgi?id=38087
3959
3960         Moving getLogical[Start/End]BoxWithNode to RootInlineBox and using it in positionForPointWithInlineChildren
3961         instead of lastLeafChild, which wasn't correct in the RTL case.
3962
3963         Test: editing/selection/click-below-rtl-text.html
3964
3965         * editing/visible_units.cpp:
3966         (WebCore::logicalStartPositionForLine): Moved to RootInlineBox.
3967         (WebCore::logicalEndPositionForLine): Ditto.
3968         * editing/visible_units.h:
3969         * rendering/RenderBlock.cpp:
3970         (WebCore::RenderBlock::positionForPointWithInlineChildren): Useing getLogicalEndBoxWithNode instead
3971         of lastLeafChild.
3972         * rendering/RootInlineBox.cpp:
3973         (WebCore::RootInlineBox::getLogicalStartBoxWithNode): Moved and refactored.
3974         (WebCore::RootInlineBox::getLogicalEndBoxWithNode): Ditto.
3975         * rendering/RootInlineBox.h:
3976
3977 2011-03-30  Yury Semikhatsky  <yurys@chromium.org>
3978
3979         Unreviewed. Rollout r82438 and r82436.
3980
3981         * CMakeLists.txt:
3982         * GNUmakefile.am:
3983         * UseJSC.cmake:
3984         * WebCore.gypi:
3985         * WebCore.pro:
3986         * WebCore.vcproj/WebCore.vcproj:
3987         * WebCore.xcodeproj/project.pbxproj:
3988         * bindings/js/JSBindingsAllInOne.cpp:
3989         * bindings/js/JSInjectedScriptHostCustom.cpp:
3990         (WebCore::JSInjectedScriptHost::currentCallFrame):
3991         * bindings/js/PageScriptDebugServer.cpp: Removed.
3992         * bindings/js/PageScriptDebugServer.h: Removed.
3993         * bindings/js/ScriptDebugServer.cpp:
3994         (WebCore::ScriptDebugServer::shared):
3995         (WebCore::ScriptDebugServer::ScriptDebugServer):
3996         (WebCore::ScriptDebugServer::addListener):
3997         (WebCore::ScriptDebugServer::removeListener):
3998         (WebCore::ScriptDebugServer::hasListenersInterestedInPage):
3999         (WebCore::toPage):
4000         (WebCore::ScriptDebugServer::sourceParsed):
4001         (WebCore::ScriptDebugServer::dispatchFunctionToListeners):
4002         (WebCore::ScriptDebugServer::setJavaScriptPaused):
4003         (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
4004         (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
4005         (WebCore::ScriptDebugServer::pauseIfNeeded):
4006         (WebCore::ScriptDebugServer::recompileAllJSFunctions):
4007         (WebCore::ScriptDebugServer::didAddListener):
4008         (WebCore::ScriptDebugServer::didRemoveListener):
4009         * bindings/js/ScriptDebugServer.h:
4010         * bindings/js/WorkerScriptDebugServer.cpp: Removed.
4011         * bindings/js/WorkerScriptDebugServer.h: Removed.
4012         * bindings/v8/PageScriptDebugServer.cpp: Removed.
4013         * bindings/v8/PageScriptDebugServer.h: Removed.
4014         * bindings/v8/ScriptDebugServer.cpp:
4015         (WebCore::retrieveFrame):
4016         (WebCore::ScriptDebugServer::shared):
4017         (WebCore::ScriptDebugServer::ScriptDebugServer):
4018         (WebCore::ScriptDebugServer::addListener):
4019         (WebCore::ScriptDebugServer::removeListener):
4020         (WebCore::ScriptDebugServer::setPauseOnNextStatement):
4021         (WebCore::ScriptDebugServer::breakProgram):
4022         (WebCore::ScriptDebugServer::continueProgram):
4023         (WebCore::ScriptDebugServer::stepIntoStatement):
4024         (WebCore::ScriptDebugServer::stepOverStatement):
4025         (WebCore::ScriptDebugServer::stepOutOfFunction):
4026         (WebCore::ScriptDebugServer::editScriptSource):
4027         (WebCore::ScriptDebugServer::setEnabled):
4028         (WebCore::ScriptDebugServer::breakProgramCallback):
4029         (WebCore::ScriptDebugServer::v8DebugEventCallback):
4030         (WebCore::ScriptDebugServer::handleV8DebugEvent):
4031         (WebCore::ScriptDebugServer::didResume):
4032         * bindings/v8/ScriptDebugServer.h:
4033         (WebCore::ScriptDebugServer::pageCreated):
4034         (WebCore::ScriptDebugServer::ClientMessageLoop::~ClientMessageLoop):
4035         (WebCore::ScriptDebugServer::setClientMessageLoop):
4036         * bindings/v8/WorkerScriptDebugServer.cpp: Removed.
4037         * bindings/v8/WorkerScriptDebugServer.h: Removed.
4038         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
4039         (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
4040         * inspector/InjectedScriptHost.h:
4041         (WebCore::InjectedScriptHost::init):
4042         * inspector/InspectorAgent.cpp:
4043         (WebCore::InspectorAgent::InspectorAgent):
4044         * inspector/InspectorDebuggerAgent.cpp:
4045         (WebCore::InspectorDebuggerAgent::create):
4046         (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
4047         (WebCore::InspectorDebuggerAgent::enable):
4048         (WebCore::InspectorDebuggerAgent::disable):
4049         (WebCore::InspectorDebuggerAgent::setBreakpointsActive):
4050         (WebCore::InspectorDebuggerAgent::removeBreakpoint):
4051         (WebCore::InspectorDebuggerAgent::continueToLocation):
4052         (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
4053         (WebCore::InspectorDebuggerAgent::editScriptSource):
4054         (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
4055         (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement):
4056         (WebCore::InspectorDebuggerAgent::resume):
4057         (WebCore::InspectorDebuggerAgent::stepOver):
4058         (WebCore::InspectorDebuggerAgent::stepInto):
4059         (WebCore::InspectorDebuggerAgent::stepOut):
4060         (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
4061         (WebCore::InspectorDebuggerAgent::didPause):
4062         (WebCore::InspectorDebuggerAgent::breakProgram):
4063         * inspector/InspectorDebuggerAgent.h:
4064         * inspector/InspectorProfilerAgent.cpp:
4065         (WebCore::InspectorProfilerAgent::disable):
4066         (WebCore::InspectorProfilerAgent::enable):
4067         (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
4068         * inspector/PageDebuggerAgent.cpp: Removed.
4069         * inspector/PageDebuggerAgent.h: Removed.
4070         * inspector/WorkerDebuggerAgent.cpp: Removed.
4071         * inspector/WorkerDebuggerAgent.h: Removed.
4072
4073 2011-03-30  Yury Semikhatsky  <yurys@chromium.org>
4074
4075         Unreviewed. Fix compilation on Windows and EFL.
4076
4077         * CMakeLists.txt:
4078         * bindings/js/JSBindingsAllInOne.cpp:
4079
4080 2011-03-30  Yury Semikhatsky  <yurys@chromium.org>
4081
4082         Reviewed by Pavel Feldman.
4083
4084         Web Inspector: split debugger agent into Page and Worker-specific ones
4085         https://bugs.webkit.org/show_bug.cgi?id=57345
4086
4087         ScriptDebugServer and InspectorDebuggerAgent contain only functionality common
4088         for Worker and Page debugger. All specifics is moved into Page/WorkerScriptDebugServer
4089         and Page/WorkerDebuggerAgent.
4090
4091         * GNUmakefile.am:
4092         * UseJSC.cmake:
4093         * WebCore.gypi:
4094         * WebCore.pro:
4095         * WebCore.vcproj/WebCore.vcproj:
4096         * WebCore.xcodeproj/project.pbxproj:
4097         * bindings/js/JSInjectedScriptHostCustom.cpp:
4098         (WebCore::JSInjectedScriptHost::currentCallFrame):
4099         * bindings/js/PageScriptDebugServer.cpp: Added.
4100         (WebCore::toPage):
4101         (WebCore::PageScriptDebugServer::shared):
4102         (WebCore::PageScriptDebugServer::PageScriptDebugServer):
4103         (WebCore::PageScriptDebugServer::~PageScriptDebugServer):
4104         (WebCore::PageScriptDebugServer::addListener):
4105         (WebCore::PageScriptDebugServer::removeListener):
4106         (WebCore::PageScriptDebugServer::recompileAllJSFunctions):
4107         (WebCore::PageScriptDebugServer::getListenersForGlobalObject):
4108         (WebCore::PageScriptDebugServer::didPause):
4109         (WebCore::PageScriptDebugServer::didContinue):
4110         (WebCore::PageScriptDebugServer::didRemoveLastListener):
4111         (WebCore::PageScriptDebugServer::setJavaScriptPaused):
4112         * bindings/js/PageScriptDebugServer.h: Added.
4113