2011-03-08 Ilya Tikhonovsky <loislo@chromium.org>
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-03-08  Ilya Tikhonovsky  <loislo@chromium.org>
2
3         Reviewed by Pavel Feldman.
4
5         Web Inspector: remove groupName from objectId.
6         https://bugs.webkit.org/show_bug.cgi?id=55825
7
8         * inspector/InjectedScriptSource.js:
9
10 2011-03-08  Xiaomei Ji  <xji@chromium.org>
11
12         Reviewed by David Hyatt.
13
14         Fix Regression: Content not drawn when scrolling horizontally in an RTL page.
15         https://bugs.webkit.org/show_bug.cgi?id=55077.
16
17         Inside ScrollView::calculateOverhangAreasForPainting(), when scroll position
18         is negative, should include the position value into overhang rectangle's 
19         starting position. 
20
21         Tests: fast/dom/scroll-reveal-left-overflow.html
22                fast/dom/scroll-reveal-top-overflow.html
23
24         * platform/ScrollView.cpp:
25         (WebCore::ScrollView::calculateOverhangAreasForPainting):
26
27 2011-03-08  Daniel Bates  <dbates@rim.com>
28
29         Reviewed by Darin Adler.
30
31         Add templatized CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}()
32         https://bugs.webkit.org/show_bug.cgi?id=55351
33
34         By using some template magic CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}()
35         can be called on an array A without the caller explicitly specifying the size of A.
36
37         No functionality was changed. So no new tests.
38
39         * css/CSSMutableStyleDeclaration.cpp:
40         (WebCore::CSSMutableStyleDeclaration::getPropertyValue): Modified to call templatized variants of
41         CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}().
42         (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Renamed second argument from "number" to "size"
43         to better reflect its purpose - to be the size of the passed array.
44         (WebCore::CSSMutableStyleDeclaration::getShorthandValue): Ditto.
45         (WebCore::CSSMutableStyleDeclaration::getCommonValue): Ditto.
46         (WebCore::CSSMutableStyleDeclaration::cssText): Modified to call templatized variant of CSSMutableStyleDeclaration::getShorthandValue().
47         * css/CSSMutableStyleDeclaration.h:
48         (WebCore::CSSMutableStyleDeclaration::getShorthandValue): Added templatized function that can determine
49         the size of a passed array. Changed type of second argument to size_t since it represents the size of
50         an array.
51         (WebCore::CSSMutableStyleDeclaration::getCommonValue): Ditto.
52         (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Ditto.
53
54 2011-03-08  Enrica Casucci  <enrica@apple.com>
55
56         Reviewed by Darin Adler.
57         
58         REGRESSION: Copied content loses formatting on paste to external apps.
59         https://bugs.webkit.org/show_bug.cgi?id=47615
60         <rdar://problem/9001214>
61         
62         This is a resubmission of a patch that was landed a while ago then rolled
63         back because of a build failure on SnowLeopard and Leopard on the 32-bit builds.
64
65         This patch adds a way for WebKit2 to create NSAttributedStrings from
66         a DOM range without using the AppKit api initWithDOMRange that internally
67         needs to access the WebView. The NSAttributedString is needed to create
68         RTF formats in the pasteboard.
69         This is to be considered a first step, since in the future we want to have
70         an implementation based on the TextIterator.
71         * WebCore.xcodeproj/project.pbxproj:
72         * platform/mac/HTMLConverter.h: Added.
73         * platform/mac/HTMLConverter.mm: Added.
74         * platform/mac/PasteboardMac.mm:
75         (WebCore::Pasteboard::writeSelection):
76
77 2011-03-08  James Robinson  <jamesr@chromium.org>
78
79         Reviewed by Kenneth Russell.
80
81         [chromium] Explicitly copy compositing properties from LayerChromium to CCLayerImpl
82         https://bugs.webkit.org/show_bug.cgi?id=55900
83
84         This adds an explicit step to synchronize properties from
85         LayerChromiums to their corresponding CCLayerImpls.
86
87         * platform/graphics/chromium/LayerChromium.cpp:
88         (WebCore::LayerChromium::setBounds):
89         * platform/graphics/chromium/LayerChromium.h:
90         (WebCore::LayerChromium::bounds):
91         (WebCore::LayerChromium::doubleSided):
92         (WebCore::LayerChromium::setDoubleSided):
93         * platform/graphics/chromium/LayerRendererChromium.cpp:
94         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
95         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
96         (WebCore::CCLayerImpl::CCLayerImpl):
97         (WebCore::CCLayerImpl::updateFromLayer):
98         (WebCore::CCLayerImpl::descendantsDrawsContent):
99         * platform/graphics/chromium/cc/CCLayerImpl.h:
100         (WebCore::CCLayerImpl::anchorPoint):
101         (WebCore::CCLayerImpl::anchorPointZ):
102         (WebCore::CCLayerImpl::masksToBounds):
103         (WebCore::CCLayerImpl::opacity):
104         (WebCore::CCLayerImpl::position):
105         (WebCore::CCLayerImpl::preserves3D):
106         (WebCore::CCLayerImpl::sublayerTransform):
107         (WebCore::CCLayerImpl::transform):
108
109 2011-03-08  James Robinson  <jamesr@chromium.org>
110
111         Chromium compile fix.
112
113         * platform/graphics/chromium/SimpleFontDataLinux.cpp:
114         (WebCore::SimpleFontData::platformInit):
115
116 2011-03-08  Peter Kasting  <pkasting@google.com>
117
118         Reviewed by James Robinson.
119
120         Unify Windows version checks, part 1.
121         https://bugs.webkit.org/show_bug.cgi?id=55979
122
123         Make everyone (I hope) pull in SystemInfo.cpp.  Eliminate the
124         now-unnecessary WindowsVersion.cpp from Chromium.
125
126         * GNUmakefile.am:
127         * WebCore.gyp/WebCore.gyp:
128         * WebCore.gypi:
129         * platform/chromium/ScrollbarThemeChromiumWin.cpp:
130         (WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit):
131         (WebCore::ScrollbarThemeChromiumWin::getThemeState):
132         (WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
133         * platform/chromium/WindowsVersion.cpp: Removed.
134         * platform/chromium/WindowsVersion.h: Removed.
135         * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
136         (WebCore::fillBMPGlyphs):
137         * rendering/RenderThemeChromiumWin.cpp:
138         (WebCore::getNonClientMetrics):
139
140 2011-03-08  Ryosuke Niwa  <rniwa@webkit.org>
141
142         Chromium Linux build fix attempt after r80582.
143
144         * platform/graphics/chromium/FontLinux.cpp:
145         (WebCore::Font::drawGlyphs):
146         * platform/graphics/chromium/SimpleFontDataLinux.cpp:
147         (WebCore::SimpleFontData::platformInit):
148         * platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
149         (WebCore::GlyphPage::fill):
150
151 2011-03-08  Ryosuke Niwa  <rniwa@webkit.org>
152
153         Mac build fix attempt for r80582.
154
155         * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
156         (WebCore::disableLigatures):
157
158 2011-03-08  Ryosuke Niwa  <rniwa@webkit.org>
159
160         Reviewed by Kent Tamura.
161
162         Remove calls to deprecatedEditingOffset in SelectionController and VisibleSelection
163         https://bugs.webkit.org/show_bug.cgi?id=54937
164
165         * editing/SelectionController.cpp:
166         (WebCore::SelectionController::setSelection): Calls anchorNode() instead of deprecatedNode() to obtain
167         the document. Also restrained the lifetime of document variable.
168         (WebCore::removingNodeRemovesPosition): Compare the node with anchorNode() instead of deprecatedNode()
169         to determine whether or not position becomes null after removing a node.
170         (WebCore::SelectionController::directionOfEnclosingBlock): The enclosing block is always a container
171         so call containerNode() instead of deprecatedNode().
172         (WebCore::SelectionController::debugRenderer): Call containerNode() and computeOffsetInContainer()
173         instead of deprecatedNode() and deprecatedEditingOffset() respectively.
174         (WebCore::SelectionController::isInPasswordField): Look for the shadow root from containerNode()
175         instead of deprecatedNode to determine whether or not selection inside a password field. Also assert
176         that the specified position is not before or after the shadow root as it violates our assumption.
177         * editing/VisibleSelection.cpp:
178         (WebCore::makeSearchRange): Call containerNode() and offsetInContainerNode() instead of deprecatedNode()
179         and deprecatedEditingOffset() respectively because start is always parent anchored and therefore
180         guaranteed to be an offset inside an anchor node.
181         (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries): Call containerNode()
182         instead of deprecatedNode() to look for the lowest editable ancestor because position before or after
183         an editable element isn't editable.
184         * page/DOMSelection.cpp: Call containerNode() and offsetInContainerNode() instead of deprecatedNode()
185         and deprecatedEditingOffset() respectively in the following functions because they are exposed to
186         DOM, which doesn't have before/after concept.
187         (WebCore::DOMSelection::anchorNode):
188         (WebCore::DOMSelection::anchorOffset):
189         (WebCore::DOMSelection::focusNode):
190         (WebCore::DOMSelection::focusOffset):
191         (WebCore::DOMSelection::baseNode):
192         (WebCore::DOMSelection::baseOffset):
193         (WebCore::DOMSelection::extentNode):
194         (WebCore::DOMSelection::extentOffset):
195
196 2011-03-08  Brent Fulgham  <bfulgham@webkit.org>
197
198         Reviewed by Adam Roben.
199
200         Correct uninitialized variable in PolicyCallback found while
201         running WebKit in BoundsChecker.
202         https://bugs.webkit.org/show_bug.cgi?id=45199.
203
204         * loader/PolicyCallback.cpp:
205         (WebCore::PolicyCallback::PolicyCallback): Initialize
206         m_argument.
207
208 2011-03-08  Brent Fulgham  <bfulgham@webkit.org>
209
210         More build bustage fix.
211
212         * platform/graphics/win/cairo/FontPlatformData.h:
213         (WebCore::FontPlatformData::setOrientation): Duplicate accessor
214         in WinCairo-local header.  This is such a mess!
215
216 2011-03-08  David Hyatt  <hyatt@apple.com>
217
218         Fix build bustage.  Hide orientation setting behind a setter and stub it out in all
219         FontPlatformData classes.  (This class really needs to move to a common header with ifdefs.)
220
221         * platform/graphics/SimpleFontData.cpp:
222         (WebCore::SimpleFontData::verticalRightOrientationFontData):
223         * platform/graphics/cg/FontPlatformData.h:
224         (WebCore::FontPlatformData::setOrientation):
225         * platform/graphics/chromium/FontPlatformDataChromiumWin.h:
226         (WebCore::FontPlatformData::setOrientation):
227         * platform/graphics/chromium/FontPlatformDataLinux.h:
228         (WebCore::FontPlatformData::setOrientation):
229         * platform/graphics/cocoa/FontPlatformData.h:
230         (WebCore::FontPlatformData::setOrientation):
231         * platform/graphics/freetype/FontPlatformData.h:
232         (WebCore::FontPlatformData::setOrientation):
233         * platform/graphics/qt/FontPlatformData.h:
234         (WebCore::FontPlatformData::setOrientation):
235         * platform/graphics/wince/FontPlatformData.h:
236         (WebCore::FontPlatformData::setOrientation):
237         * platform/graphics/wx/FontPlatformData.h:
238         (WebCore::FontPlatformData::setOrientation):
239
240 2011-03-08  Joe Wild  <joseph.wild@nokia.com>
241
242         Reviewed by Csaba Osztrogon√°c.
243
244         [Qt] Missing SVG variables
245         https://bugs.webkit.org/show_bug.cgi?id=32941
246
247         Basically, this patch just modifies features.pri to the Qt build to
248         pass on the ENABLE_SVG_* flags to the IDL binding generator.
249
250         Also I had remove global-construtors.html from the skip list and
251         updated the associated expected results files.
252
253         * features.pri:
254         * page/DOMWindow.idl:
255
256 2011-03-08  Alok priyadarshi  <alokp@chromium.org>
257
258         Reviewed by Dimitri Glazkov.
259
260         Plugins needs a way to trigger style recalc
261         https://bugs.webkit.org/show_bug.cgi?id=55242
262
263         No test needed. A simple get function is added.
264
265         * platform/graphics/chromium/PluginLayerChromium.h:
266         (WebCore::PluginLayerChromium::getTextureId):
267
268 2011-03-08  David Hyatt  <hyatt@apple.com>
269
270         Reviewed by Dan Bernstein.
271
272         https://bugs.webkit.org/show_bug.cgi?id=48540, support the text-orientation CSS property.
273         
274         This patch adds support for two values of the text-orientation property (the ones that actually matter): vertical-right and upright.
275         The TextOrientation is part of the FontDescription and used to look up fonts (similar to FontOrientation).
276         
277         Orientation of non-CJK characters is done using fallback font data of the appropriate orientation type, e.g., verticalRightOrientation and
278         uprightOrientation fallback font data.  Vertical right is just implemented as a normal horizontal font.  Upright is implemented as a
279         vertically oriented font that rotates all glyphs.
280         
281         The main complication implementing text-orientation is that fonts have "baked-in" vertical glyphs for letters that are hardcoded to
282         a vertical right facing.  This means that you can use those special vertical glyphs for vertical-right orientation without having to 
283         fall back, but then for upright orientation you have to ignore them and still fall back.  As you can see from the test case, this doesn't
284         work very well, but hopefully it won't be all that common.  Limitations of CoreText prevent this case from rendering properly in either the
285         simple or complex code paths, although the simple code path at least gets close.
286
287         Added fast/blockflow/text-orientation-basic.html
288
289         * WebCore.exp.in:
290         * WebCore.xcodeproj/project.pbxproj:
291         * css/CSSComputedStyleDeclaration.cpp:
292         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
293         * css/CSSFontFaceSource.cpp:
294         (WebCore::CSSFontFaceSource::getFontData):
295         * css/CSSParser.cpp:
296         (WebCore::CSSParser::parseValue):
297         * css/CSSPrimitiveValueMappings.h:
298         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
299         (WebCore::CSSPrimitiveValue::operator TextOrientation):
300         * css/CSSPropertyNames.in:
301         * css/CSSStyleSelector.cpp:
302         (WebCore::CSSStyleSelector::applyDeclarations):
303         (WebCore::CSSStyleSelector::applyProperty):
304         * css/CSSValueKeywords.in:
305         * loader/cache/CachedFont.cpp:
306         (WebCore::CachedFont::platformDataFromCustomData):
307         * loader/cache/CachedFont.h:
308         * platform/graphics/FontCache.cpp:
309         (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
310         (WebCore::FontPlatformDataCacheKey::operator==):
311         (WebCore::computeHash):
312         (WebCore::FontCache::getCachedFontPlatformData):
313         * platform/graphics/FontDescription.h:
314         (WebCore::FontDescription::FontDescription):
315         (WebCore::FontDescription::textOrientation):
316         (WebCore::FontDescription::setTextOrientation):
317         (WebCore::FontDescription::operator==):
318         * platform/graphics/FontFastPath.cpp:
319         (WebCore::Font::glyphDataForCharacter):
320         (WebCore::offsetToMiddleOfGlyph):
321         * platform/graphics/SimpleFontData.cpp:
322         (WebCore::SimpleFontData::SimpleFontData):
323         (WebCore::SimpleFontData::verticalRightOrientationFontData):
324         (WebCore::SimpleFontData::uprightOrientationFontData):
325         (WebCore::SimpleFontData::brokenIdeographFontData):
326         (WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):
327         * platform/graphics/SimpleFontData.h:
328         (WebCore::SimpleFontData::hasVerticalGlyphs):
329         (WebCore::SimpleFontData::isTextOrientationFallback):
330         * platform/graphics/cairo/FontCustomPlatformData.h:
331         * platform/graphics/cocoa/FontPlatformData.h:
332         (WebCore::FontPlatformData::FontPlatformData):
333         (WebCore::FontPlatformData::textOrientation):
334         (WebCore::FontPlatformData::hash):
335         (WebCore::FontPlatformData::operator==):
336         * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
337         (WebCore::FontPlatformData::FontPlatformData):
338         (WebCore::FontPlatformData::operator=):
339         * platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
340         (WebCore::FontCustomPlatformData::fontPlatformData):
341         * platform/graphics/haiku/FontCustomPlatformData.cpp:
342         (WebCore::FontCustomPlatformData::fontPlatformData):
343         * platform/graphics/haiku/FontCustomPlatformData.h:
344         * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
345         (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
346         * platform/graphics/mac/FontCacheMac.mm:
347         (WebCore::FontCache::createFontPlatformData):
348         * platform/graphics/mac/FontCustomPlatformData.cpp:
349         (WebCore::FontCustomPlatformData::fontPlatformData):
350         * platform/graphics/mac/FontCustomPlatformData.h:
351         * platform/graphics/mac/FontMac.mm:
352         (WebCore::showGlyphsWithAdvances):
353         (WebCore::Font::drawGlyphs):
354         * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
355         (WebCore::shouldUseCoreText):
356         (WebCore::GlyphPage::fill):
357         * platform/graphics/mac/SimpleFontDataCoreText.cpp:
358         (WebCore::SimpleFontData::getCFStringAttributes):
359         * platform/graphics/mac/SimpleFontDataMac.mm:
360         (WebCore::SimpleFontData::platformInit):
361         (WebCore::SimpleFontData::platformBoundsForGlyph):
362         (WebCore::SimpleFontData::platformWidthForGlyph):
363         * platform/graphics/pango/FontCustomPlatformDataPango.cpp:
364         (WebCore::FontCustomPlatformData::fontPlatformData):
365         * platform/graphics/qt/FontCustomPlatformData.h:
366         * platform/graphics/qt/FontCustomPlatformDataQt.cpp:
367         (WebCore::FontCustomPlatformData::fontPlatformData):
368         * platform/graphics/skia/FontCustomPlatformData.cpp:
369         (WebCore::FontCustomPlatformData::fontPlatformData):
370         * platform/graphics/skia/FontCustomPlatformData.h:
371         * platform/graphics/win/FontCustomPlatformData.cpp:
372         (WebCore::FontCustomPlatformData::fontPlatformData):
373         * platform/graphics/win/FontCustomPlatformData.h:
374         * platform/graphics/win/FontCustomPlatformDataCairo.cpp:
375         (WebCore::FontCustomPlatformData::fontPlatformData):
376         * platform/graphics/win/FontCustomPlatformDataCairo.h:
377         * platform/graphics/wince/FontCustomPlatformData.cpp:
378         (WebCore::FontCustomPlatformData::fontPlatformData):
379         * platform/graphics/wince/FontCustomPlatformData.h:
380         * platform/text/TextOrientation.h: Added.
381         * rendering/InlineFlowBox.cpp:
382         (WebCore::InlineFlowBox::requiresIdeographicBaseline):
383         * rendering/style/RenderStyle.h:
384         (WebCore::InheritedFlags::initialTextOrientation):
385
386 2011-03-08  Ryosuke Niwa  <rniwa@webkit.org>
387
388         Reviewed by Darin Adler.
389
390         addInlineStyleIfNeeded should take EditingStyle
391         https://bugs.webkit.org/show_bug.cgi?id=55950
392
393         Deployed EditingStyle in addInlineStyleIfNeeded, StyleChange::StyleChange, and StyleChange::init.
394         Also extracted EditingStyle::styleIsPresentInComputedStyleOfNode from removeStyleFromRunBeforeApplyingStyle.
395
396         * editing/ApplyStyleCommand.cpp:
397         (WebCore::StyleChange::StyleChange): Takes EditingStyle instead of CSSStyleDeclaration.
398         (WebCore::StyleChange::init): Ditto.
399         (WebCore::ApplyStyleCommand::applyBlockStyle): Instantiates StyleChange.
400         (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Calls addInlineStyleIfNeeded.
401         (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Calls styleIsPresentInComputedStyleOfNode.
402         (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Calls EditingStyle::mergeInlineStyleOfElement
403         instead of manually merging styles.
404         (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Calls addInlineStyleIfNeeded.
405         (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Takes EditingStyle instead of CSSMutableStyleDeclaration.
406         * editing/ApplyStyleCommand.h:
407         * editing/CompositeEditCommand.h:
408         * editing/EditingStyle.cpp:
409         (WebCore::EditingStyle::styleIsPresentInComputedStyleOfNode): Extracted from removeStyleFromRunBeforeApplyingStyle.
410         * editing/EditingStyle.h:
411
412 2011-03-08  Nico Weber  <thakis@chromium.org>
413
414         Reviewed by James Robinson.
415
416         Crash on big blur radius with canvas
417         https://bugs.webkit.org/show_bug.cgi?id=55951
418
419         Move the clamping code out of an if branch, so that it happens in the
420         canvas case as well.
421
422         Test: fast/canvas/shadow-huge-blur.html
423
424         * platform/graphics/cg/GraphicsContextCG.cpp:
425         (WebCore::GraphicsContext::setPlatformShadow):
426
427 2011-03-08  Chris Fleizach  <cfleizach@apple.com>
428
429         Reviewed by Sam Weinig.
430
431         WK2: Cannot set focus on an element when focus is outside of WKView
432         https://bugs.webkit.org/show_bug.cgi?id=55281
433     
434         In WK2, focus cannot be set from the WebProcess side because there's no platformWidget().
435         Instead, the focus/unfocus messages need to be sent to the UIProcess side.
436
437         * platform/mac/WidgetMac.mm:
438         (WebCore::Widget::setFocus):
439
440 2011-03-08  Sam Weinig  <sam@webkit.org>
441
442         Reviewed by Anders Carlsson.
443
444         Overflow: scroll areas should not paint white in scroll corner if the 
445         scrollbars are overlay.
446         <rdar://problem/9082871>
447
448         * rendering/RenderLayer.cpp:
449         (WebCore::RenderLayer::paintScrollCorner):
450         Don't paint the scroll corner white if we have overlay scrollbars.
451
452 2011-03-08  Chris Marrin  <cmarrin@apple.com>
453
454         Reviewed by Darin Adler.
455
456         The first time animations are committed they have a bad start time
457         https://bugs.webkit.org/show_bug.cgi?id=55947
458
459         Do a check for a returned lastCommitTime of <=0 and replace it
460         with the mediaTime.
461
462
463         * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
464         (WebCore::CACFLayerTreeHost::notifyAnimationsStarted):
465
466 2011-03-08  James Kozianski  <koz@chromium.org>
467
468         Reviewed by David Levin.
469
470         Expose isValidProtocol() in KURL.h.
471         https://bugs.webkit.org/show_bug.cgi?id=54594
472
473         This is needed to validate protocols used in calls to
474         navigator.registerProtocolHandler().
475
476         * platform/KURL.cpp:
477         * platform/KURL.h:
478         * platform/KURLGoogle.cpp:
479         (WebCore::isValidProtocol):
480
481 2011-03-08  Adam Roben  <aroben@apple.com>
482
483         Set svn:mime-type to text/css for all Inspector CSS files
484
485         This will cause them to be served with the correct MIME type from svn.webkit.org's web
486         interface.
487
488         Rubber-stamped by Tim Hatcher.
489
490         * inspector/front-end/audits.css: Added property svn:mime-type.
491         * inspector/front-end/goToLineDialog.css: Added property svn:mime-type.
492         * inspector/front-end/heapProfiler.css: Added property svn:mime-type.
493         * inspector/front-end/helpScreen.css: Added property svn:mime-type.
494         * inspector/front-end/inspector.css: Added property svn:mime-type.
495         * inspector/front-end/inspectorSyntaxHighlight.css: Added property svn:mime-type.
496         * inspector/front-end/networkPanel.css: Added property svn:mime-type.
497         * inspector/front-end/popover.css: Added property svn:mime-type.
498         * inspector/front-end/textViewer.css: Added property svn:mime-type.
499
500 2011-03-08  Andrei Popescu  <andreip@google.com>
501
502         Reviewed by Steve Block.
503
504         IDBCallbacks::onsuccess(IDBIndex*) is unused and should be removed.
505         https://bugs.webkit.org/show_bug.cgi?id=55938
506
507         The IndexedDatabase specification changed and IDBIndex objects are no
508         longer created asynchronously. We therefore no longer need this method.
509
510         No new tests, just cleanup.
511
512         * storage/IDBCallbacks.h:
513         * storage/IDBRequest.cpp:
514         * storage/IDBRequest.h:
515
516 2011-03-08  Sheriff Bot  <webkit.review.bot@gmail.com>
517
518         Unreviewed, rolling out r80551.
519         http://trac.webkit.org/changeset/80551
520         https://bugs.webkit.org/show_bug.cgi?id=55933
521
522         It broke 285 tests on Qt bot (Requested by Ossy on #webkit).
523
524         * WebCore.pro:
525         * platform/SharedBuffer.cpp:
526         * platform/SharedBuffer.h:
527         * platform/network/qt/QNetworkReplyHandler.cpp:
528         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
529         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
530         (WebCore::QNetworkReplyHandler::forwardData):
531         (WebCore::QNetworkReplyHandler::start):
532         * platform/network/qt/QNetworkReplyHandler.h:
533         * platform/network/qt/ResourceHandleQt.cpp:
534         (WebCore::ResourceHandle::supportsBufferedData):
535         (WebCore::ResourceHandle::bufferedData):
536         * platform/qt/QtByteBlock.cpp: Removed.
537         * platform/qt/QtByteBlock.h: Removed.
538         * platform/qt/SharedBufferQt.cpp:
539
540 2011-03-08  Andreas Kling  <kling@webkit.org>
541
542         Reviewed by Benjamin Poulain.
543
544         RenderObject: Pass complex type arguments as const-references.
545
546         * WebCore.exp.in:
547         * rendering/RenderObject.h:
548         * rendering/RenderObject.cpp:
549         (WebCore::RenderObject::drawBoxSideFromPath):
550         (WebCore::RenderObject::drawArcForBoxSide):
551         (WebCore::RenderObject::localToAbsolute):
552         (WebCore::RenderObject::absoluteToLocal):
553
554 2011-03-08  Andreas Kling  <kling@webkit.org>
555
556         Reviewed by Antonio Gomes.
557
558         Path: Make measurement functions const
559         https://bugs.webkit.org/show_bug.cgi?id=55914
560
561         * platform/graphics/Path.cpp:
562         (WebCore::Path::length):
563         (WebCore::Path::pointAtLength):
564         (WebCore::Path::normalAngleAtLength):
565         * platform/graphics/Path.h:
566         * platform/graphics/cairo/PathCairo.cpp:
567         (WebCore::Path::strokeBoundingRect):
568         * platform/graphics/cg/PathCG.cpp:
569         (WebCore::Path::strokeBoundingRect):
570         * platform/graphics/openvg/PathOpenVG.cpp:
571         (WebCore::Path::strokeBoundingRect):
572         (WebCore::Path::length):
573         (WebCore::Path::pointAtLength):
574         (WebCore::Path::normalAngleAtLength):
575         * platform/graphics/qt/PathQt.cpp:
576         (WebCore::Path::strokeBoundingRect):
577         (WebCore::Path::length):
578         (WebCore::Path::pointAtLength):
579         (WebCore::Path::normalAngleAtLength):
580         * platform/graphics/skia/PathSkia.cpp:
581         (WebCore::Path::strokeBoundingRect):
582         * platform/graphics/wince/PathWinCE.cpp:
583         (WebCore::Path::strokeBoundingRect):
584         * platform/graphics/wx/PathWx.cpp:
585         (WebCore::Path::strokeBoundingRect):
586
587 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
588
589         Reviewed by Martin Robinson.
590
591         [GTK] Do not set juntion sides on scrollbar stepper buttons
592         https://bugs.webkit.org/show_bug.cgi?id=55868
593
594         Fixes rendering of steppers for themes using rounded stepper
595         buttons on scrollbars like Adwaita.
596
597         * platform/gtk/ScrollbarThemeGtk3.cpp:
598         (WebCore::ScrollbarThemeGtk::paintButton):
599
600 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
601
602         Reviewed by Martin Robinson.
603
604         [GTK] Use doubles instead of integers for coordinates when rendering arrows
605         https://bugs.webkit.org/show_bug.cgi?id=55866
606
607         To prevent off-by-one rounding errors.
608
609         * platform/gtk/RenderThemeGtk3.cpp:
610         (WebCore::RenderThemeGtk::paintMenuList):
611         * platform/gtk/ScrollbarThemeGtk3.cpp:
612         (WebCore::ScrollbarThemeGtk::paintButton):
613
614 2011-03-08  Markus Goetz  <guruz@guruz.de>
615
616         Reviewed by Kenneth Rohde Christiansen.
617
618         [Qt] Use the QNetworkAccessManager zerocopy feature
619         https://bugs.webkit.org/show_bug.cgi?id=50082
620
621         The feature will be introduced in Qt 4.8.
622         This patch is backwards compatible with Qt 4.7.
623
624         * WebCore.pro:
625         * platform/SharedBuffer.cpp:
626         * platform/SharedBuffer.h:
627         * platform/network/qt/QNetworkReplyHandler.cpp:
628         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
629         (WebCore::QNetworkReplyHandler::bufferedData):
630         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
631         (WebCore::QNetworkReplyHandler::downloadProgress):
632         (WebCore::QNetworkReplyHandler::forwardData):
633         (WebCore::QNetworkReplyHandler::start):
634         * platform/network/qt/QNetworkReplyHandler.h:
635         * platform/network/qt/ResourceHandleQt.cpp:
636         (WebCore::ResourceHandle::supportsBufferedData):
637         (WebCore::ResourceHandle::bufferedData):
638         * platform/qt/SharedBufferQt.cpp:
639         (WebCore::SharedBuffer::wrapQtByteBlock):
640         (WebCore::SharedBuffer::hasPlatformData):
641         (WebCore::SharedBuffer::platformData):
642         (WebCore::SharedBuffer::platformDataSize):
643         (WebCore::SharedBuffer::maybeTransferPlatformData):
644         (WebCore::SharedBuffer::clearPlatformData):
645
646 2011-03-08  Alejandro G. Castro  <alex@igalia.com>
647
648         Reviewed by Martin Robinson.
649
650         [GTK] Fix compilation warnings after r80429
651         https://bugs.webkit.org/show_bug.cgi?id=55864
652
653         * platform/gtk/WidgetGtk.cpp:
654
655 2011-03-08  Philippe Normand  <pnormand@igalia.com>
656
657         Unreviewed, GTK build fix after r80536
658
659         * GNUmakefile.am:
660
661 2011-03-08  Zan Dobersek  <zandobersek@gmail.com>
662
663         Reviewed by Martin Robinson.
664
665         [Gtk] toDataURL uses incorrect quality value when saving GdkPixbuf to buffer
666         https://bugs.webkit.org/show_bug.cgi?id=55878
667
668         Multiply the quality parameter by 100 to put it in the range [0, 100] as needed
669         when saving GdkPixbuf to a buffer.
670
671         * platform/graphics/gtk/ImageBufferGtk.cpp:
672         (WebCore::ImageBuffer::toDataURL):
673
674 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
675
676         Unreviewed.
677
678         Final build fix for r80536.
679
680         * DerivedSources.make:
681
682 2011-03-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
683
684         Reviewed by Kent Tamura.
685
686         [EFL] Adjust functions of WebCore's efl port to WebKit coding style
687         https://bugs.webkit.org/show_bug.cgi?id=55924
688
689         Adjust webkit style to PlatformKeyboardEventEfl, PlatformMouseEventEfl and WidgetEfl files.
690
691         * platform/efl/PlatformKeyboardEventEfl.cpp:
692         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
693         * platform/efl/PlatformMouseEventEfl.cpp:
694         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
695         * platform/efl/WidgetEfl.cpp:
696         (WebCore::Widget::frameRectsChanged):
697         (WebCore::Widget::setEvasObject):
698
699 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
700
701         Unreviewed.
702
703         More build fixes for r80536.
704
705         * CMakeLists.txt:
706         * platform/chromium/ClipboardChromium.cpp:
707         * platform/chromium/ClipboardChromium.h:
708
709 2011-03-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
710
711         Reviewed by Antonio Gomes.
712
713         [EFL] Adjust functions of ScrollbarEfl.cpp to WebKit coding style
714         https://bugs.webkit.org/show_bug.cgi?id=55917
715
716         Adjust webkit style to ScrollbarEfl files.
717
718         * platform/efl/ScrollbarEfl.cpp:
719         (scrollbarEflEdjeMessage):
720         (ScrollbarEfl::setParent):
721         (ScrollbarEfl::updateThumbPositionAndProportion):
722         (ScrollbarEfl::frameRectsChanged):
723         (ScrollbarEfl::paint):
724         * platform/efl/ScrollbarEfl.h:
725
726 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
727
728         Unreviewed.
729
730         Build fix for Chromium after r80536.
731
732         * platform/chromium/DataTransferItemChromium.cpp:
733         * platform/chromium/DataTransferItemsChromium.cpp:
734
735 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
736
737         Unreviewed.
738
739         More build fixes for r80536.
740
741         * CMakeLists.txt:
742         * platform/chromium/ClipboardChromium.cpp:
743         * platform/chromium/ClipboardChromium.h:
744
745 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
746
747         Reviewed by David Levin.
748
749         Add support for DataTransferItems
750         https://bugs.webkit.org/show_bug.cgi?id=55115
751
752         This patch adds stubs for DataTransferItems/DataTransferItem as well as implementing the
753         basic functionality on the Chromium port. With the exception of DataTransferItem::getAsFile,
754         all functionality on the DataTransferItems collection has been implemented.
755         This change does not actually hook up DataTransferItems to reflect the actual contents of a
756         drop/paste operation or to allow mutation of data in a copy/drag start yet. That will be
757         enabled via several followup patches.
758
759         Test: editing/pasteboard/data-transfer-items.html
760
761         * Android.mk:
762         * CMakeLists.txt:
763         * CodeGenerators.pri:
764         * DerivedSources.cpp:
765         * DerivedSources.make:
766         * GNUmakefile.am:
767         * WebCore.gypi:
768         * WebCore.pro:
769         * WebCore.vcproj/WebCore.vcproj:
770         * WebCore.xcodeproj/project.pbxproj:
771         * bindings/generic/RuntimeEnabledFeatures.cpp:
772         * bindings/generic/RuntimeEnabledFeatures.h:
773         (WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled):
774         (WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled):
775         * bindings/scripts/CodeGeneratorV8.pm: Do not emit an #include line for DOMString, since it's built-in.
776         * dom/Clipboard.h:
777         (WebCore::Clipboard::policy):
778         * dom/Clipboard.idl:
779         * dom/DataTransferItem.cpp: Added.
780         * dom/DataTransferItem.h: Added.
781         (WebCore::DataTransferItem::~DataTransferItem):
782         * dom/DataTransferItem.idl: Added.
783         * dom/DataTransferItems.h: Added.
784         (WebCore::DataTransferItems::~DataTransferItems):
785         * dom/DataTransferItems.idl: Added.
786         * dom/StringCallback.cpp: Added.
787         (WebCore::StringCallback::scheduleCallback):
788         * dom/StringCallback.h: Added.
789         (WebCore::StringCallback::~StringCallback):
790         * dom/StringCallback.idl: Added.
791         * platform/chromium/ClipboardChromium.cpp:
792         (WebCore::ClipboardChromium::items):
793         * platform/chromium/ClipboardChromium.h:
794         * platform/chromium/DataTransferItemChromium.cpp: Added.
795         (WebCore::DataTransferItemChromium::create):
796         (WebCore::DataTransferItemChromium::DataTransferItemChromium):
797         (WebCore::DataTransferItemChromium::kind):
798         (WebCore::DataTransferItemChromium::type):
799         (WebCore::DataTransferItemChromium::getAsString):
800         * platform/chromium/DataTransferItemChromium.h: Added.
801         * platform/chromium/DataTransferItemsChromium.cpp: Added.
802         (WebCore::DataTransferItemsChromium::create):
803         (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
804         (WebCore::DataTransferItemsChromium::length):
805         (WebCore::DataTransferItemsChromium::item):
806         (WebCore::DataTransferItemsChromium::deleteItem):
807         (WebCore::DataTransferItemsChromium::clear):
808         (WebCore::DataTransferItemsChromium::add):
809         * platform/chromium/DataTransferItemsChromium.h: Added.
810
811 2011-03-07  Ryosuke Niwa  <rniwa@webkit.org>
812
813         Reviewed by Darin Adler.
814
815         selectionHasStyle and selectionStartHasStyle should use EditingStyle
816         https://bugs.webkit.org/show_bug.cgi?id=55902
817
818         Deployed EditingStyle in selectionHasStyle and selectionStartHasStyle.
819         This allowed us to move triStateOfStyle from Editor.cpp to EditingStyle.cpp.
820
821         Also changed the argument lists of selectionHasStyle and selectionStartHasStyle
822         to take a property id and a value instead of a CSSMutableStyleDeclaration to cleanup
823         call sites of these two functions.
824
825         * WebCore.exp.in: Updated the signature of selectionHasStyle. No longer exports
826         selectionStartHasStyle because it's not called anywhere outside of WebCore.
827         * WebCore.order: Ditto.
828         * editing/EditingStyle.cpp:
829         (WebCore::EditingStyle::EditingStyle): Added a new constructor that takes a property id
830         and a property value.
831         (WebCore::EditingStyle::triStateOfStyle): Moved from Editor.cpp.
832         * editing/EditingStyle.h:
833         (WebCore::EditingStyle::create): Added.
834         * editing/Editor.cpp:
835         (WebCore::Editor::selectionStartHasStyle): Takes a property id and a value instead of
836         a CSSStyleDeclaration.
837         (WebCore::Editor::selectionHasStyle): Ditto.
838         * editing/Editor.h: Updated the signatures of selectionStartHasStyle and selectionHasStyle.
839         * editing/EditorCommand.cpp:
840         (WebCore::executeToggleStyle): Calls selectionStartHasStyle and selectionHasStyle.
841         (WebCore::stateStyle): Ditto.
842         * page/ContextMenuController.cpp:
843         (WebCore::ContextMenuController::checkOrEnableIfNeeded): Ditto.
844
845 2011-03-07  Alexey Proskuryakov  <ap@apple.com>
846
847         Reviewed by Darin Adler.
848
849         REGRESSION (HTML5 tree builder): Text selection in a large text document is extremely slow
850         https://bugs.webkit.org/show_bug.cgi?id=55898
851
852         <rdar://problem/9095839> REGRESSION: Mail hangs with a certain large mail message when
853         linkifying e-mail addresses in in -[DOMCharacterData setData:]
854
855         Changes render tree of fast/text/large-text-composed-char.html, but not image results.
856
857         * dom/CharacterData.cpp: (WebCore::CharacterData::parserAppendData):
858         Changed parserAppendData() to accept a maximum length, and moved code from Text::createWithLengthLimit().
859
860         * dom/CharacterData.h: Moved a constant for maximum length from Text.h.
861
862         * dom/Text.cpp: (WebCore::Text::createWithLengthLimit):
863         * dom/Text.h:
864         This function was unused in ToT. Moved code around to share with CharacterData.
865
866         * html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertTextNode):
867         Chnaged to split large text nodes while parsing again.
868
869 2011-03-07  Alice Boxhall  <aboxhall@chromium.org>
870
871         Reviewed by Adam Barth.
872
873         Fix platform/image-encoders/JPEGImageEncoder.cpp empty_output_buffer() behaviour
874         https://bugs.webkit.org/show_bug.cgi?id=54522
875
876         Fix jpegEmptyOutputBuffer() by ignoring free_in_buffer value as required.
877
878         No new tests, as this code is not yet used in WebKit. Once this code is used to implement canvas.toDataUrl(), the canvas tests will exercise it.
879
880         * platform/image-encoders/JPEGImageEncoder.cpp:
881         (WebCore::jpegEmptyOutputBuffer):
882
883 2011-03-07  Sergey Glazunov  <serg.glazunov@gmail.com>
884
885         Reviewed by Eric Seidel.
886
887         Add the missing insertedIntoDocument() call in SVGVKernElement and SVGHKernElement
888         https://bugs.webkit.org/show_bug.cgi?id=55896
889
890         Test: svg/dom/vkern-element-crash.html
891
892         * svg/SVGHKernElement.cpp:
893         (WebCore::SVGHKernElement::insertedIntoDocument):
894         * svg/SVGVKernElement.cpp:
895         (WebCore::SVGVKernElement::insertedIntoDocument):
896
897 2011-03-07  Sheriff Bot  <webkit.review.bot@gmail.com>
898
899         Unreviewed, rolling out r80514.
900         http://trac.webkit.org/changeset/80514
901         https://bugs.webkit.org/show_bug.cgi?id=55915
902
903         Caused assertion failures (Requested by ukai on #webkit).
904
905         * platform/graphics/skia/GraphicsContextSkia.cpp:
906         (WebCore::GraphicsContext::setPlatformShadow):
907         * platform/graphics/skia/ImageSkia.cpp:
908         (WebCore::paintSkBitmap):
909
910 2011-03-07  Cosmin Truta  <ctruta@chromium.org>
911
912         Reviewed by Adam Barth.
913
914         SVG <image> referenced by <use> is displayed incorrectly
915         https://bugs.webkit.org/show_bug.cgi?id=55750
916
917         The result of sourceURI must use the URL of the enclosing document as base.
918         Otherwise, the base may sometimes be empty, and, as a consequence,
919         the intermediate KURL object may be invalid.
920
921         Test: svg/custom/use-image-in-g.svg
922
923         * svg/SVGImageLoader.cpp:
924         (WebCore::SVGImageLoader::sourceURI):
925
926 2011-03-07  Helder Correia  <helder@sencha.com>
927
928         Reviewed by Simon Fraser.
929
930         Shadow is not shown when using strokeRect with a gradient strokeStyle
931         https://bugs.webkit.org/show_bug.cgi?id=52509
932
933         This happens in CG and is related to bug 51869, this time to be fixed
934         in GraphicsContext::strokeRect(const FloatRect& r, float lineWidth).
935         We need to draw the gradient clipped to the stroke on a CGLayer first,
936         and then draw the layer on the GraphicsContext.
937
938         Tests: fast/canvas/canvas-strokeRect-gradient-shadow.html
939                svg/css/rect-gradient-stroke-shadow.svg
940
941         * platform/graphics/cg/GraphicsContextCG.cpp:
942         (WebCore::GraphicsContext::strokeRect):
943
944 2011-03-07  Justin Novosad  <junov@chromium.org>
945
946         Reviewed by Kenneth Russell.
947
948         Fix for blurs behind bitmap images in Chromium, and boosting
949         shadow blur quality 
950         Bug URLs:
951                 https://bugs.webkit.org/show_bug.cgi?id=55410
952                 https://bugs.webkit.org/show_bug.cgi?id=55506
953
954         No new tests. Covered by existing layout tests. 
955
956         * platform/graphics/skia/GraphicsContextSkia.cpp:
957         (WebCore::GraphicsContext::setPlatformShadow): Turn on high quality shadows and fix shadow color
958         * platform/graphics/skia/ImageSkia.cpp:
959         (WebCore::paintSkBitmap): Propagate the draw looper from context to painter
960
961 2011-03-07  Andreas Kling  <kling@webkit.org>
962
963         Unreviewed Mac build fix after r80508.
964
965         * WebCore.exp.in:
966
967 2011-03-07  Enrica Casucci  <enrica@apple.com>
968
969         Unreviewed build fix.
970
971         Rolling back  http://trac.webkit.org/changeset/80497 due to the
972         32-bit build failures.
973
974         * WebCore.xcodeproj/project.pbxproj:
975         * platform/mac/HTMLConverter.h: Removed.
976         * platform/mac/HTMLConverter.mm: Removed.
977         * platform/mac/PasteboardMac.mm:
978         (WebCore::Pasteboard::writeSelection):
979
980 2011-03-07  Andreas Kling  <kling@webkit.org>
981
982         Reviewed by Benjamin Poulain.
983
984         FrameView::setBaseBackgroundColor: Pass Color argument as const-reference.
985
986         * page/FrameView.cpp:
987         (WebCore::FrameView::setBaseBackgroundColor):
988         * page/FrameView.h:
989
990 2011-03-07  Adam Barth  <abarth@webkit.org>
991
992         Reviewed by Dimitri Glazkov.
993
994         REGRESSION(r78147): Crash on http://gnarf.net/jquery/test/
995         https://bugs.webkit.org/show_bug.cgi?id=55894
996
997         The m_frame can disappear out from under us, and there's no point in
998         checking whether the load is complete in a non-existant frame.
999
1000         Test: fast/parser/document-write-into-initial-document.html
1001
1002         * dom/Document.cpp:
1003         (WebCore::Document::explicitClose):
1004
1005 2011-03-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1006
1007         Unreviewed, rolling out r80500.
1008         http://trac.webkit.org/changeset/80500
1009         https://bugs.webkit.org/show_bug.cgi?id=55908
1010
1011         Caused mysterious GYP error (Requested by abarth on #webkit).
1012
1013         * WebCore.gyp/WebCore.gyp:
1014         * WebCore.gypi:
1015
1016 2011-03-07  Adam Barth  <abarth@webkit.org>
1017
1018         Fix Chromium Mac build.  This header should only be included when the
1019         feature is enabled.
1020
1021         * platform/cf/RunLoopTimerCF.cpp:
1022
1023 2011-03-07  Adam Barth  <abarth@webkit.org>
1024
1025         Reviewed by Dimitri Glazkov.
1026
1027         Add WML files to WebCore.gypi
1028         https://bugs.webkit.org/show_bug.cgi?id=55905
1029
1030         * WebCore.gyp/WebCore.gyp:
1031         * WebCore.gypi:
1032
1033 2011-03-07  Adrienne Walker  <enne@google.com>
1034
1035         Reviewed by James Robinson.
1036
1037         [chromium] Add missing include to #define Skia parameter
1038         https://bugs.webkit.org/show_bug.cgi?id=55885
1039
1040         * platform/graphics/chromium/ShaderChromium.h:
1041
1042 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
1043
1044         Reviewed by Beth Dakin.
1045
1046         AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
1047         https://bugs.webkit.org/show_bug.cgi?id=55706
1048
1049         * WebCore.exp.in:
1050         * accessibility/AXObjectCache.cpp:
1051         (WebCore::AXObjectCache::rootObjectForFrame):
1052         * accessibility/AXObjectCache.h:
1053         * accessibility/AccessibilityScrollView.cpp:
1054         (WebCore::AccessibilityScrollView::isAttachment):
1055         (WebCore::AccessibilityScrollView::widgetForAttachmentView):
1056         * accessibility/AccessibilityScrollView.h:
1057         (WebCore::AccessibilityScrollView::firstChild):
1058         * accessibility/mac/AccessibilityObjectWrapper.mm:
1059         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
1060
1061 2011-03-07  Enrica Casucci  <enrica@apple.com>
1062
1063         Reviewed by Darin Adler.
1064         
1065         REGRESSION: Copied content loses formatting on paste to external apps.
1066         https://bugs.webkit.org/show_bug.cgi?id=47615
1067         <rdar://problem/9001214>
1068
1069         This is a resubmission of a patch that was landed a while ago then rolled
1070         back because of a build failure on SnowLeopard and Leopard.
1071         
1072         This patch adds a way for WebKit2 to create NSAttributedStrings from
1073         a DOM range without using the AppKit api initWithDOMRange that internally
1074         needs to access the WebView. The NSAttributedString is needed to create
1075         RTF formats in the pasteboard.
1076         This is to be considered a first step, since in the future we want to have
1077         an implementation based on the TextIterator.
1078
1079         * WebCore.xcodeproj/project.pbxproj: Added new file.
1080         * platform/mac/HTMLConverter.h: Added.
1081         * platform/mac/HTMLConverter.mm: Added.
1082         * platform/mac/PasteboardMac.mm:
1083         (WebCore::Pasteboard::writeSelection): We now use WebHTMLConverter
1084         class for WebKit2 to create the NSAttributedString from the DOM range.
1085
1086 2011-03-07  Adam Barth  <abarth@webkit.org>
1087
1088         Reviewed by Dimitri Glazkov.
1089
1090         Add some missing platform files to WebCore.gypi
1091         https://bugs.webkit.org/show_bug.cgi?id=55897
1092
1093         There are a bunch more, but this is a start.
1094
1095         * WebCore.gyp/WebCore.gyp:
1096         * WebCore.gypi:
1097
1098 2011-03-07  Steve Block  <steveblock@google.com>
1099
1100         Reviewed by Jeremy Orlow.
1101
1102         Rename JNIBridgeV8.cpp/h to JavaFieldV8.cpp/h
1103         https://bugs.webkit.org/show_bug.cgi?id=55879
1104
1105         No new tests, refactoring only.
1106
1107         * Android.v8bindings.mk:
1108         * WebCore.gypi:
1109         * bridge/jni/v8/JavaClassV8.cpp:
1110         * bridge/jni/v8/JavaClassV8.h:
1111         * bridge/jni/v8/JavaFieldV8.cpp: Renamed from Source/WebCore/bridge/jni/v8/JNIBridgeV8.cpp.
1112         (JavaField::JavaField):
1113         * bridge/jni/v8/JavaFieldV8.h: Renamed from Source/WebCore/bridge/jni/v8/JNIBridgeV8.h.
1114         (JSC::Bindings::JavaField::name):
1115         (JSC::Bindings::JavaField::type):
1116         (JSC::Bindings::JavaField::getJNIType):
1117         * bridge/jni/v8/JavaInstanceV8.cpp:
1118         * bridge/jni/v8/JavaNPObjectV8.cpp:
1119
1120 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
1121
1122         Reviewed by Tony Chang.
1123
1124         Add plumbing for paste support to ChromiumDataObject::types()
1125         https://bugs.webkit.org/show_bug.cgi?id=55792
1126
1127         This is a preliminary patch to support event.dataTransfer.items. This
1128         adds plumbing to support retrieving the types in a paste event. It also
1129         moves the check for files in a drag/paste up to ClipboardChromium, since
1130         internal code needs to be able to differentiate between actual files in
1131         a drag and someone that simply decided to use "Files" as a custom type
1132         string.
1133
1134         Test: editing/pasteboard/onpaste-text-html-types.html
1135
1136         * platform/chromium/ChromiumDataObject.cpp:
1137         (WebCore::ChromiumDataObject::types):
1138         (WebCore::ChromiumDataObject::containsFilenames):
1139         * platform/chromium/ChromiumDataObject.h:
1140         * platform/chromium/ClipboardChromium.cpp:
1141         (WebCore::ClipboardChromium::types):
1142         * platform/chromium/ClipboardMimeTypes.cpp:
1143         * platform/chromium/ClipboardMimeTypes.h:
1144
1145 2011-03-07  Takayoshi Kochi  <kochi@chromium.org>
1146
1147         Reviewed by Tony Chang.
1148
1149         [chromium] Use preferred locale information when choosing fallback
1150         font using fontconfig on Linux platform.
1151         http://bugs.webkit.org/show_bug.cgi?id=55453
1152
1153         No new tests, as it depends on ICU and locale setting, so it will be
1154         covered by Chromium side.
1155
1156         * platform/chromium/PlatformBridge.h:
1157         * platform/graphics/chromium/FontCacheLinux.cpp:
1158
1159 2011-03-07  Adam Barth  <abarth@webkit.org>
1160
1161         Reviewed by Eric Seidel.
1162
1163         Add gobject, cpp, and objc bindings to WebCore.gypi
1164         https://bugs.webkit.org/show_bug.cgi?id=55892
1165
1166         These are also excluded from the Chromium build but needed for various
1167         other ports.
1168
1169         * WebCore.gyp/WebCore.gyp:
1170         * WebCore.gypi:
1171
1172 2011-03-07  Sergey Glazunov  <serg.glazunov@gmail.com>
1173
1174         Reviewed by Dimitri Glazkov.
1175
1176         Node::checkAddChild and Node::checkReplaceChild shouldn't change the owner document of a node
1177         https://bugs.webkit.org/show_bug.cgi?id=55803
1178
1179         Test: fast/dom/dom-method-document-change.html
1180
1181         * dom/ContainerNode.cpp:
1182         (WebCore::ContainerNode::insertBefore):
1183         (WebCore::ContainerNode::replaceChild):
1184         (WebCore::ContainerNode::appendChild):
1185         * dom/Node.cpp:
1186         (WebCore::Node::checkReplaceChild):
1187         (WebCore::Node::checkAddChild):
1188         * dom/Node.h:
1189
1190 2011-03-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1191
1192         Unreviewed, rolling out r80484.
1193         http://trac.webkit.org/changeset/80484
1194         https://bugs.webkit.org/show_bug.cgi?id=55891
1195
1196         requires Chromium DEPS roll (Requested by dcheng on #webkit).
1197
1198         * platform/chromium/ChromiumDataObject.cpp:
1199         (WebCore::ChromiumDataObject::types):
1200         * platform/chromium/ChromiumDataObject.h:
1201         (WebCore::ChromiumDataObject::containsFilenames):
1202         * platform/chromium/ClipboardChromium.cpp:
1203         (WebCore::ClipboardChromium::types):
1204         * platform/chromium/ClipboardMimeTypes.cpp:
1205         * platform/chromium/ClipboardMimeTypes.h:
1206
1207 2011-03-07  Adam Barth  <abarth@webkit.org>
1208
1209         Reviewed by Dimitri Glazkov.
1210
1211         Add missing bindings/js files to WebCore.gypi
1212         https://bugs.webkit.org/show_bug.cgi?id=55888
1213
1214         These files are excluded from the Chromium build but needed for the Mac
1215         build.
1216
1217         * WebCore.gypi:
1218
1219 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
1220
1221         Reviewed by Tony Chang.
1222
1223         Add plumbing for paste support to ChromiumDataObject::types()
1224         https://bugs.webkit.org/show_bug.cgi?id=55792
1225
1226         This is a preliminary patch to support event.dataTransfer.items. This
1227         adds plumbing to support retrieving the types in a paste event. It also
1228         moves the check for files in a drag/paste up to ClipboardChromium, since
1229         internal code needs to be able to differentiate between actual files in
1230         a drag and someone that simply decided to use "Files" as a custom type
1231         string.
1232
1233         Test: editing/pasteboard/onpaste-text-html-types.html
1234
1235         * platform/chromium/ChromiumDataObject.cpp:
1236         (WebCore::ChromiumDataObject::types):
1237         (WebCore::ChromiumDataObject::containsFilenames):
1238         * platform/chromium/ChromiumDataObject.h:
1239         * platform/chromium/ClipboardChromium.cpp:
1240         (WebCore::ClipboardChromium::types):
1241         * platform/chromium/ClipboardMimeTypes.cpp:
1242         * platform/chromium/ClipboardMimeTypes.h:
1243
1244 2011-03-07  Joseph Pecoraro  <joepeck@webkit.org>
1245
1246         Reviewed by Kenneth Rohde Christiansen.
1247
1248         Viewport Warning/Error Messages Are Now Inaccurate
1249         https://bugs.webkit.org/show_bug.cgi?id=53707
1250
1251         Correct and improve the error messages for viewport parsing.
1252
1253         Tests: fast/viewport/viewport-warnings-1.html
1254                fast/viewport/viewport-warnings-2.html
1255                fast/viewport/viewport-warnings-3.html
1256                fast/viewport/viewport-warnings-4.html
1257                fast/viewport/viewport-warnings-5.html
1258                fast/viewport/viewport-warnings-6.html
1259
1260         * dom/ViewportArguments.cpp:
1261         (WebCore::numericPrefix):
1262         (WebCore::findSizeValue): remove incorrect device-width / height tips.
1263         (WebCore::setViewportFeature): report a warning for an unrecognized key.
1264         (WebCore::viewportErrorMessageTemplate): added template for unrecognized key.
1265         (WebCore::viewportErrorMessageLevel): classify an unrecognized key is an error.
1266         * dom/ViewportArguments.h: removed no longer used warnings.
1267
1268 2011-03-07  James Robinson  <jamesr@chromium.org>
1269
1270         Reviewed by Kenneth Russell.
1271
1272         [chromium] Separate the update and draw portions of LayerRendererChromium's drawLayers function
1273         https://bugs.webkit.org/show_bug.cgi?id=54047
1274
1275         This splits up LayerRendererChromium::drawLayers() into two phases,
1276         one that updates layers and one that actually draws them.  Most of the
1277         patch is moving the bodies of drawLayers() and updateLayersRecursive()
1278         into smaller helper functions.
1279
1280         The main entry point is renamed updateAndDrawLayers(), but otherwise
1281         has the same signature as drawLayers() did.  Internally it does the
1282         following:
1283
1284         1.) Updates the root layer's contents
1285         2.) Updates the root layer's scrollbars
1286         3.) Updates the RenderSurface tree and the contents of all child
1287         layers
1288         4.) Draws the root layer and root layer scrollbars
1289         5.) Draws all child layers using the previously updated
1290         CCLayerImpl/RenderSurface data.
1291
1292         A few things still need to be done after this patch to complete the separation
1293         of the update and draw step, but they can happen in later patches:
1294         *) The root layer and root layer scrollbars contents should be
1295         uploaded to textures at draw time, not update time.
1296         *) The RenderSurface tree should be updated at draw time, not update
1297         time.
1298
1299         Covered by the compositing/ tests.
1300
1301         * platform/graphics/chromium/LayerRendererChromium.cpp:
1302         (WebCore::LayerRendererChromium::LayerRendererChromium):
1303         (WebCore::LayerRendererChromium::updateRootLayerContents):
1304         (WebCore::LayerRendererChromium::updateRootLayerScrollbars):
1305         (WebCore::LayerRendererChromium::drawRootLayer):
1306         (WebCore::LayerRendererChromium::updateAndDrawLayers):
1307         (WebCore::LayerRendererChromium::updateLayers):
1308         (WebCore::LayerRendererChromium::drawLayers):
1309         (WebCore::LayerRendererChromium::getFramebufferPixels):
1310         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
1311         (WebCore::LayerRendererChromium::updateContentsRecursive):
1312         (WebCore::LayerRendererChromium::drawLayer):
1313         * platform/graphics/chromium/LayerRendererChromium.h:
1314         (WebCore::LayerRendererChromium::visibleRectSize):
1315         * platform/graphics/chromium/RenderSurfaceChromium.cpp:
1316         (WebCore::RenderSurfaceChromium::drawSurface):
1317         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
1318         * platform/graphics/chromium/cc/CCLayerImpl.h:
1319
1320 2011-03-07  Adam Barth  <abarth@webkit.org>
1321
1322         Reviewed by Eric Seidel.
1323
1324         Sort WebCore.gypi
1325         https://bugs.webkit.org/show_bug.cgi?id=55887
1326
1327         These files should be in order.  This is preparation for adding in the
1328         missing files.
1329
1330         * WebCore.gypi:
1331
1332 2011-03-07  Csaba Osztrogon√°c  <ossy@webkit.org>
1333
1334         Unreviewed buildfix after r80478.
1335
1336         * dom/Document.cpp: Add suggested parentheses to make GCC happy.
1337         (WebCore::Document::didReceiveTask):
1338
1339 2011-03-07  Yong Li  <yoli@rim.com>
1340
1341         Reviewed by Darin Adler.
1342
1343         Defer ScriptExecutionContext::Task's in Document when page loading is deferred.
1344         Schedule them with timer when page loading is resumed. The tasks will be performed
1345         in the original order. This fixes the problem that database callbacks could be missed
1346         when page loading was deferred.
1347         https://bugs.webkit.org/show_bug.cgi?id=49401
1348
1349         Manual test added: manual-tests/database-callback-deferred.html.
1350
1351         * dom/Document.cpp:
1352         (WebCore::Document::Document):
1353         (WebCore::Document::~Document):
1354         (WebCore::Document::didReceiveTask):
1355         (WebCore::Document::postTask):
1356         (WebCore::Document::pendingTasksTimerFired):
1357         (WebCore::Document::willDeferLoading):
1358         (WebCore::Document::didResumeLoading):
1359         * dom/Document.h:
1360         * manual-tests/database-callback-deferred.html: Added.
1361         * page/PageGroupLoadDeferrer.cpp:
1362         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
1363         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
1364
1365 2011-03-07  Antti Koivisto  <antti@apple.com>
1366
1367         Reviewed by Sam Weinig.
1368
1369         Use HashMaps for caching primitive values
1370         https://bugs.webkit.org/show_bug.cgi?id=55873
1371         
1372         Most documents use only small subset of cacheable primitive values. By replacing
1373         fixed size cache arrays with HashMaps we can reduce the constant memory usage while also
1374         expanding the range of cacheable values.
1375
1376         * css/CSSPrimitiveValueCache.cpp:
1377         (WebCore::CSSPrimitiveValueCache::CSSPrimitiveValueCache):
1378         (WebCore::CSSPrimitiveValueCache::createIdentifierValue):
1379         (WebCore::CSSPrimitiveValueCache::createColorValue):
1380         (WebCore::CSSPrimitiveValueCache::createValue):
1381         * css/CSSPrimitiveValueCache.h:
1382
1383 2011-03-07  Steve Block  <steveblock@google.com>
1384
1385         Reviewed by Jeremy Orlow.
1386
1387         Split JNIBridgeJSC.cpp/h into JavaArrayJSC.cpp/h and JavaFieldJSC.cpp/h
1388         https://bugs.webkit.org/show_bug.cgi?id=55881
1389
1390         No new tests, refactoring only.
1391
1392         * Android.jscbindings.mk:
1393         * GNUmakefile.am:
1394         * WebCore.xcodeproj/project.pbxproj:
1395         * bridge/jni/jsc/JNIBridgeJSC.cpp: Removed.
1396         * bridge/jni/jsc/JNIBridgeJSC.h: Removed.
1397         * bridge/jni/jsc/JNIUtilityPrivate.cpp:
1398         * bridge/jni/jsc/JavaClassJSC.cpp:
1399         * bridge/jni/jsc/JavaClassJSC.h:
1400         * bridge/jni/jsc/JavaInstanceJSC.cpp:
1401
1402 2011-03-07  Sam Weinig  <sam@webkit.org>
1403
1404         Reviewed by Anders Carlsson.
1405
1406         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
1407         https://bugs.webkit.org/show_bug.cgi?id=55827
1408
1409         * loader/EmptyClients.h:
1410         (WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForResponse):
1411         * loader/FrameLoaderClient.h:
1412         * loader/MainResourceLoader.cpp:
1413         (WebCore::MainResourceLoader::didReceiveResponse):
1414         * loader/PolicyChecker.cpp:
1415         (WebCore::PolicyChecker::checkContentPolicy):
1416         * loader/PolicyChecker.h:
1417         Rename FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
1418         and pass the entire response, instead of just the MIMEType.
1419
1420 2011-03-07  Eric Carlson  <eric.carlson@apple.com>
1421
1422         Reviewed by Darin Adler.
1423
1424         Add API to enumerate/delete files downloaded for <audio> and <video>
1425         https://bugs.webkit.org/show_bug.cgi?id=55267
1426         <rdar://problem/9049280>
1427
1428         No new tests, this is just more plumbing.
1429
1430         * html/HTMLMediaElement.cpp:
1431         (WebCore::HTMLMediaElement::getSitesInMediaCache): Make static, call MediaPlayer static method.
1432         (WebCore::HTMLMediaElement::clearMediaCache): Ditto.
1433         (WebCore::HTMLMediaElement::clearMediaCacheForSite): Ditto.
1434         * html/HTMLMediaElement.h:
1435
1436         * platform/graphics/MediaPlayer.cpp:
1437         (WebCore::MediaPlayerFactory::MediaPlayerFactory): Add new media engine factory functions.
1438         (WebCore::addMediaEngine): Ditto.
1439         (WebCore::MediaPlayer::getSitesInMediaCache): Call static method on all installed media engines.
1440         (WebCore::MediaPlayer::clearMediaCache): Ditto.
1441         (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
1442         * platform/graphics/MediaPlayer.h:
1443
1444         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
1445         (WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine): Update for MediaEngineRegistrar change.
1446
1447         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1448         (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Ditto.
1449
1450         * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
1451         (WebCore::MediaPlayerPrivatePhonon::registerMediaEngine): Ditto.
1452
1453         * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
1454         (WebCore::MediaPlayerPrivateQt::registerMediaEngine): Ditto.
1455
1456         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
1457         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::registerMediaEngine): Ditto.
1458
1459         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
1460         (WebCore::MediaPlayerPrivate::registerMediaEngine): Ditto.
1461
1462 2011-03-07  Steve Block  <steveblock@google.com>
1463
1464         Reviewed by Jeremy Orlow.
1465
1466         Split JNIBridge.cpp/h into JavaString.h and JavaMethod.cpp/h
1467         https://bugs.webkit.org/show_bug.cgi?id=55774
1468
1469         No new tests, refactoring only.
1470
1471         * Android.jscbindings.mk:
1472         * Android.v8bindings.mk:
1473         * GNUmakefile.am:
1474         * WebCore.gypi:
1475         * WebCore.xcodeproj/project.pbxproj:
1476         * bridge/jni/JavaMethod.cpp:
1477         (JavaMethod::JavaMethod):
1478         (JavaMethod::~JavaMethod):
1479         (appendClassName):
1480         (JavaMethod::signature):
1481         (JavaMethod::JNIReturnType):
1482         (JavaMethod::methodID):
1483         * bridge/jni/JavaMethod.h:
1484         (JSC::Bindings::JavaMethod::name):
1485         (JSC::Bindings::JavaMethod::returnType):
1486         (JSC::Bindings::JavaMethod::parameterAt):
1487         (JSC::Bindings::JavaMethod::numParameters):
1488         (JSC::Bindings::JavaMethod::isStatic):
1489         * bridge/jni/JavaString.h:
1490         (JSC::Bindings::JavaString::JavaString):
1491         (JSC::Bindings::JavaString::utf8):
1492         (JSC::Bindings::JavaString::length):
1493         (JSC::Bindings::JavaString::impl):
1494         * bridge/jni/jni_jsobject.mm:
1495         * bridge/jni/jsc/JNIBridgeJSC.h:
1496         * bridge/jni/v8/JNIBridgeV8.h:
1497         * bridge/jni/v8/JavaClassV8.cpp:
1498         * bridge/jni/v8/JavaClassV8.h:
1499         * bridge/jni/v8/JavaInstanceV8.cpp:
1500
1501 2011-03-07  Jeremy Orlow  <jorlow@chromium.org>
1502
1503         Reviewed by Steve Block.
1504
1505         Add source to IDBCursor, objectStore to IDBIndex, and remove storeName
1506         https://bugs.webkit.org/show_bug.cgi?id=55812
1507
1508         This brings us in line with what's in the spec:
1509         http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html
1510
1511         * storage/IDBCursor.cpp:
1512         (WebCore::IDBCursor::create):
1513         (WebCore::IDBCursor::IDBCursor):
1514         (WebCore::IDBCursor::source):
1515         * storage/IDBCursor.h:
1516         * storage/IDBCursor.idl:
1517         * storage/IDBCursorWithValue.cpp:
1518         (WebCore::IDBCursorWithValue::create):
1519         (WebCore::IDBCursorWithValue::IDBCursorWithValue):
1520         * storage/IDBCursorWithValue.h:
1521         * storage/IDBIndex.cpp:
1522         (WebCore::IDBIndex::IDBIndex):
1523         * storage/IDBIndex.h:
1524         (WebCore::IDBIndex::create):
1525         (WebCore::IDBIndex::objectStore):
1526         * storage/IDBIndex.idl:
1527         * storage/IDBObjectStore.cpp:
1528         (WebCore::IDBObjectStore::createIndex):
1529         (WebCore::IDBObjectStore::index):
1530         * storage/IDBRequest.cpp:
1531         (WebCore::IDBRequest::onSuccess):
1532
1533 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
1534
1535         Reviewed by Beth Dakin.
1536
1537         AX: kAXCellForColumnAndRowParameterizedAttribute doesn't work ARIA grids with colspans
1538         https://bugs.webkit.org/show_bug.cgi?id=55735
1539
1540         The ARIA grid implementation needed to verify the row/column range of a cell instead of 
1541         assuming a 1-1 mapping between children and row/column.
1542
1543         Test: platform/mac/accessibility/aria-table-with-colspan-cells.html
1544
1545         * accessibility/AccessibilityARIAGrid.cpp:
1546         (WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
1547
1548 2011-03-07  Andrei Popescu  <andreip@google.com>
1549
1550         Reviewed by Steve Block.
1551
1552         IDBRequest::onSuccess(IDBObjectStore*) should be removed as it is unused.
1553         IDBObjectStore objects used to be created asynchronously, so we needed
1554         this method to be invoked, with the new object store as the parameter,
1555         whenever the creation succeeded. The spec has changed so that IDBObjectStore
1556         objects are created synchronously, so this method is no longer needed.
1557         https://bugs.webkit.org/show_bug.cgi?id=55777
1558
1559         No new tests, just refactoring.
1560
1561         * storage/IDBCallbacks.h:
1562         * storage/IDBRequest.cpp:
1563         * storage/IDBRequest.h:
1564
1565 2011-03-04  Steve Block  <steveblock@google.com>
1566
1567         Reviewed by Jeremy Orlow.
1568
1569         JavaParameter should be removed
1570         https://bugs.webkit.org/show_bug.cgi?id=55772
1571
1572         No new tests, refactoring only.
1573
1574         * bridge/jni/JNIBridge.cpp:
1575         (JavaMethod::JavaMethod):
1576         (JavaMethod::~JavaMethod):
1577         (JavaMethod::signature):
1578         * bridge/jni/JNIBridge.h:
1579         (JSC::Bindings::JavaMethod::parameterAt):
1580         (JSC::Bindings::JavaMethod::numParameters):
1581         * bridge/jni/JNIUtility.h:
1582         * bridge/jni/jsc/JavaInstanceJSC.cpp:
1583         (JavaInstance::invokeMethod):
1584         * bridge/jni/v8/JNIUtilityPrivate.cpp:
1585         (JSC::Bindings::convertNPVariantToJValue):
1586         * bridge/jni/v8/JNIUtilityPrivate.h:
1587         * bridge/jni/v8/JavaInstanceV8.cpp:
1588         (JavaInstance::invokeMethod):
1589
1590 2011-03-07  Antti Koivisto  <antti@apple.com>
1591
1592         Reviewed by Oliver Hunt.
1593
1594         REGRESSION (r79574): fast/dom/global-constructors.html failing on Windows 7 Release (Tests) bots 
1595         https://bugs.webkit.org/show_bug.cgi?id=55166
1596         <rdar://problem/9050430>
1597         
1598         Make CSS primitive value cache per-document.
1599         
1600         Test: http/tests/security/cross-origin-css-primitive.html
1601
1602         * Android.mk:
1603         * CMakeLists.txt:
1604         * GNUmakefile.am:
1605         * WebCore.gypi:
1606         * WebCore.pro:
1607         * WebCore.vcproj/WebCore.vcproj:
1608         * WebCore.xcodeproj/project.pbxproj:
1609         * css/CSSComputedStyleDeclaration.cpp:
1610         (WebCore::valueForNinePieceImage):
1611         (WebCore::zoomAdjustedPixelValue):
1612         (WebCore::zoomAdjustedNumberValue):
1613         (WebCore::zoomAdjustedPixelValueForLength):
1614         (WebCore::valueForReflection):
1615         (WebCore::getPositionOffsetValue):
1616         (WebCore::CSSComputedStyleDeclaration::currentColorOrValidColor):
1617         (WebCore::getBorderRadiusCornerValue):
1618         (WebCore::computedTransform):
1619         (WebCore::getDelayValue):
1620         (WebCore::getDurationValue):
1621         (WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
1622         (WebCore::CSSComputedStyleDeclaration::valueForShadow):
1623         (WebCore::valueForFamily):
1624         (WebCore::renderTextDecorationFlagsToCSSValue):
1625         (WebCore::fillRepeatToCSSValue):
1626         (WebCore::fillSizeToCSSValue):
1627         (WebCore::contentToCSSValue):
1628         (WebCore::counterToCSSValue):
1629         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1630         * css/CSSParser.cpp:
1631         (WebCore::CSSParser::parseSheet):
1632         (WebCore::CSSParser::parseRule):
1633         (WebCore::CSSParser::parseKeyframeRule):
1634         (WebCore::CSSParser::parseValue):
1635         (WebCore::CSSParser::parseColor):
1636         (WebCore::CSSParser::parseSelector):
1637         (WebCore::CSSParser::parseDeclaration):
1638         (WebCore::CSSParser::setStyleSheet):
1639         (WebCore::CSSParser::parseWCSSInputProperty):
1640         (WebCore::parseBackgroundClip):
1641         (WebCore::CSSParser::parseFillShorthand):
1642         (WebCore::CSSParser::parsePage):
1643         (WebCore::CSSParser::parseSizeParameter):
1644         (WebCore::CSSParser::parseContent):
1645         (WebCore::CSSParser::parseAttr):
1646         (WebCore::CSSParser::parseBackgroundColor):
1647         (WebCore::CSSParser::parseFillPositionXY):
1648         (WebCore::CSSParser::parseFillPosition):
1649         (WebCore::CSSParser::parseFillRepeat):
1650         (WebCore::CSSParser::parseFillSize):
1651         (WebCore::CSSParser::parseFillProperty):
1652         (WebCore::CSSParser::parseAnimationDelay):
1653         (WebCore::CSSParser::parseAnimationDirection):
1654         (WebCore::CSSParser::parseAnimationDuration):
1655         (WebCore::CSSParser::parseAnimationFillMode):
1656         (WebCore::CSSParser::parseAnimationIterationCount):
1657         (WebCore::CSSParser::parseAnimationName):
1658         (WebCore::CSSParser::parseAnimationPlayState):
1659         (WebCore::CSSParser::parseAnimationProperty):
1660         (WebCore::CSSParser::parseTransformOriginShorthand):
1661         (WebCore::CSSParser::parseAnimationTimingFunction):
1662         (WebCore::CSSParser::parseDashboardRegions):
1663         (WebCore::CSSParser::parseCounterContent):
1664         (WebCore::CSSParser::parseShape):
1665         (WebCore::CSSParser::parseFont):
1666         (WebCore::CSSParser::parseFontFamily):
1667         (WebCore::CSSParser::parseFontStyle):
1668         (WebCore::CSSParser::parseFontVariant):
1669         (WebCore::CSSParser::parseFontWeight):
1670         (WebCore::ShadowParseContext::ShadowParseContext):
1671         (WebCore::ShadowParseContext::commitLength):
1672         (WebCore::ShadowParseContext::commitStyle):
1673         (WebCore::CSSParser::parseShadow):
1674         (WebCore::CSSParser::parseReflect):
1675         (WebCore::BorderImageParseContext::BorderImageParseContext):
1676         (WebCore::BorderImageParseContext::commitNumber):
1677         (WebCore::BorderImageParseContext::commitBorderImage):
1678         (WebCore::CSSParser::parseBorderImage):
1679         (WebCore::CSSParser::parseBorderRadius):
1680         (WebCore::CSSParser::parseCounter):
1681         (WebCore::parseDeprecatedGradientPoint):
1682         (WebCore::parseDeprecatedGradientColorStop):
1683         (WebCore::CSSParser::parseDeprecatedGradient):
1684         (WebCore::valueFromSideKeyword):
1685         (WebCore::parseGradientColorOrKeyword):
1686         (WebCore::CSSParser::parseLinearGradient):
1687         (WebCore::CSSParser::parseRadialGradient):
1688         (WebCore::CSSParser::parseGradientColorStops):
1689         (WebCore::CSSParser::parseTransform):
1690         (WebCore::CSSParser::parseTransformOrigin):
1691         (WebCore::CSSParser::parseTextEmphasisStyle):
1692         * css/CSSParser.h:
1693         (WebCore::CSSParser::primitiveValueCache):
1694         * css/CSSPrimitiveValue.cpp:
1695         * css/CSSPrimitiveValue.h:
1696         (WebCore::CSSPrimitiveValue::createIdentifier):
1697         (WebCore::CSSPrimitiveValue::createColor):
1698         (WebCore::CSSPrimitiveValue::create):
1699         * css/CSSPrimitiveValueCache.cpp: Added.
1700         (WebCore::CSSPrimitiveValueCache::CSSPrimitiveValueCache):
1701         (WebCore::CSSPrimitiveValueCache::~CSSPrimitiveValueCache):
1702         (WebCore::CSSPrimitiveValueCache::createIdentifierValue):
1703         (WebCore::CSSPrimitiveValueCache::createColorValue):
1704         (WebCore::CSSPrimitiveValueCache::createValue):
1705         * css/CSSPrimitiveValueCache.h: Added.
1706         (WebCore::CSSPrimitiveValueCache::create):
1707         (WebCore::CSSPrimitiveValueCache::createValue):
1708         * dom/Document.cpp:
1709         (WebCore::Document::cssPrimitiveValueCache):
1710         * dom/Document.h:
1711
1712 2011-03-06  Adam Barth  <abarth@webkit.org>
1713
1714         Reviewed by Eric Seidel.
1715
1716         Filter sources in WebCore GYP build for Mac
1717         https://bugs.webkit.org/show_bug.cgi?id=55857
1718
1719         This patch removes a large number of files that do not build as part of
1720         the Mac build.  I'm not fully sold on this method of
1721         including/excluding files, but it's the "gyp way" so we should probably
1722         try it first.
1723
1724         This patch also sets xcode_list_excluded_files to 0, which removes the
1725         excluded files from the Xcode project file, which is necessary in order
1726         to prevent the header map feature from including the wrong header file.
1727
1728         * gyp/WebCore.gyp:
1729
1730 2011-03-07  Ryuan Choi  <ryuan.choi@samsung.com>
1731
1732         Unreviewed EFL build fix.
1733
1734         [EFL] Build break on Debug build.
1735         https://bugs.webkit.org/show_bug.cgi?id=55858
1736
1737         * platform/efl/RenderThemeEfl.cpp:
1738         (WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):
1739
1740 2011-03-06  Adam Barth  <abarth@webkit.org>
1741
1742         Reviewed by Eric Seidel.
1743
1744         Add webcore_derived_source_files to WebCore.gypi
1745         https://bugs.webkit.org/show_bug.cgi?id=55856
1746
1747         This is the list of files generated by the Mac port.  It's possible
1748         other ports generate a different list of files.
1749
1750         * WebCore.gypi:
1751         * gyp/WebCore.gyp:
1752
1753 2011-03-06  Naoki Takano  <takano.naoki@gmail.com>
1754
1755         Reviewed by Kent Tamura.
1756
1757         Input type=number spin buttons remain invisible but functional after div changed from hidden to visible.
1758         https://bugs.webkit.org/show_bug.cgi?id=55839
1759         http://crbug.com/73866
1760         http://crbug.com/62527
1761
1762         We also need style change for m_innerSpinButton not only for m_outerSpinBuggon when styleDidChange() is called.
1763
1764         Test: fast/forms/input-appearance-spinbutton-visibility.html
1765
1766         * rendering/RenderTextControlSingleLine.cpp:
1767         (WebCore::RenderTextControlSingleLine::styleDidChange):
1768
1769 2011-03-06  Naoki Takano  <takano.naoki@gmail.com>
1770
1771         Reviewed by Kent Tamura.
1772
1773         [Chromium] Autocomplete suggestion extends out of window (and onto second monitor)
1774         https://bugs.webkit.org/show_bug.cgi?id=54795
1775
1776         Implement width clip logic according to browser screen width and popup window width. This fix is enough for Win and Mac, but there is a problem in Linux. Because WebScreenInfoFactory::screenInfo() can get only merged screen size, not the screen size where the browser exists.
1777
1778         Test: manual-tests/popup-width-restriction-within-screen.html
1779
1780         * manual-tests/popup-width-restriction-within-screen.html: Added.
1781         * platform/chromium/PopupMenuChromium.cpp:
1782         (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Implement the width clip logic according to screen width.
1783
1784 2011-03-06  Yuta Kitamura  <yutak@chromium.org>
1785
1786         Reviewed by Kent Tamura.
1787
1788         Add SHA-1 for new WebSocket protocol
1789         https://bugs.webkit.org/show_bug.cgi?id=55039
1790
1791         * ForwardingHeaders/wtf/SHA1.h: Added.
1792
1793 2011-03-06  Eric Carlson  <eric.carlson@apple.com>
1794
1795         Reviewed by Antti Koivisto.
1796
1797         QuickTime based media engines should respect private browsing mode
1798         https://bugs.webkit.org/show_bug.cgi?id=55848
1799
1800         No new tests, it is only possible to test this by manually deleting and monitoring the
1801         the Quicktime caches.
1802
1803         * html/HTMLMediaElement.cpp:
1804         (WebCore::HTMLMediaElement::privateBrowsingStateDidChange): Add logging.
1805
1806         * platform/graphics/MediaPlayer.cpp:
1807         (WebCore::MediaPlayer::MediaPlayer): Initialize m_privateBrowsing.
1808         (WebCore::MediaPlayer::loadWithNextMediaEngine): Set privacy mode on new media engine.
1809         (WebCore::MediaPlayer::setPrivateBrowsingMode): Stash setting in m_privateBrowsing.
1810         * platform/graphics/MediaPlayer.h:
1811         * platform/graphics/MediaPlayerPrivate.h:
1812         (WebCore::MediaPlayerPrivateInterface::setPrivateBrowsingMode):
1813
1814         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
1815         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1816         (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit): Initialize m_privateBrowsing.
1817         (WebCore::MediaPlayerPrivateQTKit::createQTMovie): Pass private browsing attribute when
1818             creating new movie.
1819         (WebCore::MediaPlayerPrivateQTKit::setPrivateBrowsingMode): New, store privacy setting in
1820             m_privateBrowsing and set movie attribute.
1821
1822         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
1823         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
1824             Initialize m_privateBrowsing.
1825         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::setPrivateBrowsingMode): New, store 
1826             privacy setting in m_privateBrowsing and call QTMovie.
1827         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
1828
1829         * platform/graphics/win/QTMovie.cpp:
1830         (QTMoviePrivate::QTMoviePrivate): Initialize m_privateBrowsing.
1831         (QTMovie::load):Pass private browsing property when creating new movie.
1832         (QTMovie::setPrivateBrowsingMode):  New, store privacy setting in m_privateBrowsing and 
1833             set movie property.
1834         * platform/graphics/win/QTMovie.h:
1835
1836 2011-03-06  Daniel Bates  <dbates@rim.com>
1837
1838         Reviewed by Darin Adler.
1839
1840         style.borderSpacing always returns empty string
1841         https://bugs.webkit.org/show_bug.cgi?id=54816
1842
1843         Teach CSSMutableStyleDeclaration::getPropertyValue() how to reconstitute
1844         the value for border-spacing from the value of the WebKit internal CSS
1845         property -webkit-border-horizontal-spacing and -webkit-border-vertical-spacing.
1846
1847         The CSS property border-spacing describes the horizontal and vertical border
1848         spacing for an HTML Table element. Notice, WebKit internally represents the value
1849         of this property as two properties: -webkit-border-horizontal-spacing and
1850         -webkit-border-vertical-spacing, for the horizontal and vertical border spacing,
1851         respectively. And WebKit doesn't know to reconstitute these internal properties.
1852         Therefore style.borderSpacing always returns the empty string.
1853
1854         Test: fast/css/table-border-spacing.html
1855
1856         * css/CSSMutableStyleDeclaration.cpp:
1857         (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
1858         (WebCore::CSSMutableStyleDeclaration::borderSpacingValue): Added.
1859         * css/CSSMutableStyleDeclaration.h:
1860
1861 2011-03-06  Dan Bernstein  <mitz@apple.com>
1862
1863         Reviewed by Oliver Hunt.
1864
1865         <rdar://problem/9093327> Implement -hyphenate-limit-{before,after}
1866         https://bugs.webkit.org/show_bug.cgi?id=55850
1867
1868         Tests: fast/css/parsing-hyphenate-limit.html
1869                fast/text/hyphenate-limit-before-after.html
1870
1871         * css/CSSComputedStyleDeclaration.cpp:
1872         (WebCore::computedProperties) Updated this array with the new properties and some old properties
1873         that it was missing.
1874         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added
1875         CSSPropertyWebkitHyphenateLimit{Before,After}.
1876
1877         * css/CSSParser.cpp:
1878         (WebCore::CSSParser::parseValue): Parse -webkit-hyphenate-limit-{before,after}, allowing
1879         'auto' and non-negative integers.
1880
1881         * css/CSSPropertyNames.in: Added -webkit-hyphenate-limit-{before,after}.
1882
1883         * css/CSSStyleSelector.cpp:
1884         (WebCore::CSSStyleSelector::applyProperty): Handle CSSPropertyWebkitHyphenateLimit{Before,After}.
1885
1886         * rendering/RenderBlockLineLayout.cpp:
1887         (WebCore::tryHyphenating): Added minimum prefix and suffix length parameters and checks to only
1888         allow hyphenation if the prefix and the suffix are sufficiently long.
1889         (WebCore::RenderBlock::findNextLineBreak): Pass the limits to tryHyphenating().
1890
1891         * rendering/style/RenderStyle.cpp:
1892         (WebCore::RenderStyle::diff): A difference in hyphenation limits is a layout difference.
1893
1894         * rendering/style/RenderStyle.h:
1895         (WebCore::InheritedFlags::hyphenationLimitBefore): Added.
1896         (WebCore::InheritedFlags::hyphenationLimitAfter): Added.
1897         (WebCore::InheritedFlags::setHyphenationLimitBefore): Added.
1898         (WebCore::InheritedFlags::setHyphenationLimitAfter): Added.
1899         (WebCore::InheritedFlags::initialHyphenationLimitBefore): Added. Returns -1, which is the
1900         representation of 'auto'.
1901         (WebCore::InheritedFlags::initialHyphenationLimitAfter): Ditto.
1902
1903         * rendering/style/StyleRareInheritedData.cpp:
1904         (WebCore::StyleRareInheritedData::StyleRareInheritedData): Initialize hyphenation limits.
1905         (WebCore::StyleRareInheritedData::operator==): Compare hyphenation limits.
1906         * rendering/style/StyleRareInheritedData.h:
1907
1908 2011-03-06  Jessie Berlin  <jberlin@apple.com>
1909
1910         Reviewed by Sam Weinig.
1911
1912         WebKit2: Use CFNetwork Sessions API.
1913         https://bugs.webkit.org/show_bug.cgi?id=55435.
1914
1915         When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
1916         Private Browsing Storage Session.
1917
1918         * WebCore.exp.in:
1919         Add the new WKSI functions.
1920         * platform/mac/WebCoreSystemInterface.h:
1921         Ditto.
1922         * platform/mac/WebCoreSystemInterface.mm:
1923         Ditto.
1924
1925         * platform/mac/CookieJar.mm:
1926         (WebCore::cookies):
1927         If USE(CFURLSTORAGESESSIONS) and there is a Private Browsing Cookie Storage, call into WKSI.
1928         Otherwise, behave the same as before.
1929         (WebCore::cookieRequestHeaderFieldValue):
1930         Ditto.
1931         (WebCore::setCookies):
1932         Ditto.
1933         (WebCore::cookiesEnabled):
1934         Ditto
1935         (WebCore::getRawCookies):
1936         Ditto.
1937         (WebCore::deleteCookie):
1938         Ditto.
1939
1940         * platform/network/CookieStorage.h:
1941         * platform/network/cf/CookieStorageCFNet.cpp:
1942         (WebCore::privateBrowsingCookieStorage):
1943         Keep track of the Private Browsing Cookie Storage in a locally defined static inside a
1944         function instead of at the global scope.
1945         (WebCore::currentCookieStorage):
1946         Use privateBrowsingCookieStorage.
1947         (WebCore::setCurrentCookieStorage):
1948         Ditto.
1949         (WebCore::setCookieStoragePrivateBrowsingEnabled):
1950         If USE(CFURLSTORAGESESSIONS), send the Private Browsing Storage Session to
1951         wkCreatePrivateInMemoryHTTPCookieStorage.
1952         * platform/network/mac/CookieStorageMac.mm:
1953         (WebCore::privateBrowsingCookieStorage):
1954         Keep track of the Private Browsing Cookie Storage.
1955         (WebCore::setCookieStoragePrivateBrowsingEnabled):
1956         If USE(CFURLSTORAGESESSIONS), then set or clear privateBrowsingCookieStorage().
1957         Added a FIXME to observe changes to the Private Browsing Cookie Storage when it is defined.
1958
1959         * platform/network/mac/ResourceHandleMac.mm:
1960         (WebCore::shouldRelaxThirdPartyCookiePolicy):
1961         Refactor the logic to determine whether or not to relax the third party cookie policy here.
1962         If USE(CFURLSTORAGESESSIONS), then get the information from the privateBrowsingCookieStorage.
1963         (WebCore::ResourceHandle::createNSURLConnection):
1964         Use shouldRelaxThirdPartyCookiePolicy.
1965         (WebCore::ResourceHandle::loadResourceSynchronously):
1966         Ditto.
1967
1968 2011-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1969
1970         Unreviewed, rolling out r80428.
1971         http://trac.webkit.org/changeset/80428
1972         https://bugs.webkit.org/show_bug.cgi?id=55833
1973
1974         Broke SnowLeopard (Requested by xan_ on #webkit).
1975
1976         * plugins/gtk/PluginViewGtk.cpp:
1977         (WebCore::PluginView::handlePostReadFile):
1978
1979 2011-03-01  Martin Robinson  <mrobinson@igalia.com>
1980
1981         Reviewed by Xan Lopez.
1982
1983         [GTK] Windowless plugins override the view cursor
1984         https://bugs.webkit.org/show_bug.cgi?id=55531
1985
1986         manual test: manual-tests/plugins/windowless.html
1987
1988         * platform/gtk/WidgetGtk.cpp:
1989         (WebCore::Widget::setCursor): Call into the ChromeClient implementation now.
1990         * plugins/gtk/PluginViewGtk.cpp:
1991         (WebCore::PluginView::initXEvent): Instead of setting the window for windowless
1992         plugin events, set the window value to none. This method is also used to send
1993         focus in / focus out events to windowed plugins, but this is not one of the plugin
1994         types where the window parameter matters. This matches what Mozilla does. Also
1995         pass in the display of the widget itself, not the default display.
1996         (WebCore::PluginView::handleMouseEvent): When the cursor leaves the plugin area,
1997         reset the cursor.
1998         (WebCore::PluginView::platformGetValue): Clean up this section slightly. Give the
1999         widget the top-level window explicitly. This matches Mozilla.
2000
2001 2011-03-05  Martin Robinson  <mrobinson@igalia.com>
2002
2003         Reviewed by Xan Lopez.
2004
2005         [GTK] http/tests/plugins/post-url-file.html fails on GTK+
2006         https://bugs.webkit.org/show_bug.cgi?id=55826
2007
2008         Correct the implementation of handlePostReadFile which uses GIO APIs and
2009         actually resizes the buffer to fit the entire size of the file data. This
2010         was likely leading to memory corruption until now.
2011
2012         * plugins/gtk/PluginViewGtk.cpp:
2013         (WebCore::PluginView::handlePostReadFile): Fix this method.
2014
2015 2011-03-05  Mikhail Naganov  <mnaganov@chromium.org>
2016
2017         Reviewed by Pavel Feldman.
2018
2019         Web Inspector: [Chromium] Allow dynamic enabling of detailed heap profiles.
2020         https://bugs.webkit.org/show_bug.cgi?id=55824
2021
2022         Detailed heap profiles can be now enabled by typing "leakz" in Profiles tab.
2023
2024         * inspector/front-end/DetailedHeapshotView.js:
2025         (WebInspector.DetailedHeapshotView.prototype.isDetailedSnapshot):
2026         * inspector/front-end/ProfilesPanel.js:
2027         (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
2028         (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
2029         (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
2030         (WebInspector.ProfilesPanel.prototype.handleShortcut):
2031         (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint.hideHint):
2032         (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint):
2033         (WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles):
2034         (WebInspector.ProfilesPanel.prototype._recognizeKeyboardCombo):
2035
2036 2011-03-05  Qi Zhang  <qi.2.zhang@nokia.com>
2037
2038         Reviewed by Laszlo Gombos.
2039
2040         [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
2041         https://bugs.webkit.org/show_bug.cgi?id=48636
2042
2043         Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.
2044
2045         * WebCore.pri:
2046         * features.pri:
2047
2048 2011-03-05  Pavel Feldman  <pfeldman@chromium.org>
2049
2050         Not reviewed: adding null check to prevent inspector tests from failing.
2051
2052         * inspector/front-end/TextViewer.js:
2053         (WebInspector.TextEditorGutterChunk.prototype.get offsetTop):
2054         (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
2055
2056 2011-03-05  Pavel Feldman  <pfeldman@chromium.org>
2057
2058         Not reviewed: chromium rebaseline, flaky test fix.
2059
2060         * inspector/front-end/BreakpointManager.js:
2061         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
2062         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
2063         (WebInspector.DOMBreakpointView.prototype._format.formatters.s):
2064         (WebInspector.DOMBreakpointView.prototype._format.append):
2065         (WebInspector.DOMBreakpointView.prototype._format):
2066
2067 2011-03-04  Pavel Podivilov  <podivilov@chromium.org>
2068
2069         Reviewed by Yury Semikhatsky.
2070
2071         Web Inspector: [chromium] pause when script is running is broken.
2072         https://bugs.webkit.org/show_bug.cgi?id=55762
2073
2074         * inspector/CodeGeneratorInspector.pm:
2075
2076 2011-03-05  Adam Barth  <abarth@webkit.org>
2077
2078         Reviewed by Dimitri Glazkov.
2079
2080         Add Derived Sources to WebCore GYP build
2081         https://bugs.webkit.org/show_bug.cgi?id=55813
2082
2083         Adding the derived source action to the GYP file required tweaking
2084         DerivedSources.make.  I'm not sure how DerivedSources.make worked
2085         before beause these paths were incorrectly based.
2086
2087         * DerivedSources.make:
2088         * gyp/generate-derived-sources.sh: Added.
2089         * gyp/WebCore.gyp:
2090
2091 2011-03-04  Pavel Feldman  <pfeldman@chromium.org>
2092
2093         Reviewed by Yury Semikhatsky.
2094
2095         Web Inspector: fix layout tests flakiness.
2096         https://bugs.webkit.org/show_bug.cgi?id=55816
2097
2098         - Order of issuing of evaluateForTestInFrontend was not guaranteed on the backend side (InspectorAgent side)
2099         - Order of dispatching using timeouts was guaranteed via queueing. Source of all kinds of pains on SnowLeopard Release (inspector.js)
2100
2101         * inspector/CodeGeneratorInspector.pm:
2102         * inspector/InspectorAgent.cpp:
2103         (WebCore::InspectorAgent::InspectorAgent):
2104         (WebCore::InspectorAgent::disconnectFrontend):
2105         (WebCore::InspectorAgent::populateScriptObjects):
2106         (WebCore::InspectorAgent::evaluateForTestInFrontend):
2107         (WebCore::InspectorAgent::issueEvaluateForTestCommands):
2108         * inspector/InspectorAgent.h:
2109         * inspector/front-end/TimelinePanel.js:
2110         (WebInspector.TimelinePanel.FormattedRecord):
2111         * inspector/front-end/inspector.js:
2112         (WebInspector.dispatch):
2113
2114 2011-03-05  Adam Barth  <abarth@webkit.org>
2115
2116         Reviewed by Dimitri Glazkov.
2117
2118         WebCore GYP build should generate fewer than 10,000 compile errors per file
2119         https://bugs.webkit.org/show_bug.cgi?id=55810
2120
2121         This patch adds some missing include paths.  We need to figure out how
2122         to handle separate include paths per port.  It's clear that
2123         ForwardingHeaders are only useful for Mac, but it's less clear how to
2124         handle the others.
2125
2126         * WebCore.gypi:
2127         * gyp/WebCore.gyp:
2128
2129 2011-03-05  Dan Bernstein  <mitz@apple.com>
2130
2131         Reviewed by Cameron Zwarich.
2132
2133         <rdar://problem/9082946> Make the Core Text code path in GlyphPage::fill() more robust
2134         https://bugs.webkit.org/show_bug.cgi?id=55817
2135
2136         * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
2137         (WebCore::GlyphPage::fill): When determining if a CTRun uses the primary font, compare against
2138         a CGFont obtained from Core Text for the primary font. This CGFont may be different from
2139         the CGFont stored in the FontPlatformData.
2140
2141 2011-03-05  Ilya Sherman  <isherman@chromium.org>
2142
2143         Reviewed by Darin Adler.
2144
2145         HTMLInputElement::setValue() should schedule change event when the element is focused.
2146         Refactored tracking of "changed since last change event" state from renderer to DOM.In service of https://code.google.com/p/chromium/issues
2147         In service of https://code.google.com/p/chromium/issues/detail?id=42716
2148         https://bugs.webkit.org/show_bug.cgi?id=53160
2149
2150         Test: fast/forms/onchange-change-type.html
2151         Test: fast/forms/onchange-setvalueforuser.html
2152
2153         * WebCore.exp.in:
2154         * dom/Document.cpp:
2155         (WebCore::Document::setFocusedNode):
2156         * dom/Element.h:
2157         (WebCore::Element::wasChangedSinceLastFormControlChangeEvent): Added.
2158         (WebCore::Element::setChangedSinceLastFormControlChangeEvent): Added.
2159         * html/HTMLFormControlElement.cpp:
2160         (WebCore::HTMLFormControlElement::HTMLFormControlElement):
2161         (WebCore::HTMLFormControlElement::wasChangedSinceLastFormControlChangeEvent): Added.
2162         (WebCore::HTMLFormControlElement::setChangedSinceLastFormControlChangeEvent): Added.
2163         (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): Also clear the "changed since last change event" flag.
2164         (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): Also set the "changed since last change event" flag.
2165         * html/HTMLFormControlElement.h:
2166         * html/HTMLInputElement.cpp:
2167         (WebCore::HTMLInputElement::updateType): Also clear the "changed since last change event" flag.
2168         (WebCore::HTMLInputElement::setValue):
2169             For a focused text field, dispatch an input event, but delay the change event until the field loses focus.
2170         (WebCore::HTMLInputElement::defaultEventHandler):
2171         (WebCore::HTMLInputElement::stepUpFromRenderer):
2172         * html/shadow/TextControlInnerElements.cpp:
2173         (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
2174         * rendering/RenderTextControl.cpp:
2175         (WebCore::RenderTextControl::RenderTextControl):
2176         (WebCore::RenderTextControl::subtreeHasChanged):
2177         * rendering/RenderTextControl.h:
2178         * rendering/RenderTextControlMultiLine.cpp:
2179         (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
2180         * rendering/RenderTextControlSingleLine.cpp:
2181         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
2182         * wml/WMLInputElement.cpp:
2183         (WebCore::WMLInputElement::WMLInputElement):
2184         (WebCore::WMLInputElement::defaultEventHandler):
2185         * wml/WMLInputElement.h:
2186         (WebCore::WMLInputElement::wasChangedSinceLastFormControlChangeEvent): Added.
2187         (WebCore::WMLInputElement::setChangedSinceLastFormControlChangeEvent): Added.
2188
2189 2011-03-04  Xianzhu Wang  <wangxianzhu@google.com>
2190
2191         Reviewed by Adam Barth.
2192
2193         Remove fake request loading of SVGImage to avoid MainResourceLoader
2194         leak. The frame->init() already ensures initialization of the
2195         document loader.
2196
2197         https://bugs.webkit.org/show_bug.cgi?id=55017
2198
2199         Test: fast/images/svg-image-leak-loader.html
2200
2201         * svg/graphics/SVGImage.cpp:
2202         (WebCore::SVGImage::dataChanged):
2203
2204 2011-03-04  Mike Reed  <reed@google.com>
2205
2206         Reviewed by Mihai Parparita.
2207
2208         [Chromium] fast/canvas/canvas-arc-360-winding.html fails on Linux and Windows
2209         https://bugs.webkit.org/show_bug.cgi?id=49477
2210
2211         * platform/graphics/skia/PathSkia.cpp:
2212         (WebCore::Path::addArc):
2213
2214 2011-03-04  Jia Pu  <jpu@apple.com>
2215
2216         Reviewed by Darin Adler.
2217
2218         On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
2219         https://bugs.webkit.org/show_bug.cgi?id=55717
2220         <rdar://problem/9018127>
2221
2222         manual-test: manual-tests/platforms/mac/autocorrection/autocorrection-in-iframe.html
2223
2224         Previously, the bounding box passed into EditorClient::showCorrectionPanel() is in the frame's
2225         coordinate. This is incorrect when the correction occurs in an iframe. This patch added code
2226         to convert the bounding box to window coordinate using ScrollView::contentToWindow().
2227
2228         * dom/Range.cpp:
2229         (WebCore::Range::getBoundingClientRect):
2230         (WebCore::Range::boundingRect):
2231         * dom/Range.h:
2232         * editing/Editor.cpp:
2233         (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
2234         (WebCore::Editor::correctionPanelTimerFired):
2235         (WebCore::Editor::windowRectForRange):
2236         * editing/Editor.h:
2237         * manual-tests/autocorrection/autocorrection-in-iframe.html: Added.
2238         * manual-tests/autocorrection/document-for-iframe-test.html: Added.
2239
2240 2011-03-04  Jia Pu  <jpu@apple.com>
2241
2242         Reviewed by Darin Adler.
2243
2244         Those checking in Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited() should be done with VisiblePosition::isNull().
2245         https://bugs.webkit.org/show_bug.cgi?id=55731
2246
2247         No new tests. There's no behavioral change.
2248
2249         This patch improved clarity and readability of Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited().
2250
2251         * editing/Editor.cpp:
2252         (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
2253
2254 2011-03-04  John Bauman  <jbauman@chromium.org>
2255
2256         Reviewed by Kenneth Russell.
2257
2258         [chromium] premultipliedAlpha WebGL context attribute is ignored.
2259         https://bugs.webkit.org/show_bug.cgi?id=55411
2260
2261         Update compositor to set the blending of each layer correctly.
2262
2263         Test: compositing/webgl/webgl-nonpremultiplied-blend.html
2264
2265         * platform/graphics/chromium/CanvasLayerChromium.cpp:
2266         (WebCore::CanvasLayerChromium::CanvasLayerChromium):
2267         (WebCore::CanvasLayerChromium::draw):
2268         * platform/graphics/chromium/CanvasLayerChromium.h:
2269         * platform/graphics/chromium/ContentLayerChromium.cpp:
2270         (WebCore::ContentLayerChromium::draw):
2271         * platform/graphics/chromium/LayerRendererChromium.cpp:
2272         (WebCore::LayerRendererChromium::drawLayers):
2273         * platform/graphics/chromium/WebGLLayerChromium.cpp:
2274         (WebCore::WebGLLayerChromium::setContext):
2275
2276 2011-03-04  Adam Barth  <abarth@webkit.org>
2277
2278         Reviewed by Eric Seidel.
2279
2280         WebCore GYP build should link with the correct frameworks
2281         https://bugs.webkit.org/show_bug.cgi?id=55804
2282
2283         * gyp/WebCore.gyp:
2284
2285 2011-03-04  Adam Barth  <abarth@webkit.org>
2286
2287         Reviewed by Eric Seidel.
2288
2289         WebCore GYP build should Check For Inappropriate Files in Framework
2290         https://bugs.webkit.org/show_bug.cgi?id=55806
2291
2292         * gyp/WebCore.gyp:
2293
2294 2011-03-04  Dimitri Glazkov  <dglazkov@chromium.org>
2295
2296         Reviewed by Adam Barth.
2297
2298         Add skeletal WebCore.gyp
2299         https://bugs.webkit.org/show_bug.cgi?id=55802
2300
2301         This doesn't yet build, but the basic structure is there.
2302
2303         * WebCore.gypi: Added headers and include directories variables.
2304         * gyp/WebCore.gyp: Added.
2305
2306 2011-03-04  Adam Barth  <abarth@webkit.org>
2307
2308         Reviewed by Dimitri Glazkov.
2309
2310         Remove unneeded round-trips through ../Source in the Chromium GYP build
2311         https://bugs.webkit.org/show_bug.cgi?id=55795
2312
2313         This is just cleanup work, but it was bugging me.
2314
2315         * WebCore.gyp/WebCore.gyp:
2316
2317 2011-03-04  Mike Reed  <reed@google.com>
2318
2319         Reviewed by James Robinson.
2320
2321         Option to use skia's native text drawing APIs when drawing text
2322         on Windows, rather than from outlines using drawPath(). This will
2323         only have a significant effect when the skia-gpu backend is enabled.
2324         https://bugs.webkit.org/show_bug.cgi?id=55609
2325
2326         No new tests. This is disabled by default. When enabled, it will draw
2327         essentially the same, but with slightly different antialiased edges, due
2328         to differences between the current scanconverter and GDI's font scaler.
2329         When enabled, we will have to recalibrate layouttest image results. 
2330
2331         * platform/graphics/skia/SkiaFontWin.cpp:
2332         (WebCore::skiaDrawText):
2333         (WebCore::setupPaintForFont):
2334         (WebCore::paintSkiaText):
2335
2336 2011-03-04  Adrienne Walker  <enne@google.com>
2337
2338         Reviewed by James Robinson.
2339
2340         [chromium] Fix texture stride issues on large content and image layers.
2341         https://bugs.webkit.org/show_bug.cgi?id=55679
2342
2343         This was an error caused during the refactoring in r80081.
2344
2345         Tests: LayoutTests/compositing/tiling/huge-layer-img.html
2346
2347         * platform/graphics/chromium/ContentLayerChromium.cpp:
2348         (WebCore::ContentLayerChromium::updateTexture):
2349         * platform/graphics/chromium/ImageLayerChromium.cpp:
2350         (WebCore::ImageLayerChromium::updateTextureIfNeeded):
2351
2352 2011-03-04  Sheriff Bot  <webkit.review.bot@gmail.com>
2353
2354         Unreviewed, rolling out r80379.
2355         http://trac.webkit.org/changeset/80379
2356         https://bugs.webkit.org/show_bug.cgi?id=55799
2357
2358         "Breaks leopard compile (implicit conversion)" (Requested by
2359         tonyg-cr on #webkit).
2360
2361         * css/CSSStyleSelector.cpp:
2362         (WebCore::convertToLength):
2363         (WebCore::CSSStyleSelector::applyProperty):
2364         (WebCore::CSSStyleSelector::createTransformOperations):
2365         * platform/Length.h:
2366         (WebCore::Length::Length):
2367         (WebCore::Length::operator==):
2368         (WebCore::Length::operator!=):
2369         (WebCore::Length::rawValue):
2370         (WebCore::Length::type):
2371         (WebCore::Length::quirk):
2372         (WebCore::Length::setValue):
2373         (WebCore::Length::setRawValue):
2374         (WebCore::Length::calcFloatValue):
2375         (WebCore::Length::isZero):
2376         (WebCore::Length::blend):
2377         * rendering/AutoTableLayout.cpp:
2378         (WebCore::AutoTableLayout::recalcColumn):
2379         (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
2380         * rendering/FixedTableLayout.cpp:
2381         (WebCore::FixedTableLayout::calcWidthArray):
2382
2383 2011-03-04  Jessie Berlin  <jberlin@apple.com>
2384
2385         Reviewed by Darin Adler.
2386
2387         WebKit2: Use CFNetwork Sessions API.
2388         https://bugs.webkit.org/show_bug.cgi?id=55435.
2389
2390         Add in the CFURLSTORAGESESSIONS guards that I incorrectly left out because the code was
2391         contained within guards that made USE(CFURLSTORAGESESSIONS) always be true.
2392
2393         * platform/network/cf/ResourceHandleCFNet.cpp:
2394         (WebCore::makeFinalRequest):
2395         (WebCore::ResourceHandle::willSendRequest):
2396         * platform/network/cf/ResourceRequestCFNet.cpp:
2397         * platform/network/mac/ResourceHandleMac.mm:
2398         (WebCore::ResourceHandle::createNSURLConnection):
2399         (WebCore::ResourceHandle::willSendRequest):
2400         * platform/network/mac/ResourceRequestMac.mm:
2401
2402 2011-03-04  Yuqiang Xian  <yuqiang.xian@intel.com>
2403
2404         Reviewed by Darin Adler.
2405
2406         improve layout performance by reducing the traversal time of the floating objects
2407         https://bugs.webkit.org/show_bug.cgi?id=55440
2408
2409         We observered large overhead on traversing the floating objects list
2410         in logicalLeftOffsetForLine() and logicalRightOffsetForLine() especially
2411         when the list becomes enormous, for example in the default 30x30 maze test
2412         from http://ie.microsoft.com/testdrive/Performance/MazeSolver/Default.html
2413         there're >3700 floating objects. When placing a new floating object the
2414         entire list (from begin to end) is traversed for multiple times.
2415         There's a low hanging fruit to reduce the chances to do the traversal
2416         which is especially applicable in logicalLeftOffsetForLine and logicalRightOffsetForLine.
2417         As the two routines either cares about FloatLeft objects or FloatRight objects only,
2418         if we know there's no corresponding type floating objects in the list
2419         we can avoid the traversal actually. One thing we could do is to record
2420         the number of FloatLeft objects and the number of FloatRight objects and
2421         add a check before doing the traversal. This can reduce the time by 45%
2422         to resolve the 30x30 Maze measured on N470 Netbook MeeGo using latest
2423         Chromium browser 11 (from 503s to 269s).
2424
2425         No new tests, relying on existing layout tests.
2426
2427         * rendering/RenderBlock.cpp:
2428         (WebCore::RenderBlock::~RenderBlock):
2429         (WebCore::RenderBlock::addOverflowFromFloats):
2430         (WebCore::RenderBlock::repaintOverhangingFloats):
2431         (WebCore::RenderBlock::paintFloats):
2432         (WebCore::RenderBlock::selectionGaps):
2433         (WebCore::RenderBlock::insertFloatingObject):
2434         (WebCore::RenderBlock::removeFloatingObject):
2435         (WebCore::RenderBlock::removeFloatingObjectsBelow):
2436         (WebCore::RenderBlock::positionNewFloats):
2437         (WebCore::RenderBlock::positionNewFloatOnLine):
2438         (WebCore::RenderBlock::logicalLeftOffsetForLine):
2439         (WebCore::RenderBlock::logicalRightOffsetForLine):
2440         (WebCore::RenderBlock::nextFloatLogicalBottomBelow):
2441         (WebCore::RenderBlock::lowestFloatLogicalBottom):
2442         (WebCore::RenderBlock::clearFloats):
2443         (WebCore::RenderBlock::addOverhangingFloats):
2444         (WebCore::RenderBlock::addIntrudingFloats):
2445         (WebCore::RenderBlock::containsFloat):
2446         (WebCore::RenderBlock::hitTestFloats):
2447         (WebCore::RenderBlock::adjustForBorderFit):
2448         (WebCore::RenderBlock::FloatingObjects::clear):
2449         (WebCore::RenderBlock::FloatingObjects::increaseObjectsCount):
2450         (WebCore::RenderBlock::FloatingObjects::decreaseObjectsCount):
2451         * rendering/RenderBlock.h:
2452         (WebCore::RenderBlock::containsFloats):
2453         (WebCore::RenderBlock::FloatingObjects::FloatingObjects):
2454         (WebCore::RenderBlock::FloatingObjects::hasLeftObjects):
2455         (WebCore::RenderBlock::FloatingObjects::hasRightObjects):
2456         (WebCore::RenderBlock::FloatingObjects::set):
2457         * rendering/RenderBlockLineLayout.cpp:
2458         (WebCore::RenderBlock::layoutInlineChildren):
2459         (WebCore::RenderBlock::matchedEndLine):
2460
2461 2011-03-04  Rik Cabanier  <cabanier@gmail.com>
2462
2463         Reviewed by David Hyatt.
2464
2465         Fix that allows fixed length values to be floating point
2466         https://bugs.webkit.org/show_bug.cgi?id=52699
2467
2468         * WebCore.xcodeproj/project.pbxproj:
2469         * css/CSSStyleSelector.cpp:
2470         (WebCore::convertToLength):
2471         (WebCore::convertToIntLength):
2472         (WebCore::convertToFloatLength):
2473         (WebCore::CSSStyleSelector::applyProperty):
2474         (WebCore::CSSStyleSelector::createTransformOperations):
2475         * platform/Length.h:
2476         (WebCore::Length::Length):
2477         (WebCore::Length::operator==):
2478         (WebCore::Length::operator!=):
2479         (WebCore::Length::rawValue):
2480         (WebCore::Length::type):
2481         (WebCore::Length::quirk):
2482         (WebCore::Length::setValue):
2483         (WebCore::Length::calcFloatValue):
2484         (WebCore::Length::isZero):
2485         (WebCore::Length::blend):
2486         (WebCore::Length::getIntValue):
2487         (WebCore::Length::getFloatValue):
2488         * rendering/AutoTableLayout.cpp:
2489         (WebCore::AutoTableLayout::recalcColumn):
2490         (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
2491         * rendering/FixedTableLayout.cpp:
2492         (WebCore::FixedTableLayout::calcWidthArray):
2493
2494 2011-03-04  Steve Falkenburg  <sfalken@apple.com>
2495
2496         Reviewed by Jon Honeycutt.
2497
2498         Adopt VersionStamper tool for Windows WebKit DLLs
2499         https://bugs.webkit.org/show_bug.cgi?id=55784
2500         
2501         We now use a tool to stamp the version number onto the Apple WebKit DLLs
2502         during the post-build step.
2503
2504         * WebCore.vcproj/QTMovieWin.rc: Removed.
2505         * WebCore.vcproj/QTMovieWin.vcproj:
2506         * WebCore.vcproj/QTMovieWinPostBuild.cmd: Stamp version with VersionStamper.
2507         * WebCore.vcproj/QTMovieWinPreBuild.cmd: Don't run auto-version.sh. We don't use autoversion.h in this project.
2508         * WebCore.vcproj/WebCoreMediaQT.vsprops: Remove unnecessary include paths for resource files.
2509
2510 2011-03-04  Cosmin Truta  <ctruta@chromium.org>
2511
2512         Reviewed by Adam Barth.
2513
2514         Clarify comment about potential memory leak in SVGImage
2515         https://bugs.webkit.org/show_bug.cgi?id=55362
2516
2517         No functionality change. No new tests.
2518
2519         * svg/graphics/SVGImage.cpp:
2520         (WebCore::SVGImage::dataChanged):
2521
2522 2011-03-04  Jessie Berlin  <jberlin@apple.com>
2523
2524         Reviewed by Maciej Stachowiak.
2525
2526         WebKit2: Use CFNetwork Sessions API.
2527         https://bugs.webkit.org/show_bug.cgi?id=55435.
2528
2529         When Private Browsing is enabled, get the cached url response from the cache associated with
2530         the Private Browsing Storage Session.
2531
2532         * WebCore.exp.in:
2533         Export the symbol for ResourceHandle::privateBrowsingStorageSession.
2534
2535 2011-03-04  Steve Block  <steveblock@google.com>
2536
2537         Reviewed by Jeremy Orlow.
2538
2539         JSC and V8 versions of Java bridge should share JobjectWrapper
2540         https://bugs.webkit.org/show_bug.cgi?id=55763
2541
2542         No new tests, refactoring only.
2543
2544         * Android.jscbindings.mk:
2545         * Android.v8bindings.mk:
2546         * WebCore.gypi:
2547         * WebCore.order:
2548         * WebCore.xcodeproj/project.pbxproj:
2549         * bridge/jni/JobjectWrapper.cpp:
2550         (JobjectWrapper::JobjectWrapper):
2551         (JobjectWrapper::~JobjectWrapper):
2552         * bridge/jni/JobjectWrapper.h:
2553         (JSC::Bindings::JobjectWrapper::instance):
2554         (JSC::Bindings::JobjectWrapper::setInstance):
2555         (JSC::Bindings::JobjectWrapper::ref):
2556         (JSC::Bindings::JobjectWrapper::deref):
2557         * bridge/jni/jsc/JNIBridgeJSC.cpp:
2558         (JavaField::JavaField):
2559         (JavaArray::JavaArray):
2560         * bridge/jni/jsc/JNIBridgeJSC.h:
2561         * bridge/jni/jsc/JavaInstanceJSC.cpp:
2562         (JavaInstance::JavaInstance):
2563         * bridge/jni/jsc/JavaInstanceJSC.h:
2564
2565 2011-03-04  Patrick Gansterer  <paroga@webkit.org>
2566
2567         Reviewed by Nikolas Zimmermann.
2568
2569         Move shared code into SVGStyledTransformableElement::svgAttributeChanged
2570         https://bugs.webkit.org/show_bug.cgi?id=55771
2571
2572         All sub classes of SVGStyledTransformableElement request a relayout
2573         the same way. So move that code into the common base class.
2574
2575         * svg/SVGCircleElement.cpp:
2576         (WebCore::SVGCircleElement::svgAttributeChanged):
2577         * svg/SVGEllipseElement.cpp:
2578         (WebCore::SVGEllipseElement::svgAttributeChanged):
2579         * svg/SVGForeignObjectElement.cpp:
2580         (WebCore::SVGForeignObjectElement::svgAttributeChanged):
2581         * svg/SVGGElement.cpp:
2582         (WebCore::SVGGElement::svgAttributeChanged):
2583         * svg/SVGImageElement.cpp:
2584         (WebCore::SVGImageElement::svgAttributeChanged):
2585         * svg/SVGLineElement.cpp:
2586         (WebCore::SVGLineElement::svgAttributeChanged):
2587         * svg/SVGPathElement.cpp:
2588         (WebCore::SVGPathElement::svgAttributeChanged):
2589         * svg/SVGPolyElement.cpp:
2590         (WebCore::SVGPolyElement::svgAttributeChanged):
2591         * svg/SVGRectElement.cpp:
2592         (WebCore::SVGRectElement::svgAttributeChanged):
2593         * svg/SVGStyledTransformableElement.cpp:
2594         (WebCore::SVGStyledTransformableElement::svgAttributeChanged):
2595         * svg/SVGStyledTransformableElement.h:
2596         * svg/SVGUseElement.cpp:
2597         (WebCore::SVGUseElement::svgAttributeChanged):
2598
2599 2011-03-03  John Abd-El-Malek  <jam@chromium.org>
2600
2601         Reviewed by Dimitri Glazkov.
2602
2603         [chromium] Get rid of IsContentFiltered flags since they&apos;re not used anymore
2604         https://bugs.webkit.org/show_bug.cgi?id=55748
2605
2606         * platform/network/chromium/ResourceResponse.cpp:
2607         (WebCore::ResourceResponse::doPlatformCopyData):
2608         (WebCore::ResourceResponse::doPlatformAdopt):
2609         * platform/network/chromium/ResourceResponse.h:
2610         (WebCore::ResourceResponse::ResourceResponse):
2611
2612 2011-03-03  Timothy Hatcher  <timothy@apple.com>
2613
2614         Export SerializedScriptValue::create(JSC::ExecState* exec, JSC::JSValue value).
2615
2616         Reviewed by Darin Adler.
2617
2618         * WebCore.exp.in: Added __ZN7WebCore21SerializedScriptValue6createEPN3JSC9ExecStateENS1_7JSValueE.
2619
2620 2011-03-04  Pavel Podivilov  <podivilov@chromium.org>
2621
2622         Reviewed by Yury Semikhatsky.
2623
2624         Web Inspector: extract all code that depends on source mapping from SourceFrame.
2625         https://bugs.webkit.org/show_bug.cgi?id=55464
2626
2627         Extract all dependencies on DebuggerModel and ScriptsPanel to a delegate class
2628         to encapsulate source mapping aspects from SourceFrame.
2629
2630         * inspector/front-end/ResourceView.js:
2631         (WebInspector.ResourceView.createResourceView):
2632         (WebInspector.SourceFrameDelegateForResourcesPanel):
2633         (WebInspector.SourceFrameDelegateForResourcesPanel.prototype.requestContent):
2634         * inspector/front-end/ScriptsPanel.js:
2635         (WebInspector.ScriptsPanel.prototype._createSourceFrame):
2636         (WebInspector.SourceFrameDelegateForScriptsPanel):
2637         * inspector/front-end/SourceFrame.js:
2638         (WebInspector.SourceFrame):
2639         (WebInspector.SourceFrame.prototype.show):
2640         (WebInspector.SourceFrame.prototype._createTextViewer):
2641         (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
2642         (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
2643         (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
2644         (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition):
2645         (WebInspector.SourceFrame.prototype._contextMenu.else.setBreakpointEnabled):
2646         (WebInspector.SourceFrame.prototype._contextMenu):
2647         (WebInspector.SourceFrame.prototype._mouseDown):
2648         (WebInspector.SourceFrame.prototype._mouseMove):
2649         (WebInspector.SourceFrame.prototype._hidePopup):
2650         (WebInspector.SourceFrame.prototype._mouseHover):
2651         (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
2652         (WebInspector.SourceFrame.prototype._showPopup):
2653         (WebInspector.SourceFrame.prototype._doubleClick):
2654         (WebInspector.SourceFrame.prototype._didEditLine):
2655         (WebInspector.SourceFrameDelegate):
2656         (WebInspector.SourceFrameDelegate.prototype.requestContent):
2657         (WebInspector.SourceFrameDelegate.prototype.debuggingSupported):
2658         (WebInspector.SourceFrameDelegate.prototype.setBreakpoint):
2659         (WebInspector.SourceFrameDelegate.prototype.removeBreakpoint):
2660         (WebInspector.SourceFrameDelegate.prototype.updateBreakpoint):
2661         (WebInspector.SourceFrameDelegate.prototype.findBreakpoint):
2662         (WebInspector.SourceFrameDelegate.prototype.continueToLine):
2663         (WebInspector.SourceFrameDelegate.prototype.canEditScriptSource):
2664         (WebInspector.SourceFrameDelegate.prototype.editScriptSource):
2665         (WebInspector.SourceFrameDelegate.prototype.debuggerPaused):
2666         (WebInspector.SourceFrameDelegate.prototype.evaluate):
2667         (WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):
2668
2669 2011-03-04  Andrey Kosyakov  <caseq@chromium.org>
2670
2671         Reviewed by Pavel Feldman.
2672
2673         Web Inspector: [Extensions API] maintain own, unique & persistent identifiers for resources.
2674         https://bugs.webkit.org/show_bug.cgi?id=55686
2675
2676         - Use internal ids for resources in extension server.
2677         - Log errors in inspector tests.
2678
2679         * inspector/front-end/ExtensionServer.js:
2680         (WebInspector.ExtensionServer):
2681         (WebInspector.ExtensionServer.prototype.resetResources):
2682         (WebInspector.ExtensionServer.prototype._notifyResourceFinished):
2683         (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
2684         (WebInspector.ExtensionServer.prototype._onGetHAR):
2685         (WebInspector.ExtensionServer.prototype._onGetResourceContent):
2686         (WebInspector.ExtensionServer.prototype._resourceId):
2687         (WebInspector.ExtensionServer.prototype._resourceById):
2688         * inspector/front-end/HAREntry.js:
2689         (WebInspector.HARLog):
2690         (WebInspector.HARLog.prototype._convertResource):
2691         * inspector/front-end/NetworkPanel.js:
2692         (WebInspector.NetworkPanel.prototype._reset):
2693
2694 2011-03-04  Andrey Kosyakov  <caseq@chromium.org>
2695
2696         Reviewed by Pavel Feldman.
2697
2698         Web Inspector: exceptions when building context menu in network panel
2699         https://bugs.webkit.org/show_bug.cgi?id=55678
2700
2701         * inspector/front-end/DataGrid.js:
2702         (WebInspector.DataGrid.prototype.dataGridNodeFromNode):
2703         (WebInspector.DataGrid.prototype.dataGridNodeFromPoint):
2704         * inspector/front-end/NetworkPanel.js:
2705         (WebInspector.NetworkPanel.prototype._contextMenu):
2706
2707 2011-03-04  Ilya Sherman  <isherman@chromium.org>
2708
2709         Reviewed by James Robinson.
2710
2711         Override paintScrollCorner() for FramelessScrollView to forego any custom scrollbar corner rendering.
2712         This was previously done in ScrollbarThemeChromium, but we also need this on the Mac when the ScrollView
2713         is a FramelessScrollView -- which is mostly just for Autofill.
2714         In service of http://crbug.com/73772 (crash)
2715         https://bugs.webkit.org/show_bug.cgi?id=55557
2716
2717         No tests added because this fix is Chromium-specific and the code is currently untestable from within WebKit.
2718         In particular, DRT crashes when trying to render a FramelessScrollView.
2719
2720         * platform/ScrollbarTheme.h:
2721         (WebCore::ScrollbarTheme::paintScrollCorner): Body moved to static function defaultPaintScrollCorner().
2722         (WebCore::ScrollbarTheme::defaultPaintScrollCorner): Added.
2723         * platform/chromium/FramelessScrollView.cpp:
2724         (WebCore::FramelessScrollView::paintContents):
2725         (WebCore::FramelessScrollView::paintScrollCorner): Fix implementation moved to here from ScrollbarThemeChromium
2726         * platform/chromium/FramelessScrollView.h:
2727         * platform/chromium/ScrollbarThemeChromium.cpp:
2728         * platform/chromium/ScrollbarThemeChromium.h:
2729
2730 2011-03-04  Yury Semikhatsky  <yurys@chromium.org>
2731
2732         Reviewed by Pavel Feldman.
2733
2734         Web Inspector: move dispatching of didCommitLoad to agents into InspectorInstrumentation
2735         https://bugs.webkit.org/show_bug.cgi?id=55770
2736
2737         * inspector/InspectorAgent.cpp:
2738         (WebCore::InspectorAgent::InspectorAgent):
2739         (WebCore::InspectorAgent::didCommitLoad):
2740         * inspector/InspectorCSSAgent.cpp:
2741         (WebCore::InspectorCSSAgent::InspectorCSSAgent):
2742         (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
2743         * inspector/InspectorCSSAgent.h:
2744         * inspector/InspectorDatabaseAgent.cpp:
2745         (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
2746         * inspector/InspectorInstrumentation.cpp:
2747         (WebCore::InspectorInstrumentation::didCommitLoadImpl):
2748         * inspector/InspectorInstrumentation.h:
2749         (WebCore::InspectorInstrumentation::didCommitLoad):
2750         * inspector/InspectorProfilerAgent.cpp:
2751         (WebCore::InspectorProfilerAgent::create):
2752         (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
2753         (WebCore::InspectorProfilerAgent::~InspectorProfilerAgent):
2754         (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
2755         (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
2756         (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
2757         (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
2758         * inspector/InspectorProfilerAgent.h:
2759         * inspector/InstrumentingAgents.h:
2760         (WebCore::InstrumentingAgents::InstrumentingAgents):
2761         (WebCore::InstrumentingAgents::inspectorCSSAgent):
2762         (WebCore::InstrumentingAgents::setInspectorCSSAgent):
2763         (WebCore::InstrumentingAgents::inspectorDOMStorageAgent):
2764         (WebCore::InstrumentingAgents::setInspectorDOMStorageAgent):
2765         (WebCore::InstrumentingAgents::inspectorDatabaseAgent):
2766         (WebCore::InstrumentingAgents::setInspectorDatabaseAgent):
2767         (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent):
2768         (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
2769         (WebCore::InstrumentingAgents::inspectorDebuggerAgent):
2770         (WebCore::InstrumentingAgents::setInspectorDebuggerAgent):
2771         (WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent):
2772         (WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent):
2773         (WebCore::InstrumentingAgents::inspectorProfilerAgent):
2774         (WebCore::InstrumentingAgents::setInspectorProfilerAgent):
2775
2776 2011-03-04  Ilya Tikhonovsky  <loislo@chromium.org>
2777
2778         Reviewed by Yury Semikhatsky.
2779
2780         Web Inspector: rename RuntimeAgent's function from releaseWrapperObjectGroup to releaseObjectGroup.
2781         https://bugs.webkit.org/show_bug.cgi?id=55773
2782
2783         * inspector/CodeGeneratorInspector.pm:
2784         * inspector/InjectedScript.cpp:
2785         (WebCore::InjectedScript::releaseObjectGroup):
2786         * inspector/InjectedScript.h:
2787         * inspector/InjectedScriptHost.cpp:
2788         (WebCore::InjectedScriptHost::releaseObjectGroup):
2789         * inspector/InjectedScriptHost.h:
2790         * inspector/InjectedScriptSource.js:
2791         (.):
2792         * inspector/Inspector.idl:
2793         * inspector/InspectorConsoleAgent.cpp:
2794         (WebCore::InspectorConsoleAgent::clearConsoleMessages):
2795         * inspector/InspectorRuntimeAgent.cpp:
2796         (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
2797         * inspector/InspectorRuntimeAgent.h:
2798         * inspector/front-end/ConsoleView.js:
2799         (WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
2800         (WebInspector.ConsoleView.prototype.completions):
2801         * inspector/front-end/PropertiesSidebarPane.js:
2802         * inspector/front-end/SourceFrame.js:
2803         (WebInspector.SourceFrame.prototype._hidePopup):
2804         * inspector/front-end/WatchExpressionsSidebarPane.js:
2805         (WebInspector.WatchExpressionsSection.prototype.update):
2806
2807 2011-03-02  Andrey Adaikin  <aandrey@google.com>
2808
2809         Reviewed by Pavel Feldman.
2810
2811         Web Inspector: Gutter height should be 100% when few lines are displayed
2812         https://bugs.webkit.org/show_bug.cgi?id=55574
2813
2814         * inspector/front-end/SourceFrame.js:
2815         (WebInspector.SourceFrame.prototype._startEditing):
2816         * inspector/front-end/TextViewer.js:
2817         (WebInspector.TextViewer.prototype._syncScroll):
2818         (WebInspector.TextEditorGutterPanel.prototype._expandChunks):
2819         (WebInspector.TextEditorGutterPanel.prototype.textChanged):
2820         (WebInspector.TextEditorGutterPanel.prototype.syncClientHeight):
2821         * inspector/front-end/textViewer.css:
2822         (.text-editor-lines):
2823         (.text-editor-contents .inner-container):
2824         (.webkit-line-number):
2825
2826 2011-03-04  Andrey Adaikin  <aandrey@google.com>
2827
2828         Reviewed by Pavel Feldman.
2829
2830         Web Inspector: [Text editor] Do bisect to find visible chunks
2831         https://bugs.webkit.org/show_bug.cgi?id=55685
2832
2833         * inspector/front-end/TextViewer.js:
2834         (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine):
2835         (WebInspector.TextEditorChunkedPanel.prototype._findVisibleChunks):
2836         (WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
2837         (WebInspector.TextEditorGutterChunk.prototype.get offsetTop):
2838         (WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
2839         (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
2840
2841 2011-03-04  Andrey Adaikin  <aandrey@google.com>
2842
2843         Reviewed by Pavel Feldman.
2844
2845         Web Inspector: [Text editor] DOMNodeRemoved events are missing
2846         https://bugs.webkit.org/show_bug.cgi?id=55769
2847
2848         * inspector/front-end/TextViewer.js:
2849         (WebInspector.TextEditorMainPanel):
2850         (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
2851         (WebInspector.TextEditorMainChunk):
2852         (WebInspector.TextEditorMainChunk.prototype._createRow):
2853
2854 2011-03-04  Ilya Tikhonovsky  <loislo@chromium.org>
2855
2856         Reviewed by Yury Semikhatsky.
2857
2858         Web Inspector: Remove unnecessary domain and success flags from the response messages.
2859         https://bugs.webkit.org/show_bug.cgi?id=55768
2860
2861         We have domain property in the response messages but it is not used because we dispatch
2862         the responses on the callback associated with seq.
2863
2864         If we have property 'errors' in the response then success eq false and true in the other case.
2865
2866         * inspector/CodeGeneratorInspector.pm:
2867
2868 2011-03-04  Christian Dywan  <christian@lanedo.com>
2869
2870         Reviewed by Gustavo Noronha Silva.
2871
2872         Enable Copy Image Address context menu item in the Gtk port
2873         https://bugs.webkit.org/show_bug.cgi?id=55136
2874
2875         * page/ContextMenuController.cpp:
2876         * platform/ContextMenuItem.h:
2877         * platform/LocalizationStrategy.h:
2878         * platform/LocalizedStrings.cpp:
2879         * platform/LocalizedStrings.h:
2880         * platform/gtk/ContextMenuItemGtk.cpp:
2881         * platform/gtk/LocalizedStringsGtk.cpp:
2882
2883 2011-03-04  Pavel Feldman  <pfeldman@chromium.org>
2884
2885         Reviewed by Yury Semikhatsky.
2886
2887         Web Inspector: implement getCompletions via evaluate.
2888         https://bugs.webkit.org/show_bug.cgi?id=55759
2889
2890         * inspector/InjectedScript.cpp:
2891         * inspector/InjectedScript.h:
2892         * inspector/InjectedScriptSource.js:
2893         * inspector/Inspector.idl:
2894         * inspector/InspectorDebuggerAgent.cpp:
2895         * inspector/InspectorDebuggerAgent.h:
2896         * inspector/InspectorRuntimeAgent.cpp:
2897         * inspector/InspectorRuntimeAgent.h:
2898         * inspector/front-end/ConsoleView.js:
2899         (WebInspector.ConsoleView.prototype.completions.evaluated):
2900         (WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
2901         (WebInspector.ConsoleView.prototype.completions):
2902         (WebInspector.ConsoleView.prototype._reportCompletions):
2903         * inspector/front-end/ScriptsPanel.js:
2904         (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper):
2905         (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
2906         * inspector/front-end/SourceFrame.js:
2907         (WebInspector.SourceFrame.prototype._showPopup):
2908         (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
2909
2910 2011-03-04  Steve Block  <steveblock@google.com>
2911
2912         Reviewed by Jeremy Orlow.
2913
2914         V8 version of JavaString should obtain string from JNI in UTF-16 encoding
2915         https://bugs.webkit.org/show_bug.cgi?id=55566
2916
2917         We obtain the string from JNI in UTF-16 encoding and convert
2918         to UTF-8 using our own routines as required. This matches the
2919         behaviour of the JSC version of JavaString.
2920
2921         No new tests, no change in behaviour.
2922
2923         * bridge/jni/v8/JavaStringV8.h:
2924         (JSC::Bindings::JavaStringImpl::init):
2925         (JSC::Bindings::JavaStringImpl::utf8):
2926         (JSC::Bindings::JavaStringImpl::impl):
2927
2928 2011-03-03  Pavel Feldman  <pfeldman@chromium.org>
2929
2930         Reviewed by Yury Semikhatsky.
2931
2932         Web Inspector: do not push document into front-end, make it request one.
2933         https://bugs.webkit.org/show_bug.cgi?id=55664
2934
2935         * inspector/Inspector.idl:
2936         * inspector/InspectorAgent.cpp:
2937         (WebCore::InspectorAgent::InspectorAgent):
2938         * inspector/InspectorAgent.h:
2939         * inspector/InspectorBrowserDebuggerAgent.cpp:
2940         (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
2941         * inspector/InspectorDOMAgent.cpp:
2942         (WebCore::InspectorDOMAgent::InspectorDOMAgent):
2943         (WebCore::InspectorDOMAgent::clearFrontend):
2944         (WebCore::InspectorDOMAgent::setDocument):
2945         (WebCore::InspectorDOMAgent::getDocument):
2946         (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
2947         (WebCore::InspectorDOMAgent::boundNodeId):
2948         (WebCore::InspectorDOMAgent::resolveNode):
2949         (WebCore::InspectorDOMAgent::mainFrameDOMContentLoaded):
2950         * inspector/InspectorDOMAgent.h:
2951         (WebCore::InspectorDOMAgent::create):
2952         * inspector/front-end/BreakpointManager.js:
2953         (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints):
2954         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
2955         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
2956         * inspector/front-end/DOMAgent.js:
2957         (WebInspector.DOMDocument):
2958         (WebInspector.DOMAgent):
2959         (WebInspector.DOMAgent.prototype.requestDocument):
2960         (WebInspector.DOMAgent.prototype.pushNodeToFrontend):
2961         (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
2962         (WebInspector.DOMAgent.prototype._attributesUpdated):
2963         (WebInspector.DOMAgent.prototype._characterDataModified):
2964         (WebInspector.DOMAgent.prototype._documentUpdated):
2965         (WebInspector.DOMAgent.prototype._setDocument):
2966         (WebInspector.DOMAgent.prototype._setDetachedRoot):
2967         (WebInspector.DOMAgent.prototype._setChildNodes):
2968         (WebInspector.DOMAgent.prototype._childNodeInserted):
2969         (WebInspector.DOMAgent.prototype._childNodeRemoved):
2970         (WebInspector.DOMDispatcher.prototype.documentUpdated):
2971         * inspector/front-end/ElementsPanel.js:
2972         (WebInspector.ElementsPanel.prototype.show):
2973         (WebInspector.ElementsPanel.prototype.setDocument):
2974         * inspector/front-end/MetricsSidebarPane.js:
2975         * inspector/front-end/RemoteObject.js:
2976         (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
2977
2978 2011-03-04  Andrey Kosyakov  <caseq@chromium.org>
2979
2980         Reviewed by Pavel Feldman.
2981
2982         Web Inspector: summary bar may overlap content of the network item view
2983         https://bugs.webkit.org/show_bug.cgi?id=55656
2984
2985         - drop custom summary bar placement logic, do it with CSS instead.
2986
2987         * inspector/front-end/NetworkPanel.js:
2988         (WebInspector.NetworkPanel.prototype.resize):
2989         (WebInspector.NetworkPanel.prototype._createSummaryBar):
2990         (WebInspector.NetworkPanel.prototype._updateSummaryBar):
2991         (WebInspector.NetworkPanel.prototype._updateFilter):
2992         (WebInspector.NetworkPanel.prototype.show):
2993         (WebInspector.NetworkPanel.prototype.refresh):
2994         (WebInspector.NetworkPanel.prototype._reset):
2995         (WebInspector.NetworkPanel.prototype._setLargerResources):
2996         (WebInspector.NetworkPanel.prototype._updateOffscreenRows):
2997         * inspector/front-end/networkPanel.css:
2998         (.network-sidebar .data-grid td):
2999         (.network-sidebar tr.filler td):
3000         (.network-summary-bar):
3001         (.network-sidebar .data-grid .network-summary-bar td):
3002         (.network-summary-bar img):
3003
3004 2011-03-04  James Su <suzhe@chromium.org>
3005
3006         Reviewed by Dimitri Glazkov.
3007
3008         [Chromium] keycode is always 0 when using non-Latin keyboard layout.
3009         https://bugs.webkit.org/show_bug.cgi?id=54939
3010
3011         Add KeyEventCocoa.{h,mm}, so that we can reuse them in chromium.
3012
3013         No intended functionality change.
3014
3015         * WebCore.gyp/WebCore.gyp:
3016         * WebCore.gypi:
3017
3018 2011-03-04  Patrick Gansterer  <paroga@webkit.org>
3019
3020         Unreviewed EFL build fix for r80324.
3021
3022         * platform/efl/RenderThemeEfl.cpp:
3023         (WebCore::RenderThemeEfl::paintThemePart):
3024
3025 2011-03-04  Patrick Gansterer  <paroga@webkit.org>
3026
3027         Unreviewed EFL build fix for r80324.
3028
3029         * platform/efl/RenderThemeEfl.cpp:
3030         (WebCore::RenderThemeEfl::paintThemePart):
3031
3032 2011-03-03  Yury Semikhatsky  <yurys@chromium.org>
3033
3034         Reviewed by Pavel Feldman.
3035
3036         Web Inspector: AppCache agent should have same lifetime as InspectorAgent
3037         https://bugs.webkit.org/show_bug.cgi?id=55673
3038
3039         * inspector/InspectorAgent.cpp:
3040         (WebCore::InspectorAgent::InspectorAgent):
3041         (WebCore::InspectorAgent::setFrontend):
3042         (WebCore::InspectorAgent::disconnectFrontend):
3043         (WebCore::InspectorAgent::createFrontendLifetimeAgents):
3044         (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
3045         (WebCore::InspectorAgent::didCommitLoad):
3046         * inspector/InspectorApplicationCacheAgent.cpp:
3047         (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
3048         (WebCore::InspectorApplicationCacheAgent::setFrontend):
3049         (WebCore::InspectorApplicationCacheAgent::clearFrontend):
3050         * inspector/InspectorApplicationCacheAgent.h:
3051         * inspector/InspectorInstrumentation.cpp:
3052         (WebCore::InspectorInstrumentation::networkStateChangedImpl):
3053         (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
3054         * inspector/InstrumentingAgents.h:
3055         (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent):
3056         (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
3057
3058 2011-03-03  Brian Weinstein  <bweinstein@apple.com>
3059
3060         Reviewed by Adam Roben.
3061
3062         Cleanup from https://bugs.webkit.org/show_bug.cgi?id=55427.
3063         
3064         Call WebCore::startObservingCookieChanges and WebCore::stopObservingCookieChanges
3065         on all platforms, and stub the functions on platforms that don't implement them.
3066         
3067         Add startObservingCookieChanges and stopObservingCookieChanges to TemporaryLinkStubs
3068         for platforms that don't implement them.
3069
3070         * platform/android/TemporaryLinkStubs.cpp:
3071         * platform/brew/TemporaryLinkStubs.cpp:
3072         * platform/chromium/TemporaryLinkStubs.cpp:
3073         * platform/efl/TemporaryLinkStubs.cpp:
3074         * platform/gtk/TemporaryLinkStubs.cpp:
3075         * platform/haiku/TemporaryLinkStubs.cpp:
3076         * platform/qt/TemporaryLinkStubsQt.cpp:
3077         * platform/win/TemporaryLinkStubs.cpp:
3078
3079 2011-03-03  Eric Seidel  <eric@webkit.org>
3080
3081         Reviewed by Dimitri Glazkov.
3082
3083         Refactor createRendererIfNeeded to avoid premature nextRenderer calculation
3084         https://bugs.webkit.org/show_bug.cgi?id=55720
3085
3086         There are two thing going on here:
3087         1. Delaying nextRenderer calculation until we actually use it,
3088            previously we would always compute nextRenderer (expensive!)
3089            even if no renderer insertion was to occur.
3090         2. Fix fullscreen elements to be inserted into the right place
3091            in the rendering tree.  Previously they would always be the last
3092            child in their parent's list, even if that wasn't the right place.
3093
3094         I don't know of any way to trigger the fullscreen bug,
3095         but I tested this with peacekeeper and saw no performance change.
3096
3097         Peacekeeper's domJQueryBasics is now possibly as much as 2% faster
3098         but I don't really trust the stability of peacekeeper to begin with.
3099
3100         This paves the way for further improvement in our nextRenderer calculation.
3101
3102         * dom/Node.cpp:
3103         (WebCore::Node::attach):
3104         (WebCore::Node::previousRenderer):
3105         (WebCore::Node::nextRenderer):
3106         (WebCore::Node::createRendererAndStyle):
3107         (WebCore::wrapWithRenderFullScreen):
3108         (WebCore::Node::createRendererIfNeeded):
3109         * dom/Node.h:
3110
3111 2011-03-03  Ryosuke Niwa  <rniwa@webkit.org>
3112
3113         Reviewed by Darin Adler.
3114
3115         Remove LOOSE_PASS_OWN_ARRAY_PTR from PassOwnArrayPtr.h
3116         https://bugs.webkit.org/show_bug.cgi?id=55554
3117
3118         * platform/Length.cpp:
3119         (WebCore::newLengthArray): Pass nullptr instead of 0.
3120
3121 2011-03-03  Nat Duca  <nduca@chromium.org>
3122
3123         Reviewed by James Robinson.
3124
3125         [chromium] Create a LayerChromium layerTreeAsText. Add HUD to
3126         LayerRendererChromium that draws compositor FPS and, optionally,
3127         the layer tree.
3128         https://bugs.webkit.org/show_bug.cgi?id=54710
3129
3130         * WebCore.gypi:
3131         * platform/graphics/chromium/Canvas2DLayerChromium.h:
3132         (WebCore::Canvas2DLayerChromium::drawsContent):
3133         * platform/graphics/chromium/CanvasLayerChromium.h:
3134         (WebCore::CanvasLayerChromium::layerTypeAsString):
3135         * platform/graphics/chromium/ContentLayerChromium.cpp:
3136         (WebCore::writeIndent):
3137         (WebCore::ContentLayerChromium::dumpLayerProperties):
3138         * platform/graphics/chromium/ContentLayerChromium.h:
3139         (WebCore::ContentLayerChromium::drawsContent):
3140         (WebCore::ContentLayerChromium::layerTypeAsString):
3141         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
3142         (WebCore::GraphicsLayerChromium::setName):
3143         (WebCore::GraphicsLayerChromium::updateNames):
3144         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
3145         (WebCore::GraphicsLayerChromium::setupContentsLayer):
3146         * platform/graphics/chromium/GraphicsLayerChromium.h:
3147         * platform/graphics/chromium/ImageLayerChromium.h:
3148         (WebCore::ImageLayerChromium::drawsContent):
3149         (WebCore::ImageLayerChromium::layerTypeAsString):
3150         * platform/graphics/chromium/LayerChromium.cpp:
3151         (WebCore::LayerChromium::LayerChromium):
3152         (WebCore::LayerChromium::setName):
3153         (WebCore::LayerChromium::layerTreeAsText):
3154         (WebCore::writeIndent):
3155         (WebCore::LayerChromium::dumpLayer):
3156         (WebCore::LayerChromium::dumpLayerProperties):
3157         * platform/graphics/chromium/LayerChromium.h:
3158         (WebCore::LayerChromium::name):
3159         (WebCore::LayerChromium::drawsContent):
3160         (WebCore::LayerChromium::debugID):
3161         (WebCore::LayerChromium::layerTypeAsString):
3162         * platform/graphics/chromium/LayerRendererChromium.cpp:
3163         (WebCore::LayerRendererChromium::LayerRendererChromium):
3164         (WebCore::LayerRendererChromium::~LayerRendererChromium):
3165         (WebCore::LayerRendererChromium::drawLayers):
3166         (WebCore::LayerRendererChromium::present):
3167         (WebCore::LayerRendererChromium::layerTreeAsText):
3168         (WebCore::LayerRendererChromium::dumpRenderSurfaces):
3169         * platform/graphics/chromium/LayerRendererChromium.h:
3170         (WebCore::LayerRendererChromium::getHeadsUpDisplay):
3171         (WebCore::LayerRendererChromium::rootVisibleRect):
3172         * platform/graphics/chromium/PluginLayerChromium.h:
3173         (WebCore::PluginLayerChromium::drawsContent):
3174         (WebCore::PluginLayerChromium::layerTypeAsString):
3175         * platform/graphics/chromium/RenderSurfaceChromium.cpp:
3176         (WebCore::RenderSurfaceChromium::name):
3177         (WebCore::writeIndent):
3178         (WebCore::RenderSurfaceChromium::dumpSurface):
3179         * platform/graphics/chromium/RenderSurfaceChromium.h:
3180         * platform/graphics/chromium/VideoLayerChromium.h:
3181         (WebCore::VideoLayerChromium::drawsContent):
3182         (WebCore::VideoLayerChromium::layerTypeAsString):
3183         * platform/graphics/chromium/WebGLLayerChromium.h:
3184         (WebCore::WebGLLayerChromium::drawsContent):
3185         (WebCore::WebGLLayerChromium::layerTypeAsString):
3186         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: Added.
3187         (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
3188         (WebCore::CCHeadsUpDisplay::~CCHeadsUpDisplay):
3189         (WebCore::CCHeadsUpDisplay::draw):
3190         (WebCore::CCHeadsUpDisplay::drawHudContents):
3191         (WebCore::CCHeadsUpDisplay::onPresent):
3192         * platform/graphics/chromium/cc/CCHeadsUpDisplay.h: Added.
3193         (WebCore::CCHeadsUpDisplay::setShowFPSCounter):
3194         (WebCore::CCHeadsUpDisplay::showFPSCounter):
3195         (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
3196         (WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
3197         (WebCore::CCHeadsUpDisplay::enabled):
3198         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
3199         (WebCore::CCLayerImpl::CCLayerImpl):
3200         (WebCore::writeIndent):
3201         (WebCore::CCLayerImpl::dumpLayerProperties):
3202         * platform/graphics/chromium/cc/CCLayerImpl.h:
3203         (WebCore::CCLayerImpl::debugID):
3204         (WebCore::CCLayerImpl::setName):
3205         (WebCore::CCLayerImpl::name):
3206
3207 2011-03-02  Ojan Vafai  <ojan@chromium.org>
3208
3209         Reviewed by Darin Adler.
3210
3211         crash in adoptNode with mutation events
3212         https://bugs.webkit.org/show_bug.cgi?id=50046
3213
3214         If the DOM is modified during the removeChild call in adoptNode,
3215         then the setDocument call that follows can leave the DOM in an
3216         inconsistent state.
3217
3218         * dom/Document.cpp:
3219         (WebCore::Document::adoptNode):
3220
3221 2011-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
3222
3223         Reviewed by Darin Adler.
3224
3225         Add audio tag tests to the media controls manual test suite.
3226         https://bugs.webkit.org/show_bug.cgi?id=55722
3227
3228         * manual-tests/media-controls.html: Added 4 audio tests.
3229
3230 2011-03-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3231
3232         Reviewed by Eric Seidel.
3233
3234         [EFL] Adjust functions of RenderThemeEfl.cpp to WebKit parameter style
3235         https://bugs.webkit.org/show_bug.cgi?id=54392
3236
3237         Functions of RenderThemeEfl.cpp adhere efl coding style instead of WebKit coding style.
3238         WebCore's functions should adhere WebKit coding style.
3239
3240         * platform/efl/RenderThemeEfl.cpp:
3241         (WebCore::RenderThemeEfl::themePartCacheEntryReset):
3242         (WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):
3243         (WebCore::RenderThemeEfl::cacheThemePartNew):
3244         (WebCore::RenderThemeEfl::cacheThemePartReset):
3245         (WebCore::RenderThemeEfl::cacheThemePartResizeAndReset):
3246         (WebCore::RenderThemeEfl::cacheThemePartGet):
3247         (WebCore::RenderThemeEfl::cacheThemePartFlush):
3248         (WebCore::RenderThemeEfl::applyEdjeStateFromForm):
3249         (WebCore::RenderThemeEfl::paintThemePart):
3250         (WebCore::renderThemeEflColorClassSelectionActive):
3251         (WebCore::renderThemeEflColorClassSelectionInactive):
3252         (WebCore::renderThemeEflColorClassFocusRing):
3253         (WebCore::renderThemeEflColorClassButtonText):
3254         (WebCore::renderThemeEflColorClassComboText):
3255         (WebCore::renderThemeEflColorClassEntryText):
3256         (WebCore::renderThemeEflColorClassSearchText):
3257         (WebCore::RenderThemeEfl::applyPartDescription):
3258         (WebCore::RenderThemeEfl::applyPartDescriptions):
3259         (WebCore::RenderThemeEfl::controlSupportsTints):
3260         (WebCore::RenderThemeEfl::baselinePosition):
3261         (WebCore::RenderThemeEfl::paintSliderTrack):
3262         (WebCore::RenderThemeEfl::adjustSliderTrackStyle):
3263         (WebCore::RenderThemeEfl::adjustSliderThumbStyle):
3264         (WebCore::RenderThemeEfl::paintSliderThumb):
3265         (WebCore::RenderThemeEfl::adjustCheckboxStyle):
3266         (WebCore::RenderThemeEfl::paintCheckbox):
3267         (WebCore::RenderThemeEfl::adjustRadioStyle):
3268         (WebCore::RenderThemeEfl::paintRadio):
3269         (WebCore::RenderThemeEfl::adjustButtonStyle):
3270         (WebCore::RenderThemeEfl::paintButton):
3271         (WebCore::RenderThemeEfl::adjustMenuListStyle):
3272         (WebCore::RenderThemeEfl::paintMenuList):
3273         (WebCore::RenderThemeEfl::adjustTextFieldStyle):
3274         (WebCore::RenderThemeEfl::paintTextField):
3275         (WebCore::RenderThemeEfl::adjustTextAreaStyle):
3276         (WebCore::RenderThemeEfl::paintTextArea):
3277         (WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
3278         (WebCore::RenderThemeEfl::paintSearchFieldDecoration):
3279         (WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
3280         (WebCore::RenderThemeEfl::paintSearchFieldResultsButton):
3281         (WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle):
3282         (WebCore::RenderThemeEfl::paintSearchFieldResultsDecoration):
3283         (WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
3284         (WebCore::RenderThemeEfl::paintSearchFieldCancelButton):
3285         (WebCore::RenderThemeEfl::adjustSearchFieldStyle):
3286         (WebCore::RenderThemeEfl::paintSearchField):
3287         (WebCore::RenderThemeEfl::adjustProgressBarStyle):
3288         (WebCore::RenderThemeEfl::paintProgressBar):
3289         (WebCore::RenderThemeEfl::paintMediaFullscreenButton):
3290         (WebCore::RenderThemeEfl::paintMediaMuteButton):
3291         (WebCore::RenderThemeEfl::paintMediaPlayButton):
3292         (WebCore::RenderThemeEfl::paintMediaSeekBackButton):
3293         (WebCore::RenderThemeEfl::paintMediaSeekForwardButton):
3294         (WebCore::RenderThemeEfl::paintMediaSliderTrack):
3295         (WebCore::RenderThemeEfl::paintMediaSliderThumb):
3296         (WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer):
3297         (WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack):
3298         (WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb):
3299         (WebCore::RenderThemeEfl::paintMediaCurrentTime):
3300
3301 2011-03-03  Andy Estes  <aestes@apple.com>
3302
3303         Reviewed by Adam Barth.
3304
3305         Assertion failure in toElement(WebCore::Node*)
3306         https://bugs.webkit.org/show_bug.cgi?id=55697
3307
3308         Test: fast/parser/fragment-foreign-content.html
3309
3310         * html/parser/HTMLTreeBuilder.cpp:
3311         (WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken): The current
3312         element in the HTMLElementStack might be a DocumentFragment if a
3313         fragment is being parsed who's first node is foreign content.
3314
3315 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3316
3317         Reviewed by Kenneth Rohde Christiansen.
3318
3319         [QT] Implement mock client-based geolocation for layout testing
3320         https://bugs.webkit.org/show_bug.cgi?id=54334
3321
3322         Implements client() to GeolocationController to re-use geolocationClientMock class
3323         for layout testing purpose.
3324
3325         * page/GeolocationController.h:
3326         (WebCore::GeolocationController::client):
3327
3328 2011-03-03  Ryosuke Niwa  <rniwa@webkit.org>
3329
3330         Reviewed by Kent Tamura.
3331
3332         Stop calling deprecatedNode and deprecatedEditingOffset in InsertTextCommand
3333         https://bugs.webkit.org/show_bug.cgi?id=55352
3334
3335         Stopped calling deprecatedNode and deprecatedEditingOffset in the following functions:
3336
3337         * editing/CompositeEditCommand.cpp:
3338         (WebCore::CompositeEditCommand::positionOutsideTabSpan): Takes care of all types of positions and
3339         no longer calls deprecated functions.
3340         * editing/InsertTextCommand.cpp:
3341         (WebCore::InsertTextCommand::positionInsideTextNode): Ditto; renamed from prepareForTextInsertion.
3342         Check if the text node inside a tab span before checking if the container node is a text node
3343         because the position before or after a text node can still be inside a tab span.
3344         (WebCore::InsertTextCommand::input): No longer calls deprecated functions.
3345         * editing/InsertTextCommand.h:
3346         * editing/ModifySelectionListLevel.cpp:
3347         (WebCore::getStartEndListChildren): Call anchorNode() instead of deprecatedNode() because the start
3348         or the end of selection could be an immediate child of a list node (e.g. br inside ul)
3349
3350 2011-03-03  Hans Wennborg  <hans@chromium.org>
3351
3352         Reviewed by Jeremy Orlow.
3353
3354         IndexedDB: Move last bits of SQL into IDBBackingStore
3355         https://bugs.webkit.org/show_bug.cgi?id=55668
3356
3357         After this, all SQL code for IndexedDB is in IDBBackingStore.cpp.
3358
3359         No new tests: refactoring only.
3360
3361         * storage/IDBBackingStore.cpp:
3362         (WebCore::IDBBackingStore::createTransaction):
3363         * storage/IDBBackingStore.h:
3364         * storage/IDBCursorBackendImpl.h:
3365         * storage/IDBDatabaseBackendImpl.cpp:
3366         (WebCore::IDBDatabaseBackendImpl::backingStore):
3367         * storage/IDBDatabaseBackendImpl.h:
3368         * storage/IDBIndexBackendImpl.h:
3369         * storage/IDBKey.h:
3370         * storage/IDBObjectStoreBackendImpl.h:
3371         * storage/IDBTransactionBackendImpl.cpp:
3372         (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
3373         * storage/IDBTransactionBackendImpl.h:
3374         * storage/IDBTransactionBackendInterface.h:
3375         * storage/IDBTransactionCoordinator.cpp:
3376
3377 2011-03-03  Adam Klein  <adamk@chromium.org>
3378
3379         Reviewed by David Levin.
3380
3381         [fileapi] Tighten up ResolveURICallbacks
3382         https://bugs.webkit.org/show_bug.cgi?id=55638
3383
3384         Two changes:
3385           - Retry only on TYPE_MISMATCH_ERR now that Chromium
3386             properly sets that error code.
3387           - Call DirectoryEntry instead of DOMFileSystem methods.
3388
3389         No change in behavior, so no new tests.
3390
3391         * fileapi/FileSystemCallbacks.cpp:
3392         (WebCore::ResolveURICallbacks::didOpenFileSystem):
3393
3394 2011-03-03  Anders Carlsson  <andersca@apple.com>
3395
3396         Reviewed by Sam Weinig.
3397
3398         Get rid of Page::globalHistoryItem
3399         https://bugs.webkit.org/show_bug.cgi?id=55738
3400
3401         The m_globalHistoryItem is only used by Mac and Windows WebKit1.
3402         Instead of having WebCore updating this member variable, just call out
3403         to a FrameLoaderClient member function and let WebKit keep it up to date.
3404
3405         * loader/EmptyClients.h:
3406         (WebCore::EmptyFrameLoaderClient::dispatchDidRemoveBackForwardItem):
3407         (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryItemForPage):
3408         * loader/FrameLoader.cpp:
3409         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
3410         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
3411         * loader/FrameLoaderClient.h:
3412         (WebCore::FrameLoaderClient::updateGlobalHistoryItemForPage):
3413         * loader/HistoryController.cpp:
3414         (WebCore::HistoryController::goToItem):
3415         (WebCore::HistoryController::updateForStandardLoad):
3416         (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
3417         * page/Page.cpp:
3418         * page/Page.h:
3419
3420 2011-03-02  Jeremy Orlow  <jorlow@chromium.org>
3421
3422         Reviewed by Steve Block.
3423
3424         Cursor.continue with a key param should test less than, not equal to
3425         https://bugs.webkit.org/show_bug.cgi?id=55640
3426
3427         If you supply a param to cursor.continue, we sould guarantee that
3428         the item we continue to is greater than or equal to the parameter.
3429         Right now, we only test equality.
3430
3431         http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBCursor-continue
3432         http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#dfn-steps-for-iterating-a-cursor
3433
3434         Test: storage/indexeddb/cursor-continue.html
3435
3436         * storage/IDBCursorBackendImpl.cpp:
3437         (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
3438         * storage/IDBKey.cpp:
3439         (WebCore::IDBKey::isLessThan):
3440         (WebCore::IDBKey::isEqual):
3441         * storage/IDBKey.h:
3442
3443 2011-03-03  Brent Fulgham  <bfulgham@webkit.org>
3444
3445         Build fix. Need win/cURL DownloadBundle stub.
3446
3447         * platform/network/curl/DownloadBundle.h: Added.
3448
3449 2011-03-03  Geoffrey Garen  <ggaren@apple.com>
3450
3451         Rolled out 80277 and 80280 because they caused event handler layout test
3452         failures.
3453
3454         * WebCore.xcodeproj/project.pbxproj:
3455         * bindings/js/JSDOMGlobalObject.cpp:
3456         * bindings/js/JSDOMGlobalObject.h:
3457         * bindings/js/JSDOMWindowBase.cpp:
3458         * bindings/js/JSDOMWindowBase.h:
3459         * bindings/js/JSDOMWindowCustom.h:
3460         * bindings/js/JSWorkerContextBase.cpp:
3461
3462 2011-03-03  Brady Eidson  <beidson@apple.com>
3463
3464         Reviewed by Darin Adler.
3465
3466         https://bugs.webkit.org/show_bug.cgi?id=55721
3467         Global IconDatabase should be returned by reference, not as a pointer
3468
3469         * history/HistoryItem.cpp:
3470         (WebCore::HistoryItem::HistoryItem):
3471         (WebCore::HistoryItem::~HistoryItem):
3472         (WebCore::HistoryItem::reset):
3473         (WebCore::HistoryItem::icon):
3474         (WebCore::HistoryItem::setURLString):
3475
3476         * loader/FrameLoader.cpp:
3477         (WebCore::FrameLoader::startIconLoader):
3478         (WebCore::FrameLoader::commitIconURLToIconDatabase):
3479
3480         * loader/archive/cf/LegacyWebArchive.cpp:
3481         (WebCore::LegacyWebArchive::create):
3482
3483         * loader/icon/IconDatabase.cpp:
3484         (WebCore::iconDatabase):
3485         * loader/icon/IconDatabase.h:
3486         * loader/icon/IconDatabaseNone.cpp:
3487         (WebCore::iconDatabase):
3488         * loader/icon/wince/IconDatabaseWinCE.cpp:
3489         (WebCore::iconDatabase):
3490
3491         * loader/icon/IconLoader.cpp:
3492         (WebCore::IconLoader::finishLoading):
3493
3494 2011-03-03  Ryosuke Niwa  <rniwa@webkit.org>
3495
3496         Reviewed by Martin Robinson.
3497
3498         Stop instantiating legacy editing positions in FocusController::advanceFocusInDocumentOrder
3499         https://bugs.webkit.org/show_bug.cgi?id=52742
3500
3501         Use firstPositionInOrBeforeNode to instantiate appropriate position.
3502
3503         * page/FocusController.cpp:
3504         (WebCore::FocusController::advanceFocusInDocumentOrder):
3505
3506 2011-03-03  Andy Estes  <aestes@apple.com>
3507
3508         Reviewed by Darin Adler.
3509
3510         When displaying the missing plug-in sheet, pass the 'pluginspage'
3511         attribute to the UI process.