Web Inspector: small memory leak in scripts panel.
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-10-10  Ilya Tikhonovsky  <loislo@chromium.org>
2
3         Web Inspector: small memory leak in scripts panel.
4         https://bugs.webkit.org/show_bug.cgi?id=69744
5
6         Scripts panel doesn't clean the list of child views.
7
8         Reviewed by Yury Semikhatsky.
9
10         * inspector/front-end/DebuggerPresentationModel.js:
11         (WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
12         * inspector/front-end/ScriptsPanel.js:
13         (WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
14
15 2011-10-07  Yury Semikhatsky  <yurys@chromium.org>
16
17         Web Inspector: allow to start WorkerContext paused
18         https://bugs.webkit.org/show_bug.cgi?id=69635
19
20         Allow to pause WorkerContext on start.
21
22         Reviewed by Pavel Feldman.
23
24         * bindings/v8/ScriptDebugServer.cpp:
25         (WebCore::ScriptDebugServer::setPauseOnNextStatement):
26         * bindings/v8/WorkerScriptDebugServer.cpp:
27         (WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
28         * bindings/v8/WorkerScriptDebugServer.h:
29         * inspector/InspectorController.cpp:
30         (WebCore::InspectorController::InspectorController):
31         * inspector/InspectorInstrumentation.cpp:
32         (WebCore::InspectorInstrumentation::willEvaluateWorkerScript):
33         * inspector/InspectorInstrumentation.h:
34         * inspector/InspectorRuntimeAgent.cpp:
35         (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
36         (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
37         (WebCore::InspectorRuntimeAgent::pauseWorkerContext): this method will start
38         running worker message loop in "debug" mode, i.e. it will process only inspector
39         tasks until method InspectorRuntimeAgent::resume is called.
40         (WebCore::InspectorRuntimeAgent::resume):
41         * inspector/InspectorRuntimeAgent.h:
42         * inspector/WorkerDebuggerAgent.cpp:
43         * inspector/WorkerDebuggerAgent.h:
44         * inspector/WorkerInspectorController.cpp:
45         (WebCore::WorkerInspectorController::WorkerInspectorController):
46         (WebCore::WorkerInspectorController::resume): method which is called from WebKit layer
47         when it is known that inspector state was restored and it is OK to resume worker execution.
48         * inspector/WorkerInspectorController.h:
49         * workers/DedicatedWorkerThread.cpp:
50         (WebCore::DedicatedWorkerThread::create):
51         (WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
52         * workers/DedicatedWorkerThread.h:
53         * workers/SharedWorkerThread.cpp:
54         (WebCore::SharedWorkerThread::create):
55         (WebCore::SharedWorkerThread::SharedWorkerThread):
56         * workers/SharedWorkerThread.h:
57         * workers/WorkerMessagingProxy.cpp:
58         (WebCore::WorkerMessagingProxy::startWorkerContext):
59         (WebCore::WorkerMessagingProxy::disconnectFromInspector):
60         (WebCore::WorkerMessagingProxy::sendMessageToInspector):
61         * workers/WorkerThread.cpp:
62         (WebCore::WorkerThreadStartupData::create):
63         (WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
64         (WebCore::WorkerThread::WorkerThread): WorkerThread is passed a booleand flag indicating
65         whether the context should be paused and wait for explicit resume command before it
66         starts running its script.
67         (WebCore::WorkerThread::workerThread):
68         * workers/WorkerThread.h:
69
70 2011-10-10  Sheriff Bot  <webkit.review.bot@gmail.com>
71
72         Unreviewed, rolling out r97045.
73         http://trac.webkit.org/changeset/97045
74         https://bugs.webkit.org/show_bug.cgi?id=69746
75
76         makes apple bots very crashy :( (Requested by kling on
77         #webkit).
78
79         * css/CSSStyleApplyProperty.cpp:
80         (WebCore::ApplyPropertyColor::applyInheritValue):
81         * page/animation/AnimationBase.cpp:
82         (WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
83         (WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
84         (WebCore::AnimationBase::ensurePropertyMap):
85         * platform/graphics/Color.h:
86         (WebCore::Color::Color):
87         * rendering/style/BorderValue.h:
88         (WebCore::BorderValue::BorderValue):
89         (WebCore::BorderValue::isTransparent):
90         (WebCore::BorderValue::operator==):
91         (WebCore::BorderValue::color):
92         * rendering/style/OutlineValue.h:
93         (WebCore::OutlineValue::operator==):
94         * rendering/style/RenderStyle.h:
95         (WebCore::InheritedFlags::setBorderLeftColor):
96         (WebCore::InheritedFlags::setBorderRightColor):
97         (WebCore::InheritedFlags::setBorderTopColor):
98         (WebCore::InheritedFlags::setBorderBottomColor):
99         (WebCore::InheritedFlags::setOutlineColor):
100         (WebCore::InheritedFlags::setColumnRuleColor):
101         (WebCore::InheritedFlags::fillPaintColor):
102         (WebCore::InheritedFlags::strokePaintColor):
103         (WebCore::InheritedFlags::borderLeftColor):
104         (WebCore::InheritedFlags::borderRightColor):
105         (WebCore::InheritedFlags::borderTopColor):
106         (WebCore::InheritedFlags::borderBottomColor):
107         (WebCore::InheritedFlags::backgroundColor):
108         (WebCore::InheritedFlags::color):
109         (WebCore::InheritedFlags::columnRuleColor):
110         (WebCore::InheritedFlags::outlineColor):
111         (WebCore::InheritedFlags::textEmphasisColor):
112         (WebCore::InheritedFlags::textFillColor):
113         (WebCore::InheritedFlags::textStrokeColor):
114         (WebCore::InheritedFlags::stopColor):
115         (WebCore::InheritedFlags::floodColor):
116         (WebCore::InheritedFlags::lightingColor):
117
118 2011-10-06  Andreas Kling  <kling@webkit.org>
119
120         Shrink BorderValue.
121         https://bugs.webkit.org/show_bug.cgi?id=69521
122
123         Reviewed by Antti Koivisto.
124
125         Unroll BorderValue's Color member so we can pack the color's validity flag
126         in BorderValue's bitfield.
127
128         This shrinks BorderValue by 32 bit, which in turn shrinks BorderData by
129         16 bytes. This reduces memory consumption by 760 kB when loading the full
130         HTML5 spec.
131
132         * platform/graphics/Color.h:
133         (WebCore::Color::Color):
134
135             Allow construction of Color objects with specific validity.
136
137         * rendering/style/BorderValue.h:
138         (WebCore::BorderValue::BorderValue):
139         (WebCore::BorderValue::isTransparent):
140         (WebCore::BorderValue::operator==):
141         (WebCore::BorderValue::setColor):
142         (WebCore::BorderValue::color):
143         * rendering/style/OutlineValue.h:
144         (WebCore::OutlineValue::operator==):
145
146             Unroll m_color into BorderValue by splitting it into an RGBA32 and a bool.
147             Made those variables private and added color(), setColor() accessors.
148
149         * rendering/style/RenderStyle.h:
150         (WebCore::InheritedFlags::setBorderLeftColor):
151         (WebCore::InheritedFlags::setBorderRightColor):
152         (WebCore::InheritedFlags::setBorderTopColor):
153         (WebCore::InheritedFlags::setBorderBottomColor):
154         (WebCore::InheritedFlags::setOutlineColor):
155         (WebCore::InheritedFlags::setColumnRuleColor):
156
157             Added a SET_BORDERVALUE_COLOR macro and use that instead of SET_VAR
158             when setting BorderValue colors.
159
160         (WebCore::InheritedFlags::fillPaintColor):
161         (WebCore::InheritedFlags::strokePaintColor):
162         (WebCore::InheritedFlags::borderLeftColor):
163         (WebCore::InheritedFlags::borderRightColor):
164         (WebCore::InheritedFlags::borderTopColor):
165         (WebCore::InheritedFlags::borderBottomColor):
166         (WebCore::InheritedFlags::backgroundColor):
167         (WebCore::InheritedFlags::color):
168         (WebCore::InheritedFlags::columnRuleColor):
169         (WebCore::InheritedFlags::outlineColor):
170         (WebCore::InheritedFlags::textEmphasisColor):
171         (WebCore::InheritedFlags::textFillColor):
172         (WebCore::InheritedFlags::textStrokeColor):
173         (WebCore::InheritedFlags::stopColor):
174         (WebCore::InheritedFlags::floodColor):
175         (WebCore::InheritedFlags::lightingColor):
176
177             Made color getters return "Color" instead of "const Color&" since
178             BorderValue no longer has an actual object to return the reference to.
179
180         * css/CSSStyleApplyProperty.cpp:
181         (WebCore::ApplyPropertyColor::applyInheritValue):
182         * page/animation/AnimationBase.cpp:
183         (WebCore::PropertyWrapperColor::PropertyWrapperColor):
184         (WebCore::PropertyWrapperColor::blend):
185         (WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
186         (WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
187         (WebCore::AnimationBase::ensurePropertyMap):
188
189             Adapt to RenderStyle color getters now returning "Color" instead of
190             "const Color&".
191
192 2011-10-09  Yury Semikhatsky  <yurys@chromium.org>
193
194         Missing m_notificationPresenter initialization in WorkerThread constructor
195         https://bugs.webkit.org/show_bug.cgi?id=69741
196
197         Added missing m_notificationPresenter(0)
198
199         Reviewed by Pavel Feldman.
200
201         * workers/WorkerThread.cpp:
202         (WebCore::WorkerThread::WorkerThread):
203
204 2011-10-09  Daniel Bates  <dbates@webkit.org>
205
206         Another attempt to fix the Leopard Intel Debug build after changeset 97034 <http://trac.webkit.org/changeset/97034>
207         (https://bugs.webkit.org/show_bug.cgi?id=68035)
208
209         * page/FrameView.cpp:
210         (WebCore::FrameView::zoomAnimatorTransformChanged): Explicitly convert a double precision result
211         to a single precision result. I am unsure if this fix is correct. We need to look into this some
212         more. See <https://bugs.webkit.org/show_bug.cgi?id=69739> for more details.
213
214 2011-10-09  Daniel Bates  <dbates@webkit.org>
215
216         Attempt to fix the Leopard Intel Debug build after changeset 97034 <http://trac.webkit.org/changeset/97034>
217         (https://bugs.webkit.org/show_bug.cgi?id=68035)
218
219         * page/FrameView.cpp:
220         (WebCore::FrameView::zoomAnimatorTransformChanged): Explicitly convert double precision result to
221         an integer. I am unsure if this fix is correct. We need to look into this some more. See
222         <https://bugs.webkit.org/show_bug.cgi?id=69739> for more details.
223
224 2011-10-09  Luke Macpherson   <macpherson@chromium.org>
225
226         Fix Lion, Leopard and Snow Leopard builds after changeset 97034 <http://trac.webkit.org/changeset/97034>
227         (https://bugs.webkit.org/show_bug.cgi?id=68035)
228         https://bugs.webkit.org/show_bug.cgi?id=69735
229
230         Reviewed by Daniel Bates.
231
232         * testing/Internals.cpp:
233         Mark unused parameters to prevent compile errors when GESTURE_EVENTS and SMOOTH_SCROLLING are disabled.
234         (WebCore::Internals::setEnableScrollAnimator):
235         (WebCore::Internals::setZoomAnimatorTransform):
236         (WebCore::Internals::setZoomParameters):
237
238 2011-10-09  Kent Tamura  <tkent@chromium.org>
239
240         Remove redundant code of HTMLSelectElement.
241         https://bugs.webkit.org/show_bug.cgi?id=69701
242
243         Reviewed by Darin Adler.
244
245         No new tests, just a refactoring.
246
247         * html/HTMLSelectElement.cpp:
248         (WebCore::HTMLSelectElement::deselectItems):
249         Rename inner deselectItems() to deselectItemsWithoutValidation().
250         (WebCore::HTMLSelectElement::setSelectedIndex):
251         Rename a callsite of another setSelectedIndex() to setSelectedIndexInternal().
252         (WebCore::HTMLSelectElement::setSelectedIndexByUser):
253         ditto, and update a callsite of updateSelectedState().
254         (WebCore::HTMLSelectElement::listBoxSelectItem):
255         Update a callsite of updateSelectedState().
256         (WebCore::HTMLSelectElement::activeSelectionEndListIndex):
257         Update a callsite of lastSelectedListIndex().
258         (WebCore::HTMLSelectElement::selectAll):
259         Update callsites of functions which are changed to non-static.
260         (WebCore::HTMLSelectElement::saveLastSelection):
261         Merge a static function and a non-static function.
262         (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto.
263         (WebCore::HTMLSelectElement::setActiveSelectionEndIndex): ditto.
264         (WebCore::HTMLSelectElement::updateListBoxSelection): ditto.
265         (WebCore::HTMLSelectElement::listBoxOnChange): ditto.
266         (WebCore::HTMLSelectElement::menuListOnChange): ditto.
267         (WebCore::HTMLSelectElement::scrollToSelection): ditto.
268         (WebCore::HTMLSelectElement::setOptionsChangedOnRenderer): Made this non-static.
269         (WebCore::HTMLSelectElement::setRecalcListItems):
270         Merge a static function and a non-static function.
271         (WebCore::HTMLSelectElement::selectedIndex): ditto.
272         (WebCore::HTMLSelectElement::setSelectedIndexInternal):
273         Made this non-static, and renamed from setSelectedIndex() because
274         of conflict with an existing function.
275         (WebCore::HTMLSelectElement::optionToListIndex):
276         Merge a static function and a non-static function.
277         (WebCore::HTMLSelectElement::listToOptionIndex): ditto.
278         (WebCore::HTMLSelectElement::dispatchFocusEvent):
279         Update a callsite of function which is changed to no-staic.
280         (WebCore::HTMLSelectElement::dispatchBlurEvent): ditto.
281         (WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
282         Made this non-static, and renamed from deselectItems() to avoid conflict.
283         (WebCore::HTMLSelectElement::restoreFormControlState):
284         Update a callsite of function which is changed to no-staic.
285         (WebCore::HTMLSelectElement::reset): ditto.
286         (WebCore::HTMLSelectElement::platformHandleKeydownEvent): Made this non-static.
287         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
288         (WebCore::HTMLSelectElement::updateSelectedState): ditto.
289         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
290         (WebCore::HTMLSelectElement::defaultEventHandler):
291         Merged a static function and a non-static function.
292         (WebCore::HTMLSelectElement::lastSelectedListIndex): Made this non-static.
293         (WebCore::HTMLSelectElement::typeAheadFind): ditto.
294         (WebCore::HTMLSelectElement::accessKeySetSelectedIndex): ditto.
295         * html/HTMLSelectElement.h:
296         * html/HTMLSelectElementWin.cpp:
297         (WebCore::HTMLSelectElement::platformHandleKeydownEvent): Made this non-static.
298
299 2011-10-09  Adam Barth  <abarth@webkit.org>
300
301         CSP should log unrecognized directives to the console
302         https://bugs.webkit.org/show_bug.cgi?id=69728
303
304         Reviewed by Sam Weinig.
305
306         Several of the web developers who have been experimenting with CSP have
307         run into trouble with directives we don't support.  For example, one
308         developer was confused for a while why image-src didn't do what he
309         expected.  Logging a message to the console will help these folks
310         figure out what's going on.
311
312         * page/ContentSecurityPolicy.cpp:
313         (WebCore::ContentSecurityPolicy::reportUnrecognizedDirective):
314         (WebCore::ContentSecurityPolicy::addDirective):
315         * page/ContentSecurityPolicy.h:
316
317 2011-10-09  W. James MacLean  <wjmaclean@chromium.org>
318
319         [chromium] Zoom animator front-end
320         https://bugs.webkit.org/show_bug.cgi?id=68035
321
322         Adds necessary components to ScrollAnimatorNone to support a zoom animation
323         feature. Includes test infrastructure via testing/Internals to capture
324         in-progress texture scaling (zoom-animator-scale-test.html) as well as a
325         final view --- after pageScaleFactor has been applied --- in zoom-animator-scale-test2.html.
326
327         Removes temporary test fields from Settings.
328
329         Reviewed by Kenneth Russell.
330
331         Test: platform/chromium/compositing/zoom-animator-scale-test2.html
332
333         * page/EventHandler.cpp:
334         (WebCore::EventHandler::handleGestureEvent):
335         * page/FrameView.cpp:
336         (WebCore::FrameView::zoomAnimatorTransformChanged):
337         * page/FrameView.h:
338         * page/Settings.cpp:
339         (WebCore::Settings::Settings):
340         * page/Settings.h:
341         * platform/ScrollAnimator.cpp:
342         (WebCore::ScrollAnimator::ScrollAnimator):
343         (WebCore::ScrollAnimator::notifyZoomChanged):
344         (WebCore::ScrollAnimator::zoomTranslation):
345         (WebCore::ScrollAnimator::resetZoom):
346         (WebCore::ScrollAnimator::setZoomParametersForTest):
347         * platform/ScrollAnimator.h:
348         (WebCore::ScrollAnimator::zoomScale):
349         * platform/ScrollAnimatorNone.cpp:
350         (WebCore::ScrollAnimatorNone::ZoomData::ZoomData):
351         (WebCore::ScrollAnimatorNone::ZoomData::animateZoom):
352         (WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
353         (WebCore::ScrollAnimatorNone::zoom):
354         (WebCore::ScrollAnimatorNone::handleGestureEvent):
355         (WebCore::ScrollAnimatorNone::animationTimerFired):
356         * platform/ScrollAnimatorNone.h:
357         * platform/ScrollableArea.cpp:
358         (WebCore::ScrollableArea::zoomAnimatorTransformChanged):
359         * platform/ScrollableArea.h:
360         * testing/Internals.cpp:
361         (WebCore::Internals::setEnableScrollAnimator):
362         (WebCore::Internals::setZoomAnimatorTransform):
363         (WebCore::Internals::getPageScaleFactor):
364         (WebCore::Internals::setZoomParameters):
365         * testing/Internals.h:
366         * testing/Internals.idl:
367
368 2011-10-09  Dan Bernstein  <mitz@apple.com>
369
370         <rdar://problem/9484496> REGRESSION (WebKit2): Checkboxes and radio buttons are drawn 1 pixel too high, not repainted properly
371         https://bugs.webkit.org/show_bug.cgi?id=69727
372
373         Reviewed by Anders Carlsson.
374
375         * platform/mac/ThemeMac.mm: Made WebCoreFlippedView an NSControl subclass so that the NSButtonCell
376         used to draw checkboxes and radio buttons can make it its controlView, and consequently check and
377         obey its flippedness.
378
379 2011-10-09  Benjamin Poulain  <benjamin@webkit.org>
380
381         Do not compare the first glyph to itself in Font::drawGlyphBuffer()
382         https://bugs.webkit.org/show_bug.cgi?id=69715
383
384         Reviewed by Andreas Kling.
385
386         When looking for glyphs with similar properties, we should
387         skip the first one since the comparison of fontData 
388         and offset will always fail.
389
390         This is covered by the existing tests.
391
392         * platform/graphics/FontFastPath.cpp:
393         (WebCore::Font::drawGlyphBuffer):
394
395 2011-10-08  Justin Schuh  <jschuh@chromium.org>
396
397         Make ThreadGlobalData members use OwnPtr
398         https://bugs.webkit.org/show_bug.cgi?id=69710
399
400         Reviewed by Adam Barth.
401
402         No functional changes. No new tests required.
403
404         * platform/ThreadGlobalData.cpp:
405         (WebCore::ThreadGlobalData::ThreadGlobalData):
406         (WebCore::ThreadGlobalData::~ThreadGlobalData):
407         (WebCore::ThreadGlobalData::destroy):
408         * platform/ThreadGlobalData.h:
409
410 2011-10-08  Mark Hahnenberg  <mhahnenberg@apple.com>
411
412         Add static version of JSCell::getConstructData
413         https://bugs.webkit.org/show_bug.cgi?id=69673
414
415         Reviewed by Geoffrey Garen.
416
417         No new tests.
418
419         Added static version of getConstructData to all classes that 
420         override it and changed the virtual versions to call the static 
421         versions.  This is the first step in de-virtualizing JSCell::getConstructData.
422
423         * bindings/js/JSAudioConstructor.cpp:
424         (WebCore::JSAudioConstructor::getConstructData):
425         * bindings/js/JSAudioConstructor.h:
426         * bindings/js/JSImageConstructor.cpp:
427         (WebCore::JSImageConstructor::getConstructData):
428         * bindings/js/JSImageConstructor.h:
429         * bindings/js/JSOptionConstructor.cpp:
430         (WebCore::JSOptionConstructor::getConstructData):
431         * bindings/js/JSOptionConstructor.h:
432         * bindings/scripts/CodeGeneratorJS.pm:
433         (GenerateConstructorDeclaration):
434         (GenerateConstructorDefinition):
435         * bindings/scripts/test/JS/JSTestInterface.cpp:
436         (WebCore::JSTestInterfaceConstructor::getConstructData):
437         * bridge/runtime_object.cpp:
438         (JSC::Bindings::RuntimeObject::getConstructData):
439         * bridge/runtime_object.h:
440
441 2011-10-08  Mark Hahnenberg  <mhahnenberg@apple.com>
442
443         Add static version of JSCell::getOwnPropertySlot
444         https://bugs.webkit.org/show_bug.cgi?id=69593
445
446         Reviewed by Geoffrey Garen.
447
448         No new tests.
449
450         Added static version of getOwnPropertySlot to every class that overrides
451         JSCell::getOwnPropertySlot.  The virtual versions now call the static versions.
452         This is the first step in de-virtualizing JSCell::getOwnPropertySlot.
453
454         * bindings/js/JSDOMWindowShell.cpp:
455         (WebCore::JSDOMWindowShell::getOwnPropertySlot):
456         * bindings/js/JSDOMWindowShell.h:
457         * bridge/objc/objc_runtime.h:
458         * bridge/objc/objc_runtime.mm:
459         (JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertySlot):
460         * bridge/qt/qt_runtime.cpp:
461         (JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertySlot):
462         (JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertySlot):
463         * bridge/qt/qt_runtime.h:
464         * bridge/runtime_array.cpp:
465         (JSC::RuntimeArray::getOwnPropertySlot):
466         * bridge/runtime_array.h:
467         * bridge/runtime_method.cpp:
468         (JSC::RuntimeMethod::getOwnPropertySlot):
469         * bridge/runtime_method.h:
470         * bridge/runtime_object.cpp:
471         (JSC::Bindings::RuntimeObject::getOwnPropertySlot):
472         * bridge/runtime_object.h:
473
474 2011-10-03  Carlos Garcia Campos  <cgarcia@igalia.com> and Martin Robinson  <mrobinson@igalia.com>
475
476         [GTK] Implement drag and drop support in WebKit2
477         https://bugs.webkit.org/show_bug.cgi?id=63706
478
479         Reviewed by Philippe Normand.
480
481         * platform/DragData.h:
482         * platform/gtk/DataObjectGtk.cpp:
483         (WebCore::DataObjectGtk::text): Mark as const.
484         (WebCore::DataObjectGtk::markup): Ditto.
485         (WebCore::DataObjectGtk::urlLabel): Ditto.
486         * platform/gtk/DataObjectGtk.h: Remove unused member
487         m_dragContext.
488         (WebCore::DataObjectGtk::url): Mark as const.
489         (WebCore::DataObjectGtk::uriList): Ditto.
490         (WebCore::DataObjectGtk::filenames): Ditto.
491         (WebCore::DataObjectGtk::image): Ditto.
492         (WebCore::DataObjectGtk::hasText): Ditto.
493         (WebCore::DataObjectGtk::hasMarkup): Ditto.
494         (WebCore::DataObjectGtk::hasURIList): Ditto.
495         (WebCore::DataObjectGtk::hasURL): Ditto.
496         (WebCore::DataObjectGtk::hasFilenames): Ditto.
497         (WebCore::DataObjectGtk::hasImage): Ditto.
498         * platform/gtk/DragIcon.cpp: Added. A helper which takes care of
499         creating a transparent drag window for drags.
500         * platform/gtk/DragIcon.h: Added.
501
502 2011-10-08  Abhishek Arya  <inferno@chromium.org>
503
504         Add support for ADDRESS_SANITIZER in RenderArena
505         allocate, free calls.
506         https://bugs.webkit.org/show_bug.cgi?id=69636
507
508         Reviewed by Darin Adler.
509
510         Use malloc, free directly without using the debug header. Otherwise,
511         we won't be able to detect out of bounds access in debug header.
512
513         * rendering/RenderArena.cpp:
514         (WebCore::RenderArena::allocate):
515         (WebCore::RenderArena::free):
516
517 2011-10-08  Kent Tamura  <tkent@chromium.org>
518
519         Remove some static functions of HTMLSelectElement
520         https://bugs.webkit.org/show_bug.cgi?id=69621
521
522         Reviewed by Darin Adler.
523
524         Merge a static function and the corresponding non-static member function
525         into one function if there are no other callers of the static function.
526
527         No new tests, just a refactoring.
528
529         * html/HTMLFormControlElement.h:
530         Make formControlName() protected because it is called from
531         HTMLSelectElement.
532         * html/HTMLSelectElement.cpp:
533         (WebCore::HTMLSelectElement::parseMappedAttribute):
534         Remove two argument of parseMultipleAttribute().
535         (WebCore::HTMLSelectElement::selectAll):
536         Merged the static function and the member function.
537         (WebCore::HTMLSelectElement::dispatchFocusEvent): ditto.
538         (WebCore::HTMLSelectElement::dispatchBlurEvent): ditto.
539         (WebCore::HTMLSelectElement::saveFormControlState): ditto.
540         (WebCore::HTMLSelectElement::restoreFormControlState):
541         (WebCore::HTMLSelectElement::parseMultipleAttribute):
542          - Make this non-static member function.
543          - Use reattachIfAttached().
544         (WebCore::HTMLSelectElement::appendFormData): Merged.
545         (WebCore::HTMLSelectElement::reset): ditto.
546         (WebCore::HTMLSelectElement::insertedIntoTree): ditto.
547         (WebCore::HTMLSelectElement::accessKeySetSelectedIndex): ditto.
548         (WebCore::HTMLSelectElement::length): Merged with optionCount().
549         * html/HTMLSelectElement.h:
550
551 2011-10-08  Sheriff Bot  <webkit.review.bot@gmail.com>
552
553         Unreviewed, rolling out r96996.
554         http://trac.webkit.org/changeset/96996
555         https://bugs.webkit.org/show_bug.cgi?id=69697
556
557         It broke all tests on the Qt bot (Requested by Ossy_night on
558         #webkit).
559
560         * WebCore.exp.in:
561         * bindings/js/JSCallbackData.cpp:
562         (WebCore::JSCallbackData::invokeCallback):
563         * bindings/js/JSCustomXPathNSResolver.cpp:
564         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
565         * bindings/js/JSErrorHandler.cpp:
566         (WebCore::JSErrorHandler::handleEvent):
567         * bindings/js/JSEventListener.cpp:
568         (WebCore::JSEventListener::handleEvent):
569         * bindings/js/JSHTMLAllCollectionCustom.cpp:
570         (WebCore::JSHTMLAllCollection::getCallDataVirtual):
571         * bindings/js/JSHTMLAppletElementCustom.cpp:
572         (WebCore::JSHTMLAppletElement::getCallDataVirtual):
573         * bindings/js/JSHTMLEmbedElementCustom.cpp:
574         (WebCore::JSHTMLEmbedElement::getCallDataVirtual):
575         * bindings/js/JSHTMLObjectElementCustom.cpp:
576         (WebCore::JSHTMLObjectElement::getCallDataVirtual):
577         * bindings/js/JSInjectedScriptHostCustom.cpp:
578         (WebCore::JSInjectedScriptHost::evaluate):
579         * bindings/js/JSPluginElementFunctions.cpp:
580         (WebCore::runtimeObjectGetCallData):
581         * bindings/scripts/CodeGeneratorJS.pm:
582         (GenerateHeader):
583         * bridge/objc/objc_runtime.h:
584         * bridge/objc/objc_runtime.mm:
585         (JSC::Bindings::ObjcFallbackObjectImp::getCallDataVirtual):
586         * bridge/qt/qt_runtime.cpp:
587         (JSC::Bindings::QtRuntimeMetaMethod::getCallDataVirtual):
588         (JSC::Bindings::QtRuntimeConnectionMethod::call):
589         (JSC::Bindings::QtRuntimeConnectionMethod::getCallDataVirtual):
590         (JSC::Bindings::isJavaScriptFunction):
591         * bridge/qt/qt_runtime.h:
592         * bridge/runtime_method.cpp:
593         (JSC::RuntimeMethod::getCallDataVirtual):
594         * bridge/runtime_method.h:
595         * bridge/runtime_object.cpp:
596         (JSC::Bindings::RuntimeObject::getCallDataVirtual):
597         * bridge/runtime_object.h:
598
599 2011-10-08  Ryosuke Niwa  <rniwa@webkit.org>
600
601         Snow Leopard build fix after r96976. Apparently we just need a full rebuild.
602
603         * config.h:
604
605 2011-10-07  Mark Hahnenberg  <mhahnenberg@apple.com>
606
607         Add static version of JSCell::deleteProperty
608         https://bugs.webkit.org/show_bug.cgi?id=69659
609
610         Reviewed by Geoffrey Garen.
611
612         No new tests.
613
614         Added static version of both versions of put to all classes that 
615         override them and changed the virtual versions to call the static 
616         versions.  This is the first step in de-virtualizing JSCell::deleteProperty.
617
618         * bridge/objc/objc_runtime.h:
619         * bridge/objc/objc_runtime.mm:
620         (JSC::Bindings::ObjcFallbackObjectImp::deleteProperty):
621         * bridge/runtime_array.cpp:
622         (JSC::RuntimeArray::deleteProperty):
623         * bridge/runtime_array.h:
624         * bridge/runtime_object.cpp:
625         (JSC::Bindings::RuntimeObject::deleteProperty):
626         * bridge/runtime_object.h:
627
628 2011-10-07  Justin Schuh  <jschuh@chromium.org>
629
630         Make isXMLMIMEType regex use TLS
631         https://bugs.webkit.org/show_bug.cgi?id=69665
632
633         Reviewed by Adam Barth.
634
635         Test: fast/workers/worker-multi-startup.html
636
637         * dom/DOMImplementation.cpp:
638         (WebCore::XMLMIMETypeRegExp::XMLMIMETypeRegExp):
639         (WebCore::XMLMIMETypeRegExp::~XMLMIMETypeRegExp):
640         (WebCore::XMLMIMETypeRegExp::isXMLMIMEType):
641         (WebCore::DOMImplementation::isXMLMIMEType):
642         * dom/DOMImplementation.h:
643         * platform/ThreadGlobalData.cpp:
644         (WebCore::ThreadGlobalData::ThreadGlobalData):
645         (WebCore::ThreadGlobalData::destroy):
646         * platform/ThreadGlobalData.h:
647         (WebCore::ThreadGlobalData::xmlTypeRegExp):
648
649 2011-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
650
651         Unreviewed, rolling out r96847.
652         http://trac.webkit.org/changeset/96847
653         https://bugs.webkit.org/show_bug.cgi?id=69684
654
655         may have caused memory regression on win chromium (Requested
656         by simonjam on #webkit).
657
658         * platform/graphics/chromium/FontChromiumWin.cpp:
659         (WebCore::Font::drawGlyphs):
660
661 2011-10-07  Mark Hahnenberg  <mhahnenberg@apple.com>
662
663         Remove getCallDataVirtual methods
664         https://bugs.webkit.org/show_bug.cgi?id=69186
665
666         Reviewed by Geoffrey Garen.
667
668         No new tests.
669
670         Removed all getCallDataVirtual methods and replaced their call sites 
671         with an explicit lookup in the MethodTable.
672
673         * WebCore.exp.in:
674         * bindings/js/JSCallbackData.cpp:
675         (WebCore::JSCallbackData::invokeCallback):
676         * bindings/js/JSCustomXPathNSResolver.cpp:
677         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
678         * bindings/js/JSErrorHandler.cpp:
679         (WebCore::JSErrorHandler::handleEvent):
680         * bindings/js/JSEventListener.cpp:
681         (WebCore::JSEventListener::handleEvent):
682         * bindings/js/JSHTMLAllCollectionCustom.cpp:
683         * bindings/js/JSHTMLAppletElementCustom.cpp:
684         * bindings/js/JSHTMLEmbedElementCustom.cpp:
685         * bindings/js/JSHTMLObjectElementCustom.cpp:
686         * bindings/js/JSInjectedScriptHostCustom.cpp:
687         (WebCore::JSInjectedScriptHost::evaluate):
688         * bindings/js/JSPluginElementFunctions.cpp:
689         (WebCore::runtimeObjectGetCallData):
690         * bindings/scripts/CodeGeneratorJS.pm:
691         (GenerateHeader):
692         * bridge/objc/objc_runtime.h:
693         * bridge/objc/objc_runtime.mm:
694         * bridge/qt/qt_runtime.cpp:
695         (JSC::Bindings::QtRuntimeConnectionMethod::call):
696         (JSC::Bindings::isJavaScriptFunction):
697         * bridge/qt/qt_runtime.h:
698         (JSC::Bindings::QtRuntimeMetaMethod::createStructure):
699         (JSC::Bindings::QtRuntimeConnectionMethod::createStructure):
700         * bridge/runtime_method.cpp:
701         * bridge/runtime_method.h:
702         * bridge/runtime_object.cpp:
703         * bridge/runtime_object.h:
704
705 2011-10-07  Mark Hahnenberg  <mhahnenberg@apple.com>
706
707         Add static version of JSCell::put
708         https://bugs.webkit.org/show_bug.cgi?id=69382
709
710         Reviewed by Geoffrey Garen.
711
712         No new tests.
713
714         Added static version of both versions of put to all classes that 
715         override them and changed the virtual versions to call the static 
716         versions.
717
718         * bindings/scripts/CodeGeneratorJS.pm:
719         (GenerateHeader):
720         (GenerateImplementation):
721         * bindings/scripts/test/JS/JSTestObj.cpp:
722         (WebCore::JSTestObj::put):
723         * bindings/scripts/test/JS/JSTestObj.h:
724         * bridge/objc/objc_runtime.h:
725         * bridge/objc/objc_runtime.mm:
726         (JSC::Bindings::ObjcFallbackObjectImp::put):
727         * bridge/runtime_array.cpp:
728         (JSC::RuntimeArray::put):
729         * bridge/runtime_array.h:
730         * bridge/runtime_object.cpp:
731         (JSC::Bindings::RuntimeObject::put):
732         * bridge/runtime_object.h:
733
734 2011-10-07  Anantanarayanan G Iyengar  <ananta@chromium.org>
735
736          https://bugs.webkit.org/show_bug.cgi?id=69471
737
738          We now wrap the window script NPObject which is requested by NPAPI plugins for
739          scripting. The wrapped NPObject pointer maintains a weak reference to the
740          window script NPObject and is cleared out when the window script object is destroyed.
741          The NPObject wrapper is destroyed when the last outstanding reference is released.
742
743          Reviewed by Nate Chapin.
744
745          No tests added as there is no change in functionality.
746
747         * WebCore.gypi:
748         * bindings/v8/NPObjectWrapper.cpp: Added.
749         (WebCore::NPObjectWrapper::NPObjectWrapper):
750         (WebCore::NPObjectWrapper::create):
751         (WebCore::NPObjectWrapper::clear):
752         (WebCore::NPObjectWrapper::getWrapper):
753         (WebCore::NPObjectWrapper::getUnderlyingNPObject):
754         (WebCore::NPObjectWrapper::getObjectForCall):
755         (WebCore::NPObjectWrapper::NPAllocate):
756         (WebCore::NPObjectWrapper::NPDeallocate):
757         (WebCore::NPObjectWrapper::NPPInvalidate):
758         (WebCore::NPObjectWrapper::NPHasMethod):
759         (WebCore::NPObjectWrapper::NPInvoke):
760         (WebCore::NPObjectWrapper::NPInvokeDefault):
761         (WebCore::NPObjectWrapper::NPHasProperty):
762         (WebCore::NPObjectWrapper::NPGetProperty):
763         (WebCore::NPObjectWrapper::NPSetProperty):
764         (WebCore::NPObjectWrapper::NPRemoveProperty):
765         (WebCore::NPObjectWrapper::NPNEnumerate):
766         (WebCore::NPObjectWrapper::NPNConstruct):
767         (WebCore::NPObjectWrapper::NPInvokePrivate):
768         * bindings/v8/NPObjectWrapper.h: Added.
769         * bindings/v8/NPV8Object.cpp:
770         (_NPN_EvaluateHelper):
771         * bindings/v8/ScriptController.cpp:
772         (WebCore::ScriptController::ScriptController):
773         (WebCore::ScriptController::clearScriptObjects):
774         (WebCore::ScriptController::windowScriptNPObject):
775         * bindings/v8/ScriptController.h:
776
777 2011-10-07  Antoine Labour  <piman@chromium.org>
778
779         Webkit API for compositor
780         https://bugs.webkit.org/show_bug.cgi?id=69107
781
782         Reviewed by Darin Fisher.
783
784         Covered by existing compositing tests.
785
786         * platform/graphics/chromium/ContentLayerChromium.h: 
787
788 2011-10-07  Ben Wells  <benwells@chromium.org>
789
790         CSS text-transform should apply to select elements
791         https://bugs.webkit.org/show_bug.cgi?id=69503
792
793         Reviewed by Ojan Vafai.
794
795         Select elements are drawn in two ways depending on whether they are multiple and what their size is.
796         Neither method previously handled text-transforms. Both of these rendering styles are now updated to transform
797         their text correctly.
798
799         Test: fast/css/text-transform-select.html
800
801         * rendering/RenderListBox.cpp:
802         (WebCore::RenderListBox::updateFromElement):
803         (WebCore::RenderListBox::paintItemForeground):
804         * rendering/RenderMenuList.cpp:
805         (WebCore::RenderMenuList::updateOptionsWidth):
806         (WebCore::RenderMenuList::setText):
807         (WebCore::RenderMenuList::itemText):
808         * rendering/RenderText.cpp:
809         (WebCore::makeCapitalized):
810         (WebCore::applyTextTransform):
811         (WebCore::RenderText::setTextInternal):
812         (WebCore::RenderText::textWithoutTranscoding):
813         * rendering/RenderText.h:
814
815 2011-10-07  Tony Chang  <tony@chromium.org>
816
817         fix a crash when loading non-html multipart data
818         https://bugs.webkit.org/show_bug.cgi?id=69675
819
820         Reviewed by Adam Barth.
821
822         setupForReplaceByMIMEType calls DocumentWriter::end().  This leads to
823         a crash on Mac because WebHTMLRepresentation() calls commitLoad(nil),
824         which tries to write to the DocumentWriter.  By just inlining the code
825         to load the last page, we avoid this crash (and makes the non-html
826         multipart code more like the html multipart code).
827
828         * loader/DocumentLoader.cpp:
829         (WebCore::DocumentLoader::maybeFinishLoadingMultipartContent):
830
831 2011-10-07  Sergey Glazunov  <serg.glazunov@gmail.com>
832
833         XSLT-generated document should inherit its SecurityOrigin from the source document
834         https://bugs.webkit.org/show_bug.cgi?id=69661
835
836         Reviewed by Adam Barth.
837
838         Test: http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml
839
840         * xml/XSLTProcessor.cpp:
841         (WebCore::XSLTProcessor::createDocumentFromSource):
842
843 2011-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
844
845         Unreviewed, rolling out r96944.
846         http://trac.webkit.org/changeset/96944
847         https://bugs.webkit.org/show_bug.cgi?id=69662
848
849         Caused many tests to crash on Snow Leopard (Requested by rniwa
850         on #webkit).
851
852         * css/CSSStyleApplyProperty.cpp:
853         (WebCore::ApplyPropertyColor::applyInheritValue):
854         * page/animation/AnimationBase.cpp:
855         (WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
856         (WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
857         (WebCore::AnimationBase::ensurePropertyMap):
858         * platform/graphics/Color.h:
859         (WebCore::Color::Color):
860         * rendering/style/BorderValue.h:
861         (WebCore::BorderValue::BorderValue):
862         (WebCore::BorderValue::isTransparent):
863         (WebCore::BorderValue::operator==):
864         (WebCore::BorderValue::color):
865         * rendering/style/OutlineValue.h:
866         (WebCore::OutlineValue::operator==):
867         * rendering/style/RenderStyle.h:
868         (WebCore::InheritedFlags::setBorderLeftColor):
869         (WebCore::InheritedFlags::setBorderRightColor):
870         (WebCore::InheritedFlags::setBorderTopColor):
871         (WebCore::InheritedFlags::setBorderBottomColor):
872         (WebCore::InheritedFlags::setOutlineColor):
873         (WebCore::InheritedFlags::setColumnRuleColor):
874         (WebCore::InheritedFlags::fillPaintColor):
875         (WebCore::InheritedFlags::strokePaintColor):
876         (WebCore::InheritedFlags::borderLeftColor):
877         (WebCore::InheritedFlags::borderRightColor):
878         (WebCore::InheritedFlags::borderTopColor):
879         (WebCore::InheritedFlags::borderBottomColor):
880         (WebCore::InheritedFlags::backgroundColor):
881         (WebCore::InheritedFlags::color):
882         (WebCore::InheritedFlags::columnRuleColor):
883         (WebCore::InheritedFlags::outlineColor):
884         (WebCore::InheritedFlags::textEmphasisColor):
885         (WebCore::InheritedFlags::textFillColor):
886         (WebCore::InheritedFlags::textStrokeColor):
887         (WebCore::InheritedFlags::stopColor):
888         (WebCore::InheritedFlags::floodColor):
889         (WebCore::InheritedFlags::lightingColor):
890
891 2011-10-07  David Hyatt  <hyatt@apple.com>
892
893         https://bugs.webkit.org/show_bug.cgi?id=69658
894         
895         [CSS3 Regions] Box painting of overflow into regions is incorrect because children were being
896         incorrectly clamped to their containing block region ranges. Change the clamping model so that
897         renderRegionForLine no longer does it. A block will now truly have an accurate range across
898         all the regions that paint it. Instead, do the clamping at the time a child box asks the containing
899         block for its information. At that time clamp to the start and end regions, so that we never ask
900         a containing block for info about a region that it doesn't exist in.
901
902         Reviewed by Anders Carlsson.
903
904         Added new test in fast/regions and updated an old result to be correct.
905
906         * rendering/RenderBlock.cpp:
907         (WebCore::RenderBlock::pageLogicalHeightForOffset):
908         (WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
909         (WebCore::RenderBlock::regionAtBlockOffset):
910         (WebCore::RenderBlock::clampToStartAndEndRegions):
911         * rendering/RenderBlock.h:
912         * rendering/RenderBox.cpp:
913         (WebCore::RenderBox::borderBoxRectInRegion):
914         (WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
915         (WebCore::RenderBox::renderBoxRegionInfo):
916         * rendering/RenderFlowThread.cpp:
917         (WebCore::RenderFlowThread::renderRegionForLine):
918         (WebCore::RenderFlowThread::regionLogicalWidthForLine):
919         (WebCore::RenderFlowThread::regionLogicalHeightForLine):
920         (WebCore::RenderFlowThread::regionRemainingLogicalHeightForLine):
921         (WebCore::RenderFlowThread::mapFromFlowToRegion):
922         (WebCore::RenderFlowThread::setRegionRangeForBox):
923         * rendering/RenderFlowThread.h:
924
925 2011-10-07  Chang Shu  <cshu@webkit.org>
926
927         Remove compile time flag ENABLE_PASSWORD_ECHO
928         https://bugs.webkit.org/show_bug.cgi?id=69647
929
930         As we have runtime flag in the page/Settings, we should remove this redundant compile time flag.
931
932         Reviewed by Andreas Kling.
933
934         * config.h:
935         * page/Settings.cpp:
936         (WebCore::Settings::Settings):
937
938 2011-10-07  Chris Fleizach  <cfleizach@apple.com>
939
940         Bug 69562 - AccessibilityImageMapLink holds onto it's parent even after it's been freed
941         https://bugs.webkit.org/show_bug.cgi?id=69562
942
943         Some fake objects, like AXImageMapLink, have weak references to their parent's (since they are fake objects and
944         need some connection to the parent). However, if the parent disappears before the child, then we're left with a 
945         out of date reference to that parent.
946
947         The fix is to allow these elements to clear their parentage when the parent goes away.
948
949         Reviewed by Darin Adler.
950
951         Test: accessibility/image-map-update-parent-crash.html
952
953         * accessibility/AccessibilityMenuListOption.cpp:
954         (WebCore::AccessibilityMenuListOption::isVisible):
955         * accessibility/AccessibilityMenuListPopup.cpp:
956         (WebCore::AccessibilityMenuListPopup::isOffScreen):
957         (WebCore::AccessibilityMenuListPopup::isEnabled):
958         (WebCore::AccessibilityMenuListPopup::press):
959         (WebCore::AccessibilityMenuListPopup::addChildren):
960         (WebCore::AccessibilityMenuListPopup::childrenChanged):
961         * accessibility/AccessibilityMockObject.h:
962         (WebCore::AccessibilityMockObject::detachFromParent):
963         * accessibility/AccessibilityObject.cpp:
964         (WebCore::AccessibilityObject::clearChildren):
965         * accessibility/AccessibilityObject.h:
966         (WebCore::AccessibilityObject::detachFromParent):
967         * accessibility/AccessibilitySlider.cpp:
968         (WebCore::AccessibilitySliderThumb::elementRect):
969         * accessibility/AccessibilityTableColumn.cpp:
970         (WebCore::AccessibilityTableColumn::headerObjectForSection):
971
972 2011-10-07  Andreas Kling  <kling@webkit.org>
973
974         Pack StyleRareNonInheritedData even harder on 64-bit.
975         https://bugs.webkit.org/show_bug.cgi?id=69648
976
977         Reviewed by Benjamin Poulain.
978
979         Rearrange the members of StyleRareNonInheritedData to fold as much
980         as possible into the padding at the end of RefCounted.
981
982         This shrinks StyleRareNonInheritedData by 16 bytes on 64-bit,
983         reducing memory consumption by another 140 kB when loading the
984         full HTML5 spec.
985
986         * rendering/style/StyleRareNonInheritedData.cpp:
987         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
988         * rendering/style/StyleRareNonInheritedData.h:
989
990 2011-10-07  Cary Clark  <caryclark@google.com>
991
992         Enable color profiles, unless profile is grayscale
993         https://bugs.webkit.org/show_bug.cgi?id=69622
994         https://bugs.webkit.org/show_bug.cgi?id=49950
995         http://code.google.com/p/chromium/issues/detail?id=80844
996
997         Further specialize the earlier fix described in 49950 to
998         allow color profiles in YCbCr images, but disallow color
999         profiles marked as grayData.
1000         (see http://www.color.org/ICC1v42_2006-05.pdf 7.2.6 )
1001
1002         Reviewed by Adam Barth.
1003
1004         Test: fast/images/gray-scale-jpeg-with-color-profile.html
1005               fast/images/color-jpeg-with-color-profile.html
1006
1007         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
1008         (WebCore::readColorProfile):
1009         (WebCore::JPEGImageReader::decode):
1010
1011 2011-10-07  Chris Fleizach  <cfleizach@apple.com>
1012
1013         AX: re-organize fake elements to use new AccessibilityMockObject
1014         https://bugs.webkit.org/show_bug.cgi?id=69588
1015
1016         This adds an AccessibilityMockObject for "fake" elements to descend from.
1017         Its benefit is to consolidate the various ways that these fake elements are setting
1018         and returning their parent objects.
1019
1020         No functional change, hence no new tests.
1021
1022         Reviewed by Jon Honeycutt.
1023
1024         * CMakeLists.txt:
1025         * GNUmakefile.list.am:
1026         * WebCore.gypi:
1027         * WebCore.pro:
1028         * WebCore.vcproj/WebCore.vcproj:
1029         * WebCore.xcodeproj/project.pbxproj:
1030         * accessibility/AccessibilityARIAGrid.cpp:
1031         (WebCore::AccessibilityARIAGrid::addChildren):
1032         * accessibility/AccessibilityImageMapLink.cpp:
1033         (WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):
1034         * accessibility/AccessibilityImageMapLink.h:
1035         (WebCore::AccessibilityImageMapLink::node):
1036         * accessibility/AccessibilityMenuList.cpp:
1037         (WebCore::AccessibilityMenuList::addChildren):
1038         * accessibility/AccessibilityMenuList.h:
1039         (WebCore::toAccessibilityMenuList):
1040         * accessibility/AccessibilityMenuListOption.cpp:
1041         (WebCore::AccessibilityMenuListOption::AccessibilityMenuListOption):
1042         (WebCore::AccessibilityMenuListOption::isVisible):
1043         * accessibility/AccessibilityMenuListOption.h:
1044         * accessibility/AccessibilityMenuListPopup.cpp:
1045         (WebCore::AccessibilityMenuListPopup::AccessibilityMenuListPopup):
1046         (WebCore::AccessibilityMenuListPopup::isOffScreen):
1047         (WebCore::AccessibilityMenuListPopup::isEnabled):
1048         (WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):
1049         (WebCore::AccessibilityMenuListPopup::press):
1050         (WebCore::AccessibilityMenuListPopup::addChildren):
1051         (WebCore::AccessibilityMenuListPopup::childrenChanged):
1052         (WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
1053         * accessibility/AccessibilityMenuListPopup.h:
1054         * accessibility/AccessibilityMockObject.cpp: Added.
1055         (WebCore::AccessibilityMockObject::AccessibilityMockObject):
1056         (WebCore::AccessibilityMockObject::~AccessibilityMockObject):
1057         * accessibility/AccessibilityMockObject.h: Added.
1058         (WebCore::AccessibilityMockObject::parentObject):
1059         (WebCore::AccessibilityMockObject::setParent):
1060         (WebCore::AccessibilityMockObject::detachFromParent):
1061         * accessibility/AccessibilitySlider.cpp:
1062         (WebCore::AccessibilitySlider::addChildren):
1063         (WebCore::AccessibilitySliderThumb::AccessibilitySliderThumb):
1064         (WebCore::AccessibilitySliderThumb::elementRect):
1065         * accessibility/AccessibilitySlider.h:
1066         * accessibility/AccessibilityTable.cpp:
1067         (WebCore::AccessibilityTable::addChildren):
1068         (WebCore::AccessibilityTable::headerContainer):
1069         * accessibility/AccessibilityTable.h:
1070         (WebCore::toAccessibilityTable):
1071         * accessibility/AccessibilityTableColumn.cpp:
1072         (WebCore::AccessibilityTableColumn::AccessibilityTableColumn):
1073         (WebCore::AccessibilityTableColumn::setParent):
1074         (WebCore::AccessibilityTableColumn::headerObject):
1075         (WebCore::AccessibilityTableColumn::headerObjectForSection):
1076         (WebCore::AccessibilityTableColumn::accessibilityIsIgnored):
1077         (WebCore::AccessibilityTableColumn::addChildren):
1078         * accessibility/AccessibilityTableColumn.h:
1079         * accessibility/AccessibilityTableHeaderContainer.cpp:
1080         (WebCore::AccessibilityTableHeaderContainer::AccessibilityTableHeaderContainer):
1081         (WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):
1082         (WebCore::AccessibilityTableHeaderContainer::addChildren):
1083         * accessibility/AccessibilityTableHeaderContainer.h:
1084
1085 2011-10-07  Nate Chapin  <japhet@chromium.org>
1086
1087         Make IconLoader a CachedResourceClient instead of a SubresourceLoaderClient.
1088         This is one of the steps required to remove the SubresourceLoaderClient interface,
1089         which will simplify the layering in the loader.
1090         https://bugs.webkit.org/show_bug.cgi?id=69567
1091
1092         Reviewed by Adam Barth.
1093
1094         No new tests, no functionality change intended.
1095
1096         * CMakeLists.txt:
1097         * GNUmakefile.list.am:
1098         * WebCore.gypi:
1099         * WebCore.pro:
1100         * WebCore.vcproj/WebCore.vcproj:
1101         * WebCore.xcodeproj/project.pbxproj:
1102         * loader/cache/CachedRawResource.cpp: Added.
1103         * loader/cache/CachedRawResource.h: Added.
1104         * loader/cache/CachedResource.cpp:
1105         * loader/cache/CachedResource.h:
1106         (WebCore::CachedResource::ignoreForRequestCount): Renamed and generalized from isLinkResource(),
1107             which was only used to decided whether the CachedResource should count toward
1108             CachedResourceLoader::requestCount().
1109         * loader/cache/CachedResourceLoader.cpp:
1110         * loader/cache/CachedResourceLoader.h:
1111         * loader/cache/CachedResourceRequest.cpp:
1112         * loader/cache/CachedResourceRequest.h:
1113         * loader/icon/IconLoader.cpp: Get a CachedResource instead of a SubresourceLoader.
1114         (WebCore::IconLoader::notifyFinished): Merge in the status code check that was in didReceiveResponse(),
1115             since we won't be checking any callbacks before the load completes.
1116         * loader/icon/IconLoader.h:
1117
1118 2011-10-07  Adam Bergkvist  <adam.bergkvist@ericsson.com>
1119
1120         Add WebCore platform interfaces needed by updated PeerConnection design
1121         https://bugs.webkit.org/show_bug.cgi?id=68460
1122
1123         Reviewed by Adam Barth.
1124
1125         Added the PeerConnection platform files to WebCore/platform/mediastream
1126
1127         Currently not testable.
1128
1129         * GNUmakefile.am:
1130         * GNUmakefile.list.am:
1131         * WebCore.gyp/WebCore.gyp:
1132         * WebCore.gypi:
1133         * platform/mediastream/MediaStreamComponent.h: Added.
1134         (WebCore::MediaStreamComponent::create):
1135         (WebCore::MediaStreamComponent::source):
1136         (WebCore::MediaStreamComponent::enabled):
1137         (WebCore::MediaStreamComponent::setEnabled):
1138         (WebCore::MediaStreamComponent::MediaStreamComponent):
1139         * platform/mediastream/MediaStreamDescriptor.h: Added.
1140         (WebCore::MediaStreamDescriptor::create):
1141         (WebCore::MediaStreamDescriptor::owner):
1142         (WebCore::MediaStreamDescriptor::setOwner):
1143         (WebCore::MediaStreamDescriptor::label):
1144         (WebCore::MediaStreamDescriptor::component):
1145         (WebCore::MediaStreamDescriptor::numberOfComponents):
1146         (WebCore::MediaStreamDescriptor::ended):
1147         (WebCore::MediaStreamDescriptor::setEnded):
1148         (WebCore::MediaStreamDescriptor::MediaStreamDescriptor):
1149         * platform/mediastream/MediaStreamSource.h: Added.
1150         (WebCore::MediaStreamSource::create):
1151         (WebCore::MediaStreamSource::id):
1152         (WebCore::MediaStreamSource::type):
1153         (WebCore::MediaStreamSource::name):
1154         (WebCore::MediaStreamSource::muted):
1155         (WebCore::MediaStreamSource::setMuted):
1156         (WebCore::MediaStreamSource::MediaStreamSource):
1157         * platform/mediastream/PeerHandler.cpp: Added.
1158         (WebCore::PeerHandler::PeerHandler):
1159         (WebCore::PeerHandler::~PeerHandler):
1160         (WebCore::PeerHandler::produceInitialOffer):
1161         (WebCore::PeerHandler::handleInitialOffer):
1162         (WebCore::PeerHandler::processSDP):
1163         (WebCore::PeerHandler::processPendingStreams):
1164         (WebCore::PeerHandler::sendDataStreamMessage):
1165         (WebCore::PeerHandler::stop):
1166         * platform/mediastream/PeerHandler.h: Added.
1167         (WebCore::PeerHandlerClient::~PeerHandlerClient):
1168         (WebCore::PeerHandler::create):
1169
1170 2011-10-07  Vineet Chaudary  <vineet.chaudhary@motorola.com>
1171
1172         background-color affects the font color in disabled textarea.
1173         https://bugs.webkit.org/show_bug.cgi?id=65361
1174
1175         Reviewed by Darin Adler.
1176
1177         For the transparent/translucent background colors use lightening fortext color.
1178
1179         * rendering/RenderTextControl.cpp:
1180         (WebCore::disabledTextColor):
1181
1182 2011-10-07  David Barr  <davidbarr@chromium.org>
1183
1184         Implement currentColor support for box-shadow and text-shadow
1185         https://bugs.webkit.org/show_bug.cgi?id=68218
1186
1187         Reviewed by Simon Fraser.
1188
1189         Test: fast/box-shadow/box-shadow-currentcolor.html
1190
1191         * css/CSSParser.cpp:
1192         (WebCore::CSSParser::parseShadow): Add CSSValueCurrentcolor to supported keywords.
1193
1194 2011-10-07  Pavel Feldman  <pfeldman@google.com>
1195
1196         Web Inspector: add Audits panel to the compilation.
1197         https://bugs.webkit.org/show_bug.cgi?id=69633
1198
1199         Reviewed by Yury Semikhatsky.
1200
1201         * inspector/compile-front-end.sh:
1202         * inspector/front-end/AuditCategories.js:
1203         * inspector/front-end/AuditLauncherView.js:
1204         * inspector/front-end/AuditResultView.js:
1205         * inspector/front-end/AuditRules.js:
1206         (WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
1207         (WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
1208         (WebInspector.AuditRules.CacheControlRule.prototype.handleNonCacheableResources):
1209         * inspector/front-end/AuditsPanel.js:
1210         (WebInspector.AuditsPanel):
1211         * inspector/front-end/NetworkLog.js:
1212         * inspector/front-end/treeoutline.js:
1213
1214 2011-10-07  Andreas Kling  <kling@webkit.org>
1215
1216         Functions that return "const Color" should simply return "Color".
1217
1218         Rubber-stamped by Antti Koivisto.
1219
1220         * rendering/RenderLayerBacking.cpp:
1221         (WebCore::RenderLayerBacking::rendererBackgroundColor):
1222         * rendering/RenderLayerBacking.h:
1223         * rendering/RenderTable.h:
1224         (WebCore::RenderTable::bgColor):
1225         * rendering/style/RenderStyle.cpp:
1226         (WebCore::RenderStyle::colorIncludingFallback):
1227         (WebCore::RenderStyle::visitedDependentColor):
1228         * rendering/style/RenderStyle.h:
1229
1230 2011-10-07  Pavel Feldman  <pfeldman@google.com>
1231
1232         Web Inspector: TypeError: Cannot read property 'styleSheetId' of undefined in tests.
1233         https://bugs.webkit.org/show_bug.cgi?id=69634
1234
1235         Reviewed by Yury Semikhatsky.
1236
1237         * inspector/front-end/CSSStyleModel.js:
1238         (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
1239
1240 2011-10-06  Andreas Kling  <kling@webkit.org>
1241
1242         Shrink BorderValue.
1243         https://bugs.webkit.org/show_bug.cgi?id=69521
1244
1245         Reviewed by Antti Koivisto.
1246
1247         Unroll BorderValue's Color member so we can pack the color's validity flag
1248         in BorderValue's bitfield.
1249
1250         This shrinks BorderValue by 32 bit, which in turn shrinks BorderData by
1251         16 bytes. This reduces memory consumption by 760 kB when loading the full
1252         HTML5 spec.
1253
1254         * platform/graphics/Color.h:
1255         (WebCore::Color::Color):
1256
1257             Allow construction of Color objects with specific validity.
1258
1259         * rendering/style/BorderValue.h:
1260         (WebCore::BorderValue::BorderValue):
1261         (WebCore::BorderValue::isTransparent):
1262         (WebCore::BorderValue::operator==):
1263         (WebCore::BorderValue::setColor):
1264         (WebCore::BorderValue::color):
1265         * rendering/style/OutlineValue.h:
1266         (WebCore::OutlineValue::operator==):
1267
1268             Unroll m_color into BorderValue by splitting it into an RGBA32 and a bool.
1269             Made those variables private and added color(), setColor() accessors.
1270
1271         * rendering/style/RenderStyle.h:
1272         (WebCore::InheritedFlags::setBorderLeftColor):
1273         (WebCore::InheritedFlags::setBorderRightColor):
1274         (WebCore::InheritedFlags::setBorderTopColor):
1275         (WebCore::InheritedFlags::setBorderBottomColor):
1276         (WebCore::InheritedFlags::setOutlineColor):
1277         (WebCore::InheritedFlags::setColumnRuleColor):
1278
1279             Added a SET_BORDERVALUE_COLOR macro and use that instead of SET_VAR
1280             when setting BorderValue colors.
1281
1282         (WebCore::InheritedFlags::fillPaintColor):
1283         (WebCore::InheritedFlags::strokePaintColor):
1284         (WebCore::InheritedFlags::borderLeftColor):
1285         (WebCore::InheritedFlags::borderRightColor):
1286         (WebCore::InheritedFlags::borderTopColor):
1287         (WebCore::InheritedFlags::borderBottomColor):
1288         (WebCore::InheritedFlags::backgroundColor):
1289         (WebCore::InheritedFlags::color):
1290         (WebCore::InheritedFlags::columnRuleColor):
1291         (WebCore::InheritedFlags::outlineColor):
1292         (WebCore::InheritedFlags::textEmphasisColor):
1293         (WebCore::InheritedFlags::textFillColor):
1294         (WebCore::InheritedFlags::textStrokeColor):
1295         (WebCore::InheritedFlags::stopColor):
1296         (WebCore::InheritedFlags::floodColor):
1297         (WebCore::InheritedFlags::lightingColor):
1298
1299             Made color getters return "Color" instead of "const Color&" since
1300             BorderValue no longer has an actual object to return the reference to.
1301
1302         * css/CSSStyleApplyProperty.cpp:
1303         (WebCore::ApplyPropertyColor::applyInheritValue):
1304         * page/animation/AnimationBase.cpp:
1305         (WebCore::PropertyWrapperColor::PropertyWrapperColor):
1306         (WebCore::PropertyWrapperColor::blend):
1307         (WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
1308         (WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
1309         (WebCore::AnimationBase::ensurePropertyMap):
1310
1311             Adapt to RenderStyle color getters now returning "Color" instead of
1312             "const Color&".
1313
1314 2011-10-07  Philippe Normand  <pnormand@igalia.com>
1315
1316         [GStreamer] webkitwebsrc: avoid GST_BOILERPLATE_FULL
1317         https://bugs.webkit.org/show_bug.cgi?id=69630
1318
1319         Reviewed by Martin Robinson.
1320
1321         Use G_DEFINE_TYPE_WITH_CODE instead of GST_BOILERPLATE_FULL and
1322         replace use of gst_ghost_pad_new_no_target_from_template() and
1323         gst_ghost_pad_set_target() with a single call to
1324         gst_ghost_pad_new_from_template(). These changes keep the element
1325         compatible with GStreamer 0.10 while preparing the port to 0.11.
1326
1327         * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
1328         (webkit_web_src_class_init):
1329         (webkit_web_src_init):
1330
1331 2011-10-07  Martin Robinson  <mrobinson@igalia.com>
1332
1333         [Freetype] Pseudo-italics do not work
1334         https://bugs.webkit.org/show_bug.cgi?id=40856
1335
1336         Reviewed by Philippe Normand.
1337
1338         * platform/graphics/freetype/FontPlatformData.h: Add the font description as an argument initializeWithFontFace.
1339         * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
1340         (WebCore::FontPlatformData::FontPlatformData): Pass the font description to initializeWithFontFace.
1341         (WebCore::FontPlatformData::initializeWithFontFace): If we were asked for an italic font and we were
1342         given one that wasn't oblique or italic, activate the synthetic oblique bit.
1343
1344 2011-10-07  Philippe Normand  <pnormand@igalia.com>
1345
1346         [GStreamer] avoid direct access to GstMessage structure field
1347         https://bugs.webkit.org/show_bug.cgi?id=69629
1348
1349         Reviewed by Martin Robinson.
1350
1351         Use gst_message_get_structure() instead of direct access to the
1352         structure field. No direct benefit apart from compatibility with
1353         GStreamer 0.11.
1354
1355         * platform/graphics/gstreamer/GStreamerGWorld.cpp:
1356         (WebCore::gstGWorldSyncMessageCallback):
1357         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
1358         (WebCore::MediaPlayerPrivateGStreamer::handleMessage):
1359         (WebCore::MediaPlayerPrivateGStreamer::mediaLocationChanged):
1360
1361 2011-10-07  Pavel Feldman  <pfeldman@google.com>
1362
1363         Web Inspector: add timeline panel to the compilation.
1364         https://bugs.webkit.org/show_bug.cgi?id=69628
1365
1366         Reviewed by Yury Semikhatsky.
1367
1368         * inspector/compile-front-end.sh:
1369         * inspector/front-end/SidebarTreeElement.js:
1370         (WebInspector.SidebarTreeElement):
1371         * inspector/front-end/SourceCSSTokenizer.js:
1372         (WebInspector.SourceCSSTokenizer.prototype.nextToken):
1373         * inspector/front-end/SourceCSSTokenizer.re2js:
1374         * inspector/front-end/SourceHTMLTokenizer.js:
1375         (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
1376         * inspector/front-end/SourceHTMLTokenizer.re2js:
1377         * inspector/front-end/SourceJavaScriptTokenizer.js:
1378         (WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
1379         * inspector/front-end/SourceJavaScriptTokenizer.re2js:
1380         * inspector/front-end/TimelineGrid.js:
1381         * inspector/front-end/TimelineOverviewPane.js:
1382         (WebInspector.TimelineOverviewPane.prototype._createTimelineCategoryStatusBarCheckbox):
1383         * inspector/front-end/TimelinePanel.js:
1384         (WebInspector.TimelinePanel.prototype._createEventDivider):
1385         (WebInspector.TimelinePanel.prototype._addRecordToTimeline):
1386         (WebInspector.TimelinePanel.prototype._findParentRecord):
1387         (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
1388         (WebInspector.TimelinePanel.prototype.updateMainViewWidth):
1389         (WebInspector.TimelinePanel.prototype.onResize):
1390         (WebInspector.TimelinePanel.prototype._windowChanged):
1391         (WebInspector.TimelinePanel.prototype._refreshRecords):
1392         (WebInspector.TimelineRecordGraphRow.prototype._onClick):
1393         (WebInspector.TimelinePanel.FormattedRecord):
1394         (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
1395         (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
1396
1397 2011-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1398
1399         Unreviewed, rolling out r96892.
1400         http://trac.webkit.org/changeset/96892
1401         https://bugs.webkit.org/show_bug.cgi?id=69626
1402
1403         it broke windows canary bots (Requested by podivilov on
1404         #webkit).
1405
1406         * WebCore.gyp/scripts/rule_binding.py:
1407
1408 2011-10-07  Andreas Kling  <kling@webkit.org>
1409
1410         Shrink StyleInheritedData.
1411         https://bugs.webkit.org/show_bug.cgi?id=69625
1412
1413         Reviewed by Antti Koivisto.
1414
1415         Rearrange the members of StyleInheritedData to fold as much
1416         as possible into the padding at the end of RefCounted.
1417
1418         This shrinks StyleInheritedData by 8 bytes on 64-bit, reducing
1419         memory consumption by 500 kB when loading the full HTML5 spec.
1420
1421         * rendering/style/StyleInheritedData.cpp:
1422         (WebCore::StyleInheritedData::StyleInheritedData):
1423         * rendering/style/StyleInheritedData.h:
1424
1425 2011-10-07  Pavel Feldman  <pfeldman@google.com>
1426
1427         Web Inspector: make ScriptsPanel compile
1428         https://bugs.webkit.org/show_bug.cgi?id=69623
1429
1430         Reviewed by Yury Semikhatsky.
1431
1432         * inspector/compile-front-end.sh:
1433         * inspector/front-end/CallStackSidebarPane.js:
1434         (WebInspector.CallStackSidebarPane.prototype.update):
1435         (WebInspector.CallStackSidebarPane.prototype._placardSelected):
1436         * inspector/front-end/DebuggerModel.js:
1437         * inspector/front-end/JavaScriptSourceFrame.js:
1438         (WebInspector.JavaScriptSourceFrame):
1439         * inspector/front-end/KeyboardShortcut.js:
1440         * inspector/front-end/Object.js:
1441         * inspector/front-end/ObjectPropertiesSection.js:
1442         * inspector/front-end/ScopeChainSidebarPane.js:
1443         (WebInspector.ScopeChainSidebarPane.prototype.update):
1444         * inspector/front-end/ScriptsPanel.js:
1445         (WebInspector.ScriptsPanel.prototype._setScriptSourceIsBeingEdited):
1446         (WebInspector.ScriptsPanel.prototype._createSourceFrame):
1447         (WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
1448         (WebInspector.SourceFrameDelegateForScriptsPanel):
1449         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
1450         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.debuggingSupported):
1451         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setBreakpoint):
1452         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.updateBreakpoint):
1453         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.removeBreakpoint):
1454         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.findBreakpoint):
1455         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.continueToLine):
1456         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.canEditScriptSource):
1457         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSource):
1458         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSourceIsBeingEdited):
1459         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.debuggerPaused):
1460         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.evaluateInSelectedCallFrame):
1461         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.releaseEvaluationResult):
1462         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
1463         * inspector/front-end/StatusBarButton.js:
1464         * inspector/front-end/WatchExpressionsSidebarPane.js:
1465         (WebInspector.WatchExpressionsSection.prototype.update.appendResult):
1466         (WebInspector.WatchExpressionsSection.prototype.update):
1467         (WebInspector.WatchExpressionTreeElement.prototype.startEditing):
1468         * inspector/front-end/WorkerManager.js:
1469         (WebInspector.WorkerManager.prototype._openInspectorWindow):
1470         (WebInspector.WorkerManager.prototype._pageInspectorClosing):
1471         (WebInspector.DedicatedWorkerMessageForwarder.prototype._receiveMessage):
1472         * inspector/front-end/WorkersSidebarPane.js:
1473         (WebInspector.WorkersSidebarPane.prototype.removeWorker):
1474         * inspector/front-end/externs.js:
1475         (WebInspector.linkifyURL):
1476         (InjectedFakeWorker):
1477         * inspector/front-end/inspector.js:
1478
1479 2011-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1480
1481         Unreviewed, rolling out r96879.
1482         http://trac.webkit.org/changeset/96879
1483         https://bugs.webkit.org/show_bug.cgi?id=69618
1484
1485         Broke CCLayerTreeHostTestShortlived1 on chromium mac.
1486         (Requested by podivilov on #webkit).
1487
1488         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
1489
1490 2011-10-07  Pavel Feldman  <pfeldman@google.com>
1491
1492         Web Inspector: add ResourcesPanel to the compilation.
1493         https://bugs.webkit.org/show_bug.cgi?id=69612
1494
1495         Reviewed by Yury Semikhatsky.
1496
1497         * inspector/compile-front-end.sh:
1498         * inspector/front-end/ApplicationCacheItemsView.js:
1499         (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
1500         * inspector/front-end/NetworkPanel.js:
1501         * inspector/front-end/ResourceView.js:
1502         * inspector/front-end/ResourcesPanel.js:
1503         (WebInspector.ResourcesPanel.prototype.showAnchorLocation):
1504         (WebInspector.ResourcesPanel.prototype.showResource):
1505         (WebInspector.BaseStorageTreeElement.prototype.isEventWithinDisclosureTriangle):
1506         (WebInspector.FrameTreeElement.prototype.frameNavigated):
1507         (WebInspector.StorageCategoryView):
1508         (WebInspector.SearchResultsTreeElementsTraverser.prototype.last):
1509         * inspector/front-end/externs.js:
1510         (WebInspector.openRequestInNetworkPanel):
1511
1512 2011-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1513
1514         Unreviewed, rolling out r96909.
1515         http://trac.webkit.org/changeset/96909
1516         https://bugs.webkit.org/show_bug.cgi?id=69616
1517
1518         Broke chromium mac compilation (Requested by podivilov on
1519         #webkit).
1520
1521         * platform/graphics/chromium/ContentLayerChromium.h:
1522
1523 2011-10-07  Vsevolod Vlasov  <vsevik@chromium.org>
1524
1525         Web Inspector: Element highlighting does not highlight padding/border/margin for inline elements.
1526         https://bugs.webkit.org/show_bug.cgi?id=69558
1527
1528         Reviewed by Pavel Feldman.
1529
1530         * inspector/DOMNodeHighlighter.cpp:
1531
1532 2011-10-07  Mario Sanchez Prada  <msanchez@igalia.com>
1533
1534         [GTK] Don't expose objects with unknown role on GTK
1535         https://bugs.webkit.org/show_bug.cgi?id=69561
1536
1537         Reviewed by Chris Fleizach.
1538
1539         Ignore accessibility objects in accessibilityPlatformIncludesObject.
1540
1541         Test: platform/gtk/accessibility/unknown-roles-not-exposed.html
1542
1543         * accessibility/gtk/AccessibilityObjectAtk.cpp:
1544         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
1545         For unknown accessibility objects, return IgnoreObject.
1546
1547 2011-10-07  Pavel Feldman  <pfeldman@chromium.org>
1548
1549         Web Inspector: add Elements and Network panels to the compilation
1550         https://bugs.webkit.org/show_bug.cgi?id=69604
1551
1552         Reviewed by Yury Semikhatsky.
1553
1554         * inspector/compile-front-end.sh:
1555         * inspector/front-end/BreakpointsSidebarPane.js:
1556         (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked):
1557         (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked):
1558         * inspector/front-end/DOMAgent.js:
1559         * inspector/front-end/DOMBreakpointsSidebarPane.js:
1560         * inspector/front-end/DataGrid.js:
1561         (WebInspector.DataGrid.prototype._startEditingConfig):
1562         * inspector/front-end/Drawer.js:
1563         * inspector/front-end/ElementsPanel.js:
1564         (WebInspector.ElementsPanel.prototype._hideSearchHighlights):
1565         (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
1566         (WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes.collapseDimmed):
1567         (WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes):
1568         (WebInspector.ElementsPanel.prototype._registerShortcuts):
1569         * inspector/front-end/ElementsTreeOutline.js:
1570         (WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
1571         (WebInspector.ElementsTreeElement.prototype._startEditingTextNode):
1572         (WebInspector.ElementsTreeElement.prototype._startEditingTagName):
1573         (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
1574         * inspector/front-end/GoToLineDialog.js:
1575         (WebInspector.GoToLineDialog._show):
1576         * inspector/front-end/MetricsSidebarPane.js:
1577         (WebInspector.MetricsSidebarPane.prototype.startEditing):
1578         * inspector/front-end/NetworkPanel.js:
1579         (WebInspector.NetworkLogView.prototype._onLoadEventFired):
1580         (WebInspector.NetworkLogView.prototype._domContentLoadedEventFired):
1581         (WebInspector.NetworkLogView.prototype._updateOffscreenRows):
1582         (WebInspector.NetworkLogView.prototype._removeAllNodeHighlights):
1583         (WebInspector.NetworkPanel.prototype._resourceByAnchor):
1584         (WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
1585         * inspector/front-end/ObjectPropertiesSection.js:
1586         (WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
1587         * inspector/front-end/Panel.js:
1588         * inspector/front-end/Popover.js:
1589         * inspector/front-end/SourceFrame.js:
1590         (WebInspector.SourceFrame.prototype._editBreakpointCondition):
1591         * inspector/front-end/StylesSidebarPane.js:
1592         (WebInspector.StylePropertiesSection.prototype.startEditingSelector):
1593         (WebInspector.StylePropertyTreeElement.prototype):
1594         * inspector/front-end/TimelineGrid.js:
1595         * inspector/front-end/UIUtils.js:
1596         (WebInspector.EditingConfig):
1597         (WebInspector.startEditing.editingCancelled):
1598         (WebInspector.startEditing.editingCommitted):
1599         (WebInspector.formatLocalized):
1600         (WebInspector.openLinkExternallyLabel):
1601         (WebInspector.openInNetworkPanelLabel):
1602         (WebInspector.copyLinkAddressLabel):
1603         * inspector/front-end/externs.js:
1604         (WebInspector.extensionServer.notifyObjectSelected):
1605         (WebInspector.openResource):
1606         * inspector/front-end/inspector.js:
1607         (WebInspector.resourceForURL):
1608
1609 2011-10-07  Anna Cavender  <annacc@chromium.org>
1610
1611         Change enum value names for TextTrack::readyState and TextTrack::mode
1612         https://bugs.webkit.org/show_bug.cgi?id=69603
1613
1614         Reviewed by David Levin.
1615
1616         No new tests. No new functionality.
1617
1618         * html/LoadableTextTrack.cpp:
1619         (WebCore::LoadableTextTrack::trackLoadStarted):
1620         (WebCore::LoadableTextTrack::trackLoadError):
1621         (WebCore::LoadableTextTrack::trackLoadCompleted):
1622         * html/TextTrack.cpp:
1623         (WebCore::TextTrack::TextTrack):
1624         (WebCore::TextTrack::setMode):
1625         * html/TextTrack.h:
1626
1627 2011-10-07  Anna Cavender  <annacc@chromium.org>
1628
1629         Adding parens in WebVTTParser.cpp to appease compiler preferences.
1630         https://bugs.webkit.org/show_bug.cgi?id=69602
1631
1632         Reviewed by David Levin.
1633
1634         No new tests. No new functionality.
1635
1636         * html/track/WebVTTParser.cpp:
1637         (WebCore::WebVTTParser::constructTreeFromToken):
1638
1639 2011-10-06  Antoine Labour  <piman@chromium.org>
1640
1641         Webkit API for compositor
1642         https://bugs.webkit.org/show_bug.cgi?id=69107
1643
1644         Reviewed by Darin Fisher.
1645
1646         Covered by existing compositing tests.
1647
1648         * platform/graphics/chromium/ContentLayerChromium.h: 
1649
1650 2011-10-06  Kent Tamura  <tkent@chromium.org>
1651
1652         Remove SelectElement class
1653         https://bugs.webkit.org/show_bug.cgi?id=69518
1654
1655         Reviewed by Ryosuke Niwa.
1656
1657         SelectElement used to be an abstract class for HTMLSelectElement
1658         and WMLSelectElement. SelectElement is not needed anymore because
1659         WML was removed.
1660
1661         This patch just removes SelectElement by moving SelectElement
1662         functions to HTMLSelectElement.
1663
1664         No new tests. Just a refactoring.
1665
1666         * WebCore.vcproj/WebCore.vcproj:
1667         Rename dom\SelectElementWin.cpp to html\HTMLSelectElementWin.cpp.
1668         * accessibility/AccessibilityListBoxOption.cpp:
1669         (WebCore::AccessibilityListBoxOption::setSelected):
1670         Remove unnecessary cast.
1671         * accessibility/AccessibilityRenderObject.cpp:
1672         (WebCore::AccessibilityRenderObject::stringValue):
1673         Use HTMLSelectElement instead of SelectElement.
1674         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1675         (optionFromSelection): ditto.
1676         (webkit_accessible_selection_get_selection_count): ditto.
1677         * accessibility/gtk/AXObjectCacheAtk.cpp:
1678         (notifyChildrenSelectionChange): ditto.
1679         * dom/OptionElement.cpp:
1680         (WebCore::OptionElement::optionIndex): ditto.
1681         * dom/OptionElement.h: ditto.
1682         * dom/SelectElement.cpp:
1683         (WebCore::SelectElementData::checkListItems): ditto.
1684         (WebCore::SelectElementData::listItems): ditto.
1685         * dom/SelectElementWin.cpp: Removed.
1686         * dom/SelectElement.h: Removed SelectElement class declaration.
1687         * html/HTMLSelectElement.cpp: Move functions from SelectElement.cpp.
1688         (WebCore::HTMLSelectElement::selectedIndex):
1689         Removed 'SelectElement::' because the function is moved to HTMLSelectElement.
1690         (WebCore::HTMLSelectElement::deselectItems): dito.
1691         (WebCore::HTMLSelectElement::setSelectedIndex): dito.
1692         (WebCore::HTMLSelectElement::setSelectedIndexByUser): ditto.
1693         (WebCore::HTMLSelectElement::activeSelectionEndListIndex): ditto.
1694         (WebCore::HTMLSelectElement::length): ditto.
1695         (WebCore::HTMLSelectElement::saveFormControlState): ditto.
1696         (WebCore::HTMLSelectElement::restoreFormControlState): ditto.
1697         (WebCore::HTMLSelectElement::parseMappedAttribute): ditto.
1698         (WebCore::HTMLSelectElement::selectAll): ditto.
1699         (WebCore::HTMLSelectElement::appendFormData): ditto.
1700         (WebCore::HTMLSelectElement::optionToListIndex): ditto.
1701         (WebCore::HTMLSelectElement::listToOptionIndex): ditto.
1702         (WebCore::HTMLSelectElement::recalcListItems): ditto.
1703         (WebCore::HTMLSelectElement::setRecalcListItems): ditto.
1704         (WebCore::HTMLSelectElement::reset): ditto.
1705         (WebCore::HTMLSelectElement::dispatchFocusEvent): ditto.
1706         (WebCore::HTMLSelectElement::dispatchBlurEvent): ditto.
1707         (WebCore::HTMLSelectElement::defaultEventHandler): ditto.
1708         (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto.
1709         (WebCore::HTMLSelectElement::setActiveSelectionEndIndex): ditto.
1710         (WebCore::HTMLSelectElement::updateListBoxSelection): ditto.
1711         (WebCore::HTMLSelectElement::menuListOnChange): ditto.
1712         (WebCore::HTMLSelectElement::listBoxOnChange): ditto.
1713         (WebCore::HTMLSelectElement::saveLastSelection): ditto.
1714         (WebCore::HTMLSelectElement::accessKeySetSelectedIndex): ditto.
1715         (WebCore::HTMLSelectElement::scrollToSelection): ditto.
1716         (WebCore::HTMLSelectElement::insertedIntoTree): ditto.
1717         (WebCore::nextValidIndex): Moved from SelectElement.cpp.
1718         (WebCore::nextSelectableListIndex): ditto.
1719         (WebCore::previousSelectableListIndex): ditto.
1720         (WebCore::firstSelectableListIndex): ditto.
1721         (WebCore::lastSelectableListIndex): ditto.
1722         (WebCore::nextSelectableListIndexPageAway): ditto.
1723         (WebCore::HTMLSelectElement::setOptionsChangedOnRenderer): ditto.
1724         (WebCore::HTMLSelectElement::parseMultipleAttribute): ditto.
1725         (WebCore::HTMLSelectElement::platformHandleKeydownEvent): ditto.
1726         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
1727         (WebCore::HTMLSelectElement::updateSelectedState): ditto.
1728         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
1729         (WebCore::HTMLSelectElement::lastSelectedListIndex): ditto.
1730         (WebCore::stripLeadingWhiteSpace): ditto.
1731         (WebCore::HTMLSelectElement::typeAheadFind): ditto.
1732         (WebCore::HTMLSelectElement::optionCount): ditto.
1733         (WebCore::toSelectElement): ditto.
1734         * html/HTMLSelectElementWin.cpp: Copied from Source/WebCore/dom/SelectElementWin.cpp.
1735         (WebCore::HTMLSelectElement::platformHandleKeydownEvent):
1736         * html/HTMLSelectElement.h: Removed 'virtual' of SelectElement functions.
1737         (WebCore::HTMLSelectElement::size):
1738         (WebCore::HTMLSelectElement::multiple):
1739         (WebCore::HTMLSelectElement::listItems):
1740         (WebCore::HTMLSelectElement::updateValidity):
1741         * rendering/RenderListBox.cpp: Replace SelectElement with HTMLSelectElement
1742         (WebCore::RenderListBox::RenderListBox):
1743         (WebCore::RenderListBox::scrollToRevealSelection):
1744         (WebCore::RenderListBox::addFocusRingRects):
1745         (WebCore::RenderListBox::paintItemForeground):
1746         (WebCore::RenderListBox::paintItemBackground):
1747         (WebCore::RenderListBox::panScroll):
1748         (WebCore::RenderListBox::autoscroll):
1749         (WebCore::RenderListBox::valueChanged):
1750         * rendering/RenderMenuList.cpp: Replace SelectElement with HTMLSelectElement
1751         (WebCore::RenderMenuList::RenderMenuList):
1752         (WebCore::RenderMenuList::setTextFromOption):
1753         (WebCore::RenderMenuList::showPopup):
1754         (WebCore::RenderMenuList::valueChanged):
1755         (WebCore::RenderMenuList::listBoxSelectItem):
1756         (WebCore::RenderMenuList::multiple):
1757         (WebCore::RenderMenuList::didSetSelectedIndex):
1758         (WebCore::RenderMenuList::didUpdateActiveOption):
1759         (WebCore::RenderMenuList::itemText):
1760         (WebCore::RenderMenuList::itemAccessibilityText):
1761         (WebCore::RenderMenuList::itemToolTip):
1762         (WebCore::RenderMenuList::itemIsEnabled):
1763         (WebCore::RenderMenuList::itemStyle):
1764         (WebCore::RenderMenuList::itemBackgroundColor):
1765         (WebCore::RenderMenuList::listSize):
1766         (WebCore::RenderMenuList::selectedIndex):
1767         (WebCore::RenderMenuList::itemIsSeparator):
1768         (WebCore::RenderMenuList::itemIsLabel):
1769         (WebCore::RenderMenuList::itemIsSelected):
1770         (WebCore::RenderMenuList::setTextFromItem):
1771
1772 2011-10-06  Sheriff Bot  <webkit.review.bot@gmail.com>
1773
1774         Unreviewed, rolling out r96896.
1775         http://trac.webkit.org/changeset/96896
1776         https://bugs.webkit.org/show_bug.cgi?id=69601
1777
1778         broke windows and mac chromium builds (Requested by simonjam
1779         on #webkit).
1780
1781         * platform/graphics/chromium/ContentLayerChromium.h:
1782
1783 2011-10-06  Antoine Labour  <piman@chromium.org>
1784
1785         Webkit API for compositor
1786         https://bugs.webkit.org/show_bug.cgi?id=69107
1787
1788         Reviewed by Darin Fisher.
1789
1790         Covered by existing compositing tests.
1791
1792         * platform/graphics/chromium/ContentLayerChromium.h: 
1793
1794 2011-10-06  Joseph Pecoraro  <joepeck@webkit.org>
1795
1796         Reviewed by Kent Tamura.
1797
1798         Pass "accept" mime type information into FileChooser at all call sites
1799         https://bugs.webkit.org/show_bug.cgi?id=69592
1800
1801         No new tests. This only exposes some more information to
1802         WebKit ports, no functionality change in WebCore.
1803
1804         * html/FileInputType.cpp:
1805         (WebCore::FileInputType::receiveDropForDirectoryUpload):
1806
1807 2011-10-06  Kent Tamura  <tkent@chromium.org>
1808
1809         [JSC binding] Fix inconsistent behavior of DOMStringMap
1810         https://bugs.webkit.org/show_bug.cgi?id=53752
1811
1812         Reviewed by Darin Adler.
1813
1814         The dataset behavior was inconsistent. The get operation handled
1815         data-* attributes first, and the put and delete operations handled
1816         JavaScript properties first.
1817
1818         Like Firefox and Opera, the put and delete operations should
1819         handle data-* attribute first.
1820
1821         * bindings/js/JSDOMStringMapCustom.cpp:
1822         (WebCore::JSDOMStringMap::deleteProperty):
1823          Handles DOMStringMap first, then returns false if the DOMStringMap makes an error.
1824         (WebCore::JSDOMStringMap::putDelegate): ditto.
1825
1826 2011-10-06  Nico Weber  <thakis@chromium.org>
1827
1828         [chromium] Let rule_binding use os.execvp() instead of subprocess.call() to spawn fewer processes.
1829         https://bugs.webkit.org/show_bug.cgi?id=69589
1830
1831         Reviewed by Adam Barth.
1832
1833         When building with `make -j40`, all the binding rules are built en bloc. Since this script currently
1834         uses subprocess.call(), that actually spawns 80 processes at once. OS X has a max process limit of
1835         255 by default, so the build used to fail with
1836         "open2: fork failed: Resource temporarily unavailable at ../bindings/scripts/preprocessor.pm line 60"
1837         As a fix, use execvp() instead, which replaces the current process instead of spawning a new one.
1838
1839         * WebCore.gyp/scripts/rule_binding.py:
1840
1841 2011-10-06  Anders Carlsson  <andersca@apple.com>
1842
1843         When building with clang, enable -Wglobal-constructors and -Wexit-time-destructors
1844         https://bugs.webkit.org/show_bug.cgi?id=69586
1845
1846         Reviewed by Darin Adler.
1847
1848         * Configurations/Base.xcconfig:
1849         Add -Wglobal-constructors and -Wexit-time-destructors when building with clang.
1850         
1851         * WebCore.xcodeproj/project.pbxproj:
1852         When building with clang, we don't need to run the check-for-global-initializers and
1853         check-for-exit-time-destructors anymore.
1854         
1855         * platform/graphics/filters/FEGaussianBlur.cpp:
1856         (gaussianKernelFactor):
1857         (WebCore::FEGaussianBlur::calculateKernelSize):
1858         (WebCore::FEGaussianBlur::calculateStdDeviation):
1859         Change the gaussian kernel factor global to be an inline function instead.
1860
1861 2011-10-06  Anders Carlsson  <andersca@apple.com>
1862
1863         Add DEFINE_DEBUG_ONLY_GLOBAL for globals that should be defined in debug builds
1864         https://bugs.webkit.org/show_bug.cgi?id=69584
1865
1866         Reviewed by Darin Adler.
1867
1868         Adopt the DEFINE_DEBUG_ONLY_GLOBAL macro.
1869
1870         * bindings/js/JSLazyEventListener.cpp:
1871         * dom/Node.cpp:
1872         * dom/Range.cpp:
1873         * history/CachedPage.cpp:
1874         * loader/SubresourceLoader.cpp:
1875         * loader/cache/CachedResource.cpp:
1876         * page/Frame.cpp:
1877         * page/Page.cpp:
1878         * rendering/BidiRun.cpp:
1879         * rendering/RenderObject.cpp:
1880         * svg/SVGElementInstance.cpp:
1881         * xml/XMLHttpRequest.cpp:
1882
1883 2011-10-06  James Robinson  <jamesr@chromium.org>
1884
1885         [chromium] Remove USE(THREADED_COMPOSITING) from the tree
1886         https://bugs.webkit.org/show_bug.cgi?id=69489
1887
1888         Reviewed by Darin Fisher.
1889
1890         This macro isn't needed any more since the logic it guarded is guarded by a runtime switch.
1891
1892         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
1893
1894 2011-10-06  David Grogan  <dgrogan@chromium.org>
1895
1896         Return null for the value of IDB key cursors instead of ASSERTing
1897         https://bugs.webkit.org/show_bug.cgi?id=69131
1898         
1899         This is in support of the IndexedDB performance improvement here:
1900         http://codereview.chromium.org/7834006/
1901
1902         Reviewed by Tony Chang.
1903
1904         * storage/IDBCursorBackendImpl.cpp:
1905         (WebCore::IDBCursorBackendImpl::value):
1906
1907 2011-10-06  Alexey Proskuryakov  <ap@apple.com>
1908
1909         [Mac] Should be able to scroll embedded PDFs using mouse
1910         https://bugs.webkit.org/show_bug.cgi?id=69579
1911
1912         Reviewed by Darin Adler.
1913
1914         Hit testing doesn't find scrollbars installed by a plug-in, so mouse events don't work.
1915
1916         As we want to use WebKit scrollbars with PDF plug-in, a cleaner long-term solution would be
1917         to have a base class under PluginViewBase that can handle scrolling instead of doing that
1918         in PluginView and Plugin.
1919
1920         * plugins/PluginViewBase.h:
1921         (WebCore::PluginViewBase::horizontalScrollbar):
1922         (WebCore::PluginViewBase::verticalScrollbar):
1923         Added accessors for scrollbars installed by plug-in.
1924
1925         * rendering/nodeAtPoint.cpp: (WebCore::RenderEmbeddedObject::nodeAtPoint):
1926         Like RenderLayer, add scrollbars to hit result after normal  hit testing.
1927
1928         * rendering/RenderEmbeddedObject.h: Added a nodeAtPoint override.
1929
1930         * rendering/RenderWidget.h: Made nodeAtPoint() protected instead of private, so that
1931         RenderEmbeddedObject could call it.
1932
1933 2011-10-06  Dan Bernstein  <mitz@apple.com>
1934
1935         <rdar://problem/9717490> Flash of white when navigating daringfireball.net
1936         https://bugs.webkit.org/show_bug.cgi?id=69581
1937
1938         Reviewed by Darin Adler.
1939
1940         * platform/ScrollView.cpp:
1941         (WebCore::ScrollView::updateScrollbars): Moved the calls to Scrollbar::setEnabled() into the code
1942         section where invalidation is suppressed if necessary, so that they do not trigger premature invalidation.
1943
1944 2011-10-06  Dan Bernstein  <mitz@apple.com>
1945
1946         Added a comment explaining code added in r96834.
1947
1948         Suggested by Darin Adler.
1949
1950         * editing/FrameSelection.cpp:
1951         (WebCore::FrameSelection::updateAppearance):
1952
1953 2011-10-05  Ryosuke Niwa  <rniwa@webkit.org>
1954
1955         Deleting line break before h1 converts h1 to span
1956         https://bugs.webkit.org/show_bug.cgi?id=45784
1957
1958         Reviewed by Enrica Casucci.
1959
1960         This patch fundamentally alters the kind of styles we preserve while merging or moving paragraphs.
1961         StylizedMarkupAccumulator no longer wraps nodes by computed style when it's not annotating for interchange.
1962         Instead, it accumulates implicit and inline styles of ancestors of the serialized contents.
1963
1964         The most significant code change is in StyledMarkupAccumulator::serializeNodes where we setup m_wrappingStyle
1965         by merging implicit and inline style of ancestors with mergeInlineAndImplicitStyleOfElement. Because it walks up
1966         the DOM tree upwards, it should not be overriding any CSS properties. Consequently, mergeStyle,
1967         mergeInlineStyleOfElement, and mergeInlineAndImplicitStyleOfElement are modified to take CSSPropertyOverrideMode.
1968
1969         New behavior matches that of Internet Explorer and Firefox when merging paragraphs.
1970
1971         Tests: editing/deleting/merge-paragraph-from-address.html
1972                editing/deleting/merge-paragraph-from-h6-with-style-2.html
1973                editing/deleting/merge-paragraph-from-h6-with-style.html
1974                editing/deleting/merge-paragraph-from-h6.html
1975                editing/deleting/merge-paragraph-from-listing.html
1976                editing/deleting/merge-paragraph-from-p-with-style-2.html
1977                editing/deleting/merge-paragraph-from-p-with-style-3.html
1978                editing/deleting/merge-paragraph-from-p-with-style.html
1979                editing/deleting/merge-paragraph-into-h1-with-style.html
1980                editing/deleting/merge-paragraph-into-h1.html
1981                editing/deleting/merge-paragraph-into-pre.html
1982
1983         * css/CSSValueList.cpp:
1984         (WebCore::CSSValueList::hasValue): Made const.
1985         * css/CSSValueList.h:
1986         * editing/ApplyStyleCommand.cpp:
1987         (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Calls mergeInlineStyleOfElement.
1988         (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Ditto.
1989         * editing/EditingStyle.cpp:
1990         (WebCore::copyEditingProperties): Takes a boolean includeBackgroundColor.
1991         (WebCore::isEditingProperty): Extracted from elementIsStyledSpanOrHTMLEquivalent.
1992         (WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent): Calls isEditingProperty.
1993         (WebCore::EditingStyle::mergeTypingStyle): Calls mergeStyle.
1994         (WebCore::EditingStyle::mergeInlineStyleOfElement): Takes CSSPropertyOverrideMode.
1995         (WebCore::elementMatchesAndPropertyIsNotInInlineStyleDecl): Added.
1996         (WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement): Added.
1997         (WebCore::mergeTextDecorationValues): Extracted from mergeStyle.
1998         (WebCore::EditingStyle::mergeStyle): Takes CSSPropertyOverrideMode.
1999         * editing/EditingStyle.h:
2000         * editing/ReplaceSelectionCommand.cpp:
2001         (WebCore::nodeToSplitToAvoidPastingIntoInlineNodesWithStyle): Extracted from doApply.
2002         (WebCore::ReplaceSelectionCommand::doApply): Calls nodeToSplitToAvoidPastingIntoInlineNodesWithStyle.
2003         (WebCore::ReplaceSelectionCommand::performTrivialReplace): Exit early when we need to split the tree to avoid
2004         pasting into inline nodes with style. Also remove a collapsed or spurious br.
2005         * editing/markup.cpp:
2006         (WebCore::StyledMarkupAccumulator::serializeNodes):
2007
2008 2011-10-06  Abhishek Arya  <inferno@chromium.org>
2009
2010         Crash in VisiblePosition::canonicalPosition.
2011         https://bugs.webkit.org/show_bug.cgi?id=69568
2012
2013         Reviewed by Ryosuke Niwa.
2014
2015         Move the position's containerNode calculation after layout is
2016         complete(in updateLayoutIgnorePendingStylesheets).        
2017
2018         Test: editing/selection/selection-plugin-clear-crash.html
2019
2020         * editing/VisiblePosition.cpp:
2021         (WebCore::VisiblePosition::canonicalPosition):
2022
2023 2011-10-06  Sheriff Bot  <webkit.review.bot@gmail.com>
2024
2025         Unreviewed, rolling out r96861.
2026         http://trac.webkit.org/changeset/96861
2027         https://bugs.webkit.org/show_bug.cgi?id=69573
2028
2029         This patch didn't compile on windows (Requested by annacc on
2030         #webkit).
2031
2032         * html/track/WebVTTParser.cpp:
2033         (WebCore::WebVTTParser::constructTreeFromToken):
2034
2035 2011-10-06  Anna Cavender  <annacc@chromium.org>
2036
2037         Adding parens in WebVTTParser.cpp to appease compiler preferences.
2038         https://bugs.webkit.org/show_bug.cgi?id=69460
2039
2040         Reviewed by David Levin.
2041
2042         No new tests. No new functionality.
2043
2044         * html/track/WebVTTParser.cpp:
2045         (WebCore::WebVTTParser::constructTreeFromToken):
2046
2047 2011-10-06  Fady Samuel  <fsamuel@chromium.org>
2048
2049         Code clean-up: Make RenderObject::absoluteBoundingBoxRect and associated methods const and make its parameter useTransforms no longer default to false
2050         https://bugs.webkit.org/show_bug.cgi?id=69009
2051
2052         Reviewed by Simon Fraser.
2053
2054         Upcoming patches may make use of absoluteBoundingBoxRect on a const RenderObject, so this needed to be fixed.
2055         Making useTransforms default to true instead of false and replacing instances of absoluteBoundingBoxRect() to
2056         absoluteBoundingBoxRectIgnoringTransforms() partially addreses // FIXME: useTransforms should go away eventually.
2057
2058         * WebCore.exp.in:
2059         * dom/Element.cpp:
2060         (WebCore::Element::screenRect):
2061         * dom/Node.cpp:
2062         (WebCore::Node::getRect):
2063         (WebCore::Node::renderRect):
2064         * html/shadow/SliderThumbElement.cpp:
2065         (WebCore::SliderThumbElement::setPositionFromPoint):
2066         * html/shadow/TextControlInnerElements.cpp:
2067         (WebCore::InputFieldSpeechButtonElement::startSpeechInput):
2068         * inspector/DOMNodeHighlighter.cpp:
2069         * plugins/IFrameShimSupport.cpp:
2070         (WebCore::getPluginOcclusions):
2071         * rendering/RenderBlock.cpp:
2072         (WebCore::RenderBlock::absoluteRects):
2073         (WebCore::RenderBlock::absoluteQuads):
2074         * rendering/RenderBlock.h:
2075         * rendering/RenderBox.cpp:
2076         (WebCore::RenderBox::absoluteRects):
2077         (WebCore::RenderBox::absoluteQuads):
2078         * rendering/RenderBox.h:
2079         * rendering/RenderFileUploadControl.cpp:
2080         (WebCore::RenderFileUploadControl::paintObject):
2081         * rendering/RenderIFrame.cpp:
2082         (WebCore::RenderIFrame::flattenFrame):
2083         * rendering/RenderInline.cpp:
2084         (WebCore::RenderInline::absoluteRects):
2085         (WebCore::RenderInline::culledInlineAbsoluteRects):
2086         (WebCore::RenderInline::absoluteQuads):
2087         (WebCore::RenderInline::culledInlineAbsoluteQuads):
2088         * rendering/RenderInline.h:
2089         * rendering/RenderMenuList.cpp:
2090         (WebCore::RenderMenuList::showPopup):
2091         * rendering/RenderObject.cpp:
2092         (WebCore::RenderObject::absoluteBoundingBoxRect):
2093         (WebCore::RenderObject::addAbsoluteRectForLayer):
2094         (WebCore::RenderObject::paintingRootRect):
2095         * rendering/RenderObject.h:
2096         (WebCore::RenderObject::absoluteRects):
2097         (WebCore::RenderObject::absoluteBoundingBoxRectIgnoringTransforms):
2098         (WebCore::RenderObject::absoluteQuads):
2099         * rendering/RenderText.cpp:
2100         (WebCore::RenderText::absoluteRects):
2101         (WebCore::RenderText::absoluteQuads):
2102         * rendering/RenderText.h:
2103         * rendering/RenderTextControlSingleLine.cpp:
2104         (WebCore::RenderTextControlSingleLine::showPopup):
2105         * rendering/RenderThemeSafari.cpp:
2106         (WebCore::RenderThemeSafari::paintSearchFieldCancelButton):
2107         (WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration):
2108         (WebCore::RenderThemeSafari::paintSearchFieldResultsButton):
2109         * rendering/RenderView.cpp:
2110         (WebCore::RenderView::absoluteRects):
2111         (WebCore::RenderView::absoluteQuads):
2112         * rendering/RenderView.h:
2113         * rendering/svg/RenderSVGBlock.cpp:
2114         (WebCore::RenderSVGBlock::absoluteRects):
2115         * rendering/svg/RenderSVGBlock.h:
2116         * rendering/svg/RenderSVGHiddenContainer.cpp:
2117         (WebCore::RenderSVGHiddenContainer::absoluteQuads):
2118         * rendering/svg/RenderSVGHiddenContainer.h:
2119         * rendering/svg/RenderSVGInline.cpp:
2120         (WebCore::RenderSVGInline::absoluteQuads):
2121         * rendering/svg/RenderSVGInline.h:
2122         * rendering/svg/RenderSVGModelObject.cpp:
2123         (WebCore::RenderSVGModelObject::absoluteRects):
2124         (WebCore::RenderSVGModelObject::absoluteQuads):
2125         * rendering/svg/RenderSVGModelObject.h:
2126         * rendering/svg/RenderSVGText.cpp:
2127         (WebCore::RenderSVGText::absoluteQuads):
2128         * rendering/svg/RenderSVGText.h:
2129         * testing/Internals.cpp:
2130         (WebCore::Internals::boundingBox):
2131
2132 2011-10-06  Simon Hausmann  <simon.hausmann@nokia.com>
2133
2134         [Qt][Wk2] Fix build with Qt 5 when QtScript is built as standalone module
2135         https://bugs.webkit.org/show_bug.cgi?id=69520
2136
2137         Reviewed by Csaba Osztrogonác.
2138
2139         * WebCore.pri: Use qt5 scope.
2140         * WebCore.pro: Use qt5 scope and pull in QtScript for the time being.
2141
2142 2011-10-06  Tony Chang  <tony@chromium.org>
2143
2144         last frame of a multipart response is not displayed
2145         https://bugs.webkit.org/show_bug.cgi?id=69449
2146
2147         Reviewed by Adam Barth.
2148
2149         Test: http/tests/multipart/load-last-non-html-frame.php
2150
2151         * loader/DocumentLoader.cpp:
2152         (WebCore::DocumentLoader::maybeFinishLoadingMultipartContent): for non-progressive load pages, commit the load so the
2153             last frame will be displayed.
2154         * loader/DocumentLoader.h:
2155         * loader/MainResourceLoader.cpp:
2156         (WebCore::MainResourceLoader::didFinishLoading):
2157
2158 2011-10-06  Gavin Peters  <gavinp@chromium.org>
2159
2160         conditionalize m_cachedScript stacks to just Chromium port
2161         https://bugs.webkit.org/show_bug.cgi?id=69537
2162
2163         New stack saving telemetry code in ScriptElement shouldn't have
2164         been put in all ports; just narrowing it to the chromium port will
2165         save other ports the memory hit of this diagnostic code.
2166
2167         Reviewed by Nate Chapin.
2168
2169         No new tests.
2170
2171         * dom/ScriptElement.cpp:
2172         (WebCore::ScriptElement::ScriptElement):
2173         (WebCore::ScriptElement::requestScript):
2174         (WebCore::ScriptElement::stopLoadRequest):
2175         (WebCore::ScriptElement::notifyFinished):
2176         * dom/ScriptElement.h:
2177
2178 2011-10-06  Arthur Hsu  <arthurhsu@chromium.org>
2179
2180         Ensure font loaded before calling Skia to drawPosText in Chrome sandbox
2181         https://bugs.webkit.org/show_bug.cgi?id=69370
2182
2183         Reviewed by James Robinson.
2184
2185         * platform/graphics/chromium/FontChromiumWin.cpp:
2186         (WebCore::Font::drawGlyphs):
2187
2188 2011-10-06  Chris Rogers  <crogers@google.com>
2189
2190         BiquadFilterNode must not reset filter state if type attribute is set to the same type
2191         https://bugs.webkit.org/show_bug.cgi?id=69485
2192
2193         Reviewed by Kenneth Russell.
2194
2195         No new tests.  This particular case is difficult to test with a layout test using OfflineAudioContext.
2196
2197         * webaudio/BiquadProcessor.cpp:
2198         (WebCore::BiquadProcessor::setType):
2199         * webaudio/BiquadProcessor.h:
2200
2201 2011-10-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
2202
2203         [EFL] Do not create cairo surfaces with the wrong size for form elements
2204         https://bugs.webkit.org/show_bug.cgi?id=69533
2205
2206         Reviewed by Ryosuke Niwa.
2207
2208         RenderThemeEfl::cacheThemePartResizeAndReset resizes the Ecore_Evas
2209         associated with an entry, but did not reset the `size` attribute of the
2210         struct -- in practice, this meant the subsequent call to
2211         themePartCacheEntrySurfaceCreate would create a cairo surface with the
2212         previous size, thus rendering an element with the wrong size.
2213
2214         No new tests, this is triggered by running running pixel tests for
2215         running, in this order, fast/forms/button-sizes.html,
2216         fast/forms/input-appearance-preventDefault.html,
2217         fast/forms/input-appearance-spinbutton-disabled-readonly.html,
2218         fast/forms/input-appearance-width.html,
2219         fast/forms/input-button-sizes.html,
2220         fast/forms/input-placeholder-text-indent.html and
2221         fast/forms/input-text-click-inside.html (!).
2222
2223         * platform/efl/RenderThemeEfl.cpp:
2224         (WebCore::RenderThemeEfl::cacheThemePartResizeAndReset): Reset the
2225         size attribute when resizing the canvas.
2226
2227 2011-10-06  Chris Rogers  <crogers@google.com>
2228
2229         Make sure OfflineAudioContext can not be created with a sample-rate less than 44.1KHz
2230         https://bugs.webkit.org/show_bug.cgi?id=69483
2231
2232         Reviewed by Kenneth Russell.
2233
2234         No new tests.
2235
2236         * webaudio/AudioBuffer.cpp:
2237         (WebCore::AudioBuffer::create):
2238         * webaudio/AudioContext.cpp:
2239         (WebCore::AudioContext::createBuffer):
2240
2241 2011-10-06  David Hyatt  <hyatt@apple.com>
2242
2243         https://bugs.webkit.org/show_bug.cgi?id=69544
2244         
2245         [CSS3 Regions] Compute the starting and ending regions of a block, so that we can clamp
2246         descendants to those regions. This is preparation for having true overflow in the boxes
2247         in each region, and it's also a performance optimization to reduce the amount of
2248         region walking that the RenderFlowThread is doing.
2249
2250         Add a range map to RenderFlowThread to cache the start/end regions for each box.
2251         
2252         Amend everyone who calls renderRegionForLine to pass in the box that is making the query.
2253         This box is then used to clamp to start and end regions so that any regions outside of that
2254         range will never be examined.
2255
2256         Reviewed by Dan Bernstein.
2257
2258         Test: fast/regions/top-overflow-out-of-second-region.html
2259
2260         * rendering/RenderBlock.cpp:
2261         (WebCore::RenderBlock::layoutBlock):
2262         (WebCore::RenderBlock::hasNextPage):
2263         (WebCore::RenderBlock::pageLogicalHeightForOffset):
2264         (WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
2265         (WebCore::RenderBlock::regionAtBlockOffset):
2266         * rendering/RenderFlowThread.cpp:
2267         (WebCore::RenderFlowThread::~RenderFlowThread):
2268         (WebCore::RenderFlowThread::layout):
2269         (WebCore::RenderFlowThread::renderRegionForLine):
2270         (WebCore::RenderFlowThread::regionLogicalWidthForLine):
2271         (WebCore::RenderFlowThread::regionLogicalHeightForLine):
2272         (WebCore::RenderFlowThread::regionRemainingLogicalHeightForLine):
2273         (WebCore::RenderFlowThread::mapFromFlowToRegion):
2274         (WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
2275         (WebCore::RenderFlowThread::logicalWidthChangedInRegions):
2276         (WebCore::RenderFlowThread::setRegionRangeForBox):
2277         (WebCore::RenderFlowThread::getRegionRangeForBox):
2278         * rendering/RenderFlowThread.h:
2279         * rendering/RenderRegion.cpp:
2280         (WebCore::RenderRegion::takeRenderBoxRegionInfo):
2281         (WebCore::RenderRegion::removeRenderBoxRegionInfo):
2282         * rendering/RenderRegion.h:
2283
2284 2011-10-05  Gavin Barraclough  <barraclough@apple.com>
2285
2286         Add explicit JSGlobalThis type.
2287         https://bugs.webkit.org/show_bug.cgi?id=69478
2288
2289         Reviewed by Darin Adler.
2290
2291         JSC supports a split global object, as used by WebCore for the Window. As a stage
2292         of making this visible to JSC, make it so that if the global this value is not the
2293         global object itself, it must be a subclass of JSGlobalThis.
2294
2295         * ForwardingHeaders/runtime/JSGlobalThis.h: Added.
2296             - Added forwarding header.
2297         * bindings/js/JSDOMGlobalObject.cpp:
2298         (WebCore::JSDOMGlobalObject::finishCreation):
2299         * bindings/js/JSDOMGlobalObject.h:
2300             - finishCreation takes a JSGlobalThis, or thisValue is implicit.
2301         * bindings/js/JSDOMWindowShell.h:
2302             - Make the window shell a subclass of JSGlobalThis.
2303         * bindings/js/JSWorkerContextBase.cpp:
2304         (WebCore::JSWorkerContextBase::finishCreation):
2305             - Don't pass the thisValue to JSGlobalObject::finishCreation.
2306         * bindings/js/JSWorkerContextBase.h:
2307         * bindings/scripts/CodeGeneratorJS.pm:
2308         (GenerateHeader):
2309             - Don't pass the thisValue to JSGlobalObject::finishCreation,
2310               for worker contexts.
2311
2312 2011-10-06  Anna Cavender  <annacc@chromium.org>
2313
2314         Fix CodeGeneratorV8 for EnabledAtRuntime when class has no parent class.
2315         https://bugs.webkit.org/show_bug.cgi?id=69480
2316
2317         Reviewed by Adam Barth.
2318
2319         No new tests. No new functionality, yet.
2320
2321         * bindings/scripts/CodeGeneratorV8.pm:
2322
2323 2011-10-06  Dan Bernstein  <mitz@apple.com>
2324
2325         <rdar://problem/10232866> Assertion failure beneath blockSelectionGaps() when a selected node is removed
2326
2327         Reviewed by Ryosuke Niwa.
2328
2329         Test: editing/selection/invalid-in-RenderView.html
2330
2331         * editing/FrameSelection.cpp:
2332         (WebCore::FrameSelection::updateAppearance): Ensure that the VisibleSelection used to set the selection
2333         in the RenderView is valid, by reconstructing it from the current selection.
2334
2335 2011-10-06  Andreas Kling  <kling@webkit.org>
2336
2337         InlineBox's virtualLogicalHeight() partially limited to builds with SVG.
2338         https://bugs.webkit.org/show_bug.cgi?id=69538
2339
2340         Reviewed by Dan Bernstein.
2341
2342         Remove erroneous ENABLE(SVG) guards around the initialization and use
2343         of InlineBox::hasVirtualLogicalHeight.
2344
2345         This variable is used by TrailingFloatsRootInlineBox and should always
2346         be respected regardless of SVG support.
2347
2348         * rendering/InlineBox.cpp:
2349         (WebCore::InlineBox::logicalHeight):
2350         * rendering/InlineBox.h:
2351         (WebCore::InlineBox::InlineBox):
2352
2353 2011-10-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2354
2355         [GTK] Implement cache model for WebKit2
2356         https://bugs.webkit.org/show_bug.cgi?id=68434
2357
2358         Reviewed by Martin Robinson.
2359
2360         Add a function to FileSystem to get the free space of the file
2361         system where the given path is on.
2362
2363         * platform/FileSystem.h:
2364         * platform/gtk/FileSystemGtk.cpp:
2365         (WebCore::getVolumeFreeSizeForPath):
2366
2367 2011-10-06  Sergey Glazunov  <serg.glazunov@gmail.com>
2368
2369         Add check for JavaScript URLs in HTMLPlugInImageElement::allowedToLoadFrameURL
2370         https://bugs.webkit.org/show_bug.cgi?id=68813
2371
2372         Reviewed by Adam Barth.
2373
2374         Test: http/tests/security/xss-DENIED-object-element.html
2375
2376         * html/HTMLPlugInImageElement.cpp:
2377         (WebCore::HTMLPlugInImageElement::allowedToLoadFrameURL):
2378
2379 2011-10-06  Yury Semikhatsky  <yurys@chromium.org>
2380
2381         Web Inspector: avoid assertion failure in ~InspectorDebuggerAgent in case of workers
2382         https://bugs.webkit.org/show_bug.cgi?id=69534
2383
2384         Make sure frontend is disconnected before WorkerInspectorController is destroyed.
2385
2386         Reviewed by Pavel Feldman.
2387
2388         * inspector/WorkerInspectorController.cpp:
2389         (WebCore::WorkerInspectorController::~WorkerInspectorController):
2390
2391 2011-10-05  Alexey Proskuryakov  <ap@apple.com>
2392
2393         https://bugs.webkit.org/show_bug.cgi?id=69492
2394         [Mac] Should be able to scroll embedded PDFs from keyboard
2395
2396         Reviewed by Darin Adler.
2397
2398         * WebCore.exp.in: Export ScrollableArea::scroll.
2399
2400         * html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::defaultEventHandler): Call base
2401         class default event handler, so that events on focused plug-in elements would fall through
2402         to EventHandler::defaultKeyboardEventHandler.
2403
2404         * plugins/PluginViewBase.h: (WebCore::PluginViewBase::scroll): Added a method that's called
2405         on a plug-in when WebCore asks it to scroll. Plug-in cannot really know what key events
2406         result in scroll actions.
2407
2408         * rendering/RenderEmbeddedObject.cpp:
2409         (WebCore::RenderEmbeddedObject::scroll):
2410         (WebCore::RenderEmbeddedObject::logicalScroll):
2411         * rendering/RenderEmbeddedObject.h:
2412         Ask plug-in to scroll when EventHandler::scrollOverflow() is called.
2413
2414 2011-10-06  Konstantin Scheglov  <scheglov@google.com>
2415
2416         REGRESSION (r95852?): Disappearing Border on bugs.webkit.org attachments <table>
2417         https://bugs.webkit.org/show_bug.cgi?id=69296
2418
2419         Reviewed by David Hyatt.
2420
2421         Test: fast/table/border-collapsing/cached-69296.html
2422
2423         Remember BorderValue in CollapsedBorderValue by value.
2424         See https://bugs.webkit.org/show_bug.cgi?id=69296#c7 for motivation.
2425
2426         * rendering/style/CollapsedBorderValue.h:
2427         (WebCore::CollapsedBorderValue::CollapsedBorderValue):
2428         (WebCore::CollapsedBorderValue::width):
2429         (WebCore::CollapsedBorderValue::style):
2430         (WebCore::CollapsedBorderValue::exists):
2431         (WebCore::CollapsedBorderValue::isTransparent):
2432         (WebCore::CollapsedBorderValue::operator==):
2433         * rendering/RenderTableCell.cpp:
2434         (WebCore::RenderTableCell::collapsedStartBorder):
2435         (WebCore::RenderTableCell::collapsedEndBorder):
2436         (WebCore::RenderTableCell::collapsedBeforeBorder):
2437         (WebCore::RenderTableCell::collapsedAfterBorder):
2438
2439 2011-10-06  Gavin Peters  <gavinp@chromium.org>
2440
2441         save resource zeroing stacks in ScriptElement for debugging
2442         https://bugs.webkit.org/show_bug.cgi?id=69453
2443
2444         The state machine tracking how m_cachedScript gets zeroed shows that sometimes we get
2445         two notifyFinished() events in a ScriptElement, which can crash chrome (see chrome bug
2446         75604).  This patch will save a stack in the ScriptElement when this happens, so that if
2447         we do later crash, we can see how we did the first zeroing.
2448
2449         See http://code.google.com/p/chromium/issues/detail?id=75604 for the chromium bug that
2450         this change will help track down.
2451
2452         Reviewed by Nate Chapin.
2453
2454         No new tests, this shouldn't affect output at all, and isn't particularly testable.
2455
2456         * dom/ScriptElement.cpp:
2457         (WebCore::ScriptElement::ScriptElement):
2458         (WebCore::ScriptElement::stopLoadRequest):
2459         (WebCore::ScriptElement::notifyFinished):
2460         * dom/ScriptElement.h:
2461
2462 2011-10-06  Rémi Duraffort  <remi.duraffort@st.com>
2463
2464         Fix compilation by adding some missing ENABLE(VIDEO|XSLT)
2465         https://bugs.webkit.org/show_bug.cgi?id=69522
2466
2467         Unreviewed build fix
2468
2469         * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
2470         * bindings/v8/custom/V8HTMLAudioElementConstructor.h:
2471         * bindings/v8/custom/V8XSLTProcessorCustom.cpp:
2472
2473 2011-10-06  Pavel Feldman  <pfeldman@google.com>
2474
2475         Web Inspector: add Styles and Metrics sidebars to the compilation.
2476         https://bugs.webkit.org/show_bug.cgi?id=69529
2477
2478         Reviewed by Yury Semikhatsky.
2479
2480         * inspector/compile-front-end.sh:
2481         * inspector/front-end/CSSCompletions.js:
2482         (WebInspector.CSSCompletions.requestCSSNameCompletions):
2483         * inspector/front-end/CSSKeywordCompletions.js:
2484         (WebInspector.CSSKeywordCompletions.forProperty):
2485         (WebInspector.CSSKeywordCompletions.isColorAwareProperty):
2486         * inspector/front-end/Checkbox.js:
2487         * inspector/front-end/ElementsPanel.js:
2488         * inspector/front-end/MetricsSidebarPane.js:
2489         (WebInspector.MetricsSidebarPane.prototype._updateMetrics):
2490         (WebInspector.MetricsSidebarPane.prototype.startEditing):
2491         (WebInspector.MetricsSidebarPane.prototype._handleKeyDown):
2492         * inspector/front-end/SourceCSSTokenizer.js:
2493         (WebInspector.SourceCSSTokenizer):
2494         * inspector/front-end/SourceCSSTokenizer.re2js:
2495         * inspector/front-end/StylesSidebarPane.js:
2496         (WebInspector.StylesSidebarPane.prototype.update):
2497         (WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
2498         (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
2499         (WebInspector.StylePropertiesSection.prototype.onpopulate):
2500         (WebInspector.StylePropertiesSection.prototype.startEditingSelector):
2501         (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
2502         (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
2503         (WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):
2504         (WebInspector.BlankStylePropertiesSection.prototype.makeNormal):
2505         (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
2506         (WebInspector.StylePropertyTreeElement.prototype):
2507         * inspector/front-end/externs.js:
2508         (WebInspector.linkifyResourceAsNode):
2509         (Element.prototype.scrollIntoViewIfNeeded):
2510         (Element.prototype.selectionLeftOffset):
2511         * inspector/front-end/inspector.js:
2512         * inspector/front-end/utilities.js:
2513
2514 2011-10-06  Pavel Feldman  <pfeldman@google.com>
2515
2516         Web Inspector: extract DOMPresentation, make EventListenersSidebar compile
2517         https://bugs.webkit.org/show_bug.cgi?id=69527
2518
2519         Reviewed by Yury Semikhatsky.
2520
2521         * WebCore.gypi:
2522         * WebCore.vcproj/WebCore.vcproj:
2523         * inspector/compile-front-end.sh:
2524         * inspector/front-end/DOMAgent.js:
2525         (WebInspector.DOMNode.prototype.nodeNameInCorrectCase):
2526         (WebInspector.DOMNode.prototype.moveTo):
2527         (WebInspector.DOMNode.prototype.isXMLNode):
2528         * inspector/front-end/DOMBreakpointsSidebarPane.js:
2529         (WebInspector.DOMBreakpointsSidebarPane.prototype._setBreakpoint):
2530         * inspector/front-end/DOMPresentation.js: Added.
2531         (WebInspector.DOMPresentation.decorateNodeLabel):
2532         (WebInspector.DOMPresentation.linkifyNodeReference):
2533         (WebInspector.DOMPresentation.linkifyNodeById):
2534         * inspector/front-end/ElementsPanel.js:
2535         (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
2536         * inspector/front-end/ElementsTreeOutline.js:
2537         (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode):
2538         * inspector/front-end/EventListenersSidebarPane.js:
2539         * inspector/front-end/ObjectPropertiesSection.js:
2540         * inspector/front-end/PropertiesSection.js:
2541         * inspector/front-end/Section.js:
2542         * inspector/front-end/StylesSidebarPane.js:
2543         (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
2544         (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
2545         * inspector/front-end/WebKit.qrc:
2546         * inspector/front-end/inspector.html:
2547
2548 2011-10-06  Pavel Feldman  <pfeldman@google.com>
2549
2550         Web Inspector: add all Resource panel views to the compilation.
2551         https://bugs.webkit.org/show_bug.cgi?id=69526
2552
2553         Reviewed by Yury Semikhatsky.
2554
2555         * inspector/compile-front-end.sh:
2556         * inspector/front-end/CookieItemsView.js:
2557         (WebInspector.CookieItemsView.prototype._contextMenu):
2558         (WebInspector.Cookies.cookieMatchesResourceURL):
2559         * inspector/front-end/CookiesTable.js:
2560         (WebInspector.CookiesTable):
2561         (WebInspector.CookiesTable.prototype._onDeleteFromGrid):
2562         * inspector/front-end/DOMStorageItemsView.js:
2563         (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
2564         * inspector/front-end/DataGrid.js:
2565         (WebInspector.DataGrid.createSortableDataGrid.sortDataGrid.comparator):
2566         (WebInspector.DataGrid.createSortableDataGrid.sortDataGrid):
2567         (WebInspector.DataGrid.createSortableDataGrid):
2568         * inspector/front-end/DatabaseQueryView.js:
2569         (WebInspector.DatabaseQueryView.prototype._queryFinished):
2570         * inspector/front-end/DatabaseTableView.js:
2571         (WebInspector.DatabaseTableView.prototype._queryFinished):
2572         * inspector/front-end/ResourcesPanel.js:
2573         (WebInspector.ResourcesPanel.prototype.reset):
2574         (WebInspector.ResourcesPanel.prototype.showDatabase):
2575         * inspector/front-end/TextPrompt.js:
2576
2577 2011-10-06  Pavel Feldman  <pfeldman@google.com>
2578
2579         Web Inspector: add all Resource panel views to the compilation.
2580         https://bugs.webkit.org/show_bug.cgi?id=69526
2581
2582         Reviewed by Yury Semikhatsky.
2583
2584         * inspector/compile-front-end.sh:
2585         * inspector/front-end/CookieItemsView.js:
2586         (WebInspector.CookieItemsView.prototype._contextMenu):
2587         (WebInspector.Cookies.cookieMatchesResourceURL):
2588         * inspector/front-end/CookiesTable.js:
2589         (WebInspector.CookiesTable):
2590         (WebInspector.CookiesTable.prototype._onDeleteFromGrid):
2591         * inspector/front-end/DOMStorageItemsView.js:
2592         (WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
2593         * inspector/front-end/DataGrid.js:
2594         (WebInspector.DataGrid.createSortableDataGrid.sortDataGrid.comparator):
2595         (WebInspector.DataGrid.createSortableDataGrid.sortDataGrid):
2596         (WebInspector.DataGrid.createSortableDataGrid):
2597         * inspector/front-end/DatabaseQueryView.js:
2598         (WebInspector.DatabaseQueryView.prototype._queryFinished):
2599         * inspector/front-end/DatabaseTableView.js:
2600         (WebInspector.DatabaseTableView.prototype._queryFinished):
2601         * inspector/front-end/ResourcesPanel.js:
2602         (WebInspector.ResourcesPanel.prototype.reset):
2603         (WebInspector.ResourcesPanel.prototype.showDatabase):
2604         * inspector/front-end/TextPrompt.js:
2605
2606 2011-10-06  Sheriff Bot  <webkit.review.bot@gmail.com>
2607
2608         Unreviewed, rolling out r96791.
2609         http://trac.webkit.org/changeset/96791
2610         https://bugs.webkit.org/show_bug.cgi?id=69528
2611
2612         webkit_unit_tests broken on Mac and Win (Requested by
2613         hwennborg on #webkit).
2614
2615         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
2616
2617 2011-10-05  Mikhail Naganov  <mnaganov@chromium.org>
2618
2619         Web Inspector: [Chromium] Heap Snapshot colors legend help popup is not shown.
2620         https://bugs.webkit.org/show_bug.cgi?id=69482
2621
2622         Reviewed by Yury Semikhatsky.
2623
2624         * inspector/front-end/DetailedHeapshotView.js:
2625         (WebInspector.DetailedHeapshotView.prototype._helpClicked):
2626
2627 2011-10-05  Pavel Feldman  <pfeldman@google.com>
2628
2629         Web Inspector: add 10 more front-end classes to the compilation process.
2630         https://bugs.webkit.org/show_bug.cgi?id=69445
2631
2632         Reviewed by Yury Semikhatsky.
2633
2634         * inspector/compile-front-end.sh:
2635         * inspector/front-end/HAREntry.js:
2636         * inspector/front-end/HandlerRegistry.js:
2637         * inspector/front-end/IFrameView.js:
2638         * inspector/front-end/JavaScriptSourceFrame.js:
2639         * inspector/front-end/PanelEnablerView.js:
2640         (WebInspector.PanelEnablerView):
2641         * inspector/front-end/PartialQuickSort.js:
2642         * inspector/front-end/PropertiesSidebarPane.js:
2643         (WebInspector.PropertiesSidebarPane.prototype.update.fillSection):
2644         (WebInspector.PropertiesSidebarPane.prototype.update):
2645         * inspector/front-end/ShowMoreDataGridNode.js:
2646         * inspector/front-end/SidebarTreeElement.js:
2647         * inspector/front-end/TimelineAgent.js:
2648         * inspector/front-end/WelcomeView.js:
2649         * inspector/front-end/externs.js:
2650         (WebInspector.addMainEventListeners):
2651
2652 2011-10-05  Pavel Feldman  <pfeldman@google.com>
2653
2654         Web Inspector: make ElementsTreeOutline compile
2655         https://bugs.webkit.org/show_bug.cgi?id=69439
2656
2657         Reviewed by Yury Semikhatsky.
2658
2659         * inspector/compile-front-end.sh:
2660         * inspector/front-end/DOMAgent.js:
2661         * inspector/front-end/DOMSyntaxHighlighter.js:
2662         * inspector/front-end/ElementsPanel.js:
2663         (WebInspector.ElementsPanel.get this):
2664         (WebInspector.ElementsPanel):
2665         (WebInspector.ElementsPanel.prototype._populateContextMenu):
2666         (WebInspector.ElementsPanel.prototype._inspectElementRequested):
2667         * inspector/front-end/ElementsTreeOutline.js:
2668         (WebInspector.ElementsTreeOutline):
2669         (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement):
2670         (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
2671         (WebInspector.ElementsTreeOutline.prototype._updateModifiedNodes):
2672         (WebInspector.ElementsTreeOutline.prototype._populateContextMenu):
2673         (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
2674         (WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
2675         (WebInspector.ElementsTreeElement.prototype._startEditingTextNode):
2676         (WebInspector.ElementsTreeElement.prototype._startEditingTagName):
2677         (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
2678         (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.changeTagNameCallback):
2679         (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
2680         ():
2681         * inspector/front-end/externs.js:
2682         (WebInspector.highlightDOMNode):
2683         (WebInspector.resourceURLForRelatedNode):
2684
2685 2011-10-06  Pavel Feldman  <pfeldman@google.com>
2686
2687         Web Inspector: Inspector fails to start if there was at least one watch expression.
2688         https://bugs.webkit.org/show_bug.cgi?id=69516
2689
2690         Reviewed by Yury Semikhatsky.
2691
2692         * inspector/front-end/ConsoleView.js:
2693         * inspector/front-end/WatchExpressionsSidebarPane.js:
2694         (WebInspector.WatchExpressionsSidebarPane):
2695
2696 2011-10-06  Dominic Cooney   <dominicc@chromium.org>
2697
2698         Don't make virtual calls in Node::parentNode.
2699         https://bugs.webkit.org/show_bug.cgi?id=69266
2700
2701         Reviewed by Antti Koivisto.
2702
2703         ShadowRoot and SVGShadowRoot remain semantically separate (eg
2704         isShadowRoot/isSVGShadowRoot) but share a flag
2705         (IsShadowRootOrSVGShadowRootFlag, hitherto IsShadowRootFlag just
2706         for ShadowRoot). In combination with IsSVGFlag ShadowRoot (false)
2707         can be distinguished from SVGShadowRoot (true). This lets us make
2708         isSVGShadowRoot non-virtual.
2709
2710         No change in behavior => No new tests.
2711
2712         * dom/Node.cpp:
2713         (WebCore::Node::shadowHost):
2714         * dom/Node.h:
2715         (WebCore::Node::isSVGShadowRoot):
2716         (WebCore::Node::isShadowRoot):
2717         (WebCore::Node::parentNode):
2718         (WebCore::Node::parentNodeGuaranteedHostFree):
2719         * rendering/svg/SVGShadowTreeElements.cpp:
2720         (WebCore::SVGShadowTreeContainerElement::SVGShadowTreeContainerElement):
2721         (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement):
2722         * rendering/svg/SVGShadowTreeElements.h:
2723         * svg/SVGElement.cpp:
2724         (WebCore::SVGElement::SVGElement):
2725         * svg/SVGElement.h:
2726         * svg/SVGGElement.cpp:
2727         (WebCore::SVGGElement::SVGGElement):
2728         * svg/SVGGElement.h:
2729         * svg/SVGStyledElement.cpp:
2730         (WebCore::SVGStyledElement::SVGStyledElement):
2731         * svg/SVGStyledElement.h:
2732         * svg/SVGStyledLocatableElement.cpp:
2733         (WebCore::SVGStyledLocatableElement::SVGStyledLocatableElement):
2734         * svg/SVGStyledLocatableElement.h:
2735         * svg/SVGStyledTransformableElement.cpp:
2736         (WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement):
2737         * svg/SVGStyledTransformableElement.h:
2738
2739 2011-10-06  John Knottenbelt  <jknotten@chromium.org>
2740
2741         Take pageScaleFactor into account for MouseRelatedEvents.
2742         https://bugs.webkit.org/show_bug.cgi?id=67592
2743
2744         Reviewed by Tony Gentilcore.
2745
2746         Tests: fast/events/page-scaled-mouse-click-iframe.html
2747                fast/events/page-scaled-mouse-click.html
2748
2749         * dom/MouseRelatedEvent.cpp:
2750         (WebCore::contentsScrollOffset):
2751         (WebCore::MouseRelatedEvent::MouseRelatedEvent):
2752         (WebCore::frameScaleFactor):
2753         (WebCore::MouseRelatedEvent::computePageLocation):
2754         (WebCore::MouseRelatedEvent::computeRelativePosition):
2755
2756 2011-10-03  Hans Wennborg  <hans@chromium.org>
2757
2758         IndexedDB: Remove SQLite-LevelDB migration code
2759         https://bugs.webkit.org/show_bug.cgi?id=69264
2760
2761         Reviewed by Tony Chang.
2762
2763         Remove migration functionality.
2764
2765         Just removing code, so no new tests.
2766
2767         * storage/IDBFactoryBackendImpl.cpp:
2768         (WebCore::IDBFactoryBackendImpl::open):
2769         * storage/IDBFactoryBackendImpl.h:
2770
2771 2011-10-06  James Robinson  <jamesr@chromium.org>
2772
2773         [chromium] Remove USE(THREADED_COMPOSITING) from the tree
2774         https://bugs.webkit.org/show_bug.cgi?id=69489
2775
2776         Reviewed by Darin Fisher.
2777
2778         This macro isn't needed any more since the logic it guarded is guarded by a runtime switch.
2779
2780         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
2781
2782 2011-10-05  Kentaro Hara  <haraken@chromium.org>
2783
2784         Refactor IDL attributes about constructor
2785         https://bugs.webkit.org/show_bug.cgi?id=69074
2786
2787         Reviewed by Adam Barth.
2788
2789         Currently, IDL attributes about constructor are confusing:
2790
2791         - [CustomConstructFunction] means that there is a custom constructor for JSC.
2792         - [V8CustomConstructor] means that there is a custom constructor for V8.
2793         - [CustomConstructor] exists in CodeGenerator*.pm but is not used in any IDL files.
2794         - For almost all IDL files, [CustomConstructFunction] and [V8CustomConstructor] are used at the same time.
2795         - ObjC, CPP and GObject bindings do not support custom constructors.
2796
2797         This patch makes the following changes:
2798
2799         - Rename [CustomConstructFunction] to [JSCustomConstructor].
2800         - [JSCustomConstructor] means that there is a custom constructor for JSC.
2801         - [V8CustomConstructor] means that there is a custom constructor for V8.
2802         - [CustomConstructor] means that there is a custom constructor for both JSC and V8.
2803
2804         No new tests. No change in behavior. Confirm that build succeeds.
2805
2806         * bindings/scripts/CodeGeneratorJS.pm: Removed [CustomConstructFunction] and added [JSCustomConstructor]
2807         (GenerateHeader):
2808         (GenerateAttributesHashTable):
2809         (GenerateImplementation):
2810         (GenerateConstructorDefinition):
2811         * css/WebKitCSSMatrix.idl: Renamed [CustomConstructFunction] to [JSCustomConstructor]. If both [JSCustomConstructor] and [V8CustomConstructor] are specified, then we replaced them with [CustomConstructor].
2812         * dom/CustomEvent.idl: Ditto.
2813         * dom/ErrorEvent.idl: Ditto.
2814         * dom/Event.idl: Ditto.
2815         * dom/HashChangeEvent.idl: Ditto.
2816         * dom/MessageChannel.idl: Ditto.
2817         * dom/MessageEvent.idl: Ditto.
2818         * dom/PageTransitionEvent.idl: Ditto.
2819         * dom/PopStateEvent.idl: Ditto.
2820         * dom/ProgressEvent.idl: Ditto.
2821         * dom/WebKitAnimationEvent.idl: Ditto.
2822         * html/DOMFormData.idl: Ditto.
2823         * html/canvas/ArrayBuffer.idl: Ditto.
2824         * html/canvas/DataView.idl: Ditto.
2825         * html/canvas/Float32Array.idl: Ditto.
2826         * html/canvas/Float64Array.idl: Ditto.
2827         * html/canvas/Int16Array.idl: Ditto.
2828         * html/canvas/Int32Array.idl: Ditto.
2829         * html/canvas/Int8Array.idl: Ditto.
2830         * html/canvas/Uint16Array.idl: Ditto.
2831         * html/canvas/Uint32Array.idl: Ditto.
2832         * html/canvas/Uint8Array.idl: Ditto.
2833         * p2p/PeerConnection.idl: Ditto.
2834         * page/EventSource.idl: Ditto.
2835         * page/WebKitPoint.idl: Ditto.
2836         * webaudio/AudioContext.idl: Ditto.
2837         * websockets/CloseEvent.idl: Ditto.
2838         * websockets/WebSocket.idl: Ditto.
2839         * workers/SharedWorker.idl: Ditto.
2840         * workers/Worker.idl: Ditto.
2841         * xml/XMLHttpRequest.idl: Ditto.
2842         * xml/XSLTProcessor.idl: Ditto.
2843
2844 2011-10-03  Andy Estes  <aestes@apple.com>
2845
2846         Add the option to suppress rendering until the document's load event fires.
2847         https://bugs.webkit.org/show_bug.cgi?id=69298
2848
2849         Reviewed by Simon Fraser.
2850
2851         Add a WebCore setting that suppresses painting and compositing layer
2852         updates until the document's load event fires. This masks the effects
2853         of incremental rendering (for clients that opt in) by ensuring that all
2854         sub-resources have loaded and a full layout has taken place before
2855         painting the document for the first time.
2856
2857         No tests currently possible. Testing this would require the ability for
2858         DRT to dump state while resources are loading, which it doesn't
2859         currently do.
2860
2861         * dom/Document.cpp:
2862         (WebCore::Document::implicitClose): If rendering was previously
2863         suppressed, force a repaint and compositing layer update.
2864         (WebCore::Document::visualUpdatesAllowed): Add a helper method to
2865         determine if the document is in a state where rendering is allowed.
2866         * dom/Document.h:
2867         * page/Settings.cpp:
2868         (WebCore::Settings::Settings):
2869         * page/Settings.h:
2870         (WebCore::Settings::setSuppressIncrementalRendering):
2871         (WebCore::Settings::suppressIncrementalRendering):
2872         * rendering/RenderLayer.cpp:
2873         (WebCore::shouldSuppressPaintingLayer): Encapsulate the FOUC and
2874         painting suppression checks into a single helper function for
2875         readability's sake.
2876         (WebCore::RenderLayer::paintLayer):
2877         * rendering/RenderLayerCompositor.cpp:
2878         (WebCore::RenderLayerCompositor::updateCompositingLayers): If we should
2879         suppress compositing layer updates and the load event has yet to fire,
2880         return early.
2881
2882 2011-10-05  Yuta Kitamura  <yutak@chromium.org>
2883
2884         WebSocket: Add extensions attribute
2885         https://bugs.webkit.org/show_bug.cgi?id=69408
2886
2887         Reviewed by Kent Tamura.
2888
2889         Add WebSocket's "extensions" attribute as specified in the WebSocket API
2890         <http://dev.w3.org/html5/websockets/#the-websocket-interface>.
2891
2892         WebSocket protocol extension is not implemented at all, thus this attribute
2893         always returns an empty string.
2894
2895         Test: http/tests/websocket/tests/hybi/extensions.html
2896               http/tests/websocket/tests/hixie76/undefined-attributes.html (updated)
2897
2898         * websockets/WebSocket.cpp:
2899         (WebCore::WebSocket::extensions):
2900         If the hixie-76 protocol is chosen, we need to return "undefined" in order to
2901         keep behavior of the ports which have not used the newer hybi protocol yet.
2902         * websockets/WebSocket.h:
2903         * websockets/WebSocket.idl:
2904
2905 2011-10-05  Dominic Cooney  <dominicc@chromium.org>
2906
2907         IsShadowRootFlag should not depend on whether a ShadowRoot is attached to a host.
2908         https://bugs.webkit.org/show_bug.cgi?id=69406
2909
2910         Reviewed by Hajime Morita.
2911
2912         No change in behavior => No new tests.
2913
2914         * dom/Node.cpp:
2915         (WebCore::Node::setShadowHost): Don't twiddle the flag.
2916         * dom/Node.h:
2917         * dom/ShadowRoot.cpp:
2918         (WebCore::ShadowRoot::ShadowRoot): Set the IsShadowRootFlag on creation.
2919         * dom/TreeScope.cpp:
2920         (WebCore::TreeScope::TreeScope): Let ShadowRoot set creation flags.
2921         * dom/TreeScope.h:
2922
2923 2011-10-05  Chris Rogers  <crogers@google.com>
2924
2925         Define a log2f() function for Windows in wtf/MathExtras.h
2926         https://bugs.webkit.org/show_bug.cgi?id=69491
2927
2928         Reviewed by Darin Adler.
2929
2930         No new tests. This change is tested in existing layout tests.
2931
2932         * webaudio/AudioParamTimeline.cpp:
2933         (WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
2934
2935 2011-10-05  Erik Arvidsson  <arv@chromium.org>
2936
2937         window.location.href and others needlessly decodes URI-encoded characters
2938         https://bugs.webkit.org/show_bug.cgi?id=30225
2939
2940         Reviewed by Darin Adler.
2941
2942         Don't decode KURL::path() and stop using KURL::deprecatedString() in Location methods.
2943
2944         This slightly changes how we parse data and javascript URLs (non hierarchical URLs) to
2945         not encode so aggressively.
2946
2947         * fileapi/DOMFileSystemBase.cpp:
2948         (WebCore::DOMFileSystemBase::crackFileSystemURL): Manually decode path()
2949         * loader/FrameLoader.cpp:
2950         (WebCore::FrameLoader::defaultObjectContentType): Manually decode path()
2951         * page/Location.cpp:
2952         (WebCore::Location::href): Use string() instead of deprecatedString()
2953         * page/Location.h:
2954         (WebCore::Location::toString): Inline call to href()
2955         * platform/KURL.cpp:
2956         (WebCore::KURL::path): Don't decode.
2957         (WebCore::escapeAndAppendNonHierarchicalPart): Rename escapeAndAppendFragment to escapeAndAppendNonHierarchicalPart
2958                                                        since this is now used for more than just fragments.
2959         (WebCore::KURL::parse): Don't decode
2960         * platform/KURLGoogle.cpp:
2961         (WebCore::KURL::path): Remove out of date comment
2962         * platform/qt/KURLQt.cpp:
2963         (WebCore::KURL::fileSystemPath): Manually decode path()
2964         * platform/win/ClipboardWin.cpp:
2965         (WebCore::createGlobalHDropContent): Manually decode path()
2966         * workers/WorkerLocation.cpp:
2967         (WebCore::WorkerLocation::href): Use string() instead of deprecatedString()
2968         * workers/WorkerLocation.h:
2969         (WebCore::WorkerLocation::toString): Inline call to href()
2970
2971 2011-10-05  Darin Adler  <darin@apple.com>
2972
2973         [Mac] Use four more named cursors if present
2974         https://bugs.webkit.org/show_bug.cgi?id=69488
2975
2976         Reviewed by Dan Bernstein.
2977
2978         * platform/mac/CursorMac.mm:
2979         (WebCore::Cursor::ensurePlatformCursor): Use the names "Help", "Cell",
2980         "ZoomIn", and "ZoomOut" to get those cursors. Structure the code so it
2981         falls back if the cursors are not present.
2982
2983 2011-10-05  Tony Chang  <tony@chromium.org>
2984
2985         force margin:auto to 0 in flex items
2986         https://bugs.webkit.org/show_bug.cgi?id=69475
2987
2988         Reviewed by Ojan Vafai.
2989
2990         The spec used to say the margin had a value of flex(1 0 0), but changed to just be 0.
2991
2992         * rendering/RenderFlexibleBox.cpp:
2993         (WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
2994         (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
2995
2996 2011-10-05  Dean Jackson  <dino@apple.com>
2997
2998         Computed style for filter property
2999         https://bugs.webkit.org/show_bug.cgi?id=68477
3000
3001         Reviewed by Simon Fraser.
3002
3003         Reports the computed style for the new -webkit-filter
3004         property value.
3005
3006         Test: css3/filters/filter-property-computed-style.html
3007
3008         * css/CSSComputedStyleDeclaration.cpp:
3009         (WebCore::computedFilter):
3010         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3011
3012 2011-10-05  Jer Noble  <jer.noble@apple.com>
3013
3014         Enable WEB_AUDIO by default in the WebKit/mac port.
3015         https://bugs.webkit.org/show_bug.cgi?id=68587
3016
3017         Reviewed by Simon Fraser.
3018
3019         No new tests; existing webaudio/ layout tests cover this.
3020
3021         * Configurations/FeatureDefines.xcconfig:
3022         * WebCore.xcodeproj/project.pbxproj: Add a build step which copies audio resources to
3023             the WebCore.framework bundle.
3024
3025 2011-10-03  Ojan Vafai  <ojan@chromium.org>
3026
3027         [flexbox] take marginBeforeForChild into account when positioning children
3028         https://bugs.webkit.org/show_bug.cgi?id=69313
3029
3030         Reviewed by Tony Chang.
3031
3032         * rendering/RenderFlexibleBox.cpp:
3033         (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
3034
3035 2011-10-05  Vangelis Kokkevis  <vangelis@chromium.org>
3036
3037         Switching threaded compositor from a compile time option to a
3038         run time one.
3039         https://bugs.webkit.org/show_bug.cgi?id=69391
3040
3041         Reviewed by Darin Fisher.
3042
3043         Mostly converted #if USE(THREADED_COMPOSITING) to a regular if statements.
3044         In addition, CCLayerTreeHost::scheduleComposite() is removed as it wasn't being
3045         called from anywhere, 
3046
3047         No new tests as it doesn't add new functionality.
3048
3049         * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
3050         (WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
3051         (WebCore::CCLayerTreeHost::setNeedsRedraw):
3052         (WebCore::CCLayerTreeHost::composite):
3053         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
3054         * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
3055         (WebCore::CCSingleThreadProxy::setNeedsCommitThenRedraw):
3056         (WebCore::CCSingleThreadProxy::compositeImmediately):
3057         * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
3058
3059 2011-10-05  Dean Jackson  <dino@apple.com>
3060
3061         Parse '-webkit-filter' property syntax
3062         https://bugs.webkit.org/show_bug.cgi?id=68473
3063
3064         Reviewed by Nikolas Zimmermann.
3065
3066         Parse the new -webkit-filter property, looking for shorthand
3067         functions then testing number, type and value of parameters.
3068
3069         Note that support for drop-shadow() was omitted from this
3070         patch because parsing CSS shadow syntax was going to require some
3071         refactoring of the box and text shadow code. The followup
3072         bug is https://bugs.webkit.org/show_bug.cgi?id=69108.
3073
3074         Also, computed style will return null for filters at the moment.
3075         That's https://bugs.webkit.org/show_bug.cgi?id=68477.
3076
3077         Tests: css3/filters/filter-property-parsing-invalid.html
3078                css3/filters/filter-property-parsing.html
3079
3080         * CMakeLists.txt:
3081         * CodeGenerators.pri:
3082         * DerivedSources.cpp:
3083         * DerivedSources.make:
3084         * GNUmakefile.list.am:
3085         * WebCore.gypi:
3086         * WebCore.pro:
3087         * WebCore.vcproj/WebCore.vcproj:
3088         * WebCore.xcodeproj/project.pbxproj:
3089             Build files updated for new WebKitCSSFilterValue classes.
3090         * bindings/js/JSCSSValueCustom.cpp:
3091         (WebCore::toJS):
3092         * bindings/objc/DOMCSS.mm:
3093             Test if value is WebKitCSSFilterValue.
3094         * css/CSSParser.cpp:
3095         (WebCore::filterInfoForName):
3096         (WebCore::CSSParser::isValidFilterArgument):
3097         (WebCore::CSSParser::parseFilter):
3098         * css/CSSParser.h:
3099         * css/CSSStyleSelector.cpp:
3100         (WebCore::CSSStyleSelector::applyProperty):
3101         (WebCore::filterOperationForType):
3102         (WebCore::CSSStyleSelector::createFilterOperations):
3103         * css/CSSStyleSelector.h:
3104             Handle the new shorthand functions in -webkit-filter.
3105         * css/CSSValue.h:
3106         (WebCore::CSSValue::isWebKitCSSFilterValue):
3107             Add virtual function that returns false here.
3108         * css/WebKitCSSFilterValue.cpp: Added.
3109         (WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):
3110         (WebCore::WebKitCSSFilterValue::~WebKitCSSFilterValue):
3111         (WebCore::WebKitCSSFilterValue::cssText):
3112         * css/WebKitCSSFilterValue.h: Added.
3113         (WebCore::WebKitCSSFilterValue::create):
3114         (WebCore::WebKitCSSFilterValue::operationType):
3115         (WebCore::WebKitCSSFilterValue::isWebKitCSSFilterValue):
3116         * css/WebKitCSSFilterValue.idl: Added.
3117             WebKitCSSFilterValue modelled closely on WebKitCSSTransformValue,
3118             basically identifying the type of operation in a CSSValueList.
3119         * page/DOMWindow.idl:
3120             New WebKitCSSFilterValue constructor.
3121         * platform/graphics/filters/FilterOperation.h:
3122         (WebCore::BlurFilterOperation::create):
3123         (WebCore::BlurFilterOperation::stdDeviationX):
3124         (WebCore::BlurFilterOperation::stdDeviationY):
3125         (WebCore::BlurFilterOperation::BlurFilterOperation):
3126         (WebCore::SharpenFilterOperation::create):
3127         (WebCore::SharpenFilterOperation::radius):
3128         (WebCore::SharpenFilterOperation::threshold):
3129         (WebCore::SharpenFilterOperation::SharpenFilterOperation):
3130             Use Length rather than double for parameters that are CSS lengths.
3131
3132 2011-10-05  Chris Rogers  <crogers@google.com>
3133
3134         Fix Windows build - it doesn't have a log2f() function...
3135         https://bugs.webkit.org/show_bug.cgi?id=69473
3136
3137         Unreviewed build fix.
3138
3139         * webaudio/AudioParamTimeline.cpp:
3140         (WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
3141
3142 2011-10-05  James Robinson  <jamesr@chromium.org>
3143
3144         [chromium] ASSERT triggered when gpu process lost in single-threaded compositing path
3145         https://bugs.webkit.org/show_bug.cgi?id=69467
3146
3147         Reviewed by Kenneth Russell.
3148
3149         Shuffles debug-only bookkeeping around to more closely match what we do in the threaded path and not trip a
3150         false-positive ASSERT().
3151
3152         * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
3153         (WebCore::CCSingleThreadProxy::doComposite):
3154
3155 2011-10-05  Sheriff Bot  <webkit.review.bot@gmail.com>
3156
3157         Unreviewed, rolling out r96756.
3158         http://trac.webkit.org/changeset/96756
3159         https://bugs.webkit.org/show_bug.cgi?id=69472
3160
3161         Many builds broken due to WTFGetBacktrace not being exported
3162         from JavaScriptCore (Requested by aroben on #webkit).
3163
3164         * dom/ScriptElement.cpp:
3165         (WebCore::ScriptElement::ScriptElement):
3166         (WebCore::ScriptElement::stopLoadRequest):
3167         (WebCore::ScriptElement::notifyFinished):
3168         * dom/ScriptElement.h:
3169
3170 2011-10-05  Gavin Peters  <gavinp@chromium.org>
3171
3172         save resource zeroing stacks in ScriptElement for debugging
3173         https://bugs.webkit.org/show_bug.cgi?id=69453
3174
3175         The state machine tracking how m_cachedScript gets zeroed shows that sometimes we get
3176         two notifyFinished() events in a ScriptElement, which can crash chrome (see chrome bug
3177         75604).  This patch will save a stack in the ScriptElement when this happens, so that if
3178         we do later crash, we can see how we did the first zeroing.
3179
3180         See http://code.google.com/p/chromium/issues/detail?id=75604 for the chromium bug that
3181         this change will help track down.
3182
3183         Reviewed by Nate Chapin.
3184
3185         No new tests, this shouldn't affect output at all, and isn't particularly testable.
3186
3187         * dom/ScriptElement.cpp:
3188         (WebCore::ScriptElement::ScriptElement):
3189         (WebCore::ScriptElement::stopLoadRequest):
3190         (WebCore::ScriptElement::notifyFinished):
3191         * dom/ScriptElement.h:
3192
3193 2011-10-05  Alexey Proskuryakov  <ap@apple.com>
3194
3195         More build fix.
3196
3197         * WebCore.exp.in: Made a typo in a last minute change for my 32-bit build fix.
3198
3199 2011-10-05  Anna Cavender  <annacc@chromium.org>
3200
3201         Fix CueParser::didFinishLoading to match changes in ThreadableLoaderClient
3202         https://bugs.webkit.org/show_bug.cgi?id=69456
3203
3204         Reviewed by David Levin.
3205
3206         No new tests. No new functionality.
3207
3208         * html/track/CueParser.cpp:
3209         (WebCore::CueParser::didFinishLoading):
3210         * html/track/CueParser.h:
3211
3212 2011-10-05  Alexey Proskuryakov  <ap@apple.com>
3213
3214         32-bit build fix.
3215
3216         * WebCore.exp.in: In 32-bit, WebCore needs to export both NSSize and CGSize constructors.
3217         In 64-bit, NSSize is just a typedef for CGSize. Also fixed conversion operators, for good measure.
3218
3219 2011-10-05  Jer Noble  <jer.noble@apple.com>
3220
3221         WEB_AUDIO does not compile on Leopard 32-bit.
3222         https://bugs.webkit.org/show_bug.cgi?id=69292
3223
3224         Reviewed by Simon Fraser.
3225
3226         No new tests; covered by all existing audio tests.
3227
3228         Use of float and double within the WEB_AUDIO implementation have been harmonized, with most
3229         calculations done using floats, with narrowPrecisionToFloat() added when necessary to
3230         narrow double results down to floats, and with float constants initialized with float values:
3231         * platform/audio/AudioBus.cpp:
3232         (WebCore::AudioBus::AudioBus):
3233         (WebCore::AudioBus::createByMixingToMono):
3234         * platform/audio/AudioBus.h:
3235         (WebCore::AudioBus::sampleRate):
3236         (WebCore::AudioBus::setSampleRate):
3237         * platform/audio/AudioDSPKernel.h:
3238         (WebCore::AudioDSPKernel::AudioDSPKernel):
3239         (WebCore::AudioDSPKernel::sampleRate):
3240         * platform/audio/AudioDSPKernelProcessor.cpp:
3241         (WebCore::AudioDSPKernelProcessor::AudioDSPKernelProcessor):
3242         * platform/audio/AudioDSPKernelProcessor.h:
3243         * platform/audio/AudioDestination.h:
3244         * platform/audio/AudioFileReader.h:
3245         * platform/audio/AudioProcessor.h:
3246         (WebCore::AudioProcessor::AudioProcessor):
3247         (WebCore::AudioProcessor::sampleRate):
3248         * platform/audio/AudioUtilities.cpp:
3249         (WebCore::AudioUtilities::decibelsToLinear):
3250         (WebCore::AudioUtilities::linearToDecibels):
3251         (WebCore::AudioUtilities::discreteTimeConstantForSampleRate):
3252         * platform/audio/AudioUtilities.h:
3253         * platform/audio/DynamicsCompressor.cpp:
3254         (WebCore::DynamicsCompressor::DynamicsCompressor):
3255         (WebCore::DynamicsCompressor::initializeParameters):
3256         (WebCore::DynamicsCompressor::parameterValue):
3257         (WebCore::DynamicsCompressor::setEmphasisStageParameters):
3258         (WebCore::DynamicsCompressor::process):
3259         * platform/audio/DynamicsCompressor.h:
3260         (WebCore::DynamicsCompressor::sampleRate):
3261         (WebCore::DynamicsCompressor::nyquist):
3262         * platform/audio/DynamicsCompressorKernel.cpp:
3263         (WebCore::saturate):
3264         (WebCore::DynamicsCompressorKernel::DynamicsCompressorKernel):
3265         (WebCore::DynamicsCompressorKernel::process):
3266         * platform/audio/DynamicsCompressorKernel.h:
3267         * platform/audio/EqualPowerPanner.cpp:
3268         (WebCore::EqualPowerPanner::EqualPowerPanner):
3269         * platform/audio/EqualPowerPanner.h:
3270         * platform/audio/HRTFDatabase.cpp:
3271         (WebCore::HRTFDatabase::create):
3272         (WebCore::HRTFDatabase::HRTFDatabase):
3273         * platform/audio/HRTFDatabase.h:
3274         (WebCore::HRTFDatabase::sampleRate):
3275         * platform/audio/HRTFDatabaseLoader.cpp:
3276         (WebCore::HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary):
3277         (WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):
3278         * platform/audio/HRTFDatabaseLoader.h:
3279         (WebCore::HRTFDatabaseLoader::databaseSampleRate):
3280         * platform/audio/HRTFElevation.cpp:
3281         (WebCore::HRTFElevation::calculateSymmetricKernelsForAzimuthElevation):
3282         (WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):
3283         (WebCore::HRTFElevation::createForSubject):
3284         (WebCore::HRTFElevation::createByInterpolatingSlices):
3285         * platform/audio/HRTFElevation.h:
3286         (WebCore::HRTFElevation::sampleRate):
3287         (WebCore::HRTFElevation::HRTFElevation):
3288         * platform/audio/HRTFKernel.cpp:
3289         (WebCore::extractAverageGroupDelay):
3290         (WebCore::HRTFKernel::HRTFKernel):
3291         (WebCore::HRTFKernel::createInterpolatedKernel):
3292         * platform/audio/HRTFKernel.h:
3293         (WebCore::HRTFKernel::create):
3294         (WebCore::HRTFKernel::frameDelay):
3295         (WebCore::HRTFKernel::sampleRate):
3296         (WebCore::HRTFKernel::HRTFKernel):
3297         * platform/audio/HRTFPanner.cpp:
3298         (WebCore::HRTFPanner::HRTFPanner):
3299         (WebCore::HRTFPanner::fftSizeForSampleRate):
3300         * platform/audio/HRTFPanner.h:
3301         (WebCore::HRTFPanner::sampleRate):
3302         * platform/audio/Panner.cpp:
3303         (WebCore::Panner::create):
3304         * platform/audio/Panner.h:
3305         * platform/audio/chromium/AudioBusChromium.cpp:
3306         (WebCore::AudioBus::loadPlatformResource):
3307         * platform/audio/mac/AudioBusMac.mm:
3308         (WebCore::AudioBus::loadPlatformResource):
3309         * platform/audio/mac/AudioDestinationMac.cpp:
3310         (WebCore::AudioDestination::create):
3311         (WebCore::AudioDestination::hardwareSampleRate):
3312         (WebCore::AudioDestinationMac::AudioDestinationMac):
3313         * platform/audio/mac/AudioDestinationMac.h:
3314         (WebCore::AudioDestinationMac::sampleRate):
3315         * platform/audio/mac/AudioFileReaderMac.cpp:
3316         (WebCore::AudioFileReader::createBus):
3317         (WebCore::createBusFromAudioFile):
3318         (WebCore::createBusFromInMemoryAudioFile):
3319         * platform/audio/mac/AudioFileReaderMac.h:
3320         * webaudio/AsyncAudioDecoder.cpp:
3321         (WebCore::AsyncAudioDecoder::decodeAsync):
3322         (WebCore::AsyncAudioDecoder::DecodingTask::create):
3323         (WebCore::AsyncAudioDecoder::DecodingTask::DecodingTask):
3324         * webaudio/AsyncAudioDecoder.h:
3325         (WebCore::AsyncAudioDecoder::DecodingTask::sampleRate):
3326         * webaudio/AudioBasicProcessorNode.cpp:
3327         (WebCore::AudioBasicProcessorNode::AudioBasicProcessorNode):
3328         * webaudio/AudioBasicProcessorNode.h:
3329         * webaudio/AudioBuffer.cpp:
3330         (WebCore::AudioBuffer::create):
3331         (WebCore::AudioBuffer::createFromAudioFileData):
3332         (WebCore::AudioBuffer::AudioBuffer):
3333         * webaudio/AudioBuffer.h:
3334         (WebCore::AudioBuffer::sampleRate):
3335         * webaudio/AudioBufferSourceNode.cpp:
3336         (WebCore::AudioBufferSourceNode::create):
3337         (WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
3338         (WebCore::AudioBufferSourceNode::process):
3339         (WebCore::AudioBufferSourceNode::renderFromBuffer):
3340         * webaudio/AudioBufferSourceNode.h:
3341         * webaudio/AudioChannelMerger.cpp:
3342         (WebCore::AudioChannelMerger::AudioChannelMerger):
3343         * webaudio/AudioChannelMerger.h:
3344         (WebCore::AudioChannelMerger::create):
3345         * webaudio/AudioChannelSplitter.cpp:
3346         (WebCore::AudioChannelSplitter::AudioChannelSplitter):
3347         * webaudio/AudioChannelSplitter.h:
3348         (WebCore::AudioChannelSplitter::create):
3349         * webaudio/AudioContext.cpp:
3350         (WebCore::AudioContext::createOfflineContext):
3351         (WebCore::AudioContext::AudioContext):
3352         (WebCore::AudioContext::createBuffer):
3353         * webaudio/AudioContext.h:
3354         (WebCore::AudioContext::sampleRate):
3355         * webaudio/AudioDestinationNode.cpp:
3356         (WebCore::AudioDestinationNode::AudioDestinationNode):
3357         * webaudio/AudioDestinationNode.h:
3358         * webaudio/AudioGainNode.cpp:
3359         (WebCore::AudioGainNode::AudioGainNode):
3360         * webaudio/AudioGainNode.h:
3361         (WebCore::AudioGainNode::create):
3362         * webaudio/AudioListener.cpp:
3363         (WebCore::AudioListener::AudioListener):
3364         * webaudio/AudioListener.h:
3365         (WebCore::AudioListener::setPosition):
3366         (WebCore::AudioListener::setOrientation):
3367         (WebCore::AudioListener::setVelocity):
3368         * webaudio/AudioNode.cpp:
3369         (WebCore::AudioNode::AudioNode):
3370         * webaudio/AudioNode.h:
3371         (WebCore::AudioNode::sampleRate):
3372         * webaudio/AudioPannerNode.cpp:
3373         (WebCore::AudioPannerNode::AudioPannerNode):
3374         (WebCore::AudioPannerNode::getAzimuthElevation):
3375         * webaudio/AudioPannerNode.h:
3376         (WebCore::AudioPannerNode::create):
3377         * webaudio/AudioParam.cpp:
3378         (WebCore::AudioParam::value):
3379         (WebCore::AudioParam::smoothedValue):
3380         (WebCore::AudioParam::smooth):
3381         (WebCore::AudioParam::calculateSampleAccurateValues):
3382         * webaudio/AudioParamTimeline.cpp:
3383         (WebCore::AudioParamTimeline::valueForContextTime):
3384         (WebCore::timeToSampleFrame):
3385         (WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
3386         * webaudio/AudioSourceNode.h:
3387         (WebCore::AudioSourceNode::AudioSourceNode):
3388         * webaudio/BiquadFilterNode.cpp:
3389         (WebCore::BiquadFilterNode::BiquadFilterNode):
3390         * webaudio/BiquadFilterNode.h:
3391         (WebCore::BiquadFilterNode::create):
3392         * webaudio/BiquadProcessor.cpp:
3393         (WebCore::BiquadProcessor::BiquadProcessor):
3394         * webaudio/BiquadProcessor.h:
3395         * webaudio/ConvolverNode.cpp:
3396         (WebCore::ConvolverNode::ConvolverNode):
3397         * webaudio/ConvolverNode.h:
3398         (WebCore::ConvolverNode::create):
3399         * webaudio/DefaultAudioDestinationNode.cpp:
3400         (WebCore::DefaultAudioDestinationNode::initialize):
3401         * webaudio/DefaultAudioDestinationNode.h:
3402         (WebCore::DefaultAudioDestinationNode::sampleRate):
3403         * webaudio/DelayDSPKernel.cpp:
3404         (WebCore::DelayDSPKernel::DelayDSPKernel):
3405         (WebCore::DelayDSPKernel::process):
3406         * webaudio/DelayDSPKernel.h:
3407         * webaudio/DelayNode.cpp:
3408         (WebCore::DelayNode::DelayNode):
3409         * webaudio/DelayNode.h:
3410         (WebCore::DelayNode::create):
3411         * webaudio/DelayProcessor.cpp:
3412         (WebCore::DelayProcessor::DelayProcessor):
3413         * webaudio/DelayProcessor.h:
3414         * webaudio/DynamicsCompressorNode.cpp:
3415         (WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
3416         * webaudio/DynamicsCompressorNode.h:
3417         (WebCore::DynamicsCompressorNode::create):
3418         * webaudio/HighPass2FilterNode.cpp:
3419         (WebCore::HighPass2FilterNode::HighPass2FilterNode):
3420         * webaudio/HighPass2FilterNode.h:
3421         (WebCore::HighPass2FilterNode::create):
3422         * webaudio/JavaScriptAudioNode.cpp:
3423         (WebCore::JavaScriptAudioNode::create):
3424         (WebCore::JavaScriptAudioNode::JavaScriptAudioNode):
3425         (WebCore::JavaScriptAudioNode::initialize):
3426         * webaudio/JavaScriptAudioNode.h:
3427         * webaudio/LowPass2FilterNode.cpp:
3428         (WebCore::LowPass2FilterNode::LowPass2FilterNode):
3429         * webaudio/LowPass2FilterNode.h:
3430         (WebCore::LowPass2FilterNode::create):
3431         * webaudio/OfflineAudioDestinationNode.h:
3432         (WebCore::OfflineAudioDestinationNode::sampleRate):
3433         * webaudio/RealtimeAnalyserNode.cpp:
3434         (WebCore::RealtimeAnalyserNode::RealtimeAnalyserNode):
3435         * webaudio/RealtimeAnalyserNode.h:
3436         (WebCore::RealtimeAnalyserNode::create):
3437         * webaudio/WaveShaperDSPKernel.cpp:
3438         (WebCore::WaveShaperDSPKernel::process):
3439         * webaudio/WaveShaperProcessor.cpp:
3440         (WebCore::WaveShaperProcessor::WaveShaperProcessor):
3441         * webaudio/WaveShaperProcessor.h:
3442
3443
3444 2011-10-05  Alexey Proskuryakov  <ap@apple.com>
3445
3446         [Mac] Make built-in PDF description localizable
3447         https://bugs.webkit.org/show_bug.cgi?id=69442
3448
3449         Reviewed by Dan Bernstein.
3450
3451         Added strings for plug-in's name and for its supported MIME type.
3452
3453         * English.lproj/Localizable.strings:
3454         * WebCore.exp.in:
3455         * platform/DefaultLocalizationStrategy.cpp:
3456         (WebCore::DefaultLocalizationStrategy::builtInPDFPluginName):
3457         (WebCore::DefaultLocalizationStrategy::pdfDocumentTypeDescription):
3458         * platform/DefaultLocalizationStrategy.h:
3459         * platform/LocalizationStrategy.h:
3460         * platform/LocalizedStrings.cpp:
3461         (WebCore::builtInPDFPluginName):
3462         (WebCore::pdfDocumentTypeDescription):
3463         * platform/LocalizedStrings.h:
3464
3465 2011-10-05  David Levin  <levin@chromium.org>
3466
3467         Attempt to fix the bindings test (broken by r96727).
3468         Reviewed by Adam Barth.
3469
3470         * bindings/scripts/test/V8/V8TestInterface.cpp:
3471         (WebCore::ConfigureV8TestInterfaceTemplate):
3472         * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
3473         (WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
3474         * bindings/scripts/test/V8/V8TestObj.cpp:
3475         (WebCore::ConfigureV8TestObjTemplate):
3476         * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
3477         (WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
3478
3479 2011-10-05  James Robinson  <jamesr@chromium.org>
3480
3481         [chromium] Hook WebCompositor interface for input events up to the compositor proper
3482         https://bugs.webkit.org/show_bug.cgi?id=69394
3483
3484         Reviewed by Darin Fisher.
3485
3486         This wires up WebCompositorImpl to the compositor itself so we can han