[GStreamer] Review WebKitWebSource after r219252.

[WebKit-https.git] / Source / WebCore / ChangeLog

2017-07-26  Charlie Turner  <cturner@igalia.com>

        [GStreamer] Review WebKitWebSource after r219252.
        https://bugs.webkit.org/show_bug.cgi?id=174415

        Reviewed by Carlos Garcia Campos.

        Remove ResourceHandleStreamingClient, and flatten the StreamingClient
        into CachedResourceStreamingClient (the only implemetation left). They
        are no longer required after r219252.

        Also remove the locking code. It's not needed now, and what existed
        was heavy-handed and missed several cases it was supposed to protect

        Covered by existing tests.

        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        (webkit_web_src_init):
        (webKitWebSrcDispose):
        (webKitWebSrcStop):
        (webKitWebSrcStart):
        (webKitWebSrcNeedData):
        (webKitWebSrcEnoughData):
        (webKitWebSrcSeek):
        (webKitWebSrcSetMediaPlayer):
        (CachedResourceStreamingClient::CachedResourceStreamingClient):
        (CachedResourceStreamingClient::~CachedResourceStreamingClient):
        (CachedResourceStreamingClient::getOrCreateReadBuffer):
        (CachedResourceStreamingClient::responseReceived):
        (CachedResourceStreamingClient::dataReceived):
        (CachedResourceStreamingClient::loadFinished):
        (ResourceHandleStreamingClient::create): Deleted.
        (): Deleted.
        (StreamingClient::StreamingClient): Deleted.
        (StreamingClient::~StreamingClient): Deleted.
        (StreamingClient::createReadBuffer): Deleted.
        (StreamingClient::handleResponseReceived): Deleted.
        (StreamingClient::handleDataReceived): Deleted.
        (StreamingClient::handleNotifyFinished): Deleted.
        (ResourceHandleStreamingClient::ResourceHandleStreamingClient): Deleted.
        (ResourceHandleStreamingClient::~ResourceHandleStreamingClient): Deleted.
        (ResourceHandleStreamingClient::cleanupAndStopRunLoop): Deleted.
        (ResourceHandleStreamingClient::invalidate): Deleted.
        (ResourceHandleStreamingClient::loadFailed): Deleted.
        (ResourceHandleStreamingClient::setDefersLoading): Deleted.
        (ResourceHandleStreamingClient::getOrCreateReadBuffer): Deleted.
        (ResourceHandleStreamingClient::willSendRequest): Deleted.
        (ResourceHandleStreamingClient::didReceiveResponse): Deleted.
        (ResourceHandleStreamingClient::didReceiveData): Deleted.
        (ResourceHandleStreamingClient::didReceiveBuffer): Deleted.
        (ResourceHandleStreamingClient::didFinishLoading): Deleted.
        (ResourceHandleStreamingClient::didFail): Deleted.
        (ResourceHandleStreamingClient::wasBlocked): Deleted.
        (ResourceHandleStreamingClient::cannotShowURL): Deleted.

2017-07-26  Brian Burg  <bburg@apple.com>

        Remove WEB_TIMING feature flag
        https://bugs.webkit.org/show_bug.cgi?id=174795

        Reviewed by Alex Christensen.

        * Configurations/FeatureDefines.xcconfig:
        * bindings/js/JSPerformanceEntryCustom.cpp:
        * dom/Document.cpp:
        (WebCore::Document::setReadyState):
        (WebCore::Document::finishedParsing):
        * dom/Document.h:
        (WebCore::Document::timing):
        * dom/DocumentTiming.h:
        * dom/EventTargetFactory.in:
        * loader/DocumentThreadableLoader.cpp:
        (WebCore::DocumentThreadableLoader::finishedTimingForWorkerLoad):
        (WebCore::DocumentThreadableLoader::loadRequest):
        * loader/DocumentThreadableLoader.h:
        * loader/ResourceTimingInformation.cpp:
        * loader/ResourceTimingInformation.h:
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::didFinishLoading):
        (WebCore::SubresourceLoader::reportResourceTiming):
        * loader/SubresourceLoader.h:
        * loader/ThreadableLoaderClient.h:
        (WebCore::ThreadableLoaderClient::didFail):
        (WebCore::ThreadableLoaderClient::didFinishTiming):
        * loader/WorkerThreadableLoader.cpp:
        (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishTiming):
        * loader/WorkerThreadableLoader.h:
        * loader/cache/CachedResourceLoader.cpp:
        (WebCore::CachedResourceLoader::requestResource):
        (WebCore::CachedResourceLoader::revalidateResource):
        (WebCore::CachedResourceLoader::loadResource):
        * loader/cache/CachedResourceLoader.h:
        (WebCore::CachedResourceLoader::resourceTimingInformation):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::~DOMWindow):
        (WebCore::DOMWindow::resetDOMWindowProperties):
        (WebCore::DOMWindow::nowTimestamp):
        (WebCore::DOMWindow::removeAllEventListeners):
        * page/DOMWindow.h:
        * page/GlobalPerformance.idl:
        * page/Performance.cpp:
        * page/Performance.h:
        * page/Performance.idl:
        * page/PerformanceEntry.cpp:
        * page/PerformanceEntry.h:
        * page/PerformanceEntry.idl:
        * page/PerformanceMark.h:
        * page/PerformanceMark.idl:
        * page/PerformanceMeasure.h:
        * page/PerformanceMeasure.idl:
        * page/PerformanceNavigation.cpp:
        * page/PerformanceNavigation.h:
        * page/PerformanceNavigation.idl:
        * page/PerformanceObserver.cpp:
        * page/PerformanceObserver.h:
        * page/PerformanceObserver.idl:
        * page/PerformanceObserverCallback.h:
        * page/PerformanceObserverCallback.idl:
        * page/PerformanceObserverEntryList.cpp:
        * page/PerformanceObserverEntryList.h:
        * page/PerformanceObserverEntryList.idl:
        * page/PerformanceResourceTiming.cpp:
        * page/PerformanceResourceTiming.h:
        * page/PerformanceResourceTiming.idl:
        * page/PerformanceTiming.cpp:
        * page/PerformanceTiming.h:
        * page/PerformanceTiming.idl:
        * page/PerformanceUserTiming.cpp:
        * page/PerformanceUserTiming.h:
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleInternal.h:
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::start):
        * platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
        (WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
        * platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:
        (WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse):
        * platform/network/curl/ResourceHandleCurl.cpp:
        (WebCore::ResourceHandleInternal::didFinish):
        (WebCore::ResourceHandleInternal::calculateWebTimingInformations):
        (WebCore::ResourceHandleInternal::dispatchSynchronousJob):
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::createNSURLConnection):
        * platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
        * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
        (-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::restartedCallback):
        (WebCore::sendRequestCallback):
        (WebCore::createSoupMessageForHandleAndRequest):
        (WebCore::ResourceHandle::sendPendingRequest):
        * platform/network/soup/SoupNetworkSession.cpp:
        (WebCore::SoupNetworkSession::SoupNetworkSession):
        * workers/WorkerGlobalScope.cpp:
        (WebCore::WorkerGlobalScope::WorkerGlobalScope):
        (WebCore::WorkerGlobalScope::~WorkerGlobalScope):
        (WebCore::WorkerGlobalScope::removeAllEventListeners):
        * workers/WorkerGlobalScope.h:

2017-07-26  Chris Dumez  <cdumez@apple.com>

        Pressing the Escape key should not be a valid user gesture to enter fullscreen
        https://bugs.webkit.org/show_bug.cgi?id=174864
        <rdar://problem/33009088>

        Reviewed by Geoffrey Garen.

        Pressing the Escape key should not be a valid user gesture to enter fullscreen since this
        is the gesture to exit fullscreen already.

        Test: fullscreen/requestFullscreen-escape-key.html

        * dom/Document.cpp:
        (WebCore::Document::requestFullScreenForElement):
        * dom/UserGestureIndicator.cpp:
        (WebCore::UserGestureIndicator::UserGestureIndicator):
        * dom/UserGestureIndicator.h:
        (WebCore::UserGestureToken::create):
        (WebCore::UserGestureToken::gestureType):
        (WebCore::UserGestureToken::UserGestureToken):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::internalKeyEvent):

2017-07-26  Nan Wang  <n_wang@apple.com>

        AX: Incorrect range from index and length in contenteditable with <p> tags
        https://bugs.webkit.org/show_bug.cgi?id=174856

        Reviewed by Chris Fleizach.

        When asking for the string inside a text control with a given range, we sometimes get
        a wrong string at the line boundary due to a bad plain range to text marker conversion.
        To fix this, we should use the exsisting method on text controls to avoid this issue. 

        Updated the test to test the problematic case.

        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
        (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

2017-07-26  Daewoong Jang  <daewoong.jang@navercorp.com>

        [Curl] Bug fix after r219606
        https://bugs.webkit.org/show_bug.cgi?id=174845

        Reviewed by Alex Christensen.

        * platform/network/curl/CurlContext.h:
        (WebCore::CurlSList::isEmpty):
        * platform/network/curl/ResourceHandleCurl.cpp:
        (WebCore::ResourceHandleInternal::didReceiveHeaderLine):
        (WebCore::ResourceHandleInternal::headerCallback):

2017-07-26  Zan Dobersek  <zdobersek@igalia.com>

        [EME][GStreamer] Multi-key support in the GStreamer ClearKey decryptor
        https://bugs.webkit.org/show_bug.cgi?id=174779

        Reviewed by Xabier Rodriguez-Calvar.

        In the CENC decryptor, the key ID value is retrieved from the info structure
        on the GstProtectionMeta object. GstBuffer for that value is retrieved and
        passed to the setupCipher() function.

        In the ClearKey decryptor (which extends the CENC decryptor), the single
        GstBuffer object on the private instance that holds the key value is replaced
        with a Vector object that holds pairs of key ID and value GstBuffers. In the
        handleKeyResponse() implementation that Vector is emptied and then refilled
        with key ID and value pairs that are passed in through the drm-cipher-clearkey
        structure that's attached to the GstEvent that signalled new key information.

        In the ClearKey decryptor's setupCipher() implementation the passed-in key ID
        buffer is used to find a matching key ID and value pair stored on the private
        instance. If not found, an error is thrown. If found, the matching key value
        is used for decryption.

        * platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:
        (webKitMediaClearKeyDecryptorHandleKeyResponse):
        (webKitMediaClearKeyDecryptorSetupCipher):
        * platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
        (webkitMediaCommonEncryptionDecryptTransformInPlace):
        (webKitMediaCommonEncryptionDecryptDefaultSetupCipher):
        * platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.h:

2017-07-26  Zan Dobersek  <zdobersek@igalia.com>

        [EME][GStreamer] Handle ClearKey as a supported key system
        https://bugs.webkit.org/show_bug.cgi?id=174778

        Reviewed by Xabier Rodriguez-Calvar.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
        (WebCore::MediaPlayerPrivateGStreamerBase::supportsKeySystem):
        Return true for the 'org.w3.clearkey' key system when building with
        ENCRYPTED_MEDIA enabled. The underlying implementation will follow.

2017-07-26  Claudio Saavedra  <csaavedra@igalia.com>

        [WPE] Fix a potential crash in the platform pasteboard when reading a string
        https://bugs.webkit.org/show_bug.cgi?id=174859

        Reviewed by Žan Doberšek.

        We shouldn't assume that the wpe_pasteboard_string struct will be
        filled in, so initialize it.

        * platform/wpe/PlatformPasteboardWPE.cpp:
        (WebCore::PlatformPasteboard::readString): Initialize the struct
        before passing it to wpe and early return if it's still empty.

2017-07-26  Javier Fernandez  <jfernandez@igalia.com>

        InsertOrderedList command applied to table cells inserts an extra BR before the table
        https://bugs.webkit.org/show_bug.cgi?id=174593

        Reviewed by Darin Adler.

        Don't add BR when pruning empty blocks if it's the start of a paragraph.

        The function MoveParagraph is used for several operations and editing
        commands, like 'insertOrderedList'. When moving paragraphs we check out
        whether we should add a 'br' element to avoid undesired block collapse.

        However, we shouldn't do this when destination is the start of a
        paragraph.

        Tests: editing/inserting/insert-list-in-table-cell-01.html
               editing/inserting/insert-list-in-table-cell-02.html
               editing/inserting/insert-list-in-table-cell-03.html
               editing/inserting/insert-list-in-table-cell-04.html
               editing/inserting/insert-list-in-table-cell-05.html
               editing/inserting/insert-list-in-table-cell-06.html
               editing/inserting/insert-list-in-table-cell-07.html
               editing/inserting/insert-list-in-table-cell-08.html

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraphs):

2017-07-26  Zan Dobersek  <zdobersek@igalia.com>

        [WPE] WebGL2 support
        https://bugs.webkit.org/show_bug.cgi?id=174249

        Reviewed by Alex Christensen.

        Implement WebGL2 support in GraphicsContext3DCairo for the WPE port, but keep
        the implementation specific to libepoxy (which WPE leverages by default).

        In the GraphicsContext3D::create() method, we first construct the
        GraphicsContext3D object that also ensures a current GL context on this thread.
        Only then can we determine through libepoxy whether the underlying GL library
        is able to support WebGL2.

        For WebGL2, the GLES3 support is required. The initial libepoxy implementation
        ensures this only in case of 'non-desktop GL' library of minimum version 3.0.
        This effectively translates to the only supported configuration being the
        EGL and OpenGL ES 3.0 (or higher) combination. If this cannot be ensured, we
        discard the existing GraphicsContext3D object and return null.

        WebGL2 can also be supported via OpenGL (i.e. 'desktop GL'), but this hasn't
        been tested yet. Implementation will in the future be extended to support that
        as required.

        In the GraphicsContext3D constructor itself, the ANGLEWebKitBridge constructor
        has to now receive the second argument, the desired shader specification that's
        used when parsing the provided shaders. This should be SH_WEBGL_SPEC for WebGL1,
        and SH_WEBGL2_SPEC for WebGL2.

        No new tests -- a small set of existing WebGL2 tests is unskipped and passing.

        * platform/graphics/cairo/GraphicsContext3DCairo.cpp:
        (WebCore::GraphicsContext3D::create):
        (WebCore::GraphicsContext3D::GraphicsContext3D):
        * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
        Add WebGL2-specific methods to the build.

2017-07-26  Nan Wang  <n_wang@apple.com>

        AX: should dispatch accessibilityPerformPressAction async on MacOS
        https://bugs.webkit.org/show_bug.cgi?id=174849

        Reviewed by Chris Fleizach.

        If performing the accessibility press action results in a modal alert being displayed,
        it can cause VoiceOver to hang. To fix it, we should dispatch the action asynchronously.

        Updated tests to adapt to this change.

        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
        (-[WebAccessibilityObjectWrapper accessibilityPerformPressAction]):
        (-[WebAccessibilityObjectWrapper _accessibilityPerformPressAction]):

2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>

        Icon loader error on startup
        https://bugs.webkit.org/show_bug.cgi?id=174787

        Reviewed by Brady Eidson.

        This is a regression of the new icon loading, it happens with pages that shouldn't have a favicon, like about
        pages. IconController::startLoader() did several checks before starting the load that
        DocumentLoader::startIconLoading() is not doing. It checked that the frame is the main one, the document can have
        an icon (document url is not empty and not about:blank) and that favicon url is in HTTP family. We should do the
        same checks now before starting to load icons.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::startIconLoading):

2017-07-25  Sam Weinig  <sam@webkit.org>

        [WebIDL] Remove custom bindings for HTMLCanvasElement
        https://bugs.webkit.org/show_bug.cgi?id=174847

        Reviewed by Darin Adler.

        * CMakeLists.txt:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSHTMLCanvasElementCustom.cpp: Removed.
        Remove JSHTMLCanvasElementCustom.

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::getContext):
        (WebCore::HTMLCanvasElement::getContext2d):
        (WebCore::HTMLCanvasElement::getContextWebGL):
        (WebCore::HTMLCanvasElement::getContextWebGPU):
        * html/HTMLCanvasElement.h:
        * html/HTMLCanvasElement.idl:
        Move context picking code to HTMLCanvasElement. Give more
        exact types to remaining context getters.

2017-07-25  Chris Dumez  <cdumez@apple.com>

        Clean up ExceptionCode enumeration
        https://bugs.webkit.org/show_bug.cgi?id=174812

        Reviewed by Darin Adler.

        Clean up ExceptionCode enumeration:
        - Updated comments to reflect the latest WebIDL specification
        - Drop special values given to some exception codes. Those legacy codes are already in the
          table inside DOMException.cpp. This also allows us to drop empty rows in the DOMException
          table
        - Drop NoException value in the enumeration and use std::optional<ExceptionCode> when needed
          instead.

        * Modules/indexeddb/shared/IDBError.cpp:
        (WebCore::IDBError::IDBError):
        (WebCore::IDBError::name):
        (WebCore::IDBError::message):
        * Modules/indexeddb/shared/IDBError.h:
        (WebCore::IDBError::code):
        (WebCore::IDBError::encode):
        (WebCore::IDBError::decode):
        * dom/DOMException.cpp:
        * dom/ExceptionCode.h:
        * fileapi/FileReaderSync.cpp:
        (WebCore::errorCodeToException):
        (WebCore::FileReaderSync::startLoading):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::createRequest):
        * xml/XMLHttpRequest.h:

2017-07-25  Andy Estes  <aestes@apple.com>

        [Apple Pay] Add "carteBancaire" as a supported payment network
        https://bugs.webkit.org/show_bug.cgi?id=174841
        <rdar://problem/31935596>

        Reviewed by Alex Christensen.

        Tests: http/tests/ssl/applepay/ApplePaySession.html
               http/tests/ssl/applepay/ApplePaySessionV3.html

        * Modules/applepay/PaymentRequest.cpp:
        (WebCore::PaymentRequest::isValidSupportedNetwork):

2017-07-25  Daniel Bates  <dabates@apple.com>

        Make StyleResolver::isValid{Cue, Region}StyleProperty() static, inline, non-member functions
        https://bugs.webkit.org/show_bug.cgi?id=174827

        Reviewed by Simon Fraser.

        StyleResolver::isValid{Cue, Region}StyleProperty() access neither instance nor
        class data. Moreover, they are private member functions and hence cannot be
        used outside of StyleResolver's implementation. So, make these static, inline,
        non-member functions.

        * css/StyleResolver.cpp:
        (WebCore::isValidRegionStyleProperty):
        (WebCore::isValidCueStyleProperty):
        (WebCore::StyleResolver::CascadedProperties::addMatch):
        (WebCore::StyleResolver::isValidRegionStyleProperty): Deleted.
        (WebCore::StyleResolver::isValidCueStyleProperty): Deleted.
        * css/StyleResolver.h:

2017-07-25  Per Arne Vollan  <pvollan@apple.com>

        Dragged links are blurry on 1x displays.
        https://bugs.webkit.org/show_bug.cgi?id=174831
        <rdar://problem/33519698>

        Reviewed by Simon Fraser.

        When the width and height of the drag image is a multiple of 2, the drag image is not blurry
        on a 1x display. This is a workaround which should be removed when <rdar://problem/33059739>
        is fixed.

        No new tests, since this is not straightforward to test with a layout test.

        * platform/mac/DragImageMac.mm:
        (WebCore::LinkImageLayout::LinkImageLayout):

2017-07-25  Matt Baker  <mattbaker@apple.com>

        Web Inspector: Refactoring: extract async stack trace logic from InspectorInstrumentation
        https://bugs.webkit.org/show_bug.cgi?id=174738

        Reviewed by Brian Burg.

        Relocate AsyncCallType from InspectorInstrumentation to the debugger
        agent. Plumbing for `requestAnimationFrame` notifications has been added
        to PageDebuggerAgent, which is responsible for managing async stack traces. 

        * dom/ScriptedAnimationController.cpp:
        (WebCore::ScriptedAnimationController::registerCallback):
        (WebCore::ScriptedAnimationController::cancelCallback):
        (WebCore::ScriptedAnimationController::serviceScriptedAnimations):

        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didInstallTimerImpl):
        (WebCore::InspectorInstrumentation::didRemoveTimerImpl):
        (WebCore::InspectorInstrumentation::willFireTimerImpl):
        (WebCore::InspectorInstrumentation::didRequestAnimationFrameImpl):
        (WebCore::InspectorInstrumentation::didCancelAnimationFrameImpl):
        (WebCore::InspectorInstrumentation::willFireAnimationFrameImpl):
        (): Deleted.
        (WebCore::didScheduleAsyncCall): Deleted.

        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::didRequestAnimationFrame):
        (WebCore::InspectorInstrumentation::didCancelAnimationFrame):
        (WebCore::InspectorInstrumentation::willFireAnimationFrame):
        Replaced Frame and Document pointers with references and moved
        pointer validation upstream.

        * inspector/PageDebuggerAgent.cpp:
        (WebCore::PageDebuggerAgent::didRequestAnimationFrame):
        (WebCore::PageDebuggerAgent::willFireAnimationFrame):
        (WebCore::PageDebuggerAgent::didCancelAnimationFrame):
        * inspector/PageDebuggerAgent.h:

2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>

        Async image decoding for large images should be disabled after the first time a tile is painted
        https://bugs.webkit.org/show_bug.cgi?id=174451
        <rdar://problem/31246421>

        Reviewed by Simon Fraser.

        Flashing because of DOM mutation can be fixed by disabling the asynchronous
        image decoding after the first time a tile was painted.

        We can detect this by consulting the tile repaintCount. If it is zero, then
        it is safe to use asynchronous image decoded. If the tile repaintCount is
        greater than zero, we are not sure if the renderer rectangle has an image
        drawn in it already or not. In this case we have to use the synchronous
        image decoding to avoid causing a flash.

        Tests: fast/images/async-image-background-change.html
               fast/images/async-image-src-change.html
               http/tests/multipart/multipart-async-image.html

        * html/shadow/MediaControlElements.cpp:
        (WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
        * page/FrameView.cpp:
        (WebCore::FrameView::willPaintContents):
        (WebCore::FrameView::paintContentsForSnapshot):
        * page/PageOverlayController.cpp:
        (WebCore::PageOverlayController::paintContents):
        * page/PageOverlayController.h:
        * page/linux/ResourceUsageOverlayLinux.cpp:
        * page/mac/ServicesOverlayController.h:
        * page/mac/ServicesOverlayController.mm:
        (WebCore::ServicesOverlayController::Highlight::paintContents):
        * platform/graphics/BitmapImage.cpp:
        (WebCore::BitmapImage::draw):
        * platform/graphics/BitmapImage.h:
        * platform/graphics/GraphicsLayer.cpp:
        (WebCore::GraphicsLayer::paintGraphicsLayerContents):
        * platform/graphics/GraphicsLayer.h:
        * platform/graphics/GraphicsLayerClient.h:
        (WebCore::GraphicsLayerClient::paintContents):
        * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
        (WebCore::LayerClient::platformCALayerPaintContents):
        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::platformCALayerPaintContents):
        * platform/graphics/ca/GraphicsLayerCA.h:
        * platform/graphics/ca/PlatformCALayer.h:
        * platform/graphics/ca/PlatformCALayerClient.h:
        (WebCore::PlatformCALayerClient::platformCALayerRepaintCount):
        * platform/graphics/ca/TileCoverageMap.cpp:
        (WebCore::TileCoverageMap::platformCALayerPaintContents):
        * platform/graphics/ca/TileCoverageMap.h:
        * platform/graphics/ca/TileGrid.cpp:
        (WebCore::TileGrid::platformCALayerPaintContents):
        (WebCore::TileGrid::platformCALayerRepaintCount):
        * platform/graphics/ca/TileGrid.h:
        * platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
        (PlatformCALayer::drawLayerContents):
        * platform/graphics/ca/win/PlatformCALayerWin.cpp:
        (PlatformCALayer::drawLayerContents):
        * platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
        (PlatformCALayerWinInternal::displayCallback):
        * platform/graphics/ca/win/WebTiledBackingLayerWin.cpp:
        (WebTiledBackingLayerWin::displayCallback):
        * platform/graphics/mac/WebLayer.mm:
        (-[WebLayer drawInContext:]):
        (-[WebSimpleLayer drawInContext:]):
        * rendering/PaintPhase.h:
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::decodingModeForImageDraw):
        * rendering/RenderElement.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintLayerContents):
        (WebCore::RenderLayer::paintForegroundForFragments):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::paintContents):
        * rendering/RenderLayerBacking.h:
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::paintContents):
        * rendering/RenderLayerCompositor.h:
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paintContents):
        * testing/Internals.cpp:
        (WebCore::imageFromImageElement):
        (WebCore::bitmapImageFromImageElement):
        (WebCore::Internals::imageFrameIndex):
        (WebCore::Internals::setImageFrameDecodingDuration):
        (WebCore::Internals::resetImageAnimation):
        (WebCore::Internals::isImageAnimating):
        (WebCore::Internals::setClearDecoderAfterAsyncFrameRequestForTesting):
        (WebCore::Internals::imageDecodeCount):
        (WebCore::Internals::setLargeImageAsyncDecodingEnabledForTesting):
        * testing/Internals.h:
        * testing/Internals.idl:

2017-07-23  Sam Weinig  <sam@webkit.org>

        [WebIDL] Add support for generating timer bindings
        https://bugs.webkit.org/show_bug.cgi?id=174766

        Reviewed by Darin Adler.

        Adds a new non-standard type, ScheduledAction, which stands in for the
        standard (DOMString or Function). It would be good to move to that in
        future, but for now, this allows for forward momentum on removing custom
        bindings.

        * WebCore.xcodeproj/project.pbxproj:
        Add JSDOMConvertScheduledAction.h.

        * bindings/IDLTypes.h:
        Add IDLScheduledAction.

        * bindings/js/JSDOMConvertScheduledAction.h: Added.
        (WebCore::Converter<IDLScheduledAction>::convert):
        Add conversion from JSValue -> ScheduledAction. This is moved from the old ScheduledAction
        create function.

        * bindings/js/JSDOMConvertVariadic.h:
        (WebCore::convertVariadicArguments):
        (WebCore::Detail::VariadicConverterBase::convert): Deleted.
        (WebCore::Detail::VariadicConverterBase<IDLInterface<T>>::convert): Deleted.
        * bindings/js/JSDOMConvertBase.h:
        * bindings/js/JSDOMConvertAny.h:
        (WebCore::VariadicConverter<IDLAny>::convert):
        * bindings/js/JSDOMConvertInterface.h:
        (WebCore::VariadicConverter<IDLInterface<T>>::convert):
        Rename VariadicConverter to VariadicConverterDetails, and remove base class. Rename 
        VariadicConverterBase to VariadicConverter, and move specializations to the file
        containing the base converter for that IDL type 

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::setTimeout): Deleted.
        (WebCore::JSDOMWindow::setInterval): Deleted.
        * bindings/js/JSWorkerGlobalScopeCustom.cpp:
        (WebCore::JSWorkerGlobalScope::setTimeout): Deleted.
        (WebCore::JSWorkerGlobalScope::setInterval): Deleted.
        Remove custom implementations of setTimeout and setInterval.

        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::create):
        (WebCore::ScheduledAction::ScheduledAction):
        (WebCore::ScheduledAction::~ScheduledAction):
        (WebCore::ScheduledAction::addArguments):
        (WebCore::ScheduledAction::executeFunctionInContext):
        * bindings/js/ScheduledAction.h:
        (WebCore::ScheduledAction::ScheduledAction): Deleted.
        Rework ScheduledAction. Now has two create functions, one for the function
        form, one for the string form. These are now called by the Converter. Also,
        rather than extracting the arguments directly from the ExecState, allow the
        bindings to work as designed, and have the arguments come in as variadic 
        arguments to setTimeout/setInterval and get added to the ScheduledAction if
        needed. Also, move ContentSecurityPolicy check out of construction, and into
        setTimeout/setInterval.

        * bindings/scripts/CodeGenerator.pm:
        (IsBuiltinType):
        Add ScheduledAction to the builtin list.

        * bindings/scripts/CodeGeneratorJS.pm:
        (AddToIncludesForIDLType):
        Add the correct include when ScheduledAction is used.

        (GenerateParametersCheck):
        Remove rule disallowing optional arguments before variadic arguments. That works
        just fine.

        (GetBaseIDLType):
        Add mapping of ScheduledAction -> IDLScheduledAction.

        (JSValueToNativeDOMConvertNeedsGlobalObject):
        Add ScheduledAction to the list of types that need a global object
        for conversion.

        * page/WindowOrWorkerGlobalScope.idl:
        Update interface to match spec and add FIXMEs for moving to TimerHandler.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::setTimeout):
        (WebCore::DOMWindow::setInterval):
        * page/DOMWindow.h:
        * workers/WorkerGlobalScope.cpp:
        (WebCore::WorkerGlobalScope::setTimeout):
        (WebCore::WorkerGlobalScope::setInterval):
        * workers/WorkerGlobalScope.h:
        Update for new signatures. WorkerGlobalScope now has to return ExceptionOr<int>
        even though it never throws, due to having one IDL file defining these. This is 
        unfortunate and something we should look at addressing the future.

2017-07-25  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>

        [WinCairo] Fix build with AllInOnes disabled
        https://bugs.webkit.org/show_bug.cgi?id=174784
        <rdar://problem/33488914>

        Reviewed by Alex Christensen.

        * PlatformWin.cmake:
        Add RenderThemeWin.cpp to WebCore_SOURCES

        * rendering/RenderingAllInOne.cpp:
        Remove #include "RenderThemeWin.cpp"

        * testing/MemoryInfo.h:
        Remove #include "JSDomWindow.h"

        * bindings/js/JSDOMGlobalObject.cpp:
        * bindings/js/JSDOMPromiseDeferred.cpp:
        * bindings/js/JSDOMWrapper.cpp:
        * bindings/js/JSImageDataCustom.cpp:
        * bindings/scripts/CodeGeneratorJS.pm:
        (GenerateCallWith):
        * dom/ScriptExecutionContext.cpp:
        * inspector/InspectorController.cpp:
        * inspector/InspectorTimelineAgent.cpp:
        * rendering/RenderMediaControls.cpp:
        * rendering/RenderMediaControls.h:
        * rendering/RenderThemeWin.cpp:

        * bindings/scripts/test/JS/JSTestObj.cpp:
        Update test results.

2017-07-25  Konstantin Tokarev  <annulen@yandex.ru>

        Unreviewed, fix Mac CMake build after r219567

        * PlatformMac.cmake:

2017-07-23  Darin Adler  <darin@apple.com>

        More NeverDestroyed and related cleanup
        https://bugs.webkit.org/show_bug.cgi?id=174745

        Reviewed by Alex Christensen.

        * bindings/js/JSCustomElementInterface.cpp:
        (WebCore::JSCustomElementInterface::constructElementWithFallback):
        Use isNull() rather than comparing against nullAtom() since it's
        slightly more efficient.

        * css/MediaQueryEvaluator.cpp:
        (WebCore::prefersReducedMotionEvaluate): Use a switch statement for the
        three states of forcedPrefersReducedMotionAccessibilityValue. Also update
        to use Theme::singleton() instead of platformTheme().

        * dom/QualifiedName.h: Removed some unneeded includes, minor style tweaks,
        and use isNull() rather than comparing against nullAtom() since it's
        slightly more efficient.

        * html/Autofill.cpp:
        (WebCore::AutofillData::createFromHTMLFormControlElement): Use isNull()
        rather than comparing against nullAtom() since it's slightly more efficient.

        * html/HTMLDocument.cpp:
        (WebCore::addLocalNameToSet): Deleted.
        (WebCore::createHtmlCaseInsensitiveAttributesSet): Deleted.
        (WebCore::HTMLDocument::isCaseSensitiveAttribute): Moved the case-sensitive
        attribute set in here and made it use makeNeverDestroyed.

        * html/HTMLNameCollection.cpp:
        (WebCore::WindowNameCollection::elementMatchesIfNameAttributeMatch):
        Formatted vertically and sorted so it's easier to see what it does.
        (WebCore::WindowNameCollection::elementMatches): Use boolean logic instead
        of multiple return statements to make this a little more straightforward.
        (WebCore::isObjectElementForDocumentNameCollection): Added. Calls the new
        isExposed function. The old code called this isDocNamedItem.
        (WebCore::DocumentNameCollection::elementMatchesIfIdAttributeMatch):
        Use isObjectElementForDocumentNameCollection to clean up logic. Also
        sorted classes.
        (WebCore::DocumentNameCollection::elementMatchesIfNameAttributeMatch):
        Use isObjectElementForDocumentNameCollection to clean up logic. Also
        sorted classes and formatted vertically.
        (WebCore::DocumentNameCollection::elementMatches): Write in terms of
        above functions for clarity. Efficiency is roughly the same.

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::HTMLObjectElement): Initialize data members
        in class definition instead of here.
        (WebCore::HTMLObjectElement::childrenChanged): Update for name change;
        function is now called updateExposedState rather than updateDocNamedItem.
        Also use m_useFallbackContent directly instead of through a function.
        (WebCore::HTMLObjectElement::renderFallbackContent): Ditto.
        (WebCore::preventsParentObjectFromExposure): Added. Replaces the old
        isRecognizedTagName function, and does almost the same thing, but the
        argument type is different and the param tag is now one of the tags
        exempted here. Also broke up into two overloads so we can handle the
        Element, Text, and other Node cases.
        (WebCore::shouldBeExposed): Added. Helper for the updateExposedState
        function that handles the logic of when the element should be exposed,
        separating it from what to do when the state changes.
        (WebCore::HTMLObjectElement::updateExposedState): Renamed from
        updateDocNamedItem.

        * html/HTMLObjectElement.h: Renamed isDocNamedItem -> isExposed,
        m_docNamedItem -> m_isExposed, updateDocNamedItem -> updateExposedState,
        stopped using bit fields for the two boolean data members, and
        initialized those data members here in the class definition.

        * platform/Theme.cpp:
        (WebCore::Theme::baselinePositionAdjustment): Moved here from header.
        (WebCore::Theme::controlFont): Ditto.
        (WebCore::Theme::controlSize): Ditto.
        (WebCore::Theme::minimumControlSize): Ditto.
        (WebCore::Theme::controlRequiresPreWhiteSpace): Ditto.
        (WebCore::Theme::paint): Ditto.
        (WebCore::Theme::inflateControlPaintRect): Ditto.
        (WebCore::Theme::userPrefersReducedMotion): Ditto.
        (WebCore::Theme::controlBorder): Fixed switch statement indentation.
        (WebCore::Theme::controlPadding): Ditto.

        * platform/Theme.h: Removed the many unnecessary includes. The one
        I was really after here was FontCascade.h. Replaced the platformTheme
        function with a singleton function, following our normal style. Also
        changed the return type to a reference rather than a pointer.
        Removed many unused function and data members.

        * platform/cocoa/ThemeCocoa.h: Tightened up implementation, removing
        unnecessary members and making overrides private.
        * platform/cocoa/ThemeCocoa.mm: Moved include in here.

        * platform/gamepad/glib/GamepadsGlib.cpp:
        (WebCore::sampleGamepads): Use NeverDestroyed instead of
        DEPRECATED_DEFINE_STATIC_LOCAL.

        * platform/graphics/FontCascade.cpp:
        (WebCore::useBackslashAsYenSignForFamily): Build the set in a cleaner
        way and use a NeverDestroyed set instead of a heap-allocated one.
        (WebCore::FontCascade::FontCascade): Moved initialization of data members
        to the class definition.

        * platform/graphics/FontCascade.h: Initialize GlyphOverflow and
        FonstCascade data members in the class definition. Remove the constructor
        for GlyphOverflow entirely. Added FIXME about the peculiar != operator we
        defined for GlyphOverflow.

        * platform/graphics/NamedImageGeneratedImage.cpp:
        (WebCore::NamedImageGeneratedImage::draw): Use Theme::singleton() instead
        of platformTheme().
        (WebCore::NamedImageGeneratedImage::drawPattern): Ditto.

        * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
        (WebCore::CMTimeRangeStartKey): Use CFSTR directly instead of using
        DEPRECATED_DEFINE_STATIC_LOCAL.
        (WebCore::CMTimeRangeDurationKey): Ditto.
        (WebCore::CACFContextNeedsFlushNotification): Ditto.

        * platform/graphics/ca/win/LayerChangesFlusher.cpp:
        (WebCore::LayerChangesFlusher::singleton): Use NeverDestroyed instead of
        DEPRECATED_DEFINE_STATIC_LOCAL.
        * platform/graphics/ca/win/LayerChangesFlusher.h: Ditto.

        * platform/graphics/cg/ImageSourceCGWin.cpp:
        (WebCore::preferredExtensionForImageSourceType): Use HashMap constructor
        instead of writing out a lot of add calls.

        * platform/graphics/harfbuzz/HarfBuzzFace.cpp:
        (WebCore::harfBuzzFaceCache): Use NeverDestroyed instead of
        DEPRECATED_DEFINE_STATIC_LOCAL.
        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::FontCache::lastResortFallbackFont): Ditto.

        * platform/ios/ThemeIOS.h: Tightened up implementation, removing
        unnecessary members and making overrides private.
        * platform/ios/ThemeIOS.mm:
        (WebCore::Theme::singleton): Renamed from platformTheme.

        * platform/mac/ThemeMac.h: Tightened up implementation, removing
        unnecessary members and making overrides private. Removed unneeded
        WTF_MAKE_FAST_ALLOCATED since this is never allocated on the heap.
        Removed unused -[NSFont webCoreFamilyName] method.
        * platform/mac/ThemeMac.mm:
        (-[NSFont webCoreFamilyName]): Deleted.
        (WebCore::Theme::singleton): Renamed from platformTheme.

        * platform/mediastream/mac/MockRealtimeAudioSourceMac.h:
        Removed unneeded include of FontCascade.h.
        * platform/mediastream/mac/MockRealtimeVideoSourceMac.h:
        Ditto.
        * platform/mock/MockRealtimeAudioSource.h: Ditto.

        * platform/network/win/DownloadBundleWin.cpp:
        (WebCore::DownloadBundle::fileExtension): Use NeverDestroyed
        instead of DEPRECATED_DEFINE_STATIC_LOCAL.

        * platform/win/ClipboardUtilitiesWin.cpp:
        (WebCore::replaceNewlinesWithWindowsStyleNewlines): Use
        appendLiteral instead of DEPRECATED_DEFINE_STATIC_LOCAL.

        * platform/win/FileSystemWin.cpp:
        (WebCore::bundleName): Use NeverDestroyed instead of
        DEPRECATED_DEFINE_STATIC_LOCAL, and used a lambda to initialize
        rather than a boolean to control one-time code.
        (WebCore::storageDirectory): Removed unneeded use of
        DEPRECATED_DEFINE_STATIC_LOCAL for a prefix we are appending to
        a String. The + operator can handle a literal just as efficiently
        without first storing it in a String.

        * platform/wpe/ThemeWPE.cpp:
        (WebCore::Theme::singleton): Renamed from platformTheme.
        * platform/wpe/ThemeWPE.h: Tightened up implementation, removing
        unnecessary members and making overrides private.

        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::RenderTheme): No need to initialize m_theme.
        (WebCore::RenderTheme::adjustStyle): Use Theme::singleton() instead
        of accessing it through m_theme.
        (WebCore::RenderTheme::paint): Ditto.
        (WebCore::RenderTheme::baselinePosition): Ditto.
        (WebCore::RenderTheme::adjustRepaintRect): Ditto.
        (WebCore::RenderTheme::setCustomFocusRingColor): Ditto.
        (WebCore::RenderTheme::platformTapHighlightColor): Ditto.

        * rendering/RenderTheme.h: Removed unneded m_theme and unneeded
        inclusion of Theme.h.

        * rendering/line/LineBreaker.h: Removed unneeded include of
        FontCascade.h.

2017-07-24  Chris Dumez  <cdumez@apple.com>

        ExceptionCode enumeration should use modern exception names
        https://bugs.webkit.org/show_bug.cgi?id=174794

        Reviewed by Geoffrey Garen.

        ExceptionCode enumeration should use modern exception names consistently.
        This makes the code nicer and closer to the text of the specification.

2017-07-24  Andy Estes  <aestes@apple.com>

        Consider implementing W3C Payment Request API
        https://bugs.webkit.org/show_bug.cgi?id=174796

        Reviewed by Daniel Bates.

        Add Payment Request to features.json as "Under Consideration".

        * features.json:

2017-07-24  Konstantin Tokarev  <annulen@yandex.ru>

        Unreviewed attempt to fix Mac cmake build

        * PlatformMac.cmake:

2017-07-24  Chris Dumez  <cdumez@apple.com>

        Make ExceptionCode a proper enumeration
        https://bugs.webkit.org/show_bug.cgi?id=174771

        Reviewed by Sam Weinig.

        Make ExceptionCode a proper enumeration instead of a typedef to uint8_t.

        * Modules/fetch/FetchBody.h:
        (WebCore::FetchBody::formData):
        * Modules/indexeddb/shared/IDBError.h:
        (WebCore::IDBError::encode):
        (WebCore::IDBError::decode):
        * bindings/js/JSSubtleCryptoCustom.cpp:
        (WebCore::rejectWithException):
        * dom/Exception.h:
        * dom/ExceptionCode.h:
        * fileapi/FileReaderSync.cpp:
        (WebCore::errorCodeToExceptionCode):
        * html/canvas/WebGLRenderingContextBase.cpp:
        (WebCore::WebGLRenderingContextBase::texSubImage2D):
        (WebCore::WebGLRenderingContextBase::texImage2D):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::createRequest):
        * xml/XMLHttpRequest.h:

2017-07-24  Simon Fraser  <simon.fraser@apple.com>

        Change "client" coordinates back to match scrolling coordinates
        https://bugs.webkit.org/show_bug.cgi?id=174734
        rdar://problem/33336930

        Reviewed by Tim Horton.

        Baidu.com (which uses jQuery), and various iOS apps make the assumption that getBoundingClientRect() returns a rectangle
        that can be used to set or compare with the scroll position. With visual viewports, that assumption is no longer valid
        when the page is zoomed, or when the keyboard has caused the visual viewport to detach from the layout viewport.

        At this point the compatibility cost of shipping layout viewport-based client rects seems higher than the gain, so revert
        to the shipping behavior. This reverts r216803, and will re-introduce bugs that occurred on zoomed pages on macOS,
        many of which are noted in webkit.org/b/170981.

        * page/FrameView.cpp:
        (WebCore::FrameView::documentToClientOffset):

2017-07-24  Zan Dobersek  <zdobersek@igalia.com>

        [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
        https://bugs.webkit.org/show_bug.cgi?id=174780

        Reviewed by Carlos Garcia Campos.

        Newer versions of libepoxy provide EGL definitions that already use the EGL_CAST macro.
        We'd like to compile on systems where the eglplatform.h header doesn't yet provide
        that macro that was added only recently (e.g. it's available in Mesa 17.1, but not
        before).

        To address that, the EpoxyEGL.h header is added that first includes the libepoxy's EGL
        header and then provides the EGL_CAST definition in case the eglplatform.h header doesn't.
        This header should be included in place of <epoxy/egl.h> (which is included in this new
        header).

        The EpoxyEGL.h and EpoxyShims.h headers are also moved under the platform/graphics/epoxy/
        directory, with the new directory added to the list of inclusion paths for WPE.

        * PlatformWPE.cmake:
        * platform/graphics/PlatformDisplay.cpp:
        * platform/graphics/cairo/CairoUtilities.cpp:
        * platform/graphics/cairo/ImageBufferCairo.cpp:
        * platform/graphics/egl/GLContextEGL.cpp:
        * platform/graphics/egl/GLContextEGLWPE.cpp:
        * platform/graphics/epoxy/EpoxyEGL.h: Added.
        * platform/graphics/epoxy/EpoxyShims.h: Renamed from Source/WebCore/platform/graphics/EpoxyShims.h.
        * platform/graphics/opengl/Extensions3DOpenGLES.cpp:
        * platform/graphics/wpe/PlatformDisplayWPE.cpp:

2017-07-24  Zan Dobersek  <zdobersek@igalia.com>

        [CoordinatedGraphics] Remove unused GLDefs.h header
        https://bugs.webkit.org/show_bug.cgi?id=174712

        Reviewed by Michael Catanzaro.

        * platform/graphics/opengl/GLDefs.h: Remove this unused header.
        As far as my recollection goes it was used in the IPC-based
        CoordinatedGraphics subsystem, which has been removed already.

2017-07-11  Frederic Wang  <fwang@igalia.com>

        Add attribute allow-top-navigation-by-user-activation to iframe sandbox
        https://bugs.webkit.org/show_bug.cgi?id=171327

        Reviewed by Chris Dumez.

        Tests: http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-1.html
               http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-2.html
               imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_top_navigation_by_user_activation_without_user_gesture-expected.txt
               imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_top_navigation-3-expected.txt

        * dom/Document.cpp:
        (WebCore::Document::canNavigate): Case 2 of conformance verification is refined to match the
        current specification: Top navigation is allowed when it is triggered by user activation and
        when allow-top-navigation-by-user-activation is set. Because we have additional "security
        origin" rules with respect to the specification we also add some early return to ensure that
        navigation is really allowed for this new case.
        * dom/SecurityContext.cpp:
        (WebCore::SecurityContext::isSupportedSandboxPolicy): Add allow-top-navigation-by-user-activation flag.
        (WebCore::SecurityContext::parseSandboxPolicy): Parse the new flag to allow top user
        navigation by user activation. Also, make sure that allow-top-navigation allows such
        navigation as defined by the specification.
        * dom/SecurityContext.h: Declare new sandboxing flag.

2017-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>

        [iOS WK2] 5 DataInteractionTests are failing: observed selection rects after dropping don't match expected values
        https://bugs.webkit.org/show_bug.cgi?id=174769
        <rdar://problem/33478864>

        Reviewed by Tim Horton.

        These tests began failing after r219541, due to a change in behavior of whether or not we call
        setIgnoreSelectionChanges(false, RevealSelection::No) or setIgnoreSelectionChanges(false, RevealSelection::Yes)
        when performing a text editing drop.

        Before r219541, we would not reveal the selection when performing an edit drag operation. This is because in
        WebPage::performDragControllerAction, we would begin ignoring selection changes by calling
        setIgnoreSelectionChanges(true). However, while taking a text indicator snapshot, we would stop ignoring
        selection in TextIndicator::createWithRange due to us calling setIgnoreSelectionChanges(false,
        RevealSelection::No) at the end of the function. Then, when we return to the scope of
        WebPage::performDragControllerAction and try to setIgnoreSelectionChanges(false), this is a no-op because we've
        already stopped ignoring selection changes.

        After r219541, switching to using TemporarySelectionChange means that TextIndicator::createWithRange now means
        we respect whether or not we were already ignoring selection before taking the snapshot, so we won't always
        setIgnoreSelectionChanges(false) at the end. This means that selection changes will now be correctly ignored
        when performing a drag operation, but this also means that we'll try to reveal the selection, since
        WebPage::performDragControllerAction calls setIgnoreSelectionChanges(false), for which RevealSelection::Yes
        is used by default.

        Revealing the selection in WebPage::performDragControllerAction was unintended in the first place, so we should
        revert to calling setIgnoreSelectionChanges(false, RevealSelection::No). To ensure this, we adopt
        TemporarySelectionChange here and pass only TemporarySelectionOptionIgnoreSelectionChanges, so that we won't
        additionally try to reveal selection after the drop. This is consistent with behavior prior to macOS 10.13 and
        iOS 11. Additionally, this patch also moves the call to ignore selection change from WebKit into WebCore, so
        that whether we ignore selection is consistent across both WebKit1 and WebKit2.

        * page/DragController.cpp:
        (WebCore::DragController::performDragOperation):

2017-07-23  Chris Dumez  <cdumez@apple.com>

        Drop ExceptionCodeDescription class
        https://bugs.webkit.org/show_bug.cgi?id=174757

        Reviewed by Darin Adler.

        Drop ExceptionCodeDescription class now that there is only one exception
        type: DOMException. Instead, we now have static methods on DOMException
        to get the name / message for a given exception code.

        * CMakeLists.txt:
        * Modules/indexeddb/shared/IDBError.cpp:
        (WebCore::IDBError::name):
        (WebCore::IDBError::message):
        * Modules/quota/StorageErrorCallback.cpp:
        (WebCore::StorageErrorCallback::CallbackTask::CallbackTask):
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMExceptionHandling.cpp:
        (WebCore::createDOMException):
        * dom/DOMAllInOne.cpp:
        * dom/DOMException.cpp:
        (WebCore::errorCodeFromName):
        (WebCore::DOMException::create):
        (WebCore::DOMException::DOMException):
        (WebCore::DOMException::name):
        (WebCore::DOMException::message):
        * dom/DOMException.h:
        * dom/ExceptionCodeDescription.cpp: Removed.
        * dom/ExceptionCodeDescription.h: Removed.
        * inspector/DOMEditor.cpp:
        (WebCore::populateErrorString):
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::toErrorString):
        * inspector/InspectorDOMStorageAgent.cpp:
        (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):

2017-07-22  Dan Bernstein  <mitz@apple.com>

        Fixed building for macOS 10.12 with the macOS 10.13 SDK after r219644.

        * platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
        (WebCore::CDMSessionAVStreamSession::update): Suppress the objc-literal-conversion warning
          in one place where we are calling a class method on a Class and the compiler can’t tell
          which class it is, so it chooses wrong and emits a warning.

2017-07-22  Chris Dumez  <cdumez@apple.com>

        Merge ExceptionBase into DOMException and drop custom toString
        https://bugs.webkit.org/show_bug.cgi?id=174755

        Reviewed by Sam Weinig.

        Merge ExceptionBase into DOMException and drop custom toString, now that DOMException
        is the only remaining exception type.

        * CMakeLists.txt:
        * Modules/mediastream/MediaStream.h:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMExceptionHandling.cpp:
        (WebCore::retrieveErrorMessage):
        * dom/DOMAllInOne.cpp:
        * dom/DOMException.cpp:
        (WebCore::DOMException::DOMException):
        (WebCore::DOMException::initializeDescription):
        * dom/DOMException.h:
        (WebCore::DOMException::code):
        (WebCore::DOMException::name):
        (WebCore::DOMException::message):
        * dom/ExceptionBase.cpp: Removed.
        * dom/ExceptionBase.h: Removed.

2017-07-14  Filip Pizlo  <fpizlo@apple.com>

        It should be easy to decide how WebKit yields
        https://bugs.webkit.org/show_bug.cgi?id=174298

        Reviewed by Saam Barati.

        No new tests because the WebCore change is just a change to how we #include things.

        * inspector/InspectorPageAgent.h:
        * inspector/TimelineRecordFactory.h:
        * workers/Worker.h:
        * workers/WorkerGlobalScopeProxy.h:
        * workers/WorkerMessagingProxy.h:

2017-07-22  Said Abou-Hallawa  <sabouhallawa@apple.com>

        REGRESSION(r219045): A partially loaded image may not be repainted when its complete frame finishes decoding
        https://bugs.webkit.org/show_bug.cgi?id=174230

        Reviewed by Simon Fraser.

        Because of r219045, we now only repaint the CachedImageClinets which tried
        to draw the image but they could not because they have to wait for the image
        decoding to finish. This was done by keeping a HashSet of these clients 
        and make CachedImage own it. This HashSet is cleared once the image frame
        finishes decoding and all the waited clients are repainted.

        But Multiple asynchronous image decoding requests are allowed for the same
        frame if new data is added to the image source. If we tried to draw the 
        same image twice before it finishes decoding the first request, we will
        not be to record this second request since the HashSet will not add the
        same client twice. When he second request finishes decoding, CachedImage
        will not repaint any client since its HashSet is empty.

        To fix this problem we can do the following. When an image frame finishes
        decoding, CachedImage will keep its HashSet of pending drawing clients as
        long as the image frame is a partially loaded frame.

        * loader/cache/CachedImage.cpp:
        (WebCore::CachedImage::CachedImageObserver::imageFrameAvailable):
        (WebCore::CachedImage::imageFrameAvailable):
        * loader/cache/CachedImage.h:
        * platform/graphics/BitmapImage.cpp:
        (WebCore::BitmapImage::destroyDecodedData):
        (WebCore::BitmapImage::dataChanged):
        (WebCore::BitmapImage::setCurrentFrameDecodingStatusIfNecessary):
        (WebCore::BitmapImage::draw):
        (WebCore::BitmapImage::internalStartAnimation):
        (WebCore::BitmapImage::internalAdvanceAnimation):
        (WebCore::BitmapImage::imageFrameAvailableAtIndex):
        * platform/graphics/BitmapImage.h:
        * platform/graphics/ImageFrame.cpp:
        (WebCore::ImageFrame::decodingStatus):
        * platform/graphics/ImageFrame.h: Move DecodingStatus out of this class
        to ImageTypes.h to avoid adding other header files to ImageObvsever.h
        * platform/graphics/ImageFrameCache.cpp:
        (WebCore::ImageFrameCache::setNativeImage):
        (WebCore::ImageFrameCache::cacheMetadataAtIndex):
        (WebCore::ImageFrameCache::cacheNativeImageAtIndex):
        (WebCore::ImageFrameCache::cacheNativeImageAtIndexAsync):
        (WebCore::ImageFrameCache::requestFrameAsyncDecodingAtIndex):
        (WebCore::ImageFrameCache::frameDecodingStatusAtIndex):
        * platform/graphics/ImageFrameCache.h:
        * platform/graphics/ImageObserver.h:
        * platform/graphics/ImageSource.h:
        (WebCore::ImageSource::frameDecodingStatusAtIndex):
        * platform/graphics/ImageTypes.h:
        * platform/image-decoders/bmp/BMPImageReader.cpp:
        (WebCore::BMPImageReader::decodeBMP):
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoder::frameComplete):
        (WebCore::GIFImageDecoder::initFrameBuffer):
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        (WebCore::JPEGImageDecoder::outputScanlines):
        (WebCore::JPEGImageDecoder::jpegComplete):
        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageDecoder::rowAvailable):
        (WebCore::PNGImageDecoder::pngComplete):
        (WebCore::PNGImageDecoder::frameComplete):
        * platform/image-decoders/webp/WEBPImageDecoder.cpp:
        (WebCore::WEBPImageDecoder::decode):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::decodingModeForImageDraw):

2017-07-22  Timothy Horton  <timothy_horton@apple.com>

        Drag and Drop preview image for Twitter link is the wrong shape
        ​https://bugs.webkit.org/show_bug.cgi?id=174731
        <rdar://problem/33335616>

        * dom/Range.cpp:
        (WebCore::Range::absoluteRectsForRangeInText):
        * page/TextIndicator.cpp:
        (WebCore::initializeIndicator):
        Apply some post-landing review feedback for r219756.

2017-07-21  Chris Dumez  <cdumez@apple.com>

        Drop IDBDatabaseException class
        https://bugs.webkit.org/show_bug.cgi?id=174743

        Reviewed by Darin Adler.

        Drop IDBDatabaseException class and use DOMException directly. IDBDatabaseException was
        only an internal concept and was already exposed to the Web as a DOMException. This
        simplifies the code a bit and will allow for further simplification in a follow-up patch.

        No new tests, no Web-facing behavior change, except for some exception messages
        being slightly different.

        * CMakeLists.txt:
        * Modules/indexeddb/IDBCursor.cpp:
        (WebCore::IDBCursor::update):
        (WebCore::IDBCursor::advance):
        (WebCore::IDBCursor::continuePrimaryKey):
        (WebCore::IDBCursor::continueFunction):
        (WebCore::IDBCursor::deleteFunction):
        * Modules/indexeddb/IDBDatabase.cpp:
        (WebCore::IDBDatabase::createObjectStore):
        (WebCore::IDBDatabase::transaction):
        (WebCore::IDBDatabase::deleteObjectStore):
        * Modules/indexeddb/IDBDatabaseError.h: Removed.
        * Modules/indexeddb/IDBDatabaseException.cpp: Removed.
        * Modules/indexeddb/IDBDatabaseException.h: Removed.
        * Modules/indexeddb/IDBFactory.cpp:
        (WebCore::IDBFactory::cmp):
        * Modules/indexeddb/IDBIndex.cpp:
        (WebCore::IDBIndex::setName):
        (WebCore::IDBIndex::openCursor):
        (WebCore::IDBIndex::openKeyCursor):
        (WebCore::IDBIndex::count):
        (WebCore::IDBIndex::doCount):
        (WebCore::IDBIndex::get):
        (WebCore::IDBIndex::doGet):
        (WebCore::IDBIndex::getKey):
        (WebCore::IDBIndex::doGetKey):
        (WebCore::IDBIndex::getAll):
        (WebCore::IDBIndex::getAllKeys):
        * Modules/indexeddb/IDBKeyRange.cpp:
        (WebCore::IDBKeyRange::only):
        (WebCore::IDBKeyRange::lowerBound):
        (WebCore::IDBKeyRange::upperBound):
        (WebCore::IDBKeyRange::bound):
        (WebCore::IDBKeyRange::includes):
        * Modules/indexeddb/IDBObjectStore.cpp:
        (WebCore::IDBObjectStore::setName):
        (WebCore::IDBObjectStore::openCursor):
        (WebCore::IDBObjectStore::openKeyCursor):
        (WebCore::IDBObjectStore::get):
        (WebCore::IDBObjectStore::getKey):
        (WebCore::IDBObjectStore::putOrAdd):
        (WebCore::IDBObjectStore::doDelete):
        (WebCore::IDBObjectStore::deleteFunction):
        (WebCore::IDBObjectStore::clear):
        (WebCore::IDBObjectStore::createIndex):
        (WebCore::IDBObjectStore::index):
        (WebCore::IDBObjectStore::deleteIndex):
        (WebCore::IDBObjectStore::count):
        (WebCore::IDBObjectStore::doCount):
        (WebCore::IDBObjectStore::getAll):
        (WebCore::IDBObjectStore::getAllKeys):
        * Modules/indexeddb/IDBOpenDBRequest.cpp:
        (WebCore::IDBOpenDBRequest::fireErrorAfterVersionChangeCompletion):
        * Modules/indexeddb/IDBRequest.cpp:
        (WebCore::IDBRequest::result):
        (WebCore::IDBRequest::error):
        (WebCore::IDBRequest::uncaughtExceptionInEventHandler):
        * Modules/indexeddb/IDBTransaction.cpp:
        (WebCore::IDBTransaction::objectStore):
        (WebCore::IDBTransaction::abort):
        (WebCore::IDBTransaction::abortOnServerAndCancelRequests):
        (WebCore::IDBTransaction::didCreateIndexOnServer):
        (WebCore::IDBTransaction::putOrAddOnServer):
        * Modules/indexeddb/server/IndexValueStore.cpp:
        (WebCore::IDBServer::IndexValueStore::addRecord):
        * Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
        (WebCore::IDBServer::MemoryIDBBackingStore::beginTransaction):
        (WebCore::IDBServer::MemoryIDBBackingStore::abortTransaction):
        (WebCore::IDBServer::MemoryIDBBackingStore::commitTransaction):
        (WebCore::IDBServer::MemoryIDBBackingStore::createObjectStore):
        (WebCore::IDBServer::MemoryIDBBackingStore::deleteObjectStore):
        (WebCore::IDBServer::MemoryIDBBackingStore::renameObjectStore):
        (WebCore::IDBServer::MemoryIDBBackingStore::clearObjectStore):
        (WebCore::IDBServer::MemoryIDBBackingStore::createIndex):
        (WebCore::IDBServer::MemoryIDBBackingStore::deleteIndex):
        (WebCore::IDBServer::MemoryIDBBackingStore::renameIndex):
        (WebCore::IDBServer::MemoryIDBBackingStore::deleteRange):
        (WebCore::IDBServer::MemoryIDBBackingStore::addRecord):
        (WebCore::IDBServer::MemoryIDBBackingStore::getRecord):
        (WebCore::IDBServer::MemoryIDBBackingStore::getAllRecords):
        (WebCore::IDBServer::MemoryIDBBackingStore::getIndexRecord):
        (WebCore::IDBServer::MemoryIDBBackingStore::getCount):
        (WebCore::IDBServer::MemoryIDBBackingStore::generateKeyNumber):
        (WebCore::IDBServer::MemoryIDBBackingStore::openCursor):
        (WebCore::IDBServer::MemoryIDBBackingStore::iterateCursor):
        * Modules/indexeddb/server/MemoryIndex.cpp:
        (WebCore::IDBServer::MemoryIndex::putIndexKey):
        * Modules/indexeddb/server/MemoryObjectStore.cpp:
        (WebCore::IDBServer::MemoryObjectStore::createIndex):
        (WebCore::IDBServer::MemoryObjectStore::deleteIndex):
        * Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
        (WebCore::IDBServer::SQLiteIDBBackingStore::getOrEstablishDatabaseInfo):
        (WebCore::IDBServer::SQLiteIDBBackingStore::beginTransaction):
        (WebCore::IDBServer::SQLiteIDBBackingStore::abortTransaction):
        (WebCore::IDBServer::SQLiteIDBBackingStore::commitTransaction):
        (WebCore::IDBServer::SQLiteIDBBackingStore::createObjectStore):
        (WebCore::IDBServer::SQLiteIDBBackingStore::deleteObjectStore):
        (WebCore::IDBServer::SQLiteIDBBackingStore::renameObjectStore):
        (WebCore::IDBServer::SQLiteIDBBackingStore::clearObjectStore):
        (WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
        (WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedHasIndexRecord):
        (WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexKey):
        (WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexRecord):
        (WebCore::IDBServer::SQLiteIDBBackingStore::deleteIndex):
        (WebCore::IDBServer::SQLiteIDBBackingStore::renameIndex):
        (WebCore::IDBServer::SQLiteIDBBackingStore::keyExistsInObjectStore):
        (WebCore::IDBServer::SQLiteIDBBackingStore::deleteUnusedBlobFileRecords):
        (WebCore::IDBServer::SQLiteIDBBackingStore::deleteRecord):
        (WebCore::IDBServer::SQLiteIDBBackingStore::deleteRange):
        (WebCore::IDBServer::SQLiteIDBBackingStore::updateAllIndexesForAddRecord):
        (WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
        (WebCore::IDBServer::SQLiteIDBBackingStore::getBlobRecordsForObjectStoreRecord):
        (WebCore::IDBServer::SQLiteIDBBackingStore::getRecord):
        (WebCore::IDBServer::SQLiteIDBBackingStore::getAllObjectStoreRecords):
        (WebCore::IDBServer::SQLiteIDBBackingStore::getAllIndexRecords):
        (WebCore::IDBServer::SQLiteIDBBackingStore::getIndexRecord):
        (WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetIndexRecordForOneKey):
        (WebCore::IDBServer::SQLiteIDBBackingStore::getCount):
        (WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetKeyGeneratorValue):
        (WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedSetKeyGeneratorValue):
        (WebCore::IDBServer::SQLiteIDBBackingStore::generateKeyNumber):
        (WebCore::IDBServer::SQLiteIDBBackingStore::revertGeneratedKeyNumber):
        (WebCore::IDBServer::SQLiteIDBBackingStore::maybeUpdateKeyGeneratorNumber):
        (WebCore::IDBServer::SQLiteIDBBackingStore::openCursor):
        (WebCore::IDBServer::SQLiteIDBBackingStore::iterateCursor):
        * Modules/indexeddb/server/SQLiteIDBTransaction.cpp:
        (WebCore::IDBServer::SQLiteIDBTransaction::begin):
        (WebCore::IDBServer::SQLiteIDBTransaction::commit):
        (WebCore::IDBServer::SQLiteIDBTransaction::abort):
        * Modules/indexeddb/server/UniqueIDBDatabase.cpp:
        (WebCore::IDBServer::UniqueIDBDatabase::performCurrentOpenOperation):
        (WebCore::IDBServer::UniqueIDBDatabase::deleteObjectStore):
        (WebCore::IDBServer::UniqueIDBDatabase::renameObjectStore):
        (WebCore::IDBServer::UniqueIDBDatabase::deleteIndex):
        (WebCore::IDBServer::UniqueIDBDatabase::renameIndex):
        (WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd):
        (WebCore::IDBServer::UniqueIDBDatabase::commitTransaction):
        (WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):
        * Modules/indexeddb/shared/IDBError.cpp:
        (WebCore::IDBError::name):
        (WebCore::IDBError::message):
        (WebCore::IDBError::toDOMError):
        * Modules/indexeddb/shared/IDBError.h:
        (WebCore::IDBError::userDeleteError):
        (WebCore::IDBError::isNull):
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMExceptionHandling.cpp:
        (WebCore::createDOMException):

        * dom/DOMException.cpp:
        (WebCore::DOMException::initializeDescription):
        Initialize description->code from using the actual error codes in the
        coreExceptions table, instead of initializing it using |ec|. |ec| is
        the index in the ExceptionCode enumeration and it matches the error
        code only for legacy exceptions. New exceptions such as DataError
        should have a code of 0. Without this change, w3c for IDB would start
        failing.

        * dom/ExceptionCodeDescription.cpp:
        (WebCore::ExceptionCodeDescription::ExceptionCodeDescription):
        * dom/ExceptionCodeDescription.h:

2017-07-21  Sam Weinig  <sam@webkit.org>

        [WebIDL] Simplify XMLHttpRequest bindings by removing built-ins
        https://bugs.webkit.org/show_bug.cgi?id=174740

        Reviewed by Chris Dumez.

        The behavior we were getting from XMLHttpRequest.js can be implemented
        with the [CachedAttribute] extended attribute. This reduces the number
        of JS -> C++ jumps required and makes the code more similar to other
        bindings that need caching of an IDL any value.

        * CMakeLists.txt:
        * DerivedSources.make:
        * xml/XMLHttpRequest.js: Removed.
        Remove XMLHttpRequest.js.

        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::response):
        (WebCore::JSXMLHttpRequest::retrieveResponse): Deleted.
        * xml/XMLHttpRequest.idl:
        Replace builtin with a [CachedAttribute] and [CustomGetter]
        for the response property.

2017-07-21  Timothy Horton  <timothy_horton@apple.com>

        Drag and Drop preview image for Twitter link is the wrong shape
        https://bugs.webkit.org/show_bug.cgi?id=174731
        <rdar://problem/33335616>

        Reviewed by Zalan Bujtas.

        TextIndicator uses Range::borderAndTextQuads and ::absoluteTextRects
        in order to get the rects of the indicated text. Currently, these
        functions do not respect clipping, so clipped-out text (e.g. as seen
        inside links on Twitter) generates lots of meaningless indicated rects.

        * page/TextIndicator.cpp:
        (WebCore::estimatedBackgroundColorForRange):
        (WebCore::hasAnyIllegibleColors):
        Change adjustTextIndicatorDataOptionsForEstimatedColorsIfNecessary
        to instead be hasAnyIllegibleColors, and referred to in the same place
        as hasNonInlineOrReplacedElements, so that it follows the same
        upgrade path (leaving textRects empty, so that it is later filled in
        with the absoluteBoundingRect). This was a mistake in r219033, which
        instead would end up painting all content, but filling in textRects
        with the actual individual text rects.

        This alone changes the behavior on Twitter from lots of jagged misplaced
        rects to a too-large bounding rect. Combined with the following changes,
        the bounding rect is reduced to the right size:

        (WebCore::initializeIndicator):
        Adopt the new Range::borderAndTextQuads and ::absoluteTextRects parameter
        and opt-in to respecting clipping for text rects.

        * dom/DOMRectList.cpp:
        (WebCore::DOMRectList::DOMRectList):
        * dom/DOMRectList.h:
        (WebCore::DOMRectList::create):
        Add a DOMRectList constructor and create() that take FloatRects, similar
        to the one that takes FloatQuads, but without the boundingRect() calls.

        * dom/Document.h:
        * dom/Document.cpp:
        (WebCore::Document::convertAbsoluteToClientRects):
        Add convertAbsoluteToClientRects, similar to covertAbsoluteToClientQuads,
        except acting on rects instead of quads.

        * dom/Range.cpp:
        (WebCore::Range::absoluteRectsForRangeInText):
        (WebCore::Range::absoluteTextRects):
        (WebCore::Range::getClientRects):
        (WebCore::Range::borderAndTextRects):
        (WebCore::Range::boundingRect):
        (WebCore::Range::absoluteBoundingRect):
        (WebCore::Range::borderAndTextQuads): Deleted.
        * dom/Range.h:
        Replace borderAndTextQuads with borderAndTextRects, because all callers
        just ended up calling boundingBox() on the quads.

        Factor absoluteRectsForRangeInText out of absoluteTextRects and
        borderAndTextQuads, and teach it to optionally intersect the text rects
        with their renderer's absoluteClippedOverflowRect.

2017-07-21  Per Arne Vollan  <pvollan@apple.com>

        Round-tripping stroke-width styles through getComputedStyle cause the text to gain a stroke.
        https://bugs.webkit.org/show_bug.cgi?id=174701
        <rdar://problem/32903679>

        Reviewed by Simon Fraser.

        The initial value of stroke-color should be transparent, see https://www.w3.org/TR/fill-stroke-3/#stroke-color.
        Also, there is no need to set the graphics context in text stroke mode, if the stroke color is not visible.

        Test: fast/css/round-trip-stroke-width-using-computed-style.html

        * rendering/TextPaintStyle.cpp:
        (WebCore::updateGraphicsContext):
        * rendering/style/RenderStyle.h:
        (WebCore::RenderStyle::initialStrokeWidth):
        (WebCore::RenderStyle::initialStrokeColor):
        * rendering/style/StyleRareInheritedData.cpp:
        (WebCore::StyleRareInheritedData::StyleRareInheritedData):

2017-07-21  Timothy Horton  <timothy_horton@apple.com>

        Remove an inaccurate comment from RenderTextLineBoxes

        * rendering/RenderTextLineBoxes.cpp:
        (WebCore::RenderTextLineBoxes::absoluteRectsForRange):
        This comment has been wrong for at least 4 years.

2017-07-21  Timothy Horton  <timothy_horton@apple.com>

        TextIndicator::estimatedTextColorsForRange asserts inside HashSet code (inserting reserved value)
        https://bugs.webkit.org/show_bug.cgi?id=174733

        Reviewed by Wenson Hsieh.

        * page/TextIndicator.cpp:
        (WebCore::estimatedTextColorsForRange):
        (WebCore::adjustTextIndicatorDataOptionsForEstimatedColorsIfNecessary):
        RGBA32 isn't a valid hash key, because we have no traits that define the
        empty or deleted values, nor do we have any bits we could feasibly
        use -- the full range of RGBA32 is easy to reach with various colors.

        Instead, hash Color directly.

2017-07-21  Nan Wang  <n_wang@apple.com>

        AX: Expose form validation on iOS as hint
        https://bugs.webkit.org/show_bug.cgi?id=174722
        <rdar://problem/33459761>

        Reviewed by Chris Fleizach.

        Adding the validation message to the hint of the form control element.

        Test: accessibility/ios-simulator/form-control-validation-message.html

        * accessibility/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::isShowingValidationMessage):
        (WebCore::AccessibilityObject::validationMessage):
        * accessibility/AccessibilityObject.h:
        * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
        (-[WebAccessibilityObjectWrapper accessibilityHint]):
        (-[WebAccessibilityObjectWrapper accessibilityIsShowingValidationMessage]):
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::isShowingValidationMessage):
        * html/HTMLFormControlElement.h:

2017-07-21  Konstantin Tokarev  <annulen@yandex.ru>

        [cmake][Mac] Unreviewed, fix linking WebKitSystemInterface

        After r219560 link_directories() in PlatformXXX.cmake files does not
        affect corresponding targets.

        * PlatformMac.cmake:

2017-07-21  Sam Weinig  <sam@webkit.org>

        [WebIDL] Remove the need for the side map of DeprecatedCSSOMValue roots
        https://bugs.webkit.org/show_bug.cgi?id=174713

        Reviewed by Andreas Kling.

        We used to not want to bloat the size of CSSValues with a pointer to the
        owner CSSStyleDeclaration, so, for GC purposes we need kept a mapping of
        them on DOMWrapperWorld that only got set if a wrapper was made. Now that
        we have DeprecatedCSSOMValue, a wrapper for CSSValue that only gets created
        for the bindings, we no longer need the side table, and simply have the
        DeprecatedCSSOMValue maintain a reference to the CSSStyleDeclaration.

        * bindings/js/DOMWrapperWorld.h:
        (WebCore::DOMWrapperWorld::wrappers):
        Remove m_deprecatedCSSOMValueRoots and make m_wrappers private with a getter.

        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue): Deleted.
        Remove custom implementation of getPropertyCSSValue, now that it no longer
        needs to update m_deprecatedCSSOMValueRoots.

        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::fireFrameClearedWatchpointsForWindow):
        * bindings/js/JSDOMWrapperCache.h:
        (WebCore::getCachedWrapper):
        (WebCore::cacheWrapper):
        (WebCore::uncacheWrapper):
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::getOutOfLineCachedWrapper):
        Use wrappers getter rather than direct member variable.

        * bindings/js/JSDeprecatedCSSOMValueCustom.cpp:
        (WebCore::JSDeprecatedCSSOMValueOwner::isReachableFromOpaqueRoots):
        Rather than checking the side table for roots, now get the root
        via the reference CSSStyleDeclaration.

        (WebCore::JSDeprecatedCSSOMValueOwner::finalize): Deleted.
        Remove custom finalize now that we don't have to remove ourself
        from m_deprecatedCSSOMValueRoots.

        * css/CSSStyleDeclaration.idl:
        Remove [Custom] from getPropertyCSSValue.

        * css/DeprecatedCSSOMValue.idl:
        Remove [JSCustomFinalize].

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSImageValue.cpp:
        (WebCore::CSSImageValue::createDeprecatedCSSOMWrapper):
        * css/CSSImageValue.h:
        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::createDeprecatedCSSOMPrimitiveWrapper):
        * css/CSSPrimitiveValue.h:
        * css/CSSStyleDeclaration.h:
        * css/CSSValue.cpp:
        (WebCore::CSSValue::createDeprecatedCSSOMWrapper):
        * css/CSSValue.h:
        * css/DeprecatedCSSOMCounter.h:
        * css/DeprecatedCSSOMPrimitiveValue.cpp:
        (WebCore::DeprecatedCSSOMPrimitiveValue::getCounterValue):
        (WebCore::DeprecatedCSSOMPrimitiveValue::getRectValue):
        (WebCore::DeprecatedCSSOMPrimitiveValue::getRGBColorValue):
        * css/DeprecatedCSSOMPrimitiveValue.h:
        (WebCore::DeprecatedCSSOMPrimitiveValue::create):
        (WebCore::DeprecatedCSSOMPrimitiveValue::DeprecatedCSSOMPrimitiveValue):
        * css/DeprecatedCSSOMRGBColor.h:
        * css/DeprecatedCSSOMRect.h:
        * css/DeprecatedCSSOMValue.h:
        (WebCore::DeprecatedCSSOMValue::owner):
        (WebCore::DeprecatedCSSOMValue::DeprecatedCSSOMValue):
        (WebCore::DeprecatedCSSOMComplexValue::create):
        (WebCore::DeprecatedCSSOMComplexValue::DeprecatedCSSOMComplexValue):
        * css/DeprecatedCSSOMValueList.h:
        (WebCore::DeprecatedCSSOMValueList::create):
        (WebCore::DeprecatedCSSOMValueList::DeprecatedCSSOMValueList):
        * css/PropertySetCSSStyleDeclaration.cpp:
        (WebCore::PropertySetCSSStyleDeclaration::wrapForDeprecatedCSSOM):
        * css/PropertySetCSSStyleDeclaration.h:
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::getPresentationAttribute):
        Pass owning CSSStyleDeclaration to DeprecatedCSSOMValue and derived classes.

2017-07-21  Andreas Kling  <akling@apple.com>

        Use more references in event dispatch code
        https://bugs.webkit.org/show_bug.cgi?id=174681

        Reviewed by Geoffrey Garen.

        Make EventListener::handleEvent() take a ScriptExecutionContext&, Event&.
        Then make everything build again. Various null checks and assertions
        disappear in the process.

        * bindings/js/JSErrorHandler.cpp:
        (WebCore::JSErrorHandler::handleEvent):
        * bindings/js/JSErrorHandler.h:
        * bindings/js/JSEventListener.cpp:
        (WebCore::JSEventListener::initializeJSFunction):
        (WebCore::JSEventListener::handleEvent):
        (WebCore::eventHandlerAttribute):
        * bindings/js/JSEventListener.h:
        (WebCore::JSEventListener::jsFunction):
        * bindings/js/JSLazyEventListener.cpp:
        (WebCore::JSLazyEventListener::initializeJSFunction):
        * bindings/js/JSLazyEventListener.h:
        * dom/EventListener.h:
        * dom/EventTarget.cpp:
        (WebCore::EventTarget::fireEventListeners):
        * html/HTMLPlugInElement.cpp:
        (WebCore::HTMLPlugInElement::defaultEventHandler):
        * html/ImageDocument.cpp:
        (WebCore::ImageEventListener::handleEvent):
        * inspector/CommandLineAPIHost.cpp:
        (WebCore::listenerEntriesFromListenerInfo):
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::buildObjectForEventListener):
        * inspector/InspectorIndexedDBAgent.cpp:
        * platform/Widget.h:
        (WebCore::Widget::handleEvent):
        * platform/cocoa/WebPlaybackSessionModelMediaElement.h:
        * platform/cocoa/WebPlaybackSessionModelMediaElement.mm:
        (WebCore::WebPlaybackSessionModelMediaElement::handleEvent):
        * platform/cocoa/WebVideoFullscreenModelVideoElement.h:
        * platform/cocoa/WebVideoFullscreenModelVideoElement.mm:
        (WebVideoFullscreenModelVideoElement::handleEvent):
        * svg/SVGTRefElement.cpp:
        (WebCore::SVGTRefTargetEventListener::handleEvent):
        * svg/animation/SVGSMILElement.cpp:
        (WebCore::ConditionEventListener::handleEvent):
        (WebCore::SVGSMILElement::handleConditionEvent):
        * svg/animation/SVGSMILElement.h:

2017-07-21  Zalan Bujtas  <zalan@apple.com>

        iBooks: Overlapping/missing content at beginning/end of paragraph.
        https://bugs.webkit.org/show_bug.cgi?id=174717
        <rdar://problem/33117912>

        Reviewed by Simon Fraser.

        By definiton simple and normal line layout should always produce the exact same lineboxes. It enables us not
        to force repaint while swapping between these 2 line layouts.
        However in certain cases (font size pixel rounding as an example) they don't agree on how much content fits the line and
        that could result in missing/overlapping content due to the lack of repaint. 

        Unable to test.

        * rendering/RenderBlockFlow.cpp:
        (WebCore::RenderBlockFlow::ensureLineBoxes):

2017-07-21  Chris Dumez  <cdumez@apple.com>

        Drop make_dom_exceptions.pl script that we only have DOMException
        https://bugs.webkit.org/show_bug.cgi?id=174699

        Reviewed by Darin Adler.

        Drop make_dom_exceptions.pl script that we only have DOMException.

        * CMakeLists.txt:
        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreMacros.cmake:
        * bindings/js/JSDOMExceptionHandling.cpp:
        * css/FontFaceSet.cpp:
        * dom/DOMAllInOne.cpp:
        * dom/DOMExceptions.in: Removed.
        * dom/ExceptionCodeDescription.cpp: Added.
        (WebCore::ExceptionCodeDescription::ExceptionCodeDescription):
        * dom/ExceptionCodeDescription.h: Added.
        * dom/make_dom_exceptions.pl: Removed.
        * inspector/WebInjectedScriptHost.cpp:
        (WebCore::WebInjectedScriptHost::subtype):

2017-07-21  Said Abou-Hallawa  <sabouhallawa@apple.com>

        [CG] An image should not invoke many system calls before confirming its format is supported
        https://bugs.webkit.org/show_bug.cgi?id=174692

        Reviewed by Tim Horton.

        We should be careful when invoking system calls before confirming that the
        image type is available and it is one of the whitelist formats. Otherwise
        we will be calling the parsers of the unsupported formats.

        * loader/cache/CachedImage.cpp:
        (WebCore::CachedImage::setImageDataBuffer): The check isAllowedImageUTI()
        is now done in ImageDecoder::encodedDataStatus() which will return Error
        if there is an error in the data or "isAllowedImageUTI() returns false."

        * platform/graphics/BitmapImage.cpp:
        (WebCore::BitmapImage::dataChanged): Avoid calling canUseAsyncDecodingForLargeImages()
        before confirming the image type is available and it's supported by WebKit.
        canUseAsyncDecodingForLargeImages() tries to cache the first frame of the
        image to know its size. Asking the ImageFrameCache to destroy its decoded
        frames is not needed unless ImageFrameCache::decodedSize() is not zero.

        * platform/graphics/cg/ImageDecoderCG.cpp:
        (WebCore::ImageDecoder::encodedDataStatus): Avoid calling CGImageSourceGetStatus()
        before knowing the UTI of the image. When knowing it, we call CGImageSourceGetStatus()
        and if it returns kCGImageStatusIncomplete or kCGImageStatusComplete, we
        check whether isAllowedImageUTI() or not. If isAllowedImageUTI() returns
        false, return Error which will make the CachedImage cancel loading the 
        rest of the image.

2017-07-21  Jeremy Jones  <jeremyj@apple.com>

        AudioTrackPrivateMediaStreamCocoa shouldn't set AudioSession::setPreferredBufferSize
        https://bugs.webkit.org/show_bug.cgi?id=174707
        rdar://problem/33446809

        Reviewed by Eric Carlson.

        Manually tested for audio side effects.

        AudioChannel::copyFrom fails when AudioChannel lengths don't match.

        This happens because PlatformMediaSessionManager::updateSessionState() owns and sets
        AudioSession::setPreferredBufferSize().

        However, AudioTrackPrivateMediaStreamCocoa::createAudioUnit, when it creates an input
        audio unit is setting AudioSession::setPreferredBufferSize() directly to its own arbitrary value.

        AudioSession::setPreferredBufferSize() should be managed by the higher level 
        PlatformMediaSessionManager, and not modified by audio unit creation, in order to keep harmony
        within the audio pipeline.

        * platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp:
        (WebCore::AudioTrackPrivateMediaStreamCocoa::createAudioUnit):

2017-07-21  Jeremy Jones  <jeremyj@apple.com>

        Noise when AudioChannel lengths don't match.
        https://bugs.webkit.org/show_bug.cgi?id=174706
        rdar://problem/33389856

        Reviewed by Eric Carlson.

        When AudioChannel lengths don't match, copyFrom() returns early leaving uninitialized data in the audio buffer.
        This change zeros out the data, so there isn't objectionable noise sent to the speaker.

        * platform/audio/AudioChannel.cpp:
        (WebCore::AudioChannel::copyFrom):

2017-07-21  Sam Weinig  <sam@webkit.org>

        [WebIDL] Make a few parameters non-nullable in inspector IDL files
        https://bugs.webkit.org/show_bug.cgi?id=174719

        Reviewed by Joseph Pecoraro.

        * inspector/CommandLineAPIHost.cpp:
        (WebCore::CommandLineAPIHost::databaseId):
        (WebCore::CommandLineAPIHost::storageId):
        * inspector/CommandLineAPIHost.h:
        * inspector/CommandLineAPIHost.idl:
        * inspector/InspectorDOMStorageAgent.cpp:
        (WebCore::InspectorDOMStorageAgent::storageId):
        * inspector/InspectorDOMStorageAgent.h:
        * inspector/InspectorDatabaseAgent.cpp:
        (WebCore::InspectorDatabaseAgent::databaseId):
        * inspector/InspectorDatabaseAgent.h:
        * inspector/InspectorFrontendHost.cpp:
        (WebCore::InspectorFrontendHost::showContextMenu):
        (WebCore::InspectorFrontendHost::dispatchEventAsContextMenuEvent):
        * inspector/InspectorFrontendHost.h:
        * inspector/InspectorFrontendHost.idl:
        Remove nullability from arguments that should never be null.

2017-07-21  Brady Eidson  <beidson@apple.com>

        Get rid of WebCore IconDatabase code.
        https://bugs.webkit.org/show_bug.cgi?id=174700

        Reviewed by Tim Horton.

        No new tests (No behavior change).
        
        Tons of red.
        Very little green.
        No further explanation.

        * CMakeLists.txt:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/Document.cpp:
        (WebCore::Document::implicitClose):
        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::HistoryItem):
        (WebCore::HistoryItem::~HistoryItem):
        (WebCore::HistoryItem::reset):
        (WebCore::HistoryItem::setURLString):
        * inspector/InspectorNetworkAgent.cpp:
        (WebCore::InspectorNetworkAgent::willSendRequest):
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::~DocumentLoader):
        (WebCore::DocumentLoader::startIconLoading):
        (WebCore::DocumentLoader::iconLoadDecisionAvailable): Deleted.
        (WebCore::iconLoadDecisionCallback): Deleted.
        (WebCore::DocumentLoader::getIconLoadDecisionForIconURL): Deleted.
        (WebCore::DocumentLoader::continueIconLoadWithDecision): Deleted.
        (WebCore::iconDataCallback): Deleted.
        (WebCore::DocumentLoader::getIconDataForIconURL): Deleted.
        * loader/DocumentLoader.h:
        (WebCore::DocumentLoader::linkIcons):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::FrameLoader):
        (WebCore::FrameLoader::stop):
        * loader/FrameLoader.h:
        (WebCore::FrameLoader::subframeLoader):
        (WebCore::FrameLoader::icon): Deleted.
        * loader/FrameLoaderClient.h:
        * loader/archive/cf/LegacyWebArchive.cpp:
        (WebCore::LegacyWebArchive::create):
        * loader/icon/IconController.cpp: Removed.
        * loader/icon/IconController.h: Removed.
        * loader/icon/IconDatabase.cpp: Removed.
        * loader/icon/IconDatabase.h: Removed.
        * loader/icon/IconDatabaseBase.cpp: Removed.
        * loader/icon/IconDatabaseBase.h: Removed.
        * loader/icon/IconDatabaseClient.h: Removed.
        * loader/icon/IconLoader.cpp:
        (WebCore::IconLoader::IconLoader):
        (WebCore::IconLoader::startLoading):
        (WebCore::IconLoader::notifyFinished):
        * loader/icon/IconLoader.h:
        * loader/icon/IconRecord.cpp: Removed.
        * loader/icon/IconRecord.h: Removed.
        * loader/icon/PageURLRecord.cpp: Removed.
        * loader/icon/PageURLRecord.h: Removed.
        * testing/Internals.cpp:
        (WebCore::Internals::shortcutIconURLs):

2017-07-21  Chris Dumez  <cdumez@apple.com>

        Rename DOMCoreException class to DOMException
        https://bugs.webkit.org/show_bug.cgi?id=174698

        Reviewed by Darin Adler.

        Rename DOMCoreException class to DOMException to match its Web-exposed name.

        * CMakeLists.txt:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * Modules/quota/StorageErrorCallback.cpp:
        (WebCore::StorageErrorCallback::CallbackTask::CallbackTask):
        * Modules/quota/StorageErrorCallback.h:
        * Modules/quota/StorageErrorCallback.idl:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMExceptionHandling.cpp:
        (WebCore::retrieveErrorMessage):
        (WebCore::createDOMException):
        * bindings/scripts/CodeGeneratorJS.pm:
        (GenerateOverloadDispatcher):
        * css/FontFaceSet.cpp:
        * css/FontFaceSet.h:
        * dom/DOMAllInOne.cpp:
        * dom/DOMException.cpp: Renamed from Source/WebCore/dom/DOMCoreException.cpp.
        (WebCore::DOMException::create):
        (WebCore::DOMException::DOMException):
        (WebCore::DOMException::initializeDescription):
        * dom/DOMException.h: Renamed from Source/WebCore/dom/DOMCoreException.h.
        (WebCore::DOMException::create):
        (WebCore::DOMException::DOMException):
        * dom/DOMException.idl: Renamed from Source/WebCore/dom/DOMCoreException.idl.
        * dom/DOMExceptions.in:
        * dom/make_dom_exceptions.pl:
        (generateImplementation):

2017-07-21  Sam Weinig  <sam@webkit.org>

        Follow up to https://bugs.webkit.org/show_bug.cgi?id=174659.

        * inspector/InspectorFrontendHost.idl:
        Remove unnecessary JSGenerateToJSObject noticed in review.

2017-07-20  Chris Dumez  <cdumez@apple.com>

        Drop legacy SVGException type
        https://bugs.webkit.org/show_bug.cgi?id=174695

        Reviewed by Darin Adler.

        Drop legacy SVGException type and use DOMException instead, as per the latest
        SVG specification. Both Chrome and Firefox no longer expose the SVGException
        type.

        * CMakeLists.txt:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMExceptionHandling.cpp:
        (WebCore::createDOMException):
        * bindings/js/JSExceptionBase.cpp:
        (WebCore::toExceptionBase):
        * dom/DOMExceptions.in:
        * svg/SVGAllInOne.cpp:
        * svg/SVGCircleElement.cpp:
        * svg/SVGException.cpp: Removed.
        * svg/SVGException.h: Removed.
        * svg/SVGException.idl: Removed.
        * svg/SVGGraphicsElement.idl:
        * svg/SVGLocatable.cpp:
        (WebCore::SVGLocatable::getTransformToElement):
        * svg/SVGMatrixValue.h:
        * svg/SVGPathSegList.cpp:
        (WebCore::SVGPathSegList::getItem):
        (WebCore::SVGPathSegList::replaceItem):
        (WebCore::SVGPathSegList::removeItem):
        * svg/SVGPathSegList.h:
        * svg/SVGPathSegList.idl:
        * svg/properties/SVGAnimatedEnumerationPropertyTearOff.h:
        * svg/properties/SVGListProperty.h:

2017-07-20  Chris Dumez  <cdumez@apple.com>

        Hook up ITP quirks to the needsSiteSpecificQuirks setting
        https://bugs.webkit.org/show_bug.cgi?id=174691

        Reviewed by Darin Adler.

        Hook up ITP quirks to the needsSiteSpecificQuirks setting to make it easier for
        Web-developers to test their fixes.

        * loader/ResourceLoadObserver.cpp:
        (WebCore::shouldEnableSiteSpecificQuirks):
        (WebCore::areDomainsAssociated):
        (WebCore::ResourceLoadObserver::logFrameNavigation):
        (WebCore::resourceNeedsSSOQuirk):
        (WebCore::ResourceLoadObserver::logSubresourceLoading):
        (WebCore::ResourceLoadObserver::logWebSocketLoading):

2017-07-20  Matt Lewis  <jlewis3@apple.com>

        Unreviewed, rolling out r219700.

        This revision caused consistent timouts on iOS.

        Reverted changeset:

        "Turn tests at media/modern-media-controls/start-support back
        on"
        https://bugs.webkit.org/show_bug.cgi?id=174683
        http://trac.webkit.org/changeset/219700

2017-07-20  David Quesada  <david_quesada@apple.com>

        Add SPI to notify WKNavigationDelegate about client redirects
        https://bugs.webkit.org/show_bug.cgi?id=174680
        rdar://problem/33184886

        Reviewed by Brady Eidson.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::performClientRedirect):
        * loader/FrameLoader.h:
        Add a convenience method for NavigationScheduler that handles a FrameLoadRequest
        as a client redirect. Currently this means loading the request and informing the
        client about it.

        * loader/FrameLoaderClient.h:
        Add FrameLoaderClient::dispatchDidPerformClientRedirect() to inform the client when
        a client redirect occurs.

        * loader/NavigationScheduler.cpp:
        Removed ScheduledURLNavigation::fire(). This class was never instantiated directly,
        and all subclasses override fire(), so this was unused code.
        For ScheduledRedirects and ScheduledLocationChange, use FrameLoader's new method to
        load the request as a client redirect.

2017-07-20  Chris Dumez  <cdumez@apple.com>

        Drop legacy XPathException type
        https://bugs.webkit.org/show_bug.cgi?id=174679

        Reviewed by Sam Weinig.

        Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
        no longer expose XPathException.

        Test: fast/dom/DOMException/XPathException-obsolete.html

        * CMakeLists.txt:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMExceptionHandling.cpp:
        (WebCore::createDOMException):
        * bindings/js/JSExceptionBase.cpp:
        (WebCore::toExceptionBase):
        * dom/DOMExceptions.in:
        * xml/XPathException.cpp: Removed.
        * xml/XPathException.h: Removed.
        * xml/XPathException.idl: Removed.
        * xml/XPathExpression.cpp:
        (WebCore::XPathExpression::evaluate):
        * xml/XPathParser.cpp:
        (WebCore::XPath::Parser::parseStatement):
        * xml/XPathResult.cpp:
        (WebCore::XPathResult::convertTo):
        (WebCore::XPathResult::numberValue):
        (WebCore::XPathResult::stringValue):
        (WebCore::XPathResult::booleanValue):
        (WebCore::XPathResult::singleNodeValue):
        (WebCore::XPathResult::snapshotLength):
        (WebCore::XPathResult::iterateNext):
        (WebCore::XPathResult::snapshotItem):

2017-07-20  Chris Dumez  <cdumez@apple.com>

        Unreviewed, rolling out r219706.

        Broke iOS build

        Reverted changeset:

        "Drop legacy XPathException type"
        https://bugs.webkit.org/show_bug.cgi?id=174679
        http://trac.webkit.org/changeset/219706

2017-07-20  Chris Dumez  <cdumez@apple.com>

        Drop legacy XPathException type
        https://bugs.webkit.org/show_bug.cgi?id=174679

        Reviewed by Sam Weinig.

        Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
        no longer expose XPathException.

        Test: fast/dom/DOMException/XPathException-obsolete.html

        * CMakeLists.txt:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMExceptionHandling.cpp:
        (WebCore::createDOMException):
        * bindings/js/JSExceptionBase.cpp:
        (WebCore::toExceptionBase):
        * dom/DOMExceptions.in:
        * xml/XPathException.cpp: Removed.
        * xml/XPathException.h: Removed.
        * xml/XPathException.idl: Removed.
        * xml/XPathExpression.cpp:
        (WebCore::XPathExpression::evaluate):
        * xml/XPathParser.cpp:
        (WebCore::XPath::Parser::parseStatement):
        * xml/XPathResult.cpp:
        (WebCore::XPathResult::convertTo):
        (WebCore::XPathResult::numberValue):
        (WebCore::XPathResult::stringValue):
        (WebCore::XPathResult::booleanValue):
        (WebCore::XPathResult::singleNodeValue):
        (WebCore::XPathResult::snapshotLength):
        (WebCore::XPathResult::iterateNext):
        (WebCore::XPathResult::snapshotItem):

2017-07-20  Chris Dumez  <cdumez@apple.com>

        Regression(ITP): May get frequently logged out of wsj.com
        https://bugs.webkit.org/show_bug.cgi?id=174661
        <rdar://problem/32343256>

        Reviewed by Geoffrey Garen.

        Add the concept of associated domains in the ResourceLoadObserver. We
        previously ignore loads to and from the same domains. We now do the same
        if the to and from domains are associated (i.e. owned by the same entity).

        For now, only add domains owned by Dow Jones & Company, Inc. to the list,
        to address login issues on wsj.com.

        No new tests, verified manually on wsj.com.

        * loader/ResourceLoadObserver.cpp:
        (WebCore::areDomainsAssociated):
        (WebCore::ResourceLoadObserver::logFrameNavigation):
        (WebCore::ResourceLoadObserver::logSubresourceLoading):
        (WebCore::ResourceLoadObserver::logWebSocketLoading):

2017-07-20  Chris Dumez  <cdumez@apple.com>

        Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
        https://bugs.webkit.org/show_bug.cgi?id=174660

        Reviewed by Geoffrey Garen.

        Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
        This essentially replaces a branch to figure out if the new size is less or greater than the
        current size by an assertion.

        * Modules/gamepad/Gamepad.cpp:
        (WebCore::Gamepad::Gamepad):
        * Modules/webaudio/AudioContext.cpp:
        (WebCore::AudioContext::addReaction):
        * Modules/websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::skipBuffer):
        * Modules/websockets/WebSocketDeflater.cpp:
        (WebCore::WebSocketDeflater::finish):
        * contentextensions/ContentExtensionCompiler.cpp:
        (WebCore::ContentExtensions::serializeSelector):
        * contentextensions/DFABytecodeCompiler.cpp:
        (WebCore::ContentExtensions::append):
        * crypto/gcrypt/CryptoAlgorithmAES_CBCGCrypt.cpp:
        (WebCore::gcryptEncrypt):
        (WebCore::gcryptDecrypt):
        * crypto/gcrypt/CryptoAlgorithmECDHGCrypt.cpp:
        (WebCore::gcryptDerive):
        * platform/gamepad/cocoa/GameControllerGamepadProvider.mm:
        (WebCore::GameControllerGamepadProvider::controllerDidConnect):
        * platform/gamepad/mac/HIDGamepadProvider.cpp:
        (WebCore::HIDGamepadProvider::deviceAdded):
        * platform/graphics/ImageBackingStore.h:
        (WebCore::ImageBackingStore::setSize):
        * platform/graphics/WOFFFileFormat.cpp:
        * platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF.cpp:
        (WebCore::InbandMetadataTextTrackPrivateAVF::updatePendingCueEndTimes):
        (WebCore::InbandMetadataTextTrackPrivateAVF::flushPartialCues):
        * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
        (WebCore::InbandTextTrackPrivateAVF::resetCueValues):
        (WebCore::InbandTextTrackPrivateAVF::readNativeSampleBuffer):
        * platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp:
        (WebCore::InbandTextTrackPrivateAVCF::readNativeSampleBuffer):
        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::cfData):
        * platform/image-decoders/bmp/BMPImageDecoder.cpp:
        (WebCore::BMPImageDecoder::frameBufferAtIndex):
        * platform/image-decoders/ico/ICOImageDecoder.cpp:
        (WebCore::ICOImageDecoder::decode):
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        (WebCore::JPEGImageDecoder::frameBufferAtIndex):
        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageDecoder::frameBufferAtIndex):
        (WebCore::PNGImageDecoder::readChunks):
        * platform/image-decoders/webp/WEBPImageDecoder.cpp:
        (WebCore::WEBPImageDecoder::frameBufferAtIndex):
        * platform/image-encoders/JPEGImageEncoder.cpp:
        (WebCore::compressRGBABigEndianToJPEG):
        * platform/text/DecodeEscapeSequences.h:
        (WebCore::URLEscapeSequence::decodeRun):
        * platform/text/SuffixTree.h:
        (WebCore::SuffixTree::Node::Node):
        * rendering/Grid.cpp:
        (WebCore::Grid::setNeedsItemsPlacement):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::invalidateCachedColumns):

2017-07-20  Chris Dumez  <cdumez@apple.com>

        Regression(ITP): Can no longer log in on abc.go.com
        https://bugs.webkit.org/show_bug.cgi?id=174533
        <rdar://problem/33325881>

        Reviewed by Geoffrey Garen.

        Add quirk for sp.auth.adobe.com which is used for SSO by web sites such as
        abc.go.com. This would otherwise cause adobe.com to be identified as a
        tracker and log in on abc.go.com would break.

        No new tests, tested manually on abc.go.com.

        * loader/ResourceLoadObserver.cpp:
        (WebCore::resourceNeedsSSOQuirk):
        (WebCore::ResourceLoadObserver::logSubresourceLoading):

2017-07-20  Antoine Quint  <graouts@apple.com>

        Turn tests at media/modern-media-controls/start-support back on
        https://bugs.webkit.org/show_bug.cgi?id=174683

        Reviewed by Dean Jackson.

        Turning those tests back on revealed a small bug that is unlikely to really affect content
        on the Web. In the case where the size of the video is known right away, without the need
        for loading its metadata, as is the case in the start-support-click-to-start.html test with
        a local media resource, all queued layouts are flushed at once and we may call the layout()
        method of the left ButtonsContainer which originally is set to contain the play/pause button,
        which would remove the play/pause button from the center of the media. So before we potentially
        set the play/pause button as the central button, we first assign the default button set for
        the two ButtonsContainer instances and only add the play/pause button when we're not showing
        the prominent play/pause button.

        * Modules/modern-media-controls/controls/inline-media-controls.js:
        (InlineMediaControls.prototype.layout):
        (InlineMediaControls.prototype._leftContainerButtons):

2017-07-20  Chris Dumez  <cdumez@apple.com>

        Drop legacy FileException type
        https://bugs.webkit.org/show_bug.cgi?id=174676

        Reviewed by Alex Christensen.

        Drop legacy FileException type and use DOMException instead, as per the latest
        File API specification:
        - https://w3c.github.io/FileAPI/#ErrorAndException

        Both Firefox and Chrome no longer expose FileException.

        * CMakeLists.txt:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMExceptionHandling.cpp:
        (WebCore::createDOMException):
        * dom/DOMExceptions.in:
        * fileapi/FileException.cpp: Removed.
        * fileapi/FileException.h: Removed.
        * fileapi/FileException.idl: Removed.
        * fileapi/FileReaderLoader.cpp:
        (WebCore::FileReaderLoader::FileReaderLoader):
        (WebCore::FileReaderLoader::failed):
        * fileapi/FileReaderLoader.h:
        (WebCore::FileReaderLoader::errorCode):
        * fileapi/FileReaderSync.cpp:
        (WebCore::errorCodeToExceptionCode):
        (WebCore::FileReaderSync::startLoading):

2017-07-20  Sam Weinig  <sam@webkit.org>

        [WebIDL] Remove custom bindings for InspectorFrontendHost
        https://bugs.webkit.org/show_bug.cgi?id=174659

        Reviewed by Chris Dumez.

        * CMakeLists.txt:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSInspectorFrontendHostCustom.cpp: Removed.
        Remove JSInspectorFrontendHostCustom.cpp.

        * inspector/InspectorFrontendHost.cpp:
        (WebCore::populateContextMenu):
        (WebCore::InspectorFrontendHost::showContextMenu):
        * inspector/InspectorFrontendHost.h:
        * inspector/InspectorFrontendHost.idl:
        Re-implement showContextMenu by using an IDL defined ContextMenuItem dictionary
        and converting from that to a WebCore::ContextMenu in the implementation.

2017-07-20  Charlie Turner  <cturner@igalia.com>

        [GTK] Layout Test http/tests/media/hls/hls-progress.html is failing
        https://bugs.webkit.org/show_bug.cgi?id=141469

        Reviewed by Xabier Rodriguez-Calvar.

        A work-around for getting progress information in a timely manner from
        live pipelines. We cannot rely on getting BUFFERING messages within
        the stalled time window (3s), so we have to poll for progress
        information somehow.

        Makes the following pass reliably
         http/tests/media/hls/hls-audio-tracks-has-audio.html passed unexpectedly
         http/tests/media/hls/hls-audio-tracks.html passed unexpectedly
         http/tests/media/hls/hls-progress.html passed unexpectedly

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::findHLSQueue):
        (WebCore::isHLSProgressing):
        (WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):

2017-07-20  Andreas Kling  <akling@apple.com>

        Minor Node->Element type tightening fixes
        https://bugs.webkit.org/show_bug.cgi?id=174651

        Reviewed by Sam Weinig.

        Tighten up some Node* into Element* or even better, Element&.

        * dom/Document.cpp:
        (WebCore::acceptsEditingFocus): Take a const Element&.
        (WebCore::Document::setFocusedElement):
        * editing/Editor.cpp:
        (WebCore::Editor::findEventTargetFrom): Return an Element*.
        (WebCore::Editor::findEventTargetFromSelection): Ditto.
        (WebCore::Editor::pasteAsPlainText):
        (WebCore::Editor::pasteAsFragment):
        (WebCore::Editor::dispatchCPPEvent):
        * editing/Editor.h:
        * page/DragController.cpp:
        (WebCore::DragController::dispatchTextInputEventFor):

2017-07-20  Brady Eidson  <beidson@apple.com>

        WKHTTPCookieStore API tests fail on High Sierra.
        <rdar://problem/33410271> and https://bugs.webkit.org/show_bug.cgi?id=174666

        Reviewed by Andy Estes.

        Covered by existing API tests.

        In r219567 I'd moved cookie storage observation off of NSHTTPCookieStorage and NSNotificationCenter
        to CFHTTPCookieStorage observation callbacks.
        
        This is because notifications were only sent for the default [NSHTTPCookieStorage sharedHTTPCookieStorage]
        and not any of the other ones we keep in flight.
        
        Unfortunately that SPI has been disabled in High Sierra.
        Fortunately we found a way we can get non-shared NSHTTPCookieStorages to send notifications that works everywhere.
        
        * platform/network/cocoa/CookieStorageObserver.h:
        * platform/network/cocoa/CookieStorageObserver.mm:
        (-[WebCookieObserverAdapter initWithObserver:]):
        (-[WebCookieObserverAdapter cookiesChangedNotificationHandler:]):
        (WebCore::CookieStorageObserver::create):
        (WebCore::CookieStorageObserver::CookieStorageObserver):
        (WebCore::CookieStorageObserver::~CookieStorageObserver):
        (WebCore::CookieStorageObserver::startObserving): Use a trick to call some SPI on non-shared NSHTTPCookieStorages
          to get them to send notifications.
        (WebCore::CookieStorageObserver::stopObserving):
        (WebCore::cookiesChanged): Deleted.

        * platform/network/cocoa/NetworkStorageSessionCocoa.mm:
        (WebCore::NetworkStorageSession::cookieStorageObserver):

2017-07-20  Miguel Gomez  <magomez@igalia.com>

        [GStreamer] Some layout tests issue "g_mutex_clear() called on uninitialised or locked mutex" and flaky crash in ~MediaPlayerPrivateGStreamerBase
        https://bugs.webkit.org/show_bug.cgi?id=173952

        Reviewed by Carlos Garcia Campos.

        Adjust MediaPlayerPrivateGStreamerBase to avoid concurrence problems with the GStreamer thread when
        destroying the object.

        Covered by existent tests.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
        (WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
        (WebCore::MediaPlayerPrivateGStreamerBase::repaint):
        (WebCore::MediaPlayerPrivateGStreamerBase::cancelRepaint):

2017-07-19  Zan Dobersek  <zdobersek@igalia.com>

        [EME] Push CDMInstance, CDMPrivate and associated types into the Platform layer
        https://bugs.webkit.org/show_bug.cgi?id=174496

        Reviewed by Xabier Rodriguez-Calvar.

        Move the CDMInstance and CDMPrivate interfaces into the platform layer, enabling
        implementations of specific key systems at that level, as well as integration with
        the MediaPlayerPrivate stack without any layering violations.

        While the platform layer still uses the WebCore namespace, the two interface files
        have now been moved under the platform/encryptedmedia/ directory and out of the
        Modules/encryptedmedia/ directory where the Web-facing API implementation resides.

        The two interfaces integrated closely with the Web-facing enumerations and
        dictionaries: MediaKeyMessageType, MediaKeySessionType, MediaKeyStatus,
        MediaKeySystemConfiguration, MediaKeySystemCapability, MediaKeysRequirement
        and MediaKeysRestrictions. Definitions of these types are also moved to the
        platform layer without any changes (apart from renaming), and the previous
        types now alias against the types now located in the platform layer.

        No new tests -- no change in behavior.

        * CMakeLists.txt:
        * Modules/encryptedmedia/CDM.cpp:
        * Modules/encryptedmedia/CDM.h:
        * Modules/encryptedmedia/MediaKeyMessageType.h:
        * Modules/encryptedmedia/MediaKeySessionType.h:
        * Modules/encryptedmedia/MediaKeyStatus.h:
        * Modules/encryptedmedia/MediaKeySystemAccess.cpp:
        * Modules/encryptedmedia/MediaKeySystemAccess.h:
        * Modules/encryptedmedia/MediaKeySystemConfiguration.h:
        * Modules/encryptedmedia/MediaKeySystemMediaCapability.h:
        * Modules/encryptedmedia/MediaKeysRequirement.h:
        * Modules/encryptedmedia/MediaKeysRestrictions.h:
        * platform/encryptedmedia/CDMInstance.h: Renamed from Source/WebCore/Modules/encryptedmedia/CDMInstance.h.
        * platform/encryptedmedia/CDMKeyStatus.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeyStatus.h.
        * platform/encryptedmedia/CDMKeySystemConfiguration.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeySystemConfiguration.h.
        * platform/encryptedmedia/CDMMediaCapability.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeySystemMediaCapability.h.
        * platform/encryptedmedia/CDMMessageType.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeyMessageType.h.
        * platform/encryptedmedia/CDMPrivate.h: Renamed from Source/WebCore/Modules/encryptedmedia/CDMPrivate.h.
        * platform/encryptedmedia/CDMRequirement.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeysRequirement.h.
        * platform/encryptedmedia/CDMRestrictions.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeysRestrictions.h.
        * platform/encryptedmedia/CDMSessionType.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeySessionType.h.

2017-07-19  Zan Dobersek  <zdobersek@igalia.com>

        Unreviewed follow-up to r219674.

        * page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:
        Remove the AsyncScrollingCoordinator.h header include that was added by accident.

2017-07-19  Zan Dobersek  <zdobersek@igalia.com>

        [CMake] Clean up Web Crypto build targets
        https://bugs.webkit.org/show_bug.cgi?id=174253

        Reviewed by Alex Christensen.

        Gather the common WebCrypto source files in CMakeLists.txt, including them
        in the build unconditionally and instead relying on ENABLE_SUBTLE_CRYPTO
        build guards to exclude the code from compilation if the feature is disabled.

        PlatformGTK.cmake, PlatformMac.cmake and PlatformWPE.cmake can then remove
        duplicated build targets. PlatformMac.cmake still lists all the Mac-specific
        Web Crypto build targets.

        PlatformGTK.cmake and PlatformWPE.cmake now include GCrypt.cmake if the
        USE_GCRYPT variable is enabled. Both ports at the moment enable that variable
        though as they by default leverage a libgcrypt-based CrpytoDigest implementation
        in the PAL library.

        The new GCrypt.cmake file adds the libgcrypt-specific Web Crypto build targets to
        the build and also sets up libgcrypt include directiories and libraries.

        No new tests -- no change in behavior.

        * CMakeLists.txt:
        * PlatformGTK.cmake:
        * PlatformMac.cmake:
        * PlatformWPE.cmake:
        * platform/GCrypt.cmake: Added.

2017-07-19  Sam Weinig  <sam@webkit.org>

        [WebIDL] Remove custom bindings for CommandLineAPIHost
        https://bugs.webkit.org/show_bug.cgi?id=174642

        Reviewed by Joseph Pecoraro.

        * CMakeLists.txt:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSCommandLineAPIHostCustom.cpp: Removed.
        Remove JSCommandLineAPIHostCustom.cpp.

        * bindings/js/JSDOMConvertObject.h:
        (WebCore::JSConverter<IDLObject>::convert):
        Add missing JSConverter specialization for IDLObject.

        * inspector/CommandLineAPIHost.cpp:
        (WebCore::CommandLineAPIHost::inspect):
        (WebCore::listenerEntriesFromListenerInfo):
        (WebCore::CommandLineAPIHost::inspectedObject):
        (WebCore::CommandLineAPIHost::databaseId):
        (WebCore::CommandLineAPIHost::storageId):
        (WebCore::CommandLineAPIHost::inspectImpl): Deleted.
        (WebCore::CommandLineAPIHost::getEventListenersImpl): Deleted.
        (WebCore::CommandLineAPIHost::databaseIdImpl): Deleted.
        (WebCore::CommandLineAPIHost::storageIdImpl): Deleted.
        * inspector/CommandLineAPIHost.h:
        * inspector/CommandLineAPIHost.idl:
        Replace custom bindings with modern bindings affordances: dictionaries, records and sequences.

2017-07-19  Zan Dobersek  <zdobersek@igalia.com>

        Unreviewed CoordGraphics build fix.

        * page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:
        (WebCore::ScrollingCoordinatorCoordinatedGraphics::updateNodeViewportConstraints):
        This should be defined for the ScrollingCoordinatorCoordinatedGraphics class.
        Also fix the setFixedToViewport() call, fishing out the GraphicsLayer object from
        the ScrollingStateNode's LayerRepresentation.
        (WebCore::AsyncScrollingCoordinator::updateNodeViewportConstraints): Deleted.

2017-07-19  Chris Dumez  <cdumez@apple.com>

        Drop SQLException type
        https://bugs.webkit.org/show_bug.cgi?id=174665

        Reviewed by Sam Weinig.

        Drop SQLException type. We never throw such exception. Also, Firefox
        and Chrome no longer expose this type.

        * CMakeLists.txt:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * Modules/webdatabase/SQLException.cpp: Removed.
        * Modules/webdatabase/SQLException.h: Removed.
        * Modules/webdatabase/SQLException.idl: Removed.
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMExceptionHandling.cpp:
        (WebCore::createDOMException):
        * bindings/js/JSExceptionBase.cpp:
        (WebCore::toExceptionBase):
        * dom/DOMExceptions.in:

2017-07-19  Wenson Hsieh  <wenson_hsieh@apple.com>

        Unreviewed, tweak a comment above TemporarySelectionOptionIgnoreSelectionChanges in Editor.cpp.

        The comment references the UI process, but it describes an entity in WebCore. This should have been generalized
        to instead refer to the client layer in general (i.e. WebKit1 or WebKit2).

        * editing/Editor.h:

2017-07-19  Simon Fraser  <simon.fraser@apple.com>

        getBoundingClientRects not updated for programmatic scrolls
        https://bugs.webkit.org/show_bug.cgi?id=174538
        rdar://problem/33049012

        Reviewed by Tim Horton.

        Baidu.com has two event handlers on its <input>, and both query the input location with getBoundingClientRect()
        and the current pageYOffset (via jQuery), then try to scroll the input to the top of the screen. The bug is that
        programmatic scrolls did not immediately update the layout viewport rect, so the second call to
        getBoundingClientRect() would return stale coordinates, triggering an extra scroll.

        To fix this, undo the fix for r219320 which tried to keep getBoundingClientRect() current during unstable scroll
        updates by adding a shadow layout viewport rect. Instead, almost always update the layout viewport rect on
        FrameView, even during unstable visible rect updates, but not if content insets are being changed interactively,
        since changing viewport heights cause problems with bottom-fixed elements. Also, we need to compute a new layout
        viewport rect in FrameView::updateLayoutViewport() for programmatic scrolls.

        However, always updating the layout viewport triggered issues with the scrolling tree. The scrolling state tree
        fossilizes layer positions relative to a specific viewport rect, and that relationship has to be maintained.
        There are code paths that recompute fixed/sticky viewport constraints when the layout viewport has changed but
        we haven't done layout or recomputed layer positions (e.g. updating viewport-constrained layers via
        updateScrollCoordinatedLayersAfterFlush()) and in these cases using a new layout viewport for those computations
        results in an inconsistent scrolling tree.

        Fix this by not updating scrolling constraints every time we have to re-register scrolling nodes.
        updateScrollCoordinatedLayersAfterFlush() only needs to update the layer on the scrolling node (to handle
        tiled/non-tiled switches), so make updateScrollCoordinatedLayer() a little more fine-grained, and only update
        constraints when we've just computed layer geometry. This allows for different scrolling nodes to have
        constraints computed at different times, with different layout viewports, which happens.

        Two additional fixes were required to make bottom-fixed bars behave correctly.

        First, FrameView::computeLayoutViewportOrigin() had a bug where rounding of half-pixel values would cause it to
        fall into the if (visualViewport.height() > layoutViewport.height()) clause, but then fail to clamp for
        rubber-banding.
        
        Second, the FrameView::unscaledMaximumScrollPosition() was wrong after zooming on iOS, since it uses visibleSize()
        which is affected by page scale on iOS only (and the function wants scale-independent values). Fix with a hack that
        should be cleaned up via webkit.org/b/174648.

        Tested by existing tests.

        * page/FrameView.cpp:
        (WebCore::FrameView::computeUpdatedLayoutViewportRect):
        (WebCore::FrameView::computeLayoutViewportOrigin):
        (WebCore::FrameView::setLayoutViewportOverrideRect):
        (WebCore::FrameView::updateLayoutViewport):
        (WebCore::FrameView::unscaledMaximumScrollPosition):
        (WebCore::FrameView::documentToClientOffset):
        (WebCore::FrameView::setUnstableLayoutViewportRect): Deleted.
        * page/FrameView.h:
        * page/scrolling/AsyncScrollingCoordinator.cpp:
        (WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):
        (WebCore::AsyncScrollingCoordinator::reconcileScrollingState):
        (WebCore::AsyncScrollingCoordinator::reconcileViewportConstrainedLayerPositions):
        (WebCore::AsyncScrollingCoordinator::updateNodeLayer):
        (WebCore::AsyncScrollingCoordinator::updateNodeViewportConstraints):
        (WebCore::AsyncScrollingCoordinator::updateViewportConstrainedNode): Deleted.
        * page/scrolling/AsyncScrollingCoordinator.h:
        * page/scrolling/ScrollingCoordinator.cpp:
        (WebCore::operator<<):
        * page/scrolling/ScrollingCoordinator.h:
        (WebCore::ScrollingCoordinator::reconcileScrollingState):
        (WebCore::ScrollingCoordinator::updateNodeLayer):
        (WebCore::ScrollingCoordinator::updateNodeViewportConstraints):
        (WebCore::ScrollingCoordinator::updateViewportConstrainedNode): Deleted.
        * page/scrolling/ScrollingStateFixedNode.cpp:
        (WebCore::ScrollingStateFixedNode::updateConstraints):
        * page/scrolling/ScrollingStateStickyNode.cpp:
        (WebCore::ScrollingStateStickyNode::updateConstraints):
        (WebCore::ScrollingStateStickyNode::reconcileLayerPositionForViewportRect):
        * page/scrolling/ScrollingTree.cpp:
        (WebCore::ScrollingTree::commitTreeState):
        * page/scrolling/mac/ScrollingTreeFixedNode.mm:
        (WebCore::ScrollingTreeFixedNode::updateLayersAfterAncestorChange):
        * page/scrolling/mac/ScrollingTreeStickyNode.mm:
        (WebCore::ScrollingTreeStickyNode::updateLayersAfterAncestorChange):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateGeometry):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateScrollCoordinatedLayersAfterFlush):
        (WebCore::RenderLayerCompositor::updateBacking):
        (WebCore::RenderLayerCompositor::fixedRootBackgroundLayerChanged):
        (WebCore::RenderLayerCompositor::requiresCompositingForPosition):
        (WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus):
        (WebCore::RenderLayerCompositor::computeFixedViewportConstraints):
        (WebCore::RenderLayerCompositor::computeStickyViewportConstraints):
        (WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
        (WebCore::RenderLayerCompositor::didAddScrollingLayer):
        * rendering/RenderLayerCompositor.h:

2017-07-19  Megan Gardner  <megan_gardner@apple.com>

        Don't write file URLs to iOS Pasteboard
        https://bugs.webkit.org/show_bug.cgi?id=174647
        <rdar://problem/33199730>

        Reviewed by Wenson Hsieh.

        Tests updated to reflect the changes. We are no longer vending file URLs in Drag & Drop and Copy/Paste.

        * editing/ios/EditorIOS.mm:
        (WebCore::Editor::writeImageToPasteboard):
        * platform/ios/PlatformPasteboardIOS.mm:
        (WebCore::PlatformPasteboard::write):

2017-07-19  Myles C. Maxfield  <mmaxfield@apple.com>

        Setting the minimum font size preference doesn’t affect absolute line-height values, so lines overlap
        https://bugs.webkit.org/show_bug.cgi?id=174406

        Reviewed by Simon Fraser.
        <rdar://problem/10139227>

        Reviewed by NOBODY.

        When the minimumFontSize API preference is set, we will increase the font size without increasing
        the line height. If the content specifies line-height as an absolute value, there can be two
        unfortunate results:

        - Adjacent lines in a paragraph can overlap
        - If the paragraph (or containin block or whatever) uses overflow: hidden, the first and last lines
        can be cut off and potentially indecipherable.

        Instead, we should use the minimum font size preference as a signal that we should increase the
        line-height as well as the font-size. Eventually, we will want to increase it by an amount
        proportional to the increase in font-size (which can be due to minimumFontSize, minimumLogicalFontSize,
        text autosizing, etc.). However, because minimumLogicalFontSize is on by default, this would cause
        a behavior change on many webpages which use small text, so such a change would be too risky right now.
        Instead, we can pretend that minimumFontSize is the only cause that text increases, and use this as the
        only signal to boost the corresponding line-height.

        Tests: fast/text/line-height-minimumFontSize-text-zoom.html
               fast/text/line-height-minimumFontSize-visual.html
               fast/text/line-height-minimumFontSize-zoom.html
               fast/text/line-height-minimumFontSize.html
               fast/text/line-height-minimumFontSize-autosize.html

        * css/StyleBuilderCustom.h:
        (WebCore::computeBaseSpecifiedFontSize):
        (WebCore::computeLineHeightMultiplierDueToFontSize):
        (WebCore::StyleBuilderCustom::applyValueLineHeight):
        (WebCore::StyleBuilderCustom::applyValueFill):
        (WebCore::StyleBuilderCustom::applyValueStroke):
        (WebCore::StyleBuilderCustom::applyValueContent):
        * rendering/TextAutoSizing.cpp:

2017-07-18  Myles C. Maxfield  <mmaxfield@apple.com>

        Setting the minimum font size preference doesn’t affect absolute line-height values, so lines overlap
        https://bugs.webkit.org/show_bug.cgi?id=174406
        <rdar://problem/10139227>

        Reviewed by Simon Fraser.

        When the minimumFontSize API preference is set, we will increase the font size without increasing
        the line height. If the content specifies line-height as an absolute value, there can be two
        unfortunate results:

        - Adjacent lines in a paragraph can overlap
        - If the paragraph (or containin block or whatever) uses overflow: hidden, the first and last lines
        can be cut off and potentially indecipherable.

        Instead, we should use the minimum font size preference as a signal that we should increase the
        line-height as well as the font-size. Eventually, we will want to increase it by an amount
        proportional to the increase in font-size (which can be due to minimumFontSize, minimumLogicalFontSize,
        text autosizing, etc.). However, because minimumLogicalFontSize is on by default, this would cause
        a behavior change on many webpages which use small text, so such a change would be too risky right now.
        Instead, we can pretend that minimumFontSize is the only cause that text increases, and use this as the
        only signal to boost the corresponding line-height.

        Tests: fast/text/line-height-minimumFontSize-text-zoom.html
               fast/text/line-height-minimumFontSize-visual.html
               fast/text/line-height-minimumFontSize-zoom.html
               fast/text/line-height-minimumFontSize.html
               fast/text/line-height-minimumFontSize-autosize.html

        * css/StyleBuilderCustom.h:
        (WebCore::computeBaseSpecifiedFontSize):
        (WebCore::computeLineHeightMultiplierDueToFontSize):
        (WebCore::StyleBuilderCustom::applyValueLineHeight):
        (WebCore::StyleBuilderCustom::applyValueFill):
        (WebCore::StyleBuilderCustom::applyValueStroke):
        (WebCore::StyleBuilderCustom::applyValueContent):
        * rendering/TextAutoSizing.cpp:

2017-07-19  Chris Dumez  <cdumez@apple.com>

        DOMException should not have its own toString()
        https://bugs.webkit.org/show_bug.cgi?id=174630

        Reviewed by Sam Weinig.

        DOMException should not have its own toString() and should use the one from Error.prototype.toString()
        instead:
        - https://heycam.github.io/webidl/#idl-DOMException

        No new tests, rebaselined existing tests.

        * dom/DOMCoreException.idl:

2017-07-19  Antoine Quint  <graouts@apple.com>

        [iOS] REGRESSION: Scrubbing media using built-in controls does not pause media
        https://bugs.webkit.org/show_bug.cgi?id=174650
        <rdar://problem/33401877>

        Reviewed by Dean Jackson.

        We would only pause when scrubbing on macOS because we only listened to "mousedown" events on the
        scrubber's backing <input> element to identify that the user had started interacting with the
        scrubber.

        Implementing the same technique on iOS required a little more work than just listening to "touchstart"
        events on the same element. On top of that, we needed to make sure that we would only respond to
        "touchstart" events on the slider's thumb, and not on the track, since only on macOS should the user
        be able to click anywhere on the track to scrub. So we turn off pointer-events for the <input> on iOS
        only, and turn them back on specifically for the thumb.

        There is also some finessing when dealing with touch events where we need to track the identifier of
        the touch that started the user interaction. So we keep track of it in an ivar and wait until we get
        a "touchend" event where the changedTouches list contains a touch with that same identifier to ensure
        the same touch that initiates and ends the scrubbing interaction.

        Finally, we fix another issue that was uncovered while turning back on the ScrubbingSupport tests
        where we would not trash the cached _value ivar when we initiated scrubbing, which was important since
        we would mistakenly use the pre-srubbing value during a scrub.

        * Modules/modern-media-controls/controls/slider.css:
        (.ios .slider > input):
        (.slider > input::-webkit-slider-thumb):
        * Modules/modern-media-controls/controls/slider.js:
        (Slider.prototype.handleEvent):
        (Slider.prototype._handleMousedownEvent):
        (Slider.prototype._interactionEndTarget):
        (Slider.prototype._handleTouchstartEvent):
        (Slider.prototype._valueWillStartChanging):
        (Slider.prototype._valueDidStopChanging):
        (Slider.prototype._handleMouseupEvent):
        (Slider.prototype._handleTouchendEvent):

2017-07-19  Nan Wang  <n_wang@apple.com>

        AX: Web page reloaded when a node is labelling multiple childnodes
        https://bugs.webkit.org/show_bug.cgi?id=174655

        Reviewed by Chris Fleizach.

        When we are asking for the aria-labelledby attribute of a node and its
        sibling is also labelled by the same node, we get into an infinite loop
        in textUnderElement since we only ignore one child. Added checks for 
        siblings to avoid such loop.

        Test: accessibility/mac/aria-labelledby-multiple-child-crash.html

        * accessibility/AccessibilityNodeObject.cpp:
        (WebCore::AccessibilityNodeObject::textUnderElement):

2017-07-19  Andy Estes  <aestes@apple.com>

        Use a cast to work around clang's false -Wobjc-literal-conversion warnings
        https://bugs.webkit.org/show_bug.cgi?id=174631

        Reviewed by Dan Bernstein.

        Instead of ignoring -Wobjc-literal-conversion, use a cast to work around rdar://problem/33383354.

        * platform/ios/PlatformPasteboardIOS.mm:
        (WebCore::PlatformPasteboard::write):

2017-07-19  Chris Dumez  <cdumez@apple.com>

        Make cross-origin properties enumerable
        https://bugs.webkit.org/show_bug.cgi?id=174576

        Reviewed by Darin Adler.

        Makes cross-origin properties enumerable on Window and Location objects
        as per:
        - https://github.com/whatwg/html/pull/2777

        This simplifies our code quite a bit.

        No new tests, updated existing tests.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):
        (WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
        (WebCore::JSDOMWindow::getOwnPropertyNames):
        * bindings/js/JSLocationCustom.cpp:
        (WebCore::getOwnPropertySlotCommon):
        (WebCore::JSLocation::getOwnPropertyNames):
        * bindings/scripts/CodeGeneratorJS.pm:
        (GenerateHeader):

2017-07-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>

        [EME] Build failure with Clang-3.8 on InitDataRegistry.cpp
        https://bugs.webkit.org/show_bug.cgi?id=174628

        Reviewed by Žan Doberšek.

        * Modules/encryptedmedia/InitDataRegistry.cpp:
        (WebCore::extractKeyIDsKeyids): Add an explicit cast to unsigned.

2017-07-19  Matt Lewis  <jlewis3@apple.com>

        Unreviewed, rolling out r219646.

        The test added are failing on all platforms

        Reverted changeset:

        "Setting the minimum font size preference doesn’t affect
        absolute line-height values, so lines overlap"
        https://bugs.webkit.org/show_bug.cgi?id=174406
        http://trac.webkit.org/changeset/219646

2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>

        [WTF] Implement WTF::ThreadGroup
        https://bugs.webkit.org/show_bug.cgi?id=174081

        Reviewed by Mark Lam.

        * page/ResourceUsageThread.h:

2017-07-18  Andy Estes  <aestes@apple.com>

        [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
        https://bugs.webkit.org/show_bug.cgi?id=174631

        Reviewed by Tim Horton.

        * Configurations/Base.xcconfig:
        * rendering/Grid.cpp:
        (WebCore::Grid::insert):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::write):
        * rendering/SimpleLineLayoutCoverage.cpp:
        (WebCore::SimpleLineLayout::printSimpleLineLayoutCoverage):

2017-07-18  Yusuke Suzuki  <utatane.tea@gmail.com>

        WTF::Thread should have the threads stack bounds.
        https://bugs.webkit.org/show_bug.cgi?id=173975

        Reviewed by Mark Lam.

        When creating WebThread, we first allocate WebCore::ThreadGlobalData in UI thread
        and share it with WebThread.
        The problem is that WebCore::ThreadGlobalData has CachedResourceRequestInitiators.
        It allocates AtomicString, which requires WTFThreadData.

        In this patch, we call WTF::initializeThreading() before allocating WebCore::ThreadGlobalData.
        And we also call AtomicString::init() before calling WebCore::ThreadGlobalData since
        WebCore::ThreadGlobalData allocates AtomicString.

        * platform/ios/wak/WebCoreThread.mm:
        (StartWebThread):

2017-07-18  Myles C. Maxfield  <mmaxfield@apple.com>

        Setting the minimum font size preference doesn’t affect absolute line-height values, so lines overlap
        https://bugs.webkit.org/show_bug.cgi?id=174406
        <rdar://problem/10139227>

        Reviewed by Simon Fraser.

        When the minimumFontSize API preference is set, we will increase the font size without increasing
        the line height. If the content specifies line-height as an absolute value, there can be two
        unfortunate results:

        - Adjacent lines in a paragraph can overlap
        - If the paragraph (or containin block or whatever) uses overflow: hidden, the first and last lines
        can be cut off and potentially indecipherable.

        Instead, we should use the minimum font size preference as a signal that we should increase the
        line-height as well as the font-size. Eventually, we will want to increase it by an amount
        proportional to the increase in font-size (which can be due to minimumFontSize, minimumLogicalFontSize,
        text autosizing, etc.). However, because minimumLogicalFontSize is on by default, this would cause
        a behavior change on many webpages which use small text, so such a change would be too risky right now.
        Instead, we can pretend that minimumFontSize is the only cause that text increases, and use this as the
        only signal to boost the corresponding line-height.

        Tests: fast/text/line-height-minimumFontSize-text-zoom.html
               fast/text/line-height-minimumFontSize-visual.html
               fast/text/line-height-minimumFontSize-zoom.html
               fast/text/line-height-minimumFontSize.html
               fast/text/line-height-minimumFontSize-autosize.html

        * css/StyleBuilderCustom.h:
        (WebCore::computeBaseSpecifiedFontSize):
        (WebCore::computeLineHeightMultiplierDueToFontSize):
        (WebCore::StyleBuilderCustom::applyValueLineHeight):
        (WebCore::StyleBuilderCustom::applyValueFill):
        (WebCore::StyleBuilderCustom::applyValueStroke):
        (WebCore::StyleBuilderCustom::applyValueContent):
        * rendering/TextAutoSizing.cpp:

2017-07-18  Zalan Bujtas  <zalan@apple.com>

        Media controls are missing content in fullscreen when document has scroll offset.
        https://bugs.webkit.org/show_bug.cgi?id=174644
        <rdar://problem/32415323>

        Reviewed by Simon Fraser.

        If a non-user initiated scrolling (result of resize for example) is processed asynchronously, it might
        leapfrog other, programatic scrollings and trigger unintentional scroll offsets (and turn into unwanted clippings). 
        This patch ensures that both resize and top content inset change are translated into programatic scrolling. 

        Unable to test full screen video.

        * page/FrameView.cpp:
        (WebCore::FrameView::setFrameRect):
        (WebCore::FrameView::topContentInsetDidChange):

2017-07-18  Andy Estes  <aestes@apple.com>

        [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
        https://bugs.webkit.org/show_bug.cgi?id=174631

        Reviewed by Sam Weinig.

        * Configurations/Base.xcconfig:
        * platform/ios/PlatformPasteboardIOS.mm:
        (WebCore::PlatformPasteboard::write):

2017-07-18  Ali Juma  <ajuma@chromium.org>

        Align quirky number parsing with other browsers
        https://bugs.webkit.org/show_bug.cgi?id=155874

        Reviewed by Simon Fraser.

        Parse unit-less non-zero values for animation-duration and transition-duration
        as invalid time values in quirks mode.

        Test: fast/css/animation-transition-duration-quirksmode.html

        * css/parser/CSSPropertyParser.cpp:
        (WebCore::consumeAnimationValue):

2017-07-18  Chris Dumez  <cdumez@apple.com>

        HysteresisActivity cannot be used in the UIProcess
        https://bugs.webkit.org/show_bug.cgi?id=174643
        <rdar://problem/33086442>

        Reviewed by Tim Horton.

        Port HysteresisActivity to RunLoop::Timer so that it can safely be used in
        the UIProcess as well.

        * platform/HysteresisActivity.h:

2017-07-18  Joseph Pecoraro  <pecoraro@apple.com>

        Web Inspector: Modernize InjectedScriptSource
        https://bugs.webkit.org/show_bug.cgi?id=173890

        Reviewed by Brian Burg.

        Covered by existing tests.

        * inspector/CommandLineAPIModuleSource.js:
        (CommandLineAPIImpl.prototype.copy):
        (CommandLineAPIImpl.prototype._inspect):
        Use RemoteObject, a new parameter.

2017-07-18  Ryosuke Niwa  <rniwa@webkit.org>

        REGRESSION(r218910): Crash when password field changes to text field
        https://bugs.webkit.org/show_bug.cgi?id=174560

        Reviewed by Zalan Bujtas.

        The crash was caused by textMarkerDataForFirstPositionInTextControl accessing a nullptr returned by getOrCreate.
        Unfortunately, in order to this fix bug while preserving the exact behavior would require synchronously creating
        a renderer for the editing host when the input type changed since we can't create an accessbility object out of
        a renderer-less node.

        Instead, revert back to pre-r218910 behavior of always using the text control element's axID when notifying
        the value change. While this is inconsistent with the way editing commands report content changes, I've since
        learned that VoiceOver has code to deal with this exact situation.

        Test: accessibility/mac/input-type-change-crash-2.html

        * accessibility/AXObjectCache.cpp:
        (WebCore::AXObjectCache::textMarkerDataForFirstPositionInTextControl):

2017-07-18  Matt Baker  <mattbaker@apple.com>

        Web Inspector: Refactoring: replace InspectorCanvasAgent::CanvasEntry with a helper class
        https://bugs.webkit.org/show_bug.cgi?id=174311

        Reviewed by Devin Rousso.

        This patch adds a helper class for tracking canvases and their data. The
        current approach of defining a helper structure in the agent's header is
        awkward to use and maintain, and won't scale well as more canvas instrumentation
        points and data are added.

        * CMakeLists.txt:
        * WebCore.xcodeproj/project.pbxproj:
        New file.

        * inspector/InspectorCanvas.cpp: Added.
        (WebCore::InspectorCanvas::create):
        (WebCore::InspectorCanvas::InspectorCanvas):
        (WebCore::InspectorCanvas::buildObjectForCanvas):
        * inspector/InspectorCanvas.h: Added.

        * inspector/InspectorCanvasAgent.cpp:
        (WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
        (WebCore::InspectorCanvasAgent::enable):
        (WebCore::InspectorCanvasAgent::requestNode):
        (WebCore::InspectorCanvasAgent::requestContent):
        (WebCore::InspectorCanvasAgent::requestCSSCanvasClientNodes):
        (WebCore::InspectorCanvasAgent::resolveCanvasContext):
        (WebCore::InspectorCanvasAgent::frameNavigated):
        (WebCore::InspectorCanvasAgent::didCreateCSSCanvas):
        (WebCore::InspectorCanvasAgent::didChangeCSSCanvasClientNodes):
        (WebCore::InspectorCanvasAgent::didCreateCanvasRenderingContext):
        (WebCore::InspectorCanvasAgent::didChangeCanvasMemory):
        (WebCore::InspectorCanvasAgent::canvasDestroyed):
        (WebCore::InspectorCanvasAgent::canvasDestroyedTimerFired):
        (WebCore::InspectorCanvasAgent::clearCanvasData):
        (WebCore::InspectorCanvasAgent::unbindCanvas):
        (WebCore::InspectorCanvasAgent::assertInspectorCanvas):
        (WebCore::InspectorCanvasAgent::findInspectorCanvas):
        (WebCore::InspectorCanvasAgent::getCanvasEntry): Deleted.
        (WebCore::InspectorCanvasAgent::buildObjectForCanvas): Deleted.
        * inspector/InspectorCanvasAgent.h:

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        Remove unused constructor argument.

2017-07-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>

        [Curl] Move detail implementation from ResourceHandle to ResourceHandleInternal
        https://bugs.webkit.org/show_bug.cgi?id=174641

        After moving stuff from ResourceHandleManager to ResourceHandle on 
        https://bugs.webkit.org/show_bug.cgi?id=173630, still there're many violation
        remains between ResourceHandle and ResourceHandleInternal classes.
        Many of implementation detail should be move to ResourceHandleInternal
        to improve build speed.

        Reviewed by Alex Christensen.

        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/curl/ResourceHandleCurl.cpp:
        (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::cancel):
        (WebCore::ResourceHandleInternal::initialize):
        (WebCore::ResourceHandleInternal::applyAuthentication):
        (WebCore::ResourceHandleInternal::setupPUT):
        (WebCore::ResourceHandleInternal::setupPOST):
        (WebCore::ResourceHandleInternal::setupFormData):
        (WebCore::ResourceHandle::platformSetDefersLoading):
        (WebCore::ResourceHandleInternal::didFinish):
        (WebCore::ResourceHandleInternal::didFail):
        (WebCore::ResourceHandleInternal::calculateWebTimingInformations):
        (WebCore::ResourceHandleInternal::handleLocalReceiveResponse):
        (WebCore::ResourceHandleInternal::willPrepareSendData):
        (WebCore::ResourceHandleInternal::didReceiveHeaderLine):
        (WebCore::ResourceHandleInternal::didReceiveAllHeaders):
        (WebCore::ResourceHandleInternal::didReceiveContentData):
        (WebCore::ResourceHandleInternal::readCallback):
        (WebCore::ResourceHandleInternal::headerCallback):
        (WebCore::ResourceHandleInternal::writeCallback):
        (WebCore::ResourceHandle::platformLoadResourceSynchronously):
        (WebCore::ResourceHandleInternal::dispatchSynchronousJob):
        (WebCore::ResourceHandleInternal::handleDataURL):
        (WebCore::ResourceHandle::initialize): Deleted.
        (WebCore::ResourceHandle::applyAuthentication): Deleted.
        (WebCore::ResourceHandle::setupPUT): Deleted.
        (WebCore::ResourceHandle::setupPOST): Deleted.
        (WebCore::ResourceHandle::setupFormData): Deleted.
        (WebCore::ResourceHandle::didFinish): Deleted.
        (WebCore::ResourceHandle::didFail): Deleted.
        (WebCore::ResourceHandle::calculateWebTimingInformations): Deleted.
        (WebCore::ResourceHandle::handleLocalReceiveResponse): Deleted.
        (WebCore::ResourceHandle::willPrepareSendData): Deleted.
        (WebCore::ResourceHandle::didReceiveHeaderLine): Deleted.
        (WebCore::ResourceHandle::didReceiveAllHeaders): Deleted.
        (WebCore::ResourceHandle::didReceiveContentData): Deleted.
        (WebCore::ResourceHandle::readCallback): Deleted.
        (WebCore::ResourceHandle::headerCallback): Deleted.
        (WebCore::ResourceHandle::writeCallback): Deleted.
        (WebCore::ResourceHandle::dispatchSynchronousJob): Deleted.
        (WebCore::ResourceHandle::handleDataURL): Deleted.

2017-07-18  Andy Estes  <aestes@apple.com>

        [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
        https://bugs.webkit.org/show_bug.cgi?id=174631

        Reviewed by Dan Bernstein.

        * Configurations/Base.xcconfig:

2017-07-18  Antoine Quint  <graouts@apple.com>

        [macOS] Mouse pointer does not hide during fullscreen playback
        https://bugs.webkit.org/show_bug.cgi?id=174638
        <rdar://problem/33244399>

        Reviewed by Dean Jackson.

        Test: media/modern-media-controls/css/webkit-cursor-visibility-auto-hide.html

        The user-agent stylesheet sets the "-webkit-cursor-visibility" to "auto-hide" for fullscreen <video>
        elements. Since we reset the page styles, including UA styles, on .media-controls-container, we need
        to explicitly inherit this style property from the page to ensure the mouse pointer automatically
        hides in fullscreen.

        * Modules/modern-media-controls/controls/media-controls.css:
        (.media-controls-container):

2017-07-18  Sam Weinig  <sam@webkit.org>

        [WebIDL] Remove custom bindings for MockContentFilterSettings
        https://bugs.webkit.org/show_bug.cgi?id=174606

        Reviewed by Andy Estes.

        * PlatformMac.cmake:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSMockContentFilterSettingsCustom.cpp: Removed.
        Remove JSMockContentFilterSettingsCustom.

        * testing/MockContentFilterSettings.h:
        * testing/MockContentFilterSettings.idl:
        Switch from constants to IDL enums to make the bindings and tests simpler.

2017-07-18  Sam Weinig  <sam@webkit.org>

        [WebIDL] Replace some custom bindings code in JSCSSStyleDeclarationCustom.cpp with named getters/setters
        https://bugs.webkit.org/show_bug.cgi?id=174529

        Reviewed by Chris Dumez.

        * CMakeLists.txt:
        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSAllInOne.cpp:
        Add CSSStyleDeclaration.cpp

        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        Move getter / setter / getOwnProperties logic from here to CSSStyleDeclaration.cpp.

        * bindings/scripts/CodeGeneratorJS.pm:
        (GenerateGetOwnPropertySlot):
        (GenerateGetOwnPropertySlotByIndex):
        (InstanceOverridesGetOwnPropertySlot):
        (GenerateHeader):
        Remove support for no longer needed [CustomGetOwnPropertySlotAndDescriptor].
        Add support for [PutOnlyForSupportedProperties], which allows named setters to behave
        a bit more like normal setters by allowing the implementation to note which properties
        are supported which in turn, allows the bindings to continue down the normal put path
        for unsupported properties. This is necessary to mimic the behavior of CSSStyleDeclaration
        which is using named setters in place hundreds of additional properties.

        (InstanceOverridesDefineOwnProperty):
        Add [DefaultDefineOwnProperty] to allow disabling defineOwnProperty overriding that comes
        automatically with named setters. We need this for CSSStyleDeclaration since the named
        setter usage modeling real properties, not a dictionary style setter. We may want to 
        revisit this, and add support for DefineOwnProperty here, but this allows us to maintain
        the status quo.

        (GenerateDefineOwnProperty):
        Fix the case when you have a named setter, an indexed getter, but no indexed setter. In that
        case, we would get a compile error, due to the index variable being unused.

        * bindings/scripts/IDLAttributes.json:
        Remove support for no longer needed [CustomGetOwnPropertySlotAndDescriptor], add
        [PutOnlyForSupportedProperties] and [DefaultDefineOwnProperty].

        * css/CSSStyleDeclaration.h:
        * css/CSSStyleDeclaration.cpp: Added.
        (WebCore::CSSStyleDeclaration::namedItem):
        (WebCore::CSSStyleDeclaration::setNamedItem):
        (WebCore::CSSStyleDeclaration::isSupportedPropertyName):
        (WebCore::CSSStyleDeclaration::supportedPropertyNames):
        Use standard getter / setter functions to implement CSS property name getting and setting.
        Convert from Identifier to AtomicString, which are now bridgeable.

        * css/CSSStyleDeclaration.idl:
        Add named getter and setter. Remove [CustomGetOwnPropertyNames], [CustomGetOwnPropertySlotAndDescriptor]
        and [CustomPut], add [DefaultDefineOwnProperty].

        * bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp: Added.
        * bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.h: Added.
        * bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp: Added.
        * bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.h: Added.
        * bindings/scripts/test/TestNamedSetterWithIndexedGetter.idl: Added.
        * bindings/scripts/test/TestNamedSetterWithIndexedGetterAndSetter.idl: Added.
        Add tests for improved behavior when using named setters with variations of indexed getters and setters as well.

2017-07-18  Antoine Quint  <graouts@apple.com>

        [iOS] WebKit media controls are sometimes shown after exiting full screen on vimeo.com
        https://bugs.webkit.org/show_bug.cgi?id=174627
        <rdar://problem/33301005>

        Reviewed by Dean Jackson, provisionally reviewed by Jeremy Jones.

        On iOS 11, both the WebKit media controls and the Vimeo custom controls would appear sometimes when exiting
        from fullscreen when the video was playing and the user would tap the X button, which would pause the video
        as well as exit fullscreen.

        The reason this happens is that the ControlsVisibilitySupport object, which governs whether the WebKit media
        controls should be displayed for a given video, woud listen to "pause" and "webkitfullscreenchange" events
        and determine whether to show the WebKit media controls. We listen to the "pause" event because when media
        pauses, and the video has the "controls" attribute set, we should show the controls and suspend the controls
        auto-hide timer. And we're interested in knowing when we enter and exit fullscreen because we want to override
        the "controls" attribute not being set when we enter fullscreen.

        However, on iOS 11, it appears that the "webkitfullscreenchange" event is not reliably fired as the user enters
        and exits fullscreen, which is tracked by webkit.org/b/174626. So, when the user exits fullscreen, we would be
        informed of the video being paused via a "pause" event, but not of the video exiting fullscreen. And because
        media events are asynchronous, the "pause" event would sometimes be fired before we exited fullscreen, and when
        the _updateControls() would run, we would sometimes determine that we are in fullscreen still and determine
        that the WebKit media controls should be shown.

        Of course, on iOS, the WebKit media controls are not shown and instead we delegate to AVKit to display media controls.
        So we could simply disregard this whole logic in iOS. But we choose to instead use the "webkitpresentationmodechanged"
        when the presentation mode API is supported, as is the case on iOS 11, to determine changes of media fullscreen state.
        This way, should we ever choose to support fullscreen media controls provided by WebKit on iOS, this logic is already
        correct and we write less platform-specific code.

        This, alas, cannot be tested since we can't force the X button to be tapped within the AVKit fullscreen controls.

        * Modules/modern-media-controls/media/controls-visibility-support.js:
        (ControlsVisibilitySupport.prototype.get mediaEvents):
        * Modules/modern-media-controls/media/media-controller.js:
        (MediaController):
        * Modules/modern-media-controls/media/start-support.js:
        (StartSupport.prototype.get mediaEvents):

2017-07-18  Matt Lewis  <jlewis3@apple.com>

        Unreviewed, rolling out r219610.

        This caused an api failure on all platforms for the test
        SnapshotImageLargeAsyncDecoding

        Reverted changeset:

        "Async image decoding for large images should be disabled
        after the first time a tile is painted"
        https://bugs.webkit.org/show_bug.cgi?id=174451
        http://trac.webkit.org/changeset/219610

2017-07-18  Devin Rousso  <drousso@apple.com>

        Add CanvasRenderingContext2D::getTransform
        https://bugs.webkit.org/show_bug.cgi?id=174278

        Reviewed by Dean Jackson.

        Tests: fast/canvas/2d.getTransform.modification.html
               fast/canvas/2d.getTransform.newobject.html
               fast/canvas/2d.setTransform.matrix.html

        * css/DOMMatrixReadOnly.h:
        Make DOMMatrixReadOnly::validateAndFixup public so that values of DOMMatrixInit are still
        usable without having to construct a DOMMatrixReadOnly. This is beneficial in the case that
        an exception is thrown, as the validateAndFixup check can happen without any allocations.

        * html/canvas/CanvasRenderingContext2D.idl:
        * html/canvas/CanvasRenderingContext2D.h:
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::getTransform):
        (WebCore::CanvasRenderingContext2D::setTransform):

2017-07-18  Andy Estes  <aestes@apple.com>

        [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
        https://bugs.webkit.org/show_bug.cgi?id=174631

        Reviewed by Darin Adler.

        * Configurations/Base.xcconfig:

2017-07-18  Jonathan Bedard  <jbedard@apple.com>

        Unreviewed build fix after r219595

        * platform/graphics/cocoa/FontDescriptionCocoa.cpp:
&nbs