Fix a merge error in r149007 (was missing a null check added in r148777).
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2013-04-24  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Fix a merge error in r149007 (was missing a null check added in r148777).
4
5         * rendering/LogicalSelectionOffsetCaches.h:
6         (WebCore::containingBlockForAbsolutePosition):
7
8 2013-04-24  Otto Derek Cheung  <otcheung@rim.com>
9
10         Battery API won't return updated battery status until client calls didChangeBatteryStatus
11         https://bugs.webkit.org/show_bug.cgi?id=114891
12
13         Reviewed by Rob Buis.
14
15         The BatteryStatus object in BatteryManager won't get updated until BatteryClient calls
16         didChangeBatteryStatus in BatteryController. Any attempts to call webkitBattery.charged()
17         or other get functions will always return the default values until the next battery status
18         change object gets passed to the controller.
19
20         We need to update the manager when we attach it to the controller, and update all
21         existing managers when the controller receives it's first battery status object.
22
23         * Modules/battery/BatteryController.cpp:
24         (WebCore::BatteryController::addListener):
25         (WebCore::BatteryController::updateBatteryStatus):
26         * Modules/battery/BatteryManager.cpp:
27         (WebCore::BatteryManager::didChangeBatteryStatus):
28         (WebCore::BatteryManager::updateBatteryStatus):
29         (WebCore):
30         * Modules/battery/BatteryManager.h:
31         (BatteryManager):
32
33 2013-04-24  Jacky Jiang  <zhajiang@blackberry.com>
34
35         Clean up unused code in ViewportArguments.h
36         https://bugs.webkit.org/show_bug.cgi?id=115121
37
38         Reviewed by Benjamin Poulain.
39
40         The target-densityDPI emulation implementation has been removed by
41         r147893, so clean up the remaining code as well.
42
43         * dom/ViewportArguments.h:
44
45 2013-04-24  Andreas Kling  <akling@apple.com>
46
47         ElementData should use 'unsigned' attribute indices.
48         <http://webkit.org/b/115103>
49
50         Reviewed by Antti Koivisto.
51
52         Switch to using 'unsigned' for attribute indices. This gives consistent behavior
53         on 32/64-bit, and the underlying storage is already limited by Vector's 32-bit capacity.
54
55         Added an ElementData::attributeNotFound constant (-1) since we can't use WTF::notFound.
56
57         * dom/Element.cpp:
58         (WebCore::Element::detachAttribute):
59         (WebCore::Element::removeAttribute):
60         (WebCore::Element::setAttribute):
61         (WebCore::Element::setSynchronizedLazyAttribute):
62         (WebCore::Element::setAttributeInternal):
63         (WebCore::Element::setAttributeNode):
64         (WebCore::Element::removeAttributeNode):
65         (WebCore::Element::removeAttributeInternal):
66         (WebCore::UniqueElementData::removeAttribute):
67         (WebCore::ElementData::getAttributeItemIndexSlowCase):
68         * dom/Element.h:
69         (ElementData):
70         (UniqueElementData):
71         (Element):
72         (WebCore::Element::getAttributeItemIndex):
73         (WebCore::Element::attributeCount):
74         (WebCore::ElementData::length):
75         (WebCore::ElementData::getAttributeItem):
76         (WebCore::ElementData::getAttributeItemIndex):
77         * dom/NamedNodeMap.cpp:
78         (WebCore::NamedNodeMap::removeNamedItem):
79         (WebCore::NamedNodeMap::removeNamedItemNS):
80         (WebCore::NamedNodeMap::length):
81         * dom/NamedNodeMap.h:
82         (NamedNodeMap):
83
84 2013-04-24  Andreas Kling  <akling@apple.com>
85
86         ElementData::attributeItem() should bounds-check the index.
87         <http://webkit.org/b/115076>
88
89         Reviewed by Antti Koivisto.
90
91         Switch the ASSERT_WITH_SECURITY_IMPLICATION to a RELEASE_ASSERT.
92
93         * dom/Element.h:
94         (WebCore::ElementData::attributeItem):
95
96 2013-04-23  Andreas Kling  <akling@apple.com>
97
98         Setting an inline style property to "" shouldn't cause style recalc unless the property was present.
99         <http://webkit.org/b/115122>
100
101         Reviewed by Antti Koivisto.
102
103         StylePropertySet::setProperty() handles empty strings by removing the property entirely.
104         If there was no property to remove, it shouldn't claim that it changed something, as that
105         will cause the CSSOM wrapper to mark the element for style recalc.
106
107         A common idiom that triggers this is excessive use of { element.style.display = ''; }
108
109         * css/StylePropertySet.cpp:
110         (WebCore::MutableStylePropertySet::setProperty):
111
112 2013-04-23  Ryosuke Niwa  <rniwa@webkit.org>
113
114         Moving word boundaries backwards fails when there is a text node starting with an apostrophe
115         https://bugs.webkit.org/show_bug.cgi?id=115070
116
117         Reviewed by Alexey Proskuryakov.
118
119         The bug was caused by previousBoundary erroneously assuming that we don't need any more context if a word
120         boundary is found at the beginning of a string. For example, when "I'll" is split into two text nodes,
121         "I" and "'ll", there is a word boundary between "'" and "ll" in "'ll" so we need to examine the whole "I'll".
122
123         Fixed the bug by obtaining more context when the character starts exactly at offset 1 in a text node to
124         work around this bug. In the long term, we probably need to provide Foundation of the entire context since in
125         languages like Hebrew and some of European languages, there could be many accents and combining characters
126         between split into multiple text nodes as one variant is seen in the newly added test case.
127
128         Test: editing/selection/previous-word-boundary-across-text-nodes.html
129
130         * editing/VisibleUnits.cpp:
131         (WebCore::previousBoundary):
132
133 2013-04-24  Benjamin Poulain  <bpoulain@apple.com>
134
135         Do not use static string in DiagnosticLoggingKeys
136         https://bugs.webkit.org/show_bug.cgi?id=115093
137
138         Reviewed by Andreas Kling.
139
140         The code is not hot enough to justify keeping the memory around.
141         This removes 3kb from the binary on x86_64.
142
143         * page/DiagnosticLoggingKeys.cpp:
144         (WebCore::DiagnosticLoggingKeys::mediaLoadedKey):
145         (WebCore::DiagnosticLoggingKeys::mediaLoadingFailedKey):
146         (WebCore::DiagnosticLoggingKeys::pluginLoadedKey):
147         (WebCore::DiagnosticLoggingKeys::pluginLoadingFailedKey):
148         (WebCore::DiagnosticLoggingKeys::pageContainsPluginKey):
149         (WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOnePluginKey):
150         (WebCore::DiagnosticLoggingKeys::pageContainsMediaEngineKey):
151         (WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOneMediaEngineKey):
152         (WebCore::DiagnosticLoggingKeys::passKey):
153         (WebCore::DiagnosticLoggingKeys::failKey):
154         (WebCore::DiagnosticLoggingKeys::noopKey):
155         * page/DiagnosticLoggingKeys.h:
156         (DiagnosticLoggingKeys):
157
158 2013-04-24  Benjamin Poulain  <benjamin@webkit.org>
159
160         Remove wxWebKit #ifdefs from WebCore/platform/graphics
161         https://bugs.webkit.org/show_bug.cgi?id=115081
162
163         Reviewed by Geoffrey Garen.
164
165         * platform/graphics/BitmapImage.h:
166         (BitmapImage):
167         * platform/graphics/Color.h:
168         (Color):
169         * platform/graphics/FloatRect.h:
170         (FloatRect):
171         * platform/graphics/FloatSize.h:
172         (FloatSize):
173         * platform/graphics/FontPlatformData.h:
174         * platform/graphics/GlyphBuffer.h:
175         (WebCore):
176         (WebCore::GlyphBuffer::glyphAt):
177         (WebCore::GlyphBuffer::add):
178         * platform/graphics/Gradient.h:
179         * platform/graphics/GraphicsContext.h:
180         (GraphicsContext):
181         * platform/graphics/Image.cpp:
182         (WebCore::Image::drawTiled):
183         * platform/graphics/ImageBufferData.h:
184         * platform/graphics/IntPoint.h:
185         (IntPoint):
186         * platform/graphics/IntRect.h:
187         * platform/graphics/IntSize.h:
188         (IntSize):
189         * platform/graphics/NativeImagePtr.h:
190         (WebCore):
191         * platform/graphics/Path.h:
192         * platform/graphics/Pattern.h:
193         * platform/graphics/SimpleFontData.h:
194         (SimpleFontData):
195         (WebCore::SimpleFontData::widthForGlyph):
196         * platform/graphics/mac/ComplexTextController.cpp:
197         (WebCore::ComplexTextController::collectComplexTextRuns):
198         * platform/graphics/mac/ComplexTextControllerCoreText.mm:
199         (WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
200         * platform/graphics/transforms/AffineTransform.h:
201         (AffineTransform):
202         * platform/graphics/transforms/TransformationMatrix.h:
203         (TransformationMatrix):
204
205 2013-04-24  Benjamin Poulain  <benjamin@webkit.org>
206
207         Remove wxWebKit #ifdefs from WebCore/plugins
208         https://bugs.webkit.org/show_bug.cgi?id=115080
209
210         Reviewed by Geoffrey Garen.
211
212         * plugins/PluginView.h:
213         (PluginView):
214         * plugins/mac/PluginViewMac.mm:
215         (WebCore::nativeWindowFor):
216         (WebCore::cgHandleFor):
217         (WebCore::topLevelOffsetFor):
218         (WebCore::PluginView::platformStart):
219         * plugins/win/PluginViewWin.cpp:
220         (windowHandleForPageClient):
221         (WebCore::PluginView::handleMouseEvent):
222         (WebCore::PluginView::platformStart):
223         (WebCore::PluginView::snapshot):
224
225 2013-04-24  Benjamin Poulain  <benjamin@webkit.org>
226
227         Remove wxWebKit #ifdefs from WebCore/page
228         https://bugs.webkit.org/show_bug.cgi?id=115079
229
230         Reviewed by Geoffrey Garen.
231
232         * page/FrameView.cpp:
233         (WebCore::FrameView::wheelEvent):
234         * page/Settings.cpp:
235         (WebCore):
236         * page/Settings.h:
237         (Settings):
238
239 2013-04-24  Chris Fleizach  <cfleizach@apple.com>
240
241         AX: WAI-ARIA landmarks no longer speak type of landmark on iOS
242         https://bugs.webkit.org/show_bug.cgi?id=114547
243
244         Reviewed by David Kilzer.
245
246         We want iOS to speak the landmark type.
247         I've moved the landmark role description to the base Mac class and exposed
248         these localized strings to iOS (the ones used to return landmark descriptions).
249
250         I've also updated the accessibilityLabel to account for landmark type, but also
251         handle multiple label sources more gracefully by appending commas, which changed a few
252         tests in minor ways.
253
254         Test: platform/iphone-simulator/accessibility/landmark-type.html
255
256         * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
257         (-[WebAccessibilityObjectWrapper accessibilityLabel]):
258         * accessibility/mac/WebAccessibilityObjectWrapperBase.h:
259         * accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
260         (-[WebAccessibilityObjectWrapperBase ariaLandmarkRoleDescription]):
261         * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
262         (-[WebAccessibilityObjectWrapper roleDescription]):
263         * platform/LocalizedStrings.cpp:
264         (WebCore):
265         (WebCore::AXButtonActionVerb):
266         (WebCore::AXRadioButtonActionVerb):
267         (WebCore::AXTextFieldActionVerb):
268         (WebCore::AXCheckedCheckBoxActionVerb):
269         (WebCore::AXUncheckedCheckBoxActionVerb):
270         (WebCore::AXLinkActionVerb):
271         (WebCore::AXMenuListPopupActionVerb):
272         (WebCore::AXMenuListActionVerb):
273         * platform/LocalizedStrings.h:
274         (WebCore):
275
276 2013-04-24  Andreas Kling  <akling@apple.com>
277
278         CSS attribute selectors cause unnecessary style recalc when setting attribute to same value.
279         <http://webkit.org/b/115116>
280         <rdar://problem/13727709>
281
282         Reviewed by Simon Fraser.
283
284         The logic that dirties the style if there's a relevant attribute selector in the document
285         shouldn't run if the attribute is being overwritten with an identical value.
286         Move this into willModifyAttribute() instead, since we need access to both the old and the new value.
287
288         This reduces unnecessary style recalculation in Mac App Store content.
289
290         * dom/Element.cpp:
291         (WebCore::Element::attributeChanged):
292         (WebCore::Element::willModifyAttribute):
293
294 2013-04-24  Jonathan Feldstein <jfeldstein@blackberry.com>
295
296         [BlackBerry] Fixes the San Angeles demo on khronos.org
297         https://bugs.webkit.org/show_bug.cgi?id=115106
298
299         Reviewed by Rob Buis
300         Internally Reviewed by Jeremy Nicholl and Arvid Nilsson
301
302         Fixes a bug in which the currently bound vertex array object's vertex array
303         state was being modified as opposed to the default vertex array state.
304
305         * platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:
306         (EGLImageLayerWebKitThread::blitToFrontBuffer):
307
308 2013-04-24  Nico Weber  <thakis@chromium.org>
309
310         Fold RenderThemeMacShared into RenderThemeMac
311         https://bugs.webkit.org/show_bug.cgi?id=115086
312
313         Reviewed by Anders Carlsson.
314
315         No intended functionality change.
316
317         * WebCore.xcodeproj/project.pbxproj:
318         * rendering/RenderThemeMac.h:
319         (RenderThemeMac):
320         (WebCore::RenderThemeMac::supportsControlTints):
321         (WebCore::RenderThemeMac::scrollbarControlSizeForPart):
322         (WebCore::RenderThemeMac::supportsSelectionForegroundColors):
323         (WebCore::RenderThemeMac::supportsClosedCaptioning):
324         (WebCore::RenderThemeMac::updateActiveState):
325         * rendering/RenderThemeMac.mm:
326         (-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
327         (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]):
328         (-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:]):
329         (WebCore::RenderThemeMac::RenderThemeMac):
330         (WebCore::RenderThemeMac::~RenderThemeMac):
331         (WebCore::RenderThemeMac::platformActiveSelectionBackgroundColor):
332         (WebCore):
333         (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor):
334         (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor):
335         (WebCore::RenderThemeMac::platformActiveListBoxSelectionForegroundColor):
336         (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor):
337         (WebCore::RenderThemeMac::platformFocusRingColor):
338         (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):
339         (WebCore::toFontWeight):
340         (WebCore::RenderThemeMac::systemFont):
341         (WebCore::convertNSColorToColor):
342         (WebCore::menuBackgroundColor):
343         (WebCore::RenderThemeMac::platformColorsDidChange):
344         (WebCore::RenderThemeMac::systemColor):
345         (WebCore::RenderThemeMac::usesTestModeFocusRingColor):
346         (WebCore::RenderThemeMac::isControlStyled):
347         (WebCore::RenderThemeMac::adjustRepaintRect):
348         (WebCore::RenderThemeMac::inflateRect):
349         (WebCore::RenderThemeMac::convertToPaintingRect):
350         (WebCore::RenderThemeMac::updateCheckedState):
351         (WebCore::RenderThemeMac::updateEnabledState):
352         (WebCore::RenderThemeMac::updateFocusedState):
353         (WebCore::RenderThemeMac::updatePressedState):
354         (WebCore::RenderThemeMac::controlSupportsTints):
355         (WebCore::RenderThemeMac::controlSizeForFont):
356         (WebCore::RenderThemeMac::setControlSize):
357         (WebCore::RenderThemeMac::sizeForFont):
358         (WebCore::RenderThemeMac::sizeForSystemFont):
359         (WebCore::RenderThemeMac::setSizeFromFont):
360         (WebCore::RenderThemeMac::setFontFromControlSize):
361         (WebCore::RenderThemeMac::controlSizeForSystemFont):
362         (WebCore::RenderThemeMac::paintTextField):
363         (WebCore::RenderThemeMac::adjustTextFieldStyle):
364         (WebCore::RenderThemeMac::paintCapsLockIndicator):
365         (WebCore::RenderThemeMac::paintTextArea):
366         (WebCore::RenderThemeMac::adjustTextAreaStyle):
367         (WebCore::RenderThemeMac::popupButtonMargins):
368         (WebCore::RenderThemeMac::popupButtonSizes):
369         (WebCore::RenderThemeMac::popupButtonPadding):
370         (WebCore::RenderThemeMac::paintMenuList):
371         (WebCore::RenderThemeMac::meterSizeForBounds):
372         (WebCore::RenderThemeMac::paintMeter):
373         (WebCore::RenderThemeMac::supportsMeter):
374         (WebCore::RenderThemeMac::levelIndicatorStyleFor):
375         (WebCore::RenderThemeMac::levelIndicatorFor):
376         (WebCore::RenderThemeMac::progressBarSizes):
377         (WebCore::RenderThemeMac::progressBarMargins):
378         (WebCore::RenderThemeMac::minimumProgressBarHeight):
379         (WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar):
380         (WebCore::RenderThemeMac::animationDurationForProgressBar):
381         (WebCore::RenderThemeMac::adjustProgressBarStyle):
382         (WebCore::RenderThemeMac::paintProgressBar):
383         (WebCore::TopGradientInterpolate):
384         (WebCore::BottomGradientInterpolate):
385         (WebCore::MainGradientInterpolate):
386         (WebCore::TrackGradientInterpolate):
387         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
388         (WebCore::RenderThemeMac::paintMenuListButton):
389         (WebCore::menuListButtonSizes):
390         (WebCore::RenderThemeMac::adjustMenuListStyle):
391         (WebCore::RenderThemeMac::popupInternalPaddingLeft):
392         (WebCore::RenderThemeMac::popupInternalPaddingRight):
393         (WebCore::RenderThemeMac::popupInternalPaddingTop):
394         (WebCore::RenderThemeMac::popupInternalPaddingBottom):
395         (WebCore::RenderThemeMac::adjustMenuListButtonStyle):
396         (WebCore::RenderThemeMac::setPopupButtonCellState):
397         (WebCore::RenderThemeMac::menuListSizes):
398         (WebCore::RenderThemeMac::minimumMenuListSize):
399         (WebCore::RenderThemeMac::adjustSliderTrackStyle):
400         (WebCore::RenderThemeMac::paintSliderTrack):
401         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
402         (WebCore::RenderThemeMac::paintSliderThumb):
403         (WebCore::RenderThemeMac::paintSearchField):
404         (WebCore::RenderThemeMac::setSearchCellState):
405         (WebCore::RenderThemeMac::searchFieldSizes):
406         (WebCore::RenderThemeMac::setSearchFieldSize):
407         (WebCore::RenderThemeMac::adjustSearchFieldStyle):
408         (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
409         (WebCore::RenderThemeMac::cancelButtonSizes):
410         (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
411         (WebCore::RenderThemeMac::resultsButtonSizes):
412         (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
413         (WebCore::RenderThemeMac::paintSearchFieldDecoration):
414         (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
415         (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
416         (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
417         (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
418         (WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):
419         (WebCore::RenderThemeMac::sliderTickSize):
420         (WebCore::RenderThemeMac::sliderTickOffsetFromTrackCenter):
421         (WebCore::RenderThemeMac::adjustSliderThumbSize):
422         (WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):
423         (WebCore::RenderThemeMac::popupButton):
424         (WebCore::RenderThemeMac::search):
425         (WebCore::RenderThemeMac::searchMenuTemplate):
426         (WebCore::RenderThemeMac::sliderThumbHorizontal):
427         (WebCore::RenderThemeMac::sliderThumbVertical):
428         (WebCore::RenderThemeMac::textField):
429         (WebCore::RenderThemeMac::fileListNameForWidth):
430         * rendering/RenderThemeMacShared.h: Removed.
431         * rendering/RenderThemeMacShared.mm: Removed.
432
433 2013-04-24  ChangSeok Oh  <changseok.oh@collabora.com>
434
435         [GTK][AC] Visible rect doesn't update after resizing a window.
436         https://bugs.webkit.org/show_bug.cgi?id=115096
437
438         Reviewed by Gustavo Noronha Silva.
439
440         Once we set actor's a clip rect, we should update the rect when resizing the actor.
441
442         No new tests since no new functionality.
443
444         * platform/graphics/clutter/GraphicsLayerClutter.cpp:
445         (WebCore::GraphicsLayerClutter::setSize):
446
447 2013-04-24  ChangSeok Oh  <changseok.oh@collabora.com>
448
449         [GTK][AC] Fix unexpected clear of ClutterContent.
450         https://bugs.webkit.org/show_bug.cgi?id=115099
451
452         Reviewed by Gustavo Noronha Silva.
453
454         adoptGRef doesn't increase a reference count. So if a actor has a valid ClutterContent,
455         it would be cleared unexpectedly by smart pointer when escaping a function.
456
457         No new tests, no functionality changed.
458
459         * platform/graphics/clutter/GraphicsLayerActor.cpp:
460         (graphicsLayerActorUpdateTexture):
461
462 2013-04-24  Alberto Garcia  <agarcia@igalia.com>
463
464         DOMFileSystemBase: fix multiple definitions in the BlackBerry port
465         https://bugs.webkit.org/show_bug.cgi?id=114950
466
467         Reviewed by Xan Lopez.
468
469         The following  methods are already defined in DOMFileSystemBlackBerry.cpp:
470
471         crackFileSystemURL()
472         createFileSystemURL()
473         isValidType()
474         supportsToURL()
475
476         * Modules/filesystem/DOMFileSystemBase.cpp:
477         (WebCore):
478
479 2013-04-24  George Staikos  <gstaikos@rim.com>
480
481         [BlackBerry] Add support for JPEG image quality during encoding.
482         https://bugs.webkit.org/show_bug.cgi?id=105773
483
484         Reviewed by Xan Lopez.
485
486         PR 271611
487         Internally reviewed by Liam Quinn.
488
489         Pass the quality flag into the encoder, with a default of 65
490
491         Covered by existing tests.
492
493         * platform/image-encoders/JPEGImageEncoder.cpp:
494         (WebCore::compressRGBABigEndianToJPEG):
495         * platform/image-encoders/JPEGImageEncoder.h:
496         (WebCore):
497
498 2013-04-24  Csaba Osztrogon√°c  <ossy@webkit.org>
499
500         Fix cast-align WebCore/platform/graphics/GraphicsContext3D.cpp on ARM
501         https://bugs.webkit.org/show_bug.cgi?id=115036
502
503         Reviewed by Benjamin Poulain.
504
505         * platform/graphics/GraphicsContext3D.cpp:
506         (WebCore):
507
508 2013-04-24  Andreas Kling  <akling@apple.com>
509
510         Remove unnecessary MutableStylePropertySet casts.
511         <http://webkit.org/b/115075>
512
513         Reviewed by Geoffrey Garen.
514
515         Get rid of some now-unneeded static_casts that were left from the StylePropertySet
516         refactoring last weekend.
517
518         * css/StylePropertySet.cpp:
519         (WebCore::MutableStylePropertySet::setProperty):
520         * editing/EditingStyle.cpp:
521         (WebCore::EditingStyle::triStateOfStyle):
522         (WebCore::EditingStyle::removeStyleFromRulesAndContext):
523
524 2013-04-24  Kangil Han  <kangil.han@samsung.com>
525
526         [Minor code cleanup] Remove duplicated condition check
527         https://bugs.webkit.org/show_bug.cgi?id=115082
528
529         Reviewed by Andreas Kling.
530
531         areRectsPartiallyAligned() has duplicated condition check, so remove it.
532
533         * page/SpatialNavigation.cpp:
534         (WebCore::areRectsPartiallyAligned):
535
536 2013-04-24  Krzysztof Wolanski  <k.wolanski@samsung.com>
537
538         [EFL] Fix build warnings caused by missing images attributes for default buttons
539         https://bugs.webkit.org/show_bug.cgi?id=114955
540
541         Reviewed by Gyuyoung Kim.
542
543         Added default image for each button from mediacontrol catalog.
544
545         No new tests, because there is no change in behavior.
546
547         * platform/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc:
548         * platform/efl/DefaultTheme/widget/mediacontrol/mutebutton/mute_button.edc:
549         * platform/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playpause_button.edc:
550         * platform/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackward_button.edc:
551         * platform/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforward_button.edc:
552         * platform/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/toggle_captions_button.edc:
553
554 2013-04-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
555
556         Unreviewed build fix with gstreamer 0.10.x after r147555.
557
558         * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
559         (webKitWebAudioSrcLoop):
560
561 == Rolled over to ChangeLog-2013-04-24 ==