Part of WebCore should use CFNetwork-based loader on Mac
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-04-27  Pratik Solanki  <psolanki@apple.com>
2
3         Reviewed by Antti Koivisto.
4
5         Part of WebCore should use CFNetwork-based loader on Mac
6         https://bugs.webkit.org/show_bug.cgi?id=51836
7
8         * Configurations/WebCore.xcconfig: Add location of CFNetwork.framework.
9         * platform/mac/SoftLinking.h:
10         * platform/network/cf/CookieJarCFNet.cpp: Soft-link in CFNetwork functions on Mac.
11
12 2011-04-27  Nikolas Zimmermann  <nzimmermann@rim.com>
13
14         Reviewed by Antti Koivisto.
15
16         Cleanup CSSStyleApplyProperty.cpp
17         https://bugs.webkit.org/show_bug.cgi?id=59623
18
19         As first step remove ApplyPropertyColorBase, merge it with ApplyPropertyColor, there's no need for two seperated classes.
20         Use typedefs instead of repating the function pointer declarations in a few places.
21
22         * css/CSSStyleApplyProperty.cpp:
23         (WebCore::ApplyPropertyDefault::ApplyPropertyDefault):
24         (WebCore::ApplyPropertyColor::ApplyPropertyColor):
25         (WebCore::ApplyPropertyColor::applyInheritValue):
26         (WebCore::ApplyPropertyColor::applyInitialValue):
27         (WebCore::ApplyPropertyColor::applyValue):
28         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
29
30 2011-04-27  Dan Bernstein  <mitz@apple.com>
31
32         Reviewed by Anders Carlsson.
33
34         <rdar://problem/9335973> REGRESSION (r84341): Buttons in the Mac App store are rendered incorrectly
35         https://bugs.webkit.org/show_bug.cgi?id=59622
36
37         Test: fast/borders/border-image-trumps-radius.html
38
39         * rendering/RenderBox.cpp:
40         (WebCore::RenderBox::determineBackgroundBleedAvoidance): If there is a renderable, loaded border
41         image, then border radius is ignored, so no bleed avoidance is needed.
42         * rendering/RenderObject.cpp:
43         (WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Added. Moved some logic here from...
44         (WebCore::RenderObject::mustRepaintBackgroundOrBorder): ...here.
45         * rendering/RenderObject.h:
46
47 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
48
49         Reviewed by Xan Lopez.
50
51         [GTK] editing/pasteboard/copy-standalone-image.html fails
52         https://bugs.webkit.org/show_bug.cgi?id=53645
53
54         When writing an image to the clipboard, also write the URL and title
55         into the markup and URL portion. This change also abstracts a helper
56         imageToMarkup into markup.{cpp/h} from several different locations
57         throughout the platform layer.
58
59         * editing/markup.h: Added new function definition.
60         * editing/markup.cpp:
61         (WebCore::imageToMarkup): Add this function which turns an image URL 
62         and element into some markup representing that image, while preserving
63         non-src attributes.
64         * platform/chromium/ClipboardChromium.cpp: Move the imageToMarkup helper
65         to markup.cpp.
66         * platform/gtk/PasteboardGtk.cpp:
67         (WebCore::getURLForImageNode): Add this helper which gets the appropriate
68         image URL for a variety of image tag types.
69         (WebCore::Pasteboard::writeImage): Write the image URL and title to the
70         markup and URL portions of the clipboard. This will ensure that images
71         paste properly back into WebKit.
72         * platform/win/ClipboardWin.cpp: Remove the imageToMarkup helper and the
73         one from markup.h
74
75 2011-04-27  Steve Block  <steveblock@google.com>
76
77         Reviewed by David Levin.
78
79         Remove Android build system
80         https://bugs.webkit.org/show_bug.cgi?id=48111
81
82         This is to avoid the maintenance burden until the Android port is
83         fully upstreamed.
84
85         No new tests, build change only.
86
87         * Android.derived.jscbindings.mk: Removed.
88         * Android.derived.mk: Removed.
89         * Android.derived.v8bindings.mk: Removed.
90         * Android.jscbindings.mk: Removed.
91         * Android.mk: Removed.
92         * Android.v8bindings.mk: Removed.
93
94 2011-04-27  Darin Adler  <darin@apple.com>
95
96         Reviewed by Sam Weinig.
97
98         Somehow about:blank gets into the icon database
99         https://bugs.webkit.org/show_bug.cgi?id=58067
100         rdar://problem/6751446
101
102         Implemented the policy Brady suggested, where only http and https URLs can
103         be associated with and icon, guarding both on the way in to the database,
104         and on the way out.
105
106         * loader/icon/IconDatabase.cpp:
107         (WebCore::pageCanHaveIcon): Added.
108         (WebCore::IconDatabase::synchronousIconForPageURL): Call pageCanHaveIcon
109         instead of just checking for an empty URL.
110         (WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto.
111         (WebCore::IconDatabase::retainIconForPageURL): Ditto.
112         (WebCore::IconDatabase::releaseIconForPageURL): Ditto.
113         (WebCore::IconDatabase::setIconURLForPageURL): Ditto.
114         (WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto.
115         (WebCore::IconDatabase::importIconURLForPageURL): Broke assertion into
116         two separate assertions and added a third.
117         (WebCore::IconDatabase::performURLImport): Call pageCanHaveIcon.
118
119         * platform/KURL.cpp: Sorted includes. Moved a FIXME to the top of the file.
120         (WebCore::isLetterMatchIgnoringCase): Renamed matchLetter to this name,
121         overloaded it to work on both UChar and char, and added an assertion to it.
122         Also moved this to the top of the file and made the UChar version usable
123         in the shared code used even by Google.
124         (WebCore::KURL::invalidate): Updated for name change.
125         (WebCore::KURL::protocolIs): Use isLetterMatchIgnoringCase instead of
126         toASCIILower since it's faster.
127         (WebCore::KURL::parse): Updated for name changes.
128         (WebCore::protocolIs):Use isLetterMatchIgnoringCase instead of toASCIILower
129         since it's faster.
130         (WebCore::protocolIsInHTTPFamily): Added.
131
132         * platform/KURL.h: Tweaked formatting. Renamed protocolInHTTPFamily
133         to protocolIsInHTTPFamily and added a version that works on a string.
134         Kept the old name as an inline function so we don't have to rename
135         all the cal sites now.
136
137         * platform/KURLGoogle.cpp: Renamed as above.
138         (WebCore::KURLGooglePrivate::KURLGooglePrivate): Updated for rename.
139         (WebCore::KURLGooglePrivate::setUtf8): Ditto.
140         (WebCore::KURLGooglePrivate::setAscii): Ditto.
141         (WebCore::KURLGooglePrivate::initProtocolIsInHTTPFamily): Ditto.
142         (WebCore::KURLGooglePrivate::copyTo): Ditto.
143         (WebCore::KURL::KURL): Ditto.
144         (WebCore::KURL::protocolIsInHTTPFamily): Ditto.
145         (WebCore::KURL::invalidate): Ditto.
146         * platform/KURLGooglePrivate.h: Ditto.
147
148         * WebCore.exp.in: Updated for above changes.
149
150 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
151
152         Reviewed by Pavel Feldman.
153
154         Web Inspector: browser crash on evaluation of 'throw undefined'
155         https://bugs.webkit.org/show_bug.cgi?id=59611
156
157         Test: inspector/console/console-eval-throw-undefined.html
158
159         * inspector/InjectedScriptSource.js: use try/catch to protect from
160         exception during conversion of another exception to string.
161
162 2011-04-27  Pavel Feldman  <pfeldman@google.com>
163
164         Reviewed by Yury Semikhatsky.
165
166         Web Inspector: clicking bookmarklet multiplies resources panel entries.
167         https://bugs.webkit.org/show_bug.cgi?id=59590
168
169         * inspector/front-end/ResourceTreeModel.js:
170         (WebInspector.ResourceTreeModel):
171         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
172         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
173         * inspector/front-end/ResourcesPanel.js:
174         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
175         (WebInspector.FrameTreeElement):
176         (WebInspector.FrameTreeElement.prototype.appendResource):
177         * inspector/front-end/inspector.js:
178         (WebInspector.frontendReused):
179
180 2011-04-27  Pavel Feldman  <pfeldman@google.com>
181
182         Reviewed by Yury Semikhatsky.
183
184         Web Inspector: opening bookmarklet disconnects DOM agent.
185         https://bugs.webkit.org/show_bug.cgi?id=59588
186
187         * inspector/InspectorDOMAgent.cpp:
188         (WebCore::InspectorDOMAgent::setDocument):
189
190 2011-04-27  Hans Wennborg  <hans@chromium.org>
191
192         Reviewed by Tony Gentilcore.
193
194         IndexedDB: Fix compiler warnings about uninitialized variables
195         https://bugs.webkit.org/show_bug.cgi?id=59599
196
197         Build fix. No new tests.
198
199         * storage/IDBLevelDBBackingStore.cpp:
200         (WebCore::getNewObjectStoreId):
201         (WebCore::getNewIndexId):
202
203 2011-04-26  Hans Wennborg  <hans@chromium.org>
204
205         Reviewed by Tony Gentilcore.
206
207         IndexedDB: Move LevelDB key coding routines to separate file
208         https://bugs.webkit.org/show_bug.cgi?id=59452
209
210         Move all routines concerned with encoding, decoding and comparison of
211         LevelDB keys from IDBLevelDBBackingStore.cpp to a separate file:
212         IDBLevelDBCoding.cpp.
213
214         This makes IDBLevelDBBackingStore.cpp easier to work with, and will
215         allow for unit testing of the coding routines.
216
217         No new functionality, no new tests.
218
219         * WebCore.gypi:
220         * storage/IDBLevelDBBackingStore.cpp:
221         (WebCore::getInt):
222         (WebCore::putInt):
223         (WebCore::getString):
224         (WebCore::putString):
225         (WebCore::compareKeys):
226         (WebCore::compareIndexKeys):
227         (WebCore::Comparator::compare):
228         (WebCore::setUpMetadata):
229         (WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData):
230         (WebCore::getNewDatabaseId):
231         (WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
232         (WebCore::IDBLevelDBBackingStore::getObjectStores):
233         (WebCore::getNewObjectStoreId):
234         (WebCore::IDBLevelDBBackingStore::createObjectStore):
235         (WebCore::IDBLevelDBBackingStore::deleteObjectStore):
236         (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
237         (WebCore::getNewVersionNumber):
238         (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
239         (WebCore::IDBLevelDBBackingStore::clearObjectStore):
240         (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
241         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
242         (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
243         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
244         (WebCore::IDBLevelDBBackingStore::getIndexes):
245         (WebCore::getNewIndexId):
246         (WebCore::IDBLevelDBBackingStore::createIndex):
247         (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
248         (WebCore::versionExists):
249         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
250         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
251         (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
252         (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
253         (WebCore::IDBLevelDBBackingStore::openIndexCursor):
254         * storage/IDBLevelDBCoding.cpp: Added.
255         (WebCore::IDBLevelDBCoding::encodeByte):
256         (WebCore::IDBLevelDBCoding::maxIDBKey):
257         (WebCore::IDBLevelDBCoding::minIDBKey):
258         (WebCore::IDBLevelDBCoding::encodeInt):
259         (WebCore::IDBLevelDBCoding::decodeInt):
260         (WebCore::IDBLevelDBCoding::encodeVarInt):
261         (WebCore::IDBLevelDBCoding::decodeVarInt):
262         (WebCore::IDBLevelDBCoding::encodeString):
263         (WebCore::IDBLevelDBCoding::decodeString):
264         (WebCore::IDBLevelDBCoding::encodeStringWithLength):
265         (WebCore::IDBLevelDBCoding::decodeStringWithLength):
266         (WebCore::IDBLevelDBCoding::encodeDouble):
267         (WebCore::IDBLevelDBCoding::decodeDouble):
268         (WebCore::IDBLevelDBCoding::encodeIDBKey):
269         (WebCore::IDBLevelDBCoding::decodeIDBKey):
270         (WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
271         (WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
272         (WebCore::IDBLevelDBCoding::compare):
273         (WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
274         (WebCore::IDBLevelDBCoding::KeyPrefix::decode):
275         (WebCore::IDBLevelDBCoding::KeyPrefix::encode):
276         (WebCore::IDBLevelDBCoding::KeyPrefix::compare):
277         (WebCore::IDBLevelDBCoding::KeyPrefix::type):
278         (WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
279         (WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
280         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::DatabaseFreeListKey):
281         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
282         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
283         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::databaseId):
284         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare):
285         (WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
286         (WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
287         (WebCore::IDBLevelDBCoding::DatabaseNameKey::compare):
288         (WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
289         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey):
290         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
291         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
292         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::objectStoreId):
293         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
294         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
295         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::IndexMetaDataKey):
296         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
297         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
298         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare):
299         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::indexId):
300         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::ObjectStoreFreeListKey):
301         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
302         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
303         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::objectStoreId):
304         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare):
305         (WebCore::IDBLevelDBCoding::IndexFreeListKey::IndexFreeListKey):
306         (WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
307         (WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
308         (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare):
309         (WebCore::IDBLevelDBCoding::IndexFreeListKey::objectStoreId):
310         (WebCore::IDBLevelDBCoding::IndexFreeListKey::indexId):
311         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
312         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
313         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::compare):
314         (WebCore::IDBLevelDBCoding::IndexNamesKey::IndexNamesKey):
315         (WebCore::IDBLevelDBCoding::IndexNamesKey::decode):
316         (WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
317         (WebCore::IDBLevelDBCoding::IndexNamesKey::compare):
318         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::decode):
319         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
320         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare):
321         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::userKey):
322         (WebCore::IDBLevelDBCoding::ExistsEntryKey::decode):
323         (WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
324         (WebCore::IDBLevelDBCoding::ExistsEntryKey::compare):
325         (WebCore::IDBLevelDBCoding::ExistsEntryKey::userKey):
326         (WebCore::IDBLevelDBCoding::IndexDataKey::IndexDataKey):
327         (WebCore::IDBLevelDBCoding::IndexDataKey::decode):
328         (WebCore::IDBLevelDBCoding::IndexDataKey::encode):
329         (WebCore::IDBLevelDBCoding::IndexDataKey::encodeMaxKey):
330         (WebCore::IDBLevelDBCoding::IndexDataKey::compare):
331         (WebCore::IDBLevelDBCoding::IndexDataKey::databaseId):
332         (WebCore::IDBLevelDBCoding::IndexDataKey::objectStoreId):
333         (WebCore::IDBLevelDBCoding::IndexDataKey::indexId):
334         (WebCore::IDBLevelDBCoding::IndexDataKey::userKey):
335         * storage/IDBLevelDBCoding.h: Added.
336         (WebCore::IDBLevelDBCoding::DatabaseNameKey::origin):
337         (WebCore::IDBLevelDBCoding::DatabaseNameKey::databaseName):
338         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::metaDataType):
339         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::objectStoreName):
340         (WebCore::IDBLevelDBCoding::IndexNamesKey::indexName):
341
342 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
343
344         Reviewed by Pavel Feldman.
345
346         Web Inspector: expose exception details when script is paused on exception
347         https://bugs.webkit.org/show_bug.cgi?id=59591
348
349         When script is paused on an exception, the exception value is added as <exception>
350         property in the local scope and the breakpoint details message says
351         "Paused on excepion: '<exception to strin value>'."
352
353         * English.lproj/localizedStrings.js:
354         * inspector/front-end/ScopeChainSidebarPane.js:
355         (WebInspector.ScopeChainSidebarPane.prototype.update):
356         * inspector/front-end/ScriptsPanel.js:
357         (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
358         (WebInspector.ScriptsPanel.prototype._debuggerPaused):
359
360 2011-04-26  Yury Semikhatsky  <yurys@chromium.org>
361
362         Reviewed by Pavel Feldman.
363
364         Web Inspector: [protocol] Paused event should expose exception value that caused it
365         https://bugs.webkit.org/show_bug.cgi?id=58996
366
367         Debug.pause event now contains an optional reference to the exception
368         object in case script execution is paused on a JavaScript exception.
369
370         Also JavaScript call frames are passed directly into the injected script when
371         we need to wrap them for passing to the front-end. This change breaks cyclic
372         dependency ScriptDebugServer->InspectorDebuggerAgent->InjectedScript->InjectedScriptHost->ScriptDebugServer
373
374         * bindings/js/JSInjectedScriptHostCustom.cpp:
375         * bindings/js/ScriptDebugServer.cpp:
376         (WebCore::ScriptDebugServer::dispatchDidPause):
377         * bindings/js/ScriptDebugServer.h:
378         * bindings/v8/ScriptDebugServer.cpp:
379         (WebCore::ScriptDebugServer::breakProgram):
380         (WebCore::ScriptDebugServer::editScriptSource):
381         (WebCore::ScriptDebugServer::breakProgramCallback):
382         (WebCore::ScriptDebugServer::handleV8DebugEvent):
383         * bindings/v8/ScriptDebugServer.h:
384         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
385         * inspector/InjectedScript.cpp:
386         (WebCore::InjectedScript::evaluateOnCallFrame):
387         (WebCore::InjectedScript::wrapCallFrames):
388         * inspector/InjectedScript.h:
389         * inspector/InjectedScriptHost.cpp:
390         * inspector/InjectedScriptHost.h:
391         (WebCore::InjectedScriptHost::init):
392         * inspector/InjectedScriptHost.idl:
393         * inspector/InjectedScriptSource.js:
394         (.):
395         * inspector/Inspector.json:
396         * inspector/InspectorAgent.cpp:
397         (WebCore::InspectorAgent::InspectorAgent):
398         * inspector/InspectorDebuggerAgent.cpp:
399         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
400         (WebCore::InspectorDebuggerAgent::currentCallFrames):
401         (WebCore::InspectorDebuggerAgent::wrapCallFrames):
402         (WebCore::InspectorDebuggerAgent::didPause):
403         (WebCore::InspectorDebuggerAgent::didContinue):
404         (WebCore::InspectorDebuggerAgent::clear):
405         * inspector/InspectorDebuggerAgent.h:
406         * inspector/ScriptDebugListener.h:
407         * inspector/WorkerInspectorController.cpp:
408         (WebCore::WorkerInspectorController::WorkerInspectorController):
409
410 2011-04-27  Pavel Feldman  <pfeldman@google.com>
411
412         Reviewed by Yury Semikhatsky.
413
414         Web Inspector: implement incremental CSS editing in the structure view.
415         https://bugs.webkit.org/show_bug.cgi?id=59455
416
417         * inspector/front-end/StylesSidebarPane.js:
418         (WebInspector.StylePropertyTreeElement.prototype):
419
420 2011-04-27  Mihai Parparita  <mihaip@chromium.org>
421
422         Reviewed by Eric Seidel.
423
424         Frame.h shouldn't include Document.h
425         https://bugs.webkit.org/show_bug.cgi?id=59560
426
427         Frame can use a forward-declared Document if we move
428         Frame::displayStringModifiedByEncoding's implementation out of the
429         header.
430                                 Size  #includes  Size * #includes
431         Before: page/Frame.h:   0.746       653           487.138
432                 dom/Document.h: 0.220      1306           287.320
433         
434         After:  page/Frame.h:   0.646       653           421.838
435                 dom/Document.h: 0.220      1189           261.580
436
437         * WebCore.exp.in:
438         * bindings/ScriptControllerBase.cpp:
439         * bindings/generic/BindingSecurityBase.cpp:
440         * bindings/v8/V8Proxy.cpp:
441         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
442         * dom/CharacterData.cpp:
443         * dom/UserTypingGestureIndicator.cpp:
444         * editing/chromium/SelectionControllerChromium.cpp:
445         * inspector/InspectorDOMStorageResource.cpp:
446         * inspector/InspectorInstrumentation.h:
447         * loader/PingLoader.cpp:
448         * loader/SubresourceLoader.cpp:
449         * loader/appcache/DOMApplicationCache.cpp:
450         * loader/cache/CachedResourceRequest.cpp:
451         * page/Frame.cpp:
452         (WebCore::Frame::displayStringModifiedByEncoding):
453         * page/Frame.h:
454         * page/Geolocation.cpp:
455         * page/Location.cpp:
456         * page/Navigator.cpp:
457         * page/PageGroupLoadDeferrer.cpp:
458         * page/PerformanceTiming.cpp:
459         * xml/XSLTProcessorLibxslt.cpp:
460
461 2011-04-27  James Robinson  <jamesr@chromium.org>
462
463         Reviewed by Eric Seidel.
464
465         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
466         https://bugs.webkit.org/show_bug.cgi?id=59377
467
468         This cleans up some strict OwnPtr<> violations around text and box shadow data.  ShadowData's linked list data
469         structure now uses OwnPtr<>s to manage memory - each entry in the list has ownership of the next ShadowData.
470
471         * css/CSSStyleSelector.cpp:
472         (WebCore::CSSStyleSelector::applyProperty):
473         * page/animation/AnimationBase.cpp:
474         (WebCore::blendFunc):
475         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
476         (WebCore::PropertyWrapperShadow::blend):
477         * rendering/style/RenderStyle.cpp:
478         (WebCore::RenderStyle::setTextShadow):
479         (WebCore::RenderStyle::setBoxShadow):
480         * rendering/style/RenderStyle.h:
481         (WebCore::InheritedFlags::textShadow):
482         * rendering/style/ShadowData.cpp:
483         (WebCore::ShadowData::ShadowData):
484         * rendering/style/ShadowData.h:
485         (WebCore::ShadowData::ShadowData):
486         (WebCore::ShadowData::next):
487         (WebCore::ShadowData::setNext):
488         * rendering/style/StyleRareInheritedData.cpp:
489         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
490         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
491         * rendering/style/StyleRareInheritedData.h:
492         * rendering/style/StyleRareNonInheritedData.cpp:
493         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
494
495 2011-04-26  David Levin  <levin@chromium.org>
496
497         Reviewed by Eric Seidel.
498
499         Fix some strict PassOwnPtr issues in WebCore.
500         https://bugs.webkit.org/show_bug.cgi?id=59563
501
502         * css/SVGCSSStyleSelector.cpp:
503         (WebCore::CSSStyleSelector::applySVGProperty):
504         * html/canvas/WebGLRenderingContext.cpp:
505         (WebCore::WebGLRenderingContext::create):
506         (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
507         * platform/text/TextCodecLatin1.cpp:
508         (WebCore::newStreamingTextDecoderWindowsLatin1):
509         * platform/text/TextCodecUTF16.cpp:
510         (WebCore::newStreamingTextDecoderUTF16LE):
511         (WebCore::newStreamingTextDecoderUTF16BE):
512         * platform/text/TextCodecUserDefined.cpp:
513         (WebCore::newStreamingTextDecoderUserDefined):
514         * platform/text/mac/TextCodecMac.cpp:
515         (WebCore::newTextCodecMac):
516         * workers/Worker.cpp:
517         (WebCore::Worker::notifyFinished):
518
519 2011-04-26  Justin Novosad  <junov@chromium.org>
520
521         Reviewed by Kenneth Russell.
522
523         [Chromium] Expose skia gpu canvas rendering as a runtime flag
524         https://bugs.webkit.org/show_bug.cgi?id=58683
525         Replace the SKIA_GPU compile flag by the pre-existing
526         acceleratedDrawingEnabled flag. Most code changes are trivial:
527         compile-time conditionals on SKIA_GPU were either replaced with
528         a run-time check, or a compile time check on USE(SKIA) 
529
530         No new tests. Covered by existing tests.
531
532         * html/canvas/CanvasRenderingContext2D.cpp:
533         (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
534         * page/Page.cpp:
535         (WebCore::Page::sharedGraphicsContext3D):
536         Added check for the acceleratedDrawing flag.
537         * platform/graphics/chromium/DrawingBufferChromium.cpp:
538         (WebCore::DrawingBuffer::DrawingBuffer):
539         (WebCore::DrawingBuffer::publishToPlatformLayer):
540         * platform/graphics/gpu/DrawingBuffer.h:
541         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
542         (WebCore::SharedGraphicsContext3D::create):
543         On Skia builds, this methos now receives a bool arg to turn on
544         GPU-accelerated skia rendering
545         (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
546         (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
547         (WebCore::SharedGraphicsContext3D::grContext):
548         * platform/graphics/gpu/SharedGraphicsContext3D.h:
549         * platform/graphics/skia/ImageSkia.cpp:
550         (WebCore::computeResamplingMode):
551         (WebCore::paintSkBitmap):
552         (WebCore::Image::drawPattern):
553         * platform/graphics/skia/PlatformContextSkia.cpp:
554         (WebCore::PlatformContextSkia::PlatformContextSkia):
555         (WebCore::PlatformContextSkia::~PlatformContextSkia):
556         (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
557         (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
558         (WebCore::PlatformContextSkia::prepareForSoftwareDraw):
559         (WebCore::PlatformContextSkia::prepareForHardwareDraw):
560         (WebCore::PlatformContextSkia::syncSoftwareCanvas):
561         (WebCore::PlatformContextSkia::markDirtyRect):
562         * platform/graphics/skia/PlatformContextSkia.h:
563         (WebCore::PlatformContextSkia::accelerationMode):
564         (WebCore::PlatformContextSkia::useGPU):
565         (WebCore::PlatformContextSkia::useSkiaGPU):
566
567 2011-04-26  Pavel Feldman  <pfeldman@chromium.org>
568
569         Not reviewed: restore inspector test disabled in r84913.
570
571         Test: http/tests/inspector-enabled/dom-storage-open.html
572
573         * inspector/InspectorDOMStorageAgent.cpp:
574         (WebCore::InspectorDOMStorageAgent::clearFrontend):
575
576 2011-04-26  Kenichi Ishibashi  <bashi@chromium.org>
577
578         Reviewed by Tony Chang.
579
580         [Chromium] Vertical positions are off for some Arabic glyphs on Linux
581         https://bugs.webkit.org/show_bug.cgi?id=59182
582
583         Use vertical offsets of the shaping results.
584
585         Test: platform/chromium-linux/fast/text/international/arabic-vertical-offset.html
586
587         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
588         (WebCore::ComplexTextController::ComplexTextController):
589         Added initialization of m_startingY.
590         (WebCore::ComplexTextController::nextScriptRun):
591         Followed the change in handling positions.
592         (WebCore::ComplexTextController::deleteGlyphArrays): Ditto.
593         (WebCore::ComplexTextController::createGlyphArrays): Ditto.
594         (WebCore::ComplexTextController::resetGlyphArrays): Ditto.
595         (WebCore::ComplexTextController::setGlyphPositions):
596         Changed to use vertical offsets as same as horizontal offsets.
597         * platform/graphics/chromium/ComplexTextControllerLinux.h:
598         Removed m_xPositions and Added m_positions and m_startingY.
599         (WebCore::ComplexTextController::positions): Added.
600         * platform/graphics/chromium/FontLinux.cpp:
601         Followed the change in ComplexTextController.
602         (WebCore::Font::drawComplexText): Ditto.
603         (WebCore::Font::floatWidthForComplexText): Ditto.
604         (WebCore::glyphIndexForXPositionInScriptRun): Ditto.
605         (WebCore::Font::offsetForPositionForComplexText): Ditto.
606         (WebCore::Font::selectionRectForComplexText): Ditto.
607
608 2011-04-26  Levi Weintraub  <leviw@chromium.org>
609
610         Reviewed by Eric Seidel.
611
612         Root element should establish a new block formatting context
613         https://bugs.webkit.org/show_bug.cgi?id=54573
614
615         Always expanding the root renderer to include overhanging floats.
616
617         Test: fast/block/float/float-overhangs-root.html
618
619         * rendering/RenderBlock.cpp:
620         (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
621
622 2011-04-26  Dawit Alemayehu  <adawit@kde.org>
623
624         Reviewed by Andreas Kling.
625
626         [Qt] Improper rendering of <button> tag when it contains a <br>
627         https://bugs.webkit.org/show_bug.cgi?id=50521
628
629         Test: platform/qt/fast/forms/button-line-break.html
630
631         * platform/qt/RenderThemeQt.cpp:
632         (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
633         (WebCore::RenderThemeQt::setButtonPadding):
634
635 2011-04-26  James Robinson  <jamesr@chromium.org>
636
637         Reviewed by Kenneth Russell.
638
639         [chromium] Only reset tiles if the LayerRendererChromium is actually changing
640         https://bugs.webkit.org/show_bug.cgi?id=59572
641
642         http://trac.webkit.org/changeset/84981/ caused us to reset the tiles
643         when LayerRendererChromium was set.  We set this pointer every frame
644         and should only reset the tiles if the new LayerRendererChromium is
645         different from the old one (indicating a context loss), not just reset
646         on every frame.
647
648         * platform/graphics/chromium/LayerTilerChromium.cpp:
649         (WebCore::LayerTilerChromium::setLayerRenderer):
650         * platform/graphics/chromium/LayerTilerChromium.h:
651
652 2011-04-26  Dinesh K Garg  <dineshg@codeaurora.org>
653
654         Reviewed by Eric Seidel.
655
656         beginElement broken by setAttribute
657         https://bugs.webkit.org/show_bug.cgi?id=26019
658
659         Test: svg/animations/animate-beginElementAt.svg
660
661         * svg/SVGAnimationElement.cpp:
662         (WebCore::SVGAnimationElement::attributeChanged):
663         Reset the animation state here as the rest of the code reads it and would still
664         think we are animating when we are not.
665
666         * svg/animation/SVGSMILElement.h:
667         (WebCore::SVGSMILElement::setInactive): Helper function to reset the state.
668
669 2011-04-26  Sheriff Bot  <webkit.review.bot@gmail.com>
670
671         Unreviewed, rolling out r84989.
672         http://trac.webkit.org/changeset/84989
673         https://bugs.webkit.org/show_bug.cgi?id=59566
674
675         REGRESSION (r84989): Lots of vertical text tests failing on
676         windows (Requested by weinig on #webkit).
677
678         * platform/graphics/FontPlatformData.h:
679         * platform/graphics/win/FontCacheWin.cpp:
680         (WebCore::FontCache::getFontDataForCharacters):
681         (WebCore::FontCache::createFontPlatformData):
682         * platform/graphics/win/FontCustomPlatformData.cpp:
683         (WebCore::FontCustomPlatformData::fontPlatformData):
684         * platform/graphics/win/FontPlatformDataCGWin.cpp:
685         (WebCore::FontPlatformData::FontPlatformData):
686         * platform/graphics/win/FontPlatformDataWin.cpp:
687         (WebCore::FontPlatformData::FontPlatformData):
688
689 2011-04-26  Sam Weinig  <sam@webkit.org>
690
691         Reviewed by Eric Seidel.
692
693         Try again:
694             Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
695             https://bugs.webkit.org/show_bug.cgi?id=59310
696
697         * bindings/js/JSDOMBinding.h:
698         (WebCore::DOMConstructorObject::DOMConstructorObject):
699         * bindings/js/JSDOMWrapper.h:
700         (WebCore::JSDOMWrapper::globalObject):
701         (WebCore::JSDOMWrapper::scriptExecutionContext):
702         (WebCore::JSDOMWrapper::createStructure):
703         (WebCore::JSDOMWrapper::JSDOMWrapper):
704         * bindings/scripts/CodeGeneratorJS.pm:
705
706 2011-04-26  Sam Weinig  <sam@webkit.org>
707
708         Reviewed by David Hyatt.
709
710         Remove Datagrid from the tree
711         https://bugs.webkit.org/show_bug.cgi?id=59543
712
713         * Android.derived.jscbindings.mk:
714         * Android.derived.v8bindings.mk:
715         * Android.jscbindings.mk:
716         * Android.v8bindings.mk:
717         * CMakeLists.txt:
718         * CodeGenerators.pri:
719         * Configurations/FeatureDefines.xcconfig:
720         * DerivedSources.cpp:
721         * DerivedSources.make:
722         * GNUmakefile.am:
723         * GNUmakefile.list.am:
724         * UseJSC.cmake:
725         * WebCore.gypi:
726         * WebCore.pro:
727         * WebCore.vcproj/WebCore.vcproj:
728         * WebCore.xcodeproj/project.pbxproj:
729         * bindings/js/JSBindingsAllInOne.cpp:
730         * bindings/js/JSDataGridColumnListCustom.cpp: Removed.
731         * bindings/js/JSDataGridDataSource.cpp: Removed.
732         * bindings/js/JSDataGridDataSource.h: Removed.
733         * bindings/js/JSHTMLDataGridElementCustom.cpp: Removed.
734         * bindings/v8/V8DataGridDataSource.cpp: Removed.
735         * bindings/v8/V8DataGridDataSource.h: Removed.
736         * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Removed.
737         * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Removed.
738         * css/CSSStyleSelector.cpp:
739         * css/CSSStyleSelector.h:
740         * css/html.css:
741         (input, textarea, keygen, select, button, isindex):
742         (select:disabled, keygen:disabled, optgroup:disabled, option:disabled):
743         * editing/htmlediting.cpp:
744         (WebCore::canHaveChildrenForEditing):
745         * features.pri:
746         * html/DOMDataGridDataSource.cpp: Removed.
747         * html/DOMDataGridDataSource.h: Removed.
748         * html/DataGridColumn.cpp: Removed.
749         * html/DataGridColumn.h: Removed.
750         * html/DataGridColumn.idl: Removed.
751         * html/DataGridColumnList.cpp: Removed.
752         * html/DataGridColumnList.h: Removed.
753         * html/DataGridColumnList.idl: Removed.
754         * html/DataGridDataSource.h: Removed.
755         * html/HTMLDataGridCellElement.cpp: Removed.
756         * html/HTMLDataGridCellElement.h: Removed.
757         * html/HTMLDataGridCellElement.idl: Removed.
758         * html/HTMLDataGridColElement.cpp: Removed.
759         * html/HTMLDataGridColElement.h: Removed.
760         * html/HTMLDataGridColElement.idl: Removed.
761         * html/HTMLDataGridElement.cpp: Removed.
762         * html/HTMLDataGridElement.h: Removed.
763         * html/HTMLDataGridElement.idl: Removed.
764         * html/HTMLDataGridRowElement.cpp: Removed.
765         * html/HTMLDataGridRowElement.h: Removed.
766         * html/HTMLDataGridRowElement.idl: Removed.
767         * html/HTMLElement.cpp:
768         (WebCore::HTMLElement::ieForbidsInsertHTML):
769         * html/HTMLElementsAllInOne.cpp:
770         * html/HTMLTagNames.in:
771         * page/DOMWindow.idl:
772         * rendering/RenderBox.cpp:
773         (WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
774         * rendering/RenderDataGrid.cpp: Removed.
775         * rendering/RenderDataGrid.h: Removed.
776         * rendering/RenderingAllInOne.cpp:
777
778 2011-04-26  Chun-Lung Huang  <alvincl.huang@gmail.com>
779
780         Reviewed by Adele Peterson.
781
782         On WebKit (Windows), glyphs in vertical text tests are rotated 90
783         degrees clockwise.  https://bugs.webkit.org/show_bug.cgi?id=48459
784
785         This platform dependent patch makes WebKit (Windows) show the
786         vertical writing text correctly.  Job was done by adding a prefix '@'
787         in front of the font family name (Windows Only). No new tests added.
788         Some layout tests images:
789         http://www.flickr.com/photos/burorly/sets/72157625585506341/
790
791         * platform/graphics/FontPlatformData.h:
792         * platform/graphics/win/FontCacheWin.cpp:
793         (WebCore::FontCache::getFontDataForCharacters):
794         (WebCore::FontCache::createFontPlatformData):
795         * platform/graphics/win/FontCustomPlatformData.cpp:
796         (WebCore::FontCustomPlatformData::fontPlatformData):
797         * platform/graphics/win/FontPlatformDataCGWin.cpp:
798         (WebCore::FontPlatformData::FontPlatformData):
799         * platform/graphics/win/FontPlatformDataWin.cpp:
800         (WebCore::FontPlatformData::FontPlatformData):
801
802 2011-04-26  Jer Noble  <jer.noble@apple.com>
803
804         Reviewed by Brady Eidson.
805
806         HTML5 video fullscreen transition causes an audio stutter
807         https://bugs.webkit.org/show_bug.cgi?id=59544
808
809         AVFoundation will momentarily stutter when you disconnect a AVPlayerLayer 
810         from its AVPlayer.  Since you shouldn't necessarily have to destroy the
811         layer to render it invisible, instead just set the layer as hidden.
812
813         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
814         (WebCore::MediaPlayerPrivateAVFoundation::setVisible): Call through to platformSetVisible().
815         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
816         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
817         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
818         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformSetVisible): Added.
819
820 2011-04-26  Christian Dywan  <christian@lanedo.com>
821
822         Reviewed by Eric Seidel.
823
824         Extra separator after Select All in context menu
825         https://bugs.webkit.org/show_bug.cgi?id=54092
826
827         * page/ContextMenuController.cpp: Move separator to non-GTK+
828             port guards since it is for the spelling options menu
829             which the GTK+ port doesn't use.
830
831 2011-04-26  James Robinson  <jamesr@chromium.org>
832
833         Reviewed by Kenneth Russell.
834
835         [chromium] Clear out LayerTilerChromium's tiles on lost context
836         https://bugs.webkit.org/show_bug.cgi?id=59233
837
838         Clears out the LayerTilerChromium's tile set when the LayerRendererChromium is reset.  In this case the tiles are
839         no longer valid since they exist in the previous LayerRendererChromium.
840
841         Will be tested by a chrome test since we don't have any way to exercise the context lost case in layout tests.
842
843         * platform/graphics/chromium/LayerTilerChromium.h:
844         (WebCore::LayerTilerChromium::setLayerRenderer):
845
846 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
847
848         Reviewed by Dirk Schulze.
849
850         [GTK] Flash in divs with overflow: auto is not positioned and clipped properly
851         https://bugs.webkit.org/show_bug.cgi?id=57644
852
853         Manual test: plugins/windowed-in-iframe-2.html
854
855         * manual-tests/plugins/windowed-in-iframe-2.html: Added.
856         * platform/gtk/WidgetGtk.cpp:
857         (WebCore::Widget::setFrameRect): Like the Qt port, we notify the widget via frameRectsChanged.
858         * plugins/PluginView.h: Added helper method to set the allocation and clip.
859         * plugins/gtk/PluginViewGtk.cpp:
860         (WebCore::PluginView::setNPWindowIfNeeded):Call the helper method instead of setting
861         the allocation immediately. Bring this method into sync with the implementation in
862         the Qt port.
863         (WebCore::PluginView::updateWidgetAllocationAndClip): Added.
864         (WebCore::PluginView::plugAddedCallback): Call the new helper method.
865
866 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
867
868         Reviewed by Eric Seidel.
869
870         [GTK]  fast/block/float/overhanging-tall-block.html crashes in the bots
871         https://bugs.webkit.org/show_bug.cgi?id=58818
872
873         Prevent allocating scratch buffers larger than the target GdkDrawable
874         when creating a WidgetRenderingContext. This prevents incredibly large
875         widgets from crashing the X Server. This change also allowed greatly
876         simplifying the way that the painting offset is calculated.
877
878         * platform/gtk/WidgetRenderingContext.cpp:
879         (WebCore::WidgetRenderingContext::WidgetRenderingContext): Never allocate a pixmap
880         larger than the target GdkDrawable.
881         (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Calculate the offset of the
882         blit by looking at the location of the target rect itself, rather than delaying the
883         calculation up to this point.
884         (WebCore::WidgetRenderingContext::calculateClipRect): Added.
885         (WebCore::WidgetRenderingContext::gtkPaintBox): Use the new calculateClipRectHelper.
886         (WebCore::WidgetRenderingContext::gtkPaintFlatBox): Ditto.
887         (WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto.
888         (WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto.
889         (WebCore::WidgetRenderingContext::gtkPaintCheck): Ditto.
890         (WebCore::WidgetRenderingContext::gtkPaintOption): Ditto.
891         (WebCore::WidgetRenderingContext::gtkPaintShadow): Ditto.
892         (WebCore::WidgetRenderingContext::gtkPaintArrow): Ditto.
893         (WebCore::WidgetRenderingContext::gtkPaintVLine): Ditto.
894         * platform/gtk/WidgetRenderingContext.h: Remove some now unused members. Add
895         a member to store the IntSize mapping from the coordinates of the target to the coordinates
896         of the scratch buffer.
897
898 2011-04-26  Patrick Gansterer  <paroga@webkit.org>
899
900         Reviewed by Adam Barth.
901
902         Respect charset in handleDataURL
903         https://bugs.webkit.org/show_bug.cgi?id=47746
904
905         Original patch by Kwang Yul Seo <skyul@company100.net>
906
907         We must use TextEncoding(charset) to encode data URL again. Otherwise TextEncoding::encode()
908         returns an empty string because encoding name is not specified.
909
910         Also use "US-ASCII" as fallback charset as extractCharsetFromMediaType can be empty.
911
912         This change fixes over 130 layout tests when running GTK port with cURL network backend.
913
914         * platform/network/DataURL.cpp:
915         (WebCore::handleDataURL):
916
917 2011-04-26  Anders Carlsson  <andersca@apple.com>
918
919         Fix clang++ build.
920
921         You can never have too many casts!
922
923         * accessibility/mac/AccessibilityObjectWrapper.mm:
924         (-[AccessibilityObjectWrapper position]):
925         * editing/mac/SelectionControllerMac.mm:
926         (WebCore::accessibilityConvertScreenRect):
927
928 2011-04-26  Chris Rogers  <crogers@google.com>
929
930         Reviewed by Kenneth Russell.
931
932         Fix web audio build on mac port
933         https://bugs.webkit.org/show_bug.cgi?id=59355
934
935         No new tests since audio API is not yet implemented.
936
937         * WebCore.xcodeproj/project.pbxproj:
938         * bindings/js/JSAudioContextCustom.cpp:
939         (WebCore::JSAudioContext::visitChildren):
940         * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
941         (WebCore::JSJavaScriptAudioNode::visitChildren):
942         * webaudio/AudioContext.idl:
943
944 2011-04-26  Chris Rogers  <crogers@google.com>
945
946         Reviewed by Kenneth Russell.
947
948         Add FFTFrame implementation for FFmpeg
949         https://bugs.webkit.org/show_bug.cgi?id=59408
950
951         No new tests since audio API is not yet implemented.
952
953         * WebCore.gyp/WebCore.gyp:
954         * WebCore.gypi:
955         * platform/audio/FFTFrame.h:
956         * platform/audio/FFTFrameStub.cpp:
957         * platform/audio/ffmpeg: Added.
958         * platform/audio/ffmpeg/FFTFrameFFMPEG.cpp: Added.
959         (WebCore::FFTFrame::FFTFrame):
960         (WebCore::FFTFrame::initialize):
961         (WebCore::FFTFrame::cleanup):
962         (WebCore::FFTFrame::~FFTFrame):
963         (WebCore::FFTFrame::multiply):
964         (WebCore::FFTFrame::doFFT):
965         (WebCore::FFTFrame::doInverseFFT):
966         (WebCore::FFTFrame::realData):
967         (WebCore::FFTFrame::imagData):
968         (WebCore::FFTFrame::getUpToDateComplexData):
969         (WebCore::FFTFrame::contextForSize):
970         * platform/audio/mac/FFTFrameMac.cpp:
971         * webaudio/ConvolverNode.cpp:
972
973 2011-04-26  Jeff Miller  <jeffm@apple.com>
974
975         Add a newline at the end of SVGFEDropShadowElement.idl.
976
977         * svg/SVGFEDropShadowElement.idl:
978
979 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
980
981         Reviewed by Eric Seidel.
982
983         InlineBox.h shouldn't include RenderBR.h
984         https://bugs.webkit.org/show_bug.cgi?id=59480
985
986         Per bug 59348 RenderBR.h is a "top header" by include * size, because
987         InlineBox.h includes it. There's no reason why it has to.
988
989         * rendering/InlineBox.h:
990         * rendering/InlineTextBox.cpp:
991         * rendering/RenderBlock.h:
992
993 2011-04-26  Sam Weinig  <sam@webkit.org>
994
995         Nope, roll out r84950 and r84952. Working on a laptop is clearly not something
996         I should do.
997
998         * bindings/js/JSDOMBinding.h:
999         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
1000         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
1001         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
1002         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
1003         (WebCore::DOMConstructorObject::DOMConstructorObject):
1004         * bindings/js/JSDOMWrapper.h:
1005         (WebCore::JSDOMWrapper::JSDOMWrapper):
1006         * bindings/scripts/CodeGeneratorJS.pm:
1007
1008 2011-04-26  Sam Weinig  <sam@webkit.org>
1009
1010         Fix build.
1011
1012         * bindings/js/JSDOMWrapper.h:
1013         (WebCore::JSDOMWrapper::globalObject):
1014
1015 2011-04-26  Sam Weinig  <sam@webkit.org>
1016
1017         Roll r84945 back in with infinite recursion removed.
1018
1019         * bindings/js/JSDOMBinding.h:
1020         (WebCore::DOMConstructorObject::DOMConstructorObject):
1021         * bindings/js/JSDOMWrapper.h:
1022         (WebCore::JSDOMWrapper::globalObject):
1023         (WebCore::JSDOMWrapper::scriptExecutionContext):
1024         (WebCore::JSDOMWrapper::createStructure):
1025         (WebCore::JSDOMWrapper::JSDOMWrapper):
1026         * bindings/scripts/CodeGeneratorJS.pm:
1027
1028 2011-04-26  Sam Weinig  <sam@webkit.org>
1029
1030         Rollout previous patch. It broke stuff.
1031
1032         * bindings/js/JSDOMBinding.h:
1033         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
1034         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
1035         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
1036         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
1037         (WebCore::DOMConstructorObject::DOMConstructorObject):
1038         * bindings/js/JSDOMWrapper.h:
1039         (WebCore::JSDOMWrapper::JSDOMWrapper):
1040         * bindings/scripts/CodeGeneratorJS.pm:
1041
1042 2011-04-26  Sam Weinig  <sam@webkit.org>
1043
1044         Reviewed by Maciej Stachowiak.
1045
1046         Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
1047         https://bugs.webkit.org/show_bug.cgi?id=59310
1048
1049         * bindings/js/JSDOMBinding.h:
1050         (WebCore::DOMConstructorObject::DOMConstructorObject):
1051         * bindings/js/JSDOMWrapper.h:
1052         (WebCore::JSDOMWrapper::globalObject):
1053         (WebCore::JSDOMWrapper::scriptExecutionContext):
1054         (WebCore::JSDOMWrapper::createStructure):
1055         (WebCore::JSDOMWrapper::JSDOMWrapper):
1056         Merge JSDOMWrapperWithGlobalPointer with JSDOMWrapper.
1057
1058         * bindings/scripts/CodeGeneratorJS.pm:
1059         Make JSDOMWrapper the base class.
1060
1061 2011-04-26  Dan Bernstein  <mitz@apple.com>
1062
1063         Reviewed by Mark Rowe.
1064
1065         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
1066
1067         * Configurations/Base.xcconfig:
1068         * Configurations/CompilerVersion.xcconfig: Added.
1069
1070 2011-04-26  Adrienne Walker  <enne@google.com>
1071
1072         Reviewed by Geoffrey Garen.
1073
1074         Use OwnArrayPtr<T> instead of OwnPtr<T*> in ScopeTracer
1075         https://bugs.webkit.org/show_bug.cgi?id=59469
1076
1077         * platform/chromium/TraceEvent.h:
1078         (WebCore::internal::ScopeTracer::ScopeTracer):
1079
1080 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
1081
1082         Reviewed by Oliver Hunt.
1083
1084         Nixed special finalizer handling for WebCore strings
1085         https://bugs.webkit.org/show_bug.cgi?id=59425
1086
1087         Not needed anymore, since weak handles have finalizers.
1088
1089         * WebCore.exp.in: Exports!
1090
1091         * bindings/js/DOMWrapperWorld.cpp:
1092         (WebCore::JSStringOwner::finalize):
1093         (WebCore::DOMWrapperWorld::DOMWrapperWorld): Use a weak handle finalizer,
1094         so we don't need special treatment anymore.
1095
1096         * bindings/js/DOMWrapperWorld.h:
1097         (WebCore::JSStringOwner::JSStringOwner):
1098         (WebCore::DOMWrapperWorld::stringWrapperOwner): Use a HashMap of Weak<T>
1099         instead of a WeakGCMap, so we can specify a custom finalizer.
1100
1101         * bindings/js/JSDOMBinding.cpp:
1102         (WebCore::jsStringSlowCase):
1103         * bindings/js/JSDOMBinding.h:
1104         (WebCore::jsString): Updated for string map change.
1105
1106 2011-04-26  David Kilzer  <ddkilzer@apple.com>
1107
1108         <http://webkit.org/b/59372> Restore user default for enabling HTTP pipelining
1109
1110         Reviewed by Antti Koivisto.
1111
1112         To enable HTTP pipelining post-SnowLeopard, use this command:
1113
1114             defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES
1115
1116         * platform/network/cf/ResourceRequestCFNet.cpp:
1117         (WebCore::readBooleanPreference): Re-added.  Originally added in
1118         r76756 and removed in r84120.
1119         (WebCore::initializeMaximumHTTPConnectionCountPerHost): Enable
1120         HTTP pipelining if use default is set to true.  Added macro
1121         guards to match those in ResourceRequestMac.mm.
1122
1123 2011-04-26  Antti Koivisto  <antti@apple.com>
1124
1125         Reviewed by Adele Peterson.
1126
1127         Don't strip fragments from file: urls in memory cache
1128         https://bugs.webkit.org/show_bug.cgi?id=59463
1129         <rdar://problem/9231130>
1130
1131         Some clients expect file: resources to be unique based on fragment identifier. 
1132         Limit the changes in http://trac.webkit.org/changeset/74107 to the HTTP protocol only
1133
1134         Test: fast/loader/file-protocol-fragment.html
1135
1136         * loader/cache/MemoryCache.cpp:
1137         (WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
1138
1139 2011-04-26  David Levin  <levin@chromium.org>
1140
1141         Reviewed by Darin Adler.
1142
1143         Fix more strict OwnPtr in WebCore (round N).
1144         https://bugs.webkit.org/show_bug.cgi?id=59464
1145
1146         * dom/Document.cpp:
1147         (WebCore::Document::Document):
1148         (WebCore::Document::attach):
1149         * fileapi/FileReader.cpp:
1150         (WebCore::FileReader::terminate):
1151         * loader/DocumentThreadableLoader.cpp:
1152         (WebCore::DocumentThreadableLoader::preflightFailure):
1153         * workers/DefaultSharedWorkerRepository.cpp:
1154         (WebCore::SharedWorkerConnectTask::create):
1155         (WebCore::SharedWorkerScriptLoader::load):
1156
1157 2011-04-26  Ruben  <chromium@hybridsource.org>
1158
1159         Reviewed by Tony Chang.
1160
1161         Change linux ifdefs for Chromium to Unix instead, allowing
1162         new Unix ports to be enabled by default
1163         https://bugs.webkit.org/show_bug.cgi?id=59297
1164
1165         No new tests, just changing preprocessor defines.
1166
1167         * bindings/js/JSInspectorFrontendHostCustom.cpp:
1168         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
1169         * dom/SelectElement.cpp:
1170         * loader/cache/CachedFont.cpp:
1171         * page/EventHandler.cpp:
1172         * page/chromium/EventHandlerChromium.cpp:
1173         * platform/Scrollbar.cpp:
1174         * platform/chromium/PlatformBridge.h:
1175         * platform/graphics/chromium/FontPlatformData.h:
1176         * platform/graphics/skia/FontCustomPlatformData.cpp:
1177         * platform/graphics/skia/FontCustomPlatformData.h:
1178
1179 2011-04-26  Ryosuke Niwa  <rniwa@webkit.org>
1180
1181         Reviewed by Dan Bernstein.
1182
1183         [RTL] Arabic/AB - after typing a date, cursors doesn't go back
1184         https://bugs.webkit.org/show_bug.cgi?id=49111
1185
1186         Even when the offset corresponds to a position visually left of the box
1187         and there aren't any inline boxes on the left, the previous/next position
1188         may still correspond to some position in the same line.
1189
1190         The bug was caused by our ignoring such cases. Fixed the bug by comparing
1191         previous/next position's inline box to the current box. If they match,
1192         then we stay on the same position because moving to the left visually at
1193         the left edge should not result in a position on the same line.
1194
1195         Also fixed a bug that WebKit uses offsets that are not extrema when moved to
1196         the left edge or to the right edge, and a bug that WebKit could not move to
1197         the left from 12^3 CBA abc to 123 C^BA abc (there is no offset between 3 and C).
1198
1199         Test cases are added to editing/selection/move-left-right.html
1200
1201         * editing/VisiblePosition.cpp:
1202         (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
1203         (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
1204
1205 2011-04-26  Gabor Loki  <loki@webkit.org>
1206
1207         Reviewed by Csaba Osztrogon√°c.
1208
1209         Speeding up SVG filters with multicore (SMP) support
1210         https://bugs.webkit.org/show_bug.cgi?id=43903
1211
1212         Some SVG filters execute a huge number of pixel manipulations, which
1213         cannot be sped up by graphics accelerators, since their algorithm is
1214         too complex. Using the power of Symmetric Multi Processing (SMP) we
1215         can split up a task to smaller (data independent) tasks, which can be
1216         executed independently.
1217
1218         The ParallelJobs framework provides a simple way for distributed
1219         programming. The framework is based on WebKit's threading infrastructure,
1220         Open Multi-Processing's (OpenMP) API, and libdispatch API.
1221
1222         * ForwardingHeaders/wtf/ParallelJobs.h: Added.
1223         * platform/graphics/filters/FETurbulence.cpp:
1224         (WebCore::FETurbulence::PaintingData::PaintingData):
1225         (WebCore::FETurbulence::noise2D):
1226         (WebCore::FETurbulence::calculateTurbulenceValueForPoint):
1227         (WebCore::FETurbulence::fillRegion):
1228         (WebCore::FETurbulence::fillRegionWorker):
1229         (WebCore::FETurbulence::apply):
1230         * platform/graphics/filters/FETurbulence.h:
1231
1232 2011-04-26  Pavel Feldman  <pfeldman@google.com>
1233
1234         Reviewed by Yury Semikhatsky.
1235
1236         Web Inspector: close button is off in docked mode on a mac.
1237         https://bugs.webkit.org/show_bug.cgi?id=59453
1238
1239         * inspector/front-end/inspector.css:
1240         (.toolbar-item.close-left):
1241
1242 2011-04-26  Pavel Feldman  <pfeldman@google.com>
1243
1244         Reviewed by Yury Semikhatsky.
1245
1246         Web Inspector: New Style is not working (UI glitch)
1247         https://bugs.webkit.org/show_bug.cgi?id=59451
1248
1249         * inspector/InspectorDOMStorageAgent.cpp:
1250         (WebCore::InspectorDOMStorageAgent::setFrontend):
1251         * inspector/front-end/AuditRules.js:
1252         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
1253         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
1254         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
1255         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
1256         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
1257         * inspector/front-end/CSSStyleModel.js:
1258         (WebInspector.CSSStyleModel.prototype.setRuleSelector):
1259         (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
1260         (WebInspector.CSSStyleModel.prototype.addRule):
1261         (WebInspector.CSSStyleModel.prototype.addRule.callback):
1262         (WebInspector.CSSStyleModel.prototype._documentElementId):
1263         * inspector/front-end/DOMAgent.js:
1264         (WebInspector.DOMNode.prototype._addAttribute):
1265         (WebInspector.DOMNode.prototype.documentElement):
1266         * inspector/front-end/ResourceTreeModel.js:
1267         (WebInspector.PageDispatcher.prototype.frameDetached):
1268         * inspector/front-end/StylesSidebarPane.js:
1269         (WebInspector.StylesSidebarPane.prototype._createNewRule):
1270
1271 2011-04-26  Pavel Feldman  <pfeldman@google.com>
1272
1273         Reviewed by Yury Semikhatsky.
1274
1275         Web Inspector: introduce DOMStorage::enable and disable.
1276         https://bugs.webkit.org/show_bug.cgi?id=59445
1277
1278         * inspector/Inspector.json:
1279         * inspector/InspectorAgent.cpp:
1280         (WebCore::InspectorAgent::InspectorAgent):
1281         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
1282         * inspector/InspectorDOMStorageAgent.cpp:
1283         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
1284         (WebCore::InspectorDOMStorageAgent::restore):
1285         (WebCore::InspectorDOMStorageAgent::enable):
1286         (WebCore::InspectorDOMStorageAgent::disable):
1287         * inspector/InspectorDOMStorageAgent.h:
1288         (WebCore::InspectorDOMStorageAgent::create):
1289         * inspector/front-end/DOMStorage.js:
1290         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
1291         * inspector/front-end/ResourcesPanel.js:
1292         (WebInspector.ResourcesPanel.prototype._reset):
1293         * inspector/front-end/inspector.js:
1294
1295 2011-04-26  Pavel Feldman  <pfeldman@google.com>
1296
1297         Reviewed by Yury Semikhatsky.
1298
1299         Web Inspector: extract Page agent dispatcher into the ResourceTreeModel.
1300         https://bugs.webkit.org/show_bug.cgi?id=59440
1301
1302         * inspector/Inspector.json:
1303         * inspector/InspectorAgent.cpp:
1304         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
1305         * inspector/InspectorPageAgent.cpp:
1306         (WebCore::InspectorPageAgent::setFrontend):
1307         (WebCore::InspectorPageAgent::frameNavigated):
1308         * inspector/InspectorPageAgent.h:
1309         * inspector/front-end/AuditsPanel.js:
1310         (WebInspector.AuditsPanel):
1311         (WebInspector.AuditsPanel.prototype._onLoadEventFired):
1312         (WebInspector.AuditsPanel.prototype._domContentLoadedEventFired):
1313         * inspector/front-end/CSSStyleModel.js:
1314         (WebInspector.CSSStyleModelResourceBinding):
1315         (WebInspector.CSSStyleModelResourceBinding.prototype._inspectedURLChanged):
1316         * inspector/front-end/DOMBreakpointsSidebarPane.js:
1317         (WebInspector.DOMBreakpointsSidebarPane):
1318         (WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged):
1319         * inspector/front-end/DOMStorage.js:
1320         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
1321         * inspector/front-end/ExtensionServer.js:
1322         (WebInspector.ExtensionServer.prototype._inspectedURLChanged):
1323         (WebInspector.ExtensionServer.prototype.initExtensions):
1324         * inspector/front-end/NetworkPanel.js:
1325         (WebInspector.NetworkPanel):
1326         (WebInspector.NetworkPanel.prototype._onLoadEventFired):
1327         (WebInspector.NetworkPanel.prototype._domContentLoadedEventFired):
1328         (WebInspector.NetworkPanel.prototype._frameNavigated):
1329         * inspector/front-end/ResourceTreeModel.js:
1330         (WebInspector.ResourceTreeModel):
1331         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
1332         (WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged):
1333         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
1334         (WebInspector.ResourceTreeModel.prototype._frameDetached):
1335         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
1336         (WebInspector.PageDispatcher):
1337         (WebInspector.PageDispatcher.prototype.domContentEventFired):
1338         (WebInspector.PageDispatcher.prototype.loadEventFired):
1339         (WebInspector.PageDispatcher.prototype.frameNavigated):
1340         (WebInspector.PageDispatcher.prototype.frameDetached):
1341         * inspector/front-end/ResourcesPanel.js:
1342         (WebInspector.ResourcesPanel):
1343         (WebInspector.ResourcesPanel.prototype._onLoadEventFired):
1344         (WebInspector.ResourcesPanel.prototype._frameNavigated):
1345         * inspector/front-end/inspector.js:
1346
1347 2011-04-26  Csaba Osztrogon√°c  <ossy@webkit.org>
1348
1349         Unreviewed rollout r84877 and StyleRareInheritedData.cpp changes of r84892,
1350         because it broke transitions/multiple-text-shadow-transition.html
1351
1352         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
1353         https://bugs.webkit.org/show_bug.cgi?id=59377
1354
1355         * css/CSSStyleSelector.cpp:
1356         (WebCore::CSSStyleSelector::applyProperty):
1357         * page/animation/AnimationBase.cpp:
1358         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
1359         (WebCore::PropertyWrapperShadow::blend):
1360         * rendering/style/RenderStyle.cpp:
1361         (WebCore::RenderStyle::setTextShadow):
1362         (WebCore::RenderStyle::setBoxShadow):
1363         * rendering/style/RenderStyle.h:
1364         (WebCore::InheritedFlags::textShadow):
1365         * rendering/style/StyleRareInheritedData.cpp:
1366         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
1367         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
1368         * rendering/style/StyleRareInheritedData.h:
1369         * rendering/style/StyleRareNonInheritedData.cpp:
1370         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
1371
1372 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
1373
1374         Reviewed by Adam Barth.
1375
1376         Turn off make built-in implicit rules for derived sources makefile
1377         https://bugs.webkit.org/show_bug.cgi?id=59418
1378
1379         We don't use any of make's built-in implicit rules, turning them off
1380         speeds up parsing of the makefile.
1381
1382         * WebCore.xcodeproj/project.pbxproj:
1383         * gyp/generate-derived-sources.sh:
1384
1385 2011-04-26  Leo Yang  <leo.yang@torchmobile.com.cn>
1386
1387         Reviewed by Nikolas Zimmermann.
1388
1389         ASSERT failure in SVGUseElement
1390         https://bugs.webkit.org/show_bug.cgi?id=59313
1391
1392         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
1393         was wrong because the document may not be well-formed.
1394
1395         This patch asserts the element is not pending on resource or the
1396         document is not well-formed.
1397
1398         Test: svg/custom/use-crash-in-non-wellformed-document.svg
1399
1400         * svg/SVGUseElement.cpp:
1401         (WebCore::isWellFormedDocument):
1402         (WebCore::SVGUseElement::insertedIntoDocument):
1403
1404 2011-04-26  Mikhail Naganov  <mnaganov@chromium.org>
1405
1406         Reviewed by Pavel Feldman.
1407
1408         Web Inspector: [Chromium] Fix columns resizing in the detailed heap snapshot grids.
1409         https://bugs.webkit.org/show_bug.cgi?id=59438
1410
1411         * inspector/front-end/DetailedHeapshotView.js:
1412         (WebInspector.DetailedHeapshotView.prototype._changeView):
1413
1414 2011-04-26  David Levin  <levin@chromium.org>
1415
1416         Reviewed by Adam Barth.
1417
1418         Fix a few OwnPtr strict errors in WebCore headers.
1419         https://bugs.webkit.org/show_bug.cgi?id=59431
1420
1421         * bindings/js/ScheduledAction.cpp:
1422         (WebCore::ScheduledAction::create):
1423         * css/MediaQueryMatcher.cpp:
1424         (WebCore::MediaQueryMatcher::prepareEvaluator):
1425         * dom/NodeRareData.h:
1426         (WebCore::NodeListsNodeData::create):
1427         * dom/ScriptRunner.h:
1428         (WebCore::ScriptRunner::create):
1429         * inspector/WorkerInspectorController.cpp:
1430         (WebCore::WorkerInspectorController::connectFrontend):
1431         * loader/icon/IconDatabase.h:
1432         (WebCore::IconDatabase::create):
1433         * platform/graphics/SimpleFontData.cpp:
1434         (WebCore::SimpleFontData::verticalRightOrientationFontData):
1435         (WebCore::SimpleFontData::uprightOrientationFontData):
1436         (WebCore::SimpleFontData::brokenIdeographFontData):
1437         * rendering/style/StyleRareInheritedData.cpp:
1438         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
1439         * rendering/svg/SVGResources.h:
1440         (WebCore::SVGResources::ClipperFilterMaskerData::create):
1441         (WebCore::SVGResources::MarkerData::create):
1442         (WebCore::SVGResources::FillStrokeData::create):
1443         * storage/StorageSyncManager.cpp:
1444         (WebCore::StorageSyncManager::close):
1445         * workers/WorkerContext.cpp:
1446         (WebCore::CloseWorkerContextTask::create):
1447         * workers/WorkerMessagingProxy.cpp:
1448         (WebCore::MessageWorkerContextTask::create):
1449         (WebCore::MessageWorkerTask::create):
1450         (WebCore::WorkerExceptionTask::create):
1451         (WebCore::WorkerContextDestroyedTask::create):
1452         (WebCore::WorkerTerminateTask::create):
1453         (WebCore::WorkerThreadActivityReportTask::create):
1454         * workers/WorkerRunLoop.cpp:
1455         (WebCore::WorkerRunLoop::Task::create):
1456         * workers/WorkerThread.cpp:
1457         (WebCore::WorkerThreadStartupData::create):
1458         (WebCore::WorkerThreadShutdownFinishTask::create):
1459         (WebCore::WorkerThreadShutdownStartTask::create):
1460
1461 2011-04-26  Adam Klein  <adamk@chromium.org>
1462
1463         Reviewed by Adam Barth.
1464
1465         Fix last strict OwnPtr violation under svg/...
1466         https://bugs.webkit.org/show_bug.cgi?id=59429
1467
1468         * svg/SVGDocumentExtensions.cpp:
1469         (WebCore::SVGDocumentExtensions::removePendingResource):
1470
1471 2011-04-26  Adam Barth  <abarth@webkit.org>
1472
1473         Reviewed by David Levin.
1474
1475         Fix more strict OwnPtr violations in WebCore
1476         https://bugs.webkit.org/show_bug.cgi?id=59433
1477
1478         These manifest in the Chromium build.
1479
1480         * bindings/v8/ScriptController.cpp:
1481         (WebCore::ScriptController::ScriptController):
1482         * bindings/v8/ScriptDebugServer.cpp:
1483         (WebCore::ScriptDebugServer::editScriptSource):
1484         * bindings/v8/V8DOMMap.cpp:
1485         (WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
1486         * bindings/v8/V8Proxy.cpp:
1487         (WebCore::V8Proxy::precompileScript):
1488         * bindings/v8/WorkerScriptController.cpp:
1489         (WebCore::WorkerScriptController::WorkerScriptController):
1490         * page/Page.cpp:
1491         (WebCore::Page::Page):
1492         (WebCore::Page::speechInput):
1493         * platform/PlatformGestureRecognizer.cpp:
1494         (WebCore::PlatformGestureRecognizer::create):
1495         * platform/PlatformGestureRecognizer.h:
1496         * platform/graphics/chromium/DrawingBufferChromium.cpp:
1497         (WebCore::DrawingBuffer::DrawingBuffer):
1498         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
1499         (WebCore::CCLayerImpl::CCLayerImpl):
1500         * platform/graphics/gpu/Texture.cpp:
1501         (WebCore::Texture::create):
1502         * platform/image-decoders/bmp/BMPImageDecoder.cpp:
1503         (WebCore::BMPImageDecoder::decodeHelper):
1504         * platform/image-decoders/gif/GIFImageDecoder.cpp:
1505         (WebCore::GIFImageDecoder::decode):
1506         * platform/image-decoders/ico/ICOImageDecoder.cpp:
1507         (WebCore::ICOImageDecoder::decodeAtIndex):
1508         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
1509         (WebCore::JPEGImageDecoder::decode):
1510         * platform/image-decoders/png/PNGImageDecoder.cpp:
1511         (WebCore::PNGImageDecoder::decode):
1512         * storage/chromium/DatabaseTrackerChromium.cpp:
1513         (WebCore::DatabaseTracker::addOpenDatabase):
1514
1515 2011-04-25  David Levin  <levin@chromium.org>
1516
1517         Reviewed by Adam Barth.
1518
1519         Fix OwnPtr strict errors in CrossThreadTask.h
1520         https://bugs.webkit.org/show_bug.cgi?id=59427
1521
1522         * dom/CrossThreadTask.h:
1523         (WebCore::CrossThreadTask1::create):
1524         (WebCore::CrossThreadTask2::create):
1525         (WebCore::CrossThreadTask3::create):
1526         (WebCore::CrossThreadTask4::create):
1527         (WebCore::CrossThreadTask5::create):
1528         (WebCore::CrossThreadTask6::create):
1529         (WebCore::CrossThreadTask7::create):
1530         (WebCore::CrossThreadTask8::create):
1531
1532 2011-04-25  Mark Rowe  <mrowe@apple.com>
1533
1534         Reviewed by Dan Bernstein.
1535
1536         <rdar://problem/9330337> Leak of 'WebCore::ApplyPropertyFillLayer<WebCore::FillSize>'
1537
1538         * css/CSSStyleApplyProperty.cpp:
1539         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Don't initialize CSSPropertyWebkitMaskSize twice.
1540         * css/CSSStyleApplyProperty.h:
1541         (WebCore::CSSStyleApplyProperty::setPropertyValue): Add some asserts to catch this class of leak.
1542
1543 2011-04-25  Levi Weintraub  <leviw@chromium.org>
1544
1545         Reviewed by Ryosuke Niwa.
1546
1547         REGRESSION: a character appears after tab span when typing immediately before the tab span
1548         https://bugs.webkit.org/show_bug.cgi?id=58132
1549
1550         Correcting the order of operations we use to avoid inserting into invalid positions in
1551         ReplaceSelectionCommand to avoid inserting into tab-spans.
1552
1553         Test: editing/pasteboard/paste-before-tab-span.html
1554
1555         * editing/ReplaceSelectionCommand.cpp:
1556         (WebCore::ReplaceSelectionCommand::doApply): Moving positionOutsideTabSpan to after
1557         positionAvoidingPrecedingNodes, since that function could once again put our position
1558         inside a tab span.
1559
1560 2011-04-25  David Levin  <levin@chromium.org>
1561
1562         Reviewed by Adam Barth.
1563
1564         Fix OwnPtr strict error in ImageBuffer.h
1565         https://bugs.webkit.org/show_bug.cgi?id=59422
1566
1567         * platform/graphics/ImageBuffer.h:
1568         (WebCore::ImageBuffer::create):
1569
1570 2011-04-25  Adam Barth  <abarth@webkit.org>
1571
1572         Reviewed by David Levin.
1573
1574         Fix strict OwnPtr violations and whitelist known-tricky files
1575         https://bugs.webkit.org/show_bug.cgi?id=59421
1576
1577         With this patch, WebCore builds cleanly with strict OwnPtrs.
1578
1579         * dom/MessagePort.cpp:
1580         (WebCore::MessagePort::MessagePort):
1581         * dom/XMLDocumentParserLibxml2.cpp:
1582         * page/ContextMenuController.cpp:
1583         (WebCore::ContextMenuController::ContextMenuController):
1584         (WebCore::ContextMenuController::clearContextMenu):
1585         * page/PluginHalter.cpp:
1586         * platform/graphics/MediaPlayer.cpp:
1587         * platform/network/ResourceRequestBase.cpp:
1588         (WebCore::ResourceRequestBase::adopt):
1589         (WebCore::ResourceRequestBase::copyData):
1590         * svg/SVGDocumentExtensions.cpp:
1591
1592 2011-04-25  David Levin  <levin@chromium.org>
1593
1594         Reviewed by Adam Barth.
1595
1596         Fix OwnPtr strict errors in DatasetDOMStringMap.h.
1597         https://bugs.webkit.org/show_bug.cgi?id=59419
1598
1599         * dom/DatasetDOMStringMap.h:
1600         (WebCore::DatasetDOMStringMap::create):
1601
1602 2011-04-25  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1603
1604         Reviewed by Eric Seidel.
1605
1606         KeyboardEvent.cpp should work with strict OwnPtrs.
1607         https://bugs.webkit.org/show_bug.cgi?id=59403
1608
1609         * dom/KeyboardEvent.cpp:
1610         (WebCore::KeyboardEvent::KeyboardEvent):
1611
1612 2011-04-25  James Robinson  <jamesr@chromium.org>
1613
1614         Reviewed by Eric Seidel.
1615
1616         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
1617         https://bugs.webkit.org/show_bug.cgi?id=59377
1618
1619         * css/CSSStyleSelector.cpp:
1620         (WebCore::CSSStyleSelector::applyProperty):
1621         * page/animation/AnimationBase.cpp:
1622         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
1623         (WebCore::PropertyWrapperShadow::blend):
1624         * rendering/style/RenderStyle.cpp:
1625         (WebCore::RenderStyle::setTextShadow):
1626         (WebCore::RenderStyle::setBoxShadow):
1627         * rendering/style/RenderStyle.h:
1628         (WebCore::InheritedFlags::textShadow):
1629         * rendering/style/StyleRareInheritedData.cpp:
1630         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
1631         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
1632         * rendering/style/StyleRareInheritedData.h:
1633         * rendering/style/StyleRareNonInheritedData.cpp:
1634         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
1635
1636 2011-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1637
1638         Unreviewed, rolling out r84864.
1639         http://trac.webkit.org/changeset/84864
1640         https://bugs.webkit.org/show_bug.cgi?id=59413
1641
1642         Expect result of use-crash-in-non-wellformed-document.svg is
1643         platform dependent (Requested by leoyang on #webkit).
1644
1645         * svg/SVGUseElement.cpp:
1646         (WebCore::SVGUseElement::insertedIntoDocument):
1647
1648 2011-04-25  Leo Yang  <leo.yang@torchmobile.com.cn>
1649
1650         Reviewed by Nikolas Zimmermann.
1651
1652         ASSERT failure in SVGUseElement
1653         https://bugs.webkit.org/show_bug.cgi?id=59313
1654
1655         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
1656         was wrong because the document may not be well-formed.
1657
1658         This patch asserts the element is not pending on resource or the
1659         document is not well-formed.
1660
1661         Test: svg/custom/use-crash-in-non-wellformed-document.svg
1662
1663         * svg/SVGUseElement.cpp:
1664         (WebCore::isWellFormedDocument):
1665         (WebCore::SVGUseElement::insertedIntoDocument):
1666
1667 2011-04-25  Igor Oliveira  <igor.oliveira@openbossa.org>
1668
1669         Reviewed by Tony Chang.
1670
1671         Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class
1672         https://bugs.webkit.org/show_bug.cgi?id=59028
1673
1674         The DataTransferItemsChromium and DataTransferItemChromium code can be reused by other platforms.
1675         Moving the code for base class we can reduce the efforts to support DataTransferItems
1676         element in different platforms.
1677
1678         * Android.mk:
1679         * CMakeLists.txt:
1680         * GNUmakefile.list.am:
1681         * WebCore.gypi:
1682         * WebCore.pro:
1683         * WebCore.vcproj/WebCore.vcproj:
1684         * WebCore.xcodeproj/project.pbxproj:
1685         * dom/DataTransferItem.cpp:
1686         (WebCore::DataTransferItem::DataTransferItem):
1687         (WebCore::DataTransferItem::owner):
1688         (WebCore::DataTransferItem::kind):
1689         (WebCore::DataTransferItem::type):
1690         * dom/DataTransferItem.h:
1691         * dom/DataTransferItems.cpp: Copied from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp.
1692         (WebCore::DataTransferItems::DataTransferItems):
1693         (WebCore::DataTransferItems::length):
1694         (WebCore::DataTransferItems::item):
1695         (WebCore::DataTransferItems::deleteItem):
1696         (WebCore::DataTransferItems::clear):
1697         (WebCore::DataTransferItems::add):
1698         * dom/DataTransferItems.h:
1699         * platform/chromium/DataTransferItemChromium.cpp:
1700         (WebCore::DataTransferItem::create):
1701         (WebCore::DataTransferItemChromium::DataTransferItemChromium):
1702         (WebCore::DataTransferItemChromium::getAsString):
1703         (WebCore::DataTransferItemChromium::getAsFile):
1704         * platform/chromium/DataTransferItemChromium.h:
1705         * platform/chromium/DataTransferItemsChromium.cpp:
1706         (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
1707         * platform/chromium/DataTransferItemsChromium.h:
1708
1709 2011-04-25  Chris Marrin  <cmarrin@apple.com>
1710
1711         Reviewed by Simon Fraser.
1712
1713         REGRESSION(75137): directly composited images are double-drawn sometimes
1714         https://bugs.webkit.org/show_bug.cgi?id=58632
1715
1716         Depending on the order of operations (layout, creating compositing 
1717         layers and creating simple image layers) a layer can have both image
1718         content and have m_drawsContent=true. In this case 2 copies of the image
1719         are drawn in the layer. If the image has alpha, it looks wrong.
1720
1721         I added an updateDrawsContent() call after setting the image contents
1722         to make sure it's correct.
1723
1724         I couldn't create a test case that shows the problem because layerTreeAsText()
1725         doesn't emit enough info to show this level of detail. I've opened
1726         https://bugs.webkit.org/show_bug.cgi?id=59352 to fix that.
1727
1728         * rendering/RenderLayerBacking.cpp:
1729         (WebCore::RenderLayerBacking::updateImageContents):
1730
1731 2011-04-25  Kenneth Russell  <kbr@google.com>
1732
1733         Reviewed by David Levin.
1734
1735         Fix OwnPtr strict errors in InlineFlowBox.cpp
1736         https://bugs.webkit.org/show_bug.cgi?id=59392
1737
1738         * rendering/InlineFlowBox.cpp:
1739         (WebCore::InlineFlowBox::setLayoutOverflow):
1740         (WebCore::InlineFlowBox::setVisualOverflow):
1741
1742 2011-04-25  Kenneth Russell  <kbr@google.com>
1743
1744         Reviewed by David Levin.
1745
1746         Fix OwnPtr strict errors in TransformState.cpp
1747         https://bugs.webkit.org/show_bug.cgi?id=59380
1748
1749         * rendering/TransformState.cpp:
1750         (WebCore::TransformState::applyTransform):
1751
1752 2011-04-25  Adam Barth  <abarth@webkit.org>
1753
1754         Reviewed by James Robinson.
1755
1756         DOMWindow.cpp should work with strict OwnPtrs
1757         https://bugs.webkit.org/show_bug.cgi?id=59356
1758
1759         * page/DOMWindow.cpp:
1760         (WebCore::PostMessageTimer::fired):
1761         (WebCore::DOMWindow::postMessageTimerFired):
1762         * page/DOMWindow.h:
1763
1764 2011-04-25  Adam Klein  <adamk@chromium.org>
1765
1766         Reviewed by James Robinson.
1767
1768         Fix OwnPtr strict errors in some SVG classes.
1769         https://bugs.webkit.org/show_bug.cgi?id=59395
1770
1771         * rendering/style/SVGRenderStyleDefs.cpp:
1772         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
1773         * svg/SVGSVGElement.cpp:
1774         (WebCore::SVGSVGElement::SVGSVGElement):
1775         * svg/SVGStyledTransformableElement.cpp:
1776         (WebCore::SVGStyledTransformableElement::supplementalTransform):
1777         * svg/SVGTextElement.cpp:
1778         (WebCore::SVGTextElement::supplementalTransform):
1779         * svg/graphics/SVGImage.cpp:
1780         (WebCore::SVGImage::dataChanged):
1781
1782 2011-04-25  Adam Barth  <abarth@webkit.org>
1783
1784         Re-land changes to ValidationMessage.
1785
1786         * html/ValidationMessage.cpp:
1787         (WebCore::ValidationMessage::setMessage):
1788         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
1789         (WebCore::ValidationMessage::requestToHideMessage):
1790
1791 2011-04-25  Ojan Vafai  <ojan@chromium.org>
1792
1793         Reviewed by James Robinson.
1794
1795         fix OwnPtr strict error in FrameView.cpp
1796         https://bugs.webkit.org/show_bug.cgi?id=59402
1797
1798         * page/FrameView.cpp:
1799         (WebCore::FrameView::FrameView):
1800         (WebCore::FrameView::addWidgetToUpdate):
1801
1802 2011-04-25  Adam Klein  <adamk@chromium.org>
1803
1804         Unreviewed, rolling out r84844.
1805         http://trac.webkit.org/changeset/84844
1806         https://bugs.webkit.org/show_bug.cgi?id=59395
1807
1808         Checked in too much.
1809
1810         * rendering/style/SVGRenderStyleDefs.cpp:
1811         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
1812         * svg/SVGDocumentExtensions.cpp:
1813         (WebCore::SVGDocumentExtensions::removePendingResource):
1814         * svg/SVGSVGElement.cpp:
1815         (WebCore::SVGSVGElement::SVGSVGElement):
1816         * svg/SVGStyledTransformableElement.cpp:
1817         (WebCore::SVGStyledTransformableElement::supplementalTransform):
1818         * svg/SVGTextElement.cpp:
1819         (WebCore::SVGTextElement::supplementalTransform):
1820         * svg/graphics/SVGImage.cpp:
1821         (WebCore::SVGImage::dataChanged):
1822
1823 2011-04-25  Adrienne Walker  <enne@google.com>
1824
1825         Reviewed by David Levin.
1826
1827         Make ActiveDOMCallback play nice with OwnPtr strict mode
1828         https://bugs.webkit.org/show_bug.cgi?id=59398
1829
1830         * bindings/generic/ActiveDOMCallback.cpp:
1831         (WebCore::ActiveDOMCallback::ActiveDOMCallback):
1832
1833 2011-04-25  Adam Klein  <adamk@chromium.org>
1834
1835         Reviewed by James Robinson.
1836
1837         Fix OwnPtr strict errors in some SVG classes.
1838         https://bugs.webkit.org/show_bug.cgi?id=59395
1839
1840         * rendering/style/SVGRenderStyleDefs.cpp:
1841         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
1842         * svg/SVGSVGElement.cpp:
1843         (WebCore::SVGSVGElement::SVGSVGElement):
1844         * svg/SVGStyledTransformableElement.cpp:
1845         (WebCore::SVGStyledTransformableElement::supplementalTransform):
1846         * svg/SVGTextElement.cpp:
1847         (WebCore::SVGTextElement::supplementalTransform):
1848         * svg/graphics/SVGImage.cpp:
1849         (WebCore::SVGImage::dataChanged):
1850
1851 2011-04-25  James Robinson  <jamesr@chromium.org>
1852
1853         Unreviewed, rolling out r84835.
1854         http://trac.webkit.org/changeset/84835
1855         https://bugs.webkit.org/show_bug.cgi?id=59394
1856
1857         Breaks compile because Deque<OwnPtr> doesn't work
1858
1859         * dom/XMLDocumentParserLibxml2.cpp:
1860         (WebCore::PendingCallbacks::~PendingCallbacks):
1861         (WebCore::PendingCallbacks::appendStartElementNSCallback):
1862         (WebCore::PendingCallbacks::appendEndElementNSCallback):
1863         (WebCore::PendingCallbacks::appendCharactersCallback):
1864         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
1865         (WebCore::PendingCallbacks::appendCDATABlockCallback):
1866         (WebCore::PendingCallbacks::appendCommentCallback):
1867         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
1868         (WebCore::PendingCallbacks::appendErrorCallback):
1869         (WebCore::XMLDocumentParser::XMLDocumentParser):
1870         * html/ValidationMessage.cpp:
1871         (WebCore::ValidationMessage::setMessage):
1872         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
1873         (WebCore::ValidationMessage::requestToHideMessage):
1874
1875 2011-04-25  James Robinson  <jamesr@chromium.org>
1876
1877         Reviewed by Sam Weinig.
1878
1879         Fix OwnPtr strict mode violation in ImageBufferCG
1880         https://bugs.webkit.org/show_bug.cgi?id=59396
1881
1882         * platform/graphics/cg/ImageBufferCG.cpp:
1883         (WebCore::ImageBuffer::ImageBuffer):
1884
1885 2011-04-25  Huang Dongsung  <luxtella@company100.net>
1886
1887         Reviewed by Dirk Schulze.
1888
1889         [Skia] Remove an unused local variable in PlatformContextSkia::readbackHardwareToSoftware().
1890         https://bugs.webkit.org/show_bug.cgi?id=59308
1891
1892         An unused local variable is created and even allocates heap memory.
1893
1894         * platform/graphics/skia/PlatformContextSkia.cpp:
1895         (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
1896
1897 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
1898
1899         Qt build fix: Updated files not used by other ports for rename.
1900
1901         * bindings/js/JSTouchCustom.cpp:
1902         (WebCore::toJSNewlyCreated):
1903         * bindings/js/JSTouchListCustom.cpp:
1904         (WebCore::toJSNewlyCreated):
1905
1906 2011-04-25  Adrienne Walker  <enne@google.com>
1907
1908         Reviewed by David Levin.
1909
1910         WebCore/css/CSS* files should play nice with strict OwnPtrs
1911         https://bugs.webkit.org/show_bug.cgi?id=59382
1912
1913         * css/CSSFontFaceSource.cpp:
1914         (WebCore::CSSFontFaceSource::getFontData):
1915         * css/CSSParser.cpp:
1916         (WebCore::CSSParser::addProperty):
1917         (WebCore::CSSParser::parseValue):
1918
1919 2011-04-25  Adam Barth  <abarth@webkit.org>
1920
1921         Reviewed by James Robinson.
1922
1923         ValidationMessage and XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
1924         https://bugs.webkit.org/show_bug.cgi?id=59394
1925
1926         * dom/XMLDocumentParserLibxml2.cpp:
1927         (WebCore::PendingCallbacks::PendingCallbacks):
1928         (WebCore::PendingCallbacks::appendStartElementNSCallback):
1929         (WebCore::PendingCallbacks::appendEndElementNSCallback):
1930         (WebCore::PendingCallbacks::appendCharactersCallback):
1931         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
1932         (WebCore::PendingCallbacks::appendCDATABlockCallback):
1933         (WebCore::PendingCallbacks::appendCommentCallback):
1934         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
1935         (WebCore::PendingCallbacks::appendErrorCallback):
1936         (WebCore::XMLDocumentParser::XMLDocumentParser):
1937         * html/ValidationMessage.cpp:
1938         (WebCore::ValidationMessage::setMessage):
1939         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
1940         (WebCore::ValidationMessage::requestToHideMessage):
1941
1942 2011-04-25  James Robinson  <jamesr@chromium.org>
1943
1944         Reviewed by Adam Barth.
1945
1946         Fix OwnPtr strictness issues in WebCore/inspector/
1947         https://bugs.webkit.org/show_bug.cgi?id=59387
1948
1949         * inspector/InspectorAgent.cpp:
1950         (WebCore::InspectorAgent::InspectorAgent):
1951         * inspector/InspectorController.cpp:
1952         (WebCore::InspectorController::InspectorController):
1953         * inspector/InspectorStyleSheet.cpp:
1954         (WebCore::InspectorStyleSheet::ensureSourceData):
1955
1956 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
1957
1958         Reviewed by Beth Dakin.
1959
1960         Removed XPathNamespace because it was unused
1961         https://bugs.webkit.org/show_bug.cgi?id=59381
1962         
1963         This allows us to make Node::ownerDocument() non-virtual, though it has
1964         the unhappy side-effect of rebuilding the world.
1965
1966         * CMakeLists.txt:
1967         * GNUmakefile.list.am:
1968         * WebCore.gypi:
1969         * WebCore.pro:
1970         * WebCore.vcproj/WebCore.vcproj:
1971         * WebCore.xcodeproj/project.pbxproj: Bye bye dead code.
1972
1973         * dom/Node.h: Hello fast code!
1974
1975         * xml/XPathNamespace.cpp: Removed.
1976         * xml/XPathNamespace.h: Removed.
1977
1978 2011-04-25  Adam Barth  <abarth@webkit.org>
1979
1980         Reviewed by Darin Adler.
1981
1982         HistoryItemMac should play nice with OwnPtrs
1983         https://bugs.webkit.org/show_bug.cgi?id=59388
1984
1985         * history/mac/HistoryItemMac.mm:
1986         (WebCore::HistoryItem::setTransientProperty):
1987
1988 2011-04-25  David Levin  <levin@chromium.org>
1989
1990         Reviewed by Kenneth Russell.
1991
1992         Fix strict OwnPtrs in ContextMenuController.cpp
1993         https://bugs.webkit.org/show_bug.cgi?id=59375
1994
1995         * page/ContextMenuController.cpp:
1996         (WebCore::ContextMenuController::createContextMenu):
1997         (WebCore::separatorItem):
1998
1999 2011-04-25  Adam Barth  <abarth@webkit.org>
2000
2001         Reviewed by Darin Adler.
2002
2003         CheckedRadioButton should play nice with strict OwnPtr
2004         https://bugs.webkit.org/show_bug.cgi?id=59386
2005
2006         * dom/CheckedRadioButtons.cpp:
2007         (WebCore::CheckedRadioButtons::addButton):
2008
2009 2011-04-25  Adam Barth  <abarth@webkit.org>
2010
2011         Reviewed by David Levin.
2012
2013         Resource*.cpp should play nice with strict OwnPtrs
2014         https://bugs.webkit.org/show_bug.cgi?id=59383
2015
2016         * bridge/runtime_method.cpp:
2017         (JSC::RuntimeMethod::RuntimeMethod):
2018         * platform/network/ResourceHandle.cpp:
2019         (WebCore::ResourceHandle::ResourceHandle):
2020         * platform/network/ResourceResponseBase.cpp:
2021         (WebCore::ResourceResponseBase::adopt):
2022         (WebCore::ResourceResponseBase::copyData):
2023
2024 2011-04-25  Adam Barth  <abarth@webkit.org>
2025
2026         Reviewed by David Levin.
2027
2028         Page*.cpp and objc_runtime.mm should play nice with strict OwnPtrs
2029         https://bugs.webkit.org/show_bug.cgi?id=59374
2030
2031         * bridge/objc/objc_runtime.mm:
2032         (JSC::Bindings::callObjCFallbackObject):
2033         * page/Page.cpp:
2034         (WebCore::Page::Page):
2035         (WebCore::Page::initGroup):
2036         * page/PageGroup.cpp:
2037         (WebCore::PageGroup::addUserScriptToWorld):
2038         (WebCore::PageGroup::addUserStyleSheetToWorld):
2039         * page/mac/PageMac.cpp:
2040         (WebCore::Page::addSchedulePair):
2041
2042 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
2043
2044         Build fix: This time for sure!
2045         
2046         * dom/make_names.pl:
2047
2048 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
2049
2050         Build fix: Let's edit the script instead of the autogenrated file. That
2051         way, our change will stand the test of time.
2052
2053         * dom/make_names.pl:
2054
2055 2011-04-25  Adam Barth  <abarth@webkit.org>
2056
2057         Reviewed by David Levin.
2058
2059         Fix strict OwnPtrs in HTMLMediaElement and HTTPHeaderMap
2060         https://bugs.webkit.org/show_bug.cgi?id=59368
2061
2062         * html/HTMLMediaElement.cpp:
2063         (WebCore::HTMLMediaElement::HTMLMediaElement):
2064         * platform/network/HTTPHeaderMap.cpp:
2065         (WebCore::HTTPHeaderMap::copyData):
2066
2067 2011-04-25  James Robinson  <jamesr@chromium.org>
2068
2069         Reviewed by Adam Barth.
2070
2071         Fix strict OwnPtr violations in Render*.cpp
2072         https://bugs.webkit.org/show_bug.cgi?id=59361
2073
2074         * rendering/RenderBlock.cpp:
2075         (WebCore::RenderBlock::RenderBlock):
2076         (WebCore::RenderBlock::finishDelayUpdateScrollInfo):
2077         * rendering/RenderBox.cpp:
2078         (WebCore::RenderBox::addLayoutOverflow):
2079         (WebCore::RenderBox::addVisualOverflow):
2080         * rendering/RenderButton.cpp:
2081         (WebCore::RenderButton::styleDidChange):
2082         * rendering/RenderLayer.cpp:
2083         (WebCore::RenderLayer::updateTransform):
2084         (WebCore::RenderLayer::paintChildLayerIntoColumns):
2085         (WebCore::RenderLayer::hitTestChildLayerColumns):
2086         (WebCore::RenderLayer::ensureBacking):
2087         * rendering/RenderTable.cpp:
2088         (WebCore::RenderTable::styleDidChange):
2089         * rendering/RenderView.cpp:
2090         (WebCore::RenderView::compositor):
2091         * rendering/style/RenderStyle.cpp:
2092         (WebCore::RenderStyle::addCachedPseudoStyle):
2093         (WebCore::RenderStyle::accessCounterDirectives):
2094         (WebCore::RenderStyle::accessAnimations):
2095         (WebCore::RenderStyle::accessTransitions):
2096         * rendering/svg/RenderSVGResourceFilter.cpp:
2097         (WebCore::RenderSVGResourceFilter::applyResource):
2098         * rendering/svg/SVGResources.cpp:
2099         (WebCore::SVGResources::SVGResources):
2100
2101 2011-04-25  Adam Barth  <abarth@webkit.org>
2102
2103         Attempt to fix the compile.
2104
2105         * platform/graphics/MediaPlayer.cpp:
2106         (WebCore::MediaPlayer::loadWithNextMediaEngine):
2107
2108 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
2109
2110         Rubber-stamped by Beth Dakin.
2111
2112         Merged CREATE_DOM_NODE_WRAPPER and CREATE_DOM_OBJECT_WRAPPER into 
2113         CREATE_DOM_WRAPPER because there's no meaningful difference between
2114         them anymore.
2115
2116         * bindings/js/JSCDATASectionCustom.cpp:
2117         (WebCore::toJSNewlyCreated):
2118         * bindings/js/JSCSSRuleCustom.cpp:
2119         (WebCore::toJS):
2120         * bindings/js/JSCSSValueCustom.cpp:
2121         (WebCore::toJS):
2122         * bindings/js/JSDOMBinding.h:
2123         * bindings/js/JSDocumentCustom.cpp:
2124         (WebCore::toJS):
2125         * bindings/js/JSElementCustom.cpp:
2126         (WebCore::toJSNewlyCreated):
2127         * bindings/js/JSEventCustom.cpp:
2128         (WebCore::toJS):
2129         * bindings/js/JSHTMLCollectionCustom.cpp:
2130         (WebCore::toJS):
2131         * bindings/js/JSImageDataCustom.cpp:
2132         (WebCore::toJS):
2133         * bindings/js/JSNodeCustom.cpp:
2134         (WebCore::createWrapperInline):
2135         * bindings/js/JSSVGPathSegCustom.cpp:
2136         (WebCore::toJS):
2137         * bindings/js/JSStyleSheetCustom.cpp:
2138         (WebCore::toJS):
2139         * bindings/js/JSTextCustom.cpp:
2140         (WebCore::toJSNewlyCreated):
2141         * bindings/js/JSWebKitCSSMatrixCustom.cpp:
2142         (WebCore::JSWebKitCSSMatrixConstructor::constructJSWebKitCSSMatrix):
2143         * bindings/js/JSWebSocketCustom.cpp:
2144         (WebCore::JSWebSocketConstructor::constructJSWebSocket):
2145         * bindings/js/JSXMLHttpRequestCustom.cpp:
2146         (WebCore::JSXMLHttpRequestConstructor::constructJSXMLHttpRequest):
2147         * bindings/js/JSXSLTProcessorCustom.cpp:
2148         (WebCore::JSXSLTProcessorConstructor::constructJSXSLTProcessor):
2149
2150 2011-04-25  Adam Barth  <abarth@webkit.org>
2151
2152         Reviewed by James Robinson.
2153
2154         HTMLDocumentParser should play nice with OwnPtrs
2155         https://bugs.webkit.org/show_bug.cgi?id=59363
2156
2157         * html/parser/HTMLDocumentParser.cpp:
2158         (WebCore::HTMLDocumentParser::pumpTokenizer):
2159
2160 2011-04-25  Adam Barth  <abarth@webkit.org>
2161
2162         Reviewed by James Robinson.
2163
2164         Frame.cpp should work with strict OwnPtrs
2165         https://bugs.webkit.org/show_bug.cgi?id=59360
2166
2167         * page/Frame.cpp:
2168         (WebCore::createRegExpForLabels):
2169
2170 2011-04-25  Adam Barth  <abarth@webkit.org>
2171
2172         Reviewed by David Levin.
2173
2174         Fix strict OwnPtr in Element.cpp
2175         https://bugs.webkit.org/show_bug.cgi?id=59357
2176
2177         * dom/NodeRareData.h:
2178         (WebCore::NodeRareData::ensureEventTargetData):
2179
2180 2011-04-25  Adam Barth  <abarth@webkit.org>
2181
2182         Reviewed by David Levin.
2183
2184         Fix strict OwnPtr issues in Media*.cpp
2185         https://bugs.webkit.org/show_bug.cgi?id=59354
2186
2187         There's still a tricky case in MediaPlayer.cpp, but we'll worry about
2188         that later.
2189
2190         * css/MediaQueryMatcher.cpp:
2191         (WebCore::MediaQueryMatcher::addListener):
2192         * dom/Document.cpp:
2193         * platform/graphics/MediaPlayer.cpp:
2194         (WebCore::createNullMediaPlayer):
2195
2196 2011-04-25  James Robinson  <jamesr@chromium.org>
2197
2198         Reviewed by David Levin.
2199
2200         Fix strict OwnPtr violations in ListHashSet and RenderLayerCompositor
2201         https://bugs.webkit.org/show_bug.cgi?id=59353
2202
2203         * rendering/RenderLayerCompositor.cpp:
2204         (WebCore::RenderLayerCompositor::RenderLayerCompositor):
2205
2206 2011-04-25  Adam Barth  <abarth@webkit.org>
2207
2208         Reviewed by James Robinson.
2209
2210         Worker*.cpp should work with strict OwnPtrs
2211         https://bugs.webkit.org/show_bug.cgi?id=59346
2212
2213         * inspector/WorkerInspectorController.cpp:
2214         (WebCore::WorkerInspectorController::WorkerInspectorController):
2215         * workers/WorkerContext.cpp:
2216         (WebCore::WorkerContext::WorkerContext):
2217         * workers/WorkerRunLoop.cpp:
2218         (WebCore::WorkerRunLoop::WorkerRunLoop):
2219         * workers/WorkerScriptLoader.cpp:
2220         (WebCore::WorkerScriptLoader::createResourceRequest):
2221
2222 2011-04-25  James Robinson  <jamesr@chromium.org>
2223
2224         Reviewed by Adam Barth.
2225
2226         Remove bad use of OwnPtr::set() in IconDatabase.cpp
2227         https://bugs.webkit.org/show_bug.cgi?id=59344
2228
2229         Needed for strict OwnPtr compliance.
2230
2231         * loader/icon/IconDatabase.cpp:
2232         (WebCore::readySQLiteStatement):
2233
2234 2011-04-25  Adam Barth  <abarth@webkit.org>
2235
2236         Reviewed by Maciej Stachowiak.
2237
2238         ImageBuffer.h should work with strict OwnPtrs
2239         https://bugs.webkit.org/show_bug.cgi?id=59341
2240
2241         This patch is to prepare for the strict OwnPtr hack-a-thon.
2242
2243         * platform/graphics/ImageBuffer.h:
2244         (WebCore::ImageBuffer::create):
2245
2246 2011-04-25  Steve Falkenburg  <sfalken@apple.com>
2247
2248         Reviewed by Brian Weinstein.
2249
2250         WebCore build on Windows should include windows.h in its precompiled header to speed builds
2251         https://bugs.webkit.org/show_bug.cgi?id=59339
2252
2253         windows.h is included by several of the underlying wtf headers, including Atomics.h and
2254         ThreadingPrimitives.h anyway, so include it in the WebCorePrefix.h to speed up compilation.
2255         
2256         On my 8 core Mac Pro, this reduces a clean rebuild of debug WebCore from 8 minutes to 7 minutes
2257         (a 12% speedup).
2258
2259         * WebCorePrefix.h: Include windows.h
2260
2261 2011-04-25  Martin Robinson  <mrobinson@igalia.com>
2262
2263         Reviewed by Xan Lopez.
2264
2265         [GTK] Crash in WebCore::FrameView::notifyPageThatContentAreaWillPaint()
2266         https://bugs.webkit.org/show_bug.cgi?id=59311
2267
2268         * platform/gtk/MainFrameScrollbarGtk.cpp:
2269         (MainFrameScrollbarGtk::attachAdjustment): Before connecting an adjustment to a scrollbar
2270         disconnect any lingering signal handlers. This prevents an adjustment from controlling the
2271         active ScrollView and some zombie ScrollView.
2272
2273 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
2274
2275         Another shot at fixing the EFL build.
2276
2277         * UseJSC.cmake:
2278         * bindings/js/JSDOMBinding.cpp:
2279
2280 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
2281
2282         Try to fix EFL build.
2283
2284         * UseJSC.cmake: Added a missing file.
2285
2286 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
2287
2288         Reviewed by Oliver Hunt.
2289
2290         Removed a use of markDOMObjectWrapper: ActiveDOMObjects, Workers, and MessagePorts
2291         https://bugs.webkit.org/show_bug.cgi?id=59333
2292
2293         * WebCore.xcodeproj/project.pbxproj: Added .idl files for easier editing.
2294
2295         * bindings/js/JSDOMBinding.cpp:
2296         * bindings/js/JSDOMBinding.h:
2297         * bindings/js/JSDocumentCustom.cpp:
2298         * bindings/js/JSWorkerContextCustom.cpp:
2299         (WebCore::JSWorkerContext::visitChildren): Removed now-unused functions.
2300
2301         * bindings/scripts/CodeGeneratorJS.pm: Added support for ActiveDOMObject
2302         lifetime management.
2303
2304         * dom/Document.idl: No need for a custom mark function anymore, since
2305         ActiveDOMObjets now manage their own lifetimes.
2306
2307         * dom/MessagePort.cpp:
2308         (WebCore::MessagePort::hasPendingActivity): Correctly report that we
2309         have pending activity when we're remotely entangled, instead of relying
2310         on our clients to know this about us and do the check for us.
2311
2312         * dom/MessagePort.h: FIXME!
2313
2314         * dom/MessagePort.idl:
2315         * fileapi/DOMFileSystem.idl:
2316         * fileapi/FileReader.idl:
2317         * fileapi/FileWriter.idl:
2318         * notifications/Notification.idl:
2319         * notifications/NotificationCenter.idl:
2320         * page/EventSource.idl:
2321         * storage/IDBDatabase.idl:
2322         * storage/IDBRequest.idl:
2323         * storage/IDBTransaction.idl:
2324         * webaudio/AudioContext.idl:
2325         * websockets/WebSocket.idl:
2326         * workers/AbstractWorker.idl:
2327         * workers/SharedWorker.idl:
2328         * workers/Worker.idl: Opt in to ActiveDOMObject lifetime management.
2329
2330         * workers/WorkerContext.cpp:
2331         (WebCore::WorkerContext::hasPendingActivity): No need to make up for
2332         MessagePort::hasPendingActivity being wrong anymore, since it's now right.
2333
2334         * xml/XMLHttpRequest.idl: Opt in to ActiveDOMObject lifetime management.
2335
2336 2011-04-25  Yury Semikhatsky  <yurys@chromium.org>
2337
2338         Reviewed by Pavel Feldman.
2339
2340         Web Inspector: worker messages should be routed to corresponding worker front-end
2341         https://bugs.webkit.org/show_bug.cgi?id=59323
2342
2343         Added WorkerManager which is responsible for routing messages between
2344         Page inspector front-end and Worker inspector front-ends.
2345
2346         * WebCore.gypi:
2347         * inspector/front-end/WebKit.qrc:
2348         * inspector/front-end/WorkerManager.js: Added.
2349         (WebInspector.WorkerManager):
2350         (WebInspector.WorkerManager.loaded.InspectorFrontendHost.sendMessageToBackend):
2351         (WebInspector.WorkerManager.loaded.InspectorFrontendHost.loaded):
2352         (WebInspector.WorkerManager.loaded):
2353         (WebInspector.WorkerFrontendStub):
2354         (WebInspector.WorkerFrontendStub.prototype._receiveMessage):
2355         (WebInspector.WorkerDispatcher):
2356         (WebInspector.WorkerDispatcher.prototype._receiveMessage):
2357         (WebInspector.WorkerDispatcher.prototype.workerCreated):
2358         (WebInspector.WorkerDispatcher.prototype.dispatchMessageFromWorker):
2359         * inspector/front-end/inspector.html:
2360         * inspector/front-end/inspector.js:
2361         (WebInspector.loaded):
2362
2363 2011-04-25  Annie Sullivan  <sullivan@chromium.org>
2364
2365         Reviewed by Pavel Feldman.
2366
2367         Web Inspector: [Resources panel] Should be easy to copy data.
2368         https://bugs.webkit.org/show_bug.cgi?id=45662
2369
2370         Adds context menu items to copy resource location, resource request headers, and resource response headers.
2371
2372         * inspector/front-end/NetworkPanel.js:
2373         (WebInspector.NetworkPanel.prototype._contextMenu): Add new items to context menu.
2374         (WebInspector.NetworkPanel.prototype._exportLocation): Copy resource location to clipboard.
2375         (WebInspector.NetworkPanel.prototype._exportRequestHeaders): Copy resource request headers to clipboard.
2376         (WebInspector.NetworkPanel.prototype._exportResponseHeaders): Copy resource response headers to clipboard.
2377         * inspector/front-end/Resource.js:
2378         (WebInspector.Resource.prototype.get requestHeadersText): If _requestHeadersText is undefined, generate it from requestHeaders.
2379         (WebInspector.Resource.prototype.get responseHeadersText): If _responseHeadersText is undefined, generate it form responseHeaders.
2380
2381 2011-04-25  Alexander Pavlov  <apavlov@chromium.org>
2382
2383         Reviewed by Yury Semikhatsky.
2384
2385         Web Inspector: CSS is parsed improperly when saved in UTF-8 with a BOM
2386         https://bugs.webkit.org/show_bug.cgi?id=59322
2387
2388         Use TextResourceDecoder to determine external stylesheet charsets correctly.
2389
2390         Test: inspector/styles/parse-utf8-bom.html
2391
2392         * inspector/InspectorStyleSheet.cpp:
2393         (WebCore::InspectorStyleSheet::originalStyleSheetText):
2394
2395 2011-04-25  Pavel Feldman  <pfeldman@google.com>
2396
2397         Not reviewed: Inspector.json cleanup.
2398
2399         * inspector/Inspector.json:
2400
2401 2011-04-25  Yury Semikhatsky  <yurys@chromium.org>
2402
2403         Reviewed by Pavel Feldman.
2404
2405         Web Inspector: introduce InspectorWorkerAgent
2406         https://bugs.webkit.org/show_bug.cgi?id=59320
2407
2408         InspectorWorkerAgent is responsible for routing inspector messages
2409         between worker context inspector agents and corresponding worker
2410         inspector front-end.
2411
2412         * CMakeLists.txt:
2413         * GNUmakefile.list.am:
2414         * WebCore.gypi:
2415         * WebCore.pro:
2416         * WebCore.vcproj/WebCore.vcproj:
2417         * WebCore.xcodeproj/project.pbxproj:
2418         * inspector/CodeGeneratorInspector.pm:
2419         * inspector/Inspector.json:
2420         * inspector/InspectorAgent.cpp:
2421         (WebCore::InspectorAgent::InspectorAgent):
2422         (WebCore::InspectorAgent::setFrontend):
2423         (WebCore::InspectorAgent::disconnectFrontend):
2424         * inspector/InspectorAgent.h:
2425         (WebCore::InspectorAgent::workerAgent):
2426         * inspector/InspectorController.cpp:
2427         (WebCore::InspectorController::connectFrontend):
2428         (WebCore::InspectorController::disconnectFrontend):
2429         * inspector/InspectorInstrumentation.cpp:
2430         (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
2431         * inspector/InspectorInstrumentation.h:
2432         (WebCore::InspectorInstrumentation::willStartWorkerContext):
2433         (WebCore::InspectorInstrumentation::didStartWorkerContext):
2434         * inspector/InspectorWorkerAgent.cpp: Added.
2435         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
2436         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
2437         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::id):
2438         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::inspectorProxy):
2439         (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::sendMessageToFrontend):
2440         (WebCore::InspectorWorkerAgent::create):
2441         (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
2442         (WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
2443         (WebCore::InspectorWorkerAgent::setFrontend):
2444         (WebCore::InspectorWorkerAgent::clearFrontend):
2445         (WebCore::InspectorWorkerAgent::dispatchMessageOnWorkerInspector):
2446         (WebCore::InspectorWorkerAgent::didStartWorkerContext):
2447         * inspector/InspectorWorkerAgent.h: Added.
2448         * inspector/InstrumentingAgents.h:
2449         (WebCore::InstrumentingAgents::InstrumentingAgents):
2450         (WebCore::InstrumentingAgents::inspectorWorkerAgent):
2451         (WebCore::InstrumentingAgents::setInspectorWorkerAgent):
2452         * inspector/WorkerInspectorController.cpp:
2453         (WebCore::WorkerInspectorController::connectFrontend):
2454         * inspector/generate-inspector-idl:
2455         * workers/Worker.cpp:
2456         (WebCore::Worker::notifyFinished):
2457         * workers/WorkerContextInspectorProxy.h: Added. Platform-specific transport for inspector
2458         messages sent from the inspected page worker agent to the worker context inspector agents.
2459         (WebCore::WorkerContextInspectorProxy::connectFrontend):
2460         (WebCore::WorkerContextInspectorProxy::disconnectFrontend):
2461         (WebCore::WorkerContextInspectorProxy::sendMessageToWorkerContextInspector):
2462         (WebCore::WorkerContextInspectorProxy::~WorkerContextInspectorProxy):
2463         * workers/WorkerContextProxy.h:
2464         (WebCore::WorkerContextProxy::inspectorProxy):
2465
2466 2011-04-25  Pavel Feldman  <pfeldman@google.com>
2467
2468         Reviewed by Yury Semikhatsky.
2469
2470         Web Inspector: move Frame and Resource Tree management into the Page agent.
2471         https://bugs.webkit.org/show_bug.cgi?id=59321
2472
2473         Network agent should only handle network-related activities.
2474         Frame structure should be managed by the Page agent instead.
2475
2476         * inspector/Inspector.json:
2477         * inspector/InspectorAgent.cpp:
2478         (WebCore::InspectorAgent::InspectorAgent):
2479         * inspector/InspectorDOMAgent.cpp:
2480         (WebCore::InspectorDOMAgent::InspectorDOMAgent):
2481         (WebCore::InspectorDOMAgent::setFrontend):
2482         (WebCore::InspectorDOMAgent::restore):
2483         (WebCore::InspectorDOMAgent::highlightFrame):
2484         * inspector/InspectorDOMAgent.h:
2485         (WebCore::InspectorDOMAgent::create):
2486         * inspector/InspectorInstrumentation.cpp:
2487         (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
2488         (WebCore::InspectorInstrumentation::loadEventFiredImpl):
2489         (WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
2490         (WebCore::InspectorInstrumentation::didCommitLoadImpl):
2491         * inspector/InspectorPageAgent.cpp:
2492         (WebCore::InspectorPageAgent::create):
2493         (WebCore::InspectorPageAgent::resourceContent):
2494         (WebCore::InspectorPageAgent::resourceContentBase64):
2495         (WebCore::InspectorPageAgent::resourceData):
2496         (WebCore::InspectorPageAgent::cachedResource):
2497         (WebCore::InspectorPageAgent::resourceTypeString):
2498         (WebCore::InspectorPageAgent::cachedResourceType):
2499         (WebCore::InspectorPageAgent::cachedResourceTypeString):
2500         (WebCore::InspectorPageAgent::InspectorPageAgent):
2501         (WebCore::InspectorPageAgent::setFrontend):
2502         (WebCore::InspectorPageAgent::reload):
2503         (WebCore::InspectorPageAgent::open):
2504         (WebCore::InspectorPageAgent::getCookies):
2505         (WebCore::InspectorPageAgent::deleteCookie):
2506         (WebCore::InspectorPageAgent::getResourceTree):
2507         (WebCore::InspectorPageAgent::getResourceContent):
2508         (WebCore::InspectorPageAgent::restore):
2509         (WebCore::InspectorPageAgent::domContentEventFired):
2510         (WebCore::InspectorPageAgent::loadEventFired):
2511         (WebCore::InspectorPageAgent::frameNavigated):
2512         (WebCore::InspectorPageAgent::frameDetached):
2513         (WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
2514         (WebCore::InspectorPageAgent::mainFrame):
2515         (WebCore::pointerAsId):
2516         (WebCore::InspectorPageAgent::frameForId):
2517         (WebCore::InspectorPageAgent::frameId):
2518         (WebCore::InspectorPageAgent::loaderId):
2519         (WebCore::InspectorPageAgent::buildObjectForFrame):
2520         (WebCore::InspectorPageAgent::buildObjectForFrameTree):
2521         * inspector/InspectorPageAgent.h:
2522         * inspector/InspectorResourceAgent.cpp:
2523         (WebCore::buildObjectForCachedResource):
2524         (WebCore::InspectorResourceAgent::willSendRequest):
2525         (WebCore::InspectorResourceAgent::didReceiveResponse):
2526         (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
2527         (WebCore::InspectorResourceAgent::setInitialScriptContent):
2528         (WebCore::InspectorResourceAgent::setInitialXHRContent):
2529         (WebCore::InspectorResourceAgent::InspectorResourceAgent):
2530         * inspector/InspectorResourceAgent.h:
2531         (WebCore::InspectorResourceAgent::create):
2532         * inspector/InspectorStyleSheet.cpp:
2533         (WebCore::InspectorStyleSheet::resourceStyleSheetText):
2534         * inspector/front-end/NetworkManager.js:
2535         (WebInspector.NetworkManager.prototype.requestContent):
2536         * inspector/front-end/NetworkPanel.js:
2537         (WebInspector.NetworkPanel):
2538         (WebInspector.NetworkPanel.prototype.frameNavigated):
2539         * inspector/front-end/ResourceTreeModel.js:
2540         (WebInspector.ResourceTreeModel):
2541         (WebInspector.ResourceTreeModel.prototype.frontendReused):
2542         (WebInspector.ResourceTreeModel.prototype.frameNavigated):
2543         (WebInspector.ResourceTreeModel.prototype.frameDetached):
2544         * inspector/front-end/inspector.js:
2545         (WebInspector.domContentEventFired):
2546         (WebInspector.loadEventFired):
2547         (WebInspector.frameNavigated):
2548         (WebInspector.frameDetached):
2549
2550 2011-04-25  Pavel Feldman  <pfeldman@google.com>
2551
2552         Reviewed by Yury Semikhatsky.
2553
2554         Web Inspector: few protocol improvements.
2555         https://bugs.webkit.org/show_bug.cgi?id=59319
2556
2557         - Page domain is documented
2558         - setUserAgentOverride is moved to the Network agent
2559         - setSearchingForNode -> setInspectModeEnabled
2560         - highlightDOMNode -> highlightNode
2561         - reloadPage -> reload
2562         - openInNewWindow -> open with optional parameter
2563
2564         * inspector/Inspector.json:
2565         * inspector/InspectorDOMAgent.cpp:
2566         (WebCore::InspectorDOMAgent::setInspectModeEnabled):
2567         (WebCore::InspectorDOMAgent::highlightNode):
2568         * inspector/InspectorDOMAgent.h:
2569         (WebCore::InspectorDOMAgent::hideNodeHighlight):
2570         * inspector/InspectorInstrumentation.cpp:
2571         (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
2572         * inspector/InspectorPageAgent.cpp:
2573         (WebCore::InspectorPageAgent::clearFrontend):
2574         (WebCore::InspectorPageAgent::reload):
2575         (WebCore::InspectorPageAgent::open):
2576         * inspector/InspectorPageAgent.h:
2577         * inspector/InspectorResourceAgent.cpp:
2578         (WebCore::InspectorResourceAgent::clearFrontend):
2579         (WebCore::InspectorResourceAgent::applyUserAgentOverride):
2580         (WebCore::InspectorResourceAgent::setUserAgentOverride):
2581         * inspector/InspectorResourceAgent.h:
2582         * inspector/front-end/AuditsPanel.js:
2583         (WebInspector.AuditsPanel.prototype._reloadResources):
2584         * inspector/front-end/ElementsPanel.js:
2585         (WebInspector.ElementsPanel.prototype.setSearchingForNode):
2586         * inspector/front-end/ExtensionServer.js:
2587         (WebInspector.ExtensionServer.prototype._onReload):
2588         * inspector/front-end/NetworkPanel.js:
2589         (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
2590         * inspector/front-end/ResourcesPanel.js:
2591         (WebInspector.FrameResourceTreeElement.prototype.ondblclick):
2592         * inspector/front-end/inspector.js:
2593         (WebInspector.highlightDOMNode):
2594         (WebInspector.openResource):
2595         (WebInspector.documentKeyDown):
2596
2597 2011-04-25  Jon Lee  <jonlee@apple.com>
2598
2599         Reviewed by Maciej Stachowiak.
2600
2601         Overlay scroller hard to see on pages with dark background (59183)
2602         https://bugs.webkit.org/show_bug.cgi?id=59183
2603         <rdar://problem/8975367>
2604
2605         Switch the scrollbar's overlay style depending on its frame's background color.
2606         This refactors the getDocumentBackgroundColor method needed for gestures. The style
2607         is determined and set on every paint() call to the Mac scrollbar theme.
2608
2609         * WebCore.exp.in: adding method to allow changing style
2610         * page/Frame.cpp:
2611         (WebCore::Frame::getDocumentBackgroundColor): moving code from WebFrame for reuse by FrameView
2612         * page/Frame.h:
2613         * page/FrameView.cpp:
2614         (WebCore::FrameView::recommendedScrollbarOverlayStyle): overridden to suggest a style based on CSS background color
2615         * page/FrameView.h:
2616         * platform/ScrollTypes.h: new enum to represent different overlay scrollbar styles
2617         * platform/ScrollableArea.h:
2618         (WebCore::ScrollableArea::recommendedScrollbarOverlayStyle): new virtual function to return a suggested overlay style
2619         * platform/mac/ScrollbarThemeMac.mm:
2620         (WebCore::ScrollbarThemeMac::paint):
2621         * platform/mac/WebCoreSystemInterface.h:
2622         * platform/mac/WebCoreSystemInterface.mm:
2623
2624 2011-04-25  Dan Bernstein  <mitz@apple.com>
2625
2626         Reviewed by Maciej Stachowiak.
2627
2628         <rdar://problem/9113516> REGRESSION (WK2): Holding down Option while dragging scrollbar thumb has no effect (should make scroll distance equal mouse translation)
2629         https://bugs.webkit.org/show_bug.cgi?id=59315
2630
2631         * platform/Scrollbar.cpp:
2632         (WebCore::Scrollbar::Scrollbar): Initialize new member variables.
2633         (WebCore::Scrollbar::moveThumb): Added a boolean draggingDocument parameter. When true, the document
2634         is scrolled a distance equal to the change in the mouse position.
2635         (WebCore::Scrollbar::mouseMoved): Check with the theme whether the mouse move event should drag
2636         the document rather than the thumb, and pass the result to moveThumb.
2637         (WebCore::Scrollbar::mouseUp): Reset m_draggingDocument.
2638         * platform/Scrollbar.h:
2639         * platform/ScrollbarTheme.h:
2640         (WebCore::ScrollbarTheme::shouldDragDocumentInsteadOfThumb): Added. The base class implementation
2641         returns false.
2642         * platform/mac/ScrollbarThemeMac.h:
2643         * platform/mac/ScrollbarThemeMac.mm:
2644         (WebCore::ScrollbarThemeMac::shouldDragDocumentInsteadOfThumb): Overridden to return true if the
2645         Option key is down.
2646
2647 2011-04-24  Geoffrey Garen  <ggaren@apple.com>
2648
2649         Reviewed by Sam Weinig.
2650
2651         Removed a use of markDOMObjectWrapper: WebGL, XHR, workers; plus, more autogeneration
2652         https://bugs.webkit.org/show_bug.cgi?id=59307
2653
2654         * WebCore.xcodeproj/project.pbxproj: Added Blob.idl, so it's easier to edit.
2655
2656         * bindings/js/JSCSSRuleCustom.cpp:
2657         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
2658         * bindings/js/JSCanvasRenderingContextCustom.cpp:
2659         * bindings/js/JSDOMApplicationCacheCustom.cpp: Autogenerate these instead
2660         of hand-coding them.
2661
2662         * bindings/js/JSDOMBinding.h:
2663         (WebCore::root): Moved some GC helpers here from JSNodeCustom.h, because
2664         they're reasonably generic.
2665
2666         * bindings/js/JSDOMImplementationCustom.cpp:
2667         * bindings/js/JSDOMStringMapCustom.cpp:
2668         * bindings/js/JSDOMTokenListCustom.cpp:
2669         * bindings/js/JSHTMLCollectionCustom.cpp:
2670         * bindings/js/JSMediaListCustom.cpp: Autogenerate these instead of
2671         hand-coding them.
2672
2673         * bindings/js/JSMessageChannelCustom.cpp:
2674         (WebCore::JSMessageChannel::visitChildren):
2675         * bindings/js/JSMessagePortCustom.cpp:
2676         (WebCore::JSMessagePort::visitChildren): Use addOpaqueRoot instead of
2677         markDOMObjectWrapper. This is one of the few cases where a DOM object is
2678         considered a stand-alone root. It's not as efficient as the shared root
2679         case, but workers and message ports are very rare objects, so it's no
2680         big deal.
2681
2682         * bindings/js/JSNamedNodeMapCustom.cpp: Autogenerate!
2683
2684         * bindings/js/JSNodeCustom.h: Moved to JSDOMBinding.h.
2685
2686         * bindings/js/JSSharedWorkerCustom.cpp:
2687         (WebCore::JSSharedWorker::visitChildren): Use addOpaqueRoot instead of
2688         markDOMObjectWrapper, as above. Once again, a stand-alone root.
2689
2690         * bindings/js/JSStyleSheetCustom.cpp:
2691         * bindings/js/JSStyleSheetListCustom.cpp: Autogenerate!
2692
2693         * bindings/js/JSWebGLRenderingContextCustom.cpp:
2694         (WebCore::JSWebGLRenderingContext::visitChildren): Use the opaque roots
2695         system for marking WebGL contexts and their associated satellite objects.
2696
2697         * bindings/js/JSWorkerContextCustom.cpp:
2698         (WebCore::JSWorkerContext::visitChildren):
2699         * bindings/js/JSXMLHttpRequestCustom.cpp: Use addOpaqueRoot instead of
2700         markDOMObjectWrapper, as above. Once again, stand-alone roots.
2701
2702         (WebCore::JSXMLHttpRequest::visitChildren):
2703         * bindings/js/JSXMLHttpRequestUploadCustom.cpp: No need to mark our owner
2704         XHR because it is not reachable from us.
2705
2706         * bindings/scripts/CodeGeneratorJS.pm: Added autogeneration support for a
2707         bunch of repetitive cases of isReachableFromOpaqueRoots callbacks.
2708
2709         * css/CSSRule.idl:
2710         * css/CSSStyleDeclaration.idl:
2711         * css/MediaList.idl:
2712         * css/StyleMedia.idl:
2713         * css/StyleSheet.idl:
2714         * css/StyleSheetList.idl:
2715         * dom/DOMImplementation.idl:
2716         * dom/DOMStringMap.idl:
2717         * dom/MessagePort.idl:
2718         * dom/NamedNodeMap.idl:
2719         * fileapi/Blob.idl:
2720         * html/DOMTokenList.idl: Opt in to autogeneration.
2721
2722         * html/HTMLCanvasElement.cpp:
2723         (WebCore::HTMLCanvasElement::getContext): Standardized on PassOwnPtr/OwnPtr
2724         usage, to reduce human error and make ownership rules more obvious.
2725
2726         * html/HTMLCollection.idl:
2727         * html/canvas/ArrayBuffer.idl: Opt in to autogeneration.
2728
2729         * html/canvas/CanvasRenderingContext.cpp:
2730         * html/canvas/CanvasRenderingContext.h:
2731         (WebCore::CanvasRenderingContext::ref):
2732         (WebCore::CanvasRenderingContext::deref):
2733         * html/canvas/CanvasRenderingContext2D.h:
2734         (WebCore::CanvasRenderingContext2D::create):
2735         (WebCore::CanvasRenderingContext2D::state): Standardized on PassOwnPtr/OwnPtr
2736         usage, to reduce human error and make ownership rules more obvious.
2737         
2738         Inlined some functions to match our standard idiom and to make the code
2739         in the header document itself.
2740
2741         * html/canvas/CanvasRenderingContext.idl: Opt in to autogeneration.
2742
2743         * html/canvas/OESStandardDerivatives.cpp:
2744         (WebCore::OESStandardDerivatives::OESStandardDerivatives):
2745         (WebCore::OESStandardDerivatives::create):
2746         * html/canvas/OESStandardDerivatives.h:
2747         * html/canvas/OESStandardDerivatives.idl:
2748         * html/canvas/OESTextureFloat.cpp:
2749         (WebCore::OESTextureFloat::OESTextureFloat):
2750         (WebCore::OESTextureFloat::create):
2751         * html/canvas/OESTextureFloat.h:
2752         * html/canvas/OESTextureFloat.idl:
2753         * html/canvas/OESVertexArrayObject.cpp:
2754         (WebCore::OESVertexArrayObject::OESVertexArrayObject):
2755         (WebCore::OESVertexArrayObject::create):
2756         * html/canvas/OESVertexArrayObject.h:
2757         * html/canvas/OESVertexArrayObject.idl:
2758         * html/canvas/WebGLExtension.cpp:
2759         (WebCore::WebGLExtension::WebGLExtension):
2760         * html/canvas/WebGLExtension.h:
2761         (WebCore::WebGLExtension::ref):
2762         (WebCore::WebGLExtension::deref):
2763         (WebCore::WebGLExtension::context):
2764         * html/canvas/WebGLRenderingContext.cpp:
2765         (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
2766         (WebCore::WebGLRenderingContext::getExtension):
2767         * html/canvas/WebGLRenderingContext.h:
2768         * html/canvas/WebKitLoseContext.cpp:
2769         (WebCore::WebKitLoseContext::WebKitLoseContext):
2770         (WebCore::WebKitLoseContext::create):
2771         (WebCore::WebKitLoseContext::loseContext):
2772         * html/canvas/WebKitLoseContext.h:
2773         * html/canvas/WebKitLoseContext.idl: Updated the ownership model for WebGL
2774         canavs rendering contexts to match the model for 2D canvas rendering
2775         contexts. This makes garbage collection a lot more straightforward, but
2776         it also makes the behavior of these objects more reliable. (Previously,
2777         satellite objects would magically stop working when the last reference
2778         to their owner object was dropped. Now, satellite objects keep their owner
2779         alive through reference counting.)
2780
2781         * loader/appcache/DOMApplicationCache.idl:
2782         * page/BarInfo.idl:
2783         * page/Console.idl:
2784         * page/DOMSelection.idl:
2785         * page/Geolocation.idl:
2786         * page/History.idl:
2787         * page/Location.idl:
2788         * page/Navigator.idl:
2789         * page/Screen.idl:
2790         * page/WorkerNavigator.idl:
2791         * plugins/DOMMimeTypeArray.h:
2792         (WebCore::DOMMimeTypeArray::frame):
2793         * plugins/DOMMimeTypeArray.idl:
2794         * plugins/DOMPluginArray.h:
2795         (WebCore::DOMPluginArray::frame):
2796         * plugins/DOMPluginArray.idl:
2797         * storage/Storage.idl:
2798         * workers/WorkerLocation.idl: Opt in to autogeneration.
2799
2800         * xml/XMLHttpRequest.cpp:
2801         (WebCore::XMLHttpRequest::~XMLHttpRequest):
2802         * xml/XMLHttpRequest.h:
2803         * xml/XMLHttpRequestUpload.cpp:
2804         (WebCore::XMLHttpRequestUpload::scriptExecutionContext):
2805         * xml/XMLHttpRequestUpload.h:
2806         (WebCore::XMLHttpRequestUpload::create):
2807         (WebCore::XMLHttpRequestUpload::ref):
2808         (WebCore::XMLHttpRequestUpload::deref):
2809         (WebCore::XMLHttpRequestUpload::xmlHttpRequest):
2810         (WebCore::XMLHttpRequestUpload::toXMLHttpRequestUpload):
2811         * xml/XMLHttpRequestUpload.idl: Updated the ownership model for XHR and
2812         its associated upload object to match the model for canvas. This makes
2813         garbage collection a lot more straightforward, but it also makes the
2814         behavior of these objects more reliable.
2815
2816 2011-04-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2817
2818         Unreviewed, rolling out r84759.
2819         http://trac.webkit.org/changeset/84759
2820         https://bugs.webkit.org/show_bug.cgi?id=59306
2821
2822         Caused gc-shadow.html to start crashing in V8. (Requested by
2823         dglazkov|away on #webkit).
2824
2825         * dom/Node.cpp:
2826         (WebCore::NodeRendererFactory::createRendererAndStyle):
2827         (WebCore::Node::styleForRenderer):
2828
2829 2011-04-24  Maciej Stachowiak  <mjs@apple.com>
2830
2831         Reviewed by George Staikos.
2832
2833         Handling of URLs like http:/example.com/ is incorrect
2834         https://bugs.webkit.org/show_bug.cgi?id=59300
2835         <rdar://problem/9231956>
2836
2837         URLs like http:/example.com/ or http:example.com/ are now correctly
2838         canonicalized as http://example.com/
2839         
2840         The code still doesn't quite match other browsers - at least some
2841         other browsers seem to base parsing behavior on whether they
2842         recongize a scheme from a fixed list, and ignore whether // is
2843         present in the URL or not.
2844         
2845         * platform/KURL.cpp:
2846         (WebCore::isNonFileHierarchicalScheme): New helper function.
2847         (WebCore::KURL::parse): For a particular list of whitelisted schemes,
2848         assume they are hierarchical and need an authority even if there is no //
2849         after the :/
2850
2851 2011-04-24  Dan Bernstein  <mitz@apple.com>
2852
2853         LLVM Compiler build fix.
2854
2855         * page/ContentSecurityPolicy.cpp: Removed an unused function.
2856
2857 2011-04-24  Dominic Cooney  <dominicc@chromium.org>
2858
2859         Reviewed by Dimitri Glazkov.
2860
2861         Crash when adding a text node to a shadow root
2862         https://bugs.webkit.org/show_bug.cgi?id=59304
2863
2864         Text nodes need to consult their host element for style.
2865
2866         Test: fast/dom/shadow/append-child-text.html
2867
2868         * dom/Node.cpp:
2869         (WebCore::NodeRendererFactory::styleForRenderer):
2870         (WebCore::NodeRendererFactory::createRendererAndStyle):
2871         (WebCore::Node::styleForRenderer): forward to NodeRendererFactory
2872
2873 2011-04-24  Adam Barth  <abarth@webkit.org>
2874
2875         Reviewed by Eric Seidel.
2876
2877         Update Content-Security-Policy syntax to match new version of spec
2878         https://bugs.webkit.org/show_bug.cgi?id=59291
2879
2880         Brandon removed disable-xss-protection in favor of unsafe-inline and
2881         allow-eval in favor of unsafe-eval.  This change in syntax also means
2882         the options directive no longer exists.
2883
2884         * page/ContentSecurityPolicy.cpp:
2885         (WebCore::CSPSourceList::allowInline):
2886         (WebCore::CSPSourceList::allowEval):
2887         (WebCore::CSPSourceList::CSPSourceList):
2888         (WebCore::CSPSourceList::parseSource):
2889         (WebCore::CSPSourceList::addSourceUnsafeInline):
2890         (WebCore::CSPSourceList::addSourceUnsafeEval):
2891         (WebCore::CSPDirective::allowInline):
2892         (WebCore::CSPDirective::allowEval):
2893         (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
2894         (WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
2895         (WebCore::ContentSecurityPolicy::allowInlineScript):
2896         (WebCore::ContentSecurityPolicy::allowEval):
2897         (WebCore::ContentSecurityPolicy::addDirective):
2898         * page/ContentSecurityPolicy.h:
2899
2900 2011-04-24  Dan Bernstein  <mitz@apple.com>
2901
2902         Reviewed by Maciej Stachowiak.
2903
2904         Manual test for <rdar://problem/9329741> Reproducible crash in WebChromeClient::invalidateContentsAndWindow() on simonscat.com
2905         https://bugs.webkit.org/show_bug.cgi?id=59299
2906
2907         * manual-tests/back-from-document-with-scrollbar.html: Added.
2908
2909 2011-04-24  Rik Cabanier  <cabanier@adobe.com>
2910
2911         Reviewed by Simon Fraser.
2912
2913         Tables are not rendered correctly
2914         https://bugs.webkit.org/show_bug.cgi?id=59138
2915
2916         Test: fast/table/auto-100-percent-width.html
2917
2918         * rendering/AutoTableLayout.cpp:
2919         (WebCore::AutoTableLayout::computePreferredLogicalWidths):
2920
2921 2011-04-23  Simon Fraser  <simon.fraser@apple.com>
2922
2923         Fix Windows build, which complains about unreachable code.
2924
2925         * platform/ScrollableArea.cpp:
2926         (WebCore::ScrollableArea::hasLayerForHorizontalScrollbar):
2927         (WebCore::ScrollableArea::hasLayerForVerticalScrollbar):
2928         (WebCore::ScrollableArea::hasLayerForScrollCorner):
2929
2930 2011-04-23  Simon Fraser  <simon.fraser@apple.com>
2931
2932         Reviewed by Dan Bernstein.
2933
2934         Area under composited scrollbars not repainted in WebKit2 on scrolling
2935         https://bugs.webkit.org/show_bug.cgi?id=59294
2936         <rdar://problem/9299062>
2937         
2938         When computing the rect that can be copied on scrolling, we normally
2939         exclude the areas occupied by overlay scrollbars to avoid smeared scrollbars;
2940         the assumption is that other code will repaint these areas. However, when
2941         scrollbars are in their own compositing layers, we can, and should
2942         copy the entire area.
2943
2944         Not testable in DRT because it does not allow tests to use overlay scrollbars.
2945
2946         * platform/ScrollView.h:
2947         * platform/ScrollView.cpp:
2948         (WebCore::ScrollView::rectToCopyOnScroll):
2949         New method, with code moved from scrollContents and fixed to look
2950         for scrollbars in layers.
2951         (WebCore::ScrollView::scrollContents):
2952         Call rectToCopyOnScroll().
2953         
2954         * platform/ScrollableArea.h:
2955         * platform/ScrollableArea.cpp:
2956         (WebCore::ScrollableArea::hasLayerForHorizontalScrollbar):
2957         (WebCore::ScrollableArea::hasLayerForVerticalScrollbar):
2958         (WebCore::ScrollableArea::hasLayerForScrollCorner):
2959         Methods we can call outside of the ACCELERATED_COMPOSITING #ifdef.
2960
2961 2011-04-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2962
2963         Unreviewed, rolling out r84740.
2964         http://trac.webkit.org/changeset/84740
2965         https://bugs.webkit.org/show_bug.cgi?id=59290
2966
2967         change breaks apple internal builds and is incorrect
2968         (Requested by smfr on #webkit).
2969
2970         * WebCore.exp.in:
2971         * page/FrameView.cpp:
2972         * page/FrameView.h:
2973         * platform/ScrollTypes.h:
2974         * platform/ScrollableArea.h:
2975         * platform/mac/ScrollbarThemeMac.mm:
2976         (WebCore::ScrollbarThemeMac::paint):
2977         * platform/mac/WebCoreSystemInterface.h:
2978         * platform/mac/WebCoreSystemInterface.mm:
2979
2980 2011-04-23  Dan Bernstein  <mitz@apple.com>
2981
2982         Reviewed by Simon Fraser.
2983
2984         <rdar://problem/8970549> WebFindOptionsAtWordStarts fails with Japanese words
2985         https://bugs.webkit.org/show_bug.cgi?id=59288
2986
2987         * platform/text/mac/TextBoundaries.mm:
2988         (WebCore::wordStringTokenizer): Added this helper function.
2989         (WebCore::findNextWordFromIndex): Changed to use a CFStringTokenizer with kCFStringTokenizerUnitWord,
2990         whose behavior is not locale-dependent.
2991
2992 2011-04-23  Dominic Cooney  <dominicc@chromium.org>
2993
2994         Reviewed by Dimitri Glazkov.
2995
2996         [V8] Nodes in shadow DOM should not be GCed while their hosts are alive
2997         https://bugs.webkit.org/show_bug.cgi?id=59284
2998
2999         Test: fast/dom/shadow/gc-shadow.html
3000
3001         * bindings/v8/V8GCController.cpp:
3002         (WebCore::calculateGroupId): group shadow nodes with their hosts
3003
3004 2011-04-23  MORITA Hajime <morrita@google.com>
3005
3006         Reviewed by Dimitri Glazkov.
3007
3008         [Refactoring] NodeRenderParentDetector should be NodeRenderFactory
3009         https://bugs.webkit.org/show_bug.cgi?id=59280
3010         
3011         - Rename NodeRenderParentDetector to NodeRendererFactory
3012         - move createRendererAndStyle() and createRendererIfNeeded to
3013           NodeRendererFactory
3014
3015         No new test, no behavioral change.
3016         
3017         * dom/Node.cpp:
3018         (WebCore::NodeRendererFactory::NodeRendererFactory):
3019         (WebCore::NodeRendererFactory::document):
3020         (WebCore::NodeRendererFactory::nextRenderer):
3021         (WebCore::NodeRendererFactory::findVisualParent):
3022         (WebCore::NodeRendererFactory::shouldCreateRenderer):
3023         (WebCore::NodeRendererFactory::createRendererAndStyle):
3024         (WebCore::NodeRendererFactory::createRendererIfNeeded):
3025         (WebCore::Node::parentNodeForRenderingAndStyle):
3026         (WebCore::Node::createRendererIfNeeded):
3027         * dom/Node.h:
3028         * html/HTMLDetailsElement.cpp:
3029         (WebCore::DetailsSummaryElement::detailsElement): Added const_cast due to the chage on parentNodeForRenderingAndStyle() 
3030
3031 2011-04-23  MORITA Hajime  <morrita@google.com>
3032
3033         Reviewed by Kent Tamura.
3034
3035         REGRESSION: (non-Mac) <meter>'s bar part isn't rendered for with -webkit-writing-mode: vertical-lr from r82899
3036         https://bugs.webkit.org/show_bug.cgi?id=59281
3037
3038         Styles for -webkit-meter-bar and -webkit-progress-bar missed width property, which caused unexpected layout results
3039         for vertical writing modes. This fix added a width property for each of them.
3040         
3041         Tests: fast/dom/HTMLMeterElement/meter-writing-mode.html
3042                fast/dom/HTMLProgressElement/progress-writing-mode.html
3043
3044         * css/html.css:
3045         (meter::-webkit-meter-bar):
3046         (progress::-webkit-progress-bar):
3047
3048 2011-04-23  Kevin Ollivier  <kevino@theolliviers.com>
3049
3050         [wx] Unreviewed build fix. Added missing header.
3051         
3052         * platform/graphics/filters/FEDropShadow.h:
3053
3054 2011-04-23  Alexey Proskuryakov  <ap@apple.com>
3055
3056         Reviewed by Maciej Stachowiak.
3057
3058         REGRESSION (r80812): window.print();window.close() doesn't work in WebKit2
3059         https://bugs.webkit.org/show_bug.cgi?id=59241
3060         <rdar://problem/9150861>
3061
3062         Covered by manual-tests/print-after-window-close.html.
3063
3064         Re-fixing <https://bugs.webkit.org/show_bug.cgi?id=51357> in a way that doesn't cause the
3065         regression.
3066
3067         * loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didCancel): We shouldn't be
3068         doing complicated work while the loader is half-canceled.
3069
3070         * manual-tests/print-after-window-close.html: Extended to actually print a non-empty page,
3071         thus being more practical.
3072
3073         * page/Chrome.cpp: (WebCore::Chrome::print): Added a FIXME about a need for PageGroupLoadDeferrer.
3074         It's too scary for me to try now.
3075
3076         * page/DOMWindow.cpp:
3077         (WebCore::DOMWindow::DOMWindow):
3078         (WebCore::DOMWindow::finishedLoading):
3079         * page/DOMWindow.h:
3080         Reverted the previous fix for <https://bugs.webkit.org/show_bug.cgi?id=51357>.
3081
3082 2011-04-19  Vitaly Repeshko  <vitalyr@chromium.org>
3083
3084         Reviewed by Adam Barth.
3085
3086         [V8] Use implicit references for V8 listeners on DOM nodes.
3087         https://bugs.webkit.org/show_bug.cgi?id=58953
3088
3089         Instead of allocating an auxiliary V8 array referencing V8
3090         listener objects associated with a DOM node and using an extra
3091         pointer in every DOM node wrapper, we can register implicit
3092         references between nodes and their listeners during GC. This also
3093         makes V8 bindings more aligned with JSC bindings.
3094
3095         No new tests because this is a refactoring.
3096
3097         * bindings/scripts/CodeGeneratorV8.pm: Stopped generating the
3098         listener cache internal field for DOM nodes.
3099         * bindings/v8/V8AbstractEventListener.h: Exposed the lister handle
3100         to the GC.
3101         (WebCore::V8AbstractEventListener::existingListenerObjectPeristentHandle):
3102         * bindings/v8/V8GCController.cpp: Started using implicit references.
3103         (WebCore::GrouperVisitor::visitDOMWrapper):
3104         * dom/EventTarget.h: Implemented an iterator over all listeners.
3105         (WebCore::EventListenerIterator):
3106
3107 2011-04-22  Jon Lee  <jonlee@apple.com>
3108
3109         Reviewed by Beth Dakin.
3110
3111         Overlay scroller hard to see on pages with dark background (59183)
3112         https://bugs.webkit.org/show_bug.cgi?id=59183
3113         <rdar://problem/8975367>
3114
3115         * WebCore.exp.in: adding method to allow changing style
3116         * page/FrameView.cpp:
3117         (WebCore::FrameView::recommendedScrollbarOverlayStyle): overridden to suggest a style based on CSS background color
3118         * page/FrameView.h:
3119         * platform/ScrollTypes.h: new enum to represent different overlay scrollbar styles
3120         * platform/ScrollableArea.cpp:
3121         (WebCore::ScrollableArea::recommendedScrollbarOverlayStyle): new virtual function to return a suggested overlay style
3122         * platform/ScrollableArea.h:
3123         * platform/mac/ScrollbarThemeMac.mm:
3124         (WebCore::ScrollbarThemeMac::paint):
3125         * platform/mac/WebCoreSystemInterface.h:
3126         * platform/mac/WebCoreSystemInterface.mm:
3127
3128 2011-04-22  Chris Evans  <cevans@chromium.org>
3129
3130         Reviewed by Adam Barth.
3131
3132         Upgrade CSS loads from mixed content warning (displayed) to mixed
3133         content error (ran)
3134         https://bugs.webkit.org/show_bug.cgi?id=59056
3135
3136         Test: http/tests/security/mixedContent/insecure-css-in-iframe.html
3137         Test: http/tests/security/mixedContent/insecure-css-in-main-frame.html
3138
3139         * loader/cache/CachedResourceLoader.cpp:
3140         (WebCore::CachedResourceLoader::canRequest): CSS loads are running rather than displaying content.
3141
3142 2011-04-22  Geoffrey Garen  <ggaren@apple.com>
3143
3144         Fixed an upside-down conditional in my last check-in.
3145
3146         * bindings/js/JSDOMApplicationCacheCustom.cpp:
3147         (WebCore::isObservable):
3148
3149 2011-04-22  Geoffrey Garen  <ggaren@apple.com>
3150         
3151         Rolled back in r84725 and r84728 with appcache crash fixed.
3152
3153         Reviewed by Oliver Hunt.
3154
3155         Removed a use of markDOMObjectWrapper: DOMWindow
3156         https://bugs.webkit.org/show_bug.cgi?id=59260
3157
3158         * bindings/js/JSDOMWindowCustom.cpp:
3159         (WebCore::JSDOMWindow::visitChildren): No need to mark explicitly, since
3160         we use the opaque roots system now.
3161
3162         * bindings/js/JSNavigatorCustom.cpp: Ditto.
3163
3164         * bindings/scripts/CodeGeneratorJS.pm: Added autogeneration for objects
3165         whose opaque roots are frames.
3166
3167         * css/StyleMedia.h:
3168         (WebCore::StyleMedia::frame): Added an accessor for the sake of GC.
3169
3170         * css/StyleMedia.idl:
3171         * loader/appcache/DOMApplicationCache.idl:
3172         * page/BarInfo.idl:
3173         * page/Console.idl:
3174         * page/DOMSelection.idl:
3175         * page/Geolocation.idl:
3176         * page/History.idl:
3177         * page/Location.idl:
3178         * page/Navigator.idl:
3179         * page/Screen.idl:
3180         * storage/Storage.idl: Updated to use the opaque roots system.
3181
3182 2011-04-22  Nate Chapin  <japhet@chromium.org>
3183
3184         Reviewed by Adam Barth.
3185
3186         Don't use XMLTreeViewer when script is disabled (it uses Javascript
3187         to build a prettified version of the xml document).
3188         https://bugs.webkit.org/show_bug.cgi?id=59113
3189
3190         * xml/XMLTreeViewer.cpp:
3191         (WebCore::XMLTreeViewer::transformDocumentToTreeView):
3192
3193 2011-04-22  Sheriff Bot  <webkit.review.bot@gmail.com>
3194
3195         Unreviewed, rolling out r84725 and r84728.
3196         http://trac.webkit.org/changeset/84725
3197         http://trac.webkit.org/changeset/84728
3198         https://bugs.webkit.org/show_bug.cgi?id=59270
3199
3200         It broke http/tests/appcache tests (Requested by Ossy on
3201         #webkit).
3202
3203         * bindings/js/JSDOMWindowCustom.cpp:
3204         (WebCore::JSDOMWindow::visitChildren):
3205         * bindings/js/JSNavigatorCustom.cpp:
3206         (WebCore::JSNavigator::visitChildren):
3207         * bindings/scripts/CodeGeneratorJS.pm:
3208         * css/StyleMedia.h:
3209         * css/StyleMedia.idl:
3210         * loader/appcache/DOMApplicationCache.idl:
3211         * page/BarInfo.idl:
3212         * page/Console.idl:
3213         * page/DOMSelection.idl:
3214         * page/DOMWindow.h:
3215         (WebCore::DOMWindow::optionalScreen):
3216         (WebCore::DOMWindow::optionalSelection):
3217         (WebCore::DOMWindow::optionalHistory):
3218         (WebCore::DOMWindow::optionalCrypto):
3219         (WebCore::DOMWindow::optionalLocationbar):
3220         (WebCore::DOMWindow::optionalMenubar):
3221         (WebCore::DOMWindow::optionalPersonalbar):
3222         (WebCore::DOMWindow::optionalScrollbars):
3223         (WebCore::DOMWindow::optionalStatusbar):
3224         (WebCore::DOMWindow::optionalToolbar):
3225         (WebCore::DOMWindow::optionalConsole):
3226         (WebCore::DOMWindow::optionalNavigator):
3227         (WebCore::DOMWindow::optionalLocation):
3228         (WebCore::DOMWindow::optionalMedia):
3229         (WebCore::DOMWindow::optionalSessionStorage):
3230         (WebCore::DOMWindow::optionalLocalStorage):
3231         (WebCore::DOMWindow::optionalPerformance):
3232         * page/Geolocation.idl:
3233         * page/History.idl:
3234         * page/Location.idl:
3235         * page/Navigator.h:
3236         (WebCore::Navigator::optionalGeolocation):
3237         * page/Navigator.idl:
3238         * page/Screen.idl:
3239         * storage/Storage.idl:
3240
3241 2011-04-22  Dimitri Glazkov  <dglazkov@chromium.org>
3242
3243         Reviewed by Kent Tamura.
3244
3245         Change SVG-related shadow root checks to use isSVGShadowRoot.
3246         https://bugs.webkit.org/show_bug.cgi?id=59237
3247
3248         Covered by existing tests, no behavior change.
3249
3250         * css/CSSStyleSelector.cpp:
3251         (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): Use isSVGShadowRoot.
3252         * svg/SVGUseElement.cpp:
3253         (WebCore::ShadowTreeUpdateBlocker::while): Ditto.
3254         * svg/animation/SVGSMILElement.cpp:
3255         (WebCore::SVGSMILElement::insertedIntoDocument): Ditto.
3256
3257 2011-04-22  Geoffrey Garen  <ggaren@apple.com>
3258
3259         Mac build fix.
3260
3261         * page/DOMWindow.h:
3262         (WebCore::DOMWindow::optionalApplicationCache): Restored this function,
3263         which is used after all.
3264
3265 2011-04-22  Geoffrey Garen  <ggaren@apple.com>
3266
3267         Mac build fix.
3268
3269         * page/DOMWindow.h:
3270         (WebCore::DOMWindow::optionalApplicationCache): Restored this function,
3271         which is used after all.
3272
3273 2011-04-22  Geoffrey Garen  <ggaren@apple.com>
3274
3275         Reviewed by Oliver Hunt.
3276
3277         Removed a use of markDOMObjectWrapper: DOMWindow
3278         https://bugs.webkit.org/show_bug.cgi?id=59260
3279
3280         * bindings/js/JSDOMWindowCustom.cpp:
3281         (WebCore::JSDOMWindow::visitChildren): No need to mark explicitly, since
3282         we use the opaque roots system now.
3283
3284         * bindings/js/JSNavigatorCustom.cpp: Ditto.
3285
3286         * bindings/scripts/CodeGeneratorJS.pm: Added autogeneration for objects
3287         whose opaque roots are frames.
3288
3289         * css/StyleMedia.h:
3290         (WebCore::StyleMedia::frame): Added an accessor for the sake of GC.
3291
3292         * css/StyleMedia.idl:
3293         * loader/appcache/DOMApplicationCache.idl:
3294         * page/BarInfo.idl:
3295         * page/Console.idl:
3296         * page/DOMSelection.idl:
3297         * page/Geolocation.idl:
3298         * page/History.idl:
3299         * page/Location.idl:
3300         * page/Navigator.idl:
3301         * page/Screen.idl:
3302         * storage/Storage.idl: Updated to use the opaque roots system.
3303
3304 2011-04-22  Xiaomei Ji  <xji@chromium.org>
3305
3306         Reviewed by Ryosuke Niwa.
3307
3308         move caret by word in visual order returns wrong result when caret itself is at word boundary.
3309         https://bugs.webkit.org/show_bug.cgi?id=58504.
3310
3311         positionBeforeNextWord should take care that the current position is after current word.
3312         positionAfterPreviousWord should take care that the current positin is before current word.
3313
3314         * editing/visible_units.cpp:
3315         (WebCore::positionBeforeNextWord):
3316         (WebCore::positionAfterPreviousWord):
3317
3318 2011-04-19  Jer Noble  <jer.noble@apple.com>
3319
3320         Reviewed by Daniel Bates.
3321
3322         Full Screen from within an <iframe> does not cause <iframe> to resize.
3323         https://bugs.webkit.org/show_bug.cgi?id=58638
3324
3325         Tests: fullscreen/full-screen-frameset.html
3326
3327         * css/CSSStyleSelector.cpp:
3328         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Add the 
3329             -webkit-full-screen pseudo class to frame elements which contain
3330             full screen elements.
3331         * css/fullscreen.css:
3332         (iframe:-webkit-full-screen): Add iframe-specific styling rules.
3333         * dom/Document.cpp:
3334         (WebCore::Document::setContainsFullScreenElementRecursively): Added.  Walk up each
3335             successive document owner element, calling setContainsFullScreenElement() if 
3336             owner is a frame element.
3337         (WebCore::Document::fullScreenIsAllowedForElement): Use the new Element::isFrameElementBase
3338             call instead of checking the element's tag name.
3339         (WebCore::Document::webkitWillEnterFullScreenForElement): Mark any containing
3340             iframes as containing a full screen element.
3341         (WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
3342         * dom/Element.h:
3343         (WebCore::Element::isFrameElementBase): Added.
3344         * html/HTMLFrameElement.h:
3345         (WebCore::HTMLFrameElement::allowFullScreen): Disable full screen from within
3346             HTMLFrameElements.
3347         * html/HTMLFrameElementBase.cpp:
3348         (WebCore::HTMLFrameElementBase::setContainsFullScreenElement): Added.
3349         * html/HTMLFrameElementBase.h:
3350         (WebCore::HTMLFrameElementBase::containsFullScreenElement): Added.
3351         (WebCore::HTMLFrameElementBase::isFrameElementBase): Added.
3352
3353 2011-04-22  Michael Saboff  <msaboff@apple.com>
3354
3355         Reviewed by Maciej Stachowiak.
3356
3357         Creating copy of ContainerNode's when inserting or removing is inefficient
3358         https://bugs.webkit.org/show_bug.cgi?id=58695
3359
3360         Eliminated node copying in willRemove() and insertedIntoDocument().
3361
3362         No new tests as this is a more efficient implementation of
3363         existing code that is covered by existing tests.
3364
3365         * dom/ContainerNode.cpp:
3366         (WebCore::ContainerNode::willRemove): Changed method to use
3367         RefPtr<> to protect against modification during removal.
3368         (WebCore::ContainerNode::insertedIntoDocument): Changed method to use
3369         RefPtr<> and two other deletion checks to protect against 
3370         modification during insertion.
3371
3372 2011-04-22  Geoffrey Garen  <ggaren@apple.com>
3373
3374         Reviewed by Sam Weinig.
3375
3376         We have an autogenerator, so use it
3377         https://bugs.webkit.org/show_bug.cgi?id=59247
3378
3379         * bindings/js/JSCSSRuleCustom.cpp:
3380         * bindings/js/JSCSSRuleListCustom.cpp:
3381         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
3382         * bindings/js/JSCSSValueCustom.cpp:
3383         * bindings/js/JSCanvasRenderingContextCustom.cpp:
3384         * bindings/js/JSDOMImplementationCustom.cpp:
3385         * bindings/js/JSDOMStringMapCustom.cpp:
3386         * bindings/js/JSHTMLCollectionCustom.cpp:
3387         * bindings/js/JSNamedNodeMapCustom.cpp:
3388         * bindings/js/JSNodeCustom.h:
3389         * bindings/js/JSNodeListCustom.cpp:
3390         * bindings/js/JSStyleSheetCustom.cpp:
3391         * bindings/js/JSStyleSheetListCustom.cpp: Removed repetitive hand-written code.
3392
3393         * bindings/scripts/CodeGeneratorJS.pm: Augmented autogenerator to do the job.
3394
3395         * css/CSSRule.idl:
3396         * css/CSSRuleList.idl:
3397         * css/CSSStyleDeclaration.idl:
3398         * css/CSSValue.idl:
3399         * css/MediaList.idl:
3400         * css/StyleSheet.idl:
3401         * css/StyleSheetList.idl:
3402         * dom/DOMImplementation.idl:
3403         * dom/DOMStringMap.idl:
3404         * dom/NamedNodeMap.idl:
3405         * dom/Node.idl:
3406         * dom/NodeList.idl:
3407         * html/DOMTokenList.idl:
3408         * html/HTMLCollection.idl:
3409         * html/canvas/CanvasRenderingContext.idl: Updated attributes to plug into
3410         the autogenerator.
3411
3412 2011-04-22  Beth Dakin  <bdakin@apple.com>
3413
3414         Reviewed by Maciej Stachowiak.
3415
3416         https://bugs.webkit.org/show_bug.cgi?id=59223
3417         REGRESSION (r82185): iframe not displayed after navigation back to cached page
3418
3419         Manual test added.
3420         * manual-tests/frame-layout-on-back.html: Added.
3421         * manual-tests/resources/empty-document-goes-back.html: Added.
3422         * manual-tests/resources/simple-iframe.html: Added.
3423
3424 2011-04-22  Yael Aharon  <yael.aharon@nokia.com>
3425
3426         Reviewed by Sam Weinig.
3427
3428         HTMLFormControlElement::labels should allow custom attributes.
3429         https://bugs.webkit.org/show_bug.cgi?id=59128
3430
3431         Cache the labels list when it is created and keep using it for future
3432         labels calls.
3433
3434         Test: fast/forms/labels-custom-property.html
3435
3436         * html/HTMLFormControlElement.cpp:
3437         (WebCore::HTMLFormControlElement::labels):
3438
3439 2011-04-22  Adrienne Walker  <enne@google.com>
3440
3441         Reviewed by James Robinson.
3442
3443         [chromium] Remove minimum texture size for compositor tiling
3444         https://bugs.webkit.org/show_bug.cgi?id=59236
3445
3446         This was mistakenly committed in r83915 and causes bad filtering
3447         on very small textures.
3448
3449         Tests: compositing/images/content-image-change.html
3450
3451         * platform/graphics/chromium/LayerTilerChromium.cpp:
3452         (WebCore::LayerTilerChromium::setTileSize):
3453
3454 2011-04-22  Beth Dakin  <bdakin@apple.com>
3455
3456         Reviewed by Maciej Stachowiak.
3457
3458         https://bugs.webkit.org/show_bug.cgi?id=59223
3459         REGRESSION (r82185): iframe not displayed after navigation back to cached page
3460         -and corresponding-
3461         <rdar://problem/9323763>
3462
3463         Cache the scroll position in Document::setInPageCache() instead of 
3464         FrameView::resetScrollbarsAndClearContentsSize(), and only clear the contents size 
3465         for the mainFrame(). Still resetScrollbars() for other frames, which matches pre-
3466         r82185 code.
3467         * dom/Document.cpp:
3468         (WebCore::Document::setInPageCache):
3469         * page/FrameView.cpp:
3470         (WebCore::FrameView::resetScrollbarsAndClearContentsSize):
3471
3472 2011-04-22  Joseph Pecoraro  <joepeck@webkit.org>
3473
3474         Reviewed by Kent Tamura.
3475
3476         Let the RenderTheme decide if an input type should have a spinner
3477         https://bugs.webkit.org/show_bug.cgi?id=59246
3478
3479         Whether an input should have a spinner or not should
3480         be a UI decision made by the RenderTheme. Remove
3481         WebCore's default hasSpinButton values and defer
3482         to the RenderTheme.
3483
3484         No change in functionality, covered by existing tests.
3485
3486         * html/HTMLInputElement.cpp:
3487         (WebCore::HTMLInputElement::isRangeControl): expose isRangeControl
3488         for possible RenderTheme queries.
3489         * html/HTMLInputElement.h:
3490
3491         * rendering/RenderTextControlSingleLine.cpp:
3492         (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
3493         (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
3494         For both of these ask the render theme if the input should
3495         have a spinner.
3496
3497         * rendering/RenderTheme.cpp:
3498         (WebCore::RenderTheme::shouldHaveSpinButtonForInputElement):
3499         Steppable inputs (number, date, and range) but not range
3500         should have spinners. This does not change existing behavior.
3501         * rendering/RenderTheme.h:
3502
3503         * dom/InputElement.h:
3504         * html/BaseDateAndTimeInputType.cpp: remove hasSpinButton.
3505         * html/BaseDateAndTimeInputType.h: remove hasSpinButton.
3506         * html/InputType.cpp: remove hasSpinButton.
3507         * html/InputType.h: remove hasSpinButton.
3508         * html/NumberInputType.cpp: remove hasSpinButton.
3509         * html/NumberInputType.h: remove hasSpinButton.
3510
3511 2011-04-22  Joseph Pecoraro  <joepeck@webkit.org>
3512
3513         Reviewed by Kent Tamura.
3514
3515         Don't rely on hasSpinButton to check if an input type can be stepped
3516         https://bugs.webkit.org/show_bug.cgi?id=59224
3517
3518         Add isSteppable to know for certain if an input type can
3519         be stepped or not. Previously we were checking if the input
3520         has a spin control or is the range input type. These are UI
3521         details, but the step functionality does not require there
3522         to be a UI.
3523
3524         No change in behavior, covered by existing tests.
3525
3526         * html/BaseDateAndTimeInputType.cpp:
3527 &nb