39fe0314baef92c8957e6d2e98247d08fd96f24b
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-04-28  Beth Dakin  <bdakin@apple.com>
2
3         Rubber-stamped by Sam Weinig.
4
5         Rolling out revision 85258! I want to fix that bug a different way.
6         * platform/mac/ScrollbarThemeMac.mm:
7         (WebCore::ScrollbarThemeMac::paint):
8
9 2011-04-28  Chang Shu  <cshu@webkit.org>
10
11         Reviewed by Eric Seidel.
12
13         isContentEditable is not working properly with document.designMode
14         https://bugs.webkit.org/show_bug.cgi?id=53031
15
16         The specification (http://dev.w3.org/html5/spec/Overview.html#attr-contenteditable)
17         indicates that the element.isContentEditable relies on document.designMode if its
18         and its ancestors' contenteditable attributes are set to inherit.
19
20         1. Sync document render style after document.designMode is changed.
21         2. Removed the code that does unnecessary and incorrect handling for contenteditable
22         attribute with "inherit" value.
23         3. Ryosuke Niwa also helped to fix the code in ApplyStyleCommand that causes an assertion.
24
25         Tests: fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe.html
26                fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html
27                fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor.html
28                fast/dom/HTMLElement/iscontenteditable-designmodeon.html
29
30         * css/CSSStyleSelector.cpp:
31         (WebCore::CSSStyleSelector::styleForDocument):
32         * dom/Document.cpp:
33         (WebCore::Document::setDesignMode):
34         * dom/Node.cpp:
35         (WebCore::Node::rendererIsEditable):
36         * editing/ApplyStyleCommand.cpp:
37         (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
38         * html/HTMLElement.cpp:
39         (WebCore::HTMLElement::setContentEditable):
40
41 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
42
43         Unreviewed, rolling out r85101.
44         http://trac.webkit.org/changeset/85101
45         https://bugs.webkit.org/show_bug.cgi?id=59757
46
47          it'd be better to rollout the patch and do another one with
48         another property name. Current one will bring us to a problem
49         at first run after upgrade because it's type was changed from
50         int to string. (Requested by loislo on #webkit).
51
52         * inspector/front-end/ScriptsPanel.js:
53         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
54         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
55         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
56
57 2011-04-28  Mike Reed  <reed@google.com>
58
59         Reviewed by Eric Seidel.
60
61         fix shadw behavior for both CSS and Canvas -- skia only
62         https://bugs.webkit.org/show_bug.cgi?id=59700
63
64         Test:
65         canvas/philip/tests/2d.shadow.alpha.3.html
66         canvas/philip/tests/2d.shadow.alpha.4.html
67         canvas/philip/tests/2d.shadow.alpha.5.html
68         fast/canvas/canvas-fillPath-alpha-shadow.html
69         fast/canvas/canvas-strokePath-alpha-shadow.html
70         fast/canvas/canvas-strokeRect-alpha-shadow.html
71         fast/css/text-input-with-webkit-border-radius.html
72         fast/repaint/shadow-multiple-horizontal.html
73         fast/repaint/shadow-multiple-strict-horizontal.html
74         fast/repaint/shadow-multiple-strict-vertical.html
75         fast/repaint/shadow-multiple-vertical.html
76         fast/canvas/canvas-getImageData.html
77
78         * platform/graphics/chromium/FontChromiumWin.cpp:
79         (WebCore::Font::drawGlyphs):
80         * platform/graphics/skia/GraphicsContextSkia.cpp:
81         (WebCore::GraphicsContext::setPlatformShadow):
82
83 2011-04-28  David Kilzer  <ddkilzer@apple.com>
84
85         <http://webkit.org/b/59755> AXObjectCache::attachWrapper() over-retains an AccessibilityObjectWrapper
86
87         Reviewed by Chris Fleizach.
88
89         Previously, AXObjectCache::attachWrapper over-retained each
90         AccessibilityObjectWrapper it created, which is why
91         AXObjectCache::detachWrapper() contained an extra -release.
92
93         * accessibility/mac/AXObjectCacheMac.mm:
94         (WebCore::AXObjectCache::detachWrapper): Removed extra -release.
95         (WebCore::AXObjectCache::attachWrapper): Because setWrapper()
96         assigns to a RetainPtr<> instance variable, it doesn't need a +1
97         retained object passed in.  Fix the leak by using a RetainPtr<>
98         for the AccessibilityObjectWrapper.
99
100 2011-04-28  Nat Duca  <nduca@chromium.org>
101
102         Reviewed by Darin Fisher.
103
104         [chromium] Compute compositor fps value and history using the frameBegin timestamp
105         https://bugs.webkit.org/show_bug.cgi?id=59668
106
107         This change switches the compositor FPS meter to use the timestamp
108         of the beginning of the frame rather than the time we call
109         swapBuffers. When scheduling is correctly tied to vsync, we can
110         have highly variable times when we finish vsync and still have
111         stable frame rates.
112
113         * platform/graphics/chromium/LayerRendererChromium.cpp:
114         (WebCore::LayerRendererChromium::updateAndDrawLayers):
115         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
116         (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
117         (WebCore::CCHeadsUpDisplay::drawFPSCounter):
118         (WebCore::CCHeadsUpDisplay::onFrameBegin):
119         (WebCore::CCHeadsUpDisplay::onPresent):
120         * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
121
122 2011-04-28  Beth Dakin  <bdakin@apple.com>
123
124         Reviewed by Darin Adler.
125
126         https://bugs.webkit.org/show_bug.cgi?id=59759
127         Overflow:scroll regions with overlay scrollbars show full thumb instead of just a 
128         track when there is nothing to scroll to
129         <rdar://problem/9282066>
130
131         Scrollbar::totalSize() and Scrollbar::visibleSize() are the same when there is 
132         nothing to scroll to. Just dividing them to get a knob proportion yields 1, which 
133         is not right. Set the proportion to 0 in this case instead.
134         * platform/mac/ScrollbarThemeMac.mm:
135         (WebCore::ScrollbarThemeMac::paint):
136
137 2011-04-28  Dan Bernstein  <mitz@apple.com>
138
139         Reviewed by Simon Fraser.
140
141         <rdar://problem/9291132> Add support for -epub-prefixed properties
142
143         Test: fast/css/epub-properties.html
144
145         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
146         (WebCore::cssPropertyName): Map "epub"-prefixed properties to "-epub"-prefixed ones.
147         * css/CSSPropertyNames.in: Added -epub- aliases to caption-side, -webkit-hyphens, -webkit-text-combine,
148         -webkit-text-emphasis, -webkit-text-emphasis-color, -webkit-text-emphasis-style, -webkit-text-orientation,
149         text-transform, text-transform, word-break, and -webkit-writing-mode.
150
151 2011-04-28  Adam Barth  <abarth@webkit.org>
152
153         Reviewed by Eric Seidel.
154
155         Remove WML
156         https://bugs.webkit.org/show_bug.cgi?id=59678
157
158         This patch removes WML from WebCore.  After removing WML, there's a
159         bunch of twisted code that could be untwisted, but this patch contains
160         only the purely mechanical part of removing the feature.
161
162         There's been a lot of discussion on webkit-dev about whether we should
163         remove WML.  In addition to those threads, we've had an informal poll
164         of the reviewers as well as an in-person discussion at the WebKit
165         contributor's meeting.  Removing any feature is likely to make some
166         folks unhappy, but, on balance, removing WML appears to be the right
167         thing for the project to do at this time.
168
169         * CMakeLists.txt:
170         * CodeGenerators.pri:
171         * Configurations/FeatureDefines.xcconfig:
172         * DerivedSources.cpp:
173         * DerivedSources.make:
174         * GNUmakefile.am:
175         * GNUmakefile.list.am:
176         * WebCore.gyp/WebCore.gyp:
177         * WebCore.gypi:
178         * WebCore.pro:
179         * WebCore.vcproj/WebCore.vcproj:
180         * WebCore.xcodeproj/project.pbxproj:
181         * css/CSSStyleSelector.cpp:
182         (WebCore::linkAttribute):
183         (WebCore::CSSStyleSelector::styleForElement):
184         (WebCore::CSSStyleSelector::adjustRenderStyle):
185         * css/wml.css: Removed.
186         * dom/DOMImplementation.cpp:
187         (WebCore::DOMImplementation::createDocument):
188         * dom/Document.cpp:
189         (WebCore::Document::Document):
190         (WebCore::Document::createElement):
191         * dom/Document.h:
192         (WebCore::Document::isMediaDocument):
193         * dom/Document.idl:
194         * dom/InputElement.h:
195         * dom/Node.cpp:
196         (WebCore::Node::toInputElement):
197         * dom/Node.h:
198         * dom/OptionElement.cpp:
199         (WebCore::toOptionElement):
200         (WebCore::isOptionElement):
201         * dom/OptionElement.h:
202         * dom/OptionGroupElement.cpp:
203         (WebCore::toOptionGroupElement):
204         (WebCore::isOptionGroupElement):
205         * dom/SelectElement.cpp:
206         (WebCore::toSelectElement):
207         * dom/SelectElement.h:
208         * dom/Text.cpp:
209         (WebCore::Text::attach):
210         * dom/XMLDocumentParser.cpp:
211         (WebCore::XMLDocumentParser::insertErrorMessageBlock):
212         * dom/XMLDocumentParser.h:
213         * dom/XMLDocumentParserLibxml2.cpp:
214         (WebCore::XMLDocumentParser::internalSubset):
215         (WebCore::getEntityHandler):
216         * dom/XMLDocumentParserQt.cpp:
217         (WebCore::XMLDocumentParser::parse):
218         (WebCore::XMLDocumentParser::parseDtd):
219         * editing/htmlediting.cpp:
220         (WebCore::canHaveChildrenForEditing):
221         * features.pri:
222         * history/BackForwardList.h:
223         * history/BackForwardListImpl.cpp:
224         * history/BackForwardListImpl.h:
225         * history/PageCache.cpp:
226         (WebCore::PageCache::canCachePageContainingThisFrame):
227         * html/HTMLAnchorElement.h:
228         * inspector/ConsoleMessage.cpp:
229         (WebCore::messageSourceValue):
230         * inspector/front-end/ConsoleView.js:
231         (WebInspector.ConsoleMessage.prototype.toString):
232         * loader/FrameLoader.cpp:
233         (WebCore::isBackForwardLoadType):
234         (WebCore::FrameLoader::transitionToCommitted):
235         (WebCore::FrameLoader::shouldReload):
236         (WebCore::FrameLoader::loadDifferentDocumentItem):
237         (WebCore::FrameLoader::loadItem):
238         * loader/FrameLoaderTypes.h:
239         * loader/HistoryController.cpp:
240         (WebCore::HistoryController::restoreDocumentState):
241         * manual-tests/wml: Removed.
242         * manual-tests/wml/StartTests.wml: Removed.
243         * manual-tests/wml/a-br-element.wml: Removed.
244         * manual-tests/wml/a-element.wml: Removed.
245         * manual-tests/wml/a-img-element.wml: Removed.
246         * manual-tests/wml/access-target.wml: Removed.
247         * manual-tests/wml/anchor-br-element.wml: Removed.
248         * manual-tests/wml/anchor-element.wml: Removed.
249         * manual-tests/wml/anchor-img-element.wml: Removed.
250         * manual-tests/wml/card-newcontext-attr.wml: Removed.
251         * manual-tests/wml/card-onenterbackward.wml: Removed.
252         * manual-tests/wml/card-onenterforward.wml: Removed.
253         * manual-tests/wml/card-ontimer.wml: Removed.
254         * manual-tests/wml/deck-access-control.wml: Removed.
255         * manual-tests/wml/input-format.wml: Removed.
256         * manual-tests/wml/onevent-go.wml: Removed.
257         * manual-tests/wml/onevent-noop.wml: Removed.
258         * manual-tests/wml/onevent-prev.wml: Removed.
259         * manual-tests/wml/onevent-refresh.wml: Removed.
260         * manual-tests/wml/onevent-shadow.wml: Removed.
261         * manual-tests/wml/resources: Removed.
262         * manual-tests/wml/resources/smiley.png: Removed.
263         * manual-tests/wml/select-element.wml: Removed.
264         * manual-tests/wml/select-onpick-event-crash.wml: Removed.
265         * manual-tests/wml/select-onpick-event.wml: Removed.
266         * manual-tests/wml/setvar-element.wml: Removed.
267         * manual-tests/wml/targetdeck.wml: Removed.
268         * manual-tests/wml/task-go-in-anchor.wml: Removed.
269         * manual-tests/wml/task-prev-in-anchor.wml: Removed.
270         * manual-tests/wml/task-refresh-in-anchor.wml: Removed.
271         * manual-tests/wml/template-go.wml: Removed.
272         * manual-tests/wml/template-ontimer.wml: Removed.
273         * manual-tests/wml/timer.wml: Removed.
274         * manual-tests/wml/variable-substitution.wml: Removed.
275         * page/Console.cpp:
276         (WebCore::printMessageSourceAndLevelPrefix):
277         * page/Console.h:
278         * page/Frame.cpp:
279         (WebCore::Frame::Frame):
280         * page/Page.cpp:
281         * page/Page.h:
282         * platform/MIMETypeRegistry.cpp:
283         (WebCore::initializeSupportedNonImageMimeTypes):
284         * platform/network/FormDataBuilder.h:
285         * platform/network/mac/ResourceHandleMac.mm:
286         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
287         * platform/wince/MIMETypeRegistryWinCE.cpp:
288         (WebCore::initMIMETypeEntensionMap):
289         * rendering/HitTestResult.cpp:
290         (WebCore::HitTestResult::altDisplayString):
291         (WebCore::HitTestResult::absoluteImageURL):
292         (WebCore::HitTestResult::absoluteLinkURL):
293         (WebCore::HitTestResult::isLiveLink):
294         * rendering/RenderBox.cpp:
295         * rendering/RenderButton.cpp:
296         (WebCore::RenderButton::updateFromElement):
297         * rendering/RenderFieldset.cpp:
298         (WebCore::RenderFieldset::findLegend):
299         * rendering/RenderImage.cpp:
300         (WebCore::RenderImage::updateAltText):
301         * rendering/RenderObject.cpp:
302         (WebCore::RenderObject::isLegend):
303         (WebCore::RenderObject::offsetParent):
304         * wml: Removed.
305         * wml/WMLAElement.cpp: Removed.
306         * wml/WMLAElement.h: Removed.
307         * wml/WMLAccessElement.cpp: Removed.
308         * wml/WMLAccessElement.h: Removed.
309         * wml/WMLAnchorElement.cpp: Removed.
310         * wml/WMLAnchorElement.h: Removed.
311         * wml/WMLAttributeNames.in: Removed.
312         * wml/WMLBRElement.cpp: Removed.
313         * wml/WMLBRElement.h: Removed.
314         * wml/WMLCardElement.cpp: Removed.
315         * wml/WMLCardElement.h: Removed.
316         * wml/WMLDoElement.cpp: Removed.
317         * wml/WMLDoElement.h: Removed.
318         * wml/WMLDocument.cpp: Removed.
319         * wml/WMLDocument.h: Removed.
320         * wml/WMLElement.cpp: Removed.
321         * wml/WMLElement.h: Removed.
322         * wml/WMLErrorHandling.cpp: Removed.
323         * wml/WMLErrorHandling.h: Removed.
324         * wml/WMLEventHandlingElement.cpp: Removed.
325         * wml/WMLEventHandlingElement.h: Removed.
326         * wml/WMLFieldSetElement.cpp: Removed.
327         * wml/WMLFieldSetElement.h: Removed.
328         * wml/WMLFormControlElement.cpp: Removed.
329         * wml/WMLFormControlElement.h: Removed.
330         * wml/WMLGoElement.cpp: Removed.
331         * wml/WMLGoElement.h: Removed.
332         * wml/WMLImageElement.cpp: Removed.
333         * wml/WMLImageElement.h: Removed.
334         * wml/WMLImageLoader.cpp: Removed.
335         * wml/WMLImageLoader.h: Removed.
336         * wml/WMLInputElement.cpp: Removed.
337         * wml/WMLInputElement.h: Removed.
338         * wml/WMLInsertedLegendElement.cpp: Removed.
339         * wml/WMLInsertedLegendElement.h: Removed.
340         * wml/WMLIntrinsicEvent.cpp: Removed.
341         * wml/WMLIntrinsicEvent.h: Removed.
342         * wml/WMLIntrinsicEventHandler.cpp: Removed.
343         * wml/WMLIntrinsicEventHandler.h: Removed.
344         * wml/WMLMetaElement.cpp: Removed.
345         * wml/WMLMetaElement.h: Removed.
346         * wml/WMLNoopElement.cpp: Removed.
347         * wml/WMLNoopElement.h: Removed.
348         * wml/WMLOnEventElement.cpp: Removed.
349         * wml/WMLOnEventElement.h: Removed.
350         * wml/WMLOptGroupElement.cpp: Removed.
351         * wml/WMLOptGroupElement.h: Removed.
352         * wml/WMLOptionElement.cpp: Removed.
353         * wml/WMLOptionElement.h: Removed.
354         * wml/WMLPElement.cpp: Removed.
355         * wml/WMLPElement.h: Removed.
356         * wml/WMLPageState.cpp: Removed.
357         * wml/WMLPageState.h: Removed.
358         * wml/WMLPostfieldElement.cpp: Removed.
359         * wml/WMLPostfieldElement.h: Removed.
360         * wml/WMLPrevElement.cpp: Removed.
361         * wml/WMLPrevElement.h: Removed.
362         * wml/WMLRefreshElement.cpp: Removed.
363         * wml/WMLRefreshElement.h: Removed.
364         * wml/WMLSelectElement.cpp: Removed.
365         * wml/WMLSelectElement.h: Removed.
366         * wml/WMLSetvarElement.cpp: Removed.
367         * wml/WMLSetvarElement.h: Removed.
368         * wml/WMLTableElement.cpp: Removed.
369         * wml/WMLTableElement.h: Removed.
370         * wml/WMLTagNames.in: Removed.
371         * wml/WMLTaskElement.cpp: Removed.
372         * wml/WMLTaskElement.h: Removed.
373         * wml/WMLTemplateElement.cpp: Removed.
374         * wml/WMLTemplateElement.h: Removed.
375         * wml/WMLTimerElement.cpp: Removed.
376         * wml/WMLTimerElement.h: Removed.
377         * wml/WMLVariables.cpp: Removed.
378         * wml/WMLVariables.h: Removed.
379
380 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
381
382         Unreviewed, rolling out r85233 and r85235.
383         http://trac.webkit.org/changeset/85233
384         http://trac.webkit.org/changeset/85235
385         https://bugs.webkit.org/show_bug.cgi?id=59754
386
387         Causes issues with jsc. (Requested by dave_levin on #webkit).
388
389         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Removed.
390         * loader/icon/IconDatabase.cpp:
391         (WebCore::IconDatabase::defaultIcon):
392         (WebCore::IconDatabase::setIconDataForIconURL):
393         (WebCore::IconDatabase::getOrCreateIconRecord):
394         (WebCore::IconDatabase::readFromDatabase):
395
396 2011-04-28  Jay Civelli  <jcivelli@chromium.org>
397
398         Reviewed by Adam Barth.
399
400         Introducing a new class that allows serialization of a page back
401         to HTML/XML with all its sub-frames and also retrieves the page's
402         resources.
403         Tests: unit-tests in chromium/tests/WebPageNewSerializerTest.cpp
404         https://bugs.webkit.org/show_bug.cgi?id=58947
405
406         * Android.mk:
407         * CMakeLists.txt:
408         * GNUmakefile.list.am:
409         * WebCore.gypi:
410         * WebCore.pro:
411         * WebCore.vcproj/WebCore.vcproj:
412         * dom/Document.cpp:
413         (WebCore::Document::suggestedMIMEType):
414         * dom/Document.h:
415         * editing/MarkupAccumulator.cpp:
416         (WebCore::MarkupAccumulator::appendCustomAttributes):
417         (WebCore::MarkupAccumulator::appendElement):
418         * editing/MarkupAccumulator.h:
419         * html/parser/HTMLMetaCharsetParser.cpp:
420         (WebCore::HTMLMetaCharsetParser::processMeta):
421         (WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes):
422         * html/parser/HTMLMetaCharsetParser.h:
423         * page/PageSerializer.cpp: Added.
424         * page/PageSerializer.h: Added.
425
426 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
427
428         Reviewed by Tony Chang.
429
430         IndexedDB createIndex should fail if name arg is null
431         https://bugs.webkit.org/show_bug.cgi?id=58365
432
433         Test: storage/indexeddb/mozilla/create-index-null-name.html
434
435         * storage/IDBObjectStore.idl:
436         * storage/IDBObjectStoreBackendImpl.cpp:
437         (WebCore::IDBObjectStoreBackendImpl::createIndex):
438
439 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
440
441         Reviewed by Tony Chang.
442
443         IndexedDB put() should fail if second (key) parameter is null
444         https://bugs.webkit.org/show_bug.cgi?id=58613
445
446         If key arg is not specified, prpKey ends up as a null pointer in ::put().
447         However, if the key arg is specified but is null, prpKey ends up as a
448         valid IDBKey which has a null key type. As it happens, we need to be able
449         to detect the difference between these cases (the key arg is optional but
450         if specified must not be null).
451
452         Test: storage/indexeddb/mozilla/key-requirements-put-null-key.html
453
454         * storage/IDBObjectStoreBackendImpl.cpp:
455         (WebCore::IDBObjectStoreBackendImpl::put):
456
457 2011-04-07  David Levin  <levin@chromium.org>
458
459         Reviewed by Darin Adler.
460
461         Add asserts to RefCounted to make sure ref/deref happens on the right thread.
462         https://bugs.webkit.org/show_bug.cgi?id=31639
463
464         No new functionality exposed so no new tests. (The change is basically adding
465         more testing.)
466
467         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.
468         * loader/icon/IconDatabase.cpp:
469         (WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable.
470         (WebCore::IconDatabase::getOrCreateIconRecord): Ditto.
471         (WebCore::IconDatabase::setIconDataForIconURL): Ditto.
472         (WebCore::IconDatabase::readFromDatabase): Ditto.
473
474 2011-04-28  Kenneth Russell  <kbr@google.com>
475
476         Unreviewed build fix for Web Audio with strict OwnPtr.
477
478         * platform/audio/HRTFDatabaseLoader.cpp:
479         (WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):
480
481 2011-04-28  Dominic Cooney  <dominicc@chromium.org>
482
483         Reviewed by Geoffrey Garen.
484
485         Walk shadow hosts as well as parent nodes when finding opaque roots.
486         https://bugs.webkit.org/show_bug.cgi?id=59571
487
488         Test: fast/dom/shadow/gc-shadow.html
489
490         * bindings/js/JSDOMBinding.h:
491         (WebCore::root):
492
493 2011-04-28  Martin Robinson  <mrobinson@igalia.com>
494
495         Reviewed by Xan Lopez.
496
497         [GTK] Click counting logic should be shared between WebKit1 and WebKit2
498         https://bugs.webkit.org/show_bug.cgi?id=59715
499
500         Added a GtkClickCounter class which is just the logic from WebKit1 pushed down
501         into WebCore so that WebKit1 and WebKit2 can share the code.
502
503         No new tests. This is covered by fast/events/click-count.html.
504
505         * GNUmakefile.list.am: Added new files.
506         * platform/gtk/GtkClickCounter.cpp: Added.
507         (WebCore::GtkClickCounter::GtkClickCounter): Added.
508         (WebCore::GtkClickCounter::reset): Added.
509         (WebCore::GtkClickCounter::shouldProcessButtonEvent): Added.
510         (WebCore::getEventTime): Added.
511         (WebCore::GtkClickCounter::clickCountForGdkButtonEvent): Added.
512         * platform/gtk/GtkClickCounter.h: Added.
513
514 2011-04-28  Dan Bernstein  <mitz@apple.com>
515
516         Build fix.
517
518         * css/CSSParser.cpp:
519         (WebCore::cssPropertyID):
520
521 2011-04-28  Dan Bernstein  <mitz@apple.com>
522
523         Reviewed by Simon Fraser.
524
525         Allow specifying CSS property aliases in CSSPropertyNames.in files
526         https://bugs.webkit.org/show_bug.cgi?id=59712
527
528         * css/CSSParser.cpp:
529         (WebCore::cssPropertyID): Removed code to handle some aliases
530         * css/CSSPropertyNames.in: Added aliases no longer handled in code.
531         * css/makeprop.pl: Interpret lines of the form "alias-property-name = property-name" as
532         defining an alias, and add an appropriate entry to the gperf file.
533
534 2011-04-28  Arno Renevier  <arno@renevier.net>
535
536         Reviewed by Gustavo Noronha Silva.
537
538         [Soup] does not load css stylesheets without content-type
539         https://bugs.webkit.org/show_bug.cgi?id=59697
540
541         When sniffing content type, do not replace http Content-Type header in
542         soup message anymore, but keep sniffed content type in a separate
543         variable.
544
545         * platform/network/soup/ResourceHandleSoup.cpp:
546         (WebCore::contentSniffedCallback):
547         * platform/network/soup/ResourceResponse.h:
548         (WebCore::ResourceResponse::sniffedContentType):
549         (WebCore::ResourceResponse::setSniffedContentType):
550         * platform/network/soup/ResourceResponseSoup.cpp:
551         (WebCore::ResourceResponse::updateFromSoupMessage):
552
553 2011-04-28  Yael Aharon  <yael.aharon@nokia.com>
554
555         Reviewed by Andreas Kling.
556
557         Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
558         https://bugs.webkit.org/show_bug.cgi?id=59704
559
560         No new tests, just code cleanup.
561
562         * WebCore.pri:
563
564 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
565
566         Reviewed by Pavel Feldman.
567
568         Web Inspector: remove "Pretty print" source frame context menu item.
569         https://bugs.webkit.org/show_bug.cgi?id=59709
570
571         * inspector/front-end/DebuggerPresentationModel.js:
572         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
573         * inspector/front-end/ScriptsPanel.js:
574         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
575         * inspector/front-end/SourceFrame.js:
576         (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
577
578 2011-04-28  Satish Sampath  <satish@chromium.org>
579
580         Reviewed by Tony Gentilcore.
581
582         Speech input button layout issues with padding and border.
583         https://bugs.webkit.org/show_bug.cgi?id=59613
584
585         * rendering/RenderTextControlSingleLine.cpp:
586         (WebCore::RenderTextControlSingleLine::layout):
587         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
588         (WebCore::RenderTextControlSingleLine::forwardEvent):
589
590 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
591
592         Reviewed by Martin Robinson.
593
594         [GTK] Check whether to use native scrollbars at run time
595         https://bugs.webkit.org/show_bug.cgi?id=59694
596
597         It's currently decided at build time depending on whether webkit2
598         build is enabled or not. That makes imposible to build both
599         webkit1 and webkit2 using the same libWebCore.
600
601         * GNUmakefile.am:
602         * platform/ScrollView.cpp:
603         (WebCore::ScrollView::wheelEvent):
604         * platform/gtk/ScrollViewGtk.cpp:
605         (WebCore::ScrollView::createScrollbar):
606
607 2011-04-28  Pavel Feldman  <pfeldman@google.com>
608
609         Reviewed by Yury Semikhatsky.
610
611         Web Inspector: add status bar button for pretty print.
612         https://bugs.webkit.org/show_bug.cgi?id=59467
613
614         * WebCore.gypi:
615         * inspector/front-end/Images/prettyPrintButtonGlyph.png: Added.
616         * inspector/front-end/ScriptsPanel.js:
617         (WebInspector.ScriptsPanel):
618         (WebInspector.ScriptsPanel.prototype.get statusBarItems):
619         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
620         * inspector/front-end/WebKit.qrc:
621         * inspector/front-end/inspector.css:
622         (.scripts-toggle-pretty-print-status-bar-item .glyph):
623         (.scripts-toggle-pretty-print-status-bar-item.toggled .glyph):
624
625 2011-04-28  Pavel Feldman  <pfeldman@google.com>
626
627         Reviewed by Yury Semikhatsky.
628
629         Web Inspector: add ResourceTreeModel tests.
630         https://bugs.webkit.org/show_bug.cgi?id=59616
631
632         Tests: http/tests/inspector/resource-tree/resource-tree-document-url.html
633                http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
634                http/tests/inspector/resource-tree/resource-tree-reload.html
635
636         * inspector/front-end/ResourceTreeModel.js:
637         (WebInspector.ResourceTreeModel.prototype.frontendReused):
638         (WebInspector.ResourceTreeModel.prototype._addFrame):
639         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
640         (WebInspector.ResourceTreeModel.prototype._frameDetached):
641         (WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
642         (WebInspector.ResourceTreeModel.prototype.forAllResources):
643         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
644         (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
645         (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
646         * inspector/front-end/ResourcesPanel.js:
647         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
648         (WebInspector.ResourcesPanel.prototype._frameAdded):
649         (WebInspector.ResourcesPanel.prototype._frameDetached):
650         (WebInspector.ResourcesPanel.prototype._frameNavigated):
651         (WebInspector.FrameTreeElement):
652         (WebInspector.FrameTreeElement.prototype.frameNavigated):
653
654 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
655
656         Reviewed by Yury Semikhatsky.
657
658         WebInspector: [Chromium] Implement retaining paths following in detailed heap snapshots.
659         https://bugs.webkit.org/show_bug.cgi?id=59592
660
661         * inspector/front-end/DetailedHeapshotGridNodes.js:
662         (WebInspector.HeapSnapshotGridNode.prototype._populate):
663         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
664         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
665         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
666         * inspector/front-end/DetailedHeapshotView.js:
667         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
668         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
669         (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
670         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid.expandRoute):
671         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid):
672         (WebInspector.DetailedHeapshotView.prototype.changeView.sortingComplete):
673         (WebInspector.DetailedHeapshotView.prototype.changeView):
674         * inspector/front-end/HeapSnapshot.js:
675         (WebInspector.HeapSnapshotPathFinder.prototype.findNext):
676         (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter):
677         (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath):
678         (WebInspector.HeapSnapshotPathFinder.prototype._pathToString):
679         (WebInspector.HeapSnapshotPathFinder.prototype._pathToRoute):
680         * inspector/front-end/heapProfiler.css:
681         (div.retaining-paths-view td.path-column div:hover):
682
683 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
684
685         Reviewed by Yury Semikhatsky.
686
687         Web Inspector: [Chromium] Optimize detailed heap snapshots loading / parsing.
688         https://bugs.webkit.org/show_bug.cgi?id=59454
689
690         Test: inspector/profiler/heap-snapshot-loader.html
691
692         * inspector/front-end/HeapSnapshot.js:
693         (WebInspector.HeapSnapshotLoader):
694         (WebInspector.HeapSnapshotLoader.prototype._findBalancedCurlyBrackets):
695         (WebInspector.HeapSnapshotLoader.prototype.finishLoading):
696         (WebInspector.HeapSnapshotLoader.prototype._parseNodes):
697         (WebInspector.HeapSnapshotLoader.prototype._parseStringsArray):
698         (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
699         * inspector/front-end/HeapSnapshotProxy.js:
700         (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
701
702 2011-04-28  ojab  <ojab@ojab.ru>
703
704         Reviewed by David Levin.
705
706         Fix build with libpng-1.5.1
707         https://bugs.webkit.org/show_bug.cgi?id=59607
708
709         * platform/image-decoders/png/PNGImageDecoder.cpp:
710         (WebCore::readColorProfile):
711
712 2011-04-28  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
713
714         Reviewed by Nikolas Zimmermann.
715
716         Optimizing gaussian blur filter to ARM-neon SIMD instruction set
717         https://bugs.webkit.org/show_bug.cgi?id=59447
718
719         This patch contains two sub-routines, one for speeding up
720         alpha channel only gaussian blur (by 2.5 times) and one
721         for speeding up all channel blur (by 4 times).
722
723         The common code is also redesigned to better fit for platform
724         specific code. This means large chunks of code was moved to
725         different files, and all platform specific files are added to
726         all build systems.
727
728         * CMakeLists.txt:
729         * GNUmakefile.am:
730         * GNUmakefile.list.am:
731         * WebCore.gypi:
732         * WebCore.pro:
733         * WebCore.vcproj/WebCore.vcproj:
734         * WebCore.vcproj/WebCoreCommon.vsprops:
735         * WebCore.xcodeproj/project.pbxproj:
736         * platform/graphics/filters/FEGaussianBlur.cpp:
737         (WebCore::FEGaussianBlur::platformApplyGeneric):
738         (WebCore::FEGaussianBlur::apply):
739         * platform/graphics/filters/FEGaussianBlur.h:
740         (WebCore::FEGaussianBlur::kernelPosition):
741         (WebCore::FEGaussianBlur::platformApply):
742         * platform/graphics/filters/FELighting.cpp:
743         (WebCore::FELighting::platformApplyGeneric):
744         (WebCore::FELighting::drawLighting):
745         * platform/graphics/filters/FELighting.h:
746         (WebCore::FELighting::platformApply):
747         * platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Added.
748         (WebCore::WTF_ALIGNED):
749         (WebCore::feGaussianBlurConstantsForNeon):
750         * platform/graphics/filters/arm/FEGaussianBlurNEON.h: Added.
751         (WebCore::FEGaussianBlur::platformApplyNeon):
752         * platform/graphics/filters/arm/FELightingNEON.cpp:
753         (WebCore::WTF_ALIGNED):
754         (WebCore::FELighting::getPowerCoefficients):
755         * platform/graphics/filters/arm/FELightingNEON.h:
756         (WebCore::FELighting::platformApplyNeon):
757
758 2011-04-28  Alexander Pavlov  <apavlov@chromium.org>
759
760         Reviewed by Yury Semikhatsky.
761
762         Web Inspector: provide a hotkey for script pause
763         https://bugs.webkit.org/show_bug.cgi?id=59593
764
765         In fact, F8 works as a hotkey, but this fact was not reflected
766         in the shortcut help popup.
767
768         * English.lproj/localizedStrings.js:
769         * inspector/front-end/ScriptsPanel.js:
770         (WebInspector.ScriptsPanel.prototype._registerShortcuts):
771
772 2011-04-28  Adam Barth  <abarth@webkit.org>
773
774         Reviewed by Eric Seidel.
775
776         PluginStream should play nice with strict OwnPtr
777         https://bugs.webkit.org/show_bug.cgi?id=59675
778
779         These failures appear when enabling strict OwnPtr on Qt.
780
781         * plugins/PluginStream.cpp:
782         (WebCore::PluginStream::PluginStream):
783         (WebCore::PluginStream::didReceiveData):
784
785 2011-04-26  Alexander Pavlov  <apavlov@chromium.org>
786
787         Reviewed by Pavel Feldman.
788
789         Web Inspector: Use CachedResource to retrieve charset-decoded stylesheet text
790         https://bugs.webkit.org/show_bug.cgi?id=59326
791
792         Concrete CachedResource successors for stylesheets and scripts
793         can decode their content better than the generic approach we use.
794
795         * inspector/InspectorPageAgent.cpp:
796         (WebCore::decodeSharedBuffer):
797         (WebCore::prepareCachedResourceBuffer):
798         (WebCore::cachedResourceDecoded):
799         (WebCore::InspectorPageAgent::resourceContent):
800         (WebCore::InspectorPageAgent::resourceData):
801         * inspector/InspectorStyleSheet.cpp:
802         (WebCore::InspectorStyleSheet::originalStyleSheetText):
803
804 2011-04-28  Jon Lee  <jonlee@apple.com>
805
806         Reviewed by Simon Fraser.
807
808         REGRESSION: white overlay scrollbars on apple.com/startpage
809         https://bugs.webkit.org/show_bug.cgi?id=59540
810         <rdar://problem/9338653>
811
812         Now we look at the document background in addition to the <body> element,
813         and blend those colors in with the base background of the frame view to
814         arrive at our aggregate color. This provides a better result to determine
815         overlay scrollbar style.
816
817         * page/Frame.cpp:
818         (WebCore::Frame::getDocumentBackgroundColor): look up the colors on the html and body element, and properly composite them.
819         * platform/graphics/Color.h: a short comment to note that blend() uses the Porter-Duff source-over equation
820
821 2011-04-27  Adam Barth  <abarth@webkit.org>
822
823         Reviewed by Maciej Stachowiak.
824
825         Fix OwnPtr issues in IndexedDB
826         https://bugs.webkit.org/show_bug.cgi?id=59656
827
828         This patch is an attempt to fix the clang build.  Clang can't seem to
829         cope with OwnPtrs to classes declared in an anonymous namespace because
830         OwnPtr's copy constructor isn't defined (but would need to be defined
831         in this translation unit).
832
833         * platform/leveldb/LevelDBDatabase.cpp:
834
835 2011-04-27  Ryuan Choi  <ryuan.choi@samsung.com>
836
837         Reviewed by Antonio Gomes.
838
839         [EFL] Change cursor to LAZY_NATIVE_CURSOR
840         https://bugs.webkit.org/show_bug.cgi?id=59411
841
842         Enable LAZY_NATIVE_CURSOR on EFL build.
843
844         No test added because functionality is unchanged.
845
846         * CMakeListsEfl.txt: Add Cursor.cpp
847         * platform/Cursor.h:
848         (WebCore::Cursor::Cursor):
849         * platform/efl/CursorEfl.cpp:
850         (WebCore::Cursor::Cursor):
851         (WebCore::Cursor::~Cursor):
852         (WebCore::getCursorString):
853         (WebCore::Cursor::ensurePlatformCursor):
854         * platform/efl/WidgetEfl.cpp:
855         (WebCore::Widget::setCursor):
856
857 2011-04-27  Adam Barth  <abarth@webkit.org>
858
859         Build fix from the future.  Another trival strict OwnPtr fixes.  This
860         is the last futuristic build fix I can detect with my time traveling
861         abilities.
862
863         * platform/graphics/chromium/TransparencyWin.cpp:
864         (WebCore::TransparencyWin::initializeNewContext):
865
866 2011-04-27  Dmitry Lomov  <dslomov@google.com>
867
868         Reviewed by David Levin.
869
870         CrossThreadCopier should not have a default specialization for raw pointers
871         https://bugs.webkit.org/show_bug.cgi?id=59234
872         Removed the ablity to pass raw pointers cross-thread
873         Added and applied annotations for doing that
874
875         * fileapi/FileReader.cpp:
876         (WebCore::FileReader::readInternal):
877         (WebCore::FileReader::abort):
878         * fileapi/FileStreamProxy.cpp:
879         (WebCore::FileStreamProxy::startOnFileThread):
880         (WebCore::FileStreamProxy::stopOnFileThread):
881         (WebCore::FileStreamProxy::getSize):
882         (WebCore::FileStreamProxy::getSizeOnFileThread):
883         (WebCore::FileStreamProxy::openForRead):
884         (WebCore::FileStreamProxy::openForReadOnFileThread):
885         (WebCore::FileStreamProxy::openForWrite):
886         (WebCore::FileStreamProxy::openForWriteOnFileThread):
887         (WebCore::FileStreamProxy::close):
888         (WebCore::FileStreamProxy::read):
889         (WebCore::FileStreamProxy::readOnFileThread):
890         (WebCore::FileStreamProxy::write):
891         (WebCore::FileStreamProxy::writeOnFileThread):
892         (WebCore::FileStreamProxy::truncate):
893         (WebCore::FileStreamProxy::truncateOnFileThread):
894         * loader/WorkerThreadableLoader.cpp:
895         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
896         (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
897         (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
898         * page/GeolocationPositionCache.cpp:
899         (WebCore::GeolocationPositionCache::triggerReadFromDatabase):
900         (WebCore::GeolocationPositionCache::triggerWriteToDatabase):
901         * platform/CrossThreadCopier.h:
902         (WebCore::AllowCrossThreadAccessWrapper::AllowCrossThreadAccessWrapper):
903         (WebCore::AllowCrossThreadAccessWrapper::value):
904         (WebCore::AllowCrossThreadAccess):
905         (WebCore::AllowExtendedLifetimeWrapper::AllowExtendedLifetimeWrapper):
906         (WebCore::AllowExtendedLifetimeWrapper::value):
907         (WebCore::AllowExtendedLifetime):
908         * platform/graphics/chromium/cc/CCCompletionEvent.h:
909         * storage/IDBObjectStoreBackendImpl.cpp:
910         (WebCore::IDBObjectStoreBackendImpl::get):
911         (WebCore::IDBObjectStoreBackendImpl::put):
912         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
913         (WebCore::IDBObjectStoreBackendImpl::clear):
914         (WebCore::IDBObjectStoreBackendImpl::createIndex):
915         (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
916         (WebCore::IDBObjectStoreBackendImpl::openCursor):
917         * storage/SQLCallbackWrapper.h:
918         (WebCore::SQLCallbackWrapper::clear):
919         * websockets/WorkerThreadableWebSocketChannel.cpp:
920         (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
921         (WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
922         (WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
923         (WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
924         (WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
925         (WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
926         (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
927         (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
928         (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
929         * workers/WorkerMessagingProxy.cpp:
930         (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
931
932 2011-04-27  Adam Barth  <abarth@webkit.org>
933
934         Two build fixes from the future.  (Trivial strict OwnPtr fixes.)
935
936         * page/Frame.cpp:
937         (WebCore::Frame::setTiledBackingStoreEnabled):
938         * platform/audio/ReverbConvolver.cpp:
939         (WebCore::ReverbConvolver::ReverbConvolver):
940
941 2011-04-27  Adam Barth  <abarth@webkit.org>
942
943         Reviewed by David Levin.
944
945         Fix five strict PassOwnPtr violations in WebCore
946         https://bugs.webkit.org/show_bug.cgi?id=59640
947
948         * css/MediaList.cpp:
949         (WebCore::MediaList::deleteMedium):
950         (WebCore::MediaList::setMediaText):
951         (WebCore::MediaList::appendMedium):
952         * css/MediaQuery.h:
953         * dom/MessagePort.cpp:
954         (WebCore::MessagePort::disentanglePorts):
955         (WebCore::MessagePort::entanglePorts):
956         * inspector/InspectorStyleSheet.cpp:
957         (ParsedStyleSheet::setText):
958         * rendering/RenderTheme.cpp:
959         (WebCore::RenderTheme::adjustStyle):
960         (WebCore::RenderTheme::adjustMeterStyle):
961         * rendering/RenderThemeMac.mm:
962         (WebCore::RenderThemeMac::adjustMenuListStyle):
963         (WebCore::RenderThemeMac::adjustSliderTrackStyle):
964         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
965         (WebCore::RenderThemeMac::adjustSearchFieldStyle):
966         (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
967         (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
968         (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
969         (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
970
971 2011-04-27  Chris Fleizach  <cfleizach@apple.com>
972
973         Reviewed by Beth Dakin.
974
975         <rdar://problem/9315254> ARIA role attribute implemented incorrectly; does not support token list with fallbacks
976         https://bugs.webkit.org/show_bug.cgi?id=59648
977
978         Test: accessibility/aria-fallback-roles.html
979
980         * accessibility/AccessibilityObject.cpp:
981         (WebCore::AccessibilityObject::ariaRoleToWebCoreRole):
982
983 2011-04-27  Beth Dakin  <bdakin@apple.com>
984
985         Reviewed by Dan Bernstein.
986
987         https://bugs.webkit.org/show_bug.cgi?id=59671
988         Race condition with scrollbar animations and closing a page can cause a crash in 
989         WebCore::FrameView::setVisibleScrollerThumbRect + 15
990         -and corresponding-
991         <rdar://problem/9329253>
992
993         It is definitely possible for Page to be null here. So we should null-check it! 
994         And we should not ASSERT.
995         * page/FrameView.cpp:
996         (WebCore::FrameView::didCompleteRubberBand):
997         (WebCore::FrameView::scrollbarStyleChanged):
998         (WebCore::FrameView::setVisibleScrollerThumbRect):
999
1000 2011-04-27  Ryosuke Niwa  <rniwa@webkit.org>
1001
1002         WinCE build fix after r85143.
1003
1004         * platform/graphics/wince/FontWinCE.cpp:
1005         (WebCore::TextRunComponent::TextRunComponent):
1006
1007 2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>
1008
1009         Reviewed by Tony Chang.
1010
1011         IndexedDB object store delete should fail if key is null
1012         https://bugs.webkit.org/show_bug.cgi?id=58614
1013
1014         Test: storage/indexeddb/mozilla/key-requirements-delete-null-key.html
1015
1016         * storage/IDBObjectStoreBackendImpl.cpp:
1017         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
1018
1019 2011-04-27  Eric Seidel  <eric@webkit.org>
1020
1021         Reviewed by Ryosuke Niwa.
1022
1023         Should have an easy way to construct starting BidiStatus for a paragraph root
1024         https://bugs.webkit.org/show_bug.cgi?id=59226
1025
1026         Two places try to construct BidiStatuses for a paragraph root using copy/paste code.
1027         I've made this a constructor for BidiStatus instead.
1028
1029         As part of this effort I added a direction() accessor for TextRun and got
1030         rid of the old m_rtl bool.  This is part of the generic effort in the
1031         Bidi code to replace old bool usage with the superior TextDirection enum
1032         (this generally makes the code cleaner).
1033
1034         As part of this replacement effort I found several places which were
1035         assuming LTR (by passing rtl=false) when they probably want to use
1036         the current text direction.  I suspect that LTR vs. RTL may affect
1037         string width in the case of ligatures.  It's unclear.
1038
1039         This is almost entirely a mechanical change.
1040
1041         * html/canvas/CanvasRenderingContext2D.cpp:
1042         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1043         * platform/graphics/GraphicsContext.cpp:
1044         (WebCore::GraphicsContext::drawBidiText):
1045         * platform/graphics/TextRun.h:
1046         (WebCore::TextRun::TextRun):
1047         (WebCore::TextRun::direction):
1048         (WebCore::TextRun::rtl):
1049         (WebCore::TextRun::ltr):
1050         (WebCore::TextRun::setDirection):
1051         * platform/text/BidiResolver.h:
1052         (WebCore::BidiStatus::BidiStatus):
1053         * rendering/EllipsisBox.cpp:
1054         (WebCore::EllipsisBox::paint):
1055         (WebCore::EllipsisBox::selectionRect):
1056         (WebCore::EllipsisBox::paintSelection):
1057         * rendering/InlineTextBox.cpp:
1058         (WebCore::InlineTextBox::selectionRect):
1059         (WebCore::InlineTextBox::paint):
1060         (WebCore::InlineTextBox::paintSelection):
1061         (WebCore::InlineTextBox::paintCompositionBackground):
1062         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
1063         (WebCore::InlineTextBox::paintTextMatchMarker):
1064         (WebCore::InlineTextBox::computeRectForReplacementMarker):
1065         (WebCore::InlineTextBox::offsetForPosition):
1066         (WebCore::InlineTextBox::positionForOffset):
1067         * rendering/RenderBlockLineLayout.cpp:
1068         (WebCore::RenderBlock::determineStartPosition):
1069         * rendering/RenderFileUploadControl.cpp:
1070         (WebCore::RenderFileUploadControl::paintObject):
1071         (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
1072         * rendering/RenderListBox.cpp:
1073         (WebCore::RenderListBox::updateFromElement):
1074         (WebCore::RenderListBox::paintItemForeground):
1075         * rendering/RenderTextControl.cpp:
1076         (WebCore::RenderTextControl::getAvgCharWidth):
1077         (WebCore::RenderTextControl::paintPlaceholder):
1078         * rendering/svg/SVGInlineTextBox.cpp:
1079         (WebCore::SVGInlineTextBox::constructTextRun):
1080         * rendering/svg/SVGTextMetrics.cpp:
1081         (WebCore::constructTextRun):
1082
1083 2011-04-27  Robert Hogan  <robert@webkit.org>
1084
1085         Reviewed by Adam Barth.
1086
1087         Allow shadowing of history object
1088         https://bugs.webkit.org/show_bug.cgi?id=55965
1089
1090         Tests: http/tests/history/cross-origin-replace-history-object-child.html
1091                http/tests/history/cross-origin-replace-history-object.html
1092
1093         * page/DOMWindow.idl:
1094
1095 2011-04-27  James Robinson  <jamesr@chromium.org>
1096
1097         Reviewed by Kenneth Russell.
1098
1099         [chromium] Ensure compositing layers are up to date before entering doComposite
1100         https://bugs.webkit.org/show_bug.cgi?id=59159
1101
1102         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
1103         GraphicsLayerClient::paintContents() implementations).
1104
1105         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1106         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1107         * platform/graphics/chromium/LayerChromium.cpp:
1108         (WebCore::LayerChromium::LayerChromium):
1109         (WebCore::LayerChromium::~LayerChromium):
1110         * platform/graphics/chromium/LayerRendererChromium.cpp:
1111         (WebCore::LayerRendererChromium::updateLayers):
1112         * platform/graphics/chromium/LayerRendererChromium.h:
1113           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
1114
1115 2011-04-27  James Robinson  <jamesr@chromium.org>
1116
1117         Reviewed by Adam Barth.
1118
1119         Fix OwnPtr strict issues in chromium linux build
1120         https://bugs.webkit.org/show_bug.cgi?id=59664
1121
1122         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
1123         (WebCore::ComplexTextController::getNormalizedTextRun):
1124         * platform/graphics/skia/ImageBufferSkia.cpp:
1125         (WebCore::ImageBuffer::ImageBuffer):
1126         * platform/graphics/skia/PlatformContextSkia.cpp:
1127         (WebCore::PlatformContextSkia::PlatformContextSkia):
1128
1129 2011-04-27  Chris Rogers  <crogers@google.com>
1130
1131         Reviewed by Kenneth Russell.
1132
1133         Make sure to set sample-rate of created AudioBus in AudioBus::createBySampleRateConverting()
1134         https://bugs.webkit.org/show_bug.cgi?id=59641
1135
1136         No new tests since audio API is not yet implemented.
1137
1138         * platform/audio/AudioBus.cpp:
1139         (WebCore::AudioBus::createBySampleRateConverting):
1140         (WebCore::AudioBus::createByMixingToMono):
1141
1142 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
1143
1144         Motivated by Alexey Proskuryakov.
1145
1146         * bindings/scripts/CodeGeneratorJS.pm: Tried to make this comment more
1147         informative, since it confused Alexey and me.
1148
1149 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
1150
1151         Reviewed by Sam Weinig.
1152
1153         Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld
1154         https://bugs.webkit.org/show_bug.cgi?id=59646
1155
1156         Made the cssValueRoots map per-world, instead of a global. When we deallocate
1157         a world, we need to clear all entries in the map for that world, since
1158         the finalizers that would otherwise clear those entries don't run. The
1159         simplest way to do this is just to make the world own the map.
1160         
1161         * bindings/js/DOMWrapperWorld.h:
1162         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
1163         (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
1164         * bindings/js/JSCSSValueCustom.cpp:
1165         (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
1166         (WebCore::JSCSSValueOwner::finalize):
1167         * bindings/js/JSDOMBinding.h:
1168
1169 2011-04-27  Adam Barth  <abarth@webkit.org>
1170
1171         Reviewed by David Levin.
1172
1173         Fix OwnPtr issues in IndexedDB
1174         https://bugs.webkit.org/show_bug.cgi?id=59656
1175
1176         I didn't do an exhaustive review of this code, but I fixed the problems
1177         caught by turning on strict OwnPtr and all their antecedents.  This
1178         patch is entirely tighter bookkeeping.  There shouldn't be any actual
1179         behavior change.
1180
1181         * platform/leveldb/LevelDBDatabase.cpp:
1182         (WebCore::LevelDBDatabase::LevelDBDatabase):
1183         (WebCore::LevelDBDatabase::open):
1184         (WebCore::LevelDBDatabase::createIterator):
1185         * platform/leveldb/LevelDBDatabase.h:
1186         * platform/leveldb/LevelDBIterator.cpp:
1187         (WebCore::LevelDBIterator::LevelDBIterator):
1188         * platform/leveldb/LevelDBIterator.h:
1189         * storage/IDBLevelDBBackingStore.cpp:
1190         (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
1191         (WebCore::IDBLevelDBBackingStore::open):
1192         (WebCore::getNewDatabaseId):
1193         (WebCore::IDBLevelDBBackingStore::getObjectStores):
1194         (WebCore::getNewObjectStoreId):
1195         (WebCore::deleteRange):
1196         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
1197         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
1198         (WebCore::IDBLevelDBBackingStore::getIndexes):
1199         (WebCore::getNewIndexId):
1200         (WebCore::findGreatestKeyLessThan):
1201         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
1202         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
1203         (WebCore::findLastIndexKeyEqualTo):
1204         * storage/IDBLevelDBBackingStore.h:
1205
1206 2011-04-19  MORITA Hajime  <morrita@google.com>
1207
1208         Reviewed by Tony Chang.
1209
1210         [Refactoring] DocumentMarkerController::MarkerMapVectorPair should be replaced with a list of some class.
1211         https://bugs.webkit.org/show_bug.cgi?id=58113
1212
1213         * Introduced RenderedDocumentMarker, a subclass of DocumentMarker.
1214         * Eliminated Vector<IntRect> and move the IntRect into RenderedDocumentMarker
1215         * Now MarkerMapVectorPair is no longer used.
1216         
1217         No new tests, No behavior change.
1218
1219         * GNUmakefile.list.am:
1220         * WebCore.gypi:
1221         * WebCore.pro:
1222         * WebCore.vcproj/WebCore.vcproj:
1223         * WebCore.xcodeproj/project.pbxproj:
1224         * dom/DocumentMarker.h:
1225         * dom/DocumentMarkerController.cpp:
1226         (WebCore::DocumentMarkerController::addMarker):
1227         (WebCore::DocumentMarkerController::copyMarkers):
1228         (WebCore::DocumentMarkerController::removeMarkers):
1229         (WebCore::DocumentMarkerController::markerContainingPoint):
1230         (WebCore::DocumentMarkerController::markersForNode):
1231         (WebCore::DocumentMarkerController::renderedRectsForMarkers):
1232         (WebCore::DocumentMarkerController::removeMarkersFromList):
1233         (WebCore::DocumentMarkerController::repaintMarkers):
1234         (WebCore::DocumentMarkerController::setRenderedRectForMarker):
1235         (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
1236         (WebCore::DocumentMarkerController::shiftMarkers):
1237         (WebCore::DocumentMarkerController::setMarkersActive):
1238         (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
1239         (WebCore::DocumentMarkerController::showMarkers):
1240         * dom/DocumentMarkerController.h:
1241         * dom/RenderedDocumentMarker.h: Added.
1242         (WebCore::RenderedDocumentMarker::RenderedDocumentMarker):
1243         (WebCore::RenderedDocumentMarker::isRendered):
1244         (WebCore::RenderedDocumentMarker::contains):
1245         (WebCore::RenderedDocumentMarker::setRenderedRect):
1246         (WebCore::RenderedDocumentMarker::renderedRect):
1247         (WebCore::RenderedDocumentMarker::invalidate):
1248         (WebCore::RenderedDocumentMarker::invalidMarkerRect):
1249
1250 2011-04-27  James Robinson  <jamesr@chromium.org>
1251
1252         Unreviewed, rolling out r85112.
1253         http://trac.webkit.org/changeset/85112
1254         https://bugs.webkit.org/show_bug.cgi?id=59159
1255
1256         Broke mac compile
1257
1258         * page/FrameView.cpp:
1259         (WebCore::FrameView::updateCompositingLayers):
1260         * page/FrameView.h:
1261         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1262         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1263         * platform/graphics/chromium/LayerChromium.cpp:
1264         (WebCore::LayerChromium::LayerChromium):
1265         (WebCore::LayerChromium::~LayerChromium):
1266         * platform/graphics/chromium/LayerRendererChromium.cpp:
1267         (WebCore::LayerRendererChromium::updateLayers):
1268         * platform/graphics/chromium/LayerRendererChromium.h:
1269
1270 2011-04-27  Mark Rowe  <mrowe@apple.com>
1271
1272         Build fix.
1273
1274         * WebCore.xcodeproj/project.pbxproj: Make RenderLayerCompositor.h accessbile to WebKit and WebKit2.
1275
1276 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1277
1278         Unreviewed. Fix WinCE build. The include should be guarded inside USE(CFNETWORK).
1279
1280         * platform/network/ResourceHandleClient.h:
1281
1282 2011-04-27  James Robinson  <jamesr@chromium.org>
1283
1284         Reviewed by Kenneth Russell.
1285
1286         [chromium] Ensure compositing layers are up to date before entering doComposite
1287         https://bugs.webkit.org/show_bug.cgi?id=59159
1288
1289         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
1290         GraphicsLayerClient::paintContents() implementations).
1291
1292         * page/FrameView.cpp:
1293         (WebCore::FrameView::updateCompositingLayers):
1294             Add an optional CompositingUpdateType parameter.
1295         * page/FrameView.h:
1296         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1297         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1298         * platform/graphics/chromium/LayerChromium.cpp:
1299         (WebCore::LayerChromium::LayerChromium):
1300         (WebCore::LayerChromium::~LayerChromium):
1301         * platform/graphics/chromium/LayerRendererChromium.cpp:
1302         (WebCore::LayerRendererChromium::updateLayers):
1303         * platform/graphics/chromium/LayerRendererChromium.h:
1304           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
1305         * rendering/RenderLayer.cpp:
1306         (WebCore::RenderLayer::dirtyZOrderLists):
1307         (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
1308         * rendering/RenderLayerCompositor.cpp:
1309         (WebCore::RenderLayerCompositor::updateCompositingLayers):
1310         * rendering/RenderLayerCompositor.h:
1311           Fix a typo in CompositingUpdateType Pait->Paint
1312
1313 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1314
1315         Reviewed by Antti Koivisto.
1316
1317         Part of WebCore should use CFNetwork-based loader on Mac
1318         https://bugs.webkit.org/show_bug.cgi?id=51836
1319
1320         Add willCacheResponse method when using CFNetwork on Mac. Also put appropriate ifdefs around
1321         willCacheResponse/shouldCacheResponse.
1322
1323         * loader/EmptyClients.h:
1324         * loader/FrameLoaderClient.h:
1325         * loader/ResourceLoader.h:
1326         * loader/cf/ResourceLoaderCFNet.cpp:
1327         * loader/mac/ResourceLoaderMac.mm:
1328         (WebCore::ResourceLoader::willCacheResponse):
1329         * platform/network/ResourceHandleClient.h:
1330         (WebCore::ResourceHandleClient::willCacheResponse):
1331         (WebCore::ResourceHandleClient::shouldCacheResponse):
1332         * platform/network/cf/ResourceHandleCFNet.cpp:
1333         (WebCore::willCacheResponse):
1334
1335 2011-04-27  Ilya Tikhonovsky  <loislo@chromium.org>
1336
1337         Reviewed by Brian Weinstein.
1338
1339         Web Inspector: Stop on Exception state does not persist.
1340
1341         A wrong property name was used when we persist PauseOnExceptionState property to Local Storage.
1342         https://bugs.webkit.org/show_bug.cgi?id=59630
1343
1344         * inspector/front-end/ScriptsPanel.js:
1345         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
1346         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
1347         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
1348
1349 2011-04-27  Adrienne Walker  <enne@google.com>
1350
1351         [chromium] Unreviewed, rollout r85075 (scissor rect changes)
1352         https://bugs.webkit.org/show_bug.cgi?id=59020
1353
1354         * platform/graphics/chromium/LayerRendererChromium.cpp:
1355         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
1356
1357 2011-04-27  Darin Adler  <darin@apple.com>
1358
1359         Reviewed by David Levin.
1360
1361         Fix strict OwnPtr issues seen in about 30 more files
1362         https://bugs.webkit.org/show_bug.cgi?id=59615
1363
1364         * bindings/js/JSCallbackData.h:
1365         (WebCore::DeleteCallbackDataTask::create): Use adoptPtr.
1366         * bindings/js/JSMessageEventCustom.cpp:
1367         (WebCore::JSMessageEvent::initMessageEvent): Use adoptPtr.
1368         * css/CSSParser.cpp:
1369         (WebCore::CSSParser::updateSpecifiersWithElementName): Use OwnPtr,
1370         adoptPtr, and release.
1371         * dom/MessageEvent.cpp:
1372         (WebCore::MessageEvent::initMessageEvent): Use OwnPtr, adoptPtr,
1373         and release.
1374         * dom/MessagePortChannel.cpp:
1375         (WebCore::MessagePortChannel::EventData::create): Use adoptPtr.
1376         * dom/ScriptExecutionContext.cpp:
1377         (WebCore::ProcessMessagesSoonTask::create): Use adoptPtr.
1378         * dom/XMLDocumentParserLibxml2.cpp:
1379         (WebCore::XMLDocumentParser::doEnd): Use adoptPtr.
1380         * dom/default/PlatformMessagePortChannel.cpp:
1381         (WebCore::MessagePortChannel::create): Use adoptPtr.
1382         * html/HTMLFormControlElement.cpp:
1383         (WebCore::HTMLFormControlElement::detach): Use nullptr.
1384         * inspector/InspectorAgent.cpp:
1385         (WebCore::PostWorkerNotificationToFrontendTask::create): Use adoptPtr.
1386         * inspector/InspectorConsoleAgent.cpp:
1387         (WebCore::InspectorConsoleAgent::addMessageToConsole): Use adoptPtr.
1388         (WebCore::InspectorConsoleAgent::didReceiveResponse): Use adoptPtr.
1389         (WebCore::InspectorConsoleAgent::didFailLoading): Use adoptPtr.
1390         * inspector/InspectorController.cpp:
1391         (WebCore::InspectorController::connectFrontend): Use adoptPtr.
1392         * inspector/InspectorDOMAgent.cpp:
1393         (WebCore::InspectorDOMAgent::didInvalidateStyleAttr): Use adoptPtr.
1394         * inspector/InspectorResourceAgent.cpp:
1395         (WebCore::InspectorResourceAgent::InspectorResourceAgent): Use adoptPtr.
1396         * page/FrameActionScheduler.cpp:
1397         (WebCore::FrameActionScheduler::scheduleEvent): Use adoptPtr.
1398         * platform/graphics/ShadowBlur.cpp:
1399         (WebCore::ScratchBuffer::clearScratchBuffer): Use nullptr.
1400         * platform/graphics/ca/GraphicsLayerCA.cpp:
1401         (WebCore::GraphicsLayer::create): Use adoptPtr.
1402         (WebCore::GraphicsLayerCA::ensureCloneLayers): Use adoptPtr.
1403         (WebCore::GraphicsLayerCA::removeCloneLayers): Use nullptr.
1404         * rendering/RenderBlock.cpp:
1405         (WebCore::RenderBlock::setMaxMarginBeforeValues): Use adoptPtr.
1406         (WebCore::RenderBlock::setMaxMarginAfterValues): Use adoptPtr.
1407         (WebCore::RenderBlock::setPaginationStrut): Use adoptPtr.
1408         (WebCore::RenderBlock::setPageLogicalOffset): Use adoptPtr.
1409         * rendering/RenderLayerBacking.cpp:
1410         (WebCore::RenderLayerBacking::destroyGraphicsLayer): Use nullptr.
1411         (WebCore::RenderLayerBacking::updateClippingLayers): Use nullptr.
1412         (WebCore::RenderLayerBacking::updateForegroundLayer): Use nullptr.
1413         (WebCore::RenderLayerBacking::updateMaskLayer): Use nullptr.
1414         * rendering/RenderLayerCompositor.cpp:
1415         (WebCore::RenderLayerCompositor::updateOverflowControlsLayers): Use nullptr.
1416         (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): Use nullptr.
1417         (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): Use nullptr.
1418         * rendering/style/StyleRareNonInheritedData.cpp:
1419         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Removed
1420         explicit initializations of OwnPtr members to 0. Use adoptPtr.
1421         * workers/SharedWorkerContext.cpp:
1422         (WebCore::createConnectEvent): Use adoptPtr.
1423         * workers/Worker.cpp:
1424         (WebCore::Worker::notifyFinished): Use nullptr.
1425
1426 2011-04-27  Enrica Casucci  <enrica@apple.com>
1427
1428         Reviewed by Darin Adler.
1429
1430         REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
1431         https://bugs.webkit.org/show_bug.cgi?id=59251
1432         <rdar://problem/9327044>
1433
1434         When we are looking for wrapping elements that are presentational, we should
1435         include elements that have a non transparent background color only if they
1436         are not blocks.
1437
1438         Test: editing/pasteboard/do-not-copy-body-color.html
1439
1440         * editing/markup.cpp:
1441         (WebCore::isElementPresentational):
1442
1443 2011-04-20  Dimitri Glazkov  <dglazkov@chromium.org>
1444
1445         Reviewed by Antti Koivisto.
1446
1447         Teach sub-selector chains about shadow descendants
1448         https://bugs.webkit.org/show_bug.cgi?id=58342
1449
1450         The primary change is to the logic of parsing specifiers:
1451         1) The shadow descendant selectors (those specifiers that are unknown
1452         pseudo element selectors) are always kept at the top of the chain.
1453         2) The sub-selectors after shadow descendant selectors are stashed right
1454         behind the sub-selector, but not at the end of the chain.
1455         3) Other sub-selectors are appended at the end of the chain.
1456
1457         * css/CSSGrammar.y: Changed specifier_list collection to use new
1458             CSSParser::updateSpecifier helper.
1459         * css/CSSParser.cpp:
1460         (WebCore::CSSParser::updateSpecifiersWithElementName): Added logic to
1461             look for the last ShadowDescendant relation in the chain of selectors,
1462             because the next selector after it is the one that should get the
1463             element name.
1464         (WebCore::CSSParser::updateSpecifiers): Moved and modified the logic from
1465             CSSGrammar.y. The new logic adjusts the selector chain to allow
1466             shadow descendant selectors have sub-selectors (and have multiple shadow
1467             descendants in the chain).
1468         * css/CSSParser.h: Added decl.
1469         * css/CSSParserValues.cpp:
1470         (WebCore::CSSParserSelector::insertTagHistory): Added.
1471         (WebCore::CSSParserSelector::appendTagHistory): Aded.
1472         * css/CSSParserValues.h: Added decls.
1473         * css/CSSStyleSelector.cpp:
1474         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added
1475             shadow descendant selector match check, since now there could be many
1476             of them in the selector chain.
1477
1478 2011-04-20  Adrienne Walker  <enne@google.com>
1479
1480         Reviewed by Kenneth Russell.
1481
1482         [chromium] Fix incorrect scissor rect for layers that render into a rendersurface
1483         https://bugs.webkit.org/show_bug.cgi?id=59020
1484
1485         mapRect is the incorrect transform here.  The parent scissor rect
1486         needs to be projected into layer space instead.
1487
1488         Test: compositing/flat-with-transformed-child.html
1489
1490         * platform/graphics/chromium/LayerRendererChromium.cpp:
1491         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
1492
1493 2011-04-27  Pratik Solanki  <psolanki@apple.com>
1494
1495         Reviewed by Antti Koivisto.
1496
1497         Part of WebCore should use CFNetwork-based loader on Mac
1498         https://bugs.webkit.org/show_bug.cgi?id=51836
1499
1500         * Configurations/WebCore.xcconfig: Add location of CFNetwork.framework.
1501         * platform/mac/SoftLinking.h:
1502         * platform/network/cf/CookieJarCFNet.cpp: Soft-link in CFNetwork functions on Mac.
1503
1504 2011-04-27  Nikolas Zimmermann  <nzimmermann@rim.com>
1505
1506         Reviewed by Antti Koivisto.
1507
1508         Cleanup CSSStyleApplyProperty.cpp
1509         https://bugs.webkit.org/show_bug.cgi?id=59623
1510
1511         As first step remove ApplyPropertyColorBase, merge it with ApplyPropertyColor, there's no need for two seperated classes.
1512         Use typedefs instead of repating the function pointer declarations in a few places.
1513
1514         * css/CSSStyleApplyProperty.cpp:
1515         (WebCore::ApplyPropertyDefault::ApplyPropertyDefault):
1516         (WebCore::ApplyPropertyColor::ApplyPropertyColor):
1517         (WebCore::ApplyPropertyColor::applyInheritValue):
1518         (WebCore::ApplyPropertyColor::applyInitialValue):
1519         (WebCore::ApplyPropertyColor::applyValue):
1520         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
1521
1522 2011-04-27  Dan Bernstein  <mitz@apple.com>
1523
1524         Reviewed by Anders Carlsson.
1525
1526         <rdar://problem/9335973> REGRESSION (r84341): Buttons in the Mac App store are rendered incorrectly
1527         https://bugs.webkit.org/show_bug.cgi?id=59622
1528
1529         Test: fast/borders/border-image-trumps-radius.html
1530
1531         * rendering/RenderBox.cpp:
1532         (WebCore::RenderBox::determineBackgroundBleedAvoidance): If there is a renderable, loaded border
1533         image, then border radius is ignored, so no bleed avoidance is needed.
1534         * rendering/RenderObject.cpp:
1535         (WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Added. Moved some logic here from...
1536         (WebCore::RenderObject::mustRepaintBackgroundOrBorder): ...here.
1537         * rendering/RenderObject.h:
1538
1539 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
1540
1541         Reviewed by Xan Lopez.
1542
1543         [GTK] editing/pasteboard/copy-standalone-image.html fails
1544         https://bugs.webkit.org/show_bug.cgi?id=53645
1545
1546         When writing an image to the clipboard, also write the URL and title
1547         into the markup and URL portion. This change also abstracts a helper
1548         imageToMarkup into markup.{cpp/h} from several different locations
1549         throughout the platform layer.
1550
1551         * editing/markup.h: Added new function definition.
1552         * editing/markup.cpp:
1553         (WebCore::imageToMarkup): Add this function which turns an image URL 
1554         and element into some markup representing that image, while preserving
1555         non-src attributes.
1556         * platform/chromium/ClipboardChromium.cpp: Move the imageToMarkup helper
1557         to markup.cpp.
1558         * platform/gtk/PasteboardGtk.cpp:
1559         (WebCore::getURLForImageNode): Add this helper which gets the appropriate
1560         image URL for a variety of image tag types.
1561         (WebCore::Pasteboard::writeImage): Write the image URL and title to the
1562         markup and URL portions of the clipboard. This will ensure that images
1563         paste properly back into WebKit.
1564         * platform/win/ClipboardWin.cpp: Remove the imageToMarkup helper and the
1565         one from markup.h
1566
1567 2011-04-27  Steve Block  <steveblock@google.com>
1568
1569         Reviewed by David Levin.
1570
1571         Remove Android build system
1572         https://bugs.webkit.org/show_bug.cgi?id=48111
1573
1574         This is to avoid the maintenance burden until the Android port is
1575         fully upstreamed.
1576
1577         No new tests, build change only.
1578
1579         * Android.derived.jscbindings.mk: Removed.
1580         * Android.derived.mk: Removed.
1581         * Android.derived.v8bindings.mk: Removed.
1582         * Android.jscbindings.mk: Removed.
1583         * Android.mk: Removed.
1584         * Android.v8bindings.mk: Removed.
1585
1586 2011-04-27  Darin Adler  <darin@apple.com>
1587
1588         Reviewed by Sam Weinig.
1589
1590         Somehow about:blank gets into the icon database
1591         https://bugs.webkit.org/show_bug.cgi?id=58067
1592         rdar://problem/6751446
1593
1594         Implemented the policy Brady suggested, where only http and https URLs can
1595         be associated with and icon, guarding both on the way in to the database,
1596         and on the way out.
1597
1598         * loader/icon/IconDatabase.cpp:
1599         (WebCore::pageCanHaveIcon): Added.
1600         (WebCore::IconDatabase::synchronousIconForPageURL): Call pageCanHaveIcon
1601         instead of just checking for an empty URL.
1602         (WebCore::IconDatabase::synchronousIconURLForPageURL): Ditto.
1603         (WebCore::IconDatabase::retainIconForPageURL): Ditto.
1604         (WebCore::IconDatabase::releaseIconForPageURL): Ditto.
1605         (WebCore::IconDatabase::setIconURLForPageURL): Ditto.
1606         (WebCore::IconDatabase::getOrCreatePageURLRecord): Ditto.
1607         (WebCore::IconDatabase::importIconURLForPageURL): Broke assertion into
1608         two separate assertions and added a third.
1609         (WebCore::IconDatabase::performURLImport): Call pageCanHaveIcon.
1610
1611         * platform/KURL.cpp: Sorted includes. Moved a FIXME to the top of the file.
1612         (WebCore::isLetterMatchIgnoringCase): Renamed matchLetter to this name,
1613         overloaded it to work on both UChar and char, and added an assertion to it.
1614         Also moved this to the top of the file and made the UChar version usable
1615         in the shared code used even by Google.
1616         (WebCore::KURL::invalidate): Updated for name change.
1617         (WebCore::KURL::protocolIs): Use isLetterMatchIgnoringCase instead of
1618         toASCIILower since it's faster.
1619         (WebCore::KURL::parse): Updated for name changes.
1620         (WebCore::protocolIs):Use isLetterMatchIgnoringCase instead of toASCIILower
1621         since it's faster.
1622         (WebCore::protocolIsInHTTPFamily): Added.
1623
1624         * platform/KURL.h: Tweaked formatting. Renamed protocolInHTTPFamily
1625         to protocolIsInHTTPFamily and added a version that works on a string.
1626         Kept the old name as an inline function so we don't have to rename
1627         all the cal sites now.
1628
1629         * platform/KURLGoogle.cpp: Renamed as above.
1630         (WebCore::KURLGooglePrivate::KURLGooglePrivate): Updated for rename.
1631         (WebCore::KURLGooglePrivate::setUtf8): Ditto.
1632         (WebCore::KURLGooglePrivate::setAscii): Ditto.
1633         (WebCore::KURLGooglePrivate::initProtocolIsInHTTPFamily): Ditto.
1634         (WebCore::KURLGooglePrivate::copyTo): Ditto.
1635         (WebCore::KURL::KURL): Ditto.
1636         (WebCore::KURL::protocolIsInHTTPFamily): Ditto.
1637         (WebCore::KURL::invalidate): Ditto.
1638         * platform/KURLGooglePrivate.h: Ditto.
1639
1640         * WebCore.exp.in: Updated for above changes.
1641
1642 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
1643
1644         Reviewed by Pavel Feldman.
1645
1646         Web Inspector: browser crash on evaluation of 'throw undefined'
1647         https://bugs.webkit.org/show_bug.cgi?id=59611
1648
1649         Test: inspector/console/console-eval-throw-undefined.html
1650
1651         * inspector/InjectedScriptSource.js: use try/catch to protect from
1652         exception during conversion of another exception to string.
1653
1654 2011-04-27  Pavel Feldman  <pfeldman@google.com>
1655
1656         Reviewed by Yury Semikhatsky.
1657
1658         Web Inspector: clicking bookmarklet multiplies resources panel entries.
1659         https://bugs.webkit.org/show_bug.cgi?id=59590
1660
1661         * inspector/front-end/ResourceTreeModel.js:
1662         (WebInspector.ResourceTreeModel):
1663         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
1664         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
1665         * inspector/front-end/ResourcesPanel.js:
1666         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
1667         (WebInspector.FrameTreeElement):
1668         (WebInspector.FrameTreeElement.prototype.appendResource):
1669         * inspector/front-end/inspector.js:
1670         (WebInspector.frontendReused):
1671
1672 2011-04-27  Pavel Feldman  <pfeldman@google.com>
1673
1674         Reviewed by Yury Semikhatsky.
1675
1676         Web Inspector: opening bookmarklet disconnects DOM agent.
1677         https://bugs.webkit.org/show_bug.cgi?id=59588
1678
1679         * inspector/InspectorDOMAgent.cpp:
1680         (WebCore::InspectorDOMAgent::setDocument):
1681
1682 2011-04-27  Hans Wennborg  <hans@chromium.org>
1683
1684         Reviewed by Tony Gentilcore.
1685
1686         IndexedDB: Fix compiler warnings about uninitialized variables
1687         https://bugs.webkit.org/show_bug.cgi?id=59599
1688
1689         Build fix. No new tests.
1690
1691         * storage/IDBLevelDBBackingStore.cpp:
1692         (WebCore::getNewObjectStoreId):
1693         (WebCore::getNewIndexId):
1694
1695 2011-04-26  Hans Wennborg  <hans@chromium.org>
1696
1697         Reviewed by Tony Gentilcore.
1698
1699         IndexedDB: Move LevelDB key coding routines to separate file
1700         https://bugs.webkit.org/show_bug.cgi?id=59452
1701
1702         Move all routines concerned with encoding, decoding and comparison of
1703         LevelDB keys from IDBLevelDBBackingStore.cpp to a separate file:
1704         IDBLevelDBCoding.cpp.
1705
1706         This makes IDBLevelDBBackingStore.cpp easier to work with, and will
1707         allow for unit testing of the coding routines.
1708
1709         No new functionality, no new tests.
1710
1711         * WebCore.gypi:
1712         * storage/IDBLevelDBBackingStore.cpp:
1713         (WebCore::getInt):
1714         (WebCore::putInt):
1715         (WebCore::getString):
1716         (WebCore::putString):
1717         (WebCore::compareKeys):
1718         (WebCore::compareIndexKeys):
1719         (WebCore::Comparator::compare):
1720         (WebCore::setUpMetadata):
1721         (WebCore::IDBLevelDBBackingStore::extractIDBDatabaseMetaData):
1722         (WebCore::getNewDatabaseId):
1723         (WebCore::IDBLevelDBBackingStore::setIDBDatabaseMetaData):
1724         (WebCore::IDBLevelDBBackingStore::getObjectStores):
1725         (WebCore::getNewObjectStoreId):
1726         (WebCore::IDBLevelDBBackingStore::createObjectStore):
1727         (WebCore::IDBLevelDBBackingStore::deleteObjectStore):
1728         (WebCore::IDBLevelDBBackingStore::getObjectStoreRecord):
1729         (WebCore::getNewVersionNumber):
1730         (WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
1731         (WebCore::IDBLevelDBBackingStore::clearObjectStore):
1732         (WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
1733         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
1734         (WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
1735         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
1736         (WebCore::IDBLevelDBBackingStore::getIndexes):
1737         (WebCore::getNewIndexId):
1738         (WebCore::IDBLevelDBBackingStore::createIndex):
1739         (WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
1740         (WebCore::versionExists):
1741         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
1742         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
1743         (WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
1744         (WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
1745         (WebCore::IDBLevelDBBackingStore::openIndexCursor):
1746         * storage/IDBLevelDBCoding.cpp: Added.
1747         (WebCore::IDBLevelDBCoding::encodeByte):
1748         (WebCore::IDBLevelDBCoding::maxIDBKey):
1749         (WebCore::IDBLevelDBCoding::minIDBKey):
1750         (WebCore::IDBLevelDBCoding::encodeInt):
1751         (WebCore::IDBLevelDBCoding::decodeInt):
1752         (WebCore::IDBLevelDBCoding::encodeVarInt):
1753         (WebCore::IDBLevelDBCoding::decodeVarInt):
1754         (WebCore::IDBLevelDBCoding::encodeString):
1755         (WebCore::IDBLevelDBCoding::decodeString):
1756         (WebCore::IDBLevelDBCoding::encodeStringWithLength):
1757         (WebCore::IDBLevelDBCoding::decodeStringWithLength):
1758         (WebCore::IDBLevelDBCoding::encodeDouble):
1759         (WebCore::IDBLevelDBCoding::decodeDouble):
1760         (WebCore::IDBLevelDBCoding::encodeIDBKey):
1761         (WebCore::IDBLevelDBCoding::decodeIDBKey):
1762         (WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
1763         (WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
1764         (WebCore::IDBLevelDBCoding::compare):
1765         (WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
1766         (WebCore::IDBLevelDBCoding::KeyPrefix::decode):
1767         (WebCore::IDBLevelDBCoding::KeyPrefix::encode):
1768         (WebCore::IDBLevelDBCoding::KeyPrefix::compare):
1769         (WebCore::IDBLevelDBCoding::KeyPrefix::type):
1770         (WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
1771         (WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
1772         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::DatabaseFreeListKey):
1773         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
1774         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
1775         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::databaseId):
1776         (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare):
1777         (WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
1778         (WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
1779         (WebCore::IDBLevelDBCoding::DatabaseNameKey::compare):
1780         (WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
1781         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey):
1782         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
1783         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
1784         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::objectStoreId):
1785         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
1786         (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
1787         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::IndexMetaDataKey):
1788         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
1789         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
1790         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare):
1791         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::indexId):
1792         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::ObjectStoreFreeListKey):
1793         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
1794         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
1795         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::objectStoreId):
1796         (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare):
1797         (WebCore::IDBLevelDBCoding::IndexFreeListKey::IndexFreeListKey):
1798         (WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
1799         (WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
1800         (WebCore::IDBLevelDBCoding::IndexFreeListKey::compare):
1801         (WebCore::IDBLevelDBCoding::IndexFreeListKey::objectStoreId):
1802         (WebCore::IDBLevelDBCoding::IndexFreeListKey::indexId):
1803         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
1804         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
1805         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::compare):
1806         (WebCore::IDBLevelDBCoding::IndexNamesKey::IndexNamesKey):
1807         (WebCore::IDBLevelDBCoding::IndexNamesKey::decode):
1808         (WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
1809         (WebCore::IDBLevelDBCoding::IndexNamesKey::compare):
1810         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::decode):
1811         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
1812         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare):
1813         (WebCore::IDBLevelDBCoding::ObjectStoreDataKey::userKey):
1814         (WebCore::IDBLevelDBCoding::ExistsEntryKey::decode):
1815         (WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
1816         (WebCore::IDBLevelDBCoding::ExistsEntryKey::compare):
1817         (WebCore::IDBLevelDBCoding::ExistsEntryKey::userKey):
1818         (WebCore::IDBLevelDBCoding::IndexDataKey::IndexDataKey):
1819         (WebCore::IDBLevelDBCoding::IndexDataKey::decode):
1820         (WebCore::IDBLevelDBCoding::IndexDataKey::encode):
1821         (WebCore::IDBLevelDBCoding::IndexDataKey::encodeMaxKey):
1822         (WebCore::IDBLevelDBCoding::IndexDataKey::compare):
1823         (WebCore::IDBLevelDBCoding::IndexDataKey::databaseId):
1824         (WebCore::IDBLevelDBCoding::IndexDataKey::objectStoreId):
1825         (WebCore::IDBLevelDBCoding::IndexDataKey::indexId):
1826         (WebCore::IDBLevelDBCoding::IndexDataKey::userKey):
1827         * storage/IDBLevelDBCoding.h: Added.
1828         (WebCore::IDBLevelDBCoding::DatabaseNameKey::origin):
1829         (WebCore::IDBLevelDBCoding::DatabaseNameKey::databaseName):
1830         (WebCore::IDBLevelDBCoding::IndexMetaDataKey::metaDataType):
1831         (WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::objectStoreName):
1832         (WebCore::IDBLevelDBCoding::IndexNamesKey::indexName):
1833
1834 2011-04-27  Yury Semikhatsky  <yurys@chromium.org>
1835
1836         Reviewed by Pavel Feldman.
1837
1838         Web Inspector: expose exception details when script is paused on exception
1839         https://bugs.webkit.org/show_bug.cgi?id=59591
1840
1841         When script is paused on an exception, the exception value is added as <exception>
1842         property in the local scope and the breakpoint details message says
1843         "Paused on excepion: '<exception to strin value>'."
1844
1845         * English.lproj/localizedStrings.js:
1846         * inspector/front-end/ScopeChainSidebarPane.js:
1847         (WebInspector.ScopeChainSidebarPane.prototype.update):
1848         * inspector/front-end/ScriptsPanel.js:
1849         (WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
1850         (WebInspector.ScriptsPanel.prototype._debuggerPaused):
1851
1852 2011-04-26  Yury Semikhatsky  <yurys@chromium.org>
1853
1854         Reviewed by Pavel Feldman.
1855
1856         Web Inspector: [protocol] Paused event should expose exception value that caused it
1857         https://bugs.webkit.org/show_bug.cgi?id=58996
1858
1859         Debug.pause event now contains an optional reference to the exception
1860         object in case script execution is paused on a JavaScript exception.
1861
1862         Also JavaScript call frames are passed directly into the injected script when
1863         we need to wrap them for passing to the front-end. This change breaks cyclic
1864         dependency ScriptDebugServer->InspectorDebuggerAgent->InjectedScript->InjectedScriptHost->ScriptDebugServer
1865
1866         * bindings/js/JSInjectedScriptHostCustom.cpp:
1867         * bindings/js/ScriptDebugServer.cpp:
1868         (WebCore::ScriptDebugServer::dispatchDidPause):
1869         * bindings/js/ScriptDebugServer.h:
1870         * bindings/v8/ScriptDebugServer.cpp:
1871         (WebCore::ScriptDebugServer::breakProgram):
1872         (WebCore::ScriptDebugServer::editScriptSource):
1873         (WebCore::ScriptDebugServer::breakProgramCallback):
1874         (WebCore::ScriptDebugServer::handleV8DebugEvent):
1875         * bindings/v8/ScriptDebugServer.h:
1876         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
1877         * inspector/InjectedScript.cpp:
1878         (WebCore::InjectedScript::evaluateOnCallFrame):
1879         (WebCore::InjectedScript::wrapCallFrames):
1880         * inspector/InjectedScript.h:
1881         * inspector/InjectedScriptHost.cpp:
1882         * inspector/InjectedScriptHost.h:
1883         (WebCore::InjectedScriptHost::init):
1884         * inspector/InjectedScriptHost.idl:
1885         * inspector/InjectedScriptSource.js:
1886         (.):
1887         * inspector/Inspector.json:
1888         * inspector/InspectorAgent.cpp:
1889         (WebCore::InspectorAgent::InspectorAgent):
1890         * inspector/InspectorDebuggerAgent.cpp:
1891         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
1892         (WebCore::InspectorDebuggerAgent::currentCallFrames):
1893         (WebCore::InspectorDebuggerAgent::wrapCallFrames):
1894         (WebCore::InspectorDebuggerAgent::didPause):
1895         (WebCore::InspectorDebuggerAgent::didContinue):
1896         (WebCore::InspectorDebuggerAgent::clear):
1897         * inspector/InspectorDebuggerAgent.h:
1898         * inspector/ScriptDebugListener.h:
1899         * inspector/WorkerInspectorController.cpp:
1900         (WebCore::WorkerInspectorController::WorkerInspectorController):
1901
1902 2011-04-27  Pavel Feldman  <pfeldman@google.com>
1903
1904         Reviewed by Yury Semikhatsky.
1905
1906         Web Inspector: implement incremental CSS editing in the structure view.
1907         https://bugs.webkit.org/show_bug.cgi?id=59455
1908
1909         * inspector/front-end/StylesSidebarPane.js:
1910         (WebInspector.StylePropertyTreeElement.prototype):
1911
1912 2011-04-27  Mihai Parparita  <mihaip@chromium.org>
1913
1914         Reviewed by Eric Seidel.
1915
1916         Frame.h shouldn't include Document.h
1917         https://bugs.webkit.org/show_bug.cgi?id=59560
1918
1919         Frame can use a forward-declared Document if we move
1920         Frame::displayStringModifiedByEncoding's implementation out of the
1921         header.
1922                                 Size  #includes  Size * #includes
1923         Before: page/Frame.h:   0.746       653           487.138
1924                 dom/Document.h: 0.220      1306           287.320
1925         
1926         After:  page/Frame.h:   0.646       653           421.838
1927                 dom/Document.h: 0.220      1189           261.580
1928
1929         * WebCore.exp.in:
1930         * bindings/ScriptControllerBase.cpp:
1931         * bindings/generic/BindingSecurityBase.cpp:
1932         * bindings/v8/V8Proxy.cpp:
1933         * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
1934         * dom/CharacterData.cpp:
1935         * dom/UserTypingGestureIndicator.cpp:
1936         * editing/chromium/SelectionControllerChromium.cpp:
1937         * inspector/InspectorDOMStorageResource.cpp:
1938         * inspector/InspectorInstrumentation.h:
1939         * loader/PingLoader.cpp:
1940         * loader/SubresourceLoader.cpp:
1941         * loader/appcache/DOMApplicationCache.cpp:
1942         * loader/cache/CachedResourceRequest.cpp:
1943         * page/Frame.cpp:
1944         (WebCore::Frame::displayStringModifiedByEncoding):
1945         * page/Frame.h:
1946         * page/Geolocation.cpp:
1947         * page/Location.cpp:
1948         * page/Navigator.cpp:
1949         * page/PageGroupLoadDeferrer.cpp:
1950         * page/PerformanceTiming.cpp:
1951         * xml/XSLTProcessorLibxslt.cpp:
1952
1953 2011-04-27  James Robinson  <jamesr@chromium.org>
1954
1955         Reviewed by Eric Seidel.
1956
1957         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
1958         https://bugs.webkit.org/show_bug.cgi?id=59377
1959
1960         This cleans up some strict OwnPtr<> violations around text and box shadow data.  ShadowData's linked list data
1961         structure now uses OwnPtr<>s to manage memory - each entry in the list has ownership of the next ShadowData.
1962
1963         * css/CSSStyleSelector.cpp:
1964         (WebCore::CSSStyleSelector::applyProperty):
1965         * page/animation/AnimationBase.cpp:
1966         (WebCore::blendFunc):
1967         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
1968         (WebCore::PropertyWrapperShadow::blend):
1969         * rendering/style/RenderStyle.cpp:
1970         (WebCore::RenderStyle::setTextShadow):
1971         (WebCore::RenderStyle::setBoxShadow):
1972         * rendering/style/RenderStyle.h:
1973         (WebCore::InheritedFlags::textShadow):
1974         * rendering/style/ShadowData.cpp:
1975         (WebCore::ShadowData::ShadowData):
1976         * rendering/style/ShadowData.h:
1977         (WebCore::ShadowData::ShadowData):
1978         (WebCore::ShadowData::next):
1979         (WebCore::ShadowData::setNext):
1980         * rendering/style/StyleRareInheritedData.cpp:
1981         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
1982         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
1983         * rendering/style/StyleRareInheritedData.h:
1984         * rendering/style/StyleRareNonInheritedData.cpp:
1985         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
1986
1987 2011-04-26  David Levin  <levin@chromium.org>
1988
1989         Reviewed by Eric Seidel.
1990
1991         Fix some strict PassOwnPtr issues in WebCore.
1992         https://bugs.webkit.org/show_bug.cgi?id=59563
1993
1994         * css/SVGCSSStyleSelector.cpp:
1995         (WebCore::CSSStyleSelector::applySVGProperty):
1996         * html/canvas/WebGLRenderingContext.cpp:
1997         (WebCore::WebGLRenderingContext::create):
1998         (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
1999         * platform/text/TextCodecLatin1.cpp:
2000         (WebCore::newStreamingTextDecoderWindowsLatin1):
2001         * platform/text/TextCodecUTF16.cpp:
2002         (WebCore::newStreamingTextDecoderUTF16LE):
2003         (WebCore::newStreamingTextDecoderUTF16BE):
2004         * platform/text/TextCodecUserDefined.cpp:
2005         (WebCore::newStreamingTextDecoderUserDefined):
2006         * platform/text/mac/TextCodecMac.cpp:
2007         (WebCore::newTextCodecMac):
2008         * workers/Worker.cpp:
2009         (WebCore::Worker::notifyFinished):
2010
2011 2011-04-26  Justin Novosad  <junov@chromium.org>
2012
2013         Reviewed by Kenneth Russell.
2014
2015         [Chromium] Expose skia gpu canvas rendering as a runtime flag
2016         https://bugs.webkit.org/show_bug.cgi?id=58683
2017         Replace the SKIA_GPU compile flag by the pre-existing
2018         acceleratedDrawingEnabled flag. Most code changes are trivial:
2019         compile-time conditionals on SKIA_GPU were either replaced with
2020         a run-time check, or a compile time check on USE(SKIA) 
2021
2022         No new tests. Covered by existing tests.
2023
2024         * html/canvas/CanvasRenderingContext2D.cpp:
2025         (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
2026         * page/Page.cpp:
2027         (WebCore::Page::sharedGraphicsContext3D):
2028         Added check for the acceleratedDrawing flag.
2029         * platform/graphics/chromium/DrawingBufferChromium.cpp:
2030         (WebCore::DrawingBuffer::DrawingBuffer):
2031         (WebCore::DrawingBuffer::publishToPlatformLayer):
2032         * platform/graphics/gpu/DrawingBuffer.h:
2033         * platform/graphics/gpu/SharedGraphicsContext3D.cpp:
2034         (WebCore::SharedGraphicsContext3D::create):
2035         On Skia builds, this methos now receives a bool arg to turn on
2036         GPU-accelerated skia rendering
2037         (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
2038         (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D):
2039         (WebCore::SharedGraphicsContext3D::grContext):
2040         * platform/graphics/gpu/SharedGraphicsContext3D.h:
2041         * platform/graphics/skia/ImageSkia.cpp:
2042         (WebCore::computeResamplingMode):
2043         (WebCore::paintSkBitmap):
2044         (WebCore::Image::drawPattern):
2045         * platform/graphics/skia/PlatformContextSkia.cpp:
2046         (WebCore::PlatformContextSkia::PlatformContextSkia):
2047         (WebCore::PlatformContextSkia::~PlatformContextSkia):
2048         (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
2049         (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
2050         (WebCore::PlatformContextSkia::prepareForSoftwareDraw):
2051         (WebCore::PlatformContextSkia::prepareForHardwareDraw):
2052         (WebCore::PlatformContextSkia::syncSoftwareCanvas):
2053         (WebCore::PlatformContextSkia::markDirtyRect):
2054         * platform/graphics/skia/PlatformContextSkia.h:
2055         (WebCore::PlatformContextSkia::accelerationMode):
2056         (WebCore::PlatformContextSkia::useGPU):
2057         (WebCore::PlatformContextSkia::useSkiaGPU):
2058
2059 2011-04-26  Pavel Feldman  <pfeldman@chromium.org>
2060
2061         Not reviewed: restore inspector test disabled in r84913.
2062
2063         Test: http/tests/inspector-enabled/dom-storage-open.html
2064
2065         * inspector/InspectorDOMStorageAgent.cpp:
2066         (WebCore::InspectorDOMStorageAgent::clearFrontend):
2067
2068 2011-04-26  Kenichi Ishibashi  <bashi@chromium.org>
2069
2070         Reviewed by Tony Chang.
2071
2072         [Chromium] Vertical positions are off for some Arabic glyphs on Linux
2073         https://bugs.webkit.org/show_bug.cgi?id=59182
2074
2075         Use vertical offsets of the shaping results.
2076
2077         Test: platform/chromium-linux/fast/text/international/arabic-vertical-offset.html
2078
2079         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
2080         (WebCore::ComplexTextController::ComplexTextController):
2081         Added initialization of m_startingY.
2082         (WebCore::ComplexTextController::nextScriptRun):
2083         Followed the change in handling positions.
2084         (WebCore::ComplexTextController::deleteGlyphArrays): Ditto.
2085         (WebCore::ComplexTextController::createGlyphArrays): Ditto.
2086         (WebCore::ComplexTextController::resetGlyphArrays): Ditto.
2087         (WebCore::ComplexTextController::setGlyphPositions):
2088         Changed to use vertical offsets as same as horizontal offsets.
2089         * platform/graphics/chromium/ComplexTextControllerLinux.h:
2090         Removed m_xPositions and Added m_positions and m_startingY.
2091         (WebCore::ComplexTextController::positions): Added.
2092         * platform/graphics/chromium/FontLinux.cpp:
2093         Followed the change in ComplexTextController.
2094         (WebCore::Font::drawComplexText): Ditto.
2095         (WebCore::Font::floatWidthForComplexText): Ditto.
2096         (WebCore::glyphIndexForXPositionInScriptRun): Ditto.
2097         (WebCore::Font::offsetForPositionForComplexText): Ditto.
2098         (WebCore::Font::selectionRectForComplexText): Ditto.
2099
2100 2011-04-26  Levi Weintraub  <leviw@chromium.org>
2101
2102         Reviewed by Eric Seidel.
2103
2104         Root element should establish a new block formatting context
2105         https://bugs.webkit.org/show_bug.cgi?id=54573
2106
2107         Always expanding the root renderer to include overhanging floats.
2108
2109         Test: fast/block/float/float-overhangs-root.html
2110
2111         * rendering/RenderBlock.cpp:
2112         (WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
2113
2114 2011-04-26  Dawit Alemayehu  <adawit@kde.org>
2115
2116         Reviewed by Andreas Kling.
2117
2118         [Qt] Improper rendering of <button> tag when it contains a <br>
2119         https://bugs.webkit.org/show_bug.cgi?id=50521
2120
2121         Test: platform/qt/fast/forms/button-line-break.html
2122
2123         * platform/qt/RenderThemeQt.cpp:
2124         (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
2125         (WebCore::RenderThemeQt::setButtonPadding):
2126
2127 2011-04-26  James Robinson  <jamesr@chromium.org>
2128
2129         Reviewed by Kenneth Russell.
2130
2131         [chromium] Only reset tiles if the LayerRendererChromium is actually changing
2132         https://bugs.webkit.org/show_bug.cgi?id=59572
2133
2134         http://trac.webkit.org/changeset/84981/ caused us to reset the tiles
2135         when LayerRendererChromium was set.  We set this pointer every frame
2136         and should only reset the tiles if the new LayerRendererChromium is
2137         different from the old one (indicating a context loss), not just reset
2138         on every frame.
2139
2140         * platform/graphics/chromium/LayerTilerChromium.cpp:
2141         (WebCore::LayerTilerChromium::setLayerRenderer):
2142         * platform/graphics/chromium/LayerTilerChromium.h:
2143
2144 2011-04-26  Dinesh K Garg  <dineshg@codeaurora.org>
2145
2146         Reviewed by Eric Seidel.
2147
2148         beginElement broken by setAttribute
2149         https://bugs.webkit.org/show_bug.cgi?id=26019
2150
2151         Test: svg/animations/animate-beginElementAt.svg
2152
2153         * svg/SVGAnimationElement.cpp:
2154         (WebCore::SVGAnimationElement::attributeChanged):
2155         Reset the animation state here as the rest of the code reads it and would still
2156         think we are animating when we are not.
2157
2158         * svg/animation/SVGSMILElement.h:
2159         (WebCore::SVGSMILElement::setInactive): Helper function to reset the state.
2160
2161 2011-04-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2162
2163         Unreviewed, rolling out r84989.
2164         http://trac.webkit.org/changeset/84989
2165         https://bugs.webkit.org/show_bug.cgi?id=59566
2166
2167         REGRESSION (r84989): Lots of vertical text tests failing on
2168         windows (Requested by weinig on #webkit).
2169
2170         * platform/graphics/FontPlatformData.h:
2171         * platform/graphics/win/FontCacheWin.cpp:
2172         (WebCore::FontCache::getFontDataForCharacters):
2173         (WebCore::FontCache::createFontPlatformData):
2174         * platform/graphics/win/FontCustomPlatformData.cpp:
2175         (WebCore::FontCustomPlatformData::fontPlatformData):
2176         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2177         (WebCore::FontPlatformData::FontPlatformData):
2178         * platform/graphics/win/FontPlatformDataWin.cpp:
2179         (WebCore::FontPlatformData::FontPlatformData):
2180
2181 2011-04-26  Sam Weinig  <sam@webkit.org>
2182
2183         Reviewed by Eric Seidel.
2184
2185         Try again:
2186             Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
2187             https://bugs.webkit.org/show_bug.cgi?id=59310
2188
2189         * bindings/js/JSDOMBinding.h:
2190         (WebCore::DOMConstructorObject::DOMConstructorObject):
2191         * bindings/js/JSDOMWrapper.h:
2192         (WebCore::JSDOMWrapper::globalObject):
2193         (WebCore::JSDOMWrapper::scriptExecutionContext):
2194         (WebCore::JSDOMWrapper::createStructure):
2195         (WebCore::JSDOMWrapper::JSDOMWrapper):
2196         * bindings/scripts/CodeGeneratorJS.pm:
2197
2198 2011-04-26  Sam Weinig  <sam@webkit.org>
2199
2200         Reviewed by David Hyatt.
2201
2202         Remove Datagrid from the tree
2203         https://bugs.webkit.org/show_bug.cgi?id=59543
2204
2205         * Android.derived.jscbindings.mk:
2206         * Android.derived.v8bindings.mk:
2207         * Android.jscbindings.mk:
2208         * Android.v8bindings.mk:
2209         * CMakeLists.txt:
2210         * CodeGenerators.pri:
2211         * Configurations/FeatureDefines.xcconfig:
2212         * DerivedSources.cpp:
2213         * DerivedSources.make:
2214         * GNUmakefile.am:
2215         * GNUmakefile.list.am:
2216         * UseJSC.cmake:
2217         * WebCore.gypi:
2218         * WebCore.pro:
2219         * WebCore.vcproj/WebCore.vcproj:
2220         * WebCore.xcodeproj/project.pbxproj:
2221         * bindings/js/JSBindingsAllInOne.cpp:
2222         * bindings/js/JSDataGridColumnListCustom.cpp: Removed.
2223         * bindings/js/JSDataGridDataSource.cpp: Removed.
2224         * bindings/js/JSDataGridDataSource.h: Removed.
2225         * bindings/js/JSHTMLDataGridElementCustom.cpp: Removed.
2226         * bindings/v8/V8DataGridDataSource.cpp: Removed.
2227         * bindings/v8/V8DataGridDataSource.h: Removed.
2228         * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Removed.
2229         * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Removed.
2230         * css/CSSStyleSelector.cpp:
2231         * css/CSSStyleSelector.h:
2232         * css/html.css:
2233         (input, textarea, keygen, select, button, isindex):
2234         (select:disabled, keygen:disabled, optgroup:disabled, option:disabled):
2235         * editing/htmlediting.cpp:
2236         (WebCore::canHaveChildrenForEditing):
2237         * features.pri:
2238         * html/DOMDataGridDataSource.cpp: Removed.
2239         * html/DOMDataGridDataSource.h: Removed.
2240         * html/DataGridColumn.cpp: Removed.
2241         * html/DataGridColumn.h: Removed.
2242         * html/DataGridColumn.idl: Removed.
2243         * html/DataGridColumnList.cpp: Removed.
2244         * html/DataGridColumnList.h: Removed.
2245         * html/DataGridColumnList.idl: Removed.
2246         * html/DataGridDataSource.h: Removed.
2247         * html/HTMLDataGridCellElement.cpp: Removed.
2248         * html/HTMLDataGridCellElement.h: Removed.
2249         * html/HTMLDataGridCellElement.idl: Removed.
2250         * html/HTMLDataGridColElement.cpp: Removed.
2251         * html/HTMLDataGridColElement.h: Removed.
2252         * html/HTMLDataGridColElement.idl: Removed.
2253         * html/HTMLDataGridElement.cpp: Removed.
2254         * html/HTMLDataGridElement.h: Removed.
2255         * html/HTMLDataGridElement.idl: Removed.
2256         * html/HTMLDataGridRowElement.cpp: Removed.
2257         * html/HTMLDataGridRowElement.h: Removed.
2258         * html/HTMLDataGridRowElement.idl: Removed.
2259         * html/HTMLElement.cpp:
2260         (WebCore::HTMLElement::ieForbidsInsertHTML):
2261         * html/HTMLElementsAllInOne.cpp:
2262         * html/HTMLTagNames.in:
2263         * page/DOMWindow.idl:
2264         * rendering/RenderBox.cpp:
2265         (WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
2266         * rendering/RenderDataGrid.cpp: Removed.
2267         * rendering/RenderDataGrid.h: Removed.
2268         * rendering/RenderingAllInOne.cpp:
2269
2270 2011-04-26  Chun-Lung Huang  <alvincl.huang@gmail.com>
2271
2272         Reviewed by Adele Peterson.
2273
2274         On WebKit (Windows), glyphs in vertical text tests are rotated 90
2275         degrees clockwise.  https://bugs.webkit.org/show_bug.cgi?id=48459
2276
2277         This platform dependent patch makes WebKit (Windows) show the
2278         vertical writing text correctly.  Job was done by adding a prefix '@'
2279         in front of the font family name (Windows Only). No new tests added.
2280         Some layout tests images:
2281         http://www.flickr.com/photos/burorly/sets/72157625585506341/
2282
2283         * platform/graphics/FontPlatformData.h:
2284         * platform/graphics/win/FontCacheWin.cpp:
2285         (WebCore::FontCache::getFontDataForCharacters):
2286         (WebCore::FontCache::createFontPlatformData):
2287         * platform/graphics/win/FontCustomPlatformData.cpp:
2288         (WebCore::FontCustomPlatformData::fontPlatformData):
2289         * platform/graphics/win/FontPlatformDataCGWin.cpp:
2290         (WebCore::FontPlatformData::FontPlatformData):
2291         * platform/graphics/win/FontPlatformDataWin.cpp:
2292         (WebCore::FontPlatformData::FontPlatformData):
2293
2294 2011-04-26  Jer Noble  <jer.noble@apple.com>
2295
2296         Reviewed by Brady Eidson.
2297
2298         HTML5 video fullscreen transition causes an audio stutter
2299         https://bugs.webkit.org/show_bug.cgi?id=59544
2300
2301         AVFoundation will momentarily stutter when you disconnect a AVPlayerLayer 
2302         from its AVPlayer.  Since you shouldn't necessarily have to destroy the
2303         layer to render it invisible, instead just set the layer as hidden.
2304
2305         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
2306         (WebCore::MediaPlayerPrivateAVFoundation::setVisible): Call through to platformSetVisible().
2307         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
2308         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
2309         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
2310         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformSetVisible): Added.
2311
2312 2011-04-26  Christian Dywan  <christian@lanedo.com>
2313
2314         Reviewed by Eric Seidel.
2315
2316         Extra separator after Select All in context menu
2317         https://bugs.webkit.org/show_bug.cgi?id=54092
2318
2319         * page/ContextMenuController.cpp: Move separator to non-GTK+
2320             port guards since it is for the spelling options menu
2321             which the GTK+ port doesn't use.
2322
2323 2011-04-26  James Robinson  <jamesr@chromium.org>
2324
2325         Reviewed by Kenneth Russell.
2326
2327         [chromium] Clear out LayerTilerChromium's tiles on lost context
2328         https://bugs.webkit.org/show_bug.cgi?id=59233
2329
2330         Clears out the LayerTilerChromium's tile set when the LayerRendererChromium is reset.  In this case the tiles are
2331         no longer valid since they exist in the previous LayerRendererChromium.
2332
2333         Will be tested by a chrome test since we don't have any way to exercise the context lost case in layout tests.
2334
2335         * platform/graphics/chromium/LayerTilerChromium.h:
2336         (WebCore::LayerTilerChromium::setLayerRenderer):
2337
2338 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
2339
2340         Reviewed by Dirk Schulze.
2341
2342         [GTK] Flash in divs with overflow: auto is not positioned and clipped properly
2343         https://bugs.webkit.org/show_bug.cgi?id=57644
2344
2345         Manual test: plugins/windowed-in-iframe-2.html
2346
2347         * manual-tests/plugins/windowed-in-iframe-2.html: Added.
2348         * platform/gtk/WidgetGtk.cpp:
2349         (WebCore::Widget::setFrameRect): Like the Qt port, we notify the widget via frameRectsChanged.
2350         * plugins/PluginView.h: Added helper method to set the allocation and clip.
2351         * plugins/gtk/PluginViewGtk.cpp:
2352         (WebCore::PluginView::setNPWindowIfNeeded):Call the helper method instead of setting
2353         the allocation immediately. Bring this method into sync with the implementation in
2354         the Qt port.
2355         (WebCore::PluginView::updateWidgetAllocationAndClip): Added.
2356         (WebCore::PluginView::plugAddedCallback): Call the new helper method.
2357
2358 2011-04-26  Martin Robinson  <mrobinson@igalia.com>
2359
2360         Reviewed by Eric Seidel.
2361
2362         [GTK]  fast/block/float/overhanging-tall-block.html crashes in the bots
2363         https://bugs.webkit.org/show_bug.cgi?id=58818
2364
2365         Prevent allocating scratch buffers larger than the target GdkDrawable
2366         when creating a WidgetRenderingContext. This prevents incredibly large
2367         widgets from crashing the X Server. This change also allowed greatly
2368         simplifying the way that the painting offset is calculated.
2369
2370         * platform/gtk/WidgetRenderingContext.cpp:
2371         (WebCore::WidgetRenderingContext::WidgetRenderingContext): Never allocate a pixmap
2372         larger than the target GdkDrawable.
2373         (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Calculate the offset of the
2374         blit by looking at the location of the target rect itself, rather than delaying the
2375         calculation up to this point.
2376         (WebCore::WidgetRenderingContext::calculateClipRect): Added.
2377         (WebCore::WidgetRenderingContext::gtkPaintBox): Use the new calculateClipRectHelper.
2378         (WebCore::WidgetRenderingContext::gtkPaintFlatBox): Ditto.
2379         (WebCore::WidgetRenderingContext::gtkPaintFocus): Ditto.
2380         (WebCore::WidgetRenderingContext::gtkPaintSlider): Ditto.
2381         (WebCore::WidgetRenderingContext::gtkPaintCheck): Ditto.
2382         (WebCore::WidgetRenderingContext::gtkPaintOption): Ditto.
2383         (WebCore::WidgetRenderingContext::gtkPaintShadow): Ditto.
2384         (WebCore::WidgetRenderingContext::gtkPaintArrow): Ditto.
2385         (WebCore::WidgetRenderingContext::gtkPaintVLine): Ditto.
2386         * platform/gtk/WidgetRenderingContext.h: Remove some now unused members. Add
2387         a member to store the IntSize mapping from the coordinates of the target to the coordinates
2388         of the scratch buffer.
2389
2390 2011-04-26  Patrick Gansterer  <paroga@webkit.org>
2391
2392         Reviewed by Adam Barth.
2393
2394         Respect charset in handleDataURL
2395         https://bugs.webkit.org/show_bug.cgi?id=47746
2396
2397         Original patch by Kwang Yul Seo <skyul@company100.net>
2398
2399         We must use TextEncoding(charset) to encode data URL again. Otherwise TextEncoding::encode()
2400         returns an empty string because encoding name is not specified.
2401
2402         Also use "US-ASCII" as fallback charset as extractCharsetFromMediaType can be empty.
2403
2404         This change fixes over 130 layout tests when running GTK port with cURL network backend.
2405
2406         * platform/network/DataURL.cpp:
2407         (WebCore::handleDataURL):
2408
2409 2011-04-26  Anders Carlsson  <andersca@apple.com>
2410
2411         Fix clang++ build.
2412
2413         You can never have too many casts!
2414
2415         * accessibility/mac/AccessibilityObjectWrapper.mm:
2416         (-[AccessibilityObjectWrapper position]):
2417         * editing/mac/SelectionControllerMac.mm:
2418         (WebCore::accessibilityConvertScreenRect):
2419
2420 2011-04-26  Chris Rogers  <crogers@google.com>
2421
2422         Reviewed by Kenneth Russell.
2423
2424         Fix web audio build on mac port
2425         https://bugs.webkit.org/show_bug.cgi?id=59355
2426
2427         No new tests since audio API is not yet implemented.
2428
2429         * WebCore.xcodeproj/project.pbxproj:
2430         * bindings/js/JSAudioContextCustom.cpp:
2431         (WebCore::JSAudioContext::visitChildren):
2432         * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
2433         (WebCore::JSJavaScriptAudioNode::visitChildren):
2434         * webaudio/AudioContext.idl:
2435
2436 2011-04-26  Chris Rogers  <crogers@google.com>
2437
2438         Reviewed by Kenneth Russell.
2439
2440         Add FFTFrame implementation for FFmpeg
2441         https://bugs.webkit.org/show_bug.cgi?id=59408
2442
2443         No new tests since audio API is not yet implemented.
2444
2445         * WebCore.gyp/WebCore.gyp:
2446         * WebCore.gypi:
2447         * platform/audio/FFTFrame.h:
2448         * platform/audio/FFTFrameStub.cpp:
2449         * platform/audio/ffmpeg: Added.
2450         * platform/audio/ffmpeg/FFTFrameFFMPEG.cpp: Added.
2451         (WebCore::FFTFrame::FFTFrame):
2452         (WebCore::FFTFrame::initialize):
2453         (WebCore::FFTFrame::cleanup):
2454         (WebCore::FFTFrame::~FFTFrame):
2455         (WebCore::FFTFrame::multiply):
2456         (WebCore::FFTFrame::doFFT):
2457         (WebCore::FFTFrame::doInverseFFT):
2458         (WebCore::FFTFrame::realData):
2459         (WebCore::FFTFrame::imagData):
2460         (WebCore::FFTFrame::getUpToDateComplexData):
2461         (WebCore::FFTFrame::contextForSize):
2462         * platform/audio/mac/FFTFrameMac.cpp:
2463         * webaudio/ConvolverNode.cpp:
2464
2465 2011-04-26  Jeff Miller  <jeffm@apple.com>
2466
2467         Add a newline at the end of SVGFEDropShadowElement.idl.
2468
2469         * svg/SVGFEDropShadowElement.idl:
2470
2471 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
2472
2473         Reviewed by Eric Seidel.
2474
2475         InlineBox.h shouldn't include RenderBR.h
2476         https://bugs.webkit.org/show_bug.cgi?id=59480
2477
2478         Per bug 59348 RenderBR.h is a "top header" by include * size, because
2479         InlineBox.h includes it. There's no reason why it has to.
2480
2481         * rendering/InlineBox.h:
2482         * rendering/InlineTextBox.cpp:
2483         * rendering/RenderBlock.h:
2484
2485 2011-04-26  Sam Weinig  <sam@webkit.org>
2486
2487         Nope, roll out r84950 and r84952. Working on a laptop is clearly not something
2488         I should do.
2489
2490         * bindings/js/JSDOMBinding.h:
2491         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
2492         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
2493         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
2494         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
2495         (WebCore::DOMConstructorObject::DOMConstructorObject):
2496         * bindings/js/JSDOMWrapper.h:
2497         (WebCore::JSDOMWrapper::JSDOMWrapper):
2498         * bindings/scripts/CodeGeneratorJS.pm:
2499
2500 2011-04-26  Sam Weinig  <sam@webkit.org>
2501
2502         Fix build.
2503
2504         * bindings/js/JSDOMWrapper.h:
2505         (WebCore::JSDOMWrapper::globalObject):
2506
2507 2011-04-26  Sam Weinig  <sam@webkit.org>
2508
2509         Roll r84945 back in with infinite recursion removed.
2510
2511         * bindings/js/JSDOMBinding.h:
2512         (WebCore::DOMConstructorObject::DOMConstructorObject):
2513         * bindings/js/JSDOMWrapper.h:
2514         (WebCore::JSDOMWrapper::globalObject):
2515         (WebCore::JSDOMWrapper::scriptExecutionContext):
2516         (WebCore::JSDOMWrapper::createStructure):
2517         (WebCore::JSDOMWrapper::JSDOMWrapper):
2518         * bindings/scripts/CodeGeneratorJS.pm:
2519
2520 2011-04-26  Sam Weinig  <sam@webkit.org>
2521
2522         Rollout previous patch. It broke stuff.
2523
2524         * bindings/js/JSDOMBinding.h:
2525         (WebCore::JSDOMWrapperWithGlobalPointer::globalObject):
2526         (WebCore::JSDOMWrapperWithGlobalPointer::scriptExecutionContext):
2527         (WebCore::JSDOMWrapperWithGlobalPointer::createStructure):
2528         (WebCore::JSDOMWrapperWithGlobalPointer::JSDOMWrapperWithGlobalPointer):
2529         (WebCore::DOMConstructorObject::DOMConstructorObject):
2530         * bindings/js/JSDOMWrapper.h:
2531         (WebCore::JSDOMWrapper::JSDOMWrapper):
2532         * bindings/scripts/CodeGeneratorJS.pm:
2533
2534 2011-04-26  Sam Weinig  <sam@webkit.org>
2535
2536         Reviewed by Maciej Stachowiak.
2537
2538         Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects
2539         https://bugs.webkit.org/show_bug.cgi?id=59310
2540
2541         * bindings/js/JSDOMBinding.h:
2542         (WebCore::DOMConstructorObject::DOMConstructorObject):
2543         * bindings/js/JSDOMWrapper.h:
2544         (WebCore::JSDOMWrapper::globalObject):
2545         (WebCore::JSDOMWrapper::scriptExecutionContext):
2546         (WebCore::JSDOMWrapper::createStructure):
2547         (WebCore::JSDOMWrapper::JSDOMWrapper):
2548         Merge JSDOMWrapperWithGlobalPointer with JSDOMWrapper.
2549
2550         * bindings/scripts/CodeGeneratorJS.pm:
2551         Make JSDOMWrapper the base class.
2552
2553 2011-04-26  Dan Bernstein  <mitz@apple.com>
2554
2555         Reviewed by Mark Rowe.
2556
2557         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
2558
2559         * Configurations/Base.xcconfig:
2560         * Configurations/CompilerVersion.xcconfig: Added.
2561
2562 2011-04-26  Adrienne Walker  <enne@google.com>
2563
2564         Reviewed by Geoffrey Garen.
2565
2566         Use OwnArrayPtr<T> instead of OwnPtr<T*> in ScopeTracer
2567         https://bugs.webkit.org/show_bug.cgi?id=59469
2568
2569         * platform/chromium/TraceEvent.h:
2570         (WebCore::internal::ScopeTracer::ScopeTracer):
2571
2572 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
2573
2574         Reviewed by Oliver Hunt.
2575
2576         Nixed special finalizer handling for WebCore strings
2577         https://bugs.webkit.org/show_bug.cgi?id=59425
2578
2579         Not needed anymore, since weak handles have finalizers.
2580
2581         * WebCore.exp.in: Exports!
2582
2583         * bindings/js/DOMWrapperWorld.cpp:
2584         (WebCore::JSStringOwner::finalize):
2585         (WebCore::DOMWrapperWorld::DOMWrapperWorld): Use a weak handle finalizer,
2586         so we don't need special treatment anymore.
2587
2588         * bindings/js/DOMWrapperWorld.h:
2589         (WebCore::JSStringOwner::JSStringOwner):
2590         (WebCore::DOMWrapperWorld::stringWrapperOwner): Use a HashMap of Weak<T>
2591         instead of a WeakGCMap, so we can specify a custom finalizer.
2592
2593         * bindings/js/JSDOMBinding.cpp:
2594         (WebCore::jsStringSlowCase):
2595         * bindings/js/JSDOMBinding.h:
2596         (WebCore::jsString): Updated for string map change.
2597
2598 2011-04-26  David Kilzer  <ddkilzer@apple.com>
2599
2600         <http://webkit.org/b/59372> Restore user default for enabling HTTP pipelining
2601
2602         Reviewed by Antti Koivisto.
2603
2604         To enable HTTP pipelining post-SnowLeopard, use this command:
2605
2606             defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES
2607
2608         * platform/network/cf/ResourceRequestCFNet.cpp:
2609         (WebCore::readBooleanPreference): Re-added.  Originally added in
2610         r76756 and removed in r84120.
2611         (WebCore::initializeMaximumHTTPConnectionCountPerHost): Enable
2612         HTTP pipelining if use default is set to true.  Added macro
2613         guards to match those in ResourceRequestMac.mm.
2614
2615 2011-04-26  Antti Koivisto  <antti@apple.com>
2616
2617         Reviewed by Adele Peterson.
2618
2619         Don't strip fragments from file: urls in memory cache
2620         https://bugs.webkit.org/show_bug.cgi?id=59463
2621         <rdar://problem/9231130>
2622
2623         Some clients expect file: resources to be unique based on fragment identifier. 
2624         Limit the changes in http://trac.webkit.org/changeset/74107 to the HTTP protocol only
2625
2626         Test: fast/loader/file-protocol-fragment.html
2627
2628         * loader/cache/MemoryCache.cpp:
2629         (WebCore::MemoryCache::removeFragmentIdentifierIfNeeded):
2630
2631 2011-04-26  David Levin  <levin@chromium.org>
2632
2633         Reviewed by Darin Adler.
2634
2635         Fix more strict OwnPtr in WebCore (round N).
2636         https://bugs.webkit.org/show_bug.cgi?id=59464
2637
2638         * dom/Document.cpp:
2639         (WebCore::Document::Document):
2640         (WebCore::Document::attach):
2641         * fileapi/FileReader.cpp:
2642         (WebCore::FileReader::terminate):
2643         * loader/DocumentThreadableLoader.cpp:
2644         (WebCore::DocumentThreadableLoader::preflightFailure):
2645         * workers/DefaultSharedWorkerRepository.cpp:
2646         (WebCore::SharedWorkerConnectTask::create):
2647         (WebCore::SharedWorkerScriptLoader::load):
2648
2649 2011-04-26  Ruben  <chromium@hybridsource.org>
2650
2651         Reviewed by Tony Chang.
2652
2653         Change linux ifdefs for Chromium to Unix instead, allowing
2654         new Unix ports to be enabled by default
2655         https://bugs.webkit.org/show_bug.cgi?id=59297
2656
2657         No new tests, just changing preprocessor defines.
2658
2659         * bindings/js/JSInspectorFrontendHostCustom.cpp:
2660         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
2661         * dom/SelectElement.cpp:
2662         * loader/cache/CachedFont.cpp:
2663         * page/EventHandler.cpp:
2664         * page/chromium/EventHandlerChromium.cpp:
2665         * platform/Scrollbar.cpp:
2666         * platform/chromium/PlatformBridge.h:
2667         * platform/graphics/chromium/FontPlatformData.h:
2668         * platform/graphics/skia/FontCustomPlatformData.cpp:
2669         * platform/graphics/skia/FontCustomPlatformData.h:
2670
2671 2011-04-26  Ryosuke Niwa  <rniwa@webkit.org>
2672
2673         Reviewed by Dan Bernstein.
2674
2675         [RTL] Arabic/AB - after typing a date, cursors doesn't go back
2676         https://bugs.webkit.org/show_bug.cgi?id=49111
2677
2678         Even when the offset corresponds to a position visually left of the box
2679         and there aren't any inline boxes on the left, the previous/next position
2680         may still correspond to some position in the same line.
2681
2682         The bug was caused by our ignoring such cases. Fixed the bug by comparing
2683         previous/next position's inline box to the current box. If they match,
2684         then we stay on the same position because moving to the left visually at
2685         the left edge should not result in a position on the same line.
2686
2687         Also fixed a bug that WebKit uses offsets that are not extrema when moved to
2688         the left edge or to the right edge, and a bug that WebKit could not move to
2689         the left from 12^3 CBA abc to 123 C^BA abc (there is no offset between 3 and C).
2690
2691         Test cases are added to editing/selection/move-left-right.html
2692
2693         * editing/VisiblePosition.cpp:
2694         (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
2695         (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
2696
2697 2011-04-26  Gabor Loki  <loki@webkit.org>
2698
2699         Reviewed by Csaba Osztrogon√°c.
2700
2701         Speeding up SVG filters with multicore (SMP) support
2702         https://bugs.webkit.org/show_bug.cgi?id=43903
2703
2704         Some SVG filters execute a huge number of pixel manipulations, which
2705         cannot be sped up by graphics accelerators, since their algorithm is
2706         too complex. Using the power of Symmetric Multi Processing (SMP) we
2707         can split up a task to smaller (data independent) tasks, which can be
2708         executed independently.
2709
2710         The ParallelJobs framework provides a simple way for distributed
2711         programming. The framework is based on WebKit's threading infrastructure,
2712         Open Multi-Processing's (OpenMP) API, and libdispatch API.
2713
2714         * ForwardingHeaders/wtf/ParallelJobs.h: Added.
2715         * platform/graphics/filters/FETurbulence.cpp:
2716         (WebCore::FETurbulence::PaintingData::PaintingData):
2717         (WebCore::FETurbulence::noise2D):
2718         (WebCore::FETurbulence::calculateTurbulenceValueForPoint):
2719         (WebCore::FETurbulence::fillRegion):
2720         (WebCore::FETurbulence::fillRegionWorker):
2721         (WebCore::FETurbulence::apply):
2722         * platform/graphics/filters/FETurbulence.h:
2723
2724 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2725
2726         Reviewed by Yury Semikhatsky.
2727
2728         Web Inspector: close button is off in docked mode on a mac.
2729         https://bugs.webkit.org/show_bug.cgi?id=59453
2730
2731         * inspector/front-end/inspector.css:
2732         (.toolbar-item.close-left):
2733
2734 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2735
2736         Reviewed by Yury Semikhatsky.
2737
2738         Web Inspector: New Style is not working (UI glitch)
2739         https://bugs.webkit.org/show_bug.cgi?id=59451
2740
2741         * inspector/InspectorDOMStorageAgent.cpp:
2742         (WebCore::InspectorDOMStorageAgent::setFrontend):
2743         * inspector/front-end/AuditRules.js:
2744         (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
2745         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.externalStylesheetsReceived):
2746         (WebInspector.AuditRules.CssInHeadRule.prototype.doRun.inlineStylesReceived):
2747         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.cssBeforeInlineReceived):
2748         (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun.lateStylesReceived):
2749         * inspector/front-end/CSSStyleModel.js:
2750         (WebInspector.CSSStyleModel.prototype.setRuleSelector):
2751         (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
2752         (WebInspector.CSSStyleModel.prototype.addRule):
2753         (WebInspector.CSSStyleModel.prototype.addRule.callback):
2754         (WebInspector.CSSStyleModel.prototype._documentElementId):
2755         * inspector/front-end/DOMAgent.js:
2756         (WebInspector.DOMNode.prototype._addAttribute):
2757         (WebInspector.DOMNode.prototype.documentElement):
2758         * inspector/front-end/ResourceTreeModel.js:
2759         (WebInspector.PageDispatcher.prototype.frameDetached):
2760         * inspector/front-end/StylesSidebarPane.js:
2761         (WebInspector.StylesSidebarPane.prototype._createNewRule):
2762
2763 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2764
2765         Reviewed by Yury Semikhatsky.
2766
2767         Web Inspector: introduce DOMStorage::enable and disable.
2768         https://bugs.webkit.org/show_bug.cgi?id=59445
2769
2770         * inspector/Inspector.json:
2771         * inspector/InspectorAgent.cpp:
2772         (WebCore::InspectorAgent::InspectorAgent):
2773         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
2774         * inspector/InspectorDOMStorageAgent.cpp:
2775         (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
2776         (WebCore::InspectorDOMStorageAgent::restore):
2777         (WebCore::InspectorDOMStorageAgent::enable):
2778         (WebCore::InspectorDOMStorageAgent::disable):
2779         * inspector/InspectorDOMStorageAgent.h:
2780         (WebCore::InspectorDOMStorageAgent::create):
2781         * inspector/front-end/DOMStorage.js:
2782         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
2783         * inspector/front-end/ResourcesPanel.js:
2784         (WebInspector.ResourcesPanel.prototype._reset):
2785         * inspector/front-end/inspector.js:
2786
2787 2011-04-26  Pavel Feldman  <pfeldman@google.com>
2788
2789         Reviewed by Yury Semikhatsky.
2790
2791         Web Inspector: extract Page agent dispatcher into the ResourceTreeModel.
2792         https://bugs.webkit.org/show_bug.cgi?id=59440
2793
2794         * inspector/Inspector.json:
2795         * inspector/InspectorAgent.cpp:
2796         (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
2797         * inspector/InspectorPageAgent.cpp:
2798         (WebCore::InspectorPageAgent::setFrontend):
2799         (WebCore::InspectorPageAgent::frameNavigated):
2800         * inspector/InspectorPageAgent.h:
2801         * inspector/front-end/AuditsPanel.js:
2802         (WebInspector.AuditsPanel):
2803         (WebInspector.AuditsPanel.prototype._onLoadEventFired):
2804         (WebInspector.AuditsPanel.prototype._domContentLoadedEventFired):
2805         * inspector/front-end/CSSStyleModel.js:
2806         (WebInspector.CSSStyleModelResourceBinding):
2807         (WebInspector.CSSStyleModelResourceBinding.prototype._inspectedURLChanged):
2808         * inspector/front-end/DOMBreakpointsSidebarPane.js:
2809         (WebInspector.DOMBreakpointsSidebarPane):
2810         (WebInspector.DOMBreakpointsSidebarPane.prototype._inspectedURLChanged):
2811         * inspector/front-end/DOMStorage.js:
2812         (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
2813         * inspector/front-end/ExtensionServer.js:
2814         (WebInspector.ExtensionServer.prototype._inspectedURLChanged):
2815         (WebInspector.ExtensionServer.prototype.initExtensions):
2816         * inspector/front-end/NetworkPanel.js:
2817         (WebInspector.NetworkPanel):
2818         (WebInspector.NetworkPanel.prototype._onLoadEventFired):
2819         (WebInspector.NetworkPanel.prototype._domContentLoadedEventFired):
2820         (WebInspector.NetworkPanel.prototype._frameNavigated):
2821         * inspector/front-end/ResourceTreeModel.js:
2822         (WebInspector.ResourceTreeModel):
2823         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
2824         (WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged):
2825         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
2826         (WebInspector.ResourceTreeModel.prototype._frameDetached):
2827         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
2828         (WebInspector.PageDispatcher):
2829         (WebInspector.PageDispatcher.prototype.domContentEventFired):
2830         (WebInspector.PageDispatcher.prototype.loadEventFired):
2831         (WebInspector.PageDispatcher.prototype.frameNavigated):
2832         (WebInspector.PageDispatcher.prototype.frameDetached):
2833         * inspector/front-end/ResourcesPanel.js:
2834         (WebInspector.ResourcesPanel):
2835         (WebInspector.ResourcesPanel.prototype._onLoadEventFired):
2836         (WebInspector.ResourcesPanel.prototype._frameNavigated):
2837         * inspector/front-end/inspector.js:
2838
2839 2011-04-26  Csaba Osztrogon√°c  <ossy@webkit.org>
2840
2841         Unreviewed rollout r84877 and StyleRareInheritedData.cpp changes of r84892,
2842         because it broke transitions/multiple-text-shadow-transition.html
2843
2844         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
2845         https://bugs.webkit.org/show_bug.cgi?id=59377
2846
2847         * css/CSSStyleSelector.cpp:
2848         (WebCore::CSSStyleSelector::applyProperty):
2849         * page/animation/AnimationBase.cpp:
2850         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
2851         (WebCore::PropertyWrapperShadow::blend):
2852         * rendering/style/RenderStyle.cpp:
2853         (WebCore::RenderStyle::setTextShadow):
2854         (WebCore::RenderStyle::setBoxShadow):
2855         * rendering/style/RenderStyle.h:
2856         (WebCore::InheritedFlags::textShadow):
2857         * rendering/style/StyleRareInheritedData.cpp:
2858         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2859         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
2860         * rendering/style/StyleRareInheritedData.h:
2861         * rendering/style/StyleRareNonInheritedData.cpp:
2862         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2863
2864 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
2865
2866         Reviewed by Adam Barth.
2867
2868         Turn off make built-in implicit rules for derived sources makefile
2869         https://bugs.webkit.org/show_bug.cgi?id=59418
2870
2871         We don't use any of make's built-in implicit rules, turning them off
2872         speeds up parsing of the makefile.
2873
2874         * WebCore.xcodeproj/project.pbxproj:
2875         * gyp/generate-derived-sources.sh:
2876
2877 2011-04-26  Leo Yang  <leo.yang@torchmobile.com.cn>
2878
2879         Reviewed by Nikolas Zimmermann.
2880
2881         ASSERT failure in SVGUseElement
2882         https://bugs.webkit.org/show_bug.cgi?id=59313
2883
2884         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
2885         was wrong because the document may not be well-formed.
2886
2887         This patch asserts the element is not pending on resource or the
2888         document is not well-formed.
2889
2890         Test: svg/custom/use-crash-in-non-wellformed-document.svg
2891
2892         * svg/SVGUseElement.cpp:
2893         (WebCore::isWellFormedDocument):
2894         (WebCore::SVGUseElement::insertedIntoDocument):
2895
2896 2011-04-26  Mikhail Naganov  <mnaganov@chromium.org>
2897
2898         Reviewed by Pavel Feldman.
2899
2900         Web Inspector: [Chromium] Fix columns resizing in the detailed heap snapshot grids.
2901         https://bugs.webkit.org/show_bug.cgi?id=59438
2902
2903         * inspector/front-end/DetailedHeapshotView.js:
2904         (WebInspector.DetailedHeapshotView.prototype._changeView):
2905
2906 2011-04-26  David Levin  <levin@chromium.org>
2907
2908         Reviewed by Adam Barth.
2909
2910         Fix a few OwnPtr strict errors in WebCore headers.
2911         https://bugs.webkit.org/show_bug.cgi?id=59431
2912
2913         * bindings/js/ScheduledAction.cpp:
2914         (WebCore::ScheduledAction::create):
2915         * css/MediaQueryMatcher.cpp:
2916         (WebCore::MediaQueryMatcher::prepareEvaluator):
2917         * dom/NodeRareData.h:
2918         (WebCore::NodeListsNodeData::create):
2919         * dom/ScriptRunner.h:
2920         (WebCore::ScriptRunner::create):
2921         * inspector/WorkerInspectorController.cpp:
2922         (WebCore::WorkerInspectorController::connectFrontend):
2923         * loader/icon/IconDatabase.h:
2924         (WebCore::IconDatabase::create):
2925         * platform/graphics/SimpleFontData.cpp:
2926         (WebCore::SimpleFontData::verticalRightOrientationFontData):
2927         (WebCore::SimpleFontData::uprightOrientationFontData):
2928         (WebCore::SimpleFontData::brokenIdeographFontData):
2929         * rendering/style/StyleRareInheritedData.cpp:
2930         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
2931         * rendering/svg/SVGResources.h:
2932         (WebCore::SVGResources::ClipperFilterMaskerData::create):
2933         (WebCore::SVGResources::MarkerData::create):
2934         (WebCore::SVGResources::FillStrokeData::create):
2935         * storage/StorageSyncManager.cpp:
2936         (WebCore::StorageSyncManager::close):
2937         * workers/WorkerContext.cpp:
2938         (WebCore::CloseWorkerContextTask::create):
2939         * workers/WorkerMessagingProxy.cpp:
2940         (WebCore::MessageWorkerContextTask::create):
2941         (WebCore::MessageWorkerTask::create):
2942         (WebCore::WorkerExceptionTask::create):
2943         (WebCore::WorkerContextDestroyedTask::create):
2944         (WebCore::WorkerTerminateTask::create):
2945         (WebCore::WorkerThreadActivityReportTask::create):
2946         * workers/WorkerRunLoop.cpp:
2947         (WebCore::WorkerRunLoop::Task::create):
2948         * workers/WorkerThread.cpp:
2949         (WebCore::WorkerThreadStartupData::create):
2950         (WebCore::WorkerThreadShutdownFinishTask::create):
2951         (WebCore::WorkerThreadShutdownStartTask::create):
2952
2953 2011-04-26  Adam Klein  <adamk@chromium.org>
2954
2955         Reviewed by Adam Barth.
2956
2957         Fix last strict OwnPtr violation under svg/...
2958         https://bugs.webkit.org/show_bug.cgi?id=59429
2959
2960         * svg/SVGDocumentExtensions.cpp:
2961         (WebCore::SVGDocumentExtensions::removePendingResource):
2962
2963 2011-04-26  Adam Barth  <abarth@webkit.org>
2964
2965         Reviewed by David Levin.
2966
2967         Fix more strict OwnPtr violations in WebCore
2968         https://bugs.webkit.org/show_bug.cgi?id=59433
2969
2970         These manifest in the Chromium build.
2971
2972         * bindings/v8/ScriptController.cpp:
2973         (WebCore::ScriptController::ScriptController):
2974         * bindings/v8/ScriptDebugServer.cpp:
2975         (WebCore::ScriptDebugServer::editScriptSource):
2976         * bindings/v8/V8DOMMap.cpp:
2977         (WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
2978         * bindings/v8/V8Proxy.cpp:
2979         (WebCore::V8Proxy::precompileScript):
2980         * bindings/v8/WorkerScriptController.cpp:
2981         (WebCore::WorkerScriptController::WorkerScriptController):
2982         * page/Page.cpp:
2983         (WebCore::Page::Page):
2984         (WebCore::Page::speechInput):
2985         * platform/PlatformGestureRecognizer.cpp:
2986         (WebCore::PlatformGestureRecognizer::create):
2987         * platform/PlatformGestureRecognizer.h:
2988         * platform/graphics/chromium/DrawingBufferChromium.cpp:
2989         (WebCore::DrawingBuffer::DrawingBuffer):
2990         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
2991         (WebCore::CCLayerImpl::CCLayerImpl):
2992         * platform/graphics/gpu/Texture.cpp:
2993         (WebCore::Texture::create):
2994         * platform/image-decoders/bmp/BMPImageDecoder.cpp:
2995         (WebCore::BMPImageDecoder::decodeHelper):
2996         * platform/image-decoders/gif/GIFImageDecoder.cpp:
2997         (WebCore::GIFImageDecoder::decode):
2998         * platform/image-decoders/ico/ICOImageDecoder.cpp:
2999         (WebCore::ICOImageDecoder::decodeAtIndex):
3000         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
3001         (WebCore::JPEGImageDecoder::decode):
3002         * platform/image-decoders/png/PNGImageDecoder.cpp:
3003         (WebCore::PNGImageDecoder::decode):
3004         * storage/chromium/DatabaseTrackerChromium.cpp:
3005         (WebCore::DatabaseTracker::addOpenDatabase):
3006
3007 2011-04-25  David Levin  <levin@chromium.org>
3008
3009         Reviewed by Adam Barth.
3010
3011         Fix OwnPtr strict errors in CrossThreadTask.h
3012         https://bugs.webkit.org/show_bug.cgi?id=59427
3013
3014         * dom/CrossThreadTask.h:
3015         (WebCore::CrossThreadTask1::create):
3016         (WebCore::CrossThreadTask2::create):
3017         (WebCore::CrossThreadTask3::create):
3018         (WebCore::CrossThreadTask4::create):
3019         (WebCore::CrossThreadTask5::create):
3020         (WebCore::CrossThreadTask6::create):
3021         (WebCore::CrossThreadTask7::create):
3022         (WebCore::CrossThreadTask8::create):
3023
3024 2011-04-25  Mark Rowe  <mrowe@apple.com>
3025
3026         Reviewed by Dan Bernstein.
3027
3028         <rdar://problem/9330337> Leak of 'WebCore::ApplyPropertyFillLayer<WebCore::FillSize>'
3029
3030         * css/CSSStyleApplyProperty.cpp:
3031         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Don't initialize CSSPropertyWebkitMaskSize twice.
3032         * css/CSSStyleApplyProperty.h:
3033         (WebCore::CSSStyleApplyProperty::setPropertyValue): Add some asserts to catch this class of leak.
3034
3035 2011-04-25  Levi Weintraub  <leviw@chromium.org>
3036
3037         Reviewed by Ryosuke Niwa.
3038
3039         REGRESSION: a character appears after tab span when typing immediately before the tab span
3040         https://bugs.webkit.org/show_bug.cgi?id=58132
3041
3042         Correcting the order of operations we use to avoid inserting into invalid positions in
3043         ReplaceSelectionCommand to avoid inserting into tab-spans.
3044
3045         Test: editing/pasteboard/paste-before-tab-span.html
3046
3047         * editing/ReplaceSelectionCommand.cpp:
3048         (WebCore::ReplaceSelectionCommand::doApply): Moving positionOutsideTabSpan to after
3049         positionAvoidingPrecedingNodes, since that function could once again put our position
3050         inside a tab span.
3051
3052 2011-04-25  David Levin  <levin@chromium.org>
3053
3054         Reviewed by Adam Barth.
3055
3056         Fix OwnPtr strict error in ImageBuffer.h
3057         https://bugs.webkit.org/show_bug.cgi?id=59422
3058
3059         * platform/graphics/ImageBuffer.h:
3060         (WebCore::ImageBuffer::create):
3061
3062 2011-04-25  Adam Barth  <abarth@webkit.org>
3063
3064         Reviewed by David Levin.
3065
3066         Fix strict OwnPtr violations and whitelist known-tricky files
3067         https://bugs.webkit.org/show_bug.cgi?id=59421
3068
3069         With this patch, WebCore builds cleanly with strict OwnPtrs.
3070
3071         * dom/MessagePort.cpp:
3072         (WebCore::MessagePort::MessagePort):
3073         * dom/XMLDocumentParserLibxml2.cpp:
3074         * page/ContextMenuController.cpp:
3075         (WebCore::ContextMenuController::ContextMenuController):
3076         (WebCore::ContextMenuController::clearContextMenu):
3077         * page/PluginHalter.cpp:
3078         * platform/graphics/MediaPlayer.cpp:
3079         * platform/network/ResourceRequestBase.cpp:
3080         (WebCore::ResourceRequestBase::adopt):
3081         (WebCore::ResourceRequestBase::copyData):
3082         * svg/SVGDocumentExtensions.cpp:
3083
3084 2011-04-25  David Levin  <levin@chromium.org>
3085
3086         Reviewed by Adam Barth.
3087
3088         Fix OwnPtr strict errors in DatasetDOMStringMap.h.
3089         https://bugs.webkit.org/show_bug.cgi?id=59419
3090
3091         * dom/DatasetDOMStringMap.h:
3092         (WebCore::DatasetDOMStringMap::create):
3093
3094 2011-04-25  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3095
3096         Reviewed by Eric Seidel.
3097
3098         KeyboardEvent.cpp should work with strict OwnPtrs.
3099         https://bugs.webkit.org/show_bug.cgi?id=59403
3100
3101         * dom/KeyboardEvent.cpp:
3102         (WebCore::KeyboardEvent::KeyboardEvent):
3103
3104 2011-04-25  James Robinson  <jamesr@chromium.org>
3105
3106         Reviewed by Eric Seidel.
3107
3108         Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr
3109         https://bugs.webkit.org/show_bug.cgi?id=59377
3110
3111         * css/CSSStyleSelector.cpp:
3112         (WebCore::CSSStyleSelector::applyProperty):
3113         * page/animation/AnimationBase.cpp:
3114         (WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
3115         (WebCore::PropertyWrapperShadow::blend):
3116         * rendering/style/RenderStyle.cpp:
3117         (WebCore::RenderStyle::setTextShadow):
3118         (WebCore::RenderStyle::setBoxShadow):
3119         * rendering/style/RenderStyle.h:
3120         (WebCore::InheritedFlags::textShadow):
3121         * rendering/style/StyleRareInheritedData.cpp:
3122         (WebCore::StyleRareInheritedData::StyleRareInheritedData):
3123         (WebCore::StyleRareInheritedData::~StyleRareInheritedData):
3124         * rendering/style/StyleRareInheritedData.h:
3125         * rendering/style/StyleRareNonInheritedData.cpp:
3126         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
3127
3128 2011-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3129
3130         Unreviewed, rolling out r84864.
3131         http://trac.webkit.org/changeset/84864
3132         https://bugs.webkit.org/show_bug.cgi?id=59413
3133
3134         Expect result of use-crash-in-non-wellformed-document.svg is
3135         platform dependent (Requested by leoyang on #webkit).
3136
3137         * svg/SVGUseElement.cpp:
3138         (WebCore::SVGUseElement::insertedIntoDocument):
3139
3140 2011-04-25  Leo Yang  <leo.yang@torchmobile.com.cn>
3141
3142         Reviewed by Nikolas Zimmermann.
3143
3144         ASSERT failure in SVGUseElement
3145         https://bugs.webkit.org/show_bug.cgi?id=59313
3146
3147         In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
3148         was wrong because the document may not be well-formed.
3149
3150         This patch asserts the element is not pending on resource or the
3151         document is not well-formed.
3152
3153         Test: svg/custom/use-crash-in-non-wellformed-document.svg
3154
3155         * svg/SVGUseElement.cpp:
3156         (WebCore::isWellFormedDocument):
3157         (WebCore::SVGUseElement::insertedIntoDocument):
3158
3159 2011-04-25  Igor Oliveira  <igor.oliveira@openbossa.org>
3160
3161         Reviewed by Tony Chang.
3162
3163         Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class
3164         https://bugs.webkit.org/show_bug.cgi?id=59028
3165
3166         The DataTransferItemsChromium and DataTransferItemChromium code can be reused by other platforms.
3167         Moving the code for base class we can reduce the efforts to support DataTransferItems
3168         element in different platforms.
3169
3170         * Android.mk:
3171         * CMakeLists.txt:
3172         * GNUmakefile.list.am:
3173         * WebCore.gypi:
3174         * WebCore.pro:
3175         * WebCore.vcproj/WebCore.vcproj:
3176         * WebCore.xcodeproj/project.pbxproj:
3177         * dom/DataTransferItem.cpp:
3178         (WebCore::DataTransferItem::DataTransferItem):
3179         (WebCore::DataTransferItem::owner):
3180         (WebCore::DataTransferItem::kind):
3181         (WebCore::DataTransferItem::type):
3182         * dom/DataTransferItem.h:
3183         * dom/DataTransferItems.cpp: Copied from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp.
3184         (WebCore::DataTransferItems::DataTransferItems):
3185         (WebCore::DataTransferItems::length):
3186         (WebCore::DataTransferItems::item):
3187         (WebCore::DataTransferItems::deleteItem):
3188         (WebCore::DataTransferItems::clear):
3189         (WebCore::DataTransferItems::add):
3190         * dom/DataTransferItems.h:
3191         * platform/chromium/DataTransferItemChromium.cpp:
3192         (WebCore::DataTransferItem::create):
3193         (WebCore::DataTransferItemChromium::DataTransferItemChromium):
3194         (WebCore::DataTransferItemChromium::getAsString):
3195         (WebCore::DataTransferItemChromium::getAsFile):
3196         * platform/chromium/DataTransferItemChromium.h:
3197         * platform/chromium/DataTransferItemsChromium.cpp:
3198         (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
3199         * platform/chromium/DataTransferItemsChromium.h:
3200
3201 2011-04-25  Chris Marrin  <cmarrin@apple.com>
3202
3203         Reviewed by Simon Fraser.
3204
3205         REGRESSION(75137): directly composited images are double-drawn sometimes
3206         https://bugs.webkit.org/show_bug.cgi?id=58632
3207
3208         Depending on the order of operations (layout, creating compositing 
3209         layers and creating simple image layers) a layer can have both image
3210         content and have m_drawsContent=true. In this case 2 copies of the image
3211         are drawn in the layer. If the image has alpha, it looks wrong.
3212
3213         I added an updateDrawsContent() call after setting the image contents
3214         to make sure it's correct.
3215
3216         I couldn't create a test case that shows the problem because layerTreeAsText()
3217         doesn't emit enough info to show this level of detail. I've opened
3218         https://bugs.webkit.org/show_bug.cgi?id=59352 to fix that.
3219
3220         * rendering/RenderLayerBacking.cpp:
3221         (WebCore::RenderLayerBacking::updateImageContents):
3222
3223 2011-04-25  Kenneth Russell  <kbr@google.com>
3224
3225         Reviewed by David Levin.
3226
3227         Fix OwnPtr strict errors in InlineFlowBox.cpp
3228         https://bugs.webkit.org/show_bug.cgi?id=59392
3229
3230         * rendering/InlineFlowBox.cpp:
3231         (WebCore::InlineFlowBox::setLayoutOverflow):
3232         (WebCore::InlineFlowBox::setVisualOverflow):
3233
3234 2011-04-25  Kenneth Russell  <kbr@google.com>
3235
3236         Reviewed by David Levin.
3237
3238         Fix OwnPtr strict errors in TransformState.cpp
3239         https://bugs.webkit.org/show_bug.cgi?id=59380
3240
3241         * rendering/TransformState.cpp:
3242         (WebCore::TransformState::applyTransform):
3243
3244 2011-04-25  Adam Barth  <abarth@webkit.org>
3245
3246         Reviewed by James Robinson.
3247
3248         DOMWindow.cpp should work with strict OwnPtrs
3249         https://bugs.webkit.org/show_bug.cgi?id=59356
3250
3251         * page/DOMWindow.cpp:
3252         (WebCore::PostMessageTimer::fired):
3253         (WebCore::DOMWindow::postMessageTimerFired):
3254         * page/DOMWindow.h:
3255
3256 2011-04-25  Adam Klein  <adamk@chromium.org>
3257
3258         Reviewed by James Robinson.
3259
3260         Fix OwnPtr strict errors in some SVG classes.
3261         https://bugs.webkit.org/show_bug.cgi?id=59395
3262
3263         * rendering/style/SVGRenderStyleDefs.cpp:
3264         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3265         * svg/SVGSVGElement.cpp:
3266         (WebCore::SVGSVGElement::SVGSVGElement):
3267         * svg/SVGStyledTransformableElement.cpp:
3268         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3269         * svg/SVGTextElement.cpp:
3270         (WebCore::SVGTextElement::supplementalTransform):
3271         * svg/graphics/SVGImage.cpp:
3272         (WebCore::SVGImage::dataChanged):
3273
3274 2011-04-25  Adam Barth  <abarth@webkit.org>
3275
3276         Re-land changes to ValidationMessage.
3277
3278         * html/ValidationMessage.cpp:
3279         (WebCore::ValidationMessage::setMessage):
3280         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3281         (WebCore::ValidationMessage::requestToHideMessage):
3282
3283 2011-04-25  Ojan Vafai  <ojan@chromium.org>
3284
3285         Reviewed by James Robinson.
3286
3287         fix OwnPtr strict error in FrameView.cpp
3288         https://bugs.webkit.org/show_bug.cgi?id=59402
3289
3290         * page/FrameView.cpp:
3291         (WebCore::FrameView::FrameView):
3292         (WebCore::FrameView::addWidgetToUpdate):
3293
3294 2011-04-25  Adam Klein  <adamk@chromium.org>
3295
3296         Unreviewed, rolling out r84844.
3297         http://trac.webkit.org/changeset/84844
3298         https://bugs.webkit.org/show_bug.cgi?id=59395
3299
3300         Checked in too much.
3301
3302         * rendering/style/SVGRenderStyleDefs.cpp:
3303         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3304         * svg/SVGDocumentExtensions.cpp:
3305         (WebCore::SVGDocumentExtensions::removePendingResource):
3306         * svg/SVGSVGElement.cpp:
3307         (WebCore::SVGSVGElement::SVGSVGElement):
3308         * svg/SVGStyledTransformableElement.cpp:
3309         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3310         * svg/SVGTextElement.cpp:
3311         (WebCore::SVGTextElement::supplementalTransform):
3312         * svg/graphics/SVGImage.cpp:
3313         (WebCore::SVGImage::dataChanged):
3314
3315 2011-04-25  Adrienne Walker  <enne@google.com>
3316
3317         Reviewed by David Levin.
3318
3319         Make ActiveDOMCallback play nice with OwnPtr strict mode
3320         https://bugs.webkit.org/show_bug.cgi?id=59398
3321
3322         * bindings/generic/ActiveDOMCallback.cpp:
3323         (WebCore::ActiveDOMCallback::ActiveDOMCallback):
3324
3325 2011-04-25  Adam Klein  <adamk@chromium.org>
3326
3327         Reviewed by James Robinson.
3328
3329         Fix OwnPtr strict errors in some SVG classes.
3330         https://bugs.webkit.org/show_bug.cgi?id=59395
3331
3332         * rendering/style/SVGRenderStyleDefs.cpp:
3333         (WebCore::StyleShadowSVGData::StyleShadowSVGData):
3334         * svg/SVGSVGElement.cpp:
3335         (WebCore::SVGSVGElement::SVGSVGElement):
3336         * svg/SVGStyledTransformableElement.cpp:
3337         (WebCore::SVGStyledTransformableElement::supplementalTransform):
3338         * svg/SVGTextElement.cpp:
3339         (WebCore::SVGTextElement::supplementalTransform):
3340         * svg/graphics/SVGImage.cpp:
3341         (WebCore::SVGImage::dataChanged):
3342
3343 2011-04-25  James Robinson  <jamesr@chromium.org>
3344
3345         Unreviewed, rolling out r84835.
3346         http://trac.webkit.org/changeset/84835
3347         https://bugs.webkit.org/show_bug.cgi?id=59394
3348
3349         Breaks compile because Deque<OwnPtr> doesn't work
3350
3351         * dom/XMLDocumentParserLibxml2.cpp:
3352         (WebCore::PendingCallbacks::~PendingCallbacks):
3353         (WebCore::PendingCallbacks::appendStartElementNSCallback):
3354         (WebCore::PendingCallbacks::appendEndElementNSCallback):
3355         (WebCore::PendingCallbacks::appendCharactersCallback):
3356         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
3357         (WebCore::PendingCallbacks::appendCDATABlockCallback):
3358         (WebCore::PendingCallbacks::appendCommentCallback):
3359         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
3360         (WebCore::PendingCallbacks::appendErrorCallback):
3361         (WebCore::XMLDocumentParser::XMLDocumentParser):
3362         * html/ValidationMessage.cpp:
3363         (WebCore::ValidationMessage::setMessage):
3364         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3365         (WebCore::ValidationMessage::requestToHideMessage):
3366
3367 2011-04-25  James Robinson  <jamesr@chromium.org>
3368
3369         Reviewed by Sam Weinig.
3370
3371         Fix OwnPtr strict mode violation in ImageBufferCG
3372         https://bugs.webkit.org/show_bug.cgi?id=59396
3373
3374         * platform/graphics/cg/ImageBufferCG.cpp:
3375         (WebCore::ImageBuffer::ImageBuffer):
3376
3377 2011-04-25  Huang Dongsung  <luxtella@company100.net>
3378
3379         Reviewed by Dirk Schulze.
3380
3381         [Skia] Remove an unused local variable in PlatformContextSkia::readbackHardwareToSoftware().
3382         https://bugs.webkit.org/show_bug.cgi?id=59308
3383
3384         An unused local variable is created and even allocates heap memory.
3385
3386         * platform/graphics/skia/PlatformContextSkia.cpp:
3387         (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
3388
3389 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3390
3391         Qt build fix: Updated files not used by other ports for rename.
3392
3393         * bindings/js/JSTouchCustom.cpp:
3394         (WebCore::toJSNewlyCreated):
3395         * bindings/js/JSTouchListCustom.cpp:
3396         (WebCore::toJSNewlyCreated):
3397
3398 2011-04-25  Adrienne Walker  <enne@google.com>
3399
3400         Reviewed by David Levin.
3401
3402         WebCore/css/CSS* files should play nice with strict OwnPtrs
3403         https://bugs.webkit.org/show_bug.cgi?id=59382
3404
3405         * css/CSSFontFaceSource.cpp:
3406         (WebCore::CSSFontFaceSource::getFontData):
3407         * css/CSSParser.cpp:
3408         (WebCore::CSSParser::addProperty):
3409         (WebCore::CSSParser::parseValue):
3410
3411 2011-04-25  Adam Barth  <abarth@webkit.org>
3412
3413         Reviewed by James Robinson.
3414
3415         ValidationMessage and XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
3416         https://bugs.webkit.org/show_bug.cgi?id=59394
3417
3418         * dom/XMLDocumentParserLibxml2.cpp:
3419         (WebCore::PendingCallbacks::PendingCallbacks):
3420         (WebCore::PendingCallbacks::appendStartElementNSCallback):
3421         (WebCore::PendingCallbacks::appendEndElementNSCallback):
3422         (WebCore::PendingCallbacks::appendCharactersCallback):
3423         (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
3424         (WebCore::PendingCallbacks::appendCDATABlockCallback):
3425         (WebCore::PendingCallbacks::appendCommentCallback):
3426         (WebCore::PendingCallbacks::appendInternalSubsetCallback):
3427         (WebCore::PendingCallbacks::appendErrorCallback):
3428         (WebCore::XMLDocumentParser::XMLDocumentParser):
3429         * html/ValidationMessage.cpp:
3430         (WebCore::ValidationMessage::setMessage):
3431         (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
3432         (WebCore::ValidationMessage::requestToHideMessage):
3433
3434 2011-04-25  James Robinson  <jamesr@chromium.org>
3435
3436         Reviewed by Adam Barth.
3437
3438         Fix OwnPtr strictness issues in WebCore/inspector/
3439         https://bugs.webkit.org/show_bug.cgi?id=59387
3440
3441         * inspector/InspectorAgent.cpp:
3442         (WebCore::InspectorAgent::InspectorAgent):
3443         * inspector/InspectorController.cpp:
3444         (WebCore::InspectorController::InspectorController):
3445         * inspector/InspectorStyleSheet.cpp:
3446         (WebCore::InspectorStyleSheet::ensureSourceData):
3447
3448 2011-04-25  Geoffrey Garen  <ggaren@apple.com>
3449
3450         Reviewed by Beth Dakin.
3451
3452         Removed XPathNamespace because it was unused
3453         https://bugs.webkit.org/show_bug.cgi?id=59381
3454         
3455         This allows us to make Node::ownerDocument() non-virtual, though it has
3456         the unhappy side-effect of rebuilding the world.
3457
3458         * CMakeLists.txt:
3459         * GNUmakefile.list.am:
3460         * WebCore.gypi:
3461         * WebCore.pro:
3462         * WebCore.vcproj/WebCore.vcproj:
3463         * WebCore.xcodeproj/project.pbxproj: Bye bye dead code.
3464
3465         * dom/Node.h: Hello fast code!
3466
3467         * xml/XPathNamespace.cpp: Removed.
3468         * xml/XPathNamespace.h: Removed.
3469
3470 2011-04-25  Adam Barth  <abarth@webkit.org>
3471
3472         Reviewed by Darin Adler.
3473
3474         HistoryItemMac should play nice with OwnPtrs
3475         https://bugs.webkit.org/show_bug.cgi?id=59388
3476
3477         * history/mac/HistoryItemMac.mm:
3478         (WebCore::HistoryItem::setTransientProperty):
3479
3480 2011-04-25  David Levin  <levin@chromium.org>
3481
3482         Reviewed by Kenneth Russell.
3483
3484         Fix strict OwnPtrs in ContextMenuController.cpp
3485         https://bugs.webkit.org/show_bug.cgi?id=59375
3486
3487         * page/ContextMenuController.cpp:
3488         (WebCore::ContextMenuController::createContextMenu):
3489         (WebCore::separatorItem):
3490
3491 2011-04-25  Adam Barth  <abarth@webkit.org>
3492
3493         Reviewed by Darin Adler.
3494
3495         CheckedRadioButton should play nice with strict OwnPtr
3496         https://bugs.webkit.org/show_bug.cgi?id=59386
3497
3498         * dom/CheckedRadioButtons.cpp:
3499         (WebCore::CheckedRadioButtons::addButton):
3500
3501 2011-04-25  Adam Barth  <abarth@webkit.org>
3502
3503         Reviewed by David Levin.
3504
3505         Resource*.cpp should play nice with strict OwnPtrs
3506         https://bugs.webkit.org/show_bug.cgi?id=59383
3507
3508         * bridge/runtime_method.cpp:
3509         (JSC::RuntimeMethod::RuntimeMethod):
3510         * platform/network/ResourceHandle.cpp:
3511         (WebCore::ResourceHandle::ResourceHandle):
3512         * platform/network/ResourceResponseBase.cpp:
3513         (WebCore::ResourceResponseBase::adopt):