2b229f331f05731831dafe1c498c45f5b708d516
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2013-04-25  Joseph Pecoraro  <pecoraro@apple.com>
2
3         Web Inspector: ConsoleMessage should include line and column number where possible
4         https://bugs.webkit.org/show_bug.cgi?id=114929
5
6           - adds "m_column" to WebCore::ConsoleMessage
7           - adds "column" to Console.ConsoleMessage in the inspector protocol
8           - set the column number for console.* functions (Console.cpp)
9           - set the column number for XSLT errors (XSLTProcessor)
10           - plumb columnNumber everywhere else it is needed, set it to 0 and file
11             bugs for all cases missing columnNumber that could provide it.
12
13         Reviewed by Timothy Hatcher.
14
15         Test: inspector/console/console-url-line-column.html
16               inspector/console/console-messages-stack-traces.html
17
18         * inspector/ConsoleMessage.h:
19         * inspector/ConsoleMessage.cpp:
20         (WebCore::ConsoleMessage::ConsoleMessage):
21         (WebCore::ConsoleMessage::autogenerateMetadata):
22         (WebCore::ConsoleMessage::addToFrontend):
23         (WebCore::ConsoleMessage::isEqual):
24         Add m_column and set it where appropriate.
25
26         * inspector/Inspector.json:
27         Add column property to Console.ConsoleMessage.
28
29         * page/Console.cpp:
30         (WebCore::internalAddMessage):
31         (WebCore::Console::profile):
32         Set columnNumber like lineNumber from the last stack frame.
33         (WebCore::Console::groupEnd):
34         Line and column are unused in this message type, set both to 0.
35
36         * xml/XSLTProcessorLibxslt.cpp:
37         (WebCore::XSLTProcessor::parseErrorFunc):
38         * xml/XSLTProcessorQt.cpp:
39         (WebCore::XSLTMessageHandler::handleMessage):
40         Add real column numbers, the XSLT handlers already had it available.
41
42         * bindings/js/JSCustomXPathNSResolver.cpp:
43         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
44         * css/CSSParser.cpp:
45         (WebCore::CSSParser::logError):
46         * dom/ScriptExecutionContext.h:
47         * dom/ScriptExecutionContext.cpp:
48         (WebCore::ScriptExecutionContext::addConsoleMessage):
49         * dom/Document.cpp:
50         (WebCore::Document::logExceptionToConsole):
51         (WebCore::Document::addMessage):
52         * dom/Document.h:
53         * inspector/InspectorConsoleAgent.cpp:
54         (WebCore::InspectorConsoleAgent::addMessageToConsole):
55         (WebCore::InspectorConsoleAgent::stopTiming):
56         (WebCore::InspectorConsoleAgent::didFinishXHRLoading):
57         (WebCore::InspectorConsoleAgent::didReceiveResponse):
58         (WebCore::InspectorConsoleAgent::didFailLoading):
59         * inspector/InspectorConsoleAgent.h:
60         * inspector/InspectorConsoleInstrumentation.h:
61         (WebCore::InspectorInstrumentation::addMessageToConsole):
62         (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
63         * inspector/InspectorInstrumentation.cpp:
64         (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
65         (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
66         (WebCore::InspectorInstrumentation::addProfileImpl):
67         * inspector/InspectorInstrumentation.h:
68         (InspectorInstrumentation):
69         * inspector/InspectorProfilerAgent.cpp:
70         (WebCore::InspectorProfilerAgent::addProfile):
71         (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
72         (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
73         (WebCore::InspectorProfilerAgent::start):
74         (WebCore::InspectorProfilerAgent::stop):
75         * inspector/InspectorProfilerAgent.h:
76         (InspectorProfilerAgent):
77         * loader/EmptyClients.h:
78         (WebCore::EmptyChromeClient::addMessageToConsole):
79         * page/ChromeClient.h:
80         (WebCore::ChromeClient::addMessageToConsole):
81         * page/ContentSecurityPolicy.cpp:
82         (WebCore::ContentSecurityPolicy::logToConsole):
83         * page/PageConsole.cpp:
84         (WebCore::PageConsole::addMessage):
85         * page/PageConsole.h:
86         * workers/DefaultSharedWorkerRepository.cpp:
87         (SharedWorkerProxy):
88         (WebCore::postExceptionTask):
89         (WebCore::SharedWorkerProxy::postExceptionToWorkerObject):
90         (WebCore::postConsoleMessageTask):
91         (WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
92         * workers/SharedWorkerContext.cpp:
93         (WebCore::SharedWorkerContext::logExceptionToConsole):
94         * workers/WorkerContext.cpp:
95         (WebCore::WorkerContext::logExceptionToConsole):
96         (WebCore::WorkerContext::addConsoleMessage):
97         (WebCore::WorkerContext::addMessage):
98         (WebCore::WorkerContext::addMessageToWorkerConsole):
99         * workers/WorkerContext.h:
100         * workers/WorkerMessagingProxy.cpp:
101         (WebCore::WorkerExceptionTask::create):
102         (WebCore::WorkerExceptionTask::WorkerExceptionTask):
103         (WebCore::WorkerExceptionTask::performTask):
104         (WorkerExceptionTask):
105         (WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
106         (WebCore::postConsoleMessageTask):
107         (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
108         * workers/WorkerMessagingProxy.h:
109         (WorkerMessagingProxy):
110         * workers/WorkerReportingProxy.h:
111         (WorkerReportingProxy):
112         Plumb columnNumber through where appropriate. File bugs where missing.
113
114 2013-04-25  Allan Sandfeld Jensen  <allan.jensen@digia.com>
115
116         [Qt] Animated opacity does not trigger accelerated compositing
117         https://bugs.webkit.org/show_bug.cgi?id=115107
118
119         Reviewed by Simon Fraser.
120
121         Add extra option to also trigger compositing on animated opacity.
122
123         * page/ChromeClient.h:
124         * rendering/RenderLayerCompositor.cpp:
125         (WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
126
127 2013-04-25  Lamarque V. Souza  <Lamarque.Souza@basyskom.com>
128
129         Sec-WebSocket-Extensions header field must not appear more than once in an HTTP response.
130         https://bugs.webkit.org/show_bug.cgi?id=115128
131
132         Reviewed by Alexey Proskuryakov.
133
134         According to WebSocket specification Sec-WebSocket-Extensions header field
135         must not appear more than once in an HTTP response. It is ok if it appears
136         more than once in client request. Also add a check for invalid UTF-8
137         characters when parsing Sec-WebSocket-Extensions quoted string.
138
139         Test: http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header.html
140
141         * Modules/websockets/WebSocketExtensionParser.cpp:
142         (WebCore::WebSocketExtensionParser::consumeQuotedString): Return false if there is
143         invalid character in the quoted string being parsed.
144         * Modules/websockets/WebSocketHandshake.cpp:
145         (WebCore::WebSocketHandshake::readHTTPHeaders): Check if Sec-WebSocket-Extensions
146         appears more than once in header response. Abort handshake if it does.
147
148 2013-04-25  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
149
150         REGRESSION(r148758): Remove WTFLogAlways call from IconLoader.
151         https://bugs.webkit.org/show_bug.cgi?id=115182
152
153         Reviewed by Dan Bernstein.
154
155         The call added in r148758 was apparently a leftover from some debugging
156         session, and it makes the Interactive/window-resize.html performance
157         test randomly fail on Qt and EFL due to WTFLogAlways writing to stderr.
158
159         * loader/icon/IconLoader.cpp:
160         (WebCore::IconLoader::notifyFinished):
161
162 2013-04-25  Christophe Dumez  <ch.dumez@sisa.samsung.com>
163
164         Add support for Web IDL callback interfaces to the bindings generator
165         https://bugs.webkit.org/show_bug.cgi?id=115179
166
167         Reviewed by Kentaro Hara.
168
169         Add support in the bindings generator for Web IDL callback interfaces:
170         http://dev.w3.org/2006/webapi/WebIDL/#dfn-callback-interface
171
172         Drop support for the WebKit-specific [Callback] extended attributes
173         on Web IDL interfaces and update existing IDL files to use proper
174         callback interfaces instead.
175
176         No new tests, no behavior change.
177
178         * Modules/filesystem/EntriesCallback.idl:
179         * Modules/filesystem/EntryCallback.idl:
180         * Modules/filesystem/ErrorCallback.idl:
181         * Modules/filesystem/FileCallback.idl:
182         * Modules/filesystem/FileSystemCallback.idl:
183         * Modules/filesystem/FileWriterCallback.idl:
184         * Modules/filesystem/MetadataCallback.idl:
185         * Modules/geolocation/PositionCallback.idl:
186         * Modules/geolocation/PositionErrorCallback.idl:
187         * Modules/mediastream/NavigatorUserMediaErrorCallback.idl:
188         * Modules/mediastream/NavigatorUserMediaSuccessCallback.idl:
189         * Modules/mediastream/RTCErrorCallback.idl:
190         * Modules/mediastream/RTCSessionDescriptionCallback.idl:
191         * Modules/mediastream/RTCStatsCallback.idl:
192         * Modules/notifications/NotificationPermissionCallback.idl:
193         * Modules/quota/StorageErrorCallback.idl:
194         * Modules/quota/StorageQuotaCallback.idl:
195         * Modules/quota/StorageUsageCallback.idl:
196         * Modules/webaudio/AudioBufferCallback.idl:
197         * Modules/webdatabase/DatabaseCallback.idl:
198         * Modules/webdatabase/SQLStatementCallback.idl:
199         * Modules/webdatabase/SQLStatementErrorCallback.idl:
200         * Modules/webdatabase/SQLTransactionCallback.idl:
201         * Modules/webdatabase/SQLTransactionErrorCallback.idl:
202         * Modules/webdatabase/SQLTransactionSyncCallback.idl:
203         * bindings/scripts/CodeGeneratorJS.pm:
204         (GenerateInterface):
205         * bindings/scripts/IDLParser.pm:
206         (parseCallbackRestOrInterface):
207         * bindings/scripts/test/TestCallback.idl:
208         * dom/RequestAnimationFrameCallback.idl:
209         * dom/StringCallback.idl:
210         * html/VoidCallback.idl:
211
212 2013-04-25  Adrian Perez de Castro  <aperez@igalia.com>
213
214         [GStreamer] Add audio/speex MIME type as supported
215         https://bugs.webkit.org/show_bug.cgi?id=115032
216
217         Reviewed by Philippe Normand.
218
219         GStreamer has support for the Speex codec (http://www.speex.org).
220         Speex streams may be embedded in a Ogg container, or standalone.
221         The case of the Ogg container is already covered by the "*/ogg"
222         MIME types declared as supported by the GStreamer media playing
223         code, but for standalone streams to work, "audio/speex" has to
224         be added.
225
226         With this, and the needed GStreamer plugin installed, the GTK+
227         launcher is able to correctly play Speex streams served with
228         "Content-type: audio/speex".
229
230         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
231
232 2013-04-25  Andreas Kling  <akling@apple.com>
233
234         Add FINAL decorators to the InlineBox class hierarchy.
235         <http://webkit.org/b/115177>
236
237         Reviewed by Antti Koivisto.
238
239         From Blink r148628 by <cevans@chromium.org>:
240
241         FINAL is a macro in wtf/Compiler.h that does the correct thing if the compiler does not support "final")
242         The approach used is as simple as possible whilst being thorough.
243         So, leaf classes have FINAL applied to the whole class whereas intermediary classes have FINAL applied to relevant methods.
244
245         FINAL allows a compiler to devirtualize call sites and turn them into direct calls. As you might expect, this is perf positive:
246         (clang on Linux):
247         - line_layout.html goes from 120 runs/s -> 123 runs/2, +2.5%
248         - html5-full-render.html goes from 3176ms -> 3162ms, +0.4%
249
250         I have confidence that the former result is statistically significant (as the numbers are very very stable) but not the latter.
251
252         * rendering/EllipsisBox.h:
253         * rendering/InlineFlowBox.h:
254         * rendering/InlineTextBox.h:
255         * rendering/RootInlineBox.h:
256         * rendering/TrailingFloatsRootInlineBox.h:
257         * rendering/svg/SVGInlineFlowBox.h:
258         * rendering/svg/SVGInlineTextBox.h:
259         * rendering/svg/SVGRootInlineBox.h:
260
261 2013-04-25  Andreas Kling  <akling@apple.com>
262
263         CSS parser: Add error recovery while parsing @-webkit-keyframes key values.
264         <http://webkit.org/b/115175>
265
266         From Blink r148714 by <apavlov@chromium.org>:
267
268         If not a percentage, "from", or "to" value is used in a key list, the rule is erroneous,
269         and due to the absense of recovery, the parser skips the following, valid CSS rule.
270
271         On a related note, keyframes, whose selectors contain invalid keys, should be discarded
272         altogether, according to <http://www.w3.org/TR/css3-animations/#keyframes>
273
274         Tests: animations/keyframes-invalid-keys.html
275                fast/css/webkit-keyframes-errors.html
276
277         * css/CSSGrammar.y.in:
278         * css/CSSParser.cpp:
279         (WebCore::CSSParser::rewriteSpecifiers):
280
281 2013-04-25  Antti Koivisto  <antti@apple.com>
282
283         REGRESSION (r147797): Animations slideshows of images on www.thesuperficial.com are slow
284         https://bugs.webkit.org/show_bug.cgi?id=115172
285
286         Reviewed by Andreas Kling.
287
288         On this page ads dynamically loaded to subframes on slideshow navigation switch us to state where we throttle layer flushes.
289         
290         Fix by ignoring any subframe-originated loads when determining throttling.
291
292         * loader/FrameLoader.cpp:
293         (WebCore::FrameLoader::loadProgressingStatusChanged):
294         * loader/ProgressTracker.cpp:
295         (WebCore::ProgressTracker::isMainLoadProgressing):
296         
297             Rename, ignore subframe originated loads. Subframe loads that are initiated during the main load still count.
298
299         * loader/ProgressTracker.h:
300         (ProgressTracker):
301         * page/FrameView.cpp:
302         (WebCore::FrameView::updateLayerFlushThrottlingInAllFrames):
303         * page/FrameView.h:
304         (FrameView):
305         * rendering/RenderLayerBacking.cpp:
306         (WebCore::computeTileCoverage):
307
308 2013-04-25  Andreas Kling  <akling@apple.com>
309
310         SVG: Fix viewBox animations on shapes with non-scaling-stroke.
311         <http://webkit.org/b/115173>
312
313         From Blink r149058 by <pdr@chromium.org>:
314
315         Previously hasAttribute() to determine if a viewBox was set in the transform
316         code for non-scaling-strokes. hasAttribute() should not be used in this case,
317         as it will return false if the attribute is not set but the value is animating.
318
319         This patch switches to checking if the viewBox is empty instead of checking for
320         the presence of the attribute.
321
322         Test: svg/stroke/animated-non-scaling-stroke.html
323
324         * svg/SVGSVGElement.cpp:
325         (WebCore::SVGSVGElement::localCoordinateSpaceTransform):
326         * svg/SVGSVGElement.h:
327         (WebCore::SVGSVGElement::hasEmptyViewBox):
328
329 2013-04-25  Andreas Kling  <akling@apple.com>
330
331         Remove isPluginElement hack in Document::setFocusedNode()
332         <http://webkit.org/b/115171>
333
334         From Blink r148800 by <tkent@chromium.org>:
335
336         This hack is no longer necessary because r147591 made isFocusable for plugin
337         elements work correctly.
338
339         * dom/Document.cpp:
340         (WebCore::Document::setFocusedNode):
341
342 2013-04-25  Per-Erik Brodin  <per-erik.brodin@ericsson.com>
343
344         EventSource: Synchronous loader callback not handled properly
345         https://bugs.webkit.org/show_bug.cgi?id=115104
346
347         When attempting a cross-origin request towards a non-HTTP URL, an early verification
348         of the protocol scheme will cause didFailAccessControlCheck to be called synchronously
349         before the loader has even finished being created. This special case was not handled
350         properly, since we tried to cancel a non-existing loader, which resulted in a crash.
351         In addition to checking whether a request is in flight before trying to cancel it,
352         this change also schedules the initial creation of the loader to happen asynchronously
353         when an EventSource is constructed, so that a script can register for the error event
354         before it is dispatched (as a result of passing a non-HTTP URL to the constructor).
355
356         Reviewed by Alexey Proskuryakov.
357
358         Test: http/tests/eventsource/eventsource-cors-non-http.html
359
360         * page/EventSource.cpp:
361         (WebCore::EventSource::EventSource):
362         (WebCore::EventSource::create):
363         (WebCore::EventSource::scheduleInitialConnect):
364         (WebCore):
365         (WebCore::EventSource::scheduleReconnect):
366         (WebCore::EventSource::connectTimerFired):
367         (WebCore::EventSource::close):
368         (WebCore::EventSource::abortConnectionAttempt):
369         * page/EventSource.h:
370         (EventSource):
371
372 2013-04-25  Patrick Gansterer  <paroga@webkit.org>
373
374         Unreviewed WinCE build fix after r148545.
375
376         * page/wince/FrameWinCE.cpp:
377
378 2013-04-24  Kent Tamura  <tkent@chromium.org>
379
380         Back references don't work in pattern attribute
381         https://bugs.webkit.org/show_bug.cgi?id=105875
382
383         Reviewed by Geoffrey Garen.
384
385         This imports a part of Blink r148951.
386
387         Tests: Update fast/forms/ValidityState-patternMismatch.html
388
389         * html/BaseTextInputType.cpp:
390         (WebCore::BaseTextInputType::patternMismatch):
391         Don't use capturing parentheses. They affected back references in
392         pattern attribute values.
393
394 2013-04-24  Tim Horton  <timothy_horton@apple.com>
395
396         PDFPlugin: Cursor should become an i-beam when over selectable text
397         https://bugs.webkit.org/show_bug.cgi?id=115018
398         <rdar://problem/12645012>
399
400         Reviewed by Alexey Proskuryakov.
401
402         * WebCore.exp.in: Export the I-beam and arrow cursors.
403
404 2013-04-24  Simon Fraser  <simon.fraser@apple.com>
405
406         Garbage at the top of http://www.technologyreview.com after scrolling
407         https://bugs.webkit.org/show_bug.cgi?id=114825
408
409         Reviewed by Tim Horton.
410
411         Garbage pixels are caused by GraphicsLayerCA setting a layer to be opaque,
412         but then not painting anything into it. On this page, the element is
413         toggled to be visibility:hidden on scrolling, but RenderLayer::backgroundIsKnownToBeOpaqueInRect()
414         failed to consider that as something that can cause backgrounds not to be opaque.
415         
416         For the bug to happen, some subtle interactions with r142012 come into play
417         for the layer to remain visible, hence the slightly complex testcase.
418         
419         Test: compositing/contents-opaque/visibility-hidden.html
420
421         * rendering/RenderLayer.cpp:
422         (WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):
423
424 2013-04-24  Simon Fraser  <simon.fraser@apple.com>
425
426         Dump layer opaqueness in the Compositing log output
427         https://bugs.webkit.org/show_bug.cgi?id=115132
428
429         Reviewed by Tim Horton.
430
431         It's useful to see whether we consider layers to be opaque in the Compositing
432         log channel output, so dump it.
433
434         * rendering/RenderLayerCompositor.cpp:
435         (WebCore::RenderLayerCompositor::logLayerInfo):
436
437 2013-04-24  Seokju Kwon  <seokju.kwon@gmail.com>
438
439         Add efl to JSInspectorFrontendHost::port()
440         https://bugs.webkit.org/show_bug.cgi?id=115137
441
442         Reviewed by Timothy Hatcher.
443
444         No new tests, because there is no change in behavior.
445
446         * bindings/js/JSInspectorFrontendHostCustom.cpp:
447         (WebCore::JSInspectorFrontendHost::port):
448
449 2013-04-24  Kangil Han  <kangil.han@samsung.com>
450
451         Function parameter quotePair can be passed by reference
452         https://bugs.webkit.org/show_bug.cgi?id=115089
453
454         Reviewed by Alexey Proskuryakov.
455
456         Minor performance patch.
457
458         * rendering/style/QuotesData.cpp:
459         (WebCore::QuotesData::addPair):
460         * rendering/style/QuotesData.h:
461         (QuotesData):
462
463 2013-04-24  Brady Eidson  <beidson@apple.com>
464
465         Implementors of CachedResource subclasses should be forced to decide if encoded data can be replaced.
466         https://bugs.webkit.org/show_bug.cgi?id=115140
467
468         Reviewed by Beth Dakin.
469
470         No new tests (No behavior change).
471
472         This makes mayTryReplaceEncodedData() return false in CachedResource, but overrides to true
473         in all CachedResource subclasses besides CachedFont (which already has an implementation).
474
475         * loader/cache/CachedCSSStyleSheet.h:
476         * loader/cache/CachedImage.h:
477         * loader/cache/CachedRawResource.h:
478         * loader/cache/CachedResource.h:
479         * loader/cache/CachedSVGDocument.h:
480         * loader/cache/CachedScript.h:
481         * loader/cache/CachedShader.h:
482         * loader/cache/CachedTextTrack.h:
483         * loader/cache/CachedXSLStyleSheet.h:
484
485 2013-04-24  Brady Eidson  <beidson@apple.com>
486
487         Once a custom font is cached to disk, it starts failing to render until the page is refreshed.
488         <rdar://problem/13622998> and https://bugs.webkit.org/show_bug.cgi?id=115131
489
490         Reviewed by Alexey Proskuryakov.
491
492         No new tests (Not a tested config, nor are disk cache issues currently testable).
493
494         * loader/cache/CachedResource.h:
495         (WebCore::CachedResource:: mayTryReplaceEncodedData): Allow subclasses to refuse encoded data replacement.
496
497         * loader/cache/CachedResource.cpp:
498         (WebCore::CachedResource::tryReplaceEncodedData): Only try if shouldTryReplaceEncodedData() is true.
499
500         * loader/cache/CachedFont.cpp:
501         (WebCore::CachedFont::CachedFont):
502         (WebCore::CachedFont::ensureCustomFontData):
503         (WebCore::CachedFont::mayTryReplaceEncodedData): Return false if the custom font data has ever been created.
504         * loader/cache/CachedFont.h:
505
506 2013-04-24  Beth Dakin  <bdakin@apple.com>
507
508         Vertical overlay scrollbar in iframes fades in and out rapidly when you scroll in 
509         a circle
510         https://bugs.webkit.org/show_bug.cgi?id=115124
511         -and corresponding-
512         <rdar://problem/13168957>
513
514         Reviewed by Anders Carlsson.
515
516         With http://trac.webkit.org/changeset/119834 we started calling 
517         ScrollbarPainterController's contentAreaScrolled/contentAreaScrolledInDirection 
518         API on a zero-delay timer instead of calling it right away. This prevented some 
519         crashes that we saw whenever this was called during a layout. However, that delay, 
520         combined with the particulars of contentAreaScrolledInDirection cause this bug 
521         where sometimes the scrollbars in an iframe will fade out very noticeably when 
522         scrolling in a circle.
523
524         This change makes it so we will only use the zero-delay timer if the 
525         ScrollableArea is not currently handling a wheel event. If it IS handling a wheel 
526         event, then we will send the notifications to AppKit right away. I confirmed that 
527         this change did not reintroduce the old crashes. 
528
529         Keep track of whether we are currently handling a wheel event with the new member 
530         variable m_isHandlingWheelEvent.
531         * page/EventHandler.cpp:
532         (WebCore::EventHandler::EventHandler):
533         (WebCore::EventHandler::handleWheelEvent):
534         * page/EventHandler.h:
535         (WebCore::EventHandler::isHandlingWheelEvent):
536         (EventHandler):
537
538         To prevent layering violations, the ScrollableArea sub-classes will have to access 
539         this information from the EventHandler.
540         * page/FrameView.cpp:
541         (WebCore::FrameView::isHandlingWheelEvent):
542         * page/FrameView.h:
543         * platform/ScrollableArea.h:
544         (WebCore::ScrollableArea::isHandlingWheelEvent):
545         * rendering/RenderLayer.cpp:
546         (WebCore::RenderLayer::isHandlingWheelEvent):
547         * rendering/RenderLayer.h:
548         (RenderLayer):
549         * rendering/RenderListBox.cpp:
550         (WebCore::RenderListBox::isHandlingWheelEvent):
551         * rendering/RenderListBox.h:
552
553         sendContentAreaScrolledSoon() can be private. Also add new function 
554         sendContentAreaScrolled().
555         * platform/mac/ScrollAnimatorMac.h:
556         (ScrollAnimatorMac):
557
558         If the ScrollableArea is handling a wheel event, call 
559         sendContentAreaScrolled(), otherwise call sendContentAreaScrolledSoon()
560         * platform/mac/ScrollAnimatorMac.mm:
561         (WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
562         (WebCore::ScrollAnimatorMac::sendContentAreaScrolled):
563
564         Re-factored to use sendContentAreaScrolled()
565         (WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):
566
567 2013-04-24  Ryosuke Niwa  <rniwa@webkit.org>
568
569         Fix a merge error in r149007 (was missing a null check added in r148777).
570
571         * rendering/LogicalSelectionOffsetCaches.h:
572         (WebCore::containingBlockForAbsolutePosition):
573
574 2013-04-24  Otto Derek Cheung  <otcheung@rim.com>
575
576         Battery API won't return updated battery status until client calls didChangeBatteryStatus
577         https://bugs.webkit.org/show_bug.cgi?id=114891
578
579         Reviewed by Rob Buis.
580
581         The BatteryStatus object in BatteryManager won't get updated until BatteryClient calls
582         didChangeBatteryStatus in BatteryController. Any attempts to call webkitBattery.charged()
583         or other get functions will always return the default values until the next battery status
584         change object gets passed to the controller.
585
586         We need to update the manager when we attach it to the controller, and update all
587         existing managers when the controller receives it's first battery status object.
588
589         * Modules/battery/BatteryController.cpp:
590         (WebCore::BatteryController::addListener):
591         (WebCore::BatteryController::updateBatteryStatus):
592         * Modules/battery/BatteryManager.cpp:
593         (WebCore::BatteryManager::didChangeBatteryStatus):
594         (WebCore::BatteryManager::updateBatteryStatus):
595         (WebCore):
596         * Modules/battery/BatteryManager.h:
597         (BatteryManager):
598
599 2013-04-24  Jacky Jiang  <zhajiang@blackberry.com>
600
601         Clean up unused code in ViewportArguments.h
602         https://bugs.webkit.org/show_bug.cgi?id=115121
603
604         Reviewed by Benjamin Poulain.
605
606         The target-densityDPI emulation implementation has been removed by
607         r147893, so clean up the remaining code as well.
608
609         * dom/ViewportArguments.h:
610
611 2013-04-24  Andreas Kling  <akling@apple.com>
612
613         ElementData should use 'unsigned' attribute indices.
614         <http://webkit.org/b/115103>
615
616         Reviewed by Antti Koivisto.
617
618         Switch to using 'unsigned' for attribute indices. This gives consistent behavior
619         on 32/64-bit, and the underlying storage is already limited by Vector's 32-bit capacity.
620
621         Added an ElementData::attributeNotFound constant (-1) since we can't use WTF::notFound.
622
623         * dom/Element.cpp:
624         (WebCore::Element::detachAttribute):
625         (WebCore::Element::removeAttribute):
626         (WebCore::Element::setAttribute):
627         (WebCore::Element::setSynchronizedLazyAttribute):
628         (WebCore::Element::setAttributeInternal):
629         (WebCore::Element::setAttributeNode):
630         (WebCore::Element::removeAttributeNode):
631         (WebCore::Element::removeAttributeInternal):
632         (WebCore::UniqueElementData::removeAttribute):
633         (WebCore::ElementData::getAttributeItemIndexSlowCase):
634         * dom/Element.h:
635         (ElementData):
636         (UniqueElementData):
637         (Element):
638         (WebCore::Element::getAttributeItemIndex):
639         (WebCore::Element::attributeCount):
640         (WebCore::ElementData::length):
641         (WebCore::ElementData::getAttributeItem):
642         (WebCore::ElementData::getAttributeItemIndex):
643         * dom/NamedNodeMap.cpp:
644         (WebCore::NamedNodeMap::removeNamedItem):
645         (WebCore::NamedNodeMap::removeNamedItemNS):
646         (WebCore::NamedNodeMap::length):
647         * dom/NamedNodeMap.h:
648         (NamedNodeMap):
649
650 2013-04-24  Andreas Kling  <akling@apple.com>
651
652         ElementData::attributeItem() should bounds-check the index.
653         <http://webkit.org/b/115076>
654
655         Reviewed by Antti Koivisto.
656
657         Switch the ASSERT_WITH_SECURITY_IMPLICATION to a RELEASE_ASSERT.
658
659         * dom/Element.h:
660         (WebCore::ElementData::attributeItem):
661
662 2013-04-23  Andreas Kling  <akling@apple.com>
663
664         Setting an inline style property to "" shouldn't cause style recalc unless the property was present.
665         <http://webkit.org/b/115122>
666
667         Reviewed by Antti Koivisto.
668
669         StylePropertySet::setProperty() handles empty strings by removing the property entirely.
670         If there was no property to remove, it shouldn't claim that it changed something, as that
671         will cause the CSSOM wrapper to mark the element for style recalc.
672
673         A common idiom that triggers this is excessive use of { element.style.display = ''; }
674
675         * css/StylePropertySet.cpp:
676         (WebCore::MutableStylePropertySet::setProperty):
677
678 2013-04-23  Ryosuke Niwa  <rniwa@webkit.org>
679
680         Moving word boundaries backwards fails when there is a text node starting with an apostrophe
681         https://bugs.webkit.org/show_bug.cgi?id=115070
682
683         Reviewed by Alexey Proskuryakov.
684
685         The bug was caused by previousBoundary erroneously assuming that we don't need any more context if a word
686         boundary is found at the beginning of a string. For example, when "I'll" is split into two text nodes,
687         "I" and "'ll", there is a word boundary between "'" and "ll" in "'ll" so we need to examine the whole "I'll".
688
689         Fixed the bug by obtaining more context when the character starts exactly at offset 1 in a text node to
690         work around this bug. In the long term, we probably need to provide Foundation of the entire context since in
691         languages like Hebrew and some of European languages, there could be many accents and combining characters
692         between split into multiple text nodes as one variant is seen in the newly added test case.
693
694         Test: editing/selection/previous-word-boundary-across-text-nodes.html
695
696         * editing/VisibleUnits.cpp:
697         (WebCore::previousBoundary):
698
699 2013-04-24  Benjamin Poulain  <bpoulain@apple.com>
700
701         Do not use static string in DiagnosticLoggingKeys
702         https://bugs.webkit.org/show_bug.cgi?id=115093
703
704         Reviewed by Andreas Kling.
705
706         The code is not hot enough to justify keeping the memory around.
707         This removes 3kb from the binary on x86_64.
708
709         * page/DiagnosticLoggingKeys.cpp:
710         (WebCore::DiagnosticLoggingKeys::mediaLoadedKey):
711         (WebCore::DiagnosticLoggingKeys::mediaLoadingFailedKey):
712         (WebCore::DiagnosticLoggingKeys::pluginLoadedKey):
713         (WebCore::DiagnosticLoggingKeys::pluginLoadingFailedKey):
714         (WebCore::DiagnosticLoggingKeys::pageContainsPluginKey):
715         (WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOnePluginKey):
716         (WebCore::DiagnosticLoggingKeys::pageContainsMediaEngineKey):
717         (WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOneMediaEngineKey):
718         (WebCore::DiagnosticLoggingKeys::passKey):
719         (WebCore::DiagnosticLoggingKeys::failKey):
720         (WebCore::DiagnosticLoggingKeys::noopKey):
721         * page/DiagnosticLoggingKeys.h:
722         (DiagnosticLoggingKeys):
723
724 2013-04-24  Benjamin Poulain  <benjamin@webkit.org>
725
726         Remove wxWebKit #ifdefs from WebCore/platform/graphics
727         https://bugs.webkit.org/show_bug.cgi?id=115081
728
729         Reviewed by Geoffrey Garen.
730
731         * platform/graphics/BitmapImage.h:
732         (BitmapImage):
733         * platform/graphics/Color.h:
734         (Color):
735         * platform/graphics/FloatRect.h:
736         (FloatRect):
737         * platform/graphics/FloatSize.h:
738         (FloatSize):
739         * platform/graphics/FontPlatformData.h:
740         * platform/graphics/GlyphBuffer.h:
741         (WebCore):
742         (WebCore::GlyphBuffer::glyphAt):
743         (WebCore::GlyphBuffer::add):
744         * platform/graphics/Gradient.h:
745         * platform/graphics/GraphicsContext.h:
746         (GraphicsContext):
747         * platform/graphics/Image.cpp:
748         (WebCore::Image::drawTiled):
749         * platform/graphics/ImageBufferData.h:
750         * platform/graphics/IntPoint.h:
751         (IntPoint):
752         * platform/graphics/IntRect.h:
753         * platform/graphics/IntSize.h:
754         (IntSize):
755         * platform/graphics/NativeImagePtr.h:
756         (WebCore):
757         * platform/graphics/Path.h:
758         * platform/graphics/Pattern.h:
759         * platform/graphics/SimpleFontData.h:
760         (SimpleFontData):
761         (WebCore::SimpleFontData::widthForGlyph):
762         * platform/graphics/mac/ComplexTextController.cpp:
763         (WebCore::ComplexTextController::collectComplexTextRuns):
764         * platform/graphics/mac/ComplexTextControllerCoreText.mm:
765         (WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
766         * platform/graphics/transforms/AffineTransform.h:
767         (AffineTransform):
768         * platform/graphics/transforms/TransformationMatrix.h:
769         (TransformationMatrix):
770
771 2013-04-24  Benjamin Poulain  <benjamin@webkit.org>
772
773         Remove wxWebKit #ifdefs from WebCore/plugins
774         https://bugs.webkit.org/show_bug.cgi?id=115080
775
776         Reviewed by Geoffrey Garen.
777
778         * plugins/PluginView.h:
779         (PluginView):
780         * plugins/mac/PluginViewMac.mm:
781         (WebCore::nativeWindowFor):
782         (WebCore::cgHandleFor):
783         (WebCore::topLevelOffsetFor):
784         (WebCore::PluginView::platformStart):
785         * plugins/win/PluginViewWin.cpp:
786         (windowHandleForPageClient):
787         (WebCore::PluginView::handleMouseEvent):
788         (WebCore::PluginView::platformStart):
789         (WebCore::PluginView::snapshot):
790
791 2013-04-24  Benjamin Poulain  <benjamin@webkit.org>
792
793         Remove wxWebKit #ifdefs from WebCore/page
794         https://bugs.webkit.org/show_bug.cgi?id=115079
795
796         Reviewed by Geoffrey Garen.
797
798         * page/FrameView.cpp:
799         (WebCore::FrameView::wheelEvent):
800         * page/Settings.cpp:
801         (WebCore):
802         * page/Settings.h:
803         (Settings):
804
805 2013-04-24  Chris Fleizach  <cfleizach@apple.com>
806
807         AX: WAI-ARIA landmarks no longer speak type of landmark on iOS
808         https://bugs.webkit.org/show_bug.cgi?id=114547
809
810         Reviewed by David Kilzer.
811
812         We want iOS to speak the landmark type.
813         I've moved the landmark role description to the base Mac class and exposed
814         these localized strings to iOS (the ones used to return landmark descriptions).
815
816         I've also updated the accessibilityLabel to account for landmark type, but also
817         handle multiple label sources more gracefully by appending commas, which changed a few
818         tests in minor ways.
819
820         Test: platform/iphone-simulator/accessibility/landmark-type.html
821
822         * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
823         (-[WebAccessibilityObjectWrapper accessibilityLabel]):
824         * accessibility/mac/WebAccessibilityObjectWrapperBase.h:
825         * accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
826         (-[WebAccessibilityObjectWrapperBase ariaLandmarkRoleDescription]):
827         * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
828         (-[WebAccessibilityObjectWrapper roleDescription]):
829         * platform/LocalizedStrings.cpp:
830         (WebCore):
831         (WebCore::AXButtonActionVerb):
832         (WebCore::AXRadioButtonActionVerb):
833         (WebCore::AXTextFieldActionVerb):
834         (WebCore::AXCheckedCheckBoxActionVerb):
835         (WebCore::AXUncheckedCheckBoxActionVerb):
836         (WebCore::AXLinkActionVerb):
837         (WebCore::AXMenuListPopupActionVerb):
838         (WebCore::AXMenuListActionVerb):
839         * platform/LocalizedStrings.h:
840         (WebCore):
841
842 2013-04-24  Andreas Kling  <akling@apple.com>
843
844         CSS attribute selectors cause unnecessary style recalc when setting attribute to same value.
845         <http://webkit.org/b/115116>
846         <rdar://problem/13727709>
847
848         Reviewed by Simon Fraser.
849
850         The logic that dirties the style if there's a relevant attribute selector in the document
851         shouldn't run if the attribute is being overwritten with an identical value.
852         Move this into willModifyAttribute() instead, since we need access to both the old and the new value.
853
854         This reduces unnecessary style recalculation in Mac App Store content.
855
856         * dom/Element.cpp:
857         (WebCore::Element::attributeChanged):
858         (WebCore::Element::willModifyAttribute):
859
860 2013-04-24  Jonathan Feldstein <jfeldstein@blackberry.com>
861
862         [BlackBerry] Fixes the San Angeles demo on khronos.org
863         https://bugs.webkit.org/show_bug.cgi?id=115106
864
865         Reviewed by Rob Buis
866         Internally Reviewed by Jeremy Nicholl and Arvid Nilsson
867
868         Fixes a bug in which the currently bound vertex array object's vertex array
869         state was being modified as opposed to the default vertex array state.
870
871         * platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:
872         (EGLImageLayerWebKitThread::blitToFrontBuffer):
873
874 2013-04-24  Nico Weber  <thakis@chromium.org>
875
876         Fold RenderThemeMacShared into RenderThemeMac
877         https://bugs.webkit.org/show_bug.cgi?id=115086
878
879         Reviewed by Anders Carlsson.
880
881         No intended functionality change.
882
883         * WebCore.xcodeproj/project.pbxproj:
884         * rendering/RenderThemeMac.h:
885         (RenderThemeMac):
886         (WebCore::RenderThemeMac::supportsControlTints):
887         (WebCore::RenderThemeMac::scrollbarControlSizeForPart):
888         (WebCore::RenderThemeMac::supportsSelectionForegroundColors):
889         (WebCore::RenderThemeMac::supportsClosedCaptioning):
890         (WebCore::RenderThemeMac::updateActiveState):
891         * rendering/RenderThemeMac.mm:
892         (-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
893         (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]):
894         (-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:]):
895         (WebCore::RenderThemeMac::RenderThemeMac):
896         (WebCore::RenderThemeMac::~RenderThemeMac):
897         (WebCore::RenderThemeMac::platformActiveSelectionBackgroundColor):
898         (WebCore):
899         (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor):
900         (WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor):
901         (WebCore::RenderThemeMac::platformActiveListBoxSelectionForegroundColor):
902         (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor):
903         (WebCore::RenderThemeMac::platformFocusRingColor):
904         (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):
905         (WebCore::toFontWeight):
906         (WebCore::RenderThemeMac::systemFont):
907         (WebCore::convertNSColorToColor):
908         (WebCore::menuBackgroundColor):
909         (WebCore::RenderThemeMac::platformColorsDidChange):
910         (WebCore::RenderThemeMac::systemColor):
911         (WebCore::RenderThemeMac::usesTestModeFocusRingColor):
912         (WebCore::RenderThemeMac::isControlStyled):
913         (WebCore::RenderThemeMac::adjustRepaintRect):
914         (WebCore::RenderThemeMac::inflateRect):
915         (WebCore::RenderThemeMac::convertToPaintingRect):
916         (WebCore::RenderThemeMac::updateCheckedState):
917         (WebCore::RenderThemeMac::updateEnabledState):
918         (WebCore::RenderThemeMac::updateFocusedState):
919         (WebCore::RenderThemeMac::updatePressedState):
920         (WebCore::RenderThemeMac::controlSupportsTints):
921         (WebCore::RenderThemeMac::controlSizeForFont):
922         (WebCore::RenderThemeMac::setControlSize):
923         (WebCore::RenderThemeMac::sizeForFont):
924         (WebCore::RenderThemeMac::sizeForSystemFont):
925         (WebCore::RenderThemeMac::setSizeFromFont):
926         (WebCore::RenderThemeMac::setFontFromControlSize):
927         (WebCore::RenderThemeMac::controlSizeForSystemFont):
928         (WebCore::RenderThemeMac::paintTextField):
929         (WebCore::RenderThemeMac::adjustTextFieldStyle):
930         (WebCore::RenderThemeMac::paintCapsLockIndicator):
931         (WebCore::RenderThemeMac::paintTextArea):
932         (WebCore::RenderThemeMac::adjustTextAreaStyle):
933         (WebCore::RenderThemeMac::popupButtonMargins):
934         (WebCore::RenderThemeMac::popupButtonSizes):
935         (WebCore::RenderThemeMac::popupButtonPadding):
936         (WebCore::RenderThemeMac::paintMenuList):
937         (WebCore::RenderThemeMac::meterSizeForBounds):
938         (WebCore::RenderThemeMac::paintMeter):
939         (WebCore::RenderThemeMac::supportsMeter):
940         (WebCore::RenderThemeMac::levelIndicatorStyleFor):
941         (WebCore::RenderThemeMac::levelIndicatorFor):
942         (WebCore::RenderThemeMac::progressBarSizes):
943         (WebCore::RenderThemeMac::progressBarMargins):
944         (WebCore::RenderThemeMac::minimumProgressBarHeight):
945         (WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar):
946         (WebCore::RenderThemeMac::animationDurationForProgressBar):
947         (WebCore::RenderThemeMac::adjustProgressBarStyle):
948         (WebCore::RenderThemeMac::paintProgressBar):
949         (WebCore::TopGradientInterpolate):
950         (WebCore::BottomGradientInterpolate):
951         (WebCore::MainGradientInterpolate):
952         (WebCore::TrackGradientInterpolate):
953         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
954         (WebCore::RenderThemeMac::paintMenuListButton):
955         (WebCore::menuListButtonSizes):
956         (WebCore::RenderThemeMac::adjustMenuListStyle):
957         (WebCore::RenderThemeMac::popupInternalPaddingLeft):
958         (WebCore::RenderThemeMac::popupInternalPaddingRight):
959         (WebCore::RenderThemeMac::popupInternalPaddingTop):
960         (WebCore::RenderThemeMac::popupInternalPaddingBottom):
961         (WebCore::RenderThemeMac::adjustMenuListButtonStyle):
962         (WebCore::RenderThemeMac::setPopupButtonCellState):
963         (WebCore::RenderThemeMac::menuListSizes):
964         (WebCore::RenderThemeMac::minimumMenuListSize):
965         (WebCore::RenderThemeMac::adjustSliderTrackStyle):
966         (WebCore::RenderThemeMac::paintSliderTrack):
967         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
968         (WebCore::RenderThemeMac::paintSliderThumb):
969         (WebCore::RenderThemeMac::paintSearchField):
970         (WebCore::RenderThemeMac::setSearchCellState):
971         (WebCore::RenderThemeMac::searchFieldSizes):
972         (WebCore::RenderThemeMac::setSearchFieldSize):
973         (WebCore::RenderThemeMac::adjustSearchFieldStyle):
974         (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
975         (WebCore::RenderThemeMac::cancelButtonSizes):
976         (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
977         (WebCore::RenderThemeMac::resultsButtonSizes):
978         (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
979         (WebCore::RenderThemeMac::paintSearchFieldDecoration):
980         (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
981         (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
982         (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
983         (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
984         (WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):
985         (WebCore::RenderThemeMac::sliderTickSize):
986         (WebCore::RenderThemeMac::sliderTickOffsetFromTrackCenter):
987         (WebCore::RenderThemeMac::adjustSliderThumbSize):
988         (WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):
989         (WebCore::RenderThemeMac::popupButton):
990         (WebCore::RenderThemeMac::search):
991         (WebCore::RenderThemeMac::searchMenuTemplate):
992         (WebCore::RenderThemeMac::sliderThumbHorizontal):
993         (WebCore::RenderThemeMac::sliderThumbVertical):
994         (WebCore::RenderThemeMac::textField):
995         (WebCore::RenderThemeMac::fileListNameForWidth):
996         * rendering/RenderThemeMacShared.h: Removed.
997         * rendering/RenderThemeMacShared.mm: Removed.
998
999 2013-04-24  ChangSeok Oh  <changseok.oh@collabora.com>
1000
1001         [GTK][AC] Visible rect doesn't update after resizing a window.
1002         https://bugs.webkit.org/show_bug.cgi?id=115096
1003
1004         Reviewed by Gustavo Noronha Silva.
1005
1006         Once we set actor's a clip rect, we should update the rect when resizing the actor.
1007
1008         No new tests since no new functionality.
1009
1010         * platform/graphics/clutter/GraphicsLayerClutter.cpp:
1011         (WebCore::GraphicsLayerClutter::setSize):
1012
1013 2013-04-24  ChangSeok Oh  <changseok.oh@collabora.com>
1014
1015         [GTK][AC] Fix unexpected clear of ClutterContent.
1016         https://bugs.webkit.org/show_bug.cgi?id=115099
1017
1018         Reviewed by Gustavo Noronha Silva.
1019
1020         adoptGRef doesn't increase a reference count. So if a actor has a valid ClutterContent,
1021         it would be cleared unexpectedly by smart pointer when escaping a function.
1022
1023         No new tests, no functionality changed.
1024
1025         * platform/graphics/clutter/GraphicsLayerActor.cpp:
1026         (graphicsLayerActorUpdateTexture):
1027
1028 2013-04-24  Alberto Garcia  <agarcia@igalia.com>
1029
1030         DOMFileSystemBase: fix multiple definitions in the BlackBerry port
1031         https://bugs.webkit.org/show_bug.cgi?id=114950
1032
1033         Reviewed by Xan Lopez.
1034
1035         The following  methods are already defined in DOMFileSystemBlackBerry.cpp:
1036
1037         crackFileSystemURL()
1038         createFileSystemURL()
1039         isValidType()
1040         supportsToURL()
1041
1042         * Modules/filesystem/DOMFileSystemBase.cpp:
1043         (WebCore):
1044
1045 2013-04-24  George Staikos  <gstaikos@rim.com>
1046
1047         [BlackBerry] Add support for JPEG image quality during encoding.
1048         https://bugs.webkit.org/show_bug.cgi?id=105773
1049
1050         Reviewed by Xan Lopez.
1051
1052         PR 271611
1053         Internally reviewed by Liam Quinn.
1054
1055         Pass the quality flag into the encoder, with a default of 65
1056
1057         Covered by existing tests.
1058
1059         * platform/image-encoders/JPEGImageEncoder.cpp:
1060         (WebCore::compressRGBABigEndianToJPEG):
1061         * platform/image-encoders/JPEGImageEncoder.h:
1062         (WebCore):
1063
1064 2013-04-24  Csaba Osztrogon√°c  <ossy@webkit.org>
1065
1066         Fix cast-align WebCore/platform/graphics/GraphicsContext3D.cpp on ARM
1067         https://bugs.webkit.org/show_bug.cgi?id=115036
1068
1069         Reviewed by Benjamin Poulain.
1070
1071         * platform/graphics/GraphicsContext3D.cpp:
1072         (WebCore):
1073
1074 2013-04-24  Andreas Kling  <akling@apple.com>
1075
1076         Remove unnecessary MutableStylePropertySet casts.
1077         <http://webkit.org/b/115075>
1078
1079         Reviewed by Geoffrey Garen.
1080
1081         Get rid of some now-unneeded static_casts that were left from the StylePropertySet
1082         refactoring last weekend.
1083
1084         * css/StylePropertySet.cpp:
1085         (WebCore::MutableStylePropertySet::setProperty):
1086         * editing/EditingStyle.cpp:
1087         (WebCore::EditingStyle::triStateOfStyle):
1088         (WebCore::EditingStyle::removeStyleFromRulesAndContext):
1089
1090 2013-04-24  Kangil Han  <kangil.han@samsung.com>
1091
1092         [Minor code cleanup] Remove duplicated condition check
1093         https://bugs.webkit.org/show_bug.cgi?id=115082
1094
1095         Reviewed by Andreas Kling.
1096
1097         areRectsPartiallyAligned() has duplicated condition check, so remove it.
1098
1099         * page/SpatialNavigation.cpp:
1100         (WebCore::areRectsPartiallyAligned):
1101
1102 2013-04-24  Krzysztof Wolanski  <k.wolanski@samsung.com>
1103
1104         [EFL] Fix build warnings caused by missing images attributes for default buttons
1105         https://bugs.webkit.org/show_bug.cgi?id=114955
1106
1107         Reviewed by Gyuyoung Kim.
1108
1109         Added default image for each button from mediacontrol catalog.
1110
1111         No new tests, because there is no change in behavior.
1112
1113         * platform/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc:
1114         * platform/efl/DefaultTheme/widget/mediacontrol/mutebutton/mute_button.edc:
1115         * platform/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playpause_button.edc:
1116         * platform/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackward_button.edc:
1117         * platform/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforward_button.edc:
1118         * platform/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/toggle_captions_button.edc:
1119
1120 2013-04-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1121
1122         Unreviewed build fix with gstreamer 0.10.x after r147555.
1123
1124         * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
1125         (webKitWebAudioSrcLoop):
1126
1127 == Rolled over to ChangeLog-2013-04-24 ==