1 2011-11-22 Adam Klein <adamk@chromium.org>
3 Move splitView.css (added in r100991) to the correct target.
7 2011-11-22 Andreas Kling <kling@webkit.org>
9 CSSProperty: Remove unnecessary operator overloads.
10 <http://webkit.org/b/72953>
12 Reviewed by Antti Koivisto.
14 * css/CSSProperty.cpp:
17 Remove operator= and operator== from CSSProperty. They were neither
18 implemented correctly nor used anywhere.
20 2011-11-22 Andreas Kling <kling@webkit.org>
22 CSSStyleDeclaration: Kill FIXME in setProperty().
23 <http://webkit.org/b/72958>
25 Reviewed by Antonio Gomes.
27 Remove FIXME about possibly throwing an exception when setProperty()
28 is called with an invalid property name. CSSOM specifies that the
29 method should simply return in this case.
31 Spec: http://dev.w3.org/csswg/cssom/#dom-cssstyledeclaration-setproperty
33 * css/CSSStyleDeclaration.cpp:
34 (WebCore::CSSStyleDeclaration::setProperty):
36 2011-11-22 Shinya Kawanaka <shinyak@google.com>
38 Spellcheck should be able to run asynchronously.
39 https://bugs.webkit.org/show_bug.cgi?id=71991
41 Reviewed by Hajime Morita.
43 Run asynchronous spell checker if both asynchronous flag and unified text checker flag are ON.
45 When multiple asynchronous spellchecking are requested, only the first request will be processed.
47 Test: editing/spelling/spellcheck-async.html
50 (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
51 Uses asynchronous spell checker if asynchronous flag is ON.
53 2011-11-22 Alexander Pavlov <apavlov@chromium.org>
55 Web Inspector: [SuggestBox] Grayed prompt displayed with non-collapsed selection in place
56 https://bugs.webkit.org/show_bug.cgi?id=72951
58 Reviewed by Pavel Feldman.
60 * inspector/front-end/TextPrompt.js:
61 (WebInspector.TextPrompt.prototype.complete):
63 2011-11-22 Pavel Feldman <pfeldman@google.com>
65 Not reviewed: fix inspector front-end compilation.
67 * inspector/front-end/externs.js:
68 (WebInspector.showPanel):
70 2011-11-22 Adam Bergkvist <adam.bergkvist@ericsson.com>
72 Add WebCore platform interface needed by updated MediaStream API design
73 https://bugs.webkit.org/show_bug.cgi?id=70895
75 Reviewed by Adam Barth.
77 This is one in a series of patches that update the MediaStream feature
78 to use WebCore platform interfaces.
80 Tests will be provided by http://webkit.org/b/56587
82 * GNUmakefile.list.am:
84 * mediastream/LocalMediaStream.cpp:
85 (WebCore::LocalMediaStream::stopTimerFired):
86 * mediastream/MediaStream.h:
87 * mediastream/MediaStreamTrack.cpp:
88 (WebCore::MediaStreamTrack::setEnabled):
89 * mediastream/PeerConnection.cpp:
90 (WebCore::PeerConnection::didRemoveRemoteStream):
91 * mediastream/UserMediaRequest.cpp:
92 (WebCore::UserMediaRequest::start):
93 * mediastream/UserMediaRequest.h:
94 * platform/mediastream/MediaStreamCenter.cpp: Added.
95 (WebCore::MediaStreamCenter::instance):
96 (WebCore::MediaStreamCenter::endLocalMediaStream):
97 (WebCore::MediaStreamCenter::MediaStreamCenter):
98 (WebCore::MediaStreamCenter::~MediaStreamCenter):
99 (WebCore::MediaStreamCenter::queryMediaStreamSources):
100 (WebCore::MediaStreamCenter::didSetMediaStreamTrackEnabled):
101 (WebCore::MediaStreamCenter::didStopLocalMediaStream):
102 * platform/mediastream/MediaStreamCenter.h: Added.
103 (WebCore::MediaStreamSourcesQueryClient::~MediaStreamSourcesQueryClient):
104 * platform/mediastream/MediaStreamDescriptor.h:
105 (WebCore::MediaStreamDescriptorOwner::~MediaStreamDescriptorOwner):
106 (WebCore::MediaStreamDescriptor::owner):
107 (WebCore::MediaStreamDescriptor::setOwner):
109 2011-11-22 Pavel Feldman <pfeldman@google.com>
111 Web Inspector: remove Inspector::bringToFront from the protocol.
112 https://bugs.webkit.org/show_bug.cgi?id=72937
114 Inspector::bringToFront protocol method is currently used on the backend
115 in order to reveal the front-end window. We should do that by means of
116 the inspector client interface instead.
118 Reviewed by Yury Semikhatsky.
120 * inspector/Inspector.json:
121 * inspector/InspectorClient.h:
122 * inspector/InspectorController.cpp:
123 (WebCore::InspectorController::show):
124 * loader/EmptyClients.h:
125 (WebCore::EmptyInspectorClient::bringFrontendToFront):
127 2011-11-21 Andrey Kosyakov <caseq@chromium.org>
129 Web Inspector: [Extensions API][refactoring] remove dependencies on the ExtensionsServer from most of the insepctor
130 https://bugs.webkit.org/show_bug.cgi?id=72899
132 Reviewed by Pavel Feldman.
134 * inspector/front-end/ElementsPanel.js:
135 (WebInspector.ElementsPanel.prototype._selectedNodeChanged):
136 * inspector/front-end/ExtensionServer.js:
137 (WebInspector.ExtensionServer.prototype._notifyResourceContentCommitted):
138 (WebInspector.ExtensionServer.prototype._notifyElementsSelectionChanged):
139 * inspector/front-end/Resource.js:
140 (WebInspector.Resource.prototype.addRevision):
141 * inspector/front-end/externs.js:
143 2011-11-22 Zoltan Horvath <zoltan@webkit.org>
145 [Qt] Build fix for MHTML support
147 * Target.pri: Add missing includepath.
149 2011-11-22 Vsevolod Vlasov <vsevik@chromium.org>
151 Web Inspector: Extract SplitView from Panel.createSidebar() method and reuse in Elements and Scripts panels.
152 https://bugs.webkit.org/show_bug.cgi?id=72920
154 Reviewed by Pavel Feldman.
157 * WebCore.vcproj/WebCore.vcproj:
158 * inspector/compile-front-end.sh:
159 * inspector/front-end/ApplicationCacheModel.js:
160 * inspector/front-end/AuditsPanel.js:
161 (WebInspector.AuditsPanel):
162 * inspector/front-end/ElementsPanel.js:
163 (WebInspector.ElementsPanel):
164 (WebInspector.ElementsPanel.prototype.wasShown):
165 (WebInspector.ElementsPanel.prototype.sidebarResized):
166 (WebInspector.ElementsPanel.prototype.toggleSearchingForNode):
167 * inspector/front-end/NetworkPanel.js:
168 (WebInspector.NetworkPanel.prototype.wasShown):
169 (WebInspector.NetworkPanel.prototype._showResource):
170 (WebInspector.NetworkPanel.prototype._closeVisibleResource):
171 (WebInspector.NetworkPanel.prototype._toggleGridMode):
172 (WebInspector.NetworkPanel.prototype._toggleViewingResourceMode):
173 * inspector/front-end/Panel.js:
174 (WebInspector.Panel.prototype.wasShown):
175 (WebInspector.Panel.prototype.createSplitView):
176 (WebInspector.Panel.prototype.createSplitViewWithSidebarTree):
177 (WebInspector.Panel.prototype.sidebarResized):
178 * inspector/front-end/ProfilesPanel.js:
179 (WebInspector.ProfilesPanel.prototype._reset):
180 (WebInspector.ProfilesPanel.prototype.sidebarResized):
181 * inspector/front-end/ResourcesPanel.js:
182 (WebInspector.ResourcesPanel.prototype.sidebarResized):
183 * inspector/front-end/ScriptsPanel.js:
184 (WebInspector.ScriptsPanel.prototype.wasShown):
185 (WebInspector.ScriptsPanel.prototype.sidebarResized):
186 * inspector/front-end/SplitView.js: Added.
187 (WebInspector.SplitView):
188 * inspector/front-end/TimelineOverviewPane.js:
189 (WebInspector.TimelineOverviewPane.prototype.sidebarResized):
190 * inspector/front-end/TimelinePanel.js:
191 (WebInspector.TimelinePanel):
192 (WebInspector.TimelinePanel.prototype.sidebarResized):
193 (WebInspector.TimelinePanel.prototype._refreshRecords):
194 * inspector/front-end/WebKit.qrc:
195 * inspector/front-end/auditsPanel.css:
196 * inspector/front-end/elementsPanel.css:
197 * inspector/front-end/inspector.css:
199 * inspector/front-end/inspector.html:
200 * inspector/front-end/networkLogView.css:
201 * inspector/front-end/networkPanel.css:
203 * inspector/front-end/profilesPanel.css:
205 * inspector/front-end/resourcesPanel.css:
206 * inspector/front-end/scriptsPanel.css:
207 (#scripts-split-view):
208 * inspector/front-end/splitView.css: Added.
209 * inspector/front-end/timelinePanel.css:
210 (.timeline .sidebar):
211 (.timeline-sidebar-background):
212 (#resources-container-content):
214 2011-11-22 Sheriff Bot <webkit.review.bot@gmail.com>
216 Unreviewed, rolling out r100988.
217 http://trac.webkit.org/changeset/100988
218 https://bugs.webkit.org/show_bug.cgi?id=72941
220 "Broke pixel tests on Chromium-Linux" (Requested by kbalazs on
223 * platform/graphics/filters/FEConvolveMatrix.cpp:
224 (WebCore::FEConvolveMatrix::platformApplySoftware):
225 * platform/graphics/filters/FEConvolveMatrix.h:
226 * platform/graphics/filters/FEGaussianBlur.cpp:
227 (WebCore::FEGaussianBlur::platformApply):
228 * platform/graphics/filters/FEGaussianBlur.h:
229 * platform/graphics/filters/FELighting.cpp:
230 (WebCore::FELighting::platformApplyGeneric):
231 * platform/graphics/filters/FELighting.h:
232 * platform/graphics/filters/FEMorphology.cpp:
233 (WebCore::FEMorphology::platformApply):
234 * platform/graphics/filters/FEMorphology.h:
235 * platform/graphics/filters/FETurbulence.cpp:
236 (WebCore::FETurbulence::platformApplySoftware):
237 * platform/graphics/filters/FETurbulence.h:
238 * platform/graphics/filters/arm/FELightingNEON.cpp:
239 * platform/graphics/filters/arm/FELightingNEON.h:
240 (WebCore::FELighting::platformApplyNeon):
242 2011-11-21 Balazs Kelemen <kbalazs@webkit.org>
244 Enable ParallelJobs by default
245 https://bugs.webkit.org/show_bug.cgi?id=70032
247 Reviewed by Zoltan Herczeg.
249 Covered by existing tests.
251 According to measurements on Mac and Linux it is a
252 considerable speedup for SVG on multicore.
254 Remove the ENABLE(PARALLEL_JOBS) guard. Fix the Windows build
255 by qualifying ParallelJobs with the WTF namespace (otherwise
256 MSVC believes it belongs to WebCore which is likely a compiler bug).
258 * platform/graphics/filters/FEConvolveMatrix.cpp:
259 (WebCore::FEConvolveMatrix::setInteriorPixelsWorker):
260 (WebCore::FEConvolveMatrix::platformApplySoftware):
261 * platform/graphics/filters/FEConvolveMatrix.h:
262 * platform/graphics/filters/FEGaussianBlur.cpp:
263 (WebCore::FEGaussianBlur::platformApplyWorker):
264 (WebCore::FEGaussianBlur::platformApply):
265 * platform/graphics/filters/FEGaussianBlur.h:
266 * platform/graphics/filters/FELighting.cpp:
267 (WebCore::FELighting::platformApplyGenericWorker):
268 (WebCore::FELighting::platformApplyGeneric):
269 * platform/graphics/filters/FELighting.h:
270 * platform/graphics/filters/FEMorphology.cpp:
271 (WebCore::FEMorphology::platformApplyWorker):
272 (WebCore::FEMorphology::platformApply):
273 * platform/graphics/filters/FEMorphology.h:
274 * platform/graphics/filters/FETurbulence.cpp:
275 (WebCore::FETurbulence::fillRegionWorker):
276 (WebCore::FETurbulence::platformApplySoftware):
277 * platform/graphics/filters/FETurbulence.h:
278 * platform/graphics/filters/arm/FELightingNEON.cpp:
279 (WebCore::FELighting::platformApplyNeonWorker):
280 * platform/graphics/filters/arm/FELightingNEON.h:
281 (WebCore::FELighting::platformApplyNeon):
283 2011-11-22 Alexander Pavlov <apavlov@chromium.org>
285 Web Inspector: [protocol] actual JSON messages do not conform to Inspector.json in CSS
286 https://bugs.webkit.org/show_bug.cgi?id=72733
288 Reviewed by Pavel Feldman.
290 * inspector/Inspector.json:
291 * inspector/InspectorCSSAgent.cpp:
292 (WebCore::InspectorCSSAgent::getComputedStyleForNode):
293 * inspector/InspectorCSSAgent.h:
294 * inspector/InspectorStyleSheet.cpp:
295 (WebCore::InspectorStyle::buildArrayForComputedStyle):
296 * inspector/InspectorStyleSheet.h:
297 * inspector/front-end/CSSStyleModel.js:
298 (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
299 (WebInspector.CSSStyleDeclaration.parseComputedStylePayload):
301 2011-11-22 Pavel Feldman <pfeldman@google.com>
303 Web Inspector: strip unused InspectorController methods.
304 https://bugs.webkit.org/show_bug.cgi?id=72886
306 This is a follow up to the https://bugs.webkit.org/show_bug.cgi?id=63009.
307 I am now able to remove following InspectorController methods:
308 ::startUserInitiatedProfiling,
309 ::isRecordingUserInitiatedProfile,
310 ::stopUserInitiatedProfiling,
311 ::showAndEnableDebugger,
314 ::startTimelineProfiler,
315 ::stopTimelineProfiler,
316 ::timelineProfilerEnabled,
319 Reviewed by Yury Semikhatsky.
323 * inspector/Inspector.json:
324 * inspector/InspectorAgent.cpp:
325 (WebCore::InspectorAgent::setFrontend):
326 * inspector/InspectorAgent.h:
327 * inspector/InspectorController.cpp:
328 (WebCore::InspectorController::InspectorController):
329 (WebCore::InspectorController::connectFrontend):
330 * inspector/InspectorController.h:
331 * inspector/InspectorDebuggerAgent.cpp:
332 (WebCore::InspectorDebuggerAgent::enable):
333 (WebCore::InspectorDebuggerAgent::disable):
334 * inspector/InspectorDebuggerAgent.h:
335 * inspector/InspectorInstrumentation.cpp:
336 (WebCore::InspectorInstrumentation::didCommitLoadImpl):
337 * inspector/InspectorProfilerAgent.cpp:
338 (WebCore::InspectorProfilerAgent::resetState):
339 (WebCore::InspectorProfilerAgent::clearFrontend):
340 (WebCore::InspectorProfilerAgent::restore):
341 (WebCore::InspectorProfilerAgent::start):
342 (WebCore::InspectorProfilerAgent::stop):
343 * inspector/InspectorProfilerAgent.h:
344 * inspector/InspectorTimelineAgent.cpp:
345 (WebCore::InspectorTimelineAgent::start):
346 (WebCore::InspectorTimelineAgent::stop):
347 * inspector/InspectorTimelineAgent.h:
348 * inspector/front-end/DebuggerModel.js:
349 (WebInspector.DebuggerModel.prototype.enableDebugger):
350 (WebInspector.DebuggerModel.prototype.disableDebugger):
351 * inspector/front-end/TimelineManager.js:
352 (WebInspector.TimelineManager.prototype.start):
353 (WebInspector.TimelineManager.prototype.stop):
354 (WebInspector.TimelineManager.prototype._started):
355 (WebInspector.TimelineManager.prototype._stopped):
356 * inspector/front-end/inspector.js:
358 2011-11-17 Nat Duca <nduca@chromium.org>
360 [chromium] Route willDraw/setNeedsRedraw to CCInputHandler and fix double-drawing issues that result
361 https://bugs.webkit.org/show_bug.cgi?id=72688
363 This allows CCInputFilter and CCLayerTreeHostImpl to
364 perform requestAnimationFrame-style animations. The bulk of
365 work here is to make the scheduler recover gracefully when you
366 call setNeedsRedraw inside scheduledActionDraw.
368 Reviewed by James Robinson.
371 * platform/graphics/chromium/cc/CCInputHandler.h:
372 (WebCore::CCInputHandlerTarget::CCInputHandlerTarget):
373 (WebCore::CCInputHandlerTarget::~CCInputHandlerTarget):
374 * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
375 (WebCore::CCLayerTreeHostImpl::currentTimeMs):
376 (WebCore::CCLayerTreeHostImpl::setNeedsRedraw):
377 * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
378 * platform/graphics/chromium/cc/CCScheduler.cpp:
379 (WebCore::CCScheduler::CCScheduler):
380 (WebCore::CCScheduler::setVisible):
381 (WebCore::CCScheduler::setNeedsRedraw):
382 (WebCore::CCScheduler::beginFrame):
383 (WebCore::CCScheduler::processScheduledActions):
384 * platform/graphics/chromium/cc/CCScheduler.h:
385 * platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
386 (WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
387 (WebCore::CCSchedulerStateMachine::nextAction):
388 (WebCore::CCSchedulerStateMachine::updateState):
389 (WebCore::CCSchedulerStateMachine::setInsideVSync):
390 (WebCore::CCSchedulerStateMachine::setOutsideVSync):
391 * platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
392 * platform/graphics/chromium/cc/CCScrollController.h: Removed.
393 * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
394 * platform/graphics/chromium/cc/CCThreadProxy.cpp:
395 (WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
397 2011-11-22 Alexander Pavlov <apavlov@chromium.org>
399 Web Inspector: Design of the autocomplete suggest
400 https://bugs.webkit.org/show_bug.cgi?id=72798
402 Reviewed by Pavel Feldman.
404 Implemented a combination of grayed text for the first/only completion and hid
405 the suggest box for a single suggestion (the grayed text is displayed instead.)
406 Drive-by fix for the "trailing spaces in the prompt" issue
407 (got regressed when the suggest box was introduced for the first time.)
409 * inspector/front-end/ConsoleView.js:
410 (WebInspector.ConsoleView): Fix the "trailing spaces" issue
411 * inspector/front-end/TextPrompt.js:
412 (WebInspector.TextPrompt):
413 (WebInspector.TextPrompt.prototype.renderAsBlock): Fix the "trailing spaces" issue
414 (WebInspector.TextPrompt.prototype._attachInternal):
415 (WebInspector.TextPrompt.prototype.acceptAutoComplete):
416 (WebInspector.TextPrompt.prototype._completionsReady):
417 (WebInspector.TextPrompt.prototype.applySuggestion):
418 (WebInspector.TextPrompt.prototype.acceptSuggestion):
419 (WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
421 2011-11-21 David Barr <davidbarr@chromium.org>
423 REGRESSION(r98542): Chromium: CSS text is rendered on page
424 https://bugs.webkit.org/show_bug.cgi?id=71703
426 Reviewed by Dimitri Glazkov.
428 Matched UA declarations uncacheable when using simpleDefaultStyleSheet.
430 Test: fast/css/style-tag-display-none.html
432 * css/CSSStyleSelector.cpp:
433 (WebCore::CSSStyleSelector::matchUARules):
435 2011-11-21 Rob Brackett <rob@robbrackett.com>
437 If an event listener is a function, it should be called and not checked for handleEvent.
438 This also covers callbacks, which follow the same spec but are implemented separately.
439 https://bugs.webkit.org/show_bug.cgi?id=62518
441 Reviewed by Sam Weinig.
443 Tests: fast/events/dispatch-to-function-with-handle-event.html
444 fast/js/callback-function-with-handle-event.html
446 * bindings/js/JSCallbackData.cpp:
447 (WebCore::JSCallbackData::invokeCallback):
448 * bindings/js/JSEventListener.cpp:
449 (WebCore::JSEventListener::handleEvent):
451 2011-11-21 Rakesh KN <rakesh.kn@motorola.com>
453 Need support for dirname attribute
454 https://bugs.webkit.org/show_bug.cgi?id=65542
456 Reviewed by Eric Seidel.
458 Implemented 'dirname' form attribute.
460 Tests: fast/forms/form-dirname-attribute.html
461 fast/forms/submit-form-with-dirname-attribute-with-ancestor-dir-attribute.html
462 fast/forms/submit-form-with-dirname-attribute-with-nonhtml-ancestor.html
463 fast/forms/submit-form-with-dirname-attribute.html
465 * html/HTMLAttributeNames.in:
466 Added "dirname" attribute.
467 * html/HTMLInputElement.idl:
468 Add "dirName" property to HTMLInputElement interface.
469 * html/HTMLTextAreaElement.cpp:
470 (WebCore::HTMLTextAreaElement::appendFormData):
471 Append dirname form data.
472 * html/HTMLTextAreaElement.idl:
473 Add "dirName" property to HTMLTextAreaElement interface.
474 * html/HTMLTextFormControlElement.cpp:
475 (WebCore::parentHTMLElement):
476 Helper function which returns only HTML parent element.
477 (WebCore::HTMLTextFormControlElement::directionForFormData):
478 Helper function for finding directionality of the Element.
479 * html/HTMLTextFormControlElement.h:
480 Helper function for finding directionality of the Element.
481 * html/TextFieldInputType.cpp:
482 (WebCore::TextFieldInputType::appendFormData):
483 Append dirname form data.
484 * html/TextFieldInputType.h:
485 Append dirname form data.
487 2011-11-21 Joshua Bell <jsbell@chromium.org>
489 IndexedDB: Close database connections, abort transactions, and terminate requests on stop()
490 https://bugs.webkit.org/show_bug.cgi?id=72066
492 Reviewed by Tony Chang.
494 No new tests; addresses race conditions on document navigate/script context stop.
496 * dom/DocumentEventQueue.cpp:
497 (WebCore::DocumentEventQueue::enqueueEvent):
498 * dom/DocumentEventQueue.h:
500 * storage/IDBDatabase.cpp:
501 (WebCore::IDBDatabase::IDBDatabase):
502 (WebCore::IDBDatabase::~IDBDatabase):
503 (WebCore::IDBDatabase::transaction):
504 (WebCore::IDBDatabase::close):
505 (WebCore::IDBDatabase::onVersionChange):
506 (WebCore::IDBDatabase::enqueueEvent):
507 (WebCore::IDBDatabase::stop):
508 * storage/IDBDatabase.h:
509 * storage/IDBFactory.cpp:
510 (WebCore::IDBFactory::IDBFactory):
511 (WebCore::IDBFactory::getDatabaseNames):
512 (WebCore::IDBFactory::open):
513 (WebCore::IDBFactory::deleteDatabase):
514 * storage/IDBFactory.h:
515 * storage/IDBObjectStore.cpp:
516 (WebCore::IDBObjectStore::IDBObjectStore):
517 (WebCore::IDBObjectStore::name):
518 (WebCore::IDBObjectStore::keyPath):
519 (WebCore::IDBObjectStore::indexNames):
520 (WebCore::IDBObjectStore::get):
521 (WebCore::IDBObjectStore::add):
522 (WebCore::IDBObjectStore::put):
523 (WebCore::IDBObjectStore::deleteFunction):
524 (WebCore::IDBObjectStore::clear):
525 (WebCore::IDBObjectStore::createIndex):
526 (WebCore::IDBObjectStore::index):
527 (WebCore::IDBObjectStore::deleteIndex):
528 (WebCore::IDBObjectStore::openCursor):
529 * storage/IDBObjectStore.h:
530 * storage/IDBRequest.cpp:
531 (WebCore::IDBRequest::IDBRequest):
532 (WebCore::IDBRequest::abort):
533 (WebCore::IDBRequest::onSuccess):
534 (WebCore::IDBRequest::onSuccessWithContinuation):
535 (WebCore::IDBRequest::stop):
536 (WebCore::IDBRequest::dispatchEvent):
537 (WebCore::IDBRequest::enqueueEvent):
538 * storage/IDBRequest.h:
539 * storage/IDBTransaction.cpp:
540 (WebCore::IDBTransaction::IDBTransaction):
541 (WebCore::IDBTransaction::abort):
542 (WebCore::IDBTransaction::onAbort):
543 (WebCore::IDBTransaction::onComplete):
544 (WebCore::IDBTransaction::dispatchEvent):
545 (WebCore::IDBTransaction::stop):
546 (WebCore::IDBTransaction::enqueueEvent):
547 * storage/IDBTransaction.h:
548 * storage/IDBTransactionBackendImpl.cpp:
549 (WebCore::IDBTransactionBackendImpl::abort):
550 (WebCore::IDBTransactionBackendImpl::commit):
551 * workers/WorkerEventQueue.cpp:
552 (WebCore::WorkerEventQueue::enqueueEvent):
553 * workers/WorkerEventQueue.h:
555 2011-11-21 James Robinson <jamesr@chromium.org>
557 [chromium] Avoid pushing dirty tiles to the impl layer
558 https://bugs.webkit.org/show_bug.cgi?id=72765
560 Reviewed by Kenneth Russell.
562 If a tile has invalidations at pushPropertiesTo, then we know the contents of that tile are no longer valid even
563 if they still have valid backing textures. This avoids pushing that texture to the impl side so it is not
564 displayed to the user. The texture is still kept around (managed by the TextureManager) so that when we later do
565 decide to update the contents for that tile we can use partial results if they are still valid.
567 Covered by new unit test in TiledLayerChromiumTest.cpp
569 * platform/graphics/chromium/TiledLayerChromium.cpp:
570 (WebCore::UpdatableTile::isDirty):
571 (WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
572 (WebCore::TiledLayerChromium::setTileSize):
573 (WebCore::TiledLayerChromium::setLayerTreeHost):
574 (WebCore::TiledLayerChromium::createTiler):
575 (WebCore::TiledLayerChromium::updateCompositorResources):
576 (WebCore::TiledLayerChromium::pushPropertiesTo):
577 * platform/graphics/chromium/TiledLayerChromium.h:
578 (WebCore::TiledLayerChromium::setTextureFormat):
579 * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
580 (WebCore::CCTiledLayerImpl::hasTileAt):
581 (WebCore::CCTiledLayerImpl::drawTiles):
582 * platform/graphics/chromium/cc/CCTiledLayerImpl.h:
584 2011-11-21 Simon Hausmann <simon.hausmann@nokia.com>
586 [Qt] Speed up debug builds.
587 https://bugs.webkit.org/show_bug.cgi?id=72882
589 Reviewed by Tor Arne Vestbø.
591 * Target.pri: Make BUILDING_WebCore available earlier, so it can be
592 used by the build system.
594 2011-11-17 Robert Hogan <robert@webkit.org>
596 CSS 2.1 failure: empty-inline-003.htm fails
597 https://bugs.webkit.org/show_bug.cgi?id=72638
599 Reviewed by Ryosuke Niwa.
601 Empty inline elements need to share their inline height with siblings.
603 * rendering/RenderBlockLineLayout.cpp:
604 (WebCore::inlineFlowRequiresLineBox): In strict mode, add a LineBox for an empty element if it is
605 going to affect the line-height.
606 (WebCore::requiresLineBox): Pass LineInfo to inlineFlowRequiresLineBox
607 (WebCore::RenderBlock::LineBreaker::nextLineBreak): Pass LineInfo to inlineFlowRequiresLineBox
609 2011-11-21 Adrienne Walker <enne@google.com>
611 [chromium] Remove incorrect render surface layer list asserts from compositor
612 https://bugs.webkit.org/show_bug.cgi?id=72744
614 Reviewed by James Robinson.
616 These asserts are incorrect, because it's valid for the default render
617 surface to be created but to have a root layer that doesn't draw. It
618 won't get added to the single render surface and it'll have an empty
621 Test: compositor_unittests
623 * platform/graphics/chromium/LayerRendererChromium.cpp:
624 (WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
625 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
626 (WebCore::CCLayerTreeHost::paintLayerContents):
627 (WebCore::CCLayerTreeHost::updateCompositorResources):
629 2011-11-21 Andreas Kling <kling@webkit.org>
631 StyleSheet: Move completeURL() to CSSStyleSheet.
632 <http://webkit.org/b/72888>
634 Reviewed by Antti Koivisto.
636 Since completeURL() is only used on CSSStyleSheets, move it there (and make
637 it non-virtual) to make StyleSheet a little leaner.
639 * css/CSSStyleSheet.cpp:
640 (WebCore::CSSStyleSheet::completeURL):
641 * css/CSSStyleSheet.h:
642 * css/StyleSheet.cpp:
645 2011-11-21 Robin Dunn <robin@alldunn.com>
647 [wx] Fix image translation calculations.
648 https://bugs.webkit.org/show_bug.cgi?id=72892
650 Reviewed by Kevin Ollivier.
652 * platform/graphics/wx/ImageWx.cpp:
653 (WebCore::Image::drawPattern):
655 2011-11-21 Scott Graham <scottmg@chromium.org>
657 copyright comment style to C from C++ for gamepad module
658 https://bugs.webkit.org/show_bug.cgi?id=72894
660 Reviewed by Sam Weinig.
662 Just changes comment format, no code/test changes.
664 * Modules/gamepad/Gamepad.cpp:
665 * Modules/gamepad/Gamepad.h:
666 * Modules/gamepad/Gamepad.idl:
667 * Modules/gamepad/GamepadList.cpp:
668 * Modules/gamepad/GamepadList.h:
669 * Modules/gamepad/GamepadList.idl:
671 2011-11-21 Andreas Kling <kling@webkit.org>
673 JSC/CSSOM: Merge root() for style declaration objects.
674 <http://webkit.org/b/72881>
676 Reviewed by Antti Koivisto.
678 Fold root(CSSMutableStyleDeclaration*) into root(CSSStyleDeclaration*),
679 removing a duplicated chunk and making it a little easier on the eyes.
681 * bindings/js/JSDOMBinding.h:
684 2011-11-21 Igor Oliveira <igor.oliveira@openbossa.org>
686 [WK2][Qt] Move Accelerated Composite animations to UIProcess
687 https://bugs.webkit.org/show_bug.cgi?id=72753
689 Add helper method to synchronize animations in TextureMapper.
691 Reviewed by Noam Rosenthal.
693 * platform/graphics/texmap/TextureMapperNode.cpp:
694 (WebCore::TextureMapperNode::syncAnimationsRecursively):
695 * platform/graphics/texmap/TextureMapperNode.h:
697 2011-11-21 Sheriff Bot <webkit.review.bot@gmail.com>
699 Unreviewed, rolling out r100913.
700 http://trac.webkit.org/changeset/100913
701 https://bugs.webkit.org/show_bug.cgi?id=72885
703 "Break Windows build" (Requested by kbalazs on #webkit).
705 * platform/graphics/filters/FEConvolveMatrix.cpp:
706 (WebCore::FEConvolveMatrix::platformApplySoftware):
707 * platform/graphics/filters/FEConvolveMatrix.h:
708 * platform/graphics/filters/FEGaussianBlur.cpp:
709 (WebCore::FEGaussianBlur::platformApply):
710 * platform/graphics/filters/FEGaussianBlur.h:
711 * platform/graphics/filters/FELighting.cpp:
712 (WebCore::FELighting::platformApplyGeneric):
713 * platform/graphics/filters/FELighting.h:
714 * platform/graphics/filters/FEMorphology.cpp:
715 (WebCore::FEMorphology::platformApply):
716 * platform/graphics/filters/FEMorphology.h:
717 * platform/graphics/filters/FETurbulence.cpp:
718 (WebCore::FETurbulence::platformApplySoftware):
719 * platform/graphics/filters/FETurbulence.h:
720 * platform/graphics/filters/arm/FELightingNEON.cpp:
721 * platform/graphics/filters/arm/FELightingNEON.h:
722 (WebCore::FELighting::platformApplyNeon):
724 2011-11-21 Balazs Kelemen <kbalazs@webkit.org>
726 Enable ParallelJobs by default
727 https://bugs.webkit.org/show_bug.cgi?id=70032
729 Reviewed by Zoltan Herczeg.
731 Covered by existing tests.
733 According to measurements on Mac and Linux it is a
734 considerable speedup for SVG on multicore.
736 Remove the ENABLE(PARALLEL_JOBS) guard. Fix the Windows build
737 by qualifying ParallelJobs with the WTF namespace (otherwise
738 MSVC believes it belongs to WebCore which is likely a compiler bug).
740 * platform/graphics/filters/FEConvolveMatrix.cpp:
741 (WebCore::FEConvolveMatrix::setInteriorPixelsWorker):
742 (WebCore::FEConvolveMatrix::platformApplySoftware):
743 * platform/graphics/filters/FEConvolveMatrix.h:
744 * platform/graphics/filters/FEGaussianBlur.cpp:
745 (WebCore::FEGaussianBlur::platformApplyWorker):
746 (WebCore::FEGaussianBlur::platformApply):
747 * platform/graphics/filters/FEGaussianBlur.h:
748 * platform/graphics/filters/FELighting.cpp:
749 (WebCore::FELighting::platformApplyGenericWorker):
750 (WebCore::FELighting::platformApplyGeneric):
751 * platform/graphics/filters/FELighting.h:
752 * platform/graphics/filters/FEMorphology.cpp:
753 (WebCore::FEMorphology::platformApplyWorker):
754 (WebCore::FEMorphology::platformApply):
755 * platform/graphics/filters/FEMorphology.h:
756 * platform/graphics/filters/FETurbulence.cpp:
757 (WebCore::FETurbulence::fillRegionWorker):
758 (WebCore::FETurbulence::platformApplySoftware):
759 * platform/graphics/filters/FETurbulence.h:
760 * platform/graphics/filters/arm/FELightingNEON.cpp:
761 (WebCore::FELighting::platformApplyNeonWorker):
762 * platform/graphics/filters/arm/FELightingNEON.h:
763 (WebCore::FELighting::platformApplyNeon):
765 2011-11-21 Antti Koivisto <antti@apple.com>
767 Remove CSSStyleSelector::m_additionalAttributeStyleDecls field
768 https://bugs.webkit.org/show_bug.cgi?id=72876
770 Reviewed by Andreas Kling.
772 There is no reason for this temporary to be a field.
774 * css/CSSStyleSelector.cpp:
775 (WebCore::CSSStyleSelector::matchAllRules):
776 * css/CSSStyleSelector.h:
778 2011-11-21 Pavel Feldman <pfeldman@google.com>
780 Web Inspector: [REGRESSION] Assertion failed in ScriptsPanel.js
781 https://bugs.webkit.org/show_bug.cgi?id=72877
783 Reviewed by Yury Semikhatsky.
785 * inspector/front-end/ScriptsPanel.js:
787 2011-11-18 Pavel Feldman <pfeldman@google.com>
789 Web Inspector: get rid of Panel::reset in the front-end.
790 https://bugs.webkit.org/show_bug.cgi?id=72587
792 I'm slowly getting rid of the Inspector protocol domain. It currently
793 contains methods that did not find their home in the meaningful domains.
794 This change removes reset protocol method.
796 Reviewed by Yury Semikhatsky.
798 * inspector/Inspector.json:
799 * inspector/InspectorAgent.cpp:
800 (WebCore::InspectorAgent::didCommitLoad):
801 * inspector/InspectorDebuggerAgent.cpp:
802 (WebCore::InspectorDebuggerAgent::didClearMainFrameWindowObject):
803 * inspector/InspectorDebuggerAgent.h:
804 * inspector/InspectorInstrumentation.cpp:
805 (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
806 (WebCore::InspectorInstrumentation::didCommitLoadImpl):
807 * inspector/front-end/ApplicationCacheModel.js:
808 (WebInspector.ApplicationCacheModel.prototype._frameNavigated):
809 (WebInspector.ApplicationCacheModel.prototype._frameDetached):
810 * inspector/front-end/DebuggerModel.js:
811 (WebInspector.DebuggerModel.prototype._globalObjectCleared):
812 (WebInspector.DebuggerDispatcher.prototype.globalObjectCleared):
813 * inspector/front-end/DebuggerPresentationModel.js:
814 (WebInspector.DebuggerPresentationModel):
815 (WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
816 * inspector/front-end/ExtensionServer.js:
817 (WebInspector.ExtensionServer):
818 (WebInspector.ExtensionServer.prototype._mainFrameNavigated):
819 * inspector/front-end/JavaScriptContextManager.js:
820 (WebInspector.JavaScriptContextManager.prototype._frameDetached):
821 (WebInspector.FrameEvaluationContext.prototype.get frameId):
822 * inspector/front-end/NetworkLog.js:
823 (WebInspector.NetworkLog):
824 (WebInspector.NetworkLog.prototype._mainFrameNavigated):
825 * inspector/front-end/NetworkPanel.js:
826 (WebInspector.NetworkLogView):
827 (WebInspector.NetworkLogView.prototype._mainFrameNavigated):
828 * inspector/front-end/ResourceTreeModel.js:
829 (WebInspector.ResourceTreeModel.prototype._frameNavigated):
830 (WebInspector.ResourceTreeModel.prototype._frameDetached):
831 (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
832 * inspector/front-end/ResourcesPanel.js:
833 (WebInspector.ResourcesPanel.prototype._reset):
834 (WebInspector.ResourcesPanel.prototype._frameDetached):
835 * inspector/front-end/ScriptsPanel.js:
836 (WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):
837 (WebInspector.ScriptsPanel.prototype._reset):
838 * inspector/front-end/WorkerManager.js:
839 (WebInspector.WorkerManager):
840 (WebInspector.WorkerManager.prototype._mainFrameNavigated):
841 * inspector/front-end/inspector.js:
843 2011-06-20 Pavel Feldman <pfeldman@chromium.org>
845 Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
846 https://bugs.webkit.org/show_bug.cgi?id=62985
848 Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
849 methods for plumbing the menu action handlers through the WebKit and WebCore.
850 I intend to remove this menu support from the protocol and WebCore/InspectorController API.
851 I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
852 WebKit/win and WebKit2 to follow.
854 Reviewed by Yury Semikhatsky.
858 * WebCore.vcproj/WebCore.vcproj:
859 * inspector/InspectorFrontendClientLocal.cpp:
860 (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
861 (WebCore::InspectorFrontendClientLocal::frontendLoaded):
862 (WebCore::InspectorFrontendClientLocal::setAttachedWindow):
863 (WebCore::InspectorFrontendClientLocal::isDebuggingEnabled):
864 (WebCore::InspectorFrontendClientLocal::setDebuggingEnabled):
865 (WebCore::InspectorFrontendClientLocal::isJavaScriptProfilingEnabled):
866 (WebCore::InspectorFrontendClientLocal::setJavaScriptProfilingEnabled):
867 (WebCore::InspectorFrontendClientLocal::isTimelineProfilingEnabled):
868 (WebCore::InspectorFrontendClientLocal::setTimelineProfilingEnabled):
869 (WebCore::InspectorFrontendClientLocal::isProfilingJavaScript):
870 (WebCore::InspectorFrontendClientLocal::startProfilingJavaScript):
871 (WebCore::InspectorFrontendClientLocal::stopProfilingJavaScript):
872 (WebCore::InspectorFrontendClientLocal::evaluateAsBoolean):
873 (WebCore::InspectorFrontendClientLocal::evaluateOnLoad):
874 * inspector/InspectorFrontendClientLocal.h:
875 * inspector/front-end/InspectorFrontendAPI.js: Added.
876 (InspectorFrontendAPI.isDebuggingEnabled):
877 (InspectorFrontendAPI.setDebuggingEnabled):
878 (InspectorFrontendAPI.isJavaScriptProfilingEnabled):
879 (InspectorFrontendAPI.setJavaScriptProfilingEnabled):
880 (InspectorFrontendAPI.isTimelineProfilingEnabled):
881 (InspectorFrontendAPI.setTimelineProfilingEnabled):
882 (InspectorFrontendAPI.isProfilingJavaScript):
883 (InspectorFrontendAPI.startProfilingJavaScript):
884 (InspectorFrontendAPI.stopProfilingJavaScript):
885 (InspectorFrontendAPI.setAttachedWindow):
886 * inspector/front-end/ProfileView.js:
887 (WebInspector.CPUProfileType):
888 (WebInspector.CPUProfileType.prototype.isRecordingProfile):
889 (WebInspector.CPUProfileType.prototype.startRecordingProfile):
890 (WebInspector.CPUProfileType.prototype.stopRecordingProfile):
891 * inspector/front-end/ProfilesPanel.js:
892 (WebInspector.ProfilesPanel.prototype.get profilerEnabled):
893 (WebInspector.ProfilesPanel.prototype.enableProfiler):
894 (WebInspector.ProfilesPanel.prototype.disableProfiler):
895 * inspector/front-end/ScriptsPanel.js:
896 (WebInspector.ScriptsPanel):
897 (WebInspector.ScriptsPanel.prototype.get debuggingEnabled):
898 (WebInspector.ScriptsPanel.prototype.enableDebugging):
899 (WebInspector.ScriptsPanel.prototype.disableDebugging):
900 (WebInspector.ScriptsPanel.prototype.toggleDebugging):
901 * inspector/front-end/TimelinePanel.js:
902 (WebInspector.TimelinePanel.prototype._memoryOverviewItemSelected):
903 (WebInspector.TimelinePanel.prototype.setTimelineProfilingEnabled):
904 (WebInspector.TimelinePanel.prototype.get timelineProfilingEnabled):
905 * inspector/front-end/WebKit.qrc:
906 * inspector/front-end/inspector.html:
907 * inspector/front-end/inspector.js:
909 2011-11-18 Alexander Pavlov <apavlov@chromium.org>
911 Web Inspector: [Protocol] Retain a single universal method for loading a required combination of element styles
912 https://bugs.webkit.org/show_bug.cgi?id=72701
914 Reviewed by Pavel Feldman.
916 * inspector/Inspector.json:
917 * inspector/InspectorCSSAgent.cpp:
918 (WebCore::InspectorCSSAgent::getMatchedStylesForNode):
919 (WebCore::InspectorCSSAgent::getInlineStylesForNode):
920 (WebCore::InspectorCSSAgent::getComputedStyleForNode):
921 * inspector/InspectorCSSAgent.h:
922 * inspector/front-end/AuditRules.js:
923 (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
924 (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles.inlineCallback):
925 (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles.matchedCallback):
926 (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
927 * inspector/front-end/CSSStyleModel.js:
928 (WebInspector.CSSStyleModel.prototype.getMatchedStylesAsync):
929 (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
930 (WebInspector.CSSStyleModel.prototype.getInlineStylesAsync):
931 * inspector/front-end/MetricsSidebarPane.js:
932 (WebInspector.MetricsSidebarPane.prototype._innerUpdate):
933 * inspector/front-end/StylesSidebarPane.js:
934 (WebInspector.StylesSidebarPane.prototype.get forcedPseudoClasses):
935 (WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):
936 (WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate.inlineCallback):
937 (WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate.computedCallback):
938 (WebInspector.StylesSidebarPane.prototype._innerUpdate):
940 2011-11-21 Sheriff Bot <webkit.review.bot@gmail.com>
942 Unreviewed, rolling out r100856.
943 http://trac.webkit.org/changeset/100856
944 https://bugs.webkit.org/show_bug.cgi?id=72867
946 New test fast/css/style-tag-display-none.html fails on
947 Chromium (Requested by steveblock on #webkit).
949 * css/CSSStyleSelector.cpp:
950 (WebCore::CSSStyleSelector::matchUARules):
952 2011-11-21 Jochen Eisinger <jochen@chromium.org>
954 Implement Meta referrer
955 https://bugs.webkit.org/show_bug.cgi?id=72674
957 Reviewed by Adam Barth.
959 http://wiki.whatwg.org/wiki/Meta_referrer
961 Tests: http/tests/security/referrer-policy-always.html
962 http/tests/security/referrer-policy-default.html
963 http/tests/security/referrer-policy-https-always.html
964 http/tests/security/referrer-policy-https-default.html
965 http/tests/security/referrer-policy-https-never.html
966 http/tests/security/referrer-policy-https-origin.html
967 http/tests/security/referrer-policy-never.html
968 http/tests/security/referrer-policy-origin.html
969 http/tests/security/referrer-policy-redirect.html
970 http/tests/security/referrer-policy-rel-noreferrer.html
972 * WebCore.exp.in: updated
974 (WebCore::Document::Document):
975 (WebCore::Document::processReferrerPolicy):
977 (WebCore::Document::referrerPolicy):
978 * html/HTMLAnchorElement.cpp:
979 (WebCore::HTMLAnchorElement::handleClick):
980 * html/HTMLMetaElement.cpp:
981 (WebCore::HTMLMetaElement::process):
982 * loader/FrameLoader.cpp:
983 (WebCore::FrameLoader::loadFrameRequest):
984 (WebCore::FrameLoader::loadResourceSynchronously):
985 * loader/PingLoader.cpp:
986 (WebCore::PingLoader::loadImage):
987 (WebCore::PingLoader::sendPing):
988 (WebCore::PingLoader::reportContentSecurityPolicyViolation):
989 * loader/SubframeLoader.cpp:
990 (WebCore::SubframeLoader::loadSubframe):
991 * loader/SubresourceLoader.cpp:
992 (WebCore::SubresourceLoader::create):
993 * page/SecurityPolicy.cpp:
994 (WebCore::SecurityPolicy::generateReferrerHeader):
995 * page/SecurityPolicy.h:
997 2011-11-21 Vsevolod Vlasov <vsevik@chromium.org>
999 Web Inspector: ApplicationCache view should show navigator.onLine indicator.
1000 https://bugs.webkit.org/show_bug.cgi?id=72618
1002 Reviewed by Pavel Feldman.
1004 * inspector/InspectorApplicationCacheAgent.cpp:
1005 (WebCore::InspectorApplicationCacheAgent::enable):
1006 * inspector/front-end/ApplicationCacheItemsView.js:
1007 (WebInspector.ApplicationCacheItemsView):
1008 (WebInspector.ApplicationCacheItemsView.prototype.wasShown):
1009 * inspector/front-end/ApplicationCacheModel.js:
1010 (WebInspector.ApplicationCacheModel):
1011 (WebInspector.ApplicationCacheModel.prototype.get onLine):
1012 (WebInspector.ApplicationCacheModel.prototype._networkStateUpdated):
1013 * inspector/front-end/ResourcesPanel.js:
1014 (WebInspector.ResourcesPanel.prototype.showApplicationCache):
1015 (WebInspector.ResourcesPanel.prototype._applicationCacheNetworkStateChanged):
1017 2011-11-21 Carlos Garcia Campos <cgarcia@igalia.com>
1019 Unreviewed. Fix make distcheck build.
1021 * GNUmakefile.list.am:
1023 2011-11-21 Dominic Mazzoni <dmazzoni@google.com>
1025 Accessibility: Multiselect list boxes need to report the active option in addition to which items are selected.
1026 https://bugs.webkit.org/show_bug.cgi?id=72479
1028 Reviewed by Chris Fleizach.
1030 Test: accessibility/multiselect-list-reports-active-option.html
1032 * accessibility/AccessibilityListBoxOption.cpp:
1033 (WebCore::AccessibilityListBoxOption::isSelectedOptionActive):
1034 * accessibility/AccessibilityListBoxOption.h:
1035 * accessibility/AccessibilityObject.h:
1036 (WebCore::AccessibilityObject::isSelectedOptionActive):
1038 2011-11-21 Yuta Kitamura <yutak@chromium.org>
1040 [Qt] WebSocket close tests are failing
1041 https://bugs.webkit.org/show_bug.cgi?id=72865
1043 Reviewed by Simon Hausmann.
1045 * platform/network/qt/SocketStreamHandleQt.cpp:
1046 (WebCore::SocketStreamHandlePrivate::close):
1047 Emit didCloseSocketStream() callback even before the connection is established.
1048 Call m_socket->abort() to prevent "connected" signal from firing.
1050 2011-11-21 Shinya Kawanaka <shinyak@google.com>
1052 Refactoring: SpellChecker::requestCheckingFor should take Range instead of Node.
1053 https://bugs.webkit.org/show_bug.cgi?id=72847
1055 Reviewed by Hajime Morita.
1057 Covered by existing test.
1059 * editing/Editor.cpp:
1060 (WebCore::Editor::replaceSelectionWithFragment):
1061 Passes Range to requestCheckingFor instead of Node.
1062 * editing/SpellChecker.cpp:
1063 Changed argument type from Node to Range.
1064 The corresponding changes are also done in dependent methods.
1065 (WebCore::SpellChecker::initRequest):
1066 (WebCore::SpellChecker::clearRequest):
1067 (WebCore::SpellChecker::canCheckAsynchronously):
1068 (WebCore::SpellChecker::isBusy):
1069 (WebCore::SpellChecker::isValid):
1070 (WebCore::SpellChecker::isCheckable):
1071 (WebCore::SpellChecker::requestCheckingFor):
1072 Changed argument type from Node to Range.
1073 (WebCore::SpellChecker::doRequestCheckingFor):
1074 (WebCore::SpellChecker::didCheck):
1075 * editing/SpellChecker.h:
1077 2011-11-20 Kenichi Ishibashi <bashi@chromium.org>
1079 [Chromium] Remove old getFontFamilyForCharacters() and familyForChars() APIs.
1080 https://bugs.webkit.org/show_bug.cgi?id=72844
1082 Respects bold and italic properties that is given by fontconfig.
1084 Reviewed by Darin Fisher.
1086 * platform/graphics/chromium/FontCacheLinux.cpp:
1087 (WebCore::FontCache::getFontDataForCharacters): Removed #if and old logic.
1089 2011-11-20 Noel Gordon <noel.gordon@gmail.com>
1091 [chromium] Remove qt/QtMobileWebStyle from the gyp projects
1092 https://bugs.webkit.org/show_bug.cgi?id=72843
1094 Reviewed by Antonio Gomes.
1096 platform/qt/QtMobileWebStyle.{h,cpp} were removed in r100123
1098 * WebCore.gypi: remove platform/qt/QtMobileWebStyle.{h,cpp}
1100 2011-11-20 Kentaro Hara <haraken@chromium.org>
1102 Unreviewed. Rebaselined run-bindings-tests results.
1104 * bindings/scripts/test/CPP/WebDOMFloat64Array.cpp:
1105 (WebDOMFloat64Array::WebDOMFloat64Array):
1106 (WebDOMFloat64Array::impl):
1109 * bindings/scripts/test/CPP/WebDOMFloat64Array.h:
1111 2011-11-20 Adam Barth <abarth@webkit.org>
1113 REGRESSION(r100691): Safari error pages and Growl notifications fail to load stylesheets
1114 https://bugs.webkit.org/show_bug.cgi?id=72836
1116 Reviewed by Sam Weinig.
1118 This patch removes a (minor) security mitigation. Previously, we tried
1119 sequester "directory listings" into unique origins to make it more
1120 difficult for an attacker to crawl the user's local file system.
1121 Unfortunately, this mitigation doesn't really buy us much security
1122 because if the attacker has access to local files, we've probably lost
1125 The larger problem, however, is that this condition is overly
1126 complicated and has broken in sublte ways several times in its
1127 (relatively short) lifetime. In the cases reported in this bug, we see
1128 that this check affects error pages in Safari and Growl notifications,
1129 even those have nothing to do with directory listings.
1131 If we have our heart set on this directory listing mitigation, we'll
1132 need a more robust way of triggering the behavior than examining URLs
1133 and guess whether they contain directory listings. For example, if we
1134 implement Allow-From or Access-Control-Deny-Origin, then the embedder
1135 can supply those policies along with the directory listings. Those
1136 seem like much better solutions than the in-engine hack this patch
1139 * page/SecurityOrigin.cpp:
1140 (WebCore::shouldTreatAsUniqueOrigin):
1142 2011-10-17 Antonio Gomes <agomes@rim.com>
1144 Pass a Frame* parameter in EditorClient::respondToChangedSelection
1145 https://bugs.webkit.org/show_bug.cgi?id=70248
1147 Reviewed by Ryosuke Niwa.
1149 Most of the port specific implementations of EditorClient::respondToChangedSelection
1150 (like EditorClient{Qt,Gtk,etc}) are wrongly relying on FocusController::focusedOrMainFrame
1151 method to get the Frame where the selection is happening on.
1152 It is not right, since a selection can be easily triggered in an inner
1153 frame that is not focused.
1155 No new tests since it is a hard thing to test without
1156 to hook into editor client in layout tests. We could
1157 change the "Dumped Delegate" messages, but it would
1158 require a rebasile of +1200 for a minor change.
1160 * editing/Editor.cpp: Pass the Frame on where the selection is changing to the client.
1161 (WebCore::Editor::respondToChangedSelection): Ditto.
1162 (WebCore::Editor::changeSelectionAfterCommand): Ditto.
1163 (WebCore::EmptyEditorClient::respondToChangedSelection):
1164 * page/EditorClient.h: Pass Frame* to indicate where the selection is happening.
1165 * loader/EmptyClients.h: Changed signature as per base class change.
1167 2011-11-17 Mark Rowe <mrowe@apple.com>
1169 <http://webkit.org/b/72646> Disable deprecation warnings around code where we cannot easily
1170 switch away from the deprecated APIs.
1172 Reviewed by Sam Weinig.
1174 * platform/mac/WebCoreNSStringExtras.mm:
1175 * platform/network/cf/SocketStreamHandleCFNet.cpp:
1176 (WebCore::SocketStreamHandle::reportErrorToClient):
1178 2011-11-19 Kevin Ollivier <kevino@theolliviers.com>
1180 [wx] C++ bindings build fix for move of array classes to WTF.
1182 * bindings/scripts/CodeGeneratorCPP.pm:
1184 (GetNamespaceForClass):
1186 (GenerateImplementation):
1188 2011-11-19 Scott Graham <scottmg@chromium.org>
1190 Move gamepad to Modules/ (+ some cleanup)
1191 https://bugs.webkit.org/show_bug.cgi?id=72785
1193 Reviewed by Adam Barth.
1195 Move main files from page/ to Modules/gamepad/. #include guard the
1196 gamepad header inclusions in Navigator.cpp to avoid including for
1197 ports that do not enable GAMEPAD.
1199 * Modules/gamepad/Gamepad.cpp: Renamed from Source/WebCore/page/Gamepad.cpp.
1200 (WebCore::Gamepad::Gamepad):
1201 (WebCore::Gamepad::axes):
1202 (WebCore::Gamepad::buttons):
1203 (WebCore::Gamepad::~Gamepad):
1204 * Modules/gamepad/Gamepad.h: Renamed from Source/WebCore/page/Gamepad.h.
1205 * Modules/gamepad/Gamepad.idl: Renamed from Source/WebCore/page/Gamepad.idl.
1206 * Modules/gamepad/GamepadList.cpp: Renamed from Source/WebCore/page/GamepadList.cpp.
1207 (WebCore::GamepadList::~GamepadList):
1208 (WebCore::GamepadList::set):
1209 (WebCore::GamepadList::length):
1210 (WebCore::GamepadList::item):
1211 * Modules/gamepad/GamepadList.h: Renamed from Source/WebCore/page/GamepadList.h.
1212 (WebCore::GamepadList::create):
1213 (WebCore::GamepadList::GamepadList):
1214 * Modules/gamepad/GamepadList.idl: Renamed from Source/WebCore/page/GamepadList.idl.
1215 * WebCore.gyp/WebCore.gyp:
1217 * page/Navigator.cpp:
1219 2011-11-19 Sheriff Bot <webkit.review.bot@gmail.com>
1221 Unreviewed, rolling out r100834.
1222 http://trac.webkit.org/changeset/100834
1223 https://bugs.webkit.org/show_bug.cgi?id=72806
1225 this patch makes Qt run-webkit-test exit before finishing
1226 (Requested by igoroliveira on #webkit).
1228 * platform/graphics/texmap/TextureMapperNode.cpp:
1229 * platform/graphics/texmap/TextureMapperNode.h:
1231 2011-11-19 Huang Dongsung <luxtella@company100.net>
1233 Remove WebCore/ForwardingHeaders/runtime/JSObjectWithGlobalObject.h because
1234 JSObjectWithGlobalObject.h has been removed.
1235 https://bugs.webkit.org/show_bug.cgi?id=72794
1237 r94701 removed JSObjectWithGlobalObject.h.
1239 Reviewed by Oliver Hunt.
1241 * ForwardingHeaders/runtime/JSObjectWithGlobalObject.h: Removed.
1243 2011-11-19 Vsevolod Vlasov <vsevik@chromium.org>
1245 Web Inspector:[protocol] actual JSON messages do not conform to Inspector.json in InspectorApplicationCacheAgent.cpp
1246 https://bugs.webkit.org/show_bug.cgi?id=72734
1248 Reviewed by Timothy Hatcher.
1250 * inspector/Inspector.json:
1252 2011-11-19 David Barr <davidbarr@chromium.org>
1254 REGRESSION(r98542): Chromium: CSS text is rendered on page
1255 https://bugs.webkit.org/show_bug.cgi?id=71703
1257 Reviewed by Antti Koivisto.
1259 Matched UA declarations uncacheable when using simpleDefaultStyleSheet.
1261 Test: fast/css/style-tag-display-none.html
1263 * css/CSSStyleSelector.cpp:
1264 (WebCore::CSSStyleSelector::matchUARules):
1266 2011-11-19 Jay Civelli <jcivelli@chromium.org>
1268 When loading a MHTML document, make sure we set the base URL before
1269 we notify the frame was committed (so the document has the right base
1270 URL when the notification happens).
1271 https://bugs.webkit.org/show_bug.cgi?id=72788
1273 Reviewed by Adam Barth.
1275 * loader/FrameLoader.cpp:
1276 (WebCore::FrameLoader::receivedFirstData):
1278 2011-11-19 Adam Barth <abarth@webkit.org>
1280 Integrate Source/WTF with the Chromium build system
1281 https://bugs.webkit.org/show_bug.cgi?id=72790
1283 Reviewed by Eric Seidel.
1285 Add a dependency on the new WTF.
1287 * WebCore.gyp/WebCore.gyp:
1289 2011-11-18 Takashi Toyoshima <toyoshim@chromium.org>
1291 [Chromium] [WebSocket] export WebSocketChannel interface for plugins
1292 https://bugs.webkit.org/show_bug.cgi?id=72016
1294 Reviewed by Darin Fisher.
1296 Add a interface to send raw binary data.
1297 This interface is used by WebWebSocketChannel implementation
1300 No new tests because just export a interface.
1302 * websockets/WebSocketChannel.cpp:
1303 (WebCore::WebSocketChannel::send):
1304 * websockets/WebSocketChannel.h:
1306 2011-11-18 Vineet Chaudhary <vineet.chaudhary@motorola.com>
1308 https://bugs.webkit.org/show_bug.cgi?id=72591
1309 Remove document.width / document.height
1311 Reviewed by Darin Adler.
1313 Removed document.width/document.height from JS bindings,
1314 but keeping the same for ObjC bindings. Also it should use
1315 document.body.clientWidth and document.body.clientHeight instead.
1317 * html/HTMLDocument.idl:
1319 2011-11-18 Martin Robinson <mrobinson@igalia.com>
1323 * page/Navigator.idl: Properly disable the webkitGamepads API if gamepad
1324 isn't enabled at compile time.
1326 2011-11-18 Daniel Bates <dbates@rim.com>
1328 Add CMake build infrastructure for the BlackBerry port
1329 https://bugs.webkit.org/show_bug.cgi?id=72768
1331 Reviewed by Antonio Gomes.
1333 * CMakeLists.txt: At this time the BlackBerry port doesn't support generating
1334 DOM bindings from the SVG IDLs. See WebKit bug #72773.
1335 * PlatformBlackBerry.cmake: Added.
1337 2011-11-18 Sheriff Bot <webkit.review.bot@gmail.com>
1339 Unreviewed, rolling out r100826.
1340 http://trac.webkit.org/changeset/100826
1341 https://bugs.webkit.org/show_bug.cgi?id=72786
1343 Broke Chromium Mac build (Requested by aklein on #webkit).
1345 * page/ChromeClient.h:
1346 * page/FrameView.cpp:
1348 * platform/ScrollView.cpp:
1349 (WebCore::ScrollView::wheelEvent):
1350 * platform/ScrollView.h:
1351 * platform/ScrollableArea.h:
1352 (WebCore::ScrollableArea::scrollbarStyleChanged):
1353 * platform/mac/ScrollAnimatorMac.mm:
1354 (WebCore::ScrollAnimatorMac::updateScrollerStyle):
1356 2011-11-18 Alpha Lam <hclam@chromium.org>
1358 [chromium] composited layers are blurry with a zoom-in page scale factor
1359 https://bugs.webkit.org/show_bug.cgi?id=71225
1361 Reviewed by James Robinson.
1363 Pass contents scale factor to the compositor such that it can:
1364 1. Adjust contentBounds() of the compositoer layers with content scale.
1365 2. Apply the content scale in the painter for texture update in better resolution.
1366 3. Apply the content scale to the dirty rect in CanvasLayerTextureUpdater.
1368 This change fixed blurry problem for all tiled layer types and is not limited to
1369 position:fixed layers.
1371 Tests: compositing/geometry/fixed-position-composited-page-scale-down.html
1372 compositing/geometry/fixed-position-composited-page-scale.html
1373 compositing/geometry/fixed-position-iframe-composited-page-scale-down.html
1374 compositing/geometry/fixed-position-iframe-composited-page-scale.html
1375 compositing/geometry/fixed-position-transform-composited-page-scale-down.html
1376 compositing/geometry/fixed-position-transform-composited-page-scale.html
1378 * platform/graphics/chromium/GraphicsLayerChromium.cpp:
1379 (WebCore::GraphicsLayerChromium::setTransform):
1380 (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
1381 (WebCore::GraphicsLayerChromium::updateContentsScale):
1382 (WebCore::GraphicsLayerChromium::contentsScale):
1383 (WebCore::GraphicsLayerChromium::deviceOrPageScaleFactorChanged):
1384 * platform/graphics/chromium/GraphicsLayerChromium.h:
1385 * platform/graphics/chromium/ImageLayerChromium.cpp:
1386 (WebCore::ImageLayerTextureUpdater::prepareToUpdate):
1387 (WebCore::ImageLayerChromium::needsContentsScale):
1388 * platform/graphics/chromium/ImageLayerChromium.h:
1389 * platform/graphics/chromium/LayerChromium.cpp:
1390 (WebCore::LayerChromium::LayerChromium):
1391 (WebCore::LayerChromium::setContentsScale):
1392 * platform/graphics/chromium/LayerChromium.h:
1393 (WebCore::LayerChromium::needsContentsScale):
1394 (WebCore::LayerChromium::contentsScale):
1395 * platform/graphics/chromium/LayerTextureUpdater.h:
1396 * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
1397 (WebCore::LayerTextureUpdaterCanvas::paintContents):
1398 (WebCore::LayerTextureUpdaterBitmap::prepareToUpdate):
1399 (WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate):
1400 * platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
1401 * platform/graphics/chromium/TiledLayerChromium.cpp:
1402 (WebCore::TiledLayerChromium::needsContentsScale):
1403 (WebCore::TiledLayerChromium::contentBounds):
1404 (WebCore::TiledLayerChromium::prepareToUpdate):
1405 * platform/graphics/chromium/TiledLayerChromium.h:
1407 2011-11-18 Igor Oliveira <igor.oliveira@openbossa.org>
1409 [WK2][Qt] Move Accelerated Composite animations to UIProcess
1410 https://bugs.webkit.org/show_bug.cgi?id=72753
1412 Add helper method to synchronize animations in TextureMapper.
1414 Reviewed by Noam Rosenthal.
1416 * platform/graphics/texmap/TextureMapperNode.cpp:
1417 (WebCore::TextureMapperNode::syncAnimationsRecursively):
1418 * platform/graphics/texmap/TextureMapperNode.h:
1420 2011-11-18 Scott Graham <scottmg@chromium.org>
1422 IDL changes for gamepad support
1423 https://bugs.webkit.org/show_bug.cgi?id=71753
1425 Reviewed by Adam Barth.
1427 IDL changes and associated plumbing to expose list of gamepad objects
1428 on navigator object (per current spec). Full patch is
1429 https://bugs.webkit.org/show_bug.cgi?id=69451. Only basic existence
1430 test until more plumbing in future patches.
1432 Test: gamepad/gamepad-api.html
1435 * bindings/generic/RuntimeEnabledFeatures.h:
1436 (WebCore::RuntimeEnabledFeatures::setWebkitGamepadsEnabled):
1437 (WebCore::RuntimeEnabledFeatures::webkitGamepadsEnabled):
1438 * page/Gamepad.cpp: Added.
1439 (WebCore::Gamepad::Gamepad):
1440 (WebCore::Gamepad::axes):
1441 (WebCore::Gamepad::buttons):
1442 (WebCore::Gamepad::~Gamepad):
1443 * page/Gamepad.h: Added.
1444 * page/Gamepad.idl: Added.
1445 * page/GamepadList.cpp: Added.
1446 (WebCore::GamepadList::~GamepadList):
1447 (WebCore::GamepadList::set):
1448 (WebCore::GamepadList::length):
1449 (WebCore::GamepadList::item):
1450 * page/GamepadList.h: Added.
1451 (WebCore::GamepadList::create):
1452 (WebCore::GamepadList::GamepadList):
1453 * page/GamepadList.idl: Added.
1454 * page/Navigator.cpp:
1455 (WebCore::Navigator::webkitGamepads):
1457 * page/Navigator.idl:
1459 2011-11-18 Sheriff Bot <webkit.review.bot@gmail.com>
1461 Unreviewed, rolling out r100693.
1462 http://trac.webkit.org/changeset/100693
1463 https://bugs.webkit.org/show_bug.cgi?id=72779
1465 This patch caused a rendering regression (see bug 72770)
1466 (Requested by philip__ on #webkit).
1468 * rendering/RenderObject.cpp:
1469 (WebCore::RenderObject::setStyle):
1470 * rendering/style/RenderStyle.cpp:
1471 (WebCore::RenderStyle::diff):
1473 2011-11-18 Simon Fraser <simon.fraser@apple.com>
1475 Reflection on composited element doesn't update if the element changes to show no content
1476 https://bugs.webkit.org/show_bug.cgi?id=72774
1478 Reviewed by Chris Marrin.
1480 When a style change results in a reflected element losing its backing store,
1481 we need to clear the backing stores on the layer clones as well.
1483 Test: compositing/reflections/become-simple-composited-reflection.html
1485 * platform/graphics/ca/GraphicsLayerCA.cpp:
1486 (WebCore::GraphicsLayerCA::updateLayerDrawsContent):
1488 2011-11-18 Daniel Cheng <dcheng@chromium.org>
1490 [chromium] Use correct backing store for ChromiumDataObject in pasteboard writes.
1491 https://bugs.webkit.org/show_bug.cgi?id=72767
1493 Reviewed by Tony Chang.
1495 Covered by existing tests.
1497 * editing/chromium/EditorChromium.cpp:
1498 (WebCore::Editor::newGeneralClipboard):
1499 * page/chromium/EventHandlerChromium.cpp:
1500 (WebCore::EventHandler::createDraggingClipboard):
1501 * platform/chromium/ChromiumDataObject.cpp:
1502 (WebCore::ChromiumDataObject::types):
1503 (WebCore::ChromiumDataObject::getData):
1504 (WebCore::ChromiumDataObject::containsFilenames):
1505 (WebCore::ChromiumDataObject::ChromiumDataObject):
1506 * platform/chromium/ChromiumDataObject.h:
1507 (WebCore::ChromiumDataObject::createFromPasteboard):
1508 (WebCore::ChromiumDataObject::create):
1509 (WebCore::ChromiumDataObject::storageMode):
1510 * platform/chromium/ClipboardChromium.cpp:
1511 (WebCore::ClipboardChromium::hasData):
1513 2011-11-18 Chris Evans <cevans@google.com>
1515 Crash with ranges across a detached, reparented node tree
1516 https://bugs.webkit.org/show_bug.cgi?id=72757
1518 Reviewed by Adam Barth.
1520 Test: fast/dom/move-detached-child-in-range.html
1522 * dom/RangeBoundaryPoint.h:
1523 (WebCore::RangeBoundaryPoint::childBefore): protect the raw child node from getting pulled from under us.
1525 2011-11-18 Beth Dakin <bdakin@apple.com>
1527 https://bugs.webkit.org/show_bug.cgi?id=72551
1528 When the recommended scrollbar style changes, WKView's tracking options should
1531 <rdar://problem/10409328>
1533 Reviewed by Darin Adler.
1535 This new ChromeClient function is called when the recommended scrollbar style
1536 changes. This way, WebKit can respond to the change by adjusting its mouse
1538 * page/ChromeClient.h:
1539 (WebCore::ChromeClient::recommendedScrollbarStyleDidChange):
1541 Existing ScrollableArea function scrollbarStyleChanged() now takes an int
1542 indicating the new scrollbar style and a bool indicating whether it is necessary
1543 to force an update. It used to be the case that this function was ONLY used to
1544 force an update (and only called when an updated was needed), but now that it must
1545 also call into the ChromeClient, it is necessary to include a bool tracking
1546 whether we need to force an update. New implementation on FrameView is responsible
1547 for calling ChromeClient, and then that calls into the pre-existing ScrollView
1548 function for the forceUpdate part.
1549 * page/FrameView.cpp:
1550 (WebCore::FrameView::scrollbarStyleChanged):
1552 * platform/ScrollView.cpp:
1553 (WebCore::ScrollView:: scrollbarStyleChanged):
1554 * platform/ScrollView.h:
1555 * platform/ScrollableArea.h:
1556 (WebCore::ScrollableArea::scrollbarStyleChanged):
1557 * platform/mac/ScrollAnimatorMac.mm:
1558 (WebCore::ScrollAnimatorMac::updateScrollerStyle):
1560 2011-11-18 Kelly Norton <knorton@google.com>
1562 Fixes several more void functions in RenderObject that return values.
1563 https://bugs.webkit.org/show_bug.cgi?id=72750
1565 Reviewed by Adam Barth.
1567 * rendering/RenderBlock.cpp:
1568 (WebCore::RenderBlock::updateBeforeAfterContent):
1569 (WebCore::RenderBlock::addChildToContinuation):
1570 (WebCore::RenderBlock::addChildToAnonymousColumnBlocks):
1571 (WebCore::RenderBlock::addChild):
1572 (WebCore::RenderBlock::addChildIgnoringContinuation):
1574 2011-11-18 Shawn Singh <shawnsingh@chromium.org>
1576 [chromium] Add some useful text to existing debug dump
1577 https://bugs.webkit.org/show_bug.cgi?id=72576
1579 Reviewed by James Robinson.
1581 No new tests needed.
1583 * platform/graphics/chromium/cc/CCLayerImpl.cpp:
1584 (WebCore::CCLayerImpl::dumpLayerProperties):
1585 * platform/graphics/chromium/cc/CCRenderSurface.cpp:
1586 (WebCore::CCRenderSurface::dumpSurface):
1588 2011-11-18 Xiaomei Ji <xji@chromium.org>
1590 REGRESSION: rtl horizontal scrollbar / resize bug - Body shifts on resize when scrolled all the way to the left
1591 https://bugs.webkit.org/show_bug.cgi?id=70395
1593 Reviewed by Tony Chang.
1595 This patch fixes the problem in Mac and Chromium Mac.
1597 The existing test fast/dom/rtl-scroll-to-leftmost-and-resize.html seems does not really work in Mac DRT
1598 (the browswer window is not resized). It works in Chromium-Mac. And Chromium-Mac's code
1601 * platform/chromium/ScrollAnimatorChromiumMac.mm:
1602 (WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint):
1603 * platform/mac/ScrollAnimatorMac.mm:
1604 (WebCore::ScrollAnimatorMac::immediateScrollToPoint):
1606 2011-11-18 Martin Robinson <mrobinson@igalia.com>
1608 REGRESSION (r99924): broke 2 pasteboard tests on GTK
1609 https://bugs.webkit.org/show_bug.cgi?id=72131
1611 Reviewed by Tony Chang.
1613 * platform/gtk/ClipboardGtk.cpp:
1614 (WebCore::ClipboardGtk::clearData): Call clearAll now.
1615 (WebCore::ClipboardGtk::clearAllData): Call clearAllExceptFilenames now.
1616 * platform/gtk/DataObjectGtk.cpp:
1617 (WebCore::DataObjectGtk::clearAllExceptFilenames): Renamed from clear.
1618 (WebCore::DataObjectGtk::clearAll): Added this method which also clear filenames.
1619 * platform/gtk/DataObjectGtk.h:
1620 * platform/gtk/PasteboardGtk.cpp: Call clear before setting new clipboard data.
1621 (WebCore::Pasteboard::writeSelection): Ditto.
1622 (WebCore::Pasteboard::writePlainText): Ditto.
1623 (WebCore::Pasteboard::writeURL): Ditto.
1624 (WebCore::Pasteboard::writeImage): Ditto.
1625 * platform/gtk/PasteboardHelper.cpp:
1626 (WebCore::clearClipboardContentsCallback): Use the clearAll method now.
1628 2011-11-18 Vineet Chaudhary <vineet.chaudhary@motorola.com>
1630 Access key should work on all elements.
1631 https://bugs.webkit.org/show_bug.cgi?id=71854
1633 Reviewed by Ryosuke Niwa.
1635 All HTML elements can have the accesskey content attribute set.
1636 Specification http://dev.w3.org/html5/spec/Overview.html#the-accesskey-attribute
1637 Adding "accessKey" attribute to HTMLElement.idl file as [Reflect].
1639 Test: fast/forms/access-key-for-all-elements.html
1641 * bindings/objc/PublicDOMInterfaces.h: Moved properties form subclass to base class.
1642 * html/BaseButtonInputType.cpp:
1643 (WebCore::BaseButtonInputType::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
1644 * html/BaseButtonInputType.h: Ditto
1645 * html/BaseCheckableInputType.cpp:
1646 (WebCore::BaseCheckableInputType::accessKeyAction): Ditto
1647 * html/BaseCheckableInputType.h: Ditto
1648 * html/HTMLAnchorElement.cpp:
1649 (WebCore::HTMLAnchorElement::accessKeyAction): Ditto
1650 * html/HTMLAnchorElement.h: Ditto
1651 * html/HTMLAnchorElement.idl: Removed redundant IDL attribute entries.
1652 * html/HTMLAreaElement.idl: Removed redundant IDL attribute entries.
1653 * html/HTMLButtonElement.cpp:
1654 (WebCore::HTMLButtonElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
1655 * html/HTMLButtonElement.h: Ditto
1656 * html/HTMLButtonElement.idl: Removed redundant IDL attribute entries.
1657 * html/HTMLElement.cpp:
1658 (WebCore::HTMLElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
1659 If the element does not have a defined activation behavior, fire a click event at the element.
1660 * html/HTMLElement.h: Ditto
1661 * html/HTMLElement.idl: Added accessKey IDL attribute.
1662 * html/HTMLInputElement.cpp:
1663 (WebCore::HTMLInputElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
1664 * html/HTMLInputElement.h: Ditto
1665 * html/HTMLInputElement.idl: Removed redundant IDL attribute entries.
1666 * html/HTMLLabelElement.cpp:
1667 (WebCore::HTMLLabelElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
1668 * html/HTMLLabelElement.h: Ditto
1669 * html/HTMLLabelElement.idl: Removed redundant IDL attribute entries.
1670 * html/HTMLLegendElement.cpp:
1671 (WebCore::HTMLLegendElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
1672 * html/HTMLLegendElement.h: Ditto
1673 * html/HTMLLegendElement.idl: Removed redundant IDL attribute entries.
1674 * html/HTMLOptGroupElement.h: Renamed variable sendToAnyElement to sendMouseEvents.
1675 * html/HTMLSelectElement.cpp:
1676 (WebCore::HTMLSelectElement::accessKeyAction): Ditto
1677 * html/HTMLSelectElement.h: Ditto
1678 * html/HTMLTextAreaElement.h: Ditto
1679 * html/HTMLTextAreaElement.idl: Removed redundant IDL attribute entries.
1680 * html/HiddenInputType.h: Renamed variable sendToAnyElement to sendMouseEvents.
1681 * html/InputType.h: Ditto
1682 * html/RangeInputType.cpp:
1683 (WebCore::RangeInputType::accessKeyAction): Ditto
1684 * html/RangeInputType.h: Ditto
1686 2011-11-18 Simon Fraser <simon.fraser@apple.com>
1688 Appearance of compound transform animations under apps linked on SnowLeopard is incorrect
1689 https://bugs.webkit.org/show_bug.cgi?id=72641
1691 <rdar://problem/10314267>
1693 Reviewed by Dean Jackson.
1695 GraphicsLayerCA contains a "linked on or after" check to account for a bug in
1696 Core Animation on SnowLeopard and earlier, which is that CA would apply the list
1697 of animations in reverse order.
1699 Our previous fix was incorrect, because it only adjusted the 'additive' property
1700 of the animation list based on ordering, rather than flipping the entire list.
1701 This change reverses the list of animations before giving them to CA, which fixes
1704 Test: animations/additive-transform-animations.html
1706 * platform/graphics/ca/GraphicsLayerCA.cpp:
1707 (WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
1708 (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
1709 * platform/graphics/ca/GraphicsLayerCA.h:
1711 2011-11-18 Tim Horton <timothy_horton@apple.com>
1713 -webkit-cross-fade rendered incorrectly in overflow divs
1714 https://bugs.webkit.org/show_bug.cgi?id=72693
1715 <rdar://problem/10468564>
1717 Reviewed by Simon Fraser.
1719 Respect the desired source rectangle when rendering the cross-fade.
1721 Test: css3/images/cross-fade-overflow-position.html
1723 * platform/graphics/CrossfadeGeneratedImage.cpp:
1724 (WebCore::CrossfadeGeneratedImage::drawCrossfade):
1725 (WebCore::CrossfadeGeneratedImage::draw):
1726 (WebCore::CrossfadeGeneratedImage::drawPattern):
1727 * platform/graphics/CrossfadeGeneratedImage.h:
1729 2011-11-18 Raphael Kubo da Costa <kubo@profusion.mobi>
1731 Unreviewed build fix; r100686 broke the EFL build when Geolocation
1734 * platform/efl/GeolocationServiceEfl.cpp: Only declare
1735 s_factoryFunction if CLIENT_BASED_GEOLOCATION is off, otherwise it is
1736 also declared in GeolocationService.cpp.
1738 2011-11-18 Igor Oliveira <igor.oliveira@openbossa.org>
1740 [TextureMapper] computePerspectiveTransformIfNeeded is called twice in TextureMapperNode::syncCompositingState
1741 https://bugs.webkit.org/show_bug.cgi?id=72727
1743 TextureMapperNode::computeAllTransforms already has a call to TextureMapperNode::computePerspectiveTransformIfNeeded,
1744 so it does not need to be called again after TextureMapperNode::computeAllTransforms.
1746 Reviewed by Noam Rosenthal.
1748 * platform/graphics/texmap/TextureMapperNode.cpp:
1749 (WebCore::TextureMapperNode::syncCompositingState):
1751 2011-11-18 Mihnea Ovidenie <mihnea@adobe.com>
1753 Fix compilation warning in ComplexTextControllerCoreText.mm
1754 https://bugs.webkit.org/show_bug.cgi?id=72702
1756 Reviewed by Andreas Kling.
1758 No functionality changed, so no new tests.
1760 * platform/graphics/mac/ComplexTextControllerCoreText.mm:
1761 (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
1763 2011-11-18 Pavel Feldman <pfeldman@google.com>
1765 Not reviewed: restore front-end compilability via updating externs and JS generator.
1767 * inspector/front-end/ElementsPanel.js:
1768 (WebInspector.ElementsPanel.prototype.jumpToNextSearchResult):
1769 (WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult):
1770 * inspector/front-end/externs.js:
1771 (WebInspector.showPanelForAnchorNavigation):
1772 * inspector/generate-protocol-externs:
1774 2011-11-17 Pavel Feldman <pfeldman@google.com>
1776 Web Inspector: dispatch messages from the front-end to the backend asynchronously.
1777 https://bugs.webkit.org/show_bug.cgi?id=72621
1779 We should align the way we dispatch messages from the front-end to backend across the environments:
1780 - WebKit has it synchronoulsly
1781 - Chromium has it asynchronously
1782 - Remote debugging has it asynchronously
1783 Making it asynchronous made a number of flaky Qt tests pass.
1785 Tests uncovered console agent problem that was also fixed.
1787 Reviewed by Yury Semikhatsky.
1789 * inspector/InspectorConsoleAgent.cpp:
1790 (WebCore::InspectorConsoleAgent::clearFrontend):
1791 * inspector/InspectorFrontendClient.h:
1792 * inspector/InspectorFrontendClientLocal.cpp:
1793 (WebCore::InspectorBackendDispatchTask::InspectorBackendDispatchTask):
1794 (WebCore::InspectorBackendDispatchTask::dispatch):
1795 (WebCore::InspectorBackendDispatchTask::reset):
1796 (WebCore::InspectorBackendDispatchTask::onTimer):
1797 (WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
1798 (WebCore::InspectorFrontendClientLocal::windowObjectCleared):
1799 (WebCore::InspectorFrontendClientLocal::sendMessageToBackend):
1800 * inspector/InspectorFrontendClientLocal.h:
1802 2011-11-18 Iain Merrick <husky@google.com>
1804 [chromium] Pass screen refresh rate into compositor.
1805 https://bugs.webkit.org/show_bug.cgi?id=71040
1807 Reviewed by Tony Gentilcore.
1809 Covered by CCLayerTreeHostTest.
1811 * platform/PlatformScreen.h:
1812 * platform/chromium/PlatformScreenChromium.cpp:
1813 (WebCore::screenRefreshRate):
1814 * platform/chromium/PlatformSupport.h:
1815 * platform/graphics/chromium/cc/CCLayerTreeHost.h:
1816 (WebCore::CCSettings::CCSettings):
1817 * platform/graphics/chromium/cc/CCThreadProxy.cpp:
1818 (WebCore::CCThreadProxy::initializeImplOnImplThread):
1820 2011-11-18 Alexandru Chiculita <achicu@adobe.com>
1822 [CSSShaders] Implement the computed style for mesh parameters of the custom() filter
1823 https://bugs.webkit.org/show_bug.cgi?id=72478
1825 Reviewed by Dean Jackson.
1827 Added parsing and computed style for the mesh rows, columns, mesh box type
1828 (filter-box, border-box, content-box and padding-box) and the detached mode.
1830 Also fixed a case where "custom(none, 10, 10 filter-box)" was incorrectly
1831 treated as "custom(none, 10)".
1833 * css/CSSComputedStyleDeclaration.cpp:
1834 (WebCore::CSSComputedStyleDeclaration::valueForFilter):
1835 * css/CSSParser.cpp:
1836 (WebCore::CSSParser::parseCustomFilter): Fixed a case where invalid syntax was parsed as correct syntax.
1837 * css/CSSPrimitiveValueMappings.h:
1838 (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1839 (WebCore::CSSPrimitiveValue::operator CustomFilterOperation::MeshBoxType):
1840 * css/CSSStyleSelector.cpp:
1841 (WebCore::CSSStyleSelector::createCustomFilterOperation):
1842 * css/CSSValueList.h:
1843 (WebCore::CSSValueListIterator::isPrimitiveValue):
1844 * platform/graphics/filters/CustomFilterOperation.h:
1846 2011-11-18 Adam Barth <abarth@webkit.org>
1848 Remove unneeded include (and ifdef) from V8DOMWindowCustom.cpp
1849 https://bugs.webkit.org/show_bug.cgi?id=72705
1851 Reviewed by Eric Seidel.
1855 * bindings/v8/custom/V8DOMWindowCustom.cpp:
1857 2011-11-18 Adam Barth <abarth@webkit.org>
1859 Move some mediastream related files into the mediastream directory
1860 https://bugs.webkit.org/show_bug.cgi?id=72695
1862 Reviewed by Eric Seidel.
1864 Just moving the files to the proper directory.
1866 * GNUmakefile.list.am:
1868 * mediastream/NavigatorUserMediaError.h: Renamed from Source/WebCore/page/NavigatorUserMediaError.h.
1869 (WebCore::NavigatorUserMediaError::create):
1870 (WebCore::NavigatorUserMediaError::~NavigatorUserMediaError):
1871 (WebCore::NavigatorUserMediaError::code):
1872 (WebCore::NavigatorUserMediaError::NavigatorUserMediaError):
1873 * mediastream/NavigatorUserMediaError.idl: Renamed from Source/WebCore/page/NavigatorUserMediaError.idl.
1874 * mediastream/NavigatorUserMediaErrorCallback.h: Renamed from Source/WebCore/page/NavigatorUserMediaErrorCallback.h.
1875 (WebCore::NavigatorUserMediaErrorCallback::~NavigatorUserMediaErrorCallback):
1876 * mediastream/NavigatorUserMediaErrorCallback.idl: Renamed from Source/WebCore/page/NavigatorUserMediaErrorCallback.idl.
1877 * mediastream/NavigatorUserMediaSuccessCallback.h: Renamed from Source/WebCore/page/NavigatorUserMediaSuccessCallback.h.
1878 (WebCore::NavigatorUserMediaSuccessCallback::~NavigatorUserMediaSuccessCallback):
1879 * mediastream/NavigatorUserMediaSuccessCallback.idl: Renamed from Source/WebCore/page/NavigatorUserMediaSuccessCallback.idl.
1881 2011-11-18 Andrey Kosyakov <caseq@chromium.org>
1883 Web Inspector: [Extensions API] Provide a way for extension to create a status bar icon
1884 https://bugs.webkit.org/show_bug.cgi?id=45955
1886 Reviewed by Pavel Feldman.
1888 * inspector/front-end/ExtensionAPI.js:
1889 (injectedExtensionAPI.ExtensionPanelImpl.prototype.createStatusBarButton):
1890 (injectedExtensionAPI):
1891 (injectedExtensionAPI.ButtonImpl.prototype.update):
1892 * inspector/front-end/ExtensionPanel.js:
1893 (WebInspector.ExtensionPanel):
1894 (WebInspector.ExtensionPanel.prototype.get statusBarItems):
1895 (WebInspector.ExtensionPanel.prototype.addStatusBarItem):
1896 (WebInspector.ExtensionButton):
1897 (WebInspector.ExtensionButton.prototype.update):
1898 (WebInspector.ExtensionButton.prototype._onClicked):
1899 * inspector/front-end/ExtensionServer.js:
1900 (WebInspector.ExtensionServer):
1901 (WebInspector.ExtensionServer.prototype.notifyButtonClicked):
1902 (WebInspector.ExtensionServer.prototype._onCreateStatusBarButton):
1903 (WebInspector.ExtensionServer.prototype._onUpdateButton):
1904 (WebInspector.ExtensionServer.prototype._onCreateSidebarPane):
1905 * inspector/front-end/inspector.css:
1906 (button.status-bar-item.extension):
1908 2011-11-18 Tommy Widenflycht <tommyw@google.com>
1910 MediaStream API: Merging the PeerConnectionHandler.h files
1911 https://bugs.webkit.org/show_bug.cgi?id=72611
1913 Reviewed by Adam Barth.
1915 No actual code changes.
1918 * GNUmakefile.list.am:
1919 * WebCore.gyp/WebCore.gyp:
1921 * platform/mediastream/PeerConnectionHandler.h: Renamed from Source/WebCore/platform/mediastream/chromium/PeerConnectionHandler.h.
1922 * platform/mediastream/gstreamer/PeerConnectionHandler.h: Removed.
1924 2011-11-17 Simon Hausmann <simon.hausmann@nokia.com>
1926 [Qt] Layer violation: ThirdPartyCookiesQt.cpp uses QWebSettings in two places
1927 https://bugs.webkit.org/show_bug.cgi?id=72597
1929 Reviewed by Kenneth Rohde Christiansen.
1931 Moved code that queries the third party cookie policy from QWebSettings
1932 out of WebCore. Instead NetworkingContext has now the interface that allows
1933 delegating the functionality into WebKit/qt.
1935 In order to do that we need to pass the NetworkingContext around, which is used to
1936 retrieve the cookie jar and the originating frame object pointer.
1938 * platform/network/NetworkingContext.h: Add interface.
1939 * platform/network/qt/QNetworkReplyHandler.cpp:
1940 (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): Pass NetworkingContext to ResourceRequest::toNetworkRequest.
1941 (WebCore::QNetworkReplyHandler::redirect): Ditto.
1942 * platform/network/qt/ResourceRequest.h: Replaced originatingObject parameter with NetworkingContext, which can
1943 also provide the same plus more (cookie jar, policy callback).
1944 * platform/network/qt/ResourceRequestQt.cpp:
1945 (WebCore::ResourceRequest::toNetworkRequest): Ditto.
1946 * platform/qt/CookieJarQt.cpp: Simplify to use NetworkingContext to get cookie jar and
1947 call new thirdPartyCookiePolicyPermits API that takes the context as parameter.
1948 (WebCore::networkingContext):
1949 (WebCore::setCookies):
1951 (WebCore::cookieRequestHeaderFieldValue):
1952 (WebCore::cookiesEnabled):
1953 * platform/qt/ThirdPartyCookiesQt.cpp: Replace up-casting to QWebFrame and use of QWebSettings
1954 with useage of NetworkingContext.
1955 (WebCore::thirdPartyCookiePolicyPermits):
1956 * platform/qt/ThirdPartyCookiesQt.h:
1958 2011-11-17 Kenichi Ishibashi <bashi@chromium.org>
1960 crash: WebCore::FontPlatformData::roundsGlyphAdvances on Lion
1961 https://bugs.webkit.org/show_bug.cgi?id=71997
1963 Reviewed by Dan Bernstein.
1965 The cause is a null dereference of a fontData that is stored in
1966 ComplexTextRun. The fontData is initialized by using the
1967 fontCache, but it could be null when the font is in fallback
1968 list. The reason a font from the fallback list might not be in the
1969 font Cache is that it may be a web font. Before looking up the
1970 fontCache, try to see whether the font is in the fallback list.
1972 No new tests. We don't have webfonts that can produce the problem.
1974 * platform/graphics/mac/ComplexTextControllerCoreText.mm:
1975 (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): See fallback list first, then lookup cache.
1977 2011-11-17 Kaustubh Atrawalkar <kaustubh@motorola.com>
1979 Remove initProgressEvent method
1980 https://bugs.webkit.org/show_bug.cgi?id=71340
1982 Reviewed by Adam Barth.
1984 This method has been removed from the spec draft.
1985 http://www.w3.org/TR/progress-events/#interface-progressevent
1987 No new tests. Removed method.
1989 * dom/ProgressEvent.cpp:
1990 * dom/ProgressEvent.h:
1991 * dom/ProgressEvent.idl:
1993 2011-11-17 Eunmi Lee <eunmi15.lee@samsung.com>
1995 [EFL] Move keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName() to the
1996 EflKeyboardUtilities.cpp to use in the WebKit2
1997 https://bugs.webkit.org/show_bug.cgi?id=62451
1999 Reviewed by Martin Robinson.
2001 The keyIdentifierForEvasKeyName() and windowsKeyCodeForEvasKeyName() were static functions
2002 in the PlatformKeyboardEventEfl.cpp. But they are also needed in the WebKit2 EFL port, so I
2003 moved them to the separated file - EflKeyboardUtilities.cpp.
2005 * PlatformEfl.cmake:
2006 * platform/efl/EflKeyboardUtilities.cpp: Copied from Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp.
2007 (WebCore::createKeyMap):
2008 (WebCore::createWindowsKeyMap):
2009 (WebCore::keyIdentifierForEvasKeyName):
2010 (WebCore::windowsKeyCodeForEvasKeyName):
2011 * platform/efl/EflKeyboardUtilities.h: Added.
2012 * platform/efl/PlatformKeyboardEventEfl.cpp:
2014 2011-11-17 Martin Robinson <mrobinson@igalia.com>
2016 [GTK] The process freezes when you right click on windowless Flash
2017 https://bugs.webkit.org/show_bug.cgi?id=69123
2019 Reviewed by Xan Lopez.
2021 No new tests. I tried to create a layout test that exercised this
2022 issue, but it appears that EventSender clicks do not trigger
2023 it. This is covered by the manual tests containing Flash.
2025 * plugins/PluginPackage.cpp:
2026 (WebCore::PluginPackage::determineQuirks): Always activate the
2027 windowless Flash quirk if on x86_64 and X11.
2028 * plugins/gtk/PluginViewGtk.cpp:
2029 (WebCore::PluginView::handleMouseEvent): Avoid sending right-click
2030 events if we have the quirk.
2032 2011-11-17 Peter Rybin <peter.rybin@gmail.com>
2034 Web Inspector: clear fixme in generator script
2035 https://bugs.webkit.org/show_bug.cgi?id=71372
2037 Remove unnecessary field name map and update license year number.
2039 Reviewed by Pavel Feldman.
2041 * inspector/CodeGeneratorInspector.py:
2043 2011-11-17 Raphael Kubo da Costa <kubo@profusion.mobi>
2045 [EFL] Clean up the use of DATA_DIR in the buildsystem
2046 https://bugs.webkit.org/show_bug.cgi?id=72681
2048 Reviewed by Daniel Bates.
2050 Add the -DDATA_DIR definition here instead of defining it globally in
2051 OptionsEfl.cmake, as WebCore is the only place which needs it.
2053 No new tests, this is a buildsystem change.
2055 * PlatformEfl.cmake:
2057 2011-11-17 Adam Klein <adamk@chromium.org>
2059 Move JS recursion counter from V8Proxy to V8BindingPerIsolateData
2060 https://bugs.webkit.org/show_bug.cgi?id=72645
2062 Reviewed by Adam Barth.
2064 With the JS recursion level stored as a member of V8Proxy, it's tied
2065 to a frame. But this is incorrect, as there's no reason that a JS call
2066 stack need be restricted to a single frame (see my new test case for
2067 an example of code going across frames).
2069 In order to get the correct accounting of JS recursion level, per-Isolate
2070 is the right granularity (per dslomov), which is what this patch accomplishes.
2072 Test: storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html
2074 * bindings/v8/V8Binding.cpp:
2075 (WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):
2076 * bindings/v8/V8Binding.h:
2077 (WebCore::V8BindingPerIsolateData::recursionLevel):
2078 (WebCore::V8BindingPerIsolateData::incrementRecursionLevel):
2079 (WebCore::V8BindingPerIsolateData::decrementRecursionLevel):
2080 (WebCore::V8RecursionScope::V8RecursionScope):
2081 (WebCore::V8RecursionScope::~V8RecursionScope):
2082 * bindings/v8/V8Proxy.cpp:
2083 (WebCore::incrementRecursionLevel):
2084 (WebCore::decrementRecursionLevel):
2085 (WebCore::recursionLevel):
2086 (WebCore::V8Proxy::V8Proxy):
2087 (WebCore::V8Proxy::runScript):
2088 (WebCore::V8Proxy::callFunction):
2089 (WebCore::V8Proxy::didLeaveScriptContext):
2090 * bindings/v8/V8Proxy.h:
2092 2011-11-17 Robin Cao <robin.cao@torchmobile.com.cn>
2094 [chromium] Font::drawComplexText can not draw a segment of text run
2095 https://bugs.webkit.org/show_bug.cgi?id=72095
2097 Reviewed by Adam Barth.
2099 drawComplexText() should respect the 'from' and 'to' arguments.
2100 Drawing the whole text run may result in text overlapping.
2102 Test: platform/chromium-linux/fast/text/international/draw-complex-text-from-to.html
2104 * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
2105 (WebCore::ComplexTextController::glyphsForRange):
2106 * platform/graphics/chromium/ComplexTextControllerLinux.h:
2107 * platform/graphics/chromium/FontLinux.cpp:
2108 (WebCore::Font::drawComplexText):
2110 2011-11-17 Adam Barth <abarth@webkit.org>
2112 Unique SecurityOrigins shouldn't remember their old schemes and hosts
2113 https://bugs.webkit.org/show_bug.cgi?id=71745
2115 Reviewed by Darin Adler.
2117 This is the final step in this series of patches.
2119 This patch removes the forceUnique flag from SecurityOrigin::create.
2120 Now, we create unique origins without passing in the document's URL,
2121 preventing information from the document's URL from leaking into the
2126 (WebCore::Document::setIsViewSource):
2127 (WebCore::Document::initSecurityContext):
2128 * loader/cache/MemoryCache.cpp:
2129 (WebCore::MemoryCache::getOriginsWithCache):
2130 - Update this callsite to use createFromString, which does exactly
2131 what this code is doing manually.
2132 * page/SecurityOrigin.cpp:
2133 (WebCore::SecurityOrigin::create):
2134 * page/SecurityOrigin.h:
2136 2011-11-17 Vincent Scheib <scheib@chromium.org>
2138 Pointer Lock: Page Settings unecessary
2139 https://bugs.webkit.org/show_bug.cgi?id=72662
2141 Reviewed by Darin Fisher.
2145 * page/Settings.cpp:
2146 (WebCore::Settings::Settings):
2149 2011-11-17 James Robinson <jamesr@chromium.org>
2151 [chromium] Disable incremental uploading in threaded compositing path
2152 https://bugs.webkit.org/show_bug.cgi?id=72669
2154 Reviewed by Kenneth Russell.
2156 Since we don't currently support atomic incremental uploads, incremental uploads in the threaded path result in
2157 very strange-looking texture popping as tiles come in on pages that require more than 16 tile uploads per frame.
2158 This disables that logic (by setting the upload limit per frame to 99999) until we handle the incremental
2159 updates in an atomic fashion.
2161 * platform/graphics/chromium/cc/CCThreadProxy.cpp:
2162 (WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
2164 2011-11-06 Nat Duca <nduca@chromium.org>
2166 [chromium] Fix handling of setNeedsCommit and setNeedsAnimate in threaded mode
2167 https://bugs.webkit.org/show_bug.cgi?id=71638
2169 Reviewed by James Robinson.
2171 * platform/graphics/chromium/cc/CCThreadProxy.cpp:
2172 (WebCore::CCThreadProxy::CCThreadProxy):
2173 (WebCore::CCThreadProxy::setNeedsAnimate):
2174 (WebCore::CCThreadProxy::beginFrameAndCommit):
2176 2011-11-17 Adam Barth <abarth@webkit.org>
2178 Remove bogus ASSERT.
2180 * page/SecurityOrigin.cpp:
2181 (WebCore::SecurityOrigin::SecurityOrigin):
2183 2011-11-17 Peter Kasting <pkasting@google.com>
2185 Unreviewed, rolling out r100698.
2186 http://trac.webkit.org/changeset/100698
2187 https://bugs.webkit.org/show_bug.cgi?id=72239
2189 This change wasn't the problem either.
2192 (WebCore::Document::implicitClose):
2194 2011-11-17 David Reveman <reveman@chromium.org>
2196 [Chromium] Calls to paintContentsIfDirty() and updateCompositorResources() should be balanced.
2197 https://bugs.webkit.org/show_bug.cgi?id=72630
2199 Reviewed by James Robinson.
2201 Layer property changes during paintContent() can leave the layer
2202 in an invalid state as paintContentsIfDirty() has been called
2203 without a matching updateCompositorResources() call. Removing
2204 conditionals around these calls ensure they are balanced.
2206 This patch is tested by the following unit test:
2207 - CCLayerTreeHostTestOpacityChange.runMultiThread
2209 * platform/graphics/chromium/ContentLayerChromium.cpp:
2210 (WebCore::ContentLayerChromium::paintContentsIfDirty):
2211 * platform/graphics/chromium/VideoLayerChromium.cpp:
2212 (WebCore::VideoLayerChromium::updateCompositorResources):
2213 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
2214 (WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
2215 (WebCore::CCLayerTreeHost::paintLayerContents):
2216 (WebCore::CCLayerTreeHost::updateCompositorResources):
2217 * platform/graphics/chromium/cc/CCLayerTreeHost.h:
2219 2011-11-17 Peter Kasting <pkasting@google.com>
2221 Unreviewed, rolling out r100584.
2222 http://trac.webkit.org/changeset/100584
2223 https://bugs.webkit.org/show_bug.cgi?id=72239
2225 See if this change caused Linux dbg crashes.
2228 (WebCore::Document::implicitClose):
2230 2011-11-17 Adam Barth <abarth@webkit.org>
2232 Remove cargo-cult copy/pasting of ScriptExecutionContext namespace
2233 https://bugs.webkit.org/show_bug.cgi?id=72676
2235 Reviewed by Eric Seidel.
2237 It looks like this cargo-cult started with initDNSPrefetch being hacked
2238 into setSecurityOrigin. I've removed this hack along with the
2241 * dom/DOMImplementation.cpp:
2243 (WebCore::Document::setIsViewSource):
2244 (WebCore::Document::open):
2245 (WebCore::Document::initSecurityContext):
2246 (WebCore::Document::setSecurityOrigin):
2248 * xml/XSLTProcessor.cpp:
2250 2011-11-17 Peter Kasting <pkasting@google.com>
2252 Unreviewed, rolling out r100676.
2253 http://trac.webkit.org/changeset/100676
2254 https://bugs.webkit.org/show_bug.cgi?id=72393
2256 Looks like r100572 was not the source of the crashes.
2258 * bindings/js/ScriptDebugServer.cpp:
2259 (WebCore::ScriptDebugServer::canSetScriptSource):
2260 * bindings/js/ScriptDebugServer.h:
2261 * bindings/v8/ScriptDebugServer.cpp:
2262 (WebCore::ScriptDebugServer::stepOutOfFunction):
2263 (WebCore::ScriptDebugServer::canSetScriptSource):
2264 * bindings/v8/ScriptDebugServer.h:
2265 * inspector/CodeGeneratorInspector.py:
2266 * inspector/Inspector.json:
2267 * inspector/InspectorDebuggerAgent.cpp:
2268 (WebCore::InspectorDebuggerAgent::getCapabilities):
2269 * inspector/InspectorDebuggerAgent.h:
2270 * inspector/front-end/DebuggerModel.js:
2271 (WebInspector.DebuggerModel):
2272 (WebInspector.DebuggerModel.prototype.enableDebugger):
2273 (WebInspector.DebuggerModel.prototype.disableDebugger):
2274 (WebInspector.DebuggerModel.prototype.canSetScriptSource):
2275 * inspector/front-end/DebuggerPresentationModel.js:
2276 (WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
2277 * inspector/front-end/Settings.js:
2279 2011-11-17 Konstantin Scheglov <scheglov@google.com>
2281 Absolute child is not repainted when parent opacity changes
2282 https://bugs.webkit.org/show_bug.cgi?id=68777
2284 Reviewed by Simon Fraser.
2286 First time when we change opacity for parent we don't have layer, so
2287 diff=StyleDifferenceRepaint is used instead of diff=StyleDifferenceRepaintLayer.
2288 Layer is created later, in styleDidChange().
2289 So, when we recalculate later diff, we now check for diff=StyleDifferenceRepaintLayer and
2290 performs repaintIncludingDescendants().
2292 Test: fast/layers/layer-absolute-parent-opacity.html
2294 * rendering/RenderObject.cpp:
2295 (WebCore::RenderObject::setStyle): Call repaintIncludingDescendants() instead of repaint().
2296 * rendering/style/RenderStyle.cpp:
2297 (WebCore::RenderStyle::diff): Add ContextSensitivePropertyOpacity when change opacity.
2299 2011-11-17 Nate Chapin <japhet@chromium.org>
2301 r100311 dropped a RefPtr that is very
2302 helpful. Add it back.
2303 https://bugs.webkit.org/show_bug.cgi?id=72647
2305 Reviewed by Adam Barth.
2307 http/tests/misc/xslt-bad-import.html should
2308 stop crashing in full chromium builds.
2310 * loader/cache/CachedResourceLoader.cpp:
2311 (WebCore::CachedResourceLoader::loadDone):
2313 2011-11-17 Adam Barth <abarth@webkit.org>
2315 Refactor SecurityOrigin::create to be easier to understand
2316 https://bugs.webkit.org/show_bug.cgi?id=72342
2318 Reviewed by Eric Seidel.
2320 Over time, the SecurityOrigin constructor has grown a bit out of
2321 control. This patch attempts to separate the different concerns into
2322 free functions. The general approach is to put more logic in the
2323 "create" function and introduce a simple constructor for unique
2326 This patch shouldn't change any behavior.
2328 * page/SecurityOrigin.cpp:
2329 (WebCore::schemeRequiresAuthority):
2330 (WebCore::shouldUseInnerURL):
2331 (WebCore::extractInnerURL):
2332 (WebCore::isDirectory):
2333 (WebCore::shouldTreatAsUniqueOrigin):
2334 (WebCore::SecurityOrigin::SecurityOrigin):
2335 (WebCore::SecurityOrigin::create):
2336 (WebCore::SecurityOrigin::createUnique):
2337 (WebCore::SecurityOrigin::databaseIdentifier):
2338 * page/SecurityOrigin.h:
2340 2011-11-17 Shawn Singh <shawnsingh@chromium.org>
2342 [chromium] Fix minor style nit in CCLayerImpl
2343 https://bugs.webkit.org/show_bug.cgi?id=71070
2345 Reviewed by James Robinson.
2347 Fixes if-statements on several settors to follow WebKit
2348 conventions. Existing CCLayerImplTest unit tests already cover
2351 * platform/graphics/chromium/cc/CCLayerImpl.cpp:
2352 (WebCore::CCLayerImpl::setBounds):
2353 (WebCore::CCLayerImpl::setMaskLayer):
2354 (WebCore::CCLayerImpl::setReplicaLayer):
2355 (WebCore::CCLayerImpl::setDrawsContent):
2356 (WebCore::CCLayerImpl::setAnchorPoint):
2357 (WebCore::CCLayerImpl::setAnchorPointZ):
2358 (WebCore::CCLayerImpl::setBackgroundColor):
2359 (WebCore::CCLayerImpl::setMasksToBounds):
2360 (WebCore::CCLayerImpl::setOpaque):
2361 (WebCore::CCLayerImpl::setOpacity):
2362 (WebCore::CCLayerImpl::setPosition):
2363 (WebCore::CCLayerImpl::setPreserves3D):
2364 (WebCore::CCLayerImpl::setZoomAnimatorTransform):
2365 (WebCore::CCLayerImpl::setSublayerTransform):
2366 (WebCore::CCLayerImpl::setTransform):
2367 (WebCore::CCLayerImpl::setDebugBorderColor):
2368 (WebCore::CCLayerImpl::setDebugBorderWidth):
2369 (WebCore::CCLayerImpl::setContentBounds):
2370 (WebCore::CCLayerImpl::setScrollPosition):
2371 (WebCore::CCLayerImpl::setScrollDelta):
2372 (WebCore::CCLayerImpl::setScaleDelta):
2373 (WebCore::CCLayerImpl::setDoubleSided):
2375 2011-11-17 Michael Saboff <msaboff@apple.com>
2377 Leaks seen in MemoryPressureHandlerMac.mm on Leaks bot
2378 https://bugs.webkit.org/show_bug.cgi?id=72416
2380 Added code to release _cache_event_source and _timer_event_source
2381 after they are canceled. Also added defensive code to
2382 clean up the _timer_event_source in uninstall().
2384 Reviewed by Geoffrey Garen.
2386 No new tests, fixing leaks caught by leaks bot.
2388 * platform/mac/MemoryPressureHandlerMac.mm:
2389 (WebCore::MemoryPressureHandler::uninstall):
2390 (WebCore::MemoryPressureHandler::holdOff):
2392 2011-11-17 Ken Buchanan <kenrb@chromium.org>
2394 Crash from positioned generated content under run-in
2395 https://bugs.webkit.org/show_bug.cgi?id=70456
2397 Reviewed by David Hyatt.
2399 Modified handling of run-in children to clear generated children
2400 before removing the parent from the render tree. This caused problems
2401 with absolute positioned children being not properly removed from the
2402 positioned object list of the RenderView.
2404 * rendering/RenderBlock.cpp:
2405 (WebCore::RenderBlock::handleRunInChild):
2407 2011-11-17 Peter Kasting <pkasting@google.com>
2409 Unreviewed, rolling out r100572.
2410 https://bugs.webkit.org/show_bug.cgi?id=72393
2411 https://bugs.webkit.org/show_bug.cgi?id=72651
2413 May have caused seg faults on Chromium Linux dbg bot.
2415 * bindings/js/ScriptDebugServer.cpp:
2416 * bindings/js/ScriptDebugServer.h:
2417 * bindings/v8/ScriptDebugServer.cpp:
2418 (WebCore::ScriptDebugServer::stepOutOfFunction):
2419 * bindings/v8/ScriptDebugServer.h:
2420 * inspector/CodeGeneratorInspector.py:
2421 * inspector/Inspector.json:
2422 * inspector/InspectorDebuggerAgent.cpp:
2423 * inspector/InspectorDebuggerAgent.h:
2424 * inspector/front-end/DebuggerModel.js:
2425 (WebInspector.DebuggerModel):
2426 (WebInspector.DebuggerModel.prototype.enableDebugger):
2427 (WebInspector.DebuggerModel.prototype.disableDebugger):
2428 * inspector/front-end/DebuggerPresentationModel.js:
2429 (WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
2430 * inspector/front-end/Settings.js:
2432 2011-11-17 Sheriff Bot <webkit.review.bot@gmail.com>
2434 Unreviewed, rolling out r100652.
2435 http://trac.webkit.org/changeset/100652
2436 https://bugs.webkit.org/show_bug.cgi?id=72648
2438 "Caused outline-offset-min-assert.html to assert on debug
2439 builds" (Requested by mwenge2 on #webkit).
2441 * rendering/RenderObject.cpp:
2442 (WebCore::RenderObject::paintOutline):
2444 2011-11-17 Mark Rowe <mrowe@apple.com>
2446 <http://webkit.org/b/72637> Stop performing runtime version checks on OS versions where the check can never possibly fail.
2448 Reviewed by Simon Fraser.
2450 * platform/graphics/cg/ImageBufferDataCG.cpp:
2451 (WebCore::haveVImageRoundingErrorFix): When not targeting Snow Leopard we always have the fix.
2453 2011-11-17 Chris Fleizach <cfleizach@apple.com>
2455 AX: The scrollArea is not correctly returning the scrollbars
2456 https://bugs.webkit.org/show_bug.cgi?id=70247
2458 Reviewed by Beth Dakin.
2460 A few bugs that were preventing this from working.
2461 1) In accessibilityAttributeValue: when an element did not have a renderer() we were returning earlier than we should have
2462 2) We were not updating and clearing the scrollbars correctly when children were cleared or when asked for.
2464 Test: platform/mac/accessibility/scrollbars.html
2466 * accessibility/AccessibilityScrollView.cpp:
2467 (WebCore::AccessibilityScrollView::scrollBar):
2468 (WebCore::AccessibilityScrollView::clearChildren):
2469 * accessibility/AccessibilityScrollView.h:
2470 * accessibility/mac/WebAccessibilityObjectWrapper.mm:
2471 (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
2473 2011-11-14 Adam Barth <abarth@webkit.org>
2475 Unique origins shouldn't remember their scheme, host, or port
2476 https://bugs.webkit.org/show_bug.cgi?id=72308
2478 Reviewed by Eric Seidel.
2480 This patch contains the bulk (all?) of the behavior differences in this
2481 patch series. Unique origins shouldn't remember their schemes. Doing
2482 so causes some privileges (e.g., local access) to leak into unique
2485 * page/SecurityOrigin.cpp:
2486 (WebCore::SecurityOrigin::SecurityOrigin):
2487 - Explicitly clear out the protocol, host, and port for unique
2488 origins. A future patch will refactor all this code to be more
2490 * platform/SchemeRegistry.cpp:
2491 (WebCore::schemesWithUniqueOrigins):
2492 - Merge "about" and "javascript" in with the general case now that
2493 we don't have a separate notion of an empty origin.
2495 2011-11-17 Chris Fleizach <cfleizach@apple.com>
2497 AX: cleanup style and naming and code in accessibility search mechanism
2498 https://bugs.webkit.org/show_bug.cgi?id=72570
2500 Reviewed by Beth Dakin.
2502 Cleanup the naming and code style within the element searching mechanism.
2504 * accessibility/AccessibilityObject.cpp:
2505 (WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
2506 (WebCore::AccessibilityObject::isAccessibilityTextSearchMatch):
2507 (WebCore::AccessibilityObject::firstAccessibleObjectFromNode):
2508 (WebCore::AccessibilityObject::findMatchingObjects):
2509 * accessibility/AccessibilityObject.h:
2510 * accessibility/mac/WebAccessibilityObjectWrapper.mm:
2511 (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
2513 2011-11-17 Julien Chaffraix <jchaffraix@webkit.org>
2515 CSS table with 100% width can overflow their containing block
2516 https://bugs.webkit.org/show_bug.cgi?id=72180
2518 Reviewed by David Hyatt.
2520 Tests: fast/table/table-in-table-percent-width-collapsing-border-quirks-mode.html
2521 fast/table/table-in-table-percent-width-collapsing-border.html
2522 fast/table/table-in-table-percent-width-quirks-mode.html
2523 fast/table/table-in-table-percent-width.html
2525 After r97555, we would include the borders in a CSS table's logical width even if the 'width'
2526 property was a percent. This does not match what Firefox and IE are doing. Thus don't apply
2527 this behavior to percent 'width'.
2529 * rendering/RenderTable.cpp:
2530 (WebCore::RenderTable::computeLogicalWidth):
2532 2011-11-17 Adrienne Walker <enne@google.com>
2534 [chromium] Implicitly skip render surfaces that won't be drawn
2535 https://bugs.webkit.org/show_bug.cgi?id=71038
2537 Rather than having redundant checks in three places for how to walk
2538 through a render surface list, instead don't add render surfaces that
2539 don't need to get rendered to the render surface list.
2541 Reviewed by James Robinson.
2543 Covered by existing layout tests and unit tests.
2545 * platform/graphics/chromium/LayerRendererChromium.cpp:
2546 (WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
2547 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
2548 (WebCore::CCLayerTreeHost::paintLayerContents):
2549 (WebCore::CCLayerTreeHost::updateCompositorResources):
2550 * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
2551 (WebCore::calculateDrawTransformsAndVisibilityInternal):
2553 2011-11-17 Simon Hausmann <simon.hausmann@nokia.com>
2555 [Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode
2556 https://bugs.webkit.org/show_bug.cgi?id=72595
2558 Reviewed by Noam Rosenthal.
2560 Removed QWebElement and QtDRTNode usage that reached from WebCore into
2561 WebKit/qt and replaced it with the ability to register custom JSValue
2562 conversion functions. The old code has been moved to WebKit/qt.
2564 * bridge/qt/qt_instance.cpp:
2565 (JSC::Bindings::QtInstance::QtInstance): Remove unnecessary meta type registration
2566 (now done in QtWebElementRuntime::initialize in WebKit/qt).
2567 * bridge/qt/qt_runtime.cpp:
2568 (JSC::Bindings::registerCustomType):
2569 (JSC::Bindings::convertValueToQVariant):
2570 (JSC::Bindings::convertQVariantToValue):
2571 * bridge/qt/qt_runtime.h:
2573 2011-11-17 Fady Samuel <fsamuel@chromium.org>
2575 Pass Aspect Ratio to RenderStyle
2576 https://bugs.webkit.org/show_bug.cgi?id=72350
2578 Reviewed by Ojan Vafai.
2580 * css/CSSComputedStyleDeclaration.cpp:
2581 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2582 * css/CSSStyleApplyProperty.cpp:
2583 (WebCore::ApplyPropertyAspectRatio::applyInheritValue):
2584 (WebCore::ApplyPropertyAspectRatio::applyInitialValue):
2585 (WebCore::ApplyPropertyAspectRatio::applyValue):
2586 (WebCore::ApplyPropertyAspectRatio::createHandler):
2587 (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
2588 * css/CSSStyleSelector.cpp:
2589 (WebCore::CSSStyleSelector::applyProperty):
2591 (WebCore::CSSValue::isAspectRatioValue):
2592 * rendering/style/RenderStyle.h:
2593 (WebCore::InheritedFlags::hasAspectRatio):
2594 (WebCore::InheritedFlags::aspectRatio):
2595 (WebCore::InheritedFlags::aspectRatioDenominator):
2596 (WebCore::InheritedFlags::aspectRatioNumerator):
2597 (WebCore::InheritedFlags::setHasAspectRatio):
2598 (WebCore::InheritedFlags::setAspectRatioDenominator):
2599 (WebCore::InheritedFlags::setAspectRatioNumerator):
2600 (WebCore::InheritedFlags::initialHasAspectRatio):
2601 (WebCore::InheritedFlags::initialAspectRatioDenominator):
2602 (WebCore::InheritedFlags::initialAspectRatioNumerator):
2603 * rendering/style/StyleRareNonInheritedData.cpp:
2604 (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2605 (WebCore::StyleRareNonInheritedData::operator==):
2606 * rendering/style/StyleRareNonInheritedData.h:
2608 2011-11-09 Robert Hogan <robert@webkit.org>
2610 CSS 2.1 failure: outline-color-* tests fail
2611 https://bugs.webkit.org/show_bug.cgi?id=71931
2613 Reviewed by Julien Chaffraix.
2615 WebKit wasn't displaying the top block in these tests because it did not paint the outline
2616 of divs with zero size.
2618 * rendering/RenderObject.cpp:
2619 (WebCore::RenderObject::paintOutline): paint the outline even when the block has zero size
2621 2011-11-17 Sergio Villar Senin <svillar@igalia.com>
2623 [GTK] plugins/get-url-notify-with-url-that-fails-to-load.html on bots after r100466
2624 https://bugs.webkit.org/show_bug.cgi?id=72613
2626 Reviewed by Martin Robinson.
2628 Do not assume that a SoupRequest always exists, it is not
2629 generated for example when the provided URL is
2630 invalid. ResourceHandle::platformSetDefersLoading was crashing
2633 * platform/network/soup/ResourceHandleSoup.cpp:
2634 (WebCore::ResourceHandle::platformSetDefersLoading):
2636 2011-11-17 Vsevolod Vlasov <vsevik@chromium.org>
2638 Web Inspector: Remove onlineDetectionEnabled from Preferences
2639 https://bugs.webkit.org/show_bug.cgi?id=72617
2641 Reviewed by Pavel Feldman.
2643 * inspector/front-end/ApplicationCacheItemsView.js:
2644 (WebInspector.ApplicationCacheItemsView):
2645 (WebInspector.ApplicationCacheItemsView.prototype.get statusBarItems):
2646 * inspector/front-end/Settings.js:
2648 2011-11-17 Ken Buchanan <kenrb@chromium.org>
2650 Crash from nested tables with generated content
2651 https://bugs.webkit.org/show_bug.cgi?id=68811
2653 Reviewed by David Hyatt.
2655 When adding a child to a table that has generated content, this change
2656 ensures that we leave alone any generated content renderers that belong
2657 to descendants in the tree. They don't need to be touched, and doing so
2658 can create confusion about who the content belongs to.
2660 This patch also simplifies some existing code for finding pseudoelement
2663 * rendering/RenderBlock.cpp:
2664 (WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
2665 * rendering/RenderObject.cpp:
2666 (WebCore::RenderObject::addChild):
2667 (WebCore::RenderObject::isBeforeAfterContentGeneratedByAncestor): Added
2668 * rendering/RenderObject.h:
2669 (WebCore::RenderObject::findAfterContentRenderer): Deleted
2670 (WebCore::RenderObject::findBeforeContentRenderer): Deleted
2671 * rendering/RenderObjectChildList.cpp:
2672 (WebCore::RenderObjectChildList::beforePseudoElementRenderer):
2673 (WebCore::RenderObjectChildList::afterPseudoElementRenderer):
2674 * rendering/RenderTable.cpp:
2675 (WebCore::RenderTable::addChild):
2676 * rendering/RenderTableRow.cpp:
2677 (WebCore::RenderTableRow::addChild):
2678 * rendering/RenderTableSection.cpp:
2679 (WebCore::RenderTableSection::addChild):
2681 2011-11-17 Patrick Gansterer <paroga@webkit.org>
2683 Unreviewed WinCE build fix for r94119.
2685 MSVC throws multiply defined symbols linker error when using local class in inline function.
2687 * bindings/js/JSDictionary.h:
2688 (WebCore::JSDictionary::IdentitySetter::identitySetter):
2689 (WebCore::JSDictionary::tryGetProperty):
2691 2011-11-17 Eric Carlson <eric.carlson@apple.com>
2693 TextTrackList not sorted correctly
2694 https://bugs.webkit.org/show_bug.cgi?id=72545
2696 Reviewed by Darin Adler.
2698 Test: media/track/track-texttracks.html
2700 * WebCore.xcodeproj/project.pbxproj: Add TextTrack.h to WebCore private headers because
2701 it is included by HTMLMediaElement.h.
2702 * html/LoadableTextTrack.cpp:
2703 (WebCore::LoadableTextTrack::LoadableTextTrack): Pass track type to base class constructor.
2704 (WebCore::LoadableTextTrack::trackElementIndex): New, return the <track> element's tree order
2706 * html/LoadableTextTrack.h:
2708 * html/TextTrack.cpp:
2709 (WebCore::TextTrack::TextTrack): Set track type.
2711 (WebCore::TextTrack::create): Ditto.
2712 (WebCore::TextTrack::trackType): Ditto.
2714 * html/track/TextTrackList.cpp:
2715 (TextTrackList::length): Update to deal with two TextTrack vectors.
2716 (TextTrackList::item): Ditto.
2717 (TextTrackList::append): Ditto.
2718 (TextTrackList::remove): Ditto
2719 * html/track/TextTrackList.h: Store the two types of TextTracks in separate Vectors to make
2720 it simpler to keep them in the correct order.
2722 2011-11-17 Simon Hausmann <simon.hausmann@nokia.com>
2724 [Qt] Layer violation: WebCore::dnsPrefetch uses QWebSettings::globalSettings()
2725 https://bugs.webkit.org/show_bug.cgi?id=72596
2727 Reviewed by Kenneth Rohde Christiansen.
2729 We don't need to use QWebSettings here, because we now propagate the DNS prefetch
2730 setting to WebCore::Settings and the rest of WebCore checks the setting before calling
2731 WebCore::prefetchDNS.
2733 * platform/network/qt/DnsPrefetchHelper.cpp:
2734 (WebCore::prefetchDNS): Removed the use of QWebSettings.
2735 * platform/network/qt/DnsPrefetchHelper.h: Remove offending qwebsettings.h inclusion.
2737 2011-11-17 Simon Hausmann <simon.hausmann@nokia.com>
2739 [Qt] Layer violation: Image::loadPlatformResource uses QWebSettings::webGraphic
2740 https://bugs.webkit.org/show_bug.cgi?id=72594
2742 Reviewed by Kenneth Rohde Christiansen.
2744 Move the cache for the resource pixmaps into ImageQt.cpp.
2746 * platform/graphics/Image.h: Add Qt specific setter for resource pixmaps.
2747 * platform/graphics/qt/ImageQt.cpp: Moved resource pixmap hash from qwebsettings.
2748 (earlyClearGraphics):
2750 (loadResourcePixmap):
2751 (WebCore::Image::setPlatformResource):
2753 2011-11-17 Zeno Albisser <zeno@webkit.org>
2755 [Qt][WK2] Touch/Mouse events are delivered with wrong coordinates.
2756 https://bugs.webkit.org/show_bug.cgi?id=72604
2758 When using the QtViewportInterationEngine for zooming/panning,
2759 no additional scroll offset should be applied to input events
2762 This patch is based on work by Andreas Kling.
2764 Reviewed by Kenneth Rohde Christiansen.
2766 * platform/ScrollView.cpp:
2767 (WebCore::ScrollView::windowToContents):
2768 (WebCore::ScrollView::contentsToWindow):
2770 2011-11-17 Ben Murdoch <benm@google.com>
2772 Unreviewed build fix.
2774 Fix the Windows builds by adding WorkerEventQueue.cpp|h to the
2775 vcproj. Build break was introduced in
2776 https://bugs.webkit.org/show_bug.cgi?id=72528
2778 * WebCore.vcproj/WebCore.vcproj: Add missing files.
2780 2011-11-17 Mihnea Ovidenie <mihnea@adobe.com>
2782 CSS Exclusions: parse the wrap-margin and wrap-padding properties
2783 https://bugs.webkit.org/show_bug.cgi?id=71900
2785 Reviewed by Dean Jackson.
2787 Tests: fast/exclusions/wrap-margin-parsing.html
2788 fast/exclusions/wrap-padding-parsing.html
2790 * css/CSSComputedStyleDeclaration.cpp:
2791 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2792 * css/CSSParser.cpp:
2793 (WebCore::isSimpleLengthPropertyID):
2794 (WebCore::CSSParser::parseValue):
2795 * css/CSSProperty.cpp:
2796 (WebCore::CSSProperty::isInheritedProperty):
2797 * css/CSSPropertyNames.in:
2798 * css/CSSStyleApplyProperty.cpp:
2799 (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
2800 * css/CSSStyleSelector.cpp:
2801 (WebCore::CSSStyleSelector::applyProperty):
2802 * rendering/style/RenderStyle.cpp:
2803 (WebCore::RenderStyle::diff):
2804 * rendering/style/RenderStyle.h:
2805 (WebCore::InheritedFlags::wrapPadding):
2806 (WebCore::InheritedFlags::setWrapPadding):
2807 (WebCore::InheritedFlags::initialWrapPadding):
2808 (WebCore::InheritedFlags::wrapMargin):
2809 (WebCore::InheritedFlags::setWrapMargin):
2810 (WebCore::InheritedFlags::initialWrapMargin):
2811 * rendering/style/StyleRareNonInheritedData.cpp:
2812 (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2813 (WebCore::StyleRareNonInheritedData::operator==):
2814 * rendering/style/StyleRareNonInheritedData.h:
2816 2011-11-17 Kenichi Ishibashi <bashi@chromium.org>
2818 [chromium] don't call fontconfig twice in complex text path
2819 https://bugs.webkit.org/show_bug.cgi?id=38701
2821 Adds a new API for getting font family. For now, FontCacheLinux calls the new API, but don't use additional properties for compatibility. The old API will be removed when Chromium is ready to use new API.
2823 Reviewed by Tony Chang.
2825 No new tests. No behavior changes for now.
2827 * platform/chromium/PlatformSupport.h: Added FontFamily struct and changed the declaration of getFontFamilyForCharacters().
2828 * platform/graphics/chromium/FontCacheLinux.cpp:
2829 (WebCore::FontCache::getFontDataForCharacters): Uses new PlatformSupport::getFontFamilyForCharacters().
2830 * platform/graphics/chromium/FontPlatformDataLinux.h:
2831 (WebCore::FontPlatformData::setFakeBold): Added.
2832 (WebCore::FontPlatformData::setFakeItalic): Added.
2834 2011-11-17 Mario Sanchez Prada <msanchez@igalia.com>
2836 [GTK] Consider parent AtkObject in webkit_accessible_get_parent(), if already set
2837 https://bugs.webkit.org/show_bug.cgi?id=72525
2839 Reviewed by Xan Lopez.
2841 * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2842 (webkit_accessible_get_parent): Call to the implementation of
2843 atk_object_get_parent in AtkObject class to check whether a parent
2844 AtkObject has been previously set, before trying to find one.
2846 2011-11-17 Pavel Feldman <pfeldman@google.com>
2848 Not reviewed: fix IE user agents strings in the inspector.
2850 * inspector/front-end/SettingsScreen.js:
2851 (WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):
2853 2011-11-16 Kenneth Rohde Christiansen <kenneth@webkit.org>
2855 Make use-fixed-layout work reliable
2856 https://bugs.webkit.org/show_bug.cgi?id=72511
2858 Reviewed by Simon Hausmann.
2860 Always send a viewport update per page load as we depend on that,
2861 to reset all viewport handling before doing layout.
2864 (WebCore::Page::updateViewportArguments):
2866 2011-11-16 Alexander Pavlov <apavlov@chromium.org>
2868 Web Inspector: inspector follows javascript: hrefs as relative
2869 https://bugs.webkit.org/show_bug.cgi?id=72373
2871 javascript: hrefs should never be linkified for security.
2873 Reviewed by Yury Semikhatsky.
2875 * inspector/front-end/ElementsTreeOutline.js:
2876 (WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):
2877 * inspector/front-end/ResourceUtils.js:
2878 (WebInspector.completeURL):
2880 2011-11-17 Nikolas Zimmermann <nzimmermann@rim.com>
2882 Not reviewed. Fix 32bit builds.
2884 * platform/ClockGeneric.cpp:
2885 (ClockGeneric::now): Use narrowPrecisionToFloat.
2886 * rendering/FilterEffectRenderer.cpp:
2887 (WebCore::FilterEffectRenderer::build): Use it correctly.
2889 2011-11-17 Dominic Mazzoni <dmazzoni@google.com>
2891 Accessibility: Chromium requires an AX notification when an iframe loads.
2892 https://bugs.webkit.org/show_bug.cgi?id=72239
2894 When a document finishes loading, we were sending an AXLoadComplete if it
2895 was the top document. Now, if it's a document in an iframe, send an
2896 AXLayoutComplete on the iframe.
2898 Reviewed by Chris Fleizach.
2900 Test: accessibility/loading-iframe-sends-notification.html
2903 (WebCore::Document::implicitClose):
2905 2011-11-16 Mark Rowe <mrowe@apple.com>
2907 <http://webkit.org/b/72574> Remove unnecessary use of CarbonCore APIs from Audio code
2909 Reviewed by Andy Estes.
2911 * platform/audio/mac/AudioDestinationMac.cpp:
2912 (WebCore::AudioDestinationMac::AudioDestinationMac): Switch from using the Carbon Component Manager
2913 to using AudioUnit's own component interface.
2914 (WebCore::AudioDestinationMac::~AudioDestinationMac): Ditto.
2915 * platform/audio/mac/AudioFileReaderMac.cpp:
2916 (WebCore::AudioFileReader::AudioFileReader): Remove an unncessary trip through the Carbon File Manager
2917 when converting a char* path to a CFURLRef representing the same.
2919 2011-11-17 Adam Barth <abarth@webkit.org>
2921 CSP report-only mode doesn't work from an HTTP header
2922 https://bugs.webkit.org/show_bug.cgi?id=71958
2924 Reviewed by Eric Seidel.
2926 "It's tested or it's broken." -- Adam Leventhal
2928 Test: http/tests/security/contentSecurityPolicy/report-only-from-header.php
2930 * loader/FrameLoader.cpp:
2931 (WebCore::FrameLoader::didBeginDocument):
2933 2011-11-15 Pavel Feldman <pfeldman@google.com>
2935 Web Inspector: introduce Debugger domain capabilities concept.
2936 https://bugs.webkit.org/show_bug.cgi?id=72393
2938 Many of the Preferences that we have in Settings.js and override in DevTools.js
2939 are really not preferences, but capabilities. Protocol clients should have a way
2940 of figuring out whether some capability is present before using it.
2942 Reviewed by Yury Semikhatsky.
2944 * bindings/js/ScriptDebugServer.cpp:
2945 (WebCore::ScriptDebugServer::canSetScriptSource):
2946 * bindings/js/ScriptDebugServer.h:
2947 * bindings/v8/ScriptDebugServer.cpp:
2948 (WebCore::ScriptDebugServer::canSetScriptSource):
2949 * bindings/v8/ScriptDebugServer.h:
2950 * inspector/CodeGeneratorInspector.py:
2951 * inspector/Inspector.json:
2952 * inspector/InspectorDebuggerAgent.cpp:
2953 (WebCore::InspectorDebuggerAgent::getCapabilities):
2954 * inspector/InspectorDebuggerAgent.h:
2955 * inspector/front-end/DebuggerModel.js:
2956 (WebInspector.DebuggerModel):
2957 (WebInspector.DebuggerModel.prototype.enableDebugger):
2958 (WebInspector.DebuggerModel.prototype.canSetScriptSource):
2959 * inspector/front-end/DebuggerPresentationModel.js:
2960 (WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
2961 * inspector/front-end/Settings.js:
2963 2011-11-17 Mihnea Ovidenie <mihnea@adobe.com>
2965 CSS exclusions: parse the wrap-flow and wrap-through properties
2966 https://bugs.webkit.org/show_bug.cgi?id=71904
2968 Reviewed by Dean Jackson.
2970 Tests: fast/exclusions/wrap-flow-parsing.html
2971 fast/exclusions/wrap-through-parsing.html
2973 * css/CSSComputedStyleDeclaration.cpp:
2974 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2975 * css/CSSParser.cpp:
2976 (WebCore::CSSParser::parseValue):
2977 * css/CSSPrimitiveValueMappings.h:
2978 (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
2979 (WebCore::CSSPrimitiveValue::operator WrapFlow):
2980 (WebCore::CSSPrimitiveValue::operator WrapThrough):
2981 * css/CSSProperty.cpp:
2982 (WebCore::CSSProperty::isInheritedProperty):
2983 * css/CSSPropertyNames.in:
2984 * css/CSSStyleSelector.cpp:
2985 (WebCore::CSSStyleSelector::applyProperty):
2986 * css/CSSValueKeywords.in:
2987 * rendering/style/RenderStyle.cpp:
2988 (WebCore::RenderStyle::diff):
2989 * rendering/style/RenderStyle.h:
2990 (WebCore::InheritedFlags::wrapFlow):
2991 (WebCore::InheritedFlags::wrapThrough):
2992 (WebCore::InheritedFlags::setWrapFlow):
2993 (WebCore::InheritedFlags::setWrapThrough):
2994 (WebCore::InheritedFlags::initialWrapFlow):
2995 (WebCore::InheritedFlags::initialWrapThrough):
2996 * rendering/style/RenderStyleConstants.h:
2997 * rendering/style/StyleRareNonInheritedData.cpp:
2998 (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
2999 (WebCore::StyleRareNonInheritedData::operator==):
3000 * rendering/style/StyleRareNonInheritedData.h:
3002 2011-11-16 Dean Jackson <dino@apple.com>
3004 Implement filter function shorthands
3005 https://bugs.webkit.org/show_bug.cgi?id=68475
3007 Reviewed by Simon Fraser.
3009 Implement the shorthand functions for filter effects.
3010 This includes grayscale, sepia, invert, hue-rotate, saturate,
3011 opacity, gamma, drop-shadow and blur. At the moment sharpen
3012 and url are not supported.
3014 CSSParser needed to be updated because it was mistakenly
3015 clamping saturation values to [0,1]. Any positive number
3016 is allowed so you can produce super-saturated images.
3018 The biggest change was the API to FilterEffectRenderer. It now
3019 builds a list of effects and applies the filter itself.
3021 Note that the drop-shadow and blur operations don't yet
3022 provide accurate results because they produce an output image
3023 that is larger than the input. See
3024 https://bugs.webkit.org/show_bug.cgi?id=71929
3025 https://bugs.webkit.org/show_bug.cgi?id=71930
3027 While I was there, I fixed a small style issue in
3028 CustomFilterOperation.
3030 Tests: css3/filters/effect-blur.html
3031 css3/filters/effect-combined.html
3032 css3/filters/effect-drop-shadow.html
3033 css3/filters/effect-gamma.html
3034 css3/filters/effect-grayscale.html
3035 css3/filters/effect-hue-rotate.html
3036 css3/filters/effect-invert.html
3037 css3/filters/effect-opacity.html
3038 css3/filters/effect-saturate.html
3039 css3/filters/effect-sepia.html
3041 * WebCore.xcodeproj/project.pbxproj: Add StyleShader.h to
3042 the project (missing from earlier commit).
3043 * css/CSSParser.cpp:
3044 (WebCore::CSSParser::isValidFilterArgument): Don't clamp
3046 * platform/graphics/filters/CustomFilterOperation.h:
3047 * rendering/FilterEffectRenderer.cpp:
3048 (WebCore::endMatrixRow):
3049 (WebCore::lastMatrixRow):
3050 (WebCore::FilterEffectRenderer::FilterEffectRenderer):
3051 (WebCore::FilterEffectRenderer::inputContext):
3052 (WebCore::FilterEffectRenderer::build):
3053 (WebCore::FilterEffectRenderer::prepare):
3054 (WebCore::FilterEffectRenderer::apply):
3055 * rendering/FilterEffectRenderer.h:
3056 (WebCore::FilterEffectRenderer::setSourceImageRect):
3057 (WebCore::FilterEffectRenderer::output):
3058 (WebCore::FilterEffectRenderer::setMaxEffectRects):
3059 (WebCore::FilterEffectRenderer::lastEffect):
3060 * rendering/RenderLayer.cpp:
3061 (WebCore::RenderLayer::paintLayer):
3062 (WebCore::RenderLayer::updateOrRemoveFilterEffect):
3063 (WebCore::RenderLayer::updateFilterBackingStore):
3065 2011-11-16 Kentaro Hara <haraken@chromium.org>
3067 Remove all custom constructors of Events from JSC
3068 https://bugs.webkit.org/show_bug.cgi?id=72577
3070 Reviewed by Adam Barth.
3072 - Makes CodeGeneratorJS.pm generate Event constructors
3073 if [ConstructorTemplate=Event] IDL is specified.
3074 - Removes EventConstructors.h and JSEventConstructors.cpp.
3075 - Replaces all JSC custom constructors of Events
3076 with the generated code by [ConstructorTemplate=Event] IDL.
3078 Tests: fast/events/constructors/before-load-event-constructor.html
3079 fast/events/constructors/close-event-constructor.html
3080 fast/events/constructors/custom-event-constructor.html
3081 fast/events/constructors/error-event-constructor.html
3082 fast/events/constructors/event-constructors.html
3083 fast/events/constructors/hash-change-event-constructor.html
3084 fast/events/constructors/message-event-constructor.html
3085 fast/events/constructors/overflow-event-constructor.html
3086 fast/events/constructors/page-transition-event-constructor.html
3087 fast/events/constructors/pop-state-event-constructor.html
3088 fast/events/constructors/progress-event-constructor.html
3089 fast/events/constructors/track-event-constructor.html
3090 fast/events/constructors/webkit-animation-event-constructor.html
3091 fast/events/constructors/webkit-transition-event-constructor.html
3093 * bindings/generic/EventConstructors.h: Removed. This is what we wanted to do in this patch.
3094 * bindings/js/JSEventConstructors.cpp: Ditto.
3095 * GNUmakefile.list.am: Removed EventConstructors.h and JSEventConstructors.cpp.
3096 * Target.pri: Ditto.
3097 * UseJSC.cmake: Ditto.
3098 * WebCore.gypi: Ditto.
3099 * WebCore.vcproj/WebCore.vcproj: Ditto.
3100 * WebCore.xcodeproj/project.pbxproj: Ditto.
3101 * bindings/js/JSBindingsAllInOne.cpp: Ditto.
3103 * bindings/scripts/CodeGeneratorJS.pm:
3104 (GenerateHeader): Added JSDictionary.h.
3105 (GenerateConstructorDeclaration): Added a header for fillXXXXEventInit(...).
3106 (GenerateConstructorDefinition): Generates an Event constructor. The generated code is the same as the code that had been written in JSEventConstructors.cpp.
3107 (IsConstructable): Judges if a given interface is constructable.
3108 (IsConstructorTemplate): Judges if a given interface has a given template, e.g. judges if an interface has [ConstructorTemplate=Event].
3110 * bindings/scripts/test/TestEventConstructor.idl: Changed 'CustomConstructor=Event' to 'ConstructorTemplate=Event'. We should have changed this in r100108.
3111 * bindings/scripts/test/JS/JSTestEventConstructor.cpp: Updated a run-bindings-tests result.
3112 (WebCore::JSTestEventConstructorConstructor::constructJSTestEventConstructor):
3113 (WebCore::fillTestEventConstructorInit):
3114 * bindings/scripts/test/JS/JSTestEventConstructor.h: Ditto.
3115 * bindings/scripts/test/V8/V8TestEventConstructor.cpp: Ditto.
3116 (WebCore::V8TestEventConstructor::constructorCallback):
3117 (WebCore::fillTestEventConstructorInit):
3118 * bindings/scripts/test/V8/V8TestEventConstructor.h: Ditto.
3120 * dom/BeforeLoadEvent.idl: In essence, replaced [JSCustomConstructor] IDL with [JSConstructorTemplate=Event] IDL.
3121 * dom/CustomEvent.idl: Ditto.
3122 * dom/ErrorEvent.idl: Ditto.
3123 * dom/Event.idl: Ditto.
3124 * dom/HashChangeEvent.idl: Ditto.
3125 * dom/MessageEvent.idl: Ditto.
3126 * dom/OverflowEvent.idl: Ditto.
3127 * dom/PageTransitionEvent.idl: Ditto.
3128 * dom/PopStateEvent.idl: Ditto.
3129 * dom/ProgressEvent.idl: Ditto.
3130 * dom/WebKitAnimationEvent.idl: Ditto.
3131 * dom/WebKitTransitionEvent.idl: Ditto.
3132 * html/track/TrackEvent.idl: Ditto.
3133 * websockets/CloseEvent.idl: Ditto.
3135 2011-11-16 Dean Jackson <dino@apple.com>
3137 Build fix for Apple WebKit due to r100560.
3138 When I removed the violating header file it lost the
3143 * platform/graphics/filters/FilterOperation.h:
3145 2011-11-16 Dean Jackson <dino@apple.com>
3147 DropShadowFilterOperation violates platform isolation
3148 https://bugs.webkit.org/show_bug.cgi?id=72544
3150 Reviewed by Simon Fraser.
3152 Move ShadowData properties into the DropShadowFilterOperation
3153 to avoid depending on something outside platform.
3155 * css/CSSComputedStyleDeclaration.cpp:
3156 (WebCore::CSSComputedStyleDeclaration::valueForFilter):
3157 * css/CSSStyleSelector.cpp:
3158 (WebCore::CSSStyleSelector::createFilterOperations):
3159 * platform/graphics/filters/FilterOperation.h:
3160 (WebCore::DropShadowFilterOperation::create):
3161 (WebCore::DropShadowFilterOperation::x):
3162 (WebCore::DropShadowFilterOperation::y):
3163 (WebCore::DropShadowFilterOperation::stdDeviation):
3164 (WebCore::DropShadowFilterOperation::color):
3165 (WebCore::DropShadowFilterOperation::operator==):
3166 (WebCore::DropShadowFilterOperation::DropShadowFilterOperation):
3168 2011-11-16 Adam Bergkvist <adam.bergkvist@ericsson.com>
3170 Use a simple page client for user consent in getUserMedia()
3171 https://bugs.webkit.org/show_bug.cgi?id=70897
3173 Reviewed by Adam Barth.
3175 This is one in a series of patches that update the MediaStream feature
3176 to use WebCore platform interfaces.
3178 Covered by existing tests.
3180 * GNUmakefile.list.am:
3182 * mediastream/MediaStreamClient.h: Removed.
3183 * mediastream/MediaStreamController.cpp: Removed.
3184 * mediastream/MediaStreamController.h: Removed.
3185 * mediastream/MediaStreamFrameController.cpp: Removed.
3186 * mediastream/MediaStreamFrameController.h: Removed.
3187 * mediastream/UserMediaClient.h: Added.
3188 (WebCore::UserMediaClient::~UserMediaClient):
3189 * mediastream/UserMediaRequest.cpp: Added.
3190 (WebCore::UserMediaRequest::create):
3191 (WebCore::UserMediaRequest::UserMediaRequest):
3192 (WebCore::UserMediaRequest::~UserMediaRequest):
3193 (WebCore::UserMediaRequest::start):
3194 (WebCore::UserMediaRequest::mediaStreamSourcesQueryCompleted):
3195 (WebCore::UserMediaRequest::succeed):
3196 (WebCore::UserMediaRequest::fail):
3197 (WebCore::UserMediaRequest::contextDestroyed):
3198 (WebCore::UserMediaRequest::parseOptions):
3199 * mediastream/UserMediaRequest.h: Added.
3200 (WebCore::UserMediaRequest::audio):
3201 (WebCore::UserMediaRequest::video):
3202 (WebCore::UserMediaRequest::cameraPreferenceUser):
3203 (WebCore::UserMediaRequest::cameraPreferenceEnvironment):
3204 (WebCore::UserMediaRequest::successCallback):
3205 (WebCore::UserMediaRequest::errorCallback):
3206 * page/CallbackTask.h: Removed.
3208 (WebCore::Frame::Frame):
3209 (WebCore::Frame::~Frame):
3210 (WebCore::Frame::pageDestroyed):
3211 (WebCore::Frame::transferChildFrameToNewDocument):
3213 * page/Navigator.cpp:
3214 (WebCore::Navigator::webkitGetUserMedia):
3215 * page/NavigatorUserMediaErrorCallback.h:
3217 (WebCore::Page::Page):
3218 (WebCore::Page::~Page):
3219 (WebCore::Page::PageClients::PageClients):
3221 (WebCore::Page::userMediaClient):
3223 2011-11-16 David Grogan <dgrogan@chromium.org>
3225 instantiate WorkerEventQueue in WorkerContext
3226 https://bugs.webkit.org/show_bug.cgi?id=72528
3228 Reviewed by David Levin.
3230 No new tests - nothing uses it yet.
3232 * workers/WorkerContext.cpp:
3233 (WebCore::WorkerContext::WorkerContext):
3234 Instantiate WorkerEventQueue in InitializerList
3236 * workers/WorkerEventQueue.h:
3237 Don't inherit from RefCounted, WorkerContext has an OwnPtr to it
3239 2011-11-16 Kentaro Hara <haraken@chromium.org>
3241 Unreviewed. Rebaselined run-bindings-tests results.
3243 * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
3244 (WebCore::JSTestEventConstructor::JSTestEventConstructor):
3245 (WebCore::JSTestEventConstructorOwner::finalize):
3246 * bindings/scripts/test/JS/JSTestEventConstructor.h:
3247 (WebCore::JSTestEventConstructor::impl):
3248 (WebCore::JSTestEventConstructor::releaseImpl):
3249 * bindings/scripts/test/JS/JSTestInterface.cpp:
3250 (WebCore::JSTestInterface::JSTestInterface):
3251 (WebCore::JSTestInterfaceOwner::finalize):
3252 * bindings/scripts/test/JS/JSTestInterface.h:
3253 (WebCore::JSTestInterface::impl):
3254 (WebCore::JSTestInterface::releaseImpl):
3255 * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
3256 (WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
3257 (WebCore::JSTestMediaQueryListListenerOwner::finalize):
3258 * bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
3259 (WebCore::JSTestMediaQueryListListener::impl):
3260 (WebCore::JSTestMediaQueryListListener::releaseImpl):
3261 * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
3262 (WebCore::JSTestNamedConstructor::JSTestNamedConstructor):
3263 (WebCore::JSTestNamedConstructorOwner::finalize):
3264 * bindings/scripts/test/JS/JSTestNamedConstructor.h:
3265 (WebCore::JSTestNamedConstructor::impl):
3266 (WebCore::JSTestNamedConstructor::releaseImpl):
3267 * bindings/scripts/test/JS/JSTestObj.cpp:
3268 (WebCore::JSTestObj::JSTestObj):
3269 (WebCore::JSTestObjOwner::finalize):
3270 * bindings/scripts/test/JS/JSTestObj.h:
3271 (WebCore::JSTestObj::impl):
3272 (WebCore::JSTestObj::releaseImpl):
3273 * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
3274 (WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
3275 (WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):
3276 * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
3277 (WebCore::JSTestSerializedScriptValueInterface::impl):
3278 (WebCore::JSTestSerializedScriptValueInterface::releaseImpl):
3280 2011-11-16 Jay Civelli <jcivelli@chromium.org>
3282 Make sure MHTML documents use the domain of the MHTML file.
3283 https://bugs.webkit.org/show_bug.cgi?id=72445
3285 Reviewed by Adam Barth.
3288 (WebCore::Document::setBaseURL):
3289 * loader/FrameLoader.cpp:
3290 (WebCore::FrameLoader::receivedFirstData):
3292 2011-11-16 Julien Chaffraix <jchaffraix@webkit.org>
3294 Update supported display list after -webkit-grid and -webkit-inline-grid addition
3295 https://bugs.webkit.org/show_bug.cgi?id=72559
3297 Reviewed by Tony Chang.
3299 * css/CSSParser.cpp:
3300 (WebCore::CSSParser::parseValue): Added the 2 new supported
3301 values (forgotten in the previous change).
3303 2011-11-11 Adrienne Walker <enne@google.com>
3305 [chromium] Expose mock scrollbars to window.internals
3306 https://bugs.webkit.org/show_bug.cgi?id=72195
3308 Reviewed by James Robinson.
3310 * testing/Internals.cpp:
3311 (WebCore::Internals::setMockScrollbarsEnabled):
3312 * testing/Internals.h:
3313 * testing/Internals.idl:
3315 2011-11-16 Michael Nordman <michaeln@google.com>
3317 ApplicationCache manifest should work with any MIME type.
3318 https://bugs.webkit.org/show_bug.cgi?id=72082
3320 Reviewed by Alexey Proskuryakov.
3322 * loader/appcache/ApplicationCacheGroup.cpp:
3323 (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Remove the test for a particular type.
3325 2011-11-16 Daniel Sievers <sievers@chromium.org>
3327 [Chromium] Avoid color mask operations for root layers
3328 https://bugs.webkit.org/show_bug.cgi?id=72452
3330 Instead of relying on the combination of clearing the surface and initializing
3331 the alpha channel to 1.0 followed by disabling alpha in the color mask when
3332 rendering the root layer tiles, add shaders to support writing out opaque layers
3333 (alpha channel values written as 1.0).
3335 Reviewed by James Robinson.
3337 No functional change made that requires new tests.
3339 * platform/graphics/chromium/LayerRendererChromium.cpp:
3340 (WebCore::LayerRendererChromium::drawLayersInternal):
3341 (WebCore::LayerRendererChromium::initializeSharedObjects):
3342 (WebCore::LayerRendererChromium::tilerProgramOpaque):
3343 (WebCore::LayerRendererChromium::tilerProgramOpaqueAA):
3344 (WebCore::LayerRendererChromium::tilerProgramSwizzleOpaque):
3345 (WebCore::LayerRendererChromium::tilerProgramSwizzleOpaqueAA):
3346 (WebCore::LayerRendererChromium::cleanupSharedObjects):
3347 * platform/graphics/chromium/LayerRendererChromium.h:
3348 * platform/graphics/chromium/ShaderChromium.cpp:
3349 (WebCore::FragmentTexOpaqueBinding::FragmentTexOpaqueBinding):
3350 (WebCore::FragmentTexOpaqueBinding::init):
3351 (WebCore::FragmentShaderRGBATexOpaque::getShaderString):
3352 (WebCore::FragmentShaderRGBATexSwizzleOpaque::getShaderString):
3353 (WebCore::FragmentTexClampOpaqueAABinding::FragmentTexClampOpaqueAABinding):
3354 (WebCore::FragmentTexClampOpaqueAABinding::init):
3355 (WebCore::FragmentShaderRGBATexClampOpaqueAA::getShaderString):
3356 (WebCore::FragmentShaderRGBATexClampSwizzleOpaqueAA::getShaderString):
3357 * platform/graphics/chromium/ShaderChromium.h:
3358 (WebCore::FragmentTexOpaqueBinding::alphaLocation):
3359 (WebCore::FragmentTexOpaqueBinding::samplerLocation):
3360 (WebCore::FragmentTexClampOpaqueAABinding::alphaLocation):
3361 (WebCore::FragmentTexClampOpaqueAABinding::samplerLocation):
3362 (WebCore::FragmentTexClampOpaqueAABinding::fragmentTexTransformLocation):
3363 (WebCore::FragmentTexClampOpaqueAABinding::edgeLocation):
3364 * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
3365 (WebCore::CCTiledLayerImpl::draw):
3366 * platform/graphics/chromium/cc/CCTiledLayerImpl.h:
3368 2011-11-16 Tim Horton <timothy_horton@apple.com>
3370 Implement CSS3 Images cross-fade() image function
3371 https://bugs.webkit.org/show_bug.cgi?id=52162
3372 <rdar://problem/10209254>
3374 Reviewed by Simon Fraser.
3376 Render -webkit-cross-fade. Only cross-fades entirely composed of images will render for now,
3377 cross-fades involving generated images are not yet implemented.
3379 Reorganize GeneratedImage to be the base class for GeneratorGeneratedImage and CrossfadeGeneratedImage.
3381 Add a pending state to CSSImageGeneratorValue, which is used to enable the pending-images loading
3382 mechanism for -webkit-cross-fade's sub-images. Rework the logic in CSSStyleSelector to support pending
3385 Support parsing fractional values for the cross-fade amount (for example, 0.5 = 50%). Clamp cross-fade
3386 amount to 0-1 range.
3388 Tests: css3/images/cross-fade-invalidation.html
3389 css3/images/cross-fade-simple.html
3390 css3/images/cross-fade-sizing.html
3391 css3/images/cross-fade-tiled.html
3394 * GNUmakefile.list.am:
3397 * WebCore.xcodeproj/project.pbxproj:
3398 * css/CSSCanvasValue.h:
3399 (WebCore::CSSCanvasValue::isPending):
3400 (WebCore::CSSCanvasValue::loadSubimages):
3401 * css/CSSCrossfadeValue.cpp:
3402 (WebCore::CSSCrossfadeValue::isPending):
3403 (WebCore::CSSCrossfadeValue::loadSubimages):
3404 (WebCore::subimageIsPending):
3405 (WebCore::loadSubimage):
3406 (WebCore::cachedImageForCSSValue):
3407 (WebCore::CSSCrossfadeValue::image):
3408 (WebCore::CSSCrossfadeValue::crossfadeChanged):
3409 * css/CSSCrossfadeValue.h:
3410 (WebCore::CSSCrossfadeValue::create):
3411 (WebCore::CSSCrossfadeValue::~CSSCrossfadeValue):
3412 (WebCore::CSSCrossfadeValue::fixedSize):
3413 (WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
3414 (WebCore::CSSCrossfadeValue::CrossfadeObserverProxy::CrossfadeObserverProxy):
3415 * css/CSSGradientValue.cpp:
3416 (WebCore::CSSGradientValue::image):
3417 * css/CSSGradientValue.h:
3418 (WebCore::CSSGradientValue::isPending):
3419 (WebCore::CSSGradientValue::loadSubimages):
3420 * css/CSSImageGeneratorValue.cpp:
3421 (WebCore::CSSImageGeneratorValue::generatedOrPendingImage):
3422 (WebCore::CSSImageGeneratorValue::generatedImage):
3423 (WebCore::CSSImageGeneratorValue::isPending):
3424 (WebCore::CSSImageGeneratorValue::loadSubimages):
3425 * css/CSSImageGeneratorValue.h:
3426 * css/CSSParser.cpp:
3427 (WebCore::CSSParser::parseCrossfade):
3428 * css/CSSStyleSelector.cpp:
3429 (WebCore::CSSStyleSelector::styleImage):
3430 (WebCore::CSSStyleSelector::generatedOrPendingFromValue):
3431 (WebCore::CSSStyleSelector::loadPendingImage):
3432 (WebCore::CSSStyleSelector::loadPendingImages):
3433 * css/CSSStyleSelector.h:
3434 * platform/graphics/BitmapImage.h:
3435 * platform/graphics/CrossfadeGeneratedImage.cpp: Added.
3436 (WebCore::CrossfadeGeneratedImage::CrossfadeGeneratedImage):
3437 (WebCore::CrossfadeGeneratedImage::~CrossfadeGeneratedImage):
3438 (WebCore::CrossfadeGeneratedImage::drawCrossfade):
3439 (WebCore::CrossfadeGeneratedImage::draw):
3440 (WebCore::CrossfadeGeneratedImage::drawPattern):
3441 (WebCore::CrossfadeGeneratedImage::imageChanged):
3442 * platform/graphics/CrossfadeGeneratedImage.h: Added.
3443 (WebCore::CrossfadeGeneratedImage::create):
3444 (WebCore::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):
3445 (WebCore::CrossfadeSubimageObserverProxy::setReady):
3446 * platform/graphics/GeneratedImage.h:
3447 (WebCore::GeneratedImage::GeneratedImage):
3448 * platform/graphics/GeneratorGeneratedImage.cpp: Renamed from Source/WebCore/platform/graphics/GeneratedImage.cpp.
3449 (WebCore::GeneratorGeneratedImage::draw):
3450 (WebCore::GeneratorGeneratedImage::drawPattern):
3451 (WebCore::GeneratedImage::computeIntrinsicDimensions):
3452 * platform/graphics/GeneratorGeneratedImage.h: Copied from Source/WebCore/platform/graphics/GeneratedImage.h.
3453 (WebCore::GeneratorGeneratedImage::create):
3454 (WebCore::GeneratorGeneratedImage::~GeneratorGeneratedImage):
3455 (WebCore::GeneratorGeneratedImage::GeneratorGeneratedImage):
3456 * platform/graphics/Image.h:
3457 * platform/graphics/ImageBuffer.h:
3458 * rendering/style/StylePendingImage.h:
3459 (WebCore::StylePendingImage::create):
3460 (WebCore::StylePendingImage::data):
3461 (WebCore::StylePendingImage::cssImageValue):
3462 (WebCore::StylePendingImage::cssImageGeneratorValue):
3463 (WebCore::StylePendingImage::StylePendingImage):
3466 2011-11-16 Dan Bernstein <mitz@apple.com>
3468 WebCore part of <rdar://problem/10262242> Add API for paginated display
3469 https://bugs.webkit.org/show_bug.cgi?id=72537
3471 Reviewed by Anders Carlsson.
3473 * WebCore.exp.in: Exported Page::pageCount().
3475 (WebCore::Page::pageCount): Added this getter.
3478 2011-11-16 Shawn Singh <shawnsingh@chromium.org>
3480 [chromium] Track property changes for render surfaces.
3481 https://bugs.webkit.org/show_bug.cgi?id=72521
3483 Reviewed by James Robinson.
3485 Created CCRenderSurfaceTest for testing.
3487 * platform/graphics/chromium/LayerRendererChromium.cpp:
3488 (WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
3489 * platform/graphics/chromium/cc/CCLayerImpl.cpp:
3490 (WebCore::CCLayerImpl::resetPropertyChangedFlagForSubtree):
3491 * platform/graphics/chromium/cc/CCLayerImpl.h:
3492 * platform/graphics/chromium/cc/CCRenderSurface.cpp:
3493 (WebCore::CCRenderSurface::CCRenderSurface):
3494 (WebCore::CCRenderSurface::setClipRect):
3495 (WebCore::CCRenderSurface::setContentRect):
3496 (WebCore::CCRenderSurface::surfacePropertyChanged):
3497 * platform/graphics/chromium/cc/CCRenderSurface.h:
3498 (WebCore::CCRenderSurface::resetPropertyChangedFlag):
3500 2011-11-16 Ben Wells <benwells@chromium.org>