Source/WebCore/ChangeLog

   1 2011-10-12  David Hyatt  <hyatt@apple.com>
   2
   3         https://bugs.webkit.org/show_bug.cgi?id=69950
   4
   5         REGRESSION: Printing broken because of the isWritingModeRoot addition for unsplittable
   6         paginated content. Make sure not to include the RenderView when checking for writing mode
   7         roots. We only care about children that differ from their parents.
   8
   9         Reviewed by Dimitri Glazkov.
  10
  11         * rendering/LayoutState.cpp:
  12         (WebCore::LayoutState::LayoutState):
  13         * rendering/RenderBlock.cpp:
  14         (WebCore::RenderBlock::adjustForUnsplittableChild):
  15         * rendering/RenderBox.cpp:
  16         (WebCore::RenderBox::isUnsplittableForPagination):
  17         * rendering/RenderBox.h:
  18
  19 2011-10-12  Anna Cavender  <annacc@chromium.org>
  20
  21         Moving ScriptExecutionContext to the front of the argument list for
  22         IDL constructors that use ConstructorWith=ScriptExecutionContext.
  23         https://bugs.webkit.org/show_bug.cgi?id=69799
  24
  25         Reviewed by Adam Barth.
  26
  27         Tests:
  28         - http/tests/eventsource/* (for EventSource)
  29         - fast/filesystem/* (for Worker)
  30
  31         * bindings/js/JSEventSourceCustom.cpp:
  32         (WebCore::JSEventSourceConstructor::constructJSEventSource):
  33         * bindings/js/JSWorkerCustom.cpp:
  34         (WebCore::JSWorkerConstructor::constructJSWorker):
  35         * bindings/scripts/CodeGeneratorV8.pm:
  36         (GenerateConstructorCallback):
  37         * bindings/scripts/test/V8/V8TestInterface.cpp:
  38         (WebCore::V8TestInterface::constructorCallback):
  39         * page/EventSource.cpp:
  40         (WebCore::EventSource::create):
  41         * page/EventSource.h:
  42         * workers/Worker.cpp:
  43         (WebCore::Worker::create):
  44         * workers/Worker.h:
  45
  46 2011-10-11  David Hyatt  <hyatt@apple.com>
  47
  48         https://bugs.webkit.org/show_bug.cgi?id=69896
  49
  50         [CSS Regions] Make positioned blocks work with variable width regions.
  51
  52         Make positioned objects able to position and size independently in each region. This involves
  53         lifting the restriction in renderBoxRegionInfo for positioned objects and passing in region
  54         information to computeLogicalWidthForPositioned so that it can compute answers for a given
  55         region.
  56
  57         In order to make mixed writing modes work with positioned objects, this patch also takes some
  58         baby steps towards fixing differing writing modes in paginated environments.
  59
  60         Reviewed by Sam Weinig.
  61
  62         Added many new tests in fast/regions.
  63
  64         * rendering/LayoutState.cpp:
  65         (WebCore::LayoutState::LayoutState):
  66         Disable pagination whenever differing writing modes are encountered. The block effectively becomes
  67         unsplittable (as though it was an image).
  68
  69         * rendering/RenderBlock.cpp:
  70         (WebCore::RenderBlock::layoutBlock):
  71         Remove a FIXME that looks incorrect now.
  72
  73         (WebCore::RenderBlock::adjustPositionedBlock):
  74         Patch static inline position caching to call a new method that unshifts the position to put it back
  75         in the overall block's space rather than having it be per-region.
  76
  77         (WebCore::RenderBlock::layoutPositionedObjects):
  78         Make sure to attempt to set a logicalTop for positioned objects before they lay out so that they
  79         have a chance of paginating correctly the first time around. If for some reason the top estimate proves
  80         to be incorrect, we lay out again. Technically this bug exists for multi-column and printing as well, but
  81         for now just fixing it for regions.
  82
  83         (WebCore::RenderBlock::adjustForUnsplittableChild):
  84         Add writing mode roots to the set of objects we consider to be unsplittable.
  85
  86         (WebCore::RenderBlock::setStaticInlinePositionForChild):
  87         New helper function that handles shifting the inline static position back into the overall block's space
  88         rather than leaving it in a translated region-specific space.
  89
  90         * rendering/RenderBlock.h:
  91         (WebCore::RenderBlock::startOffsetForContent):
  92         New helper function for computing the start offset when no regions are involved.
  93
  94         * rendering/RenderBlockLineLayout.cpp:
  95         (WebCore::setStaticPositions):
  96         (WebCore::RenderBlock::LineBreaker::nextLineBreak):
  97         Patched to call the new helper function, setStaticInlinePositionForChild.
  98
  99         * rendering/RenderBox.cpp:
 100         (WebCore::RenderBox::positionLineBox):
 101         Patched to call the new helper function, setStaticInlinePositionForChild.
 102
 103         (WebCore::RenderBox::computeLogicalWidthInRegion):
 104         Pass region information into the positioning logical width computation function.
 105
 106         (WebCore::RenderBox::renderBoxRegionInfo):
 107         Remove the positioning restriction and properly compute shifting and left/right offsets for positioned
 108         objects.
 109
 110         (WebCore::RenderBox::computeLogicalHeight):
 111         Add code for perpendicular flows that just positions the object within the first region it is encountered
 112         in. Since the object is unsplittable, this will work out. Should the object be so tall that it can't fit
 113         in any region, then the resulting rendering will potentially be terrible, but the expectation is that authors should
 114         avoid having perpendicular flows break across pages.
 115
 116         (WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
 117         (WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
 118         Patched to handle regions when they are passed in. Also makes sure that the pagination direction axis computation uses
 119         the flow thread's first region when the flow thread is the positioned object's containing block.
 120
 121         (WebCore::computeInlineStaticDistance):
 122         Patched to examine regions and to modify the static distance computation accordingly so that it is per-region.
 123
 124         (WebCore::RenderBox::computePositionedLogicalWidth):
 125         Pass along the region information when computing the positioned logical width.
 126
 127         (WebCore::computeLogicalLeftPositionedOffset):
 128         Handle the adjustment of the logical left offset for differing writing modes (in this case when the writing mode
 129         is flipped relative to us).
 130
 131         (WebCore::RenderBox::computePositionedLogicalHeight):
 132         Deal with perpendicular writing modes and make sure the object is placed properly using the first region it
 133         occurs in.
 134
 135         (WebCore::computeLogicalTopPositionedOffset):
 136         Remove code that is no longer needed.
 137
 138         (WebCore::RenderBox::computePositionedLogicalWidthReplaced):
 139         Patched to pass in 0 instead of a region since replaced elements aren't handled yet.
 140
 141         * rendering/RenderBox.h:
 142         Changing the computePositionedLogicalWidth method to take region information.
 143
 144         * rendering/RenderDeprecatedFlexibleBox.cpp:
 145         (WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
 146         (WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
 147         Didn't bother fixing deprecated flexible box, and the new flexbox still can't handle positioned objects. When it does,
 148         it will use the new method. Put in some FIXMEs to help the flexbox coders see the issue when they port the code over
 149         to the new flexbox.
 150
 151         * rendering/RenderLayer.h:
 152         (WebCore::RenderLayer::staticInlinePosition):
 153         (WebCore::RenderLayer::staticBlockPosition):
 154         (WebCore::RenderLayer::setStaticInlinePosition):
 155         (WebCore::RenderLayer::setStaticBlockPosition):
 156         Patched to take LayoutUnits instead of ints.
 157
 158 2011-10-12  Nate Chapin  <japhet@chromium.org>
 159
 160         Remove logging to determine how null v8::Contexts are happening,
 161         and check the return value of V8DOMWindowShell::initContextIfNeeded()
 162         before using the context it initialized.
 163         https://bugs.webkit.org/show_bug.cgi?id=68099
 164
 165         Reviewed by Adam Barth.
 166
 167         No new tests, the only symptom is a crash without a known repro.
 168
 169         * bindings/v8/ScriptController.cpp:
 170         * bindings/v8/V8DOMWindowShell.cpp:
 171         (WebCore::V8DOMWindowShell::initContextIfNeeded): Return true
 172             if a context already existed.
 173         (WebCore::V8DOMWindowShell::namedItemAdded): Remove logging.
 174         * bindings/v8/V8Proxy.cpp:
 175
 176 2011-10-06  Robert Hogan  <robert@webkit.org>
 177
 178         CSS 2.1 failure: border-conflict-style-079
 179         https://bugs.webkit.org/show_bug.cgi?id=69551
 180
 181         Reviewed by Antonio Gomes.
 182
 183         * css/CSSValueKeywords.in: ridge and outset were the wrong way round
 184         * rendering/style/RenderStyleConstants.h: ditto
 185
 186
 187 2011-10-12  Jian Li  <jianli@chromium.org>
 188
 189         Support passing optional filename when FormData.append() is used to
 190         append a blob
 191         https://bugs.webkit.org/show_bug.cgi?id=69885
 192
 193         Reviewed by David Levin.
 194
 195         Covered by existing test with new test case added:
 196         http/tests/local/formdata/send-form-data-with-sliced-file.html
 197
 198         * bindings/js/JSDOMFormDataCustom.cpp:
 199         (WebCore::JSDOMFormData::append):
 200         * bindings/v8/custom/V8DOMFormDataCustom.cpp:
 201         (WebCore::V8DOMFormData::appendCallback):
 202         * html/DOMFormData.cpp:
 203         (WebCore::DOMFormData::append):
 204         * html/DOMFormData.h:
 205         * html/DOMFormData.idl:
 206         * html/FormDataList.cpp:
 207         (WebCore::FormDataList::appendBlob):
 208         * html/FormDataList.h:
 209         (WebCore::FormDataList::Item::Item):
 210         (WebCore::FormDataList::Item::filename):
 211         (WebCore::FormDataList::appendBlob):
 212         * platform/network/FormData.cpp:
 213         (WebCore::FormData::appendKeyValuePairItems):
 214
 215 2011-10-12  Sergey Glazunov  <serg.glazunov@gmail.com>
 216
 217         ScriptController::executeIfJavaScriptURL gets confused by synchronous frame loads
 218         https://bugs.webkit.org/show_bug.cgi?id=69777
 219
 220         Reviewed by Adam Barth.
 221
 222         Test: http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url.html
 223
 224         * bindings/ScriptControllerBase.cpp:
 225         (WebCore::ScriptController::executeIfJavaScriptURL):
 226         * loader/DocumentWriter.cpp:
 227         (WebCore::DocumentWriter::replaceDocument):
 228         (WebCore::DocumentWriter::begin):
 229         * loader/DocumentWriter.h:
 230
 231 2011-10-12  Vsevolod Vlasov  <vsevik@chromium.org>
 232
 233         Web Inspector: Searching in multiple scripts in the scripts tab
 234         https://bugs.webkit.org/show_bug.cgi?id=38807
 235
 236         Reviewed by Pavel Feldman.
 237
 238         Added support for advanced search capabilities in inspector by means
 239         of showing the new SearchView in Drawer. Advanced search is activated
 240         with Ctrl+Shift+F (Cmd+Shift+F) shortcut.
 241
 242         * English.lproj/localizedStrings.js:
 243         * WebCore.gypi:
 244         * WebCore.vcproj/WebCore.vcproj:
 245         * inspector/compile-front-end.sh:
 246         * inspector/front-end/AdvancedSearchController.js: Added.
 247         * inspector/front-end/DebuggerPresentationModel.js:
 248         (WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
 249         * inspector/front-end/ScriptsPanel.js:
 250         * inspector/front-end/ScriptsSearchScope.js: Added.
 251         * inspector/front-end/UISourceCode.js:
 252         (WebInspector.UISourceCode.prototype.searchInContent):
 253         * inspector/front-end/WebKit.qrc:
 254         * inspector/front-end/externs.js:
 255         (WebInspector.showViewInDrawer):
 256         * inspector/front-end/inspector.css:
 257         (.search-view):
 258         (.search-view .search-panel):
 259         (.search-view .search-results):
 260         (#search-results-pane-file-based .search-result):
 261         (#search-results-pane-file-based .search-result:first-child):
 262         (#search-results-pane-file-based .search-result .search-result-file-name):
 263         (#search-results-pane-file-based .search-result .search-result-matches-count):
 264         (#search-results-pane-file-based .search-match):
 265         (#search-results-pane-file-based .search-match .webkit-line-number.search-match-line-number):
 266         (#search-results-pane-file-based .search-match:not(:hover) .webkit-line-number.search-match-line-number):
 267         (#search-results-pane-file-based .search-match:hover):
 268         (#search-results-pane-file-based .search-match .highlighted-match):
 269         (#search-results-pane-file-based a):
 270         (#search-results-pane-file-based .search-match .search-match-content):
 271         * inspector/front-end/inspector.html:
 272         * inspector/front-end/inspector.js:
 273         (WebInspector.documentKeyDown):
 274         * inspector/front-end/utilities.js:
 275         ():
 276
 277 2011-10-12  Vsevolod Vlasov  <vsevik@chromium.org>
 278
 279         Web Inspector: Fix Drawer to make it possible to show views other than Console.
 280         https://bugs.webkit.org/show_bug.cgi?id=69831
 281
 282         Reviewed by Pavel Feldman.
 283
 284         Animation type extracted to distinguish between slow and normal
 285         animation and immediate show/hide.
 286         Implemented correct console toggle button behavior on showing views
 287         other than console in Drawer.
 288         View shown in Drawer is now shown in drawer-contents div with common
 289         styles moved there.
 290         Removed unused "_safelyRemoveChildren" method from Drawer.
 291
 292         * inspector/front-end/ConsolePanel.js:
 293         (WebInspector.ConsolePanel.prototype.show):
 294         (WebInspector.ConsolePanel.prototype.hide):
 295         * inspector/front-end/Drawer.js:
 296         (WebInspector.Drawer):
 297         (WebInspector.Drawer.prototype.show):
 298         (WebInspector.Drawer.prototype.hide):
 299         (WebInspector.Drawer.prototype._animationDuration):
 300         * inspector/front-end/inspector.css:
 301         (body.drawer-visible #drawer-contents):
 302         * inspector/front-end/inspector.js:
 303         (WebInspector._toggleConsoleButtonClicked):
 304         (WebInspector._escPressed):
 305         (WebInspector.showViewInDrawer):
 306         (WebInspector.documentKeyDown):
 307
 308 2011-10-12  Yury Semikhatsky  <yurys@chromium.org>
 309
 310         [v8] Use V8DOMWrapper::isWrapperOfType for determining global object type
 311         https://bugs.webkit.org/show_bug.cgi?id=69923
 312
 313         Get rid of globalObjectPrototypeIsDOMWindow, use V8DOMWrapper::isWrapperOfType instead.
 314
 315         Reviewed by Pavel Feldman.
 316
 317         * bindings/v8/V8DOMWrapper.cpp:
 318         (WebCore::V8DOMWrapper::instantiateV8Object):
 319         (WebCore::V8DOMWrapper::getEventListener):
 320
 321 2011-10-12  Yury Semikhatsky  <yurys@chromium.org>
 322
 323         [Chromium] Web Inspector: assertion failure when evaluating expression in worker inspector console
 324         https://bugs.webkit.org/show_bug.cgi?id=69922
 325
 326         Check that the global object is a DOMWindow wrapper befor casting it to V8DOMWindow.
 327
 328         Reviewed by Pavel Feldman.
 329
 330         * bindings/v8/ScriptState.cpp:
 331         (WebCore::ScriptState::domWindow):
 332
 333 2011-10-12  Yuta Kitamura  <yutak@chromium.org>
 334
 335         WebSocket: Update WebSocket protocol to hybi-17
 336         https://bugs.webkit.org/show_bug.cgi?id=69910
 337
 338         Reviewed by Kent Tamura.
 339
 340         Essential changes between hybi-10 and hybi-17 are:
 341         - Sec-WebSocket-Origin header has been renamed to "Origin".
 342         - Sec-WebSocket-Version header value has been bumped to 13.
 343
 344         No new tests are necessary. pywebsocket has already been updated to the latest version
 345         which understands the new protocol. Tests under http/tests/websocket/ should keep
 346         passing.
 347
 348         * websockets/WebSocketHandshake.cpp:
 349         (WebCore::WebSocketHandshake::clientHandshakeMessage):
 350         (WebCore::WebSocketHandshake::clientHandshakeRequest):
 351
 352 2011-10-11  Antti Koivisto  <antti@apple.com>
 353
 354         Resolve regular and visited link style in a single pass
 355         https://bugs.webkit.org/show_bug.cgi?id=69838
 356
 357         Reviewed by Darin Adler
 358
 359         We can simplify and speed up selector matching by removing the recursive matching done
 360         to generate the style for the :visited pseudo selector. Both regular and visited link style
 361         can be generated in a single pass through the style selector.
 362
 363         - Make SelectorChecker::checkSelector to return both :visited and :link matches for all links.
 364         - For each selector statically determine and cache the link states it may match.
 365         - When applying the matched style declarations, apply them to the right RenderStyle
 366           (regular, visited, or both).
 367
 368         Statically determining which link state will be matched works since we only support :visited matching
 369         based on the current element state (not ancestors or siblings).
 370
 371         A later patch will eliminate the separate RenderStyle for visited style completely and include the
 372         few allowed properties to the regular RenderStyle.
 373
 374         * css/CSSStyleSelector.cpp:
 375         (WebCore::RuleData::linkMatchType):
 376         (WebCore::RuleSet::linkPseudoClassRules):
 377         (WebCore::CSSStyleSelector::addMatchedDeclaration):
 378         (WebCore::CSSStyleSelector::matchRules):
 379         (WebCore::CSSStyleSelector::styleForElement):
 380         (WebCore::CSSStyleSelector::pseudoStyleForElement):
 381         (WebCore::CSSStyleSelector::updateFont):
 382         (WebCore::CSSStyleSelector::checkSelector):
 383         (WebCore::RuleData::RuleData):
 384         (WebCore::RuleSet::addRule):
 385         (WebCore::RuleSet::collectFeatures):
 386         (WebCore::RuleSet::shrinkToFit):
 387         (WebCore::CSSStyleSelector::applyDeclaration):
 388         (WebCore::CSSStyleSelector::applyDeclarations):
 389         (WebCore::CSSStyleSelector::applyProperty):
 390         (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
 391         * css/CSSStyleSelector.h:
 392         (WebCore::CSSStyleSelector::MatchedStyleDeclaration::MatchedStyleDeclaration):
 393         * css/SelectorChecker.cpp:
 394         (WebCore::SelectorChecker::SelectorChecker):
 395         (WebCore::SelectorChecker::checkSelector):
 396         (WebCore::SelectorChecker::fastCheckRightmostSelector):
 397         (WebCore::SelectorChecker::fastCheckSelector):
 398         (WebCore::SelectorChecker::checkOneSelector):
 399         (WebCore::SelectorChecker::commonPseudoClassSelectorMatches):
 400         (WebCore::SelectorChecker::determineLinkMatchType):
 401         * css/SelectorChecker.h:
 402         * rendering/style/RenderStyle.cpp:
 403         (WebCore::RenderStyle::addCachedPseudoStyle):
 404
 405 2011-10-12  Kent Tamura  <tkent@chromium.org>
 406
 407         REGRESSION(r94836): An assertion fails in HTMLFormControlElement::isValidFormControlElement
 408         when HTMLInputElement::setValue() is called while the element is focused.
 409         https://bugs.webkit.org/show_bug.cgi?id=69909
 410
 411         Reviewed by Ryosuke Niwa.
 412
 413         setNeedsValidityCheck() should be called after the value update
 414         and before any style recalculation. r94836 moved
 415         setSelectionRange() call, and it recalculates the element style.
 416
 417         * html/HTMLInputElement.cpp:
 418         (WebCore::HTMLInputElement::setValue): Move setNeedsValidityCheck() to setValueInternal().
 419         (WebCore::HTMLInputElement::setValueInternal): Move setNeedsValidityCheck() from setValue().
 420
 421 2011-10-12  Kent Tamura  <tkent@chromium.org>
 422
 423         Build fixes for r97238.
 424         https://bugs.webkit.org/show_bug.cgi?id=69828
 425
 426         * GNUmakefile.list.am: Remove SelectElement.{cpp,h}.
 427         * dom/DOMAllInOne.cpp: Remove SelectElement.cpp.
 428
 429 2011-10-12  Kent Tamura  <tkent@chromium.org>
 430
 431         Move the content of SelectElementData into HTMLSelectElement, and remove SelectElement.{cpp,h}
 432         https://bugs.webkit.org/show_bug.cgi?id=69828
 433
 434         Reviewed by Darin Adler.
 435
 436         - Move all of the data members of SelectElementData to
 437         HTMLSelectElement, and their accessor functions are not needed
 438         anymore.
 439         - Move SelectElementData::useMenuList() to HTMLSelectElement.
 440
 441         No new tests, just a refactoring.
 442
 443         * CMakeLists.txt: Remove SelectElement.cpp.
 444         * WebCore.gypi: Remove SelectElement.{cpp,h}.
 445         * WebCore.pro: ditto.
 446         * WebCore.vcproj/WebCore.vcproj: ditto.
 447         * WebCore.xcodeproj/project.pbxproj: ditto.
 448         * dom/OptionElement.cpp: Remove a reference to SelectElement.h.
 449         * dom/SelectElement.cpp: Removed.
 450         * dom/SelectElement.h: Removed.
 451         * html/HTMLSelectElement.cpp:
 452         (WebCore::HTMLSelectElement::HTMLSelectElement):
 453         Initializes the moved data members.
 454         (WebCore::HTMLSelectElement::formControlType):
 455         (WebCore::HTMLSelectElement::setSelectedIndexByUser):
 456         (WebCore::HTMLSelectElement::activeSelectionStartListIndex):
 457         (WebCore::HTMLSelectElement::activeSelectionEndListIndex):
 458         (WebCore::HTMLSelectElement::parseMappedAttribute):
 459         (WebCore::HTMLSelectElement::canSelectAll):
 460         (WebCore::HTMLSelectElement::createRenderer):
 461         (WebCore::HTMLSelectElement::setOption):
 462         (WebCore::HTMLSelectElement::selectAll):
 463         (WebCore::HTMLSelectElement::saveLastSelection):
 464         (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
 465         (WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
 466         (WebCore::HTMLSelectElement::updateListBoxSelection):
 467         (WebCore::HTMLSelectElement::listBoxOnChange):
 468         (WebCore::HTMLSelectElement::menuListOnChange):
 469         (WebCore::HTMLSelectElement::scrollToSelection):
 470         (WebCore::HTMLSelectElement::setOptionsChangedOnRenderer):
 471         (WebCore::HTMLSelectElement::setRecalcListItems):
 472         (WebCore::HTMLSelectElement::recalcListItemsInternal):
 473         (WebCore::HTMLSelectElement::setSelectedIndexInternal):
 474         (WebCore::HTMLSelectElement::dispatchFocusEvent):
 475         (WebCore::HTMLSelectElement::dispatchBlurEvent):
 476         (WebCore::HTMLSelectElement::parseMultipleAttribute):
 477         (WebCore::HTMLSelectElement::reset):
 478         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
 479         (WebCore::HTMLSelectElement::updateSelectedState):
 480         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
 481         (WebCore::HTMLSelectElement::defaultEventHandler):
 482         (WebCore::HTMLSelectElement::typeAheadFind):
 483         (WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
 484         * html/HTMLSelectElement.h:
 485         (WebCore::HTMLSelectElement::size):
 486         (WebCore::HTMLSelectElement::multiple):
 487         (WebCore::HTMLSelectElement::usesMenuList):
 488
 489 2011-10-12  Ryosuke Niwa  <rniwa@webkit.org>
 490
 491         Chromium Mac build fix after r97227.
 492
 493         * platform/chromium/ScrollbarThemeChromiumMac.mm:
 494         (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
 495
 496 2011-10-11  Antoine Labour  <piman@chromium.org>
 497
 498         Separate compositor client thread from webkit's main thread.
 499         https://bugs.webkit.org/show_bug.cgi?id=69048
 500
 501         Reviewed by Darin Fisher.
 502
 503         Covered by compositing tests.
 504
 505         * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
 506         (WebCore::CCLayerTreeHost::CCLayerTreeHost):
 507         * platform/graphics/chromium/cc/CCMainThread.cpp:
 508         * platform/graphics/chromium/cc/CCMainThread.h:
 509         * platform/graphics/chromium/cc/CCProxy.cpp:
 510         (WebCore::CCProxy::isMainThread):
 511         (WebCore::CCProxy::setMainThread):
 512         (WebCore::CCProxy::CCProxy):
 513         * platform/graphics/chromium/cc/CCProxy.h:
 514
 515 2011-10-11  Simon Fraser  <simon.fraser@apple.com>
 516
 517         Fix Leopard and Snow Leopard builds, which don't use the scrollbar painter.
 518
 519         * platform/mac/ScrollAnimatorMac.mm:
 520
 521 2011-10-11  Simon Fraser  <simon.fraser@apple.com>
 522
 523         Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms
 524         https://bugs.webkit.org/show_bug.cgi?id=68134
 525
 526         Reviewed by Darin Adler.
 527
 528         Use ScrollbarThemeMock when the setting to use mock scrollbars is enabled.
 529
 530         Make ScrollbarTheme::nativeTheme() private, and add a new static theme() method
 531         that reads the setting, and returns the mock theme if set. All callers now use
 532         theme() rther than nativeTheme(). Add the new ScrollbarTheme.cpp file to the build.
 533
 534         Fix scroll animator code for Mac and Chromium that was casting the ScrollbarTheme
 535         without type-checking it to test whether it's the mock theme.
 536
 537         * CMakeLists.txt:
 538         * GNUmakefile.list.am:
 539         * WebCore.exp.in:
 540         * WebCore.gypi:
 541         * WebCore.pro:
 542         * WebCore.vcproj/WebCore.vcproj:
 543         * WebCore.xcodeproj/project.pbxproj:
 544         * html/shadow/TextControlInnerElements.cpp:
 545         (WebCore::SpinButtonElement::startRepeatingTimer):
 546         * platform/ScrollAnimatorWin.cpp:
 547         (WebCore::ScrollAnimatorWin::scroll):
 548         (WebCore::ScrollAnimatorWin::accelerationTime):
 549         (WebCore::ScrollAnimatorWin::animateScroll):
 550         * platform/ScrollView.cpp:
 551         (WebCore::ScrollView::wheelEvent):
 552         * platform/ScrollableArea.cpp:
 553         (WebCore::ScrollableArea::setScrollbarOverlayStyle):
 554         * platform/Scrollbar.cpp:
 555         (WebCore::Scrollbar::maxOverlapBetweenPages):
 556         (WebCore::Scrollbar::Scrollbar):
 557         * platform/ScrollbarTheme.cpp: Copied from Source/WebCore/platform/mock/ScrollbarThemeMock.h.
 558         (WebCore::ScrollbarTheme::theme):
 559         * platform/ScrollbarTheme.h:
 560         (WebCore::ScrollbarTheme::isMockTheme):
 561         * platform/chromium/PopupListBox.cpp:
 562         (WebCore::PopupListBox::layout):
 563         * platform/chromium/ScrollAnimatorChromiumMac.mm:
 564         (WebCore::chromiumScrollbarTheme):
 565         (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar):
 566         (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar):
 567         (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar):
 568         (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar):
 569         (WebCore::ScrollAnimatorChromiumMac::updateScrollerStyle):
 570         * platform/chromium/ScrollbarThemeChromiumMac.mm:
 571         (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
 572         (+[ScrollbarPrefsObserver behaviorPrefsChanged:]):
 573         * platform/mac/ScrollAnimatorMac.mm:
 574         (WebCore::macScrollbarTheme):
 575         (WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
 576         (WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
 577         (WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
 578         (WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
 579         (WebCore::ScrollAnimatorMac::updateScrollerStyle):
 580         * platform/mac/ScrollbarThemeMac.mm:
 581         (+[WebScrollbarPrefsObserver appearancePrefsChanged:]):
 582         (+[WebScrollbarPrefsObserver behaviorPrefsChanged:]):
 583         * platform/mock/ScrollbarThemeMock.h:
 584         (WebCore::ScrollbarThemeMock::isMockTheme):
 585         * platform/qt/RenderThemeQt.cpp:
 586         (WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
 587         * platform/win/PopupMenuWin.cpp:
 588         (WebCore::PopupMenuWin::calculatePositionAndSize):
 589         * rendering/RenderLayer.cpp:
 590         (WebCore::cornerRect):
 591         * rendering/RenderScrollbarPart.cpp:
 592         (WebCore::calcScrollbarThicknessUsing):
 593         * rendering/RenderScrollbarTheme.h:
 594         (WebCore::RenderScrollbarTheme::scrollbarThickness):
 595         (WebCore::RenderScrollbarTheme::buttonsPlacement):
 596         (WebCore::RenderScrollbarTheme::shouldCenterOnThumb):
 597         (WebCore::RenderScrollbarTheme::initialAutoscrollTimerDelay):
 598         (WebCore::RenderScrollbarTheme::autoscrollTimerDelay):
 599         (WebCore::RenderScrollbarTheme::registerScrollbar):
 600         (WebCore::RenderScrollbarTheme::unregisterScrollbar):
 601         * rendering/RenderTextControl.cpp:
 602         (WebCore::RenderTextControl::scrollbarThickness):
 603         * rendering/RenderThemeChromiumSkia.cpp:
 604         (WebCore::RenderThemeChromiumSkia::menuListInternalPadding):
 605         * rendering/RenderThemeChromiumWin.cpp:
 606         (WebCore::RenderThemeChromiumWin::adjustInnerSpinButtonStyle):
 607
 608 2011-10-11  Kentaro Hara  <haraken@chromium.org>
 609
 610         Implement a WebKitTransitionEvent constructor for JSC
 611         https://bugs.webkit.org/show_bug.cgi?id=69829
 612
 613         Reviewed by Adam Barth.
 614
 615         There is no spec for the WebKitTransitionEvent constructor
 616         since it is WebKit-specific. However, judging from the current
 617         IDL of initWebKitTransitionEvent(), the constructor IDL
 618         should be as follows.
 619
 620         [Constructor(DOMString type, optional WebKitTransitionEventInit eventInitDict)]
 621         interface WebKitTransitionEvent : Event {
 622             ...;
 623         }
 624
 625         dictionary WebKitTransitionEventInit : EventInit {
 626             DOMString propertyName;
 627             double elapsedTime;
 628         }
 629
 630         Test: fast/events/constructors/webkit-transition-event-constructor.html
 631
 632         * bindings/generic/EventConstructors.h: Added a definition for the WebKitTransitionEvent constructor.
 633         * bindings/js/JSEventConstructors.cpp: Added #includes for WebKitTransitionEvent.
 634         * dom/WebKitTransitionEvent.cpp:
 635         (WebCore::WebKitTransitionEventInit::WebKitTransitionEventInit):
 636         (WebCore::WebKitTransitionEvent::WebKitTransitionEvent):
 637         (WebCore::WebKitTransitionEvent::initWebKitTransitionEvent):
 638         * dom/WebKitTransitionEvent.h: Added a definition for WebKitTransitionEventInit.
 639         (WebCore::WebKitTransitionEvent::create):
 640         (WebCore::WebKitTransitionEvent::isWebKitTransitionEvent):
 641         * dom/WebKitTransitionEvent.idl: Makes WebKitTransitionEvent constructible.
 642
 643 2011-10-11  Sameer Patil  <mkrp87@motorola.com>
 644
 645         :checked pseudo selector not matching selected option
 646         https://bugs.webkit.org/show_bug.cgi?id=63192
 647
 648         Reviewed by Kent Tamura.
 649
 650         Test: fast/css/checked-pseudo-selector.html
 651
 652         Option element selected state need to be checked in checkOneSelector,
 653         so that it can be considered as checked on querySelectorAll(':checked').
 654
 655         * css/SelectorChecker.cpp:
 656         (WebCore::SelectorChecker::checkOneSelector):
 657
 658 2011-10-11  Ryuan Choi  <ryuan.choi@samsung.com>
 659
 660         StorageAreaSync::sync needs a transaction for better performance.
 661         https://bugs.webkit.org/show_bug.cgi?id=57694
 662
 663         Reviewed by Darin Adler.
 664
 665         For now, StorageAreaSync::sync execute SQLite operations for all items outside
 666         a transaction.
 667         However, SQLite operations outside a transaction are all atomic and thus
 668         writes will block on I/O, which makes the process slow during heavy I/O.
 669         This wrapped them with BEGIN TRANSACTION and END TRANSACTION for the better
 670         performance.
 671
 672         No new tests required.
 673         No functional changes if transaction doesn't fail.
 674         And also, it is difficult to test the case of transaction fails.
 675
 676         * storage/StorageAreaSync.cpp:
 677         (WebCore::StorageAreaSync::sync):
 678
 679 2011-10-11  Ojan Vafai  <ojan@chromium.org>
 680
 681         margin-right is ignored with vertical writing mode
 682         https://bugs.webkit.org/show_bug.cgi?id=69686
 683
 684         Reviewed by Darin Adler.
 685
 686         We need to use the parent's writing mode when grabbing
 687         the margin start/end for the purposes of computing the parent's
 688         preferred widths.
 689
 690         Test: fast/writing-mode/margins.html
 691
 692         * rendering/RenderBlock.cpp:
 693         (WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
 694         * rendering/RenderBlock.h:
 695
 696 2011-10-11  Sheriff Bot  <webkit.review.bot@gmail.com>
 697
 698         Unreviewed, rolling out r97202, r97207, and r97215.
 699         http://trac.webkit.org/changeset/97202
 700         http://trac.webkit.org/changeset/97207
 701         http://trac.webkit.org/changeset/97215
 702         https://bugs.webkit.org/show_bug.cgi?id=69894
 703
 704         Broke builds (Requested by rniwa on #webkit).
 705
 706         * platform/PopupMenuClient.h:
 707         * rendering/RenderMenuList.cpp:
 708         (WebCore::RenderMenuList::showPopup):
 709         * rendering/RenderMenuList.h:
 710         * rendering/RenderObject.h:
 711         * rendering/RenderTextControlSingleLine.cpp:
 712         (WebCore::RenderTextControlSingleLine::showPopup):
 713         * rendering/RenderTextControlSingleLine.h:
 714         * testing/Internals.cpp:
 715         * testing/Internals.h:
 716         * testing/Internals.idl:
 717
 718 2011-10-11  Martin Robinson  <mrobinson@igalia.com>
 719
 720         [Soup] ResourceHandleSoup does not handle encodedBlobData
 721         https://bugs.webkit.org/show_bug.cgi?id=52092
 722
 723         Reviewed by Gustavo Noronha Silva.
 724
 725         Add support for sending encoded blob data during requests.
 726
 727         * platform/network/soup/ResourceHandleSoup.cpp:
 728         (WebCore::addFileToSoupMessageBody): Added this helper.
 729         (WebCore::blobIsOutOfDate): Ditto.
 730         (WebCore::addEncodedBlobItemToSoupMessageBody): Ditto.
 731         (WebCore::addEncodedBlobToSoupMessageBody): Ditto.
 732         (WebCore::addFormElementsToSoupMessage): No longer flatten form data, as we
 733         cannot do this in the case where the form data contains blobs. Now handle
 734         the blob case.
 735         (WebCore::loadResourceSynchronously): Add blob support for synchronous loading.
 736
 737 2011-10-11  Chris Rogers  <crogers@google.com>
 738
 739         Heap buffer overflow in Webaudio FFTFrame::doFFT
 740         https://bugs.webkit.org/show_bug.cgi?id=69447
 741
 742         Reviewed by Kenneth Russell.
 743
 744         No new tests. This only changes internal implementation details.
 745
 746         * platform/audio/HRTFKernel.cpp:
 747         (WebCore::extractAverageGroupDelay):
 748         * platform/audio/HRTFPanner.cpp:
 749         (WebCore::HRTFPanner::fftSizeForSampleRate):
 750
 751 2011-10-11  Ryosuke Niwa  <rniwa@webkit.org>
 752
 753         Second Qt minimum release build fix attempt after r97163.
 754
 755         * platform/graphics/texmap/TextureMapperNode.cpp:
 756         (WebCore::TextureMapperNode::syncCompositingStateSelf):
 757
 758 2011-10-11  Ryosuke Niwa  <rniwa@webkit.org>
 759
 760         Qt minimum release build fix attempt after r97163.
 761
 762         * platform/graphics/texmap/TextureMapperNode.cpp:
 763         (WebCore::TextureMapperNode::syncCompositingStateSelf):
 764
 765 2011-10-11  Oliver Hunt  <oliver@apple.com>
 766
 767         Clang build broken
 768         https://bugs.webkit.org/show_bug.cgi?id=69891
 769
 770         Reviewed by Darin Adler.
 771
 772         Rename CachedResourceClient::type to CachedResourceClient::resourceClientType
 773         to avoid conflict in CSSImportRule.
 774
 775         * loader/cache/CachedCSSStyleSheet.cpp:
 776         (WebCore::CachedCSSStyleSheet::didAddClient):
 777         * loader/cache/CachedFont.cpp:
 778         (WebCore::CachedFont::didAddClient):
 779         * loader/cache/CachedFont.h:
 780         (WebCore::CachedFontClient::resourceClientType):
 781         * loader/cache/CachedImage.cpp:
 782         (WebCore::CachedImage::didAddClient):
 783         * loader/cache/CachedImage.h:
 784         (WebCore::CachedImageClient::resourceClientType):
 785         * loader/cache/CachedResourceClient.h:
 786         (WebCore::CachedResourceClient::resourceClientType):
 787         * loader/cache/CachedResourceClientWalker.h:
 788         (WebCore::CachedResourceClientWalker::next):
 789         * loader/cache/CachedStyleSheetClient.h:
 790         (WebCore::CachedStyleSheetClient::resourceClientType):
 791         * loader/cache/CachedXSLStyleSheet.cpp:
 792         (WebCore::CachedXSLStyleSheet::didAddClient):
 793
 794 2011-10-11  Ryosuke Niwa  <rniwa@webkit.org>
 795
 796         Dir attribute is converted into direction property when merging paragraphs
 797         https://bugs.webkit.org/show_bug.cgi?id=69680
 798
 799         Reviewed by Enrica Casucci.
 800
 801         Don't include direction and unicode-bidi properties in the wrapping style.
 802
 803         Tests: editing/deleting/merge-paragraph-into-h1-with-dir-2.html
 804                editing/deleting/merge-paragraph-into-h1-with-dir.html
 805
 806         * editing/EditingStyle.cpp:
 807         (WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement): Skip unicode-bidi and direction properties.
 808         (WebCore::EditingStyle::wrappingStyleForSerialization): Extracted from StyledMarkupAccumulator::serializeNodes.
 809         * editing/EditingStyle.h:
 810         * editing/markup.cpp:
 811         (WebCore::StyledMarkupAccumulator::serializeNodes): Calls wrappingStyleForSerialization.
 812
 813 2011-10-11  Nico Weber  <thakis@chromium.org>
 814
 815         [chromium] Let rule_binding use os.execvp() instead of subprocess.call() to spawn fewer processes.
 816         https://bugs.webkit.org/show_bug.cgi?id=69589
 817
 818         Reviewed by Dirk Pranke.
 819
 820         When building with `make -j40`, all the binding rules are built en bloc. Since this script currently
 821         uses subprocess.call(), that actually spawns 80 processes at once. OS X has a max process limit of
 822         255 by default, so the build used to fail with
 823         "open2: fork failed: Resource temporarily unavailable at ../bindings/scripts/preprocessor.pm line 60"
 824         As a fix, use execvp() instead, which replaces the current process instead of spawning a new one.
 825
 826         * WebCore.gyp/scripts/rule_binding.py:
 827
 828 2011-10-11  Fady Samuel  <fsamuel@chromium.org>
 829
 830         Towards making PopupMenuClient more testable
 831         https://bugs.webkit.org/show_bug.cgi?id=69631
 832
 833         Reviewed by Simon Fraser.
 834
 835         Added some functions to window.internals to allow testing of parts of PopupMenuClient.
 836
 837         Test: fast/dom/popup-menu-client-test.html
 838
 839         * platform/PopupMenuClient.h:
 840         * rendering/RenderMenuList.cpp:
 841         (WebCore::RenderMenuList::showPopup):
 842         (WebCore::RenderMenuList::boundingBoxRect):
 843         * rendering/RenderMenuList.h:
 844         (WebCore::RenderMenuList::RenderMenuList::isPopupMenuClient):
 845         * rendering/RenderObject.h:
 846         (WebCore::RenderObject::isPopupMenuClient):
 847         * rendering/RenderTextControlSingleLine.cpp:
 848         (WebCore::RenderTextControlSingleLine::showPopup):
 849         (WebCore::RenderTextControlSingleLine::boundingBoxRect):
 850         * rendering/RenderTextControlSingleLine.h:
 851         (WebCore::RenderTextControlSingleLine::isPopupMenuClient):
 852         * testing/Internals.cpp:
 853         (WebCore::Internals::toPopupMenuClient):
 854         (WebCore::Internals::popupClientPaddingLeft):
 855         (WebCore::Internals::popupClientPaddingRight):
 856         (WebCore::Internals::popupClientBoundingBoxRect):
 857         * testing/Internals.h:
 858         * testing/Internals.idl:
 859
 860 2011-10-11  Nate Chapin  <japhet@chromium.org>
 861
 862         Make CachedResourceClientWalker templates, and
 863         have it check and filter out bad casts when iterating
 864         (currently we rely on CachedResourceClients being careful
 865         to inherit from the right subclass for the type of resource
 866         they want to load).
 867         https://bugs.webkit.org/show_bug.cgi?id=69877
 868
 869         Reviewed by Adam Barth.
 870
 871         No new tests, no functionality change.
 872
 873         * CMakeLists.txt:
 874         * GNUmakefile.list.am:
 875         * WebCore.gypi:
 876         * WebCore.pro:
 877         * WebCore.vcproj/WebCore.vcproj:
 878         * WebCore.xcodeproj/project.pbxproj:
 879         * loader/cache/CachedCSSStyleSheet.cpp:
 880         * loader/cache/CachedFont.cpp:
 881         * loader/cache/CachedFont.h:
 882         * loader/cache/CachedImage.cpp:
 883         * loader/cache/CachedImage.h:
 884         * loader/cache/CachedResource.cpp:
 885         * loader/cache/CachedResourceClient.h:
 886         * loader/cache/CachedResourceClientWalker.cpp: Removed.
 887         * loader/cache/CachedResourceClientWalker.h:
 888         * loader/cache/CachedStyleSheetClient.h:
 889         * loader/cache/CachedXSLStyleSheet.cpp:
 890
 891 2011-10-11  W. James MacLean  <wjmaclean@chromium.org>
 892
 893         [chromium] Fix compilation guards in ScrollAnimatorNone (GESTURE_EVENTS).
 894         https://bugs.webkit.org/show_bug.cgi?id=69853
 895
 896         Reviewed by Kenneth Russell.
 897
 898         Adding missing guards ENABLE(GESTURE_EVENTS) in ScrollAnimatorNone. So
 899         far this hasn't been a problem since GESTURE_EVENTS are usually turned on
 900         whenever SMOOTH_SCROLLING is, but it could be a problem if this changes.
 901
 902         No new tests (compilation without errors is the test).
 903
 904         * platform/ScrollAnimatorNone.cpp:
 905         * platform/ScrollAnimatorNone.h:
 906
 907 2011-10-11  Kenneth Russell  <kbr@google.com>
 908
 909         [chromium] Check for lost context at beginning of compositor's execution
 910         https://bugs.webkit.org/show_bug.cgi?id=69776
 911
 912         Reviewed by James Robinson.
 913
 914         Test: platform/chromium/compositing/webgl-loses-compositor-context.html
 915
 916         * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
 917         (WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
 918
 919 2011-10-11  W. James MacLean  <wjmaclean@chromium.org>
 920
 921         Loss of precision when converting from double to int and double to float in FrameView::zoomAnimatorTransformChanged()
 922         https://bugs.webkit.org/show_bug.cgi?id=69739
 923
 924         Reviewed by Simon Fraser.
 925
 926         Change 'double' parameters in FrameView:: & ScrollableArea::zoomAnimatorTransformChanged()
 927         to 'float' to avoid loss of precision warnings when invoking setPageScalefactor.
 928
 929         Test coverage provided by existing zoom-animator tests.
 930
 931         * page/FrameView.cpp:
 932         (WebCore::FrameView::zoomAnimatorTransformChanged):
 933         * page/FrameView.h:
 934         * platform/ScrollableArea.cpp:
 935         (WebCore::ScrollableArea::zoomAnimatorTransformChanged):
 936         * platform/ScrollableArea.h:
 937
 938 2011-10-11  No'am Rosenthal  <noam.rosenthal@nokia.com>
 939
 940         Unreviewed build fix, unbreaking the Qt minimal bot.
 941         Some #ifdef ENABLED(TILED_BACKING_STORE) clauses were missing.
 942
 943         * platform/graphics/texmap/TextureMapperNode.cpp:
 944         (WebCore::TextureMapperNode::computeTiles):
 945         (WebCore::TextureMapperNode::renderContent):
 946         (WebCore::TextureMapperNode::paintSelf):
 947
 948 2011-10-11  Abhishek Arya  <inferno@chromium.org>
 949
 950         Generalize r95461 change to include table-cell and
 951         allow splitting between :before, :after content.
 952         https://bugs.webkit.org/show_bug.cgi?id=69854
 953
 954         Reviewed by Eric Seidel.
 955
 956         Test: fast/table/table-row-before-after-content-around-table-cell.html
 957
 958         * rendering/RenderObject.cpp:
 959         (WebCore::RenderObject::addChild):
 960
 961 2011-10-11  Dominic Mazzoni  <dmazzoni@google.com>
 962
 963         AccessibilityMenuList should fire change notification when popup is not open.
 964         https://bugs.webkit.org/show_bug.cgi?id=69440
 965
 966         Reviewed by Chris Fleizach.
 967
 968         Test: accessibility/menu-list-sends-change-notification.html
 969
 970         * accessibility/AccessibilityMenuList.cpp:
 971         (WebCore::AccessibilityMenuList::didUpdateActiveOption):
 972
 973 2011-10-11  Joshua Bell  <jsbell@chromium.org>
 974
 975         IndexedDB: implement IDBFactory.cmp method
 976         https://bugs.webkit.org/show_bug.cgi?id=62293
 977
 978         Reviewed by Tony Chang.
 979
 980         * storage/IDBFactory.cpp:
 981         (WebCore::IDBFactory::cmp):
 982         * storage/IDBFactory.h:
 983         * storage/IDBFactory.idl:
 984         * storage/IDBKey.cpp:
 985         (WebCore::IDBKey::compare):
 986         (WebCore::IDBKey::isLessThan):
 987         (WebCore::IDBKey::isEqual):
 988         * storage/IDBKey.h:
 989
 990 2011-10-11  No'am Rosenthal  <noam.rosenthal@nokia.com>
 991
 992         [Texmap] TextureMapperGL leaves GL in a modified state.
 993         https://bugs.webkit.org/show_bug.cgi?id=68983
 994
 995         Reviewed by Andreas Kling.
 996
 997         Disable the vertexAttribArray after clipping.
 998
 999         No new functionality so no new tests.
1000
1001         * platform/graphics/opengl/TextureMapperGL.cpp:
1002         (WebCore::TextureMapperGL::beginClip):
1003
1004 2011-10-11  No'am Rosenthal  <noam.rosenthal@nokia.com>
1005
1006         [Qt][WK2] Synchronize tiling with accelerated compositing
1007         https://bugs.webkit.org/show_bug.cgi?id=69151
1008
1009         Reviewed by Kenneth Rohde Christiansen.
1010
1011         Enable "externally managed" tiles in TextureMapperNodes.
1012         Currently, TextureMapperNodes manage tiles themselves, the tiles being there only to
1013         overcome the 2k texture size limitation. For WebKit2, we want those tiles to be managed
1014         externally, namely through the web process via the remote tile backend for
1015         TiledBackingStore.
1016
1017         This patch adds a store for those externally managed tiles, and adds the necessary code to
1018         paint them instead of the owned tiles when appropriate.
1019
1020         In addition, in order to support externally managed remote tiles, we have to calculate per-
1021         layer visible rects and pass them to the web process. The new collectVisibleContentRects
1022         does this - and is directly tied to the externally-managed tile approach.
1023
1024         Code is disabled for now, but covered by existing compositing tests.
1025
1026         * platform/graphics/texmap/TextureMapperNode.cpp:
1027         (WebCore::TextureMapperNode::computeTiles):
1028         (WebCore::clampRect):
1029         (WebCore::TextureMapperNode::collectVisibleContentRects):
1030         (WebCore::TextureMapperNode::renderContent):
1031         (WebCore::TextureMapperNode::targetRectForTileRect):
1032         (WebCore::TextureMapperNode::paintSelf):
1033         (WebCore::TextureMapperNode::createContentsTile):
1034         (WebCore::TextureMapperNode::removeContentsTile):
1035         (WebCore::TextureMapperNode::setTileBackBufferTextureForDirectlyCompositedImage):
1036         (WebCore::TextureMapperNode::clearAllDirectlyCompositedImageTiles):
1037         (WebCore::TextureMapperNode::setContentsTileBackBuffer):
1038         (WebCore::TextureMapperNode::swapContentsBuffers):
1039         (WebCore::TextureMapperNode::syncCompositingStateSelf):
1040         (WebCore::TextureMapperNode::syncCompositingState):
1041         * platform/graphics/texmap/TextureMapperNode.h:
1042         (WebCore::TextureMapperNode::size):
1043         (WebCore::TextureMapperNode::setTileOwnership):
1044         (WebCore::TextureMapperNode::setID):
1045         (WebCore::TextureMapperNode::id):
1046         (WebCore::TextureMapperNode::texture):
1047         (WebCore::TextureMapperNode::ExternallyManagedTile::ExternallyManagedTile):
1048         (WebCore::TextureMapperNode::State::State):
1049
1050 2011-10-11  Claudio Saavedra  <csaavedra@igalia.com>
1051
1052         [GTK] GtkAuthenticationDialog: use GtkGrid instead of GtkTable
1053         https://bugs.webkit.org/show_bug.cgi?id=69749
1054
1055         Reviewed by Martin Robinson.
1056
1057         * platform/gtk/GtkAuthenticationDialog.cpp:
1058         (WebCore::addEntryToGrid): Migrate to GtkGrid when using GTK+ 3
1059         (WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog):
1060         Ditto.
1061
1062 2011-10-11  Alexey Proskuryakov  <ap@apple.com>
1063
1064         Build fix.
1065
1066         * WebCore.exp.in: Export GraphicsContext::clearShadow().
1067
1068 2011-10-10  Adam Klein  <adamk@chromium.org>
1069
1070         [MutationObservers] Add stub implementation of WebKitMutationObserver
1071         https://bugs.webkit.org/show_bug.cgi?id=68949
1072
1073         Reviewed by Ryosuke Niwa, Oliver Hunt, and Dimitri Glazkov.
1074
1075         See https://bugs.webkit.org/show_bug.cgi?id=68729 for the metabug.
1076
1077         This patch adds a stub WebKitMutationObserver and its supporting classes
1078         MutationCallback and MutationObserverOptions.
1079         No implementation is provided for the all-important observe() and
1080         disconnect() methods.
1081
1082         Note that WebKitMutationObserver is vendor-prefixed since it has a
1083         constructor exposed on DOMWindow.  None of the rest of the API needs
1084         prefixing, as it's only available via a call through a MutationObserver
1085         callback (created by instantiating WebKitMutationObserver).
1086
1087         Given the number of files required to get just the stub up and running,
1088         it seems reasonable to leave the actual implementation for the next
1089         patch (or more likely several patches).  I've left FIXMEs in all the places
1090         that'll need augmentation.
1091
1092         Tests: fast/mutation/mutation-observer-constructor.html
1093                fast/mutation/observe-exceptions.html
1094
1095         * CMakeLists.txt:
1096         * DerivedSources.cpp:
1097         * DerivedSources.make:
1098         * GNUmakefile.list.am:
1099         * UseJSC.cmake:
1100         * WebCore.gypi:
1101         * WebCore.pro:
1102         * WebCore.vcproj/WebCore.vcproj:
1103         * WebCore.xcodeproj/project.pbxproj:
1104         * bindings/js/JSDictionary.h:
1105         (WebCore::JSDictionary::tryGetProperty):
1106         * bindings/js/JSMutationCallbackCustom.cpp: Added.
1107         (WebCore::JSMutationCallback::handleEvent):
1108         * bindings/js/JSWebKitMutationObserverCustom.cpp: Added.
1109         (WebCore::JSWebKitMutationObserverConstructor::constructJSWebKitMutationObserver):
1110         (WebCore::JSWebKitMutationObserver::observe):
1111         * bindings/v8/custom/V8MutationCallbackCustom.cpp: Added.
1112         (WebCore::V8MutationCallback::handleEvent):
1113         * bindings/v8/custom/V8WebKitMutationObserverCustom.cpp: Added.
1114         (WebCore::V8WebKitMutationObserver::constructorCallback):
1115         (WebCore::V8WebKitMutationObserver::observeCallback):
1116         * dom/MutationCallback.h: Added.
1117         (WebCore::MutationCallback::~MutationCallback):
1118         * dom/MutationCallback.idl: Added.
1119         * dom/MutationObserverOptions.h: Added.
1120         (WebCore::MutationObserverOptions::create):
1121         (WebCore::MutationObserverOptions::childList):
1122         (WebCore::MutationObserverOptions::setChildList):
1123         (WebCore::MutationObserverOptions::attributes):
1124         (WebCore::MutationObserverOptions::setAttributes):
1125         (WebCore::MutationObserverOptions::characterData):
1126         (WebCore::MutationObserverOptions::setCharacterData):
1127         (WebCore::MutationObserverOptions::subtree):
1128         (WebCore::MutationObserverOptions::setSubtree):
1129         (WebCore::MutationObserverOptions::attributeOldValue):
1130         (WebCore::MutationObserverOptions::setAttributeOldValue):
1131         (WebCore::MutationObserverOptions::characterDataOldValue):
1132         (WebCore::MutationObserverOptions::setCharacterDataOldValue):
1133         (WebCore::MutationObserverOptions::MutationObserverOptions):
1134         * dom/WebKitMutationObserver.cpp: Added.
1135         (WebCore::WebKitMutationObserver::create):
1136         (WebCore::WebKitMutationObserver::WebKitMutationObserver):
1137         (WebCore::WebKitMutationObserver::~WebKitMutationObserver):
1138         (WebCore::WebKitMutationObserver::observe):
1139         (WebCore::WebKitMutationObserver::disconnect):
1140         * dom/WebKitMutationObserver.h: Added.
1141         * dom/WebKitMutationObserver.idl: Added.
1142         * page/DOMWindow.idl:
1143
1144 2011-10-11  Arun Patole  <BMF834@motorola.com>
1145
1146         Need more efficient ways to set inline CSS styles
1147         https://bugs.webkit.org/show_bug.cgi?id=58157
1148
1149         Reviewed by Dimitri Glazkov.
1150
1151         No new tests added as this is just a code optimization.
1152
1153         Code optimization:
1154           -Used CSSPropertyNames, CSSValues and CSSPrimitiveValues instead of Strings.
1155           -Removed displayString(), webkitTransitionString(), opacityString() functions as they will no longer be needed after this change.
1156           -Moved makeOpaque and makeTransparent functionality to MediaControlPanelElement from MediaControlRootElement.
1157
1158         * html/HTMLMediaElement.cpp:
1159         (WebCore::HTMLMediaElement::mediaPlayerRateChanged):
1160         * html/shadow/MediaControlElements.cpp:
1161         (WebCore::MediaControlElement::show):
1162         (WebCore::MediaControlElement::hide):
1163         (WebCore::MediaControlPanelElement::MediaControlPanelElement):
1164         (WebCore::MediaControlPanelElement::makeOpaque):
1165         (WebCore::MediaControlPanelElement::makeTransparent):
1166         (WebCore::MediaControlInputElement::show):
1167         (WebCore::MediaControlInputElement::hide):
1168         * html/shadow/MediaControlElements.h:
1169         * html/shadow/MediaControlRootElement.cpp:
1170         (WebCore::MediaControlRootElement::MediaControlRootElement):
1171         (WebCore::MediaControlRootElement::makeOpaque):
1172         (WebCore::MediaControlRootElement::makeTransparent):
1173         * html/shadow/MediaControlRootElement.h:
1174         * html/shadow/MediaControlRootElementChromium.cpp:
1175         (WebCore::MediaControlRootElementChromium::makeOpaque):
1176         (WebCore::MediaControlRootElementChromium::makeTransparent):
1177
1178 2011-10-11  Pavel Feldman  <pfeldman@google.com>
1179
1180         Web Inspector: make Extensions component compile.
1181         https://bugs.webkit.org/show_bug.cgi?id=69833
1182
1183         Reviewed by Yury Semikhatsky.
1184
1185         * inspector/compile-front-end.sh:
1186         * inspector/front-end/BinarySearch.js:
1187         * inspector/front-end/ConsoleModel.js:
1188         * inspector/front-end/ExtensionAPI.js:
1189         (injectedExtensionAPI.Network.prototype.addRequestHeaders):
1190         (injectedExtensionAPI.AuditResultImpl.prototype.addResult):
1191         (injectedExtensionAPI.AuditResultNode.prototype.addChild):
1192         * inspector/front-end/ExtensionAuditCategory.js:
1193         * inspector/front-end/ExtensionPanel.js:
1194         (WebInspector.ExtensionSidebarPane.prototype.setExpression):
1195         * inspector/front-end/ExtensionRegistryStub.js:
1196         * inspector/front-end/ExtensionServer.js:
1197         (WebInspector.ExtensionServer.prototype._postNotification):
1198         (WebInspector.ExtensionServer.prototype._onAddRequestHeaders):
1199         (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
1200         (WebInspector.ExtensionServer.prototype._registerExtension):
1201         (WebInspector.ExtensionStatus):
1202         * inspector/front-end/NetworkLog.js:
1203         (WebInspector.NetworkLog.prototype._onResourceStarted):
1204         * inspector/front-end/Object.js:
1205         (WebInspector.Object.prototype.dispatchEventToListeners):
1206         * inspector/front-end/externs.js:
1207         (console.warn):
1208         (console.assert):
1209         (console.error):
1210         ():
1211         (AuditResult):
1212         (EventSink):
1213         (ExtensionSidebarPane):
1214         (Panel):
1215         (PanelWithSidebar):
1216         (Request):
1217         (Resource):
1218         (Timeline):
1219
1220 2011-10-05  Pavel Podivilov  <podivilov@chromium.org>
1221
1222         Web Inspector: implement CompilerSourceMappingProvider.
1223         https://bugs.webkit.org/show_bug.cgi?id=69423
1224
1225         Reviewed by Pavel Feldman.
1226
1227         CompilerSourceMappingProvider implements a cross-domain communication channel for loading source mappings and source files.
1228         Front-end page can't send XHRs to source mapping server directly due to SOP restrictions. Instead, we inject an invisible
1229         iframe that is loaded from source mapping server and use window.postMessage to communicate with it. iframe has a different
1230         origin and thus doesn't have access to front-end window.
1231
1232         Test: http/tests/inspector/compiler-source-mapping-provider.html
1233
1234         * inspector/front-end/CompilerSourceMappingProvider.js:
1235         (WebInspector.CompilerSourceMappingProvider):
1236         (WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping.frameLoaded.didLoadData):
1237         (WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping.frameLoaded):
1238         (WebInspector.CompilerSourceMappingProvider.prototype.loadSourceMapping):
1239         (WebInspector.CompilerSourceMappingProvider.prototype.loadSourceCode):
1240         (WebInspector.CompilerSourceMappingProvider.prototype._sendRequest):
1241         (WebInspector.CompilerSourceMappingProvider.prototype._onMessage):
1242         (WebInspector.CompilerSourceMappingProvider.prototype._cancelRequest):
1243         * inspector/front-end/inspector.js:
1244         (WebInspector.installSourceMappingForTest):
1245
1246 2011-10-11  Mike Reed  <reed@google.com>
1247
1248         re-add support for GDI text behind a compile flag
1249         https://bugs.webkit.org/show_bug.cgi?id=69530
1250
1251         Reviewed by James Robinson.
1252
1253         Reverts back to using GDI for text (when possible)
1254         but keeps skia-text version behind a compile-flag. If/when we can
1255         resolve the outstanding soft-clip and intl-performance bugs with the
1256         skia version, we may change the compile-flag to reenable skia.
1257
1258         Previous change http://trac.webkit.org/changeset/94589 removed the GDI code.
1259
1260         * platform/graphics/chromium/FontChromiumWin.cpp:
1261         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
1262         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
1263         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
1264         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
1265         (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
1266         (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
1267         (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::estimateTextBounds):
1268         (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
1269         (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
1270         (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
1271         (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
1272         (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::estimateTextBounds):
1273         (WebCore::drawGlyphsWin):
1274         (WebCore::Font::drawGlyphs):
1275         (WebCore::Font::drawComplexText):
1276         * platform/graphics/chromium/UniscribeHelper.cpp:
1277         (WebCore::UniscribeHelper::draw):
1278         * platform/graphics/skia/PlatformContextSkia.cpp:
1279         (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
1280         * platform/graphics/skia/PlatformContextSkia.h:
1281         * platform/graphics/skia/SkiaFontWin.cpp:
1282         (WebCore::windowsCanHandleDrawTextShadow):
1283         (WebCore::windowsCanHandleTextDrawing):
1284         (WebCore::windowsCanHandleTextDrawingWithoutShadow):
1285         * platform/graphics/skia/SkiaFontWin.h:
1286
1287 2011-10-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1288
1289         [Qt] Remove all references to QTDIR_build and standalone_package
1290
1291         Qt is now modularized, which means we no longer import WebKit into
1292         the Qt source tree. Instead we use git submodules, and building
1293         QtWebKit as "part of Qt" is really building QtWebKit as from trunk.
1294
1295         To decrease the number of buildsystem configurations we also remove
1296         the standalone_package code-path used when we were providing tarballs
1297         with the derived sources pre-generated.
1298
1299         Reviewed by Simon Hausmann.
1300
1301         * CodeGenerators.pri:
1302         * WebCore.pri:
1303         * features.pri:
1304
1305 2011-10-10  Andreas Kling  <kling@webkit.org>
1306
1307         Shrink WebCore::Node on 64-bit.
1308         https://bugs.webkit.org/show_bug.cgi?id=69768
1309
1310         Reviewed by Antti Koivisto.
1311
1312         Rearrange TreeShared and Node members so that the node flags fall
1313         into the padding at the end of TreeShared on 64-bit, reducing the
1314         size of Node (and all subclasses) by 8 bytes.
1315
1316         * dom/Document.h:
1317         (WebCore::Node::Node):
1318         * dom/Node.h:
1319         * platform/TreeShared.h:
1320         (WebCore::TreeShared::TreeShared):
1321
1322 2011-10-11  Kent Tamura  <tkent@chromium.org>
1323
1324         Move m_listItems and m_recalcListItems from SelectElementData to HTMLSelectElement
1325         https://bugs.webkit.org/show_bug.cgi?id=69812
1326
1327         Reviewed by Ryosuke Niwa.
1328
1329         Move SelectElementData::m_recalcListItems,
1330         SelectElementData::m_listItems, and related functions of
1331         SelectElementData class to HTMLSelectElement.
1332
1333         Non-const listItems() was removed because it is used only in
1334         recalcListItemsInternal() and it can access m_listItems diretly.
1335
1336         Static recalcListItems() is changed to non-static, and renamed to
1337         recalcListItemsInternal() in order to avoid confusion with the
1338         existing recalcListItems().
1339
1340         No new tests, just a refactoring.
1341
1342         * dom/SelectElement.cpp:
1343         Move checkListItems() and listItems() to HTMLSelectElement.
1344         (WebCore::SelectElementData::SelectElementData):
1345         Remove Initialization of m_recalcListItems.
1346         * dom/SelectElement.h:
1347         Move m_recalcListItems, m_listItems, and related functions to HTMLSelectElement.
1348         * html/HTMLSelectElement.cpp:
1349         (WebCore::HTMLSelectElement::HTMLSelectElement):
1350         Initializes m_recalcListItems.
1351         (WebCore::HTMLSelectElement::recalcListItems):
1352         Rename the static recalcListItems() to recalcListItemsInternal().
1353         (WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
1354         Use m_recalcListItems directly.
1355         (WebCore::HTMLSelectElement::nextSelectableListIndex):
1356         Update a listItems() callsite.
1357         (WebCore::HTMLSelectElement::previousSelectableListIndex): ditto.
1358         (WebCore::HTMLSelectElement::firstSelectableListIndex): ditto.
1359         (WebCore::HTMLSelectElement::lastSelectableListIndex): ditto.
1360         (WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): ditto.
1361         (WebCore::HTMLSelectElement::saveLastSelection): ditto.
1362         (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto.
1363         (WebCore::HTMLSelectElement::updateListBoxSelection): ditto.
1364         (WebCore::HTMLSelectElement::listBoxOnChange): ditto.
1365         (WebCore::HTMLSelectElement::checkListItems):
1366         Moved from SelectElementData.
1367         (WebCore::HTMLSelectElement::listItems): ditto.
1368         (WebCore::HTMLSelectElement::setRecalcListItems):
1369         Use m_recalcListItems directly.
1370         (WebCore::HTMLSelectElement::recalcListItemsInternal):
1371         - Make this non-static.
1372         - Renamed from recalcListItems() to avoid confilct with another recalcListItems().
1373         - Use m_recalcListItems and m_listItems directly.
1374         (WebCore::HTMLSelectElement::selectedIndex):
1375         Update a listItems() callsite.
1376         (WebCore::HTMLSelectElement::setSelectedIndexInternal): ditto.
1377         (WebCore::HTMLSelectElement::optionToListIndex): ditto.
1378         (WebCore::HTMLSelectElement::listToOptionIndex): ditto.
1379         (WebCore::HTMLSelectElement::deselectItemsWithoutValidation): ditto.
1380         (WebCore::HTMLSelectElement::saveFormControlState):
1381         Update callsites of listItems() and recalcListItems().
1382         (WebCore::HTMLSelectElement::restoreFormControlState):
1383         Update a listItems() callsite.
1384         (WebCore::HTMLSelectElement::appendFormData): ditto.
1385         (WebCore::HTMLSelectElement::reset): ditto.
1386         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
1387         (WebCore::HTMLSelectElement::updateSelectedState): ditto.
1388         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
1389         (WebCore::HTMLSelectElement::lastSelectedListIndex): ditto.
1390         (WebCore::HTMLSelectElement::typeAheadFind): ditto.
1391         (WebCore::HTMLSelectElement::insertedIntoTree):
1392         Update a recalcListItems() callsite.
1393         (WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
1394         Update a listItems() callsite.
1395         (WebCore::HTMLSelectElement::length): ditto.
1396         * html/HTMLSelectElement.h:
1397         Move m_recalcListItems, m_listItems, and related functions from SelectElementData.
1398         * html/HTMLSelectElementWin.cpp:
1399         (WebCore::HTMLSelectElement::platformHandleKeydownEvent):
1400         Update a listItems() callsite.
1401
1402 2011-10-11  Kenichi Ishibashi  <bashi@chromium.org>
1403
1404         [Chromium] Complex script code path breaks on Windows XP when a CFF font is used
1405         https://bugs.webkit.org/show_bug.cgi?id=69497
1406
1407         Reviewed by Kent Tamura.
1408
1409         Don't use CFF webfonts when ScriptShape() can't handle it.
1410         ScriptShape() indicates us the case by setting fNoGlyphIndex to TRUE.
1411         If it's TRUE, we don't use the font. This could happen with early
1412         version of Uniscribe on WinXP.
1413
1414         No new tests because the version of Uniscribe depends on environment.
1415         One can install newer version of Uniscribe on WinXP.
1416
1417         * platform/graphics/chromium/UniscribeHelper.cpp:
1418         (WebCore::canUseGlyphIndex): Added.
1419         (WebCore::UniscribeHelper::shape): Don't use the shape result when canUseGlyphIndex() returns false.
1420
1421 2011-10-11  John Bauman  <jbauman@chromium.org>
1422
1423         Fix crash with toDataURL to JPEG
1424         https://bugs.webkit.org/show_bug.cgi?id=69681
1425
1426         Reviewed by Kenneth Russell.
1427
1428         Move RefPtr declaration outside if to make sure image data still
1429         exists through CGImageToDataURL.
1430
1431         * platform/graphics/cg/ImageBufferCG.cpp:
1432         (WebCore::ImageBuffer::toDataURL):
1433
1434 2011-10-10  Adam Barth  <abarth@webkit.org>
1435
1436         Update test results.
1437
1438         * bindings/scripts/test/V8/V8TestInterface.h:
1439         (WebCore::V8TestInterface::existingWrapper):
1440         (WebCore::V8TestInterface::wrap):
1441         * bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
1442         (WebCore::V8TestMediaQueryListListener::existingWrapper):
1443         (WebCore::V8TestMediaQueryListListener::wrap):
1444         * bindings/scripts/test/V8/V8TestObj.cpp:
1445         (WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter):
1446         (WebCore::TestObjInternal::cachedAttribute1AttrGetter):
1447         (WebCore::TestObjInternal::cachedAttribute2AttrGetter):
1448         * bindings/scripts/test/V8/V8TestObj.h:
1449         (WebCore::V8TestObj::existingWrapper):
1450         (WebCore::V8TestObj::wrap):
1451         * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
1452         (WebCore::V8TestSerializedScriptValueInterface::existingWrapper):
1453         (WebCore::V8TestSerializedScriptValueInterface::wrap):
1454
1455 2011-10-10  Abhishek Arya  <inferno@chromium.org>
1456
1457         Style not updated on text fragment in :first-letter
1458         nested in :before table.
1459         https://bugs.webkit.org/show_bug.cgi?id=69540
1460
1461         Reviewed by Dan Bernstein.
1462
1463         Test: fast/css-generated-content/first-letter-in-nested-before-table.html
1464
1465         * rendering/RenderObjectChildList.cpp:
1466         (WebCore::RenderObjectChildList::updateBeforeAfterContent):
1467
1468 2011-10-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1469
1470         Unreviewed, rolling out r97121.
1471         http://trac.webkit.org/changeset/97121
1472         https://bugs.webkit.org/show_bug.cgi?id=69815
1473
1474         Many layout tests failed (Requested by tkent on #webkit).
1475
1476         * dom/SelectElement.cpp:
1477         (WebCore::SelectElementData::SelectElementData):
1478         (WebCore::SelectElementData::checkListItems):
1479         (WebCore::SelectElementData::listItems):
1480         * dom/SelectElement.h:
1481         (WebCore::SelectElementData::shouldRecalcListItems):
1482         (WebCore::SelectElementData::setShouldRecalcListItems):
1483         (WebCore::SelectElementData::rawListItems):
1484         * html/HTMLSelectElement.cpp:
1485         (WebCore::HTMLSelectElement::HTMLSelectElement):
1486         (WebCore::HTMLSelectElement::recalcListItems):
1487         (WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
1488         (WebCore::HTMLSelectElement::nextSelectableListIndex):
1489         (WebCore::HTMLSelectElement::previousSelectableListIndex):
1490         (WebCore::HTMLSelectElement::firstSelectableListIndex):
1491         (WebCore::HTMLSelectElement::lastSelectableListIndex):
1492         (WebCore::HTMLSelectElement::nextSelectableListIndexPageAway):
1493         (WebCore::HTMLSelectElement::saveLastSelection):
1494         (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
1495         (WebCore::HTMLSelectElement::updateListBoxSelection):
1496         (WebCore::HTMLSelectElement::listBoxOnChange):
1497         (WebCore::HTMLSelectElement::setRecalcListItems):
1498         (WebCore::HTMLSelectElement::selectedIndex):
1499         (WebCore::HTMLSelectElement::setSelectedIndexInternal):
1500         (WebCore::HTMLSelectElement::optionToListIndex):
1501         (WebCore::HTMLSelectElement::listToOptionIndex):
1502         (WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
1503         (WebCore::HTMLSelectElement::saveFormControlState):
1504         (WebCore::HTMLSelectElement::restoreFormControlState):
1505         (WebCore::HTMLSelectElement::appendFormData):
1506         (WebCore::HTMLSelectElement::reset):
1507         (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
1508         (WebCore::HTMLSelectElement::updateSelectedState):
1509         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
1510         (WebCore::HTMLSelectElement::lastSelectedListIndex):
1511         (WebCore::HTMLSelectElement::typeAheadFind):
1512         (WebCore::HTMLSelectElement::insertedIntoTree):
1513         (WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
1514         (WebCore::HTMLSelectElement::length):
1515         * html/HTMLSelectElement.h:
1516         (WebCore::HTMLSelectElement::listItems):
1517         * html/HTMLSelectElementWin.cpp:
1518         (WebCore::HTMLSelectElement::platformHandleKeydownEvent):
1519
1520 2011-10-10  Kent Tamura  <tkent@chromium.org>
1521
1522         Move m_listItems and m_recalcListItems from SelectElementData to HTMLSelectElement
1523         https://bugs.webkit.org/show_bug.cgi?id=69812
1524
1525         Reviewed by Ryosuke Niwa.
1526
1527         Move SelectElementData::m_recalcListItems,
1528         SelectElementData::m_listItems, and related functions of
1529         SelectElementData class to HTMLSelectElement.
1530
1531         Non-const listItems() was removed because it is used only in
1532         recalcListItemsInternal() and it can access m_listItems diretly.
1533
1534         Static recalcListItems() is changed to non-static, and renamed to
1535         recalcListItemsInternal() in order to avoid confusion with the
1536         existing recalcListItems().
1537
1538         No new tests, just a refactoring.
1539
1540         * dom/SelectElement.cpp:
1541         Move checkListItems() and listItems() to HTMLSelectElement.
1542         (WebCore::SelectElementData::SelectElementData):
1543         Remove Initialization of m_recalcListItems.
1544         * dom/SelectElement.h:
1545         Move m_recalcListItems, m_listItems, and related functions to HTMLSelectElement.
1546         * html/HTMLSelectElement.cpp:
1547         (WebCore::HTMLSelectElement::HTMLSelectElement):
1548         Initializes m_recalcListItems.
1549         (WebCore::HTMLSelectElement::recalcListItems):
1550         Rename the static recalcListItems() to recalcListItemsInternal().
1551         (WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
1552         Use m_recalcListItems directly.
1553         (WebCore::HTMLSelectElement::nextSelectableListIndex):
1554         Update a listItems() callsite.
1555         (WebCore::HTMLSelectElement::previousSelectableListIndex): ditto.
1556         (WebCore::HTMLSelectElement::firstSelectableListIndex): ditto.
1557         (WebCore::HTMLSelectElement::lastSelectableListIndex): ditto.
1558         (WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): ditto.
1559         (WebCore::HTMLSelectElement::saveLastSelection): ditto.
1560         (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto.
1561         (WebCore::HTMLSelectElement::updateListBoxSelection): ditto.
1562         (WebCore::HTMLSelectElement::listBoxOnChange): ditto.
1563         (WebCore::HTMLSelectElement::checkListItems):
1564         Moved from SelectElementData.
1565         (WebCore::HTMLSelectElement::listItems): ditto.
1566         (WebCore::HTMLSelectElement::setRecalcListItems):
1567         Use m_recalcListItems directly.
1568         (WebCore::HTMLSelectElement::recalcListItemsInternal):
1569         - Make this non-static.
1570         - Renamed from recalcListItems() to avoid confilct with another recalcListItems().
1571         - Use m_recalcListItems and m_listItems directly.
1572         (WebCore::HTMLSelectElement::selectedIndex):
1573         Update a listItems() callsite.
1574         (WebCore::HTMLSelectElement::setSelectedIndexInternal): ditto.
1575         (WebCore::HTMLSelectElement::optionToListIndex): ditto.
1576         (WebCore::HTMLSelectElement::listToOptionIndex): ditto.
1577         (WebCore::HTMLSelectElement::deselectItemsWithoutValidation): ditto.
1578         (WebCore::HTMLSelectElement::saveFormControlState):
1579         Update callsites of listItems() and recalcListItems().
1580         (WebCore::HTMLSelectElement::restoreFormControlState):
1581         Update a listItems() callsite.
1582         (WebCore::HTMLSelectElement::appendFormData): ditto.
1583         (WebCore::HTMLSelectElement::reset): ditto.
1584         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
1585         (WebCore::HTMLSelectElement::updateSelectedState): ditto.
1586         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
1587         (WebCore::HTMLSelectElement::lastSelectedListIndex): ditto.
1588         (WebCore::HTMLSelectElement::typeAheadFind): ditto.
1589         (WebCore::HTMLSelectElement::insertedIntoTree):
1590         Update a recalcListItems() callsite.
1591         (WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
1592         Update a listItems() callsite.
1593         (WebCore::HTMLSelectElement::length): ditto.
1594         * html/HTMLSelectElement.h:
1595         Move m_recalcListItems, m_listItems, and related functions from SelectElementData.
1596         * html/HTMLSelectElementWin.cpp:
1597         (WebCore::HTMLSelectElement::platformHandleKeydownEvent):
1598         Update a listItems() callsite.
1599
1600 2011-10-10  Dan Bernstein  <mitz@apple.com>
1601
1602         <rdar://problem/10246137> Duplicate ::after content when both ::before and ::after are styled as table parts
1603
1604         Reviewed by Sam Weinig.
1605
1606         Test: fast/css-generated-content/table-parts-before-and-after.html
1607
1608         * rendering/RenderObject.cpp:
1609         (WebCore::RenderObject::addChild): Prevented table part childern after a ::before table from being merged
1610         into it.
1611         * rendering/RenderTable.cpp:
1612         (WebCore::RenderTable::addChild): Prevented children after a ::before table section from being merged
1613         into it.
1614
1615 2011-10-10  Nate Chapin  <japhet@chromium.org>
1616
1617         Most of the functions in CachedResourceClient are specific
1618         to a single type of CachedResource. Move these callbacks into
1619         separate subclasses of CachedResourceClient, and leave only
1620         the common callback (notifyFinished) in the base class.
1621         https://bugs.webkit.org/show_bug.cgi?id=69790
1622
1623         Reviewed by Adam Barth.
1624
1625         No new tests, no functionality changed intended.
1626
1627         * css/CSSFontFaceSource.h:
1628         * css/CSSImageValue.h:
1629         * css/CSSImportRule.h:
1630         * dom/ProcessingInstruction.cpp:
1631         * dom/ProcessingInstruction.h:
1632         * html/HTMLLinkElement.h:
1633         * html/ImageDocument.h:
1634         * loader/ImageLoader.h:
1635         * loader/cache/CachedCSSStyleSheet.cpp:
1636         * loader/cache/CachedCSSStyleSheet.h:
1637         * loader/cache/CachedFont.cpp:
1638         * loader/cache/CachedFont.h:
1639         * loader/cache/CachedImage.cpp:
1640         * loader/cache/CachedImage.h:
1641         * loader/cache/CachedResourceClient.h:
1642         * loader/cache/CachedXSLStyleSheet.cpp:
1643         * loader/cache/CachedXSLStyleSheet.h:
1644         * platform/chromium/ClipboardChromium.h:
1645         * platform/gtk/ClipboardGtk.h:
1646         * platform/mac/ClipboardMac.h:
1647         * platform/qt/ClipboardQt.h:
1648         * platform/win/ClipboardWin.h:
1649         * rendering/RenderObject.cpp:
1650         * rendering/RenderObject.h:
1651         * svg/SVGFEImageElement.h:
1652         * svg/SVGFontFaceUriElement.h:
1653         * xml/XSLImportRule.h:
1654
1655 2011-10-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1656
1657         Unreviewed, rolling out r97087.
1658         http://trac.webkit.org/changeset/97087
1659         https://bugs.webkit.org/show_bug.cgi?id=69805
1660
1661         failing assert on debug builds (Requested by simonjam on
1662         #webkit).
1663
1664         * bindings/ScriptControllerBase.cpp:
1665         (WebCore::ScriptController::executeIfJavaScriptURL):
1666         * loader/DocumentWriter.cpp:
1667         (WebCore::DocumentWriter::replaceDocument):
1668         (WebCore::DocumentWriter::begin):
1669         * loader/DocumentWriter.h:
1670
1671 2011-10-10  Adam Barth  <abarth@webkit.org>
1672
1673         [V8] CodeGeneratorV8 shouldn't hardcode the list of ActiveDOMObjects
1674         https://bugs.webkit.org/show_bug.cgi?id=69792
1675
1676         Reviewed by Nate Chapin.
1677
1678         We used to hard code the list of active DOM objects in the code
1679         generator, but now we have an IDL attribute.  This patch switches the
1680         code generator over to using the IDL attribute.
1681
1682         * bindings/scripts/CodeGeneratorV8.pm:
1683         (GenerateHeader):
1684         (GenerateNormalAttrGetter):
1685         (GenerateImplementation):
1686         (GetDomMapFunction):
1687
1688 2011-10-10  Nico Weber  <thakis@chromium.org>
1689
1690         PluginDocumentParser uses incorrect syntax for background color
1691         https://bugs.webkit.org/show_bug.cgi?id=69694
1692
1693         Reviewed by Adam Barth.
1694
1695         * html/PluginDocument.cpp:
1696         (WebCore::PluginDocumentParser::createDocumentStructure):
1697
1698 2011-10-10  Ryosuke Niwa  <rniwa@webkit.org>
1699
1700         REGRESSION(r96870): editing/pasteboard/smart-paste-008.html fails on non-Mac
1701         https://bugs.webkit.org/show_bug.cgi?id=69587
1702
1703         Reviewed by Enrica Casucci.
1704
1705         Insert a space at the correct offset when startNode is a text node.
1706
1707         * editing/ReplaceSelectionCommand.cpp:
1708         (WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace):
1709
1710 2011-09-20  Jer Noble  <jer.noble@apple.com>
1711
1712         MediaControlSeekButtonElement should support seeking by changing the playback rate.
1713         https://bugs.webkit.org/show_bug.cgi?id=63595
1714
1715         Reviewed by Eric Carlson.
1716
1717         Test: media/video-controls-scanning.html
1718
1719         Add a new property to HTMLMediaElement, supportsScanning(), which returns whether the
1720         element is capable of playing its media at a rate greater than 1x. HTMLMediaElement passes
1721         this call through to MediaPlayer and MediaPlayerPrivate. If this property returns true, the
1722         built-in scanning controls can prefer to scan by changing the playbackRate, rather than by
1723         repeatedly seeking small amounts of time. Unless overridden by specific media engines, this
1724         property defaults to "false".
1725
1726         * html/HTMLMediaElement.h:
1727         * html/HTMLMediaElement.cpp:
1728         (WebCore::HTMLMediaElement::supportsScanning): Added.  Calls through to MediaPlayer.
1729         * platform/graphics/MediaPlayer.h:
1730         * platform/graphics/MediaPlayer.cpp:
1731         (WebCore::MediaPlayer::supportsScanning): Added. Calls through to MediaPlayerPrivate.
1732         * platform/graphics/MediaPlayerPrivate.h:
1733         (WebCore::MediaPlayerPrivateInterface::supportsScanning): Added. Defaults to "false".
1734         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
1735         (WebCore::MediaPlayerPrivateAVFoundation::supportsScanning): Added.
1736         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
1737         (WebCore::MediaPlayerPrivateQTKit::supportsScanning): Added.
1738
1739         MediaControlSeekButtonElement now queries HTMLMediaElement::supportsScanning() to see if the
1740         media element can implement its seeking behavior by scanning the media at greater than 1x
1741         rate. Note whether the media was playing or paused when the seek begins, so that the playing
1742         state can be restored when seeking ends.  Instead of capturing the mouse after mouseDown,
1743         the seek button now responds to setActive() and begins seeking when the button is active
1744         and stops when it becomes inactive.
1745
1746         Some behaviors have changed: clicking on the seek button no longer causes the media element
1747         to pause; the media will end in the same state it began after the click.  cStepTime has been
1748         eliminated; Clicking the seek button will always skip by at least cSeekTime, or 0.2s.
1749
1750         * html/shadow/MediaControlElements.cpp:
1751         (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): Initialize new
1752             ivars.
1753         (WebCore::MediaControlSeekButtonElement::defaultEventHandler): Mark mouseDown and mouseUp
1754             as defaultHandled, so as not to trigger drag start and drag end actions.
1755         (WebCore::MediaControlSeekButtonElement::setActive): Call startTimer or stopTimer based
1756             on whether the button is active or not.
1757         (WebCore::MediaControlSeekButtonElement::startTimer): Determine whether to scan or skip
1758             and start the seekTimer.
1759         (WebCore::MediaControlSeekButtonElement::stopTimer): Restore the playing state and
1760             stop the timer.
1761         (WebCore::MediaControlSeekButtonElement::seekTimerFired): Depending on whether we're
1762             scanning or skipping, jump ahead or change the playback rate.
1763         * html/shadow/MediaControlElements.h:
1764
1765 2011-10-10  Mark Hahnenberg  <mhahnenberg@apple.com>
1766
1767         Remove getCallDataVirtual methods
1768         https://bugs.webkit.org/show_bug.cgi?id=69186
1769
1770         Reviewed by Geoffrey Garen.
1771
1772         No new tests.
1773
1774         Removed all getCallDataVirtual methods and replaced their call sites
1775         with an explicit lookup in the MethodTable.
1776
1777         * WebCore.exp.in:
1778         * bindings/js/JSCallbackData.cpp:
1779         (WebCore::JSCallbackData::invokeCallback):
1780         * bindings/js/JSCustomXPathNSResolver.cpp:
1781         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
1782         * bindings/js/JSErrorHandler.cpp:
1783         (WebCore::JSErrorHandler::handleEvent):
1784         * bindings/js/JSEventListener.cpp:
1785         (WebCore::JSEventListener::handleEvent):
1786         * bindings/js/JSHTMLAllCollectionCustom.cpp:
1787         * bindings/js/JSHTMLAppletElementCustom.cpp:
1788         * bindings/js/JSHTMLEmbedElementCustom.cpp:
1789         * bindings/js/JSHTMLObjectElementCustom.cpp:
1790         * bindings/js/JSInjectedScriptHostCustom.cpp:
1791         (WebCore::JSInjectedScriptHost::evaluate):
1792         * bindings/js/JSPluginElementFunctions.cpp:
1793         (WebCore::runtimeObjectGetCallData):
1794         * bindings/scripts/CodeGeneratorJS.pm:
1795         (GenerateHeader):
1796         * bridge/objc/objc_runtime.h:
1797         * bridge/objc/objc_runtime.mm:
1798         * bridge/qt/qt_runtime.cpp:
1799         (JSC::Bindings::QtRuntimeConnectionMethod::call):
1800         (JSC::Bindings::isJavaScriptFunction):
1801         * bridge/qt/qt_runtime.h:
1802         (JSC::Bindings::QtRuntimeMetaMethod::create):
1803         (JSC::Bindings::QtRuntimeMetaMethod::createStructure):
1804         (JSC::Bindings::QtRuntimeConnectionMethod::create):
1805         (JSC::Bindings::QtRuntimeConnectionMethod::createStructure):
1806         * bridge/runtime_method.cpp:
1807         * bridge/runtime_method.h:
1808         * bridge/runtime_object.cpp:
1809         * bridge/runtime_object.h:
1810
1811 2011-10-06  Jer Noble  <jer.noble@apple.com>
1812
1813         media/video-loop.html is failing on Lion because of negative currentTime()
1814         https://bugs.webkit.org/show_bug.cgi?id=69468
1815
1816         Reviewed by Darin Adler.
1817
1818         No new tests. Covered by media/video-loop.html test.
1819
1820         AVFoundation will occasionally return small, negative current times during loop operations.
1821         Clean up these negative times before returning the currentTime.
1822
1823         * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
1824         (WebCore::MediaPlayerPrivateAVFoundationObjC::currentTime):
1825
1826 2011-10-10  Jeremy Apthorp  <jeremya@chromium.org>
1827
1828         Exiting fullscreen shouldn't crash if the element that was fullscreened
1829         had associated anonymous blocks.
1830         https://bugs.webkit.org/show_bug.cgi?id=68503
1831
1832         Reviewed by Simon Fraser.
1833
1834         Test: fullscreen/full-screen-render-inline.html
1835         Test: fullscreen/parent-flow-inline-with-block-child.html
1836
1837         * rendering/RenderBlock.cpp:
1838         (WebCore::RenderBlock::moveChildTo):
1839         (WebCore::RenderBlock::moveChildrenTo):
1840         * rendering/RenderBlock.h:
1841         (WebCore::RenderBlock::moveChildTo):
1842         (WebCore::RenderBlock::moveAllChildrenTo):
1843         (WebCore::RenderBlock::moveChildrenTo):
1844         * rendering/RenderFullScreen.cpp:
1845         (RenderFullScreen::unwrapRenderer):
1846         Move all children back to the parent, not just the firstChild.
1847
1848 2011-10-10  Sergey Glazunov  <serg.glazunov@gmail.com>
1849
1850         ScriptController::executeIfJavaScriptURL gets confused by synchronous frame loads
1851         https://bugs.webkit.org/show_bug.cgi?id=69777
1852
1853         Reviewed by Adam Barth.
1854
1855         Test: http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url.html
1856
1857         * bindings/ScriptControllerBase.cpp:
1858         (WebCore::ScriptController::executeIfJavaScriptURL):
1859         * loader/DocumentWriter.cpp:
1860         (WebCore::DocumentWriter::replaceDocument):
1861         (WebCore::DocumentWriter::begin):
1862         * loader/DocumentWriter.h:
1863
1864 2011-10-10  Nayan Kumar K  <nayankk@motorola.com>
1865
1866         Add missing ifdef for JAVASCRIPT_DEBUGGER feature.
1867         https://bugs.webkit.org/show_bug.cgi?id=69758
1868
1869         Reviewed by Adam Barth.
1870
1871         No new tests added since this is a build failure fix.
1872
1873         * bindings/v8/custom/V8ScriptProfileCustom.cpp:
1874         * bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
1875
1876 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
1877
1878         REGRESSION(96070) 25% intl1 PLT regression from scrollbar invalidation
1879         https://bugs.webkit.org/show_bug.cgi?id=69238
1880
1881         Reviewed by Darin Adler.
1882
1883         Fix PLT regression from additional scrollbars invalidations.
1884
1885         Don't invalidate the scrollbar rect from setHasHorizontalScrollbar()
1886         and setHasVerticalScrollbar(), because this is called during FrameView
1887         teardown, at which point the invalidation is redundant.
1888
1889         Instead, invalidate from ScrollView::updateScrollbars(), which is
1890         called only when scrollbars change because of size or layout
1891         changes.
1892
1893         * platform/ScrollView.cpp:
1894         (WebCore::ScrollView::setHasHorizontalScrollbar):
1895         (WebCore::ScrollView::setHasVerticalScrollbar):
1896         (WebCore::ScrollView::updateScrollbars):
1897
1898 2011-10-10  Abhishek Arya  <inferno@chromium.org>
1899
1900         Style for updated due to inability to locate
1901         :before content in presence of listmarkers and runins.
1902         https://bugs.webkit.org/show_bug.cgi?id=68624
1903
1904         Reviewed by Dan Bernstein.
1905
1906         Tests: fast/lists/inline-before-content-after-list-marker.html
1907                fast/runin/runin-between-list-marker-and-before-content.html
1908                fast/runin/runin-into-div-with-float-child.html
1909                fast/runin/runin-not-go-into-float.html
1910
1911         * rendering/RenderBlock.cpp:
1912         (WebCore::RenderBlock::handleRunInChild): Fix as per spec that
1913         we should not be skipping over floating/positioned renderers to
1914         push runins into neighbouring block. This matches Opera renderings.
1915         * rendering/RenderObject.cpp: Add const to parameter variable
1916         to make call from beforePseudoElementRenderer easier. Also matches
1917         CounterNode.h definition.
1918         (WebCore::RenderObject::nextInPreOrder):
1919         (WebCore::RenderObject::nextInPreOrderAfterChildren):
1920         * rendering/RenderObject.h: Same const addition.
1921         * rendering/RenderObjectChildList.cpp:
1922         (WebCore::RenderObjectChildList::beforePseudoElementRenderer):
1923         Remove skipping of floating/positioned renderers, similar to
1924         handleRunIn. Revert code change in r94857 and add better next
1925         sibling iterator. This addresses the layouttest in r94857 where
1926         :before content is in its own anonymous rendertable.
1927
1928 2011-10-10  Abhishek Arya  <inferno@chromium.org>
1929
1930         Handle insertion into an anonymous table part that
1931         is followed by a non-anonymous block correctly.
1932         https://bugs.webkit.org/show_bug.cgi?id=69536
1933
1934         Reviewed by Dan Bernstein.
1935
1936         Tests: fast/table/table-insert-before-non-anonymous-block.html
1937
1938         * rendering/RenderTable.cpp:
1939         (WebCore::RenderTable::addChild):
1940         * rendering/RenderTableRow.cpp:
1941         (WebCore::RenderTableRow::addChild):
1942         * rendering/RenderTableSection.cpp:
1943         (WebCore::RenderTableSection::addChild):
1944         (WebCore::RenderTableSection::splitColumn):
1945
1946 2011-10-10  Kent Tamura  <tkent@chromium.org>
1947
1948         Make static functions in HTMLSelectElement.cpp member functions of HTMLSelectElement class
1949         https://bugs.webkit.org/show_bug.cgi?id=69755
1950
1951         Reviewed by Ryosuke Niwa.
1952
1953
1954         No new tests, just a refactoring.
1955
1956         * html/HTMLSelectElement.cpp:
1957         (WebCore::HTMLSelectElement::nextValidIndex):
1958         Make this a static member function of HTMLSelectElement.
1959         (WebCore::HTMLSelectElement::nextSelectableListIndex):
1960         Make this a member function of HTMLSelectElement.
1961         (WebCore::HTMLSelectElement::previousSelectableListIndex): ditto.
1962         (WebCore::HTMLSelectElement::firstSelectableListIndex): ditto.
1963         (WebCore::HTMLSelectElement::lastSelectableListIndex): ditto.
1964         (WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): ditto.
1965         (WebCore::HTMLSelectElement::selectAll): Update callsite of the above functions.
1966         (WebCore::HTMLSelectElement::setSelectedIndexInternal): ditto.
1967         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
1968         * html/HTMLSelectElement.h:
1969          - Add the above function declarations.
1970          - Move SkipDirection definition from HTMLSelectElement.cpp.
1971
1972 2011-10-10  Pavel Feldman  <pfeldman@google.com>
1973
1974         Web Inspector: annotate DOMAgent, Debugger(Presentation)Model with types.
1975         https://bugs.webkit.org/show_bug.cgi?id=69726
1976
1977         Reviewed by Yury Semikhatsky.
1978
1979         * inspector/compile-front-end.sh:
1980         * inspector/front-end/ApplicationCacheItemsView.js:
1981         (WebInspector.ApplicationCacheItemsView):
1982         * inspector/front-end/AuditsPanel.js:
1983         (WebInspector.AuditsPanel):
1984         * inspector/front-end/BreakpointManager.js:
1985         (WebInspector.BreakpointManager.prototype._breakpointResolved):
1986         * inspector/front-end/CSSStyleModel.js:
1987         * inspector/front-end/CompilerSourceMapping.js:
1988         (WebInspector.CompilerSourceMapping.prototype.compiledLocationToSourceLocation):
1989         (WebInspector.CompilerSourceMapping.prototype.sourceLocationToCompiledLocation):
1990         (WebInspector.CompilerSourceMapping.prototype.sources):
1991         * inspector/front-end/ConsoleView.js:
1992         (WebInspector.ConsoleView.prototype._completions.evaluated):
1993         (WebInspector.ConsoleView.prototype._completions.receivedPropertyNamesFromEval):
1994         (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
1995         * inspector/front-end/CookieItemsView.js:
1996         (WebInspector.CookieItemsView):
1997         * inspector/front-end/DOMAgent.js:
1998         (WebInspector.DOMNode.prototype.isXMLNode):
1999         (WebInspector.DOMDocument):
2000         (WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable.onDocumentAvailable):
2001         (WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable):
2002         (WebInspector.DOMDispatcher.prototype.characterDataModified):
2003         (WebInspector.DOMDispatcher.prototype.childNodeCountUpdated):
2004         (WebInspector.DOMDispatcher.prototype.childNodeInserted):
2005         (WebInspector.DOMDispatcher.prototype.childNodeRemoved):
2006         * inspector/front-end/DOMStorageItemsView.js:
2007         (WebInspector.DOMStorageItemsView):
2008         * inspector/front-end/DatabaseTableView.js:
2009         (WebInspector.DatabaseTableView):
2010         * inspector/front-end/DebuggerModel.js:
2011         (WebInspector.DebuggerModel):
2012         (WebInspector.DebuggerPausedDetails):
2013         (WebInspector.DebuggerModel.prototype.reset):
2014         (WebInspector.DebuggerModel.prototype.get callFrames):
2015         (WebInspector.DebuggerModel.prototype._pausedScript):
2016         (WebInspector.DebuggerModel.prototype._resumedScript):
2017         (WebInspector.DebuggerModel.prototype._parsedScriptSource):
2018         (WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
2019         (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
2020         (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
2021         * inspector/front-end/DebuggerPresentationModel.js:
2022         (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
2023         (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
2024         (WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
2025         (WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
2026         (WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
2027         (WebInspector.DebuggerPresentationModel.prototype._createPresentationMessage):
2028         (WebInspector.PresentationConsoleMessage):
2029         (WebInspector.PresentationCallFrame.prototype.evaluate):
2030         (WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateSourceAnchors):
2031         * inspector/front-end/ElementsPanel.js:
2032         (WebInspector.ElementsPanel):
2033         (WebInspector.ElementsPanel.prototype._documentUpdated.selectLastSelectedNode):
2034         (WebInspector.ElementsPanel.prototype._documentUpdated):
2035         * inspector/front-end/NetworkPanel.js:
2036         * inspector/front-end/Object.js:
2037         (WebInspector.Object.prototype.dispatchEventToListeners):
2038         (WebInspector.Event):
2039         (WebInspector.Event.prototype.stopPropagation):
2040         (WebInspector.Event.prototype.preventDefault):
2041         * inspector/front-end/RawSourceCode.js:
2042         (WebInspector.RawSourceCode.SourceMapping):
2043         (WebInspector.RawSourceCode.SourceMapping.prototype.rawLocationToUILocation):
2044         (WebInspector.RawSourceCode.SourceMapping.prototype.uiLocationToRawLocation):
2045         (WebInspector.RawSourceCode.PlainSourceMapping.prototype.rawLocationToUILocation):
2046         (WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation):
2047         (WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
2048         (WebInspector.RawSourceCode.CompilerSourceMapping.prototype.rawLocationToUILocation):
2049         (WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation):
2050         * inspector/front-end/Script.js:
2051         (WebInspector.Script):
2052         (WebInspector.Script.prototype.requestSource):
2053         (WebInspector.Script.prototype.searchInContent):
2054         (WebInspector.Script.prototype.editSource):
2055         * inspector/front-end/ScriptsPanel.js:
2056         (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
2057         * inspector/front-end/TimelinePanel.js:
2058         (WebInspector.TimelinePanel.prototype._createStatusbarButtons):
2059         * inspector/front-end/UISourceCode.js:
2060         (WebInspector.UISourceCode):
2061         (WebInspector.ContentProvider.SearchMatch):
2062         * inspector/front-end/WatchExpressionsSidebarPane.js:
2063         (WebInspector.WatchExpressionsSection.prototype.update):
2064         * inspector/front-end/externs.js:
2065         * inspector/generate-protocol-externs:
2066
2067 2011-10-10  Ilya Tikhonovsky  <loislo@chromium.org>
2068
2069         Web Inspector: Linkifier.reset throw an exception if it is called after reset of debuggerPresentationModel.
2070         https://bugs.webkit.org/show_bug.cgi?id=69756
2071
2072         Reviewed by Yury Semikhatsky.
2073
2074         * inspector/front-end/DebuggerPresentationModel.js:
2075         (WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
2076
2077 2011-09-28  Pavel Podivilov  <podivilov@chromium.org>
2078
2079         Web Inspector: RawSourceCode could be mapped to multiple sources.
2080         https://bugs.webkit.org/show_bug.cgi?id=68526
2081
2082         Replace SourceMapping.uiSourceCode with SourceMapping.uiSourceCodeList as there could be more
2083         then one UISourceCode associated with a RawSourceCode.
2084
2085         Reviewed by Pavel Feldman.
2086
2087         * inspector/front-end/DebuggerPresentationModel.js:
2088         (WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
2089         (WebInspector.DebuggerPresentationModel.prototype._updateSourceMapping):
2090         (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
2091         (WebInspector.PresentationCallFrame.prototype.get url):
2092         (WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
2093         (WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
2094         * inspector/front-end/ScriptsPanel.js:
2095         (WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
2096         * inspector/front-end/SourceFile.js:
2097         (WebInspector.RawSourceCode.prototype._saveSourceMapping):
2098         (WebInspector.RawSourceCode.PlainSourceMapping):
2099         (WebInspector.RawSourceCode.PlainSourceMapping.prototype.rawLocationToUILocation):
2100         (WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiSourceCodeList):
2101         (WebInspector.RawSourceCode.FormattedSourceMapping):
2102         (WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
2103         (WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiSourceCodeList):
2104
2105 2011-10-10  Andreas Kling  <kling@webkit.org>
2106
2107         Shrink RenderLayer and ScrollableArea.
2108         https://bugs.webkit.org/show_bug.cgi?id=69759
2109
2110         Reviewed by Antti Koivisto.
2111
2112         Rearrange the members of RenderLayer and its base class ScrollableArea
2113         to maximize struct packing, shrinking RenderLayer by one CPU word on
2114         32-bit (and two on 64-bit.)
2115
2116         This reduces memory consumption by 134 kB (on 64-bit) when loading the
2117         full HTML5 spec.
2118
2119         * platform/ScrollableArea.h:
2120         (WebCore::ScrollableArea::verticalScrollElasticity):
2121         (WebCore::ScrollableArea::horizontalScrollElasticity):
2122         (WebCore::ScrollableArea::scrollbarOverlayStyle):
2123
2124             Cast the now-bitfield members to the appropriate enum types.
2125
2126         * rendering/RenderLayer.h:
2127         * rendering/RenderLayer.cpp:
2128         (WebCore::RenderLayer::RenderLayer):
2129
2130             Move shouldBeNormalFlowOnly() call out of initializer list since it
2131             depends on m_renderer being initialized.
2132
2133 2011-10-10  Cary Clark  <caryclark@google.com>
2134
2135         [Skia on Chromium Mac] Set canExpandAroundIdeographsInComplexText to true
2136         https://bugs.webkit.org/show_bug.cgi?id=69656
2137         https://bugs.webkit.org/show_bug.cgi?id=62987
2138         https://bugs.webkit.org/show_bug.cgi?id=62889
2139
2140         Reviewed by Stephen White.
2141
2142         Skia on Linux and Windows uses different font engines from
2143         Skia on Mac. After determining that the underlying CoreText
2144         can handle it, enabling this allows justification to work
2145         correctly.
2146
2147         Tests: fast/text/justify-ideograph-complex.html
2148
2149         * platform/graphics/skia/FontSkia.cpp:
2150         (WebCore::Font::canExpandAroundIdeographsInComplexText):
2151
2152 2011-10-10  Ilya Tikhonovsky  <loislo@chromium.org>
2153
2154         Web Inspector: memory leak in Resource panel.
2155         https://bugs.webkit.org/show_bug.cgi?id=69754
2156
2157         Reviewed by Yury Semikhatsky.
2158
2159         * inspector/front-end/ResourcesPanel.js:
2160         (WebInspector.ResourcesPanel.prototype.reset):
2161         * inspector/front-end/View.js:
2162         (WebInspector.View.prototype.childViews):
2163
2164 2011-10-06  Pavel Podivilov  <podivilov@chromium.org>
2165
2166         Web Inspector: saving JavaScript after live edit resets scroller position.
2167         https://bugs.webkit.org/show_bug.cgi?id=69340
2168
2169         Do not recreate SourceFrame when content is changed. Instead, update text model in existing SourceFrame.
2170
2171         Reviewed by Yury Semikhatsky.
2172
2173         * inspector/front-end/DebuggerPresentationModel.js:
2174         (WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
2175         (WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
2176         * inspector/front-end/JavaScriptSourceFrame.js:
2177         (WebInspector.JavaScriptSourceFrame):
2178         * inspector/front-end/RawSourceCode.js:
2179         (WebInspector.RawSourceCode.prototype.setCompilerSourceMappingProvider):
2180         * inspector/front-end/SourceFrame.js:
2181         (WebInspector.SourceFrame.prototype._setReadOnly):
2182         (WebInspector.SourceFrame.prototype.contentChanged):
2183         * inspector/front-end/UISourceCode.js:
2184         (WebInspector.UISourceCode.prototype.contentChanged):
2185
2186 2011-10-10  Ilya Tikhonovsky  <loislo@chromium.org>
2187
2188         Unreviewed test fix for r97050.
2189
2190         * inspector/front-end/DebuggerPresentationModel.js:
2191         (WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
2192
2193 2011-10-10  Andreas Kling  <kling@webkit.org>
2194
2195         Shrink RenderListItem on 64-bit.
2196         https://bugs.webkit.org/show_bug.cgi?id=69751
2197
2198         Reviewed by Kenneth Rohde Christiansen.
2199
2200         Rearrange members to utilize the padding at the end of RenderBlock.
2201         This shrinks RenderListItem by 8 bytes on 64-bit, reducing memory consumption
2202         by 60 kB when loading the full HTML5 spec.
2203
2204         * rendering/RenderListItem.h:
2205
2206 2011-10-10  Andreas Kling  <kling@webkit.org>
2207
2208         Shrink RootInlineBox.
2209         https://bugs.webkit.org/show_bug.cgi?id=69707
2210
2211         Reviewed by Antti Koivisto.
2212
2213         Move the bitfields from RootInlineBox up into its base class (InlineFlowBox.)
2214         This shrinks RootInlineBox by one CPU word without growing InlineFlowBox.
2215         Enum bitfields were changed to "unsigned" for the MSVC signedness quirk.
2216
2217         Also move one 32-bit member to the head of RootInlineBox so it falls into the
2218         padding at the end of InlineFlowBox on 64-bit.
2219
2220         This reduces memory consumption by 780 kB (on 64-bit) when loading the full
2221         HTML5 spec.
2222
2223         * rendering/InlineFlowBox.h:
2224         (WebCore::InlineFlowBox::InlineFlowBox):
2225         * rendering/RootInlineBox.cpp:
2226         (WebCore::RootInlineBox::RootInlineBox):
2227         (WebCore::RootInlineBox::lineBreakBidiStatus):
2228         * rendering/RootInlineBox.h:
2229
2230 2011-10-10  Pavel Podivilov  <podivilov@chromium.org>
2231
2232         Unreviewed, attempt to fix chromium mac build after r97034.
2233
2234         * platform/ScrollAnimatorNone.h:
2235
2236 2011-10-10  Ilya Tikhonovsky  <loislo@chromium.org>
2237
2238         Web Inspector: small memory leak in scripts panel.
2239         https://bugs.webkit.org/show_bug.cgi?id=69744
2240
2241         Scripts panel doesn't clean the list of child views.
2242
2243         Reviewed by Yury Semikhatsky.
2244
2245         * inspector/front-end/DebuggerPresentationModel.js:
2246         (WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
2247         * inspector/front-end/ScriptsPanel.js:
2248         (WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
2249
2250 2011-10-07  Yury Semikhatsky  <yurys@chromium.org>
2251
2252         Web Inspector: allow to start WorkerContext paused
2253         https://bugs.webkit.org/show_bug.cgi?id=69635
2254
2255         Allow to pause WorkerContext on start.
2256
2257         Reviewed by Pavel Feldman.
2258
2259         * bindings/v8/ScriptDebugServer.cpp:
2260         (WebCore::ScriptDebugServer::setPauseOnNextStatement):
2261         * bindings/v8/WorkerScriptDebugServer.cpp:
2262         (WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
2263         * bindings/v8/WorkerScriptDebugServer.h:
2264         * inspector/InspectorController.cpp:
2265         (WebCore::InspectorController::InspectorController):
2266         * inspector/InspectorInstrumentation.cpp:
2267         (WebCore::InspectorInstrumentation::willEvaluateWorkerScript):
2268         * inspector/InspectorInstrumentation.h:
2269         * inspector/InspectorRuntimeAgent.cpp:
2270         (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
2271         (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
2272         (WebCore::InspectorRuntimeAgent::pauseWorkerContext): this method will start
2273         running worker message loop in "debug" mode, i.e. it will process only inspector
2274         tasks until method InspectorRuntimeAgent::resume is called.
2275         (WebCore::InspectorRuntimeAgent::resume):
2276         * inspector/InspectorRuntimeAgent.h:
2277         * inspector/WorkerDebuggerAgent.cpp:
2278         * inspector/WorkerDebuggerAgent.h:
2279         * inspector/WorkerInspectorController.cpp:
2280         (WebCore::WorkerInspectorController::WorkerInspectorController):
2281         (WebCore::WorkerInspectorController::resume): method which is called from WebKit layer
2282         when it is known that inspector state was restored and it is OK to resume worker execution.
2283         * inspector/WorkerInspectorController.h:
2284         * workers/DedicatedWorkerThread.cpp:
2285         (WebCore::DedicatedWorkerThread::create):
2286         (WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
2287         * workers/DedicatedWorkerThread.h:
2288         * workers/SharedWorkerThread.cpp:
2289         (WebCore::SharedWorkerThread::create):
2290         (WebCore::SharedWorkerThread::SharedWorkerThread):
2291         * workers/SharedWorkerThread.h:
2292         * workers/WorkerMessagingProxy.cpp:
2293         (WebCore::WorkerMessagingProxy::startWorkerContext):
2294         (WebCore::WorkerMessagingProxy::disconnectFromInspector):
2295         (WebCore::WorkerMessagingProxy::sendMessageToInspector):
2296         * workers/WorkerThread.cpp:
2297         (WebCore::WorkerThreadStartupData::create):
2298         (WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
2299         (WebCore::WorkerThread::WorkerThread): WorkerThread is passed a booleand flag indicating
2300         whether the context should be paused and wait for explicit resume command before it
2301         starts running its script.
2302         (WebCore::WorkerThread::workerThread):
2303         * workers/WorkerThread.h:
2304
2305 2011-10-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2306
2307         Unreviewed, rolling out r97045.
2308         http://trac.webkit.org/changeset/97045
2309         https://bugs.webkit.org/show_bug.cgi?id=69746
2310
2311         makes apple bots very crashy :( (Requested by kling on
2312         #webkit).
2313
2314         * css/CSSStyleApplyProperty.cpp:
2315         (WebCore::ApplyPropertyColor::applyInheritValue):
2316         * page/animation/AnimationBase.cpp:
2317         (WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
2318         (WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
2319         (WebCore::AnimationBase::ensurePropertyMap):
2320         * platform/graphics/Color.h:
2321         (WebCore::Color::Color):
2322         * rendering/style/BorderValue.h:
2323         (WebCore::BorderValue::BorderValue):
2324         (WebCore::BorderValue::isTransparent):
2325         (WebCore::BorderValue::operator==):
2326         (WebCore::BorderValue::color):
2327         * rendering/style/OutlineValue.h:
2328         (WebCore::OutlineValue::operator==):
2329         * rendering/style/RenderStyle.h:
2330         (WebCore::InheritedFlags::setBorderLeftColor):
2331         (WebCore::InheritedFlags::setBorderRightColor):
2332         (WebCore::InheritedFlags::setBorderTopColor):
2333         (WebCore::InheritedFlags::setBorderBottomColor):
2334         (WebCore::InheritedFlags::setOutlineColor):
2335         (WebCore::InheritedFlags::setColumnRuleColor):
2336         (WebCore::InheritedFlags::fillPaintColor):
2337         (WebCore::InheritedFlags::strokePaintColor):
2338         (WebCore::InheritedFlags::borderLeftColor):
2339         (WebCore::InheritedFlags::borderRightColor):
2340         (WebCore::InheritedFlags::borderTopColor):
2341         (WebCore::InheritedFlags::borderBottomColor):
2342         (WebCore::InheritedFlags::backgroundColor):
2343         (WebCore::InheritedFlags::color):
2344         (WebCore::InheritedFlags::columnRuleColor):
2345         (WebCore::InheritedFlags::outlineColor):
2346         (WebCore::InheritedFlags::textEmphasisColor):
2347         (WebCore::InheritedFlags::textFillColor):
2348         (WebCore::InheritedFlags::textStrokeColor):
2349         (WebCore::InheritedFlags::stopColor):
2350         (WebCore::InheritedFlags::floodColor):
2351         (WebCore::InheritedFlags::lightingColor):
2352
2353 2011-10-06  Andreas Kling  <kling@webkit.org>
2354
2355         Shrink BorderValue.
2356         https://bugs.webkit.org/show_bug.cgi?id=69521
2357
2358         Reviewed by Antti Koivisto.
2359
2360         Unroll BorderValue's Color member so we can pack the color's validity flag
2361         in BorderValue's bitfield.
2362
2363         This shrinks BorderValue by 32 bit, which in turn shrinks BorderData by
2364         16 bytes. This reduces memory consumption by 760 kB when loading the full
2365         HTML5 spec.
2366
2367         * platform/graphics/Color.h:
2368         (WebCore::Color::Color):
2369
2370             Allow construction of Color objects with specific validity.
2371
2372         * rendering/style/BorderValue.h:
2373         (WebCore::BorderValue::BorderValue):
2374         (WebCore::BorderValue::isTransparent):
2375         (WebCore::BorderValue::operator==):
2376         (WebCore::BorderValue::setColor):
2377         (WebCore::BorderValue::color):
2378         * rendering/style/OutlineValue.h:
2379         (WebCore::OutlineValue::operator==):
2380
2381             Unroll m_color into BorderValue by splitting it into an RGBA32 and a bool.
2382             Made those variables private and added color(), setColor() accessors.
2383
2384         * rendering/style/RenderStyle.h:
2385         (WebCore::InheritedFlags::setBorderLeftColor):
2386         (WebCore::InheritedFlags::setBorderRightColor):
2387         (WebCore::InheritedFlags::setBorderTopColor):
2388         (WebCore::InheritedFlags::setBorderBottomColor):
2389         (WebCore::InheritedFlags::setOutlineColor):
2390         (WebCore::InheritedFlags::setColumnRuleColor):
2391
2392             Added a SET_BORDERVALUE_COLOR macro and use that instead of SET_VAR
2393             when setting BorderValue colors.
2394
2395         (WebCore::InheritedFlags::fillPaintColor):
2396         (WebCore::InheritedFlags::strokePaintColor):
2397         (WebCore::InheritedFlags::borderLeftColor):
2398         (WebCore::InheritedFlags::borderRightColor):
2399         (WebCore::InheritedFlags::borderTopColor):
2400         (WebCore::InheritedFlags::borderBottomColor):
2401         (WebCore::InheritedFlags::backgroundColor):
2402         (WebCore::InheritedFlags::color):
2403         (WebCore::InheritedFlags::columnRuleColor):
2404         (WebCore::InheritedFlags::outlineColor):
2405         (WebCore::InheritedFlags::textEmphasisColor):
2406         (WebCore::InheritedFlags::textFillColor):
2407         (WebCore::InheritedFlags::textStrokeColor):
2408         (WebCore::InheritedFlags::stopColor):
2409         (WebCore::InheritedFlags::floodColor):
2410         (WebCore::InheritedFlags::lightingColor):
2411
2412             Made color getters return "Color" instead of "const Color&" since
2413             BorderValue no longer has an actual object to return the reference to.
2414
2415         * css/CSSStyleApplyProperty.cpp:
2416         (WebCore::ApplyPropertyColor::applyInheritValue):
2417         * page/animation/AnimationBase.cpp:
2418         (WebCore::PropertyWrapperColor::PropertyWrapperColor):
2419         (WebCore::PropertyWrapperColor::blend):
2420         (WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
2421         (WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
2422         (WebCore::AnimationBase::ensurePropertyMap):
2423
2424             Adapt to RenderStyle color getters now returning "Color" instead of
2425             "const Color&".
2426
2427 2011-10-09  Yury Semikhatsky  <yurys@chromium.org>
2428
2429         Missing m_notificationPresenter initialization in WorkerThread constructor
2430         https://bugs.webkit.org/show_bug.cgi?id=69741
2431
2432         Added missing m_notificationPresenter(0)
2433
2434         Reviewed by Pavel Feldman.
2435
2436         * workers/WorkerThread.cpp:
2437         (WebCore::WorkerThread::WorkerThread):
2438
2439 2011-10-09  Daniel Bates  <dbates@webkit.org>
2440
2441         Another attempt to fix the Leopard Intel Debug build after changeset 97034 <http://trac.webkit.org/changeset/97034>
2442         (https://bugs.webkit.org/show_bug.cgi?id=68035)
2443
2444         * page/FrameView.cpp:
2445         (WebCore::FrameView::zoomAnimatorTransformChanged): Explicitly convert a double precision result
2446         to a single precision result. I am unsure if this fix is correct. We need to look into this some
2447         more. See <https://bugs.webkit.org/show_bug.cgi?id=69739> for more details.
2448
2449 2011-10-09  Daniel Bates  <dbates@webkit.org>
2450
2451         Attempt to fix the Leopard Intel Debug build after changeset 97034 <http://trac.webkit.org/changeset/97034>
2452         (https://bugs.webkit.org/show_bug.cgi?id=68035)
2453
2454         * page/FrameView.cpp:
2455         (WebCore::FrameView::zoomAnimatorTransformChanged): Explicitly convert double precision result to
2456         an integer. I am unsure if this fix is correct. We need to look into this some more. See
2457         <https://bugs.webkit.org/show_bug.cgi?id=69739> for more details.
2458
2459 2011-10-09  Luke Macpherson   <macpherson@chromium.org>
2460
2461         Fix Lion, Leopard and Snow Leopard builds after changeset 97034 <http://trac.webkit.org/changeset/97034>
2462         (https://bugs.webkit.org/show_bug.cgi?id=68035)
2463         https://bugs.webkit.org/show_bug.cgi?id=69735
2464
2465         Reviewed by Daniel Bates.
2466
2467         * testing/Internals.cpp:
2468         Mark unused parameters to prevent compile errors when GESTURE_EVENTS and SMOOTH_SCROLLING are disabled.
2469         (WebCore::Internals::setEnableScrollAnimator):
2470         (WebCore::Internals::setZoomAnimatorTransform):
2471         (WebCore::Internals::setZoomParameters):
2472
2473 2011-10-09  Kent Tamura  <tkent@chromium.org>
2474
2475         Remove redundant code of HTMLSelectElement.
2476         https://bugs.webkit.org/show_bug.cgi?id=69701
2477
2478         Reviewed by Darin Adler.
2479
2480         No new tests, just a refactoring.
2481
2482         * html/HTMLSelectElement.cpp:
2483         (WebCore::HTMLSelectElement::deselectItems):
2484         Rename inner deselectItems() to deselectItemsWithoutValidation().
2485         (WebCore::HTMLSelectElement::setSelectedIndex):
2486         Rename a callsite of another setSelectedIndex() to setSelectedIndexInternal().
2487         (WebCore::HTMLSelectElement::setSelectedIndexByUser):
2488         ditto, and update a callsite of updateSelectedState().
2489         (WebCore::HTMLSelectElement::listBoxSelectItem):
2490         Update a callsite of updateSelectedState().
2491         (WebCore::HTMLSelectElement::activeSelectionEndListIndex):
2492         Update a callsite of lastSelectedListIndex().
2493         (WebCore::HTMLSelectElement::selectAll):
2494         Update callsites of functions which are changed to non-static.
2495         (WebCore::HTMLSelectElement::saveLastSelection):
2496         Merge a static function and a non-static function.
2497         (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto.
2498         (WebCore::HTMLSelectElement::setActiveSelectionEndIndex): ditto.
2499         (WebCore::HTMLSelectElement::updateListBoxSelection): ditto.
2500         (WebCore::HTMLSelectElement::listBoxOnChange): ditto.
2501         (WebCore::HTMLSelectElement::menuListOnChange): ditto.
2502         (WebCore::HTMLSelectElement::scrollToSelection): ditto.
2503         (WebCore::HTMLSelectElement::setOptionsChangedOnRenderer): Made this non-static.
2504         (WebCore::HTMLSelectElement::setRecalcListItems):
2505         Merge a static function and a non-static function.
2506         (WebCore::HTMLSelectElement::selectedIndex): ditto.
2507         (WebCore::HTMLSelectElement::setSelectedIndexInternal):
2508         Made this non-static, and renamed from setSelectedIndex() because
2509         of conflict with an existing function.
2510         (WebCore::HTMLSelectElement::optionToListIndex):
2511         Merge a static function and a non-static function.
2512         (WebCore::HTMLSelectElement::listToOptionIndex): ditto.
2513         (WebCore::HTMLSelectElement::dispatchFocusEvent):
2514         Update a callsite of function which is changed to no-staic.
2515         (WebCore::HTMLSelectElement::dispatchBlurEvent): ditto.
2516         (WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
2517         Made this non-static, and renamed from deselectItems() to avoid conflict.
2518         (WebCore::HTMLSelectElement::restoreFormControlState):
2519         Update a callsite of function which is changed to no-staic.
2520         (WebCore::HTMLSelectElement::reset): ditto.
2521         (WebCore::HTMLSelectElement::platformHandleKeydownEvent): Made this non-static.
2522         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
2523         (WebCore::HTMLSelectElement::updateSelectedState): ditto.
2524         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
2525         (WebCore::HTMLSelectElement::defaultEventHandler):
2526         Merged a static function and a non-static function.
2527         (WebCore::HTMLSelectElement::lastSelectedListIndex): Made this non-static.
2528         (WebCore::HTMLSelectElement::typeAheadFind): ditto.
2529         (WebCore::HTMLSelectElement::accessKeySetSelectedIndex): ditto.
2530         * html/HTMLSelectElement.h:
2531         * html/HTMLSelectElementWin.cpp:
2532         (WebCore::HTMLSelectElement::platformHandleKeydownEvent): Made this non-static.
2533
2534 2011-10-09  Adam Barth  <abarth@webkit.org>
2535
2536         CSP should log unrecognized directives to the console
2537         https://bugs.webkit.org/show_bug.cgi?id=69728
2538
2539         Reviewed by Sam Weinig.
2540
2541         Several of the web developers who have been experimenting with CSP have
2542         run into trouble with directives we don't support.  For example, one
2543         developer was confused for a while why image-src didn't do what he
2544         expected.  Logging a message to the console will help these folks
2545         figure out what's going on.
2546
2547         * page/ContentSecurityPolicy.cpp:
2548         (WebCore::ContentSecurityPolicy::reportUnrecognizedDirective):
2549         (WebCore::ContentSecurityPolicy::addDirective):
2550         * page/ContentSecurityPolicy.h:
2551
2552 2011-10-09  W. James MacLean  <wjmaclean@chromium.org>
2553
2554         [chromium] Zoom animator front-end
2555         https://bugs.webkit.org/show_bug.cgi?id=68035
2556
2557         Adds necessary components to ScrollAnimatorNone to support a zoom animation
2558         feature. Includes test infrastructure via testing/Internals to capture
2559         in-progress texture scaling (zoom-animator-scale-test.html) as well as a
2560         final view --- after pageScaleFactor has been applied --- in zoom-animator-scale-test2.html.
2561
2562         Removes temporary test fields from Settings.
2563
2564         Reviewed by Kenneth Russell.
2565
2566         Test: platform/chromium/compositing/zoom-animator-scale-test2.html
2567
2568         * page/EventHandler.cpp:
2569         (WebCore::EventHandler::handleGestureEvent):
2570         * page/FrameView.cpp:
2571         (WebCore::FrameView::zoomAnimatorTransformChanged):
2572         * page/FrameView.h:
2573         * page/Settings.cpp:
2574         (WebCore::Settings::Settings):
2575         * page/Settings.h:
2576         * platform/ScrollAnimator.cpp:
2577         (WebCore::ScrollAnimator::ScrollAnimator):
2578         (WebCore::ScrollAnimator::notifyZoomChanged):
2579         (WebCore::ScrollAnimator::zoomTranslation):
2580         (WebCore::ScrollAnimator::resetZoom):
2581         (WebCore::ScrollAnimator::setZoomParametersForTest):
2582         * platform/ScrollAnimator.h:
2583         (WebCore::ScrollAnimator::zoomScale):
2584         * platform/ScrollAnimatorNone.cpp:
2585         (WebCore::ScrollAnimatorNone::ZoomData::ZoomData):
2586         (WebCore::ScrollAnimatorNone::ZoomData::animateZoom):
2587         (WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
2588         (WebCore::ScrollAnimatorNone::zoom):
2589         (WebCore::ScrollAnimatorNone::handleGestureEvent):
2590         (WebCore::ScrollAnimatorNone::animationTimerFired):
2591         * platform/ScrollAnimatorNone.h:
2592         * platform/ScrollableArea.cpp:
2593         (WebCore::ScrollableArea::zoomAnimatorTransformChanged):
2594         * platform/ScrollableArea.h:
2595         * testing/Internals.cpp:
2596         (WebCore::Internals::setEnableScrollAnimator):
2597         (WebCore::Internals::setZoomAnimatorTransform):
2598         (WebCore::Internals::getPageScaleFactor):
2599         (WebCore::Internals::setZoomParameters):
2600         * testing/Internals.h:
2601         * testing/Internals.idl:
2602
2603 2011-10-09  Dan Bernstein  <mitz@apple.com>
2604
2605         <rdar://problem/9484496> REGRESSION (WebKit2): Checkboxes and radio buttons are drawn 1 pixel too high, not repainted properly
2606         https://bugs.webkit.org/show_bug.cgi?id=69727
2607
2608         Reviewed by Anders Carlsson.
2609
2610         * platform/mac/ThemeMac.mm: Made WebCoreFlippedView an NSControl subclass so that the NSButtonCell
2611         used to draw checkboxes and radio buttons can make it its controlView, and consequently check and
2612         obey its flippedness.
2613
2614 2011-10-09  Benjamin Poulain  <benjamin@webkit.org>
2615
2616         Do not compare the first glyph to itself in Font::drawGlyphBuffer()
2617         https://bugs.webkit.org/show_bug.cgi?id=69715
2618
2619         Reviewed by Andreas Kling.
2620
2621         When looking for glyphs with similar properties, we should
2622         skip the first one since the comparison of fontData
2623         and offset will always fail.
2624
2625         This is covered by the existing tests.
2626
2627         * platform/graphics/FontFastPath.cpp:
2628         (WebCore::Font::drawGlyphBuffer):
2629
2630 2011-10-08  Justin Schuh  <jschuh@chromium.org>
2631
2632         Make ThreadGlobalData members use OwnPtr
2633         https://bugs.webkit.org/show_bug.cgi?id=69710
2634
2635         Reviewed by Adam Barth.
2636
2637         No functional changes. No new tests required.
2638
2639         * platform/ThreadGlobalData.cpp:
2640         (WebCore::ThreadGlobalData::ThreadGlobalData):
2641         (WebCore::ThreadGlobalData::~ThreadGlobalData):
2642         (WebCore::ThreadGlobalData::destroy):
2643         * platform/ThreadGlobalData.h:
2644
2645 2011-10-08  Mark Hahnenberg  <mhahnenberg@apple.com>
2646
2647         Add static version of JSCell::getConstructData
2648         https://bugs.webkit.org/show_bug.cgi?id=69673
2649
2650         Reviewed by Geoffrey Garen.
2651
2652         No new tests.
2653
2654         Added static version of getConstructData to all classes that
2655         override it and changed the virtual versions to call the static
2656         versions.  This is the first step in de-virtualizing JSCell::getConstructData.
2657
2658         * bindings/js/JSAudioConstructor.cpp:
2659         (WebCore::JSAudioConstructor::getConstructData):
2660         * bindings/js/JSAudioConstructor.h:
2661         * bindings/js/JSImageConstructor.cpp:
2662         (WebCore::JSImageConstructor::getConstructData):
2663         * bindings/js/JSImageConstructor.h:
2664         * bindings/js/JSOptionConstructor.cpp:
2665         (WebCore::JSOptionConstructor::getConstructData):
2666         * bindings/js/JSOptionConstructor.h:
2667         * bindings/scripts/CodeGeneratorJS.pm:
2668         (GenerateConstructorDeclaration):
2669         (GenerateConstructorDefinition):
2670         * bindings/scripts/test/JS/JSTestInterface.cpp:
2671         (WebCore::JSTestInterfaceConstructor::getConstructData):
2672         * bridge/runtime_object.cpp:
2673         (JSC::Bindings::RuntimeObject::getConstructData):
2674         * bridge/runtime_object.h:
2675
2676 2011-10-08  Mark Hahnenberg  <mhahnenberg@apple.com>
2677
2678         Add static version of JSCell::getOwnPropertySlot
2679         https://bugs.webkit.org/show_bug.cgi?id=69593
2680
2681         Reviewed by Geoffrey Garen.
2682
2683         No new tests.
2684
2685         Added static version of getOwnPropertySlot to every class that overrides
2686         JSCell::getOwnPropertySlot.  The virtual versions now call the static versions.
2687         This is the first step in de-virtualizing JSCell::getOwnPropertySlot.
2688
2689         * bindings/js/JSDOMWindowShell.cpp:
2690         (WebCore::JSDOMWindowShell::getOwnPropertySlot):
2691         * bindings/js/JSDOMWindowShell.h:
2692         * bridge/objc/objc_runtime.h:
2693         * bridge/objc/objc_runtime.mm:
2694         (JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertySlot):
2695         * bridge/qt/qt_runtime.cpp:
2696         (JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertySlot):
2697         (JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertySlot):
2698         * bridge/qt/qt_runtime.h:
2699         * bridge/runtime_array.cpp:
2700         (JSC::RuntimeArray::getOwnPropertySlot):
2701         * bridge/runtime_array.h:
2702         * bridge/runtime_method.cpp:
2703         (JSC::RuntimeMethod::getOwnPropertySlot):
2704         * bridge/runtime_method.h:
2705         * bridge/runtime_object.cpp:
2706         (JSC::Bindings::RuntimeObject::getOwnPropertySlot):
2707         * bridge/runtime_object.h:
2708
2709 2011-10-03  Carlos Garcia Campos  <cgarcia@igalia.com> and Martin Robinson  <mrobinson@igalia.com>
2710
2711         [GTK] Implement drag and drop support in WebKit2
2712         https://bugs.webkit.org/show_bug.cgi?id=63706
2713
2714         Reviewed by Philippe Normand.
2715
2716         * platform/DragData.h:
2717         * platform/gtk/DataObjectGtk.cpp:
2718         (WebCore::DataObjectGtk::text): Mark as const.
2719         (WebCore::DataObjectGtk::markup): Ditto.
2720         (WebCore::DataObjectGtk::urlLabel): Ditto.
2721         * platform/gtk/DataObjectGtk.h: Remove unused member
2722         m_dragContext.
2723         (WebCore::DataObjectGtk::url): Mark as const.
2724         (WebCore::DataObjectGtk::uriList): Ditto.
2725         (WebCore::DataObjectGtk::filenames): Ditto.
2726         (WebCore::DataObjectGtk::image): Ditto.
2727         (WebCore::DataObjectGtk::hasText): Ditto.
2728         (WebCore::DataObjectGtk::hasMarkup): Ditto.
2729         (WebCore::DataObjectGtk::hasURIList): Ditto.
2730         (WebCore::DataObjectGtk::hasURL): Ditto.
2731         (WebCore::DataObjectGtk::hasFilenames): Ditto.
2732         (WebCore::DataObjectGtk::hasImage): Ditto.
2733         * platform/gtk/DragIcon.cpp: Added. A helper which takes care of
2734         creating a transparent drag window for drags.
2735         * platform/gtk/DragIcon.h: Added.
2736
2737 2011-10-08  Abhishek Arya  <inferno@chromium.org>
2738
2739         Add support for ADDRESS_SANITIZER in RenderArena
2740         allocate, free calls.
2741         https://bugs.webkit.org/show_bug.cgi?id=69636
2742
2743         Reviewed by Darin Adler.
2744
2745         Use malloc, free directly without using the debug header. Otherwise,
2746         we won't be able to detect out of bounds access in debug header.
2747
2748         * rendering/RenderArena.cpp:
2749         (WebCore::RenderArena::allocate):
2750         (WebCore::RenderArena::free):
2751
2752 2011-10-08  Kent Tamura  <tkent@chromium.org>
2753
2754         Remove some static functions of HTMLSelectElement
2755         https://bugs.webkit.org/show_bug.cgi?id=69621
2756
2757         Reviewed by Darin Adler.
2758
2759         Merge a static function and the corresponding non-static member function
2760         into one function if there are no other callers of the static function.
2761
2762         No new tests, just a refactoring.
2763
2764         * html/HTMLFormControlElement.h:
2765         Make formControlName() protected because it is called from
2766         HTMLSelectElement.
2767         * html/HTMLSelectElement.cpp:
2768         (WebCore::HTMLSelectElement::parseMappedAttribute):
2769         Remove two argument of parseMultipleAttribute().
2770         (WebCore::HTMLSelectElement::selectAll):
2771         Merged the static function and the member function.
2772         (WebCore::HTMLSelectElement::dispatchFocusEvent): ditto.
2773         (WebCore::HTMLSelectElement::dispatchBlurEvent): ditto.
2774         (WebCore::HTMLSelectElement::saveFormControlState): ditto.
2775         (WebCore::HTMLSelectElement::restoreFormControlState):
2776         (WebCore::HTMLSelectElement::parseMultipleAttribute):
2777          - Make this non-static member function.
2778          - Use reattachIfAttached().
2779         (WebCore::HTMLSelectElement::appendFormData): Merged.
2780         (WebCore::HTMLSelectElement::reset): ditto.
2781         (WebCore::HTMLSelectElement::insertedIntoTree): ditto.
2782         (WebCore::HTMLSelectElement::accessKeySetSelectedIndex): ditto.
2783         (WebCore::HTMLSelectElement::length): Merged with optionCount().
2784         * html/HTMLSelectElement.h:
2785
2786 2011-10-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2787
2788         Unreviewed, rolling out r96996.
2789         http://trac.webkit.org/changeset/96996
2790         https://bugs.webkit.org/show_bug.cgi?id=69697
2791
2792         It broke all tests on the Qt bot (Requested by Ossy_night on
2793         #webkit).
2794
2795         * WebCore.exp.in:
2796         * bindings/js/JSCallbackData.cpp:
2797         (WebCore::JSCallbackData::invokeCallback):
2798         * bindings/js/JSCustomXPathNSResolver.cpp:
2799         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
2800         * bindings/js/JSErrorHandler.cpp:
2801         (WebCore::JSErrorHandler::handleEvent):
2802         * bindings/js/JSEventListener.cpp:
2803         (WebCore::JSEventListener::handleEvent):
2804         * bindings/js/JSHTMLAllCollectionCustom.cpp:
2805         (WebCore::JSHTMLAllCollection::getCallDataVirtual):
2806         * bindings/js/JSHTMLAppletElementCustom.cpp:
2807         (WebCore::JSHTMLAppletElement::getCallDataVirtual):
2808         * bindings/js/JSHTMLEmbedElementCustom.cpp:
2809         (WebCore::JSHTMLEmbedElement::getCallDataVirtual):
2810         * bindings/js/JSHTMLObjectElementCustom.cpp:
2811         (WebCore::JSHTMLObjectElement::getCallDataVirtual):
2812         * bindings/js/JSInjectedScriptHostCustom.cpp:
2813         (WebCore::JSInjectedScriptHost::evaluate):
2814         * bindings/js/JSPluginElementFunctions.cpp:
2815         (WebCore::runtimeObjectGetCallData):
2816         * bindings/scripts/CodeGeneratorJS.pm:
2817         (GenerateHeader):
2818         * bridge/objc/objc_runtime.h:
2819         * bridge/objc/objc_runtime.mm:
2820         (JSC::Bindings::ObjcFallbackObjectImp::getCallDataVirtual):
2821         * bridge/qt/qt_runtime.cpp:
2822         (JSC::Bindings::QtRuntimeMetaMethod::getCallDataVirtual):
2823         (JSC::Bindings::QtRuntimeConnectionMethod::call):
2824         (JSC::Bindings::QtRuntimeConnectionMethod::getCallDataVirtual):
2825         (JSC::Bindings::isJavaScriptFunction):
2826         * bridge/qt/qt_runtime.h:
2827         * bridge/runtime_method.cpp:
2828         (JSC::RuntimeMethod::getCallDataVirtual):
2829         * bridge/runtime_method.h:
2830         * bridge/runtime_object.cpp:
2831         (JSC::Bindings::RuntimeObject::getCallDataVirtual):
2832         * bridge/runtime_object.h:
2833
2834 2011-10-08  Ryosuke Niwa  <rniwa@webkit.org>
2835
2836         Snow Leopard build fix after r96976. Apparently we just need a full rebuild.
2837
2838         * config.h:
2839
2840 2011-10-07  Mark Hahnenberg  <mhahnenberg@apple.com>
2841
2842         Add static version of JSCell::deleteProperty
2843         https://bugs.webkit.org/show_bug.cgi?id=69659
2844
2845         Reviewed by Geoffrey Garen.
2846
2847         No new tests.
2848
2849         Added static version of both versions of put to all classes that
2850         override them and changed the virtual versions to call the static
2851         versions.  This is the first step in de-virtualizing JSCell::deleteProperty.
2852
2853         * bridge/objc/objc_runtime.h:
2854         * bridge/objc/objc_runtime.mm:
2855         (JSC::Bindings::ObjcFallbackObjectImp::deleteProperty):
2856         * bridge/runtime_array.cpp:
2857         (JSC::RuntimeArray::deleteProperty):
2858         * bridge/runtime_array.h:
2859         * bridge/runtime_object.cpp:
2860         (JSC::Bindings::RuntimeObject::deleteProperty):
2861         * bridge/runtime_object.h:
2862
2863 2011-10-07  Justin Schuh  <jschuh@chromium.org>
2864
2865         Make isXMLMIMEType regex use TLS
2866         https://bugs.webkit.org/show_bug.cgi?id=69665
2867
2868         Reviewed by Adam Barth.
2869
2870         Test: fast/workers/worker-multi-startup.html
2871
2872         * dom/DOMImplementation.cpp:
2873         (WebCore::XMLMIMETypeRegExp::XMLMIMETypeRegExp):
2874         (WebCore::XMLMIMETypeRegExp::~XMLMIMETypeRegExp):
2875         (WebCore::XMLMIMETypeRegExp::isXMLMIMEType):
2876         (WebCore::DOMImplementation::isXMLMIMEType):
2877         * dom/DOMImplementation.h:
2878         * platform/ThreadGlobalData.cpp:
2879         (WebCore::ThreadGlobalData::ThreadGlobalData):
2880         (WebCore::ThreadGlobalData::destroy):
2881         * platform/ThreadGlobalData.h:
2882         (WebCore::ThreadGlobalData::xmlTypeRegExp):
2883
2884 2011-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2885
2886         Unreviewed, rolling out r96847.
2887         http://trac.webkit.org/changeset/96847
2888         https://bugs.webkit.org/show_bug.cgi?id=69684
2889
2890         may have caused memory regression on win chromium (Requested
2891         by simonjam on #webkit).
2892
2893         * platform/graphics/chromium/FontChromiumWin.cpp:
2894         (WebCore::Font::drawGlyphs):
2895
2896 2011-10-07  Mark Hahnenberg  <mhahnenberg@apple.com>
2897
2898         Remove getCallDataVirtual methods
2899         https://bugs.webkit.org/show_bug.cgi?id=69186
2900
2901         Reviewed by Geoffrey Garen.
2902
2903         No new tests.
2904
2905         Removed all getCallDataVirtual methods and replaced their call sites
2906         with an explicit lookup in the MethodTable.
2907
2908         * WebCore.exp.in:
2909         * bindings/js/JSCallbackData.cpp:
2910         (WebCore::JSCallbackData::invokeCallback):
2911         * bindings/js/JSCustomXPathNSResolver.cpp:
2912         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
2913         * bindings/js/JSErrorHandler.cpp:
2914         (WebCore::JSErrorHandler::handleEvent):
2915         * bindings/js/JSEventListener.cpp:
2916         (WebCore::JSEventListener::handleEvent):
2917         * bindings/js/JSHTMLAllCollectionCustom.cpp:
2918         * bindings/js/JSHTMLAppletElementCustom.cpp:
2919         * bindings/js/JSHTMLEmbedElementCustom.cpp:
2920         * bindings/js/JSHTMLObjectElementCustom.cpp:
2921         * bindings/js/JSInjectedScriptHostCustom.cpp:
2922         (WebCore::JSInjectedScriptHost::evaluate):
2923         * bindings/js/JSPluginElementFunctions.cpp:
2924         (WebCore::runtimeObjectGetCallData):
2925         * bindings/scripts/CodeGeneratorJS.pm:
2926         (GenerateHeader):
2927         * bridge/objc/objc_runtime.h:
2928         * bridge/objc/objc_runtime.mm:
2929         * bridge/qt/qt_runtime.cpp:
2930         (JSC::Bindings::QtRuntimeConnectionMethod::call):
2931         (JSC::Bindings::isJavaScriptFunction):
2932         * bridge/qt/qt_runtime.h:
2933         (JSC::Bindings::QtRuntimeMetaMethod::createStructure):
2934         (JSC::Bindings::QtRuntimeConnectionMethod::createStructure):
2935         * bridge/runtime_method.cpp:
2936         * bridge/runtime_method.h:
2937         * bridge/runtime_object.cpp:
2938         * bridge/runtime_object.h:
2939
2940 2011-10-07  Mark Hahnenberg  <mhahnenberg@apple.com>
2941
2942         Add static version of JSCell::put
2943         https://bugs.webkit.org/show_bug.cgi?id=69382
2944
2945         Reviewed by Geoffrey Garen.
2946
2947         No new tests.
2948
2949         Added static version of both versions of put to all classes that
2950         override them and changed the virtual versions to call the static
2951         versions.
2952
2953         * bindings/scripts/CodeGeneratorJS.pm:
2954         (GenerateHeader):
2955         (GenerateImplementation):
2956         * bindings/scripts/test/JS/JSTestObj.cpp:
2957         (WebCore::JSTestObj::put):
2958         * bindings/scripts/test/JS/JSTestObj.h:
2959         * bridge/objc/objc_runtime.h:
2960         * bridge/objc/objc_runtime.mm:
2961         (JSC::Bindings::ObjcFallbackObjectImp::put):
2962         * bridge/runtime_array.cpp:
2963         (JSC::RuntimeArray::put):
2964         * bridge/runtime_array.h:
2965         * bridge/runtime_object.cpp:
2966         (JSC::Bindings::RuntimeObject::put):
2967         * bridge/runtime_object.h:
2968
2969 2011-10-07  Anantanarayanan G Iyengar  <ananta@chromium.org>
2970
2971          https://bugs.webkit.org/show_bug.cgi?id=69471
2972
2973          We now wrap the window script NPObject which is requested by NPAPI plugins for
2974          scripting. The wrapped NPObject pointer maintains a weak reference to the
2975          window script NPObject and is cleared out when the window script object is destroyed.
2976          The NPObject wrapper is destroyed when the last outstanding reference is released.
2977
2978          Reviewed by Nate Chapin.
2979
2980          No tests added as there is no change in functionality.
2981
2982         * WebCore.gypi:
2983         * bindings/v8/NPObjectWrapper.cpp: Added.
2984         (WebCore::NPObjectWrapper::NPObjectWrapper):
2985         (WebCore::NPObjectWrapper::create):
2986         (WebCore::NPObjectWrapper::clear):
2987         (WebCore::NPObjectWrapper::getWrapper):
2988         (WebCore::NPObjectWrapper::getUnderlyingNPObject):
2989         (WebCore::NPObjectWrapper::getObjectForCall):
2990         (WebCore::NPObjectWrapper::NPAllocate):
2991         (WebCore::NPObjectWrapper::NPDeallocate):
2992         (WebCore::NPObjectWrapper::NPPInvalidate):
2993         (WebCore::NPObjectWrapper::NPHasMethod):
2994         (WebCore::NPObjectWrapper::NPInvoke):
2995         (WebCore::NPObjectWrapper::NPInvokeDefault):
2996         (WebCore::NPObjectWrapper::NPHasProperty):
2997         (WebCore::NPObjectWrapper::NPGetProperty):
2998         (WebCore::NPObjectWrapper::NPSetProperty):
2999         (WebCore::NPObjectWrapper::NPRemoveProperty):
3000         (WebCore::NPObjectWrapper::NPNEnumerate):
3001         (WebCore::NPObjectWrapper::NPNConstruct):
3002         (WebCore::NPObjectWrapper::NPInvokePrivate):
3003         * bindings/v8/NPObjectWrapper.h: Added.
3004         * bindings/v8/NPV8Object.cpp:
3005         (_NPN_EvaluateHelper):
3006         * bindings/v8/ScriptController.cpp:
3007         (WebCore::ScriptController::ScriptController):
3008         (WebCore::ScriptController::clearScriptObjects):
3009         (WebCore::ScriptController::windowScriptNPObject):
3010         * bindings/v8/ScriptController.h:
3011
3012 2011-10-07  Antoine Labour  <piman@chromium.org>
3013
3014         Webkit API for compositor
3015         https://bugs.webkit.org/show_bug.cgi?id=69107
3016
3017         Reviewed by Darin Fisher.
3018
3019         Covered by existing compositing tests.
3020
3021         * platform/graphics/chromium/ContentLayerChromium.h:
3022
3023 2011-10-07  Ben Wells  <benwells@chromium.org>
3024
3025         CSS text-transform should apply to select elements
3026         https://bugs.webkit.org/show_bug.cgi?id=69503
3027
3028         Reviewed by Ojan Vafai.
3029
3030         Select elements are drawn in two ways depending on whether they are multiple and what their size is.
3031         Neither method previously handled text-transforms. Both of these rendering styles are now updated to transform
3032         their text correctly.
3033
3034         Test: fast/css/text-transform-select.html
3035
3036         * rendering/RenderListBox.cpp:
3037         (WebCore::RenderListBox::updateFromElement):
3038         (WebCore::RenderListBox::paintItemForeground):
3039         * rendering/RenderMenuList.cpp:
3040         (WebCore::RenderMenuList::updateOptionsWidth):
3041         (WebCore::RenderMenuList::setText):
3042         (WebCore::RenderMenuList::itemText):
3043         * rendering/RenderText.cpp:
3044         (WebCore::makeCapitalized):
3045         (WebCore::applyTextTransform):
3046         (WebCore::RenderText::setTextInternal):
3047         (WebCore::RenderText::textWithoutTranscoding):
3048         * rendering/RenderText.h:
3049
3050 2011-10-07  Tony Chang  <tony@chromium.org>
3051
3052         fix a crash when loading non-html multipart data
3053         https://bugs.webkit.org/show_bug.cgi?id=69675
3054
3055         Reviewed by Adam Barth.
3056
3057         setupForReplaceByMIMEType calls DocumentWriter::end().  This leads to
3058         a crash on Mac because WebHTMLRepresentation() calls commitLoad(nil),
3059         which tries to write to the DocumentWriter.  By just inlining the code
3060         to load the last page, we avoid this crash (and makes the non-html
3061         multipart code more like the html multipart code).
3062
3063         * loader/DocumentLoader.cpp:
3064         (WebCore::DocumentLoader::maybeFinishLoadingMultipartContent):
3065
3066 2011-10-07  Sergey Glazunov  <serg.glazunov@gmail.com>
3067
3068         XSLT-generated document should inherit its SecurityOrigin from the source document
3069         https://bugs.webkit.org/show_bug.cgi?id=69661
3070
3071         Reviewed by Adam Barth.
3072
3073         Test: http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml
3074
3075         * xml/XSLTProcessor.cpp:
3076         (WebCore::XSLTProcessor::createDocumentFromSource):
3077
3078 2011-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3079
3080         Unreviewed, rolling out r96944.
3081         http://trac.webkit.org/changeset/96944
3082         https://bugs.webkit.org/show_bug.cgi?id=69662
3083
3084         Caused many tests to crash on Snow Leopard (Requested by rniwa
3085         on #webkit).
3086
3087         * css/CSSStyleApplyProperty.cpp:
3088         (WebCore::ApplyPropertyColor::applyInheritValue):
3089         * page/animation/AnimationBase.cpp:
3090         (WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
3091         (WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
3092         (WebCore::AnimationBase::ensurePropertyMap):
3093         * platform/graphics/Color.h:
3094         (WebCore::Color::Color):
3095         * rendering/style/BorderValue.h:
3096         (WebCore::BorderValue::BorderValue):
3097         (WebCore::BorderValue::isTransparent):
3098         (WebCore::BorderValue::operator==):
3099         (WebCore::BorderValue::color):
3100         * rendering/style/OutlineValue.h:
3101         (WebCore::OutlineValue::operator==):
3102         * rendering/style/RenderStyle.h:
3103         (WebCore::InheritedFlags::setBorderLeftColor):
3104         (WebCore::InheritedFlags::setBorderRightColor):
3105         (WebCore::InheritedFlags::setBorderTopColor):
3106         (WebCore::InheritedFlags::setBorderBottomColor):
3107         (WebCore::InheritedFlags::setOutlineColor):
3108         (WebCore::InheritedFlags::setColumnRuleColor):
3109         (WebCore::InheritedFlags::fillPaintColor):
3110         (WebCore::InheritedFlags::strokePaintColor):
3111         (WebCore::InheritedFlags::borderLeftColor):
3112         (WebCore::InheritedFlags::borderRightColor):
3113         (WebCore::InheritedFlags::borderTopColor):
3114         (WebCore::InheritedFlags::borderBottomColor):
3115         (WebCore::InheritedFlags::backgroundColor):
3116         (WebCore::InheritedFlags::color):
3117         (WebCore::InheritedFlags::columnRuleColor):
3118         (WebCore::InheritedFlags::outlineColor):
3119         (WebCore::InheritedFlags::textEmphasisColor):
3120         (WebCore::InheritedFlags::textFillColor):
3121         (WebCore::InheritedFlags::textStrokeColor):
3122         (WebCore::InheritedFlags::stopColor):
3123         (WebCore::InheritedFlags::floodColor):
3124         (WebCore::InheritedFlags::lightingColor):
3125
3126 2011-10-07  David Hyatt  <hyatt@apple.com>
3127
3128         https://bugs.webkit.org/show_bug.cgi?id=69658
3129
3130         [CSS3 Regions] Box painting of overflow into regions is incorrect because children were being
3131         incorrectly clamped to their containing block region ranges. Change the clamping model so that
3132         renderRegionForLine no longer does it. A block will now truly have an accurate range across
3133         all the regions that paint it. Instead, do the clamping at the time a child box asks the containing
3134         block for its information. At that time clamp to the start and end regions, so that we never ask
3135         a containing block for info about a region that it doesn't exist in.
3136
3137         Reviewed by Anders Carlsson.
3138
3139         Added new test in fast/regions and updated an old result to be correct.
3140
3141         * rendering/RenderBlock.cpp:
3142         (WebCore::RenderBlock::pageLogicalHeightForOffset):
3143         (WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
3144         (WebCore::RenderBlock::regionAtBlockOffset):
3145         (WebCore::RenderBlock::clampToStartAndEndRegions):
3146         * rendering/RenderBlock.h:
3147         * rendering/RenderBox.cpp:
3148         (WebCore::RenderBox::borderBoxRectInRegion):
3149         (WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
3150         (WebCore::RenderBox::renderBoxRegionInfo):
3151         * rendering/RenderFlowThread.cpp:
3152         (WebCore::RenderFlowThread::renderRegionForLine):
3153         (WebCore::RenderFlowThread::regionLogicalWidthForLine):
3154         (WebCore::RenderFlowThread::regionLogicalHeightForLine):
3155         (WebCore::RenderFlowThread::regionRemainingLogicalHeightForLine):
3156         (WebCore::RenderFlowThread::mapFromFlowToRegion):
3157         (WebCore::RenderFlowThread::setRegionRangeForBox):
3158         * rendering/RenderFlowThread.h:
3159
3160 2011-10-07  Chang Shu  <cshu@webkit.org>
3161
3162         Remove compile time flag ENABLE_PASSWORD_ECHO
3163         https://bugs.webkit.org/show_bug.cgi?id=69647
3164
3165         As we have runtime flag in the page/Settings, we should remove this redundant compile time flag.
3166
3167         Reviewed by Andreas Kling.
3168
3169         * config.h:
3170         * page/Settings.cpp:
3171         (WebCore::Settings::Settings):
3172
3173 2011-10-07  Chris Fleizach  <cfleizach@apple.com>
3174
3175         Bug 69562 - AccessibilityImageMapLink holds onto it's parent even after it's been freed
3176         https://bugs.webkit.org/show_bug.cgi?id=69562
3177
3178         Some fake objects, like AXImageMapLink, have weak references to their parent's (since they are fake objects and
3179         need some connection to the parent). However, if the parent disappears before the child, then we're left with a
3180         out of date reference to that parent.
3181
3182         The fix is to allow these elements to clear their parentage when the parent goes away.
3183
3184         Reviewed by Darin Adler.
3185
3186         Test: accessibility/image-map-update-parent-crash.html
3187
3188         * accessibility/AccessibilityMenuListOption.cpp:
3189         (WebCore::AccessibilityMenuListOption::isVisible):
3190         * accessibility/AccessibilityMenuListPopup.cpp:
3191         (WebCore::AccessibilityMenuListPopup::isOffScreen):
3192         (WebCore::AccessibilityMenuListPopup::isEnabled):
3193         (WebCore::AccessibilityMenuListPopup::press):
3194         (WebCore::AccessibilityMenuListPopup::addChildren):
3195         (WebCore::AccessibilityMenuListPopup::childrenChanged):
3196         * accessibility/AccessibilityMockObject.h:
3197         (WebCore::AccessibilityMockObject::detachFromParent):
3198         * accessibility/AccessibilityObject.cpp:
3199         (WebCore::AccessibilityObject::clearChildren):
3200         * accessibility/AccessibilityObject.h:
3201         (WebCore::AccessibilityObject::detachFromParent):
3202         * accessibility/AccessibilitySlider.cpp:
3203         (WebCore::AccessibilitySliderThumb::elementRect):
3204         * accessibility/AccessibilityTableColumn.cpp:
3205         (WebCore::AccessibilityTableColumn::headerObjectForSection):
3206
3207 2011-10-07  Andreas Kling  <kling@webkit.org>
3208
3209         Pack StyleRareNonInheritedData even harder on 64-bit.
3210         https://bugs.webkit.org/show_bug.cgi?id=69648
3211
3212         Reviewed by Benjamin Poulain.
3213
3214         Rearrange the members of StyleRareNonInheritedData to fold as much
3215         as possible into the padding at the end of RefCounted.
3216
3217         This shrinks StyleRareNonInheritedData by 16 bytes on 64-bit,
3218         reducing memory consumption by another 140 kB when loading the
3219         full HTML5 spec.
3220
3221         * rendering/style/StyleRareNonInheritedData.cpp:
3222         (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
3223         * rendering/style/StyleRareNonInheritedData.h:
3224
3225 2011-10-07  Cary Clark  <caryclark@google.com>
3226
3227         Enable color profiles, unless profile is grayscale
3228         https://bugs.webkit.org/show_bug.cgi?id=69622
3229         https://bugs.webkit.org/show_bug.cgi?id=49950
3230         http://code.google.com/p/chromium/issues/detail?id=80844
3231
3232         Further specialize the earlier fix described in 49950 to
3233         allow color profiles in YCbCr images, but disallow color
3234         profiles marked as grayData.
3235         (see http://www.color.org/ICC1v42_2006-05.pdf 7.2.6 )
3236
3237         Reviewed by Adam Barth.
3238
3239         Test: fast/images/gray-scale-jpeg-with-color-profile.html
3240               fast/images/color-jpeg-with-color-profile.html
3241
3242         * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
3243         (WebCore::readColorProfile):
3244         (WebCore::JPEGImageReader::decode):
3245
3246 2011-10-07  Chris Fleizach  <cfleizach@apple.com>
3247
3248         AX: re-organize fake elements to use new AccessibilityMockObject
3249         https://bugs.webkit.org/show_bug.cgi?id=69588
3250
3251         This adds an AccessibilityMockObject for "fake" elements to descend from.
3252         Its benefit is to consolidate the various ways that these fake elements are setting
3253         and returning their parent objects.
3254
3255         No functional change, hence no new tests.
3256
3257         Reviewed by Jon Honeycutt.
3258
3259         * CMakeLists.txt:
3260         * GNUmakefile.list.am:
3261         * WebCore.gypi:
3262         * WebCore.pro:
3263         * WebCore.vcproj/WebCore.vcproj:
3264         * WebCore.xcodeproj/project.pbxproj:
3265         * accessibility/AccessibilityARIAGrid.cpp:
3266         (WebCore::AccessibilityARIAGrid::addChildren):
3267         * accessibility/AccessibilityImageMapLink.cpp:
3268         (WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):
3269         * accessibility/AccessibilityImageMapLink.h:
3270         (WebCore::AccessibilityImageMapLink::node):
3271         * accessibility/AccessibilityMenuList.cpp:
3272         (WebCore::AccessibilityMenuList::addChildren):
3273         * accessibility/AccessibilityMenuList.h:
3274         (WebCore::toAccessibilityMenuList):
3275         * accessibility/AccessibilityMenuListOption.cpp:
3276         (WebCore::AccessibilityMenuListOption::AccessibilityMenuListOption):
3277         (WebCore::AccessibilityMenuListOption::isVisible):
3278         * accessibility/AccessibilityMenuListOption.h:
3279         * accessibility/AccessibilityMenuListPopup.cpp:
3280         (WebCore::AccessibilityMenuListPopup::AccessibilityMenuListPopup):
3281         (WebCore::AccessibilityMenuListPopup::isOffScreen):
3282         (WebCore::AccessibilityMenuListPopup::isEnabled):
3283         (WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):
3284         (WebCore::AccessibilityMenuListPopup::press):
3285         (WebCore::AccessibilityMenuListPopup::addChildren):
3286         (WebCore::AccessibilityMenuListPopup::childrenChanged):
3287         (WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
3288         * accessibility/AccessibilityMenuListPopup.h:
3289         * accessibility/AccessibilityMockObject.cpp: Added.
3290         (WebCore::AccessibilityMockObject::AccessibilityMockObject):
3291         (WebCore::AccessibilityMockObject::~AccessibilityMockObject):
3292         * accessibility/AccessibilityMockObject.h: Added.
3293         (WebCore::AccessibilityMockObject::parentObject):
3294         (WebCore::AccessibilityMockObject::setParent):
3295         (WebCore::AccessibilityMockObject::detachFromParent):
3296         * accessibility/AccessibilitySlider.cpp:
3297         (WebCore::AccessibilitySlider::addChildren):
3298         (WebCore::AccessibilitySliderThumb::AccessibilitySliderThumb):
3299         (WebCore::AccessibilitySliderThumb::elementRect):
3300         * accessibility/AccessibilitySlider.h:
3301         * accessibility/AccessibilityTable.cpp:
3302         (WebCore::AccessibilityTable::addChildren):
3303         (WebCore::AccessibilityTable::headerContainer):
3304         * accessibility/AccessibilityTable.h:
3305         (WebCore::toAccessibilityTable):
3306         * accessibility/AccessibilityTableColumn.cpp:
3307         (WebCore::AccessibilityTableColumn::AccessibilityTableColumn):
3308         (WebCore::AccessibilityTableColumn::setParent):
3309         (WebCore::AccessibilityTableColumn::headerObject):
3310         (WebCore::AccessibilityTableColumn::headerObjectForSection):
3311         (WebCore::AccessibilityTableColumn::accessibilityIsIgnored):
3312         (WebCore::AccessibilityTableColumn::addChildren):
3313         * accessibility/AccessibilityTableColumn.h:
3314         * accessibility/AccessibilityTableHeaderContainer.cpp:
3315         (WebCore::AccessibilityTableHeaderContainer::AccessibilityTableHeaderContainer):
3316         (WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):
3317         (WebCore::AccessibilityTableHeaderContainer::addChildren):
3318         * accessibility/AccessibilityTableHeaderContainer.h:
3319
3320 2011-10-07  Nate Chapin  <japhet@chromium.org>
3321
3322         Make IconLoader a CachedResourceClient instead of a SubresourceLoaderClient.
3323         This is one of the steps required to remove the SubresourceLoaderClient interface,
3324         which will simplify the layering in the loader.
3325         https://bugs.webkit.org/show_bug.cgi?id=69567
3326
3327         Reviewed by Adam Barth.
3328
3329         No new tests, no functionality change intended.
3330
3331         * CMakeLists.txt:
3332         * GNUmakefile.list.am:
3333         * WebCore.gypi:
3334         * WebCore.pro:
3335         * WebCore.vcproj/WebCore.vcproj:
3336         * WebCore.xcodeproj/project.pbxproj:
3337         * loader/cache/CachedRawResource.cpp: Added.
3338         * loader/cache/CachedRawResource.h: Added.
3339         * loader/cache/CachedResource.cpp:
3340         * loader/cache/CachedResource.h:
3341         (WebCore::CachedResource::ignoreForRequestCount): Renamed and generalized from isLinkResource(),
3342             which was only used to decided whether the CachedResource should count toward
3343             CachedResourceLoader::requestCount().
3344         * loader/cache/CachedResourceLoader.cpp:
3345         * loader/cache/CachedResourceLoader.h:
3346         * loader/cache/CachedResourceRequest.cpp:
3347         * loader/cache/CachedResourceRequest.h:
3348         * loader/icon/IconLoader.cpp: Get a CachedResource instead of a SubresourceLoader.
3349         (WebCore::IconLoader::notifyFinished): Merge in the status code check that was in didReceiveResponse(),
3350             since we won't be checking any callbacks before the load completes.
3351         * loader/icon/IconLoader.h:
3352
3353 2011-10-07  Adam Bergkvist  <adam.bergkvist@ericsson.com>
3354
3355         Add WebCore platform interfaces needed by updated PeerConnection design
3356         https://bugs.webkit.org/show_bug.cgi?id=68460
3357
3358         Reviewed by Adam Barth.
3359
3360         Added the PeerConnection platform files to WebCore/platform/mediastream
3361
3362         Currently not testable.
3363
3364         * GNUmakefile.am:
3365         * GNUmakefile.list.am:
3366         * WebCore.gyp/WebCore.gyp:
3367         * WebCore.gypi:
3368         * platform/mediastream/MediaStreamComponent.h: Added.
3369         (WebCore::MediaStreamComponent::create):
3370         (WebCore::MediaStreamComponent::source):
3371         (WebCore::MediaStreamComponent::enabled):
3372         (WebCore::MediaStreamComponent::setEnabled):
3373         (WebCore::MediaStreamComponent::MediaStreamComponent):
3374         * platform/mediastream/MediaStreamDescriptor.h: Added.
3375         (WebCore::MediaStreamDescriptor::create):
3376         (WebCore::MediaStreamDescriptor::owner):
3377         (WebCore::MediaStreamDescriptor::setOwner):
3378         (WebCore::MediaStreamDescriptor::label):
3379         (WebCore::MediaStreamDescriptor::component):
3380         (WebCore::MediaStreamDescriptor::numberOfComponents):
3381         (WebCore::MediaStreamDescriptor::ended):
3382         (WebCore::MediaStreamDescriptor::setEnded):
3383         (WebCore::MediaStreamDescriptor::MediaStreamDescriptor):
3384         * platform/mediastream/MediaStreamSource.h: Added.
3385         (WebCore::MediaStreamSource::create):
3386         (WebCore::MediaStreamSource::id):
3387         (WebCore::MediaStreamSource::type):
3388         (WebCore::MediaStreamSource::name):
3389         (WebCore::MediaStreamSource::muted):
3390         (WebCore::MediaStreamSource::setMuted):
3391         (WebCore::MediaStreamSource::MediaStreamSource):
3392         * platform/mediastream/PeerHandler.cpp: Added.
3393         (WebCore::PeerHandler::PeerHandler):
3394         (WebCore::PeerHandler::~PeerHandler):
3395         (WebCore::PeerHandler::produceInitialOffer):
3396         (WebCore::PeerHandler::handleInitialOffer):
3397         (WebCore::PeerHandler::processSDP):
3398         (WebCore::PeerHandler::processPendingStreams):
3399         (WebCore::PeerHandler::sendDataStreamMessage):
3400         (WebCore::PeerHandler::stop):
3401         * platform/mediastream/PeerHandler.h: Added.
3402         (WebCore::PeerHandlerClient::~PeerHandlerClient):
3403         (WebCore::PeerHandler::create):
3404
3405 2011-10-07  Vineet Chaudary  <vineet.chaudhary@motorola.com>
3406
3407         background-color affects the font color in disabled textarea.
3408         https://bugs.webkit.org/show_bug.cgi?id=65361
3409
3410         Reviewed by Darin Adler.
3411
3412         For the transparent/translucent background colors use lightening fortext color.
3413
3414         * rendering/RenderTextControl.cpp:
3415         (WebCore::disabledTextColor):
3416
3417 2011-10-07  David Barr  <davidbarr@chromium.org>
3418
3419         Implement currentColor support for box-shadow and text-shadow
3420         https://bugs.webkit.org/show_bug.cgi?id=68218
3421
3422         Reviewed by Simon Fraser.
3423
3424         Test: fast/box-shadow/box-shadow-currentcolor.html
3425
3426         * css/CSSParser.cpp:
3427         (WebCore::CSSParser::parseShadow): Add CSSValueCurrentcolor to supported keywords.
3428
3429 2011-10-07  Pavel Feldman  <pfeldman@google.com>
3430
3431         Web Inspector: add Audits panel to the compilation.
3432         https://bugs.webkit.org/show_bug.cgi?id=69633
3433
3434         Reviewed by Yury Semikhatsky.
3435
3436         * inspector/compile-front-end.sh:
3437         * inspector/front-end/AuditCategories.js:
3438         * inspector/front-end/AuditLauncherView.js:
3439         * inspector/front-end/AuditResultView.js:
3440         * inspector/front-end/AuditRules.js:
3441         (WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
3442         (WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
3443         (WebInspector.AuditRules.CacheControlRule.prototype.handleNonCacheableResources):
3444         * inspector/front-end/AuditsPanel.js:
3445         (WebInspector.AuditsPanel):
3446         * inspector/front-end/NetworkLog.js:
3447         * inspector/front-end/treeoutline.js:
3448
3449 2011-10-07  Andreas Kling  <kling@webkit.org>
3450
3451         Functions that return "const Color" should simply return "Color".
3452
3453         Rubber-stamped by Antti Koivisto.
3454
3455         * rendering/RenderLayerBacking.cpp:
3456         (WebCore::RenderLayerBacking::rendererBackgroundColor):
3457         * rendering/RenderLayerBacking.h:
3458         * rendering/RenderTable.h:
3459         (WebCore::RenderTable::bgColor):
3460         * rendering/style/RenderStyle.cpp:
3461         (WebCore::RenderStyle::colorIncludingFallback):
3462         (WebCore::RenderStyle::visitedDependentColor):
3463         * rendering/style/RenderStyle.h:
3464
3465 2011-10-07  Pavel Feldman  <pfeldman@google.com>
3466
3467         Web Inspector: TypeError: Cannot read property 'styleSheetId' of undefined in tests.
3468         https://bugs.webkit.org/show_bug.cgi?id=69634
3469
3470         Reviewed by Yury Semikhatsky.
3471
3472         * inspector/front-end/CSSStyleModel.js:
3473         (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):
3474
3475 2011-10-06  Andreas Kling  <kling@webkit.org>
3476
3477         Shrink BorderValue.
3478         https://bugs.webkit.org/show_bug.cgi?id=69521
3479
3480         Reviewed by Antti Koivisto.
3481
3482         Unroll BorderValue's Color member so we can pack the color's validity flag
3483         in BorderValue's bitfield.
3484
3485         This shrinks BorderValue by 32 bit, which in turn shrinks BorderData by
3486         16 bytes. This reduces memory consumption by 760 kB when loading the full
3487         HTML5 spec.
3488
3489         * platform/graphics/Color.h:
3490         (WebCore::Color::Color):
3491
3492             Allow construction of Color objects with specific validity.
3493
3494         * rendering/style/BorderValue.h:
3495         (WebCore::BorderValue::BorderValue):
3496         (WebCore::BorderValue::isTransparent):
3497         (WebCore::BorderValue::operator==):
3498         (WebCore::BorderValue::setColor):
3499         (WebCore::BorderValue::color):
3500         * rendering/style/OutlineValue.h:
3501         (WebCore::OutlineValue::operator==):
3502
3503             Unroll m_color into BorderValue by splitting it into an RGBA32 and a bool.
3504             Made those variables private and added color(), setColor() accessors.
3505
3506         * rendering/style/RenderStyle.h:
3507         (WebCore::InheritedFlags::setBorderLeftColor):
3508         (WebCore::InheritedFlags::setBorderRightColor):
3509         (WebCore::InheritedFlags::setBorderTopColor):
3510         (WebCore::InheritedFlags::setBorderBottomColor):
3511         (WebCore::InheritedFlags::setOutlineColor):
3512         (WebCore::InheritedFlags::setColumnRuleColor):
3513
3514             Added a SET_BORDERVALUE_COLOR macro and use that instead of SET_VAR
3515             when setting BorderValue colors.
3516
3517         (WebCore::InheritedFlags::fillPaintColor):
3518         (WebCore::InheritedFlags::strokePaintColor):
3519         (WebCore::InheritedFlags::borderLeftColor):
3520         (WebCore::InheritedFlags::borderRightColor):
3521         (WebCore::InheritedFlags::borderTopColor):
3522         (WebCore::InheritedFlags::borderBottomColor):
3523         (WebCore::InheritedFlags::backgroundColor):
3524         (WebCore::InheritedFlags::color):
3525         (WebCore::InheritedFlags::columnRuleColor):
3526         (WebCore::InheritedFlags::outlineColor):
3527         (WebCore::InheritedFlags::textEmphasisColor):
3528         (WebCore::InheritedFlags::textFillColor):
3529         (WebCore::InheritedFlags::textStrokeColor):
3530         (WebCore::InheritedFlags::stopColor):
3531         (WebCore::InheritedFlags::floodColor):
3532         (WebCore::InheritedFlags::lightingColor):
3533
3534             Made color getters return "Color" instead of "const Color&" since
3535             BorderValue no longer has an actual object to return the reference to.
3536
3537         * css/CSSStyleApplyProperty.cpp:
3538         (WebCore::ApplyPropertyColor::applyInheritValue):
3539         * page/animation/AnimationBase.cpp:
3540         (WebCore::PropertyWrapperColor::PropertyWrapperColor):
3541         (WebCore::PropertyWrapperColor::blend):
3542         (WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
3543         (WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
3544         (WebCore::AnimationBase::ensurePropertyMap):
3545
3546             Adapt to RenderStyle color getters now returning "Color" instead of
3547             "const Color&".
3548
3549 2011-10-07  Philippe Normand  <pnormand@igalia.com>
3550
3551         [GStreamer] webkitwebsrc: avoid GST_BOILERPLATE_FULL
3552         https://bugs.webkit.org/show_bug.cgi?id=69630
3553
3554         Reviewed by Martin Robinson.
3555
3556         Use G_DEFINE_TYPE_WITH_CODE instead of GST_BOILERPLATE_FULL and
3557         replace use of gst_ghost_pad_new_no_target_from_template() and
3558         gst_ghost_pad_set_target() with a single call to
3559         gst_ghost_pad_new_from_template(). These changes keep the element
3560         compatible with GStreamer 0.10 while preparing the port to 0.11.
3561
3562         * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
3563         (webkit_web_src_class_init):
3564         (webkit_web_src_init):
3565
3566 2011-10-07  Martin Robinson  <mrobinson@igalia.com>
3567
3568         [Freetype] Pseudo-italics do not work
3569         https://bugs.webkit.org/show_bug.cgi?id=40856
3570
3571         Reviewed by Philippe Normand.
3572
3573         * platform/graphics/freetype/FontPlatformData.h: Add the font description as an argument initializeWithFontFace.
3574         * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
3575         (WebCore::FontPlatformData::FontPlatformData): Pass the font description to initializeWithFontFace.
3576         (WebCore::FontPlatformData::initializeWithFontFace): If we were asked for an italic font and we were
3577         given one that wasn't oblique or italic, activate the synthetic oblique bit.
3578
3579 2011-10-07  Philippe Normand  <pnormand@igalia.com>
3580
3581         [GStreamer] avoid direct access to GstMessage structure field
3582         https://bugs.webkit.org/show_bug.cgi?id=69629
3583
3584         Reviewed by Martin Robinson.
3585
3586         Use gst_message_get_structure() instead of direct access to the
3587         structure field. No direct benefit apart from compatibility with
3588         GStreamer 0.11.
3589
3590         * platform/graphics/gstreamer/GStreamerGWorld.cpp:
3591         (WebCore::gstGWorldSyncMessageCallback):
3592         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
3593         (WebCore::MediaPlayerPrivateGStreamer::handleMessage):
3594         (WebCore::MediaPlayerPrivateGStreamer::mediaLocationChanged):
3595
3596 2011-10-07  Pavel Feldman  <pfeldman@google.com>
3597
3598         Web Inspector: add timeline panel to the compilation.
3599         https://bugs.webkit.org/show_bug.cgi?id=69628
3600
3601         Reviewed by Yury Semikhatsky.
3602
3603         * inspector/compile-front-end.sh:
3604         * inspector/front-end/SidebarTreeElement.js:
3605         (WebInspector.SidebarTreeElement):
3606         * inspector/front-end/SourceCSSTokenizer.js:
3607         (WebInspector.SourceCSSTokenizer.prototype.nextToken):
3608         * inspector/front-end/SourceCSSTokenizer.re2js:
3609         * inspector/front-end/SourceHTMLTokenizer.js:
3610         (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
3611         * inspector/front-end/SourceHTMLTokenizer.re2js:
3612         * inspector/front-end/SourceJavaScriptTokenizer.js:
3613         (WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):
3614         * inspector/front-end/SourceJavaScriptTokenizer.re2js:
3615         * inspector/front-end/TimelineGrid.js:
3616         * inspector/front-end/TimelineOverviewPane.js:
3617         (WebInspector.TimelineOverviewPane.prototype._createTimelineCategoryStatusBarCheckbox):
3618         * inspector/front-end/TimelinePanel.js:
3619         (WebInspector.TimelinePanel.prototype._createEventDivider):
3620         (WebInspector.TimelinePanel.prototype._addRecordToTimeline):
3621         (WebInspector.TimelinePanel.prototype._findParentRecord):
3622         (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
3623         (WebInspector.TimelinePanel.prototype.updateMainViewWidth):
3624         (WebInspector.TimelinePanel.prototype.onResize):
3625         (WebInspector.TimelinePanel.prototype._windowChanged):
3626         (WebInspector.TimelinePanel.prototype._refreshRecords):
3627         (WebInspector.TimelineRecordGraphRow.prototype._onClick):
3628         (WebInspector.TimelinePanel.FormattedRecord):
3629         (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
3630         (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
3631
3632 2011-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3633
3634         Unreviewed, rolling out r96892.
3635         http://trac.webkit.org/changeset/96892
3636         https://bugs.webkit.org/show_bug.cgi?id=69626
3637
3638         it broke windows canary bots (Requested by podivilov on
3639         #webkit).
3640
3641         * WebCore.gyp/scripts/rule_binding.py:
3642
3643 2011-10-07  Andreas Kling  <kling@webkit.org>
3644
3645         Shrink StyleInheritedData.
3646         https://bugs.webkit.org/show_bug.cgi?id=69625
3647
3648         Reviewed by Antti Koivisto.
3649
3650         Rearrange the members of StyleInheritedData to fold as much
3651         as possible into the padding at the end of RefCounted.
3652
3653         This shrinks StyleInheritedData by 8 bytes on 64-bit, reducing
3654         memory consumption by 500 kB when loading the full HTML5 spec.
3655
3656         * rendering/style/StyleInheritedData.cpp:
3657         (WebCore::StyleInheritedData::StyleInheritedData):
3658         * rendering/style/StyleInheritedData.h:
3659
3660 2011-10-07  Pavel Feldman  <pfeldman@google.com>
3661
3662         Web Inspector: make ScriptsPanel compile
3663         https://bugs.webkit.org/show_bug.cgi?id=69623
3664
3665         Reviewed by Yury Semikhatsky.
3666
3667         * inspector/compile-front-end.sh:
3668         * inspector/front-end/CallStackSidebarPane.js:
3669         (WebInspector.CallStackSidebarPane.prototype.update):
3670         (WebInspector.CallStackSidebarPane.prototype._placardSelected):
3671         * inspector/front-end/DebuggerModel.js:
3672         * inspector/front-end/JavaScriptSourceFrame.js:
3673         (WebInspector.JavaScriptSourceFrame):
3674         * inspector/front-end/KeyboardShortcut.js:
3675         * inspector/front-end/Object.js:
3676         * inspector/front-end/ObjectPropertiesSection.js:
3677         * inspector/front-end/ScopeChainSidebarPane.js:
3678         (WebInspector.ScopeChainSidebarPane.prototype.update):
3679         * inspector/front-end/ScriptsPanel.js:
3680         (WebInspector.ScriptsPanel.prototype._setScriptSourceIsBeingEdited):
3681         (WebInspector.ScriptsPanel.prototype._createSourceFrame):
3682         (WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
3683         (WebInspector.SourceFrameDelegateForScriptsPanel):
3684         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
3685         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.debuggingSupported):
3686         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setBreakpoint):
3687         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.updateBreakpoint):
3688         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.removeBreakpoint):
3689         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.findBreakpoint):
3690         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.continueToLine):
3691         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.canEditScriptSource):
3692         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSource):
3693         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSourceIsBeingEdited):
3694         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.debuggerPaused):
3695         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.evaluateInSelectedCallFrame):
3696         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.releaseEvaluationResult):
3697         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
3698         * inspector/front-end/StatusBarButton.js:
3699         * inspector/front-end/WatchExpressionsSidebarPane.js:
3700         (WebInspector.WatchExpressionsSection.prototype.update.appendResult):
3701         (WebInspector.WatchExpressionsSection.prototype.update):
3702         (WebInspector.WatchExpressionTreeElement.prototype.startEditing):
3703         * inspector/front-end/WorkerManager.js:
3704         (WebInspector.WorkerManager.prototype._openInspectorWindow):
3705         (WebInspector.WorkerManager.prototype._pageInspectorClosing):
3706         (WebInspector.DedicatedWorkerMessageForwarder.prototype._receiveMessage):
3707         * inspector/front-end/WorkersSidebarPane.js:
3708         (WebInspector.WorkersSidebarPane.prototype.removeWorker):
3709         * inspector/front-end/externs.js:
3710         (WebInspector.linkifyURL):
3711         (InjectedFakeWorker):
3712         * inspector/front-end/inspector.js:
3713
3714 2011-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3715
3716         Unreviewed, rolling out r96879.
3717         http://trac.webkit.org/changeset/96879
3718         https://bugs.webkit.org/show_bug.cgi?id=69618
3719
3720         Broke CCLayerTreeHostTestShortlived1 on chromium mac.
3721         (Requested by podivilov on #webkit).
3722
3723         * platform/graphics/chromium/cc/CCLayerTreeHost.h:
3724
3725 2011-10-07  Pavel Feldman  <pfeldman@google.com>
3726
3727         Web Inspector: add ResourcesPanel to the compilation.
3728         https://bugs.webkit.org/show_bug.cgi?id=69612
3729
3730         Reviewed by Yury Semikhatsky.
3731
3732         * inspector/compile-front-end.sh:
3733         * inspector/front-end/ApplicationCacheItemsView.js:
3734         (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
3735         * inspector/front-end/NetworkPanel.js:
3736         * inspector/front-end/ResourceView.js:
3737         * inspector/front-end/ResourcesPanel.js:
3738         (WebInspector.ResourcesPanel.prototype.showAnchorLocation):
3739         (WebInspector.ResourcesPanel.prototype.showResource):
3740         (WebInspector.BaseStorageTreeElement.prototype.isEventWithinDisclosureTriangle):
3741         (WebInspector.FrameTreeElement.prototype.frameNavigated):
3742         (WebInspector.StorageCategoryView):
3743         (WebInspector.SearchResultsTreeElementsTraverser.prototype.last):
3744         * inspector/front-end/externs.js:
3745         (WebInspector.openRequestInNetworkPanel):
3746
3747 2011-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3748
3749         Unreviewed, rolling out r96909.
3750         http://trac.webkit.org/changeset/96909
3751         https://bugs.webkit.org/show_bug.cgi?id=69616
3752
3753         Broke chromium mac compilation (Requested by podivilov on
3754         #webkit).
3755
3756         * platform/graphics/chromium/ContentLayerChromium.h:
3757
3758 2011-10-07  Vsevolod Vlasov  <vsevik@chromium.org>
3759
3760         Web Inspector: Element highlighting does not highlight padding/border/margin for inline elements.
3761         https://bugs.webkit.org/show_bug.cgi?id=69558
3762
3763         Reviewed by Pavel Feldman.
3764
3765         * inspector/DOMNodeHighlighter.cpp:
3766
3767 2011-10-07  Mario Sanchez Prada  <msanchez@igalia.com>
3768
3769         [GTK] Don't expose objects with unknown role on GTK
3770         https://bugs.webkit.org/show_bug.cgi?id=69561
3771
3772         Reviewed by Chris Fleizach.
3773
3774         Ignore accessibility objects in accessibilityPlatformIncludesObject.
3775
3776         Test: platform/gtk/accessibility/unknown-roles-not-exposed.html
3777
3778         * accessibility/gtk/AccessibilityObjectAtk.cpp:
3779         (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
3780         For unknown accessibility objects, return IgnoreObject.
3781
3782 2011-10-07  Pavel Feldman  <pfeldman@chromium.org>
3783
3784         Web Inspector: add Elements and Network panels to the compilation
3785         https://bugs.webkit.org/show_bug.cgi?id=69604
3786
3787         Reviewed by Yury Semikhatsky.
3788
3789         * inspector/compile-front-end.sh:
3790         * inspector/front-end/BreakpointsSidebarPane.js:
3791         (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked):
3792         (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked):
3793         * inspector/front-end/DOMAgent.js:
3794         * inspector/front-end/DOMBreakpointsSidebarPane.js:
3795         * inspector/front-end/DataGrid.js:
3796         (WebInspector.DataGrid.prototype._startEditingConfig):
3797         * inspector/front-end/Drawer.js:
3798         * inspector/front-end/ElementsPanel.js:
3799         (WebInspector.ElementsPanel.prototype._hideSearchHighlights):
3800         (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
3801         (WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes.collapseDimmed):
3802         (WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes):
3803         (WebInspector.ElementsPanel.prototype._registerShortcuts):
3804         * inspector/front-end/ElementsTreeOutline.js:
3805         (WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
3806         (WebInspector.ElementsTreeElement.prototype._startEditingTextNode):
3807         (WebInspector.ElementsTreeElement.prototype._startEditingTagName):
3808         (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
3809         * inspector/front-end/GoToLineDialog.js:
3810         (WebInspector.GoToLineDialog._show):
3811         * inspector/front-end/MetricsSidebarPane.js:
3812         (WebInspector.MetricsSidebarPane.prototype.startEditing):
3813         * inspector/front-end/NetworkPanel.js:
3814         (WebInspector.NetworkLogView.prototype._onLoadEventFired):
3815         (WebInspector.NetworkLogView.prototype._domContentLoadedEventFired):
3816         (WebInspector.NetworkLogView.prototype._updateOffscreenRows):
3817         (WebInspector.NetworkLogView.prototype._removeAllNodeHighlights):
3818         (WebInspector.NetworkPanel.prototype._resourceByAnchor):
3819         (WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
3820         * inspector/front-end/ObjectPropertiesSection.js:
3821         (WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
3822         * inspector/front-end/Panel.js:
3823         * inspector/front-end/Popover.js:
3824         * inspector/front-end/SourceFrame.js:
3825         (WebInspector.SourceFrame.prototype._editBreakpointCondition):
3826         * inspector/front-end/StylesSidebarPane.js:
3827         (WebInspector.StylePropertiesSection.prototype.startEditingSelector):
3828         (WebInspector.StylePropertyTreeElement.prototype):
3829         * inspector/front-end/TimelineGrid.js:
3830         * inspector/front-end/UIUtils.js:
3831         (WebInspector.EditingConfig):
3832         (WebInspector.startEditing.editingCancelled):
3833         (WebInspector.startEditing.editingCommitted):
3834         (WebInspector.formatLocalized):
3835         (WebInspector.openLinkExternallyLabel):
3836         (WebInspector.openInNetworkPanelLabel):
3837         (WebInspector.copyLinkAddressLabel):
3838         * inspector/front-end/externs.js:
3839         (WebInspector.extensionServer.notifyObjectSelected):
3840         (WebInspector.openResource):
3841         * inspector/front-end/inspector.js:
3842         (WebInspector.resourceForURL):
3843
3844 2011-10-07  Anna Cavender  <annacc@chromium.org>
3845
3846         Change enum value names for TextTrack::readyState and TextTrack::mode
3847         https://bugs.webkit.org/show_bug.cgi?id=69603
3848
3849         Reviewed by David Levin.
3850
3851         No new tests. No new functionality.
3852
3853         * html/LoadableTextTrack.cpp:
3854         (WebCore::LoadableTextTrack::trackLoadStarted):
3855         (WebCore::LoadableTextTrack::trackLoadError):
3856         (WebCore::LoadableTextTrack::trackLoadCompleted):
3857         * html/TextTrack.cpp:
3858         (WebCore::TextTrack::TextTrack):
3859         (WebCore::TextTrack::setMode):
3860         * html/TextTrack.h:
3861
3862 2011-10-07  Anna Cavender  <annacc@chromium.org>
3863
3864         Adding parens in WebVTTParser.cpp to appease compiler preferences.
3865         https://bugs.webkit.org/show_bug.cgi?id=69602
3866
3867         Reviewed by David Levin.
3868
3869         No new tests. No new functionality.
3870
3871         * html/track/WebVTTParser.cpp:
3872         (WebCore::WebVTTParser::constructTreeFromToken):
3873
3874 2011-10-06  Antoine Labour  <piman@chromium.org>
3875
3876         Webkit API for compositor
3877         https://bugs.webkit.org/show_bug.cgi?id=69107
3878
3879         Reviewed by Darin Fisher.
3880
3881         Covered by existing compositing tests.
3882
3883         * platform/graphics/chromium/ContentLayerChromium.h:
3884
3885 2011-10-06  Kent Tamura  <tkent@chromium.org>
3886
3887         Remove SelectElement class
3888         https://bugs.webkit.org/show_bug.cgi?id=69518
3889
3890         Reviewed by Ryosuke Niwa.
3891
3892         SelectElement used to be an abstract class for HTMLSelectElement
3893         and WMLSelectElement. SelectElement is not needed anymore because
3894         WML was removed.
3895
3896         This patch just removes SelectElement by moving SelectElement
3897         functions to HTMLSelectElement.
3898
3899         No new tests. Just a refactoring.
3900
3901         * WebCore.vcproj/WebCore.vcproj:
3902         Rename dom\SelectElementWin.cpp to html\HTMLSelectElementWin.cpp.
3903         * accessibility/AccessibilityListBoxOption.cpp:
3904         (WebCore::AccessibilityListBoxOption::setSelected):
3905         Remove unnecessary cast.
3906         * accessibility/AccessibilityRenderObject.cpp:
3907         (WebCore::AccessibilityRenderObject::stringValue):
3908         Use HTMLSelectElement instead of SelectElement.
3909         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3910         (optionFromSelection): ditto.
3911         (webkit_accessible_selection_get_selection_count): ditto.
3912         * accessibility/gtk/AXObjectCacheAtk.cpp:
3913         (notifyChildrenSelectionChange): ditto.
3914         * dom/OptionElement.cpp:
3915         (WebCore::OptionElement::optionIndex): ditto.
3916         * dom/OptionElement.h: ditto.
3917         * dom/SelectElement.cpp:
3918         (WebCore::SelectElementData::checkListItems): ditto.
3919         (WebCore::SelectElementData::listItems): ditto.
3920         * dom/SelectElementWin.cpp: Removed.
3921         * dom/SelectElement.h: Removed SelectElement class declaration.
3922         * html/HTMLSelectElement.cpp: Move functions from SelectElement.cpp.
3923         (WebCore::HTMLSelectElement::selectedIndex):
3924         Removed 'SelectElement::' because the function is moved to HTMLSelectElement.
3925         (WebCore::HTMLSelectElement::deselectItems): dito.
3926         (WebCore::HTMLSelectElement::setSelectedIndex): dito.
3927         (WebCore::HTMLSelectElement::setSelectedIndexByUser): ditto.
3928         (WebCore::HTMLSelectElement::activeSelectionEndListIndex): ditto.
3929         (WebCore::HTMLSelectElement::length): ditto.
3930         (WebCore::HTMLSelectElement::saveFormControlState): ditto.
3931         (WebCore::HTMLSelectElement::restoreFormControlState): ditto.
3932         (WebCore::HTMLSelectElement::parseMappedAttribute): ditto.
3933         (WebCore::HTMLSelectElement::selectAll): ditto.
3934         (WebCore::HTMLSelectElement::appendFormData): ditto.
3935         (WebCore::HTMLSelectElement::optionToListIndex): ditto.
3936         (WebCore::HTMLSelectElement::listToOptionIndex): ditto.
3937         (WebCore::HTMLSelectElement::recalcListItems): ditto.
3938         (WebCore::HTMLSelectElement::setRecalcListItems): ditto.
3939         (WebCore::HTMLSelectElement::reset): ditto.
3940         (WebCore::HTMLSelectElement::dispatchFocusEvent): ditto.
3941         (WebCore::HTMLSelectElement::dispatchBlurEvent): ditto.
3942         (WebCore::HTMLSelectElement::defaultEventHandler): ditto.
3943         (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto.
3944         (WebCore::HTMLSelectElement::setActiveSelectionEndIndex): ditto.
3945         (WebCore::HTMLSelectElement::updateListBoxSelection): ditto.
3946         (WebCore::HTMLSelectElement::menuListOnChange): ditto.
3947         (WebCore::HTMLSelectElement::listBoxOnChange): ditto.
3948         (WebCore::HTMLSelectElement::saveLastSelection): ditto.
3949         (WebCore::HTMLSelectElement::accessKeySetSelectedIndex): ditto.
3950         (WebCore::HTMLSelectElement::scrollToSelection): ditto.
3951         (WebCore::HTMLSelectElement::insertedIntoTree): ditto.
3952         (WebCore::nextValidIndex): Moved from SelectElement.cpp.
3953         (WebCore::nextSelectableListIndex): ditto.
3954         (WebCore::previousSelectableListIndex): ditto.
3955         (WebCore::firstSelectableListIndex): ditto.
3956         (WebCore::lastSelectableListIndex): ditto.
3957         (WebCore::nextSelectableListIndexPageAway): ditto.
3958         (WebCore::HTMLSelectElement::setOptionsChangedOnRenderer): ditto.
3959         (WebCore::HTMLSelectElement::parseMultipleAttribute): ditto.
3960         (WebCore::HTMLSelectElement::platformHandleKeydownEvent): ditto.
3961         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
3962         (WebCore::HTMLSelectElement::updateSelectedState): ditto.
3963         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
3964         (WebCore::HTMLSelectElement::lastSelectedListIndex): ditto.
3965         (WebCore::stripLeadingWhiteSpace): ditto.
3966         (WebCore::HTMLSelectElement::typeAheadFind): ditto.
3967         (WebCore::HTMLSelectElement::optionCount): ditto.
3968         (WebCore::toSelectElement): ditto.
3969         * html/HTMLSelectElementWin.cpp: Copied from Source/WebCore/dom/SelectElementWin.cpp.
3970         (WebCore::HTMLSelectElement::platformHandleKeydownEvent):
3971         * html/HTMLSelectElement.h: Removed 'virtual' of SelectElement functions.
3972         (WebCore::HTMLSelectElement::size):
3973         (WebCore::HTMLSelectElement::multiple):
3974         (WebCore::HTMLSelectElement::listItems):
3975         (WebCore::HTMLSelectElement::updateValidity):
3976         * rendering/RenderListBox.cpp: Replace SelectElement with HTMLSelectElement
3977         (WebCore::RenderListBox::RenderListBox):
3978         (WebCore::RenderListBox::scrollToRevealSelection):
3979         (WebCore::RenderListBox::addFocusRingRects):
3980         (WebCore::RenderListBox::paintItemForeground):
3981         (WebCore::RenderListBox::paintItemBackground):
3982         (WebCore::RenderListBox::panScroll):
3983         (WebCore::RenderListBox::autoscroll):
3984         (WebCore::RenderListBox::valueChanged):
3985         * rendering/RenderMenuList.cpp: Replace SelectElement with HTMLSelectElement
3986         (WebCore::RenderMenuList::RenderMenuList):
3987         (WebCore::RenderMenuList::setTextFromOption):
3988         (WebCore::RenderMenuList::showPopup):
3989         (WebCore::RenderMenuList::valueChanged):
3990         (WebCore::RenderMenuList::listBoxSelectItem):
3991         (WebCore::RenderMenuList::multiple):
3992         (WebCore::RenderMenuList::didSetSelectedIndex):
3993         (WebCore::RenderMenuList::didUpdateActiveOption):
3994         (WebCore::RenderMenuList::itemText):
3995         (WebCore::RenderMenuList::itemAccessibilityText):
3996         (WebCore::RenderMenuList::itemToolTip):
3997         (WebCore::RenderMenuList::itemIsEnabled):
3998         (WebCore::RenderMenuList::itemStyle):
3999         (WebCore::RenderMenuList::itemBackgroundColor):
4000         (WebCore::RenderMenuList::listSize):
4001         (WebCore::RenderMenuList::selectedIndex):
4002         (WebCore::RenderMenuList::itemIsSeparator):
4003         (WebCore::RenderMenuList::itemIsLabel):
4004         (WebCore::RenderMenuList::itemIsSelected):
4005         (WebCore::RenderMenuList::setTextFromItem):
4006
4007 2011-10-06  Sheriff Bot  <webkit.review.bot@gmail.com>
4008
4009         Unreviewed, rolling out r96896.
4010         http://trac.webkit.org/changeset/96896
4011         https://bugs.webkit.org/show_bug.cgi?id=69601
4012
4013         broke windows and mac chromium builds (Requested by simonjam
4014         on #webkit).
4015
4016         * platform/graphics/chromium/ContentLayerChromium.h:
4017
4018 2011-10-06  Antoine Labour  <piman@chromium.org>
4019
4020         Webkit API for compositor
4021         https://bugs.webkit.org/show_bug.cgi?id=69107
4022
4023         Reviewed by Darin Fisher.
4024
4025         Covered by existing compositing tests.
4026
4027         * platform/graphics/chromium/ContentLayerChromium.h:
4028
4029 2011-10-06  Joseph Pecoraro  <joepeck@webkit.org>
4030
4031         Reviewed by Kent Tamura.
4032
4033         Pass "accept" mime type information into FileChooser at all call sites
4034         https://bugs.webkit.org/show_bug.cgi?id=69592
4035
4036         No new tests. This only exposes some more information to
4037         WebKit ports, no functionality change in WebCore.
4038
4039         * html/FileInputType.cpp:
4040         (WebCore::FileInputType::receiveDropForDirectoryUpload):
4041
4042 2011-10-06  Kent Tamura  <tkent@chromium.org>
4043
4044         [JSC binding] Fix inconsistent behavior of DOMStringMap
4045         https://bugs.webkit.org/show_bug.cgi?id=53752
4046
4047         Reviewed by Darin Adler.
4048
4049         The dataset behavior was inconsistent. The get operation handled
4050         data-* attributes first, and the put and delete operations handled
4051         JavaScript properties first.
4052
4053         Like Firefox and Opera, the put and delete operations should
4054         handle data-* attribute first.
4055
4056         * bindings/js/JSDOMStringMapCustom.cpp:
4057         (WebCore::JSDOMStringMap::deleteProperty):
4058          Handles DOMStringMap first, then returns false if the DOMStringMap makes an error.
4059         (WebCore::JSDOMStringMap::putDelegate): ditto.
4060
4061 2011-10-06  Nico Weber  <thakis@chromium.org>
4062
4063         [chromium] Let rule_binding use os.execvp() instead of subprocess.call() to spawn fewer processes.
4064         https://bugs.webkit.org/show_bug.cgi?id=69589
4065
4066         Reviewed by Adam Barth.
4067
4068         When building with `make -j40`, all the binding rules are built en bloc. Since this script currently
4069         uses subprocess.call(), that actually spawns 80 processes at once. OS X has a max process limit of
4070         255 by default, so the build used to fail with