Source/WebCore/ChangeLog

   1 2011-05-03  Andrey Kosyakov  <caseq@chromium.org>
   2
   3         Reviewed by Dimitri Glazkov.
   4
   5         [Chromium] toV8(Node*) will enter infinite recursion when called with a node of type SHADOW_ROOT_NODE
   6         https://bugs.webkit.org/show_bug.cgi?id=60026
   7
   8         Return a wrapper for Node in toV8(Node*) when called with a node of type
   9         SHADOW_ROOT_NODE instead of entering infinite recursion.
  10
  11         * bindings/v8/custom/V8NodeCustom.cpp:
  12         (WebCore::toV8Slow):
  13
  14 2011-05-02  Adam Roben  <aroben@apple.com>
  15
  16         Take advantage of implicit conversion from nullptr_t to PassOwnPtr
  17
  18         Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
  19         doesn't work, but should
  20
  21         Reviewed by Adam Barth.
  22
  23         * bindings/js/ScheduledAction.cpp:
  24         * css/CSSStyleSelector.cpp:
  25         * css/MediaList.cpp:
  26         * css/MediaQueryMatcher.cpp:
  27         * css/SVGCSSStyleSelector.cpp:
  28         * dom/MessagePort.cpp:
  29         * html/InputType.cpp:
  30         * html/canvas/WebGLRenderingContext.cpp:
  31         * inspector/InspectorStyleSheet.cpp:
  32         * page/ContextMenuController.cpp:
  33         * page/Page.cpp:
  34         * platform/PlatformGestureRecognizer.cpp:
  35         * platform/PurgeableBuffer.h:
  36         * platform/graphics/ImageBuffer.h:
  37         * platform/leveldb/LevelDBDatabase.cpp:
  38         * platform/mac/PurgeableBufferMac.cpp:
  39         * platform/text/RegularExpression.cpp:
  40         * rendering/RenderTheme.cpp:
  41         * rendering/RenderThemeMac.mm:
  42         * rendering/style/RenderStyle.h:
  43         * rendering/style/SVGRenderStyleDefs.cpp:
  44         * rendering/style/ShadowData.cpp:
  45         * rendering/style/StyleRareInheritedData.cpp:
  46         * rendering/style/StyleRareNonInheritedData.cpp:
  47         * rendering/svg/RenderSVGResourcePattern.cpp:
  48
  49 2011-05-03  Pavel Feldman  <pfeldman@google.com>
  50
  51         Not reviewed: fix inspector status bar image glyph reference in network panel.
  52
  53         * inspector/front-end/networkPanel.css:
  54         (.network-larger-resources-status-bar-item .glyph):
  55
  56 2011-05-03  Pavel Feldman  <pfeldman@google.com>
  57
  58         Reviewed by Yury Semikhatsky.
  59
  60         Web Inspector: rename BrowserDebugger agent to DOMDebugger.
  61         https://bugs.webkit.org/show_bug.cgi?id=60019
  62
  63         * inspector/CodeGeneratorInspector.pm:
  64         * inspector/Inspector.json:
  65         * inspector/InspectorController.cpp:
  66         (WebCore::InspectorController::connectFrontend):
  67         * inspector/front-end/BreakpointsSidebarPane.js:
  68         (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint):
  69         (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint):
  70         (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
  71         (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint):
  72         (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
  73         * inspector/generate-inspector-idl:
  74
  75 2011-05-03  Yury Semikhatsky  <yurys@chromium.org>
  76
  77         Reviewed by Pavel Feldman.
  78
  79         Web Inspector: remove special logic for type of document.__proto__
  80         https://bugs.webkit.org/show_bug.cgi?id=60014
  81
  82         Test: inspector/console/console-log-document-proto.html
  83
  84         * inspector/InjectedScriptSource.js: removed unnecessary check nodeType === undefined
  85
  86 2011-05-03  Pavel Feldman  <pfeldman@google.com>
  87
  88         Not reviewed: fixed typo in inspector style.
  89
  90         * inspector/front-end/inspector.css:
  91         (.status-bar-item > .glyph):
  92
  93 2011-05-03  Pavel Feldman  <pfeldman@chromium.org>
  94
  95         Reviewed by Yury Semikhatsky.
  96
  97         Web Inspector: revision history storage is too slow.
  98         https://bugs.webkit.org/show_bug.cgi?id=59939
  99
 100         It turns out that iterating localStorage keys is very
 101         expensive (results in slow inspector start), refactor revision
 102         history in order not to rely upon that operation.
 103
 104         * inspector/front-end/Resource.js:
 105         (WebInspector.Resource):
 106         (WebInspector.Resource._resourceRevisionRegistry):
 107         (WebInspector.Resource.restoreRevisions.persist):
 108         (WebInspector.Resource.restoreRevisions):
 109         (WebInspector.Resource.persistRevision):
 110         (WebInspector.Resource.prototype._persistRevision):
 111         * inspector/front-end/ResourceTreeModel.js:
 112         (WebInspector.ResourceTreeModel.prototype._processCachedResources):
 113         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
 114
 115 2011-05-03  Pavel Feldman  <pfeldman@chromium.org>
 116
 117         Reviewed by Yury Semikhatsky.
 118
 119         Web Inspector: combine toolbar icon images.
 120         https://bugs.webkit.org/show_bug.cgi?id=59931
 121
 122         * WebCore.gypi:
 123         * inspector/front-end/Images/auditsIcon.png: Removed.
 124         * inspector/front-end/Images/consoleIcon.png: Removed.
 125         * inspector/front-end/Images/elementsIcon.png: Removed.
 126         * inspector/front-end/Images/networkIcon.png: Removed.
 127         * inspector/front-end/Images/profilesIcon.png: Removed.
 128         * inspector/front-end/Images/resourcesIcon.png: Removed.
 129         * inspector/front-end/Images/scriptsIcon.png: Removed.
 130         * inspector/front-end/Images/timelineIcon.png: Removed.
 131         * inspector/front-end/Images/toolbarIcons.png: Added.
 132         * inspector/front-end/Images/toolbarIconsSmall.png: Added.
 133         * inspector/front-end/WebKit.qrc:
 134         * inspector/front-end/inspector.css:
 135         (.toolbar-icon):
 136         (#toolbar-dropdown .toolbar-icon):
 137         (.toolbar-item:active .toolbar-icon):
 138         (#toolbar-dropdown .toolbar-item:active .toolbar-icon):
 139         (.toolbar-item.elements .toolbar-icon):
 140         (.toolbar-item.resources .toolbar-icon):
 141         (#toolbar-dropdown .toolbar-item.resources .toolbar-icon):
 142         (.toolbar-item.network .toolbar-icon):
 143         (#toolbar-dropdown .toolbar-item.network .toolbar-icon):
 144         (.toolbar-item.scripts .toolbar-icon):
 145         (#toolbar-dropdown .toolbar-item.scripts .toolbar-icon):
 146         (.toolbar-item.timeline .toolbar-icon):
 147         (#toolbar-dropdown .toolbar-item.timeline .toolbar-icon):
 148         (.toolbar-item.profiles .toolbar-icon):
 149         (#toolbar-dropdown .toolbar-item.profiles .toolbar-icon):
 150         (.toolbar-item.audits .toolbar-icon):
 151         (#toolbar-dropdown .toolbar-item.audits .toolbar-icon):
 152         (.toolbar-item.console .toolbar-icon):
 153         (#toolbar-dropdown .toolbar-item.console .toolbar-icon):
 154         (.status-bar-item > .glyph):
 155
 156 2011-05-03  Pavel Feldman  <pfeldman@chromium.org>
 157
 158         Reviewed by Yury Semikhatsky.
 159
 160         Web Inspector: combine status bar button glyphs.
 161         https://bugs.webkit.org/show_bug.cgi?id=59885
 162
 163         * WebCore.gypi:
 164         * inspector/front-end/Images/breakpointsActivateButtonGlyph.png: Removed.
 165         * inspector/front-end/Images/breakpointsDeactivateButtonGlyph.png: Removed.
 166         * inspector/front-end/Images/clearConsoleButtonGlyph.png: Removed.
 167         * inspector/front-end/Images/consoleButtonGlyph.png: Removed.
 168         * inspector/front-end/Images/dockButtonGlyph.png: Removed.
 169         * inspector/front-end/Images/enableOutlineButtonGlyph.png: Removed.
 170         * inspector/front-end/Images/enableSolidButtonGlyph.png: Removed.
 171         * inspector/front-end/Images/excludeButtonGlyph.png: Removed.
 172         * inspector/front-end/Images/focusButtonGlyph.png: Removed.
 173         * inspector/front-end/Images/garbageCollectButtonGlyph.png: Removed.
 174         * inspector/front-end/Images/gearButtonGlyph.png: Removed.
 175         * inspector/front-end/Images/helpButtonGlyph.png: Removed.
 176         * inspector/front-end/Images/largerResourcesButtonGlyph.png: Removed.
 177         * inspector/front-end/Images/nodeSearchButtonGlyph.png: Removed.
 178         * inspector/front-end/Images/pauseOnExceptionButtonGlyph.png: Removed.
 179         * inspector/front-end/Images/percentButtonGlyph.png: Removed.
 180         * inspector/front-end/Images/prettyPrintButtonGlyph.png: Removed.
 181         * inspector/front-end/Images/recordButtonGlyph.png: Removed.
 182         * inspector/front-end/Images/recordToggledButtonGlyph.png: Removed.
 183         * inspector/front-end/Images/reloadButtonGlyph.png: Removed.
 184         * inspector/front-end/Images/statusBarButtonGlyphs.png: Added.
 185         * inspector/front-end/Images/undockButtonGlyph.png: Removed.
 186         * inspector/front-end/WebKit.qrc:
 187         * inspector/front-end/inspector.css:
 188         (.status-bar-item > .glyph):
 189         (#dock-status-bar-item .glyph):
 190         (body.detached #dock-status-bar-item .glyph):
 191         (#console-status-bar-item .glyph):
 192         (.clear-status-bar-item .glyph):
 193         (button.enable-toggle-status-bar-item .glyph):
 194         (button.enable-toggle-status-bar-item.toggled-on .glyph):
 195         (.scripts-pause-on-exceptions-status-bar-item .glyph):
 196         (.scripts-toggle-pretty-print-status-bar-item .glyph):
 197         (.toggle-breakpoints .glyph):
 198         (.toggle-breakpoints.toggled-on .glyph):
 199         (.resources-larger-resources-status-bar-item .glyph):
 200         (.timeline-filter-status-bar-item .glyph):
 201         (.garbage-collect-status-bar-item .glyph):
 202         (.record-profile-status-bar-item .glyph):
 203         (.record-profile-status-bar-item.toggled-on .glyph):
 204         (.heap-snapshot-status-bar-item .glyph):
 205         (.node-search-status-bar-item .glyph):
 206         (.percent-time-status-bar-item .glyph):
 207         (.focus-profile-node-status-bar-item .glyph):
 208         (.exclude-profile-node-status-bar-item .glyph):
 209         (.reset-profile-status-bar-item .glyph):
 210         (.delete-storage-status-bar-item .glyph):
 211         (.refresh-storage-status-bar-item .glyph):
 212         * inspector/front-end/inspector.js:
 213
 214 2011-05-02  Simon Fraser  <simon.fraser@apple.com>
 215
 216         Reviewed by Dan Bernstein.
 217
 218         Possible crash when removing elements with reflections
 219         https://bugs.webkit.org/show_bug.cgi?id=60009
 220
 221         RenderLayer's destructor deleted its z-order list Vector pointers
 222         before removing the reflection layer. However, the reflection cleanup
 223         code could call back into the RenderLayer to dirty z-order lists,
 224         so move reflection cleanup to before z-order vector deletion.
 225
 226         The test crashes when run manually a few times with MallocScribble enabled,
 227         but I was not able to create a test that crashed reliably.
 228
 229         Test: fast/reflections/remove-reflection-crash.html
 230
 231         * rendering/RenderLayer.cpp:
 232         (WebCore::RenderLayer::~RenderLayer):
 233
 234 2011-05-02  Ian Henderson  <ianh@apple.com>
 235
 236         Reviewed by Dan Bernstein.
 237
 238         CSS !important not respected by JavaScript
 239         https://bugs.webkit.org/show_bug.cgi?id=60007
 240
 241         The addParsedProperty and addParsedProperties methods were subtly
 242         different.  The former did not check for !important before setting the
 243         given property.
 244
 245         Change addParsedProperties to call addParsedProperty and move the
 246         relevant code.  The one other caller of this method, in
 247         editing/markup.cpp, probably wanted this behavior anyway.
 248
 249         Test: fast/css/important-js-override.html
 250
 251         * css/CSSMutableStyleDeclaration.cpp:
 252         (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
 253         (WebCore::CSSMutableStyleDeclaration::addParsedProperty):
 254
 255 2011-05-02  Ben Wells  <benwells@chromium.org>
 256
 257         Reviewed by Simon Fraser.
 258
 259         Cleanup variable usage in RenderObject.cpp paintOutline()
 260         https://bugs.webkit.org/show_bug.cgi?id=59911
 261
 262         No new tests for this, there should be no change in behaviour.
 263
 264         * rendering/RenderObject.cpp:
 265         (WebCore::RenderObject::paintOutline):
 266
 267 2011-05-02  Ryosuke Niwa  <rniwa@webkit.org>
 268
 269         Reviewed by James Robinson.
 270
 271         REGRESSION(r84672): showTree doesn't work for input/textarea elements
 272         https://bugs.webkit.org/show_bug.cgi?id=60001
 273
 274         When shadow is null, try retrieving the inner element of a render text control.
 275
 276         * dom/Node.cpp:
 277         (WebCore::traverseTreeAndMark):
 278
 279 2011-05-02  Joseph Pecoraro  <joepeck@webkit.org>
 280
 281         Reviewed by David Kilzer.
 282
 283         Respect fixed text-indent on ::-webkit-input-placeholder
 284         https://bugs.webkit.org/show_bug.cgi?id=59825
 285
 286         Test: fast/forms/input-placeholder-text-indent.html
 287
 288         * rendering/RenderTextControl.cpp:
 289         (WebCore::RenderTextControl::paintPlaceholder): indent by
 290         a fixed text-indent size specified on the placeholder style.
 291
 292 2011-05-02  Eric Uhrhane  <ericu@chromium.org>
 293
 294         Reviewed by Eric Seidel.
 295
 296         Some FileWriter progress events should be queued
 297         https://bugs.webkit.org/show_bug.cgi?id=50846
 298
 299         * fileapi/FileWriter.cpp:
 300         * fileapi/FileWriter.h:
 301         Create a new asynchronous Task [FileWriterCompletionEventTask] that will set readyState to DONE and fire off the right events.
 302
 303 2011-05-02  Jia Pu  <jpu@apple.com>
 304
 305         Reviewed by Alexey Proskuryakov.
 306
 307         [Mac] Need to truncate the string sent to "Look Up … " menu item, if it's too long.
 308         https://bugs.webkit.org/show_bug.cgi?id=59836
 309         <rdar://problem/9275983>
 310
 311         * platform/DefaultLocalizationStrategy.cpp:
 312         (WebCore::truncatedStringForLookupMenuItem):
 313         (WebCore::DefaultLocalizationStrategy::contextMenuItemTagLookUpInDictionary):
 314
 315 2011-05-02  Brady Eidson  <beidson@apple.com>
 316
 317         Reviewed by Anders Carlsson.
 318
 319         <rdar://problem/9340945> and https://bugs.webkit.org/show_bug.cgi?id=59973
 320         In Aperture, a WebView might be dealloc'ed before it finishes loading.
 321
 322         * WebCore.exp.in:
 323         * platform/RuntimeApplicationChecks.cpp:
 324         (WebCore::applicationIsAperture): Perform a com.apple.Aperture bundle check.
 325         * platform/RuntimeApplicationChecks.h:
 326
 327 2011-05-02  Simon Fraser  <simon.fraser@apple.com>
 328
 329         Reviewed by Dan Bernstein.
 330
 331         Avoid wasted cycles updating paths when popping the context stack
 332         https://bugs.webkit.org/show_bug.cgi?id=59967
 333
 334         CanvasRenderingContext2D has to map the current path through
 335         transforms whenever the context stack is popped, which creates
 336         a lot of platform path objects. Avoid extra work here when the
 337         path is empty, or when the transform is identity.
 338
 339         * platform/graphics/cg/PathCG.cpp:
 340         (WebCore::Path::transform):
 341
 342 2011-05-02  Enrica Casucci  <enrica@apple.com>
 343
 344         Reviewed by Dan Bernstein.
 345
 346         Text does not split on white space when typing to the edge of window.
 347         https://bugs.webkit.org/show_bug.cgi?id=59968
 348         <rdar://problem/9112683>
 349
 350         Test: editing/inserting/typing-at-end-of-line.html
 351
 352         This is a regression introduced when we converted the line box tree to
 353         floating point in r78846. In findNextLineBreak, there was still one place where
 354         the character width was treated as int and truncated and we were inconsistent
 355         in the way we treated a character that did not fit entirely in the line.
 356
 357         * rendering/RenderBlockLineLayout.cpp:
 358         (WebCore::RenderBlock::findNextLineBreak):
 359
 360 2011-04-19  Adrienne Walker  <enne@google.com>
 361
 362         Reviewed by James Robinson.
 363
 364         [chromium] Don't unnecessarily resize skia/cg canvases when painting in compositor
 365         https://bugs.webkit.org/show_bug.cgi?id=58907
 366
 367         Additionally, move the context save/restore logic to a place where it
 368         will reset the translation added in LayerTilerChromium.
 369
 370         Test: compositing/repaint/same-size-invalidation.html
 371
 372         * platform/graphics/chromium/ContentLayerChromium.cpp:
 373         (WebCore::ContentLayerPainter::paint):
 374         * platform/graphics/chromium/PlatformCanvas.cpp:
 375         (WebCore::PlatformCanvas::resize):
 376         (WebCore::PlatformCanvas::Painter::Painter):
 377         (WebCore::PlatformCanvas::Painter::~Painter):
 378         * platform/graphics/chromium/PlatformCanvas.h:
 379
 380 2011-05-02  Csaba Osztrogonác  <ossy@webkit.org>
 381
 382         Enable strict OwnPtr for Qt
 383         https://bugs.webkit.org/show_bug.cgi?id=59667
 384
 385         Unreviewed buildfix after r85343.
 386
 387         * platform/graphics/qt/GraphicsContext3DQt.cpp:
 388         (WebCore::GraphicsContext3D::GraphicsContext3D):
 389
 390 2011-05-02  Sheriff Bot  <webkit.review.bot@gmail.com>
 391
 392         Unreviewed, rolling out r85483.
 393         http://trac.webkit.org/changeset/85483
 394         https://bugs.webkit.org/show_bug.cgi?id=59958
 395
 396         Causes media test failures. (Requested by eric_carlson on
 397         #webkit).
 398
 399         * html/HTMLMediaElement.cpp:
 400         (WebCore::HTMLMediaElement::HTMLMediaElement):
 401         (WebCore::HTMLMediaElement::prepareForLoad):
 402         (WebCore::HTMLMediaElement::seek):
 403         (WebCore::HTMLMediaElement::updatePlayState):
 404         * html/HTMLMediaElement.h:
 405         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
 406         (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
 407         (WebCore::MediaPlayerPrivateAVFoundation::resumeLoad):
 408         (WebCore::MediaPlayerPrivateAVFoundation::load):
 409         (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay):
 410         (WebCore::MediaPlayerPrivateAVFoundation::paint):
 411         (WebCore::MediaPlayerPrivateAVFoundation::duration):
 412         (WebCore::MediaPlayerPrivateAVFoundation::seeking):
 413         (WebCore::MediaPlayerPrivateAVFoundation::updateStates):
 414         (WebCore::MediaPlayerPrivateAVFoundation::hasAvailableVideoFrame):
 415         (WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded):
 416         (WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged):
 417         (WebCore::MediaPlayerPrivateAVFoundation::timeChanged):
 418         (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
 419         (WebCore::MediaPlayerPrivateAVFoundation::repaint):
 420         (WebCore::MediaPlayerPrivateAVFoundation::setPreload):
 421         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
 422         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
 423         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
 424         (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
 425         (WebCore::MediaPlayerPrivateAVFoundationObjC::videoLayerIsReadyToDisplay):
 426         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForURL):
 427         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForCacheResource):
 428         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
 429         (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata):
 430         (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus):
 431         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
 432         (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus):
 433         (WebCore::MediaPlayerPrivateAVFoundationObjC::paint):
 434         (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
 435         (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged):
 436
 437 2011-05-02  Adam Barth  <abarth@webkit.org>
 438
 439         Reviewed by David Levin.
 440
 441         PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
 442         https://bugs.webkit.org/show_bug.cgi?id=59924
 443
 444         * css/CSSGrammar.y:
 445         * platform/graphics/mac/SimpleFontDataMac.mm:
 446             - Memory management for the font cache is somewhat... complext.
 447               This will require some careful thought to sort out.
 448
 449 2011-05-02  Levi Weintraub  <leviw@chromium.org>
 450
 451         Reviewed by Eric Seidel.
 452
 453         showLineTree/showLineTreeForThis would make working with the line box tree easier
 454         https://bugs.webkit.org/show_bug.cgi?id=59662
 455
 456         Adding a showLineTree/showLineTreeForThis method to help visualize and debug
 457         the line tree. Also adding a missing showRenderTreeForThis method to RenderObject.
 458
 459         No new tests since this is a debugging feature only and not compiled in release.
 460
 461         * rendering/InlineBox.cpp:
 462         (WebCore::InlineBox::showLineTreeForThis):
 463         (WebCore::InlineBox::showLineTreeAndMark):
 464         (WebCore::InlineBox::showBox):
 465         (showLineTree):
 466         * rendering/InlineBox.h:
 467         * rendering/InlineFlowBox.cpp:
 468         (WebCore::InlineFlowBox::showLineTreeAndMark):
 469         * rendering/InlineFlowBox.h:
 470         * rendering/InlineTextBox.cpp:
 471         (WebCore::InlineTextBox::showBox):
 472         * rendering/InlineTextBox.h:
 473         * rendering/RenderBlock.cpp:
 474         (WebCore::RenderBlock::showLineTreeAndMark):
 475         * rendering/RenderBlock.h:
 476         * rendering/RenderObject.cpp:
 477         (WebCore::RenderObject::showRenderTreeForThis):
 478         (WebCore::RenderObject::showLineTreeForThis):
 479         (showTree):
 480         (showLineTree):
 481         * rendering/RenderObject.h:
 482
 483 2011-05-02  Dimitri Glazkov  <dglazkov@chromium.org>
 484
 485         Reviewed by Eric Carlson.
 486
 487         REGRESSIONS (r71934): In standalone media documents, (double-)clicking the media element doesn’t play/pause
 488         https://bugs.webkit.org/show_bug.cgi?id=59917
 489
 490         Since default event handlers are not retargeted, we should always attempt ancestor
 491         traversal to find out whether the event.
 492
 493         * html/MediaDocument.cpp:
 494         (WebCore::ancestorVideoElement): Added ancestor-traversing helper.
 495         (WebCore::MediaDocument::defaultEventHandler): Changed to use ancestorVideoElement.
 496
 497 2011-05-02  Sam Weinig  <sam@webkit.org>
 498
 499         Attempt to fix the Leopard build.
 500
 501         * platform/graphics/FontPlatformData.h:
 502         * platform/graphics/mac/ComplexTextController.h:
 503         * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
 504         * platform/mac/WebCoreSystemInterface.h:
 505
 506 2011-05-02  Tony Chang  <tony@chromium.org>
 507
 508         Reviewed by Kent Tamura.
 509
 510         convert manual-tests/bugzilla-6821.html to a layout test
 511         https://bugs.webkit.org/show_bug.cgi?id=59404
 512
 513         Test: fast/css/hover-update.html
 514
 515         * manual-tests/bugzilla-6821.html: Removed.
 516
 517 2011-05-02  Sam Weinig  <sam@webkit.org>
 518
 519         Reviewed by Anders Carlsson.
 520
 521         Prune ApplicationServices.h out of the headers
 522         https://bugs.webkit.org/show_bug.cgi?id=59952
 523
 524         More forward declares are better.
 525
 526         * html/canvas/CanvasRenderingContext2D.cpp:
 527         * html/canvas/CanvasRenderingContext2D.h:
 528         * platform/graphics/GlyphBuffer.h:
 529         * platform/graphics/cg/ImageBufferCG.cpp:
 530         * platform/graphics/cg/PDFDocumentImage.cpp:
 531         * platform/graphics/cg/PDFDocumentImage.h:
 532         * platform/graphics/mac/ComplexTextController.h:
 533         * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
 534         * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
 535         * platform/mac/ScrollAnimatorMac.h:
 536         * platform/mac/ScrollAnimatorMac.mm:
 537         * platform/mac/ScrollbarThemeMac.h:
 538         * platform/mac/ScrollbarThemeMac.mm:
 539         * platform/mac/WebCoreNSStringExtras.h:
 540         * platform/mac/WebCoreSystemInterface.h:
 541
 542 2011-05-02  Dan Bernstein  <mitz@apple.com>
 543
 544         Reviewed by Simon Fraser.
 545
 546         <rdar://problem/7972529> Images with percentage based height/max-height are missing when they are inside blocks inside tables
 547         https://bugs.webkit.org/show_bug.cgi?id=58006
 548
 549         * rendering/RenderBox.cpp:
 550         (WebCore::RenderBox::computeReplacedLogicalHeightUsing): Expanded the scope of the fix for
 551         <http://webkit.org/b/15359> from r29039 to cover not just the case of a auto-or-percent-height
 552         table cell as the immediate containing block, but any case where all containing block ancestors
 553         up to and including a table cell are auto-or-percent height.
 554
 555 2011-05-02  Daniel Bates  <dbates@webkit.org>
 556
 557         Reviewed by Sam Weinig.
 558
 559         Convert manual test onblur-remove.html to a DRT test; onblur-remove.html fails
 560         https://bugs.webkit.org/show_bug.cgi?id=59379
 561
 562         Move manual test onblur-remove.html to LayoutTests/fast/events.
 563
 564         Test: fast/events/onblur-remove.html
 565
 566         * manual-tests/onblur-remove.html: Removed.
 567
 568 2011-05-02  Sailesh Agrawal  <sail@chromium.org>
 569
 570         Reviewed by Dimitri Glazkov.
 571
 572         Chromium Mac: Add scrollbar overlay drawing functions
 573         https://bugs.webkit.org/show_bug.cgi?id=59741
 574
 575         These functions are simply copied from WebCoreSystemInterface. These will be used to implement overlay scrollbars for Chromium Mac.
 576
 577         No new tests, since this code is only enabled on future versions of Mac OS X.
 578
 579         * WebCore.gypi:
 580         * platform/chromium/ScrollbarOverlayUtilitiesMac.h: Added.
 581         * platform/chromium/ScrollbarOverlayUtilitiesMac.mm: Added.
 582         (LookUpNSScrollerImpClass):
 583         (LookUpNSScrollerImpPairClass):
 584         (ScrollbarControlSizeToNSControlSize):
 585         (wkScrollbarPainterUsesOverlayScrollers):
 586         (wkScrollbarPainterIsHorizontal):
 587         (wkScrollbarPainterKnobAlpha):
 588         (wkScrollbarPainterSetOverlayState):
 589         (wkScrollbarPainterPaint):
 590         (wkScrollbarMinimumThumbLength):
 591         (wkScrollbarPainterSetDelegate):
 592         (wkScrollbarPainterTrackAlpha):
 593         (wkMakeScrollbarPainter):
 594         (wkScrollbarThickness):
 595         (wkScrollbarMinimumTotalLengthNeededForThumb):
 596         (wkVerticalScrollbarPainterForController):
 597         (wkHorizontalScrollbarPainterForController):
 598         (wkMakeScrollbarReplacementPainter):
 599         (wkSetPainterForPainterController):
 600         (wkSetScrollbarPainterControllerStyle):
 601         (wkScrollbarPainterKnobRect):
 602         (wkSetScrollbarPainterKnobAlpha):
 603         (wkSetScrollbarPainterTrackAlpha):
 604         (wkSetScrollbarPainterKnobStyle):
 605         (wkMakeScrollbarPainterController):
 606         (wkContentAreaScrolled):
 607         (wkContentAreaWillPaint):
 608         (wkMouseEnteredContentArea):
 609         (wkMouseExitedContentArea):
 610         (wkMouseMovedInContentArea):
 611         (wkWillStartLiveResize):
 612         (wkContentAreaResized):
 613         (wkWillEndLiveResize):
 614         (wkContentAreaDidShow):
 615         (wkContentAreaDidHide):
 616         (wkDidBeginScrollGesture):
 617         (wkDidEndScrollGesture):
 618         (wkScrollbarPainterForceFlashScrollers):
 619         (IsScrollbarOverlayAPIAvailable):
 620
 621 2011-05-02  Luke Macpherson   <macpherson@chromium.org>
 622
 623         Reviewed by Dimitri Glazkov.
 624
 625         Implement Length based CSS properties in CSSStyleApplyProperty
 626         https://bugs.webkit.org/show_bug.cgi?id=59314
 627
 628         No new tests as no functionality changed.
 629
 630         * css/CSSStyleApplyProperty.cpp:
 631         (WebCore::ApplyPropertyLength::ApplyPropertyLength):
 632         Added this class to handle all length types.
 633         Property specific behavior is handled through set of boolean parameters.
 634         (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
 635         Added calls to set up entries for the newly added length properties.
 636         * css/CSSStyleSelector.cpp:
 637         (WebCore::CSSStyleSelector::applyProperty):
 638         Remove property implementations mow implemented in CSSStyleApplyProperty.
 639         * css/CSSStyleSelector.h:
 640         (WebCore::CSSStyleSelector::rootElementStyle):
 641         Expose m_rootElementStyle via getter.
 642
 643 2011-05-02  Eric Carlson  <eric.carlson@apple.com>
 644
 645         Reviewed by Eric Seidel.
 646
 647         HTMLMediaElement should not seek to time 0 when readyState reaches HAVE_METADATA
 648         https://bugs.webkit.org/show_bug.cgi?id=59828
 649
 650         No new tests required, no functional change because seeking to time zero before playback
 651         begins has no effect.
 652
 653         * html/HTMLMediaElement.cpp:
 654         (WebCore::HTMLMediaElement::setReadyState): Don't seek to time 0 when readyState reaches
 655             HAVE_METADATA.
 656
 657 2011-05-02  Sam Weinig  <sam@webkit.org>
 658
 659         Reviewed by Gavin Barraclough.
 660
 661         Fix extra whitespace in license in FocusDirection.h.
 662
 663         * page/FocusDirection.h:
 664
 665 2011-05-02  Sam Weinig  <sam@webkit.org>
 666
 667         Reviewed by Adam Barth.
 668
 669         Prune some #includes from DOMWindow.h
 670         https://bugs.webkit.org/show_bug.cgi?id=59907
 671
 672         * page/DOMWindow.cpp:
 673         (WebCore::DOMWindow::setSecurityOrigin):
 674         * page/DOMWindow.h:
 675         Remove #includes of SecurityOrigin and MessagePort by forward declaring
 676         and moving the SecurityOrigin setter to the .cpp file. Also adds EventTarget
 677         #include that was getting added by MessagePort.h.
 678
 679         * bindings/js/JSCustomVoidCallback.cpp:
 680         * bindings/js/JSCustomXPathNSResolver.cpp:
 681         * bindings/js/JSDOMWindowCustom.h:
 682         * bindings/js/JSHistoryCustom.cpp:
 683         * bindings/js/ScriptController.h:
 684         * html/HTMLAnchorElement.cpp:
 685         * html/HTMLMediaElement.cpp:
 686         * html/parser/XSSFilter.cpp:
 687         * inspector/InspectorDOMStorageResource.cpp:
 688         * loader/MainResourceLoader.cpp:
 689         * page/DragController.cpp:
 690         * page/EventSource.cpp:
 691         * page/Location.cpp:
 692         * websockets/WebSocket.cpp:
 693         * xml/XSLTProcessorLibxslt.cpp:
 694         Add now missing SecurityOrigin.h #includes.
 695
 696 2011-05-02  Eric Carlson  <eric.carlson@apple.com>
 697
 698         Reviewed by Brady Eidson.
 699
 700         The preload attribute of the video tag is not completely implemented
 701         https://bugs.webkit.org/show_bug.cgi?id=43673
 702         <rdar://problem/7508322>
 703
 704         Tested manually with manual-tests/media-elements/video-preload.html.
 705
 706         * html/HTMLMediaElement.cpp:
 707         (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_havePreparedToPlay.
 708         (WebCore::HTMLMediaElement::prepareForLoad): Ditto.
 709         (WebCore::HTMLMediaElement::prepareToPlay): New, tell player to prepare to play.
 710         (WebCore::HTMLMediaElement::seek): Call prepareToPlay when preload is less than 'metadata'
 711             because we need to have media data loaded to seek.
 712         (WebCore::HTMLMediaElement::updatePlayState): Call prepareToPlay.
 713         * html/HTMLMediaElement.h:
 714
 715         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
 716         (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):  Remove
 717             m_videoFrameHasDrawn and m_delayingLoad as they are no longer used.
 718         (WebCore::MediaPlayerPrivateAVFoundation::resumeLoad): Removed.
 719         (WebCore::MediaPlayerPrivateAVFoundation::load): Don't initialize m_videoFrameHasDrawn.
 720             Move all preload logic to setPreload, call it from here.
 721         (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Move all preload logic to
 722             setPreload, call it.
 723         (WebCore::MediaPlayerPrivateAVFoundation::duration): Don't cache duration = 0, it is
 724             unlikely to be correct and isn't worth caching.
 725         (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Update for name change AVAssetStatus
 726             to AssetStatus. Create the AVPlayer once we know an asset is playable but preload is
 727             'metadata'. Set networkState to 'idle' when the playback buffer is full because that is
 728             a signal that AVFoundation won't do any more IO. Set readyState to 'HAVE_CURRENT_DATA'
 729             when the first frame is available.
 730         (WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Call tracksChanged so we cache
 731             width, height, hasVideo, etc.
 732         (WebCore::MediaPlayerPrivateAVFoundation::repaint): Don't set m_videoFrameHasDrawn, it is done
 733             in derived classes.
 734         (WebCore::MediaPlayerPrivateAVFoundation::setPreload): Centralize all logic about when to create
 735             AVAsset and AVPlayerItem here.
 736         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
 737
 738         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
 739         * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
 740         (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize
 741             m_videoFrameHasDrawn.
 742         (WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame): New, renamed from
 743             videoLayerIsReadyToDisplay. Return true if we have a layer with frames available or
 744             if we have painted a frame to the context.
 745         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): New, create the AVAsset
 746             if necessary.
 747         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForCacheResource): Ditto.
 748         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Restructure logic.
 749         (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): New, create AVPlayerItem.
 750         (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): Correct logging.
 751         (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus): Return "buffer full" when
 752             the buffer is full.
 753         (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Get the duration from the
 754             AVAsset when we haven't allocated the AVPlayerItem yet so that we can return duration
 755             when we only have metadata.
 756         (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): Update for name change.
 757         (WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Set m_videoFrameHasDrawn.
 758         (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Get attributes from AVAsset
 759             when when we haven't allocated the AVPlayerItem yet so that we can report attributes
 760             when we only have metadata.
 761         (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): Guard against being called before
 762             we have allocated the AVPlayerItem.
 763
 764 2011-05-02  Philippe Normand  <pnormand@igalia.com>
 765
 766         Reviewed by Martin Robinson.
 767
 768         [GTK] gdk_drawable_get_size() shouldn't be used with GTK+ >= 2.24
 769         https://bugs.webkit.org/show_bug.cgi?id=59932
 770
 771         Use gdk_window_get_width() and gdk_window_get_height() if
 772         available, instead of the deprecated gdk_drawable_get_size().
 773
 774         No new tests, build fix only.
 775
 776         * platform/gtk/WidgetRenderingContext.cpp:
 777         (WebCore::WidgetRenderingContext::WidgetRenderingContext):
 778
 779 2011-05-02  Eric Carlson  <eric.carlson@apple.com>
 780
 781         Reviewed by Brady Eidson.
 782
 783         The preload attribute of the video tag is not completely implemented
 784         https://bugs.webkit.org/show_bug.cgi?id=43673
 785         <rdar://problem/7508322>
 786
 787         Test manually with manual-tests/media-elements/video-preload.html.
 788
 789         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
 790         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
 791         (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes): Add new "limit read-ahead"
 792             attribute when preload is not "auto".
 793         (WebCore::MediaPlayerPrivateQTKit::resumeLoad): Remove m_delayingLoad, we don't need it.
 794         (WebCore::MediaPlayerPrivateQTKit::load): Correct comment.
 795         (WebCore::MediaPlayerPrivateQTKit::prepareToPlay): Call setPreload('auto').
 796         (WebCore::MediaPlayerPrivateQTKit::setPreload): Set new attribue if we already have
 797             a QTMovie.
 798
 799 2011-05-02  Eric Carlson  <eric.carlson@apple.com>
 800
 801         Reviewed by Brady Eidson.
 802
 803         The preload attribute of the video tag is not completely implemented
 804         https://bugs.webkit.org/show_bug.cgi?id=43673
 805         <rdar://problem/7508322>
 806
 807         Manual test manual-tests/media-elements/video-preload.html added.
 808
 809         * manual-tests/media-elements/video-preload.html: Added. New manual test for media element
 810             'preload' attribute because it is not possible to detect if a media engine supports
 811             "preload=metadata" in a way that lets us have per-platform layout test results.
 812
 813 2011-05-01  Abhishek Arya  <inferno@chromium.org>
 814
 815         Reviewed by Eric Carlson.
 816
 817         Regression(r74787): Media document mouse click and double-click
 818         events should be checked on target node only and not its descendants.
 819         https://bugs.webkit.org/show_bug.cgi?id=59886
 820
 821         * html/MediaDocument.cpp:
 822         (WebCore::MediaDocument::defaultEventHandler):
 823
 824 2011-05-01  Adam Barth  <abarth@webkit.org>
 825
 826         Reviewed by Eric Seidel.
 827
 828         Polish CSP host and port matching
 829         https://bugs.webkit.org/show_bug.cgi?id=59899
 830
 831         Finish last two details of host and port matching.  I don't think the
 832         default port handling is testable with our current testing
 833         infrastructure.
 834
 835         Tests: http/tests/security/contentSecurityPolicy/image-full-host-wildcard-allowed.html
 836                http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed.html
 837
 838         * page/ContentSecurityPolicy.cpp:
 839         (WebCore::CSPSource::hostMatches):
 840         (WebCore::CSPSource::portMatches):
 841
 842 2011-05-01  Adam Barth  <abarth@webkit.org>
 843
 844         Reviewed by Eric Seidel.
 845
 846         CSP default-src is missing
 847         https://bugs.webkit.org/show_bug.cgi?id=58641
 848
 849         Add support for default-src.  The default-src provides a default policy
 850         for every directive that sends in "-src".  If the more-specific
 851         directive is present, it takes precedence.  I also took this
 852         opportunity to refactor the internals of ContentSecurityPolicy a bit to
 853         reduce duplicate code.
 854
 855         Tests: http/tests/security/contentSecurityPolicy/default-src-inline-allowed.html
 856                http/tests/security/contentSecurityPolicy/default-src-inline-blocked.html
 857                http/tests/security/contentSecurityPolicy/script-src-overrides-default-src.html
 858
 859         * page/ContentSecurityPolicy.cpp:
 860         (WebCore::ContentSecurityPolicy::didReceiveHeader):
 861         (WebCore::ContentSecurityPolicy::checkEval):
 862         (WebCore::ContentSecurityPolicy::operativeDirective):
 863         (WebCore::ContentSecurityPolicy::checkInlineAndReportViolation):
 864         (WebCore::ContentSecurityPolicy::checkEvalAndReportViolation):
 865         (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation):
 866         (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
 867         (WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
 868         (WebCore::ContentSecurityPolicy::allowInlineScript):
 869         (WebCore::ContentSecurityPolicy::allowInlineStyle):
 870         (WebCore::ContentSecurityPolicy::allowEval):
 871         (WebCore::ContentSecurityPolicy::allowScriptFromSource):
 872         (WebCore::ContentSecurityPolicy::allowObjectFromSource):
 873         (WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
 874         (WebCore::ContentSecurityPolicy::allowImageFromSource):
 875         (WebCore::ContentSecurityPolicy::allowStyleFromSource):
 876         (WebCore::ContentSecurityPolicy::allowFontFromSource):
 877         (WebCore::ContentSecurityPolicy::allowMediaFromSource):
 878         (WebCore::ContentSecurityPolicy::addDirective):
 879         * page/ContentSecurityPolicy.h:
 880
 881 2011-05-01  Sam Weinig  <sam@webkit.org>
 882
 883         Reviewed by Anders Carlsson.
 884
 885         Prune some unnecessary #includes
 886         https://bugs.webkit.org/show_bug.cgi?id=59895
 887
 888         Start getting rid of unnecessary #includes and forward declares.
 889
 890         * bindings/js/JSDOMBinding.h:
 891         * bindings/js/JSDOMWindowBase.h:
 892         * bindings/js/JSDOMWindowShell.h:
 893         * bindings/js/ScheduledAction.cpp:
 894         * bindings/js/ScriptController.cpp:
 895         * bindings/js/ScriptController.h:
 896         * bindings/js/ScriptDebugServer.cpp:
 897         * editing/Editor.h:
 898         * inspector/InspectorClient.cpp:
 899         * loader/FrameLoader.h:
 900         * loader/NavigationScheduler.h:
 901         * page/Console.cpp:
 902         * xml/XMLTreeViewer.cpp:
 903         * xml/XMLTreeViewer.h:
 904
 905 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
 906
 907         [WIN] Unreviewed buildfix after r85434.
 908
 909         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
 910         (WebCore::MediaPlayerPrivate::createLayerForMovie):
 911
 912 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
 913
 914         [WIN] Unreviewed buildfix after r85434.
 915
 916         * platform/graphics/win/QTMovieVisualContext.cpp:
 917         (QTMovieVisualContext::QTMovieVisualContext): Added missing header.
 918
 919 2011-05-01  Justin Schuh  <jschuh@chromium.org>
 920
 921         Reviewed by Adam Barth.
 922
 923         History::stateObjectAdded should check origin via SecurityOrigin::canRequest
 924         https://bugs.webkit.org/show_bug.cgi?id=59840
 925
 926         Tests: fast/loader/stateobjects/pushstate-in-data-url-denied.html
 927                http/tests/navigation/replacestate-base-illegal.html
 928                http/tests/navigation/replacestate-base-legal.html
 929
 930         * page/History.cpp:
 931         (WebCore::History::stateObjectAdded):
 932
 933 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
 934
 935         [WIN] Unreviewed buildfix after r85434.
 936
 937         * platform/graphics/win/QTMovieVisualContext.cpp:
 938         (QTMovieVisualContext::QTMovieVisualContext):
 939
 940 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
 941
 942         Reviewed by Adam Barth.
 943
 944         [WINCE] Fix OwnPtr strict issues
 945         https://bugs.webkit.org/show_bug.cgi?id=59898
 946
 947         * page/wince/FrameWinCE.cpp:
 948         (WebCore::imageFromSelection):
 949         * platform/graphics/wince/FontPlatformData.cpp:
 950         (WebCore::FixedSizeFontData::create):
 951         (WebCore::FontPlatformPrivateData::FontPlatformData::hfont):
 952         (WebCore::FontPlatformPrivateData::FontPlatformData::getScaledFontHandle):
 953         (WebCore::FontPlatformPrivateData::FontPlatformData::discardFontHandle):
 954         * platform/graphics/wince/GraphicsContextWinCE.cpp:
 955         (WebCore::GraphicsContext::strokeArc):
 956         (WebCore::GraphicsContext::fillRect):
 957         (WebCore::GraphicsContext::clip):
 958         (WebCore::GraphicsContext::fillRoundedRect):
 959         (WebCore::GraphicsContext::drawRoundCorner):
 960         (WebCore::GraphicsContext::drawText):
 961         * platform/graphics/wince/ImageBufferWinCE.cpp:
 962         (WebCore::ImageBuffer::ImageBuffer):
 963         * platform/graphics/wince/ImageWinCE.cpp:
 964         (WebCore::BitmapImage::getHBITMAPOfSize):
 965         * platform/graphics/wince/SharedBitmap.cpp:
 966         (WebCore::SharedBitmap::SharedBitmap):
 967
 968 2011-05-01  Ryosuke Niwa  <rniwa@webkit.org>
 969
 970         Reviewed by Eric Seidel.
 971
 972         Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
 973         https://bugs.webkit.org/show_bug.cgi?id=59837
 974
 975         Removed EventHandler::sendContextMenuEvent(NSEvent*) and EventHandler::eventMayStartDrag(NSEvent*)
 976
 977         * WebCore.exp.in:
 978         * page/EventHandler.h:
 979         * page/mac/EventHandlerMac.mm:
 980
 981 2011-05-01  Ryosuke Niwa  <rniwa@webkit.org>
 982
 983         Reviewed by Eric Seidel.
 984
 985         Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
 986         https://bugs.webkit.org/show_bug.cgi?id=59835
 987
 988         Moved currentKeyboardEvent.
 989
 990         * WebCore.exp.in:
 991         * page/EventHandler.h:
 992         * page/mac/EventHandlerMac.mm:
 993
 994 2011-05-01  ojab  <ojab@ojab.ru>
 995
 996         Reviewed by Eric Seidel.
 997
 998         Fix build with --disable-video --enable-fullscreen-api
 999         https://bugs.webkit.org/show_bug.cgi?id=59698
1000
1001         * rendering/RenderTheme.h:
1002         (WebCore::RenderTheme::extraFullScreenStyleSheet):
1003
1004 2011-05-01  Jeff Timanus  <twiz@chromium.org>
1005
1006         Reviewed by Eric Seidel.
1007
1008         Add solid-color checking to BitmapImage::checkForSolidColour in the skia port.
1009         https://bugs.webkit.org/show_bug.cgi?id=59041
1010
1011         Test:css2.1/t140201-c533-bgimage-00-a.html
1012
1013         * platform/graphics/Image.cpp:
1014         (WebCore::Image::drawTiled): Removal of macro exclusion of assert for Skia path.
1015         * platform/graphics/skia/ImageSkia.cpp:
1016         (WebCore::BitmapImage::checkForSolidColor):
1017
1018 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
1019
1020         Reviewed by Adam Barth.
1021
1022         Fix OwnPtr strict issues in windows build
1023         https://bugs.webkit.org/show_bug.cgi?id=59878
1024
1025         * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
1026         (WebCore::getDirtyRects):
1027         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
1028         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
1029         * platform/graphics/win/WKCAImageQueue.cpp:
1030         (WebCore::WKCAImageQueue::WKCAImageQueue):
1031         * platform/win/CursorWin.cpp:
1032         (WebCore::createSharedCursor):
1033         * platform/win/PasteboardWin.cpp:
1034         (WebCore::Pasteboard::writeImage):
1035
1036 2011-05-01  Patrick Gansterer  <paroga@webkit.org>
1037
1038         Reviewed by Eric Seidel.
1039
1040         Use PassOwnPtr as return value of GraphicsContext::createWindowsBitmap
1041         https://bugs.webkit.org/show_bug.cgi?id=59876
1042
1043         Also pass the size "as reference" instead of "as value".
1044
1045         * platform/graphics/GraphicsContext.h:
1046         * platform/graphics/win/FontCGWin.cpp:
1047         (WebCore::drawGDIGlyphs):
1048         * platform/graphics/win/GraphicsContextWin.cpp:
1049         (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap):
1050         (WebCore::GraphicsContext::createWindowsBitmap):
1051         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
1052         (WebCore::MediaPlayerPrivate::paint):
1053
1054 2011-05-01  Emil A Eklund  <eae@chromium.org>
1055
1056         Reviewed by Eric Seidel.
1057
1058         getComputedStyle() returns unitless values for some properties that require units
1059         https://bugs.webkit.org/show_bug.cgi?id=55111
1060
1061         Change getComputedStyle to return value with unit for -webkit-column-width, -webkit-column-gap and -webkit-perspective
1062
1063         Test: fast/css/getComputedStyle/getComputedStyle-length-unit.html
1064
1065         * css/CSSComputedStyleDeclaration.cpp:
1066         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1067
1068 2011-05-01  Young Han Lee  <joybro@company100.net>
1069
1070         Reviewed by Eric Seidel.
1071
1072         Change TEXMAP_OPENGL_ES2 to TEXMAP_OPENGL_ES_2
1073         https://bugs.webkit.org/show_bug.cgi?id=59608
1074
1075         TEXMAP_OPENGL_ES2 is a wrong name. TEXMAP_OPENGL_ES_2 is already defined in TextureMapper.h
1076
1077         No new functionality, no new tests.
1078
1079         * platform/graphics/opengl/TextureMapperGL.cpp:
1080         (WebCore::TextureMapperGL::TextureMapperGL):
1081
1082 2011-05-01  Yael Aharon  <yael.aharon@nokia.com>
1083
1084         Reviewed by Eric Seidel.
1085
1086         CSS3 nth-child(n) selector fails
1087         https://bugs.webkit.org/show_bug.cgi?id=56943
1088
1089         Regression from r75158.
1090         "n" is a valid parameter to nth() and should be allowed.
1091
1092         Test: fast/css/nth-child-n.html
1093
1094         * css/CSSParser.cpp:
1095         (WebCore::isValidNthToken):
1096
1097 2011-05-01  Pavel Feldman  <pfeldman@chromium.org>
1098
1099         Not reviewed: address stack frame scriptName -> url rename in timeline panel.
1100
1101         * inspector/front-end/TimelinePanel.js:
1102         (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
1103         (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
1104
1105 2011-05-01  Chris Fleizach  <cfleizach@apple.com>
1106
1107         Reviewed by Maciej Stachowiak.
1108
1109         Crash in AccessibilityRenderObject while viewing PDFs in iframes
1110         https://bugs.webkit.org/show_bug.cgi?id=59629
1111
1112         Could not reproduce this crash, but it's quite clear how it could happen.
1113
1114         * accessibility/AccessibilityRenderObject.cpp:
1115         (WebCore::AccessibilityRenderObject::accessibilityHitTest):
1116
1117 2011-05-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1118
1119         Reviewed by Dirk Schulze.
1120
1121         LEAK: SVGElement leaks when detaching it in a pending resource state
1122         https://bugs.webkit.org/show_bug.cgi?id=59072
1123
1124         Make the pending resources set non-refcounted again. We made it refcounted a while ago
1125         to fix a security bug, as we had dangling pointers in the set in SVGDocumentExtensions.
1126         Fix the underlying problem, by removing all pending resources referencing to a particular
1127         SVGElement, upon its destruction or upon removing it from the document.
1128
1129         Example: <rect fill="url(#foo)" id="rect">
1130         When we try to render the rect, the foo paint server can't be found and thus "foo" will be
1131         added to the pending resource set, with "rect" as client. When "foo" appears, it would remove
1132         itself from the pending resource set, and a ref count to the "rect" would be released.
1133         If "foo" never appears, SVGDocumentExtensions still holds a ref to the <rect>, thus keeping
1134         it and the associated document alive.
1135
1136         Tests: svg/custom/pending-resource-leak-2.svg
1137                svg/custom/pending-resource-leak-3.svg
1138                svg/custom/pending-resource-leak.svg
1139
1140         These tests cover several scenarios where we used to leak. Should fix several SVG*Element leaks on the bots.
1141         I manually tested reloading above testcases dozens of times, before the leak count was incremented by 2 nodes on every reload, that's gone now.
1142
1143         * rendering/svg/RenderSVGResourceContainer.cpp:
1144         (WebCore::RenderSVGResourceContainer::registerResource):
1145         * rendering/svg/RenderSVGShadowTreeRootContainer.cpp:
1146         (WebCore::RenderSVGShadowTreeRootContainer::updateFromElement):
1147         * rendering/svg/SVGResources.cpp:
1148         (WebCore::registerPendingResource):
1149         * svg/SVGDocumentExtensions.cpp:
1150         (WebCore::SVGDocumentExtensions::addPendingResource):
1151         (WebCore::SVGDocumentExtensions::hasPendingResources):
1152         (WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
1153         (WebCore::SVGDocumentExtensions::removePendingResource):
1154         * svg/SVGDocumentExtensions.h:
1155         * svg/SVGElement.cpp:
1156         * svg/SVGElement.h:
1157         * svg/SVGElementRareData.h:
1158         (WebCore::SVGElementRareData::SVGElementRareData):
1159         (WebCore::SVGElementRareData::hasPendingResources):
1160         (WebCore::SVGElementRareData::setHasPendingResources):
1161         * svg/SVGStyledElement.cpp:
1162         (WebCore::SVGStyledElement::~SVGStyledElement):
1163         (WebCore::SVGStyledElement::insertedIntoDocument):
1164         (WebCore::SVGStyledElement::removedFromDocument):
1165         (WebCore::SVGStyledElement::hasPendingResources):
1166         (WebCore::SVGStyledElement::setHasPendingResources):
1167         * svg/SVGStyledElement.h:
1168         (WebCore::SVGStyledElement::needsPendingResourceHandling):
1169         (WebCore::SVGStyledElement::buildPendingResource):
1170         * svg/SVGUseElement.cpp:
1171         (WebCore::SVGUseElement::SVGUseElement):
1172         (WebCore::SVGUseElement::insertedIntoDocument):
1173         (WebCore::SVGUseElement::svgAttributeChanged):
1174         (WebCore::SVGUseElement::buildPendingResource):
1175         * svg/SVGUseElement.h:
1176
1177 2011-05-01  Rafael Brandao  <rafael.lobo@openbossa.org>
1178
1179         Reviewed by Csaba Osztrogonác.
1180
1181         [Qt] build-webkit warning Inspector.idl is missing
1182         https://bugs.webkit.org/show_bug.cgi?id=59047
1183
1184         Added variable_out to pipe output from one compiler to another,
1185         and then forced the output to be added to the sources.
1186
1187         * CodeGenerators.pri:
1188
1189 2011-05-01  Dan Bernstein  <mitz@apple.com>
1190
1191         Reviewed by Anders Carlsson.
1192
1193         <rdar://problem/9155067> REGRESSION (float-based line boxes): Gaps and overlaps in selection highlight
1194         https://bugs.webkit.org/show_bug.cgi?id=56658
1195
1196         Test: fast/text/selection-rect-rounding.html
1197
1198         * platform/graphics/FontFastPath.cpp:
1199         (WebCore::Font::selectionRectForSimpleText): Account for non-integral anchor point coordinates.
1200         * platform/graphics/mac/FontComplexTextMac.cpp:
1201         (WebCore::Font::selectionRectForComplexText): Ditto.
1202         * rendering/InlineTextBox.cpp:
1203         (WebCore::InlineTextBox::selectionRect): Floor the horizontal sides of the clip rect.
1204         (WebCore::InlineTextBox::paintSelection): Pass the logical left location to Font::selectionRectForText(),
1205         since it affects rounding.
1206
1207 2011-04-30  Justin Schuh  <jschuh@chromium.org>
1208
1209         Reviewed by Dirk Schulze.
1210
1211         Make RenderSVGResourceFilter take ownership of filter data when painting
1212         https://bugs.webkit.org/show_bug.cgi?id=51524
1213
1214         Test: svg/custom/filter-on-svgimage.svg
1215
1216         * rendering/svg/RenderSVGResourceFilter.cpp:
1217         (WebCore::RenderSVGResourceFilter::removeClientFromCache):
1218         (WebCore::RenderSVGResourceFilter::postApplyResource):
1219         * rendering/svg/RenderSVGResourceFilter.h:
1220         (WebCore::FilterData::FilterData):
1221
1222 2011-04-30  Martin Robinson  <mrobinson@igalia.com>
1223
1224         Reviewed by Adam Barth.
1225
1226         Enable strict mode for OwnPtr and PassOwnPtr
1227         https://bugs.webkit.org/show_bug.cgi?id=59428
1228
1229         Fix assignments and .set() calls with OwnPtr to use adoptPtr. Have GeolocationService
1230         factory methods return a PassOwnPtr.
1231
1232         No new tests. This should not change functionality.
1233
1234         * platform/GeolocationService.cpp:
1235         (WebCore::createGeolocationServiceNull):
1236         (WebCore::GeolocationService::create):
1237         * platform/GeolocationService.h:
1238         * platform/android/GeolocationServiceAndroid.cpp:
1239         (WebCore::GeolocationServiceAndroid::create):
1240         * platform/android/GeolocationServiceAndroid.h:
1241         * platform/efl/GeolocationServiceEfl.cpp:
1242         (WebCore::GeolocationServiceEfl::create):
1243         * platform/efl/GeolocationServiceEfl.h:
1244         * platform/graphics/cairo/CairoUtilities.cpp:
1245         (WebCore::appendPathToCairoContext):
1246         * platform/graphics/cairo/GraphicsContextCairo.cpp:
1247         (WebCore::drawPathShadow):
1248         (WebCore::GraphicsContext::clip):
1249         * platform/graphics/cairo/ImageBufferCairo.cpp:
1250         (WebCore::ImageBuffer::ImageBuffer):
1251         * platform/graphics/cairo/OwnPtrCairo.h:
1252         * platform/graphics/cairo/PathCairo.cpp:
1253         (WebCore::Path::Path):
1254         (WebCore::Path::operator=):
1255         (WebCore::Path::apply):
1256         * platform/gtk/GeolocationServiceGtk.cpp:
1257         (WebCore::GeolocationServiceGtk::create):
1258         * platform/gtk/GeolocationServiceGtk.h:
1259         * platform/mock/GeolocationServiceMock.cpp:
1260         (WebCore::GeolocationServiceMock::create):
1261         * platform/mock/GeolocationServiceMock.h:
1262
1263 2011-04-30  Pavel Feldman  <pfeldman@chromium.org>
1264
1265         Not reviewed: inspector toolbar titles were 2px off.
1266
1267         * inspector/front-end/inspector.css:
1268         (#toolbar-dropdown .toolbar-label):
1269
1270 2011-04-30  Mihai Parparita  <mihaip@chromium.org>
1271
1272         Reviewed by Eric Seidel.
1273
1274         V8Proxy.h shouldn't include SecurityOrigin.h
1275         https://bugs.webkit.org/show_bug.cgi?id=59859
1276
1277         Remove SecurityOrigin.h #include from V8Proxy.h. Touching
1278         SecurityOrigin.h now rebuilds 234 targets instead of 638 (when building
1279         chromium's DumpRenderTree).
1280
1281         * bindings/v8/NPV8Object.cpp:
1282         * bindings/v8/V8Proxy.cpp:
1283         * bindings/v8/V8Proxy.h:
1284         * css/CSSStyleSelector.cpp:
1285         * dom/XMLDocumentParserLibxml2.cpp:
1286         * html/HTMLLinkElement.cpp:
1287         * loader/SubframeLoader.cpp:
1288         * page/History.cpp:
1289         * storage/IDBFactory.cpp:
1290         * storage/StorageAreaImpl.cpp:
1291
1292 2011-04-29  Adam Barth  <abarth@webkit.org>
1293
1294         Reviewed by Eric Seidel.
1295
1296         CSP script-src should block eval
1297         https://bugs.webkit.org/show_bug.cgi?id=59850
1298
1299         Rather than have JavaScriptCore call back into WebCore to learn whether
1300         eval is enabled, we push that bit of the policy into JavaScriptCore.
1301
1302         Tests: http/tests/security/contentSecurityPolicy/eval-allowed.html
1303                http/tests/security/contentSecurityPolicy/eval-blocked.html
1304
1305         * bindings/js/ScriptController.cpp:
1306         (WebCore::ScriptController::disableEval):
1307         * bindings/js/ScriptController.h:
1308         * page/ContentSecurityPolicy.cpp:
1309         (WebCore::ContentSecurityPolicy::didReceiveHeader):
1310         (WebCore::ContentSecurityPolicy::internalAllowEval):
1311         (WebCore::ContentSecurityPolicy::allowEval):
1312         * page/ContentSecurityPolicy.h:
1313
1314 2011-04-29  Joseph Pecoraro  <joepeck@webkit.org>
1315
1316         GTK build fix. Missed moving DateComponents and
1317         adding LocalizedDate files for their build file.
1318
1319         * GNUmakefile.list.am:
1320
1321 2011-04-29  Adam Barth  <abarth@webkit.org>
1322
1323         Reviewed by Eric Seidel.
1324
1325         style-src should block @style
1326         https://bugs.webkit.org/show_bug.cgi?id=59293
1327
1328         This patch blocks @style when style-src doesn't have the
1329         'unsafe-inline' token.  This patch blocks the parsing of the attribute
1330         itself.  That feels vaguely like too low a level to interpose the
1331         policy, but there didn't seem to be anywhere else natural to enforce
1332         the policy.
1333
1334         Tests: http/tests/security/contentSecurityPolicy/inline-style-attribute-allowed.html
1335                http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked.html
1336                http/tests/security/contentSecurityPolicy/inline-style-on-html.html
1337
1338         * dom/StyledElement.cpp:
1339         (WebCore::StyledElement::parseMappedAttribute):
1340
1341 2011-04-29  Joseph Pecoraro  <joepeck@webkit.org>
1342
1343         Reviewed by Kent Tamura.
1344
1345         Allow Localized Date Strings for Date Input Fields
1346         https://bugs.webkit.org/show_bug.cgi?id=59752
1347
1348         Test: fast/forms/date-input-visible-strings.html
1349
1350         * CMakeLists.txt:
1351         * WebCore.gypi:
1352         * WebCore.pro:
1353         * WebCore.vcproj/WebCore.vcproj:
1354         * WebCore.xcodeproj/project.pbxproj: update build files for
1355         moving DateComponents from WebCore/html to WebCore/platform
1356         and adding the LocalizedDate files.
1357
1358         * html/BaseDateAndTimeInputType.cpp:
1359         (WebCore::BaseDateAndTimeInputType::serialize):
1360         (WebCore::BaseDateAndTimeInputType::serializeWithComponents):
1361         (WebCore::BaseDateAndTimeInputType::serializeWithMilliseconds):
1362         InputType::serialize for a double value with date types is
1363         different for the month type because it assumes the incoming
1364         value is months instead of msecs (matching valueAsNumber in
1365         HTML5).  So provide a more general serialization function,
1366         serializeWithComponents, that will always serialize a string
1367         correctly for the current type but taking in a DateComponents
1368         object. The default serialize, and new serializeWithMilliseconds,
1369         can fall back to this and allows an override point for
1370         the month type.
1371
1372         * html/MonthInputType.cpp:
1373         (WebCore::MonthInputType::serializeWithMilliseconds): the month
1374         type is a case where the default serialize does not take msec,
1375         so provide an implementation for month which handles msec input.
1376
1377         * html/BaseDateAndTimeInputType.cpp:
1378         (WebCore::BaseDateAndTimeInputType::setValueAsDate): switch
1379         to serializeWithMilliseconds as the incoming date value is msec.
1380         * html/MonthInputType.cpp:
1381         (WebCore::MonthInputType::setValueAsDate): removed.
1382
1383         * html/BaseDateAndTimeInputType.cpp:
1384         (WebCore::BaseDateAndTimeInputType::visibleValue): allow
1385         localized formatting of a date value.
1386         (WebCore::BaseDateAndTimeInputType::convertFromVisibleValue):
1387         allow parsing for a formatted date value.
1388
1389         * html/BaseDateAndTimeInputType.h:
1390         * platform/DateComponents.cpp: Renamed from Source/WebCore/html/DateComponents.cpp.
1391         Expose the Type enum so it can be used outside of the DateComponents class.
1392         * platform/text/LocalizedDate.h: Added.
1393         * platform/text/LocalizedDateNone.cpp: Added.
1394         (WebCore::formatLocalizedDate): Default implementation falls back to
1395         existing HTML5 date input value formatting.
1396
1397         * html/BaseDateAndTimeInputType.h:
1398         * html/DateInputType.cpp:
1399         (WebCore::DateInputType::dateType):
1400         * html/DateInputType.h:
1401         * html/DateTimeInputType.cpp:
1402         (WebCore::DateTimeInputType::dateType):
1403         * html/DateTimeInputType.h:
1404         * html/DateTimeLocalInputType.cpp:
1405         (WebCore::DateTimeLocalInputType::dateType):
1406         * html/DateTimeLocalInputType.h:
1407         * html/MonthInputType.cpp:
1408         (WebCore::MonthInputType::dateType):
1409         * html/MonthInputType.h:
1410         * html/TimeInputType.cpp:
1411         (WebCore::TimeInputType::dateType):
1412         * html/TimeInputType.h:
1413         * html/WeekInputType.cpp:
1414         (WebCore::WeekInputType::dateType):
1415         * html/WeekInputType.h: Accessors for the desired date
1416         type of a date input type. This allows the base class
1417         to write a generic algorithm.
1418
1419 2011-04-29  Adam Barth  <abarth@webkit.org>
1420
1421         Reviewed by Eric Seidel.
1422
1423         style-src should block inline style from <style>
1424         https://bugs.webkit.org/show_bug.cgi?id=59292
1425
1426         The spec has been updated to allow blocking of inline styles with
1427         style-src.  This will help folks defend against tricky CSS3 injections.
1428
1429         This patch covers the <style> case.  The next patch will cover the
1430         @style case.
1431
1432         Tests: http/tests/security/contentSecurityPolicy/inline-style-allowed.html
1433                http/tests/security/contentSecurityPolicy/inline-style-blocked.html
1434
1435         * dom/StyleElement.cpp:
1436         (WebCore::StyleElement::createSheet):
1437         * page/ContentSecurityPolicy.cpp:
1438         (WebCore::ContentSecurityPolicy::allowInlineStyle):
1439         * page/ContentSecurityPolicy.h:
1440
1441 2011-04-29  Chris Evans  <cevans@chromium.org>
1442
1443         Reviewed by Adam Barth.
1444
1445         Add WebCore::Setting to block displaying and/or running insecure content on secure pages
1446         https://bugs.webkit.org/show_bug.cgi?id=58378
1447
1448         Test: To follow in subsequent patch, including the wiring to expose the new settings to LayoutTests.
1449
1450         * loader/FrameLoader.cpp:
1451         (WebCore::FrameLoader::checkIfDisplayInsecureContent): Return whether or not the load should be blocked, and tweak the message upon blocking.
1452         (WebCore::FrameLoader::checkIfRunInsecureContent): Return whether or not the load should be blocked, and tweak the message upon blocking.
1453         * loader/FrameLoader.h:
1454         * loader/MainResourceLoader.cpp:
1455         (WebCore::MainResourceLoader::willSendRequest): Check if the frame load is blocked due to mixed content and cancel it if so. The check was moved up so that it occurs before firing the load callbacks, to avoid any outgoing network hits or accounting. Redirects are handled because willSendRequest is called for each one in the chain.
1456         * loader/SubframeLoader.cpp:
1457         (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin): Handle the blocking of mixed-content plug-in loads.
1458         (WebCore::SubframeLoader::loadPlugin): Handle the blocking of mixed-content plug-in loads.
1459         * loader/cache/CachedResourceLoader.cpp:
1460         (WebCore::CachedResourceLoader::canRequest): Handle the blocking of various loads due to mixed content conditions.
1461         * page/Settings.cpp:
1462         (WebCore::Settings::Settings): Permit mixed-content loads by default to avoid a change in behavior by default.
1463         * page/Settings.h: Add two new booleans to control blocking of mixed content (displaying and running thereof).
1464         (WebCore::Settings::setAllowDisplayOfInsecureContent):
1465         (WebCore::Settings::allowDisplayOfInsecureContent):
1466         (WebCore::Settings::setAllowRunningOfInsecureContent):
1467         (WebCore::Settings::allowRunningOfInsecureContent):
1468
1469 2011-04-29  Ryosuke Niwa  <rniwa@webkit.org>
1470
1471         Reviewed by Eric Seidel.
1472
1473         Extract a function to obtain VisiblePosition from RenderText::positionForPoint
1474         https://bugs.webkit.org/show_bug.cgi?id=59811
1475
1476         Extracted lineDirectionPointFitsInBox from positionForPoint.
1477
1478         * rendering/RenderText.cpp:
1479         (WebCore::lineDirectionPointFitsInBox):
1480         (WebCore::RenderText::positionForPoint):
1481
1482 2011-04-29  Geoffrey Garen  <ggaren@apple.com>
1483
1484         Reviewed by Alexey Proskuryakov.
1485
1486         REGRESSION: r83938 abandons GC memory
1487         https://bugs.webkit.org/show_bug.cgi?id=59604
1488
1489         This bug was caused by script and image elements waiting indefinitely
1490         for their loads to finish.
1491
1492         * bindings/js/JSNodeCustom.cpp:
1493         (WebCore::isReachableFromDOM): Don't test for the load event firing,
1494         since the load event doesn't fire in cases of canceled or errored loads.
1495         Instead, test hasPendingActivity().
1496
1497         Don't do this test at all for script elements because script elements
1498         can't load while outside the document. (fast/dom/script-element-gc.html
1499         verifies that this is correct.)
1500
1501         * html/HTMLImageElement.cpp:
1502         (WebCore::HTMLImageElement::hasPendingActivity):
1503         * html/HTMLImageElement.h:
1504         * loader/ImageLoader.cpp:
1505         (WebCore::ImageEventSender::hasPendingEvents):
1506         (WebCore::ImageLoader::hasPendingLoadEvent):
1507         * loader/ImageLoader.h: Added API for finding out if an image element
1508         has pending activity.
1509
1510         * loader/cache/CachedResource.cpp:
1511         (WebCore::CachedResource::setRequest): All loads are supposed to end in
1512         data(allDataReceived = true) or error(), but in the edge case of a
1513         canceled load, all we get is a call to setRequest(0). Be sure to
1514         record that we're no longer loading in that case, otherwise our element
1515         will leak forever, waiting for its load to complete.
1516
1517 2011-04-29  Emil Eklund  <eae@chromium.org>
1518
1519         Reviewed by Tony Chang.
1520
1521         Setting outerHTML should merge text nodes
1522         https://bugs.webkit.org/show_bug.cgi?id=52686
1523
1524         When setting outerHTML adjacent text nodes should be merged. This matches
1525         the behavior of outerText and the IE implementation of outerHTML.
1526
1527         Test: fast/dom/set-outer-html.html
1528
1529         * html/HTMLElement.cpp:
1530         (WebCore::mergeWithNextTextNode): Move function to before setOuterHTML.
1531         (WebCore::HTMLElement::setOuterHTML): Merge adjacent text nodes after replacing the element.
1532
1533 2011-04-29  Emil A Eklund  <eae@chromium.org>
1534
1535         Reviewed by Dimitri Glazkov.
1536
1537         Onchange on text fields has an incoherent behavior
1538         https://bugs.webkit.org/show_bug.cgi?id=57330
1539
1540         * html/HTMLFormControlElement.cpp:
1541         (WebCore::HTMLTextFormControlElement::insertedIntoDocument):
1542         Initialize m_textAsOfLastFormControlChangeEvent to empty string rather
1543         than null for empty fields.
1544
1545 2011-04-29  Csaba Osztrogonác  <ossy@webkit.org>
1546
1547         [Qt] Unreviewed buildfix after r85343.
1548
1549         Enable strict OwnPtr for Qt
1550         https://bugs.webkit.org/show_bug.cgi?id=59667
1551
1552         * plugins/mac/PluginViewMac.mm:
1553         (WebCore::PluginView::platformStart):
1554
1555 2011-04-29  Jon Lee  <jonlee@apple.com>
1556
1557         Reviewed by mitzpettel.
1558
1559         REGRESSION (WebKit2): (Mac) Selection is gone after switching tabs (59721)
1560         <rdar://problem/9327332>
1561         https://bugs.webkit.org/show_bug.cgi?id=59721
1562
1563         Removing shouldClearSelectionWhenLosingWebPageFocus().  Reverting changelist 83814.
1564
1565         * WebCore.exp.in:
1566         * editing/EditingBehavior.h:
1567
1568 2011-04-29  Abhishek Arya  <inferno@chromium.org>
1569
1570         Reviewed by Dave Hyatt.
1571
1572         Allow only first table caption and destroy the remaining ones.
1573         https://bugs.webkit.org/show_bug.cgi?id=58249
1574
1575         Previously, we were only laying out the first table caption.
1576         However Table::layout didn't mark the other ones as not needing
1577         layout. So after table layout completes, table is marked as not
1578         needing layout with its other table caption still needing layout.
1579         This causes incorrect layout root calculations and set it to a
1580         node which is already getting deleted.
1581
1582         Tests: fast/table/dynamic-caption-add-before-child.xhtml
1583                fast/table/dynamic-caption-add-remove-before-child.xhtml
1584                fast/table/multiple-captions-crash.xhtml
1585                fast/table/multiple-captions-crash2.xhtml
1586                fast/table/multiple-captions-display.xhtml
1587
1588         * rendering/RenderTable.cpp:
1589         (WebCore::RenderTable::addChild): when new caption or a before
1590         child caption is added, we need to explicitly trigger section
1591         recalc or otherwise layout won't catch it.
1592         (WebCore::RenderTable::removeChild): when child to be removed is
1593         m_caption, make sure to trigger style recalc on the table.
1594         (WebCore::RenderTable::recalcCaption): code to destroy captions
1595         other than the first one.
1596         (WebCore::RenderTable::recalcSections): call recalcCaption
1597         helper. Store the next sibling early since child can get destroyed
1598         in recalcCaption.
1599         * rendering/RenderTable.h:
1600
1601 2011-04-29  David Kilzer  <ddkilzer@apple.com>
1602
1603         Remove WML
1604         https://bugs.webkit.org/show_bug.cgi?id=59678
1605
1606         * DerivedSources.make: Removed $(WebCore)/wml path in VPATH.
1607
1608 2011-04-29  James Robinson  <jamesr@chromium.org>
1609
1610         Unreviewed, rolling out r85330.
1611         http://trac.webkit.org/changeset/85330
1612         https://bugs.webkit.org/show_bug.cgi?id=41311
1613
1614         Caused unexpected border rendering change on 500 tests on chromium linux.
1615
1616         * platform/graphics/skia/GraphicsContextSkia.cpp:
1617         (WebCore::GraphicsContext::drawConvexPolygon):
1618         (WebCore::GraphicsContext::clipConvexPolygon):
1619
1620 2011-04-29  Csaba Osztrogonác  <ossy@webkit.org>
1621
1622         [Qt] Unreviewed buildfix after r85343.
1623
1624         Enable strict OwnPtr for Qt
1625         https://bugs.webkit.org/show_bug.cgi?id=59667
1626
1627         * plugins/win/PluginViewWin.cpp:
1628         (WebCore::PluginView::wndProc):
1629         (WebCore::PluginView::snapshot):
1630
1631 2011-04-29  Csaba Osztrogonác  <ossy@webkit.org>
1632
1633         Reviewed by Adam Barth.
1634
1635         Enable strict OwnPtr for Qt
1636         https://bugs.webkit.org/show_bug.cgi?id=59667
1637
1638         * platform/graphics/qt/ImageBufferQt.cpp:
1639         (WebCore::ImageBufferData::ImageBufferData):
1640         (WebCore::ImageBuffer::ImageBuffer):
1641         * platform/graphics/qt/ImageDecoderQt.cpp:
1642         (WebCore::ImageDecoderQt::setData):
1643         * platform/graphics/qt/ImageDecoderQt.h:
1644         * platform/network/qt/QNetworkReplyHandler.cpp:
1645         (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
1646         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
1647
1648 2011-04-29  Dean Jackson  <dino@apple.com>
1649
1650         Reviewed by Simon Fraser.
1651
1652         Add ENABLE macro for WebKitAnimation
1653         https://bugs.webkit.org/show_bug.cgi?id=59729
1654
1655         Add new feature to toggle WebKit Animation API.
1656
1657         * Configurations/FeatureDefines.xcconfig:
1658         * GNUmakefile.am:
1659         * dom/Element.idl:
1660         * features.pri:
1661         * page/DOMWindow.idl:
1662
1663 2011-04-29  Dean Jackson  <dino@apple.com>
1664
1665         Reviewed by Simon Fraser.
1666
1667         https://bugs.webkit.org/show_bug.cgi?id=59149
1668         (Regression) Existing animations are not replaced when filling.
1669
1670         Hardware animations that fill forwards were not being correctly
1671         replaced when the animation was removed. The actual animation
1672         logic was working correctly, but it wasn't deleting the
1673         CoreAnimation animation from the PlatformLayer. The fix was
1674         to explicitly call endAnimation when disconnecting the animation
1675         from its RenderObject.
1676
1677         Test: animations/3d/replace-filling-transform.html
1678
1679         * page/animation/AnimationBase.h:
1680         (WebCore::AnimationBase::clear): call endAnimation as the animation is cleared
1681
1682 2011-04-29  Abhishek Arya  <inferno@chromium.org>
1683
1684         Reviewed by Nikolas Zimmermann.
1685
1686         When svg inline text is getting destroyed, make sure to mark
1687         its svg text ancestor as needing a positioning values update.
1688         This helps to recalculate layout attributes and makes sure
1689         that svg inline text is not used again.
1690         https://bugs.webkit.org/show_bug.cgi?id=59161
1691
1692         Test: svg/text/inline-text-destroy-attributes-crash.xhtml
1693
1694         * rendering/svg/RenderSVGInlineText.cpp:
1695         (WebCore::RenderSVGInlineText::destroy):
1696         * rendering/svg/RenderSVGInlineText.h:
1697
1698 2011-04-29  Kevin Ollivier  <kevino@theolliviers.com>
1699
1700         [wx] Unreviewed build fix. Fix wxMSW trunk builds by adding include.
1701
1702         * platform/graphics/wx/GraphicsContextWx.cpp:
1703
1704 2011-04-29  Mike Reed  <reed@google.com>
1705
1706         Reviewed by Ojan Vafai.
1707
1708         Skia: Need to implement GraphicsContext::clipConvexPolygon()
1709         https://bugs.webkit.org/show_bug.cgi?id=41311
1710
1711         This does not (yet) enable HAVE_PATH_BASED_BORDER_RADIUS_DRAWING
1712         as that shows other issues/question unrelated to clipping.
1713         https://bugs.webkit.org/show_bug.cgi?id=41311
1714
1715         No new tests. covered by existing layout tests
1716
1717         * platform/graphics/skia/GraphicsContextSkia.cpp:
1718         (WebCore::setPathFromConvexPoints):
1719         (WebCore::GraphicsContext::drawConvexPolygon):
1720         (WebCore::GraphicsContext::clipConvexPolygon):
1721
1722 2011-04-29  Mike Lawther  <mikelawther@chromium.org>
1723
1724         Reviewed by Ojan Vafai.
1725
1726         Fix IR->SR typo in enum value (and resulting style fails)
1727         https://bugs.webkit.org/show_bug.cgi?id=59779
1728
1729         No functionality change, so no new tests
1730
1731         * css/CSSPrimitiveValueMappings.h:
1732         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1733         (WebCore::CSSPrimitiveValue::operator EShapeRendering):
1734
1735 2011-04-29  Pavel Feldman  <pfeldman@google.com>
1736
1737         Reviewed by Yury Semikhatsky.
1738
1739         Web Inspector: CSS editing breaks when entering "color: rgb(1"
1740         https://bugs.webkit.org/show_bug.cgi?id=59789
1741
1742         Tests: inspector/styles/styles-add-invalid-property.html
1743                inspector/styles/styles-cancel-editing.html
1744                inspector/styles/styles-commit-editing.html
1745
1746         * inspector/front-end/CSSStyleModel.js:
1747         (WebInspector.CSSProperty.prototype.setText.callback):
1748         (WebInspector.CSSProperty.prototype.setText):
1749         * inspector/front-end/StylesSidebarPane.js:
1750         (WebInspector.StylePropertyTreeElement.prototype.selectElement):
1751         (WebInspector.StylePropertyTreeElement.prototype):
1752         (WebInspector.StylePropertyTreeElement.prototype.styleText.updateInterface.majorChange.isRevert.originalPropertyText):
1753         * inspector/front-end/inspector.js:
1754         (WebInspector.startEditing.defaultFinishHandler):
1755         (WebInspector.startEditing.keyDownEventListener):
1756         (WebInspector.startEditing):
1757
1758 2011-04-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1759
1760         Reviewed by Simon Hausmann.
1761
1762         ENABLE(QT_BEARER) -> USE(QT_BEARER)
1763
1764         * WebCore.pri:
1765         * WebCore.pro:
1766         * features.pri:
1767         * platform/network/NetworkStateNotifier.h:
1768         * platform/network/qt/NetworkStateNotifierQt.cpp:
1769
1770 2011-04-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1771
1772         Reviewed by Simon Hausmann.
1773
1774         ENABLE(QT_USERAGENT_DEVICEMODEL) -> USE(QT_MOBILITY_SYSTEMINFO)
1775
1776         * WebCore.pri:
1777         * features.pri:
1778
1779 2011-04-29  Pavel Podivilov  <podivilov@chromium.org>
1780
1781         Reviewed by Pavel Feldman.
1782
1783         Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
1784         https://bugs.webkit.org/show_bug.cgi?id=59476
1785
1786         * inspector/front-end/DebuggerPresentationModel.js:
1787         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
1788         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
1789         (WebInspector.PresentationBreakpoint.prototype.serialize):
1790         * inspector/front-end/ScriptsPanel.js:
1791         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
1792         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
1793         (WebInspector.ScriptsPanel.prototype.reset):
1794
1795 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
1796
1797         Reviewed by Yury Semikhatsky.
1798
1799         Web Inspector: include script end line:column in scriptParsed parameters.
1800         https://bugs.webkit.org/show_bug.cgi?id=59717
1801
1802         * bindings/js/ScriptDebugServer.cpp:
1803         (WebCore::ScriptDebugServer::dispatchDidParseSource):
1804         * bindings/v8/DebuggerScript.js:
1805         ():
1806         * bindings/v8/ScriptDebugServer.cpp:
1807         (WebCore::ScriptDebugServer::dispatchDidParseSource):
1808         * inspector/Inspector.json:
1809         * inspector/InspectorDebuggerAgent.cpp:
1810         (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
1811         (WebCore::InspectorDebuggerAgent::didParseSource):
1812         * inspector/InspectorDebuggerAgent.h:
1813         (WebCore::InspectorDebuggerAgent::Script::Script):
1814         * inspector/ScriptDebugListener.h:
1815         * inspector/front-end/DebuggerModel.js:
1816         (WebInspector.DebuggerModel.prototype._parsedScriptSource):
1817         (WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
1818         (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
1819         * inspector/front-end/Script.js:
1820         (WebInspector.Script):
1821
1822 2011-04-28  Yury Semikhatsky  <yurys@chromium.org>
1823
1824         Reviewed by Pavel Feldman.
1825
1826         Web Inspector: [protocol] Evaluate should expose thrown exception value
1827         https://bugs.webkit.org/show_bug.cgi?id=59000
1828
1829         Each evaluation command may have either thrown or returned result. This is indicated
1830         by wasThrown property in the protocol.
1831
1832         * inspector/InjectedScript.cpp:
1833         (WebCore::InjectedScript::evaluate):
1834         (WebCore::InjectedScript::evaluateOn):
1835         (WebCore::InjectedScript::evaluateOnCallFrame):
1836         (WebCore::InjectedScript::getProperties):
1837         (WebCore::InjectedScript::makeEvalCall):
1838         * inspector/InjectedScript.h:
1839         * inspector/InjectedScriptSource.js:
1840         * inspector/Inspector.json: Removed "error" remote object type, added "wasThrown" property to
1841         the evaluation results.
1842         * inspector/InspectorDebuggerAgent.cpp:
1843         (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
1844         * inspector/InspectorDebuggerAgent.h:
1845         * inspector/InspectorRuntimeAgent.cpp:
1846         (WebCore::InspectorRuntimeAgent::evaluate):
1847         (WebCore::InspectorRuntimeAgent::evaluateOn):
1848         (WebCore::InspectorRuntimeAgent::getProperties):
1849         * inspector/InspectorRuntimeAgent.h:
1850         * inspector/front-end/ConsoleView.js:
1851         (WebInspector.ConsoleView.prototype.completions.evaluated):
1852         (WebInspector.ConsoleView.prototype.evalInInspectedWindow):
1853         (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult):
1854         (WebInspector.ConsoleView.prototype._enterKeyPressed):
1855         (WebInspector.ConsoleCommandResult):
1856         * inspector/front-end/DebuggerPresentationModel.js:
1857         (WebInspector.PresenationCallFrame.prototype.evaluate):
1858         * inspector/front-end/ElementsTreeOutline.js:
1859         (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
1860         * inspector/front-end/ExtensionPanel.js:
1861         (WebInspector.ExtensionSidebarPane.prototype._onEvaluate):
1862         * inspector/front-end/ExtensionServer.js:
1863         (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
1864         * inspector/front-end/ObjectPropertiesSection.js:
1865         (WebInspector.ObjectPropertyTreeElement.prototype.update):
1866         * inspector/front-end/PropertiesSidebarPane.js:
1867         (WebInspector.PropertiesSidebarPane.prototype.update.nodePrototypesReady):
1868         * inspector/front-end/SourceFrame.js:
1869         (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
1870         (WebInspector.SourceFrame.prototype._showPopup):
1871
1872 2011-04-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1873
1874         Unreviewed, rolling out r85315.
1875         http://trac.webkit.org/changeset/85315
1876         https://bugs.webkit.org/show_bug.cgi?id=59792
1877
1878         Broke script-formatter.html test (Requested by podivilov on
1879         #webkit).
1880
1881         * inspector/front-end/DebuggerPresentationModel.js:
1882         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
1883         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger.didRemoveBreakpoint):
1884         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
1885         (WebInspector.PresentationBreakpoint.prototype.serialize):
1886         * inspector/front-end/ScriptsPanel.js:
1887         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
1888         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
1889         (WebInspector.ScriptsPanel.prototype.reset):
1890
1891 2011-04-29  Vsevolod Vlasov  <vsevik@chromium.org>
1892
1893         Reviewed by Pavel Feldman.
1894
1895         Web Inspector: Hyperlink Auditing (ping) requests are not shown in network panel
1896         https://bugs.webkit.org/show_bug.cgi?id=58794
1897
1898         Added ping requests to network panel.
1899
1900         Test: http/tests/inspector/network/ping.html
1901
1902         * English.lproj/localizedStrings.js:
1903         * inspector/InspectorInstrumentation.cpp:
1904         (WebCore::InspectorInstrumentation::continueAfterPingLoaderImpl):
1905         * inspector/InspectorInstrumentation.h:
1906         (WebCore::InspectorInstrumentation::continueAfterPingLoader):
1907         * inspector/front-end/NetworkPanel.js:
1908         (WebInspector.NetworkDataGridNode.prototype.refreshResource):
1909         (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
1910         (WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):
1911         * inspector/front-end/Resource.js:
1912         (WebInspector.Resource.prototype.get formParameters):
1913         (WebInspector.Resource.prototype.requestContentType):
1914         (WebInspector.Resource.prototype.isPingRequest):
1915         * loader/PingLoader.cpp:
1916         (WebCore::PingLoader::PingLoader):
1917         * loader/PingLoader.h:
1918
1919 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
1920
1921         Reviewed by Pavel Feldman.
1922
1923         Web Inspector: breakpoints set in original and formatted scripts are messed up after navigation.
1924         https://bugs.webkit.org/show_bug.cgi?id=59476
1925
1926         * inspector/front-end/DebuggerPresentationModel.js:
1927         (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
1928         (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
1929         (WebInspector.PresentationBreakpoint.prototype.serialize):
1930         * inspector/front-end/ScriptsPanel.js:
1931         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.optionCompare):
1932         (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
1933         (WebInspector.ScriptsPanel.prototype.reset):
1934
1935 2011-04-29  Pavel Feldman  <pfeldman@google.com>
1936
1937         Reviewed by Yury Semikhatsky.
1938
1939         Web Inspector: add "open link in new tab" action into the network and resources panels.
1940         https://bugs.webkit.org/show_bug.cgi?id=59788
1941
1942         This change also distinguishes context menu items case between platforms.
1943
1944         * English.lproj/localizedStrings.js:
1945         * inspector/front-end/ConsoleView.js:
1946         (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
1947         * inspector/front-end/DOMBreakpointsSidebarPane.js:
1948         (WebInspector.DOMBreakpointsSidebarPane):
1949         * inspector/front-end/ElementsPanel.js:
1950         (WebInspector.ElementsPanel.prototype._contextMenuEventFired):
1951         (WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
1952         * inspector/front-end/ElementsTreeOutline.js:
1953         (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
1954         (WebInspector.ElementsTreeElement.prototype._populateTextContextMenu):
1955         * inspector/front-end/NetworkPanel.js:
1956         (WebInspector.NetworkPanel.prototype._contextMenu):
1957         * inspector/front-end/ResourcesPanel.js:
1958         (WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
1959         (WebInspector.FrameResourceTreeElement.prototype._appendSaveAsAction):
1960         (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
1961         * inspector/front-end/Settings.js:
1962         * inspector/front-end/SourceFrame.js:
1963         (WebInspector.SourceFrame.prototype.populateLineGutterContextMenu):
1964         * inspector/front-end/TextViewer.js:
1965         (WebInspector.TextViewer.prototype._contextMenu):
1966         * inspector/front-end/inspector.js:
1967         (WebInspector.openLinkExternallyLabel):
1968         (WebInspector.openResource):
1969         (WebInspector.useLowerCaseMenuTitles):
1970
1971 2011-04-28  Simon Fraser  <simon.fraser@apple.com>
1972
1973         Reviewed by Dan Bernstein.
1974
1975         Mask placement on composited layer is incorrect sometimes
1976         https://bugs.webkit.org/show_bug.cgi?id=59775
1977
1978         The mask layer always has the same size as its owning GraphicsLayer,
1979         so it needs to share the same offsetFromRenderer as well. This fixes
1980         the offset at which the mask layer contents are painted in cases where
1981         that offset is non-zero, for example when outline style bloats all of
1982         the layer sizes.
1983
1984         Test: compositing/masks/layer-mask-placement.html
1985
1986         * rendering/RenderLayerBacking.cpp:
1987         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
1988
1989 2011-04-28  Dan Bernstein  <mitz@apple.com>
1990
1991         Rubber-stamped by Mark Rowe.
1992
1993         Reverted r81319.
1994
1995         Fixes <rdar://problem/9331580> REGRESSION (r81319): Safari fails to display dropdown navigation on classics.berkeley.edu
1996
1997         * page/NavigatorBase.cpp:
1998
1999 2011-04-28  Simon Fraser  <simon.fraser@apple.com>
2000
2001         Reviewed by Dirk Schulze.
2002
2003         1px box-shadow looks ugly
2004         https://bugs.webkit.org/show_bug.cgi?id=58100
2005         and
2006         ShadowBlur incorrectly handles zero-sized blur radius in one axis
2007         https://bugs.webkit.org/show_bug.cgi?id=59710
2008
2009         blurLayerImage() has issues at the edges if the blur radius
2010         is one, so in that case bump the buffer size out by a pixel.
2011         This results in a correct, symmetrical blur.
2012
2013         Also fix an issue noticed during testing where a zero
2014         height or width radius would still blur on that axis,
2015         because we clamp the kernel size to a minimum of two.
2016
2017         Test: fast/box-shadow/single-pixel-shadow.html
2018
2019         * platform/graphics/ShadowBlur.h:
2020         * platform/graphics/ShadowBlur.cpp:
2021         (WebCore::ShadowBlur::blurLayerImage):
2022         Skip horizontal or vertial passes if the radius on that axis is zero.
2023         Move the "if (pass && m_blurRadius.width() != m_blurRadius.height())"
2024         clause to the end of the loop, since it only needs to execute once
2025         after the first pass.
2026         (WebCore::ShadowBlur::blurredEdgeSize):
2027         New method to compute the width of the blurred edge (radius + extra
2028         pixel when necessary).
2029         (WebCore::ShadowBlur::calculateLayerBoundingRect):
2030         (WebCore::ShadowBlur::templateSize):
2031         (WebCore::ShadowBlur::drawRectShadow):
2032         (WebCore::ShadowBlur::drawInsetShadow):
2033         (WebCore::ShadowBlur::drawInsetShadowWithTiling):
2034         (WebCore::ShadowBlur::drawRectShadowWithTiling):
2035         (WebCore::ShadowBlur::drawLayerPieces):
2036         Use the result of blurredEdgeSize() rather than recomputing.
2037
2038 2011-04-28  Yael Aharon  <yael.aharon@nokia.com>
2039
2040         Reviewed by Beth Dakin.
2041
2042         CSS sibling selector (~) does not work with :target pseudo class
2043         https://bugs.webkit.org/show_bug.cgi?id=26539
2044
2045         Allow style recalculation of forward siblings of elements with
2046         forward positional rules.
2047
2048         Tests: fast/css/pseudo-target-indirect-sibling-001.html
2049                fast/css/pseudo-target-indirect-sibling-002.html
2050
2051         * dom/Element.cpp:
2052         (WebCore::Element::recalcStyle):
2053
2054 2011-04-28  Nat Duca  <nduca@chromium.org>
2055
2056         Reviewed by Kenneth Russell.
2057
2058         [chromium] Add swapBuffersCompleteCallback to Extensions3DChromium
2059         https://bugs.webkit.org/show_bug.cgi?id=59626
2060
2061         * platform/graphics/chromium/Extensions3DChromium.h:
2062         (WebCore::Extensions3DChromium::SwapBuffersCompleteCallbackCHROMIUM::~SwapBuffersCompleteCallbackCHROMIUM):
2063
2064 2011-04-28  Steve Lacey  <sjl@chromium.org>
2065
2066         Reviewed by Eric Carlson.
2067
2068         Change chromium media controls to use absolute positioning until bug 59644 is fixed.
2069         https://bugs.webkit.org/show_bug.cgi?id=59732
2070
2071         * css/mediaControlsChromium.css:
2072         (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
2073         (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
2074
2075 2011-04-28  Luke Macpherson   <macpherson@chromium.org>
2076
2077         Reviewed by Eric Seidel.
2078
2079         Implement CSS border width and related properties in CSSStyleApplyProperty.
2080         https://bugs.webkit.org/show_bug.cgi?id=59414
2081
2082         No new tests as no functionality added.
2083
2084         * css/CSSStyleApplyProperty.cpp:
2085         Separated ApplyPropertyDefault into parent and child so that other classes could inherit
2086         the applyInheritValue and applyInitialValue methods only.
2087         This was necessary to avoid casting from CSSPrimitiveValue to inappropriate types in ApplyPropertyDefault::applyValue().
2088
2089         Added ApplyPropertyWidth class for handling width based CSS properties.
2090         * css/CSSStyleSelector.cpp:
2091         Removed no-longer-required code for handling width based CSS properties.
2092         * css/CSSStyleSelector.h:
2093         Added a getter for m_rootElementStyle.
2094
2095 2011-04-28  Kent Tamura  <tkent@chromium.org>
2096
2097         Run sort-Xcode-project-file.
2098
2099         * WebCore.xcodeproj/project.pbxproj:
2100
2101 2011-04-28  Martin Robinson  <mrobinson@igalia.com>
2102
2103         Reviewed by Dirk Schulze.
2104
2105         [Cairo] Text underline is not shadowed when text-shadow is enabled
2106         https://bugs.webkit.org/show_bug.cgi?id=48074
2107
2108         Use ContextShadow to enable shadows for text underlines. Also remove quite a bit
2109         of duplicate code in GraphicsContext used for stroking lines. This code looks like it was
2110         originally copied from the CG GraphicsContext.
2111
2112         * platform/graphics/GraphicsContext.h: Make adjustLineToPixelBoundaries so that we
2113           can call it from a static helper function.
2114         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2115         (WebCore::calculateStrokePatternOffset): Abstracted this code into a helper.
2116         (WebCore::drawLineOnCairoContext): Abstracted this code into a helper. We need to
2117         call it multiple times when shadowing text underlines.
2118         (WebCore::GraphicsContext::drawLine): Use drawLineOnCairoContext.
2119         (WebCore::GraphicsContext::strokeArc): Use calculateStrokePatternOffset.
2120         (WebCore::GraphicsContext::drawLineForText): Use drawLineOnCairoContext.
2121
2122 2011-04-28  Sam Weinig  <sam@webkit.org>
2123
2124         Rubber-stamped by Mark Rowe.
2125
2126         Cleanup WebCore.xcodeproj a bit.
2127
2128         * WebCore.xcodeproj/project.pbxproj:
2129         Added CompilerVersion.xcconfig and moved some JS bindings files into the
2130         correct sub groups.
2131
2132 2011-04-28  David Levin  <levin@chromium.org>
2133
2134         Reviewed by Adam Barth.
2135
2136         Remove IMAGE_RESIZER related code.
2137         https://bugs.webkit.org/show_bug.cgi?id=59735
2138
2139         * CMakeLists.txt:
2140         * Configurations/FeatureDefines.xcconfig:
2141         * GNUmakefile.am:
2142         * GNUmakefile.list.am:
2143         * WebCore.gypi:
2144         * WebCore.pro:
2145         * WebCore.vcproj/WebCore.vcproj:
2146         * WebCore.xcodeproj/project.pbxproj:
2147         * features.pri:
2148         * html/AsyncImageResizer.cpp: Removed.
2149         * html/AsyncImageResizer.h: Removed.
2150         * html/ImageResizerThread.cpp: Removed.
2151         * html/ImageResizerThread.h: Removed.
2152
2153 2011-04-28  Ilya Tikhonovsky  <loislo@chromium.org>
2154
2155         Unreviewed trivial one-line fix inspired by wrong patch for https://bugs.webkit.org/show_bug.cgi?id=59630.
2156
2157         * inspector/front-end/Settings.js:
2158         (WebInspector.Settings):
2159
2160 2011-04-28  Beth Dakin  <bdakin@apple.com>
2161
2162         Rubber-stamped by Sam Weinig.
2163
2164         Rolling out revision 85258! I want to fix that bug a different way.
2165         * platform/mac/ScrollbarThemeMac.mm:
2166         (WebCore::ScrollbarThemeMac::paint):
2167
2168 2011-04-28  Chang Shu  <cshu@webkit.org>
2169
2170         Reviewed by Eric Seidel.
2171
2172         isContentEditable is not working properly with document.designMode
2173         https://bugs.webkit.org/show_bug.cgi?id=53031
2174
2175         The specification (http://dev.w3.org/html5/spec/Overview.html#attr-contenteditable)
2176         indicates that the element.isContentEditable relies on document.designMode if its
2177         and its ancestors' contenteditable attributes are set to inherit.
2178
2179         1. Sync document render style after document.designMode is changed.
2180         2. Removed the code that does unnecessary and incorrect handling for contenteditable
2181         attribute with "inherit" value.
2182         3. Ryosuke Niwa also helped to fix the code in ApplyStyleCommand that causes an assertion.
2183
2184         Tests: fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit-subframe.html
2185                fast/dom/HTMLElement/iscontenteditable-designmodeon-allinherit.html
2186                fast/dom/HTMLElement/iscontenteditable-designmodeon-ancestor.html
2187                fast/dom/HTMLElement/iscontenteditable-designmodeon.html
2188
2189         * css/CSSStyleSelector.cpp:
2190         (WebCore::CSSStyleSelector::styleForDocument):
2191         * dom/Document.cpp:
2192         (WebCore::Document::setDesignMode):
2193         * dom/Node.cpp:
2194         (WebCore::Node::rendererIsEditable):
2195         * editing/ApplyStyleCommand.cpp:
2196         (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):
2197         * html/HTMLElement.cpp:
2198         (WebCore::HTMLElement::setContentEditable):
2199
2200 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2201
2202         Unreviewed, rolling out r85101.
2203         http://trac.webkit.org/changeset/85101
2204         https://bugs.webkit.org/show_bug.cgi?id=59757
2205
2206          it'd be better to rollout the patch and do another one with
2207         another property name. Current one will bring us to a problem
2208         at first run after upgrade because it's type was changed from
2209         int to string. (Requested by loislo on #webkit).
2210
2211         * inspector/front-end/ScriptsPanel.js:
2212         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
2213         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
2214         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
2215
2216 2011-04-28  Mike Reed  <reed@google.com>
2217
2218         Reviewed by Eric Seidel.
2219
2220         fix shadw behavior for both CSS and Canvas -- skia only
2221         https://bugs.webkit.org/show_bug.cgi?id=59700
2222
2223         Test:
2224         canvas/philip/tests/2d.shadow.alpha.3.html
2225         canvas/philip/tests/2d.shadow.alpha.4.html
2226         canvas/philip/tests/2d.shadow.alpha.5.html
2227         fast/canvas/canvas-fillPath-alpha-shadow.html
2228         fast/canvas/canvas-strokePath-alpha-shadow.html
2229         fast/canvas/canvas-strokeRect-alpha-shadow.html
2230         fast/css/text-input-with-webkit-border-radius.html
2231         fast/repaint/shadow-multiple-horizontal.html
2232         fast/repaint/shadow-multiple-strict-horizontal.html
2233         fast/repaint/shadow-multiple-strict-vertical.html
2234         fast/repaint/shadow-multiple-vertical.html
2235         fast/canvas/canvas-getImageData.html
2236
2237         * platform/graphics/chromium/FontChromiumWin.cpp:
2238         (WebCore::Font::drawGlyphs):
2239         * platform/graphics/skia/GraphicsContextSkia.cpp:
2240         (WebCore::GraphicsContext::setPlatformShadow):
2241
2242 2011-04-28  David Kilzer  <ddkilzer@apple.com>
2243
2244         <http://webkit.org/b/59755> AXObjectCache::attachWrapper() over-retains an AccessibilityObjectWrapper
2245
2246         Reviewed by Chris Fleizach.
2247
2248         Previously, AXObjectCache::attachWrapper over-retained each
2249         AccessibilityObjectWrapper it created, which is why
2250         AXObjectCache::detachWrapper() contained an extra -release.
2251
2252         * accessibility/mac/AXObjectCacheMac.mm:
2253         (WebCore::AXObjectCache::detachWrapper): Removed extra -release.
2254         (WebCore::AXObjectCache::attachWrapper): Because setWrapper()
2255         assigns to a RetainPtr<> instance variable, it doesn't need a +1
2256         retained object passed in.  Fix the leak by using a RetainPtr<>
2257         for the AccessibilityObjectWrapper.
2258
2259 2011-04-28  Nat Duca  <nduca@chromium.org>
2260
2261         Reviewed by Darin Fisher.
2262
2263         [chromium] Compute compositor fps value and history using the frameBegin timestamp
2264         https://bugs.webkit.org/show_bug.cgi?id=59668
2265
2266         This change switches the compositor FPS meter to use the timestamp
2267         of the beginning of the frame rather than the time we call
2268         swapBuffers. When scheduling is correctly tied to vsync, we can
2269         have highly variable times when we finish vsync and still have
2270         stable frame rates.
2271
2272         * platform/graphics/chromium/LayerRendererChromium.cpp:
2273         (WebCore::LayerRendererChromium::updateAndDrawLayers):
2274         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
2275         (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
2276         (WebCore::CCHeadsUpDisplay::drawFPSCounter):
2277         (WebCore::CCHeadsUpDisplay::onFrameBegin):
2278         (WebCore::CCHeadsUpDisplay::onPresent):
2279         * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
2280
2281 2011-04-28  Beth Dakin  <bdakin@apple.com>
2282
2283         Reviewed by Darin Adler.
2284
2285         https://bugs.webkit.org/show_bug.cgi?id=59759
2286         Overflow:scroll regions with overlay scrollbars show full thumb instead of just a
2287         track when there is nothing to scroll to
2288         <rdar://problem/9282066>
2289
2290         Scrollbar::totalSize() and Scrollbar::visibleSize() are the same when there is
2291         nothing to scroll to. Just dividing them to get a knob proportion yields 1, which
2292         is not right. Set the proportion to 0 in this case instead.
2293         * platform/mac/ScrollbarThemeMac.mm:
2294         (WebCore::ScrollbarThemeMac::paint):
2295
2296 2011-04-28  Dan Bernstein  <mitz@apple.com>
2297
2298         Reviewed by Simon Fraser.
2299
2300         <rdar://problem/9291132> Add support for -epub-prefixed properties
2301
2302         Test: fast/css/epub-properties.html
2303
2304         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
2305         (WebCore::cssPropertyName): Map "epub"-prefixed properties to "-epub"-prefixed ones.
2306         * css/CSSPropertyNames.in: Added -epub- aliases to caption-side, -webkit-hyphens, -webkit-text-combine,
2307         -webkit-text-emphasis, -webkit-text-emphasis-color, -webkit-text-emphasis-style, -webkit-text-orientation,
2308         text-transform, text-transform, word-break, and -webkit-writing-mode.
2309
2310 2011-04-28  Adam Barth  <abarth@webkit.org>
2311
2312         Reviewed by Eric Seidel.
2313
2314         Remove WML
2315         https://bugs.webkit.org/show_bug.cgi?id=59678
2316
2317         This patch removes WML from WebCore.  After removing WML, there's a
2318         bunch of twisted code that could be untwisted, but this patch contains
2319         only the purely mechanical part of removing the feature.
2320
2321         There's been a lot of discussion on webkit-dev about whether we should
2322         remove WML.  In addition to those threads, we've had an informal poll
2323         of the reviewers as well as an in-person discussion at the WebKit
2324         contributor's meeting.  Removing any feature is likely to make some
2325         folks unhappy, but, on balance, removing WML appears to be the right
2326         thing for the project to do at this time.
2327
2328         * CMakeLists.txt:
2329         * CodeGenerators.pri:
2330         * Configurations/FeatureDefines.xcconfig:
2331         * DerivedSources.cpp:
2332         * DerivedSources.make:
2333         * GNUmakefile.am:
2334         * GNUmakefile.list.am:
2335         * WebCore.gyp/WebCore.gyp:
2336         * WebCore.gypi:
2337         * WebCore.pro:
2338         * WebCore.vcproj/WebCore.vcproj:
2339         * WebCore.xcodeproj/project.pbxproj:
2340         * css/CSSStyleSelector.cpp:
2341         (WebCore::linkAttribute):
2342         (WebCore::CSSStyleSelector::styleForElement):
2343         (WebCore::CSSStyleSelector::adjustRenderStyle):
2344         * css/wml.css: Removed.
2345         * dom/DOMImplementation.cpp:
2346         (WebCore::DOMImplementation::createDocument):
2347         * dom/Document.cpp:
2348         (WebCore::Document::Document):
2349         (WebCore::Document::createElement):
2350         * dom/Document.h:
2351         (WebCore::Document::isMediaDocument):
2352         * dom/Document.idl:
2353         * dom/InputElement.h:
2354         * dom/Node.cpp:
2355         (WebCore::Node::toInputElement):
2356         * dom/Node.h:
2357         * dom/OptionElement.cpp:
2358         (WebCore::toOptionElement):
2359         (WebCore::isOptionElement):
2360         * dom/OptionElement.h:
2361         * dom/OptionGroupElement.cpp:
2362         (WebCore::toOptionGroupElement):
2363         (WebCore::isOptionGroupElement):
2364         * dom/SelectElement.cpp:
2365         (WebCore::toSelectElement):
2366         * dom/SelectElement.h:
2367         * dom/Text.cpp:
2368         (WebCore::Text::attach):
2369         * dom/XMLDocumentParser.cpp:
2370         (WebCore::XMLDocumentParser::insertErrorMessageBlock):
2371         * dom/XMLDocumentParser.h:
2372         * dom/XMLDocumentParserLibxml2.cpp:
2373         (WebCore::XMLDocumentParser::internalSubset):
2374         (WebCore::getEntityHandler):
2375         * dom/XMLDocumentParserQt.cpp:
2376         (WebCore::XMLDocumentParser::parse):
2377         (WebCore::XMLDocumentParser::parseDtd):
2378         * editing/htmlediting.cpp:
2379         (WebCore::canHaveChildrenForEditing):
2380         * features.pri:
2381         * history/BackForwardList.h:
2382         * history/BackForwardListImpl.cpp:
2383         * history/BackForwardListImpl.h:
2384         * history/PageCache.cpp:
2385         (WebCore::PageCache::canCachePageContainingThisFrame):
2386         * html/HTMLAnchorElement.h:
2387         * inspector/ConsoleMessage.cpp:
2388         (WebCore::messageSourceValue):
2389         * inspector/front-end/ConsoleView.js:
2390         (WebInspector.ConsoleMessage.prototype.toString):
2391         * loader/FrameLoader.cpp:
2392         (WebCore::isBackForwardLoadType):
2393         (WebCore::FrameLoader::transitionToCommitted):
2394         (WebCore::FrameLoader::shouldReload):
2395         (WebCore::FrameLoader::loadDifferentDocumentItem):
2396         (WebCore::FrameLoader::loadItem):
2397         * loader/FrameLoaderTypes.h:
2398         * loader/HistoryController.cpp:
2399         (WebCore::HistoryController::restoreDocumentState):
2400         * manual-tests/wml: Removed.
2401         * manual-tests/wml/StartTests.wml: Removed.
2402         * manual-tests/wml/a-br-element.wml: Removed.
2403         * manual-tests/wml/a-element.wml: Removed.
2404         * manual-tests/wml/a-img-element.wml: Removed.
2405         * manual-tests/wml/access-target.wml: Removed.
2406         * manual-tests/wml/anchor-br-element.wml: Removed.
2407         * manual-tests/wml/anchor-element.wml: Removed.
2408         * manual-tests/wml/anchor-img-element.wml: Removed.
2409         * manual-tests/wml/card-newcontext-attr.wml: Removed.
2410         * manual-tests/wml/card-onenterbackward.wml: Removed.
2411         * manual-tests/wml/card-onenterforward.wml: Removed.
2412         * manual-tests/wml/card-ontimer.wml: Removed.
2413         * manual-tests/wml/deck-access-control.wml: Removed.
2414         * manual-tests/wml/input-format.wml: Removed.
2415         * manual-tests/wml/onevent-go.wml: Removed.
2416         * manual-tests/wml/onevent-noop.wml: Removed.
2417         * manual-tests/wml/onevent-prev.wml: Removed.
2418         * manual-tests/wml/onevent-refresh.wml: Removed.
2419         * manual-tests/wml/onevent-shadow.wml: Removed.
2420         * manual-tests/wml/resources: Removed.
2421         * manual-tests/wml/resources/smiley.png: Removed.
2422         * manual-tests/wml/select-element.wml: Removed.
2423         * manual-tests/wml/select-onpick-event-crash.wml: Removed.
2424         * manual-tests/wml/select-onpick-event.wml: Removed.
2425         * manual-tests/wml/setvar-element.wml: Removed.
2426         * manual-tests/wml/targetdeck.wml: Removed.
2427         * manual-tests/wml/task-go-in-anchor.wml: Removed.
2428         * manual-tests/wml/task-prev-in-anchor.wml: Removed.
2429         * manual-tests/wml/task-refresh-in-anchor.wml: Removed.
2430         * manual-tests/wml/template-go.wml: Removed.
2431         * manual-tests/wml/template-ontimer.wml: Removed.
2432         * manual-tests/wml/timer.wml: Removed.
2433         * manual-tests/wml/variable-substitution.wml: Removed.
2434         * page/Console.cpp:
2435         (WebCore::printMessageSourceAndLevelPrefix):
2436         * page/Console.h:
2437         * page/Frame.cpp:
2438         (WebCore::Frame::Frame):
2439         * page/Page.cpp:
2440         * page/Page.h:
2441         * platform/MIMETypeRegistry.cpp:
2442         (WebCore::initializeSupportedNonImageMimeTypes):
2443         * platform/network/FormDataBuilder.h:
2444         * platform/network/mac/ResourceHandleMac.mm:
2445         (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
2446         * platform/wince/MIMETypeRegistryWinCE.cpp:
2447         (WebCore::initMIMETypeEntensionMap):
2448         * rendering/HitTestResult.cpp:
2449         (WebCore::HitTestResult::altDisplayString):
2450         (WebCore::HitTestResult::absoluteImageURL):
2451         (WebCore::HitTestResult::absoluteLinkURL):
2452         (WebCore::HitTestResult::isLiveLink):
2453         * rendering/RenderBox.cpp:
2454         * rendering/RenderButton.cpp:
2455         (WebCore::RenderButton::updateFromElement):
2456         * rendering/RenderFieldset.cpp:
2457         (WebCore::RenderFieldset::findLegend):
2458         * rendering/RenderImage.cpp:
2459         (WebCore::RenderImage::updateAltText):
2460         * rendering/RenderObject.cpp:
2461         (WebCore::RenderObject::isLegend):
2462         (WebCore::RenderObject::offsetParent):
2463         * wml: Removed.
2464         * wml/WMLAElement.cpp: Removed.
2465         * wml/WMLAElement.h: Removed.
2466         * wml/WMLAccessElement.cpp: Removed.
2467         * wml/WMLAccessElement.h: Removed.
2468         * wml/WMLAnchorElement.cpp: Removed.
2469         * wml/WMLAnchorElement.h: Removed.
2470         * wml/WMLAttributeNames.in: Removed.
2471         * wml/WMLBRElement.cpp: Removed.
2472         * wml/WMLBRElement.h: Removed.
2473         * wml/WMLCardElement.cpp: Removed.
2474         * wml/WMLCardElement.h: Removed.
2475         * wml/WMLDoElement.cpp: Removed.
2476         * wml/WMLDoElement.h: Removed.
2477         * wml/WMLDocument.cpp: Removed.
2478         * wml/WMLDocument.h: Removed.
2479         * wml/WMLElement.cpp: Removed.
2480         * wml/WMLElement.h: Removed.
2481         * wml/WMLErrorHandling.cpp: Removed.
2482         * wml/WMLErrorHandling.h: Removed.
2483         * wml/WMLEventHandlingElement.cpp: Removed.
2484         * wml/WMLEventHandlingElement.h: Removed.
2485         * wml/WMLFieldSetElement.cpp: Removed.
2486         * wml/WMLFieldSetElement.h: Removed.
2487         * wml/WMLFormControlElement.cpp: Removed.
2488         * wml/WMLFormControlElement.h: Removed.
2489         * wml/WMLGoElement.cpp: Removed.
2490         * wml/WMLGoElement.h: Removed.
2491         * wml/WMLImageElement.cpp: Removed.
2492         * wml/WMLImageElement.h: Removed.
2493         * wml/WMLImageLoader.cpp: Removed.
2494         * wml/WMLImageLoader.h: Removed.
2495         * wml/WMLInputElement.cpp: Removed.
2496         * wml/WMLInputElement.h: Removed.
2497         * wml/WMLInsertedLegendElement.cpp: Removed.
2498         * wml/WMLInsertedLegendElement.h: Removed.
2499         * wml/WMLIntrinsicEvent.cpp: Removed.
2500         * wml/WMLIntrinsicEvent.h: Removed.
2501         * wml/WMLIntrinsicEventHandler.cpp: Removed.
2502         * wml/WMLIntrinsicEventHandler.h: Removed.
2503         * wml/WMLMetaElement.cpp: Removed.
2504         * wml/WMLMetaElement.h: Removed.
2505         * wml/WMLNoopElement.cpp: Removed.
2506         * wml/WMLNoopElement.h: Removed.
2507         * wml/WMLOnEventElement.cpp: Removed.
2508         * wml/WMLOnEventElement.h: Removed.
2509         * wml/WMLOptGroupElement.cpp: Removed.
2510         * wml/WMLOptGroupElement.h: Removed.
2511         * wml/WMLOptionElement.cpp: Removed.
2512         * wml/WMLOptionElement.h: Removed.
2513         * wml/WMLPElement.cpp: Removed.
2514         * wml/WMLPElement.h: Removed.
2515         * wml/WMLPageState.cpp: Removed.
2516         * wml/WMLPageState.h: Removed.
2517         * wml/WMLPostfieldElement.cpp: Removed.
2518         * wml/WMLPostfieldElement.h: Removed.
2519         * wml/WMLPrevElement.cpp: Removed.
2520         * wml/WMLPrevElement.h: Removed.
2521         * wml/WMLRefreshElement.cpp: Removed.
2522         * wml/WMLRefreshElement.h: Removed.
2523         * wml/WMLSelectElement.cpp: Removed.
2524         * wml/WMLSelectElement.h: Removed.
2525         * wml/WMLSetvarElement.cpp: Removed.
2526         * wml/WMLSetvarElement.h: Removed.
2527         * wml/WMLTableElement.cpp: Removed.
2528         * wml/WMLTableElement.h: Removed.
2529         * wml/WMLTagNames.in: Removed.
2530         * wml/WMLTaskElement.cpp: Removed.
2531         * wml/WMLTaskElement.h: Removed.
2532         * wml/WMLTemplateElement.cpp: Removed.
2533         * wml/WMLTemplateElement.h: Removed.
2534         * wml/WMLTimerElement.cpp: Removed.
2535         * wml/WMLTimerElement.h: Removed.
2536         * wml/WMLVariables.cpp: Removed.
2537         * wml/WMLVariables.h: Removed.
2538
2539 2011-04-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2540
2541         Unreviewed, rolling out r85233 and r85235.
2542         http://trac.webkit.org/changeset/85233
2543         http://trac.webkit.org/changeset/85235
2544         https://bugs.webkit.org/show_bug.cgi?id=59754
2545
2546         Causes issues with jsc. (Requested by dave_levin on #webkit).
2547
2548         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Removed.
2549         * loader/icon/IconDatabase.cpp:
2550         (WebCore::IconDatabase::defaultIcon):
2551         (WebCore::IconDatabase::setIconDataForIconURL):
2552         (WebCore::IconDatabase::getOrCreateIconRecord):
2553         (WebCore::IconDatabase::readFromDatabase):
2554
2555 2011-04-28  Jay Civelli  <jcivelli@chromium.org>
2556
2557         Reviewed by Adam Barth.
2558
2559         Introducing a new class that allows serialization of a page back
2560         to HTML/XML with all its sub-frames and also retrieves the page's
2561         resources.
2562         Tests: unit-tests in chromium/tests/WebPageNewSerializerTest.cpp
2563         https://bugs.webkit.org/show_bug.cgi?id=58947
2564
2565         * Android.mk:
2566         * CMakeLists.txt:
2567         * GNUmakefile.list.am:
2568         * WebCore.gypi:
2569         * WebCore.pro:
2570         * WebCore.vcproj/WebCore.vcproj:
2571         * dom/Document.cpp:
2572         (WebCore::Document::suggestedMIMEType):
2573         * dom/Document.h:
2574         * editing/MarkupAccumulator.cpp:
2575         (WebCore::MarkupAccumulator::appendCustomAttributes):
2576         (WebCore::MarkupAccumulator::appendElement):
2577         * editing/MarkupAccumulator.h:
2578         * html/parser/HTMLMetaCharsetParser.cpp:
2579         (WebCore::HTMLMetaCharsetParser::processMeta):
2580         (WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes):
2581         * html/parser/HTMLMetaCharsetParser.h:
2582         * page/PageSerializer.cpp: Added.
2583         * page/PageSerializer.h: Added.
2584
2585 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
2586
2587         Reviewed by Tony Chang.
2588
2589         IndexedDB createIndex should fail if name arg is null
2590         https://bugs.webkit.org/show_bug.cgi?id=58365
2591
2592         Test: storage/indexeddb/mozilla/create-index-null-name.html
2593
2594         * storage/IDBObjectStore.idl:
2595         * storage/IDBObjectStoreBackendImpl.cpp:
2596         (WebCore::IDBObjectStoreBackendImpl::createIndex):
2597
2598 2011-04-28  Mark Pilgrim  <pilgrim@chromium.org>
2599
2600         Reviewed by Tony Chang.
2601
2602         IndexedDB put() should fail if second (key) parameter is null
2603         https://bugs.webkit.org/show_bug.cgi?id=58613
2604
2605         If key arg is not specified, prpKey ends up as a null pointer in ::put().
2606         However, if the key arg is specified but is null, prpKey ends up as a
2607         valid IDBKey which has a null key type. As it happens, we need to be able
2608         to detect the difference between these cases (the key arg is optional but
2609         if specified must not be null).
2610
2611         Test: storage/indexeddb/mozilla/key-requirements-put-null-key.html
2612
2613         * storage/IDBObjectStoreBackendImpl.cpp:
2614         (WebCore::IDBObjectStoreBackendImpl::put):
2615
2616 2011-04-07  David Levin  <levin@chromium.org>
2617
2618         Reviewed by Darin Adler.
2619
2620         Add asserts to RefCounted to make sure ref/deref happens on the right thread.
2621         https://bugs.webkit.org/show_bug.cgi?id=31639
2622
2623         No new functionality exposed so no new tests. (The change is basically adding
2624         more testing.)
2625
2626         * ForwardingHeaders/wtf/ThreadRestrictionVerifier.h: Added.
2627         * loader/icon/IconDatabase.cpp:
2628         (WebCore::IconDatabase::defaultIcon): Set the mutex which does the guarding of the variable.
2629         (WebCore::IconDatabase::getOrCreateIconRecord): Ditto.
2630         (WebCore::IconDatabase::setIconDataForIconURL): Ditto.
2631         (WebCore::IconDatabase::readFromDatabase): Ditto.
2632
2633 2011-04-28  Kenneth Russell  <kbr@google.com>
2634
2635         Unreviewed build fix for Web Audio with strict OwnPtr.
2636
2637         * platform/audio/HRTFDatabaseLoader.cpp:
2638         (WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader):
2639
2640 2011-04-28  Dominic Cooney  <dominicc@chromium.org>
2641
2642         Reviewed by Geoffrey Garen.
2643
2644         Walk shadow hosts as well as parent nodes when finding opaque roots.
2645         https://bugs.webkit.org/show_bug.cgi?id=59571
2646
2647         Test: fast/dom/shadow/gc-shadow.html
2648
2649         * bindings/js/JSDOMBinding.h:
2650         (WebCore::root):
2651
2652 2011-04-28  Martin Robinson  <mrobinson@igalia.com>
2653
2654         Reviewed by Xan Lopez.
2655
2656         [GTK] Click counting logic should be shared between WebKit1 and WebKit2
2657         https://bugs.webkit.org/show_bug.cgi?id=59715
2658
2659         Added a GtkClickCounter class which is just the logic from WebKit1 pushed down
2660         into WebCore so that WebKit1 and WebKit2 can share the code.
2661
2662         No new tests. This is covered by fast/events/click-count.html.
2663
2664         * GNUmakefile.list.am: Added new files.
2665         * platform/gtk/GtkClickCounter.cpp: Added.
2666         (WebCore::GtkClickCounter::GtkClickCounter): Added.
2667         (WebCore::GtkClickCounter::reset): Added.
2668         (WebCore::GtkClickCounter::shouldProcessButtonEvent): Added.
2669         (WebCore::getEventTime): Added.
2670         (WebCore::GtkClickCounter::clickCountForGdkButtonEvent): Added.
2671         * platform/gtk/GtkClickCounter.h: Added.
2672
2673 2011-04-28  Dan Bernstein  <mitz@apple.com>
2674
2675         Build fix.
2676
2677         * css/CSSParser.cpp:
2678         (WebCore::cssPropertyID):
2679
2680 2011-04-28  Dan Bernstein  <mitz@apple.com>
2681
2682         Reviewed by Simon Fraser.
2683
2684         Allow specifying CSS property aliases in CSSPropertyNames.in files
2685         https://bugs.webkit.org/show_bug.cgi?id=59712
2686
2687         * css/CSSParser.cpp:
2688         (WebCore::cssPropertyID): Removed code to handle some aliases
2689         * css/CSSPropertyNames.in: Added aliases no longer handled in code.
2690         * css/makeprop.pl: Interpret lines of the form "alias-property-name = property-name" as
2691         defining an alias, and add an appropriate entry to the gperf file.
2692
2693 2011-04-28  Arno Renevier  <arno@renevier.net>
2694
2695         Reviewed by Gustavo Noronha Silva.
2696
2697         [Soup] does not load css stylesheets without content-type
2698         https://bugs.webkit.org/show_bug.cgi?id=59697
2699
2700         When sniffing content type, do not replace http Content-Type header in
2701         soup message anymore, but keep sniffed content type in a separate
2702         variable.
2703
2704         * platform/network/soup/ResourceHandleSoup.cpp:
2705         (WebCore::contentSniffedCallback):
2706         * platform/network/soup/ResourceResponse.h:
2707         (WebCore::ResourceResponse::sniffedContentType):
2708         (WebCore::ResourceResponse::setSniffedContentType):
2709         * platform/network/soup/ResourceResponseSoup.cpp:
2710         (WebCore::ResourceResponse::updateFromSoupMessage):
2711
2712 2011-04-28  Yael Aharon  <yael.aharon@nokia.com>
2713
2714         Reviewed by Andreas Kling.
2715
2716         Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
2717         https://bugs.webkit.org/show_bug.cgi?id=59704
2718
2719         No new tests, just code cleanup.
2720
2721         * WebCore.pri:
2722
2723 2011-04-28  Pavel Podivilov  <podivilov@chromium.org>
2724
2725         Reviewed by Pavel Feldman.
2726
2727         Web Inspector: remove "Pretty print" source frame context menu item.
2728         https://bugs.webkit.org/show_bug.cgi?id=59709
2729
2730         * inspector/front-end/DebuggerPresentationModel.js:
2731         (WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
2732         * inspector/front-end/ScriptsPanel.js:
2733         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
2734         * inspector/front-end/SourceFrame.js:
2735         (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
2736
2737 2011-04-28  Satish Sampath  <satish@chromium.org>
2738
2739         Reviewed by Tony Gentilcore.
2740
2741         Speech input button layout issues with padding and border.
2742         https://bugs.webkit.org/show_bug.cgi?id=59613
2743
2744         * rendering/RenderTextControlSingleLine.cpp:
2745         (WebCore::RenderTextControlSingleLine::layout):
2746         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
2747         (WebCore::RenderTextControlSingleLine::forwardEvent):
2748
2749 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2750
2751         Reviewed by Martin Robinson.
2752
2753         [GTK] Check whether to use native scrollbars at run time
2754         https://bugs.webkit.org/show_bug.cgi?id=59694
2755
2756         It's currently decided at build time depending on whether webkit2
2757         build is enabled or not. That makes imposible to build both
2758         webkit1 and webkit2 using the same libWebCore.
2759
2760         * GNUmakefile.am:
2761         * platform/ScrollView.cpp:
2762         (WebCore::ScrollView::wheelEvent):
2763         * platform/gtk/ScrollViewGtk.cpp:
2764         (WebCore::ScrollView::createScrollbar):
2765
2766 2011-04-28  Pavel Feldman  <pfeldman@google.com>
2767
2768         Reviewed by Yury Semikhatsky.
2769
2770         Web Inspector: add status bar button for pretty print.
2771         https://bugs.webkit.org/show_bug.cgi?id=59467
2772
2773         * WebCore.gypi:
2774         * inspector/front-end/Images/prettyPrintButtonGlyph.png: Added.
2775         * inspector/front-end/ScriptsPanel.js:
2776         (WebInspector.ScriptsPanel):
2777         (WebInspector.ScriptsPanel.prototype.get statusBarItems):
2778         (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
2779         * inspector/front-end/WebKit.qrc:
2780         * inspector/front-end/inspector.css:
2781         (.scripts-toggle-pretty-print-status-bar-item .glyph):
2782         (.scripts-toggle-pretty-print-status-bar-item.toggled .glyph):
2783
2784 2011-04-28  Pavel Feldman  <pfeldman@google.com>
2785
2786         Reviewed by Yury Semikhatsky.
2787
2788         Web Inspector: add ResourceTreeModel tests.
2789         https://bugs.webkit.org/show_bug.cgi?id=59616
2790
2791         Tests: http/tests/inspector/resource-tree/resource-tree-document-url.html
2792                http/tests/inspector/resource-tree/resource-tree-frame-navigate.html
2793                http/tests/inspector/resource-tree/resource-tree-reload.html
2794
2795         * inspector/front-end/ResourceTreeModel.js:
2796         (WebInspector.ResourceTreeModel.prototype.frontendReused):
2797         (WebInspector.ResourceTreeModel.prototype._addFrame):
2798         (WebInspector.ResourceTreeModel.prototype._frameNavigated):
2799         (WebInspector.ResourceTreeModel.prototype._frameDetached):
2800         (WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
2801         (WebInspector.ResourceTreeModel.prototype.forAllResources):
2802         (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources):
2803         (WebInspector.ResourceTreeModel.prototype._callForFrameResources):
2804         (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
2805         * inspector/front-end/ResourcesPanel.js:
2806         (WebInspector.ResourcesPanel.prototype._populateResourceTree):
2807         (WebInspector.ResourcesPanel.prototype._frameAdded):
2808         (WebInspector.ResourcesPanel.prototype._frameDetached):
2809         (WebInspector.ResourcesPanel.prototype._frameNavigated):
2810         (WebInspector.FrameTreeElement):
2811         (WebInspector.FrameTreeElement.prototype.frameNavigated):
2812
2813 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
2814
2815         Reviewed by Yury Semikhatsky.
2816
2817         WebInspector: [Chromium] Implement retaining paths following in detailed heap snapshots.
2818         https://bugs.webkit.org/show_bug.cgi?id=59592
2819
2820         * inspector/front-end/DetailedHeapshotGridNodes.js:
2821         (WebInspector.HeapSnapshotGridNode.prototype._populate):
2822         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
2823         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
2824         (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
2825         * inspector/front-end/DetailedHeapshotView.js:
2826         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
2827         (WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
2828         (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
2829         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid.expandRoute):
2830         (WebInspector.DetailedHeapshotView.prototype._mouseClickInRetainmentGrid):
2831         (WebInspector.DetailedHeapshotView.prototype.changeView.sortingComplete):
2832         (WebInspector.DetailedHeapshotView.prototype.changeView):
2833         * inspector/front-end/HeapSnapshot.js:
2834         (WebInspector.HeapSnapshotPathFinder.prototype.findNext):
2835         (WebInspector.HeapSnapshotPathFinder.prototype._nextEdgeIter):
2836         (WebInspector.HeapSnapshotPathFinder.prototype._buildNextPath):
2837         (WebInspector.HeapSnapshotPathFinder.prototype._pathToString):
2838         (WebInspector.HeapSnapshotPathFinder.prototype._pathToRoute):
2839         * inspector/front-end/heapProfiler.css:
2840         (div.retaining-paths-view td.path-column div:hover):
2841
2842 2011-04-28  Mikhail Naganov  <mnaganov@chromium.org>
2843
2844         Reviewed by Yury Semikhatsky.
2845
2846         Web Inspector: [Chromium] Optimize detailed heap snapshots loading / parsing.
2847         https://bugs.webkit.org/show_bug.cgi?id=59454
2848
2849         Test: inspector/profiler/heap-snapshot-loader.html
2850
2851         * inspector/front-end/HeapSnapshot.js:
2852         (WebInspector.HeapSnapshotLoader):
2853         (WebInspector.HeapSnapshotLoader.prototype._findBalancedCurlyBrackets):
2854         (WebInspector.HeapSnapshotLoader.prototype.finishLoading):
2855         (WebInspector.HeapSnapshotLoader.prototype._parseNodes):
2856         (WebInspector.HeapSnapshotLoader.prototype._parseStringsArray):
2857         (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
2858         * inspector/front-end/HeapSnapshotProxy.js:
2859         (WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
2860
2861 2011-04-28  ojab  <ojab@ojab.ru>
2862
2863         Reviewed by David Levin.
2864
2865         Fix build with libpng-1.5.1
2866         https://bugs.webkit.org/show_bug.cgi?id=59607
2867
2868         * platform/image-decoders/png/PNGImageDecoder.cpp:
2869         (WebCore::readColorProfile):
2870
2871 2011-04-28  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
2872
2873         Reviewed by Nikolas Zimmermann.
2874
2875         Optimizing gaussian blur filter to ARM-neon SIMD instruction set
2876         https://bugs.webkit.org/show_bug.cgi?id=59447
2877
2878         This patch contains two sub-routines, one for speeding up
2879         alpha channel only gaussian blur (by 2.5 times) and one
2880         for speeding up all channel blur (by 4 times).
2881
2882         The common code is also redesigned to better fit for platform
2883         specific code. This means large chunks of code was moved to
2884         different files, and all platform specific files are added to
2885         all build systems.
2886
2887         * CMakeLists.txt:
2888         * GNUmakefile.am:
2889         * GNUmakefile.list.am:
2890         * WebCore.gypi:
2891         * WebCore.pro:
2892         * WebCore.vcproj/WebCore.vcproj:
2893         * WebCore.vcproj/WebCoreCommon.vsprops:
2894         * WebCore.xcodeproj/project.pbxproj:
2895         * platform/graphics/filters/FEGaussianBlur.cpp:
2896         (WebCore::FEGaussianBlur::platformApplyGeneric):
2897         (WebCore::FEGaussianBlur::apply):
2898         * platform/graphics/filters/FEGaussianBlur.h:
2899         (WebCore::FEGaussianBlur::kernelPosition):
2900         (WebCore::FEGaussianBlur::platformApply):
2901         * platform/graphics/filters/FELighting.cpp:
2902         (WebCore::FELighting::platformApplyGeneric):
2903         (WebCore::FELighting::drawLighting):
2904         * platform/graphics/filters/FELighting.h:
2905         (WebCore::FELighting::platformApply):
2906         * platform/graphics/filters/arm/FEGaussianBlurNEON.cpp: Added.
2907         (WebCore::WTF_ALIGNED):
2908         (WebCore::feGaussianBlurConstantsForNeon):
2909         * platform/graphics/filters/arm/FEGaussianBlurNEON.h: Added.
2910         (WebCore::FEGaussianBlur::platformApplyNeon):
2911         * platform/graphics/filters/arm/FELightingNEON.cpp:
2912         (WebCore::WTF_ALIGNED):
2913         (WebCore::FELighting::getPowerCoefficients):
2914         * platform/graphics/filters/arm/FELightingNEON.h:
2915         (WebCore::FELighting::platformApplyNeon):
2916
2917 2011-04-28  Alexander Pavlov  <apavlov@chromium.org>
2918
2919         Reviewed by Yury Semikhatsky.
2920
2921         Web Inspector: provide a hotkey for script pause
2922         https://bugs.webkit.org/show_bug.cgi?id=59593
2923
2924         In fact, F8 works as a hotkey, but this fact was not reflected
2925         in the shortcut help popup.
2926
2927         * English.lproj/localizedStrings.js:
2928         * inspector/front-end/ScriptsPanel.js:
2929         (WebInspector.ScriptsPanel.prototype._registerShortcuts):
2930
2931 2011-04-28  Adam Barth  <abarth@webkit.org>
2932
2933         Reviewed by Eric Seidel.
2934
2935         PluginStream should play nice with strict OwnPtr
2936         https://bugs.webkit.org/show_bug.cgi?id=59675
2937
2938         These failures appear when enabling strict OwnPtr on Qt.
2939
2940         * plugins/PluginStream.cpp:
2941         (WebCore::PluginStream::PluginStream):
2942         (WebCore::PluginStream::didReceiveData):
2943
2944 2011-04-26  Alexander Pavlov  <apavlov@chromium.org>
2945
2946         Reviewed by Pavel Feldman.
2947
2948         Web Inspector: Use CachedResource to retrieve charset-decoded stylesheet text
2949         https://bugs.webkit.org/show_bug.cgi?id=59326
2950
2951         Concrete CachedResource successors for stylesheets and scripts
2952         can decode their content better than the generic approach we use.
2953
2954         * inspector/InspectorPageAgent.cpp:
2955         (WebCore::decodeSharedBuffer):
2956         (WebCore::prepareCachedResourceBuffer):
2957         (WebCore::cachedResourceDecoded):
2958         (WebCore::InspectorPageAgent::resourceContent):
2959         (WebCore::InspectorPageAgent::resourceData):
2960         * inspector/InspectorStyleSheet.cpp:
2961         (WebCore::InspectorStyleSheet::originalStyleSheetText):
2962
2963 2011-04-28  Jon Lee  <jonlee@apple.com>
2964
2965         Reviewed by Simon Fraser.
2966
2967         REGRESSION: white overlay scrollbars on apple.com/startpage
2968         https://bugs.webkit.org/show_bug.cgi?id=59540
2969         <rdar://problem/9338653>
2970
2971         Now we look at the document background in addition to the <body> element,
2972         and blend those colors in with the base background of the frame view to
2973         arrive at our aggregate color. This provides a better result to determine
2974         overlay scrollbar style.
2975
2976         * page/Frame.cpp:
2977         (WebCore::Frame::getDocumentBackgroundColor): look up the colors on the html and body element, and properly composite them.
2978         * platform/graphics/Color.h: a short comment to note that blend() uses the Porter-Duff source-over equation
2979
2980 2011-04-27  Adam Barth  <abarth@webkit.org>
2981
2982         Reviewed by Maciej Stachowiak.
2983
2984         Fix OwnPtr issues in IndexedDB
2985         https://bugs.webkit.org/show_bug.cgi?id=59656
2986
2987         This patch is an attempt to fix the clang build.  Clang can't seem to
2988         cope with OwnPtrs to classes declared in an anonymous namespace because
2989         OwnPtr's copy constructor isn't defined (but would need to be defined
2990         in this translation unit).
2991
2992         * platform/leveldb/LevelDBDatabase.cpp:
2993
2994 2011-04-27  Ryuan Choi  <ryuan.choi@samsung.com>
2995
2996         Reviewed by Antonio Gomes.
2997
2998         [EFL] Change cursor to LAZY_NATIVE_CURSOR
2999         https://bugs.webkit.org/show_bug.cgi?id=59411
3000
3001         Enable LAZY_NATIVE_CURSOR on EFL build.
3002
3003         No test added because functionality is unchanged.
3004
3005         * CMakeListsEfl.txt: Add Cursor.cpp
3006         * platform/Cursor.h:
3007         (WebCore::Cursor::Cursor):
3008         * platform/efl/CursorEfl.cpp:
3009         (WebCore::Cursor::Cursor):
3010         (WebCore::Cursor::~Cursor):
3011         (WebCore::getCursorString):
3012         (WebCore::Cursor::ensurePlatformCursor):
3013         * platform/efl/WidgetEfl.cpp:
3014         (WebCore::Widget::setCursor):
3015
3016 2011-04-27  Adam Barth  <abarth@webkit.org>
3017
3018         Build fix from the future.  Another trival strict OwnPtr fixes.  This
3019         is the last futuristic build fix I can detect with my time traveling
3020         abilities.
3021
3022         * platform/graphics/chromium/TransparencyWin.cpp:
3023         (WebCore::TransparencyWin::initializeNewContext):
3024
3025 2011-04-27  Dmitry Lomov  <dslomov@google.com>
3026
3027         Reviewed by David Levin.
3028
3029         CrossThreadCopier should not have a default specialization for raw pointers
3030         https://bugs.webkit.org/show_bug.cgi?id=59234
3031         Removed the ablity to pass raw pointers cross-thread
3032         Added and applied annotations for doing that
3033
3034         * fileapi/FileReader.cpp:
3035         (WebCore::FileReader::readInternal):
3036         (WebCore::FileReader::abort):
3037         * fileapi/FileStreamProxy.cpp:
3038         (WebCore::FileStreamProxy::startOnFileThread):
3039         (WebCore::FileStreamProxy::stopOnFileThread):
3040         (WebCore::FileStreamProxy::getSize):
3041         (WebCore::FileStreamProxy::getSizeOnFileThread):
3042         (WebCore::FileStreamProxy::openForRead):
3043         (WebCore::FileStreamProxy::openForReadOnFileThread):
3044         (WebCore::FileStreamProxy::openForWrite):
3045         (WebCore::FileStreamProxy::openForWriteOnFileThread):
3046         (WebCore::FileStreamProxy::close):
3047         (WebCore::FileStreamProxy::read):
3048         (WebCore::FileStreamProxy::readOnFileThread):
3049         (WebCore::FileStreamProxy::write):
3050         (WebCore::FileStreamProxy::writeOnFileThread):
3051         (WebCore::FileStreamProxy::truncate):
3052         (WebCore::FileStreamProxy::truncateOnFileThread):
3053         * loader/WorkerThreadableLoader.cpp:
3054         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
3055         (WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
3056         (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):
3057         * page/GeolocationPositionCache.cpp:
3058         (WebCore::GeolocationPositionCache::triggerReadFromDatabase):
3059         (WebCore::GeolocationPositionCache::triggerWriteToDatabase):
3060         * platform/CrossThreadCopier.h:
3061         (WebCore::AllowCrossThreadAccessWrapper::AllowCrossThreadAccessWrapper):
3062         (WebCore::AllowCrossThreadAccessWrapper::value):
3063         (WebCore::AllowCrossThreadAccess):
3064         (WebCore::AllowExtendedLifetimeWrapper::AllowExtendedLifetimeWrapper):
3065         (WebCore::AllowExtendedLifetimeWrapper::value):
3066         (WebCore::AllowExtendedLifetime):
3067         * platform/graphics/chromium/cc/CCCompletionEvent.h:
3068         * storage/IDBObjectStoreBackendImpl.cpp:
3069         (WebCore::IDBObjectStoreBackendImpl::get):
3070         (WebCore::IDBObjectStoreBackendImpl::put):
3071         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
3072         (WebCore::IDBObjectStoreBackendImpl::clear):
3073         (WebCore::IDBObjectStoreBackendImpl::createIndex):
3074         (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
3075         (WebCore::IDBObjectStoreBackendImpl::openCursor):
3076         * storage/SQLCallbackWrapper.h:
3077         (WebCore::SQLCallbackWrapper::clear):
3078         * websockets/WorkerThreadableWebSocketChannel.cpp:
3079         (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
3080         (WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
3081         (WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
3082         (WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
3083         (WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):
3084         (WebCore::WorkerThreadableWebSocketChannel::Bridge::close):
3085         (WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
3086         (WebCore::WorkerThreadableWebSocketChannel::Bridge::suspend):
3087         (WebCore::WorkerThreadableWebSocketChannel::Bridge::resume):
3088         * workers/WorkerMessagingProxy.cpp:
3089         (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
3090
3091 2011-04-27  Adam Barth  <abarth@webkit.org>
3092
3093         Two build fixes from the future.  (Trivial strict OwnPtr fixes.)
3094
3095         * page/Frame.cpp:
3096         (WebCore::Frame::setTiledBackingStoreEnabled):
3097         * platform/audio/ReverbConvolver.cpp:
3098         (WebCore::ReverbConvolver::ReverbConvolver):
3099
3100 2011-04-27  Adam Barth  <abarth@webkit.org>
3101
3102         Reviewed by David Levin.
3103
3104         Fix five strict PassOwnPtr violations in WebCore
3105         https://bugs.webkit.org/show_bug.cgi?id=59640
3106
3107         * css/MediaList.cpp:
3108         (WebCore::MediaList::deleteMedium):
3109         (WebCore::MediaList::setMediaText):
3110         (WebCore::MediaList::appendMedium):
3111         * css/MediaQuery.h:
3112         * dom/MessagePort.cpp:
3113         (WebCore::MessagePort::disentanglePorts):
3114         (WebCore::MessagePort::entanglePorts):
3115         * inspector/InspectorStyleSheet.cpp:
3116         (ParsedStyleSheet::setText):
3117         * rendering/RenderTheme.cpp:
3118         (WebCore::RenderTheme::adjustStyle):
3119         (WebCore::RenderTheme::adjustMeterStyle):
3120         * rendering/RenderThemeMac.mm:
3121         (WebCore::RenderThemeMac::adjustMenuListStyle):
3122         (WebCore::RenderThemeMac::adjustSliderTrackStyle):
3123         (WebCore::RenderThemeMac::adjustSliderThumbStyle):
3124         (WebCore::RenderThemeMac::adjustSearchFieldStyle):
3125         (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
3126         (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
3127         (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
3128         (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
3129
3130 2011-04-27  Chris Fleizach  <cfleizach@apple.com>
3131
3132         Reviewed by Beth Dakin.
3133
3134         <rdar://problem/9315254> ARIA role attribute implemented incorrectly; does not support token list with fallbacks
3135         https://bugs.webkit.org/show_bug.cgi?id=59648
3136
3137         Test: accessibility/aria-fallback-roles.html
3138
3139         * accessibility/AccessibilityObject.cpp:
3140         (WebCore::AccessibilityObject::ariaRoleToWebCoreRole):
3141
3142 2011-04-27  Beth Dakin  <bdakin@apple.com>
3143
3144         Reviewed by Dan Bernstein.
3145
3146         https://bugs.webkit.org/show_bug.cgi?id=59671
3147         Race condition with scrollbar animations and closing a page can cause a crash in
3148         WebCore::FrameView::setVisibleScrollerThumbRect + 15
3149         -and corresponding-
3150         <rdar://problem/9329253>
3151
3152         It is definitely possible for Page to be null here. So we should null-check it!
3153         And we should not ASSERT.
3154         * page/FrameView.cpp:
3155         (WebCore::FrameView::didCompleteRubberBand):
3156         (WebCore::FrameView::scrollbarStyleChanged):
3157         (WebCore::FrameView::setVisibleScrollerThumbRect):
3158
3159 2011-04-27  Ryosuke Niwa  <rniwa@webkit.org>
3160
3161         WinCE build fix after r85143.
3162
3163         * platform/graphics/wince/FontWinCE.cpp:
3164         (WebCore::TextRunComponent::TextRunComponent):
3165
3166 2011-04-27  Mark Pilgrim  <pilgrim@chromium.org>
3167
3168         Reviewed by Tony Chang.
3169
3170         IndexedDB object store delete should fail if key is null
3171         https://bugs.webkit.org/show_bug.cgi?id=58614
3172
3173         Test: storage/indexeddb/mozilla/key-requirements-delete-null-key.html
3174
3175         * storage/IDBObjectStoreBackendImpl.cpp:
3176         (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
3177
3178 2011-04-27  Eric Seidel  <eric@webkit.org>
3179
3180         Reviewed by Ryosuke Niwa.
3181
3182         Should have an easy way to construct starting BidiStatus for a paragraph root
3183         https://bugs.webkit.org/show_bug.cgi?id=59226
3184
3185         Two places try to construct BidiStatuses for a paragraph root using copy/paste code.
3186         I've made this a constructor for BidiStatus instead.
3187
3188         As part of this effort I added a direction() accessor for TextRun and got
3189         rid of the old m_rtl bool.  This is part of the generic effort in the
3190         Bidi code to replace old bool usage with the superior TextDirection enum
3191         (this generally makes the code cleaner).
3192
3193         As part of this replacement effort I found several places which were
3194         assuming LTR (by passing rtl=false) when they probably want to use
3195         the current text direction.  I suspect that LTR vs. RTL may affect
3196         string width in the case of ligatures.  It's unclear.
3197
3198         This is almost entirely a mechanical change.
3199
3200         * html/canvas/CanvasRenderingContext2D.cpp:
3201         (WebCore::CanvasRenderingContext2D::drawTextInternal):
3202         * platform/graphics/GraphicsContext.cpp:
3203         (WebCore::GraphicsContext::drawBidiText):
3204         * platform/graphics/TextRun.h:
3205         (WebCore::TextRun::TextRun):
3206         (WebCore::TextRun::direction):
3207         (WebCore::TextRun::rtl):
3208         (WebCore::TextRun::ltr):
3209         (WebCore::TextRun::setDirection):
3210         * platform/text/BidiResolver.h:
3211         (WebCore::BidiStatus::BidiStatus):
3212         * rendering/EllipsisBox.cpp:
3213         (WebCore::EllipsisBox::paint):
3214         (WebCore::EllipsisBox::selectionRect):
3215         (WebCore::EllipsisBox::paintSelection):
3216         * rendering/InlineTextBox.cpp:
3217         (WebCore::InlineTextBox::selectionRect):
3218         (WebCore::InlineTextBox::paint):
3219         (WebCore::InlineTextBox::paintSelection):
3220         (WebCore::InlineTextBox::paintCompositionBackground):
3221         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
3222         (WebCore::InlineTextBox::paintTextMatchMarker):
3223         (WebCore::InlineTextBox::computeRectForReplacementMarker):
3224         (WebCore::InlineTextBox::offsetForPosition):
3225         (WebCore::InlineTextBox::positionForOffset):
3226         * rendering/RenderBlockLineLayout.cpp:
3227         (WebCore::RenderBlock::determineStartPosition):
3228         * rendering/RenderFileUploadControl.cpp:
3229         (WebCore::RenderFileUploadControl::paintObject):
3230         (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
3231         * rendering/RenderListBox.cpp:
3232         (WebCore::RenderListBox::updateFromElement):
3233         (WebCore::RenderListBox::paintItemForeground):
3234         * rendering/RenderTextControl.cpp:
3235         (WebCore::RenderTextControl::getAvgCharWidth):
3236         (WebCore::RenderTextControl::paintPlaceholder):
3237         * rendering/svg/SVGInlineTextBox.cpp:
3238         (WebCore::SVGInlineTextBox::constructTextRun):
3239         * rendering/svg/SVGTextMetrics.cpp:
3240         (WebCore::constructTextRun):
3241
3242 2011-04-27  Robert Hogan  <robert@webkit.org>
3243
3244         Reviewed by Adam Barth.
3245
3246         Allow shadowing of history object
3247         https://bugs.webkit.org/show_bug.cgi?id=55965
3248
3249         Tests: http/tests/history/cross-origin-replace-history-object-child.html
3250                http/tests/history/cross-origin-replace-history-object.html
3251
3252         * page/DOMWindow.idl:
3253
3254 2011-04-27  James Robinson  <jamesr@chromium.org>
3255
3256         Reviewed by Kenneth Russell.
3257
3258         [chromium] Ensure compositing layers are up to date before entering doComposite
3259         https://bugs.webkit.org/show_bug.cgi?id=59159
3260
3261         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
3262         GraphicsLayerClient::paintContents() implementations).
3263
3264         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
3265         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
3266         * platform/graphics/chromium/LayerChromium.cpp:
3267         (WebCore::LayerChromium::LayerChromium):
3268         (WebCore::LayerChromium::~LayerChromium):
3269         * platform/graphics/chromium/LayerRendererChromium.cpp:
3270         (WebCore::LayerRendererChromium::updateLayers):
3271         * platform/graphics/chromium/LayerRendererChromium.h:
3272           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
3273
3274 2011-04-27  James Robinson  <jamesr@chromium.org>
3275
3276         Reviewed by Adam Barth.
3277
3278         Fix OwnPtr strict issues in chromium linux build
3279         https://bugs.webkit.org/show_bug.cgi?id=59664
3280
3281         * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
3282         (WebCore::ComplexTextController::getNormalizedTextRun):
3283         * platform/graphics/skia/ImageBufferSkia.cpp:
3284         (WebCore::ImageBuffer::ImageBuffer):
3285         * platform/graphics/skia/PlatformContextSkia.cpp:
3286         (WebCore::PlatformContextSkia::PlatformContextSkia):
3287
3288 2011-04-27  Chris Rogers  <crogers@google.com>
3289
3290         Reviewed by Kenneth Russell.
3291
3292         Make sure to set sample-rate of created AudioBus in AudioBus::createBySampleRateConverting()
3293         https://bugs.webkit.org/show_bug.cgi?id=59641
3294
3295         No new tests since audio API is not yet implemented.
3296
3297         * platform/audio/AudioBus.cpp:
3298         (WebCore::AudioBus::createBySampleRateConverting):
3299         (WebCore::AudioBus::createByMixingToMono):
3300
3301 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
3302
3303         Motivated by Alexey Proskuryakov.
3304
3305         * bindings/scripts/CodeGeneratorJS.pm: Tried to make this comment more
3306         informative, since it confused Alexey and me.
3307
3308 2011-04-27  Geoffrey Garen  <ggaren@apple.com>
3309
3310         Reviewed by Sam Weinig.
3311
3312         Fixed a small leak related to CSSValues when deallocating a DOMWrapperWorld
3313         https://bugs.webkit.org/show_bug.cgi?id=59646
3314
3315         Made the cssValueRoots map per-world, instead of a global. When we deallocate
3316         a world, we need to clear all entries in the map for that world, since
3317         the finalizers that would otherwise clear those entries don't run. The
3318         simplest way to do this is just to make the world own the map.
3319
3320         * bindings/js/DOMWrapperWorld.h:
3321         * bindings/js/JSCSSStyleDeclarationCustom.cpp:
3322         (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
3323         * bindings/js/JSCSSValueCustom.cpp:
3324         (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
3325         (WebCore::JSCSSValueOwner::finalize):
3326         * bindings/js/JSDOMBinding.h:
3327
3328 2011-04-27  Adam Barth  <abarth@webkit.org>
3329
3330         Reviewed by David Levin.
3331
3332         Fix OwnPtr issues in IndexedDB
3333         https://bugs.webkit.org/show_bug.cgi?id=59656
3334
3335         I didn't do an exhaustive review of this code, but I fixed the problems
3336         caught by turning on strict OwnPtr and all their antecedents.  This
3337         patch is entirely tighter bookkeeping.  There shouldn't be any actual
3338         behavior change.
3339
3340         * platform/leveldb/LevelDBDatabase.cpp:
3341         (WebCore::LevelDBDatabase::LevelDBDatabase):
3342         (WebCore::LevelDBDatabase::open):
3343         (WebCore::LevelDBDatabase::createIterator):
3344         * platform/leveldb/LevelDBDatabase.h:
3345         * platform/leveldb/LevelDBIterator.cpp:
3346         (WebCore::LevelDBIterator::LevelDBIterator):
3347         * platform/leveldb/LevelDBIterator.h:
3348         * storage/IDBLevelDBBackingStore.cpp:
3349         (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
3350         (WebCore::IDBLevelDBBackingStore::open):
3351         (WebCore::getNewDatabaseId):
3352         (WebCore::IDBLevelDBBackingStore::getObjectStores):
3353         (WebCore::getNewObjectStoreId):
3354         (WebCore::deleteRange):
3355         (WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
3356         (WebCore::IDBLevelDBBackingStore::forEachObjectStoreRecord):
3357         (WebCore::IDBLevelDBBackingStore::getIndexes):
3358         (WebCore::getNewIndexId):
3359         (WebCore::findGreatestKeyLessThan):
3360         (WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
3361         (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
3362         (WebCore::findLastIndexKeyEqualTo):
3363         * storage/IDBLevelDBBackingStore.h:
3364
3365 2011-04-19  MORITA Hajime  <morrita@google.com>
3366
3367         Reviewed by Tony Chang.
3368
3369         [Refactoring] DocumentMarkerController::MarkerMapVectorPair should be replaced with a list of some class.
3370         https://bugs.webkit.org/show_bug.cgi?id=58113
3371
3372         * Introduced RenderedDocumentMarker, a subclass of DocumentMarker.
3373         * Eliminated Vector<IntRect> and move the IntRect into RenderedDocumentMarker
3374         * Now MarkerMapVectorPair is no longer used.
3375
3376         No new tests, No behavior change.
3377
3378         * GNUmakefile.list.am:
3379         * WebCore.gypi:
3380         * WebCore.pro:
3381         * WebCore.vcproj/WebCore.vcproj:
3382         * WebCore.xcodeproj/project.pbxproj:
3383         * dom/DocumentMarker.h:
3384         * dom/DocumentMarkerController.cpp:
3385         (WebCore::DocumentMarkerController::addMarker):
3386         (WebCore::DocumentMarkerController::copyMarkers):
3387         (WebCore::DocumentMarkerController::removeMarkers):
3388         (WebCore::DocumentMarkerController::markerContainingPoint):
3389         (WebCore::DocumentMarkerController::markersForNode):
3390         (WebCore::DocumentMarkerController::renderedRectsForMarkers):
3391         (WebCore::DocumentMarkerController::removeMarkersFromList):
3392         (WebCore::DocumentMarkerController::repaintMarkers):
3393         (WebCore::DocumentMarkerController::setRenderedRectForMarker):
3394         (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
3395         (WebCore::DocumentMarkerController::shiftMarkers):
3396         (WebCore::DocumentMarkerController::setMarkersActive):
3397         (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):
3398         (WebCore::DocumentMarkerController::showMarkers):
3399         * dom/DocumentMarkerController.h:
3400         * dom/RenderedDocumentMarker.h: Added.
3401         (WebCore::RenderedDocumentMarker::RenderedDocumentMarker):
3402         (WebCore::RenderedDocumentMarker::isRendered):
3403         (WebCore::RenderedDocumentMarker::contains):
3404         (WebCore::RenderedDocumentMarker::setRenderedRect):
3405         (WebCore::RenderedDocumentMarker::renderedRect):
3406         (WebCore::RenderedDocumentMarker::invalidate):
3407         (WebCore::RenderedDocumentMarker::invalidMarkerRect):
3408
3409 2011-04-27  James Robinson  <jamesr@chromium.org>
3410
3411         Unreviewed, rolling out r85112.
3412         http://trac.webkit.org/changeset/85112
3413         https://bugs.webkit.org/show_bug.cgi?id=59159
3414
3415         Broke mac compile
3416
3417         * page/FrameView.cpp:
3418         (WebCore::FrameView::updateCompositingLayers):
3419         * page/FrameView.h:
3420         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
3421         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
3422         * platform/graphics/chromium/LayerChromium.cpp:
3423         (WebCore::LayerChromium::LayerChromium):
3424         (WebCore::LayerChromium::~LayerChromium):
3425         * platform/graphics/chromium/LayerRendererChromium.cpp:
3426         (WebCore::LayerRendererChromium::updateLayers):
3427         * platform/graphics/chromium/LayerRendererChromium.h:
3428
3429 2011-04-27  Mark Rowe  <mrowe@apple.com>
3430
3431         Build fix.
3432
3433         * WebCore.xcodeproj/project.pbxproj: Make RenderLayerCompositor.h accessbile to WebKit and WebKit2.
3434
3435 2011-04-27  Pratik Solanki  <psolanki@apple.com>
3436
3437         Unreviewed. Fix WinCE build. The include should be guarded inside USE(CFNETWORK).
3438
3439         * platform/network/ResourceHandleClient.h:
3440
3441 2011-04-27  James Robinson  <jamesr@chromium.org>
3442
3443         Reviewed by Kenneth Russell.
3444
3445         [chromium] Ensure compositing layers are up to date before entering doComposite
3446         https://bugs.webkit.org/show_bug.cgi?id=59159
3447
3448         Adds some assertions to try to catch GraphicsLayer mutations at bad times (such as during
3449         GraphicsLayerClient::paintContents() implementations).
3450
3451         * page/FrameView.cpp:
3452         (WebCore::FrameView::updateCompositingLayers):
3453             Add an optional CompositingUpdateType parameter.
3454         * page/FrameView.h:
3455         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
3456         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
3457         * platform/graphics/chromium/LayerChromium.cpp:
3458         (WebCore::LayerChromium::LayerChromium):
3459         (WebCore::LayerChromium::~LayerChromium):
3460         * platform/graphics/chromium/LayerRendererChromium.cpp:
3461         (WebCore::LayerRendererChromium::updateLayers):
3462         * platform/graphics/chromium/LayerRendererChromium.h:
3463           Add a set of assertions that we aren't creating or destroying LayerChromiums during paintContents
3464         * rendering/RenderLayer.cpp:
3465         (WebCore::RenderLayer::dirtyZOrderLists):
3466         (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded):
3467         * rendering/RenderLayerCompositor.cpp:
3468         (WebCore::RenderLayerCompositor::updateCompositingLayers):
3469         * rendering/RenderLayerCompositor.h:
3470           Fix a typo in CompositingUpdateType Pait->Paint
3471
3472 2011-04-27  Pratik Solanki  <psolanki@apple.com>
3473
3474         Reviewed by Antti Koivisto.
3475
3476         Part of WebCore should use CFNetwork-based loader on Mac
3477         https://bugs.webkit.org/show_bug.cgi?id=51836
3478
3479         Add willCacheResponse method when using CFNetwork on Mac. Also put appropriate ifdefs around
3480         willCacheResponse/shouldCacheResponse.
3481
3482         * loader/EmptyClients.h:
3483         * loader/FrameLoaderClient.h:
3484         * loader/ResourceLoader.h:
3485         * loader/cf/ResourceLoaderCFNet.cpp:
3486         * loader/mac/ResourceLoaderMac.mm:
3487         (WebCore::ResourceLoader::willCacheResponse):
3488         * platform/network/ResourceHandleClient.h:
3489         (WebCore::ResourceHandleClient::willCacheResponse):
3490         (WebCore::ResourceHandleClient::shouldCacheResponse):
3491         * platform/network/cf/ResourceHandleCFNet.cpp:
3492         (WebCore::willCacheResponse):
3493
3494 2011-04-27  Ilya Tikhonovsky  <loislo@chromium.org>
3495
3496         Reviewed by Brian Weinstein.
3497
3498         Web Inspector: Stop on Exception state does not persist.
3499
3500         A wrong property name was used when we persist PauseOnExceptionState property to Local Storage.
3501         https://bugs.webkit.org/show_bug.cgi?id=59630
3502
3503         * inspector/front-end/ScriptsPanel.js:
3504         (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
3505         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions.callback):
3506         (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):