0e948652a1059f32f9ef56a6f9360692e759b4c4
[WebKit-https.git] / Source / WebCore / ChangeLog
1 2011-03-10  Alexander Pavlov  <apavlov@chromium.org>
2
3         Reviewed by Pavel Feldman.
4
5         Web Inspector: Invalid expected parameter list in CSSAgent.setSelectorText() callback (CSSStyleModel.js)
6         https://bugs.webkit.org/show_bug.cgi?id=56092
7
8         * inspector/front-end/CSSStyleModel.js:
9         (WebInspector.CSSStyleModel.prototype.setRuleSelector):
10
11 2011-03-10  Pavel Feldman  <pfeldman@chromium.org>
12
13         Not reviewed: rolling out r80478 and its follow ups for breaking
14         inspector and engadget.com.
15         https://bugs.webkit.org/show_bug.cgi?id=49401
16
17         * dom/Document.cpp:
18         (WebCore::Document::Document):
19         (WebCore::performTask):
20         (WebCore::Document::postTask):
21         * dom/Document.h:
22         * loader/FrameLoader.cpp:
23         (WebCore::FrameLoader::setDefersLoading):
24         * manual-tests/database-callback-deferred.html: Removed.
25         * page/PageGroupLoadDeferrer.cpp:
26         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
27         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
28
29 2011-03-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
30
31         Reviewed by Kenneth Rohde Christiansen.
32
33         Tiled backing store's delegated scroll request uses incorrect convention
34         https://bugs.webkit.org/show_bug.cgi?id=56011
35
36         Use a point instead of delta, when relaying the scroll request from
37         ScrollView::setScrollPosition.
38
39         * loader/EmptyClients.h:
40         (WebCore::EmptyChromeClient::delegatedScrollRequested):
41         * page/Chrome.cpp:
42         (WebCore::Chrome::delegatedScrollRequested):
43         * page/Chrome.h:
44         * page/ChromeClient.h:
45         * platform/HostWindow.h:
46         * platform/ScrollView.cpp:
47         (WebCore::ScrollView::setScrollPosition):
48
49 2011-03-10  Pavel Feldman  <pfeldman@chromium.org>
50
51         Reviewed by Yury Semikhatsky.
52
53         Web Inspector: brush up DOM agent API.
54         https://bugs.webkit.org/show_bug.cgi?id=56093
55
56         * inspector/Inspector.idl:
57         * inspector/InspectorDOMAgent.cpp:
58         (WebCore::InspectorDOMAgent::childNodes):
59         (WebCore::InspectorDOMAgent::setNodeName):
60         (WebCore::InspectorDOMAgent::outerHTML):
61         (WebCore::InspectorDOMAgent::setNodeValue):
62         * inspector/InspectorDOMAgent.h:
63         * inspector/front-end/DOMAgent.js:
64         (WebInspector.DOMNode):
65         (WebInspector.DOMNode.prototype.hasAttributes):
66         (WebInspector.DOMNode.prototype.nodeType):
67         (WebInspector.DOMNode.prototype.nodeName):
68         (WebInspector.DOMNode.prototype.setNodeName):
69         (WebInspector.DOMNode.prototype.localName):
70         (WebInspector.DOMNode.prototype.nodeValue):
71         (WebInspector.DOMNode.prototype.setNodeValue):
72         (WebInspector.DOMNode.prototype.setAttribute):
73         (WebInspector.DOMNode.prototype.attributes):
74         (WebInspector.DOMNode.prototype.removeAttribute):
75         (WebInspector.DOMNode.prototype.childNodes.mycallback):
76         (WebInspector.DOMNode.prototype.childNodes):
77         (WebInspector.DOMNode.prototype.outerHTML):
78         (WebInspector.DOMNode.prototype.setOuterHTML):
79         (WebInspector.DOMNode.prototype.removeNode):
80         (WebInspector.DOMNode.prototype.copyNode):
81         (WebInspector.DOMNode.prototype.path):
82         (WebInspector.DOMNode.prototype._setAttributesPayload):
83         (WebInspector.DOMNode.prototype._addAttribute):
84         (WebInspector.DOMAgent.prototype._characterDataModified):
85         * inspector/front-end/ElementsPanel.js:
86         (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
87         (WebInspector.ElementsPanel.prototype.decorateNodeLabel):
88         (WebInspector.ElementsPanel.prototype.handleCopyEvent):
89         * inspector/front-end/ElementsTreeOutline.js:
90         (WebInspector.ElementsTreeOutline.prototype.findTreeElement):
91         (WebInspector.ElementsTreeElement):
92         (WebInspector.ElementsTreeElement.prototype.updateChildren):
93         (WebInspector.ElementsTreeElement.prototype._updateChildren):
94         (WebInspector.ElementsTreeElement.prototype._startEditingTarget):
95         (WebInspector.ElementsTreeElement.prototype._startEditing):
96         (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
97         (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.moveToNextAttributeIfNeeded):
98         (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
99         (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted):
100         (WebInspector.ElementsTreeElement.prototype._attributeHTML):
101         ():
102         * inspector/front-end/EventListenersSidebarPane.js:
103         ():
104         * inspector/front-end/MetricsSidebarPane.js:
105         * inspector/front-end/StylesSidebarPane.js:
106         * inspector/front-end/utilities.js:
107
108 2011-03-09  Alexander Pavlov  <apavlov@chromium.org>
109
110         Reviewed by Pavel Feldman.
111
112         Web Inspector: [STYLES] Editing a property value adds a word for any property value that uses a paren
113         https://bugs.webkit.org/show_bug.cgi?id=56002
114
115         * inspector/front-end/StylesSidebarPane.js: Introduce an additional check.
116
117 2011-03-09  Pavel Podivilov  <podivilov@chromium.org>
118
119         Reviewed by Pavel Feldman.
120
121         Web Inspector: use DebuggerPresentation instead of DebuggerModel in source frame delegate.
122         https://bugs.webkit.org/show_bug.cgi?id=56034
123
124         * inspector/front-end/DebuggerPresentationModel.js:
125         (WebInspector.DebuggerPresentationModel.prototype.continueToLine):
126         (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
127         (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
128         (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
129         (WebInspector.DebuggerPresentationModel.prototype._sourceLocationToActualLocation):
130         * inspector/front-end/ScriptsPanel.js:
131         (WebInspector.ScriptsPanel.prototype._createSourceFrame):
132         (WebInspector.SourceFrameDelegateForScriptsPanel):
133         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setBreakpoint):
134         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.updateBreakpoint):
135         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.removeBreakpoint):
136         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.findBreakpoint):
137         (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.continueToLine):
138         * inspector/front-end/SourceFrame.js:
139         (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
140         (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition):
141         (WebInspector.SourceFrame.prototype._contextMenu.else.setBreakpointEnabled):
142         (WebInspector.SourceFrame.prototype._contextMenu):
143         (WebInspector.SourceFrame.prototype._mouseDown):
144         (WebInspector.SourceFrameDelegate.prototype.removeBreakpoint):
145         (WebInspector.SourceFrameDelegate.prototype.updateBreakpoint):
146
147 2011-03-09  Alexander Pavlov  <apavlov@chromium.org>
148
149         Reviewed by Pavel Feldman.
150
151         Web Inspector: elements dom tree - word wrap toggle
152         https://bugs.webkit.org/show_bug.cgi?id=44311
153
154         A "Word Wrap" option is now shown in a context menu for the entire DOM tree content area
155         and persisted into application settings.
156
157         * English.lproj/localizedStrings.js:
158         * inspector/front-end/ElementsPanel.js:
159         (WebInspector.ElementsPanel.prototype._contextMenuEventFired):
160         (WebInspector.ElementsPanel.prototype._contextMenuEventFired.toggleWordWrap):
161         * inspector/front-end/ElementsTreeOutline.js:
162         (WebInspector.ElementsTreeOutline):
163         (WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
164         (WebInspector.ElementsTreeOutline.prototype.populateContextMenu):
165         (WebInspector.ElementsTreeElement.prototype.onreveal):
166         * inspector/front-end/Settings.js:
167         (WebInspector.Settings):
168         * inspector/front-end/inspector.css:
169         (#elements-content.nowrap):
170         (#elements-content > ol):
171
172 2011-03-09  Pavel Podivilov  <podivilov@chromium.org>
173
174         Reviewed by Pavel Feldman.
175
176         Web Inspector: re-implement breakpoints sidebar pane based on debugger presentation model.
177         https://bugs.webkit.org/show_bug.cgi?id=55823
178
179         * inspector/front-end/BreakpointsSidebarPane.js:
180         (WebInspector.JavaScriptBreakpointsSidebarPane):
181         (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint.didLoadSnippet):
182         (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint):
183         (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.removeBreakpoint):
184         (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.highlightBreakpoint):
185         (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.clearBreakpointHighlight):
186         (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._createBreakpointItemId):
187         (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointClicked):
188         (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointCheckboxClicked):
189         (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._contextMenu):
190         (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.reset):
191         * inspector/front-end/DebuggerPresentationModel.js:
192         (WebInspector.DebuggerPresentationModel):
193         (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
194         (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
195         (WebInspector.DebuggerPresentationModel.prototype._revealHiddenBreakpoints):
196         (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
197         (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
198         (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
199         (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
200         (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
201         (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
202         (WebInspector.DebuggerPresentationModel.prototype.reset):
203         * inspector/front-end/ScriptsPanel.js:
204         (WebInspector.ScriptsPanel):
205         (WebInspector.ScriptsPanel.prototype._breakpointAdded):
206         (WebInspector.ScriptsPanel.prototype._breakpointRemoved):
207         (WebInspector.ScriptsPanel.prototype._debuggerPaused):
208         (WebInspector.ScriptsPanel.prototype.reset):
209         (WebInspector.ScriptsPanel.prototype._clearInterface):
210
211 2011-03-10  Andrey Adaikin  <aandrey@google.com>
212
213         Reviewed by Pavel Feldman.
214
215         Web Inspector: Highlighter refactoring
216         https://bugs.webkit.org/show_bug.cgi?id=56015
217
218         * inspector/front-end/TextEditorHighlighter.js:
219         (WebInspector.TextEditorHighlighter):
220         (WebInspector.TextEditorHighlighter.prototype.set mimeType):
221         (WebInspector.TextEditorHighlighter.prototype.highlight):
222         (WebInspector.TextEditorHighlighter.prototype.updateHighlight):
223         (WebInspector.TextEditorHighlighter.prototype._highlightInChunks):
224         (WebInspector.TextEditorHighlighter.prototype._highlightLines):
225         (WebInspector.TextEditorHighlighter.prototype._selectHighlightState):
226         (WebInspector.TextEditorHighlighter.prototype._clearHighlightState):
227         * inspector/front-end/TextViewer.js:
228         (WebInspector.TextEditorMainPanel.prototype._buildChunks):
229         (WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
230
231 2011-03-05  Pavel Podivilov  <podivilov@chromium.org>
232
233         Reviewed by Pavel Feldman.
234
235         Web Inspector: move breakpoint column adjustment to debugger model.
236         https://bugs.webkit.org/show_bug.cgi?id=55821
237
238         Test: inspector/debugger/debug-inlined-scripts.html
239
240         * inspector/front-end/DebuggerModel.js:
241         (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
242         (WebInspector.DebuggerModel.prototype.setBreakpoint):
243         * inspector/front-end/SourceFrameContent.js:
244         (WebInspector.SourceFrameContent.prototype.sourceFrameLineNumberToActualLocation):
245
246 2011-01-21  John Knottenbelt  <jknotten@chromium.org>
247
248         Reviewed by Dmitry Titov.
249
250         Detach Geolocation from Frame when Page destroyed.
251         https://bugs.webkit.org/show_bug.cgi?id=52877
252
253         On Page destruction, any outstanding Geolocation permission
254         requests should be cancelled, because the Geolocation can only
255         access the client indirectly via m_frame->page().
256
257         Page destruction is signalled by a call to the
258         Frame::pageDestroyed() method. This explictly calls
259         DOMWindow::resetGeolocation which ultimately calls Geolocation::reset.
260
261         Geolocation::reset() detaches from the GeolocationController,
262         cancels requests, watches and single shots, and sets the
263         permission state back to Unknown.
264
265         Frame::pageDestroyed() is also called by FrameLoader even though
266         the page is not destroyed. We should still cancel permission
267         requests, because the GeolocationClient will become inaccessible
268         to the Geolocation object after this call.
269
270         Frame::transferChildFrameToNewDocument also indirectly calls
271         Geolocation::reset when the frame is reparented between
272         pages. Ideally we would like the Geolocation's activities to
273         continue after reparenting, see bug
274         https://bugs.webkit.org/show_bug.cgi?id=55577
275
276         Since GeolocationController is owned by Page, and all Geolocation
277         objects will now unsubscribe from the GeolocationController on
278         pageDetached(), we no longer need to call stopUpdating() from the
279         GeolocationController's destructor. Instead we can simply assert
280         that there should be no no observers. See related bug
281         https://bugs.webkit.org/show_bug.cgi?id=52216 .
282
283         Introduced new method 'numberOfPendingPermissionRequests' on
284         GeolocationClientMock to count the number of outstanding pending
285         permission requests. This provides a reusable implementation for
286         client-based implementations of the LayoutTestController's
287         numberOfPendingGeolocationPermissionRequests method.
288
289         Test: fast/dom/Geolocation/page-reload-cancel-permission-requests.html
290
291         * page/DOMWindow.cpp:
292         (WebCore::DOMWindow::resetGeolocation):
293         * page/DOMWindow.h:
294         * page/Frame.cpp:
295         (WebCore::Frame::pageDestroyed):
296         (WebCore::Frame::transferChildFrameToNewDocument):
297         * page/Geolocation.cpp:
298         (WebCore::Geolocation::~Geolocation):
299         (WebCore::Geolocation::page):
300         (WebCore::Geolocation::reset):
301         (WebCore::Geolocation::disconnectFrame):
302         (WebCore::Geolocation::lastPosition):
303         (WebCore::Geolocation::requestPermission):
304         (WebCore::Geolocation::startUpdating):
305         (WebCore::Geolocation::stopUpdating):
306         * page/Geolocation.h:
307         * page/GeolocationController.cpp:
308         (WebCore::GeolocationController::~GeolocationController):
309         * page/Navigator.cpp:
310         (WebCore::Navigator::resetGeolocation):
311         * page/Navigator.h:
312         * platform/mock/GeolocationClientMock.cpp:
313         (WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
314         * platform/mock/GeolocationClientMock.h:
315
316 2011-03-10  Ojan Vafai  <ojan@chromium.org>
317
318         Reviewed by Darin Adler.
319
320         Able to move nodes across documents
321         https://bugs.webkit.org/show_bug.cgi?id=19524
322
323         Makes cross-document appendChild, insertBefore, Range.insertNode and Range.surroundContents work.
324         This matches Gecko and the new Dom Core spec. There are a number of Range methods where we don't 
325         match Gecko or the spec that will need to be updated in a following patch.
326
327         Test: fast/dom/move-nodes-across-documents.html
328
329         * dom/Element.cpp:
330         (WebCore::Element::removeAttributeNode):
331         * dom/NamedNodeMap.cpp:
332         (WebCore::NamedNodeMap::setNamedItem):
333         * dom/Node.cpp:
334         (WebCore::Node::setDocumentRecursively):
335         (WebCore::checkAcceptChild):
336         (WebCore::Node::checkReplaceChild):
337         * dom/Range.cpp:
338         (WebCore::Range::insertNode):
339         (WebCore::Range::surroundContents):
340
341 2011-03-09  Antti Koivisto  <antti@apple.com>
342
343         Not reviewed.
344
345         Reverting crash catching code, the bug being hunted was fixed by
346         http://trac.webkit.org/changeset/80686
347
348         * loader/cache/CachedResourceLoader.cpp:
349         (WebCore::CachedResourceLoader::CachedResourceLoader):
350         (WebCore::CachedResourceLoader::~CachedResourceLoader):
351         (WebCore::CachedResourceLoader::requestImage):
352         (WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
353         (WebCore::CachedResourceLoader::requestResource):
354         (WebCore::CachedResourceLoader::setAutoLoadImages):
355         (WebCore::CachedResourceLoader::load):
356         (WebCore::CachedResourceLoader::loadDone):
357         (WebCore::CachedResourceLoader::preload):
358         (WebCore::CachedResourceLoader::requestPreload):
359         * loader/cache/CachedResourceLoader.h:
360
361 2011-03-09  Peter Kasting  <pkasting@google.com>
362
363         Unreviewed, build fix.
364
365         * StringsNotToBeLocalized.txt: Add function names I forgot.
366         * platform/win/SystemInfo.cpp: #if out some uncalled functions on WinCE,
367           since they don't compile anyway.  Use ZeroMemory() instead of "= {0}"
368           since Qt is stupid and (sometimes?!) warns about it.
369         (WebCore::windowsVersion):
370         (WebCore::processorArchitecture):
371
372 2011-03-09  Peter Kasting  <pkasting@google.com>
373
374         Reviewed by Ryosuke Niwa.
375
376         Add UA string tags for Windows 64.
377         https://bugs.webkit.org/show_bug.cgi?id=55226
378
379         * StringsNotToBeLocalized.txt:
380         * platform/win/SystemInfo.cpp:
381         (WebCore::osVersionForUAString):
382         (WebCore::isWOW64):
383         (WebCore::processorArchitecture):
384         (WebCore::architectureTokenForUAString):
385         (WebCore::windowsVersionForUAString):
386
387 2011-03-09  Peter Kasting  <pkasting@google.com>
388
389         Unreviewed, attempted build fix.
390
391         * WebCore.pri: Try to update include path for Qt Windows build.
392
393 2011-03-09  Peter Kasting  <pkasting@google.com>
394
395         Unreviewed, build fix.
396
397         * platform/win/SystemInfo.cpp:
398         (WebCore::windowsVersionForUAString): Fix const conversion warning on Qt.
399
400 2011-03-09  Peter Kasting  <pkasting@google.com>
401
402         Reviewed by Mihai Parparita.
403
404         Unify Windows version checks.
405         https://bugs.webkit.org/show_bug.cgi?id=55979
406
407         * GNUmakefile.am: Fix spaces -> tabs.
408         * StringsNotToBeLocalized.txt:
409         * WebCore.pro: Add SystemInfo.* to Qt build.
410         * platform/chromium/ScrollbarThemeChromiumWin.cpp:
411         (WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit):
412         (WebCore::ScrollbarThemeChromiumWin::getThemeState):
413         (WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
414         * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
415         (WebCore::fillBMPGlyphs):
416         * platform/win/CursorWin.cpp:
417         (WebCore::createSharedCursor):
418         * platform/win/ScrollbarThemeWin.cpp:
419         (WebCore::ScrollbarThemeWin::ScrollbarThemeWin):
420         * platform/win/SystemInfo.cpp: Add full-fledged version check and UA string helper function.
421         (WebCore::windowsVersion):
422         (WebCore::windowsVersionForUAString):
423         * platform/win/SystemInfo.h: Add full-fledged version check and UA string helper function.
424         * rendering/RenderThemeChromiumWin.cpp:
425         (WebCore::getNonClientMetrics):
426         * rendering/RenderThemeWin.cpp:
427         (WebCore::RenderThemeWin::getThemeData):
428         (WebCore::RenderThemeWin::paintMenuList):
429         (WebCore::RenderThemeWin::paintMenuListButton):
430
431 2011-03-09  Mihai Parparita  <mihaip@chromium.org>
432
433         Reviewed by Tony Gentilcore.
434
435         REGRESSION (r74807): memory corruption after CachedResourceLoader refactoring
436         https://bugs.webkit.org/show_bug.cgi?id=53045
437         
438         Copy the URL out of the CachedResource that is being revalidated, so
439         that we can still use it (in m_validatedURLs) after removing the
440         resource from the memory cache, which may delete it.
441
442         No new tests, since I was not able to trigger this locally (in a layout
443         test or otherwise).
444
445         * loader/cache/CachedResourceLoader.cpp:
446         (WebCore::CachedResourceLoader::revalidateResource):
447
448 2011-03-09  Chris Fleizach  <cfleizach@apple.com>
449
450         Reviewed by Beth Dakin.
451
452         VO reporting incorrect list count for http://www.macworld.com/news.html
453         https://bugs.webkit.org/show_bug.cgi?id=56064
454
455         <li> tags should not be ignored, because they provide valuable information
456         to screen readers.
457
458         Test: platform/mac/accessibility/list-items-ignored.html
459
460         * accessibility/AccessibilityRenderObject.cpp:
461         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
462
463 2011-03-09  Dan Bernstein  <mitz@apple.com>
464
465         Reviewed by Dave Hyatt.
466
467         <rdar://problem/8733254> Float disappears after incremental layout
468         Fixed the original bug and a copule more issues noticed while doing so.
469
470         Tests: fast/dynamic/dirty-float-in-clean-line.html
471                fast/dynamic/float-at-line-break.html
472                fast/dynamic/float-from-empty-line.html
473
474         * rendering/RenderBlock.h:
475         * rendering/RenderBlockLineLayout.cpp:
476         (WebCore::RenderBlock::layoutInlineChildren): If findNextLineBreak() returned an empty line,
477         update the line break info of the last line with the new line break position. This is tested
478         by float-from-empty-line.html.
479         (WebCore::RenderBlock::checkFloatsInCleanLine): Factored out code from determineStartPosition()
480         into this new function.
481         (WebCore::RenderBlock::determineStartPosition): Call checkFloatsInCleanLine().
482         (WebCore::RenderBlock::determineEndPosition): When iterating over lines, check clean lines with
483         floats, as they may yet become dirty because of the floats. This is tested by
484         dirty-float-in-clean-line.html.
485         (WebCore::RenderBlock::findNextLineBreak): If a float fits on the line, and the current line
486         break is at the float, advance it to after the float. Otherwise, if the line gets dirty and the
487         next one does not, the float will not make it into any line. This is tested by
488         float-at-line-break.html.
489
490 2011-03-09  Ryosuke Niwa  <rniwa@webkit.org>
491
492         Reviewed by Kent Tamura.
493
494         selectionStart reports wrong caret position when the last characters are newlines
495         https://bugs.webkit.org/show_bug.cgi?id=56061
496
497         The bug was caused by SelectionController::setSelection's not calling
498         notifyRendererOfSelectionChange when old selection was equal to new selection.
499
500         Because InsertLineBreakCommand inserts a text node with a single LF before the caret,
501         this condition holds after the command is executed. However, the values of
502         selectionStart and selectionEnd still need to be updated in this case because
503         the offsets counted from the beginning of textarea have been increased by 1.
504
505         * editing/SelectionController.cpp:
506         (WebCore::SelectionController::setSelection): Call notifyRendererOfSelectionChange
507         when m_selection = s.
508         * manual-tests/selection-start-after-inserting-line-break-in-textarea.html: Added.
509
510 2011-03-09  Andy Estes  <aestes@apple.com>
511
512         Reviewed by Adam Barth.
513
514         Bad cast in HTMLTreeBuilder::processStartTag
515         https://bugs.webkit.org/show_bug.cgi?id=55955
516
517         Test: fast/parser/self-closing-foreign-content.html
518
519         When the parser encounters an svg or mathml root element, it places the
520         insertion mode into InForeignContentMode. However, if the root element
521         is self-closing (e.g. <svg />) then the element is never placed on the
522         open elements stack. This leaves the parser in an inconsistent state
523         where it is in InForeignContentMode but no foreign content is in the
524         open element stack.
525
526         * html/parser/HTMLTreeBuilder.cpp:
527         (WebCore::HTMLTreeBuilder::processStartTagForInBody): If a self-closing
528         foreign element is inserted into the tree, do not set the insertion
529         mode to InForeignContentMode.
530
531 2011-03-09  Gavin Barraclough  <barraclough@apple.com>
532
533         Qt build fix.
534
535         * bridge/qt/qt_runtime.cpp:
536         (JSC::Bindings::convertQVariantToValue):
537
538 2011-03-09  Andy Estes  <aestes@apple.com>
539
540         Reviewed by Adam Barth.
541
542         REGRESSION (r80320): Assertion failure when processing mis-nested foreign content.
543         https://bugs.webkit.org/show_bug.cgi?id=55982
544
545         Test: fast/parser/fragment-foreign-content-misnested.html
546         
547         It is a parse error to encounter certain start tags while the parser's
548         insertion mode is InForeignContentMode (e.g. <br>). In these cases, we
549         are to pop open elements off the HTMLElementStack until a foreign
550         content scope marker is encountered. Before the change in r80320 to not
551         insert a fake HTML element during fragment parsing, said fake HTML
552         element counted as a foreign content scope marker.
553         
554         With r80320, no fake HTML element is inserted and the stack is popped
555         until empty in cases where no other element claims to be a foreign
556         content scope marker. Fix this by treating the DocumentFragment as a
557         foreign content scope marker.
558
559         * html/parser/HTMLElementStack.cpp:
560         (WebCore::HTMLNames::isForeignContentScopeMarker): Take a
561         ContainerNode* instead of a Element*.
562         (WebCore::HTMLElementStack::popUntilForeignContentScopeMarker): Pass
563         topNode() to isForeignContentScopeMarker() instead of top().
564
565 2011-03-09  Gavin Barraclough  <barraclough@apple.com>
566
567         Reviewed by Darin Adler.
568
569         Bug 56041 - RexExp constructor should only accept flags "gim"
570         We also should be passing the flags around as a bitfield rather than a string,
571         and should not have redundant, incompatible code for converting the string to a bitfield!
572
573         * bindings/js/SerializedScriptValue.cpp:
574         (WebCore::CloneDeserializer::readTerminal):
575             - Need to parse flags string back to enum.
576
577 2011-03-09  James Robinson  <jamesr@chromium.org>
578
579         Reviewed by Kenneth Russell.
580
581         [chromium]: Regression - Explicitly copy compositing properties from LayerChromium to CCLayerImpl
582         https://bugs.webkit.org/show_bug.cgi?id=56021
583
584         Initializes the m_doubleSided flag of LayerChromiums to the default
585         value of true so the back sides of layers without
586         backface-visibility:hidden are rendered.
587
588         Test: compositing/backface-visibility.html
589
590         * platform/graphics/chromium/LayerChromium.cpp:
591         (WebCore::LayerChromium::LayerChromium):
592
593 2011-03-09  David Hyatt  <hyatt@apple.com>
594
595         Reviewed by Dan Bernstein.
596
597         <rdar://problem/9110316> REGRESSION: 'ex' unit broken for vertical text
598
599         Fall back to the verticalRightOrientation data when obtaining the x-height for vertically oriented
600         text. That way we use the same metrics as for horizontal.
601
602         This fixes regressions in fast/lists and fast/overflow vertical text tests.
603
604         * platform/graphics/mac/SimpleFontDataMac.mm:
605         (WebCore::SimpleFontData::platformInit):
606         (WebCore::SimpleFontData::platformBoundsForGlyph):
607
608 2011-03-09  Ryosuke Niwa  <rniwa@webkit.org>
609
610         Reviewed by Tony Chang.
611
612         REGRESSION: crash in nextLinePosition when extending selection forward by line in an empty document
613         https://bugs.webkit.org/show_bug.cgi?id=56004
614
615         The crash was caused by the false assumption that rootEditableElement() or documentElement()
616         always return non-null pointer. Fixed the bug by adding an early exit.
617
618         Test: editing/selection/extend-by-line-in-empty-document.html
619
620         * editing/visible_units.cpp:
621         (WebCore::previousLinePosition):
622         (WebCore::nextLinePosition):
623
624 2011-03-09  Pavel Podivilov  <podivilov@chromium.org>
625
626         Reviewed by Pavel Feldman.
627
628         Web Inspector: it should be possible to copy stack trace from call stack sidebar pane.
629         https://bugs.webkit.org/show_bug.cgi?id=56024
630
631         * English.lproj/localizedStrings.js:
632         * inspector/front-end/CallStackSidebarPane.js:
633         (WebInspector.CallStackSidebarPane):
634         (WebInspector.CallStackSidebarPane.prototype.update):
635         (WebInspector.CallStackSidebarPane.prototype._contextMenu):
636
637 2011-03-09  David Hyatt  <hyatt@apple.com>
638
639         Reviewed by Darin Adler.
640
641         Patch FontPlatformDataLinux to properly initialize and copy orientation/text-orientation in all
642         places.  Make sure text-orientation is specified in the lookups/creation in FontCustomPlatformData
643         and FontCache.
644
645         * platform/graphics/chromium/FontPlatformDataLinux.cpp:
646         (WebCore::FontPlatformData::FontPlatformData):
647         * platform/graphics/chromium/FontPlatformDataLinux.h:
648         (WebCore::FontPlatformData::FontPlatformData):
649
650 2011-03-09  Steve Block  <steveblock@google.com>
651
652         Reviewed by Jeremy Orlow.
653
654         JavaNPObject should not use JNI directly
655         https://bugs.webkit.org/show_bug.cgi?id=56009
656
657         We move the JNI code to access a Java object's fields into
658         a new JavaInstance::getField() method.
659
660         No new tests, refactoring only.
661
662         * bridge/jni/v8/JavaInstanceV8.cpp:
663         (JavaInstance::getField):
664         * bridge/jni/v8/JavaInstanceV8.h:
665         * bridge/jni/v8/JavaNPObjectV8.cpp:
666         (JSC::Bindings::JavaNPObjectGetProperty):
667
668 2011-03-09  Steve Block  <steveblock@google.com>
669
670         Reviewed by Jeremy Orlow.
671
672         NPAPI - jvalue conversion should not be in JavaInstance
673         https://bugs.webkit.org/show_bug.cgi?id=55967
674
675         No new tests, refactoring only.
676
677         * bridge/jni/v8/JavaInstanceV8.cpp:
678         (JavaInstance::invokeMethod):
679         * bridge/jni/v8/JavaInstanceV8.h:
680         * bridge/jni/v8/JavaNPObjectV8.cpp:
681         (JSC::Bindings::JavaNPObjectInvoke):
682
683 2011-03-09  Jessie Berlin  <jberlin@apple.com>
684
685         Reviewed by Adam Roben.
686
687         Use the Cookie Storage from the Private Browsing Storage Session directly
688         https://bugs.webkit.org/show_bug.cgi?id=55986
689
690         * WebCore.exp.in:
691         * platform/mac/WebCoreSystemInterface.h:
692         * platform/mac/WebCoreSystemInterface.mm:
693
694         * platform/network/mac/CookieStorageMac.mm:
695         (WebCore::setCookieStoragePrivateBrowsingEnabled):
696         Just copy the cookie storage from the private browsing storage session.
697         * platform/network/cf/CookieStorageCFNet.cpp:
698         (WebCore::setCookieStoragePrivateBrowsingEnabled):
699         Ditto.
700
701 2011-03-09  Andrey Kosyakov  <caseq@chromium.org>
702
703         Unreviewed. Fixed a crash in InspectorInstrumentation::didReceiveResponse() when loader is null (broken in r80639)
704
705         * inspector/InspectorInstrumentation.cpp:
706         (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
707
708 2011-03-09  Yury Semikhatsky  <yurys@chromium.org>
709
710         Reviewed by Pavel Feldman.
711
712         Web Inspector: pass explicit agent references to InspectorBackendDispatcher
713         https://bugs.webkit.org/show_bug.cgi?id=55820
714
715         * inspector/CodeGeneratorInspector.pm:
716         * inspector/InspectorController.cpp:
717         (WebCore::InspectorController::InspectorController):
718         (WebCore::InspectorController::connectFrontend):
719         (WebCore::InspectorController::disconnectFrontend):
720         (WebCore::InspectorController::dispatchMessageFromFrontend):
721
722 2011-03-09  Andrey Kosyakov  <caseq@chromium.org>
723
724         Reviewed by Pavel Feldman.
725
726         Web Inspector: resource errors are not reported before front-end is opened
727         https://bugs.webkit.org/show_bug.cgi?id=55939
728
729         * inspector/InspectorInstrumentation.cpp:
730         (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
731         * inspector/InspectorInstrumentation.h:
732         (WebCore::InspectorInstrumentation::didReceiveResourceResponse):
733         (WebCore::InspectorInstrumentation::didFailLoading):
734
735 2011-03-08  Hans Wennborg  <hans@chromium.org>
736
737         Reviewed by Jeremy Orlow.
738
739         IndexedDB: Add BackingStoreType parameter to IDBFactoryBackendInterface::open
740         https://bugs.webkit.org/show_bug.cgi?id=55948
741
742         Add a parameter that allows for selection of alternative backing store
743         implementations.
744
745         No new tests: no new functionality.
746
747         * storage/IDBFactory.cpp:
748         (WebCore::IDBFactory::open):
749         * storage/IDBFactoryBackendImpl.cpp:
750         (WebCore::IDBFactoryBackendImpl::open):
751         * storage/IDBFactoryBackendImpl.h:
752         * storage/IDBFactoryBackendInterface.h:
753
754 2011-03-08  Steve Block  <steveblock@google.com>
755
756         Reviewed by Jeremy Orlow.
757
758         Factor out JNI method call to be used by both JSC and V8
759         https://bugs.webkit.org/show_bug.cgi?id=55966
760
761         No new tests, refactoring only.
762
763         * bridge/jni/JNIUtility.cpp:
764         (JSC::Bindings::callJNIMethod):
765         * bridge/jni/JNIUtility.h:
766         * bridge/jni/jsc/JavaInstanceJSC.cpp:
767         (JavaInstance::invokeMethod):
768         * bridge/jni/v8/JavaInstanceV8.cpp:
769         (JavaInstance::invokeMethod):
770
771 2011-03-09  Andrey Adaikin  <aandrey@google.com>
772
773         Reviewed by Pavel Feldman.
774
775         Web Inspector: [Text editor] Regression in handling DOMNodeInserted/DOMNodeRemoved events
776         https://bugs.webkit.org/show_bug.cgi?id=55818
777
778         * inspector/front-end/TextViewer.js:
779         (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
780
781 2011-03-09  Ilya Tikhonovsky  <loislo@chromium.org>
782
783         Reviewed by Yury Semikhatsky.
784
785         Web Inspector: Web Inspector: we don't need to transfer objectId and hasChildren for primitive values.
786         https://bugs.webkit.org/show_bug.cgi?id=55998
787
788         * inspector/InjectedScriptSource.js:
789
790 2011-03-09  Pavel Feldman  <pfeldman@chromium.org>
791
792         Reviewed by Yury Semikhatsky.
793
794         Web Inspector: watch expressions should show string values in quotes.
795         https://bugs.webkit.org/show_bug.cgi?id=55846
796
797         * inspector/InjectedScriptSource.js:
798         * inspector/front-end/ObjectPropertiesSection.js:
799         (WebInspector.ObjectPropertyTreeElement.prototype.update):
800         * inspector/front-end/RemoteObject.js:
801         (WebInspector.LocalJSONObject.prototype.get description):
802         * inspector/front-end/WatchExpressionsSidebarPane.js:
803         (WebInspector.WatchExpressionsSection.prototype.update):
804         * inspector/front-end/inspector.css:
805         (.console-formatted-string, .console-formatted-regexp):
806
807 2011-03-09  Pavel Feldman  <pfeldman@chromium.org>
808
809         Reviewed by Yury Semikhatsky.
810
811         Web Inspector: "length" getter is invoked upon console object formatting.
812         https://bugs.webkit.org/show_bug.cgi?id=55220
813
814         * inspector/InjectedScriptSource.js:
815
816 2011-03-08  Ilya Tikhonovsky  <loislo@chromium.org>
817
818         Reviewed by Pavel Feldman.
819
820         Web Inspector: remove groupName from objectId.
821         https://bugs.webkit.org/show_bug.cgi?id=55825
822
823         * inspector/InjectedScriptSource.js:
824
825 2011-03-08  Xiaomei Ji  <xji@chromium.org>
826
827         Reviewed by David Hyatt.
828
829         Fix Regression: Content not drawn when scrolling horizontally in an RTL page.
830         https://bugs.webkit.org/show_bug.cgi?id=55077.
831
832         Inside ScrollView::calculateOverhangAreasForPainting(), when scroll position
833         is negative, should include the position value into overhang rectangle's 
834         starting position. 
835
836         Tests: fast/dom/scroll-reveal-left-overflow.html
837                fast/dom/scroll-reveal-top-overflow.html
838
839         * platform/ScrollView.cpp:
840         (WebCore::ScrollView::calculateOverhangAreasForPainting):
841
842 2011-03-08  Daniel Bates  <dbates@rim.com>
843
844         Reviewed by Darin Adler.
845
846         Add templatized CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}()
847         https://bugs.webkit.org/show_bug.cgi?id=55351
848
849         By using some template magic CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}()
850         can be called on an array A without the caller explicitly specifying the size of A.
851
852         No functionality was changed. So no new tests.
853
854         * css/CSSMutableStyleDeclaration.cpp:
855         (WebCore::CSSMutableStyleDeclaration::getPropertyValue): Modified to call templatized variants of
856         CSSMutableStyleDeclaration::get{ShorthandValue, CommonValue, LayeredShorthandValue}().
857         (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Renamed second argument from "number" to "size"
858         to better reflect its purpose - to be the size of the passed array.
859         (WebCore::CSSMutableStyleDeclaration::getShorthandValue): Ditto.
860         (WebCore::CSSMutableStyleDeclaration::getCommonValue): Ditto.
861         (WebCore::CSSMutableStyleDeclaration::cssText): Modified to call templatized variant of CSSMutableStyleDeclaration::getShorthandValue().
862         * css/CSSMutableStyleDeclaration.h:
863         (WebCore::CSSMutableStyleDeclaration::getShorthandValue): Added templatized function that can determine
864         the size of a passed array. Changed type of second argument to size_t since it represents the size of
865         an array.
866         (WebCore::CSSMutableStyleDeclaration::getCommonValue): Ditto.
867         (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue): Ditto.
868
869 2011-03-08  Enrica Casucci  <enrica@apple.com>
870
871         Reviewed by Darin Adler.
872         
873         REGRESSION: Copied content loses formatting on paste to external apps.
874         https://bugs.webkit.org/show_bug.cgi?id=47615
875         <rdar://problem/9001214>
876         
877         This is a resubmission of a patch that was landed a while ago then rolled
878         back because of a build failure on SnowLeopard and Leopard on the 32-bit builds.
879
880         This patch adds a way for WebKit2 to create NSAttributedStrings from
881         a DOM range without using the AppKit api initWithDOMRange that internally
882         needs to access the WebView. The NSAttributedString is needed to create
883         RTF formats in the pasteboard.
884         This is to be considered a first step, since in the future we want to have
885         an implementation based on the TextIterator.
886         * WebCore.xcodeproj/project.pbxproj:
887         * platform/mac/HTMLConverter.h: Added.
888         * platform/mac/HTMLConverter.mm: Added.
889         * platform/mac/PasteboardMac.mm:
890         (WebCore::Pasteboard::writeSelection):
891
892 2011-03-08  James Robinson  <jamesr@chromium.org>
893
894         Reviewed by Kenneth Russell.
895
896         [chromium] Explicitly copy compositing properties from LayerChromium to CCLayerImpl
897         https://bugs.webkit.org/show_bug.cgi?id=55900
898
899         This adds an explicit step to synchronize properties from
900         LayerChromiums to their corresponding CCLayerImpls.
901
902         * platform/graphics/chromium/LayerChromium.cpp:
903         (WebCore::LayerChromium::setBounds):
904         * platform/graphics/chromium/LayerChromium.h:
905         (WebCore::LayerChromium::bounds):
906         (WebCore::LayerChromium::doubleSided):
907         (WebCore::LayerChromium::setDoubleSided):
908         * platform/graphics/chromium/LayerRendererChromium.cpp:
909         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
910         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
911         (WebCore::CCLayerImpl::CCLayerImpl):
912         (WebCore::CCLayerImpl::updateFromLayer):
913         (WebCore::CCLayerImpl::descendantsDrawsContent):
914         * platform/graphics/chromium/cc/CCLayerImpl.h:
915         (WebCore::CCLayerImpl::anchorPoint):
916         (WebCore::CCLayerImpl::anchorPointZ):
917         (WebCore::CCLayerImpl::masksToBounds):
918         (WebCore::CCLayerImpl::opacity):
919         (WebCore::CCLayerImpl::position):
920         (WebCore::CCLayerImpl::preserves3D):
921         (WebCore::CCLayerImpl::sublayerTransform):
922         (WebCore::CCLayerImpl::transform):
923
924 2011-03-08  James Robinson  <jamesr@chromium.org>
925
926         Chromium compile fix.
927
928         * platform/graphics/chromium/SimpleFontDataLinux.cpp:
929         (WebCore::SimpleFontData::platformInit):
930
931 2011-03-08  Peter Kasting  <pkasting@google.com>
932
933         Reviewed by James Robinson.
934
935         Unify Windows version checks, part 1.
936         https://bugs.webkit.org/show_bug.cgi?id=55979
937
938         Make everyone (I hope) pull in SystemInfo.cpp.  Eliminate the
939         now-unnecessary WindowsVersion.cpp from Chromium.
940
941         * GNUmakefile.am:
942         * WebCore.gyp/WebCore.gyp:
943         * WebCore.gypi:
944         * platform/chromium/ScrollbarThemeChromiumWin.cpp:
945         (WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit):
946         (WebCore::ScrollbarThemeChromiumWin::getThemeState):
947         (WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
948         * platform/chromium/WindowsVersion.cpp: Removed.
949         * platform/chromium/WindowsVersion.h: Removed.
950         * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
951         (WebCore::fillBMPGlyphs):
952         * rendering/RenderThemeChromiumWin.cpp:
953         (WebCore::getNonClientMetrics):
954
955 2011-03-08  Ryosuke Niwa  <rniwa@webkit.org>
956
957         Chromium Linux build fix attempt after r80582.
958
959         * platform/graphics/chromium/FontLinux.cpp:
960         (WebCore::Font::drawGlyphs):
961         * platform/graphics/chromium/SimpleFontDataLinux.cpp:
962         (WebCore::SimpleFontData::platformInit):
963         * platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
964         (WebCore::GlyphPage::fill):
965
966 2011-03-08  Ryosuke Niwa  <rniwa@webkit.org>
967
968         Mac build fix attempt for r80582.
969
970         * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
971         (WebCore::disableLigatures):
972
973 2011-03-08  Ryosuke Niwa  <rniwa@webkit.org>
974
975         Reviewed by Kent Tamura.
976
977         Remove calls to deprecatedEditingOffset in SelectionController and VisibleSelection
978         https://bugs.webkit.org/show_bug.cgi?id=54937
979
980         * editing/SelectionController.cpp:
981         (WebCore::SelectionController::setSelection): Calls anchorNode() instead of deprecatedNode() to obtain
982         the document. Also restrained the lifetime of document variable.
983         (WebCore::removingNodeRemovesPosition): Compare the node with anchorNode() instead of deprecatedNode()
984         to determine whether or not position becomes null after removing a node.
985         (WebCore::SelectionController::directionOfEnclosingBlock): The enclosing block is always a container
986         so call containerNode() instead of deprecatedNode().
987         (WebCore::SelectionController::debugRenderer): Call containerNode() and computeOffsetInContainer()
988         instead of deprecatedNode() and deprecatedEditingOffset() respectively.
989         (WebCore::SelectionController::isInPasswordField): Look for the shadow root from containerNode()
990         instead of deprecatedNode to determine whether or not selection inside a password field. Also assert
991         that the specified position is not before or after the shadow root as it violates our assumption.
992         * editing/VisibleSelection.cpp:
993         (WebCore::makeSearchRange): Call containerNode() and offsetInContainerNode() instead of deprecatedNode()
994         and deprecatedEditingOffset() respectively because start is always parent anchored and therefore
995         guaranteed to be an offset inside an anchor node.
996         (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries): Call containerNode()
997         instead of deprecatedNode() to look for the lowest editable ancestor because position before or after
998         an editable element isn't editable.
999         * page/DOMSelection.cpp: Call containerNode() and offsetInContainerNode() instead of deprecatedNode()
1000         and deprecatedEditingOffset() respectively in the following functions because they are exposed to
1001         DOM, which doesn't have before/after concept.
1002         (WebCore::DOMSelection::anchorNode):
1003         (WebCore::DOMSelection::anchorOffset):
1004         (WebCore::DOMSelection::focusNode):
1005         (WebCore::DOMSelection::focusOffset):
1006         (WebCore::DOMSelection::baseNode):
1007         (WebCore::DOMSelection::baseOffset):
1008         (WebCore::DOMSelection::extentNode):
1009         (WebCore::DOMSelection::extentOffset):
1010
1011 2011-03-08  Brent Fulgham  <bfulgham@webkit.org>
1012
1013         Reviewed by Adam Roben.
1014
1015         Correct uninitialized variable in PolicyCallback found while
1016         running WebKit in BoundsChecker.
1017         https://bugs.webkit.org/show_bug.cgi?id=45199.
1018
1019         * loader/PolicyCallback.cpp:
1020         (WebCore::PolicyCallback::PolicyCallback): Initialize
1021         m_argument.
1022
1023 2011-03-08  Brent Fulgham  <bfulgham@webkit.org>
1024
1025         More build bustage fix.
1026
1027         * platform/graphics/win/cairo/FontPlatformData.h:
1028         (WebCore::FontPlatformData::setOrientation): Duplicate accessor
1029         in WinCairo-local header.  This is such a mess!
1030
1031 2011-03-08  David Hyatt  <hyatt@apple.com>
1032
1033         Fix build bustage.  Hide orientation setting behind a setter and stub it out in all
1034         FontPlatformData classes.  (This class really needs to move to a common header with ifdefs.)
1035
1036         * platform/graphics/SimpleFontData.cpp:
1037         (WebCore::SimpleFontData::verticalRightOrientationFontData):
1038         * platform/graphics/cg/FontPlatformData.h:
1039         (WebCore::FontPlatformData::setOrientation):
1040         * platform/graphics/chromium/FontPlatformDataChromiumWin.h:
1041         (WebCore::FontPlatformData::setOrientation):
1042         * platform/graphics/chromium/FontPlatformDataLinux.h:
1043         (WebCore::FontPlatformData::setOrientation):
1044         * platform/graphics/cocoa/FontPlatformData.h:
1045         (WebCore::FontPlatformData::setOrientation):
1046         * platform/graphics/freetype/FontPlatformData.h:
1047         (WebCore::FontPlatformData::setOrientation):
1048         * platform/graphics/qt/FontPlatformData.h:
1049         (WebCore::FontPlatformData::setOrientation):
1050         * platform/graphics/wince/FontPlatformData.h:
1051         (WebCore::FontPlatformData::setOrientation):
1052         * platform/graphics/wx/FontPlatformData.h:
1053         (WebCore::FontPlatformData::setOrientation):
1054
1055 2011-03-08  Joe Wild  <joseph.wild@nokia.com>
1056
1057         Reviewed by Csaba Osztrogon√°c.
1058
1059         [Qt] Missing SVG variables
1060         https://bugs.webkit.org/show_bug.cgi?id=32941
1061
1062         Basically, this patch just modifies features.pri to the Qt build to
1063         pass on the ENABLE_SVG_* flags to the IDL binding generator.
1064
1065         Also I had remove global-construtors.html from the skip list and
1066         updated the associated expected results files.
1067
1068         * features.pri:
1069         * page/DOMWindow.idl:
1070
1071 2011-03-08  Alok priyadarshi  <alokp@chromium.org>
1072
1073         Reviewed by Dimitri Glazkov.
1074
1075         Plugins needs a way to trigger style recalc
1076         https://bugs.webkit.org/show_bug.cgi?id=55242
1077
1078         No test needed. A simple get function is added.
1079
1080         * platform/graphics/chromium/PluginLayerChromium.h:
1081         (WebCore::PluginLayerChromium::getTextureId):
1082
1083 2011-03-08  David Hyatt  <hyatt@apple.com>
1084
1085         Reviewed by Dan Bernstein.
1086
1087         https://bugs.webkit.org/show_bug.cgi?id=48540, support the text-orientation CSS property.
1088         
1089         This patch adds support for two values of the text-orientation property (the ones that actually matter): vertical-right and upright.
1090         The TextOrientation is part of the FontDescription and used to look up fonts (similar to FontOrientation).
1091         
1092         Orientation of non-CJK characters is done using fallback font data of the appropriate orientation type, e.g., verticalRightOrientation and
1093         uprightOrientation fallback font data.  Vertical right is just implemented as a normal horizontal font.  Upright is implemented as a
1094         vertically oriented font that rotates all glyphs.
1095         
1096         The main complication implementing text-orientation is that fonts have "baked-in" vertical glyphs for letters that are hardcoded to
1097         a vertical right facing.  This means that you can use those special vertical glyphs for vertical-right orientation without having to 
1098         fall back, but then for upright orientation you have to ignore them and still fall back.  As you can see from the test case, this doesn't
1099         work very well, but hopefully it won't be all that common.  Limitations of CoreText prevent this case from rendering properly in either the
1100         simple or complex code paths, although the simple code path at least gets close.
1101
1102         Added fast/blockflow/text-orientation-basic.html
1103
1104         * WebCore.exp.in:
1105         * WebCore.xcodeproj/project.pbxproj:
1106         * css/CSSComputedStyleDeclaration.cpp:
1107         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1108         * css/CSSFontFaceSource.cpp:
1109         (WebCore::CSSFontFaceSource::getFontData):
1110         * css/CSSParser.cpp:
1111         (WebCore::CSSParser::parseValue):
1112         * css/CSSPrimitiveValueMappings.h:
1113         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1114         (WebCore::CSSPrimitiveValue::operator TextOrientation):
1115         * css/CSSPropertyNames.in:
1116         * css/CSSStyleSelector.cpp:
1117         (WebCore::CSSStyleSelector::applyDeclarations):
1118         (WebCore::CSSStyleSelector::applyProperty):
1119         * css/CSSValueKeywords.in:
1120         * loader/cache/CachedFont.cpp:
1121         (WebCore::CachedFont::platformDataFromCustomData):
1122         * loader/cache/CachedFont.h:
1123         * platform/graphics/FontCache.cpp:
1124         (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
1125         (WebCore::FontPlatformDataCacheKey::operator==):
1126         (WebCore::computeHash):
1127         (WebCore::FontCache::getCachedFontPlatformData):
1128         * platform/graphics/FontDescription.h:
1129         (WebCore::FontDescription::FontDescription):
1130         (WebCore::FontDescription::textOrientation):
1131         (WebCore::FontDescription::setTextOrientation):
1132         (WebCore::FontDescription::operator==):
1133         * platform/graphics/FontFastPath.cpp:
1134         (WebCore::Font::glyphDataForCharacter):
1135         (WebCore::offsetToMiddleOfGlyph):
1136         * platform/graphics/SimpleFontData.cpp:
1137         (WebCore::SimpleFontData::SimpleFontData):
1138         (WebCore::SimpleFontData::verticalRightOrientationFontData):
1139         (WebCore::SimpleFontData::uprightOrientationFontData):
1140         (WebCore::SimpleFontData::brokenIdeographFontData):
1141         (WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):
1142         * platform/graphics/SimpleFontData.h:
1143         (WebCore::SimpleFontData::hasVerticalGlyphs):
1144         (WebCore::SimpleFontData::isTextOrientationFallback):
1145         * platform/graphics/cairo/FontCustomPlatformData.h:
1146         * platform/graphics/cocoa/FontPlatformData.h:
1147         (WebCore::FontPlatformData::FontPlatformData):
1148         (WebCore::FontPlatformData::textOrientation):
1149         (WebCore::FontPlatformData::hash):
1150         (WebCore::FontPlatformData::operator==):
1151         * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
1152         (WebCore::FontPlatformData::FontPlatformData):
1153         (WebCore::FontPlatformData::operator=):
1154         * platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
1155         (WebCore::FontCustomPlatformData::fontPlatformData):
1156         * platform/graphics/haiku/FontCustomPlatformData.cpp:
1157         (WebCore::FontCustomPlatformData::fontPlatformData):
1158         * platform/graphics/haiku/FontCustomPlatformData.h:
1159         * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
1160         (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
1161         * platform/graphics/mac/FontCacheMac.mm:
1162         (WebCore::FontCache::createFontPlatformData):
1163         * platform/graphics/mac/FontCustomPlatformData.cpp:
1164         (WebCore::FontCustomPlatformData::fontPlatformData):
1165         * platform/graphics/mac/FontCustomPlatformData.h:
1166         * platform/graphics/mac/FontMac.mm:
1167         (WebCore::showGlyphsWithAdvances):
1168         (WebCore::Font::drawGlyphs):
1169         * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
1170         (WebCore::shouldUseCoreText):
1171         (WebCore::GlyphPage::fill):
1172         * platform/graphics/mac/SimpleFontDataCoreText.cpp:
1173         (WebCore::SimpleFontData::getCFStringAttributes):
1174         * platform/graphics/mac/SimpleFontDataMac.mm:
1175         (WebCore::SimpleFontData::platformInit):
1176         (WebCore::SimpleFontData::platformBoundsForGlyph):
1177         (WebCore::SimpleFontData::platformWidthForGlyph):
1178         * platform/graphics/pango/FontCustomPlatformDataPango.cpp:
1179         (WebCore::FontCustomPlatformData::fontPlatformData):
1180         * platform/graphics/qt/FontCustomPlatformData.h:
1181         * platform/graphics/qt/FontCustomPlatformDataQt.cpp:
1182         (WebCore::FontCustomPlatformData::fontPlatformData):
1183         * platform/graphics/skia/FontCustomPlatformData.cpp:
1184         (WebCore::FontCustomPlatformData::fontPlatformData):
1185         * platform/graphics/skia/FontCustomPlatformData.h:
1186         * platform/graphics/win/FontCustomPlatformData.cpp:
1187         (WebCore::FontCustomPlatformData::fontPlatformData):
1188         * platform/graphics/win/FontCustomPlatformData.h:
1189         * platform/graphics/win/FontCustomPlatformDataCairo.cpp:
1190         (WebCore::FontCustomPlatformData::fontPlatformData):
1191         * platform/graphics/win/FontCustomPlatformDataCairo.h:
1192         * platform/graphics/wince/FontCustomPlatformData.cpp:
1193         (WebCore::FontCustomPlatformData::fontPlatformData):
1194         * platform/graphics/wince/FontCustomPlatformData.h:
1195         * platform/text/TextOrientation.h: Added.
1196         * rendering/InlineFlowBox.cpp:
1197         (WebCore::InlineFlowBox::requiresIdeographicBaseline):
1198         * rendering/style/RenderStyle.h:
1199         (WebCore::InheritedFlags::initialTextOrientation):
1200
1201 2011-03-08  Ryosuke Niwa  <rniwa@webkit.org>
1202
1203         Reviewed by Darin Adler.
1204
1205         addInlineStyleIfNeeded should take EditingStyle
1206         https://bugs.webkit.org/show_bug.cgi?id=55950
1207
1208         Deployed EditingStyle in addInlineStyleIfNeeded, StyleChange::StyleChange, and StyleChange::init.
1209         Also extracted EditingStyle::styleIsPresentInComputedStyleOfNode from removeStyleFromRunBeforeApplyingStyle.
1210
1211         * editing/ApplyStyleCommand.cpp:
1212         (WebCore::StyleChange::StyleChange): Takes EditingStyle instead of CSSStyleDeclaration.
1213         (WebCore::StyleChange::init): Ditto.
1214         (WebCore::ApplyStyleCommand::applyBlockStyle): Instantiates StyleChange.
1215         (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Calls addInlineStyleIfNeeded.
1216         (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Calls styleIsPresentInComputedStyleOfNode.
1217         (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Calls EditingStyle::mergeInlineStyleOfElement
1218         instead of manually merging styles.
1219         (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Calls addInlineStyleIfNeeded.
1220         (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Takes EditingStyle instead of CSSMutableStyleDeclaration.
1221         * editing/ApplyStyleCommand.h:
1222         * editing/CompositeEditCommand.h:
1223         * editing/EditingStyle.cpp:
1224         (WebCore::EditingStyle::styleIsPresentInComputedStyleOfNode): Extracted from removeStyleFromRunBeforeApplyingStyle.
1225         * editing/EditingStyle.h:
1226
1227 2011-03-08  Nico Weber  <thakis@chromium.org>
1228
1229         Reviewed by James Robinson.
1230
1231         Crash on big blur radius with canvas
1232         https://bugs.webkit.org/show_bug.cgi?id=55951
1233
1234         Move the clamping code out of an if branch, so that it happens in the
1235         canvas case as well.
1236
1237         Test: fast/canvas/shadow-huge-blur.html
1238
1239         * platform/graphics/cg/GraphicsContextCG.cpp:
1240         (WebCore::GraphicsContext::setPlatformShadow):
1241
1242 2011-03-08  Chris Fleizach  <cfleizach@apple.com>
1243
1244         Reviewed by Sam Weinig.
1245
1246         WK2: Cannot set focus on an element when focus is outside of WKView
1247         https://bugs.webkit.org/show_bug.cgi?id=55281
1248     
1249         In WK2, focus cannot be set from the WebProcess side because there's no platformWidget().
1250         Instead, the focus/unfocus messages need to be sent to the UIProcess side.
1251
1252         * platform/mac/WidgetMac.mm:
1253         (WebCore::Widget::setFocus):
1254
1255 2011-03-08  Sam Weinig  <sam@webkit.org>
1256
1257         Reviewed by Anders Carlsson.
1258
1259         Overflow: scroll areas should not paint white in scroll corner if the 
1260         scrollbars are overlay.
1261         <rdar://problem/9082871>
1262
1263         * rendering/RenderLayer.cpp:
1264         (WebCore::RenderLayer::paintScrollCorner):
1265         Don't paint the scroll corner white if we have overlay scrollbars.
1266
1267 2011-03-08  Chris Marrin  <cmarrin@apple.com>
1268
1269         Reviewed by Darin Adler.
1270
1271         The first time animations are committed they have a bad start time
1272         https://bugs.webkit.org/show_bug.cgi?id=55947
1273
1274         Do a check for a returned lastCommitTime of <=0 and replace it
1275         with the mediaTime.
1276
1277
1278         * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
1279         (WebCore::CACFLayerTreeHost::notifyAnimationsStarted):
1280
1281 2011-03-08  James Kozianski  <koz@chromium.org>
1282
1283         Reviewed by David Levin.
1284
1285         Expose isValidProtocol() in KURL.h.
1286         https://bugs.webkit.org/show_bug.cgi?id=54594
1287
1288         This is needed to validate protocols used in calls to
1289         navigator.registerProtocolHandler().
1290
1291         * platform/KURL.cpp:
1292         * platform/KURL.h:
1293         * platform/KURLGoogle.cpp:
1294         (WebCore::isValidProtocol):
1295
1296 2011-03-08  Adam Roben  <aroben@apple.com>
1297
1298         Set svn:mime-type to text/css for all Inspector CSS files
1299
1300         This will cause them to be served with the correct MIME type from svn.webkit.org's web
1301         interface.
1302
1303         Rubber-stamped by Tim Hatcher.
1304
1305         * inspector/front-end/audits.css: Added property svn:mime-type.
1306         * inspector/front-end/goToLineDialog.css: Added property svn:mime-type.
1307         * inspector/front-end/heapProfiler.css: Added property svn:mime-type.
1308         * inspector/front-end/helpScreen.css: Added property svn:mime-type.
1309         * inspector/front-end/inspector.css: Added property svn:mime-type.
1310         * inspector/front-end/inspectorSyntaxHighlight.css: Added property svn:mime-type.
1311         * inspector/front-end/networkPanel.css: Added property svn:mime-type.
1312         * inspector/front-end/popover.css: Added property svn:mime-type.
1313         * inspector/front-end/textViewer.css: Added property svn:mime-type.
1314
1315 2011-03-08  Andrei Popescu  <andreip@google.com>
1316
1317         Reviewed by Steve Block.
1318
1319         IDBCallbacks::onsuccess(IDBIndex*) is unused and should be removed.
1320         https://bugs.webkit.org/show_bug.cgi?id=55938
1321
1322         The IndexedDatabase specification changed and IDBIndex objects are no
1323         longer created asynchronously. We therefore no longer need this method.
1324
1325         No new tests, just cleanup.
1326
1327         * storage/IDBCallbacks.h:
1328         * storage/IDBRequest.cpp:
1329         * storage/IDBRequest.h:
1330
1331 2011-03-08  Sheriff Bot  <webkit.review.bot@gmail.com>
1332
1333         Unreviewed, rolling out r80551.
1334         http://trac.webkit.org/changeset/80551
1335         https://bugs.webkit.org/show_bug.cgi?id=55933
1336
1337         It broke 285 tests on Qt bot (Requested by Ossy on #webkit).
1338
1339         * WebCore.pro:
1340         * platform/SharedBuffer.cpp:
1341         * platform/SharedBuffer.h:
1342         * platform/network/qt/QNetworkReplyHandler.cpp:
1343         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
1344         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
1345         (WebCore::QNetworkReplyHandler::forwardData):
1346         (WebCore::QNetworkReplyHandler::start):
1347         * platform/network/qt/QNetworkReplyHandler.h:
1348         * platform/network/qt/ResourceHandleQt.cpp:
1349         (WebCore::ResourceHandle::supportsBufferedData):
1350         (WebCore::ResourceHandle::bufferedData):
1351         * platform/qt/QtByteBlock.cpp: Removed.
1352         * platform/qt/QtByteBlock.h: Removed.
1353         * platform/qt/SharedBufferQt.cpp:
1354
1355 2011-03-08  Andreas Kling  <kling@webkit.org>
1356
1357         Reviewed by Benjamin Poulain.
1358
1359         RenderObject: Pass complex type arguments as const-references.
1360
1361         * WebCore.exp.in:
1362         * rendering/RenderObject.h:
1363         * rendering/RenderObject.cpp:
1364         (WebCore::RenderObject::drawBoxSideFromPath):
1365         (WebCore::RenderObject::drawArcForBoxSide):
1366         (WebCore::RenderObject::localToAbsolute):
1367         (WebCore::RenderObject::absoluteToLocal):
1368
1369 2011-03-08  Andreas Kling  <kling@webkit.org>
1370
1371         Reviewed by Antonio Gomes.
1372
1373         Path: Make measurement functions const
1374         https://bugs.webkit.org/show_bug.cgi?id=55914
1375
1376         * platform/graphics/Path.cpp:
1377         (WebCore::Path::length):
1378         (WebCore::Path::pointAtLength):
1379         (WebCore::Path::normalAngleAtLength):
1380         * platform/graphics/Path.h:
1381         * platform/graphics/cairo/PathCairo.cpp:
1382         (WebCore::Path::strokeBoundingRect):
1383         * platform/graphics/cg/PathCG.cpp:
1384         (WebCore::Path::strokeBoundingRect):
1385         * platform/graphics/openvg/PathOpenVG.cpp:
1386         (WebCore::Path::strokeBoundingRect):
1387         (WebCore::Path::length):
1388         (WebCore::Path::pointAtLength):
1389         (WebCore::Path::normalAngleAtLength):
1390         * platform/graphics/qt/PathQt.cpp:
1391         (WebCore::Path::strokeBoundingRect):
1392         (WebCore::Path::length):
1393         (WebCore::Path::pointAtLength):
1394         (WebCore::Path::normalAngleAtLength):
1395         * platform/graphics/skia/PathSkia.cpp:
1396         (WebCore::Path::strokeBoundingRect):
1397         * platform/graphics/wince/PathWinCE.cpp:
1398         (WebCore::Path::strokeBoundingRect):
1399         * platform/graphics/wx/PathWx.cpp:
1400         (WebCore::Path::strokeBoundingRect):
1401
1402 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1403
1404         Reviewed by Martin Robinson.
1405
1406         [GTK] Do not set juntion sides on scrollbar stepper buttons
1407         https://bugs.webkit.org/show_bug.cgi?id=55868
1408
1409         Fixes rendering of steppers for themes using rounded stepper
1410         buttons on scrollbars like Adwaita.
1411
1412         * platform/gtk/ScrollbarThemeGtk3.cpp:
1413         (WebCore::ScrollbarThemeGtk::paintButton):
1414
1415 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1416
1417         Reviewed by Martin Robinson.
1418
1419         [GTK] Use doubles instead of integers for coordinates when rendering arrows
1420         https://bugs.webkit.org/show_bug.cgi?id=55866
1421
1422         To prevent off-by-one rounding errors.
1423
1424         * platform/gtk/RenderThemeGtk3.cpp:
1425         (WebCore::RenderThemeGtk::paintMenuList):
1426         * platform/gtk/ScrollbarThemeGtk3.cpp:
1427         (WebCore::ScrollbarThemeGtk::paintButton):
1428
1429 2011-03-08  Markus Goetz  <guruz@guruz.de>
1430
1431         Reviewed by Kenneth Rohde Christiansen.
1432
1433         [Qt] Use the QNetworkAccessManager zerocopy feature
1434         https://bugs.webkit.org/show_bug.cgi?id=50082
1435
1436         The feature will be introduced in Qt 4.8.
1437         This patch is backwards compatible with Qt 4.7.
1438
1439         * WebCore.pro:
1440         * platform/SharedBuffer.cpp:
1441         * platform/SharedBuffer.h:
1442         * platform/network/qt/QNetworkReplyHandler.cpp:
1443         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
1444         (WebCore::QNetworkReplyHandler::bufferedData):
1445         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
1446         (WebCore::QNetworkReplyHandler::downloadProgress):
1447         (WebCore::QNetworkReplyHandler::forwardData):
1448         (WebCore::QNetworkReplyHandler::start):
1449         * platform/network/qt/QNetworkReplyHandler.h:
1450         * platform/network/qt/ResourceHandleQt.cpp:
1451         (WebCore::ResourceHandle::supportsBufferedData):
1452         (WebCore::ResourceHandle::bufferedData):
1453         * platform/qt/SharedBufferQt.cpp:
1454         (WebCore::SharedBuffer::wrapQtByteBlock):
1455         (WebCore::SharedBuffer::hasPlatformData):
1456         (WebCore::SharedBuffer::platformData):
1457         (WebCore::SharedBuffer::platformDataSize):
1458         (WebCore::SharedBuffer::maybeTransferPlatformData):
1459         (WebCore::SharedBuffer::clearPlatformData):
1460
1461 2011-03-08  Alejandro G. Castro  <alex@igalia.com>
1462
1463         Reviewed by Martin Robinson.
1464
1465         [GTK] Fix compilation warnings after r80429
1466         https://bugs.webkit.org/show_bug.cgi?id=55864
1467
1468         * platform/gtk/WidgetGtk.cpp:
1469
1470 2011-03-08  Philippe Normand  <pnormand@igalia.com>
1471
1472         Unreviewed, GTK build fix after r80536
1473
1474         * GNUmakefile.am:
1475
1476 2011-03-08  Zan Dobersek  <zandobersek@gmail.com>
1477
1478         Reviewed by Martin Robinson.
1479
1480         [Gtk] toDataURL uses incorrect quality value when saving GdkPixbuf to buffer
1481         https://bugs.webkit.org/show_bug.cgi?id=55878
1482
1483         Multiply the quality parameter by 100 to put it in the range [0, 100] as needed
1484         when saving GdkPixbuf to a buffer.
1485
1486         * platform/graphics/gtk/ImageBufferGtk.cpp:
1487         (WebCore::ImageBuffer::toDataURL):
1488
1489 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
1490
1491         Unreviewed.
1492
1493         Final build fix for r80536.
1494
1495         * DerivedSources.make:
1496
1497 2011-03-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1498
1499         Reviewed by Kent Tamura.
1500
1501         [EFL] Adjust functions of WebCore's efl port to WebKit coding style
1502         https://bugs.webkit.org/show_bug.cgi?id=55924
1503
1504         Adjust webkit style to PlatformKeyboardEventEfl, PlatformMouseEventEfl and WidgetEfl files.
1505
1506         * platform/efl/PlatformKeyboardEventEfl.cpp:
1507         (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
1508         * platform/efl/PlatformMouseEventEfl.cpp:
1509         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
1510         * platform/efl/WidgetEfl.cpp:
1511         (WebCore::Widget::frameRectsChanged):
1512         (WebCore::Widget::setEvasObject):
1513
1514 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
1515
1516         Unreviewed.
1517
1518         More build fixes for r80536.
1519
1520         * CMakeLists.txt:
1521         * platform/chromium/ClipboardChromium.cpp:
1522         * platform/chromium/ClipboardChromium.h:
1523
1524 2011-03-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1525
1526         Reviewed by Antonio Gomes.
1527
1528         [EFL] Adjust functions of ScrollbarEfl.cpp to WebKit coding style
1529         https://bugs.webkit.org/show_bug.cgi?id=55917
1530
1531         Adjust webkit style to ScrollbarEfl files.
1532
1533         * platform/efl/ScrollbarEfl.cpp:
1534         (scrollbarEflEdjeMessage):
1535         (ScrollbarEfl::setParent):
1536         (ScrollbarEfl::updateThumbPositionAndProportion):
1537         (ScrollbarEfl::frameRectsChanged):
1538         (ScrollbarEfl::paint):
1539         * platform/efl/ScrollbarEfl.h:
1540
1541 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
1542
1543         Unreviewed.
1544
1545         Build fix for Chromium after r80536.
1546
1547         * platform/chromium/DataTransferItemChromium.cpp:
1548         * platform/chromium/DataTransferItemsChromium.cpp:
1549
1550 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
1551
1552         Unreviewed.
1553
1554         More build fixes for r80536.
1555
1556         * CMakeLists.txt:
1557         * platform/chromium/ClipboardChromium.cpp:
1558         * platform/chromium/ClipboardChromium.h:
1559
1560 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
1561
1562         Reviewed by David Levin.
1563
1564         Add support for DataTransferItems
1565         https://bugs.webkit.org/show_bug.cgi?id=55115
1566
1567         This patch adds stubs for DataTransferItems/DataTransferItem as well as implementing the
1568         basic functionality on the Chromium port. With the exception of DataTransferItem::getAsFile,
1569         all functionality on the DataTransferItems collection has been implemented.
1570         This change does not actually hook up DataTransferItems to reflect the actual contents of a
1571         drop/paste operation or to allow mutation of data in a copy/drag start yet. That will be
1572         enabled via several followup patches.
1573
1574         Test: editing/pasteboard/data-transfer-items.html
1575
1576         * Android.mk:
1577         * CMakeLists.txt:
1578         * CodeGenerators.pri:
1579         * DerivedSources.cpp:
1580         * DerivedSources.make:
1581         * GNUmakefile.am:
1582         * WebCore.gypi:
1583         * WebCore.pro:
1584         * WebCore.vcproj/WebCore.vcproj:
1585         * WebCore.xcodeproj/project.pbxproj:
1586         * bindings/generic/RuntimeEnabledFeatures.cpp:
1587         * bindings/generic/RuntimeEnabledFeatures.h:
1588         (WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled):
1589         (WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled):
1590         * bindings/scripts/CodeGeneratorV8.pm: Do not emit an #include line for DOMString, since it's built-in.
1591         * dom/Clipboard.h:
1592         (WebCore::Clipboard::policy):
1593         * dom/Clipboard.idl:
1594         * dom/DataTransferItem.cpp: Added.
1595         * dom/DataTransferItem.h: Added.
1596         (WebCore::DataTransferItem::~DataTransferItem):
1597         * dom/DataTransferItem.idl: Added.
1598         * dom/DataTransferItems.h: Added.
1599         (WebCore::DataTransferItems::~DataTransferItems):
1600         * dom/DataTransferItems.idl: Added.
1601         * dom/StringCallback.cpp: Added.
1602         (WebCore::StringCallback::scheduleCallback):
1603         * dom/StringCallback.h: Added.
1604         (WebCore::StringCallback::~StringCallback):
1605         * dom/StringCallback.idl: Added.
1606         * platform/chromium/ClipboardChromium.cpp:
1607         (WebCore::ClipboardChromium::items):
1608         * platform/chromium/ClipboardChromium.h:
1609         * platform/chromium/DataTransferItemChromium.cpp: Added.
1610         (WebCore::DataTransferItemChromium::create):
1611         (WebCore::DataTransferItemChromium::DataTransferItemChromium):
1612         (WebCore::DataTransferItemChromium::kind):
1613         (WebCore::DataTransferItemChromium::type):
1614         (WebCore::DataTransferItemChromium::getAsString):
1615         * platform/chromium/DataTransferItemChromium.h: Added.
1616         * platform/chromium/DataTransferItemsChromium.cpp: Added.
1617         (WebCore::DataTransferItemsChromium::create):
1618         (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
1619         (WebCore::DataTransferItemsChromium::length):
1620         (WebCore::DataTransferItemsChromium::item):
1621         (WebCore::DataTransferItemsChromium::deleteItem):
1622         (WebCore::DataTransferItemsChromium::clear):
1623         (WebCore::DataTransferItemsChromium::add):
1624         * platform/chromium/DataTransferItemsChromium.h: Added.
1625
1626 2011-03-07  Ryosuke Niwa  <rniwa@webkit.org>
1627
1628         Reviewed by Darin Adler.
1629
1630         selectionHasStyle and selectionStartHasStyle should use EditingStyle
1631         https://bugs.webkit.org/show_bug.cgi?id=55902
1632
1633         Deployed EditingStyle in selectionHasStyle and selectionStartHasStyle.
1634         This allowed us to move triStateOfStyle from Editor.cpp to EditingStyle.cpp.
1635
1636         Also changed the argument lists of selectionHasStyle and selectionStartHasStyle
1637         to take a property id and a value instead of a CSSMutableStyleDeclaration to cleanup
1638         call sites of these two functions.
1639
1640         * WebCore.exp.in: Updated the signature of selectionHasStyle. No longer exports
1641         selectionStartHasStyle because it's not called anywhere outside of WebCore.
1642         * WebCore.order: Ditto.
1643         * editing/EditingStyle.cpp:
1644         (WebCore::EditingStyle::EditingStyle): Added a new constructor that takes a property id
1645         and a property value.
1646         (WebCore::EditingStyle::triStateOfStyle): Moved from Editor.cpp.
1647         * editing/EditingStyle.h:
1648         (WebCore::EditingStyle::create): Added.
1649         * editing/Editor.cpp:
1650         (WebCore::Editor::selectionStartHasStyle): Takes a property id and a value instead of
1651         a CSSStyleDeclaration.
1652         (WebCore::Editor::selectionHasStyle): Ditto.
1653         * editing/Editor.h: Updated the signatures of selectionStartHasStyle and selectionHasStyle.
1654         * editing/EditorCommand.cpp:
1655         (WebCore::executeToggleStyle): Calls selectionStartHasStyle and selectionHasStyle.
1656         (WebCore::stateStyle): Ditto.
1657         * page/ContextMenuController.cpp:
1658         (WebCore::ContextMenuController::checkOrEnableIfNeeded): Ditto.
1659
1660 2011-03-07  Alexey Proskuryakov  <ap@apple.com>
1661
1662         Reviewed by Darin Adler.
1663
1664         REGRESSION (HTML5 tree builder): Text selection in a large text document is extremely slow
1665         https://bugs.webkit.org/show_bug.cgi?id=55898
1666
1667         <rdar://problem/9095839> REGRESSION: Mail hangs with a certain large mail message when
1668         linkifying e-mail addresses in in -[DOMCharacterData setData:]
1669
1670         Changes render tree of fast/text/large-text-composed-char.html, but not image results.
1671
1672         * dom/CharacterData.cpp: (WebCore::CharacterData::parserAppendData):
1673         Changed parserAppendData() to accept a maximum length, and moved code from Text::createWithLengthLimit().
1674
1675         * dom/CharacterData.h: Moved a constant for maximum length from Text.h.
1676
1677         * dom/Text.cpp: (WebCore::Text::createWithLengthLimit):
1678         * dom/Text.h:
1679         This function was unused in ToT. Moved code around to share with CharacterData.
1680
1681         * html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertTextNode):
1682         Chnaged to split large text nodes while parsing again.
1683
1684 2011-03-07  Alice Boxhall  <aboxhall@chromium.org>
1685
1686         Reviewed by Adam Barth.
1687
1688         Fix platform/image-encoders/JPEGImageEncoder.cpp empty_output_buffer() behaviour
1689         https://bugs.webkit.org/show_bug.cgi?id=54522
1690
1691         Fix jpegEmptyOutputBuffer() by ignoring free_in_buffer value as required.
1692
1693         No new tests, as this code is not yet used in WebKit. Once this code is used to implement canvas.toDataUrl(), the canvas tests will exercise it.
1694
1695         * platform/image-encoders/JPEGImageEncoder.cpp:
1696         (WebCore::jpegEmptyOutputBuffer):
1697
1698 2011-03-07  Sergey Glazunov  <serg.glazunov@gmail.com>
1699
1700         Reviewed by Eric Seidel.
1701
1702         Add the missing insertedIntoDocument() call in SVGVKernElement and SVGHKernElement
1703         https://bugs.webkit.org/show_bug.cgi?id=55896
1704
1705         Test: svg/dom/vkern-element-crash.html
1706
1707         * svg/SVGHKernElement.cpp:
1708         (WebCore::SVGHKernElement::insertedIntoDocument):
1709         * svg/SVGVKernElement.cpp:
1710         (WebCore::SVGVKernElement::insertedIntoDocument):
1711
1712 2011-03-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1713
1714         Unreviewed, rolling out r80514.
1715         http://trac.webkit.org/changeset/80514
1716         https://bugs.webkit.org/show_bug.cgi?id=55915
1717
1718         Caused assertion failures (Requested by ukai on #webkit).
1719
1720         * platform/graphics/skia/GraphicsContextSkia.cpp:
1721         (WebCore::GraphicsContext::setPlatformShadow):
1722         * platform/graphics/skia/ImageSkia.cpp:
1723         (WebCore::paintSkBitmap):
1724
1725 2011-03-07  Cosmin Truta  <ctruta@chromium.org>
1726
1727         Reviewed by Adam Barth.
1728
1729         SVG <image> referenced by <use> is displayed incorrectly
1730         https://bugs.webkit.org/show_bug.cgi?id=55750
1731
1732         The result of sourceURI must use the URL of the enclosing document as base.
1733         Otherwise, the base may sometimes be empty, and, as a consequence,
1734         the intermediate KURL object may be invalid.
1735
1736         Test: svg/custom/use-image-in-g.svg
1737
1738         * svg/SVGImageLoader.cpp:
1739         (WebCore::SVGImageLoader::sourceURI):
1740
1741 2011-03-07  Helder Correia  <helder@sencha.com>
1742
1743         Reviewed by Simon Fraser.
1744
1745         Shadow is not shown when using strokeRect with a gradient strokeStyle
1746         https://bugs.webkit.org/show_bug.cgi?id=52509
1747
1748         This happens in CG and is related to bug 51869, this time to be fixed
1749         in GraphicsContext::strokeRect(const FloatRect& r, float lineWidth).
1750         We need to draw the gradient clipped to the stroke on a CGLayer first,
1751         and then draw the layer on the GraphicsContext.
1752
1753         Tests: fast/canvas/canvas-strokeRect-gradient-shadow.html
1754                svg/css/rect-gradient-stroke-shadow.svg
1755
1756         * platform/graphics/cg/GraphicsContextCG.cpp:
1757         (WebCore::GraphicsContext::strokeRect):
1758
1759 2011-03-07  Justin Novosad  <junov@chromium.org>
1760
1761         Reviewed by Kenneth Russell.
1762
1763         Fix for blurs behind bitmap images in Chromium, and boosting
1764         shadow blur quality 
1765         Bug URLs:
1766                 https://bugs.webkit.org/show_bug.cgi?id=55410
1767                 https://bugs.webkit.org/show_bug.cgi?id=55506
1768
1769         No new tests. Covered by existing layout tests. 
1770
1771         * platform/graphics/skia/GraphicsContextSkia.cpp:
1772         (WebCore::GraphicsContext::setPlatformShadow): Turn on high quality shadows and fix shadow color
1773         * platform/graphics/skia/ImageSkia.cpp:
1774         (WebCore::paintSkBitmap): Propagate the draw looper from context to painter
1775
1776 2011-03-07  Andreas Kling  <kling@webkit.org>
1777
1778         Unreviewed Mac build fix after r80508.
1779
1780         * WebCore.exp.in:
1781
1782 2011-03-07  Enrica Casucci  <enrica@apple.com>
1783
1784         Unreviewed build fix.
1785
1786         Rolling back  http://trac.webkit.org/changeset/80497 due to the
1787         32-bit build failures.
1788
1789         * WebCore.xcodeproj/project.pbxproj:
1790         * platform/mac/HTMLConverter.h: Removed.
1791         * platform/mac/HTMLConverter.mm: Removed.
1792         * platform/mac/PasteboardMac.mm:
1793         (WebCore::Pasteboard::writeSelection):
1794
1795 2011-03-07  Andreas Kling  <kling@webkit.org>
1796
1797         Reviewed by Benjamin Poulain.
1798
1799         FrameView::setBaseBackgroundColor: Pass Color argument as const-reference.
1800
1801         * page/FrameView.cpp:
1802         (WebCore::FrameView::setBaseBackgroundColor):
1803         * page/FrameView.h:
1804
1805 2011-03-07  Adam Barth  <abarth@webkit.org>
1806
1807         Reviewed by Dimitri Glazkov.
1808
1809         REGRESSION(r78147): Crash on http://gnarf.net/jquery/test/
1810         https://bugs.webkit.org/show_bug.cgi?id=55894
1811
1812         The m_frame can disappear out from under us, and there's no point in
1813         checking whether the load is complete in a non-existant frame.
1814
1815         Test: fast/parser/document-write-into-initial-document.html
1816
1817         * dom/Document.cpp:
1818         (WebCore::Document::explicitClose):
1819
1820 2011-03-07  Sheriff Bot  <webkit.review.bot@gmail.com>
1821
1822         Unreviewed, rolling out r80500.
1823         http://trac.webkit.org/changeset/80500
1824         https://bugs.webkit.org/show_bug.cgi?id=55908
1825
1826         Caused mysterious GYP error (Requested by abarth on #webkit).
1827
1828         * WebCore.gyp/WebCore.gyp:
1829         * WebCore.gypi:
1830
1831 2011-03-07  Adam Barth  <abarth@webkit.org>
1832
1833         Fix Chromium Mac build.  This header should only be included when the
1834         feature is enabled.
1835
1836         * platform/cf/RunLoopTimerCF.cpp:
1837
1838 2011-03-07  Adam Barth  <abarth@webkit.org>
1839
1840         Reviewed by Dimitri Glazkov.
1841
1842         Add WML files to WebCore.gypi
1843         https://bugs.webkit.org/show_bug.cgi?id=55905
1844
1845         * WebCore.gyp/WebCore.gyp:
1846         * WebCore.gypi:
1847
1848 2011-03-07  Adrienne Walker  <enne@google.com>
1849
1850         Reviewed by James Robinson.
1851
1852         [chromium] Add missing include to #define Skia parameter
1853         https://bugs.webkit.org/show_bug.cgi?id=55885
1854
1855         * platform/graphics/chromium/ShaderChromium.h:
1856
1857 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
1858
1859         Reviewed by Beth Dakin.
1860
1861         AX: WK1 needs to use ScrollView attachment for AXScrollArea, WK2 does not
1862         https://bugs.webkit.org/show_bug.cgi?id=55706
1863
1864         * WebCore.exp.in:
1865         * accessibility/AXObjectCache.cpp:
1866         (WebCore::AXObjectCache::rootObjectForFrame):
1867         * accessibility/AXObjectCache.h:
1868         * accessibility/AccessibilityScrollView.cpp:
1869         (WebCore::AccessibilityScrollView::isAttachment):
1870         (WebCore::AccessibilityScrollView::widgetForAttachmentView):
1871         * accessibility/AccessibilityScrollView.h:
1872         (WebCore::AccessibilityScrollView::firstChild):
1873         * accessibility/mac/AccessibilityObjectWrapper.mm:
1874         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
1875
1876 2011-03-07  Enrica Casucci  <enrica@apple.com>
1877
1878         Reviewed by Darin Adler.
1879         
1880         REGRESSION: Copied content loses formatting on paste to external apps.
1881         https://bugs.webkit.org/show_bug.cgi?id=47615
1882         <rdar://problem/9001214>
1883
1884         This is a resubmission of a patch that was landed a while ago then rolled
1885         back because of a build failure on SnowLeopard and Leopard.
1886         
1887         This patch adds a way for WebKit2 to create NSAttributedStrings from
1888         a DOM range without using the AppKit api initWithDOMRange that internally
1889         needs to access the WebView. The NSAttributedString is needed to create
1890         RTF formats in the pasteboard.
1891         This is to be considered a first step, since in the future we want to have
1892         an implementation based on the TextIterator.
1893
1894         * WebCore.xcodeproj/project.pbxproj: Added new file.
1895         * platform/mac/HTMLConverter.h: Added.
1896         * platform/mac/HTMLConverter.mm: Added.
1897         * platform/mac/PasteboardMac.mm:
1898         (WebCore::Pasteboard::writeSelection): We now use WebHTMLConverter
1899         class for WebKit2 to create the NSAttributedString from the DOM range.
1900
1901 2011-03-07  Adam Barth  <abarth@webkit.org>
1902
1903         Reviewed by Dimitri Glazkov.
1904
1905         Add some missing platform files to WebCore.gypi
1906         https://bugs.webkit.org/show_bug.cgi?id=55897
1907
1908         There are a bunch more, but this is a start.
1909
1910         * WebCore.gyp/WebCore.gyp:
1911         * WebCore.gypi:
1912
1913 2011-03-07  Steve Block  <steveblock@google.com>
1914
1915         Reviewed by Jeremy Orlow.
1916
1917         Rename JNIBridgeV8.cpp/h to JavaFieldV8.cpp/h
1918         https://bugs.webkit.org/show_bug.cgi?id=55879
1919
1920         No new tests, refactoring only.
1921
1922         * Android.v8bindings.mk:
1923         * WebCore.gypi:
1924         * bridge/jni/v8/JavaClassV8.cpp:
1925         * bridge/jni/v8/JavaClassV8.h:
1926         * bridge/jni/v8/JavaFieldV8.cpp: Renamed from Source/WebCore/bridge/jni/v8/JNIBridgeV8.cpp.
1927         (JavaField::JavaField):
1928         * bridge/jni/v8/JavaFieldV8.h: Renamed from Source/WebCore/bridge/jni/v8/JNIBridgeV8.h.
1929         (JSC::Bindings::JavaField::name):
1930         (JSC::Bindings::JavaField::type):
1931         (JSC::Bindings::JavaField::getJNIType):
1932         * bridge/jni/v8/JavaInstanceV8.cpp:
1933         * bridge/jni/v8/JavaNPObjectV8.cpp:
1934
1935 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
1936
1937         Reviewed by Tony Chang.
1938
1939         Add plumbing for paste support to ChromiumDataObject::types()
1940         https://bugs.webkit.org/show_bug.cgi?id=55792
1941
1942         This is a preliminary patch to support event.dataTransfer.items. This
1943         adds plumbing to support retrieving the types in a paste event. It also
1944         moves the check for files in a drag/paste up to ClipboardChromium, since
1945         internal code needs to be able to differentiate between actual files in
1946         a drag and someone that simply decided to use "Files" as a custom type
1947         string.
1948
1949         Test: editing/pasteboard/onpaste-text-html-types.html
1950
1951         * platform/chromium/ChromiumDataObject.cpp:
1952         (WebCore::ChromiumDataObject::types):
1953         (WebCore::ChromiumDataObject::containsFilenames):
1954         * platform/chromium/ChromiumDataObject.h:
1955         * platform/chromium/ClipboardChromium.cpp:
1956         (WebCore::ClipboardChromium::types):
1957         * platform/chromium/ClipboardMimeTypes.cpp:
1958         * platform/chromium/ClipboardMimeTypes.h:
1959
1960 2011-03-07  Takayoshi Kochi  <kochi@chromium.org>
1961
1962         Reviewed by Tony Chang.
1963
1964         [chromium] Use preferred locale information when choosing fallback
1965         font using fontconfig on Linux platform.
1966         http://bugs.webkit.org/show_bug.cgi?id=55453
1967
1968         No new tests, as it depends on ICU and locale setting, so it will be
1969         covered by Chromium side.
1970
1971         * platform/chromium/PlatformBridge.h:
1972         * platform/graphics/chromium/FontCacheLinux.cpp:
1973
1974 2011-03-07  Adam Barth  <abarth@webkit.org>
1975
1976         Reviewed by Eric Seidel.
1977
1978         Add gobject, cpp, and objc bindings to WebCore.gypi
1979         https://bugs.webkit.org/show_bug.cgi?id=55892
1980
1981         These are also excluded from the Chromium build but needed for various
1982         other ports.
1983
1984         * WebCore.gyp/WebCore.gyp:
1985         * WebCore.gypi:
1986
1987 2011-03-07  Sergey Glazunov  <serg.glazunov@gmail.com>
1988
1989         Reviewed by Dimitri Glazkov.
1990
1991         Node::checkAddChild and Node::checkReplaceChild shouldn't change the owner document of a node
1992         https://bugs.webkit.org/show_bug.cgi?id=55803
1993
1994         Test: fast/dom/dom-method-document-change.html
1995
1996         * dom/ContainerNode.cpp:
1997         (WebCore::ContainerNode::insertBefore):
1998         (WebCore::ContainerNode::replaceChild):
1999         (WebCore::ContainerNode::appendChild):
2000         * dom/Node.cpp:
2001         (WebCore::Node::checkReplaceChild):
2002         (WebCore::Node::checkAddChild):
2003         * dom/Node.h:
2004
2005 2011-03-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2006
2007         Unreviewed, rolling out r80484.
2008         http://trac.webkit.org/changeset/80484
2009         https://bugs.webkit.org/show_bug.cgi?id=55891
2010
2011         requires Chromium DEPS roll (Requested by dcheng on #webkit).
2012
2013         * platform/chromium/ChromiumDataObject.cpp:
2014         (WebCore::ChromiumDataObject::types):
2015         * platform/chromium/ChromiumDataObject.h:
2016         (WebCore::ChromiumDataObject::containsFilenames):
2017         * platform/chromium/ClipboardChromium.cpp:
2018         (WebCore::ClipboardChromium::types):
2019         * platform/chromium/ClipboardMimeTypes.cpp:
2020         * platform/chromium/ClipboardMimeTypes.h:
2021
2022 2011-03-07  Adam Barth  <abarth@webkit.org>
2023
2024         Reviewed by Dimitri Glazkov.
2025
2026         Add missing bindings/js files to WebCore.gypi
2027         https://bugs.webkit.org/show_bug.cgi?id=55888
2028
2029         These files are excluded from the Chromium build but needed for the Mac
2030         build.
2031
2032         * WebCore.gypi:
2033
2034 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
2035
2036         Reviewed by Tony Chang.
2037
2038         Add plumbing for paste support to ChromiumDataObject::types()
2039         https://bugs.webkit.org/show_bug.cgi?id=55792
2040
2041         This is a preliminary patch to support event.dataTransfer.items. This
2042         adds plumbing to support retrieving the types in a paste event. It also
2043         moves the check for files in a drag/paste up to ClipboardChromium, since
2044         internal code needs to be able to differentiate between actual files in
2045         a drag and someone that simply decided to use "Files" as a custom type
2046         string.
2047
2048         Test: editing/pasteboard/onpaste-text-html-types.html
2049
2050         * platform/chromium/ChromiumDataObject.cpp:
2051         (WebCore::ChromiumDataObject::types):
2052         (WebCore::ChromiumDataObject::containsFilenames):
2053         * platform/chromium/ChromiumDataObject.h:
2054         * platform/chromium/ClipboardChromium.cpp:
2055         (WebCore::ClipboardChromium::types):
2056         * platform/chromium/ClipboardMimeTypes.cpp:
2057         * platform/chromium/ClipboardMimeTypes.h:
2058
2059 2011-03-07  Joseph Pecoraro  <joepeck@webkit.org>
2060
2061         Reviewed by Kenneth Rohde Christiansen.
2062
2063         Viewport Warning/Error Messages Are Now Inaccurate
2064         https://bugs.webkit.org/show_bug.cgi?id=53707
2065
2066         Correct and improve the error messages for viewport parsing.
2067
2068         Tests: fast/viewport/viewport-warnings-1.html
2069                fast/viewport/viewport-warnings-2.html
2070                fast/viewport/viewport-warnings-3.html
2071                fast/viewport/viewport-warnings-4.html
2072                fast/viewport/viewport-warnings-5.html
2073                fast/viewport/viewport-warnings-6.html
2074
2075         * dom/ViewportArguments.cpp:
2076         (WebCore::numericPrefix):
2077         (WebCore::findSizeValue): remove incorrect device-width / height tips.
2078         (WebCore::setViewportFeature): report a warning for an unrecognized key.
2079         (WebCore::viewportErrorMessageTemplate): added template for unrecognized key.
2080         (WebCore::viewportErrorMessageLevel): classify an unrecognized key is an error.
2081         * dom/ViewportArguments.h: removed no longer used warnings.
2082
2083 2011-03-07  James Robinson  <jamesr@chromium.org>
2084
2085         Reviewed by Kenneth Russell.
2086
2087         [chromium] Separate the update and draw portions of LayerRendererChromium's drawLayers function
2088         https://bugs.webkit.org/show_bug.cgi?id=54047
2089
2090         This splits up LayerRendererChromium::drawLayers() into two phases,
2091         one that updates layers and one that actually draws them.  Most of the
2092         patch is moving the bodies of drawLayers() and updateLayersRecursive()
2093         into smaller helper functions.
2094
2095         The main entry point is renamed updateAndDrawLayers(), but otherwise
2096         has the same signature as drawLayers() did.  Internally it does the
2097         following:
2098
2099         1.) Updates the root layer's contents
2100         2.) Updates the root layer's scrollbars
2101         3.) Updates the RenderSurface tree and the contents of all child
2102         layers
2103         4.) Draws the root layer and root layer scrollbars
2104         5.) Draws all child layers using the previously updated
2105         CCLayerImpl/RenderSurface data.
2106
2107         A few things still need to be done after this patch to complete the separation
2108         of the update and draw step, but they can happen in later patches:
2109         *) The root layer and root layer scrollbars contents should be
2110         uploaded to textures at draw time, not update time.
2111         *) The RenderSurface tree should be updated at draw time, not update
2112         time.
2113
2114         Covered by the compositing/ tests.
2115
2116         * platform/graphics/chromium/LayerRendererChromium.cpp:
2117         (WebCore::LayerRendererChromium::LayerRendererChromium):
2118         (WebCore::LayerRendererChromium::updateRootLayerContents):
2119         (WebCore::LayerRendererChromium::updateRootLayerScrollbars):
2120         (WebCore::LayerRendererChromium::drawRootLayer):
2121         (WebCore::LayerRendererChromium::updateAndDrawLayers):
2122         (WebCore::LayerRendererChromium::updateLayers):
2123         (WebCore::LayerRendererChromium::drawLayers):
2124         (WebCore::LayerRendererChromium::getFramebufferPixels):
2125         (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
2126         (WebCore::LayerRendererChromium::updateContentsRecursive):
2127         (WebCore::LayerRendererChromium::drawLayer):
2128         * platform/graphics/chromium/LayerRendererChromium.h:
2129         (WebCore::LayerRendererChromium::visibleRectSize):
2130         * platform/graphics/chromium/RenderSurfaceChromium.cpp:
2131         (WebCore::RenderSurfaceChromium::drawSurface):
2132         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
2133         * platform/graphics/chromium/cc/CCLayerImpl.h:
2134
2135 2011-03-07  Adam Barth  <abarth@webkit.org>
2136
2137         Reviewed by Eric Seidel.
2138
2139         Sort WebCore.gypi
2140         https://bugs.webkit.org/show_bug.cgi?id=55887
2141
2142         These files should be in order.  This is preparation for adding in the
2143         missing files.
2144
2145         * WebCore.gypi:
2146
2147 2011-03-07  Csaba Osztrogon√°c  <ossy@webkit.org>
2148
2149         Unreviewed buildfix after r80478.
2150
2151         * dom/Document.cpp: Add suggested parentheses to make GCC happy.
2152         (WebCore::Document::didReceiveTask):
2153
2154 2011-03-07  Yong Li  <yoli@rim.com>
2155
2156         Reviewed by Darin Adler.
2157
2158         Defer ScriptExecutionContext::Task's in Document when page loading is deferred.
2159         Schedule them with timer when page loading is resumed. The tasks will be performed
2160         in the original order. This fixes the problem that database callbacks could be missed
2161         when page loading was deferred.
2162         https://bugs.webkit.org/show_bug.cgi?id=49401
2163
2164         Manual test added: manual-tests/database-callback-deferred.html.
2165
2166         * dom/Document.cpp:
2167         (WebCore::Document::Document):
2168         (WebCore::Document::~Document):
2169         (WebCore::Document::didReceiveTask):
2170         (WebCore::Document::postTask):
2171         (WebCore::Document::pendingTasksTimerFired):
2172         (WebCore::Document::willDeferLoading):
2173         (WebCore::Document::didResumeLoading):
2174         * dom/Document.h:
2175         * manual-tests/database-callback-deferred.html: Added.
2176         * page/PageGroupLoadDeferrer.cpp:
2177         (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
2178         (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
2179
2180 2011-03-07  Antti Koivisto  <antti@apple.com>
2181
2182         Reviewed by Sam Weinig.
2183
2184         Use HashMaps for caching primitive values
2185         https://bugs.webkit.org/show_bug.cgi?id=55873
2186         
2187         Most documents use only small subset of cacheable primitive values. By replacing
2188         fixed size cache arrays with HashMaps we can reduce the constant memory usage while also
2189         expanding the range of cacheable values.
2190
2191         * css/CSSPrimitiveValueCache.cpp:
2192         (WebCore::CSSPrimitiveValueCache::CSSPrimitiveValueCache):
2193         (WebCore::CSSPrimitiveValueCache::createIdentifierValue):
2194         (WebCore::CSSPrimitiveValueCache::createColorValue):
2195         (WebCore::CSSPrimitiveValueCache::createValue):
2196         * css/CSSPrimitiveValueCache.h:
2197
2198 2011-03-07  Steve Block  <steveblock@google.com>
2199
2200         Reviewed by Jeremy Orlow.
2201
2202         Split JNIBridgeJSC.cpp/h into JavaArrayJSC.cpp/h and JavaFieldJSC.cpp/h
2203         https://bugs.webkit.org/show_bug.cgi?id=55881
2204
2205         No new tests, refactoring only.
2206
2207         * Android.jscbindings.mk:
2208         * GNUmakefile.am:
2209         * WebCore.xcodeproj/project.pbxproj:
2210         * bridge/jni/jsc/JNIBridgeJSC.cpp: Removed.
2211         * bridge/jni/jsc/JNIBridgeJSC.h: Removed.
2212         * bridge/jni/jsc/JNIUtilityPrivate.cpp:
2213         * bridge/jni/jsc/JavaClassJSC.cpp:
2214         * bridge/jni/jsc/JavaClassJSC.h:
2215         * bridge/jni/jsc/JavaInstanceJSC.cpp:
2216
2217 2011-03-07  Sam Weinig  <sam@webkit.org>
2218
2219         Reviewed by Anders Carlsson.
2220
2221         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
2222         https://bugs.webkit.org/show_bug.cgi?id=55827
2223
2224         * loader/EmptyClients.h:
2225         (WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForResponse):
2226         * loader/FrameLoaderClient.h:
2227         * loader/MainResourceLoader.cpp:
2228         (WebCore::MainResourceLoader::didReceiveResponse):
2229         * loader/PolicyChecker.cpp:
2230         (WebCore::PolicyChecker::checkContentPolicy):
2231         * loader/PolicyChecker.h:
2232         Rename FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
2233         and pass the entire response, instead of just the MIMEType.
2234
2235 2011-03-07  Eric Carlson  <eric.carlson@apple.com>
2236
2237         Reviewed by Darin Adler.
2238
2239         Add API to enumerate/delete files downloaded for <audio> and <video>
2240         https://bugs.webkit.org/show_bug.cgi?id=55267
2241         <rdar://problem/9049280>
2242
2243         No new tests, this is just more plumbing.
2244
2245         * html/HTMLMediaElement.cpp:
2246         (WebCore::HTMLMediaElement::getSitesInMediaCache): Make static, call MediaPlayer static method.
2247         (WebCore::HTMLMediaElement::clearMediaCache): Ditto.
2248         (WebCore::HTMLMediaElement::clearMediaCacheForSite): Ditto.
2249         * html/HTMLMediaElement.h:
2250
2251         * platform/graphics/MediaPlayer.cpp:
2252         (WebCore::MediaPlayerFactory::MediaPlayerFactory): Add new media engine factory functions.
2253         (WebCore::addMediaEngine): Ditto.
2254         (WebCore::MediaPlayer::getSitesInMediaCache): Call static method on all installed media engines.
2255         (WebCore::MediaPlayer::clearMediaCache): Ditto.
2256         (WebCore::MediaPlayer::clearMediaCacheForSite): Ditto.
2257         * platform/graphics/MediaPlayer.h:
2258
2259         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
2260         (WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine): Update for MediaEngineRegistrar change.
2261
2262         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
2263         (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Ditto.
2264
2265         * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
2266         (WebCore::MediaPlayerPrivatePhonon::registerMediaEngine): Ditto.
2267
2268         * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
2269         (WebCore::MediaPlayerPrivateQt::registerMediaEngine): Ditto.
2270
2271         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
2272         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::registerMediaEngine): Ditto.
2273
2274         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
2275         (WebCore::MediaPlayerPrivate::registerMediaEngine): Ditto.
2276
2277 2011-03-07  Steve Block  <steveblock@google.com>
2278
2279         Reviewed by Jeremy Orlow.
2280
2281         Split JNIBridge.cpp/h into JavaString.h and JavaMethod.cpp/h
2282         https://bugs.webkit.org/show_bug.cgi?id=55774
2283
2284         No new tests, refactoring only.
2285
2286         * Android.jscbindings.mk:
2287         * Android.v8bindings.mk:
2288         * GNUmakefile.am:
2289         * WebCore.gypi:
2290         * WebCore.xcodeproj/project.pbxproj:
2291         * bridge/jni/JavaMethod.cpp:
2292         (JavaMethod::JavaMethod):
2293         (JavaMethod::~JavaMethod):
2294         (appendClassName):
2295         (JavaMethod::signature):
2296         (JavaMethod::JNIReturnType):
2297         (JavaMethod::methodID):
2298         * bridge/jni/JavaMethod.h:
2299         (JSC::Bindings::JavaMethod::name):
2300         (JSC::Bindings::JavaMethod::returnType):
2301         (JSC::Bindings::JavaMethod::parameterAt):
2302         (JSC::Bindings::JavaMethod::numParameters):
2303         (JSC::Bindings::JavaMethod::isStatic):
2304         * bridge/jni/JavaString.h:
2305         (JSC::Bindings::JavaString::JavaString):
2306         (JSC::Bindings::JavaString::utf8):
2307         (JSC::Bindings::JavaString::length):
2308         (JSC::Bindings::JavaString::impl):
2309         * bridge/jni/jni_jsobject.mm:
2310         * bridge/jni/jsc/JNIBridgeJSC.h:
2311         * bridge/jni/v8/JNIBridgeV8.h:
2312         * bridge/jni/v8/JavaClassV8.cpp:
2313         * bridge/jni/v8/JavaClassV8.h:
2314         * bridge/jni/v8/JavaInstanceV8.cpp:
2315
2316 2011-03-07  Jeremy Orlow  <jorlow@chromium.org>
2317
2318         Reviewed by Steve Block.
2319
2320         Add source to IDBCursor, objectStore to IDBIndex, and remove storeName
2321         https://bugs.webkit.org/show_bug.cgi?id=55812
2322
2323         This brings us in line with what's in the spec:
2324         http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html
2325
2326         * storage/IDBCursor.cpp:
2327         (WebCore::IDBCursor::create):
2328         (WebCore::IDBCursor::IDBCursor):
2329         (WebCore::IDBCursor::source):
2330         * storage/IDBCursor.h:
2331         * storage/IDBCursor.idl:
2332         * storage/IDBCursorWithValue.cpp:
2333         (WebCore::IDBCursorWithValue::create):
2334         (WebCore::IDBCursorWithValue::IDBCursorWithValue):
2335         * storage/IDBCursorWithValue.h:
2336         * storage/IDBIndex.cpp:
2337         (WebCore::IDBIndex::IDBIndex):
2338         * storage/IDBIndex.h:
2339         (WebCore::IDBIndex::create):
2340         (WebCore::IDBIndex::objectStore):
2341         * storage/IDBIndex.idl:
2342         * storage/IDBObjectStore.cpp:
2343         (WebCore::IDBObjectStore::createIndex):
2344         (WebCore::IDBObjectStore::index):
2345         * storage/IDBRequest.cpp:
2346         (WebCore::IDBRequest::onSuccess):
2347
2348 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
2349
2350         Reviewed by Beth Dakin.
2351
2352         AX: kAXCellForColumnAndRowParameterizedAttribute doesn't work ARIA grids with colspans
2353         https://bugs.webkit.org/show_bug.cgi?id=55735
2354
2355         The ARIA grid implementation needed to verify the row/column range of a cell instead of 
2356         assuming a 1-1 mapping between children and row/column.
2357
2358         Test: platform/mac/accessibility/aria-table-with-colspan-cells.html
2359
2360         * accessibility/AccessibilityARIAGrid.cpp:
2361         (WebCore::AccessibilityARIAGrid::cellForColumnAndRow):
2362
2363 2011-03-07  Andrei Popescu  <andreip@google.com>
2364
2365         Reviewed by Steve Block.
2366
2367         IDBRequest::onSuccess(IDBObjectStore*) should be removed as it is unused.
2368         IDBObjectStore objects used to be created asynchronously, so we needed
2369         this method to be invoked, with the new object store as the parameter,
2370         whenever the creation succeeded. The spec has changed so that IDBObjectStore
2371         objects are created synchronously, so this method is no longer needed.
2372         https://bugs.webkit.org/show_bug.cgi?id=55777
2373
2374         No new tests, just refactoring.
2375
2376         * storage/IDBCallbacks.h:
2377         * storage/IDBRequest.cpp:
2378         * storage/IDBRequest.h:
2379
2380 2011-03-04  Steve Block  <steveblock@google.com>
2381
2382         Reviewed by Jeremy Orlow.
2383
2384         JavaParameter should be removed
2385         https://bugs.webkit.org/show_bug.cgi?id=55772
2386
2387         No new tests, refactoring only.
2388
2389         * bridge/jni/JNIBridge.cpp:
2390         (JavaMethod::JavaMethod):
2391         (JavaMethod::~JavaMethod):
2392         (JavaMethod::signature):
2393         * bridge/jni/JNIBridge.h:
2394         (JSC::Bindings::JavaMethod::parameterAt):
2395         (JSC::Bindings::JavaMethod::numParameters):
2396         * bridge/jni/JNIUtility.h:
2397         * bridge/jni/jsc/JavaInstanceJSC.cpp:
2398         (JavaInstance::invokeMethod):
2399         * bridge/jni/v8/JNIUtilityPrivate.cpp:
2400         (JSC::Bindings::convertNPVariantToJValue):
2401         * bridge/jni/v8/JNIUtilityPrivate.h:
2402         * bridge/jni/v8/JavaInstanceV8.cpp:
2403         (JavaInstance::invokeMethod):
2404
2405 2011-03-07  Antti Koivisto  <antti@apple.com>
2406
2407         Reviewed by Oliver Hunt.
2408
2409         REGRESSION (r79574): fast/dom/global-constructors.html failing on Windows 7 Release (Tests) bots 
2410         https://bugs.webkit.org/show_bug.cgi?id=55166
2411         <rdar://problem/9050430>
2412         
2413         Make CSS primitive value cache per-document.
2414         
2415         Test: http/tests/security/cross-origin-css-primitive.html
2416
2417         * Android.mk:
2418         * CMakeLists.txt:
2419         * GNUmakefile.am:
2420         * WebCore.gypi:
2421         * WebCore.pro:
2422         * WebCore.vcproj/WebCore.vcproj:
2423         * WebCore.xcodeproj/project.pbxproj:
2424         * css/CSSComputedStyleDeclaration.cpp:
2425         (WebCore::valueForNinePieceImage):
2426         (WebCore::zoomAdjustedPixelValue):
2427         (WebCore::zoomAdjustedNumberValue):
2428         (WebCore::zoomAdjustedPixelValueForLength):
2429         (WebCore::valueForReflection):
2430         (WebCore::getPositionOffsetValue):
2431         (WebCore::CSSComputedStyleDeclaration::currentColorOrValidColor):
2432         (WebCore::getBorderRadiusCornerValue):
2433         (WebCore::computedTransform):
2434         (WebCore::getDelayValue):
2435         (WebCore::getDurationValue):
2436         (WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
2437         (WebCore::CSSComputedStyleDeclaration::valueForShadow):
2438         (WebCore::valueForFamily):
2439         (WebCore::renderTextDecorationFlagsToCSSValue):
2440         (WebCore::fillRepeatToCSSValue):
2441         (WebCore::fillSizeToCSSValue):
2442         (WebCore::contentToCSSValue):
2443         (WebCore::counterToCSSValue):
2444         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2445         * css/CSSParser.cpp:
2446         (WebCore::CSSParser::parseSheet):
2447         (WebCore::CSSParser::parseRule):
2448         (WebCore::CSSParser::parseKeyframeRule):
2449         (WebCore::CSSParser::parseValue):
2450         (WebCore::CSSParser::parseColor):
2451         (WebCore::CSSParser::parseSelector):
2452         (WebCore::CSSParser::parseDeclaration):
2453         (WebCore::CSSParser::setStyleSheet):
2454         (WebCore::CSSParser::parseWCSSInputProperty):
2455         (WebCore::parseBackgroundClip):
2456         (WebCore::CSSParser::parseFillShorthand):
2457         (WebCore::CSSParser::parsePage):
2458         (WebCore::CSSParser::parseSizeParameter):
2459         (WebCore::CSSParser::parseContent):
2460         (WebCore::CSSParser::parseAttr):
2461         (WebCore::CSSParser::parseBackgroundColor):
2462         (WebCore::CSSParser::parseFillPositionXY):
2463         (WebCore::CSSParser::parseFillPosition):
2464         (WebCore::CSSParser::parseFillRepeat):
2465         (WebCore::CSSParser::parseFillSize):
2466         (WebCore::CSSParser::parseFillProperty):
2467         (WebCore::CSSParser::parseAnimationDelay):
2468         (WebCore::CSSParser::parseAnimationDirection):
2469         (WebCore::CSSParser::parseAnimationDuration):
2470         (WebCore::CSSParser::parseAnimationFillMode):
2471         (WebCore::CSSParser::parseAnimationIterationCount):
2472         (WebCore::CSSParser::parseAnimationName):
2473         (WebCore::CSSParser::parseAnimationPlayState):
2474         (WebCore::CSSParser::parseAnimationProperty):
2475         (WebCore::CSSParser::parseTransformOriginShorthand):
2476         (WebCore::CSSParser::parseAnimationTimingFunction):
2477         (WebCore::CSSParser::parseDashboardRegions):
2478         (WebCore::CSSParser::parseCounterContent):
2479         (WebCore::CSSParser::parseShape):
2480         (WebCore::CSSParser::parseFont):
2481         (WebCore::CSSParser::parseFontFamily):
2482         (WebCore::CSSParser::parseFontStyle):
2483         (WebCore::CSSParser::parseFontVariant):
2484         (WebCore::CSSParser::parseFontWeight):
2485         (WebCore::ShadowParseContext::ShadowParseContext):
2486         (WebCore::ShadowParseContext::commitLength):
2487         (WebCore::ShadowParseContext::commitStyle):
2488         (WebCore::CSSParser::parseShadow):
2489         (WebCore::CSSParser::parseReflect):
2490         (WebCore::BorderImageParseContext::BorderImageParseContext):
2491         (WebCore::BorderImageParseContext::commitNumber):
2492         (WebCore::BorderImageParseContext::commitBorderImage):
2493         (WebCore::CSSParser::parseBorderImage):
2494         (WebCore::CSSParser::parseBorderRadius):
2495         (WebCore::CSSParser::parseCounter):
2496         (WebCore::parseDeprecatedGradientPoint):
2497         (WebCore::parseDeprecatedGradientColorStop):
2498         (WebCore::CSSParser::parseDeprecatedGradient):
2499         (WebCore::valueFromSideKeyword):
2500         (WebCore::parseGradientColorOrKeyword):
2501         (WebCore::CSSParser::parseLinearGradient):
2502         (WebCore::CSSParser::parseRadialGradient):
2503         (WebCore::CSSParser::parseGradientColorStops):
2504         (WebCore::CSSParser::parseTransform):
2505         (WebCore::CSSParser::parseTransformOrigin):
2506         (WebCore::CSSParser::parseTextEmphasisStyle):
2507         * css/CSSParser.h:
2508         (WebCore::CSSParser::primitiveValueCache):
2509         * css/CSSPrimitiveValue.cpp:
2510         * css/CSSPrimitiveValue.h:
2511         (WebCore::CSSPrimitiveValue::createIdentifier):
2512         (WebCore::CSSPrimitiveValue::createColor):
2513         (WebCore::CSSPrimitiveValue::create):
2514         * css/CSSPrimitiveValueCache.cpp: Added.
2515         (WebCore::CSSPrimitiveValueCache::CSSPrimitiveValueCache):
2516         (WebCore::CSSPrimitiveValueCache::~CSSPrimitiveValueCache):
2517         (WebCore::CSSPrimitiveValueCache::createIdentifierValue):
2518         (WebCore::CSSPrimitiveValueCache::createColorValue):
2519         (WebCore::CSSPrimitiveValueCache::createValue):
2520         * css/CSSPrimitiveValueCache.h: Added.
2521         (WebCore::CSSPrimitiveValueCache::create):
2522         (WebCore::CSSPrimitiveValueCache::createValue):
2523         * dom/Document.cpp:
2524         (WebCore::Document::cssPrimitiveValueCache):
2525         * dom/Document.h:
2526
2527 2011-03-06  Adam Barth  <abarth@webkit.org>
2528
2529         Reviewed by Eric Seidel.
2530
2531         Filter sources in WebCore GYP build for Mac
2532         https://bugs.webkit.org/show_bug.cgi?id=55857
2533
2534         This patch removes a large number of files that do not build as part of
2535         the Mac build.  I'm not fully sold on this method of
2536         including/excluding files, but it's the "gyp way" so we should probably
2537         try it first.
2538
2539         This patch also sets xcode_list_excluded_files to 0, which removes the
2540         excluded files from the Xcode project file, which is necessary in order
2541         to prevent the header map feature from including the wrong header file.
2542
2543         * gyp/WebCore.gyp:
2544
2545 2011-03-07  Ryuan Choi  <ryuan.choi@samsung.com>
2546
2547         Unreviewed EFL build fix.
2548
2549         [EFL] Build break on Debug build.
2550         https://bugs.webkit.org/show_bug.cgi?id=55858
2551
2552         * platform/efl/RenderThemeEfl.cpp:
2553         (WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):
2554
2555 2011-03-06  Adam Barth  <abarth@webkit.org>
2556
2557         Reviewed by Eric Seidel.
2558
2559         Add webcore_derived_source_files to WebCore.gypi
2560         https://bugs.webkit.org/show_bug.cgi?id=55856
2561
2562         This is the list of files generated by the Mac port.  It's possible
2563         other ports generate a different list of files.
2564
2565         * WebCore.gypi:
2566         * gyp/WebCore.gyp:
2567
2568 2011-03-06  Naoki Takano  <takano.naoki@gmail.com>
2569
2570         Reviewed by Kent Tamura.
2571
2572         Input type=number spin buttons remain invisible but functional after div changed from hidden to visible.
2573         https://bugs.webkit.org/show_bug.cgi?id=55839
2574         http://crbug.com/73866
2575         http://crbug.com/62527
2576
2577         We also need style change for m_innerSpinButton not only for m_outerSpinBuggon when styleDidChange() is called.
2578
2579         Test: fast/forms/input-appearance-spinbutton-visibility.html
2580
2581         * rendering/RenderTextControlSingleLine.cpp:
2582         (WebCore::RenderTextControlSingleLine::styleDidChange):
2583
2584 2011-03-06  Naoki Takano  <takano.naoki@gmail.com>
2585
2586         Reviewed by Kent Tamura.
2587
2588         [Chromium] Autocomplete suggestion extends out of window (and onto second monitor)
2589         https://bugs.webkit.org/show_bug.cgi?id=54795
2590
2591         Implement width clip logic according to browser screen width and popup window width. This fix is enough for Win and Mac, but there is a problem in Linux. Because WebScreenInfoFactory::screenInfo() can get only merged screen size, not the screen size where the browser exists.
2592
2593         Test: manual-tests/popup-width-restriction-within-screen.html
2594
2595         * manual-tests/popup-width-restriction-within-screen.html: Added.
2596         * platform/chromium/PopupMenuChromium.cpp:
2597         (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Implement the width clip logic according to screen width.
2598
2599 2011-03-06  Yuta Kitamura  <yutak@chromium.org>
2600
2601         Reviewed by Kent Tamura.
2602
2603         Add SHA-1 for new WebSocket protocol
2604         https://bugs.webkit.org/show_bug.cgi?id=55039
2605
2606         * ForwardingHeaders/wtf/SHA1.h: Added.
2607
2608 2011-03-06  Eric Carlson  <eric.carlson@apple.com>
2609
2610         Reviewed by Antti Koivisto.
2611
2612         QuickTime based media engines should respect private browsing mode
2613         https://bugs.webkit.org/show_bug.cgi?id=55848
2614
2615         No new tests, it is only possible to test this by manually deleting and monitoring the
2616         the Quicktime caches.
2617
2618         * html/HTMLMediaElement.cpp:
2619         (WebCore::HTMLMediaElement::privateBrowsingStateDidChange): Add logging.
2620
2621         * platform/graphics/MediaPlayer.cpp:
2622         (WebCore::MediaPlayer::MediaPlayer): Initialize m_privateBrowsing.
2623         (WebCore::MediaPlayer::loadWithNextMediaEngine): Set privacy mode on new media engine.
2624         (WebCore::MediaPlayer::setPrivateBrowsingMode): Stash setting in m_privateBrowsing.
2625         * platform/graphics/MediaPlayer.h:
2626         * platform/graphics/MediaPlayerPrivate.h:
2627         (WebCore::MediaPlayerPrivateInterface::setPrivateBrowsingMode):
2628
2629         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
2630         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
2631         (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit): Initialize m_privateBrowsing.
2632         (WebCore::MediaPlayerPrivateQTKit::createQTMovie): Pass private browsing attribute when
2633             creating new movie.
2634         (WebCore::MediaPlayerPrivateQTKit::setPrivateBrowsingMode): New, store privacy setting in
2635             m_privateBrowsing and set movie attribute.
2636
2637         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
2638         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
2639             Initialize m_privateBrowsing.
2640         (WebCore::MediaPlayerPrivateQuickTimeVisualContext::setPrivateBrowsingMode): New, store 
2641             privacy setting in m_privateBrowsing and call QTMovie.
2642         * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
2643
2644         * platform/graphics/win/QTMovie.cpp:
2645         (QTMoviePrivate::QTMoviePrivate): Initialize m_privateBrowsing.
2646         (QTMovie::load):Pass private browsing property when creating new movie.
2647         (QTMovie::setPrivateBrowsingMode):  New, store privacy setting in m_privateBrowsing and 
2648             set movie property.
2649         * platform/graphics/win/QTMovie.h:
2650
2651 2011-03-06  Daniel Bates  <dbates@rim.com>
2652
2653         Reviewed by Darin Adler.
2654
2655         style.borderSpacing always returns empty string
2656         https://bugs.webkit.org/show_bug.cgi?id=54816
2657
2658         Teach CSSMutableStyleDeclaration::getPropertyValue() how to reconstitute
2659         the value for border-spacing from the value of the WebKit internal CSS
2660         property -webkit-border-horizontal-spacing and -webkit-border-vertical-spacing.
2661
2662         The CSS property border-spacing describes the horizontal and vertical border
2663         spacing for an HTML Table element. Notice, WebKit internally represents the value
2664         of this property as two properties: -webkit-border-horizontal-spacing and
2665         -webkit-border-vertical-spacing, for the horizontal and vertical border spacing,
2666         respectively. And WebKit doesn't know to reconstitute these internal properties.
2667         Therefore style.borderSpacing always returns the empty string.
2668
2669         Test: fast/css/table-border-spacing.html
2670
2671         * css/CSSMutableStyleDeclaration.cpp:
2672         (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
2673         (WebCore::CSSMutableStyleDeclaration::borderSpacingValue): Added.
2674         * css/CSSMutableStyleDeclaration.h:
2675
2676 2011-03-06  Dan Bernstein  <mitz@apple.com>
2677
2678         Reviewed by Oliver Hunt.
2679
2680         <rdar://problem/9093327> Implement -hyphenate-limit-{before,after}
2681         https://bugs.webkit.org/show_bug.cgi?id=55850
2682
2683         Tests: fast/css/parsing-hyphenate-limit.html
2684                fast/text/hyphenate-limit-before-after.html
2685
2686         * css/CSSComputedStyleDeclaration.cpp:
2687         (WebCore::computedProperties) Updated this array with the new properties and some old properties
2688         that it was missing.
2689         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added
2690         CSSPropertyWebkitHyphenateLimit{Before,After}.
2691
2692         * css/CSSParser.cpp:
2693         (WebCore::CSSParser::parseValue): Parse -webkit-hyphenate-limit-{before,after}, allowing
2694         'auto' and non-negative integers.
2695
2696         * css/CSSPropertyNames.in: Added -webkit-hyphenate-limit-{before,after}.
2697
2698         * css/CSSStyleSelector.cpp:
2699         (WebCore::CSSStyleSelector::applyProperty): Handle CSSPropertyWebkitHyphenateLimit{Before,After}.
2700
2701         * rendering/RenderBlockLineLayout.cpp:
2702         (WebCore::tryHyphenating): Added minimum prefix and suffix length parameters and checks to only
2703         allow hyphenation if the prefix and the suffix are sufficiently long.
2704         (WebCore::RenderBlock::findNextLineBreak): Pass the limits to tryHyphenating().
2705
2706         * rendering/style/RenderStyle.cpp:
2707         (WebCore::RenderStyle::diff): A difference in hyphenation limits is a layout difference.
2708
2709         * rendering/style/RenderStyle.h:
2710         (WebCore::InheritedFlags::hyphenationLimitBefore): Added.
2711         (WebCore::InheritedFlags::hyphenationLimitAfter): Added.
2712         (WebCore::InheritedFlags::setHyphenationLimitBefore): Added.
2713         (WebCore::InheritedFlags::setHyphenationLimitAfter): Added.
2714         (WebCore::InheritedFlags::initialHyphenationLimitBefore): Added. Returns -1, which is the
2715         representation of 'auto'.
2716         (WebCore::InheritedFlags::initialHyphenationLimitAfter): Ditto.
2717
2718         * rendering/style/StyleRareInheritedData.cpp:
2719         (WebCore::StyleRareInheritedData::StyleRareInheritedData): Initialize hyphenation limits.
2720         (WebCore::StyleRareInheritedData::operator==): Compare hyphenation limits.
2721         * rendering/style/StyleRareInheritedData.h:
2722
2723 2011-03-06  Jessie Berlin  <jberlin@apple.com>
2724
2725         Reviewed by Sam Weinig.
2726
2727         WebKit2: Use CFNetwork Sessions API.
2728         https://bugs.webkit.org/show_bug.cgi?id=55435.
2729
2730         When Private Browsing is enabled, use cookies from a in-memory cookie storage based on the
2731         Private Browsing Storage Session.
2732
2733         * WebCore.exp.in:
2734         Add the new WKSI functions.
2735         * platform/mac/WebCoreSystemInterface.h:
2736         Ditto.
2737         * platform/mac/WebCoreSystemInterface.mm:
2738         Ditto.
2739
2740         * platform/mac/CookieJar.mm:
2741         (WebCore::cookies):
2742         If USE(CFURLSTORAGESESSIONS) and there is a Private Browsing Cookie Storage, call into WKSI.
2743         Otherwise, behave the same as before.
2744         (WebCore::cookieRequestHeaderFieldValue):
2745         Ditto.
2746         (WebCore::setCookies):
2747         Ditto.
2748         (WebCore::cookiesEnabled):
2749         Ditto
2750         (WebCore::getRawCookies):
2751         Ditto.
2752         (WebCore::deleteCookie):
2753         Ditto.
2754
2755         * platform/network/CookieStorage.h:
2756         * platform/network/cf/CookieStorageCFNet.cpp:
2757         (WebCore::privateBrowsingCookieStorage):
2758         Keep track of the Private Browsing Cookie Storage in a locally defined static inside a
2759         function instead of at the global scope.
2760         (WebCore::currentCookieStorage):
2761         Use privateBrowsingCookieStorage.
2762         (WebCore::setCurrentCookieStorage):
2763         Ditto.
2764         (WebCore::setCookieStoragePrivateBrowsingEnabled):
2765         If USE(CFURLSTORAGESESSIONS), send the Private Browsing Storage Session to
2766         wkCreatePrivateInMemoryHTTPCookieStorage.
2767         * platform/network/mac/CookieStorageMac.mm:
2768         (WebCore::privateBrowsingCookieStorage):
2769         Keep track of the Private Browsing Cookie Storage.
2770         (WebCore::setCookieStoragePrivateBrowsingEnabled):
2771         If USE(CFURLSTORAGESESSIONS), then set or clear privateBrowsingCookieStorage().
2772         Added a FIXME to observe changes to the Private Browsing Cookie Storage when it is defined.
2773
2774         * platform/network/mac/ResourceHandleMac.mm:
2775         (WebCore::shouldRelaxThirdPartyCookiePolicy):
2776         Refactor the logic to determine whether or not to relax the third party cookie policy here.
2777         If USE(CFURLSTORAGESESSIONS), then get the information from the privateBrowsingCookieStorage.
2778         (WebCore::ResourceHandle::createNSURLConnection):
2779         Use shouldRelaxThirdPartyCookiePolicy.
2780         (WebCore::ResourceHandle::loadResourceSynchronously):
2781         Ditto.
2782
2783 2011-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
2784
2785         Unreviewed, rolling out r80428.
2786         http://trac.webkit.org/changeset/80428
2787         https://bugs.webkit.org/show_bug.cgi?id=55833
2788
2789         Broke SnowLeopard (Requested by xan_ on #webkit).
2790
2791         * plugins/gtk/PluginViewGtk.cpp:
2792         (WebCore::PluginView::handlePostReadFile):
2793
2794 2011-03-01  Martin Robinson  <mrobinson@igalia.com>
2795
2796         Reviewed by Xan Lopez.
2797
2798         [GTK] Windowless plugins override the view cursor
2799         https://bugs.webkit.org/show_bug.cgi?id=55531
2800
2801         manual test: manual-tests/plugins/windowless.html
2802
2803         * platform/gtk/WidgetGtk.cpp:
2804         (WebCore::Widget::setCursor): Call into the ChromeClient implementation now.
2805         * plugins/gtk/PluginViewGtk.cpp:
2806         (WebCore::PluginView::initXEvent): Instead of setting the window for windowless
2807         plugin events, set the window value to none. This method is also used to send
2808         focus in / focus out events to windowed plugins, but this is not one of the plugin
2809         types where the window parameter matters. This matches what Mozilla does. Also
2810         pass in the display of the widget itself, not the default display.
2811         (WebCore::PluginView::handleMouseEvent): When the cursor leaves the plugin area,
2812         reset the cursor.
2813         (WebCore::PluginView::platformGetValue): Clean up this section slightly. Give the
2814         widget the top-level window explicitly. This matches Mozilla.
2815
2816 2011-03-05  Martin Robinson  <mrobinson@igalia.com>
2817
2818         Reviewed by Xan Lopez.
2819
2820         [GTK] http/tests/plugins/post-url-file.html fails on GTK+
2821         https://bugs.webkit.org/show_bug.cgi?id=55826
2822
2823         Correct the implementation of handlePostReadFile which uses GIO APIs and
2824         actually resizes the buffer to fit the entire size of the file data. This
2825         was likely leading to memory corruption until now.
2826
2827         * plugins/gtk/PluginViewGtk.cpp:
2828         (WebCore::PluginView::handlePostReadFile): Fix this method.
2829
2830 2011-03-05  Mikhail Naganov  <mnaganov@chromium.org>
2831
2832         Reviewed by Pavel Feldman.
2833
2834         Web Inspector: [Chromium] Allow dynamic enabling of detailed heap profiles.
2835         https://bugs.webkit.org/show_bug.cgi?id=55824
2836
2837         Detailed heap profiles can be now enabled by typing "leakz" in Profiles tab.
2838
2839         * inspector/front-end/DetailedHeapshotView.js:
2840         (WebInspector.DetailedHeapshotView.prototype.isDetailedSnapshot):
2841         * inspector/front-end/ProfilesPanel.js:
2842         (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
2843         (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
2844         (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
2845         (WebInspector.ProfilesPanel.prototype.handleShortcut):
2846         (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint.hideHint):
2847         (WebInspector.ProfilesPanel.prototype._displayDetailedHeapProfilesEnabledHint):
2848         (WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles):
2849         (WebInspector.ProfilesPanel.prototype._recognizeKeyboardCombo):
2850
2851 2011-03-05  Qi Zhang  <qi.2.zhang@nokia.com>
2852
2853         Reviewed by Laszlo Gombos.
2854
2855         [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
2856         https://bugs.webkit.org/show_bug.cgi?id=48636
2857
2858         Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.
2859
2860         * WebCore.pri:
2861         * features.pri:
2862
2863 2011-03-05  Pavel Feldman  <pfeldman@chromium.org>
2864
2865         Not reviewed: adding null check to prevent inspector tests from failing.
2866
2867         * inspector/front-end/TextViewer.js:
2868         (WebInspector.TextEditorGutterChunk.prototype.get offsetTop):
2869         (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
2870
2871 2011-03-05  Pavel Feldman  <pfeldman@chromium.org>
2872
2873         Not reviewed: chromium rebaseline, flaky test fix.
2874
2875         * inspector/front-end/BreakpointManager.js:
2876         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
2877         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
2878         (WebInspector.DOMBreakpointView.prototype._format.formatters.s):
2879         (WebInspector.DOMBreakpointView.prototype._format.append):
2880         (WebInspector.DOMBreakpointView.prototype._format):
2881
2882 2011-03-04  Pavel Podivilov  <podivilov@chromium.org>
2883
2884         Reviewed by Yury Semikhatsky.
2885
2886         Web Inspector: [chromium] pause when script is running is broken.
2887         https://bugs.webkit.org/show_bug.cgi?id=55762
2888
2889         * inspector/CodeGeneratorInspector.pm:
2890
2891 2011-03-05  Adam Barth  <abarth@webkit.org>
2892
2893         Reviewed by Dimitri Glazkov.
2894
2895         Add Derived Sources to WebCore GYP build
2896         https://bugs.webkit.org/show_bug.cgi?id=55813
2897
2898         Adding the derived source action to the GYP file required tweaking
2899         DerivedSources.make.  I'm not sure how DerivedSources.make worked
2900         before beause these paths were incorrectly based.
2901
2902         * DerivedSources.make:
2903         * gyp/generate-derived-sources.sh: Added.
2904         * gyp/WebCore.gyp:
2905
2906 2011-03-04  Pavel Feldman  <pfeldman@chromium.org>
2907
2908         Reviewed by Yury Semikhatsky.
2909
2910         Web Inspector: fix layout tests flakiness.
2911         https://bugs.webkit.org/show_bug.cgi?id=55816
2912
2913         - Order of issuing of evaluateForTestInFrontend was not guaranteed on the backend side (InspectorAgent side)
2914         - Order of dispatching using timeouts was guaranteed via queueing. Source of all kinds of pains on SnowLeopard Release (inspector.js)
2915
2916         * inspector/CodeGeneratorInspector.pm:
2917         * inspector/InspectorAgent.cpp:
2918         (WebCore::InspectorAgent::InspectorAgent):
2919         (WebCore::InspectorAgent::disconnectFrontend):
2920         (WebCore::InspectorAgent::populateScriptObjects):
2921         (WebCore::InspectorAgent::evaluateForTestInFrontend):
2922         (WebCore::InspectorAgent::issueEvaluateForTestCommands):
2923         * inspector/InspectorAgent.h:
2924         * inspector/front-end/TimelinePanel.js:
2925         (WebInspector.TimelinePanel.FormattedRecord):
2926         * inspector/front-end/inspector.js:
2927         (WebInspector.dispatch):
2928
2929 2011-03-05  Adam Barth  <abarth@webkit.org>
2930
2931         Reviewed by Dimitri Glazkov.
2932
2933         WebCore GYP build should generate fewer than 10,000 compile errors per file
2934         https://bugs.webkit.org/show_bug.cgi?id=55810
2935
2936         This patch adds some missing include paths.  We need to figure out how
2937         to handle separate include paths per port.  It's clear that
2938         ForwardingHeaders are only useful for Mac, but it's less clear how to
2939         handle the others.
2940
2941         * WebCore.gypi:
2942         * gyp/WebCore.gyp:
2943
2944 2011-03-05  Dan Bernstein  <mitz@apple.com>
2945
2946         Reviewed by Cameron Zwarich.
2947
2948         <rdar://problem/9082946> Make the Core Text code path in GlyphPage::fill() more robust
2949         https://bugs.webkit.org/show_bug.cgi?id=55817
2950
2951         * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
2952         (WebCore::GlyphPage::fill): When determining if a CTRun uses the primary font, compare against
2953         a CGFont obtained from Core Text for the primary font. This CGFont may be different from
2954         the CGFont stored in the FontPlatformData.
2955
2956 2011-03-05  Ilya Sherman  <isherman@chromium.org>
2957
2958         Reviewed by Darin Adler.
2959
2960         HTMLInputElement::setValue() should schedule change event when the element is focused.
2961         Refactored tracking of "changed since last change event" state from renderer to DOM.In service of https://code.google.com/p/chromium/issues
2962         In service of https://code.google.com/p/chromium/issues/detail?id=42716
2963         https://bugs.webkit.org/show_bug.cgi?id=53160
2964
2965         Test: fast/forms/onchange-change-type.html
2966         Test: fast/forms/onchange-setvalueforuser.html
2967
2968         * WebCore.exp.in:
2969         * dom/Document.cpp:
2970         (WebCore::Document::setFocusedNode):
2971         * dom/Element.h:
2972         (WebCore::Element::wasChangedSinceLastFormControlChangeEvent): Added.
2973         (WebCore::Element::setChangedSinceLastFormControlChangeEvent): Added.
2974         * html/HTMLFormControlElement.cpp:
2975         (WebCore::HTMLFormControlElement::HTMLFormControlElement):
2976         (WebCore::HTMLFormControlElement::wasChangedSinceLastFormControlChangeEvent): Added.
2977         (WebCore::HTMLFormControlElement::setChangedSinceLastFormControlChangeEvent): Added.
2978         (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): Also clear the "changed since last change event" flag.
2979         (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): Also set the "changed since last change event" flag.
2980         * html/HTMLFormControlElement.h:
2981         * html/HTMLInputElement.cpp:
2982         (WebCore::HTMLInputElement::updateType): Also clear the "changed since last change event" flag.
2983         (WebCore::HTMLInputElement::setValue):
2984             For a focused text field, dispatch an input event, but delay the change event until the field loses focus.
2985         (WebCore::HTMLInputElement::defaultEventHandler):
2986         (WebCore::HTMLInputElement::stepUpFromRenderer):
2987         * html/shadow/TextControlInnerElements.cpp:
2988         (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
2989         * rendering/RenderTextControl.cpp:
2990         (WebCore::RenderTextControl::RenderTextControl):
2991         (WebCore::RenderTextControl::subtreeHasChanged):
2992         * rendering/RenderTextControl.h:
2993         * rendering/RenderTextControlMultiLine.cpp:
2994         (WebCore::RenderTextControlMultiLine::subtreeHasChanged):
2995         * rendering/RenderTextControlSingleLine.cpp:
2996         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
2997         * wml/WMLInputElement.cpp:
2998         (WebCore::WMLInputElement::WMLInputElement):
2999         (WebCore::WMLInputElement::defaultEventHandler):
3000         * wml/WMLInputElement.h:
3001         (WebCore::WMLInputElement::wasChangedSinceLastFormControlChangeEvent): Added.
3002         (WebCore::WMLInputElement::setChangedSinceLastFormControlChangeEvent): Added.
3003
3004 2011-03-04  Xianzhu Wang  <wangxianzhu@google.com>
3005
3006         Reviewed by Adam Barth.
3007
3008         Remove fake request loading of SVGImage to avoid MainResourceLoader
3009         leak. The frame->init() already ensures initialization of the
3010         document loader.
3011
3012         https://bugs.webkit.org/show_bug.cgi?id=55017
3013
3014         Test: fast/images/svg-image-leak-loader.html
3015
3016         * svg/graphics/SVGImage.cpp:
3017         (WebCore::SVGImage::dataChanged):
3018
3019 2011-03-04  Mike Reed  <reed@google.com>
3020
3021         Reviewed by Mihai Parparita.
3022
3023         [Chromium] fast/canvas/canvas-arc-360-winding.html fails on Linux and Windows
3024         https://bugs.webkit.org/show_bug.cgi?id=49477
3025
3026         * platform/graphics/skia/PathSkia.cpp:
3027         (WebCore::Path::addArc):
3028
3029 2011-03-04  Jia Pu  <jpu@apple.com>
3030
3031         Reviewed by Darin Adler.
3032
3033         On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.
3034         https://bugs.webkit.org/show_bug.cgi?id=55717
3035         <rdar://problem/9018127>
3036
3037         manual-test: manual-tests/platforms/mac/autocorrection/autocorrection-in-iframe.html
3038
3039         Previously, the bounding box passed into EditorClient::showCorrectionPanel() is in the frame's
3040         coordinate. This is incorrect when the correction occurs in an iframe. This patch added code
3041         to convert the bounding box to window coordinate using ScrollView::contentToWindow().
3042
3043         * dom/Range.cpp:
3044         (WebCore::Range::getBoundingClientRect):
3045         (WebCore::Range::boundingRect):
3046         * dom/Range.h:
3047         * editing/Editor.cpp:
3048         (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
3049         (WebCore::Editor::correctionPanelTimerFired):
3050         (WebCore::Editor::windowRectForRange):
3051         * editing/Editor.h:
3052         * manual-tests/autocorrection/autocorrection-in-iframe.html: Added.
3053         * manual-tests/autocorrection/document-for-iframe-test.html: Added.
3054
3055 2011-03-04  Jia Pu  <jpu@apple.com>
3056
3057         Reviewed by Darin Adler.
3058
3059         Those checking in Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited() should be done with VisiblePosition::isNull().
3060         https://bugs.webkit.org/show_bug.cgi?id=55731
3061
3062         No new tests. There's no behavioral change.
3063
3064         This patch improved clarity and readability of Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited().
3065
3066         * editing/Editor.cpp:
3067         (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
3068
3069 2011-03-04  John Bauman  <jbauman@chromium.org>
3070
3071         Reviewed by Kenneth Russell.
3072
3073         [chromium] premultipliedAlpha WebGL context attribute is ignored.
3074         https://bugs.webkit.org/show_bug.cgi?id=55411
3075
3076         Update compositor to set the blending of each layer correctly.
3077
3078         Test: compositing/webgl/webgl-nonpremultiplied-blend.html
3079
3080         * platform/graphics/chromium/CanvasLayerChromium.cpp:
3081         (WebCore::CanvasLayerChromium::CanvasLayerChromium):
3082         (WebCore::CanvasLayerChromium::draw):
3083         * platform/graphics/chromium/CanvasLayerChromium.h:
3084         * platform/graphics/chromium/ContentLayerChromium.cpp:
3085         (WebCore::ContentLayerChromium::draw):
3086         * platform/graphics/chromium/LayerRendererChromium.cpp:
3087         (WebCore::LayerRendererChromium::drawLayers):
3088         * platform/graphics/chromium/WebGLLayerChromium.cpp:
3089         (WebCore::WebGLLayerChromium::setContext):
3090
3091 2011-03-04  Adam Barth  <abarth@webkit.org>
3092
3093         Reviewed by Eric Seidel.
3094
3095         WebCore GYP build should link with the correct frameworks
3096         https://bugs.webkit.org/show_bug.cgi?id=55804
3097
3098         * gyp/WebCore.gyp:
3099
3100 2011-03-04  Adam Barth  <abarth@webkit.org>
3101
3102         Reviewed by Eric Seidel.
3103
3104         WebCore GYP build should Check For Inappropriate Files in Framework
3105         https://bugs.webkit.org/show_bug.cgi?id=55806
3106
3107         * gyp/WebCore.gyp:
3108
3109 2011-03-04  Dimitri Glazkov  <dglazkov@chromium.org>
3110
3111         Reviewed by Adam Barth.
3112
3113         Add skeletal WebCore.gyp
3114         https://bugs.webkit.org/show_bug.cgi?id=55802
3115
3116         This doesn't yet build, but the basic structure is there.
3117
3118         * WebCore.gypi: Added headers and include directories variables.
3119         * gyp/WebCore.gyp: Added.
3120
3121 2011-03-04  Adam Barth  <abarth@webkit.org>
3122
3123         Reviewed by Dimitri Glazkov.
3124
3125         Remove unneeded round-trips through ../Source in the Chromium GYP build
3126         https://bugs.webkit.org/show_bug.cgi?id=55795
3127
3128         This is just cleanup work, but it was bugging me.
3129
3130         * WebCore.gyp/WebCore.gyp:
3131
3132 2011-03-04  Mike Reed  <reed@google.com>
3133
3134         Reviewed by James Robinson.
3135
3136         Option to use skia's native text drawing APIs when drawing text
3137         on Windows, rather than from outlines using drawPath(). This will
3138         only have a significant effect when the skia-gpu backend is enabled.
3139         https://bugs.webkit.org/show_bug.cgi?id=55609
3140
3141         No new tests. This is disabled by default. When enabled, it will draw
3142         essentially the same, but with slightly different antialiased edges, due
3143         to differences between the current scanconverter and GDI's font scaler.
3144         When enabled, we will have to recalibrate layouttest image results. 
3145
3146         * platform/graphics/skia/SkiaFontWin.cpp:
3147         (WebCore::skiaDrawText):
3148         (WebCore::setupPaintForFont):
3149         (WebCore::paintSkiaText):
3150
3151 2011-03-04  Adrienne Walker  <enne@google.com>
3152
3153         Reviewed by James Robinson.
3154
3155         [chromium] Fix texture stride issues on large content and image layers.
3156         https://bugs.webkit.org/show_bug.cgi?id=55679
3157
3158         This was an error caused during the refactoring in r80081.
3159
3160         Tests: LayoutTests/compositing/tiling/huge-layer-img.html
3161
3162         * platform/graphics/chromium/ContentLayerChromium.cpp:
3163         (WebCore::ContentLayerChromium::updateTexture):
3164         * platform/graphics/chromium/ImageLayerChromium.cpp:
3165         (WebCore::ImageLayerChromium::updateTextureIfNeeded):
3166
3167 2011-03-04  Sheriff Bot  <webkit.review.bot@gmail.com>
3168
3169         Unreviewed, rolling out r80379.
3170         http://trac.webkit.org/changeset/80379
3171         https://bugs.webkit.org/show_bug.cgi?id=55799
3172
3173         "Breaks leopard compile (implicit conversion)" (Requested by
3174         tonyg-cr on #webkit).
3175
3176         * css/CSSStyleSelector.cpp:
3177         (WebCore::convertToLength):
3178         (WebCore::CSSStyleSelector::applyProperty):
3179         (WebCore::CSSStyleSelector::createTransformOperations):
3180         * platform/Length.h:
3181         (WebCore::Length::Length):
3182         (WebCore::Length::operator==):
3183         (WebCore::Length::operator!=):
3184         (WebCore::Length::rawValue):
3185         (WebCore::Length::type):
3186         (WebCore::Length::quirk):
3187         (WebCore::Length::setValue):
3188         (WebCore::Length::setRawValue):
3189         (WebCore::Length::calcFloatValue):
3190         (WebCore::Length::isZero):
3191         (WebCore::Length::blend):
3192         * rendering/AutoTableLayout.cpp:
3193         (WebCore::AutoTableLayout::recalcColumn):
3194         (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
3195         * rendering/FixedTableLayout.cpp:
3196         (WebCore::FixedTableLayout::calcWidthArray):
3197
3198 2011-03-04  Jessie Berlin  <jberlin@apple.com>
3199
3200         Reviewed by Darin Adler.
3201
3202         WebKit2: Use CFNetwork Sessions API.
3203         https://bugs.webkit.org/show_bug.cgi?id=55435.
3204
3205         Add in the CFURLSTORAGESESSIONS guards that I incorrectly left out because the code was
3206         contained within guards that made USE(CFURLSTORAGESESSIONS) always be true.
3207
3208         * platform/network/cf/ResourceHandleCFNet.cpp:
3209         (WebCore::makeFinalRequest):
3210         (WebCore::ResourceHandle::willSendRequest):
3211         * platform/network/cf/ResourceRequestCFNet.cpp:
3212         * platform/network/mac/ResourceHandleMac.mm:
3213         (WebCore::ResourceHandle::createNSURLConnection):
3214         (WebCore::ResourceHandle::willSendRequest):
3215         * platform/network/mac/ResourceRequestMac.mm:
3216
3217 2011-03-04  Yuqiang Xian  <yuqiang.xian@intel.com>
3218
3219         Reviewed by Darin Adler.
3220
3221         improve layout performance by reducing the traversal time of the floating objects
3222         https://bugs.webkit.org/show_bug.cgi?id=55440
3223
3224         We observered large overhead on traversing the floating objects list
3225         in logicalLeftOffsetForLine() and logicalRightOffsetForLine() especially
3226         when the list becomes enormous, for example in the default 30x30 maze test
3227         from http://ie.microsoft.com/testdrive/Performance/MazeSolver/Default.html
3228         there're >3700 floating objects. When placing a new floating object the
3229         entire list (from begin to end) is traversed for multiple times.
3230         There's a low hanging fruit to reduce the chances to do the traversal
3231         which is especially applicable in logicalLeftOffsetForLine and logicalRightOffsetForLine.
3232         As the two routines either cares about FloatLeft objects or FloatRight objects only,
3233         if we know there's no corresponding type floating objects in the list
3234         we can avoid the traversal actually. One thing we could do is to record
3235         the number of FloatLeft objects and the number of FloatRight objects and
3236         add a check before doing the traversal. This can reduce the time by 45%
3237         to resolve the 30x30 Maze measured on N470 Netbook MeeGo using latest
3238         Chromium browser 11 (from 503s to 269s).
3239
3240         No new tests, relying on existing layout tests.
3241
3242         * rendering/RenderBlock.cpp:
3243         (WebCore::RenderBlock::~RenderBlock):
3244         (WebCore::RenderBlock::addOverflowFromFloats):
3245         (WebCore::RenderBlock::repaintOverhangingFloats):
3246         (WebCore::RenderBlock::paintFloats):
3247         (WebCore::RenderBlock::selectionGaps):
3248         (WebCore::RenderBlock::insertFloatingObject):
3249         (WebCore::RenderBlock::removeFloatingObject):
3250         (WebCore::RenderBlock::removeFloatingObjectsBelow):
3251         (WebCore::RenderBlock::positionNewFloats):
3252         (WebCore::RenderBlock::positionNewFloatOnLine):
3253         (WebCore::RenderBlock::logicalLeftOffsetForLine):
3254         (WebCore::RenderBlock::logicalRightOffsetForLine):
3255         (WebCore::RenderBlock::nextFloatLogicalBottomBelow):
3256         (WebCore::RenderBlock::lowestFloatLogicalBottom):
3257         (WebCore::RenderBlock::clearFloats):
3258         (WebCore::RenderBlock::addOverhangingFloats):
3259         (WebCore::RenderBlock::addIntrudingFloats):
3260         (WebCore::RenderBlock::containsFloat):
3261         (WebCore::RenderBlock::hitTestFloats):
3262         (WebCore::RenderBlock::adjustForBorderFit):
3263         (WebCore::RenderBlock::FloatingObjects::clear):
3264         (WebCore::RenderBlock::FloatingObjects::increaseObjectsCount):
3265         (WebCore::RenderBlock::FloatingObjects::decreaseObjectsCount):
3266         * rendering/RenderBlock.h:
3267         (WebCore::RenderBlock::containsFloats):
3268         (WebCore::RenderBlock::FloatingObjects::FloatingObjects):
3269         (WebCore::RenderBlock::FloatingObjects::hasLeftObjects):
3270         (WebCore::RenderBlock::FloatingObjects::hasRightObjects):
3271         (WebCore::RenderBlock::FloatingObjects::set):
3272         * rendering/RenderBlockLineLayout.cpp:
3273         (WebCore::RenderBlock::layoutInlineChildren):
3274         (WebCore::RenderBlock::matchedEndLine):
3275
3276 2011-03-04  Rik Cabanier  <cabanier@gmail.com>
3277
3278         Reviewed by David Hyatt.
3279
3280         Fix that allows fixed length values to be floating point
3281         https://bugs.webkit.org/show_bug.cgi?id=52699
3282
3283         * WebCore.xcodeproj/project.pbxproj:
3284         * css/CSSStyleSelector.cpp:
3285         (WebCore::convertToLength):
3286         (WebCore::convertToIntLength):
3287         (WebCore::convertToFloatLength):
3288         (WebCore::CSSStyleSelector::applyProperty):
3289         (WebCore::CSSStyleSelector::createTransformOperations):
3290         * platform/Length.h:
3291         (WebCore::Length::Length):
3292         (WebCore::Length::operator==):
3293         (WebCore::Length::operator!=):
3294         (WebCore::Length::rawValue):
3295         (WebCore::Length::type):
3296         (WebCore::Length::quirk):
3297         (WebCore::Length::setValue):
3298         (WebCore::Length::calcFloatValue):
3299         (WebCore::Length::isZero):
3300         (WebCore::Length::blend):
3301         (WebCore::Length::getIntValue):
3302         (WebCore::Length::getFloatValue):
3303         * rendering/AutoTableLayout.cpp:
3304         (WebCore::AutoTableLayout::recalcColumn):
3305         (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
3306         * rendering/FixedTableLayout.cpp:
3307         (WebCore::FixedTableLayout::calcWidthArray):
3308
3309 2011-03-04  Steve Falkenburg  <sfalken@apple.com>
3310
3311         Reviewed by Jon Honeycutt.
3312
3313         Adopt VersionStamper tool for Windows WebKit DLLs
3314         https://bugs.webkit.org/show_bug.cgi?id=55784
3315         
3316         We now use a tool to stamp the version number onto the Apple WebKit DLLs
3317         during the post-build step.
3318
3319         * WebCore.vcproj/QTMovieWin.rc: Removed.
3320         * WebCore.vcproj/QTMovieWin.vcproj:
3321         * WebCore.vcproj/QTMovieWinPostBuild.cmd: Stamp version with VersionStamper.
3322         * WebCore.vcproj/QTMovieWinPreBuild.cmd: Don't run auto-version.sh. We don't use autoversion.h in this project.
3323         * WebCore.vcproj/WebCoreMediaQT.vsprops: Remove unnecessary include paths for resource files.
3324
3325 2011-03-04  Cosmin Truta  <ctruta@chromium.org>
3326
3327         Reviewed by Adam Barth.
3328
3329         Clarify comment about potential memory leak in SVGImage
3330         https://bugs.webkit.org/show_bug.cgi?id=55362
3331
3332         No functionality change. No new tests.
3333
3334         * svg/graphics/SVGImage.cpp:
3335         (WebCore::SVGImage::dataChanged):
3336
3337 2011-03-04  Jessie Berlin  <jberlin@apple.com>
3338
3339         Reviewed by Maciej Stachowiak.
3340
3341         WebKit2: Use CFNetwork Sessions API.
3342         https://bugs.webkit.org/show_bug.cgi?id=55435.
3343
3344         When Private Browsing is enabled, get the cached url response from the cache associated with
3345         the Private Browsing Storage Session.
3346
3347         * WebCore.exp.in:
3348         Export the symbol for ResourceHandle::privateBrowsingStorageSession.
3349
3350 2011-03-04  Steve Block  <steveblock@google.com>
3351
3352         Reviewed by Jeremy Orlow.
3353
3354         JSC and V8 versions of Java bridge should share JobjectWrapper
3355         https://bugs.webkit.org/show_bug.cgi?id=55763
3356
3357         No new tests, refactoring only.
3358
3359         * Android.jscbindings.mk:
3360         * Android.v8bindings.mk:
3361         * WebCore.gypi:
3362         * WebCore.order:
3363         * WebCore.xcodeproj/project.pbxproj:
3364         * bridge/jni/JobjectWrapper.cpp:
3365         (JobjectWrapper::JobjectWrapper):
3366         (JobjectWrapper::~JobjectWrapper):
3367         * bridge/jni/JobjectWrapper.h:
3368         (JSC::Bindings::JobjectWrapper::instance):
3369         (JSC::Bindings::JobjectWrapper::setInstance):
3370         (JSC::Bindings::JobjectWrapper::ref):
3371         (JSC::Bindings::JobjectWrapper::deref):
3372         * bridge/jni/jsc/JNIBridgeJSC.cpp:
3373         (JavaField::JavaField):
3374         (JavaArray::JavaArray):
3375         * bridge/jni/jsc/JNIBridgeJSC.h:
3376         * bridge/jni/jsc/JavaInstanceJSC.cpp:
3377         (JavaInstance::JavaInstance):
3378         * bridge/jni/jsc/JavaInstanceJSC.h:
3379
3380 2011-03-04  Patrick Gansterer  <paroga@webkit.org>
3381
3382         Reviewed by Nikolas Zimmermann.
3383
3384         Move shared code into SVGStyledTransformableElement::svgAttributeChanged
3385         https://bugs.webkit.org/show_bug.cgi?id=55771
3386
3387         All sub classes of SVGStyledTransformableElement request a relayout
3388         the same way. So move that code into the common base class.
3389
3390         * svg/SVGCircleElement.cpp:
3391         (WebCore::SVGCircleElement::svgAttributeChanged):
3392         * svg/SVGEllipseElement.cpp:
3393         (WebCore::SVGEllipseElement::svgAttributeChanged):
3394         * svg/SVGForeignObjectElement.cpp:
3395         (WebCore::SVGForeignObjectElement::svgAttributeChanged):
3396         * svg/SVGGElement.cpp:
3397         (WebCore::SVGGElement::svgAttributeChanged):
3398         * svg/SVGImageElement.cpp:
3399         (WebCore::SVGImageElement::svgAttributeChanged):
3400         * svg/SVGLineElement.cpp:
3401         (WebCore::SVGLineElement::svgAttributeChanged):
3402         * svg/SVGPathElement.cpp:
3403         (WebCore::SVGPathElement::svgAttributeChanged):
3404         * svg/SVGPolyElement.cpp:
3405         (WebCore::SVGPolyElement::svgAttributeChanged):
3406         * svg/SVGRectElement.cpp:
3407         (WebCore::SVGRectElement::svgAttributeChanged):
3408         * svg/SVGStyledTransformableElement.cpp:
3409         (WebCore::SVGStyledTransformableElement::svgAttributeChanged):
3410         * svg/SVGStyledTransformableElement.h:
3411         * svg/SVGUseElement.cpp:
3412         (WebCore::SVGUseElement::svgAttributeChanged):
3413
3414 2011-03-03  John Abd-El-Malek  <jam@chromium.org>
3415
3416         Reviewed by Dimitri Glazkov.
3417
3418         [chromium] Get rid of IsContentFiltered flags since they&apos;re not used anymore
3419         https://bugs.webkit.org/show_bug.cgi?id=55748
3420
3421         * platform/network/chromium/ResourceResponse.cpp:
3422         (WebCore::ResourceResponse::doPlatformCopyData):
3423         (WebCore::ResourceResponse::doPlatformAdopt):
3424         * platform/network/chromium/ResourceResponse.h:
3425         (WebCore::ResourceResponse::ResourceResponse):
3426
3427 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3428
3429         Export SerializedScriptValue::create(JSC::ExecState* exec, JSC::JSValue value).
3430
3431         Reviewed by Darin Adler.
3432
3433         * WebCore.exp.in: Added __ZN7WebCore21SerializedScriptValue6createEPN3JSC9ExecStateENS1_7JSValueE.
3434
3435 2011-03-04  Pavel Podivilov  <podivilov@chromium.org>
3436
3437         Reviewed by Yury Semikhatsky.
3438
3439         Web Inspector: extract all code that depends on source mapping from SourceFrame.
3440         https://bugs.webkit.org/show_bug.cgi?id=55464
3441
3442         Extract all dependencies on DebuggerModel and ScriptsPanel to a delegate class
3443         to encapsulate source mapping aspects from SourceFrame.
3444
3445         * inspector/front-end/ResourceView.js:
3446         (WebInspector.ResourceView.createResourceView):
3447         (WebInspector.SourceFrameDelegateForResourcesPanel):
3448         (WebInspector.SourceFrameDelegateForResourcesPanel.prototype.requestContent):
3449         * inspector/front-end/ScriptsPanel.js:
3450         (WebInspector.ScriptsPanel.prototype._createSourceFrame):
3451         (WebInspector.SourceFrameDelegateForScriptsPanel):
3452         * inspector/front-end/SourceFrame.js:
3453         (WebInspector.SourceFrame):
3454         (WebInspector.SourceFrame.prototype.show):
3455         (WebInspector.SourceFrame.prototype._createTextViewer):
3456         (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
3457         (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint):
3458         (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
3459         (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition):
3460         (WebInspector.SourceFrame.prototype._contextMenu.else.setBreakpointEnabled):
3461         (WebInspector.SourceFrame.prototype._contextMenu):
3462         (WebInspector.SourceFrame.prototype._mouseDown):
3463         (WebInspector.SourceFrame.prototype._mouseMove):
3464         (WebInspector.SourceFrame.prototype._hidePopup):
3465         (WebInspector.SourceFrame.prototype._mouseHover):
3466         (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
3467         (WebInspector.SourceFrame.prototype._showPopup):
3468         (WebInspector.SourceFrame.prototype._doubleClick):
3469         (WebInspector.SourceFrame.prototype._didEditLine):
3470         (WebInspector.SourceFrameDelegate):
3471         (WebInspector.SourceFrameDelegate.prototype.requestContent):
3472         (WebInspector.SourceFrameDelegate.prototype.debuggingSupported):
3473         (WebInspector.SourceFrameDelegate.prototype.setBreakpoint):
3474         (WebInspector.SourceFrameDelegate.prototype.removeBreakpoint):
3475         (WebInspector.SourceFrameDelegate.prototype.updateBreakpoint):
3476         (WebInspector.SourceFrameDelegate.prototype.findBreakpoint):
3477         (WebInspector.SourceFrameDelegate.prototype.continueToLine):
3478         (WebInspector.SourceFrameDelegate.prototype.canEditScriptSource):
3479         (WebInspector.SourceFrameDelegate.prototype.editScriptSource):
3480         (WebInspector.SourceFrameDelegate.prototype.debuggerPaused):
3481         (WebInspector.SourceFrameDelegate.prototype.evaluate):
3482         (WebInspector.SourceFrameDelegate.prototype.releaseEvaluationResult):
3483
3484 2011-03-04  Andrey Kosyakov  <caseq@chromium.org>
3485
3486         Reviewed by Pavel Feldman.
3487
3488         Web Inspector: [Extensions API] maintain own, unique & persistent identifiers for resources.
3489         https://bugs.webkit.org/show_bug.cgi?id=55686
3490
3491         - Use internal ids for resources in extension server.
3492         - Log errors in inspector tests.
3493
3494         * inspector/front-end/ExtensionServer.js:
3495         (WebInspector.ExtensionServer):
3496         (WebInspector.ExtensionServer.prototype.resetResources):
3497         (WebInspector.ExtensionServer.prototype._notifyResourceFinished):
3498         (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
3499         (WebInspector.ExtensionServer.prototype._onGetHAR):
3500         (WebInspector.ExtensionServer.prototype._onGetResourceContent):
3501         (WebInspector.ExtensionServer.prototype._resourceId):
3502         (WebInspector.ExtensionServer.prototype._resourceById):
3503         * inspector/front-end/HAREntry.js:
3504         (WebInspector.HARLog):
3505         (WebInspector.HARLog.prototype._convertResource):
3506         * inspector/front-end/NetworkPanel.js:
3507         (WebInspector.NetworkPanel.prototype._reset):
3508
3509 2011-03-04  Andrey Kosyakov  <caseq@chromium.org>
3510
3511         Reviewed by Pavel Feldman.
3512
3513         Web Inspector: exceptions when building context menu in network panel
3514         https://bugs.webkit.org/show_bug.cgi?id=55678
3515
3516         * inspector/front-end/DataGrid.js:
3517         (WebInspector.DataGrid.prototype.dataGridNodeFromNode):
3518         (WebInspector.DataGrid.prototype.dataGridNodeFromPoint):
3519         * inspector/front-end/NetworkPanel.js:
3520         (WebInspector.NetworkPanel.prototype._contextMenu):
3521
3522 2011-03-04  Ilya Sherman  <isherman@chromium.org>
3523
3524         Reviewed by James Robinson.
3525
3526         Override paintScrollCorner() for FramelessScrollView to forego any custom scrollbar corner rendering.
3527         This was previously done in ScrollbarThemeChromium, but we also need this on the Mac when the ScrollView
3528         is a FramelessScrollView -- which is mostly just for Autofill.
3529         In service of http://crbug.com/73772 (crash)
3530         https://bugs.webkit.org/show_bug.cgi?id=55557
3531
3532         No tests added because this fix is Chromium-specific and the code is currently untestable from within WebKit.
3533         In particular, DRT crashes when trying to render a FramelessScrollView.
3534
3535         * platform/ScrollbarTheme.h:
3536         (WebCore::ScrollbarTheme::paintScrollCorner): Body moved to static function defaultPaintScrollCorner().
3537         (WebCore::ScrollbarTheme::defaultPaintScrollCorner): Added.
3538         * platform/chromium/FramelessScrollView.cpp:
3539         (WebCore::FramelessScrollView::paintContents):
3540         (WebCore::FramelessScrollView::paintScrollCorner): Fix implementation moved to here from ScrollbarThemeChromium
3541         * platform/chromium/FramelessScrollView.h:
3542         * platform/chromium/ScrollbarThemeChromium.cpp:
3543         * platform/chromium/ScrollbarThemeChromium.h:
3544
3545 2011-03-04  Yury Semikhatsky  <yurys@chromium.org>
3546
3547         Reviewed by Pavel Feldman.
3548
3549         Web Inspector: move dispatching of didCommitLoad to agents into InspectorInstrumentation
3550         https://bugs.webkit.org/show_bug.cgi?id=55770
3551
3552         * inspector/InspectorAgent.cpp:
3553         (WebCore::InspectorAgent::InspectorAgent):
3554         (WebCore::InspectorAgent::didCommitLoad):
3555         * inspector/InspectorCSSAgent.cpp:
3556         (WebCore::InspectorCSSAgent::InspectorCSSAgent):
3557         (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
3558         * inspector/InspectorCSSAgent.h:
3559         * inspector/InspectorDatabaseAgent.cpp:
3560         (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
3561         * inspector/InspectorInstrumentation.cpp:
3562         (WebCore::InspectorInstrumentation::didCommitLoadImpl):
3563         * inspector/InspectorInstrumentation.h:
3564         (WebCore::InspectorInstrumentation::didCommitLoad):
3565         * inspector/InspectorProfilerAgent.cpp:
3566         (WebCore::InspectorProfilerAgent::create):
3567         (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
3568         (WebCore::InspectorProfilerAgent::~InspectorProfilerAgent):
3569         (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
3570         (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
3571         (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
3572         (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
3573         * inspector/InspectorProfilerAgent.h:
3574         * inspector/InstrumentingAgents.h:
3575         (WebCore::InstrumentingAgents::InstrumentingAgents):
3576         (WebCore::InstrumentingAgents::inspectorCSSAgent):
3577         (WebCore::InstrumentingAgents::setInspectorCSSAgent):
3578         (WebCore::InstrumentingAgents::inspectorDOMStorageAgent):
3579         (WebCore::InstrumentingAgents::setInspectorDOMStorageAgent):
3580         (WebCore::InstrumentingAgents::inspectorDatabaseAgent):
3581         (WebCore::InstrumentingAgents::setInspectorDatabaseAgent):
3582         (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent):
3583         (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
3584         (WebCore::InstrumentingAgents::inspectorDebuggerAgent):
3585         (WebCore::InstrumentingAgents::setInspectorDebuggerAgent):
3586         (WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent):
3587         (WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent):
3588         (WebCore::InstrumentingAgents::inspectorProfilerAgent):
3589         (WebCore::InstrumentingAgents::setInspectorProfilerAgent):
3590
3591 2011-03-04  Ilya Tikhonovsky  <loislo@chromium.org>
3592
3593         Reviewed by Yury Semikhatsky.
3594
3595         Web Inspector: rename RuntimeAgent's function from releaseWrapperObjectGroup to releaseObjectGroup.
3596         https://bugs.webkit.org/show_bug.cgi?id=55773
3597
3598         * inspector/CodeGeneratorInspector.pm:
3599         * inspector/InjectedScript.cpp:
3600         (WebCore::InjectedScript::releaseObjectGroup):
3601         * inspector/InjectedScript.h:
3602         * inspector/InjectedScriptHost.cpp:
3603         (WebCore::InjectedScriptHost::releaseObjectGroup):
3604         * inspector/InjectedScriptHost.h:
3605         * inspector/InjectedScriptSource.js:
3606         (.):
3607         * inspector/Inspector.idl:
3608         * inspector/InspectorConsoleAgent.cpp:
3609         (WebCore::InspectorConsoleAgent::clearConsoleMessages):
3610         * inspector/InspectorRuntimeAgent.cpp:
3611         (WebCore::InspectorRuntimeAgent::releaseObjectGroup):
3612         * inspector/InspectorRuntimeAgent.h:
3613         * inspector/front-end/ConsoleView.js:
3614         (WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
3615         (WebInspector.ConsoleView.prototype.completions):
3616         * inspector/front-end/PropertiesSidebarPane.js:
3617         * inspector/front-end/SourceFrame.js:
3618         (WebInspector.SourceFrame.prototype._hidePopup):
3619         * inspector/front-end/WatchExpressionsSidebarPane.js:
3620         (WebInspector.WatchExpressionsSection.prototype.update):
3621
3622 2011-03-02  Andrey Adaikin  <aandrey@google.com>
3623
3624         Reviewed by Pavel Feldman.
3625
3626         Web Inspector: Gutter height should be 100% when few lines are displayed
3627         https://bugs.webkit.org/show_bug.cgi?id=55574
3628
3629         * inspector/front-end/SourceFrame.js:
3630         (WebInspector.SourceFrame.prototype._startEditing):
3631         * inspector/front-end/TextViewer.js:
3632         (WebInspector.TextViewer.prototype._syncScroll):
3633         (WebInspector.TextEditorGutterPanel.prototype._expandChunks):
3634         (WebInspector.TextEditorGutterPanel.prototype.textChanged):
3635         (WebInspector.TextEditorGutterPanel.prototype.syncClientHeight):
3636         * inspector/front-end/textViewer.css:
3637         (.text-editor-lines):
3638         (.text-editor-contents .inner-container):
3639         (.webkit-line-number):
3640
3641 2011-03-04  Andrey Adaikin  <aandrey@google.com>
3642
3643         Reviewed by Pavel Feldman.
3644
3645         Web Inspector: [Text editor] Do bisect to find visible chunks
3646         https://bugs.webkit.org/show_bug.cgi?id=55685
3647
3648         * inspector/front-end/TextViewer.js:
3649         (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine):
3650         (WebInspector.TextEditorChunkedPanel.prototype._findVisibleChunks):
3651         (WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
3652         (WebInspector.TextEditorGutterChunk.prototype.get offsetTop):
3653         (WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
3654         (WebInspector.TextEditorMainChunk.prototype.get offsetTop):
3655
3656 2011-03-04  Andrey Adaikin  <aandrey@google.com>
3657
3658         Reviewed by Pavel Feldman.
3659
3660         Web Inspector: [Text editor] DOMNodeRemoved events are missing
3661         https://bugs.webkit.org/show_bug.cgi?id=55769
3662
3663         * inspector/front-end/TextViewer.js:
3664         (WebInspector.TextEditorMainPanel):
3665         (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
3666         (WebInspector.TextEditorMainChunk):
3667         (WebInspector.TextEditorMainChunk.prototype._createRow):
3668
3669 2011-03-04  Ilya Tikhonovsky  <loislo@chromium.org>
3670
3671         Reviewed by Yury Semikhatsky.
3672
3673         Web Inspector: Remove unnecessary domain and success flags from the response messages.
3674         https://bugs.webkit.org/show_bug.cgi?id=55768
3675
3676         We have domain property in the response messages but it is not used because we dispatch
3677         the responses on the callback associated with seq.
3678
3679         If we have property 'errors' in the response then success eq false and true in the other case.
3680
3681         * inspector/CodeGeneratorInspector.pm:
3682
3683 2011-03-04  Christian Dywan  <christian@lanedo.com>
3684
3685         Reviewed by Gustavo Noronha Silva.
3686
3687         Enable Copy Image Address context menu item in the Gtk port
3688         https://bugs.webkit.org/show_bug.cgi?id=55136
3689
3690         * page/ContextMenuController.cpp:
3691         * platform/ContextMenuItem.h:
3692         * platform/LocalizationStrategy.h:
3693         * platform/LocalizedStrings.cpp:
3694         * platform/LocalizedStrings.h:
3695         * platform/gtk/ContextMenuItemGtk.cpp:
3696         * platform/gtk/LocalizedStringsGtk.cpp:
3697
3698 2011-03-04  Pavel Feldman  <pfeldman@chromium.org>
3699
3700         Reviewed by Yury Semikhatsky.
3701
3702         Web Inspector: implement getCompletions via evaluate.
3703         https://bugs.webkit.org/show_bug.cgi?id=55759
3704
3705         * inspector/InjectedScript.cpp:
3706         * inspector/InjectedScript.h:
3707         * inspector/InjectedScriptSource.js:
3708         * inspector/Inspector.idl:
3709         * inspector/InspectorDebuggerAgent.cpp:
3710         * inspector/InspectorDebuggerAgent.h:
3711         * inspector/InspectorRuntimeAgent.cpp:
3712         * inspector/InspectorRuntimeAgent.h:
3713         * inspector/front-end/ConsoleView.js:
3714         (WebInspector.ConsoleView.prototype.completions.evaluated):
3715         (WebInspector.ConsoleView.prototype.completions.evaluatedProperties):
3716         (WebInspector.ConsoleView.prototype.completions):
3717         (WebInspector.ConsoleView.prototype._reportCompletions):
3718         * inspector/front-end/ScriptsPanel.js:
3719         (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper):
3720         (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
3721         * inspector/front-end/SourceFrame.js:
3722         (WebInspector.SourceFrame.prototype._showPopup):
3723         (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
3724
3725 2011-03-04  Steve Block  <steveblock@google.com>
3726
3727         Reviewed by Jeremy Orlow.
3728
3729         V8 version of JavaString should obtain string from JNI in UTF-16 encoding
3730         https://bugs.webkit.org/show_bug.cgi?id=55566
3731
3732         We obtain the string from JNI in UTF-16 encoding and convert
3733         to UTF-8 using our own routines as required. This matches the
3734         behaviour of the JSC version of JavaString.
3735
3736         No new tests, no change in behaviour.
3737
3738         * bridge/jni/v8/JavaStringV8.h:
3739         (JSC::Bindings::JavaStringImpl::init):
3740         (JSC::Bindings::JavaStringImpl::utf8):
3741         (JSC::Bindings::JavaStringImpl::impl):
3742
3743 2011-03-03  Pavel Feldman  <pfeldman@chromium.org>
3744
3745         Reviewed by Yury Semikhatsky.
3746
3747         Web Inspector: do not push document into front-end, make it request one.
3748         https://bugs.webkit.org/show_bug.cgi?id=55664
3749
3750         * inspector/Inspector.idl:
3751         * inspector/InspectorAgent.cpp:
3752         (WebCore::InspectorAgent::InspectorAgent):
3753         * inspector/InspectorAgent.h:
3754         * inspector/InspectorBrowserDebuggerAgent.cpp:
3755         (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
3756         * inspector/InspectorDOMAgent.cpp:
3757         (WebCore::InspectorDOMAgent::InspectorDOMAgent):
3758         (WebCore::InspectorDOMAgent::clearFrontend):
3759         (WebCore::InspectorDOMAgent::setDocument):
3760         (WebCore::InspectorDOMAgent::getDocument):
3761         (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
3762         (WebCore::InspectorDOMAgent::boundNodeId):
3763         (WebCore::InspectorDOMAgent::resolveNode):
3764         (WebCore::InspectorDOMAgent::mainFrameDOMContentLoaded):
3765         * inspector/InspectorDOMAgent.h:
3766         (WebCore::InspectorDOMAgent::create):
3767         * inspector/front-end/BreakpointManager.js:
3768         (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints):
3769         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement.decorateNode):
3770         (WebInspector.DOMBreakpointView.prototype.populateStatusMessageElement):
3771         * inspector/front-end/DOMAgent.js:
3772         (WebInspector.DOMDocument):
3773         (WebInspector.DOMAgent):
3774         (WebInspector.DOMAgent.prototype.requestDocument):
3775         (WebInspector.DOMAgent.prototype.pushNodeToFrontend):
3776         (WebInspector.DOMAgent.prototype.pushNodeByPathToFrontend):
3777         (WebInspector.DOMAgent.prototype._attributesUpdated):
3778         (WebInspector.DOMAgent.prototype._characterDataModified):
3779         (WebInspector.DOMAgent.prototype._documentUpdated):
3780         (WebInspector.DOMAgent.prototype._setDocument):
3781         (WebInspector.DOMAgent.prototype._setDetachedRoot):
3782         (WebInspector.DOMAgent.prototype._setChildNodes):
3783         (WebInspector.DOMAgent.prototype._childNodeInserted):
3784         (WebInspector.DOMAgent.prototype._childNodeRemoved):
3785         (WebInspector.DOMDispatcher.prototype.documentUpdated):
3786         * inspector/front-end/ElementsPanel.js:
3787         (WebInspector.ElementsPanel.prototype.show):
3788         (WebInspector.ElementsPanel.prototype.setDocument):
3789         * inspector/front-end/MetricsSidebarPane.js:
3790         * inspector/front-end/RemoteObject.js:
3791         (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
3792
3793 2011-03-04  Andrey Kosyakov  <caseq@chromium.org>
3794
3795         Reviewed by Pavel Feldman.
3796
3797         Web Inspector: summary bar may overlap content of the network item view
3798         https://bugs.webkit.org/show_bug.cgi?id=55656
3799
3800         - drop custom summary bar placement logic, do it with CSS instead.
3801
3802         * inspector/front-end/NetworkPanel.js:
3803         (WebInspector.NetworkPanel.prototype.resize):
3804         (WebInspector.NetworkPanel.prototype._createSummaryBar):
3805         (WebInspector.NetworkPanel.prototype._updateSummaryBar):
3806         (WebInspector.NetworkPanel.prototype._updateFilter):
3807         (WebInspector.NetworkPanel.prototype.show):
3808         (WebInspector.NetworkPanel.prototype.refresh):
3809         (WebInspector.NetworkPanel.prototype._reset):
3810         (WebInspector.NetworkPanel.prototype._setLargerResources):
3811         (WebInspector.NetworkPanel.prototype._updateOffscreenRows):
3812         * inspector/front-end/networkPanel.css:
3813         (.network-sidebar .data-grid td):
3814         (.network-sidebar tr.filler td):
3815         (.network-summary-bar):
3816         (.network-sidebar .data-grid .network-summary-bar td):
3817         (.network-summary-bar img):
3818
3819 2011-03-04  James Su <suzhe@chromium.org>
3820
3821         Reviewed by Dimitri Glazkov.
3822
3823         [Chromium] keycode is always 0 when using non-Latin keyboard layout.
3824         https://bugs.webkit.org/show_bug.cgi?id=54939
3825
3826         Add KeyEventCocoa.{h,mm}, so that we can reuse them in chromium.
3827
3828         No intended functionality change.
3829
3830         * WebCore.gyp/WebCore.gyp:
3831         * WebCore.gypi:
3832
3833 2011-03-04  Patrick Gansterer  <paroga@webkit.org>
3834
3835         Unreviewed EFL build fix for r80324.
3836
3837         * platform/efl/RenderThemeEfl.cpp:
3838         (WebCore::RenderThemeEfl::paintThemePart):
3839
3840 2011-03-04  Patrick Gansterer  <paroga@webkit.org>
3841
3842         Unreviewed EFL build fix for r80324.
3843
3844         * platform/efl/RenderThemeEfl.cpp:
3845         (WebCore::RenderThemeEfl::paintThemePart):
3846
3847 2011-03-03  Yury Semikhatsky  <yurys@chromium.org>
3848
3849         Reviewed by Pavel Feldman.
3850
3851         Web Inspector: AppCache agent should have same lifetime as InspectorAgent
3852         https://bugs.webkit.org/show_bug.cgi?id=55673
3853
3854         * inspector/InspectorAgent.cpp:
3855         (WebCore::InspectorAgent::InspectorAgent):
3856         (WebCore::InspectorAgent::setFrontend):
3857         (WebCore::InspectorAgent::disconnectFrontend):
3858         (WebCore::InspectorAgent::createFrontendLifetimeAgents):
3859         (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
3860         (WebCore::InspectorAgent::didCommitLoad):
3861         * inspector/InspectorApplicationCacheAgent.cpp:
3862         (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
3863         (WebCore::InspectorApplicationCacheAgent::setFrontend):
3864         (WebCore::InspectorApplicationCacheAgent::clearFrontend):
3865         * inspector/InspectorApplicationCacheAgent.h:
3866         * inspector/InspectorInstrumentation.cpp:
3867         (WebCore::InspectorInstrumentation::networkStateChangedImpl):
3868         (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
3869         * inspector/InstrumentingAgents.h:
3870         (WebCore::InstrumentingAgents::inspectorApplicationCacheAgent):
3871         (WebCore::InstrumentingAgents::setInspectorApplicationCacheAgent):
3872
3873 2011-03-03  Brian Weinstein  <bweinstein@apple.com>
3874
3875         Reviewed by Adam Roben.
3876
3877         Cleanup from https://bugs.webkit.org/show_bug.cgi?id=55427.
3878         
3879         Call WebCore::startObservingCookieChanges and WebCore::stopObservingCookieChanges
3880         on all platforms, and stub the functions on platforms that don't implement them.
3881         
3882         Add startObservingCookieChanges and stopObservingCookieChanges to TemporaryLinkStubs
3883         for platforms that don't implement them.
3884
3885         * platform/android/TemporaryLinkStubs.cpp:
3886         * platform/brew/TemporaryLinkStubs.cpp:
3887         * platform/chromium/TemporaryLinkStubs.cpp:
3888         * platform/efl/TemporaryLinkStubs.cpp:
3889         * platform/gtk/TemporaryLinkStubs.cpp:
3890         * platform/haiku/TemporaryLinkStubs.cpp:
3891         * platform/qt/TemporaryLinkStubsQt.cpp:
3892         * platform/win/TemporaryLinkStubs.cpp:
3893
3894 2011-03-03  Eric Seidel  <eric@webkit.org>
3895
3896         Reviewed by Dimitri Glazkov.
3897
3898         Refactor createRendererIfNeeded to avoid premature nextRenderer calculation
3899         https://bugs.webkit.org/show_bug.cgi?id=55720
3900
3901         There are two thing going on here:
3902         1. Delaying nextRenderer calculation until we actually use it,
3903            previously we would always compute nextRenderer (expensive!)
3904            even if no renderer insertion was to occur.
3905         2. Fix fullscreen elements to be inserted into the right place
3906            in the rendering tree.  Previously they would always be the last
3907            child in their parent's list, even if that wasn't the right place.
3908
3909         I don't know of any way to trigger the fullscreen bug,
3910         but I tested this with peacekeeper and saw no performance change.
3911
3912         Peacekeeper's domJQueryBasics is now possibly as much as 2% faster
3913         but I don't really trust the stability of peacekeeper to begin with.
3914
3915         This paves the way for further improvement in our nextRenderer calculation.
3916
3917         * dom/Node.cpp:
3918         (WebCore::Node::attach):
3919         (WebCore::Node::previousRenderer):
3920         (WebCore::Node::nextRenderer):
3921         (WebCore::Node::createRendererAndStyle):
3922         (WebCore::wrapWithRenderFullScreen):
3923         (WebCore::Node::createRendererIfNeeded):
3924         * dom/Node.h:
3925
3926 2011-03-03  Ryosuke Niwa  <rniwa@webkit.org>
3927
3928         Reviewed by Darin Adler.
3929
3930         Remove LOOSE_PASS_OWN_ARRAY_PTR from PassOwnArrayPtr.h
3931         https://bugs.webkit.org/show_bug.cgi?id=55554
3932
3933         * platform/Length.cpp:
3934         (WebCore::newLengthArray): Pass nullptr instead of 0.
3935
3936 2011-03-03  Nat Duca  <nduca@chromium.org>
3937
3938         Reviewed by James Robinson.
3939
3940         [chromium] Create a LayerChromium layerTreeAsText. Add HUD to
3941         LayerRendererChromium that draws compositor FPS and, optionally,
3942         the layer tree.
3943         https://bugs.webkit.org/show_bug.cgi?id=54710
3944
3945         * WebCore.gypi:
3946         * platform/graphics/chromium/Canvas2DLayerChromium.h:
3947         (WebCore::Canvas2DLayerChromium::drawsContent):
3948         * platform/graphics/chromium/CanvasLayerChromium.h:
3949         (WebCore::CanvasLayerChromium::layerTypeAsString):
3950         * platform/graphics/chromium/ContentLayerChromium.cpp:
3951         (WebCore::writeIndent):
3952         (WebCore::ContentLayerChromium::dumpLayerProperties):
3953         * platform/graphics/chromium/ContentLayerChromium.h:
3954         (WebCore::ContentLayerChromium::drawsContent):
3955         (WebCore::ContentLayerChromium::layerTypeAsString):
3956         * platform/graphics/chromium/GraphicsLayerChromium.cpp:
3957         (WebCore::GraphicsLayerChromium::setName):
3958         (WebCore::GraphicsLayerChromium::updateNames):
3959         (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
3960         (WebCore::GraphicsLayerChromium::setupContentsLayer):
3961         * platform/graphics/chromium/GraphicsLayerChromium.h:
3962         * platform/graphics/chromium/ImageLayerChromium.h:
3963         (WebCore::ImageLayerChromium::drawsContent):
3964         (WebCore::ImageLayerChromium::layerTypeAsString):
3965         * platform/graphics/chromium/LayerChromium.cpp:
3966         (WebCore::LayerChromium::LayerChromium):
3967         (WebCore::LayerChromium::setName):
3968         (WebCore::LayerChromium::layerTreeAsText):
3969         (WebCore::writeIndent):
3970         (WebCore::LayerChromium::dumpLayer):
3971         (WebCore::LayerChromium::dumpLayerProperties):
3972         * platform/graphics/chromium/LayerChromium.h:
3973         (WebCore::LayerChromium::name):
3974         (WebCore::LayerChromium::drawsContent):
3975         (WebCore::LayerChromium::debugID):
3976         (WebCore::LayerChromium::layerTypeAsString):
3977         * platform/graphics/chromium/LayerRendererChromium.cpp:
3978         (WebCore::LayerRendererChromium::LayerRendererChromium):
3979         (WebCore::LayerRendererChromium::~LayerRendererChromium):
3980         (WebCore::LayerRendererChromium::drawLayers):
3981         (WebCore::LayerRendererChromium::present):
3982         (WebCore::LayerRendererChromium::layerTreeAsText):
3983         (WebCore::LayerRendererChromium::dumpRenderSurfaces):
3984         * platform/graphics/chromium/LayerRendererChromium.h:
3985         (WebCore::LayerRendererChromium::getHeadsUpDisplay):
3986         (WebCore::LayerRendererChromium::rootVisibleRect):
3987         * platform/graphics/chromium/PluginLayerChromium.h:
3988         (WebCore::PluginLayerChromium::drawsContent):
3989         (WebCore::PluginLayerChromium::layerTypeAsString):
3990         * platform/graphics/chromium/RenderSurfaceChromium.cpp:
3991         (WebCore::RenderSurfaceChromium::name):
3992         (WebCore::writeIndent):
3993         (WebCore::RenderSurfaceChromium::dumpSurface):
3994         * platform/graphics/chromium/RenderSurfaceChromium.h:
3995         * platform/graphics/chromium/VideoLayerChromium.h:
3996         (WebCore::VideoLayerChromium::drawsContent):
3997         (WebCore::VideoLayerChromium::layerTypeAsString):
3998         * platform/graphics/chromium/WebGLLayerChromium.h:
3999         (WebCore::WebGLLayerChromium::drawsContent):
4000         (WebCore::WebGLLayerChromium::layerTypeAsString):
4001         * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: Added.
4002         (WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
4003         (WebCore::CCHeadsUpDisplay::~CCHeadsUpDisplay):
4004         (WebCore::CCHeadsUpDisplay::draw):
4005         (WebCore::CCHeadsUpDisplay::drawHudContents):
4006         (WebCore::CCHeadsUpDisplay::onPresent):
4007         * platform/graphics/chromium/cc/CCHeadsUpDisplay.h: Added.
4008         (WebCore::CCHeadsUpDisplay::setShowFPSCounter):
4009         (WebCore::CCHeadsUpDisplay::showFPSCounter):
4010         (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
4011         (WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
4012         (WebCore::CCHeadsUpDisplay::enabled):
4013         * platform/graphics/chromium/cc/CCLayerImpl.cpp:
4014         (WebCore::CCLayerImpl::CCLayerImpl):
4015         (WebCore::writeIndent):
4016         (WebCore::CCLayerImpl::dumpLayerProperties):
4017         * platform/graphics/chromium/cc/CCLayerImpl.h:
4018         (WebCore::CCLayerImpl::debugID):
4019         (WebCore::CCLayerImpl::setName):
4020         (WebCore::CCLayerImpl::name):
4021
4022 2011-03-02  Ojan Vafai  <ojan@chromium.org>
4023
4024         Reviewed by Darin Adler.
4025
4026         crash in adoptNode with mutation events
4027         https://bugs.webkit.org/show_bug.cgi?id=50046
4028
4029         If the DOM is modified during the removeChild call in adoptNode,
4030         then the setDocument call that follows can leave the DOM in an
4031         inconsistent state.
4032
4033         * dom/Document.cpp:
4034         (WebCore::Document::adoptNode):
4035
4036 2011-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
4037
4038         Reviewed by Darin Adler.
4039
4040         Add audio tag tests to the media controls manual test suite.
4041         https://bugs.webkit.org/show_bug.cgi?id=55722
4042
4043         * manual-tests/media-controls.html: Added 4 audio tests.
4044
4045 2011-03-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4046
4047         Reviewed by Eric Seidel.
4048
4049         [EFL] Adjust functions of RenderThemeEfl.cpp to WebKit parameter style
4050         https://bugs.webkit.org/show_bug.cgi?id=54392
4051
4052         Functions of RenderThemeEfl.cpp adhere efl coding style instead of WebKit coding style.
4053         WebCore's functions should adhere WebKit coding style.
4054
4055         * platform/efl/RenderThemeEfl.cpp:
4056         (WebCore::RenderThemeEfl::themePartCacheEntryReset):
4057         (WebCore::RenderThemeEfl::themePartCacheEntrySurfaceCreate):
4058         (WebCore::RenderThemeEfl::cacheThemePartNew):
4059         (WebCore::RenderThemeEfl::cacheThemePartReset):
4060         (WebCore::RenderThemeEfl::cacheThemePartResizeAndReset):
4061         (WebCore::RenderThemeEfl::cacheThemePartGet):
4062         (WebCore::RenderThemeEfl::cacheThemePartFlush):
4063         (WebCore::RenderThemeEfl::applyEdjeStateFromForm):
4064         (WebCore::RenderThemeEfl::paintThemePart):
4065         (WebCore::renderThemeEflColorClassSelectionActive):
4066         (WebCore::renderThemeEflColorClassSelectionInactive):
4067         (WebCore::renderThemeEflColorClassFocusRing):
4068         (WebCore::renderThemeEflColorClassButtonText):
4069         (WebCore::renderThemeEflColorClassComboText):
4070         (WebCore::renderThemeEflColorClassEntryText):
4071         (WebCore::renderThemeEflColorClassSearchText):
4072         (WebCore::RenderThemeEfl::applyPartDescription):
4073         (WebCore::RenderThemeEfl::applyPartDescriptions):
4074         (WebCore::RenderThemeEfl::controlSupportsTints):
4075         (WebCore::RenderThemeEfl::baselinePosition):
4076         (WebCore::RenderThemeEfl::paintSliderTrack):
4077         (WebCore::RenderThemeEfl::adjustSliderTrackStyle):
4078         (WebCore::RenderThemeEfl::adjustSliderThumbStyle):
4079         (WebCore::RenderThemeEfl::paintSliderThumb):
4080         (WebCore::RenderThemeEfl::adjustCheckboxStyle):
4081         (WebCore::RenderThemeEfl::paintCheckbox):
4082         (WebCore::RenderThemeEfl::adjustRadioStyle):
4083         (WebCore::RenderThemeEfl::paintRadio):
4084         (WebCore::RenderThemeEfl::adjustButtonStyle):
4085         (WebCore::RenderThemeEfl::paintButton):
4086         (WebCore::RenderThemeEfl::adjustMenuListStyle):
4087         (WebCore::RenderThemeEfl::paintMenuList):
4088         (WebCore::RenderThemeEfl::adjustTextFieldStyle):
4089         (WebCore::RenderThemeEfl::paintTextField):
4090         (WebCore::RenderThemeEfl::adjustTextAreaStyle):
4091         (WebCore::RenderThemeEfl::paintTextArea):
4092         (WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
4093         (WebCore::RenderThemeEfl::paintSearchFieldDecoration):
4094         (WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
4095         (WebCore::RenderThemeEfl::paintSearchFieldResultsButton):
4096         (WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle):
4097         (WebCore::RenderThemeEfl::paintSearchFieldResultsDecoration):
4098         (WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
4099         (WebCore::RenderThemeEfl::paintSearchFieldCancelButton):
4100         (WebCore::RenderThemeEfl::adjustSearchFieldStyle):
4101         (WebCore::RenderThemeEfl::paintSearchField):
4102         (WebCore::RenderThemeEfl::adjustProgressBarStyle):
4103         (WebCore::RenderThemeEfl::paintProgressBar):
4104         (WebCore::RenderThemeEfl::paintMediaFullscreenButton):
4105         (WebCore::RenderThemeEfl::paintMediaMuteButton):
4106         (WebCore::RenderThemeEfl::paintMediaPlayButton):
4107         (WebCore::RenderThemeEfl::paintMediaSeekBackButton):
4108         (WebCore::RenderThemeEfl::paintMediaSeekForwardButton):
4109         (WebCore::RenderThemeEfl::paintMediaSliderTrack):
4110         (WebCore::RenderThemeEfl::paintMediaSliderThumb):
4111         (WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer):
4112         (WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack):
4113         (WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb):
4114         (WebCore::RenderThemeEfl::paintMediaCurrentTime):
4115
4116 2011-03-03  Andy Estes  <aestes@apple.com>
4117