1 2021-10-20 Carlos Garcia Campos <cgarcia@igalia.com>
3 [WPE] Reenable -fvisibility=hidden and -fvisibility-inlines-hidden
4 https://bugs.webkit.org/show_bug.cgi?id=222860
6 Reviewed by Don Olmstead.
8 * Source/cmake/OptionsWPE.cmake:
10 2021-10-19 Ross Kirsling <ross.kirsling@sony.com>
12 [CMake] Align OptionsMac with Xcode build
13 https://bugs.webkit.org/show_bug.cgi?id=231982
15 Reviewed by Don Olmstead.
17 * Source/cmake/OptionsMac.cmake:
18 Ensure that the listed options (1) are not redundant with the defaults in WebKitFeatures.cmake and
19 (2) match the options for the Xcode build as closely as possible.
21 * Source/cmake/WebKitFeatures.cmake:
22 Remove an outdated feature, ENABLE_APPLE_PAY_SESSION_V9,
23 and let ENABLE_MAC_GESTURE_EVENTS be handled by PlatformEnable, since it depends on USE_APPLE_INTERNAL_SDK.
25 2021-10-19 Tyler Wilcock <tyler_w@apple.com>
27 Add AX team GitHub usernames to contributors.json
28 https://bugs.webkit.org/show_bug.cgi?id=231966
30 Reviewed by Chris Fleizach.
32 * metadata/contributors.json:
33 Add Chris Fleizach's and Andres Gonzalez's GitHub usernames. Add Tyler
34 Wilcock as a contributor. Run validate-committer-lists --canonicalize
35 to fix some style issues.
37 2021-10-19 Sergio Villar Senin <svillar@igalia.com>
39 Add my github username to contributors.json
43 * metadata/contributors.json:
45 2021-10-18 Ms2ger <Ms2ger@igalia.com>
47 Add my github username to contributors.json
48 https://bugs.webkit.org/show_bug.cgi?id=231893
52 * metadata/contributors.json:
54 2021-10-18 Rob Buis <rbuis@igalia.com>
56 Add my github username to contributors.json
57 https://bugs.webkit.org/show_bug.cgi?id=231889
59 Reviewed by Manuel Rego Casasnovas.
61 * metadata/contributors.json:
63 2021-10-18 Xan Lopez <xan@igalia.com>
65 Add my github username to contributors.json
66 https://bugs.webkit.org/show_bug.cgi?id=231887
70 * metadata/contributors.json: add my github username.
72 2021-10-18 Miguel Gomez <magomez@igalia.com>
74 Add my github username to contributors.json
78 * metadata/contributors.json:
80 2021-10-16 Tetsuharu Ohzeki <tetsuharu.ohzeki@gmail.com>
82 Add github username for tetsuharuohzeki to contributors.json
83 https://bugs.webkit.org/show_bug.cgi?id=231864
85 Reviewed by Fujii Hironori.
87 * metadata/contributors.json:
89 2021-10-16 Angelos Oikonomopoulos <angelos@igalia.com>
91 Add my github username to contributors.json
92 https://bugs.webkit.org/show_bug.cgi?id=231861
96 * metadata/contributors.json:
98 2021-10-16 Caitlin Potter <caitp@igalia.com>
100 Add github username for myself
101 https://bugs.webkit.org/show_bug.cgi?id=231857
103 Reviewed by Yusuke Suzuki.
105 * metadata/contributors.json:
107 2021-10-15 Basuke Suzuki <basuke.suzuki@sony.com>
109 Add flag to turn off Iso heap
110 https://bugs.webkit.org/show_bug.cgi?id=231823
112 Reviewed by Yusuke Suzuki.
114 Added USE_ISO_MALLOC feature flags which is on by default for most platforms.
116 * Source/cmake/OptionsPlayStation.cmake:
117 * Source/cmake/WebKitFeatures.cmake:
119 2021-10-15 Ross Kirsling <ross.kirsling@sony.com>
121 Realize Mac CMake build of WebCore and WebKit
122 https://bugs.webkit.org/show_bug.cgi?id=231749
124 Reviewed by Alex Christensen.
126 * Source/cmake/OptionsMac.cmake:
127 * Source/cmake/WebKitMacros.cmake:
129 2021-10-15 Jonathan Bedard <jbedard@apple.com>
131 Add github username for Dewei Zhu
135 * metadata/contributors.json:
137 2021-10-15 Andres Gonzalez <andresg_22@apple.com>
139 Change Andres Gonzalez status to reviewer.
140 https://bugs.webkit.org/show_bug.cgi?id=231738
142 Reviewed by Chris Fleizach.
144 * metadata/contributors.json:
146 2021-10-15 Carlos Garcia Campos <cgarcia@igalia.com>
148 Unreviewed. Fix GTK build with ubuntu 18.04
150 GLib version bump in r284152 was too high for ubuntu 18.04 even though it followed our dependencies policy.
152 * Source/cmake/OptionsGTK.cmake:
153 * Source/cmake/OptionsWPE.cmake:
155 2021-10-14 Ali Juma <ajuma@chromium.org>
157 Add my GitHub username to contributors.json
161 * metadata/contributors.json:
163 2021-10-14 Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
165 Add my GitHub username to contributors.json
169 * metadata/contributors.json:
171 2021-10-14 Commit Queue <commit-queue@webkit.org>
173 Unreviewed, reverting r283878.
174 https://bugs.webkit.org/show_bug.cgi?id=231735
180 "[WPE] Reenable -fvisibility=hidden and -fvisibility-inlines-
182 https://bugs.webkit.org/show_bug.cgi?id=222860
183 https://commits.webkit.org/r283878
185 2021-10-14 Carlos Garcia Campos <cgarcia@igalia.com>
187 [GTK][WPE] Bump GLib version to 2.58.3
188 https://bugs.webkit.org/show_bug.cgi?id=231726
190 Reviewed by Philippe Normand.
192 * Source/cmake/OptionsGTK.cmake:
193 * Source/cmake/OptionsWPE.cmake:
195 2021-10-14 Enrique Ocaña González <eocanha@igalia.com>
197 [contributors.json] Add eocanha github account and canonicalize
198 https://bugs.webkit.org/show_bug.cgi?id=231729
202 Added eocanha github user to contributors.json and canonicalize the file to make the style checker happy.
204 * metadata/contributors.json:
206 2021-10-13 Tim Horton <timothy_horton@apple.com>
208 Add my GitHub username to contributors.json
212 * metadata/contributors.json:
214 2021-10-13 Carlos Garcia Campos <cgarcia@igalia.com>
216 Add my github username to contributors.json
220 * metadata/contributors.json:
222 2021-10-12 Alex Christensen <achristensen@webkit.org>
224 Add webpushd executable
225 https://bugs.webkit.org/show_bug.cgi?id=231650
227 Reviewed by Brady Eidson.
229 * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
231 2021-10-12 Basuke Suzuki <basuke.suzuki@sony.com>
233 [PlayStation] Enable RemoteInspector by default
234 https://bugs.webkit.org/show_bug.cgi?id=231599
236 Reviewed by Fujii Hironori.
238 It was treated as experimental feature but we've depended on this feature in various situation.
240 * Source/cmake/OptionsPlayStation.cmake:
242 2021-10-12 Philippe Normand <pnormand@igalia.com>
244 Add my github username to contributors.json
248 * metadata/contributors.json:
250 2021-10-11 Patrick Griffis <pgriffis@igalia.com>
252 Add my github username to contributors.json
256 * metadata/contributors.json:
258 2021-10-11 Sam Weinig <weinig@apple.com>
260 Add my github username and keep my expertise where it is because, while not up to date, it is fun
264 * metadata/contributors.json:
266 2021-10-11 Theresa O'Connor <hober@apple.com>
268 Various updates to my contributors.json entry.
272 * metadata/contributors.json:
274 2021-10-11 Devin Rousso <drousso@apple.com>
276 Add my github and update my expertise
280 * metadata/contributors.json:
282 2021-10-10 Noam Rosenthal <noam@webkit.org>
284 Add my github username to contributors.json
288 * metadata/contributors.json:
290 2021-10-11 Emilio Cobos Álvarez <emilio@crisal.io>
292 Add my GitHub username to contributors.json.
293 https://bugs.webkit.org/show_bug.cgi?id=231507
297 * metadata/contributors.json:
299 2021-10-11 Claudio Saavedra <csaavedra@igalia.com>
301 Add my github username to contributors.json
305 * metadata/contributors.json:
307 2021-10-11 Diego Pino Garcia <dpino@igalia.com>
309 Add GitHub username for Diego Pino Garcia
313 * metadata/contributors.json:
315 2021-10-10 Pablo Saavedra <psaavedra@igalia.com>
317 Add GitHub username for Pablo Saavedra
321 * metadata/contributors.json:
323 2021-10-10 Xabier Rodriguez Calvar <calvaris@igalia.com>
325 Unreviewed. Add GitHub username for Xabier Rodriguez Calvar
327 * metadata/contributors.json:
329 2021-10-10 Cameron McCormack <heycam@apple.com>
331 Add GitHub account to contributors.json
332 https://bugs.webkit.org/show_bug.cgi?id=231497
336 * metadata/contributors.json:
338 2021-10-10 Michael Catanzaro <mcatanzaro@gnome.org>
340 [WPE] Reenable -fvisibility=hidden and -fvisibility-inlines-hidden
341 https://bugs.webkit.org/show_bug.cgi?id=222860
343 Reviewed by Philippe Normand.
345 * Source/cmake/OptionsWPE.cmake:
347 2021-10-10 Adrian Perez de Castro <aperez@igalia.com>
349 Unreviewed. Add GitHub username for Adrian Perez de Castro
351 While at it, run "validate-committer-lists --canonicalize".
353 * metadata/contributors.json:
355 2021-10-09 Alberto Garcia <berto@igalia.com>
357 Add GitHub account to contributors.json
361 * metadata/contributors.json:
363 2021-10-09 Jean-Yves Avenard <jya@apple.com>
365 Unreviewed, add my GitHub username
367 * metadata/contributors.json:
369 2021-10-09 Manuel Rego Casasnovas <rego@igalia.com>
371 Add GitHub account to contributors.json and update expertise field
372 https://bugs.webkit.org/show_bug.cgi?id=231476
376 * metadata/contributors.json:
378 2021-10-08 Joonghun Park <jh718.park@samsung.com>
380 Unreviewed. Add github username for Joonghun Park.
382 * metadata/contributors.json:
384 2021-10-08 Jonathan Bedard <jbedard@apple.com>
386 Add github username for Michael Catanzaro
390 * metadata/contributors.json:
392 2021-10-08 Kenneth Russell <kbr@chromium.org>
394 Add github username for kbr
395 https://bugs.webkit.org/show_bug.cgi?id=231462
397 Reviewed by Dean Jackson.
399 * metadata/contributors.json:
401 2021-10-08 Ross Kirsling <ross.kirsling@sony.com>
403 Unreviewed, add GitHub usernames for Sony contributors.
405 * metadata/contributors.json:
407 2021-10-08 Yusuke Suzuki <ysuzuki@apple.com>
409 Unreviewed, add my GitHub username
411 * metadata/contributors.json:
413 2021-10-08 Tim Nguyen <ntim@apple.com>
415 [contributors.json] Add more Github usernames
416 https://bugs.webkit.org/show_bug.cgi?id=231453
418 Reviewed by Jonathan Bedard.
420 * metadata/contributors.json:
422 2021-10-08 Jonathan Bedard <jbedard@apple.com>
424 [contributors.json] Support GitHub usernames
425 https://bugs.webkit.org/show_bug.cgi?id=231400
426 <rdar://problem/84005266>
428 Reviewed by Dewei Zhu.
430 * metadata/contributors.json: Add some GitHub usernames.
432 2021-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
434 [GTK] Reenable -fvisibility=hidden
435 https://bugs.webkit.org/show_bug.cgi?id=181916
437 Reviewed by Michael Catanzaro.
439 * Source/cmake/OptionsGTK.cmake:
441 2021-10-06 Chris Dumez <cdumez@apple.com>
443 Unreviewed, mark Kimmo Kinnunen as reviewer in the right contributors.json file this time.
445 * metadata/contributors.json:
447 2021-10-03 Basuke Suzuki <basuke.suzuki@sony.com>
449 Enable release log to stderr
450 https://bugs.webkit.org/show_bug.cgi?id=230725
451 <rdar://problem/83740529>
453 Reviewed by Michael Catanzaro.
455 Introduced new flags, USE_LOG_STDERR for release logging to stderr.
457 * Source/cmake/WebKitFeatures.cmake:
459 2021-10-02 Philippe Normand <pnormand@igalia.com>
461 [GTK][WPE] Enable bwrap launcher build on bots
462 https://bugs.webkit.org/show_bug.cgi?id=230969
464 Reviewed by Michael Catanzaro.
466 * Source/cmake/OptionsGTK.cmake:
467 * Source/cmake/OptionsWPE.cmake:
469 2021-09-30 Yusuke Suzuki <ysuzuki@apple.com>
471 Upgrade GCC requirement to 8.3.0
472 https://bugs.webkit.org/show_bug.cgi?id=231042
474 Reviewed by Darin Adler.
476 Based on the roadmap[1], we upgrade GCC requirement to 8.3.0, which is default GCC in Debian one-old-stable (buster) right now.
477 This paves the way to enabling some of useful C++20 features, e.g. default initializer for bitfields.
479 [1]: https://trac.webkit.org/wiki/WebKitGTK/GCCRequirement
481 * Source/cmake/WebKitCommon.cmake:
483 2021-09-29 Kimmo Kinnunen <kkinnunen@apple.com>
485 MediaStream canvas.captureStream() fails for WebGL
486 https://bugs.webkit.org/show_bug.cgi?id=230613
489 Reviewed by Youenn Fablet.
491 Add a manual test to interact with media stream
492 captureStream() behavior until the implementation is
495 * ManualTests/mediastream/mediastream-canvas-to-video.html: Added.
497 2021-09-28 Carlos Garcia Campos <cgarcia@igalia.com>
499 [GTK][WPE] Bump libsoup3 version to 3.0.0
500 https://bugs.webkit.org/show_bug.cgi?id=230601
502 Reviewed by Philippe Normand.
504 * Source/cmake/OptionsGTK.cmake:
505 * Source/cmake/OptionsWPE.cmake:
507 2021-09-23 Fujii Hironori <Hironori.Fujii@sony.com>
509 [MSVC] The "/Zc:lambda" switch is recommended to use the new lambda processor.
510 https://bugs.webkit.org/show_bug.cgi?id=226070
512 Reviewed by Ross Kirsling.
514 Visual Studio 16.5 added the "/Zc:lambda" switch for the better
515 C++ conformance, but it had a compiler crashing bug. Visual Studio
518 * Source/cmake/OptionsMSVC.cmake: Added /Zc:lambda for Visual
519 Studio 16.9 or later. I will remove the MSVC_VERSION check after
520 AppleWin bots will upgrade MSVC.
522 2021-09-17 Angelos Oikonomopoulos <angelos@igalia.com>
524 Unbreak GCC_OFFLINEASM_SOURCE_MAP when LTO is in use
525 https://bugs.webkit.org/show_bug.cgi?id=230061
526 <rdar://problem/83166173>
528 Reviewed by Michael Catanzaro.
530 * Source/cmake/OptionsCommon.cmake:
532 Re-enable GCC_OFFLINEASM_SOURCE_MAP.
534 2021-09-17 Carlos Garcia Campos <cgarcia@igalia.com>
536 Unreviewed. [GTK] Bump version numbers
538 * Source/cmake/OptionsGTK.cmake:
540 2021-09-17 Martin Robinson <mrobinson@webkit.org>
542 Add Martin Robinson as a reviewer
543 https://bugs.webkit.org/show_bug.cgi?id=230392
547 * metadata/contributors.json: Add myself as a reviewer and update my specializations.
549 2021-09-17 Carlos Garcia Campos <cgarcia@igalia.com>
551 [GTK][a11y] Add a build option to enable ATSPI
552 https://bugs.webkit.org/show_bug.cgi?id=230254
554 Reviewed by Adrian Perez de Castro.
556 Add USE_ATSPI build option that disables ATK and enables isolated tree.
558 * Source/cmake/OptionsGTK.cmake:
560 2021-09-16 Philip Chimento <pchimento@igalia.com>
562 Fixes for build-webkit --minimal
563 https://bugs.webkit.org/show_bug.cgi?id=229780
565 Reviewed by Fujii Hironori.
567 Remove ENABLE_RESIZE_OBSERVER build-time option. This option is
568 quite broken if you try to disable it.
570 * Source/cmake/OptionsFTW.cmake:
571 * Source/cmake/OptionsMac.cmake:
572 * Source/cmake/WebKitFeatures.cmake:
574 2021-09-15 Philip Chimento <pchimento@igalia.com>
576 Fixes for build-webkit --minimal
577 https://bugs.webkit.org/show_bug.cgi?id=229780
579 Reviewed by Fujii Hironori.
581 Remove ENABLE_INTERSECTION_OBSERVER build-time option. This option is
582 quite broken if you try to disable it.
584 * Source/cmake/OptionsFTW.cmake:
585 * Source/cmake/OptionsMac.cmake:
586 * Source/cmake/WebKitFeatures.cmake:
588 2021-09-14 John Wilander <wilander@apple.com>
590 Rename RESOURCE_LOAD_STATISTICS to INTELLIGENT_TRACKING_PREVENTION
591 https://bugs.webkit.org/show_bug.cgi?id=230279
592 <rdar://problem/83118683>
594 Reviewed by Darin Adler.
596 * Source/cmake/OptionsFTW.cmake:
597 * Source/cmake/OptionsGTK.cmake:
598 * Source/cmake/OptionsMac.cmake:
599 * Source/cmake/OptionsPlayStation.cmake:
600 * Source/cmake/OptionsWPE.cmake:
601 * Source/cmake/OptionsWin.cmake:
602 * Source/cmake/WebKitFeatures.cmake:
604 2021-09-14 Hoa Dinh <dvh@apple.com>
606 Add dvh@apple.com to the list of contributors.
607 https://bugs.webkit.org/show_bug.cgi?id=230276
609 Reviewed by Jonathan Bedard.
611 * metadata/contributors.json:
613 2021-09-13 Sam Sneddon <gsnedders@apple.com>
615 Move ENABLE_RESOLUTION_MEDIA_QUERY to a runtime flag, start running tests again
616 https://bugs.webkit.org/show_bug.cgi?id=229776
618 Reviewed by Simon Fraser.
620 * Source/cmake/OptionsFTW.cmake:
621 * Source/cmake/WebKitFeatures.cmake:
623 2021-09-11 Philippe Normand <pnormand@igalia.com>
625 [GLIB] MediaSession is not enabled
626 https://bugs.webkit.org/show_bug.cgi?id=217991
627 <rdar://problem/70740119>
629 Reviewed by Michael Catanzaro.
631 Enable MediaSession as an experimental build feature in CMake ports. The spec status is
634 * Source/cmake/OptionsGTK.cmake:
635 * Source/cmake/OptionsWPE.cmake:
636 * Source/cmake/WebKitFeatures.cmake:
638 2021-09-08 Justin Michaud <justin_michaud@apple.com>
640 Change Justin Michaud's primary email to apple.com
641 https://bugs.webkit.org/show_bug.cgi?id=230069
643 Reviewed by Robin Morisset.
645 * metadata/contributors.json:
647 2021-09-07 Fujii Hironori <Hironori.Fujii@sony.com>
649 [WinCairo] Support prefers-color-scheme media query
650 https://bugs.webkit.org/show_bug.cgi?id=229976
652 Reviewed by Don Olmstead.
654 Just turned on ENABLE_DARK_MODE_CSS and HAVE_OS_DARK_MODE_SUPPORT.
655 It's always the light mode.
657 * Source/cmake/OptionsWin.cmake:
658 * Source/cmake/OptionsWinCairo.cmake:
660 2021-09-06 Carlos Alberto Lopez Perez <clopez@igalia.com>
662 [CMake] Prefer python3 over python2
663 https://bugs.webkit.org/show_bug.cgi?id=229969
665 Reviewed by Michael Catanzaro.
667 Use the CMake module FindPython instead of FindPythonInterp.
668 FindPython looks preferably for version 3 of Python. If not found, then it looks for version 2.
670 * Source/cmake/WebKitCommon.cmake:
672 2021-09-03 Michael Catanzaro <mcatanzaro@gnome.org>
674 Disable GCC_OFFLINEASM_SOURCE_MAP
675 https://bugs.webkit.org/show_bug.cgi?id=229893
677 Unreviewed, this fixes build failures caused by invalid assembler sources.
679 * Source/cmake/OptionsCommon.cmake:
681 2021-09-01 Jonathan Bedard <jbedard@apple.com>
683 [contributors.json] Relocation (Part 2)
684 https://bugs.webkit.org/show_bug.cgi?id=229690
685 <rdar://problem/82552403>
687 Reviewed by Dewei Zhu.
689 * metadata/contributors.json: Convert from dictionary to list.
691 2021-09-01 Jonathan Bedard <jbedard@apple.com>
693 [contributors.json] Relocation (Part 1)
694 https://bugs.webkit.org/show_bug.cgi?id=229690
695 <rdar://problem/82552403>
697 Reviewed by Aakash Jain.
699 * metadata/contributors.json: Copied from Tools/Scripts/webkitpy/common/config/contributors.json.
701 2021-08-30 Zan Dobersek <zdobersek@igalia.com>
703 RISCV64 support in LLInt
704 https://bugs.webkit.org/show_bug.cgi?id=229035
705 <rdar://problem/82120908>
707 Reviewed by Yusuke Suzuki.
709 * Source/cmake/WebKitFeatures.cmake:
710 Don't force CLoop to be default for RISCV64 anymore.
712 2021-08-27 Stephan Szabo <stephan.szabo@sony.com>
714 [PlayStation][CMake] Add control over whether JavaScriptCore should be shared
715 https://bugs.webkit.org/show_bug.cgi?id=229591
717 Add option for controlling whether to build a shared JavaScriptCore and
718 set build type for that appropriately.
720 Reviewed by Don Olmstead.
722 * Source/cmake/OptionsPlayStation.cmake:
724 2021-08-27 Russell Epstein <repstein@apple.com>
726 Land Windows build fixes from safari-612.1.29.14-branch.
727 https://bugs.webkit.org/show_bug.cgi?id=229627
729 Reviewed by Per Arne Vollan.
732 * Source/cmake/WinTools.make:
734 2021-08-27 Carlos Alberto Lopez Perez <clopez@igalia.com>
736 [CMake] ICU 61.2 is required to build WebKit since r281375
737 https://bugs.webkit.org/show_bug.cgi?id=229608
739 Reviewed by Yusuke Suzuki.
741 Raise the minimum version required for ICU.
743 * Source/cmake/OptionsAppleWin.cmake:
744 * Source/cmake/OptionsFTW.cmake:
745 * Source/cmake/OptionsGTK.cmake:
746 * Source/cmake/OptionsJSCOnly.cmake:
747 * Source/cmake/OptionsMac.cmake:
748 * Source/cmake/OptionsPlayStation.cmake:
749 * Source/cmake/OptionsWPE.cmake:
750 * Source/cmake/OptionsWinCairo.cmake:
752 2021-08-25 Myles C. Maxfield <mmaxfield@apple.com>
754 Add command to enable logging in the docs
755 https://bugs.webkit.org/show_bug.cgi?id=229419
757 Reviewed by Dean Jackson.
761 2021-08-20 Carlos Alberto Lopez Perez <clopez@igalia.com>
763 REGRESSION(r274166): [GTK] It broke run-javascriptcore-tests causing all tests to use lot of memory
764 https://bugs.webkit.org/show_bug.cgi?id=229321
766 Unreviewed, reverting r274166 because it caused JSC tests to use too much memory.
769 "[GTK] Reenable -fvisibility=hidden"
770 https://bugs.webkit.org/show_bug.cgi?id=181916
771 https://commits.webkit.org/r274166
773 * Source/cmake/OptionsGTK.cmake:
775 2021-08-16 David Kilzer <ddkilzer@apple.com>
777 "make analyze" should run clang static analyzer in deep mode
778 <https://webkit.org/b/229127>
779 <rdar://problem/81960587>
781 Reviewed by Alexey Proskuryakov.
784 - Add "analyze" argument to xcodebuild command when invoking
785 "make analyze" to run clang static analyzer in deep mode.
786 Simplify "make analyze" since $(PATH_TO_SCAN_BUILD) does not
789 2021-08-16 Carlos Garcia Campos <cgarcia@igalia.com>
791 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.33.3 release
793 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
795 2021-08-09 Myles C. Maxfield <mmaxfield@apple.com>
797 Update logging docs after r280758
798 https://bugs.webkit.org/show_bug.cgi?id=228899
800 Reviewed by Fujii Hironori.
802 Add more information about logging.
806 2021-08-05 Michael Catanzaro <mcatanzaro@gnome.org>
808 GCC 11 builds should use -Wno-array-bounds, -Wno-nonnull
809 https://bugs.webkit.org/show_bug.cgi?id=228601
811 Reviewed by Carlos Garcia Campos.
813 Prior to GCC 11, these were good warnings that could catch serious errors. But GCC 11 has
814 just become too sensitive and it's flagging what appear to be harmless cases, and not
815 providing enough feedback to know why. This has resulted in me littering our code with
816 pragmas to suppress GCC's false positives, and I think it's reached the point where it's
817 nicer to just turn off the warnings until such time that GCC gets this under control, and
818 rely on Clang instead in the meantime.
820 The GCC developers have indicated that these warnings will *always* produce false positives
821 in some circumstances, but with GCC 11 it's just too become too much IMO.
823 * Source/cmake/WebKitCompilerFlags.cmake:
825 2021-07-30 Adrian Perez de Castro <aperez@igalia.com>
827 [CMake] Fix fallback methods in the libgcrypt find module
828 https://bugs.webkit.org/show_bug.cgi?id=228581
830 Reviewed by Carlos Alberto Lopez Perez.
832 * Source/cmake/FindLibGcrypt.cmake: Make sure to use the libgcrypt-config script as
833 first fallback if libgcrypt.pc is not present, and fix the regexp used as last fallback
834 that checks the version from the gcrypt.h header as last fallback to only include digits
837 2021-07-29 Myles C. Maxfield <mmaxfield@apple.com>
839 Stop building WebGPU and the WHLSL compiler to decrease binary size
840 https://bugs.webkit.org/show_bug.cgi?id=228179
842 Reviewed by Dean Jackson, Robin Morisset, and Devin Rousso.
844 * Source/cmake/OptionsFTW.cmake:
845 * Source/cmake/OptionsMac.cmake:
846 * Source/cmake/OptionsWinCairo.cmake:
847 * Source/cmake/WebKitFeatures.cmake:
848 * Source/cmake/tools/vsprops/FeatureDefines.props:
849 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
851 2021-07-29 Adrian Perez de Castro <aperez@igalia.com>
853 [CMake] Fix missing libgpg-error not added to link commands as libgcrypt dep after r280423
854 https://bugs.webkit.org/show_bug.cgi?id=228581
856 Reviewed by Carlos Alberto Lopez Perez.
858 * Source/cmake/FindLibGcrypt.cmake: Manually search for libgpg-error, which is not listed
859 in libgcrypt.pc as a dependency, add an imported target for it, and add it as a dependency
860 of LibGcrypt::LibGcrypt to avoid missing symbols at link time.
862 2021-07-29 Adrian Perez de Castro <aperez@igalia.com>
864 [CMake] Use an imported target for the libgcrypt library
865 https://bugs.webkit.org/show_bug.cgi?id=228581
867 Reviewed by Michael Catanzaro.
869 * Source/cmake/FindLibGcrypt.cmake: Replaced find module by a new one which defines a
870 LibGcrypt::LibGcrypt imported target, using more modern CMake constructs.
871 * Source/cmake/OptionsGTK.cmake: Use the LibGcrypt::LibGcrypt imported target.
872 * Source/cmake/OptionsWPE.cmake: Ditto.
874 2021-07-28 Philippe Normand <pnormand@igalia.com>
876 [WPE][GTK] SVN_REVISION drifting away if bots don't re-run cmake
877 https://bugs.webkit.org/show_bug.cgi?id=228290
879 Reviewed by Michael Catanzaro.
881 The CMake configure_file() is now used only tarball builds for files requiring information
882 about the build revision. For developer builds a custom target now takes care of keeping
883 those files up-to-date.
885 * Source/cmake/OptionsGTK.cmake:
886 * Source/cmake/OptionsWPE.cmake:
888 2021-07-27 Zan Dobersek <zdobersek@igalia.com>
890 [CMake] Add WTF_CPU_RISCV64
891 https://bugs.webkit.org/show_bug.cgi?id=228322
893 Reviewed by Adrian Perez de Castro.
895 Define the WTF_CPU_RISCV64 CMake macro when the specified system
896 processor name begins with 'riscv64'. This should also cover potential
897 RISC-V processor names ingrained with specific ISA extensions that are
898 then detectable at compile-time through specified C macros.
900 For WTF_CPU_RISCV64, default to disabling JIT and FTL features at the
901 CMake level until they are properly supported. Defaulting to system
902 malloc can already be avoided, but CLoop is necessary for now.
904 * Source/cmake/WebKitCommon.cmake:
905 * Source/cmake/WebKitFeatures.cmake:
907 2021-07-25 Michael Catanzaro <mcatanzaro@gnome.org>
909 [GTK] USE_OPENGL_OR_ES should not be an automagic feature
910 https://bugs.webkit.org/show_bug.cgi?id=228266
912 Reviewed by Fujii Hironori.
914 The USE_OPENGL_OR_ES feature flag added in r271220 is currently automagic: that is, if
915 neither OpenGL nor OpenGL ES is available at build time, it gets silently disabled. This is
916 not OK because it makes it easy for distributors to accidentally fail to enable OpenGL
917 support. We should require manually disabling the feature with -DUSE_OPENGL_OR_ES=OFF in
918 order to build with OpenGL disabled.
920 * Source/cmake/OptionsGTK.cmake:
922 2021-07-23 Philippe Normand <pnormand@igalia.com>
924 [GLib] Remove libportal dependency
925 https://bugs.webkit.org/show_bug.cgi?id=228056
927 Reviewed by Carlos Garcia Campos.
929 * Source/cmake/FindLIBPORTAL.cmake: Removed.
930 * Source/cmake/GStreamerChecks.cmake:
932 2021-07-16 Alexander Mikhaylenko <alexm@gnome.org>
934 [GTK][WPE] Support color-schemes CSS property
935 https://bugs.webkit.org/show_bug.cgi?id=208204
937 Reviewed by Adrian Perez de Castro.
939 * Source/cmake/OptionsGTK.cmake:
940 Enable HAVE_OS_DARK_MODE_SUPPORT.
941 * Source/cmake/OptionsWPE.cmake:
942 Enable ENABLE_DARK_MODE_CSS and HAVE_OS_DARK_MODE_SUPPORT.
944 2021-07-15 Philippe Normand <pnormand@igalia.com>
946 Unreviewed, CMake fix-up after r279940
948 * Source/cmake/FindLIBPORTAL.cmake: Fix libportal detection.
950 2021-07-15 Philippe Normand <pnormand@igalia.com>
952 [GStreamer][Pipewire] Implement getDisplayMedia() backend
953 https://bugs.webkit.org/show_bug.cgi?id=210926
955 Reviewed by Xabier Rodriguez-Calvar.
957 * Source/cmake/FindLIBPORTAL.cmake: Added.
958 * Source/cmake/GStreamerChecks.cmake: Enable Pipewire support if libportal was found.
960 2021-07-13 Michael Catanzaro <mcatanzaro@gnome.org>
962 Remove USE_64KB_PAGE_BLOCK
963 https://bugs.webkit.org/show_bug.cgi?id=227905
965 Reviewed by Yusuke Suzuki.
967 I added the USE_64KB_PAGE_BLOCK build option in bug #217989 for use by RHEL. But going
968 forward, I don't need it anymore, and can maintain it downstream where it is needed. (This
969 option might also be useful to SUSE, but they already don't use it, so won't miss it.)
971 I've seen users who don't understand the consequences of this option enabling it on x86_64,
972 even though there are serious negative consequences and zero benefits to using it. So let's
975 * Source/cmake/WebKitFeatures.cmake:
977 2021-07-13 Carlos Garcia Campos <cgarcia@igalia.com>
979 [GTK][WPE] Expose support for client certificate auth
980 https://bugs.webkit.org/show_bug.cgi?id=200805
982 Reviewed by Michael Catanzaro.
984 Bump libsoup3 required version.
986 * Source/cmake/OptionsGTK.cmake:
987 * Source/cmake/OptionsWPE.cmake:
989 2021-06-24 Zan Dobersek <zdobersek@igalia.com>
991 REGRESSION(r236846): WPE shouldn't depend on OpenGL ES 3
992 https://bugs.webkit.org/show_bug.cgi?id=227289
994 Reviewed by Adrian Perez de Castro.
996 * Source/cmake/OptionsWPE.cmake: Drop the OpenGLES2 package search.
997 None of the possible versions are meaningful because libepoxy is used
998 as the underlying GL relay.
1000 2021-06-24 Martin Robinson <mrobinson@webkit.org>
1002 [css-scroll-snap] Remove ENABLE_SCROLL_SNAP compile-time option
1003 https://bugs.webkit.org/show_bug.cgi?id=227067
1005 Reviewed by Simon Fraser.
1007 Remove compile-time ENABLE_SCROLL_SNAP configuration option.
1009 * Source/cmake/WebKitFeatures.cmake: Remove the flag from the CMake configuration.
1011 2021-06-21 Fujii Hironori <Hironori.Fujii@sony.com>
1013 [WinCairo] Turn ENABLE_SHAREABLE_RESOURCE on
1014 https://bugs.webkit.org/show_bug.cgi?id=227011
1016 Reviewed by Don Olmstead.
1018 * Source/cmake/OptionsWin.cmake: Turned ENABLE_SHAREABLE_RESOURCE on for WinCairo port.
1020 2021-06-18 Sergio Villar Senin <svillar@igalia.com>
1022 Ignore clangd's directory with index files
1023 https://bugs.webkit.org/show_bug.cgi?id=227162
1025 Reviewed by Žan Doberšek.
1027 clangd stores its indexes in a .cache directory. Let git ignore it.
1031 2021-06-11 Adrian Perez de Castro <aperez@igalia.com>
1033 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.33.2 release
1035 * Source/cmake/OptionsWPE.cmake: Bump version numbers.
1037 2021-06-10 Carlos Alberto Lopez Perez <clopez@igalia.com>
1039 [CMake][GTK][WPE] Improve error message when libsoup3 is not found
1040 https://bugs.webkit.org/show_bug.cgi?id=226905
1042 Reviewed by Adrian Perez de Castro.
1044 When libsoup 3 is not found be more clear about the problem and
1045 offer possible workaround to continue the build.
1047 * Source/cmake/FindLibSoup.cmake:
1048 * Source/cmake/OptionsGTK.cmake:
1049 * Source/cmake/OptionsWPE.cmake:
1051 2021-06-10 Philippe Normand <pnormand@igalia.com>
1053 [WPE] Enable Cog for developer builds
1054 https://bugs.webkit.org/show_bug.cgi?id=224360
1056 Reviewed by Adrian Perez de Castro.
1058 Cog would be preferred over MiniBrowser for WPE developer builds because it provides a nicer
1059 user experience, while keeping the same spirit as MiniBrowser. Pass `-DENABLE_COG=NO` to
1060 CMake to disable it and fall back to MiniBrowser.
1062 * Source/cmake/OptionsWPE.cmake:
1064 2021-06-08 Carlos Garcia Campos <cgarcia@igalia.com>
1066 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.33.2 release
1068 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
1070 2021-06-07 Carlos Garcia Campos <cgarcia@igalia.com>
1072 [GTK][WPE] Bump libsoup3 version to 2.99.8
1073 https://bugs.webkit.org/show_bug.cgi?id=226713
1075 Reviewed by Philippe Normand.
1077 * Source/cmake/OptionsGTK.cmake:
1078 * Source/cmake/OptionsWPE.cmake:
1080 2021-06-04 Per Arne Vollan <pvollan@apple.com>
1082 [AppleWin] JSC build failure
1083 https://bugs.webkit.org/show_bug.cgi?id=226659
1086 Reviewed by Brent Fulgham.
1088 WTF scripts location is not being correctly identified.
1090 * Source/cmake/OptionsAppleWin.cmake:
1092 2021-06-04 Martin Robinson <mrobinson@webkit.org>
1094 [Win] Implement scroll-snap-points on Windows
1095 https://bugs.webkit.org/show_bug.cgi?id=142503
1096 <rdar://problem/20093603>
1098 Reviewed by Simon Fraser.
1100 * Source/cmake/OptionsWin.cmake: Stop disabling scroll-snap for Apple Win port.
1102 2021-05-27 Don Olmstead <don.olmstead@sony.com>
1104 [CMake] Add check for timingsafe_bcmp
1105 https://bugs.webkit.org/show_bug.cgi?id=226347
1107 Reviewed by Chris Dumez.
1109 Adds a symbol check for timingsafe_bcmp and sets HAVE_TIMINGSAFE_BCMP accordingly in the
1112 * Source/cmake/OptionsCommon.cmake:
1114 2021-05-27 Adrian Perez de Castro <aperez@igalia.com>
1116 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.33.1 release
1118 * Source/cmake/OptionsWPE.cmake: Bump version numbers.
1120 2021-05-27 Adrian Perez de Castro <aperez@igalia.com>
1122 Unreviewed. [WPE] Bump version numbers
1124 * Source/cmake/OptionsWPE.cmake:
1126 2021-05-26 Don Olmstead <don.olmstead@sony.com>
1128 [CMake] Support USE_ANGLE_EGL on additional platforms
1129 https://bugs.webkit.org/show_bug.cgi?id=224888
1130 <rdar://problem/77280211>
1132 Reviewed by Ken Russell.
1134 USE_ANGLE_EGL is for platforms that want to use ANGLE as the sole OpenGL ES implementation
1135 within WebKit. This setting is applicable to Mac and Windows platforms. USE_ANGLE_WEBGL is
1136 just for platforms that want to use ANGLE for WebGL 2.0 support only. Any other uses of
1137 OpenGL should go through the system OpenGL (desktop or embedded). This setting applies to
1140 The platform options were modified to match this.
1142 * Source/cmake/OptionsGTK.cmake:
1143 * Source/cmake/OptionsMac.cmake:
1145 2021-05-25 Don Olmstead <don.olmstead@sony.com>
1147 [PlayStation] Implement FileSystem without std::filesystem
1148 https://bugs.webkit.org/show_bug.cgi?id=226197
1150 Reviewed by Chris Dumez.
1152 Expose the result of the check for <filesystem> support as HAVE_STD_FILESYSTEM.
1154 * Source/cmake/OptionsCommon.cmake:
1156 2021-05-18 Yoshiaki Jitsukawa <yoshiaki.jitsukawa@sony.com>
1158 [PlayStation] Fix PlayStation port
1159 https://bugs.webkit.org/show_bug.cgi?id=225913
1161 Reviewed by Don Olmstead.
1163 Fix PlayStation port
1165 * Source/cmake/OptionsPlayStation.cmake: Rename
1166 PLAYSTATION_COPY_SHARED_LIBRARIES to PLAYSTATION_COPY_REQUIREMENTS and
1167 let it copy more general files.
1168 Touch ebootparam.ini by the playstation_tools_copy custom_target.
1170 2021-05-15 Sam Weinig <weinig@apple.com>
1172 Allow conditionally enabling OffscreenCanvas only for non-worker contexts
1173 https://bugs.webkit.org/show_bug.cgi?id=225845
1175 Reviewed by Darin Adler.
1177 * Source/cmake/OptionsGTK.cmake:
1178 * Source/cmake/OptionsWPE.cmake:
1179 * Source/cmake/WebKitFeatures.cmake:
1180 Match current behavior of ENABLE_OFFSCREEN_CANVAS for ENABLE_OFFSCREEN_CANVAS_IN_WORKERS.
1182 2021-05-14 Carlos Garcia Campos <cgarcia@igalia.com>
1184 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.33.1 release
1186 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
1188 2021-05-14 Carlos Garcia Campos <cgarcia@igalia.com>
1190 Unreviewed. [GTK] Fix make distcheck
1192 Use WEBKITGTK_API_DOC_VERSION instead of WEBKITGTK_API_VERSION or the documentation install rules.
1194 * Source/PlatformGTK.cmake:
1196 2021-05-07 Carlos Garcia Campos <cgarcia@igalia.com>
1198 [GTK][WPE] Bump libsoup3 version to 2.99.5
1199 https://bugs.webkit.org/show_bug.cgi?id=225506
1201 Reviewed by Philippe Normand.
1203 * Source/cmake/OptionsGTK.cmake:
1204 * Source/cmake/OptionsWPE.cmake:
1206 2021-05-06 Yoshiaki Jitsukawa <yoshiaki.jitsukawa@sony.com>
1208 [OpenSSL] Implement CryptoAlgorithmRSA*
1209 https://bugs.webkit.org/show_bug.cgi?id=225294
1211 Reviewed by Don Olmstead.
1213 Implement RSA for OpenSSL.
1215 Implement CryptoAlgorithmRSA_OAEP, CryptoAlgorithmRSA_PSS,
1216 CryptoAlgorithmRSAES_PKCS1_v1_5, CryptoAlgorithmRSASA_PKCS1_v1_5,
1217 and CryptoKeyRSA for OpenSSL.
1219 Note that if such OpenSSL version that does not support RSA_OAEP or
1220 RSA_PSS, the WebCrypto API for those algorithm will return a
1223 * Source/cmake/OptionsPlayStation.cmake:
1224 * Source/cmake/OptionsWinCairo.cmake:
1226 2021-05-05 Michael Catanzaro <mcatanzaro@gnome.org>
1228 USE_64KB_PAGE_BLOCK build option is broken
1229 https://bugs.webkit.org/show_bug.cgi?id=225393
1231 Reviewed by Adrian Perez de Castro.
1233 Call SET_AND_EXPOSE_TO_BUILD().
1235 * Source/cmake/WebKitFeatures.cmake:
1237 2021-05-05 Michael Catanzaro <mcatanzaro@gnome.org>
1239 Fix typo in comment in WebKitFeatures.cmake
1240 https://bugs.webkit.org/show_bug.cgi?id=225392
1244 * Source/cmake/WebKitFeatures.cmake:
1246 2021-04-27 Don Olmstead <don.olmstead@sony.com>
1248 [CMake] Don't use FORWARDING_HEADERS_DIR for GTK WebKit headers
1249 https://bugs.webkit.org/show_bug.cgi?id=225006
1251 Reviewed by Michael Catanzaro.
1253 Create CMake variables WebKit2Gtk_FRAMEWORK_HEADERS_DIR and WebKit2Gtk_DERIVED_SOURCES_DIR
1254 to represent where the WebKit2 GTK headers and derived sources will reside. The names and
1255 locations set then follow along with the conventions used for the other frameworks.
1257 * Source/cmake/OptionsGTK.cmake:
1259 2021-04-26 Alex Christensen <achristensen@webkit.org>
1261 Update Mac-specific CMake files
1262 https://bugs.webkit.org/show_bug.cgi?id=225064
1264 Rubber-stamped by Tim Horton.
1266 * Source/cmake/OptionsMac.cmake:
1267 * Source/cmake/WebKitCommon.cmake:
1269 2021-04-26 Don Olmstead <don.olmstead@sony.com>
1271 [PlayStation] Fix build break after r276368
1272 https://bugs.webkit.org/show_bug.cgi?id=225056
1274 Reviewed by Ross Kirsling.
1276 Ensure that the OpenGL::GLES target is created.
1278 * Source/cmake/OptionsPlayStation.cmake:
1280 2021-04-22 Martin Robinson <mrobinson@webkit.org>
1282 [GTK] Turn on editable <input type=date> and <input type=time> fields
1283 https://bugs.webkit.org/show_bug.cgi?id=224921
1285 Reviewed by Carlos Garcia Campos.
1287 Turn on editable date and time inputs for GTK
1289 * Source/cmake/OptionsGTK.cmake: Add new source file to the list.
1291 2021-04-22 Imanol Fernandez <ifernandez@igalia.com>
1293 Implement WebXR Input Sources
1294 https://bugs.webkit.org/show_bug.cgi?id=223257
1296 Reviewed by Youenn Fablet.
1298 Enable WPE Gamepad when WebXR is enabled.
1300 * Source/cmake/OptionsWPE.cmake:
1302 2021-04-22 Carlos Garcia Campos <cgarcia@igalia.com>
1304 [SOUP] Add support for preconnect
1305 https://bugs.webkit.org/show_bug.cgi?id=177934
1307 Reviewed by Sergio Villar Senin.
1309 Enable server preconnect support when building with libsoup3.
1311 * Source/cmake/OptionsGTK.cmake:
1312 * Source/cmake/OptionsWPE.cmake:
1314 2021-04-22 Carlos Garcia Campos <cgarcia@igalia.com>
1316 [GTK][WPE] Bump libsoup3 version to 2.99.4
1317 https://bugs.webkit.org/show_bug.cgi?id=224925
1319 Reviewed by Philippe Normand.
1321 * Source/cmake/OptionsGTK.cmake:
1322 * Source/cmake/OptionsWPE.cmake:
1324 2021-04-21 Martin Robinson <mrobinson@igalia.com>
1326 Enable CSS Scroll Snap by default
1327 https://bugs.webkit.org/show_bug.cgi?id=224867
1329 Reviewed by Don Olmstead.
1331 * Source/cmake/OptionsFTW.cmake: Remove redundant line enabling scroll snap.
1332 * Source/cmake/OptionsGTK.cmake: Ditto.
1333 * Source/cmake/OptionsMac.cmake: Ditto.
1334 * Source/cmake/OptionsWPE.cmake: Ditto.
1335 * Source/cmake/OptionsWin.cmake: Explicitly disable scroll snap for AppleWin port
1336 until it can be approved by maintainers.
1337 * Source/cmake/WebKitFeatures.cmake: Enable scroll snap by default.
1339 2021-04-21 Don Olmstead <don.olmstead@sony.com>
1341 [CMake] Add OpenGLES2 targets
1342 https://bugs.webkit.org/show_bug.cgi?id=224786
1344 Reviewed by Adrian Perez de Castro.
1346 Modernize the FindOpenGLES2.cmake module. Add an OpenGL::GLES target. Also add an
1347 OpenGLES2_API_VERSION value so HAVE_OPENGL_ES_3 can be determined.
1349 For WPE add a find_package for OpenGL ES so the target is present.
1351 For GTK set HAVE_OPENGL_ES_3 if OpenGLES2_API_VERSION supports it.
1353 * Source/cmake/FindOpenGLES2.cmake:
1354 * Source/cmake/OptionsGTK.cmake:
1355 * Source/cmake/OptionsWPE.cmake:
1357 2021-04-20 Don Olmstead <don.olmstead@sony.com>
1359 [CMake] Don't use FORWARDING_HEADERS_DIR for JSC GLib headers
1360 https://bugs.webkit.org/show_bug.cgi?id=224821
1362 Reviewed by Michael Catanzaro.
1364 Create CMake variables JavaScriptCoreGLib_FRAMEWORK_HEADERS_DIR and
1365 JavaScriptCoreGLib_DERIVED_SOURCES_DIR to represent where the JavaScriptCore GLib headers
1366 and derived sources will reside. The names and locations set then follow along with the
1367 conventions used for the other frameworks.
1369 * Source/cmake/OptionsGTK.cmake:
1370 * Source/cmake/OptionsWPE.cmake:
1372 2021-04-20 Carlos Garcia Campos <cgarcia@igalia.com>
1374 [WPE] Switch to libsoup3 by default
1375 https://bugs.webkit.org/show_bug.cgi?id=224802
1377 Reviewed by Žan Doberšek.
1379 * Source/cmake/OptionsWPE.cmake:
1381 2021-04-19 Carlos Garcia Campos <cgarcia@igalia.com>
1383 [GTK] Switch to libsoup3 by default
1384 https://bugs.webkit.org/show_bug.cgi?id=224741
1386 Reviewed by Sergio Villar Senin.
1388 * Source/cmake/OptionsGTK.cmake:
1390 2021-04-19 Philippe Normand <pnormand@igalia.com>
1392 [WPE][GTK] Enable AVIF decoder as experimental feature and unskip tests
1393 https://bugs.webkit.org/show_bug.cgi?id=224663
1395 Reviewed by Xabier Rodriguez-Calvar.
1397 Make the USE_AVIF option public and enable it as experimental feature.
1399 * Source/cmake/OptionsGTK.cmake:
1400 * Source/cmake/OptionsWPE.cmake:
1402 2021-04-16 Philippe Normand <pnormand@igalia.com>
1404 [CMake] UBSan build fixes
1405 https://bugs.webkit.org/show_bug.cgi?id=224536
1407 Reviewed by Adrian Perez de Castro.
1409 Synchronize UBSan compiler flags with the ones defined in ubsan.xcconfig.
1411 * Source/cmake/WebKitCompilerFlags.cmake:
1413 2021-04-15 Don Olmstead <don.olmstead@sony.com>
1415 ANGLE is only being built when WebGL is enabled
1416 https://bugs.webkit.org/show_bug.cgi?id=224555
1418 Reviewed by Fujii Hironori.
1420 ANGLE should be built if either USE_ANGLE_EGL or ENABLE_WEBGL is ON.
1422 * Source/CMakeLists.txt:
1424 2021-04-15 Basuke Suzuki <basuke.suzuki@sony.com>
1426 Remove warnings caused by export g_config extern definition in WTFConfig.h
1427 https://bugs.webkit.org/show_bug.cgi?id=224462
1429 Reviewed by Don Olmstead.
1431 While building PlayStation port, lots of warnings are displayed:
1433 > WTF/Headers\wtf/WTFConfig.h:49:36: warning: redeclaration of 'WebConfig::g_config'
1434 > should not add 'dllimport' attribute [-Wdll-attribute-on-redeclaration]
1435 > extern "C" WTF_EXPORT_PRIVATE Slot g_config[];
1437 > bmalloc/Headers\bmalloc/GigacageConfig.h:38:17: note: previous declaration is here
1438 > extern "C" Slot g_config[];
1440 This is because the two definitions are not same.
1441 Becasue we can't solve the situation completely, we just ignore these warnings at
1444 * Source/cmake/OptionsPlayStation.cmake:
1446 2021-04-15 Philippe Normand <pnormand@igalia.com>
1448 [WebRTC][GStreamer] Build and use the openh264 based encoder if present on the system
1449 https://bugs.webkit.org/show_bug.cgi?id=202538
1450 <rdar://problem/76047172>
1452 Reviewed by Xabier Rodriguez-Calvar.
1454 * Source/CMakeLists.txt:
1455 * Source/cmake/GStreamerChecks.cmake:
1457 2021-04-14 Don Olmstead <don.olmstead@sony.com>
1459 [PlayStation] Disable WebGL
1460 https://bugs.webkit.org/show_bug.cgi?id=224562
1462 Reviewed by Alex Christensen.
1464 WebGL support on PlayStation platforms is deprecated.
1466 * Source/cmake/OptionsPlayStation.cmake:
1468 2021-04-13 Philippe Normand <pnormand@igalia.com>
1470 [GTK][WPE] Avif decoder build broken
1471 https://bugs.webkit.org/show_bug.cgi?id=224232
1473 Reviewed by Carlos Garcia Campos.
1475 * Source/cmake/OptionsGTK.cmake: Require 0.9.0 due to avifIO usage in the decoder.
1477 2021-04-09 Carlos Garcia Campos <cgarcia@igalia.com>
1479 [GTK][WPE] Bump libsoup3 version to 2.99.3
1480 https://bugs.webkit.org/show_bug.cgi?id=224362
1482 Reviewed by Žan Doberšek.
1484 * Source/cmake/OptionsGTK.cmake:
1485 * Source/cmake/OptionsWPE.cmake:
1487 2021-04-07 Michael Catanzaro <mcatanzaro@gnome.org>
1489 [GTK] webkit://gpu should print runtime libwpe and wpebackend-fdo versions
1490 https://bugs.webkit.org/show_bug.cgi?id=224298
1492 Reviewed by Adrian Perez de Castro.
1494 * Source/cmake/OptionsGTK.cmake:
1496 2021-04-07 Don Olmstead <don.olmstead@sony.com>
1498 [CMake] Mark _LIBRARY not _LIBRARIES in find modules
1499 https://bugs.webkit.org/show_bug.cgi?id=224283
1501 Reviewed by Michael Catanzaro.
1503 A few find modules are erroniously sending _LIBRARIES to mark_as_advanced rather than
1504 _LIBRARY. The former is created from the _LIBRARY value so it isn't valid at that point.
1506 * Source/cmake/FindCairo.cmake:
1507 * Source/cmake/FindFontconfig.cmake:
1508 * Source/cmake/FindSQLite3.cmake:
1510 2021-04-07 Kimmo Kinnunen <kkinnunen@apple.com>
1512 .gitignore contains 'build/' which causes all directories named 'build/' to be ignored
1513 https://bugs.webkit.org/show_bug.cgi?id=224227
1515 Reviewed by Ryosuke Niwa.
1517 Remove 'build/' from .gitignore, it was causing errors by hiding files.
1518 WebGL conformance test suite files have directiories with 'build/' in its path.
1520 Most likely '/build/' is not a common build directory, since the scripts
1521 seem to default to '/WebKitBuild/'.
1525 2021-04-06 Philippe Normand <pnormand@igalia.com>
1527 REGRESSION(r275275): Broke some build configs lacking openh264
1528 https://bugs.webkit.org/show_bug.cgi?id=224244
1530 Unreviewed, manual revert of r275275 and r275409.
1532 * Source/CMakeLists.txt:
1533 * Source/cmake/GStreamerChecks.cmake:
1535 2021-04-06 Mark Lam <mark.lam@apple.com>
1537 Speculative build fix for Windows port.
1538 https://bugs.webkit.org/show_bug.cgi?id=224243
1541 Reviewed by Saam Barati.
1543 Source/cmake/tools/scripts/auto-version.pl was limiting our `minor` and `micro`
1544 version to only 2 decimal digits only. In practice, we can use up to 3 digits.
1546 * Source/cmake/tools/scripts/auto-version.pl:
1549 2021-04-05 Alex Christensen <achristensen@webkit.org>
1551 Resurrect Mac CMake build
1552 https://bugs.webkit.org/show_bug.cgi?id=224084
1554 Reviewed by Tim Horton.
1556 * Source/cmake/OptionsMac.cmake:
1558 2021-04-05 Tyler Wilcock <twilco.o@protonmail.com>
1560 Document how to use logging in WebKit
1561 https://bugs.webkit.org/show_bug.cgi?id=224152
1563 Reviewed by Simon Fraser.
1565 Add documentation about how to use logging in WebKit.
1569 2021-03-28 David Kilzer <ddkilzer@apple.com>
1571 Compile WebKit with UBSan
1572 <https://webkit.org/b/176131>
1573 <rdar://problem/34174018>
1575 Reviewed by Alexey Proskuryakov.
1578 - Add support for "UBSAN=YES" argument to make.
1580 2021-03-27 Philippe Normand <pnormand@igalia.com>
1582 REGRESSION(r275111) [GLIB] Fix build with new derived sources and forwarding headers scheme
1583 https://bugs.webkit.org/show_bug.cgi?id=223834
1585 Unreviewed build fix.
1587 * Source/cmake/OptionsGTK.cmake:
1588 * Source/cmake/OptionsWPE.cmake:
1590 2021-03-26 Lauro Moura <lmoura@igalia.com>
1592 REGRESSION(r275111) [GLIB] Fix build with new derived sources and forwarding headers scheme
1593 https://bugs.webkit.org/show_bug.cgi?id=223834
1595 Unreviewed build fix.
1597 Buildfix for now. Actual removal of older scheme will come in the
1600 * Source/cmake/OptionsWPE.cmake: Add some missing variables with the
1601 per framework source and header dirs.
1603 2021-03-26 Don Olmstead <don.olmstead@sony.com>
1605 [CMake] Deprecate using DERIVED_SOURCES_DIR/FOWARDING_HEADERS_DIR directly
1606 https://bugs.webkit.org/show_bug.cgi?id=223763
1608 Reviewed by Michael Catanzaro.
1610 Remove any usages of DERIVED_SOURCES_DIR and FOWARDING_HEADERS_DIR. There are still some
1611 uses in GTK/WPE but those should be phased out.
1613 Sets the directory structure to look like an Apple build in terms of where headers and
1614 derived sources are held. Rather than having one root derived sources and one root
1615 header directory those directories are now per project. This helps catch any errors with
1618 Deletes some old Mac CMake code that is no longer relevant around creating forwarding
1621 For AppleWin the old structure is used because of its internal build which assumes the
1624 * Source/cmake/OptionsAppleWin.cmake:
1625 * Source/cmake/OptionsFTW.cmake:
1626 * Source/cmake/OptionsGTK.cmake:
1627 * Source/cmake/OptionsPlayStation.cmake:
1628 * Source/cmake/OptionsWPE.cmake:
1629 * Source/cmake/OptionsWinCairo.cmake:
1630 * Source/cmake/WebKitCommon.cmake:
1631 * Source/cmake/WebKitFS.cmake:
1632 * Source/cmake/WebKitMacros.cmake:
1634 2021-03-23 Adrian Perez de Castro <aperez@igalia.com>
1636 [CMake] Use an imported target for the LCMS2 library
1637 https://bugs.webkit.org/show_bug.cgi?id=223442
1639 Reviewed by Carlos Garcia Campos.
1641 * Source/cmake/FindLCMS2.cmake: Replaced find module by a new one which
1642 defines a LCMS2::LCMS2 imported target and in general uses more modern CMake
1645 2021-03-23 Cameron McCormack <heycam@apple.com>
1647 Update .clang-format to reflect WebKit style better.
1648 https://bugs.webkit.org/show_bug.cgi?id=223229
1650 First, SpaceBeforeCpp11BracedList is set to true so that a space
1651 is introduced after a variable name and before a braced initializer.
1653 Second, AlwaysBreakTemplateDeclarations is changed from false (an
1654 invalid value) to No, which should result in no line breaks being
1655 introduced in template declarations. Although there is a mix of
1656 template declaration line breaking styles in the codebase, changing
1657 this option to No will prevent clang-format from introducing one
1658 where the patch author decides to write the declaration all on one
1661 Reviewed by Alex Christensen.
1665 2021-03-22 Adrian Perez de Castro <aperez@igalia.com>
1667 [CMake] Wrong variable used in FindFontconfig used to pick version from pkg-config
1668 https://bugs.webkit.org/show_bug.cgi?id=223557
1670 Reviewed by Michael Catanzaro.
1672 * Source/cmake/FindFontconfig.cmake: Fix to use ${PC_FONTCONFIG_VERSION}.
1674 2021-03-18 Carlos Garcia Campos <cgarcia@igalia.com>
1676 [WPE] Bump API version when building with libsoup3
1677 https://bugs.webkit.org/show_bug.cgi?id=223437
1679 Reviewed by Adrian Perez de Castro.
1681 Use 1.1 as the API version when building with soup3.
1683 * Source/PlatformWPE.cmake:
1684 * Source/cmake/OptionsWPE.cmake:
1686 2021-03-17 Martin Robinson <mrobinson@igalia.com>
1688 [GTK][WPE] Enable CSS scroll snap support by default
1689 https://bugs.webkit.org/show_bug.cgi?id=222641
1691 Reviewed by Carlos Garcia Campos.
1693 * Source/cmake/OptionsGTK.cmake: Enable CSS scroll snap by default.
1694 * Source/cmake/OptionsWPE.cmake: Ditto.
1696 2021-03-16 Khem Raj <raj.khem@gmail.com>
1698 [CMake] Build fails on RISC-V with GCC 11
1699 https://bugs.webkit.org/show_bug.cgi?id=222959
1701 Reviewed by Carlos Alberto Lopez Perez.
1703 Check for 1 byte atomic operations along with 64bit ones, some
1704 architevtures (e.g. RISCV) operations on less than 4 bytes are not lock-free
1706 * Source/cmake/WebKitCompilerFlags.cmake:
1708 2021-03-14 Lauro Moura <lmoura@igalia.com>
1710 [GLIB] Keep GPUProcess disabled when using experimental features
1711 https://bugs.webkit.org/show_bug.cgi?id=223155
1713 Reviewed by Philippe Normand.
1715 At least two recent GPUProcess-related revisions caused issues in
1716 GLIB, causing serious regressions in the bots. Disabling it for now
1717 until we improve its support.
1721 r274327 - 2D Canvas enabled by default in GPUProcess
1722 r272842 - Media enabled by default in GPUProcess
1724 * Source/cmake/OptionsGTK.cmake:
1725 * Source/cmake/OptionsWPE.cmake:
1727 2021-03-12 Carlos Garcia Campos <cgarcia@igalia.com>
1729 [GTK] Bump API version when building with libsoup3
1730 https://bugs.webkit.org/show_bug.cgi?id=223067
1732 Reviewed by Adrian Perez de Castro.
1734 Use 4.1 as the API version when building with soup3 and keep using 5.0 for GTK4. Also make it impossible to
1735 build with GTK4 and soup2.
1737 * Source/PlatformGTK.cmake:
1738 * Source/cmake/OptionsGTK.cmake:
1740 2021-03-11 Carlos Garcia Campos <cgarcia@igalia.com>
1742 Unreviewed. [GTK][WPE] Bump libsoup3 version to 2.99.3
1744 * Source/cmake/OptionsGTK.cmake:
1745 * Source/cmake/OptionsWPE.cmake:
1747 2021-03-11 Carlos Garcia Campos <cgarcia@igalia.com>
1749 [WPE][GTK] Add support for ICC color management
1750 https://bugs.webkit.org/show_bug.cgi?id=177185
1752 Reviewed by Adrian Perez de Castro.
1754 Add optional lcms2 dependency.
1756 * Source/cmake/FindLCMS2.cmake: Added.
1757 * Source/cmake/OptionsGTK.cmake:
1758 * Source/cmake/OptionsWPE.cmake:
1760 2021-03-10 Michael Catanzaro <mcatanzaro@gnome.org>
1762 [GTK] Reenable -fvisibility=hidden
1763 https://bugs.webkit.org/show_bug.cgi?id=181916
1765 Reviewed by Don Olmstead.
1767 In non-DEVELOPER_MODE builds, we rely on a linker version script to hide symbols that we
1768 don't want to export. Building with hidden visibility might seem redundant with this, but
1769 actually building with hidden visibility has advantages anyway. See
1770 https://gcc.gnu.org/wiki/Visibility.
1772 Note that I'm not confident GTK port can safely use -fvisibility-inlines-hidden, since it's
1773 split between two shared objects. Also, because GTK is split into two shared objects, GTK
1774 needs to build bmalloc and WTF as CMake OBJECT libraries, which is effectively the same as
1775 using -Wl,--whole-archive to prevent symbols from being prematurely stripped away.
1777 P.S. Major credit to Don Olmstead, who did most of the work to make this possible, which has
1778 already landed in previous patches.
1780 * Source/cmake/OptionsGTK.cmake:
1782 2021-03-10 Commit Queue <commit-queue@webkit.org>
1784 Unreviewed, reverting r274166.
1785 https://bugs.webkit.org/show_bug.cgi?id=223024
1787 Broke GTK Debug builds
1791 "[GTK] Reenable -fvisibility=hidden"
1792 https://bugs.webkit.org/show_bug.cgi?id=181916
1793 https://trac.webkit.org/changeset/274166
1795 2021-03-09 Don Olmstead <don.olmstead@sony.com>
1797 GLib JSC API headers should only include other GLib JSC API headers
1798 https://bugs.webkit.org/show_bug.cgi?id=222803
1800 Reviewed by Michael Catanzaro.
1802 GTK and WPE both build the JavaScriptCore GLib API. However they diverged with their CMake
1803 variable names for the directory containing jsc. Declare a single variable for that
1804 directory, DERIVED_SOURCES_JAVASCRIPTCORE_GLIB_DIR, that is shared between GLib ports.
1806 Remove the GLIB_API_DIR variant which will just be replaced with
1807 ${DERIVED_SOURCES_JAVASCRIPTCORE_GLIB_DIR}/jsc in the CMake code.
1809 * Source/cmake/OptionsGTK.cmake:
1810 * Source/cmake/OptionsWPE.cmake:
1812 2021-03-09 Michael Catanzaro <mcatanzaro@gnome.org>
1814 [GTK] Reenable -fvisibility=hidden
1815 https://bugs.webkit.org/show_bug.cgi?id=181916
1817 Reviewed by Don Olmstead.
1819 In non-DEVELOPER_MODE builds, we rely on a linker version script to hide symbols that we
1820 don't want to export. Building with hidden visibility might seem redundant with this, but
1821 actually building with hidden visibility has advantages anyway. See
1822 https://gcc.gnu.org/wiki/Visibility.
1824 Note that I'm not confident GTK port can safely use -fvisibility-inlines-hidden, since it's
1825 split between two shared objects. Also, because GTK is split into two shared objects, GTK
1826 needs to build bmalloc and WTF as CMake OBJECT libraries, which is effectively the same as
1827 using -Wl,--whole-archive to prevent symbols from being prematurely stripped away.
1829 P.S. Major credit to Don Olmstead, who did most of the work to make this possible, which has
1830 already landed in previous patches.
1832 * Source/cmake/OptionsGTK.cmake:
1834 2021-03-05 Michael Catanzaro <mcatanzaro@gnome.org>
1836 [GTK] Remove ADD_WHOLE_ARCHIVE_TO_LIBRARIES
1837 https://bugs.webkit.org/show_bug.cgi?id=222826
1839 Reviewed by Don Olmstead.
1841 I don't know why it's no longer needed, but GTK links without it, so it can go away.
1843 * Source/cmake/OptionsGTK.cmake:
1845 2021-03-05 Don Olmstead <don.olmstead@sony.com>
1847 [CMake] Bump cmake_minimum_required version to 3.12 or later
1848 https://bugs.webkit.org/show_bug.cgi?id=221727
1849 <rdar://problem/74454980>
1851 Reviewed by Konstantin Tokarev.
1853 Updates the minimum version to 3.12. In CMake 3.12 OBJECT library functionality was
1854 expanded to the point where they can successfully be used as a replacement for
1855 --whole-archive within WebKit. The check in JSCOnly for the minimum version before
1856 using hidden visibility was removed accordingly.
1859 * Source/cmake/OptionsJSCOnly.cmake:
1861 2021-03-05 ChangSeok Oh <changseok@webkit.org>
1863 AVIF decoding support
1864 https://bugs.webkit.org/show_bug.cgi?id=207750
1866 Reviewed by Philippe Normand.
1868 This patch brings an initial support of AVIF image format to the gtk port.
1869 AVIF is a new royalty-free image format derived from the keyframes of AV1 video.
1870 FireFox and Chromium-variant browsers already support it. Its specification can be found
1871 at https://rawcdn.githack.com/AOMediaCodec/av1-avif/67a92add6cd642a8863e386fa4db87954a6735d1/index.html
1872 This patch aims to land a build option for AVIF and a basic decoding ability
1873 for still images by using libavif. Animated AVIF images will be covered later.
1875 * Source/cmake/FindAVIF.cmake: Added to find libavif.
1876 * Source/cmake/OptionsGTK.cmake: A build option, USE_AVIF is added.
1878 2021-03-03 Commit Queue <commit-queue@webkit.org>
1880 Unreviewed, reverting r273814.
1881 https://bugs.webkit.org/show_bug.cgi?id=222676
1883 Unresolved types in JavaScriptCore-4.0.gir
1887 "[CMake] JavaScriptCore GLib headers should be copies"
1888 https://bugs.webkit.org/show_bug.cgi?id=222625
1889 https://trac.webkit.org/changeset/273814
1891 2021-03-03 Don Olmstead <don.olmstead@sony.com>
1893 [CMake] JavaScriptCore GLib headers should be copies
1894 https://bugs.webkit.org/show_bug.cgi?id=222625
1896 Reviewed by Michael Catanzaro.
1898 Specify the directories for JavaScriptCore GLib headers and derived sources.
1900 * Source/cmake/OptionsGTK.cmake:
1901 * Source/cmake/OptionsWPE.cmake:
1903 2021-03-01 Per Arne <pvollan@apple.com>
1905 [Win] Fix build failure
1906 https://bugs.webkit.org/show_bug.cgi?id=222576
1907 <rdar://problem/74590803>
1908 Reviewed by Brent Fulgham.
1910 It appears a recent change has unintentionally enabled WebInspectorUI on Apple Win. Address this by explicitly disabling it.
1912 * Source/cmake/OptionsAppleWin.cmake:
1914 2021-02-26 Carlos Garcia Campos <cgarcia@igalia.com>
1916 Unreviewed. [GTK] Bump version numbers
1918 * Source/cmake/OptionsGTK.cmake:
1920 2021-02-26 Imanol Fernandez <ifernandez@igalia.com>
1922 Implement OpenXR port graphics binding
1923 https://bugs.webkit.org/show_bug.cgi?id=222173
1925 Reviewed by Sergio Villar Senin.
1927 Enable OpenXR defines required for EGL graphics binding.
1929 * Source/cmake/OptionsWPE.cmake:
1931 2021-02-26 Carlos Garcia Campos <cgarcia@igalia.com>
1933 [GTK][WPE] Bump libsoup3 version to 2.99.1
1934 https://bugs.webkit.org/show_bug.cgi?id=222413
1936 Reviewed by Adrian Perez de Castro.
1938 * Source/cmake/OptionsGTK.cmake:
1939 * Source/cmake/OptionsWPE.cmake:
1941 2021-02-24 Cameron McCormack <heycam@apple.com>
1943 Fix typo in Introduction.md.
1944 https://bugs.webkit.org/show_bug.cgi?id=222387
1946 Reviewed by Ryosuke Niwa.
1950 2021-02-23 Don Olmstead <don.olmstead@sony.com>
1952 [CMake] Fix JSCOnly build on Windows
1953 https://bugs.webkit.org/show_bug.cgi?id=222316
1955 Reviewed by Michael Catanzaro.
1957 Turn off ENABLE_WEBASSEMBLY for Windows on JSCOnly now that its possible to build it
1960 * Source/cmake/OptionsJSCOnly.cmake:
1962 2021-02-22 Carlos Garcia Campos <cgarcia@igalia.com>
1964 [SOUP] Add support for libsoup3
1965 https://bugs.webkit.org/show_bug.cgi?id=222093
1967 Reviewed by Adrian Perez de Castro.
1969 * Source/cmake/FindLibSoup.cmake:
1970 * Source/cmake/OptionsGTK.cmake:
1971 * Source/cmake/OptionsWPE.cmake:
1973 2021-02-18 Martin Robinson <mrobinson@igalia.com>
1975 [GTK][WPE] Implement support for CSS Scroll Snap
1976 https://bugs.webkit.org/show_bug.cgi?id=203684
1978 Reviewed by Carlos Garcia Campos.
1980 Add initial support for css-scroll-snap on WebKitGTK+ and WebKitWPE. This
1981 adds support for all types of scroll snapping that WebKit supports apart
1982 from mouse wheel snapping. Support for that will be added in a followup
1985 * Source/cmake/OptionsGTK.cmake: Enable scroll snapping when experimental features
1987 * Source/cmake/OptionsWPE.cmake: Ditto.
1989 2021-02-16 Tim Horton <timothy_horton@apple.com>
1991 Local macCatalyst builds should not build WebInspectorUI
1992 https://bugs.webkit.org/show_bug.cgi?id=221992
1994 Reviewed by Wenson Hsieh.
1997 This project is not used in macCatalyst, and is not even built in production builds.
1998 We should stop building it in local release/debug builds as well.
2000 2021-02-11 Don Olmstead <don.olmstead@sony.com>
2002 [CMake] WEBKIT_EXECUTABLE can incorrectly link framework
2003 https://bugs.webkit.org/show_bug.cgi?id=221703
2005 Reviewed by Michael Catanzaro.
2007 After r272484 which added an additional test for TestJavaScriptCore the PlayStation build
2008 began failing with an unresolved symbol in bmalloc. On PlayStation both WTF and bmalloc
2009 are linked into JavaScriptCore. That library was building successfully which implied that
2010 WTF was being erroniously linked into TestJavaScriptCore.
2012 Inside _WEBKIT_EXECUTABLE_LINK_FRAMEWORK there was an invalid conditional which was causing
2013 WTF to be linked. Fixed the logic to ensure that if the requested framework is linked into
2014 another framework that is being linked then it is not added to the linker.
2016 * Source/cmake/WebKitMacros.cmake:
2018 2021-02-10 Don Olmstead <don.olmstead@sony.com>
2020 [CMake] Enable hidden visibility on JSCOnly
2021 https://bugs.webkit.org/show_bug.cgi?id=221726
2023 Reviewed by Yusuke Suzuki.
2025 Turn on hidden visibility for all *NIX ports of JSCOnly. To properly export the symbols
2026 from WTF/bmalloc OBJECT libraries are used. This requires CMake 3.12 or later to
2029 * Source/cmake/OptionsJSCOnly.cmake:
2031 2021-02-10 Christopher Reid <chris.reid@sony.com>
2033 [PlayStation] Add initial RESOURCE_USAGE implementation
2034 https://bugs.webkit.org/show_bug.cgi?id=221706
2036 Reviewed by Ross Kirsling.
2038 * Source/cmake/OptionsPlayStation.cmake:
2040 2021-02-10 Philippe Normand <pnormand@igalia.com>
2042 [WPE] Optionally build Cog as external project and replacement for MiniBrowser
2043 https://bugs.webkit.org/show_bug.cgi?id=221518
2045 Reviewed by Adrian Perez de Castro.
2047 * Source/cmake/OptionsWPE.cmake: New variable for JSC forwarded headers path, useful
2048 uninstalled builds of projects depending on JSC.
2050 2021-02-09 Jonathan Bedard <jbedard@apple.com>
2052 AX: introduction.md broken architecture.png link
2053 https://bugs.webkit.org/show_bug.cgi?id=221607
2054 <rdar://problem/74140397>
2056 Reviewed by Sam Weinig.
2058 * Introduction.md: webkit2-process-architecture.png Moved to resources.
2060 2021-02-08 Alicia Boya García <aboya@igalia.com>
2062 ConsoleMessage: Don't encode string JSONLogValue's as JSON
2063 https://bugs.webkit.org/show_bug.cgi?id=221421
2065 Reviewed by Eric Carlson.
2067 Enable JavaScriptCore API tests.
2069 * Source/cmake/WebKitCommon.cmake:
2071 2021-02-05 Don Olmstead <don.olmstead@sony.com>
2073 [MSVC] Catalog warnings
2074 https://bugs.webkit.org/show_bug.cgi?id=199248
2076 Unreviewed build fix.
2078 Missed a warning generated when building AppleWin.
2080 * Source/cmake/OptionsMSVC.cmake:
2082 2021-02-05 Don Olmstead <don.olmstead@sony.com>
2084 [MSVC] Catalog warnings
2085 https://bugs.webkit.org/show_bug.cgi?id=199248
2087 Reviewed by Fujii Hironori.
2089 Catalog all the MSVC warnings providing the message and a link to documentation
2090 for the warning. Some warnings are noted as being against the style guide so they
2091 won't be addressed. All other warnings could potentially be fixed in the codebase.
2093 * Source/cmake/OptionsMSVC.cmake:
2095 2021-02-04 Adrian Perez de Castro <aperez@igalia.com>
2097 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.31.1 release
2099 * Source/cmake/OptionsWPE.cmake: Bump version numbers.
2101 2021-02-04 Philippe Normand <pnormand@igalia.com>
2103 [GStreamer] Misc Thunder nitpicks
2104 https://bugs.webkit.org/show_bug.cgi?id=221398
2106 Reviewed by Xabier Rodriguez-Calvar.
2108 * Source/cmake/FindThunder.cmake: Look-up Thunder through pkg-config before attempting a
2109 direct libocdm lookup.
2111 2021-02-01 Saam Barati <sbarati@apple.com>
2113 Lazily create m_windowCloseWatchpoints so we don't mistakenly think we have a frame when re-associating a document to a given cached frame
2114 https://bugs.webkit.org/show_bug.cgi?id=221098
2117 Reviewed by Ryosuke Niwa and Mark Lam.
2119 * ManualTests/dont-create-invalid-watchpoint-when-going-back.html: Added.
2120 * ManualTests/resources/empty-text.txt: Added.
2121 * ManualTests/resources/full_results.json: Added.
2122 * ManualTests/resources/test-results-page.html: Added.
2124 2021-02-01 Don Olmstead <don.olmstead@sony.com>
2126 [Curl] Enable FTP protocol only when ENABLE_FTPDIR is on
2127 https://bugs.webkit.org/show_bug.cgi?id=220941
2129 Reviewed by Fujii Hironori.
2131 Turn off ENABLE_FTPDIR for WinCairo. The version of cURL used has FTP support explicitly
2134 * Source/cmake/OptionsWin.cmake:
2136 2021-01-27 Yusuke Suzuki <ysuzuki@apple.com>
2138 WebAssembly: add support for stream APIs
2139 https://bugs.webkit.org/show_bug.cgi?id=173105
2141 Reviewed by Keith Miller.
2143 * Source/cmake/OptionsFTW.cmake:
2144 * Source/cmake/WebKitFeatures.cmake:
2146 2021-01-27 Angelos Oikonomopoulos <angelos@igalia.com>
2148 Set ruby-indent-level to 4
2149 https://bugs.webkit.org/show_bug.cgi?id=220982
2151 Reviewed by Fujii Hironori.
2153 All the ruby source files seem to default to 4 as the indent
2154 level; make it official.
2159 2021-01-23 Xan Lopez <xan@igalia.com>
2161 [JSC] Allow to build WebAssembly without B3
2162 https://bugs.webkit.org/show_bug.cgi?id=220365
2164 Reviewed by Yusuke Suzuki.
2166 Make the WebAssembly feature depend on Baseline JIT, not B3
2167 JIT. Also add a WEBASSEMBLY_B3JIT feature to enable or disable the
2168 B3 tier in WebAssembly.
2170 * Source/cmake/WebKitFeatures.cmake: disable on 32bit.
2172 2021-01-21 Fujii Hironori <Hironori.Fujii@sony.com>
2174 Remove ENABLE_USERSELECT_ALL macro which is enabled for all ports
2175 https://bugs.webkit.org/show_bug.cgi?id=100424
2177 Reviewed by Don Olmstead.
2179 * Source/cmake/OptionsMac.cmake:
2180 * Source/cmake/WebKitFeatures.cmake:
2182 2021-01-20 Yusuke Suzuki <ysuzuki@apple.com>
2184 Unreviewed, ANGLE should not be built in JSCOnly port
2186 ANGLE is not a part of JSC. Do not build it.
2188 * Source/cmake/OptionsJSCOnly.cmake:
2190 2021-01-19 Lauro Moura <lmoura@igalia.com>
2192 REGRESSION(r271580) [GTK] LTS/Debian build failure due to unsupported g-ir-scanner parameter
2193 https://bugs.webkit.org/show_bug.cgi?id=220730
2195 Reviewed by Philippe Normand.
2197 * Source/cmake/FindGObjectIntrospection.cmake: Expose variable about the
2198 presence of --sources-top-dirs.
2200 2021-01-14 Jonathan Bedard <jbedard@apple.com>
2202 [GitHub] Reference GitHub repository in readme
2203 https://bugs.webkit.org/show_bug.cgi?id=220611
2204 <rdar://problem/73173367>
2206 Reviewed by Aakash Jain.
2208 * ReadMe.md: Reference GitHub repository.
2210 2021-01-12 Fujii Hironori <Hironori.Fujii@sony.com>
2212 [PlayStation] Enable ENABLE_USERSELECT_ALL for -webkit-user-select:all support
2213 https://bugs.webkit.org/show_bug.cgi?id=220533
2215 Reviewed by Don Olmstead.
2217 * Source/cmake/OptionsPlayStation.cmake: Removed the line disabling ENABLE_USERSELECT_ALL.
2219 2021-01-12 Philippe Normand <pnormand@igalia.com>
2221 [GStreamer] Bump version requirement
2222 https://bugs.webkit.org/show_bug.cgi?id=220356
2224 Reviewed by Xabier Rodriguez-Calvar.
2226 * Source/cmake/GStreamerChecks.cmake: Bump required version to 1.14.
2228 2021-01-12 Xabier Rodriguez Calvar <calvaris@igalia.com>
2230 [GStreamer] Switch from ENABLE_ to USE_ in native audio/video and text sink options
2231 https://bugs.webkit.org/show_bug.cgi?id=220515
2233 Reviewed by Philippe Normand.
2235 * Source/cmake/GStreamerDefinitions.cmake: Add USE_ definitions.
2236 * Source/cmake/WebKitFeatures.cmake: Remove global ENABLE_
2239 2021-01-12 Carlos Garcia Campos <cgarcia@igalia.com>
2241 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.31.1 release
2243 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
2245 2021-01-11 Yoshiaki Jitsukawa <yoshiaki.jitsukawa@sony.com>
2247 [PlayStation] Add MiniBrowser
2248 https://bugs.webkit.org/show_bug.cgi?id=220359
2250 Reviewed by Don Olmstead.
2252 Enable Fullscreen API.
2254 * Source/cmake/OptionsPlayStation.cmake:
2256 2021-01-11 Xabier Rodriguez Calvar <calvaris@igalia.com>
2258 [GStreamer] Add support to build with native audio and video
2259 https://bugs.webkit.org/show_bug.cgi?id=220087
2261 Reviewed by Philippe Normand.
2263 * Source/cmake/GStreamerDefinitions.cmake: Enable TEXT_SINK.
2264 * Source/cmake/WebKitFeatures.cmake: Declare TEXT_SINK, NATIVE_VIDEO and NATIVE_AUDIO.
2266 2021-01-08 Ryan Hostetler <rhost@apple.com>
2268 Add support for source caching between platforms
2269 https://bugs.webkit.org/show_bug.cgi?id=220439
2272 Reviewed by Andy Estes.
2274 Include WebInspectorUI Source during any installsrc phase.
2278 2021-01-08 Fujii Hironori <Hironori.Fujii@sony.com>
2280 [Win] Enable ENABLE_USERSELECT_ALL for -webkit-user-select:all support
2281 https://bugs.webkit.org/show_bug.cgi?id=118740
2283 Reviewed by Don Olmstead.
2285 This change also fixes the assertion failure of
2286 editing/inserting/insert-list-user-select-none-crash.html
2289 * Source/cmake/OptionsFTW.cmake: Removed the line disabling ENABLE_USERSELECT_ALL.
2290 * Source/cmake/OptionsWin.cmake: Ditto.
2292 2021-01-07 Ryan Hostetler <rhost@apple.com>
2294 make clean/installsrc fail: You cannot specify -alltargets and also specify individual targets.
2295 https://bugs.webkit.org/show_bug.cgi?id=220370
2298 Reviewed by Andy Estes.
2300 Update hardcoded '-alltargets' to use new XCODE_TARGET variable.
2304 2021-01-07 Monson Shao <holymonson@gmail.com>
2306 [CMake] Add USE_APPLE_ICU option
2307 https://bugs.webkit.org/show_bug.cgi?id=220081
2309 Reviewed by Yusuke Suzuki.
2311 Add USE_APPLE_ICU option to allow non-Mac ports (GTK or JSCOnly) on Darwin could build with
2314 * Source/cmake/OptionsCommon.cmake:
2315 * Source/cmake/WebKitFindPackage.cmake:
2317 2021-01-06 Alexey Proskuryakov <ap@apple.com>
2319 Make svn status ignore Python 3 __pycache__ directories.
2323 Python 2 *.pyc files are still inconsistently handled via svn:ignore on each
2324 directory, but it is not worth cleaning up before GitHub move.
2326 * Tools: Added property svn:global-ignores.
2328 2021-01-06 Fujii Hironori <Hironori.Fujii@sony.com>
2330 [GTK][CMake] Add a build switch USE_OPENGL_OR_ES to be able to disable OpenGL and ES
2331 https://bugs.webkit.org/show_bug.cgi?id=220183
2333 Reviewed by Kenneth Russell.
2335 r270477 removed ENABLE_GRAPHICS_CONTEXT_GL macro and build switch,
2336 but GTK port still needs the build switch. Revert r270477
2337 partially to restore the build switch and rename it to
2340 * Source/cmake/OptionsGTK.cmake:
2342 2021-01-05 Fujii Hironori <Hironori.Fujii@sony.com>
2344 [WinCairo][curl] Enable CURLSSLOPT_NATIVE_CA flag to use system's CA certs instead of cacert.pem
2345 https://bugs.webkit.org/show_bug.cgi?id=220258
2347 Reviewed by Don Olmstead.
2349 Libcurl 7.71 added a new flag CURLSSLOPT_NATIVE_CA to use the
2350 operating system's native CA store only for Windows. Use the flag
2353 * Source/cmake/OptionsWinCairo.cmake: Bumped the minimum Curl version.
2355 2021-01-04 Lauro Moura <lmoura@igalia.com>
2357 [WebXR][WPE] Build fails without openxr installed
2358 https://bugs.webkit.org/show_bug.cgi?id=220250
2360 Reviewed by Carlos Alberto Lopez Perez.
2362 * Source/cmake/FindOpenXR.cmake: Fix some names and export
2364 * Source/cmake/OptionsWPE.cmake: Fail config is WebXR is enabled but
2365 couldn't find OpenXR.
2367 2021-01-04 Jeff Miller <jeffm@apple.com>
2369 Update user-visible copyright strings to include 2021
2370 https://bugs.webkit.org/show_bug.cgi?id=219901
2372 Reviewed by Anders Carlsson.
2374 * Source/cmake/tools/scripts/COPYRIGHT-END-YEAR:
2376 2020-12-23 Fujii Hironori <Hironori.Fujii@sony.com>
2378 [WinCairo] Enable WebGL 2
2379 https://bugs.webkit.org/show_bug.cgi?id=192314
2381 Reviewed by Kenneth Russell.
2383 * Source/cmake/OptionsWin.cmake: Turned ENABLE_WEBGL2 on.
2385 2020-12-23 Monson Shao <holymonson@gmail.com>
2387 [CMake] Fix seperated include dir of harfbuzz and harfbuzz-icu
2388 https://bugs.webkit.org/show_bug.cgi?id=220082
2390 Reviewed by Alex Christensen.
2392 In some distros (NixOS) harfbuzz and harfbuzz-icu may have different include dir.
2394 * Source/cmake/FindHarfBuzz.cmake:
2396 2020-12-21 Ryan Hostetler <rhost@apple.com>
2398 $(findstring iphone,$(SDKROOT)) fails when SDKROOT is not lowercase
2399 https://bugs.webkit.org/show_bug.cgi?id=219993
2402 Reviewed by Darin Adler.
2404 Update SDKROOT evaluation to be lowercase and SDK filename only.
2408 2020-12-16 Fujii Hironori <Hironori.Fujii@sony.com>
2410 [WinCairo] Enable USE_ANGLE
2411 https://bugs.webkit.org/show_bug.cgi?id=219421
2413 Reviewed by Don Olmstead.
2415 * Source/cmake/OptionsWinCairo.cmake:
2417 2020-12-13 Don Olmstead <don.olmstead@sony.com>
2419 [CMake] Version of LibPSL not reported
2420 https://bugs.webkit.org/show_bug.cgi?id=219837
2422 Reviewed by Adrian Perez de Castro.
2424 When determining the version of LibPSL from the header file LIBPSL_VERSION was set
2425 but the VERSION_VAR reported was LibPSL_VERSION. Consistently use LibPSL_VERSION
2426 within the file to prevent this.
2428 Additionally LibPSL_LIBRARY not LibPSL_LIBRARIES should be marked_as_advanced.
2430 * Source/cmake/FindLibPSL.cmake:
2432 2020-12-11 Don Olmstead <don.olmstead@sony.com>
2434 [CMake] Determine correct visibility for linked frameworks
2435 https://bugs.webkit.org/show_bug.cgi?id=210366
2437 Reviewed by Michael Catanzaro.
2439 WebKit has some frameworks that are compiled statically into a larger shared library. For
2440 example Apple compiles bmalloc and WTF into JavaScriptCore. This means the JavaScriptCore
2441 framework also exposes the symbols for those two libraries and that targets depending
2442 on WTF or bmalloc should link to JavaScriptCore and never to WTF or bmalloc directly.
2444 The CMake code allows each port to decide the type of library for a WEBKIT_FRAMEWORK.
2445 This means there are many different combinations that it needs to support. To ensure that
2446 everything links properly some bookkeeping is required.
2448 WEBKIT_FRAMEWORK now uses ${target}_FRAMEWORKS to determine how to link the frameworks
2449 it depends on. First the macro determines if the framework is a SHARED library or is linked
2450 into a shared library, and if so it is linked as PUBLIC. If the framework itself is not a
2451 SHARED library, then it links other STATIC/OBJECT framework as PUBLIC. If the framework
2452 itself is SHARED then any framework that is a STATIC/OBJECT library is linked as PRIVATE
2453 to stop propagation. The linked framework's header directories are added to the
2454 WebKit::${framework} target to allow the framework to present as that framework. A global
2455 property is set to inform consumers that they should link to this different framework
2456 to get the requested framework.
2458 This ensures that all ports can ship with hidden visibility turned on which is a precursor
2459 to a port turning on link time optimization (LTO).
2461 * Source/cmake/WebKitMacros.cmake:
2463 2020-12-10 Don Olmstead <don.olmstead@sony.com>
2465 [CMake] Determine when to use $<TARGET_OBJECTS> for executables
2466 https://bugs.webkit.org/show_bug.cgi?id=219648
2468 Reviewed by Michael Catanzaro.
2470 When a WebKit framework is declared as an OBJECT library the WebKit::${framework} ALIAS
2471 does not propagate the objects to the executable being built. As a workaround ports will
2472 explicitly add $<TARGET_OBJECTS> to the list of libraries being linked. There is already
2473 enough information to determine when $<TARGET_OBJECTS> is needed so this decision is moved
2474 into the WEBKIT_EXECUTABLE macros.
2476 An additional ${taget_name}_FRAMEWORKS variable is added which specifies the WebKit
2477 frameworks being used. This will link the WebKit::${framework} alias and if necessary the
2478 associated $<TARGET_OBJECTS>.
2480 This functionality will be expanded upon when support for ${target_name}_FRAMEWORKS is
2481 added to WebKit frameworks to support hidden visibility across ports.
2483 * Source/cmake/WebKitMacros.cmake:
2485 2020-12-07 Don Olmstead <don.olmstead@sony.com>
2487 [CMake] Remove WEBKIT_WRAP_SOURCELIST
2488 https://bugs.webkit.org/show_bug.cgi?id=196916
2490 Reviewed by Michael Catanzaro.
2492 WEBKIT_WRAP_SOURCELIST macro is used only to adjust source groups in Visual Studio
2493 projects without any impact on build process. Its references variable specific to
2494 particular targets (WebCore) which contradicts our goal of having target-oriented
2495 CMake project. It can be reintroduced later in a more clean way, in case anyone needs
2496 to have such grouping.
2498 * Source/cmake/WebKitMacros.cmake:
2500 2020-12-05 Fujii Hironori <Hironori.Fujii@sony.com>
2502 Remove ENABLE_GRAPHICS_CONTEXT_GL by replacing it with ENABLE(WEBGL)
2503 https://bugs.webkit.org/show_bug.cgi?id=219551
2505 Reviewed by Kenneth Russell.
2507 * Source/CMakeLists.txt:
2508 * Source/cmake/GStreamerDependencies.cmake:
2509 * Source/cmake/OptionsFTW.cmake:
2510 * Source/cmake/OptionsGTK.cmake:
2511 * Source/cmake/OptionsMac.cmake:
2512 * Source/cmake/OptionsPlayStation.cmake:
2513 * Source/cmake/OptionsWPE.cmake:
2514 * Source/cmake/OptionsWinCairo.cmake:
2516 2020-11-26 Lauro Moura <lmoura@igalia.com>
2518 [GTK][GTK4] Building with GObject-Introspection support does not work
2519 https://bugs.webkit.org/show_bug.cgi?id=219221
2521 Reviewed by Carlos Garcia Campos.
2523 * Source/cmake/OptionsGTK.cmake: Allow introspection with GTK4.
2525 2020-11-26 Fujii Hironori <Hironori.Fujii@sony.com>
2527 [WinCairo] Enable GPU process
2528 https://bugs.webkit.org/show_bug.cgi?id=219294
2530 Reviewed by Don Olmstead.
2532 * Source/cmake/OptionsWin.cmake: Turned ENABLE_GPU_PROCESS on for WinCairo.
2534 2020-11-26 Yoshiaki Jitsukawa <yoshiaki.jitsukawa@sony.com>
2536 [PlayStation] Enable ResourceLoadStatistics
2537 https://bugs.webkit.org/show_bug.cgi?id=219292
2539 Reviewed by Fujii Hironori.
2541 * Source/cmake/OptionsPlayStation.cmake:
2543 2020-11-20 Don Olmstead <don.olmstead@sony.com>
2546 https://bugs.webkit.org/show_bug.cgi?id=219206
2548 Reviewed by Anders Carlsson.
2550 Remove the ability to set ENABLE_QUOTA. The Storage Quota API is deprecated and no
2551 WebKit port is enabling it.
2553 * Source/cmake/OptionsFTW.cmake:
2554 * Source/cmake/OptionsWin.cmake:
2555 * Source/cmake/WebKitFeatures.cmake:
2556 * Source/cmake/tools/vsprops/FeatureDefines.props:
2557 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
2559 2020-11-09 Michael Catanzaro <mcatanzaro@gnome.org>
2561 Enable llint asm on aarch64 when USE(64KB_PAGE_BLOCK) is enabled
2562 https://bugs.webkit.org/show_bug.cgi?id=218613
2564 Reviewed by Carlos Alberto Lopez Perez.
2566 Normally we fall back to cloop when JIT is not supported. But on aarch64, llint asm is well-
2567 supported, so it is safe to use that here. This will only happen on aarch64, and only when
2568 USE(64KB_PAGE_BLOCK) is enabled, which should probably only be used by RHEL and SUSE.
2569 Everyone else should get the JIT.
2571 * Source/cmake/WebKitFeatures.cmake:
2573 2020-11-04 Sergey Rubanov <chi187@gmail.com>
2575 Fix JSC build on macOS Big Sur
2576 https://bugs.webkit.org/show_bug.cgi?id=218566
2578 Reviewed by David Kilzer.
2580 * Source/cmake/WebKitFindPackage.cmake:
2582 2020-11-04 Michael Catanzaro <mcatanzaro@gnome.org>
2584 Add new build option USE(64KB_PAGE_BLOCK)
2585 https://bugs.webkit.org/show_bug.cgi?id=217989
2587 Reviewed by Yusuke Suzuki.
2589 Why do we need this option? Because JSC and bmalloc both want to know the userspace page
2590 size at compile time, which is impossible on Linux because it's a runtime setting. We
2591 cannot test the system page size at build time in hopes that it will be the same on the
2592 target system, because (a) cross compiling wouldn't work, and (b) the build system could
2593 use a different page size than the target system (which will be true for Fedora aarch64,
2594 because Fedora is built using RHEL), so the best we can do is guess based on the target CPU
2595 architecture. In practice, guessing works for all architectures except aarch64 (unless
2596 unusual page sizes are used), but it fails for aarch64 because distros are split between
2597 using 4 KB and 64 KB pages there. Most distros (including Fedora) use 4 KB, but RHEL uses
2598 64 KB. SUSE actually supports both. Since there is no way to guess correctly, the best we
2599 can do is provide an option for it. You should probably only use this if building for
2600 aarch64. Otherwise, known CPUs except PowerPC will use 4 KB, while PowerPC and unknown CPUs
2601 will use 64 KB (see wtf/PageBlock.h). aarch64 will continue to default to 4 KB because this
2602 is a much better default on systems where it doesn't crash.
2604 Having one flag will help avoid mistakes. E.g. both RHEL and SUSE were manually passing
2605 -DENABLE_JIT=OFF and -DUSE_SYSTEM_MALLOC=ON, but we missed -DENABLE_C_LOOP=ON and
2606 -DENABLE_SAMPLING_PROFILER=OFF, so wound up running with both JIT and cloop disabled, a
2607 configuration not otherwise used on Linux (and not supported by GTK or WPE ports). It will
2608 be easier to not mess up if we only have to pass one special build option. This will also
2609 allow us to stop patching PageBlock.h downstream, because I don't like downstream patches
2610 that we have to keep forever.
2612 * Source/cmake/WebKitFeatures.cmake:
2614 2020-10-30 Ryosuke Niwa <rniwa@webkit.org>
2616 Add Introduction to WebKit
2617 https://bugs.webkit.org/show_bug.cgi?id=217017
2619 Rubber-stamped by Simon Fraser.
2621 Added the basic introductory documentation for WebKit.
2623 * Introduction.md: Added.
2624 * resources/js-wrapper.png: Added.
2625 * resources/webkit2-process-architecture.png: Added.
2626 * resources/xcode-add-file.png: Added.
2627 * resources/xcode-build-settings-for-run.png: Added.
2628 * resources/xcode-export-header.png: Added.
2629 * resources/xcode-scheme-dumprendertree.png: Added.
2630 * resources/xcode-scheme-layout-test.png: Added.
2631 * resources/xcode-workspace-build-location.png: Added.
2632 * resources/xcode-workspace-settings.png: Added.
2634 2020-10-30 Jonathan Bedard <jbedard@apple.com>
2636 Github mirror ReadMe need to update
2637 https://bugs.webkit.org/show_bug.cgi?id=218120
2638 <rdar://problem/70861595>
2640 Reviewed by Aakash Jain.
2644 2020-10-27 Keith Rollin <krollin@apple.com>
2646 Fix "usage" message when invoking `ar -V`
2647 https://bugs.webkit.org/show_bug.cgi?id=218255
2648 <rdar://problem/70735674>
2650 Reviewed by Fujii Hironori.
2652 The Mac/BSD version of `ar` does not support the -V flag. This flag is
2653 used unconditionally in OptionsCommon.cmake when trying to determine
2654 if the installed `ar` supports the thinning of archives, leading to a
2655 "usage" message being emitted on macOS.
2657 Avoid this message by capturing the error-output. Examine the output
2658 to see if it's a "usage" message. If so, then treat the `ar` as one
2659 that does not support thinning. Any other error-output is printed as a
2660 warning. If there is no error-output, continue processing as normal.
2662 * Source/cmake/OptionsCommon.cmake:
2664 2020-10-27 Brian Burg <bburg@apple.com>
2666 Web Inspector: add ENABLE(INSPECTOR_EXTENSIONS) to feature defines
2667 https://bugs.webkit.org/show_bug.cgi?id=218237
2668 <rdar://problem/69968787>
2670 Reviewed by Antti Koivisto.
2672 * Source/cmake/OptionsMac.cmake:
2673 * Source/cmake/WebKitFeatures.cmake:
2674 Add ENABLE(INSPECTOR_EXTENSIONS), which is only on for the Cocoa macOS port.
2676 2020-10-26 Keith Rollin <krollin@apple.com>
2678 Move some initialization code from top-level CMakeLists.txt to WebKitCommon.cmake
2679 https://bugs.webkit.org/show_bug.cgi?id=218069
2680 <rdar://problem/70556952>
2682 Reviewed by Fujii Hironori.
2684 Moving this initialization code into a central location allows other
2685 top-level CMakeLists.txt files to include WebKitCommon.cmake and get
2686 that same initialization.
2689 * Source/cmake/WebKitCommon.cmake:
2691 2020-10-23 Philippe Normand <pnormand@igalia.com>
2693 [GStreamer] Replace USE(WEBAUDIO_GSTREAMER) with USE(GSTREAMER)
2694 https://bugs.webkit.org/show_bug.cgi?id=218083
2696 Reviewed by Xabier Rodriguez-Calvar.
2698 A separate define was introduced back when we thought enabling WebAudio without enabling
2699 <audio> would be a highly relevant scenario. I don't think it is very relevant, let's clean
2702 * Source/cmake/GStreamerChecks.cmake: Wrap the WebAudio platform bits in the USE(GSTREAMER) umbrella.
2704 2020-10-21 Carlos Garcia Campos <cgarcia@igalia.com>
2706 WebDriver: add support for wheel actions
2707 https://bugs.webkit.org/show_bug.cgi?id=217174
2709 Reviewed by Brian Burg.
2711 Enable WEBDRIVER_WHEEL_INTERACTIONS for GTK and WPE ports.
2713 * Source/cmake/OptionsGTK.cmake:
2714 * Source/cmake/OptionsWPE.cmake:
2715 * Source/cmake/WebKitFeatures.cmake:
2717 2020-10-20 Michael Catanzaro <mcatanzaro@gnome.org>
2719 [GTK] Move ENABLE_ASYNC_SCROLLING build option to right place in OptionsGTK.cmake
2720 https://bugs.webkit.org/show_bug.cgi?id=217977
2722 Unreviewed. No functional changes.
2724 * Source/cmake/OptionsGTK.cmake:
2726 2020-10-20 Adrian Perez de Castro <aperez@igalia.com>
2728 [GTK] Implement HTML5 Gamepad API
2729 https://bugs.webkit.org/show_bug.cgi?id=133847
2731 Reviewed by Michael Catanzaro.
2733 Enable the gamepad support by default for the GTK port. The option is marked PUBLIC
2734 because libmanette is not available in the current Debian "old stable" (Buster), which
2735 we need to support until September 2021.
2737 * Source/cmake/OptionsGTK.cmake: Set ENABLE_GAMEPAD to PUBLIC and ON by default.
2739 2020-10-19 Lauro Moura <lmoura@igalia.com>
2741 REGRESSION(r268115) [GTK] Build failures with GCC 7 (Ubuntu 18.04) and GCC 8 (Debian Buster)
2742 https://bugs.webkit.org/show_bug.cgi?id=217425
2744 Reviewed by Carlos Alberto Lopez Perez.
2746 The root cause is lack of proper <filesystem> support in gcc7/8 (and
2747 incompatibility with llvm's header that was included). As such, we
2748 need to check whether to use <filesystem>, <experimental/filesystem>,
2749 or fallback to the included header.
2751 Note: In some systems like Ubuntu 20.04, gcc-8 can use gcc-9's
2752 libstdc++ and link successfully, but running will fail as it should
2753 actually link with its libstc++fs to provide the correct symbols. As
2754 this is some corner case (Ubuntu's 20 default gcc is 9), LDFLAGS
2755 can be used to overcome this.
2757 * Source/cmake/OptionsCommon.cmake: Add a HAVE directive to
2758 check whether <experimental/filesystem> is the filesystem impl
2760 * Source/cmake/WebKitCompilerFlags.cmake: Test first whether
2761 <filesystem> can be used, with <experimental/filestystem> as fallback.
2763 2020-10-14 Zan Dobersek <zdobersek@igalia.com>
2765 Remove ACCELERATED_2D_CANVAS build flags and guarded code
2766 https://bugs.webkit.org/show_bug.cgi?id=217603
2768 Reviewed by Carlos Garcia Campos.
2770 Yank the CMake ENABLE_ACCELERATED_2D_CANVAS option now that it won't
2771 have any effect. FindCairoGL.cmake can also be removed.
2773 * Source/cmake/FindCairoGL.cmake: Removed.
2774 * Source/cmake/OptionsFTW.cmake:
2775 * Source/cmake/OptionsGTK.cmake:
2776 * Source/cmake/OptionsWPE.cmake:
2777 * Source/cmake/OptionsWin.cmake:
2778 * Source/cmake/WebKitFeatures.cmake:
2779 * Source/cmake/tools/vsprops/FeatureDefines.props:
2780 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
2782 2020-10-13 Adrian Perez de Castro <aperez@igalia.com>
2784 [GTK] Set ENABLE_GAMEPAD=ON for developer builds
2785 https://bugs.webkit.org/show_bug.cgi?id=217493
2787 Reviewed by Carlos Garcia Campos.
2789 * Source/cmake/OptionsGTK.cmake: Make the default value of ENABLE_GAMEPAD
2790 depend on ENABLE_EXPERIMENTAL_FEATURES.
2792 2020-10-13 Michael Catanzaro <mcatanzaro@gnome.org>
2794 [WPE][GTK] ENABLE_SHAREABLE_RESOURCE should be PRIVATE build option
2795 https://bugs.webkit.org/show_bug.cgi?id=217592
2797 Reviewed by Carlos Garcia Campos.
2799 * Source/cmake/OptionsGTK.cmake:
2800 * Source/cmake/OptionsWPE.cmake:
2802 2020-10-09 Fujii Hironori <Hironori.Fujii@sony.com>
2804 [WinCairo][GraphicsLayerTextureMapper] backdrop-filter support
2805 https://bugs.webkit.org/show_bug.cgi?id=217081
2807 Reviewed by Don Olmstead.
2809 * Source/cmake/OptionsWin.cmake: Turn ENABLE_FILTERS_LEVEL_2 on for WinCairo.
2811 2020-10-08 Keith Rollin <krollin@apple.com>
2813 Remove copy-webkitlibraries-to-product-directory
2814 https://bugs.webkit.org/show_bug.cgi?id=217465
2815 <rdar://problem/70082193>
2817 Reviewed by Darin Adler.
2819 This script no longer does anything, so remove it along with the
2820 scaffolding around it that invokes it during the build.
2824 2020-10-04 Ryan Hostetler <rhost@apple.com>
2826 Submission failure with "make: *** No rule to make target `installsrc'. Stop"
2827 https://bugs.webkit.org/show_bug.cgi?id=214696
2828 <rdar://problem/62268104>
2830 Reviewed by Darin Adler.
2832 Add installsrc phase to support xbs submitproject for WebKit repository.
2833 This change allows internal tools to submit and build in a single step.
2839 2020-10-02 Keith Rollin <krollin@apple.com>
2841 Seeing "usage: basename string [suffix]" spam when using make to build
2842 https://bugs.webkit.org/show_bug.cgi?id=217231
2843 <rdar://problem/69889138>
2845 Reviewed by Darin Adler.
2847 The name of the project being built is no longer displayed when using
2848 XCBuild. Therefore, https://bugs.webkit.org/show_bug.cgi?id=216865
2849 taught the Makefile to perform this logging. The approach took
2850 advantage of a `make` variable (PATH_FROM_ROOT) that tracks the
2851 relative path from the root of the build hierarchy to the current
2852 project. However, that variable may not be initialized if the build is
2853 not initiated from the root. Therefore, don't count on that variable,
2854 and get the name of the current project by invoking `pwd`.
2858 2020-10-02 Sam Weinig <weinig@apple.com>
2860 Remove code behind ENABLE(MEDIA_SESSION), no ports enable it
2861 https://bugs.webkit.org/show_bug.cgi?id=216831
2863 Reviewed by Alex Christensen.
2865 * Source/cmake/OptionsFTW.cmake:
2866 * Source/cmake/WebKitFeatures.cmake:
2867 Remove option to build with MEDIA_SESSION, no one was doing it.
2869 2020-10-02 Karl Rackler <rackler@apple.com>
2871 Unreviewed, reverting r267796.
2873 This change is breaking the build on AzulE debug bots.
2877 "Remove code behind ENABLE(MEDIA_SESSION), no ports enable it"
2878 https://bugs.webkit.org/show_bug.cgi?id=216831
2879 https://trac.webkit.org/changeset/267796
2881 2020-10-02 Adrian Perez de Castro <aperez@igalia.com>
2883 [GTK] Build broken with ENABLE_MEDIA_STREAM enabled and ENABLE_WEB_RTC_DISABLED
2884 https://bugs.webkit.org/show_bug.cgi?id=217128
2886 Reviewed by Philippe Normand.
2888 * Source/cmake/GStreamerChecks.cmake: Only enable USE_LIBWEBRTC when both
2889 ENABLE_MEDIA_STREAM and ENABLE_WEB_RTC is defined. This prevents trying to
2890 build code that uses libwebrtc types when ENABLE_WEB_RTC is disabled but
2891 ENABLE_MEDIA_STREAM is enabled.
2893 2020-09-30 Sam Weinig <weinig@apple.com>
2895 Remove code behind ENABLE(MEDIA_SESSION), no ports enable it
2896 https://bugs.webkit.org/show_bug.cgi?id=216831
2898 Reviewed by Alex Christensen.
2900 * Source/cmake/OptionsFTW.cmake:
2901 * Source/cmake/WebKitFeatures.cmake:
2902 Remove option to build with MEDIA_SESSION, no one was doing it.
2904 2020-09-30 Philippe Normand <pnormand@igalia.com>
2906 [GStreamer] Internal audio rendering support
2907 https://bugs.webkit.org/show_bug.cgi?id=207634
2909 Reviewed by Xabier Rodriguez-Calvar.
2911 * Source/cmake/FindWPEBackend_fdo.cmake: Check for the audio extension header initially
2912 shipped in the 1.8.0 release.
2913 * Source/cmake/GStreamerChecks.cmake: Check and enable external audio rendering support if
2914 the WPEBackend-FDO audio extension was found.
2916 2020-09-29 Don Olmstead <don.olmstead@sony.com>
2918 [CMake][WebGPU] Add FindDawn module
2919 https://bugs.webkit.org/show_bug.cgi?id=217097
2921 Reviewed by Darin Adler.
2923 Add a FindDawn CMake module to use for a WebGPU implementation on non-Cocoa platforms.
2924 If ENABLE_WEBGPU is on for WinCairo it will attempt to detect Dawn.
2926 * Source/cmake/FindDawn.cmake: Added.
2927 * Source/cmake/OptionsWinCairo.cmake:
2929 2020-09-28 Keith Rollin <krollin@apple.com>
2931 Print message saying what project is being built
2932 https://bugs.webkit.org/show_bug.cgi?id=216865
2933 <rdar://problem/69408135>
2935 Reviewed by Andy Estes.
2937 XCBuild removes the progress messages saying which project/target is
2938 being built. We can't show the target, but update the Makefiles to at
2939 least show which project is being built.
2943 2020-09-27 Philippe Normand <pnormand@igalia.com>
2945 Add .ccls config file
2946 https://bugs.webkit.org/show_bug.cgi?id=216877
2948 Reviewed by Darin Adler.
2950 ccls is a stand-alone server implementing the Language Server Protocol for C, C++, and
2951 Objective-C languages. It can be used with any editor which provides an LSP client
2952 implementation. It originates from cquery.
2954 https://github.com/MaskRay/ccls/wiki
2956 It's basically used to provide semantic highlighting and code navigation. Many IDEs support
2962 2020-09-25 Fujii Hironori <Hironori.Fujii@sony.com>
2964 make_names.pl no longer needs C preprocessor
2965 https://bugs.webkit.org/show_bug.cgi?id=216953
2967 Reviewed by Sam Weinig.
2969 * Source/cmake/WebKitCompilerFlags.cmake: Removed CODE_GENERATOR_PREPROCESSOR_WITH_LINEMARKERS which was used only for make_names.pl.
2971 2020-09-25 Antti Koivisto <antti@apple.com>
2973 [LFC][Integration] Enable on Apple Windows port
2974 https://bugs.webkit.org/show_bug.cgi?id=216928
2975 <rdar://problem/69505961>
2977 Reviewed by Zalan Bujtas.
2979 * Source/cmake/OptionsWin.cmake:
2981 2020-09-23 Fujii Hironori <Hironori.Fujii@sony.com>
2983 Remove ENABLE_SVG_FONTS macro
2984 https://bugs.webkit.org/show_bug.cgi?id=216850
2986 Reviewed by Don Olmstead.
2988 No ports have this disabled, so remove it.
2990 * Source/cmake/OptionsFTW.cmake:
2991 * Source/cmake/OptionsMac.cmake:
2992 * Source/cmake/OptionsWin.cmake:
2993 * Source/cmake/WebKitFeatures.cmake:
2994 * Source/cmake/tools/vsprops/FeatureDefines.props:
2995 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
2997 2020-09-22 Keith Rollin <krollin@apple.com>
2999 Unify debug and release target aliases
3000 https://bugs.webkit.org/show_bug.cgi?id=216863
3001 <rdar://problem/69407746>
3003 Reviewed by Tim Horton.
3005 All Makefiles have "debug", "d", "release", and "r" for build
3006 targets. Others -- but not all -- also include "dev", "develop",
3007 "development", "dep", "deploy", and "deployment". Because of this
3008 inconsistency, trying to use those additional targets didn't work. It
3009 looks like all Makefiles used to support all of those targets, but
3010 some got dropped along the way. For instance, the top-level Makefile
3011 and Source/Makefile dropped them in 2013 as part of Bug 107863. And it
3012 looks like WebKitLibraries/Makefile never had them. Given that those
3013 additional targets don't work, it seems like no one uses them, so
3014 let's remove them completely.
3018 2020-09-22 Keith Rollin <krollin@apple.com>
3020 Refactor build rules in Makefiles and Makefile.shared
3021 https://bugs.webkit.org/show_bug.cgi?id=216806
3022 <rdar://problem/69332316>
3024 Reviewed by David Kilzer.
3026 Build fix: Previous change for this bug broke the ability to perform a
3027 build with just `make`, due to that code path invoking
3028 `set-webkit-configuration` with no parameters, which causes that
3029 script to error-out.
3033 2020-09-22 Keith Rollin <krollin@apple.com>
3035 Refactor build rules in Makefiles and Makefile.shared
3036 https://bugs.webkit.org/show_bug.cgi?id=216806
3037 <rdar://problem/69332316>
3039 Reviewed by David Kilzer.
3041 Factor out the common aspects of the build rules in Makefile.shared
3042 and the various Makefiles. This allows us to more easily see what's
3043 different between the various build targets, and to apply uniform
3044 changes across all of the targets.
3050 2020-09-22 Jonathan Bedard <jbedard@apple.com>
3052 Correct instructions for building iOS in ReadMe
3053 https://bugs.webkit.org/show_bug.cgi?id=216825
3054 <rdar://problem/69372654>
3056 Reviewed by David Kilzer.
3058 * ReadMe.md: Update iOS build instructions to apply to all embedded platforms.
3060 2020-09-21 Adrian Perez de Castro <aperez@igalia.com>
3062 [CMake] Use imported targets in find module for the ATK SPI2 bridge dependency
3063 https://bugs.webkit.org/show_bug.cgi?id=216773
3065 Reviewed by Don Olmstead.
3067 * Source/cmake/FindATKBridge.cmake: Rewrite to define an ATK::Bridge imported target.
3068 * Source/cmake/OptionsWPE.cmake: Use the ATK::Bridge imported target.
3070 2020-09-16 Fujii Hironori <Hironori.Fujii@sony.com>
3072 [CMake] Add a new library target TestRunnerShared
3073 https://bugs.webkit.org/show_bug.cgi?id=216465
3075 WinCairo port is using both DRT and WTR. However, it has a problem
3076 for precompiled header builds to compile the source of
3077 TestRunnerShared twice for DRT and WTR.
3079 Add a new library target TestRunnerShared. Re-enable precompiled
3080 header for DRT and WTR for WinCairo.
3082 Reviewed by Don Olmstead.
3084 * Source/cmake/OptionsWinCairo.cmake:
3085 * Source/cmake/WebKitFS.cmake:
3087 2020-09-16 Stephan Szabo <stephan.szabo@sony.com>
3089 Remove ENABLE_METER_ELEMENT
3090 https://bugs.webkit.org/show_bug.cgi?id=216582
3092 Reviewed by Fujii Hironori.
3094 With PlayStation finally planning to turn this on,
3095 no ports had this disabled, so remove the enable flag.
3097 * Source/cmake/OptionsFTW.cmake:
3098 * Source/cmake/OptionsMac.cmake:
3099 * Source/cmake/OptionsPlayStation.cmake:
3100 * Source/cmake/OptionsWin.cmake:
3101 * Source/cmake/WebKitFeatures.cmake:
3102 * Source/cmake/tools/vsprops/FeatureDefines.props:
3103 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
3105 2020-09-15 David Kilzer <ddkilzer@apple.com>
3107 WebKit should support building with clang ThreadSanitizer enabled
3108 <https://webkit.org/b/216318>
3109 <rdar://problem/31615729>
3111 Reviewed by Darin Adler.
3113 This patch doesn't attempt to resolve every potential false
3114 positive, but makes it easy to build WebKit with TSan enabled.
3117 - Update to work with `make [args] TSAN=YES`.
3119 2020-09-14 Fujii Hironori <Hironori.Fujii@sony.com>
3121 [PlayStation] Enable ENABLE_SVG_FONTS
3122 https://bugs.webkit.org/show_bug.cgi?id=216522
3124 Reviewed by Don Olmstead.
3126 * Source/cmake/OptionsPlayStation.cmake:
3128 2020-09-12 Myles C. Maxfield <mmaxfield@apple.com>
3130 [Apple Win] Add a CTFont member to FontPlatformData
3131 https://bugs.webkit.org/show_bug.cgi?id=216432
3133 Reviewed by Darin Adler.
3135 Include ***CoreText.cpp files on the Apple Win port.
3137 * Source/cmake/OptionsAppleWin.cmake:
3139 2020-09-10 Adrian Perez de Castro <aperez@igalia.com>
3141 [CMake] Use imported targets in find module for libseccomp
3142 https://bugs.webkit.org/show_bug.cgi?id=216329
3144 Reviewed by Don Olmstead.
3146 * Source/cmake/BubblewrapSandboxChecks.cmake: Use Libseccomp_FOUND.
3147 * Source/cmake/FindLibseccomp.cmake: Rewrite to define the
3148 Libseccomp::Libseccomp target, fall-back to read version from the main
3149 header, and define variables with Libseccomp_ as prefix.
3151 2020-09-04 Adrian Perez de Castro <aperez@igalia.com>
3153 Unreviewed. [WPE] Bump version numbers
3155 * Source/cmake/OptionsWPE.cmake:
3157 2020-09-04 Carlos Garcia Campos <cgarcia@igalia.com>
3159 Unreviewed. [GTK] Bump version numbers
3161 * Source/cmake/OptionsGTK.cmake:
3163 2020-09-02 Philippe Normand <pnormand@igalia.com>
3165 [Flatpak SDK] Update to FDO 20.08
3166 https://bugs.webkit.org/show_bug.cgi?id=215763
3168 Reviewed by Žan Doberšek.
3170 * .gitignore: Ignore buildstream local Flatpak repository. This is created only when
3171 manually building the SDK.
3173 2020-08-31 Stephan Szabo <stephan.szabo@sony.com>
3175 [PlayStation] Build fix for intermittent copy errors
3176 https://bugs.webkit.org/show_bug.cgi?id=215951
3178 Reviewed by Ross Kirsling.
3180 * Source/cmake/OptionsPlayStation.cmake:
3181 When copying platform specific files into the binary
3182 directory post build on executable targets, we'd
3183 intermittently get copy errors in parallel builds.
3185 2020-08-28 Adrian Perez de Castro <aperez@igalia.com>
3187 [WPE] Enable Notifications support
3188 https://bugs.webkit.org/show_bug.cgi?id=215924
3190 Reviewed by Philippe Normand.
3192 Enable web notifications support for the WPE port. The code is shared with the GTK
3193 port, but as we do not try to find and enable libnotify the default implementation
3194 is a stub: embedders can customize how to display notifications by connecting to
3195 the WebKitWebView:show-notification signal. This way we do not add any additional
3198 * Source/cmake/OptionsWPE.cmake: Flip ENABLE_NOTIFICATIONS to ON.
3200 2020-08-27 Stephan Szabo <stephan.szabo@sony.com>
3202 [PlayStation] Build fix due to memmem not always being available.
3203 https://bugs.webkit.org/show_bug.cgi?id=215893
3205 Unreviewed build fix
3207 * Source/cmake/OptionsPlayStation.cmake: Check for memmem
3209 2020-08-22 Philippe Normand <pnormand@igalia.com>
3211 [GTK][WPE] Compilation warnings with clang/gcc 10
3212 https://bugs.webkit.org/show_bug.cgi?id=215699
3214 Reviewed by Darin Adler.
3216 * Source/cmake/WebKitCompilerFlags.cmake: Disable tautological-compare and
3217 misleading-indentation warnings triggering false-positive when building JSC.
3219 2020-08-17 Carlos Garcia Campos <cgarcia@igalia.com>
3221 [GTK][WPE] Remove support for NPAPI plugins
3222 https://bugs.webkit.org/show_bug.cgi?id=215503
3224 Reviewed by Darin Adler.
3226 * Source/cmake/OptionsGTK.cmake:
3228 2020-08-12 Keith Rollin <krollin@apple.com>
3230 Remove the need for defining USE_NEW_BUILD_SYSTEM
3231 https://bugs.webkit.org/show_bug.cgi?id=215439
3233 Reviewed by Darin Adler.
3235 When building WebKit for XCBuild, we currently require that the
3236 external build system (such as the Makefile, build-webkit, etc.)
3237 defines the USE_NEW_BUILD_SYSTEM=YES build setting. This build setting
3238 controls parts of our build instructions that are sensitive to when
3239 XCBuild or the Legacy build system are being used. Notably, we need to
3240 know when to use our custom “copy and modify” scripts with copying
3241 certain header files (used with the Legacy build system) vs. using the
3242 enhanced Copy Headers build phase that’s enabled with
3243 APPLY_RULES_IN_COPY_HEADERS=YES (introduced with and used by XCBuild).
3244 The choice of which method to copy headers is used is controlled by
3245 USE_NEW_BUILD_SYSTEM.
3247 There is no built-in build setting that we can probe to help us
3248 determine which approach to take when copying and modifying headers,
3249 which is why we need to define USE_NEW_BUILD_SYSTEM ourselves. But it
3250 turns out that we can *detect* which build system is being used by
3251 taking advantage of a subtle difference between the two systems. As
3254 https://developer.apple.com/documentation/xcode-release-notes/build-system-release-notes-for-xcode-10
3256 “When an .xcconfig file contains multiple assignments of the same
3257 build setting, later assignments using $(inherited) or
3258 $(<setting_name>) will inherit from earlier assignments in the
3259 .xcconfig. The legacy build system caused every use of
3260 $(inherited) or $(<setting_name>) skip any other values defined
3261 within the .xcconfig.”
3263 This difference can be exploited as follows:
3265 WK_WHICH_BUILD_SYSTEM = not_
3266 WK_WHICH_BUILD_SYSTEM = $(inherited)legacy
3267 WK_USE_NEW_BUILD_SYSTEM = $(WK_USE_NEW_BUILD_SYSTEM_$(WK_WHICH_BUILD_SYSTEM))
3268 WK_USE_NEW_BUILD_SYSTEM_legacy = NO
3269 WK_USE_NEW_BUILD_SYSTEM_not_legacy = YES
3271 We can then use WK_USE_NEW_BUILD_SYSTEM where we used to use the
3272 externally-defined USE_NEW_BUILD_SYSTEM.
3276 2020-08-11 Philippe Normand <pnormand@igalia.com>
3278 [GStreamer] gst-full standalone library support
3279 https://bugs.webkit.org/show_bug.cgi?id=215262
3281 Reviewed by Xabier Rodriguez-Calvar.
3283 * Source/cmake/FindGStreamer.cmake:
3284 * Source/cmake/GStreamerChecks.cmake:
3285 * Source/cmake/GStreamerDefinitions.cmake:
3287 2020-08-03 Wenson Hsieh <wenson_hsieh@apple.com>
3289 Remove the ENABLE_DATA_INTERACTION feature flag
3290 https://bugs.webkit.org/show_bug.cgi?id=215091
3292 Reviewed by Megan Gardner.
3294 * Source/cmake/OptionsFTW.cmake:
3295 * Source/cmake/WebKitFeatures.cmake:
3297 2020-07-15 Carlos Garcia Campos <cgarcia@igalia.com>
3299 [GTK4] Enable API tests
3300 https://bugs.webkit.org/show_bug.cgi?id=214344
3302 Reviewed by Adrian Perez de Castro.
3304 Build API tests for GTK4 too.
3306 * Source/cmake/OptionsGTK.cmake:
3308 2020-07-29 Adrian Perez de Castro <aperez@igalia.com>
3310 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.29.2 release
3312 * Source/cmake/OptionsWPE.cmake: Bump version numbers.
3314 2020-07-29 Carlos Garcia Campos <cgarcia@igalia.com>
3316 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.29.4 release
3318 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
3320 2020-07-27 Carlos Garcia Campos <cgarcia@igalia.com>
3322 [GTK][WPE] Support for backdrop-filter
3323 https://bugs.webkit.org/show_bug.cgi?id=169988
3325 Reviewed by Adrian Perez de Castro.
3327 Enable FILTERS_LEVEL_2 by default for WPE and GTK.
3329 * Source/cmake/OptionsGTK.cmake:
3330 * Source/cmake/OptionsWPE.cmake:
3332 2020-07-27 Alberto Garcia <berto@igalia.com>
3334 [GTK] Default to OpenGL ES in arm
3335 https://bugs.webkit.org/show_bug.cgi?id=214828
3337 Reviewed by Carlos Garcia Campos.
3339 * Source/cmake/OptionsGTK.cmake:
3341 2020-07-24 Yusuke Suzuki <ysuzuki@apple.com>
3343 Add project.pbxproj editorconfig entry
3344 https://bugs.webkit.org/show_bug.cgi?id=214778
3346 Reviewed by Mark Lam.
3348 We should use tab for project.pbxproj file.
3352 2020-07-21 Adrian Perez de Castro <aperez@igalia.com>
3354 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.29.1 release
3356 * Source/cmake/OptionsWPE.cmake: Bump version numbers.
3358 2020-07-20 Adrian Perez de Castro <aperez@igalia.com>
3360 [CMake] Do not use ${DEVELOPER_MODE} directly, as it may be undefined
3362 Unreviewed build fix.
3364 Instead of using ${DEVELOPER_MODE} directly, which might be undefined an cause errors, set
3365 first ENABLE_DEVELOPER_MODE based on its value with SET_AND_EXPOSE_TO_BUILD(), and then use
3366 the ${ENABLE_DEVELOPER_MODE} expansion in the rest of the file.
3368 * Source/cmake/OptionsWPE.cmake:
3370 2020-07-13 Xabier Rodriguez Calvar <calvaris@igalia.com>
3372 Unreviewed. Fixed copy&paste typos of gcrypt -> Thunder
3374 * Source/cmake/FindThunder.cmake:
3376 2020-07-11 Fujii Hironori <Hironori.Fujii@sony.com>
3378 [WinCairo] Conic gradients support
3379 https://bugs.webkit.org/show_bug.cgi?id=214216
3381 Reviewed by Sam Weinig.
3383 * Source/cmake/OptionsWin.cmake: Turn ENABLE_CSS_CONIC_GRADIENTS on.
3385 2020-07-10 Don Olmstead <don.olmstead@sony.com> and Fujii Hironori <Hironori.Fujii@sony.com>
3387 [WinCairo] WOFF2 font support
3388 https://bugs.webkit.org/show_bug.cgi?id=214174
3390 Reviewed by Per Arne Vollan.
3392 * Source/cmake/OptionsWinCairo.cmake: Unmarked fast/text/woff2-totalsfntsize.html and fast/text/woff2.html.
3394 2020-07-10 Xabier Rodriguez Calvar <calvaris@igalia.com>
3396 [GStreamer][EME][OpenCDM] Implement OpenCDM support
3397 https://bugs.webkit.org/show_bug.cgi?id=213550
3399 Reviewed by Philippe Normand.
3401 Added support to enable OpenCDM and find it it needed.
3403 * Source/cmake/FindOpenCDM.cmake: Added.
3404 * Source/cmake/OptionsGTK.cmake:
3405 * Source/cmake/OptionsWPE.cmake:
3406 * Source/cmake/WebKitFeatures.cmake:
3408 2020-07-08 Carlos Garcia Campos <cgarcia@igalia.com>
3410 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.29.3 release
3412 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
3414 2020-07-07 Adrian Perez de Castro <aperez@igalia.com>
3416 [CMake] Fix typo in version variable assingment in FindWOFF2.cmake
3417 https://bugs.webkit.org/show_bug.cgi?id=214012
3419 Reviewed by Carlos Garcia Campos.
3421 * Source/cmake/FindWOFF2.cmake: Properly use PC_WOFF2_VERSION as the version
3422 detected from pkg-config.
3424 2020-07-04 Sergio Villar Senin <svillar@igalia.com>
3426 [Flatpak SDK] Require OpenXR 1.0.9
3427 https://bugs.webkit.org/show_bug.cgi?id=213930
3429 Reviewed by Philippe Normand.
3431 Require version 1.0.9 because is the first one that include EGL support for Monado.
3433 * Source/cmake/OptionsWPE.cmake:
3435 2020-07-03 Darin Adler <darin@apple.com>
3437 Make generate-unified-sources.sh not depend on features being listed in FEATURE_DEFINES environment variable
3438 https://bugs.webkit.org/show_bug.cgi?id=212420
3440 Reviewed by Don Olmstead.
3442 * Source/cmake/WebKitCommon.cmake: Removed call to SET_CONFIGURATION_FOR_UNIFIED_SOURCE_LISTS.
3443 * Source/cmake/WebKitFeatures.cmake: Removed SET_CONFIGURATION_FOR_UNIFIED_SOURCE_LISTS.
3444 * Source/cmake/WebKitMacros.cmake: Removed use of "--feature-flags" when invoking the
3445 generate-unified-source-bundles.rb, which also means no longer depending on the
3446 UNIFIED_SOURCE_LIST_ENABLED_FEATURES variable, which was set by the
3447 SET_CONFIGURATION_FOR_UNIFIED_SOURCE_LISTS function.
3449 2020-07-03 Sam Weinig <weinig@apple.com>
3451 Remove support for ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE
3452 https://bugs.webkit.org/show_bug.cgi?id=213932
3454 Reviewed by Darin Adler.
3456 Removes support for non-standard <input type="datetime">, currently being
3457 guarded by the macro ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE. This macro, was
3458 added back in 2013 as a temporary measure to support some engines who shipped
3459 support for <input type="datetime">. It is currently not enabled for any
3460 ports so now seems like as good a time as any to remove it.
3462 * Source/cmake/OptionsWin.cmake:
3463 * Source/cmake/WebKitFeatures.cmake:
3464 * Source/cmake/tools/vsprops/FeatureDefines.props:
3465 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
3467 2020-07-02 Alex Christensen <achristensen@webkit.org>
3469 Update Mac CMake build
3471 * Source/cmake/OptionsMac.cmake:
3473 2020-07-01 Don Olmstead <don.olmstead@sony.com>
3475 [CMake] Add WOFF2 targets
3476 https://bugs.webkit.org/show_bug.cgi?id=213865
3478 Reviewed by Fujii Hironori.
3480 Rework the Find module for WOFF2 to provide targets for libwoff2common and
3481 libwoff2dec. Previously only libwoff2dec was specified in the find module. This
3482 is because pkg-config works on that platform and because shared libraries are
3483 supported. Neither is true for Windows so the module was expanded in anticipation
3484 of support for WinCairo.
3486 * Source/cmake/FindWOFF2.cmake: Added.
3487 * Source/cmake/FindWOFF2Dec.cmake: Removed.
3488 * Source/cmake/OptionsGTK.cmake:
3489 * Source/cmake/OptionsWPE.cmake:
3491 2020-06-30 Andres Gonzalez <andresg_22@apple.com>
3493 Code cleanup in AccessibilityMenuList.cpp and AXIsolatedTree.h.
3494 https://bugs.webkit.org/show_bug.cgi?id=213806
3496 Reviewed by Darin Adler.
3498 * WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings:
3500 2020-06-29 Guowei Yang <guowei_yang@apple.com>
3502 Adding Experimental Feature Flags for CoreImage backed SVG/CSS Filters
3503 https://bugs.webkit.org/show_bug.cgi?id=213578
3505 Reviewed by Darin Adler, Simon Fraser, Myles C. Maxfield.
3507 Preparing to implement CoreImage backed filter rendering
3508 Needs Compiler guards and experimental feature guard.
3510 * Source/cmake/WebKitFeatures.cmake: added definition of
3511 CoreImage-accelerated filter rendering feature flag,
3512 ENABLE_CORE_IMAGE_ACCELERATED_FILTER_RENDER
3514 2020-06-29 Tetsuharu Ohzeki <tetsuharu.ohzeki@gmail.com>
3516 Remove ENABLE_STREAMS_API compilation flag
3517 https://bugs.webkit.org/show_bug.cgi?id=213728
3519 Reviewed by Sam Weinig.
3521 * Source/cmake/OptionsFTW.cmake:
3522 * Source/cmake/OptionsMac.cmake:
3523 * Source/cmake/OptionsWin.cmake:
3524 * Source/cmake/WebKitFeatures.cmake:
3525 * Source/cmake/tools/vsprops/FeatureDefines.props:
3527 2020-06-25 Diego Pino Garcia <dpino@igalia.com>
3529 [GTK] Enable WEB_API_STATISTICS
3530 https://bugs.webkit.org/show_bug.cgi?id=213592
3532 Reviewed by Carlos Garcia Campos.
3534 * Source/cmake/OptionsGTK.cmake:
3536 2020-06-24 Carlos Garcia Campos <cgarcia@igalia.com>
3538 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.29.2 release
3540 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
3542 2020-06-22 Saam Barati <sbarati@apple.com>
3544 Allow building JavaScriptCore Mac+arm64 in public SDK build
3545 https://bugs.webkit.org/show_bug.cgi?id=213472
3547 Reviewed by Sam Weinig.
3549 * Source/cmake/OptionsFTW.cmake:
3550 * Source/cmake/WebKitFeatures.cmake:
3552 2020-06-18 Tim Horton <timothy_horton@apple.com>
3554 Remove some vestiges of the 32-bit Plugin Process
3555 https://bugs.webkit.org/show_bug.cgi?id=213361
3557 Reviewed by Dan Bernstein.
3560 This hack from r203348 is no longer needed, because WebKit cannot be built for 32-bit anymore.
3562 2020-06-17 Michael Catanzaro <mcatanzaro@gnome.org>
3564 REGRESSION(r260760): ENABLE_GRAPHICS_CONTEXT_GL should be ON, not TRUE
3565 https://bugs.webkit.org/show_bug.cgi?id=212057
3567 Reviewed by Carlos Garcia Campos.
3569 This is already set by feature policy. Don't clobber it.
3571 * Source/cmake/OptionsGTK.cmake:
3573 2020-06-10 Dean Jackson <dino@apple.com>
3575 Add a dynamic library target for ANGLE
3576 https://bugs.webkit.org/show_bug.cgi?id=207591
3578 Reviewed by Tim Horton.
3580 In preparation for moving to a dynamic library, start
3581 by compiling and linking it. It isn't used anywhere
3582 but getting it into the build will help Apple's
3583 build system remain happy as we migrate, as well
3584 as have the system know it exists for building
3585 the shared system cache.
3587 * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
3589 2020-06-12 Adrian Perez de Castro <aperez@igalia.com>
3591 Build is broken with EVENT_LOOP_TYPE=GLib
3592 https://bugs.webkit.org/show_bug.cgi?id=212987
3594 Reviewed by Konstantin Tokarev.
3596 * Source/cmake/OptionsJSCOnly.cmake: Add gio-unix as a required component of the GLib
3597 package, as it is needed for the remote inspector support with EVENT_LOOP_TYPE=GLib.
3599 2020-06-12 Carlos Garcia Campos <cgarcia@igalia.com>
3601 [GTK4] Get MiniBrowser ready for GTK4
3602 https://bugs.webkit.org/show_bug.cgi?id=210276
3604 Reviewed by Adrian Perez de Castro.
3606 Bump GTK4 required version.
3608 * Source/cmake/OptionsGTK.cmake:
3610 2020-06-07 Philippe Normand <pnormand@igalia.com>
3612 Remove ENABLE_VIDEO_TRACK ifdef guards
3613 https://bugs.webkit.org/show_bug.cgi?id=212568
3615 Reviewed by Youenn Fablet.
3617 VIDEO_TRACK has been enabled by default on all ports for a long time. As the spec is stable,
3618 the feature can unconditionally be enabled and is now guarded under ENABLE(VIDEO).
3620 * Source/cmake/OptionsFTW.cmake:
3621 * Source/cmake/OptionsMac.cmake:
3622 * Source/cmake/OptionsWin.cmake:
3623 * Source/cmake/WebKitFeatures.cmake:
3624 * Source/cmake/tools/vsprops/FeatureDefines.props:
3625 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
3627 2020-06-05 Andy Estes <aestes@apple.com>
3629 [Apple Pay] Remove conditionals for ENABLE_APPLE_PAY_SESSION_V(3|4)
3630 https://bugs.webkit.org/show_bug.cgi?id=212541
3631 <rdar://problem/63781452>
3633 Reviewed by Darin Adler.
3635 APPLE_PAY_SESSION_V(3|4) is now enabled whenever APPLE_PAY itself is enabled.
3637 * Source/cmake/OptionsFTW.cmake:
3638 * Source/cmake/OptionsMac.cmake:
3639 * Source/cmake/WebKitFeatures.cmake:
3641 2020-06-04 Mark Lam <mark.lam@apple.com>
3643 Editors should not automatically trim trailing whitespace.
3644 https://bugs.webkit.org/show_bug.cgi?id=212763
3646 Reviewed by Yusuke Suzuki.
3648 Doing so would force a lot of unnecessary code changes and make patches hard to
3649 review. It is common WebKit practice to not make unrelated changes in patches.
3653 2020-06-02 Keith Rollin <krollin@apple.com>
3655 Revert FEATURES_DEFINES related changes
3656 https://bugs.webkit.org/show_bug.cgi?id=212664
3657 <rdar://problem/63893033>
3659 Reviewed by Andy Estes.
3661 Bug 262310, Bug 262311, Bug 262318, and Bug 262331 involve changes to
3662 FEATURE_DEFINES and how the values there relate to those found in the
3663 Platform*.h files. Those changes break XCBuild (by removing the
3664 .xcfilelist related to UnifiedSources and the process for generating
3665 them), and so are being reverted.
3667 * Source/cmake/OptionsFTW.cmake:
3668 * Source/cmake/OptionsMac.cmake:
3669 * Source/cmake/WebKitFeatures.cmake:
3671 2020-06-02 Yoshiaki JITSUKAWA <yoshiaki.jitsukawa@sony.com>
3674 https://bugs.webkit.org/show_bug.cgi?id=212463
3676 Add .editorconfig for Visual Studio.
3678 Initally following file types are supported:
3680 - CMakeFilelist.txt/.cmake
3681 - .editorconfig itself
3683 Reviewed by Fujii Hironori.
3685 * .editorconfig: Added.
3687 2020-05-29 Andy Estes <aestes@apple.com>
3689 [Apple Pay] Remove conditionals for ENABLE_APPLE_PAY_SESSION_V(3|4)
3690 https://bugs.webkit.org/show_bug.cgi?id=212541
3692 Reviewed by Darin Adler.
3694 APPLE_PAY_SESSION_V(3|4) is now enabled whenever APPLE_PAY itself is enabled.
3696 * Source/cmake/OptionsFTW.cmake:
3697 * Source/cmake/OptionsMac.cmake:
3698 * Source/cmake/WebKitFeatures.cmake:
3700 2020-05-29 Keith Rollin <krollin@apple.com>
3702 Revert switch to XCBuild
3703 https://bugs.webkit.org/show_bug.cgi?id=212530
3704 <rdar://problem/63764632>
3706 Unreviewed build fix.
3708 Bug 209890 enabled the use of XCBuild by default. Since then, some
3709 build issues have shown up. While addressing them, temporarily turn
3710 off the use of XCBuild by default.
3713 * WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings:
3715 2020-05-27 Kenneth Russell <kbr@chromium.org>
3717 Update MobileMiniBrowser project settings to current Xcode
3718 https://bugs.webkit.org/show_bug.cgi?id=212428
3720 Reviewed by Dean Jackson.
3722 Accept Xcode's suggested upgrade to use the new build system.
3724 * WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings:
3726 2020-05-27 ChangSeok Oh <changseok@webkit.org>
3728 [GTK] Manette_INCLUDE_DIR and Manette_LIBRARY are undefined.
3729 https://bugs.webkit.org/show_bug.cgi?id=212236
3731 Reviewed by Michael Catanzaro.
3733 The cmake complains Manette_INCLUDE_DIR and Manette_LIBRARY are missing
3734 in finding the manette package where GAMEPAD is enabled for the gtk port.
3735 In r261965, we thought they would be automatically defined with IMPORTED_TARGET
3736 but they seem not. We explicitly find the header and library paths, following FindOpenJPEG.cmake.
3738 * Source/cmake/FindManette.cmake:
3739 * Source/cmake/OptionsGTK.cmake: REQUIRED removed.
3741 2020-05-26 Fujii Hironori <Hironori.Fujii@sony.com>
3743 [WinCairo][WK2] Use GraphicsLayerTextureMapper for Accelerated Compositing mode
3744 https://bugs.webkit.org/show_bug.cgi?id=211883
3746 Reviewed by Don Olmstead.
3748 * Source/cmake/OptionsWinCairo.cmake: Added a new build option
3749 USE_GRAPHICS_LAYER_TEXTURE_MAPPER, and set ON as the default.
3751 2020-05-26 Don Olmstead <don.olmstead@sony.com>
3753 [CMake] Add static analyzers
3754 https://bugs.webkit.org/show_bug.cgi?id=212280
3756 Reviewed by David Kilzer.
3758 Add support for static analyzers within CMake builds. Supported analyzers are
3759 clang-tidy, iwyu (include-what-you-use) and lwyu (link-what-you-use). They can
3760 be enabled by passing a semicolon separated list to CMake through the ANALYZERS
3763 * Source/cmake/WebKitCommon.cmake:
3764 * Source/cmake/WebKitFeatures.cmake:
3765 * Source/cmake/WebKitMacros.cmake:
3766 * Source/cmake/WebKitStaticAnalysis.cmake: Added.
3768 2020-05-26 Keith Rollin <krollin@apple.com>
3770 Enable the use of XCBuild by default in Apple builds
3771 https://bugs.webkit.org/show_bug.cgi?id=209890
3772 <rdar://problem/44182078>
3774 Reviewed by Darin Adler.
3776 Switch from the "legacy" Xcode build system to the "new" build system
3777 (also known as "XCBuild"). Switching to the new system speeds up
3778 builds by a small percentage, better validates projects for
3779 build-related issues (such as dependency cycles), lets WebKit benefit
3780 from future improvements in XCBuild such as those coming from the
3781 underlying llbuild open source project, and prepares us for any other
3782 tools built for this new ecosystem.
3786 - Remove Xcode project and workspace settings that selected the Build
3787 system, allowing the default to take hold (which is currently the
3789 - Updated webkitdirs.pm with a terser check for Xcode version.
3790 - Update build-webkit and Makefile.shared to be explicit when using
3791 the old build system (no longer treat it as a default or fall-back
3793 - Update various xcconfig files similarly to treat the default as
3794 using the new build system.
3795 - Update various post-processing build steps to check for Xcode 11.4
3796 and to no longer treat the default as using the old build system.
3799 * WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings:
3801 2020-05-22 Yoshiaki JITSUKAWA <yoshiaki.jitsukawa@sony.com>
3803 [PlayStation] Enable JSC shell to run
3804 https://bugs.webkit.org/show_bug.cgi?id=212294
3806 Reviewed by Ross Kirsling.
3808 * Source/cmake/OptionsPlayStation.cmake:
3810 2020-05-21 Yoshiaki Jitsukawa <yoshiaki.jitsukawa@sony.com>
3812 [PlayStation] Add minimal WKView API to enable TestWebKitAPI
3813 https://bugs.webkit.org/show_bug.cgi?id=211868
3815 Reviewed by Alex Christensen.
3817 Enable TestWebKitAPI
3819 * Source/cmake/OptionsPlayStation.cmake:
3820 Disable FullScreen API and ContextMenus.
3822 2020-05-20 ChangSeok Oh <changseok@webkit.org>
3824 [GTK] Implement connected and disconnected events of GAMEPAD API with libmanette
3825 https://bugs.webkit.org/show_bug.cgi?id=133854
3827 Reviewed by Carlos Garcia Campos.
3829 This patch brings initial GAMEPAD API support to the gtk port. We use libmanette,
3830 a simple GObject game controller library to handle gamepad connection and input.
3832 * Source/cmake/FindManette.cmake: Added to detect libmanette headers and libs installed in host system.
3833 * Source/cmake/OptionsGTK.cmake: Added a private flag, ENABLE_GAMEPAD.
3834 Once libmanette is found, we expose another build flag, USE_MANETTE for other ports.
3836 2020-05-20 Carlos Garcia Campos <cgarcia@igalia.com>
3838 Unreviewed. Fix GTK4 build with GTK 3.98.4
3840 * Source/cmake/OptionsGTK.cmake:
3842 2020-05-18 Michael Catanzaro <mcatanzaro@gnome.org>
3844 [GTK] Allow gtk-doc and introspection in cross builds
3845 https://bugs.webkit.org/show_bug.cgi?id=212026
3847 Reviewed by Adrian Perez de Castro.
3849 Stop disabling these options in cross builds.
3851 * Source/cmake/OptionsGTK.cmake:
3853 2020-05-18 Carlos Garcia Campos <cgarcia@igalia.com>
3855 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.29.1 release
3857 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
3859 2020-05-10 Basuke Suzuki <basuke.suzuki@sony.com>
3861 Add ENABLE_PERIODIC_MEMORY_MONITOR flag.
3862 https://bugs.webkit.org/show_bug.cgi?id=211704
3864 Reviewed by Yusuke Suzuki.
3866 Define ENABLE_PERIODIC_MEMORY_MONITOR flags in specific platform's options.
3867 Enable it for PlayStation port.
3869 * Source/cmake/OptionsGTK.cmake:
3870 * Source/cmake/OptionsMac.cmake:
3871 * Source/cmake/OptionsPlayStation.cmake:
3872 * Source/cmake/OptionsWPE.cmake:
3873 * Source/cmake/WebKitFeatures.cmake:
3875 2020-05-09 Don Olmstead <don.olmstead@sony.com>
3877 [CMake] Use WEBKIT_EXECUTABLE in MallocBench
3878 https://bugs.webkit.org/show_bug.cgi?id=211665
3880 Reviewed by Yusuke Suzuki.
3882 Add the PerformanceTest subdirectory for all ports when in DEVELOPER_MODE.
3886 2020-05-07 Philippe Normand <pnormand@igalia.com>
3888 [WPE][Qt] Enable by default
3889 https://bugs.webkit.org/show_bug.cgi?id=211517
3891 Reviewed by Adrian Perez de Castro.
3893 * Source/cmake/OptionsWPE.cmake: Now that the EWS and bots use the
3894 Flatpak SDK, Qt5 libs are available so we can enable the module
3895 and have bots run its tests.
3897 2020-05-05 Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
3899 Compile GPUProcess in WPE port as experimental feature
3900 https://bugs.webkit.org/show_bug.cgi?id=211442
3902 Reviewed by Don Olmstead.
3904 Enable GPUProcess in WPE.
3906 * Source/cmake/OptionsWPE.cmake: enable GPU Process as
3907 experimental feature
3909 2020-05-05 Rob Buis <rbuis@igalia.com>
3911 [GTK][WPE][Fetch API] Stale-while-revalidate is not enabled
3912 https://bugs.webkit.org/show_bug.cgi?id=206416
3914 Reviewed by Carlos Alberto Lopez Perez.
3916 Enable s-w-r for GTK/WPE.
3918 * Source/cmake/OptionsGTK.cmake:
3919 * Source/cmake/OptionsWPE.cmake:
3921 2020-05-04 Darin Adler <darin@apple.com>
3923 Remove unused HAVE(STRINGS_H)
3924 https://bugs.webkit.org/show_bug.cgi?id=211377
3926 Reviewed by Alex Christensen.
3928 * Source/cmake/OptionsCommon.cmake: Remove code to set HAVE_STRINGS_H.
3930 2020-05-01 Per Arne Vollan <pvollan@apple.com>
3932 [Win] Fix AppleWin build
3933 https://bugs.webkit.org/show_bug.cgi?id=211324
3935 Reviewed by Don Olmstead.
3937 Use correct target namespace.
3939 * Source/cmake/target/WebCore.cmake:
3941 2020-05-01 Don Olmstead <don.olmstead@sony.com>
3943 Use export macros on all platforms
3944 https://bugs.webkit.org/show_bug.cgi?id=211293
3946 Reviewed by Michael Catanzaro.
3948 Remove explicit setting of USE_EXPORT_MACROS from all ports.
3950 Ports that use declspec require no changes. Ports with visibility attributes
3951 need to set that as the default in the CMake. This is already done on the
3954 The export macros can also be overridden for different build variants if
3955 required. For example production builds may want to override them.
3957 * Source/cmake/OptionsFTW.cmake:
3958 * Source/cmake/OptionsPlayStation.cmake:
3960 2020-04-29 Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
3962 [GPUP][GTK] compile GPUProcess in GTK port
3963 https://bugs.webkit.org/show_bug.cgi?id=208814
3965 Reviewed by Don Olmstead.
3967 Enable GPUProcess compilation in WebKitGTK as an experimental
3970 * Source/cmake/OptionsGTK.cmake: sort alphabetically WebKit
3971 options for GTK port and enable GPU_PROCESS if experimental
3972 features option is enabled.
3974 2020-04-29 Sergio Villar Senin <svillar@igalia.com>
3976 Add ccls config file to the list of ignored files
3977 https://bugs.webkit.org/show_bug.cgi?id=210426
3979 Reviewed by Tim Horton.
3981 * .gitignore: ccls can read configuration options from a .ccls file in
3982 the project root directory. Let's just ignore it.
3984 2020-04-28 Christopher Reid <chris.reid@sony.com>
3986 [Win] Bundle Inspector Resources in Release builds
3987 https://bugs.webkit.org/show_bug.cgi?id=210942
3989 Reviewed by Fujii Hironori.
3991 Add ENABLE_WEBINSPECTORUI so the resource copy can be disabled
3992 on platforms without inspector frontends.
3995 * Source/CMakeLists.txt:
3996 * Source/PlatformWin.cmake:
3997 * Source/cmake/OptionsJSCOnly.cmake:
3998 * Source/cmake/OptionsPlayStation.cmake:
4000 2020-04-28 Philippe Normand <pnormand@igalia.com>
4002 [GStreamer][MediaStream] Doesn't build with GStreamer 1.10
4003 https://bugs.webkit.org/show_bug.cgi?id=210271
4005 Reviewed by Xabier Rodriguez-Calvar.
4007 * Source/cmake/GStreamerChecks.cmake: Require at least GStreamer
4008 1.12 when building with WebRTC/MediaStream enabled.
4010 2020-04-27 Philippe Normand <pnormand@igalia.com>
4012 [GTK] ENABLE(OPENGL) remmants...
4013 https://bugs.webkit.org/show_bug.cgi?id=211077
4015 Reviewed by Adrian Perez de Castro.
4017 ENABLE(OPENGL) was renamed to ENABLE(GRAPHICS_CONTEXT_GL) in
4018 r254064 but not in all the code base...
4020 * Source/cmake/GStreamerDependencies.cmake:
4021 * Source/cmake/OptionsGTK.cmake:
4023 2020-04-27 Carlos Garcia Campos <cgarcia@igalia.com>
4025 [GTK4] Make it possible to build with GTK4 without errors
4026 https://bugs.webkit.org/show_bug.cgi?id=210967
4028 Reviewed by Adrian Perez de Castro.
4030 Disable API tests and GObject introspection when building with GTK4.
4032 * Source/cmake/OptionsGTK.cmake:
4034 2020-04-27 Diego Pino Garcia <dpino@igalia.com>
4036 Unreviewed, reverting r260672.
4038 [GTK] WebInspector tests are timing out after r260672
4042 "[Win] Bundle Inspector Resources in Release builds"
4043 https://bugs.webkit.org/show_bug.cgi?id=210942
4044 https://trac.webkit.org/changeset/260672
4046 2020-04-26 Yoshiaki Jitsukawa <yoshiaki.jitsukawa@sony.com>
4048 [PlayStation] Enable TestWTF and TestWebCore
4049 https://bugs.webkit.org/show_bug.cgi?id=208849
4051 Reviewed by Don Olmstead.
4053 * Source/cmake/OptionsPlayStation.cmake:
4054 - Add PLAYSTATION_COPY_SHARED_LIBRARIES() to install dependencies.
4055 - Add -g option for "Release" configuration.
4056 - Drop "RelWithDebInfo" and "MinSizeRel" configuration.
4058 2020-04-24 Michael Catanzaro <mcatanzaro@gnome.org>
4060 [GTK][WPE][JSCOnly] compile error when -DWTF_CPU_ARM64_CORTEXA53=ON set for arm64
4061 https://bugs.webkit.org/show_bug.cgi?id=197192
4063 Reviewed by Yusuke Suzuki.
4065 * Source/cmake/OptionsCommon.cmake:
4067 2020-04-24 Christopher Reid <chris.reid@sony.com>
4069 [Win] Bundle Inspector Resources in Release builds
4070 https://bugs.webkit.org/show_bug.cgi?id=210942
4072 Reviewed by Fujii Hironori.
4074 Add ENABLE_WEBINSPECTORUI so the resource copy can be disabled
4075 on platforms without inspector frontends.
4078 * Source/CMakeLists.txt:
4079 * Source/PlatformWin.cmake:
4080 * Source/cmake/OptionsJSCOnly.cmake:
4081 * Source/cmake/OptionsPlayStation.cmake:
4083 2020-04-24 Per Arne Vollan <pvollan@apple.com>
4085 [Win] Fix AppleWin build
4086 https://bugs.webkit.org/show_bug.cgi?id=210971
4088 Reviewed by Brent Fulgham.
4090 PAL is built as a static library.
4092 * Source/cmake/target/PAL.cmake:
4094 2020-04-23 Yusuke Suzuki <ysuzuki@apple.com>
4096 Make JSCOnly work on macOS
4097 https://bugs.webkit.org/show_bug.cgi?id=210953
4099 Reviewed by Ross Kirsling.
4101 In JSCOnly port on macOS, we should disable ICU API renaming because OS shipped ICU does not have version suffix.
4103 * Source/cmake/OptionsJSCOnly.cmake:
4105 2020-04-22 Darin Adler <darin@apple.com>
4107 [Cocoa] Build with UChar as char16_t even in builds that use Apple's internal SDK
4108 https://bugs.webkit.org/show_bug.cgi?id=210845
4110 Reviewed by Anders Carlsson.
4112 * Source/cmake/OptionsCommon.cmake: Move ICU-configuring macros to Platform.h.
4113 * Source/cmake/OptionsJSCOnly.cmake: Ditto.
4114 * Source/cmake/OptionsMac.cmake: Ditto.
4116 2020-04-22 Don Olmstead <don.olmstead@sony.com>
4118 [CMake] Use WEBKIT_EXECUTABLE in WebKitTestRunner
4119 https://bugs.webkit.org/show_bug.cgi?id=210132
4121 Reviewed by Adrian Perez de Castro.
4123 Add a WebKitTestRunner derived sources directory.
4125 * Source/cmake/WebKitFS.cmake:
4127 2020-04-21 Adrian Perez de Castro <aperez@igalia.com>
4129 [GTK][CMake] Make gtk-unix-print a component of FindGTK.cmake
4130 https://bugs.webkit.org/show_bug.cgi?id=210792
4132 Reviewed by Carlos Garcia Campos.
4134 * Source/cmake/FindGTK.cmake: Support an "unix-print" component.
4135 * Source/cmake/FindGTKUnixPrint.cmake: Removed.
4136 * Source/cmake/OptionsGTK.cmake: Use the "unix-print" component of the GTK find module.
4138 2020-04-20 Carlos Garcia Campos <cgarcia@igalia.com>
4140 [GTK][WPE] Enable resource load statistics
4141 https://bugs.webkit.org/show_bug.cgi?id=210184
4143 Reviewed by Žan Doberšek.
4145 Enable resource load statistics.
4147 * Source/cmake/OptionsGTK.cmake:
4148 * Source/cmake/OptionsWPE.cmake:
4150 2020-04-17 Don Olmstead <don.olmstead@sony.com>
4152 [CMake] Add WebKit::WebCore target
4153 https://bugs.webkit.org/show_bug.cgi?id=210445
4155 Reviewed by Michael Catanzaro.
4157 Add a target file for internal Apple Windows builds.
4159 * Source/cmake/target/WebCore.cmake: Added.
4161 2020-04-16 Carlos Garcia Campos <cgarcia@igalia.com>
4163 [GTK4] Disable netscape plugins API
4164 https://bugs.webkit.org/show_bug.cgi?id=210552
4166 Reviewed by Adrian Perez de Castro.
4168 Because GTK4 is the future and NPAPI plugins the past.
4170 * Source/cmake/OptionsGTK.cmake:
4172 2020-04-15 Carlos Garcia Campos <cgarcia@igalia.com>
4174 Unreviewed. Do not run gtk-doc when building with GTK4
4176 It's not supported yet.
4178 * Source/PlatformGTK.cmake:
4180 2020-04-13 Adrian Perez de Castro <aperez@igalia.com>
4182 [GTK][CMake] Introduce an USE_GTK4 build option
4183 https://bugs.webkit.org/show_bug.cgi?id=210154
4185 Reviewed by Carlos Garcia Campos.
4187 Do the bare minimum changes to build against GTK4 and produce a WebKit port library with a
4188 different name than GTK3 builds. Note that this does not attempt to make the built artifacts
4189 parallel-installable yet, though at least the main library, headers, and the pkg-config .pc
4190 file should be safe to install. The final names for built artifacts for GTK4 builds may
4193 * Source/cmake/OptionsGTK.cmake: Add a new USE_GTK4 public build option, which defaults
4194 to FALSE for now, and depending on its value choose the required version of GTK and set
4195 a different API version versions. This is enough to build a library with a different
4196 name (libwebkit2gtk-5.0 vs. libwebkit2gtk-4.0) when GTK4 is in use.
4198 2020-04-10 Philippe Normand <pnormand@igalia.com>
4200 [Flatpak SDK] Improved sccache support
4201 https://bugs.webkit.org/show_bug.cgi?id=210027
4203 Reviewed by Žan Doberšek.
4205 * Source/cmake/WebKitCCache.cmake: Check for sccache if one of its
4206 environment variables has been set as well, otherwise the local
4207 disk cache would be used, if WEBKIT_USE_SCCACHE is set to 1.
4209 2020-04-08 Ross Kirsling <ross.kirsling@sony.com>
4211 Remove ENABLE_INTL define
4212 https://bugs.webkit.org/show_bug.cgi?id=210164
4214 Reviewed by Darin Adler.
4216 * Source/cmake/OptionsFTW.cmake:
4217 * Source/cmake/OptionsMac.cmake:
4218 * Source/cmake/OptionsWin.cmake:
4219 * Source/cmake/WebKitFeatures.cmake:
4220 * Source/cmake/tools/vsprops/FeatureDefines.props:
4221 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
4223 2020-04-08 Stephan Szabo <stephan.szabo@sony.com>
4225 [PlayStation] Update import of libdl stubs for new Angle dladdr use
4226 https://bugs.webkit.org/show_bug.cgi?id=210200
4228 Reviewed by Don Olmstead.
4230 * Source/cmake/OptionsPlayStation.cmake:
4231 Use find_package to get libdl wrappers on playstation, include
4232 them in both executables and shared libraries.
4234 2020-04-08 Truitt Savell <tsavell@apple.com>
4236 Unreviewed, reverting r259708.
4238 Broke the iOS device Build
4242 "Enable the use of XCBuild by default in Apple builds"
4243 https://bugs.webkit.org/show_bug.cgi?id=209890
4244 https://trac.webkit.org/changeset/259708
4246 2020-04-08 Keith Rollin <krollin@apple.com>
4248 Enable the use of XCBuild by default in Apple builds
4249 https://bugs.webkit.org/show_bug.cgi?id=209890
4250 <rdar://problem/44182078>
4252 Reviewed by Darin Adler.
4254 Switch from the "legacy" Xcode build system to the "new" build system
4255 (also known as "XCBuild"). Switching to the new system speeds up
4256 builds by a small percentage, better validates projects for
4257 build-related issues (such as dependency cycles), lets WebKit benefit
4258 from future improvements in XCBuild such as those coming from the
4259 underlying llbuild open source project, and prepares us for any other
4260 tools built for this new ecosystem.
4264 - Remove Xcode project and workspace settings that selected the Build
4265 system, allowing the default to take hold (which is currently the
4267 - Updated webkitdirs.pm with a terser check for Xcode version.
4268 - Update build-webkit and Makefile.shared to be explicit when using
4269 the old build system (no longer treat it as a default or fall-back
4271 - Update various xcconfig files similarly to treat the default as
4272 using the new build system.
4273 - Update various post-processing build steps to check for Xcode 11.4
4274 and to no longer treat the default as using the old build system.
4277 * WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings:
4279 2020-04-08 Philippe Normand <pnormand@igalia.com>
4281 [GTK][WPE] Release logs are unconditionally filling the journal
4282 https://bugs.webkit.org/show_bug.cgi?id=209421
4284 Reviewed by Carlos Alberto Lopez Perez.
4286 Re-enable Systemd logging and make it opt-in via the WEBKIT_DEBUG environment variable.
4288 * Source/cmake/OptionsGTK.cmake:
4289 * Source/cmake/OptionsWPE.cmake:
4291 2020-04-07 Adrian Perez de Castro <aperez@igalia.com>
4293 [GTK] CMake find module for GTK4
4294 https://bugs.webkit.org/show_bug.cgi?id=210110
4296 Reviewed by Don Olmstead.
4298 Rename FindGTK3.cmake as FindGTK.cmake, make it provide a GTK::GTK imported target,
4299 and rewrite the logic to detect which targets (backends) have been built into GTK
4300 to use the "targets" pkg-config variable instead of checking for multiple pkg-config
4303 * Source/cmake/FindGDK3.cmake: Removed.
4304 * Source/cmake/FindGTK.cmake: Added.
4305 * Source/cmake/FindGTK3.cmake: Removed. This is now unused because the GTK::GTK target
4306 will transitively depend on GDK3 when using GTK3 and bring in the compiler and linker
4307 options automatically without needing to use a separate find module for GDK.
4308 * Source/cmake/OptionsGTK.cmake: Use the GTK::GTK imported target, change variables
4309 prefixed with GTK3_ to use the GTK_ prefix, and remove variables which are not needed
4310 anymore when using the target (GTK_LIBRARIES, GTK_INCLUDE_DIRS, GDK_LIBRARIES and
4313 2020-04-06 Don Olmstead <don.olmstead@sony.com>
4315 [CMake] Use WEBKIT_EXECUTABLE in DumpRenderTree
4316 https://bugs.webkit.org/show_bug.cgi?id=210059
4318 Reviewed by Fujii Hironori.
4320 Add a DumpRenderTree derived sources directory.
4322 * Source/cmake/WebKitFS.cmake:
4324 2020-04-06 Ross Kirsling <ross.kirsling@sony.com>
4326 Update minimum ICU version to 60.2
4327 https://bugs.webkit.org/show_bug.cgi?id=209694
4329 Reviewed by Darin Adler.
4331 * Source/cmake/OptionsAppleWin.cmake:
4332 * Source/cmake/OptionsCommon.cmake:
4333 * Source/cmake/OptionsFTW.cmake:
4334 * Source/cmake/OptionsGTK.cmake:
4335 * Source/cmake/OptionsJSCOnly.cmake:
4336 * Source/cmake/OptionsMac.cmake:
4337 * Source/cmake/OptionsPlayStation.cmake:
4338 * Source/cmake/OptionsWPE.cmake:
4339 * Source/cmake/OptionsWinCairo.cmake:
4340 Indicate 60.2 as minimum version (as required by GTK for supporting Ubuntu 18.04 LTS).
4341 Also ensure that the C++ API is hidden for all platforms.
4343 2020-04-05 Don Olmstead <don.olmstead@sony.com>
4345 [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
4346 https://bugs.webkit.org/show_bug.cgi?id=206894
4348 Reviewed by Adrian Perez de Castro.
4350 Add a MiniBrowser derived sources directory.
4352 * Source/cmake/WebKitFS.cmake:
4354 2020-04-05 Don Olmstead <don.olmstead@sony.com>
4356 [CMake] Add WebKit::WebKit target
4357 https://bugs.webkit.org/show_bug.cgi?id=210033
4359 Reviewed by Fujii Hironori.
4361 Use SET_AND_EXPOSE_TO_BUILD for the Plugin process since ENABLE(PLUGIN_PROCESS)
4362 is used in the source code.
4364 * Source/cmake/OptionsGTK.cmake:
4366 2020-04-02 Commit Queue <commit-queue@webkit.org>
4368 Unreviewed, reverting r259390.
4369 https://bugs.webkit.org/show_bug.cgi?id=209944
4371 It broke WinCairo builds (Requested by fujihiro on #webkit).
4375 "Enable offlineasm debug annotations for GCC"
4376 https://bugs.webkit.org/show_bug.cgi?id=207119
4377 https://trac.webkit.org/changeset/259390
4379 2020-04-01 Don Olmstead <don.olmstead@sony.com>
4381 [GPUP][PlayStation] Enable GPU Process
4382 https://bugs.webkit.org/show_bug.cgi?id=209865
4384 Reviewed by Eric Carlson.
4386 Enable GPU Process for development builds as an experimental feature.
4388 * Source/cmake/OptionsPlayStation.cmake:
4390 2020-04-01 Don Olmstead <don.olmstead@sony.com>
4392 [PlayStation] Use OBJECT libraries for WebCore and PAL
4393 https://bugs.webkit.org/show_bug.cgi?id=209835
4395 Reviewed by Ross Kirsling.
4397 When compiling WebCore in debug mode ranlib was having issues with the size of
4398 libWebCore.a. This is similar to what happened with Visual Studio and WinCairo.
4400 Additionally hidden visibility defaults are added for the port.
4402 * Source/cmake/OptionsPlayStation.cmake:
4404 2020-03-30 Zan Dobersek <zdobersek@igalia.com>
4406 [WPE] Can't create WebGL context after r259139
4407 https://bugs.webkit.org/show_bug.cgi?id=209722
4409 Reviewed by Carlos Garcia Campos.
4411 * Source/cmake/OptionsWPE.cmake: Disable WebGL2 for WPE until
4412 the ANGLE-backed implementation can be used for it.
4414 2020-03-26 Don Olmstead <don.olmstead@sony.com>
4416 [MSVC] Remove experimental lambda processor usage
4417 https://bugs.webkit.org/show_bug.cgi?id=209358
4419 Reviewed by Fujii Hironori.
4421 Remove /experimental:newLambdaProcessor since WebKit is no longer able to build
4422 with this setting as of Visual Studio 16.5.0.
4424 * Source/cmake/OptionsMSVC.cmake:
4426 2020-03-26 Fujii Hironori <Hironori.Fujii@sony.com>
4428 [Win] lld-link: error: /manifestdependency: is not allowed in .drectve
4429 https://bugs.webkit.org/show_bug.cgi?id=204831
4431 Reviewed by Ross Kirsling.
4433 * Source/cmake/WebKitMacros.cmake (WEBKIT_EXECUTABLE): Added /manifestdependency linkder option if WIN32.
4435 2020-03-26 Commit Queue <commit-queue@webkit.org>
4437 Unreviewed, reverting r259035.
4438 https://bugs.webkit.org/show_bug.cgi?id=209597
4440 broke windows layout-tests (Requested by aakashjain on
4445 "[Win] lld-link: error: /manifestdependency: is not allowed in
4447 https://bugs.webkit.org/show_bug.cgi?id=204831
4448 https://trac.webkit.org/changeset/259035
4450 2020-03-25 Fujii Hironori <Hironori.Fujii@sony.com>
4452 [Win] lld-link: error: /manifestdependency: is not allowed in .drectve
4453 https://bugs.webkit.org/show_bug.cgi?id=204831
4455 Reviewed by Ross Kirsling.
4457 clang-cl doesn't support #pragma comment(linker, "/manifestdependency ..").
4458 Use an linker option instead.
4460 * Source/cmake/WebKitMacros.cmake (WEBKIT_EXECUTABLE): Added -manifestdependency linkder option if WIN32.
4462 2020-03-23 Michael Catanzaro <mcatanzaro@gnome.org>
4464 [GTK] Allow distributors to brand user agent
4465 https://bugs.webkit.org/show_bug.cgi?id=162611
4467 Reviewed by Adrian Perez de Castro.
4469 Add build option for inserting distributor branding into the user agent string.
4471 * Source/cmake/OptionsGTK.cmake:
4472 * Source/cmake/OptionsWPE.cmake:
4474 2020-03-23 Philippe Normand <pnormand@igalia.com>
4476 [GTK][WPE] Disable systemd logging by default
4478 Rubber-stamped by Žan Doberšek.
4480 The logAlways logs are filling the journal way too fast currently,
4481 specially on EWS running tests and buildbots. For the time being
4482 disable logging until we figure out a better way to handle this.
4484 * Source/cmake/OptionsGTK.cmake:
4485 * Source/cmake/OptionsWPE.cmake:
4487 2020-03-21 Michael Catanzaro <mcatanzaro@gnome.org>
4489 [GTK] Use ${PYTHON_EXECUTABLE} to run generate-gtkdoc
4490 https://bugs.webkit.org/show_bug.cgi?id=208970
4492 Reviewed by Konstantin Tokarev.
4494 There's no need to rely on shebangs when executing python scripts from CMake. This should
4495 ensure the script always works even if the shebang does not.
4497 * Source/cmake/GtkDoc.cmake:
4499 2020-03-20 Justin Michaud <justin@justinmichaud.com>
4501 Fix JSCOnly build without unified sources
4502 https://bugs.webkit.org/show_bug.cgi?id=209343
4504 Reviewed by Keith Miller.
4508 2020-03-17 Philippe Normand <pnormand@igalia.com>
4510 RELEASE_LOG should not be Cocoa specific
4511 https://bugs.webkit.org/show_bug.cgi?id=195182
4513 Reviewed by Konstantin Tokarev.
4515 Add a Systemd Journald Logger implementation, enabled by default
4516 in the GTK and WPE ports. When this is enabled, release logs will
4517 be sent to the Systemd Journal. To retrieve media logs for
4518 instance, this command can be used:
4520 $ journalctl WEBKIT_SUBSYSTEM=WebKitGTK WEBKIT_CHANNEL=Media
4522 * Source/cmake/FindSystemd.cmake: Added.
4523 * Source/cmake/OptionsGTK.cmake:
4524 * Source/cmake/OptionsWPE.cmake:
4526 2020-03-16 Keith Rollin <krollin@apple.com>
4528 Remove support for WebKitSystemInterface
4529 https://bugs.webkit.org/show_bug.cgi?id=208894
4530 <rdar://problem/60297590>
4532 Reviewed by Brent Fulgham.
4534 This project provided support for facilities that are now handled
4535 elsewhere and is no longer needed.
4538 * Source/PlatformWin.cmake:
4539 * Source/cmake/OptionsAppleWin.cmake:
4541 2020-03-13 Sergio Villar Senin <svillar@igalia.com>
4543 [WebXR] IDLs, stubs and build configuration for WPE
4544 https://bugs.webkit.org/show_bug.cgi?id=208702
4546 Reviewed by Dean Jackson.
4548 Added a new compile flag for WEBXR which depends on WEBGL.
4550 For the WPE port, added OpenXR detection and USE_OPENXR define to be
4551 used in the sources. It also adds a dependency between USE_OPENXR and
4554 Largely based on previous work by Žan Doberšek.
4556 * Source/cmake/FindOpenXR.cmake: Added.
4557 * Source/cmake/OptionsWPE.cmake: Added mandatory OpenXR dependency if
4558 WEBXR is enabled exposing USE_OPENXR to the build.
4559 * Source/cmake/WebKitFeatures.cmake: Added ENABLE_WEBXR.
4560 * Source/cmake/tools/vsprops/FeatureDefines.props: Ditto.
4561 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props: Ditto.
4563 2020-03-14 Michael Catanzaro <mcatanzaro@gnome.org>
4565 [CMake] Warning when ccache is not installed
4566 https://bugs.webkit.org/show_bug.cgi?id=208952
4568 Reviewed by Daniel Bates.
4570 Change the warning when ccache is not installed to a status message. We shouldn't be
4571 printing warnings except when there is an actual problem.
4573 * Source/cmake/WebKitCCache.cmake:
4575 2020-03-13 Konstantin Tokarev <annulen@yandex.ru>
4577 [CMake] Eleminate mismatches between Find* module names and variables they set
4578 https://bugs.webkit.org/show_bug.cgi?id=208948
4580 Reviewed by Michael Catanzaro.
4582 * Source/cmake/FindLibseccomp.cmake:
4583 * Source/cmake/FindWPEBackend_fdo.cmake: Renamed from Source/cmake/FindWPEBackend-fdo.cmake.
4584 * Source/cmake/OptionsGTK.cmake:
4585 * Source/cmake/OptionsWPE.cmake:
4587 2020-03-12 Konstantin Tokarev <annulen@yandex.ru>
4589 [CMake] Find modules should find pkg-config with find_package(PkgConfig QUIET)
4590 https://bugs.webkit.org/show_bug.cgi?id=208948
4592 Reviewed by Michael Catanzaro.
4594 * Source/cmake/FindATK.cmake:
4595 * Source/cmake/FindATKBridge.cmake:
4596 * Source/cmake/FindATSPI.cmake:
4597 * Source/cmake/FindCairo.cmake:
4598 * Source/cmake/FindCairoGL.cmake:
4599 * Source/cmake/FindEGL.cmake:
4600 * Source/cmake/FindEnchant.cmake:
4601 * Source/cmake/FindFontconfig.cmake:
4602 * Source/cmake/FindGDK3.cmake:
4603 * Source/cmake/FindGLIB.cmake:
4604 * Source/cmake/FindGObjectIntrospection.cmake:
4605 * Source/cmake/FindGStreamer.cmake:
4606 * Source/cmake/FindGTK3.cmake:
4607 * Source/cmake/FindGTKUnixPrint.cmake:
4608 * Source/cmake/FindHarfBuzz.cmake:
4609 * Source/cmake/FindLibEpoxy.cmake: