LICM shouldn't hoist nodes if hoisted nodes exited in that code block
[WebKit-https.git] / ChangeLog
1 2018-04-30  JF Bastien  <jfbastien@apple.com>
2
3         Use some C++17 features
4         https://bugs.webkit.org/show_bug.cgi?id=185135
5
6         Reviewed by Alex Christensen.
7
8         As discussed here [0] let's move WebKit to a subset of C++17. We
9         now require GCC 6 [1] which means that, according to [2] we can
10         use the following C++17 language features (I removed some
11         uninteresting ones):
12
13          - New auto rules for direct-list-initialization
14          - static_assert with no message
15          - typename in a template template parameter
16          - Nested namespace definition
17          - Attributes for namespaces and enumerators
18          - u8 character literals
19          - Allow constant evaluation for all non-type template arguments
20          - Fold Expressions
21          - Unary fold expressions and empty parameter packs
22          - __has_include in preprocessor conditional
23          - Differing begin and end types in range-based for
24          - Improving std::pair and std::tuple
25
26         Consult the Tony Tables [3] to see before / after examples.
27
28         Of course we can use any library feature if we're willing to
29         import them to WTF (and they don't require language support).
30
31
32           [0]: https://lists.webkit.org/pipermail/webkit-dev/2018-March/029922.html
33           [1]: https://trac.webkit.org/changeset/231152/webkit
34           [2]: https://en.cppreference.com/w/cpp/compiler_support
35           [3]: https://github.com/tvaneerd/cpp17_in_TTs/blob/master/ALL_IN_ONE.md
36
37         * Source/cmake/WebKitCompilerFlags.cmake:
38
39 2018-04-29  Michael Catanzaro  <mcatanzaro@igalia.com>
40
41         [CMake] Require GCC 6
42         https://bugs.webkit.org/show_bug.cgi?id=184985
43
44         Reviewed by Alex Christensen.
45
46         Require it.
47
48         * CMakeLists.txt:
49
50 2018-04-26  Daniel Bates  <dabates@apple.com>
51
52         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
53         https://bugs.webkit.org/show_bug.cgi?id=184161
54         <rdar://problem/39051645>
55
56         Reviewed by Dan Bernstein.
57
58         * ManualTests/DragInlinePDFImageDocument.html: Added.
59         * ManualTests/resources/simple.pdf: Added.
60
61 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
62
63         [INTL] Implement Intl.PluralRules
64         https://bugs.webkit.org/show_bug.cgi?id=184312
65
66         Reviewed by JF Bastien.
67
68         Added Intl.PluralRules feature flag.
69
70         * Source/cmake/WebKitFeatures.cmake:
71
72 2018-04-26  Zan Dobersek  <zdobersek@igalia.com>
73
74         [GTK][WPE] Initial ASYNC_SCROLLING support
75         https://bugs.webkit.org/show_bug.cgi?id=184961
76
77         Reviewed by Carlos Garcia Campos.
78
79         * Source/cmake/OptionsGTK.cmake: Enable ASYNC_SCROLLING as a private option.
80         * Source/cmake/OptionsWPE.cmake: Ditto.
81
82 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
83
84         [WPE] Build and link against latest WPEBackend and WPEBackend-fdo
85         https://bugs.webkit.org/show_bug.cgi?id=184643
86
87         Reviewed by Žan Doberšek.
88
89         Update find modules to include the API versions.
90
91         * Source/cmake/FindWPEBackend-fdo.cmake:
92         * Source/cmake/FindWPEBackend.cmake:
93
94 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
95
96         [CMake] Some options should be marked as advanced
97         https://bugs.webkit.org/show_bug.cgi?id=184972
98
99         Reviewed by Konstantin Tokarev.
100
101         * Source/cmake/FindLibGcrypt.cmake:
102         * Source/cmake/FindWebP.cmake:
103
104 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
105
106         [GTK] Miscellaneous build cleanups
107         https://bugs.webkit.org/show_bug.cgi?id=184399
108
109         Reviewed by Žan Doberšek.
110
111         * Source/cmake/OptionsGTK.cmake:
112
113 2018-04-24  Leo Balter  <leonardo.balter@gmail.com>
114
115         Land test262 test results associated with Test262 runner
116         https://bugs.webkit.org/show_bug.cgi?id=184667
117
118         Reviewed by Michael Saboff.
119
120         * .gitignore: Ignore test262 results file.
121
122 2018-04-24  Zan Dobersek  <zdobersek@igalia.com>
123
124         [WPE] Remove libgbm dependency
125         https://bugs.webkit.org/show_bug.cgi?id=184906
126
127         Reviewed by Carlos Garcia Campos.
128
129         Remove the libgbm CMake search module. It's not necessary anymore
130         after r230562.
131
132         * Source/cmake/FindLibGBM.cmake: Removed.
133
134 2018-04-23  Michael Catanzaro  <mcatanzaro@igalia.com>
135
136         [GTK] check target looks broken
137         https://bugs.webkit.org/show_bug.cgi?id=184407
138
139         Reviewed by Carlos Garcia Campos.
140
141         It's pretty clear that nobody has been using check for a long time.
142
143         We got rid of check-for-webkitdom-api-breaks a long time ago, when we stopped autogenerating
144         the DOM API, but it's still used in the check target. Fix this.
145
146         Also, the check target for some reason runs itself from the Source subdirectory of the
147         builddir, but the test script expects to be run from the toplevel build directory. Fix this
148         too.
149
150         Add VERBATIM for good measure.
151
152         * Source/PlatformGTK.cmake:
153
154 2018-04-20  Daniel Bates  <dabates@apple.com>
155
156         Unreviewed, rolling out r230117.
157
158         Broke find-in-page for PDFs
159
160         Reverted changeset:
161
162         "ASSERTION FAILED: ASSERT(!containsImage ||
163         MIMETypeRegistry::isSupportedImageResourceMIMEType([resource
164         MIMEType])) in -[NSPasteboard(WebExtras)
165         _web_writePromisedRTFDFromArchive:containsImage:]"
166         https://bugs.webkit.org/show_bug.cgi?id=184161
167         https://trac.webkit.org/changeset/230117
168
169 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
170
171         [GTK] Local cross references are broken in API documentation
172         https://bugs.webkit.org/show_bug.cgi?id=184771
173
174         Reviewed by Michael Catanzaro.
175
176         Update the documentation html paths and install the JSC GLib API too.
177
178         * Source/PlatformGTK.cmake:
179
180 2018-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
181
182         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.21.1 release.
183
184         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
185
186 2018-04-17  Zan Dobersek  <zdobersek@igalia.com>
187
188         [CMake] Add and enable the ENABLE_CSS_ANIMATIONS_LEVEL_2 feature define
189         https://bugs.webkit.org/show_bug.cgi?id=184681
190
191         Reviewed by Carlos Garcia Campos.
192
193         * Source/cmake/WebKitFeatures.cmake: Add the ENABLE_CSS_ANIMATIONS_LEVEL_2
194         feature define. Follow Cocoa ports and enable it by default.
195
196 2018-04-15  Michael Catanzaro  <mcatanzaro@igalia.com>
197
198         [WPE] Install files needed for WebKitWebExtensions
199         https://bugs.webkit.org/show_bug.cgi?id=179915
200
201         Reviewed by Žan Doberšek.
202
203         * Source/cmake/OptionsWPE.cmake:
204
205 2018-04-12  Ryan Haddad  <ryanhaddad@apple.com>
206
207         Unreviewed, rolling out r230554.
208
209         The non-ASCII character in the filename causes issues with SVN
210
211         Reverted changeset:
212
213         "input.webkitEntries does not work as expected when folder
214         contains accented chars"
215         https://bugs.webkit.org/show_bug.cgi?id=184517
216         https://trac.webkit.org/changeset/230554
217
218 2018-04-12  Zan Dobersek  <zdobersek@igalia.com>
219
220         [WPE] Switch testing process to using WPEBackend-fdo
221         https://bugs.webkit.org/show_bug.cgi?id=184357
222
223         Reviewed by Carlos Alberto Lopez Perez.
224
225         * Source/cmake/FindWPEBackend-fdo.cmake: Renamed from Source/cmake/FindWPEBackend-mesa.cmake.
226
227 2018-04-11  Thibault Saunier  <tsaunier@igalia.com>
228
229         [GStreamer] Use of playbin3 when USE_PLAYBIN3 environment variable is set
230         https://bugs.webkit.org/show_bug.cgi?id=184498
231
232         Reviewed by Philippe Normand.
233
234         This is the same behaviour as with playbin itself.
235
236         Make sure to keep using "playbin" for MediaSource.
237
238         * Source/cmake/GStreamerDefinitions.cmake:
239
240 2018-04-09  Michael Catanzaro  <mcatanzaro@igalia.com>
241
242         [WPE] Use GNU install directories
243         https://bugs.webkit.org/show_bug.cgi?id=184377
244
245         Reviewed by Carlos Garcia Campos.
246
247         Notably, this means all the CMake arguments that distributors use to customize install
248         directories (-DCMAKE_INSTALL_*DIR) will no longer be ignored.
249
250         * Source/cmake/OptionsCommon.cmake:
251         * Source/cmake/OptionsWPE.cmake:
252
253 2018-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
254
255         [CMake] WebKit should link to WebCore as a PRIVATE library if WebCore is a static library
256         https://bugs.webkit.org/show_bug.cgi?id=184127
257
258         Reviewed by Konstantin Tokarev.
259
260         Building TestWebKitLib on Windows causes a linkage error of
261         multiply defined symbols because TestWebKitLib links to
262         both WebCore and WebKit. TestWebKitLib explicitly links only with
263         WebKit, But, WebCore is propagated because WebKit links WebCore as
264         public.
265
266         * Source/cmake/OptionsGTK.cmake (ADD_WHOLE_ARCHIVE_TO_LIBRARIES):
267         Do not wrap PRIVATE and PUBLIC keywords with -Wl,--whole-archive.
268
269 2018-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
270
271         [WPE][GTK] Remove applicationDirectoryPath() and sharedResourcePath()
272         https://bugs.webkit.org/show_bug.cgi?id=184381
273
274         Reviewed by Carlos Garcia Campos.
275
276         * Source/cmake/OptionsGTK.cmake:
277         * Source/cmake/OptionsWPE.cmake:
278
279 2018-04-02  Per Arne Vollan  <pvollan@apple.com>
280
281         Remove references to internal version of WebKitQuartzCoreAdditions in CMake files.
282         https://bugs.webkit.org/show_bug.cgi?id=184246
283         <rdar://problem/39116563>
284
285         Unreviewed build fix.
286
287         * Source/PlatformWin.cmake:
288
289 2018-04-02  Alejandro G. Castro  <alex@igalia.com>
290
291         [GTK] Make libwebrtc backend buildable for GTK  port
292         https://bugs.webkit.org/show_bug.cgi?id=178860
293
294         Reviewed by Youenn Fablet.
295
296         * Source/CMakeLists.txt: Add the libwebrtc directory to the compilation.
297         * Source/cmake/OptionsGTK.cmake: Add the USE_LIBWEBRTC option to
298         allow compilation of the specific code.
299
300 2018-03-30  Daniel Bates  <dabates@apple.com>
301
302         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
303         https://bugs.webkit.org/show_bug.cgi?id=184161
304
305         Reviewed by Per Arne Vollan.
306
307         * ManualTests/DragInlinePDFImageDocument.html: Added.
308         * ManualTests/resources/simple.pdf: Added.
309
310 2018-03-28  Tim Horton  <timothy_horton@apple.com>
311
312         Make it possible to disable building the tools with Make
313         https://bugs.webkit.org/show_bug.cgi?id=184109
314
315         Reviewed by Simon Fraser.
316
317         * Makefile:
318
319 2018-03-25  Carlos Garcia Campos  <cgarcia@igalia.com>
320
321         [GTK][WPE] Add API to convert between DOM and JSCValue
322         https://bugs.webkit.org/show_bug.cgi?id=183448
323
324         Reviewed by Michael Catanzaro.
325
326         Define FORWARDING_HEADERS_WPE_DOM_DIR.
327
328         * Source/cmake/OptionsWPE.cmake:
329
330 2018-03-22  Adrian Perez de Castro  <aperez@igalia.com>
331
332         [WPE] Enable WOFF2 support
333         https://bugs.webkit.org/show_bug.cgi?id=178158
334
335         Reviewed by Frédéric Wang.
336
337         * Source/cmake/OptionsWPE.cmake: Add needed logic to detect the Brotli and WOFF2 libraries.
338
339 2018-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
340
341         [GTK][WPE] Initial implementation of JavaScriptCore glib bindings
342         https://bugs.webkit.org/show_bug.cgi?id=164061
343
344         Reviewed by Michael Catanzaro.
345
346         Set global variables used by the makefiles.
347
348         * Source/cmake/OptionsGTK.cmake:
349         * Source/cmake/OptionsWPE.cmake:
350
351 2018-03-15  Ms2ger  <Ms2ger@igalia.com>
352
353         [GTK][WPE] Enable service workers
354         https://bugs.webkit.org/show_bug.cgi?id=178576
355
356         Reviewed by Žan Doberšek.
357
358         * Source/cmake/OptionsGTK.cmake:
359         * Source/cmake/OptionsWPE.cmake:
360
361 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
362
363         Runtime flag for link prefetch and remove link subresource.
364         https://bugs.webkit.org/show_bug.cgi?id=183540
365
366         Reviewed by Chris Dumez.
367
368         Remove the LINK_PREFETCH build time flag.
369
370         * Source/cmake/OptionsWin.cmake:
371         * Source/cmake/WebKitFeatures.cmake:
372         * Source/cmake/tools/vsprops/FeatureDefines.props:
373         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
374
375 2018-03-12  Zan Dobersek  <zdobersek@igalia.com>
376
377         Unreviewed. Unbreak the WPE layout testing that's been broken since
378         r229470. Due to disassociation between ENABLE(ACCESSIBILITY) and
379         HAVE(ACCESSIBILITY), the injected bundle for the WPE port was left with
380         undefined symbols. This is fixed with ENABLE_ACCESSIBILITY being enabled
381         for the WPE port as well.
382
383         * Source/cmake/OptionsWPE.cmake:
384
385 2018-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
386
387         Unreviewed. Fix library version of JavaScriptCoreGTK.
388
389         * Source/cmake/OptionsGTK.cmake:
390
391 2018-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
392
393         Unreviewed. Bump WebKitGTK+ version to 2.21.0.
394
395         * Source/cmake/OptionsGTK.cmake:
396
397 2018-03-08  Tim Horton  <timothy_horton@apple.com>
398
399         Add a way to not build libwebrtc when building WebKit via Makefiles
400         https://bugs.webkit.org/show_bug.cgi?id=183437
401         <rdar://problem/38254840>
402
403         Reviewed by Dan Bernstein.
404
405         * Source/Makefile:
406
407 2018-03-05  Don Olmstead  <don.olmstead@sony.com>
408
409         [CMake] Split JSC header copying into public and private targets
410         https://bugs.webkit.org/show_bug.cgi?id=183251
411
412         Reviewed by Konstantin Tokarev.
413
414         * Source/cmake/WebKitMacros.cmake:
415
416 2018-03-02  Don Olmstead  <don.olmstead@sony.com>
417
418         Add clang-format configuration
419         https://bugs.webkit.org/show_bug.cgi?id=183302
420
421         Reviewed by Ryosuke Niwa.
422
423         * .clang-format: Added.
424
425 2018-03-01  Michael Catanzaro  <mcatanzaro@igalia.com>
426
427         [CMake] configure failure for aarch64
428         https://bugs.webkit.org/show_bug.cgi?id=183268
429
430         Unreviewed build fix. This failure is caused by a simple typo.
431
432         * Source/cmake/OptionsCommon.cmake:
433
434 2018-02-26  Yousuke Kimoto  <yousuke.kimoto@sony.com>
435
436         [WinCairo] WebKit2_C.h should be included for TestWebKit
437         https://bugs.webkit.org/show_bug.cgi?id=182682
438
439         Reviewed by Yusuke Suzuki.
440
441         Added a new definition "BUILDING_WIN_CAIRO_WEBKIT" to specify
442         the wincairo webkit build.
443
444         * Source/cmake/OptionsWinCairo.cmake:
445
446 2018-02-26  Fujii Hironori  <Hironori.Fujii@sony.com>
447
448         [CMake][OpenVR] Linkage errors happen because only OpenVR is compiled with -stdlib=libc++ if Clang is used
449         https://bugs.webkit.org/show_bug.cgi?id=183116
450
451         Reviewed by Žan Doberšek.
452
453         OpenVR has a option USE_LIBCXX to enable/disable that behavior. Let's disable it.
454
455         * Source/CMakeLists.txt: Added a option command for USE_LIBCXX to set OFF as default.
456
457 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
458
459         [CMake] Expose HAVE macros globally
460         https://bugs.webkit.org/show_bug.cgi?id=183011
461
462         Reviewed by Michael Catanzaro.
463
464         * Source/cmake/OptionsCommon.cmake:
465         * Source/cmake/WebKitFeatures.cmake:
466
467 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
468
469         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
470         https://bugs.webkit.org/show_bug.cgi?id=182883
471
472         Reviewed by Per Arne Vollan.
473
474         * Source/cmake/OptionsAppleWin.cmake:
475         * Source/cmake/OptionsWin.cmake:
476         * Source/cmake/OptionsWinCairo.cmake:
477
478 2018-02-21  Michael Catanzaro  <mcatanzaro@igalia.com>
479
480         [GTK] USE_UPOWER causes crashes inside a chroot or on systems with broken dbus/upower
481         https://bugs.webkit.org/show_bug.cgi?id=181825
482
483         Reviewed by Carlos Garcia Campos.
484
485         Get rid of the upower-glib dependency. We will use upower's D-Bus API instead.
486
487         * Source/cmake/FindUPowerGLib.cmake: Removed.
488         * Source/cmake/OptionsGTK.cmake:
489
490 2018-02-20  Adrian Perez de Castro  <aperez@igalia.com>
491
492         [GTK][CMake] Support building with Enchant 2.x
493         https://bugs.webkit.org/show_bug.cgi?id=182933
494
495         Reviewed by Michael Catanzaro.
496
497         * Source/cmake/FindEnchant.cmake: Check for both the "enchant" and "enchant-2"
498         pkg-config components, picking the first available for which the headers and
499         library are usable.
500
501 2018-02-19  Philippe Normand  <pnormand@igalia.com>
502
503         [GStreamer] Playbin3 support
504         https://bugs.webkit.org/show_bug.cgi?id=182530
505
506         Reviewed by Xabier Rodriguez-Calvar.
507
508         * Source/cmake/GStreamerDefinitions.cmake: New
509         USE(GSTREAMER_PLAYBIN3) feature. This should be enabled only for
510         very recent versions of GStreamer (1.14 at least) and is optional, for now.
511
512 2018-02-18  Philippe Normand  <pnormand@igalia.com>
513
514         [GTK][WPE] Fullscreen video is broken
515         https://bugs.webkit.org/show_bug.cgi?id=182740
516
517         Reviewed by Michael Catanzaro.
518
519         * Source/cmake/WebKitFeatures.cmake: Enable the
520         VIDEO_USES_ELEMENT_FULLSCREEN feature on CMake ports.
521
522 2018-02-16  Dean Jackson  <dino@apple.com>
523
524         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
525         https://bugs.webkit.org/show_bug.cgi?id=182894
526
527         Reviewed by Tim Horton.
528
529         Rename OPENGL_ES_2 to OPENGL_ES.
530
531         * Source/cmake/OptionsGTK.cmake:
532         * Source/cmake/OptionsWPE.cmake:
533
534 2018-02-09  Ross Kirsling  <ross.kirsling@sony.com>
535
536         Simplify .gitignore's WebKitLibraries/win section.
537         https://bugs.webkit.org/show_bug.cgi?id=182618
538
539         Reviewed by Per Arne Vollan.
540
541         We need to update this section for WinCairoRequirements regardless, but
542         it never needed to be this longwinded in the first place.
543
544         * .gitignore:
545
546 2018-02-08  Fujii Hironori  <Hironori.Fujii@sony.com>
547
548         [Meta][Win] Support ICU 59.1+
549         https://bugs.webkit.org/show_bug.cgi?id=181004
550
551         Reviewed by Alex Christensen.
552
553         ICU 59 changed the type of UChar from wchar_t to char16_t on
554         Windows. We need a lot of conversions between UChar* and wchar_t*
555         to call Windows API because it takes string as wchar_t*.
556
557         Fortunately, ICU is configurable to define UChar as wchar_t as
558         well as the prior ICU.
559         <http://icu-project.org/apiref/icu4c/umachine_8h.html#a6bb9fad572d65b305324ef288165e2ac>
560
561         * Source/cmake/OptionsWin.cmake: Add a compile option -DUCHAR_TYPE=wchar_t.
562
563 2018-02-08  Michael Catanzaro  <mcatanzaro@igalia.com>
564
565         Unreviewed, switch -pthread to -lpthread per recommendation from Adrian
566         https://bugs.webkit.org/show_bug.cgi?id=182400
567         <rdar://problem/37252242>
568
569         This is tested and works fine.
570
571         * Source/cmake/WebKitCompilerFlags.cmake:
572
573 2018-02-05  Yousuke Kimoto  <yousuke.kimoto@sony.com>
574
575         [WinCairo] Refine WebKitLegacy and WebKit build for wincairo
576         https://bugs.webkit.org/show_bug.cgi?id=182478
577
578         Reviewed by Alex Christensen.
579
580         * Source/cmake/OptionsWinCairo.cmake: Added a ENABLE_WIN_CAIRO_WEBKIT option to build webkit for wincairo.
581
582 2018-02-05  Michael Catanzaro  <mcatanzaro@igalia.com>
583
584         Unreviewed, fix build using the new ENABLE_ADDRESS_SANITIZER option
585         https://bugs.webkit.org/show_bug.cgi?id=182400
586         <rdar://problem/37252242>
587
588         I failed to properly test a last-minute change.
589
590         * Source/cmake/WebKitCompilerFlags.cmake:
591
592 2018-02-05  Michael Catanzaro  <mcatanzaro@igalia.com>
593
594         [CMake] Add ENABLE_ADDRESS_SANITIZER to make it easier to build with asan support
595         https://bugs.webkit.org/show_bug.cgi?id=182400
596
597         Reviewed by Konstantin Tokarev.
598
599         * Source/cmake/OptionsGTK.cmake:
600         * Source/cmake/WebKitCompilerFlags.cmake:
601
602 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
603
604         Update ReadMe.md
605         https://bugs.webkit.org/show_bug.cgi?id=182314
606
607         Reviewed by Alex Christensen.
608
609         Add download link for Epiphany Technology Preview. Improve build instructions for GTK. Add
610         build instructions for WPE. Add instructions to run MiniBrowser on Linux. Miscellaneous
611         typographical adjustments.
612
613         * ReadMe.md:
614
615 2018-01-30  Sergio Villar Senin  <svillar@igalia.com>
616
617         [WebVR][GTK][WPE] Exclude OpenVR from tarballs
618         https://bugs.webkit.org/show_bug.cgi?id=182284
619
620         Reviewed by Michael Catanzaro.
621
622         Added private build options for USE_OPENVR.
623
624         * Source/cmake/OptionsGTK.cmake:
625         * Source/cmake/OptionsWPE.cmake:
626
627 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
628
629         [WinCairo] Fix forwarding header conflict of WebKit on WinCairo
630         https://bugs.webkit.org/show_bug.cgi?id=177202
631
632         Reviewed by Alex Christensen.
633
634         * Source/cmake/WebKitMacros.cmake:
635
636 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
637
638         [WebAuthN] Add a compile-time feature flag
639         https://bugs.webkit.org/show_bug.cgi?id=182211
640         <rdar://problem/36936365>
641
642         Reviewed by Brent Fulgham.
643
644         * Source/cmake/WebKitFeatures.cmake:
645         * Source/cmake/tools/vsprops/FeatureDefines.props:
646         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
647
648 2018-01-18  Sergio Villar Senin  <svillar@igalia.com>
649
650         [WebVR] Add OpenVR to the tree and to the build
651         https://bugs.webkit.org/show_bug.cgi?id=177298
652
653         Reviewed by Žan Doberšek.
654
655         * Source/CMakeLists.txt:
656         * Source/cmake/OptionsGTK.cmake: Enable USE_OPENVR.
657         * Source/cmake/OptionsWPE.cmake: Ditto.
658
659 2018-01-18  Dan Bernstein  <mitz@apple.com>
660
661         [Xcode] Shared schemes in the WebKit workspace still have build pre-actions that invoke copy-webkitlibraries-to-product-directory
662         https://bugs.webkit.org/show_bug.cgi?id=181784
663
664         Reviewed by Anders Carlsson.
665
666         * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: Remove the build pre-action.
667         * WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme: Ditto.
668
669 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
670
671         WEBKIT_FRAMEWORK should not modify file-global include directories
672         https://bugs.webkit.org/show_bug.cgi?id=181656
673
674         Reviewed by Konstantin Tokarev.
675
676         Only modify the system include directories of the target passed to WEBKIT_FRAMEWORK.
677
678         * Source/cmake/WebKitMacros.cmake:
679
680 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
681
682         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.6 release.
683
684         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
685
686 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
687
688         REGRESSION(r226266): [GTK] RELEASE_ASSERT(reservedZoneSize >= minimumReservedZoneSize) in JSC::VM::updateStackLimits
689         https://bugs.webkit.org/show_bug.cgi?id=181438
690         <rdar://problem/36376724>
691
692         Reviewed by Carlos Garcia Campos.
693
694         Build JSC as a shared library.
695
696         Stop using -fvisibility=hidden. This is a shame, but it is causing problems that I don't
697         know how to fix.
698
699         * Source/cmake/OptionsGTK.cmake:
700         * Source/cmake/WebKitCompilerFlags.cmake:
701
702 2018-01-11  Keith Miller  <keith_miller@apple.com>
703
704         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
705         https://bugs.webkit.org/show_bug.cgi?id=181573
706
707         Reviewed by Simon Fraser.
708
709         * Source/cmake/WebKitFeatures.cmake:
710
711 2018-01-10  Per Arne Vollan  <pvollan@apple.com>
712
713         [Win] WebKitLegacy should be a dll, not a static library.
714         https://bugs.webkit.org/show_bug.cgi?id=181500
715
716         Reviewed by Alex Christensen.
717
718         Set WebKitLegacy library type to shared.
719
720         * Source/cmake/OptionsWin.cmake:
721
722 2018-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
723
724         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.5 release.
725
726         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
727
728 2018-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
729
730         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.4 release.
731
732         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
733
734 2018-01-05  Fujii Hironori  <Hironori.Fujii@sony.com>
735
736         REGRESSION(r226306)[Win][CMake] Unnecessary recompilations triggered by unconditionally copied header files of DerivedSources
737         https://bugs.webkit.org/show_bug.cgi?id=181324
738
739         Reviewed by Konstantin Tokarev.
740
741         r226306 changed to use cmake -E copy to copy header files of
742         DerivedSources. This command copies files unconditionally, then
743         introduced unnecessary recompilations.
744
745         * Source/cmake/WebKitMacros.cmake: Use copy_if_different instead of copy.
746
747 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
748
749         Replace hard-coded paths in shebangs with #!/usr/bin/env
750         https://bugs.webkit.org/show_bug.cgi?id=181040
751
752         Reviewed by Alex Christensen.
753
754         * Source/cmake/tools/scripts/auto-version.pl:
755         * Source/cmake/tools/scripts/feature-defines.pl:
756         * Source/cmake/tools/scripts/version-stamp.pl:
757
758 == Rolled over to ChangeLog-2018-01-01 ==