From fdbac1cde7e23dbb05153d832db5749ca4ff1187 Mon Sep 17 00:00:00 2001 From: "ojan@chromium.org" Date: Tue, 10 Jan 2012 21:19:55 +0000 Subject: [PATCH] Rename flex-align to flex-item-align. https://bugs.webkit.org/show_bug.cgi?id=75929 Reviewed by Darin Adler. Source/WebCore: The spec has changed and now flex-align will be set on the flexbox itself. * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EFlexAlign): * css/CSSProperty.cpp: (WebCore::CSSProperty::isInheritedProperty): * css/CSSPropertyNames.in: * css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): * rendering/RenderBox.cpp: (WebCore::RenderBox::sizesToIntrinsicLogicalWidth): * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutAndPlaceChildren): (WebCore::RenderFlexibleBox::alignChildren): * rendering/style/RenderStyle.h: (WebCore::RenderStyleBitfields::flexItemAlign): (WebCore::RenderStyleBitfields::setFlexItemAlign): (WebCore::RenderStyleBitfields::initialFlexItemAlign): * rendering/style/RenderStyleConstants.h: * rendering/style/StyleFlexibleBoxData.cpp: (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData): (WebCore::StyleFlexibleBoxData::operator==): * rendering/style/StyleFlexibleBoxData.h: LayoutTests: * css3/flexbox/css-properties-expected.txt: * css3/flexbox/flex-align-column.html: * css3/flexbox/flex-align-vertical-writing-mode.html: * css3/flexbox/flex-align.html: * css3/flexbox/line-wrapping.html: * css3/flexbox/orthogonal-flex-directions.html: * css3/flexbox/script-tests/css-properties.js: * fast/css/getComputedStyle/computed-style-expected.txt: * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104625 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- LayoutTests/ChangeLog | 18 +++++ .../css3/flexbox/css-properties-expected.txt | 30 ++++---- LayoutTests/css3/flexbox/flex-align-column.html | 20 +++--- .../flexbox/flex-align-vertical-writing-mode.html | 82 +++++++++++----------- LayoutTests/css3/flexbox/flex-align.html | 70 +++++++++--------- LayoutTests/css3/flexbox/line-wrapping.html | 30 ++++---- .../css3/flexbox/orthogonal-flex-directions.html | 2 +- .../css3/flexbox/script-tests/css-properties.js | 44 ++++++------ .../getComputedStyle/computed-style-expected.txt | 2 +- .../computed-style-without-renderer-expected.txt | 2 +- .../svg/css/getComputedStyle-basic-expected.txt | 8 +-- Source/WebCore/ChangeLog | 39 ++++++++++ Source/WebCore/css/CSSComputedStyleDeclaration.cpp | 6 +- Source/WebCore/css/CSSParser.cpp | 4 +- Source/WebCore/css/CSSPrimitiveValueMappings.h | 5 ++ Source/WebCore/css/CSSProperty.cpp | 2 +- Source/WebCore/css/CSSPropertyNames.in | 2 +- Source/WebCore/css/CSSStyleApplyProperty.cpp | 2 +- Source/WebCore/css/CSSStyleSelector.cpp | 2 +- Source/WebCore/rendering/RenderBox.cpp | 2 +- Source/WebCore/rendering/RenderFlexibleBox.cpp | 7 +- Source/WebCore/rendering/style/RenderStyle.h | 7 +- .../WebCore/rendering/style/RenderStyleConstants.h | 2 +- .../rendering/style/StyleFlexibleBoxData.cpp | 6 +- .../WebCore/rendering/style/StyleFlexibleBoxData.h | 2 +- 25 files changed, 231 insertions(+), 165 deletions(-) diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog index 4002929..a66946b 100644 --- a/LayoutTests/ChangeLog +++ b/LayoutTests/ChangeLog @@ -1,3 +1,21 @@ +2012-01-10 Ojan Vafai + + Rename flex-align to flex-item-align. + https://bugs.webkit.org/show_bug.cgi?id=75929 + + Reviewed by Darin Adler. + + * css3/flexbox/css-properties-expected.txt: + * css3/flexbox/flex-align-column.html: + * css3/flexbox/flex-align-vertical-writing-mode.html: + * css3/flexbox/flex-align.html: + * css3/flexbox/line-wrapping.html: + * css3/flexbox/orthogonal-flex-directions.html: + * css3/flexbox/script-tests/css-properties.js: + * fast/css/getComputedStyle/computed-style-expected.txt: + * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: + * svg/css/getComputedStyle-basic-expected.txt: + 2012-01-10 Eric Carlson Replace TextTrackCue "getCueAsSource" method with "text" attribute diff --git a/LayoutTests/css3/flexbox/css-properties-expected.txt b/LayoutTests/css3/flexbox/css-properties-expected.txt index b6b3705da..069dec0 100644 --- a/LayoutTests/css3/flexbox/css-properties-expected.txt +++ b/LayoutTests/css3/flexbox/css-properties-expected.txt @@ -28,21 +28,21 @@ PASS flexbox.style.webkitFlexPack is "justify" PASS window.getComputedStyle(flexbox, null).webkitFlexPack is "justify" PASS flexbox.style.webkitFlexPack is "" PASS window.getComputedStyle(flexbox, null).webkitFlexPack is "start" -PASS flexbox.style.webkitFlexAlign is "" -PASS window.getComputedStyle(flexbox, null).webkitFlexAlign is "stretch" -PASS flexbox.style.webkitFlexAlign is "" -PASS flexbox.style.webkitFlexAlign is "start" -PASS window.getComputedStyle(flexbox, null).webkitFlexAlign is "start" -PASS flexbox.style.webkitFlexAlign is "end" -PASS window.getComputedStyle(flexbox, null).webkitFlexAlign is "end" -PASS flexbox.style.webkitFlexAlign is "center" -PASS window.getComputedStyle(flexbox, null).webkitFlexAlign is "center" -PASS flexbox.style.webkitFlexAlign is "stretch" -PASS window.getComputedStyle(flexbox, null).webkitFlexAlign is "stretch" -PASS flexbox.style.webkitFlexAlign is "baseline" -PASS window.getComputedStyle(flexbox, null).webkitFlexAlign is "baseline" -PASS flexbox.style.webkitFlexAlign is "" -PASS window.getComputedStyle(flexbox, null).webkitFlexAlign is "stretch" +PASS flexbox.style.webkitFlexItemAlign is "" +PASS window.getComputedStyle(flexbox, null).webkitFlexItemAlign is "stretch" +PASS flexbox.style.webkitFlexItemAlign is "" +PASS flexbox.style.webkitFlexItemAlign is "start" +PASS window.getComputedStyle(flexbox, null).webkitFlexItemAlign is "start" +PASS flexbox.style.webkitFlexItemAlign is "end" +PASS window.getComputedStyle(flexbox, null).webkitFlexItemAlign is "end" +PASS flexbox.style.webkitFlexItemAlign is "center" +PASS window.getComputedStyle(flexbox, null).webkitFlexItemAlign is "center" +PASS flexbox.style.webkitFlexItemAlign is "stretch" +PASS window.getComputedStyle(flexbox, null).webkitFlexItemAlign is "stretch" +PASS flexbox.style.webkitFlexItemAlign is "baseline" +PASS window.getComputedStyle(flexbox, null).webkitFlexItemAlign is "baseline" +PASS flexbox.style.webkitFlexItemAlign is "" +PASS window.getComputedStyle(flexbox, null).webkitFlexItemAlign is "stretch" PASS flexbox.style.webkitFlexDirection is "" PASS window.getComputedStyle(flexbox, null).webkitFlexDirection is "row" PASS flexbox.style.webkitFlexDirection is "" diff --git a/LayoutTests/css3/flexbox/flex-align-column.html b/LayoutTests/css3/flexbox/flex-align-column.html index 4cbc210..ee2e4b2 100644 --- a/LayoutTests/css3/flexbox/flex-align-column.html +++ b/LayoutTests/css3/flexbox/flex-align-column.html @@ -46,20 +46,20 @@ if (window.layoutTestController)
-
-
-
-
-
+
+
+
+
+
-
-
-
-
-
+
+
+
+
+
diff --git a/LayoutTests/css3/flexbox/flex-align-vertical-writing-mode.html b/LayoutTests/css3/flexbox/flex-align-vertical-writing-mode.html index 6a00e6c..fdf2c7c 100644 --- a/LayoutTests/css3/flexbox/flex-align-vertical-writing-mode.html +++ b/LayoutTests/css3/flexbox/flex-align-vertical-writing-mode.html @@ -81,86 +81,86 @@ if (window.layoutTestController)
-
-
-
-
-
-
+
+
+
+
+
+
-
-
-
-
-
-
+
+
+
+
+
+
-
-
-
-
-
-
+
+
+
+
+
+
-
-
-
+
+
+
-
-
-
+
+
+
-
-
-
+
+
+
-
ahem
-
-
-
+
ahem
+
+
+
-
ahem
-

-
+
ahem
+

+
-
ahem
-
-
-
+
ahem
+
+
+
-
ahem
-

-
+
ahem
+

+
diff --git a/LayoutTests/css3/flexbox/flex-align.html b/LayoutTests/css3/flexbox/flex-align.html index 8c6f823..2c67d2a 100644 --- a/LayoutTests/css3/flexbox/flex-align.html +++ b/LayoutTests/css3/flexbox/flex-align.html @@ -88,71 +88,71 @@ if (window.layoutTestController)
-
-
-
-
-
-
+
+
+
+
+
+
-
-
-
-
-
-
+
+
+
+
+
+
-
-
-
-
-
-
+
+
+
+
+
+
-
-
-
+
+
+
-
-
-
+
+
+
-
-
-
+
+
+
-
ahem
-
-
-
+
ahem
+
+
+
-
ahem
-

-
+
ahem
+

+
@@ -167,7 +167,7 @@ function additionalBaselineChecks() logIfFalse(baseline1.offsetTop + baseline1.offsetHeight == baseline2.offsetTop + baseline2.offsetHeight, "baseline1 and baseline2 should have the same baseline."); logIfFalse(baseline3.offsetTop < 25, - "baseline3 should be above the center flex-aligned item."); + "baseline3 should be above the center flex-item-aligned item."); var baseline4 = document.getElementById("baseline4"); var baseline5 = document.getElementById("baseline5"); diff --git a/LayoutTests/css3/flexbox/line-wrapping.html b/LayoutTests/css3/flexbox/line-wrapping.html index 45d2f0c..edfff45 100644 --- a/LayoutTests/css3/flexbox/line-wrapping.html +++ b/LayoutTests/css3/flexbox/line-wrapping.html @@ -117,7 +117,7 @@ if (window.layoutTestController)
-
+
@@ -126,7 +126,7 @@ if (window.layoutTestController)
-
+
@@ -135,7 +135,7 @@ if (window.layoutTestController)
-
+
@@ -144,7 +144,7 @@ if (window.layoutTestController)
-
+
@@ -153,7 +153,7 @@ if (window.layoutTestController)
-
+
@@ -164,7 +164,7 @@ if (window.layoutTestController)
-
+
@@ -173,7 +173,7 @@ if (window.layoutTestController)
-
+
@@ -182,7 +182,7 @@ if (window.layoutTestController)
-
+
@@ -191,7 +191,7 @@ if (window.layoutTestController)
-
+
@@ -200,7 +200,7 @@ if (window.layoutTestController)
-
+
@@ -210,7 +210,7 @@ if (window.layoutTestController)
-
+
@@ -219,7 +219,7 @@ if (window.layoutTestController)
-
+
@@ -228,7 +228,7 @@ if (window.layoutTestController)
-
+
@@ -237,7 +237,7 @@ if (window.layoutTestController)
-
+
@@ -249,7 +249,7 @@ if (window.layoutTestController)
-
+
diff --git a/LayoutTests/css3/flexbox/orthogonal-flex-directions.html b/LayoutTests/css3/flexbox/orthogonal-flex-directions.html index a4d3ec0..107cf523 100644 --- a/LayoutTests/css3/flexbox/orthogonal-flex-directions.html +++ b/LayoutTests/css3/flexbox/orthogonal-flex-directions.html @@ -59,7 +59,7 @@ body { } .align-start { - -webkit-flex-align: start; + -webkit-flex-item-align: start; }