From e1a549b83f1f61148c3f21defa3cdb386b880be0 Mon Sep 17 00:00:00 2001 From: "caseq@chromium.org" Date: Wed, 19 Jan 2011 11:37:34 +0000 Subject: [PATCH] 2011-01-19 Andrey Kosyakov Reviewed by Pavel Feldman. Web Inspector: [Extensions API] delete pending callback from callback map before invoking it https://bugs.webkit.org/show_bug.cgi?id=52707 * inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.ExtensionServerClient.prototype._onCallback): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76109 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Source/WebCore/ChangeLog | 10 ++++++++++ Source/WebCore/inspector/front-end/ExtensionAPI.js | 3 ++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index cd1b927..7dfe09b 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,3 +1,13 @@ +2011-01-19 Andrey Kosyakov + + Reviewed by Pavel Feldman. + + Web Inspector: [Extensions API] delete pending callback from callback map before invoking it + https://bugs.webkit.org/show_bug.cgi?id=52707 + + * inspector/front-end/ExtensionAPI.js: + (WebInspector.injectedExtensionAPI.ExtensionServerClient.prototype._onCallback): + 2011-01-19 Levi Weintraub Reviewed by Ryosuke Niwa. diff --git a/Source/WebCore/inspector/front-end/ExtensionAPI.js b/Source/WebCore/inspector/front-end/ExtensionAPI.js index a9a2423..b10452d 100644 --- a/Source/WebCore/inspector/front-end/ExtensionAPI.js +++ b/Source/WebCore/inspector/front-end/ExtensionAPI.js @@ -450,8 +450,9 @@ ExtensionServerClient.prototype = { _onCallback: function(request) { if (request.requestId in this._callbacks) { - this._callbacks[request.requestId](request.result); + var callback = this._callbacks[request.requestId]; delete this._callbacks[request.requestId]; + callback(request.result); } }, -- 1.8.3.1