From d3592c5de39e5568a122caa773bf8f8d342989af Mon Sep 17 00:00:00 2001 From: "jer.noble@apple.com" Date: Mon, 2 Apr 2018 18:59:59 +0000 Subject: [PATCH] Enable Legacy EME for all WebKit & WebKitLegacy clients https://bugs.webkit.org/show_bug.cgi?id=184018 Reviewed by Eric Carlson. Source/WebKit: * Shared/WebPreferences.yaml: * Shared/WebPreferencesDefaultValues.h: Source/WebKitLegacy/mac: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230169 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Source/WebKit/ChangeLog | 11 +++++++++++ Source/WebKit/Shared/WebPreferences.yaml | 2 +- Source/WebKit/Shared/WebPreferencesDefaultValues.h | 2 -- Source/WebKitLegacy/mac/ChangeLog | 11 +++++++++++ Source/WebKitLegacy/mac/WebView/WebPreferences.mm | 4 ---- 5 files changed, 23 insertions(+), 7 deletions(-) diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog index 90898e6..1425aea 100644 --- a/Source/WebKit/ChangeLog +++ b/Source/WebKit/ChangeLog @@ -1,5 +1,16 @@ 2018-04-02 Jer Noble + Enable Legacy EME for all WebKit & WebKitLegacy clients + https://bugs.webkit.org/show_bug.cgi?id=184018 + + + Reviewed by Eric Carlson. + + * Shared/WebPreferences.yaml: + * Shared/WebPreferencesDefaultValues.h: + +2018-04-02 Jer Noble + REGRESSION (229680): Fullscreen video does not work (youtube, netflix) https://bugs.webkit.org/show_bug.cgi?id=184235 diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml index b4231fd..9babe92 100644 --- a/Source/WebKit/Shared/WebPreferences.yaml +++ b/Source/WebKit/Shared/WebPreferences.yaml @@ -741,7 +741,7 @@ BeaconAPIEnabled: LegacyEncryptedMediaAPIEnabled: type: bool - defaultValue: DEFAULT_LEGACY_ENCRYPTED_MEDIA_API_ENABLED + defaultValue: true humanReadableName: "Enable Legacy EME API" humanReadableDescription: "Enable legacy EME API" webcoreBinding: RuntimeEnabledFeatures diff --git a/Source/WebKit/Shared/WebPreferencesDefaultValues.h b/Source/WebKit/Shared/WebPreferencesDefaultValues.h index 35f557e..566289a 100644 --- a/Source/WebKit/Shared/WebPreferencesDefaultValues.h +++ b/Source/WebKit/Shared/WebPreferencesDefaultValues.h @@ -74,7 +74,6 @@ #define DEFAULT_MEDIA_CONTROLS_SCALE_WITH_PAGE_ZOOM false #define DEFAULT_TEMPORARY_TILE_COHORT_RETENTION_ENABLED false #define DEFAULT_REQUIRES_USER_GESTURE_FOR_AUDIO_PLAYBACK true -#define DEFAULT_LEGACY_ENCRYPTED_MEDIA_API_ENABLED false #define DEFAULT_INTERACTIVE_MEDIA_CAPTURE_STREAM_REPROMPT_INTERVAL_IN_MINUTES 1 #define DEFAULT_ENABLE_FULLSCREEN_API false #else @@ -94,7 +93,6 @@ #define DEFAULT_MEDIA_CONTROLS_SCALE_WITH_PAGE_ZOOM true #define DEFAULT_TEMPORARY_TILE_COHORT_RETENTION_ENABLED true #define DEFAULT_REQUIRES_USER_GESTURE_FOR_AUDIO_PLAYBACK false -#define DEFAULT_LEGACY_ENCRYPTED_MEDIA_API_ENABLED true #define DEFAULT_INTERACTIVE_MEDIA_CAPTURE_STREAM_REPROMPT_INTERVAL_IN_MINUTES 10 #define DEFAULT_ENABLE_FULLSCREEN_API true #endif diff --git a/Source/WebKitLegacy/mac/ChangeLog b/Source/WebKitLegacy/mac/ChangeLog index 18a0904..f616a81 100644 --- a/Source/WebKitLegacy/mac/ChangeLog +++ b/Source/WebKitLegacy/mac/ChangeLog @@ -1,3 +1,14 @@ +2018-04-02 Jer Noble + + Enable Legacy EME for all WebKit & WebKitLegacy clients + https://bugs.webkit.org/show_bug.cgi?id=184018 + + + Reviewed by Eric Carlson. + + * WebView/WebPreferences.mm: + (+[WebPreferences initialize]): + 2018-03-29 JF Bastien Use Forward.h instead of forward-declaring WTF::String diff --git a/Source/WebKitLegacy/mac/WebView/WebPreferences.mm b/Source/WebKitLegacy/mac/WebView/WebPreferences.mm index 344bad5..1bb4796 100644 --- a/Source/WebKitLegacy/mac/WebView/WebPreferences.mm +++ b/Source/WebKitLegacy/mac/WebView/WebPreferences.mm @@ -672,11 +672,7 @@ public: @NO, WebKitWebAuthenticationEnabledPreferenceKey, @NO, WebKitMediaUserGestureInheritsFromDocument, @NO, WebKitIsSecureContextAttributeEnabledPreferenceKey, -#if PLATFORM(IOS) - @NO, WebKitLegacyEncryptedMediaAPIEnabledKey, -#else @YES, WebKitLegacyEncryptedMediaAPIEnabledKey, -#endif @NO, WebKitEncryptedMediaAPIEnabledKey, @YES, WebKitViewportFitEnabledPreferenceKey, @YES, WebKitConstantPropertiesEnabledPreferenceKey, -- 1.8.3.1