From b8a5003d7f900256a0d1e9f9b2bf0b2952f5ef13 Mon Sep 17 00:00:00 2001 From: "eae@chromium.org" Date: Tue, 5 Mar 2013 23:59:52 +0000 Subject: [PATCH] ASSERTION FAILED: i < size(), UNKNOWN in WebCore::RenderTableSection::layout https://bugs.webkit.org/show_bug.cgi?id=108838 Source/WebCore: Reviewed by Levi Weintraub. Ensure that RenderTable::recalcSections is called when moving a TableSection by calling setNeedsSectionRecalc in addChild for TableSections. Test: fullscreen/full-screen-table-section.html * rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): LayoutTests: Reviewed by Levi Weintraub. Add test for calling requestFullscreen on an element with a table-section display type. * fullscreen/full-screen-table-section-expected.txt: Added. * fullscreen/full-screen-table-section.html: Added. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144837 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- LayoutTests/ChangeLog | 13 +++++++ .../full-screen-table-section-expected.txt | 5 +++ .../fullscreen/full-screen-table-section.html | 40 ++++++++++++++++++++++ Source/WebCore/ChangeLog | 16 +++++++++ Source/WebCore/rendering/RenderTable.cpp | 3 ++ 5 files changed, 77 insertions(+) create mode 100644 LayoutTests/fullscreen/full-screen-table-section-expected.txt create mode 100644 LayoutTests/fullscreen/full-screen-table-section.html diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog index 012da00..9314f81 100644 --- a/LayoutTests/ChangeLog +++ b/LayoutTests/ChangeLog @@ -1,3 +1,16 @@ +2013-03-05 Emil A Eklund + + ASSERTION FAILED: i < size(), UNKNOWN in WebCore::RenderTableSection::layout + https://bugs.webkit.org/show_bug.cgi?id=108838 + + Reviewed by Levi Weintraub. + + Add test for calling requestFullscreen on an element with a + table-section display type. + + * fullscreen/full-screen-table-section-expected.txt: Added. + * fullscreen/full-screen-table-section.html: Added. + 2013-03-05 Roger Fong Unreviewed. Skip tests on Windows to make EWS bots happier. diff --git a/LayoutTests/fullscreen/full-screen-table-section-expected.txt b/LayoutTests/fullscreen/full-screen-table-section-expected.txt new file mode 100644 index 0000000..5d6a8b1 --- /dev/null +++ b/LayoutTests/fullscreen/full-screen-table-section-expected.txt @@ -0,0 +1,5 @@ +PASS document.webkitFullscreenElement.id is 'test' +Tests that a table-section element can be used in full screen mode. + +Test Element +Hit Enter to run if not in test runner. diff --git a/LayoutTests/fullscreen/full-screen-table-section.html b/LayoutTests/fullscreen/full-screen-table-section.html new file mode 100644 index 0000000..4ae6557 --- /dev/null +++ b/LayoutTests/fullscreen/full-screen-table-section.html @@ -0,0 +1,40 @@ + + + + + + +

+ Tests that a table-section element can be used in full screen mode. +

Test Element

+ Hit Enter to run if not in test runner. +

+ + + diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index 968766e..2817286 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,3 +1,19 @@ +2013-03-05 Emil A Eklund + + ASSERTION FAILED: i < size(), UNKNOWN in WebCore::RenderTableSection::layout + https://bugs.webkit.org/show_bug.cgi?id=108838 + + Reviewed by Levi Weintraub. + + Ensure that RenderTable::recalcSections is called when moving a + TableSection by calling setNeedsSectionRecalc in addChild for + TableSections. + + Test: fullscreen/full-screen-table-section.html + + * rendering/RenderTable.cpp: + (WebCore::RenderTable::addChild): + 2013-03-05 Kenneth Russell Upgrade ANGLE to r1987 diff --git a/Source/WebCore/rendering/RenderTable.cpp b/Source/WebCore/rendering/RenderTable.cpp index 21ccd93..497bca1 100644 --- a/Source/WebCore/rendering/RenderTable.cpp +++ b/Source/WebCore/rendering/RenderTable.cpp @@ -154,6 +154,9 @@ void RenderTable::addChild(RenderObject* child, RenderObject* beforeChild) else wrapInAnonymousSection = true; + if (child->isTableSection()) + setNeedsSectionRecalc(); + if (!wrapInAnonymousSection) { if (beforeChild && beforeChild->parent() != this) beforeChild = splitAnonymousBoxesAroundChild(beforeChild); -- 1.8.3.1