From 7df4d89f302e0395abbeec4b1874e0d9c5e844d7 Mon Sep 17 00:00:00 2001 From: "zalan@apple.com" Date: Mon, 6 Jun 2016 03:19:21 +0000 Subject: [PATCH] Addressing post-review comments on r201635. Reviewed by Chris Dumez. * rendering/RenderInline.h: (WebCore::RenderInline::computeRectForRepaint): * rendering/RenderObject.h: (WebCore::RenderObject::RepaintContext::RepaintContext): (WebCore::RenderObject::computeRectForRepaint): * rendering/RenderTableCell.h: * rendering/RenderView.h: * rendering/svg/RenderSVGForeignObject.h: * rendering/svg/RenderSVGText.h: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@201704 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Source/WebCore/ChangeLog | 16 ++++++++++++++++ Source/WebCore/rendering/RenderInline.h | 2 +- Source/WebCore/rendering/RenderObject.h | 8 ++++---- Source/WebCore/rendering/RenderTableCell.h | 2 +- Source/WebCore/rendering/RenderView.h | 2 +- Source/WebCore/rendering/svg/RenderSVGForeignObject.h | 2 +- Source/WebCore/rendering/svg/RenderSVGText.h | 2 +- 7 files changed, 25 insertions(+), 9 deletions(-) diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index fd5ba59..ef3bac9 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,3 +1,19 @@ +2016-06-05 Zalan Bujtas + + Addressing post-review comments on r201635. + + Reviewed by Chris Dumez. + + * rendering/RenderInline.h: + (WebCore::RenderInline::computeRectForRepaint): + * rendering/RenderObject.h: + (WebCore::RenderObject::RepaintContext::RepaintContext): + (WebCore::RenderObject::computeRectForRepaint): + * rendering/RenderTableCell.h: + * rendering/RenderView.h: + * rendering/svg/RenderSVGForeignObject.h: + * rendering/svg/RenderSVGText.h: + 2016-06-05 Yusuke Suzuki Change ProxyObject.[[Get]] not to use custom accessor diff --git a/Source/WebCore/rendering/RenderInline.h b/Source/WebCore/rendering/RenderInline.h index d915660..5ceafc2 100644 --- a/Source/WebCore/rendering/RenderInline.h +++ b/Source/WebCore/rendering/RenderInline.h @@ -145,7 +145,7 @@ private: LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const override; LayoutRect rectWithOutlineForRepaint(const RenderLayerModelObject* repaintContainer, LayoutUnit outlineWidth) const final; - LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { false, false }) const final; + LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { }) const final; void mapLocalToContainer(const RenderLayerModelObject* repaintContainer, TransformState&, MapCoordinatesFlags, bool* wasFixed) const override; const RenderObject* pushMappingToContainer(const RenderLayerModelObject* ancestorToStopAt, RenderGeometryMap&) const override; diff --git a/Source/WebCore/rendering/RenderObject.h b/Source/WebCore/rendering/RenderObject.h index 6486686..6314a06 100644 --- a/Source/WebCore/rendering/RenderObject.h +++ b/Source/WebCore/rendering/RenderObject.h @@ -747,15 +747,15 @@ public: // Given a rect in the object's coordinate space, compute a rect suitable for repainting // that rect in the coordinate space of repaintContainer. struct RepaintContext { - RepaintContext(bool hasPositionFixedDescendant, bool dirtyRectIsFlipped) + RepaintContext(bool hasPositionFixedDescendant = false, bool dirtyRectIsFlipped = false) : m_hasPositionFixedDescendant(hasPositionFixedDescendant) , m_dirtyRectIsFlipped(dirtyRectIsFlipped) { } - bool m_hasPositionFixedDescendant { false }; - bool m_dirtyRectIsFlipped { false }; + bool m_hasPositionFixedDescendant; + bool m_dirtyRectIsFlipped; }; - virtual LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { false, false }) const; + virtual LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { }) const; virtual FloatRect computeFloatRectForRepaint(const FloatRect&, const RenderLayerModelObject* repaintContainer, bool fixed = false) const; virtual unsigned int length() const { return 1; } diff --git a/Source/WebCore/rendering/RenderTableCell.h b/Source/WebCore/rendering/RenderTableCell.h index 064b980..b592f75 100644 --- a/Source/WebCore/rendering/RenderTableCell.h +++ b/Source/WebCore/rendering/RenderTableCell.h @@ -153,7 +153,7 @@ private: bool boxShadowShouldBeAppliedToBackground(const LayoutPoint& paintOffset, BackgroundBleedAvoidance, InlineFlowBox*) const override; LayoutSize offsetFromContainer(RenderElement&, const LayoutPoint&, bool* offsetDependsOnPoint = 0) const override; - LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { false, false }) const override; + LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { }) const override; LayoutUnit borderHalfLeft(bool outer) const; LayoutUnit borderHalfRight(bool outer) const; diff --git a/Source/WebCore/rendering/RenderView.h b/Source/WebCore/rendering/RenderView.h index 531e0c5..b4cfbe0 100644 --- a/Source/WebCore/rendering/RenderView.h +++ b/Source/WebCore/rendering/RenderView.h @@ -76,7 +76,7 @@ public: FrameView& frameView() const { return m_frameView; } LayoutRect visualOverflowRect() const override; - LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { false, false }) const override; + LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { }) const override; void repaintRootContents(); void repaintViewRectangle(const LayoutRect&) const; void repaintViewAndCompositedLayers(); diff --git a/Source/WebCore/rendering/svg/RenderSVGForeignObject.h b/Source/WebCore/rendering/svg/RenderSVGForeignObject.h index de2de12..a3702e2 100644 --- a/Source/WebCore/rendering/svg/RenderSVGForeignObject.h +++ b/Source/WebCore/rendering/svg/RenderSVGForeignObject.h @@ -41,7 +41,7 @@ public: LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const override; FloatRect computeFloatRectForRepaint(const FloatRect&, const RenderLayerModelObject* repaintContainer, bool fixed = false) const override; - LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { false, false }) const override; + LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { }) const override; bool requiresLayer() const override { return false; } void layout() override; diff --git a/Source/WebCore/rendering/svg/RenderSVGText.h b/Source/WebCore/rendering/svg/RenderSVGText.h index 7892ce8..dd2ec30 100644 --- a/Source/WebCore/rendering/svg/RenderSVGText.h +++ b/Source/WebCore/rendering/svg/RenderSVGText.h @@ -78,7 +78,7 @@ private: void absoluteQuads(Vector&, bool* wasFixed) const override; LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const override; - LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { false, false }) const override; + LayoutRect computeRectForRepaint(const LayoutRect&, const RenderLayerModelObject* repaintContainer, RepaintContext = { }) const override; FloatRect computeFloatRectForRepaint(const FloatRect&, const RenderLayerModelObject* repaintContainer, bool fixed = false) const override; void mapLocalToContainer(const RenderLayerModelObject* repaintContainer, TransformState&, MapCoordinatesFlags, bool* wasFixed) const override; -- 1.8.3.1