From 484a174fdc95bb381ea34ea1b4234c248e54621c Mon Sep 17 00:00:00 2001 From: "antti@apple.com" Date: Mon, 22 Jan 2018 18:48:42 +0000 Subject: [PATCH] REGRESSION(r224535): Can't write reviews in the App Store https://bugs.webkit.org/show_bug.cgi?id=181936 Reviewed by Zalan Bujtas. * page/LayoutContext.cpp: (WebCore::LayoutContext::updateStyleForLayout): r224535 was about media queries but it also removed a seemingly spurious call to SyleScope::didChangeStyleSheetEnvironment from the path that does not involve media queries. Turns out UITextContentView somehow depended on it, so revert this specific change. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@227343 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Source/WebCore/ChangeLog | 15 +++++++++++++++ Source/WebCore/page/LayoutContext.cpp | 5 +++++ 2 files changed, 20 insertions(+) diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index 1473109..99d56e6 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,3 +1,18 @@ +2018-01-22 Antti Koivisto + + REGRESSION(r224535): Can't write reviews in the App Store + https://bugs.webkit.org/show_bug.cgi?id=181936 + + + Reviewed by Zalan Bujtas. + + * page/LayoutContext.cpp: + (WebCore::LayoutContext::updateStyleForLayout): + + r224535 was about media queries but it also removed a seemingly spurious call to SyleScope::didChangeStyleSheetEnvironment + from the path that does not involve media queries. + Turns out UITextContentView somehow depended on it, so revert this specific change. + 2018-01-22 Brady Eidson In WebKit2, make the MessagePortChannelRegistry live in the UI process. diff --git a/Source/WebCore/page/LayoutContext.cpp b/Source/WebCore/page/LayoutContext.cpp index ce7c3b3..bce90df 100644 --- a/Source/WebCore/page/LayoutContext.cpp +++ b/Source/WebCore/page/LayoutContext.cpp @@ -482,6 +482,11 @@ void LayoutContext::applyTextSizingIfNeeded(RenderElement& layoutRoot) void LayoutContext::updateStyleForLayout() { Document& document = *frame().document(); + + // FIXME: This shouldn't be necessary, but see rdar://problem/36670246. + if (!document.styleScope().resolverIfExists()) + document.styleScope().didChangeStyleSheetEnvironment(); + // Viewport-dependent media queries may cause us to need completely different style information. document.styleScope().evaluateMediaQueriesForViewportChange(); -- 1.8.3.1