From 199e250622aa8a24aa2d0546374255911577d4fc Mon Sep 17 00:00:00 2001 From: "commit-queue@webkit.org" Date: Sat, 2 May 2015 15:41:48 +0000 Subject: [PATCH] Use Ref instead of PassRefPtr in WebCore/svg https://bugs.webkit.org/show_bug.cgi?id=144479 Patch by Gyuyoung Kim on 2015-05-02 Reviewed by Darin Adler. Remove remained PassRefPtr in svg. No new tests, no behavior changes. * svg/SVGFontFaceSrcElement.cpp: (WebCore::SVGFontFaceSrcElement::srcValue): * svg/SVGFontFaceSrcElement.h: * svg/properties/SVGPropertyInfo.h: git-svn-id: https://svn.webkit.org/repository/webkit/trunk@183717 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Source/WebCore/ChangeLog | 16 ++++++++++++++++ Source/WebCore/svg/SVGFontFaceSrcElement.cpp | 4 ++-- Source/WebCore/svg/SVGFontFaceSrcElement.h | 2 +- Source/WebCore/svg/properties/SVGPropertyInfo.h | 1 - 4 files changed, 19 insertions(+), 4 deletions(-) diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index 8a37f06..cdf2dca 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,3 +1,19 @@ +2015-05-02 Gyuyoung Kim + + Use Ref instead of PassRefPtr in WebCore/svg + https://bugs.webkit.org/show_bug.cgi?id=144479 + + Reviewed by Darin Adler. + + Remove remained PassRefPtr in svg. + + No new tests, no behavior changes. + + * svg/SVGFontFaceSrcElement.cpp: + (WebCore::SVGFontFaceSrcElement::srcValue): + * svg/SVGFontFaceSrcElement.h: + * svg/properties/SVGPropertyInfo.h: + 2015-05-02 Simon Fraser Small cleanup in BitmapImage diff --git a/Source/WebCore/svg/SVGFontFaceSrcElement.cpp b/Source/WebCore/svg/SVGFontFaceSrcElement.cpp index 718c3a9..d6b9341 100644 --- a/Source/WebCore/svg/SVGFontFaceSrcElement.cpp +++ b/Source/WebCore/svg/SVGFontFaceSrcElement.cpp @@ -45,9 +45,9 @@ Ref SVGFontFaceSrcElement::create(const QualifiedName& ta return adoptRef(*new SVGFontFaceSrcElement(tagName, document)); } -PassRefPtr SVGFontFaceSrcElement::srcValue() const +Ref SVGFontFaceSrcElement::srcValue() const { - RefPtr list = CSSValueList::createCommaSeparated(); + Ref list = CSSValueList::createCommaSeparated(); for (auto& child : childrenOfType(*this)) { RefPtr srcValue; if (is(child)) diff --git a/Source/WebCore/svg/SVGFontFaceSrcElement.h b/Source/WebCore/svg/SVGFontFaceSrcElement.h index 6bd5563..e3111ea 100644 --- a/Source/WebCore/svg/SVGFontFaceSrcElement.h +++ b/Source/WebCore/svg/SVGFontFaceSrcElement.h @@ -31,7 +31,7 @@ class SVGFontFaceSrcElement final : public SVGElement { public: static Ref create(const QualifiedName&, Document&); - PassRefPtr srcValue() const; + Ref srcValue() const; private: SVGFontFaceSrcElement(const QualifiedName&, Document&); diff --git a/Source/WebCore/svg/properties/SVGPropertyInfo.h b/Source/WebCore/svg/properties/SVGPropertyInfo.h index 69725b5..79cc951 100644 --- a/Source/WebCore/svg/properties/SVGPropertyInfo.h +++ b/Source/WebCore/svg/properties/SVGPropertyInfo.h @@ -21,7 +21,6 @@ #define SVGPropertyInfo_h #include "QualifiedName.h" -#include namespace WebCore { -- 1.8.3.1