WebKit-https.git
8 years agoUnreviewed, gardening.
haraken@chromium.org [Fri, 2 Mar 2012 09:30:00 +0000 (09:30 +0000)]
Unreviewed, gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHandle CSSPropertyWebkitRegionBreakAfter, CSSPropertyWebkitRegionBreakBefore and...
macpherson@chromium.org [Fri, 2 Mar 2012 09:22:37 +0000 (09:22 +0000)]
Handle CSSPropertyWebkitRegionBreakAfter, CSSPropertyWebkitRegionBreakBefore and CSSPropertyWebkitRegionBreakInside in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80066

Reviewed by Eric Seidel.

No new tests / refactoring only.

* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement DefaultParagraphSeparator execCommand, to let authors choose the default...
commit-queue@webkit.org [Fri, 2 Mar 2012 09:20:39 +0000 (09:20 +0000)]
Implement DefaultParagraphSeparator execCommand, to let authors choose the default block element
https://bugs.webkit.org/show_bug.cgi?id=59961

Patch by Pablo Flouret <pablof@motorola.com> on 2012-03-02
Reviewed by Ryosuke Niwa.

Source/WebCore:

http://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#the-defaultparagraphseparator-command

Test: editing/execCommand/default-paragraph-separator.html

* editing/Editor.cpp:
(WebCore::Editor::Editor):
* editing/Editor.h:
(WebCore::Editor::defaultParagraphSeparator):
(WebCore::Editor::setDefaultParagraphSeparator):
(Editor):
* editing/EditorCommand.cpp:
(WebCore::executeDefaultParagraphSeparator):
(WebCore):
(WebCore::valueDefaultParagraphSeparator):
(WebCore::createCommandMap):
* editing/htmlediting.cpp:
(WebCore::createDefaultParagraphElement):

* html/HTMLParagraphElement.cpp:
(WebCore::HTMLParagraphElement::create):
(WebCore):
* html/HTMLParagraphElement.h:
(HTMLParagraphElement):
    Added create(Document*) method that defaults to pTag as the QualifiedName.

LayoutTests:

* editing/execCommand/default-paragraph-separator-expected.txt: Added.
* editing/execCommand/default-paragraph-separator.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Fix errors in LayerRendererChromium cleanup
kbr@google.com [Fri, 2 Mar 2012 09:12:43 +0000 (09:12 +0000)]
[chromium] Fix errors in LayerRendererChromium cleanup
https://bugs.webkit.org/show_bug.cgi?id=80064

Reviewed by James Robinson.

Tested manually by forcing lost context while rendering Flash on
Mac OS in a Debug build.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::cleanupSharedObjects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix errors found when building the Mac port with ICONDATABASE disabled.
aestes@apple.com [Fri, 2 Mar 2012 09:05:09 +0000 (09:05 +0000)]
Fix errors found when building the Mac port with ICONDATABASE disabled.
https://bugs.webkit.org/show_bug.cgi?id=80059

Reviewed by Brady Eidson.

* WebCore.exp.in: Only export IconDatabase symbols when the feature is
enabled.
* loader/icon/IconDatabase.h:
(WebCore::IconDatabase::create): WebKit calls this static method, so it
should be defined on the stub class.
(WebCore::IconDatabase::allowDatabaseCleanup): Ditto.
(WebCore::IconDatabase::checkIntegrityBeforeOpening): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix a warning in InputHandler::learnText()
commit-queue@webkit.org [Fri, 2 Mar 2012 08:55:03 +0000 (08:55 +0000)]
Fix a warning in InputHandler::learnText()
https://bugs.webkit.org/show_bug.cgi?id=80049

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.

Fix a warning of the comparison "textInField.length() <=
MaxLearnTextDataSize" in InputHandler::learnText().

Rubber-stamped internally by Mike Fenton.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::learnText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHandle CSSPropertyWebkitColorCorrection in CSSStyleApplyProperty.
macpherson@chromium.org [Fri, 2 Mar 2012 08:50:08 +0000 (08:50 +0000)]
Handle CSSPropertyWebkitColorCorrection in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80056

Reviewed by Eric Seidel.

No new tests / refactoring only.

* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Enabling 'Inspect Element' in Ewk_Context_Menu_Action.
commit-queue@webkit.org [Fri, 2 Mar 2012 08:33:36 +0000 (08:33 +0000)]
[EFL] Enabling 'Inspect Element' in Ewk_Context_Menu_Action.
https://bugs.webkit.org/show_bug.cgi?id=79646

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2012-03-02
Reviewed by Andreas Kling.

INSPECTOR feature is already enabled for WebKit-Efl port (OptionsEfl.cmake).
As a result WebCore's ContextMenuAction contains ContextMenuItemTagInspectElement
and enums order has been changed. WebKit-Efl has to synchronize ContextMenuAction
with Ewk_Context_Menu_Action.
To avoid similar case in the feature I added checks between WebCore and
WebKit-EFL's enums by using COMPILE_ASSERT_MATCHING_ENUM.

* WebCoreSupport/AssertMatchingEnums.cpp:
* ewk/ewk_contextmenu.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoreflection computed style test for CSS3 calc
mikelawther@chromium.org [Fri, 2 Mar 2012 08:15:42 +0000 (08:15 +0000)]
reflection computed style test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75902

Reviewed by Ojan Vafai.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

* css3/calc/reflection-computed-style-expected.txt: Added.
* css3/calc/reflection-computed-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix for platforms that have DFG_JIT disabled but PARALLEL_GC enabled.
fpizlo@apple.com [Fri, 2 Mar 2012 08:15:29 +0000 (08:15 +0000)]
Unreviewed build fix for platforms that have DFG_JIT disabled but PARALLEL_GC enabled.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Send didCommitAndDrawFrame after swap
commit-queue@webkit.org [Fri, 2 Mar 2012 08:11:42 +0000 (08:11 +0000)]
[chromium] Send didCommitAndDrawFrame after swap
https://bugs.webkit.org/show_bug.cgi?id=80052

Patch by John Bauman <jbauman@chromium.org> on 2012-03-02
Reviewed by James Robinson.

Sending didCommitAndDrawFrame before the swap was causing plugins to
redraw themselves between compositing and the swap, which reduces
opportunities for optimization.

* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::doComposite):
(WebCore):
(WebCore::CCSingleThreadProxy::didSwapFrame):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK gardening.
philn@webkit.org [Fri, 2 Mar 2012 08:06:44 +0000 (08:06 +0000)]
Unreviewed, GTK gardening.

* platform/gtk/Skipped: Skip 2 new failing tests and unskip a new
media test that should pass on GTK.
* platform/gtk/editing/inserting/5994480-2-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:
* platform/gtk/fast/multicol/span/clone-summary-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFGCodeBlocks should not trace CodeBlocks that are also going to be traced by
fpizlo@apple.com [Fri, 2 Mar 2012 08:04:19 +0000 (08:04 +0000)]
DFGCodeBlocks should not trace CodeBlocks that are also going to be traced by
virtue of being in the transitive closure
https://bugs.webkit.org/show_bug.cgi?id=80098

Reviewed by Anders Carlsson.

If DFGCodeBlocks traces a CodeBlock that might also be traced via its owner Executable,
then you might have the visitAggregate() method called concurrently by multiple threads.
This is benign on 64-bit -- visitAggregate() and everything it calls turns out to be
racy and slightly imprecise but not unsound. But on 32-bit, visitAggregate() may crash
due to word tearing in ValueProfile bucket updates inside of computeUpdatedPrediction().

It would seem that the fix is just to have DFGCodeBlocks not trace CodeBlocks that are
not jettisoned. But CodeBlocks may be jettisoned later during the GC, so it must trace
any CodeBlock that it knows to be live by virtue of it being reachable from the stack.
Hence the real fix is to make sure that concurrent calls into CodeBlock::visitAggregate()
don't lead to two threads racing over each other as they clobber state. This patch
achieves this with a simple CAS loop: whichever thread wins the CAS race (which is
trivially linearizable) will get to trace the CodeBlock; all other threads give up and
go home.

Unfortunately there will be no new tests. It's possible to reproduce this maybe 1/10
times by running V8-v6's raytrace repeatedly, using the V8 harness hacked to rerun it
even when it's gotten sufficient counts. But that takes a while - sometimes up to a
minute to get a crash. I have no other reliable repro case.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
* bytecode/CodeBlock.h:
(DFGData):
* heap/DFGCodeBlocks.cpp:
(JSC::DFGCodeBlocks::clearMarks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAudioParam needs tests for the parameter automation routines.
commit-queue@webkit.org [Fri, 2 Mar 2012 08:01:01 +0000 (08:01 +0000)]
AudioParam needs tests for the parameter automation routines.
https://bugs.webkit.org/show_bug.cgi?id=77666

Patch by Raymond Toy <rtoy@google.com> on 2012-03-02
Reviewed by Chris Rogers.

Source/WebCore:

Tests: webaudio/audioparam-linearRampToValueAtTime.html
       webaudio/audioparam-setTargetValueAtTime.html
       webaudio/audioparam-setValueAtTime.html
       webaudio/audioparam-setValueCurveAtTime.html

* webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl): Round the
curveIndex to fix timing issue in setValueCurveAtTime.

LayoutTests:

* webaudio/audioparam-exponentialRampToValueAtTime.html:
* webaudio/audioparam-linearRampToValueAtTime-expected.txt: Added.
* webaudio/audioparam-linearRampToValueAtTime.html: Added.
* webaudio/audioparam-setTargetValueAtTime-expected.txt: Added.
* webaudio/audioparam-setTargetValueAtTime.html: Added.
* webaudio/audioparam-setValueAtTime-expected.txt: Added.
* webaudio/audioparam-setValueAtTime.html: Added.
* webaudio/audioparam-setValueCurveAtTime-expected.txt: Added.
* webaudio/audioparam-setValueCurveAtTime.html: Added.
* webaudio/resources/audioparam-testing.js:
(renderLength):
(createConstantArray):
(createLinearRampArray):
(discreteTimeConstantForSampleRate):
(createExponentialApproachArray):
(createSineWaveArray):
(endValueDelta):
(valueUpdate):
(comparePartialSignals):
(verifyDiscontinuities):
(compareSignals):
(checkResultFunction.return.var):
(checkResultFunction):
(doAutomation):
(createAudioGraphAndTest):
* webaudio/resources/audio-testing.js: Moved isValidNumber from
biquad-testing.js to here.
* webaudio/resources/biquad-testing.js: Moved isValidNumber from
here to audio-testing.js.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Simplify the code to adjust font sizes depending on screen DPI
carlosgc@webkit.org [Fri, 2 Mar 2012 07:33:24 +0000 (07:33 +0000)]
[GTK] Simplify the code to adjust font sizes depending on screen DPI
https://bugs.webkit.org/show_bug.cgi?id=80032

Reviewed by Martin Robinson.

* webkit/webkitwebview.cpp:
(screenDPI): Helper function to get the DPI of a given
GdkScreen. Added also fallback code when gdk_screen_resolution
returns -1.
(webViewGetDPI): Use screenDPI() from WebCore.
(webViewConvertFontSizeToPixels): This is the existing
pixelsFromSize(), renamed and moved to be used also in
webkit_web_view_screen_changed().
(webkit_web_view_screen_changed): Use
webViewConvertFontSizeToPixels() instead of duplicating the code.
(webkit_web_view_settings_notify): Use
webViewConvertFontSizeToPixels() instead of pixelsFromSize().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMoar tightening of expectations (mac this time).
dpranke@chromium.org [Fri, 2 Mar 2012 06:50:49 +0000 (06:50 +0000)]
Moar tightening of expectations (mac this time).

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix code generators to correctly guard header declarations that have a [Conditional...
commit-queue@webkit.org [Fri, 2 Mar 2012 06:50:12 +0000 (06:50 +0000)]
Fix code generators to correctly guard header declarations that have a [Conditional] attribute.
https://bugs.webkit.org/show_bug.cgi?id=79375

Patch by Pablo Flouret <pablof@motorola.com> on 2012-03-01
Reviewed by Kentaro Hara.

In most cases code generators weren't checking the Conditional attribute
when generating code in headers for function/attribute/constants, they
were just guarding against the Conditional for the whole interface.

* bindings/scripts/CodeGeneratorCPP.pm:
(GenerateHeader):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateHeader):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/scripts/test/CPP/WebDOMTestInterface.h:
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/JS/JSTestInterface.h:
(JSTestInterface):
(WebCore):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/ObjC/DOMTestInterface.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Make opaque paint tracker aware of SkCanvas layers
commit-queue@webkit.org [Fri, 2 Mar 2012 06:47:13 +0000 (06:47 +0000)]
[chromium] Make opaque paint tracker aware of SkCanvas layers
https://bugs.webkit.org/show_bug.cgi?id=79145

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-01
Reviewed by Stephen White.

Source/WebCore:

The current opaque paint tracker ignored SkCanvas layers entirely. But
SkCanvas layers can be used to apply things like alpha. So we make it
know about layers, and apply any clipping and SkPaint objects for layers
when tracking a paint.

Image clipping is done via a layer, so we can now also remove the
special-case code around image clipping in PlatformContextSkia and
OpaqueRegionSkia.

Unit test: PlatformContextSkiaTest.contextTransparencyLayerTest

Test: compositing/culling/clear-fixed-iframe.html

* platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::OpaqueRegionSkia::didDrawRect):
(WebCore::OpaqueRegionSkia::didDrawPath):
(WebCore::OpaqueRegionSkia::didDrawPoints):
(WebCore::OpaqueRegionSkia::didDrawBounded):
(WebCore::OpaqueRegionSkia::didDraw):
(WebCore):
* platform/graphics/skia/OpaqueRegionSkia.h:
(OpaqueRegionSkia):
* platform/graphics/skia/PlatformContextSkia.cpp:
* platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):

Source/WebKit/chromium:

* tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
(WebCore):

LayoutTests:

* compositing/culling/clear-fixed-iframe-expected.png: Added.
* compositing/culling/clear-fixed-iframe-expected.txt: Added.
* compositing/culling/clear-fixed-iframe.html: Added.
* compositing/culling/resources/clear-fixed-iframe-content.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd HTML-capable popup API to ChromeClient
tkent@chromium.org [Fri, 2 Mar 2012 06:43:31 +0000 (06:43 +0000)]
Add HTML-capable popup API to ChromeClient
https://bugs.webkit.org/show_bug.cgi?id=79078

Reviewed by Dimitri Glazkov.

This API will be used to implement a calendar picker of <input type=date>.
The code is enclosed with ENABLE_PAGE_POPUP, and doesn't change any
behavior for now.

* page/ChromeClient.h: Added declarations of openPagePopup() and closePagePopup().
* loader/EmptyClients.h:
(EmptyChromeClient): Add empty implementations of new ChromeClient functions.
* page/PagePopup.h: Added.
(PagePopup): Define an empty interface
* page/PagePopupClient.h: Added.
(PagePopupClient): Define an interface to provide various information to HTMLPopup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRender overflow controls of an RTL element to its left-side.
morrita@google.com [Fri, 2 Mar 2012 06:33:00 +0000 (06:33 +0000)]
Render overflow controls of an RTL element to its left-side.
https://bugs.webkit.org/show_bug.cgi?id=54623

This change adds a new flag WTF_USE_RTL_SCROLLBAR and render the
vertical scrollbars and resizers of RTL elements to their left side if
this new flag is enabled.

Patch by Hironori Bono <hbono@chromium.org> on 2012-03-01
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: platform/chromium/fast/events/rtl-scrollbar.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromPositionedObjects): Move child elements right.
(WebCore::RenderBlock::determineLogicalLeftPositionForChild): ditto.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::overflowClipRect): Move the content rectangle right.
* rendering/RenderLayer.cpp:
(WebCore::cornerStart): Added a function that calculates the X position of a resizer.
(WebCore):
(WebCore::cornerRect): Use cornerStart to move a resizer.
(WebCore::RenderLayer::verticalScrollbarStart): Added a function that calculates
the X position of a vertical scrollbar.
(WebCore::RenderLayer::horizontalScrollbarStart): Added a function that calculates
the X position of a horizontal scrollbar.
(WebCore::RenderLayer::scrollbarOffset): Render a vertical scrollbar to the left side
and move a horizontal scrollbar right by the width of the vertical scrollbar.
(WebCore::RenderLayer::invalidateScrollbarRect): ditto.
(WebCore::RenderLayer::positionOverflowControls): ditto.
(WebCore::RenderLayer::hitTestOverflowControls): ditto.
* rendering/RenderLayer.h:
(RenderLayer):
* rendering/style/RenderStyle.h: Added shouldPlaceBlockDirectionScrollbarOnLogicalLeft,
which returns if we need to move a left scrollbar to its right side.

Source/WebKit/chromium:

* features.gypi: Set WTF_USE_RTL_SCROLLBAR to 1 on Chromium.

LayoutTests:

* platform/chromium/fast/events/rtl-scrollbar-expected.txt: Added.
* platform/chromium/fast/events/rtl-scrollbar.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe JIT should not crash the entire process just because there is not enough executable
ossy@webkit.org [Fri, 2 Mar 2012 06:28:45 +0000 (06:28 +0000)]
The JIT should not crash the entire process just because there is not enough executable
memory, if the LLInt is enabled
https://bugs.webkit.org/show_bug.cgi?id=79962

Patch by Filip Pizlo <fpizlo@apple.com> on 2012-03-01
Reviewed by Csaba Osztrogonác.

Fix for ARM, SH4.

* assembler/AssemblerBufferWithConstantPool.h:
(JSC::AssemblerBufferWithConstantPool::executableCopy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTighten various expectations to be more accurate.
dpranke@chromium.org [Fri, 2 Mar 2012 06:28:17 +0000 (06:28 +0000)]
Tighten various expectations to be more accurate.

Unreviewed, expectations change.

(This means fewer "unexpected pass" results).

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKitTestRunner: Explicitly include unistd.h for gcc 4.7
commit-queue@webkit.org [Fri, 2 Mar 2012 06:26:10 +0000 (06:26 +0000)]
WebKitTestRunner: Explicitly include unistd.h for gcc 4.7
https://bugs.webkit.org/show_bug.cgi?id=80033

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-03-01
Reviewed by Gustavo Noronha Silva.

GCC 4.7 no longer includes unistd.h from most of the standard C++
header files, so we need to explicitly include it for getcwd().

* WebKitTestRunner/TestInvocation.cpp: Make sure unistd.h gets included
not only on Mac, but on all Unix platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a link to the EFL wiki page
commit-queue@webkit.org [Fri, 2 Mar 2012 06:13:51 +0000 (06:13 +0000)]
Add a link to the EFL wiki page
https://bugs.webkit.org/show_bug.cgi?id=79439

Patch by Seo Sanghyeon <sh4.seo@samsung.com> on 2012-03-01
Reviewed by Adam Barth.

* building/tools.html:
* css/main.css: Cross-browser border-radius.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofast/forms/textfield-overflow.html is no longer failing.
dpranke@chromium.org [Fri, 2 Mar 2012 06:11:37 +0000 (06:11 +0000)]
fast/forms/textfield-overflow.html is no longer failing.

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Implement features for find-in-page
commit-queue@webkit.org [Fri, 2 Mar 2012 06:10:34 +0000 (06:10 +0000)]
[BlackBerry] Implement features for find-in-page
https://bugs.webkit.org/show_bug.cgi?id=79820

Patch by Andy Chen <andchen@rim.com> on 2012-03-01
Reviewed by Antonio Gomes.

- Make it be able to search text around the whole page instead of single frame.
- Make it be able to start new search from active selection and last active match.

No new tests as this patch doesn't change behavior.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::frameUnloaded):
* Api/WebPage_p.h:
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchWillClose):
(WebCore::FrameLoaderClientBlackBerry::detachedFromParent2):
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::incrementFrame):
* WebKitSupport/DOMSupport.h:
* WebKitSupport/InPageSearchManager.cpp:
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::shouldSearchForText):
(BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
(BlackBerry::WebKit::InPageSearchManager::setMarkerActive):
(BlackBerry::WebKit::InPageSearchManager::frameUnloaded):
* WebKitSupport/InPageSearchManager.h:
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::frameUnloaded):
* WebKitSupport/InputHandler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix paths to mac baselines for virtual/gpu/canvas/philip tests.
dpranke@chromium.org [Fri, 2 Mar 2012 05:56:38 +0000 (05:56 +0000)]
Fix paths to mac baselines for virtual/gpu/canvas/philip tests.

Unreveiwed, baselines update.

* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.cylinder-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.gradient.radial.cone.cylinder-expected.txt.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.line.width.basic-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.line.width.basic-expected.txt.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.line.width.transformed-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.line.width.transformed-expected.txt.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.path.arcTo.shape.curve1-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.path.arcTo.shape.curve1-expected.txt.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.path.arcTo.shape.curve2-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.path.arcTo.shape.curve2-expected.txt.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.shadow.enable.blur-expected.txt.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.fontface.notinpage-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.text.draw.fontface.notinpage-expected.txt.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.transformation.setTransform.skewed-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.transformation.setTransform.skewed-expected.txt.
* platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/tests/2d.transformation.transform.skewed-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/canvas/philip/2d.transformation.transform.skewed-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, gardening.
haraken@chromium.org [Fri, 2 Mar 2012 05:45:37 +0000 (05:45 +0000)]
Unreviewed, gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(90089): Input type='search' text shakes up and down when the style is...
tkent@chromium.org [Fri, 2 Mar 2012 05:43:01 +0000 (05:43 +0000)]
REGRESSION(90089): Input type='search' text shakes up and down when the style is changed.
https://bugs.webkit.org/show_bug.cgi?id=79445

Reviewed by Dimitri Glazkov.

Source/WebCore:

If the inner text height of a search field is smaller than the
content box height of the <input>, the height of the container
element should be same as the content box height.

When the element style is changed, the RenderStyle height of the
container element is cleared, but the renderer height of the
container element remains. We had a bug that layout() didn't set
the RenderStyle height in a case that the renderer height was the
desired height. It shrunk the renderer height as the result of
layout for children.

Tests: fast/forms/search/search-shaking-text.html

* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
Always set the RenderStyle height explicitly.

LayoutTests:

* fast/forms/search/search-shaking-text-expected.html: Added.
* fast/forms/search/search-shaking-text.html: Added.
* platform/chromium/test_expectations.txt:
 This change might need a rebaseline of fast/repaint/search-field-cancel.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rebaselined run-bindings-tests results.
haraken@chromium.org [Fri, 2 Mar 2012 05:40:00 +0000 (05:40 +0000)]
Unreviewed, rebaselined run-bindings-tests results.

* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
* bindings/scripts/test/CPP/WebDOMTestObj.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, gardening.
haraken@chromium.org [Fri, 2 Mar 2012 05:37:41 +0000 (05:37 +0000)]
Unreviewed, gardening.

* platform/chromium/fast/js/mozilla/strict/13.1-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, gardening.
haraken@chromium.org [Fri, 2 Mar 2012 05:35:18 +0000 (05:35 +0000)]
Unreviewed, gardening.

* platform/chromium/fast/js/mozilla/strict/12.14.1-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, gardening.
haraken@chromium.org [Fri, 2 Mar 2012 05:26:40 +0000 (05:26 +0000)]
Unreviewed, gardening.

* platform/chromium-linux/fast/frames/transparent-scrollbar-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/frames/transparent-scrollbar-expected.png: Added.
* platform/chromium-win/fast/frames/transparent-scrollbar-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoActually look at the args in driver_input :(.
dpranke@chromium.org [Fri, 2 Mar 2012 05:25:30 +0000 (05:25 +0000)]
Actually look at the args in driver_input :(.

Unreviewed, build fix.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.run_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/10942540> REGRESSION (r108956): Safari Webpage Preview Fetcher crashe...
mitz@apple.com [Fri, 2 Mar 2012 04:54:18 +0000 (04:54 +0000)]
<rdar://problem/10942540> REGRESSION (r108956): Safari Webpage Preview Fetcher crashes in WebCore::localizedString() when using a WebKit nightly build
https://bugs.webkit.org/show_bug.cgi?id=80034

Reviewed by Benjamin Poulain.

Safari Webpage Preview Fetcher can’t access the WebCore framework when launched from a WebKit
nightly build. After r108956, this causes it to crash.

* platform/mac/LocalizedStringsMac.cpp:
(WebCore::localizedString): Added a null-check for the value returned from
CFBundleGetBundleWithIdentifier(CFSTR("com.apple.WebCore")).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix typo in flag used to run gpu virtual suites.
dpranke@chromium.org [Fri, 2 Mar 2012 04:49:30 +0000 (04:49 +0000)]
Fix typo in flag used to run gpu virtual suites.

Unreviewed, build fix.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.virtual_test_suites):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r109317.
abarth@webkit.org [Fri, 2 Mar 2012 04:31:38 +0000 (04:31 +0000)]
Unreviewed, rolling out r109317.
http://trac.webkit.org/changeset/109317

Let's try watchlists again now that we're using a pure git
working copy

* Scripts/webkitpy/tool/bot/stylequeuetask.py:
(StyleQueueTask.run):
* Scripts/webkitpy/tool/commands/queues_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry]Array of Cookies in HTTP request header are not in order.
commit-queue@webkit.org [Fri, 2 Mar 2012 04:26:40 +0000 (04:26 +0000)]
[BlackBerry]Array of Cookies in HTTP request header are not in order.
https://bugs.webkit.org/show_bug.cgi?id=79870

Std::sort and HashMap are not stable. So cookies with the same creating
time sometimes are sent disorder.
Change std::sort with std::stable-sort.
We don't need using HashMap to save so few cookies for one domain.
It is a wast of time to create HashMap, too.
So change it with vector.

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-03-01
Reviewed by George Staikos.

Test: http/tests/cookies/resources/setArraycookies.php

* platform/blackberry/CookieManager.cpp:
(WebCore::cookieSorter):
(WebCore::CookieManager::getRawCookies):
(WebCore::CookieManager::checkAndTreatCookie):
(WebCore::CookieManager::addCookieToMap):
* platform/blackberry/CookieManager.h:
* platform/blackberry/CookieMap.cpp:
(WebCore::CookieMap::addOrReplaceCookie):
(WebCore::CookieMap::removeCookieAtIndex):
(WebCore::CookieMap::removeCookie):
(WebCore):
(WebCore::CookieMap::getAllCookies):
(WebCore::CookieMap::updateOldestCookie):
(WebCore::CookieMap::deleteAllCookiesAndDomains):
* platform/blackberry/CookieMap.h:
(WebCore::CookieMap::count):
(CookieMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove WebCore/storage/IDB* files into WebCore/Modules/indexeddb
abarth@webkit.org [Fri, 2 Mar 2012 04:23:25 +0000 (04:23 +0000)]
Move WebCore/storage/IDB* files into WebCore/Modules/indexeddb
https://bugs.webkit.org/show_bug.cgi?id=80071

Reviewed by Kentaro Hara.

Now that we've removed all the ENABLE(INDEXED_DATABASE) ifdefs from
WebCore proper, we can move IndexedDB into its own module.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Modules/indexeddb/IDBAny.cpp: Copied from Source/WebCore/storage/IDBAny.cpp.
* Modules/indexeddb/IDBAny.h: Copied from Source/WebCore/storage/IDBAny.h.
* Modules/indexeddb/IDBAny.idl: Copied from Source/WebCore/storage/IDBAny.idl.
* Modules/indexeddb/IDBBackingStore.h: Copied from Source/WebCore/storage/IDBBackingStore.h.
* Modules/indexeddb/IDBCallbacks.h: Copied from Source/WebCore/storage/IDBCallbacks.h.
* Modules/indexeddb/IDBCursor.cpp: Copied from Source/WebCore/storage/IDBCursor.cpp.
* Modules/indexeddb/IDBCursor.h: Copied from Source/WebCore/storage/IDBCursor.h.
* Modules/indexeddb/IDBCursor.idl: Copied from Source/WebCore/storage/IDBCursor.idl.
* Modules/indexeddb/IDBCursorBackendImpl.cpp: Copied from Source/WebCore/storage/IDBCursorBackendImpl.cpp.
* Modules/indexeddb/IDBCursorBackendImpl.h: Copied from Source/WebCore/storage/IDBCursorBackendImpl.h.
* Modules/indexeddb/IDBCursorBackendInterface.h: Copied from Source/WebCore/storage/IDBCursorBackendInterface.h.
* Modules/indexeddb/IDBCursorWithValue.cpp: Copied from Source/WebCore/storage/IDBCursorWithValue.cpp.
* Modules/indexeddb/IDBCursorWithValue.h: Copied from Source/WebCore/storage/IDBCursorWithValue.h.
* Modules/indexeddb/IDBCursorWithValue.idl: Copied from Source/WebCore/storage/IDBCursorWithValue.idl.
* Modules/indexeddb/IDBDatabase.cpp: Copied from Source/WebCore/storage/IDBDatabase.cpp.
* Modules/indexeddb/IDBDatabase.h: Copied from Source/WebCore/storage/IDBDatabase.h.
* Modules/indexeddb/IDBDatabase.idl: Copied from Source/WebCore/storage/IDBDatabase.idl.
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Copied from Source/WebCore/storage/IDBDatabaseBackendImpl.cpp.
* Modules/indexeddb/IDBDatabaseBackendImpl.h: Copied from Source/WebCore/storage/IDBDatabaseBackendImpl.h.
* Modules/indexeddb/IDBDatabaseBackendInterface.h: Copied from Source/WebCore/storage/IDBDatabaseBackendInterface.h.
* Modules/indexeddb/IDBDatabaseCallbacks.h: Copied from Source/WebCore/storage/IDBDatabaseCallbacks.h.
* Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp: Copied from Source/WebCore/storage/IDBDatabaseCallbacksImpl.cpp.
* Modules/indexeddb/IDBDatabaseCallbacksImpl.h: Copied from Source/WebCore/storage/IDBDatabaseCallbacksImpl.h.
* Modules/indexeddb/IDBDatabaseError.h: Copied from Source/WebCore/storage/IDBDatabaseError.h.
* Modules/indexeddb/IDBDatabaseError.idl: Copied from Source/WebCore/storage/IDBDatabaseError.idl.
* Modules/indexeddb/IDBDatabaseException.cpp: Copied from Source/WebCore/storage/IDBDatabaseException.cpp.
* Modules/indexeddb/IDBDatabaseException.h: Copied from Source/WebCore/storage/IDBDatabaseException.h.
* Modules/indexeddb/IDBDatabaseException.idl: Copied from Source/WebCore/storage/IDBDatabaseException.idl.
* Modules/indexeddb/IDBEventDispatcher.cpp: Copied from Source/WebCore/storage/IDBEventDispatcher.cpp.
* Modules/indexeddb/IDBEventDispatcher.h: Copied from Source/WebCore/storage/IDBEventDispatcher.h.
* Modules/indexeddb/IDBFactory.cpp: Copied from Source/WebCore/storage/IDBFactory.cpp.
* Modules/indexeddb/IDBFactory.h: Copied from Source/WebCore/storage/IDBFactory.h.
* Modules/indexeddb/IDBFactory.idl: Copied from Source/WebCore/storage/IDBFactory.idl.
* Modules/indexeddb/IDBFactoryBackendImpl.cpp: Copied from Source/WebCore/storage/IDBFactoryBackendImpl.cpp.
* Modules/indexeddb/IDBFactoryBackendImpl.h: Copied from Source/WebCore/storage/IDBFactoryBackendImpl.h.
* Modules/indexeddb/IDBFactoryBackendInterface.cpp: Copied from Source/WebCore/storage/IDBFactoryBackendInterface.cpp.
* Modules/indexeddb/IDBFactoryBackendInterface.h: Copied from Source/WebCore/storage/IDBFactoryBackendInterface.h.
* Modules/indexeddb/IDBIndex.cpp: Copied from Source/WebCore/storage/IDBIndex.cpp.
* Modules/indexeddb/IDBIndex.h: Copied from Source/WebCore/storage/IDBIndex.h.
* Modules/indexeddb/IDBIndex.idl: Copied from Source/WebCore/storage/IDBIndex.idl.
* Modules/indexeddb/IDBIndexBackendImpl.cpp: Copied from Source/WebCore/storage/IDBIndexBackendImpl.cpp.
* Modules/indexeddb/IDBIndexBackendImpl.h: Copied from Source/WebCore/storage/IDBIndexBackendImpl.h.
* Modules/indexeddb/IDBIndexBackendInterface.h: Copied from Source/WebCore/storage/IDBIndexBackendInterface.h.
* Modules/indexeddb/IDBKey.cpp: Copied from Source/WebCore/storage/IDBKey.cpp.
* Modules/indexeddb/IDBKey.h: Copied from Source/WebCore/storage/IDBKey.h.
* Modules/indexeddb/IDBKey.idl: Copied from Source/WebCore/storage/IDBKey.idl.
* Modules/indexeddb/IDBKeyPath.cpp: Copied from Source/WebCore/storage/IDBKeyPath.cpp.
* Modules/indexeddb/IDBKeyPath.h: Copied from Source/WebCore/storage/IDBKeyPath.h.
* Modules/indexeddb/IDBKeyPathBackendImpl.cpp: Copied from Source/WebCore/storage/IDBKeyPathBackendImpl.cpp.
* Modules/indexeddb/IDBKeyPathBackendImpl.h: Copied from Source/WebCore/storage/IDBKeyPathBackendImpl.h.
* Modules/indexeddb/IDBKeyRange.cpp: Copied from Source/WebCore/storage/IDBKeyRange.cpp.
* Modules/indexeddb/IDBKeyRange.h: Copied from Source/WebCore/storage/IDBKeyRange.h.
* Modules/indexeddb/IDBKeyRange.idl: Copied from Source/WebCore/storage/IDBKeyRange.idl.
* Modules/indexeddb/IDBLevelDBBackingStore.cpp: Copied from Source/WebCore/storage/IDBLevelDBBackingStore.cpp.
* Modules/indexeddb/IDBLevelDBBackingStore.h: Copied from Source/WebCore/storage/IDBLevelDBBackingStore.h.
* Modules/indexeddb/IDBLevelDBCoding.cpp: Copied from Source/WebCore/storage/IDBLevelDBCoding.cpp.
* Modules/indexeddb/IDBLevelDBCoding.h: Copied from Source/WebCore/storage/IDBLevelDBCoding.h.
* Modules/indexeddb/IDBObjectStore.cpp: Copied from Source/WebCore/storage/IDBObjectStore.cpp.
* Modules/indexeddb/IDBObjectStore.h: Copied from Source/WebCore/storage/IDBObjectStore.h.
* Modules/indexeddb/IDBObjectStore.idl: Copied from Source/WebCore/storage/IDBObjectStore.idl.
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp: Copied from Source/WebCore/storage/IDBObjectStoreBackendImpl.cpp.
* Modules/indexeddb/IDBObjectStoreBackendImpl.h: Copied from Source/WebCore/storage/IDBObjectStoreBackendImpl.h.
* Modules/indexeddb/IDBObjectStoreBackendInterface.h: Copied from Source/WebCore/storage/IDBObjectStoreBackendInterface.h.
* Modules/indexeddb/IDBPendingTransactionMonitor.cpp: Copied from Source/WebCore/storage/IDBPendingTransactionMonitor.cpp.
* Modules/indexeddb/IDBPendingTransactionMonitor.h: Copied from Source/WebCore/storage/IDBPendingTransactionMonitor.h.
* Modules/indexeddb/IDBRequest.cpp: Copied from Source/WebCore/storage/IDBRequest.cpp.
* Modules/indexeddb/IDBRequest.h: Copied from Source/WebCore/storage/IDBRequest.h.
* Modules/indexeddb/IDBRequest.idl: Copied from Source/WebCore/storage/IDBRequest.idl.
* Modules/indexeddb/IDBTracing.h: Copied from Source/WebCore/storage/IDBTracing.h.
* Modules/indexeddb/IDBTransaction.cpp: Copied from Source/WebCore/storage/IDBTransaction.cpp.
* Modules/indexeddb/IDBTransaction.h: Copied from Source/WebCore/storage/IDBTransaction.h.
* Modules/indexeddb/IDBTransaction.idl: Copied from Source/WebCore/storage/IDBTransaction.idl.
* Modules/indexeddb/IDBTransactionBackendImpl.cpp: Copied from Source/WebCore/storage/IDBTransactionBackendImpl.cpp.
* Modules/indexeddb/IDBTransactionBackendImpl.h: Copied from Source/WebCore/storage/IDBTransactionBackendImpl.h.
* Modules/indexeddb/IDBTransactionBackendInterface.h: Copied from Source/WebCore/storage/IDBTransactionBackendInterface.h.
* Modules/indexeddb/IDBTransactionCallbacks.h: Copied from Source/WebCore/storage/IDBTransactionCallbacks.h.
* Modules/indexeddb/IDBTransactionCoordinator.cpp: Copied from Source/WebCore/storage/IDBTransactionCoordinator.cpp.
* Modules/indexeddb/IDBTransactionCoordinator.h: Copied from Source/WebCore/storage/IDBTransactionCoordinator.h.
* Modules/indexeddb/IDBVersionChangeEvent.cpp: Copied from Source/WebCore/storage/IDBVersionChangeEvent.cpp.
* Modules/indexeddb/IDBVersionChangeEvent.h: Copied from Source/WebCore/storage/IDBVersionChangeEvent.h.
* Modules/indexeddb/IDBVersionChangeEvent.idl: Copied from Source/WebCore/storage/IDBVersionChangeEvent.idl.
* Modules/indexeddb/IDBVersionChangeRequest.cpp: Copied from Source/WebCore/storage/IDBVersionChangeRequest.cpp.
* Modules/indexeddb/IDBVersionChangeRequest.h: Copied from Source/WebCore/storage/IDBVersionChangeRequest.h.
* Modules/indexeddb/IDBVersionChangeRequest.idl: Copied from Source/WebCore/storage/IDBVersionChangeRequest.idl.
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* storage/IDBAny.cpp: Removed.
* storage/IDBAny.h: Removed.
* storage/IDBAny.idl: Removed.
* storage/IDBBackingStore.h: Removed.
* storage/IDBCallbacks.h: Removed.
* storage/IDBCursor.cpp: Removed.
* storage/IDBCursor.h: Removed.
* storage/IDBCursor.idl: Removed.
* storage/IDBCursorBackendImpl.cpp: Removed.
* storage/IDBCursorBackendImpl.h: Removed.
* storage/IDBCursorBackendInterface.h: Removed.
* storage/IDBCursorWithValue.cpp: Removed.
* storage/IDBCursorWithValue.h: Removed.
* storage/IDBCursorWithValue.idl: Removed.
* storage/IDBDatabase.cpp: Removed.
* storage/IDBDatabase.h: Removed.
* storage/IDBDatabase.idl: Removed.
* storage/IDBDatabaseBackendImpl.cpp: Removed.
* storage/IDBDatabaseBackendImpl.h: Removed.
* storage/IDBDatabaseBackendInterface.h: Removed.
* storage/IDBDatabaseCallbacks.h: Removed.
* storage/IDBDatabaseCallbacksImpl.cpp: Removed.
* storage/IDBDatabaseCallbacksImpl.h: Removed.
* storage/IDBDatabaseError.h: Removed.
* storage/IDBDatabaseError.idl: Removed.
* storage/IDBDatabaseException.cpp: Removed.
* storage/IDBDatabaseException.h: Removed.
* storage/IDBDatabaseException.idl: Removed.
* storage/IDBEventDispatcher.cpp: Removed.
* storage/IDBEventDispatcher.h: Removed.
* storage/IDBFactory.cpp: Removed.
* storage/IDBFactory.h: Removed.
* storage/IDBFactory.idl: Removed.
* storage/IDBFactoryBackendImpl.cpp: Removed.
* storage/IDBFactoryBackendImpl.h: Removed.
* storage/IDBFactoryBackendInterface.cpp: Removed.
* storage/IDBFactoryBackendInterface.h: Removed.
* storage/IDBIndex.cpp: Removed.
* storage/IDBIndex.h: Removed.
* storage/IDBIndex.idl: Removed.
* storage/IDBIndexBackendImpl.cpp: Removed.
* storage/IDBIndexBackendImpl.h: Removed.
* storage/IDBIndexBackendInterface.h: Removed.
* storage/IDBKey.cpp: Removed.
* storage/IDBKey.h: Removed.
* storage/IDBKey.idl: Removed.
* storage/IDBKeyPath.cpp: Removed.
* storage/IDBKeyPath.h: Removed.
* storage/IDBKeyPathBackendImpl.cpp: Removed.
* storage/IDBKeyPathBackendImpl.h: Removed.
* storage/IDBKeyRange.cpp: Removed.
* storage/IDBKeyRange.h: Removed.
* storage/IDBKeyRange.idl: Removed.
* storage/IDBLevelDBBackingStore.cpp: Removed.
* storage/IDBLevelDBBackingStore.h: Removed.
* storage/IDBLevelDBCoding.cpp: Removed.
* storage/IDBLevelDBCoding.h: Removed.
* storage/IDBObjectStore.cpp: Removed.
* storage/IDBObjectStore.h: Removed.
* storage/IDBObjectStore.idl: Removed.
* storage/IDBObjectStoreBackendImpl.cpp: Removed.
* storage/IDBObjectStoreBackendImpl.h: Removed.
* storage/IDBObjectStoreBackendInterface.h: Removed.
* storage/IDBPendingTransactionMonitor.cpp: Removed.
* storage/IDBPendingTransactionMonitor.h: Removed.
* storage/IDBRequest.cpp: Removed.
* storage/IDBRequest.h: Removed.
* storage/IDBRequest.idl: Removed.
* storage/IDBTracing.h: Removed.
* storage/IDBTransaction.cpp: Removed.
* storage/IDBTransaction.h: Removed.
* storage/IDBTransaction.idl: Removed.
* storage/IDBTransactionBackendImpl.cpp: Removed.
* storage/IDBTransactionBackendImpl.h: Removed.
* storage/IDBTransactionBackendInterface.h: Removed.
* storage/IDBTransactionCallbacks.h: Removed.
* storage/IDBTransactionCoordinator.cpp: Removed.
* storage/IDBTransactionCoordinator.h: Removed.
* storage/IDBVersionChangeEvent.cpp: Removed.
* storage/IDBVersionChangeEvent.h: Removed.
* storage/IDBVersionChangeEvent.idl: Removed.
* storage/IDBVersionChangeRequest.cpp: Removed.
* storage/IDBVersionChangeRequest.h: Removed.
* storage/IDBVersionChangeRequest.idl: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove tests that now pass.
dpranke@chromium.org [Fri, 2 Mar 2012 03:45:32 +0000 (03:45 +0000)]
Remove tests that now pass.

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: test_run_test_pause_before_testing is failing after r109482
dpranke@chromium.org [Fri, 2 Mar 2012 03:37:18 +0000 (03:37 +0000)]
webkitpy: test_run_test_pause_before_testing is failing after r109482
https://bugs.webkit.org/show_bug.cgi?id=80084

Unreviewed, build fix.

Fixes the test string compare to ignore the time spent running
the tests.

* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_test_pause_before_testing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: virtual tests aren't being run
dpranke@chromium.org [Fri, 2 Mar 2012 03:28:12 +0000 (03:28 +0000)]
nrwt: virtual tests aren't being run
https://bugs.webkit.org/show_bug.cgi?id=80083

Reviewed by Eric Seidel.

If we tried to run all of the tests by default (and
didn't specify any paths), the virtual tests weren't
picked up.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port._virtual_tests):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_tests):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.virtual_test_suites):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix test checking for incorrect results.
barraclough@apple.com [Fri, 2 Mar 2012 03:28:08 +0000 (03:28 +0000)]
Fix test checking for incorrect results.

Rubber stamped by Sam Weinig.

* fast/js/mozilla/strict/function-name-arity-expected.txt:
* fast/js/mozilla/strict/script-tests/function-name-arity.js:
    - This tests a non-existent, non-spec-defined property.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHandle CSSPropertyWebkitBorderFit in CSSStyleApplyProperty.
macpherson@chromium.org [Fri, 2 Mar 2012 03:18:41 +0000 (03:18 +0000)]
Handle CSSPropertyWebkitBorderFit in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=79998

Reviewed by Andreas Kling.

No new tests / refactoring only.

* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix test checking for incorrect results.
barraclough@apple.com [Fri, 2 Mar 2012 03:17:41 +0000 (03:17 +0000)]
Fix test checking for incorrect results.

Rubber stamped by Sam Weinig.

* fast/js/mozilla/strict/12.14.1-expected.txt:
* fast/js/mozilla/strict/script-tests/12.14.1.js:
    - This test uses destructuring, this didn't make it into ES5.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash when doing repeated double-tap-to-zoom gesture on apple startpage
andersca@apple.com [Fri, 2 Mar 2012 03:11:56 +0000 (03:11 +0000)]
Crash when doing repeated double-tap-to-zoom gesture on apple startpage
https://bugs.webkit.org/show_bug.cgi?id=80081
<rdar://problem/10966391>

Reviewed by Sam Weinig.

Setting the contents scale on the tile cache layer was creating a WebTileCacheLayer presentation layer copy with a null _tileCache.

Implement -[WebTileCacheLayer actionForKey:] and have it always return nil so we'll avoid implicit animations, and thus creating presentation layers.

* platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer initWithLayer:]):
Implement this and assert that it's never reached. We should never create presentation layers since we don't animate this layer.

(-[WebTileCacheLayer actionForKey:]):
Implement this and always return nil.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix test checking for incorrect results.
barraclough@apple.com [Fri, 2 Mar 2012 03:10:44 +0000 (03:10 +0000)]
Fix test checking for incorrect results.

Rubber stamped by Sam Weinig.

* fast/js/mozilla/strict/13.1-expected.txt:
* fast/js/mozilla/strict/script-tests/13.1.js:
    - This test uses destructuring, this didn't make it into ES5.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix typo in test, causing test to fail.
barraclough@apple.com [Fri, 2 Mar 2012 03:08:23 +0000 (03:08 +0000)]
Fix typo in test, causing test to fail.

Rubber stamped by Sam Weinig.

* fast/js/number-parsing-crash-expected.txt:
* fast/js/script-tests/number-parsing-crash.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCustom scrollbars do not support transparency
morrita@google.com [Fri, 2 Mar 2012 02:39:38 +0000 (02:39 +0000)]
Custom scrollbars do not support transparency
https://bugs.webkit.org/show_bug.cgi?id=50547

Source/WebCore:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-03-01
Reviewed by James Robinson.

RenderScrollbar, which is used even for outermost frame when
-webkit-scrollbar is specified, assumes that its background is
painted by the enclosing container. But there is no such container
for outermost frame. This causes visual glitches when the
scrollbar has transparency.

This change clears background region for custom
outermostscrollbars to erase such glitches.

Test: fast/frames/transparent-scrollbar.html

* page/FrameView.cpp:
(WebCore::FrameView::paintScrollbar): The background is cleared here.
(WebCore):
* page/FrameView.h:
(FrameView):
* platform/ScrollView.cpp:
(WebCore::ScrollView::paintScrollbar): Added to hook in FrameView
(WebCore):
(WebCore::ScrollView::paintScrollbars):
* platform/ScrollView.h:
(ScrollView):

LayoutTests:

Reviewed by James Robinson.

* fast/frames/transparent-scrollbar.html: Added.
* fast/frames/transparent-scrollbar-expected.txt: Added.
* platform/chromium-linux/fast/frames/transparent-scrollbar-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agorun-perf-tests should report the test runtime
rniwa@webkit.org [Fri, 2 Mar 2012 02:35:14 +0000 (02:35 +0000)]
run-perf-tests should report the test runtime
https://bugs.webkit.org/show_bug.cgi?id=80078

Reviewed by Hajime Morita.

Record and output the aggreated test run time.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._run_single_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRevert my change. Broke builds.
rniwa@webkit.org [Fri, 2 Mar 2012 02:32:38 +0000 (02:32 +0000)]
Revert my change. Broke builds.
Source/JavaScriptCore/wtf/Atomics.h:188: error: redefinition of 'bool WTF::weakCompareAndSwap(volatile uintptr_t*, uintptr_t, uintptr_t)'
Source/JavaScriptCore/wtf/Atomics.h:122: error: 'bool WTF::weakCompareAndSwap(volatile unsigned int*, unsigned int, unsigned i

* wtf/Atomics.h:
(WTF):
(WTF::weakCompareAndSwap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r106388): Form state is restored to a wrong document.
tkent@chromium.org [Fri, 2 Mar 2012 02:29:59 +0000 (02:29 +0000)]
REGRESSION(r106388): Form state is restored to a wrong document.
https://bugs.webkit.org/show_bug.cgi?id=79206

Reviewed by Brady Eidson.

Source/WebCore:

In some cases, the URL of the current HistoryItem and the document
URL are mismatched.
A form state should be restored only if the document was loaded
with a HistoryItem and the document is not loaded as a
redirection.

Test: fast/loader/form-state-restore-with-locked-back-forward-list.html

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted): Clear m_requestedHistoryItem.
(WebCore::FrameLoader::loadItem):
Save the requested HistoryItem for didLoadWithLodItem().
* loader/FrameLoader.h:
(WebCore::FrameLoader::requestedHistoryItem):
Added. Accessor for m_requestedHistoryItem.
* loader/HistoryController.cpp:
(WebCore::HistoryController::restoreDocumentState):
Restore a form state only if the current document was loaded with
FrameLoader::loadItem() and not redirection.

LayoutTests:

* fast/loader/form-state-restore-with-locked-back-forward-list-expected.txt: Added.
* fast/loader/form-state-restore-with-locked-back-forward-list.html: Added.
* fast/loader/resources/form-state-restore-with-locked-back-forward-list-2.html: Added.
* fast/loader/resources/form-state-restore-with-locked-back-forward-list-3.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGcc build fix.
rniwa@webkit.org [Fri, 2 Mar 2012 02:13:30 +0000 (02:13 +0000)]
Gcc build fix.

Rubber-stamped by Filip Pizlo.

* wtf/Atomics.h:
(WTF):
(WTF::weakCompareAndSwap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSSE optimization for vsvesq and vmaxmgv
commit-queue@webkit.org [Fri, 2 Mar 2012 02:00:07 +0000 (02:00 +0000)]
SSE optimization for vsvesq and vmaxmgv
https://bugs.webkit.org/show_bug.cgi?id=77950

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-03-01
Reviewed by Chris Rogers.

Achieved the performance of 3.7x on vsvesq and 4.1x on vmaxmgv.

* platform/audio/VectorMath.cpp:
(WebCore::VectorMath::vsvesq):
(WebCore::VectorMath::vmaxmgv):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Web Notification crashes the browser.
abarth@webkit.org [Fri, 2 Mar 2012 01:57:07 +0000 (01:57 +0000)]
[BlackBerry] Web Notification crashes the browser.
https://bugs.webkit.org/show_bug.cgi?id=79897

Patch by Charles Wei <charles.wei@torchmobile.com.cn> on 2012-03-01
Reviewed by Antonio Gomes.

The reason of the crash is that it still uses the iterator
after been removed from the container, which invalidates the
iterator.
We should stop processing after we have found the element
and removed from the container through the iterator.

This patch only fixes the crash issue, but not any notification
functionality issue, which is tracked seperatly.

Test case: http://sandbox.gtaero.net/chrome/notifications.php

* WebCoreSupport/NotificationPresenterImpl.cpp:
(WebKit::NotificationPresenterImpl::onPermission):
(WebKit::NotificationPresenterImpl::notificationClicked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHandle CSSPropertyBoxSizing in CSSStyleApplyProperty.
macpherson@chromium.org [Fri, 2 Mar 2012 01:44:51 +0000 (01:44 +0000)]
Handle CSSPropertyBoxSizing in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80001

Reviewed by Andreas Kling.

No new tests / refactoring only.

* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] LayerChromium::contentChanged is redundant with setNeedsDisplay
jamesr@google.com [Fri, 2 Mar 2012 01:14:16 +0000 (01:14 +0000)]
[chromium] LayerChromium::contentChanged is redundant with setNeedsDisplay
https://bugs.webkit.org/show_bug.cgi?id=79708

Reviewed by Adrienne Walker.

Some layer types need special handling when they receive damage. WebGL layers need to know if their texture is
updated for clear-on-swap behavior and both WebGL and canvas 2d layers have rate limiting mechanisms tied to
receiving invalidations. This mechanism was implemented by LayerChromium::contentChanged(), but this is
redundant with setNeedsDisplay().

Covered by existing tests.

* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::setNeedsDisplay):
* platform/graphics/chromium/Canvas2DLayerChromium.h:
(Canvas2DLayerChromium):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setNeedsDisplay):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::setNeedsDisplay):
* platform/graphics/chromium/VideoLayerChromium.h:
(VideoLayerChromium):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::setNeedsDisplay):
* platform/graphics/chromium/WebGLLayerChromium.h:
(WebGLLayerChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Mark a JS strict mode test as failing in V8,
adamk@chromium.org [Fri, 2 Mar 2012 01:06:55 +0000 (01:06 +0000)]
Unreviewed gardening. Mark a JS strict mode test as failing in V8,
and link it to a semi-related V8 bug.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Rename LayerChromium::name to debugName to be more consistent with other...
jamesr@google.com [Fri, 2 Mar 2012 00:47:56 +0000 (00:47 +0000)]
[chromium] Rename LayerChromium::name to debugName to be more consistent with other debug properties, make threadsafe
https://bugs.webkit.org/show_bug.cgi?id=79723

Reviewed by Adrienne Walker.

Source/WebCore:

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::updateNames):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
(WebCore::LayerChromium::setDebugName):
(WebCore):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::dumpLayer):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
(WebCore::CCLayerImpl::setDebugName):
(WebCore::CCLayerImpl::debugName):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::name):

Source/WebKit/chromium:

* tests/LayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Mark two media tests as flaky.
adamk@chromium.org [Fri, 2 Mar 2012 00:33:46 +0000 (00:33 +0000)]
Unreviewed gardening. Mark two media tests as flaky.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove last ENABLED(INDEXED_DATABASE) ifdef from WebCore proper
abarth@webkit.org [Fri, 2 Mar 2012 00:25:40 +0000 (00:25 +0000)]
Remove last ENABLED(INDEXED_DATABASE) ifdef from WebCore proper
https://bugs.webkit.org/show_bug.cgi?id=80061

Reviewed by Dimitri Glazkov.

This patch removes the last ENABLED(INDEXED_DATABASE) ifdef from
WebCore proper by moving the backend factory out of PageGroup and into
a supplement for PageGroup.  After this patch, we're ready to move the
IDB code into Modules.

* Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::webkitIndexedDB):
* WebCore.gypi:
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore::assertIDBFactory):
* page/PageGroup.cpp:
(WebCore):
* page/PageGroup.h:
(PageGroup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Use webkit_support to create session storage namespaces in DRT.
michaeln@google.com [Fri, 2 Mar 2012 00:25:13 +0000 (00:25 +0000)]
[chromium] Use webkit_support to create session storage namespaces in DRT.
https://bugs.webkit.org/show_bug.cgi?id=79933

Reviewed by Tony Chang.

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createSessionStorageNamespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoES5.1-15.3.5.4. prohibits Function.caller from [[Get]]ting a strict caller
barraclough@apple.com [Fri, 2 Mar 2012 00:12:58 +0000 (00:12 +0000)]
ES5.1-15.3.5.4. prohibits Function.caller from [[Get]]ting a strict caller
https://bugs.webkit.org/show_bug.cgi?id=80011

Reviewed by Oliver Hunt.

Also, fix getting the caller from within a bound function, for within a getter,
or setter (make our implementation match other browsers).

Source/JavaScriptCore:

* interpreter/Interpreter.cpp:
(JSC::getCallerInfo):
    - Allow this to get the caller of host functions.
(JSC::Interpreter::retrieveCallerFromVMCode):
    - This should use getCallerInfo, and should skip over function bindings.
* runtime/JSFunction.cpp:
(JSC::JSFunction::callerGetter):
    - This should never return a strict-mode function.

LayoutTests:

* fast/js/caller-property-expected.txt:
* fast/js/script-tests/caller-property.js:
    - Add test cases covering permutations of caller/callee being strict/non-strict,
      And for callee being a getter/setter/bound.
* fast/js/stack-trace-expected.txt:
    - Allow stack tracing over host functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove deprecated FFmpeg build directories.
dpranke@chromium.org [Fri, 2 Mar 2012 00:05:16 +0000 (00:05 +0000)]
Remove deprecated FFmpeg build directories.
https://bugs.webkit.org/show_bug.cgi?id=79282

We've switched the layout of the FFmpeg repo in Chrome and these paths
are no longer needed or valid.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-03-01
Reviewed by Dirk Pranke.

Source/WebCore:

No new tests. It either compiles or not.

* WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable IPP for Biquad filter
commit-queue@webkit.org [Thu, 1 Mar 2012 23:59:02 +0000 (23:59 +0000)]
Enable IPP for Biquad filter
https://bugs.webkit.org/show_bug.cgi?id=77509

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-03-01
Reviewed by Chris Rogers.

Source/WebCore:

Use IIR filter in IPP and improve ~27% performance in linux.
Changes are covered by current tests.

* platform/audio/Biquad.cpp:
(WebCore::Biquad::Biquad):
(WebCore::Biquad::~Biquad):
(WebCore):
(WebCore::Biquad::process):
(WebCore::Biquad::reset):
(WebCore::Biquad::setLowpassParams):
(WebCore::Biquad::setHighpassParams):
(WebCore::Biquad::setNormalizedCoefficients):
(WebCore::Biquad::setZeroPolePairs):
* platform/audio/Biquad.h:
(Biquad):

LayoutTests:

Adjust a code format issue.

* webaudio/resources/biquad-testing.js:
(filterData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline fast/flexbox/010.html on Leopard after removing its suppression.
adamk@chromium.org [Thu, 1 Mar 2012 23:45:29 +0000 (23:45 +0000)]
Rebaseline fast/flexbox/010.html on Leopard after removing its suppression.

Unreviewed gardening.

* platform/chromium-mac-leopard/fast/flexbox/010-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/flexbox/010-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/flexbox/010-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaselining some old Chromium tests and removing test_expectations.
adamk@chromium.org [Thu, 1 Mar 2012 23:43:32 +0000 (23:43 +0000)]
Rebaselining some old Chromium tests and removing test_expectations.

Unreviewed gardening.

* fast/writing-mode/block-level-images-expected.txt: Renamed from LayoutTests/platform/gtk/fast/writing-mode/block-level-images-expected.txt.
* platform/chromium-linux/fast/backgrounds/background-leakage-expected.png: Added.
* platform/chromium-linux/fast/backgrounds/background-leakage-transforms-expected.png: Added.
* platform/chromium-linux/fast/multicol/float-multicol-expected.png:
* platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png:
* platform/chromium-mac-leopard/fast/backgrounds/background-leakage-transforms-expected.png: Removed.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/multicol/float-multicol-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/float-multicol-expected.png.
* platform/chromium-mac-snowleopard/fast/writing-mode/block-level-images-expected.png: Added.
* platform/chromium-mac/fast/writing-mode/block-level-images-expected.png: Removed.
* platform/chromium-win/fast/backgrounds/background-leakage-expected.png: Added.
* platform/chromium-win/fast/backgrounds/background-leakage-expected.txt: Added.
* platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.png: Added.
* platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.txt: Added.
* platform/chromium-win/fast/multicol/float-multicol-expected.png:
* platform/chromium-win/fast/multicol/float-multicol-expected.txt:
* platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/mac/fast/writing-mode/block-level-images-expected.txt: Removed.
* platform/qt/fast/writing-mode/block-level-images-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDecouple scrollbar painting from Scrollbar object
jamesr@google.com [Thu, 1 Mar 2012 23:36:21 +0000 (23:36 +0000)]
Decouple scrollbar painting from Scrollbar object
https://bugs.webkit.org/show_bug.cgi?id=78028

Patch by Peter Kotwicz <pkotwicz@google.com> on 2012-03-01
Reviewed by James Robinson.

Added interface ScrollbarThemeClient which Scrollbar inherits from.
This allows painting via ScrollbarTheme with a proxy to a Scrollbar
object.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/Scrollbar.cpp:
(WebCore::Scrollbar::scrollbarOverlayStyle):
(WebCore):
(WebCore::Scrollbar::getTickmarks):
(WebCore::Scrollbar::isScrollableAreaActive):
(WebCore::Scrollbar::isScrollViewScrollbar):
(WebCore::Scrollbar::setFrameRect):
* platform/Scrollbar.h:
(Scrollbar):
(WebCore::Scrollbar::x):
(WebCore::Scrollbar::y):
(WebCore::Scrollbar::width):
(WebCore::Scrollbar::height):
(WebCore::Scrollbar::size):
(WebCore::Scrollbar::location):
(WebCore::Scrollbar::parent):
(WebCore::Scrollbar::root):
(WebCore::Scrollbar::frameRect):
(WebCore::Scrollbar::invalidate):
(WebCore::Scrollbar::convertFromContainingWindow):
(WebCore::Scrollbar::isCustomScrollbar):
(WebCore::Scrollbar::orientation):
(WebCore::Scrollbar::value):
(WebCore::Scrollbar::currentPos):
(WebCore::Scrollbar::visibleSize):
(WebCore::Scrollbar::totalSize):
(WebCore::Scrollbar::maximum):
(WebCore::Scrollbar::controlSize):
(WebCore::Scrollbar::lineStep):
(WebCore::Scrollbar::pageStep):
(WebCore::Scrollbar::pressedPart):
(WebCore::Scrollbar::hoveredPart):
(WebCore::Scrollbar::styleChanged):
(WebCore::Scrollbar::enabled):
* platform/ScrollbarTheme.h:
(WebCore):
(WebCore::ScrollbarTheme::updateEnabledState):
(WebCore::ScrollbarTheme::paint):
(WebCore::ScrollbarTheme::hitTest):
(WebCore::ScrollbarTheme::updateScrollbarOverlayStyle):
(WebCore::ScrollbarTheme::invalidateParts):
(WebCore::ScrollbarTheme::invalidatePart):
(WebCore::ScrollbarTheme::shouldCenterOnThumb):
(WebCore::ScrollbarTheme::shouldSnapBackToDragOrigin):
(WebCore::ScrollbarTheme::shouldDragDocumentInsteadOfThumb):
(WebCore::ScrollbarTheme::thumbPosition):
(WebCore::ScrollbarTheme::thumbLength):
(WebCore::ScrollbarTheme::trackPosition):
(WebCore::ScrollbarTheme::trackLength):
(WebCore::ScrollbarTheme::registerScrollbar):
(WebCore::ScrollbarTheme::unregisterScrollbar):
* platform/ScrollbarThemeClient.h: Added.
(WebCore):
(ScrollbarThemeClient):
(WebCore::ScrollbarThemeClient::~ScrollbarThemeClient):
* platform/ScrollbarThemeComposite.cpp:
(WebCore::ScrollbarThemeComposite::paint):
(WebCore::ScrollbarThemeComposite::hitTest):
(WebCore::ScrollbarThemeComposite::invalidatePart):
(WebCore::ScrollbarThemeComposite::splitTrack):
(WebCore::usedTotalSize):
(WebCore::ScrollbarThemeComposite::thumbPosition):
(WebCore::ScrollbarThemeComposite::thumbLength):
(WebCore::ScrollbarThemeComposite::minimumThumbLength):
(WebCore::ScrollbarThemeComposite::trackPosition):
(WebCore::ScrollbarThemeComposite::trackLength):
* platform/ScrollbarThemeComposite.h:
(ScrollbarThemeComposite):
(WebCore::ScrollbarThemeComposite::paintScrollbarBackground):
(WebCore::ScrollbarThemeComposite::paintTrackBackground):
(WebCore::ScrollbarThemeComposite::paintTrackPiece):
(WebCore::ScrollbarThemeComposite::paintButton):
(WebCore::ScrollbarThemeComposite::paintThumb):
(WebCore::ScrollbarThemeComposite::paintTickmarks):
(WebCore::ScrollbarThemeComposite::constrainTrackRectToTrackPieces):
* platform/chromium/ScrollbarThemeChromium.cpp:
(WebCore::ScrollbarThemeChromium::hasThumb):
(WebCore::ScrollbarThemeChromium::backButtonRect):
(WebCore::ScrollbarThemeChromium::forwardButtonRect):
(WebCore::ScrollbarThemeChromium::trackRect):
(WebCore::ScrollbarThemeChromium::paintTrackBackground):
(WebCore::ScrollbarThemeChromium::paintTickmarks):
* platform/chromium/ScrollbarThemeChromium.h:
(WebCore::ScrollbarThemeChromium::hasButtons):
(ScrollbarThemeChromium):
* platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
(WebCore::ScrollbarThemeChromiumAndroid::paintScrollbarBackground):
(WebCore::ScrollbarThemeChromiumAndroid::shouldCenterOnThumb):
(WebCore::ScrollbarThemeChromiumAndroid::buttonSize):
(WebCore::ScrollbarThemeChromiumAndroid::minimumThumbLength):
* platform/chromium/ScrollbarThemeChromiumAndroid.h:
(ScrollbarThemeChromiumAndroid):
* platform/chromium/ScrollbarThemeChromiumLinux.cpp:
(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumLinux::paintButton):
(WebCore::ScrollbarThemeChromiumLinux::paintThumb):
(WebCore::ScrollbarThemeChromiumLinux::shouldCenterOnThumb):
(WebCore::ScrollbarThemeChromiumLinux::buttonSize):
(WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
* platform/chromium/ScrollbarThemeChromiumLinux.h:
(ScrollbarThemeChromiumLinux):
* platform/chromium/ScrollbarThemeChromiumMac.h:
(ScrollbarThemeChromiumMac):
* platform/chromium/ScrollbarThemeChromiumMac.mm:
(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paint):
(WebCore::ScrollbarThemeChromiumMac::paintGivenTickmarks):
* platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::shouldSnapBackToDragOrigin):
(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumWin::paintButton):
(WebCore::ScrollbarThemeChromiumWin::paintThumb):
(WebCore::ScrollbarThemeChromiumWin::getThemeState):
(WebCore::ScrollbarThemeChromiumWin::getThemeArrowState):
(WebCore::ScrollbarThemeChromiumWin::getClassicThemeState):
(WebCore::ScrollbarThemeChromiumWin::shouldCenterOnThumb):
(WebCore::ScrollbarThemeChromiumWin::buttonSize):
* platform/chromium/ScrollbarThemeChromiumWin.h:
(ScrollbarThemeChromiumWin):
* platform/efl/ScrollbarThemeEfl.cpp:
(WebCore::ScrollbarThemeEfl::registerScrollbar):
(WebCore::ScrollbarThemeEfl::unregisterScrollbar):
* platform/efl/ScrollbarThemeEfl.h:
(ScrollbarThemeEfl):
* platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore):
(WebCore::ScrollbarThemeGtk::registerScrollbar):
(WebCore::ScrollbarThemeGtk::unregisterScrollbar):
(WebCore::ScrollbarThemeGtk::updateScrollbarsFrameThickness):
(WebCore::ScrollbarThemeGtk::hasThumb):
(WebCore::ScrollbarThemeGtk::backButtonRect):
(WebCore::ScrollbarThemeGtk::forwardButtonRect):
(WebCore::ScrollbarThemeGtk::trackRect):
(WebCore::ScrollbarThemeGtk::thumbRect):
(WebCore::ScrollbarThemeGtk::paint):
(WebCore::ScrollbarThemeGtk::shouldCenterOnThumb):
(WebCore::ScrollbarThemeGtk::buttonSize):
(WebCore::ScrollbarThemeGtk::minimumThumbLength):
* platform/gtk/ScrollbarThemeGtk.h:
(WebCore::ScrollbarThemeGtk::hasButtons):
(ScrollbarThemeGtk):
* platform/gtk/ScrollbarThemeGtk2.cpp:
(WebCore::getWidgetForScrollbar):
(WebCore::ScrollbarThemeGtk::paintTrackBackground):
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
(WebCore::ScrollbarThemeGtk::paintThumb):
(WebCore::ScrollbarThemeGtk::paintButton):
* platform/gtk/ScrollbarThemeGtk3.cpp:
(WebCore::ScrollbarThemeGtk::paintTrackBackground):
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
(WebCore::ScrollbarThemeGtk::paintThumb):
(WebCore::ScrollbarThemeGtk::paintButton):
* platform/mac/ScrollbarThemeMac.h:
(ScrollbarThemeMac):
* platform/mac/ScrollbarThemeMac.mm:
(WebCore):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::setNewPainterForScrollbar):
(WebCore::ScrollbarThemeMac::painterForScrollbar):
(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
(WebCore::ScrollbarThemeMac::hasButtons):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::backButtonRect):
(WebCore::ScrollbarThemeMac::forwardButtonRect):
(WebCore::ScrollbarThemeMac::trackRect):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::shouldCenterOnThumb):
(WebCore::ScrollbarThemeMac::shouldDragDocumentInsteadOfThumb):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::ScrollbarThemeMac::paint):
* platform/mock/ScrollbarThemeMock.cpp:
(WebCore::ScrollbarThemeMock::trackRect):
(WebCore::ScrollbarThemeMock::paintTrackBackground):
(WebCore::ScrollbarThemeMock::paintThumb):
* platform/mock/ScrollbarThemeMock.h:
(WebCore::ScrollbarThemeMock::hasButtons):
(WebCore::ScrollbarThemeMock::hasThumb):
(WebCore::ScrollbarThemeMock::backButtonRect):
(WebCore::ScrollbarThemeMock::forwardButtonRect):
(ScrollbarThemeMock):
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::styleOptionSlider):
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::hitTest):
(WebCore::ScrollbarThemeQt::shouldCenterOnThumb):
(WebCore::ScrollbarThemeQt::invalidatePart):
(WebCore::ScrollbarThemeQt::thumbPosition):
(WebCore::ScrollbarThemeQt::thumbLength):
(WebCore::ScrollbarThemeQt::trackPosition):
(WebCore::ScrollbarThemeQt::trackLength):
* platform/qt/ScrollbarThemeQt.h:
(ScrollbarThemeQt):
* platform/win/ScrollbarThemeSafari.cpp:
(WebCore::ScrollbarThemeSafari::hasButtons):
(WebCore::ScrollbarThemeSafari::hasThumb):
(WebCore::ScrollbarThemeSafari::backButtonRect):
(WebCore::ScrollbarThemeSafari::forwardButtonRect):
(WebCore::ScrollbarThemeSafari::trackRect):
(WebCore::ScrollbarThemeSafari::minimumThumbLength):
(WebCore::ScrollbarThemeSafari::shouldCenterOnThumb):
(WebCore::ScrollbarThemeSafari::paintTrackBackground):
(WebCore::ScrollbarThemeSafari::paintButton):
(WebCore::ScrollbarThemeSafari::paintThumb):
* platform/win/ScrollbarThemeSafari.h:
(ScrollbarThemeSafari):
* platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::hasThumb):
(WebCore::ScrollbarThemeWin::backButtonRect):
(WebCore::ScrollbarThemeWin::forwardButtonRect):
(WebCore::ScrollbarThemeWin::trackRect):
(WebCore::ScrollbarThemeWin::shouldCenterOnThumb):
(WebCore::ScrollbarThemeWin::shouldSnapBackToDragOrigin):
(WebCore::ScrollbarThemeWin::paintTrackBackground):
(WebCore::ScrollbarThemeWin::paintTrackPiece):
(WebCore::ScrollbarThemeWin::paintButton):
(WebCore::paintGripper):
(WebCore::ScrollbarThemeWin::paintThumb):
* platform/win/ScrollbarThemeWin.h:
(WebCore::ScrollbarThemeWin::hasButtons):
(ScrollbarThemeWin):
* platform/wx/ScrollbarThemeWx.cpp:
(WebCore::ScrollbarThemeWx::hasThumb):
(WebCore::ScrollbarThemeWx::minimumThumbLength):
(WebCore::ScrollbarThemeWx::buttonSize):
(WebCore::ScrollbarThemeWx::splitTrack):
(WebCore::ScrollbarThemeWx::backButtonRect):
(WebCore::ScrollbarThemeWx::forwardButtonRect):
(WebCore::ScrollbarThemeWx::trackRect):
(WebCore::ScrollbarThemeWx::paint):
* platform/wx/ScrollbarThemeWx.h:
(ScrollbarThemeWx):
(WebCore::ScrollbarThemeWx::hasButtons):
* rendering/RenderScrollbar.h:
(WebCore::toRenderScrollbar):
* rendering/RenderScrollbarTheme.cpp:
(WebCore::RenderScrollbarTheme::buttonSizesAlongTrackAxis):
(WebCore::RenderScrollbarTheme::hasButtons):
(WebCore::RenderScrollbarTheme::hasThumb):
(WebCore::RenderScrollbarTheme::minimumThumbLength):
(WebCore::RenderScrollbarTheme::backButtonRect):
(WebCore::RenderScrollbarTheme::forwardButtonRect):
(WebCore::RenderScrollbarTheme::trackRect):
(WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):
(WebCore::RenderScrollbarTheme::paintScrollbarBackground):
(WebCore::RenderScrollbarTheme::paintTrackBackground):
(WebCore::RenderScrollbarTheme::paintTrackPiece):
(WebCore::RenderScrollbarTheme::paintButton):
(WebCore::RenderScrollbarTheme::paintThumb):
* rendering/RenderScrollbarTheme.h:
(WebCore::RenderScrollbarTheme::shouldCenterOnThumb):
(WebCore::RenderScrollbarTheme::registerScrollbar):
(WebCore::RenderScrollbarTheme::unregisterScrollbar):
(RenderScrollbarTheme):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement CSSPropertyImageRendering in CSSStyleApplyProperty.
macpherson@chromium.org [Thu, 1 Mar 2012 23:33:09 +0000 (23:33 +0000)]
Implement CSSPropertyImageRendering in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=79855

Reviewed by Eric Seidel.

No new tests / refactoring only.

* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agochromium: start running virtual gpu tests
dpranke@chromium.org [Thu, 1 Mar 2012 23:28:35 +0000 (23:28 +0000)]
chromium: start running virtual gpu tests
https://bugs.webkit.org/show_bug.cgi?id=80050

Unreviewed, expectations change.

This patch un-SKIPs the platform/chromium/virtual/gpu tests
and copies their expectations from the GPU and generic
expectations for fast/canvas and canvas/philip. I
will re-sort the expectations in subsequent patches so
that the virtual expectations are next to the action ones,
for easier maintenance.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMark fast/workers/stress-js-execution.html as flakily crashy on cr-win.
adamk@chromium.org [Thu, 1 Mar 2012 23:23:54 +0000 (23:23 +0000)]
Mark fast/workers/stress-js-execution.html as flakily crashy on cr-win.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRoll chromium DEPS to 124511
dpranke@chromium.org [Thu, 1 Mar 2012 23:21:48 +0000 (23:21 +0000)]
Roll chromium DEPS to 124511

Unreviewed, DEPS change.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Partial texture updates not happening with accelerated painting path
alokp@chromium.org [Thu, 1 Mar 2012 23:17:12 +0000 (23:17 +0000)]
[chromium] Partial texture updates not happening with accelerated painting path
https://bugs.webkit.org/show_bug.cgi?id=80040

Reviewed by James Robinson.

The order of y-flip and clip-rect was opposite of what it should be.
The clip rect was not properly transformed to account for y-flip and hence clipping everything.

* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove outdated (mostly mac) test suppressions.
adamk@chromium.org [Thu, 1 Mar 2012 23:16:54 +0000 (23:16 +0000)]
Remove outdated (mostly mac) test suppressions.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago FileReader read speed is way too low
ap@apple.com [Thu, 1 Mar 2012 22:50:07 +0000 (22:50 +0000)]
    FileReader read speed is way too low
        https://bugs.webkit.org/show_bug.cgi?id=77272

        Reviewed by Oliver Hunt.

        This brings performance to reasonable range, but certainly doesn't exhaust improvement opportunities.

        * platform/network/BlobResourceHandle.cpp: Use a more appropriate block size. Performing
        cross-thread messaging for every 1024 bytes is slow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMark svg/W3C-SVG-1.1/animate-elem-32-t.svg as debug/crash after r109342.
adamk@chromium.org [Thu, 1 Mar 2012 22:48:38 +0000 (22:48 +0000)]
Mark svg/W3C-SVG-1.1/animate-elem-32-t.svg as debug/crash after r109342.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoScrollView::setFrameRect() calls contentsResized() even when the frame size is unchanged
mitz@apple.com [Thu, 1 Mar 2012 22:42:44 +0000 (22:42 +0000)]
ScrollView::setFrameRect() calls contentsResized() even when the frame size is unchanged
https://bugs.webkit.org/show_bug.cgi?id=80047

Reviewed by Anders Carlsson.

* platform/ScrollView.cpp:
(WebCore::ScrollView::setFrameRect): Added a check that the new frame size differs from the
old one before calling contentsResized().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAutocomplete attribute should apply to textarea's.
commit-queue@webkit.org [Thu, 1 Mar 2012 22:41:56 +0000 (22:41 +0000)]
Autocomplete attribute should apply to textarea's.
https://bugs.webkit.org/show_bug.cgi?id=79929

Patch by Mike Fenton <mifenton@rim.com> on 2012-03-01
Reviewed by Antonio Gomes.

Add local static Qualified name for autocorrect attribute.

* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::elementSupportsAutocorrect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: test_isfile, test_isdir, and test_exists don't work for virtual tests
dpranke@chromium.org [Thu, 1 Mar 2012 22:41:33 +0000 (22:41 +0000)]
nrwt: test_isfile, test_isdir, and test_exists don't work for virtual tests
https://bugs.webkit.org/show_bug.cgi?id=80048

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.test_isfile):
(Port.test_isdir):
(Port):
(Port.test_exists):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_test_exists):
(PortTest):
(PortTest.test_test_isfile):
(PortTest.test_test_isdir):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.virtual_test_suites):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_virtual):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Move pageScaleDirty logic from LayerChromium to GraphicsLayerChromium
commit-queue@webkit.org [Thu, 1 Mar 2012 22:24:52 +0000 (22:24 +0000)]
[chromium] Move pageScaleDirty logic from LayerChromium to GraphicsLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=79714

Patch by James Robinson <jamesr@chromium.org> on 2012-03-01
Reviewed by Adrienne Walker.

When the page scale changes on a composited layer we need to invalidate all of the contents on the layer in
order to repaint them at the new scale. The sequence of calls we get make this a bit tricky, since we first
receive a page scale changed notification and then receive the new layer bounds. The solution is to defer the
invalidation until we have the new layer bounds, which landed in r99774.

This moves that logic from LayerChromium into GraphicsLayerChromium since IMO this is pretty particular to the
way WebCore is passing us invalidations and not something fundamental to the compositor.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::deviceOrPageScaleFactorChanged):
* platform/graphics/chromium/GraphicsLayerChromium.h:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setBounds):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove lots of bogus flaky test suppressions, mark some others
adamk@chromium.org [Thu, 1 Mar 2012 22:07:28 +0000 (22:07 +0000)]
Remove lots of bogus flaky test suppressions, mark some others
as always failing and some others for rebaselining.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPerf-o-matic: generate dashboard images for 30, 90, and 365 days
rniwa@webkit.org [Thu, 1 Mar 2012 21:55:49 +0000 (21:55 +0000)]
Perf-o-matic: generate dashboard images for 30, 90, and 365 days
https://bugs.webkit.org/show_bug.cgi?id=80016

Reviewed by Eric Seidel.

Add the ability to generate graphs for 30, 90, and 365 day graphs but only occasionally
according to the heuristics in DashboardImage.needs_update.

Also fix a bug in Runs.chart_params that y-axis grid was set to an incorrect value.

* Websites/webkit-perf.appspot.com/controller.py:
(schedule_runs_update):
(RunsChartHandler.post):
* Websites/webkit-perf.appspot.com/json_generators.py:
(Runs.chart_params):
* Websites/webkit-perf.appspot.com/json_generators_unittest.py:
(RunsTest.test_chart_params_with_value):
* Websites/webkit-perf.appspot.com/models.py:
(DashboardImage):
(DashboardImage.needs_update):
* Websites/webkit-perf.appspot.com/models_unittest.py:
(HelperTests._assert_there_is_exactly_one_id_holder_and_matches):
(HelperTests.test_create_in_transaction_with_numeric_id_holder.execute):
(HelperTests.test_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_failing_in_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_raising_in_create_in_transaction_with_numeric_id_holder):
(HelperTests.test_delete_model_with_numeric_id_holder.execute):
(HelperTests.test_delete_model_with_numeric_id_holder):
(HelperTests.test_model_from_numeric_id.execute):
(HelperTests):
(HelperTests.test_model_from_numeric_id):
(BranchTests.test_create_if_possible):
(PlatformTests.test_create_if_possible):
(BuilderTests.test_create):
(BuilderTests.test_update_password):
(BuilderTests.test_hashed_password):
(BuilderTests.test_authenticate):
(_create_some_builder):
(_create_build):
(BuildTests.test_get_or_insert_from_log):
(TestModelTests.test_update_or_insert):
(TestModelTests.test_update_or_insert_to_update):
(TestModelTests.test_merge):
(TestResultTests.test_get_or_insert_value):
(TestResultTests.test_get_or_insert_stat_value):
(TestResultTests.test_replace_to_change_test_name):
(TestResultTests.test_replace_to_change_test_name_with_stat_value):
(TestResultTests.test_replace_to_change_test_name_overrides_conflicting_result):
(ReportLogTests._create_log_with_payload):
(ReportLogTests.test_builder):
(ReportLogTests.test_branch):
(ReportLogTests.test_platform):
(PersistentCacheTests._assert_persistent_cache):
(PersistentCacheTests.test_set):
(PersistentCacheTests.test_get):
(DashboardImageTests):
(DashboardImageTests.test_needs_update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago:empty still applies to elements made non-empty via page dynamics.
commit-queue@webkit.org [Thu, 1 Mar 2012 21:53:23 +0000 (21:53 +0000)]
:empty still applies to elements made non-empty via page dynamics.
https://bugs.webkit.org/show_bug.cgi?id=79734

Check for :empty style change should be made even if the RenderStyle for the element is NULL
as changes to the element's children can trigger a change in :empty state of the parent element.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-01
Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/selectors/empty-element-made-non-empty.html

* dom/Element.cpp:
(WebCore::checkForSiblingStyleChanges):

LayoutTests:

* fast/selectors/empty-element-made-non-empty-expected.txt: Added.
* fast/selectors/empty-element-made-non-empty.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Make the interaction with the Flickable work on the N9
abecsi@webkit.org [Thu, 1 Mar 2012 21:51:26 +0000 (21:51 +0000)]
[Qt][WK2] Make the interaction with the Flickable work on the N9
https://bugs.webkit.org/show_bug.cgi?id=80029

Reviewed by Simon Hausmann.

Because the WebView item accepts all touch events it receives and sends
them to the web process before propagating them to the gesture recognizers,
which is correct behaviour, we can not rely on the touch->mouse conversion
of Qt5 when controlling Flickable. Hence we need to convert the received
touch events to mouse events in the QtFlickProvider.

* UIProcess/qt/QtFlickProvider.cpp:
(QtFlickProvider::handleTouchFlickEvent):
Do the touch to mouse event conversion for the Flickable.
* UIProcess/qt/QtPanGestureRecognizer.cpp:
(WebKit::QtPanGestureRecognizer::recognize):
A touch begin event should cancel the previous pan gesture
and stop the ongoing flick animation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Move context lost control code from CCSingleThreadProxy to CCLayerTreeHost
nduca@chromium.org [Thu, 1 Mar 2012 21:42:45 +0000 (21:42 +0000)]
[chromium] Move context lost control code from CCSingleThreadProxy to CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=79964

Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::recreateContext):
(WebCore::CCLayerTreeHost::createContext):
(WebCore::CCLayerTreeHost::didLoseContext):
(WebCore::CCLayerTreeHost::compositeAndReadback):
(WebCore::CCLayerTreeHost::loseContext):
(WebCore::CCLayerTreeHost::updateLayers):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHostClient):
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::initializeContext):
(WebCore::CCSingleThreadProxy::recreateContext):
(WebCore):
(WebCore::CCSingleThreadProxy::loseContext):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::doComposite):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeContext):
(WebCore::CCThreadProxy::recreateContext):
(WebCore):
(WebCore::CCThreadProxy::loseContext):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

Source/WebKit/chromium:

* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::loseCompositorContext):
* src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::createContext):
(WebKit::WebLayerTreeViewImpl::didRecreateContext):
* src/WebLayerTreeViewImpl.h:
(WebLayerTreeViewImpl):
* tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHostClient::createContext):
(WTF::MockLayerTreeHostClient::didRecreateContext):
* tests/FakeCCLayerTreeHostClient.h:
(WebCore::FakeCCLayerTreeHostClient::createContext):
(WebCore::FakeCCLayerTreeHostClient::didRecreateContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoVersioning.
lforschler@apple.com [Thu, 1 Mar 2012 21:35:24 +0000 (21:35 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPrevent layout root to remain set on renderers getting destroyed.
inferno@chromium.org [Thu, 1 Mar 2012 21:27:36 +0000 (21:27 +0000)]
Prevent layout root to remain set on renderers getting destroyed.
https://bugs.webkit.org/show_bug.cgi?id=79953

Reviewed by Eric Seidel.

Implement Julien Chaffraix's idea.

* page/FrameView.h:
(WebCore::FrameView::clearLayoutRoot): helper to clear layout root.
* rendering/RenderObject.cpp:
(WebCore::clearLayoutRootIfNeeded): if we know we are going
away and we are the view's layout root, then we need to reset the layout
root to prevent being used.
(WebCore):
(WebCore::RenderObject::willBeDestroyed): call clearLayoutRootIfNeeded at end.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAssertion failure in pageContainsAnyHorizontalScrollbars() (scrollableArea->isOnActiv...
andersca@apple.com [Thu, 1 Mar 2012 21:26:50 +0000 (21:26 +0000)]
Assertion failure in pageContainsAnyHorizontalScrollbars() (scrollableArea->isOnActivePage()) when leaving pages with embedded PDFs
https://bugs.webkit.org/show_bug.cgi?id=80044
<rdar://problem/10919940>

Reviewed by Brady Eidson.

Remove the code that would add and remove wheel event handlers since that's not what we want to track.
Instead, dynamically add and remove the view as its scrollbars come and go.

* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::updateScrollbars):
(WebKit::BuiltInPDFView::initialize):
* WebProcess/Plugins/PDF/BuiltInPDFView.h:
(BuiltInPDFView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[DRT] Remove all PlainTextController usages in existing tests by adding internal API
commit-queue@webkit.org [Thu, 1 Mar 2012 20:55:53 +0000 (20:55 +0000)]
[DRT] Remove all PlainTextController usages in existing tests by adding internal API
https://bugs.webkit.org/show_bug.cgi?id=78570

Patch by Kangil Han <kangil.han@samsung.com> on 2012-03-01
Reviewed by Hajime Morita.

This patch will remove all PlainTextController usages
in existing DRT tests by adding internal API to WebCore/testing/Internals

.:

* Source/autotools/symbols.filter:

Source/WebCore:

Changed editing/text-iterator/script-tests/basic-iteration.js to use internals.rangeAsText

* testing/Internals.cpp:
(WebCore::Internals::rangeAsText):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

* editing/text-iterator/basic-iteration-expected.txt:
* editing/text-iterator/script-tests/basic-iteration.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline to remove quotes around font name after r109382.
adamk@chromium.org [Thu, 1 Mar 2012 20:43:15 +0000 (20:43 +0000)]
Rebaseline to remove quotes around font name after r109382.

Unreviewed gardening.

* editing/inserting/5994480-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Avoid building any parts of WebKitTestRunner when WK2 is disabled
commit-queue@webkit.org [Thu, 1 Mar 2012 20:37:52 +0000 (20:37 +0000)]
[GTK] Avoid building any parts of WebKitTestRunner when WK2 is disabled
https://bugs.webkit.org/show_bug.cgi?id=80031

Patch by Kalev Lember <kalevlember@gmail.com> on 2012-03-01
Reviewed by Gustavo Noronha Silva.

Only build the libTestRunnerInjectedBundle.la convenience library when
ENABLE_WEBKIT2 is defined.

* WebKitTestRunner/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove expectations for no-longer-flaky tests on Snow Leopard.
adamk@chromium.org [Thu, 1 Mar 2012 20:35:38 +0000 (20:35 +0000)]
Remove expectations for no-longer-flaky tests on Snow Leopard.
https://bugs.webkit.org/show_bug.cgi?id=54322

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, second attempt to fix GTK NRWT after r109242.
philn@webkit.org [Thu, 1 Mar 2012 20:32:55 +0000 (20:32 +0000)]
Unreviewed, second attempt to fix GTK NRWT after r109242.

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkDriver._start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDOMWindow shouldn't have any INDEXED_DATABASE ifdefs
abarth@webkit.org [Thu, 1 Mar 2012 20:29:55 +0000 (20:29 +0000)]
DOMWindow shouldn't have any INDEXED_DATABASE ifdefs
https://bugs.webkit.org/show_bug.cgi?id=80013

Reviewed by Kentaro Hara.

Before this patch, DOMWindow still knew about IDB because of the
database factory.  This patch moves the factory to
DOMWindowIndexedDatabase.

* Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::DOMWindowIndexedDatabase):
(WebCore::DOMWindowIndexedDatabase::from):
(WebCore):
(WebCore::DOMWindowIndexedDatabase::disconnectFrame):
(WebCore::DOMWindowIndexedDatabase::webkitIndexedDB):
* Modules/indexeddb/DOMWindowIndexedDatabase.h:
(DOMWindowIndexedDatabase):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::clear):
(WebCore):
* page/DOMWindow.h:
(DOMWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGlitchy scrolling on pages where the scroll layer needs to be updated on the main...
andersca@apple.com [Thu, 1 Mar 2012 20:04:09 +0000 (20:04 +0000)]
Glitchy scrolling on pages where the scroll layer needs to be updated on the main thread
https://bugs.webkit.org/show_bug.cgi?id=80038
<rdar://problem/10933831>

Reviewed by Simon Fraser.

When we need to update the scroll layer position on the main thread, we need to cache the
scroll position we sent to the main thread and assume that that's the correct scroll position.

* page/scrolling/mac/ScrollingTreeNodeMac.h:
(ScrollingTreeNodeMac):
* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::update):
(WebCore::ScrollingTreeNodeMac::setScrollPosition):
(WebCore::ScrollingTreeNodeMac::scrollPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r109367.
jchaffraix@webkit.org [Thu, 1 Mar 2012 19:58:33 +0000 (19:58 +0000)]
Unreviewed, rolling out r109367.
http://trac.webkit.org/changeset/109367
https://bugs.webkit.org/show_bug.cgi?id=75568

Some tests started to fail in a non obvious way.

Source/WebCore:

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateScrollInfoAfterLayout):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::isPointInOverflowControl):
* rendering/RenderBlock.h:
(RenderBlock):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::willBeDestroyed):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::scrollLeft):
(WebCore::RenderBox::scrollTop):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::RenderBox::includeVerticalScrollbarSize):
(WebCore::RenderBox::includeHorizontalScrollbarSize):
(WebCore::RenderBox::scrolledContentOffset):
(WebCore::RenderBox::cachedSizeForOverflowClip):
(WebCore::RenderBox::pushContentsClip):
(WebCore::RenderBox::popContentsClip):
(WebCore::RenderBox::addLayoutOverflow):
* rendering/RenderBox.h:
(RenderBox):
(WebCore):
* rendering/RenderBoxModelObject.cpp:
(WebCore):
(WebCore::RenderBoxModelObject::styleDidChange):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::requiresLayer):
(RenderBoxModelObject):
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
* rendering/RenderTableRow.h:
(WebCore::RenderTableRow::requiresLayer):

LayoutTests:

* platform/chromium-win/fast/repaint/iframe-scroll-repaint-expected.png:
* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION: Outlook 2007 doesn't display fonts correctly on emails composed by WebKit
bashi@chromium.org [Thu, 1 Mar 2012 19:47:44 +0000 (19:47 +0000)]
REGRESSION: Outlook 2007 doesn't display fonts correctly on emails composed by WebKit
https://bugs.webkit.org/show_bug.cgi?id=79448

Reviewed by Ryosuke Niwa.

Source/WebCore:

Don't produce single quotes around face attribute of font elements.

Test: editing/style/font-face-unquote.html

* editing/EditingStyle.cpp:
(WebCore::StyleChange::extractTextStyles): Remove single quotes from m_applyFontFace.

LayoutTests:

Add a test that makes sure WebKit doesn't produce single quotes around
face attribute of font element.

* editing/style/font-face-unquote-expected.txt: Added.
* editing/style/font-face-unquote.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReviewed by Kevin Decker.
bdakin@apple.com [Thu, 1 Mar 2012 19:36:55 +0000 (19:36 +0000)]
Reviewed by Kevin Decker.

Part of https://bugs.webkit.org/show_bug.cgi?id=79705

Here's some of that tweaking promised in the comment. Adjusting
gMaximumUnpaintedAreaRatio down a bit.
* page/Page.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd roundToInt method for LayoutUnits
leviw@chromium.org [Thu, 1 Mar 2012 19:33:44 +0000 (19:33 +0000)]
Add roundToInt method for LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=79283

Reviewed by Eric Seidel.

Adding a roundToInt method that rounds a LayoutUnit to the nearest integer. This
only has an effect once we switch to sub-pixel positioning. Points and offsets
are rounded for painting and hit testing.

No new tests. No change in behavior.

* dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::offsetX):
(WebCore::MouseRelatedEvent::offsetY):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateSizes):
* rendering/LayoutState.cpp:
(WebCore::LayoutState::computeLineGridPaginationOrigin):
* rendering/LayoutTypes.h:
(WebCore::roundToInt): Stub until we switch to sub-pixel LayoutUnits.
(WebCore):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::pageLogicalTopForOffset):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine): Correcting to use the
pixel snapped methods on FloatingObjects and removing the fixme.
(WebCore::RenderBlock::pixelSnappedLogicalTopForFloat): Ditto.
(WebCore::RenderBlock::pixelSnappedLogicalBottomForFloat): Ditto.
(WebCore::RenderBlock::pixelSnappedLogicalLeftForFloat): Ditto.
(WebCore::RenderBlock::pixelSnappedLogicalRightForFloat): Ditto.
(WebCore::RenderBlock::pixelSnappedLogicalWidthForFloat): Ditto.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::updateAvailableWidth):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Using
pixelSnappedLogicalLeft/RightOffsetForLine convenience methods for line layout. When
we switch to sub-pixel positioning, we still pixel snap blocks before painting them,
but text is rendered using floats. We need to ensure the text is laid out using the
actual pixel width of the containing block to avoid bleeding out of the block.
* rendering/RenderBoxModelObject.h: Moving the fixme to pixelSnappedWidth/Height and
adding the necessary rounding for Left/Top.
(WebCore::RenderBoxModelObject::pixelSnappedOffsetLeft):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetTop):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollHeight): Rounding the height for scrollHeight. Scrolling
always uses rounded values.
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::localToParentTransform): Similar to the line box tree, since
SVG renders using floats, we need to start with pixel snapped values from the render
tree or we'll end up with the contents not properly aligned to the rest of the page.
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::prepareToRenderSVGContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMark use-same-database-in-page-and-workers.html as a TEXT failure.
adamk@chromium.org [Thu, 1 Mar 2012 19:22:44 +0000 (19:22 +0000)]
Mark use-same-database-in-page-and-workers.html as a TEXT failure.
Requested by dslomov on #webkit.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109375 268f45cc-cd09-0410-ab3c-d52691b4dbfc