WebKit-https.git
7 years agoDFG should inline prototype chain accesses, and do the right things if the
fpizlo@apple.com [Fri, 8 Jun 2012 01:31:21 +0000 (01:31 +0000)]
DFG should inline prototype chain accesses, and do the right things if the
specific function optimization is available
https://bugs.webkit.org/show_bug.cgi?id=88594

Reviewed by Gavin Barraclough.

Looks like a 3% win on V8.

* bytecode/CodeBlock.h:
(JSC::Structure::prototypeForLookup):
(JSC):
* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC):
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):
* bytecode/GetByIdStatus.h:
(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::isSimple):
(JSC::GetByIdStatus::chain):
(JSC::GetByIdStatus::specificValue):
(GetByIdStatus):
* bytecode/StructureSet.h:
(StructureSet):
(JSC::StructureSet::singletonStructure):
* bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::initGetByIdProto):
(JSC::StructureStubInfo::initGetByIdChain):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleGetById):
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryCacheGetByID):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCacheGetByID):
* runtime/JSGlobalObject.h:
(JSC::Structure::prototypeForLookup):
(JSC):
* runtime/Structure.h:
(Structure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Move didStartWorkerRunLoop to Platform.h
pilgrim@chromium.org [Fri, 8 Jun 2012 00:48:40 +0000 (00:48 +0000)]
[Chromium] Move didStartWorkerRunLoop to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=88562

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* WebCore.gyp/WebCore.gyp:
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::~WorkerScriptController):
* platform/chromium/PlatformSupport.h:
(WebCore):
* workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDropping m_startingLineNumber property from StyledElement.
commit-queue@webkit.org [Fri, 8 Jun 2012 00:36:22 +0000 (00:36 +0000)]
Dropping m_startingLineNumber property from StyledElement.
https://bugs.webkit.org/show_bug.cgi?id=86848

Patch by Mike West <mkwst@chromium.org> on 2012-06-07
Reviewed by Adam Barth.

We can have the same effect by moving the line-number calculation
directly into StyledElement::styleAttributeChanged. This means that
subsequent changes to the style attribute (via script) won't generate
error messages with line numbers, but that's an acceptable tradeoff.

Behavior is covered by existing CSP tests.

* dom/StyledElement.cpp:
(WebCore::StyledElement::StyledElement):
(WebCore::StyledElement::styleAttributeChanged):
* dom/StyledElement.h:
(WebCore::StyledElement::destroyInlineStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMath.pow on iOS does not support denormal numbers.
barraclough@apple.com [Fri, 8 Jun 2012 00:29:27 +0000 (00:29 +0000)]
Math.pow on iOS does not support denormal numbers.
https://bugs.webkit.org/show_bug.cgi?id=88592

Reviewed by Filip Pizlo.

Import an implementation from fdlibm, detect cases where it is safe to use the system
implementation & where we should fall back to fdlibm.

* runtime/MathObject.cpp:
(JSC::isDenormal):
(JSC::isEdgeCase):
(JSC::mathPow):
    - On iOS, detect cases where denormal support may be required & use fdlibm in these cases.
(JSC::mathProtoFuncPow):
    - Changed to use mathPow.
(JSC::fdlibmScalbn):
(JSC::fdlibmPow):
    - These functions imported from fdlibm; original style retained to ease future merging.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Should Use the WebPage Already Created by Client, No Need to Create...
commit-queue@webkit.org [Fri, 8 Jun 2012 00:00:04 +0000 (00:00 +0000)]
[BlackBerry] Should Use the WebPage Already Created by Client, No Need to Create New One.
https://bugs.webkit.org/show_bug.cgi?id=88576

Patch by Crystal Zhang <haizhang@rim.com> on 2012-06-07
Reviewed by Rob Buis.

When PagePopupBlackBerry::init() is called, a WebPage is already created, we can just use
this to load popup, no need to create a new one. The old code is based on an old solution
which has been abandoned.

* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::openPagePopup):
* WebCoreSupport/PagePopupBlackBerry.cpp:
(WebCore::PagePopupBlackBerry::init):
(WebCore::setValueAndClosePopupCallback):
(WebCore::PagePopupBlackBerry::handleMouseEvent):
(WebCore::PagePopupBlackBerry::closePopup):
* WebCoreSupport/PagePopupBlackBerry.h:
(PagePopupBlackBerry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInitialize m_document in AXObjectCache's constructor for !HAVE(ACCESSIBILITY) builds
peter@chromium.org [Thu, 7 Jun 2012 23:59:48 +0000 (23:59 +0000)]
Initialize m_document in AXObjectCache's constructor for !HAVE(ACCESSIBILITY) builds
https://bugs.webkit.org/show_bug.cgi?id=88527

Reviewed by Adam Barth.

Initialize the m_document member with the passed on document in the stubbed
AXObjectCache constructor. No behavioral changes.

* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::AXObjectCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark fast/table/multiple-captions-display.xhtml as flaky on Chromium.
ojan@chromium.org [Thu, 7 Jun 2012 23:46:17 +0000 (23:46 +0000)]
Mark fast/table/multiple-captions-display.xhtml as flaky on Chromium.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Get rid of unused maximumLayoutSize in WebPage
zhajiang@rim.com [Thu, 7 Jun 2012 23:44:04 +0000 (23:44 +0000)]
[BlackBerry] Get rid of unused maximumLayoutSize in WebPage
https://bugs.webkit.org/show_bug.cgi?id=88574

Reviewed by Rob Buis.
Patch by Jacky Jiang <zhajiang@rim.com>

PR: 164098
maximumLayoutSize was deprecated when we made use of
WebCore::computeViewportAttributes for
WebPagePrivate::recomputeVirtualViewportFromViewportArguments.
So clean it up.

* Api/WebPage.cpp:
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium rebaselines after http://trac.webkit.org/changeset/119760.
ojan@chromium.org [Thu, 7 Jun 2012 23:36:09 +0000 (23:36 +0000)]
Chromium rebaselines after trac.webkit.org/changeset/119760.

* platform/chromium-linux/fast/borders/border-radius-valid-border-clipping-expected.png: Added.
* platform/chromium-mac/fast/borders/border-radius-valid-border-clipping-expected.png:
* platform/chromium-win/fast/borders/border-radius-valid-border-clipping-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Move deferral-related logic out of Canvas2DLayerChromium
jamesr@google.com [Thu, 7 Jun 2012 23:35:54 +0000 (23:35 +0000)]
[chromium] Move deferral-related logic out of Canvas2DLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=86050

Reviewed by Stephen White.

Source/WebCore:

This removes Canvas2DLayerChromium and puts the deferral and double-buffering related logic in a new class,
Canvas2DLayerBridge, that uses TextureLayerChromium for compositing.  The bridge is responsible for managing the
front texture when double buffering is active, inserting the correct makeContextCurrent() and flush() calls on
the GraphicsContext3D and SkCanvas when appropriate, and owning the lifetime of the layer.

* WebCore.gypi:
* platform/graphics/chromium/Canvas2DLayerBridge.cpp: Added.
(WebCore):
(AcceleratedDeviceContext):
(WebCore::AcceleratedDeviceContext::AcceleratedDeviceContext):
(WebCore::AcceleratedDeviceContext::prepareForDraw):
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::skCanvas):
(WebCore::Canvas2DLayerBridge::prepareTexture):
(WebCore::Canvas2DLayerBridge::context):
(WebCore::Canvas2DLayerBridge::layer):
(WebCore::Canvas2DLayerBridge::contextAcquired):
* platform/graphics/chromium/Canvas2DLayerBridge.h: Added.
(WebCore):
(Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::create):
* platform/graphics/chromium/Canvas2DLayerChromium.cpp: Removed.
* platform/graphics/chromium/Canvas2DLayerChromium.h: Removed.
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
* platform/graphics/chromium/ImageBufferDataSkia.h:
(WebCore):
(ImageBufferData):
* platform/graphics/chromium/TextureLayerChromium.cpp:
(WebCore::TextureLayerChromium::willModifyTexture):
    willModifyTexture() is called whenever the texture currently owned by the TextureLayerChromium will be
    modified by a system out of the compositor's control. It makes sure that the compositor does not attempt to
    draw with the potentially-modified texture until the next commit. For canvas, this is used when threading is
    enabled and a non-deferrable drawing command is invoked from JS.
(WebCore):
* platform/graphics/chromium/TextureLayerChromium.h:
(TextureLayerChromium):
* platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::hasMoreUpdates):
(WebCore::CCTextureUpdater::update):
(WebCore::CCTextureUpdater::clear):
* platform/graphics/chromium/cc/CCTextureUpdater.h:
(CCTextureUpdater):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::createAcceleratedCanvas):
(WebCore::ImageBuffer::~ImageBuffer):
(WebCore::ImageBuffer::context):
(WebCore::ImageBuffer::platformLayer):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/Canvas2DLayerBridgeTest.cpp: Renamed from tests/Canvas2DLayerChromiumTest
(Canvas2DLayerBridgeTest):
(Canvas2DLayerBridgeTest::fullLifecycleTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Build fix for !ENABLE(JIT) after r119441.
paroga@webkit.org [Thu, 7 Jun 2012 23:24:14 +0000 (23:24 +0000)]
Unreviewed. Build fix for !ENABLE(JIT) after r119441.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for WinCE after r113570.
paroga@webkit.org [Thu, 7 Jun 2012 23:18:38 +0000 (23:18 +0000)]
Build fix for WinCE after r113570.

* Source/cmake/OptionsWinCE.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes...
dpranke@chromium.org [Thu, 7 Jun 2012 23:10:23 +0000 (23:10 +0000)]
webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
https://bugs.webkit.org/show_bug.cgi?id=88581

Reviewed by Ojan Vafai.

webkit-paptch rebaseline-expectations was ignoring what the
expected results for a test were and pulling down all the result
files from a bot. This could lead to us pulling down old,
incorrect .txt or .png files. With this patch we will now only
pull down expectations of the appropriate file types (so an
IMAGE failure will only pull the png and not the txt file).

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(has_pixel_failures):
(suffixes_for_expectations):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(FunctionsTest.test_suffixes_for_expectations):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractRebaseliningCommand.__init__):
(RebaselineExpectations._is_supported_port):
(RebaselineExpectations._update_expectations_file):
(RebaselineExpectations._tests_to_rebaseline):
(RebaselineExpectations._rebaseline_port):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_overrides_are_included_correctly):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove HAVE(PATH_BASED_BORDER_RADIUS_DRAWING)
paroga@webkit.org [Thu, 7 Jun 2012 23:07:48 +0000 (23:07 +0000)]
Remove HAVE(PATH_BASED_BORDER_RADIUS_DRAWING)
https://bugs.webkit.org/show_bug.cgi?id=87931

Reviewed by Beth Dakin.

r62035 added HAVE(PATH_BASED_BORDER_RADIUS_DRAWING) until all ports implement
GraphicsContext::clipConvexPolygon(). All major ports define HAVE_PATH_BASED_BORDER_RADIUS_DRAWING in the
meantime and the alternative path has unnecessary maintainace costs and even don't compile at the moment.

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::paintFocusRing):
* rendering/RenderObject.h:
(RenderObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed, new baselines for chromium-win after fixing
tony@chromium.org [Thu, 7 Jun 2012 22:44:46 +0000 (22:44 +0000)]
[chromium] Unreviewed, new baselines for chromium-win after fixing
scrollbar rendering in r119748.

List of files omitted since it's long.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd new Pointer Lock spec events webkitpointerlockchange and webkitpointerlockerror
scheib@chromium.org [Thu, 7 Jun 2012 22:40:19 +0000 (22:40 +0000)]
Add new Pointer Lock spec events webkitpointerlockchange and webkitpointerlockerror
https://bugs.webkit.org/show_bug.cgi?id=88377

Reviewed by Dimitri Glazkov.

Part of a series of refactoring changes to update pointer lock API to
the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402

New change and error events added. Follow up patches will remove
the previous callbacks and pointerlocklost event. Tests updated
to include the new events, and a new test added specifically for
the new events, pointerlockchange-pointerlockerror-events.html.

Source/WebCore:

Test: pointer-lock/pointerlockchange-pointerlockerror-events.html

* dom/Document.h:
(Document):
* dom/Document.idl:
* dom/EventNames.h:
(WebCore):
* page/PointerLockController.cpp:
(WebCore::PointerLockController::requestPointerLock):
(WebCore::PointerLockController::didAcquirePointerLock):
(WebCore::PointerLockController::didNotAcquirePointerLock):
(WebCore::PointerLockController::didLosePointerLock):
(WebCore::PointerLockController::enqueueEvent):
(WebCore):
* page/PointerLockController.h:
(PointerLockController):

LayoutTests:

* pointer-lock/lock-already-locked-expected.txt:
* pointer-lock/lock-already-locked.html:
* pointer-lock/pointer-lock-api-expected.txt:
* pointer-lock/pointer-lock-api.html:
* pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt: Added.
* pointer-lock/pointerlockchange-pointerlockerror-events.html: Added.
* pointer-lock/pointerlocklost-event-expected.txt:
* pointer-lock/pointerlocklost-event.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r119744.
commit-queue@webkit.org [Thu, 7 Jun 2012 22:37:50 +0000 (22:37 +0000)]
Unreviewed, rolling out r119744.
http://trac.webkit.org/changeset/119744
https://bugs.webkit.org/show_bug.cgi?id=88584

Fails assertions in debug builds (Requested by jamesr_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-07

Source/WebCore:

* platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
(WebCore::CCIOSurfaceLayerImpl::~CCIOSurfaceLayerImpl):
(WebCore::CCIOSurfaceLayerImpl::willDraw):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCache RenderLayer::isRootLayer for better performance
jchaffraix@webkit.org [Thu, 7 Jun 2012 22:27:32 +0000 (22:27 +0000)]
Cache RenderLayer::isRootLayer for better performance
https://bugs.webkit.org/show_bug.cgi?id=88570

Reviewed by Ojan Vafai.

Caching covered by existing tests.

RenderLayer::isRootLayer()'s answer will be the same during the RenderLayer's
lifetime as a RenderLayer is tied to a RenderBoxModelObject. This change caches
isRootLayer value in the constructor.

On http://dglazkov.github.com/performance-tests/biggrid.html with a 100,000 rows
by 100 columns table, it saves about 10% on the paint time during scrolling on
my machine (going from 50ms to 45ms). It would expect all code paths to see some
improvement as checking renderer()->isRenderView() was pretty common.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
Added code to cache the result of renderer()->isRenderView() here.

(WebCore::RenderLayer::stackingContext):
(WebCore::isPositionedContainer):
(WebCore::isFixedPositionedContainer):
(WebCore::RenderLayer::enclosingTransformedAncestor):
(WebCore::RenderLayer::clippingRootForPainting):
(WebCore::shouldSuppressPaintingLayer):
(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::intersectsDamageRect):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::isStackingContext):
Updated all the call sites to use isRootLayer() instead of renderer()->isRenderView()
as it is faster.

(WebCore::RenderLayer::isRootLayer):
Added our caching here. Also made m_canSkipRepaintRectsUpdateOnScroll to follow
m_isRootLayer example.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIncorrect border rendering when border radius is above 2px.
commit-queue@webkit.org [Thu, 7 Jun 2012 22:12:31 +0000 (22:12 +0000)]
Incorrect border rendering when border radius is above 2px.
https://bugs.webkit.org/show_bug.cgi?id=88046

Source/WebCore:

Fixing findInnerVertex's logic to decide which is the better line
to find an inner vertex, x=center point's x of a rendering box or
y=center point's y of a rendering box.

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-07
Reviewed by Simon Fraser.

Test: fast/borders/border-radius-valid-border-clipping.html

* rendering/RenderBoxModelObject.cpp:
(WebCore::findInnerVertex):

LayoutTests:

Patch by Takashi Sakamoto <tasak@google.com> on 2012-06-07
Reviewed by Simon Fraser.

* fast/borders/border-radius-valid-border-clipping-expected.txt: Added.
* fast/borders/border-radius-valid-border-clipping.html: Added.
* platform/chromium-mac/fast/borders/border-radius-valid-border-clipping-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Should fire error event for empty 404 script
commit-queue@webkit.org [Thu, 7 Jun 2012 22:08:53 +0000 (22:08 +0000)]
Source/WebCore: Should fire error event for empty 404 script
https://bugs.webkit.org/show_bug.cgi?id=50589

Patch by Edaena Salinas Jasso <edaena@apple.com> on 2012-06-07
Reviewed by Brady Eidson.

Tests:
http/tests/loading/fire-error-event-empty-404-script.html
http/tests/loading/fire-error-script-no-content-type.html

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse): We should check for http status
codes here to stop depending on the response being non-empty.
(WebCore::SubresourceLoader::didReceiveData): Moved the http status check but
avoid messing with multipart responses.
(WebCore::SubresourceLoader::checkForHTTPStatusCodeError): Renamed from
errorLoadingResource for clarity.

* loader/SubresourceLoader.h:
* loader/cf/SubresourceLoaderCF.cpp:
(WebCore::SubresourceLoader::didReceiveDataArray):
Updated for errorLoadingResource renaming.

LayoutTests: Should fire error event for empty 404 script
https://bugs.webkit.org/show_bug.cgi?id=50589

Patch by Edaena Salinas Jasso <edaena@apple.com> on 2012-06-07
Reviewed by Brady Eidson.

Based on a test by Ojan Vafai.

* http/tests/loading/fire-error-event-empty-404-script-expected.txt: Added.
* http/tests/loading/fire-error-event-empty-404-script.html: Added.
* http/tests/loading/fire-error-event-script-no-content-type-expected.txt: Added.
* http/tests/loading/fire-error-event-script-no-content-type.html: Added.
* http/tests/loading/resources/404-with-empty-body-no-content-type.cgi: Added.
* http/tests/loading/resources/404-with-empty-body.cgi: Added.
* http/tests/resources/network-simulator.php: Fixed to no longer return 404 error
when logging a request.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSearch highlight does not scroll with the content of the page, and find overlay doesn...
andersca@apple.com [Thu, 7 Jun 2012 22:08:32 +0000 (22:08 +0000)]
Search highlight does not scroll with the content of the page, and find overlay doesn't work, on large-enough window
https://bugs.webkit.org/show_bug.cgi?id=88577
<rdar://problem/11430118>

Reviewed by John Sullivan.

Prevent the page overlay layer from falling into tiled mode.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Qt DRT should load external resources - cleanup
zoltan@webkit.org [Thu, 7 Jun 2012 22:01:37 +0000 (22:01 +0000)]
[Qt] Qt DRT should load external resources - cleanup
https://bugs.webkit.org/show_bug.cgi?id=88568

Make things more straighforward to load external URLs in DRT.

Reviewed by Ryosuke Niwa.

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/js/dfg-double-vote-fuzz.html fails on Chromium release.
ojan@chromium.org [Thu, 7 Jun 2012 21:55:42 +0000 (21:55 +0000)]
fast/js/dfg-double-vote-fuzz.html fails on Chromium release.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Update PlayBook's User Agent String for Web Inspector
commit-queue@webkit.org [Thu, 7 Jun 2012 21:35:35 +0000 (21:35 +0000)]
[BlackBerry] Update PlayBook's User Agent String for Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=88543

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-06-07
Reviewed by Antonio Gomes.

We expect users to upgrade their devices so developers only need the latest UA String.

No tests needed.

* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix recent null pointer error regression in the flakiness dashboard
ojan@chromium.org [Thu, 7 Jun 2012 21:32:33 +0000 (21:32 +0000)]
Fix recent null pointer error regression in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=88573

Reviewed by Dirk Pranke.

* TestResultServer/static-dashboards/builders.js:
(requestBuilderList):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove obsolete FIXME comment about a layer sorting bug.
shawnsingh@chromium.org [Thu, 7 Jun 2012 21:32:13 +0000 (21:32 +0000)]
[chromium] Remove obsolete FIXME comment about a layer sorting bug.
https://bugs.webkit.org/show_bug.cgi?id=88546

Reviewed by James Robinson.

No tests needed, only comment changed. The comment referred to a
potential bug that actually will not occur. The W3C spec on CSS 3d
transforms indicates that layers that do not share the same "3d
rendering context" do not sort together, and our existing code
sorts this way already.

* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::subtreeShouldRenderToSeparateSurface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSettings::defaultDeviceScaleFactor is redundant with Page::deviceScaleFactor
abarth@webkit.org [Thu, 7 Jun 2012 21:21:31 +0000 (21:21 +0000)]
Settings::defaultDeviceScaleFactor is redundant with Page::deviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=88375

Reviewed by James Robinson.

.:

This symbol no longer exists.

* Source/autotools/symbols.filter:

Source/WebCore:

This patch removes Settings::defaultDeviceScaleFactor because it is
redundant with Page::deviceScaleFactor now that we no longer support
target-densitydpi.  Page::deviceScaleFactor is the canonical place to
store the device scale factor.

* WebCore.exp.in:
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore):
* page/Settings.h:
(Settings):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::setDeviceScaleFactor):

Source/WebKit/chromium:

* public/WebSettings.h:
(WebKit::WebSettings::setDefaultDeviceScaleFactor):
(WebSettings):
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
* src/WebSettingsImpl.cpp:
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* tests/WebFrameTest.cpp:
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Error codes, phase one
commit-queue@webkit.org [Thu, 7 Jun 2012 21:11:36 +0000 (21:11 +0000)]
IndexedDB: Error codes, phase one
https://bugs.webkit.org/show_bug.cgi?id=88459

Patch by Alec Flett <alecflett@chromium.org> on 2012-06-07
Reviewed by Tony Chang.

Source/WebCore:

This phase gets rid of the now-deprecated NOT_ALLOWED_ERR and
NON_TRANSIENT_ERR from earlier versions of the spec, and
normalizes the place where TypeError should be thrown so that it's
easier to update when the bindings change.

No new tests: existing tests cover these changes and have been updated.

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::advance):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::stringToDirection):
(WebCore::IDBCursor::directionToString):
* Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::update):
(WebCore::IDBCursorBackendImpl::deleteFunction):
* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::setVersion):
(WebCore::IDBDatabase::transaction):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::setVersion):
* Modules/indexeddb/IDBDatabaseException.cpp:
(WebCore):
* Modules/indexeddb/IDBDatabaseException.h:
* Modules/indexeddb/IDBDatabaseException.idl:
* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::open):
(WebCore::IDBFactory::deleteDatabase):
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::index):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::result):
(WebCore::IDBRequest::errorCode):
(WebCore::IDBRequest::webkitErrorMessage):
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::stringToMode):
(WebCore::IDBTransaction::modeToString):
* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::objectStore):

LayoutTests:

* storage/indexeddb/basics-expected.txt:
* storage/indexeddb/basics-shared-workers-expected.txt:
* storage/indexeddb/basics-workers-expected.txt:
* storage/indexeddb/create-and-remove-object-store-expected.txt:
* storage/indexeddb/cursor-advance-expected.txt:
* storage/indexeddb/cursor-update-expected.txt:
* storage/indexeddb/database-basics-expected.txt:
* storage/indexeddb/deleteIndex-expected.txt:
* storage/indexeddb/resources/basics.js:
(test):
* storage/indexeddb/resources/create-and-remove-object-store.js:
(testCreateAndRemove):
(tryOnceMore):
* storage/indexeddb/resources/cursor-advance.js:
(testBadAdvance.advanceBadly):
(testBadAdvance):
* storage/indexeddb/resources/cursor-update.js:
(keyCursor):
* storage/indexeddb/resources/database-basics.js:
(testClose):
* storage/indexeddb/resources/deleteIndex.js:
(postTwiddling):
* storage/indexeddb/resources/transaction-after-close.js:
(firstTransactionComplete):
* storage/indexeddb/resources/transaction-and-objectstore-calls.js:
(afterComplete):
* storage/indexeddb/resources/transaction-basics.js:
(testInvalidMode):
* storage/indexeddb/transaction-after-close-expected.txt:
* storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
* storage/indexeddb/transaction-basics-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd Konrad Piascik to committers.py
commit-queue@webkit.org [Thu, 7 Jun 2012 20:08:43 +0000 (20:08 +0000)]
Add Konrad Piascik to committers.py
https://bugs.webkit.org/show_bug.cgi?id=88560

Unreviewed.

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-06-07

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] features.gypi should have the correct definitions for Android
peter@chromium.org [Thu, 7 Jun 2012 20:07:59 +0000 (20:07 +0000)]
[Chromium] features.gypi should have the correct definitions for Android
https://bugs.webkit.org/show_bug.cgi?id=88533

Reviewed by Adam Barth.

Make all features which are enabled on Android but disabled on other platforms,
or are disabled on Android while enabled on other platforms, conditional. This
also means that the selection of code compiled for Android will slightly change.

This change also removes the enable_viewport variable as the value of this is
no longer respected by WebKit - it's enabled by default for all of Chromium.
Furthermore, ENABLE_OVERFLOW_SCROLLING is now listed in features.gypi again.

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
tony@chromium.org [Thu, 7 Jun 2012 20:06:57 +0000 (20:06 +0000)]
[chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
https://bugs.webkit.org/show_bug.cgi?id=77368

Reviewed by Ojan Vafai.

It doesn't look like we ever get a rect with width or height of 0.
I ran css1, css2.1, fast/forms, and tables without any crashes.

* DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
(webRectToSkIRect): Correctly convert a WebRect to a SkIRect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorun-webkit-tests --lint-test-files gives an error when run on linux
dpranke@chromium.org [Thu, 7 Jun 2012 19:44:59 +0000 (19:44 +0000)]
run-webkit-tests --lint-test-files gives an error when run on linux
https://bugs.webkit.org/show_bug.cgi?id=88551

Reviewed by Ojan Vafai.

We weren't mapping the expectations properly for the
google-chrome ports.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.path_to_test_expectations_file):
* Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
(TestGoogleChromePort.test_path_to_expectations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r119737.
epoger@chromium.org [Thu, 7 Jun 2012 19:27:40 +0000 (19:27 +0000)]
Unreviewed, rolling out r119737.
http://trac.webkit.org/changeset/119737

see https://bugs.webkit.org/show_bug.cgi?id=88561

* css1/basic/class_as_selector-expected.txt: Removed.
* css1/basic/containment-expected.txt: Removed.
...
* platform/gtk/css3/selectors3/xml/css3-modsel-74-expected.txt: Copied from LayoutTests/platform/gtk/css3/selectors3/xml/css3-modsel-74-expected.txt.
* platform/gtk/css3/selectors3/xml/css3-modsel-74b-expected.txt: Copied from LayoutTests/platform/gtk/css3/selectors3/xml/css3-modsel-74b-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHopefully final chromium rebaseline for r119617.
ojan@chromium.org [Thu, 7 Jun 2012 19:16:24 +0000 (19:16 +0000)]
Hopefully final chromium rebaseline for r119617.

* platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed
danakj@chromium.org [Thu, 7 Jun 2012 19:07:37 +0000 (19:07 +0000)]
[chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed
https://bugs.webkit.org/show_bug.cgi?id=88371

Reviewed by James Robinson.

Source/WebCore:

Unit test: CCLayerTreeHostImplTest.layersFreeTextures

* platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
(WebCore::CCIOSurfaceLayerImpl::~CCIOSurfaceLayerImpl):
(WebCore::CCIOSurfaceLayerImpl::willDraw):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuildfix for ENABLE_OVERFLOW_SCROLLING=0 (though defined)
peter@chromium.org [Thu, 7 Jun 2012 18:46:51 +0000 (18:46 +0000)]
Buildfix for ENABLE_OVERFLOW_SCROLLING=0 (though defined)
https://bugs.webkit.org/show_bug.cgi?id=88564

Reviewed by Adam Barth.

Where ENABLE(X) mandates that X both has to be defined and evaluates to
true as a lone preprocessor statement, there were two places in the CSS
property and value input files where only was checked whether is has
been defined. This also goes against other #ifdefs in those files.

* css/CSSPropertyNames.in:
* css/CSSValueKeywords.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPlumb CORS attribute information from HTMLMediaElement to media players so it can...
fischman@chromium.org [Thu, 7 Jun 2012 18:37:39 +0000 (18:37 +0000)]
Plumb CORS attribute information from HTMLMediaElement to media players so it can be used
https://bugs.webkit.org/show_bug.cgi?id=88349

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/video-cross-origin-readback.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerCORSMode):
(WebCore):
* html/HTMLMediaElement.h:
(HTMLMediaElement):
* html/canvas/CanvasRenderingContext.cpp:
(WebCore::CanvasRenderingContext::wouldTaintOrigin):
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::didPassCORSAccessCheck):
(WebCore):
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerCORSMode):
(MediaPlayer):
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::didPassCORSAccessCheck):
(MediaPlayerPrivateInterface):

Source/WebKit/chromium:

* public/WebMediaPlayer.h:
(WebMediaPlayer):
* src/AssertMatchingEnums.cpp:
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit::WebMediaPlayerClientImpl::didPassCORSAccessCheck):
(WebKit):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):

LayoutTests:

* http/tests/security/resources/video-cross-origin-allow.php: Added.
* http/tests/security/video-cross-origin-readback-expected.txt: Added.
* http/tests/security/video-cross-origin-readback.html: Added.
* platform/efl/Skipped:
* platform/gtk/TestExpectations:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed; chromium test_expectations update.
senorblanco@chromium.org [Thu, 7 Jun 2012 18:32:52 +0000 (18:32 +0000)]
Unreviewed; chromium test_expectations update.

Removing expected-to-fail results for now-passing tests.

* platform/chromium-mac/canvas/philip/tests/2d.line.width.basic-expected.txt: Removed.
* platform/chromium-mac/canvas/philip/tests/2d.line.width.transformed-expected.txt: Removed.
* platform/chromium-mac/canvas/philip/tests/2d.transformation.setTransform.skewed-expected.txt: Removed.
* platform/chromium-mac/canvas/philip/tests/2d.transformation.transform.skewed-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWorker tear-down can re-enter JSC during GC finalization
mhahnenberg@apple.com [Thu, 7 Jun 2012 18:31:50 +0000 (18:31 +0000)]
Worker tear-down can re-enter JSC during GC finalization
https://bugs.webkit.org/show_bug.cgi?id=88449

Reviewed by Geoffrey Garen.

No new tests.

This is the first of two patches to fix this issue with Workers.

* workers/AbstractWorker.cpp:
(WebCore::AbstractWorker::~AbstractWorker): We don't need to call onDestroyWorker() here, it
will be called elsewhere in contextDestroyed().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agosometimes all slaved videos don't start playing
jer.noble@apple.com [Thu, 7 Jun 2012 18:18:37 +0000 (18:18 +0000)]
sometimes all slaved videos don't start playing
https://bugs.webkit.org/show_bug.cgi?id=88553

Reviewed by Darin Adler.

Source/WebCore:

Test: media/media-controller-time-clamp.html

Some PlatformClock classes will occasionally return times < 0 and will
always return times slightly > duration() when playback has ended.  Clamp
the value of currentTime() to the specified [0..duration] range.

* html/MediaController.cpp:
(MediaController::currentTime):

LayoutTests:

* media/media-controller-time-clamp-expected.txt: Added.
* media/media-controller-time-clamp.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark another test as slow on Chromium Windows.
ojan@chromium.org [Thu, 7 Jun 2012 18:02:40 +0000 (18:02 +0000)]
Mark another test as slow on Chromium Windows.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPart 1 of rebaselines for http://crbug.com/131189
epoger@chromium.org [Thu, 7 Jun 2012 17:58:11 +0000 (17:58 +0000)]
Part 1 of rebaselines for http://crbug.com/131189

Unreviewed rebaselining.

* css1/basic/class_as_selector-expected.txt: Added.
* css1/basic/containment-expected.txt: Added.
...
* platform/gtk/css3/selectors3/xml/css3-modsel-74-expected.txt: Removed.
* platform/gtk/css3/selectors3/xml/css3-modsel-74b-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOptimize FrameView::scrollXForFixedPosition() / scrollYForFixedPosition()
simon.fraser@apple.com [Thu, 7 Jun 2012 17:57:00 +0000 (17:57 +0000)]
Optimize FrameView::scrollXForFixedPosition() / scrollYForFixedPosition()
https://bugs.webkit.org/show_bug.cgi?id=88475

Reviewed by Sam Weinig.

FrameView's scrollXForFixedPosition() and scrollYForFixedPosition()
methods were often called together, but they do duplicate work,
including calling into platform widget code which might be slow.

Fix by converting scrollOffsetForFixedPosition() from being a wrapper
that just calls scrollXForFixedPosition() and scrollYForFixedPosition()
to the method that does all the work, calling just once into platform
widget code.

Changed callers to use scrollOffsetForFixedPosition() rather than make
two separate method calls.

Added ScrollView::layoutSize() and visibleSize() methods for
convenience.

Removed FrameView::scrollXForFixedPosition and FrameView::scrollYForFixedPosition
to avoid inefficient callers in future.

No new tests; refactoring only.

* page/FrameView.cpp:
(WebCore::fixedPositionScrollOffset):
(WebCore::FrameView::scrollOffsetForFixedPosition):
* page/FrameView.h: Removed scrollXForFixedPosition and scrollYForFixedPosition.
* platform/ScrollView.cpp:
(WebCore::ScrollView::layoutSize):
* platform/ScrollView.h:
(WebCore::ScrollView::visibleSize):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::backgroundClipRect):
* rendering/RenderLayer.h:
(WebCore::ClipRect::move):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
* rendering/RenderView.cpp:
(WebCore::RenderView::computeRectForRepaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoclean up suppressions around two-point-radial-gradient in skia (fix will come later)
reed@google.com [Thu, 7 Jun 2012 17:44:50 +0000 (17:44 +0000)]
clean up suppressions around two-point-radial-gradient in skia (fix will come later)
https://bugs.webkit.org/show_bug.cgi?id=88549

Expectations change only.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate some flaky/slow expectations to better match the bots.
ojan@chromium.org [Thu, 7 Jun 2012 17:37:03 +0000 (17:37 +0000)]
Update some flaky/slow expectations to better match the bots.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIncorrect rect-based hit-test result for culled-inline elements
commit-queue@webkit.org [Thu, 7 Jun 2012 17:02:19 +0000 (17:02 +0000)]
Incorrect rect-based hit-test result for culled-inline elements
https://bugs.webkit.org/show_bug.cgi?id=85849

Patch by Raymes Khoury <raymes@chromium.org> on 2012-06-07
Reviewed by Levi Weintraub.

Source/WebCore:

Modified code which blindly adds culled inlines to rect-based hit-test
results so that it only does so if the child node does not fully cover
the hit-test region.

Test: fast/dom/nodesFromRect-culled-inline.html

* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::addNodeToRectBasedTestResult):

LayoutTests:

Added tests for rect-based hit-testing for the case when the child of a
culled inline element is in the hit-test result. One of these tests is
expected to fail due to https://bugs.webkit.org/show_bug.cgi?id=88376.

* fast/dom/nodesFromRect-culled-inline-expected.txt: Added.
* fast/dom/nodesFromRect-culled-inline.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Make Skia backend honor requests for subpixel-positioned text.
commit-queue@webkit.org [Thu, 7 Jun 2012 16:58:43 +0000 (16:58 +0000)]
Source/WebCore: Make Skia backend honor requests for subpixel-positioned text.
https://bugs.webkit.org/show_bug.cgi?id=88263

Patch by Daniel Erat <derat@chromium.org> on 2012-06-07
Reviewed by Tony Chang.

Add subpixel positioning field to FontRenderStyle and rename
subpixel rendering field.

Pass setting to SkPaint in FontPlatformDataHarfBuzz and remove
round() call when computing glyph widths in SimpleFontDataSkia.

Test: platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning.html

* platform/graphics/blackberry/skia/PlatformSupport.cpp:
(WebCore::setFontRenderStyleDefaults):
(WebCore::PlatformSupport::getRenderStyleForStrike):
* platform/graphics/chromium/FontRenderStyle.h:
(WebCore::FontRenderStyle::FontRenderStyle):
(WebCore::FontRenderStyle::operator==):
(FontRenderStyle):
* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore):
(WebCore::FontPlatformData::setSubpixelRendering):
(WebCore::FontPlatformData::setSubpixelPositioning):
(WebCore::FontPlatformData::setupPaint):
(WebCore::FontPlatformData::querySystemForRenderStyle):
* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
(FontPlatformData):
* platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformWidthForGlyph):

Source/WebKit/chromium: Add setting to enable subpixel-positioned text on Linux.
https://bugs.webkit.org/show_bug.cgi?id=88263

Patch by Daniel Erat <derat@chromium.org> on 2012-06-07
Reviewed by Tony Chang.

Add subpixel positioning field to WebFontRenderStyle and rename
subpixel rendering field.  Make similar changes in
WebFontRendering.

Also add global WebFontInfo::setSubpixelPositioning() to turn
subpixel positioning on or off (there's not currently a
well-defined way to configure subpixel positioning via FontConfig).

* public/linux/WebFontInfo.h:
(WebFontInfo):
* public/linux/WebFontRenderStyle.h:
* public/linux/WebFontRendering.h:
(WebFontRendering):
* src/linux/WebFontInfo.cpp:
(WebKit):
(WebKit::WebFontInfo::setSubpixelPositioning):
(WebKit::WebFontInfo::renderStyleForStrike):
* src/linux/WebFontRenderStyle.cpp:
(WebKit::WebFontRenderStyle::toFontRenderStyle):
(WebKit::WebFontRenderStyle::setDefaults):
* src/linux/WebFontRendering.cpp:
(WebKit::WebFontRendering::setSubpixelGlyphs):
(WebKit):
(WebKit::WebFontRendering::setSubpixelRendering):
(WebKit::WebFontRendering::setSubpixelPositioning):

Tools: [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
https://bugs.webkit.org/show_bug.cgi?id=88263

Patch by Daniel Erat <derat@chromium.org> on 2012-06-07
Reviewed by Tony Chang.

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::reset):
(LayoutTestController::setTextSubpixelPositioning):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/chromium/fonts.conf:

LayoutTests: [chromium] Add test for subpixel positioning.
https://bugs.webkit.org/show_bug.cgi?id=88263

Patch by Daniel Erat <derat@chromium.org> on 2012-06-07
Reviewed by Tony Chang.

* platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning-expected.png: Added.
* platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning-expected.txt: Added.
* platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add baselines for new tests
commit-queue@webkit.org [Thu, 7 Jun 2012 16:53:13 +0000 (16:53 +0000)]
[GTK] Add baselines for new tests
https://bugs.webkit.org/show_bug.cgi?id=88540

Unreviewed gardening. Added baselines for new tests.

Patch by Simon Pena <spena@igalia.com> on 2012-06-07

* platform/gtk/TestExpectations:
* platform/gtk/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
* platform/gtk/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
* platform/gtk/fast/reflections/reflection-with-zoom-expected.png: Added.
* platform/gtk/fast/reflections/reflection-with-zoom-expected.txt: Added.
* platform/gtk/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Added.
* platform/gtk/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Added.
* platform/gtk/svg/repaint/text-mask-update-expected.png: Added.
* platform/gtk/svg/repaint/text-mask-update-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=88481
beidson@apple.com [Thu, 7 Jun 2012 16:50:22 +0000 (16:50 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=88481

Move new test added by r119644 that was only meant for platform/mac into the platform/mac directory:
* platform/mac/fast/loader/resources/utf8-encoded.webarchive: Renamed from LayoutTests/fast/loader/resources/utf8-encoded.webarchive.
* platform/mac/fast/loader/webarchive-encoding-respected-expected.txt: Renamed from LayoutTests/fast/loader/webarchive-encoding-respected-expected.txt.
* platform/mac/fast/loader/webarchive-encoding-respected.html: Renamed from LayoutTests/fast/loader/webarchive-encoding-respected.html.

Also remove it from the TestExpectations files for platforms where it was Skipped:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix after r119593.
wingo@igalia.com [Thu, 7 Jun 2012 16:05:19 +0000 (16:05 +0000)]
Unreviewed build fix after r119593.

* llint/LLIntOfflineAsmConfig.h (OFFLINE_ASM_GLOBAL_LABEL): Fix
uses of "name" to be "label", the macro's parameter.  Otherwise we
serialize mentions of the literal symbol "name" into the objcode.
Causes a build error using GNU ld (not gold).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r119707.
commit-queue@webkit.org [Thu, 7 Jun 2012 16:03:31 +0000 (16:03 +0000)]
Unreviewed, rolling out r119707.
http://trac.webkit.org/changeset/119707
https://bugs.webkit.org/show_bug.cgi?id=88539

Because the original patch with the failing test was rolled
out by 119712 (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-07

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rebaseline tests after r119591 that enabled imageSmoothingEnabled for...
senorblanco@chromium.org [Thu, 7 Jun 2012 15:31:34 +0000 (15:31 +0000)]
[Chromium] Rebaseline tests after r119591 that enabled imageSmoothingEnabled for patterns
https://bugs.webkit.org/show_bug.cgi?id=88253

Unreviewed; test expectations update.

* platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/chromium-linux/svg/custom/pattern-skew-transformed-expected.png: Removed.
* platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-mac-leopard/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/chromium-mac/svg/custom/nested-pattern-boundingBoxModeContent-expected.png:
* platform/chromium-mac/svg/custom/oversized-pattern-scale-expected.png:
* platform/chromium-mac/svg/custom/pattern-in-defs-expected.png:
* platform/chromium-mac/svg/custom/pattern-skew-transformed-expected.png:
* platform/chromium-mac/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/chromium-win/svg/custom/nested-pattern-boundingBoxModeContent-expected.png:
* platform/chromium-win/svg/custom/oversized-pattern-scale-expected.png:
* platform/chromium-win/svg/custom/pattern-in-defs-expected.png:
* platform/chromium-win/svg/custom/pattern-skew-transformed-expected.png:
* platform/chromium-win/svg/custom/pattern-with-transformation-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] deviceScaleFactor setting is not honored
commit-queue@webkit.org [Thu, 7 Jun 2012 15:24:32 +0000 (15:24 +0000)]
[GTK] deviceScaleFactor setting is not honored
https://bugs.webkit.org/show_bug.cgi?id=88511

Patch by Simon Pena <spena@igalia.com> on 2012-06-07
Reviewed by Gustavo Noronha Silva.

Honor the deviceScaleFactor property in the paintWebView
method of the ChromeClientGtk.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::paintWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] In each composited frame, didDraw() should only be called on layers for...
danakj@chromium.org [Thu, 7 Jun 2012 15:09:22 +0000 (15:09 +0000)]
[chromium] In each composited frame, didDraw() should only be called on layers for which willDraw() was called
https://bugs.webkit.org/show_bug.cgi?id=88469

Reviewed by James Robinson.

Source/WebCore:

Unit test: CCLayerTreeHostImplTest.didDrawNotCalledOnScissoredLayer

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::shouldDrawLayer):
(WebCore):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::didDrawAllLayers):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Unskip passing tests for GTK.
mario@webkit.org [Thu, 7 Jun 2012 14:54:57 +0000 (14:54 +0000)]
Unreviewed. Unskip passing tests for GTK.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd QML API tests for Device Pixel Ratio
ahf@0x90.dk [Thu, 7 Jun 2012 14:46:21 +0000 (14:46 +0000)]
Add QML API tests for Device Pixel Ratio
https://bugs.webkit.org/show_bug.cgi?id=88531

Reviewed by Kenneth Rohde Christiansen.

This patch adds an initial test case for the QML device pixel ratio
API. The test currently fails and is therefore marked as being
expected to fail. This will be fixed in a separated patch.

* UIProcess/API/qt/tests/qmltests/WebView/tst_devicePixelRatio.qml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: sorting of object fields is broken in heap profiler
loislo@chromium.org [Thu, 7 Jun 2012 14:41:31 +0000 (14:41 +0000)]
Web Inspector: sorting of object fields is broken in heap profiler
https://bugs.webkit.org/show_bug.cgi?id=88532

A recent change to heap profiler has replaced getters with functions.
Function calls were missing in couple places after that change.

Source/WebCore:

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-07
Reviewed by Vsevolod Vlasov.

Tests: inspector/profiler/heap-snapshot-summary-sorting-fields.html
       inspector/profiler/heap-snapshot-summary-sorting-instances.html

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareNodeField):

LayoutTests:

The following changes were made to the tests:
- generateSnapshot now uses pseudo random numbers for object sizes.
  It allows to test sorting.
- Added a test that checks sorting of object instances of a particular class.
- Added a test that checks sorting of fields in an object instance.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-07
Reviewed by Vsevolod Vlasov.

Tests: inspector/profiler/heap-snapshot-summary-sorting-fields.html
       inspector/profiler/heap-snapshot-summary-sorting-instances.html

* inspector/profiler/heap-snapshot-summary-sorting-fields-expected.txt: Added.
* inspector/profiler/heap-snapshot-summary-sorting-fields.html: Added.
* inspector/profiler/heap-snapshot-summary-sorting-instances-expected.txt: Added.
* inspector/profiler/heap-snapshot-summary-sorting-instances.html: Added.
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.):
(initialize_HeapSnapshotTest):
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] User viewport arguments are not respected
commit-queue@webkit.org [Thu, 7 Jun 2012 14:30:56 +0000 (14:30 +0000)]
[BlackBerry] User viewport arguments are not respected
https://bugs.webkit.org/show_bug.cgi?id=88530

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-06-07
Reviewed by Antonio Gomes.

RIM PR #163767

Fixed by applying the user supplied viewport arguments if the page
specifies default viewport arguments (i.e. the page has no viewport
meta tag).

If the user didn't supply any viewport arguments either, the behaviour
is the same as before the patch, the caller will successfully reset to
default viewport arguments.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] WebKit2-EFL does not link in debug mode
commit-queue@webkit.org [Thu, 7 Jun 2012 14:19:34 +0000 (14:19 +0000)]
[EFL][WK2] WebKit2-EFL does not link in debug mode
https://bugs.webkit.org/show_bug.cgi?id=88518

Unreviewed. Fix WebKit2-EFL linking error in debug mode.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-07

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Consider Ctrl+Shift+key as valid zoom change combinations
apavlov@chromium.org [Thu, 7 Jun 2012 14:17:14 +0000 (14:17 +0000)]
Web Inspector: Consider Ctrl+Shift+key as valid zoom change combinations
https://bugs.webkit.org/show_bug.cgi?id=88520

Reviewed by Vsevolod Vlasov.

* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Allow WebPageCompositor to blend a transparent web page
commit-queue@webkit.org [Thu, 7 Jun 2012 14:00:41 +0000 (14:00 +0000)]
[BlackBerry] Allow WebPageCompositor to blend a transparent web page
https://bugs.webkit.org/show_bug.cgi?id=88233

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-06-07
Reviewed by Rob Buis.

RIM PR #159998

Source/WebCore:

Add a parameter to LayerRenderer::compositeBuffer() indicating whether
the buffer contents are opaque, and set the GL blend mode accordingly.

This is not currently testable using BlackBerry testing infrastructure.

Reviewed internally by Jakob Petsovits.

* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::compositeBuffer):
* platform/graphics/blackberry/LayerRenderer.h:
(LayerRenderer):

Source/WebKit/blackberry:

Keep track of the web page background color in the compositor so we can
determine whether the contents of the root layer are transparent.

Reviewed internally by Jakob Petsovits.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::compositeContents):
* Api/BackingStore_p.h:
(BackingStorePrivate):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setCompositor):
(BlackBerry::WebKit::WebPagePrivate::setCompositorBackgroundColor):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::createCompositor):
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositorPrivate::setBackgroundColor):
(WebKit):
* Api/WebPageCompositor_p.h:
(BlackBerry::WebKit::WebPageCompositorPrivate::backgroundColor):
(WebPageCompositorPrivate):
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Clean chromium test expectations.
loislo@chromium.org [Thu, 7 Jun 2012 13:45:02 +0000 (13:45 +0000)]
Unreviewed. Clean chromium test expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Fix broken build due to missing <SECTION> in GTK-DOC
kov@webkit.org [Thu, 7 Jun 2012 13:43:45 +0000 (13:43 +0000)]
[GTK] Fix broken build due to missing <SECTION> in GTK-DOC
https://bugs.webkit.org/show_bug.cgi?id=88525

Unreviewed gardening. Added missing <SECTION> tag.

Patch by Simon Pena <spena@igalia.com> on 2012-06-07

* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] Assertions in gtk_widget_draw when acquiring pixel output
zandobersek@gmail.com [Thu, 7 Jun 2012 13:21:08 +0000 (13:21 +0000)]
[Gtk] Assertions in gtk_widget_draw when acquiring pixel output
https://bugs.webkit.org/show_bug.cgi?id=88060

Reviewed by Martin Robinson.

Spin the main loop before acquiring the pixel content. This ensures things
like late size allocations are finished before calling gtk_widget_draw,
avoiding assertions and subsequent empty pixel results.

* DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
(createBitmapContextFromWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: reuse edge_count field of heap snapshot to store retained size
commit-queue@webkit.org [Thu, 7 Jun 2012 13:09:18 +0000 (13:09 +0000)]
Web Inspector: reuse edge_count field of heap snapshot to store retained size
https://bugs.webkit.org/show_bug.cgi?id=88416

The edge_count field is unused after node first edge indexes have been built.
Store node retained size in there instead of allocating an extra array for it.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-07
Reviewed by Vsevolod Vlasov.

Source/WebCore:

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.retainedSize):
(WebInspector.HeapSnapshot.prototype._calculateRetainedSizes):

LayoutTests:

* inspector/profiler/heap-snapshot.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Add enable credential autofill and enable form autofill feature control...
commit-queue@webkit.org [Thu, 7 Jun 2012 12:59:54 +0000 (12:59 +0000)]
[BlackBerry] Add enable credential autofill and enable form autofill feature control in WebSetting
https://bugs.webkit.org/show_bug.cgi?id=88513

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-06-07
Reviewed by Rob Buis.

RIM PR: #163391
Implemented credential autofill setting and form autofill setting.

Internally reviewed by Leo Yang <leo.yang@torchmobile.com.cn>.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::autofillTextField):
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
(BlackBerry::WebKit::WebPage::clearCredentials):
(BlackBerry::WebKit::WebPage::clearAutofillData):
(BlackBerry::WebKit::WebPage::clearNeverRememberSites):
* Api/WebSettings.cpp:
(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::isCredentialAutofillEnabled):
(BlackBerry::WebKit::WebSettings::setCredentialAutofillEnabled):
(BlackBerry::WebKit::WebSettings::isFormAutofillEnabled):
(BlackBerry::WebKit::WebSettings::setFormAutofillEnabled):
* Api/WebSettings.h:
* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::textFieldDidEndEditing):
(WebCore::EditorClientBlackBerry::textDidChangeInTextField):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r119694.
loislo@chromium.org [Thu, 7 Jun 2012 12:56:04 +0000 (12:56 +0000)]
Unreviewed, rolling out r119694.
http://trac.webkit.org/changeset/119694
https://bugs.webkit.org/show_bug.cgi?id=88529

it broke PrerenderBrowserTest.PrerenderHTML5VideoNetwork
(Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-07

Source/WebCore:

* html/HTMLMediaElement.cpp:
* html/HTMLMediaElement.h:
(HTMLMediaElement):
* html/canvas/CanvasRenderingContext.cpp:
(WebCore::CanvasRenderingContext::wouldTaintOrigin):
* platform/graphics/MediaPlayer.cpp:
* platform/graphics/MediaPlayer.h:
(MediaPlayer):
* platform/graphics/MediaPlayerPrivate.h:

Source/WebKit/chromium:

* public/WebMediaPlayer.h:
(WebMediaPlayer):
* src/AssertMatchingEnums.cpp:
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::loadInternal):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):

LayoutTests:

* http/tests/security/resources/video-cross-origin-allow.php: Removed.
* http/tests/security/video-cross-origin-readback-expected.txt: Removed.
* http/tests/security/video-cross-origin-readback.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDelete a contenteditable element having a Shadow DOM causes a crash.
shinyak@chromium.org [Thu, 7 Jun 2012 12:22:40 +0000 (12:22 +0000)]
Delete a contenteditable element having a Shadow DOM causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=86345

Reviewed by Ryosuke Niwa.

Source/WebCore:

In VisibleSelection::validate(), m_start.downstream() or m_end.upstream() might cross
editing boundaries. So we adjust selection after calling them again.

Test: editing/shadow/select-contenteditable-shadowhost.html

* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::validate):

LayoutTests:

* editing/shadow/select-contenteditable-shadowhost-expected.txt: Added.
* editing/shadow/select-contenteditable-shadowhost.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Improve the visual of the viewport info box
kenneth@webkit.org [Thu, 7 Jun 2012 12:11:29 +0000 (12:11 +0000)]
[Qt] Improve the visual of the viewport info box
https://bugs.webkit.org/show_bug.cgi?id=88410

Reviewed by Tor Arne Vestbø.

Improve the visual and make it possible to see the content more easy.

* MiniBrowser/qt/qml/ViewportInfoItem.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed rebaseline for r115582.
kinuko@chromium.org [Thu, 7 Jun 2012 12:08:45 +0000 (12:08 +0000)]
Unreviewed rebaseline for r115582.

* http/tests/security/filesystem-iframe-from-remote-expected.txt:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNo new line at the end for SVGCSSPropertyNames.in causes compilation warning
commit-queue@webkit.org [Thu, 7 Jun 2012 11:58:27 +0000 (11:58 +0000)]
No new line at the end for SVGCSSPropertyNames.in causes compilation warning
https://bugs.webkit.org/show_bug.cgi?id=88503

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-06-07
Reviewed by Ryosuke Niwa.

Added new line at the end of the file.

No new tests required.

* css/SVGCSSPropertyNames.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Gardening. Skip failing new test.
ossy@webkit.org [Thu, 7 Jun 2012 11:57:55 +0000 (11:57 +0000)]
[Qt] Gardening. Skip failing new test.
https://bugs.webkit.org/show_bug.cgi?id=88523

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-06-07
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped: Skip http/tests/security/video-cross-origin-readback.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Win] Use OS(WINDOWS) instead of Q_WS_WIN in WebCore/platform/graphics/GraphicsCo...
ossy@webkit.org [Thu, 7 Jun 2012 11:49:06 +0000 (11:49 +0000)]
[Qt][Win] Use OS(WINDOWS) instead of Q_WS_WIN in WebCore/platform/graphics/GraphicsContext.h
https://bugs.webkit.org/show_bug.cgi?id=88305

Reviewed by Simon Hausmann.

* platform/graphics/GraphicsContext.h: Buildfix.
(GraphicsContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIncorrect data retrieved in calls to get selection data in client->textWillBeReplaced...
shinyak@chromium.org [Thu, 7 Jun 2012 11:45:20 +0000 (11:45 +0000)]
Incorrect data retrieved in calls to get selection data in client->textWillBeReplaced from CharacterData::setDataAndUpdate
https://bugs.webkit.org/show_bug.cgi?id=66120

Reviewed by Ryosuke Niwa.

Since FrameSelection::textWillBeReplaced was called before replacing text, updated Selection became
temporarily invalid. The invalid selection was set to updateSelection(), so client will have
invalid selection.

This patch makes calling updateSelection() after updating selection.

No new tests, it's too hard to create a correct test cases in DRT.

* dom/CharacterData.cpp:
(WebCore::CharacterData::setDataAndUpdate):
* editing/FrameSelection.cpp:
(WebCore::updatePositionAfterAdoptingTextReplacement):
(WebCore::FrameSelection::textWasReplaced):
* editing/FrameSelection.h:
(FrameSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Win] Fix linking WTF with ICU
ossy@webkit.org [Thu, 7 Jun 2012 11:39:58 +0000 (11:39 +0000)]
[Qt][Win] Fix linking WTF with ICU
https://bugs.webkit.org/show_bug.cgi?id=88302

Reviewed by Simon Hausmann.

* WTF.pri: Use proper library names on win32 platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed Skipped list cleanup. Remove disabled/passing tests, add bug reports.
ossy@webkit.org [Thu, 7 Jun 2012 11:25:46 +0000 (11:25 +0000)]
[Qt] Unreviewed Skipped list cleanup. Remove disabled/passing tests, add bug reports.

* platform/qt-arm/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFileAPI: If type consists of non-ASCII characters in Blob constructor, it should...
commit-queue@webkit.org [Thu, 7 Jun 2012 11:06:58 +0000 (11:06 +0000)]
FileAPI: If type consists of non-ASCII characters in Blob constructor, it should throw a SyntaxError.
https://bugs.webkit.org/show_bug.cgi?id=88411

Patch by Li Yin <li.yin@intel.com> on 2012-06-07
Reviewed by Kentaro Hara.

Source/WebCore:

From spec: http://dev.w3.org/2006/webapi/FileAPI/#constructorBlob
If type consists of any non-ASCII characters, throw a SyntaxError and
return from this algorithm.
This patch checks the String is ASCii or not, if not, throw SyntaxError.

Test: fast/files/blob-constructor.html

* bindings/js/JSBlobCustom.cpp:
(WebCore::JSBlobConstructor::constructJSBlob):
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCallback):

LayoutTests:

From Spec: http://dev.w3.org/2006/webapi/FileAPI/#constructorBlob
If type consists of any non-ASCII characters, throw a SyntaxError and
return from this algorithm.

* fast/files/blob-constructor-expected.txt:
* fast/files/script-tests/blob-constructor.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInsertUnorderedList and InsertOrderedList (execCommand) do not remove bullets
commit-queue@webkit.org [Thu, 7 Jun 2012 10:36:38 +0000 (10:36 +0000)]
InsertUnorderedList and InsertOrderedList (execCommand) do not remove bullets
https://bugs.webkit.org/show_bug.cgi?id=84597

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-06-07
Reviewed by Ryosuke Niwa.

Source/WebCore:

Comparison between start and end VisiblePositions will fail when a position inside
a paragraph is compared with one at the start of the paragraph.

This fix thus converts the end VisiblePosition (which could be inside the paragraph)
to the start of the paragraph thereby enabling a proper comparison of start and end
positions.

Test: editing/execCommand/remove-list-from-multi-list-items.html

* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::selectionHasListOfType):

LayoutTests:

This test verifies removing of an (un)ordered list on a selection consisting of multiple
list items (paragraphs) when the end point of the selection points to the end of the last
list item; followed by another paragraph not part of the selection/list.

* editing/execCommand/remove-list-from-multi-list-items-expected.txt: Added.
* editing/execCommand/remove-list-from-multi-list-items.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add API to register custom URI schemes to WebKit2 GTK+ API
carlosgc@webkit.org [Thu, 7 Jun 2012 10:16:03 +0000 (10:16 +0000)]
[GTK] Add API to register custom URI schemes to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=84133

Reviewed by Martin Robinson.

* GNUmakefile.list.am: Add new files to compilation.
* UIProcess/API/gtk/WebKitPrivate.h:
* UIProcess/API/gtk/WebKitRequestManagerClient.cpp: Added.
(didReceiveURIRequest): Callback emitted by the C API when a
request for a custom URI scheme has been received. Call
webkitWebContextReceivedURIRequest() to handle the request.
(didFailToLoadURIRequest): Callback emitted by the C API when a
request for a custom URI scheme failed to load. Call
webkitWebContextDidFailToLoadURIRequest() to noitfy the web
context.
(attachRequestManagerClientToContext): Initialize the
WKSoupRequestManagerClient.
* UIProcess/API/gtk/WebKitRequestManagerClient.h: Added.
* UIProcess/API/gtk/WebKitURISchemeRequest.cpp: Added.
(webkit_uri_scheme_request_init):
(webkitURISchemeRequestFinalize):
(webkit_uri_scheme_request_class_init):
(webkitURISchemeRequestCreate): Create a new
WebKitURISchemeRequest for the given URI and request identifier.
(webkitURISchemeRequestGetID): Return the request identifier.
(webkitURISchemeRequestCancel): Cancel the request operation.
(webkit_uri_scheme_request_get_scheme): Return the scheme of the
request.
(webkit_uri_scheme_request_get_uri): Return the full URI of the
request.
(webkit_uri_scheme_request_get_path): Return the path of the URI.
(webkitURISchemeRequestReadCallback): Read callback emitted when
reading the contents of the input stream.
(webkit_uri_scheme_request_finish): Finish the request by reading
the contents of the input stream and sending the data to the
WebProcess.
* UIProcess/API/gtk/WebKitURISchemeRequest.h: Added.
* UIProcess/API/gtk/WebKitURISchemeRequestPrivate.h: Added.
* UIProcess/API/gtk/WebKitWebContext.cpp:
(WebKitURISchemeHandler::WebKitURISchemeHandler): Helper struct to
save callback and user data of registered URI schemes.
(createDefaultWebContext): Initialize the SoupRequestManager.
(webkit_web_context_register_uri_scheme): Public API to register a
custom URI scheme providing a callback that will be called to
handle requests for that URI scheme.
(webkitWebContextGetRequestManager): Helper private method to
return the SoupRequestManager.
(webkitWebContextReceivedURIRequest): Get the
WebKitURISchemeHandler for the given request identifier and call
the callback. Save the request in the request map.
(webkitWebContextDidFailToLoadURIRequest): Cancel the ongoing
request.
(webkitWebContextDidFinishURIRequest): Remove the request from the
map.
* UIProcess/API/gtk/WebKitWebContext.h:
* UIProcess/API/gtk/WebKitWebContextPrivate.h:
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add
WebKitURISchemeRequest section.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/docs/webkit2gtk.types: Add
webkit_uri_scheme_request_get_type.
* UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(testWebContextURIScheme):
(beforeAll):
* UIProcess/API/gtk/webkit2.h: Include WebKitURISchemeRequest.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Forms] Improve test coverage of input-number-size.html
yosin@chromium.org [Thu, 7 Jun 2012 09:47:23 +0000 (09:47 +0000)]
[Forms] Improve test coverage of input-number-size.html
https://bugs.webkit.org/show_bug.cgi?id=88489

Reviewed by Kent Tamura.

This patch improves test coverage for NumberInputType::sizeShouldIncludeDecoration()
for preparation of introducing decimal arithmetic.

* fast/forms/number/input-number-size-expected.txt: Updated for a new test case.
* fast/forms/number/input-number-size.html: Added a test case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[FileAPI] FileReader should throw an InvalidStateError exception when readyState...
commit-queue@webkit.org [Thu, 7 Jun 2012 09:42:57 +0000 (09:42 +0000)]
[FileAPI] FileReader should throw an InvalidStateError exception when readyState is LOADING
https://bugs.webkit.org/show_bug.cgi?id=88212

Patch by Li Yin <li.yin@intel.com> on 2012-06-07
Reviewed by Jian Li.

Source/WebCore:

From Spec: http://www.w3.org/TR/FileAPI/#readAsBinaryString
FileReader should throw an InvalidStateError exception instead of NOT_ALLOWED_ERR
when the readyState is LOADING.
Also delete OperationNotAllowedException related code, because it is not longer needed.

Tests: fast/files/read-file-async.html
       fast/files/workers/worker-read-file-async.html

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMExceptions.in:
* fileapi/FileReader.cpp:
(WebCore::FileReader::readInternal): Changed it to throw INVALID_STATE_ERR.
* fileapi/FileReader.idl: Changed it to raise DOMException for all read methods.
* fileapi/OperationNotAllowedException.cpp: Removed.
* fileapi/OperationNotAllowedException.h: Removed.
* fileapi/OperationNotAllowedException.idl: Removed.

LayoutTests:

From spec: http://www.w3.org/TR/FileAPI/#readAsBinaryString
FileReader should throw an InvalidStateError exception instead of NOT_ALLOWED_ERR.

* fast/files/read-file-async-expected.txt:
* fast/files/workers/worker-read-file-async-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] setPageItemRectVisible() is not guarded by ViewportUpdateDeferrer at scaleA...
abecsi@webkit.org [Thu, 7 Jun 2012 09:38:45 +0000 (09:38 +0000)]
[Qt][WK2] setPageItemRectVisible() is not guarded by ViewportUpdateDeferrer at scaleAnimationValueChanged()
https://bugs.webkit.org/show_bug.cgi?id=87954

Reviewed by Kenneth Rohde Christiansen.

Resetting the end value, the easing curve or the duration of the scale animation triggers
a recalculation of the animation interval. This might change the current value of the
animated property.
Since guarding of setPageItemRectVisible() relies on animation state change we have to
make sure we only act on animation value changes if the animation is in active state.

* UIProcess/qt/QtViewportHandler.cpp:
(WebKit::QtViewportHandler::QtViewportHandler):
(WebKit::QtViewportHandler::animatePageItemRectVisible):
(WebKit::QtViewportHandler::scaleAnimationValueChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r119689.
loislo@chromium.org [Thu, 7 Jun 2012 09:26:37 +0000 (09:26 +0000)]
Unreviewed, rolling out r119689.
http://trac.webkit.org/changeset/119689
https://bugs.webkit.org/show_bug.cgi?id=88516

it broke didDrawNotCalledOnScissoredLayer webkit_unit_test
(Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-07

Source/WebCore:

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::didDrawAllLayers):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[SOUP] WebSoupRequestManager should handle loading errors and zero-length replies
carlosgc@webkit.org [Thu, 7 Jun 2012 09:11:08 +0000 (09:11 +0000)]
[SOUP] WebSoupRequestManager should handle loading errors and zero-length replies
https://bugs.webkit.org/show_bug.cgi?id=88087

Reviewed by Martin Robinson.

* UIProcess/API/C/soup/WKSoupRequestManager.h:
* UIProcess/soup/WebSoupRequestManagerClient.cpp:
(WebKit::WebSoupRequestManagerClient::didFailToLoadURIRequest):
Call didFailToLoadURIRequest in the client if present.
* UIProcess/soup/WebSoupRequestManagerClient.h:
* UIProcess/soup/WebSoupRequestManagerProxy.cpp:
(WebKit::WebSoupRequestManagerProxy::WebSoupRequestManagerProxy):
Initialize m_loadFailed.
(WebKit::WebSoupRequestManagerProxy::didReceiveURIRequestData):
Don't send more data to the web process if the resource failed to
load.
(WebKit::WebSoupRequestManagerProxy::didFailToLoadURIRequest): Set
m_loadFailed and notifiy the client calling didFailToLoadURIRequest.
* UIProcess/soup/WebSoupRequestManagerProxy.h:
* UIProcess/soup/WebSoupRequestManagerProxy.messages.in: Add
DidFailToLoadURIRequest message.
* WebProcess/soup/WebKitSoupRequestGeneric.cpp:
(webkitSoupRequestGenericSendAsync): Pass the cancellable to the
WebSoupRequestManager.
* WebProcess/soup/WebSoupRequestManager.cpp:
(WebKit::WebSoupRequestAsyncData::WebSoupRequestAsyncData): Helper
struct to save requests.
(WebSoupRequestAsyncData): Add a weak pointer to invalidate the
request when it's destroyed before the operation has finished.
(WebKit::WebSoupRequestAsyncData::~WebSoupRequestAsyncData):
Remove the weak pointer.
(WebKit::WebSoupRequestAsyncData::requestFailed): Return whther
the request failed.
(WebKit::WebSoupRequestAsyncData::releaseResult): Return the
result and clear the pointer.
(WebKit::WebSoupRequestManager::didHandleURIRequest): Create and
empty memory stream for zero-length replies instead of creating an
error.
(WebKit::WebSoupRequestManager::didReceiveURIRequestData): If the
request failed and more data expected from the UI process, send a
message to the UI process to notify that the resource load failed.
(WebKit::WebSoupRequestManager::send): Save request information in
the request map.
* WebProcess/soup/WebSoupRequestManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPlumb CORS attribute information from HTMLMediaElement to media players so it can...
fischman@chromium.org [Thu, 7 Jun 2012 08:48:25 +0000 (08:48 +0000)]
Plumb CORS attribute information from HTMLMediaElement to media players so it can be used
https://bugs.webkit.org/show_bug.cgi?id=88349

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/video-cross-origin-readback.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerCORSMode):
(WebCore):
* html/HTMLMediaElement.h:
(HTMLMediaElement):
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerCORSMode):

Source/WebKit/chromium:

* public/WebMediaPlayer.h:
(WebMediaPlayer):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::loadInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse light gray for grammar markers on Windows and Linux
hbono@chromium.org [Thu, 7 Jun 2012 08:28:10 +0000 (08:28 +0000)]
Use light gray for grammar markers on Windows and Linux
https://bugs.webkit.org/show_bug.cgi?id=88398

Reviewed by Ryosuke Niwa.

This change changes the color of grammar markers from dark gray to light gray
and rebaselines a couple of pixel tests affected by this change.

Source/WebCore:

No new tests because it changes the marker color of an existing test 'grammar-markers.html'.

* platform/graphics/skia/GraphicsContextSkia.cpp: Change dark gray to light gray.

LayoutTests:

* platform/chromium-linux/editing/spelling/grammar-markers-expected.png:
* platform/chromium-win/editing/spelling/grammar-markers-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: [Platform] Introduce conversion from/to Deciaml to/from double
yosin@chromium.org [Thu, 7 Jun 2012 07:56:57 +0000 (07:56 +0000)]
Source/WebCore: [Platform] Introduce conversion from/to Deciaml to/from double
https://bugs.webkit.org/show_bug.cgi?id=88480

Reviewed by Kent Tamura.

This patch added functions for Decimal/Double conversion and isInfinity
for reducing patch size of introducing Decimal arithmetic, bug 88383.

Tests: WebKit/chromium/tests/DecimalTest.cpp

* platform/Decimal.cpp:
(WebCore::Decimal::fromDouble): Added.
(WebCore::Decimal::toDouble): Added.
* platform/Decimal.h:
(WebCore::Decimal::EncodedData::isInfinity): Added for isinf()
(WebCore::Decimal::isInfinity): Added.

Source/WebKit/chromium: [Platform] Introduce conversion from/to Deciaml to/from double and helper functions
https://bugs.webkit.org/show_bug.cgi?id=88480

Reviewed by Kent Tamura.

This patch added tests for Decimal::fromDouble, isInfinity, toDouble.

* tests/DecimalTest.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
fischman@chromium.org [Thu, 7 Jun 2012 07:45:21 +0000 (07:45 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoElement.getBoundingClientRect() and Element.getClientRects() return incorrect values...
wangxianzhu@chromium.org [Thu, 7 Jun 2012 06:57:19 +0000 (06:57 +0000)]
Element.getBoundingClientRect() and Element.getClientRects() return incorrect values in frames in a scaled page
https://bugs.webkit.org/show_bug.cgi?id=88430

Source/WebCore:

Element.getBoudingClientRect() and Element.getClientRects() should not scale back the rects
if the element is in a frame because page scale only apply to elements in the main frame.

Reviewed by James Robinson.

Tests: fast/dom/Element/scale-page-bounding-client-rect-in-frame.html
       fast/dom/Element/scale-page-client-rects-in-frame.html

* dom/Document.cpp:
(WebCore):
(WebCore::Document::adjustFloatQuadsForScrollAndAbsoluteZoomAndFrameScale): Extracted from Element.cpp and Range.cpp and fixed issue of pageScale in frames.
(WebCore::Document::adjustFloatRectForScrollAndAbsoluteZoomAndFrameScale): Extracted from Element.cpp and fixed issue of pageScale in frames.
* dom/Document.h:
(WebCore):
(Document):
* dom/Element.cpp:
(WebCore::Element::getClientRects):
(WebCore::Element::getBoundingClientRect):
* dom/Range.cpp:
(WebCore):
(WebCore::adjustFloatQuadsForScrollAndAbsoluteZoomAndPageScale): Moved into Document and fixed issue of pageScale in frames.
(WebCore::Range::getBorderAndTextQuads):
* rendering/RenderObject.h: Removed adjustFloatQuadForPageScale and adjustFloatRectForPageScale because they seem unrelated to RenderObject.
(WebCore):

LayoutTests:

Reviewed by James Robinson.

* fast/dom/Element/resources/client-rect-frame.html: Added.
* fast/dom/Element/scale-page-bounding-client-rect-in-frame-expected.txt: Added.
* fast/dom/Element/scale-page-bounding-client-rect-in-frame.html: Added.
* fast/dom/Element/scale-page-client-rects-in-frame-expected.txt: Added.
* fast/dom/Element/scale-page-client-rects-in-frame.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] In each composited frame, didDraw() should only be called on layers for...
danakj@chromium.org [Thu, 7 Jun 2012 06:54:04 +0000 (06:54 +0000)]
[chromium] In each composited frame, didDraw() should only be called on layers for which willDraw() was called
https://bugs.webkit.org/show_bug.cgi?id=88469

Reviewed by James Robinson.

Source/WebCore:

Unit test: CCLayerTreeHostImplTest.didDrawNotCalledOnScissoredLayer

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::shouldDrawLayer):
(WebCore):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::didDrawAllLayers):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r60044.
tkent@chromium.org [Thu, 7 Jun 2012 06:25:27 +0000 (06:25 +0000)]
Unreviewed, rolling out r60044.
http://trac.webkit.org/changeset/60044

It made a regression, crbug.com/114922.

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::invalidateContentsForSlowScroll): Do not hide popups by scrolling.
(WebKit::ChromeClientImpl::scroll): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWrap uppercaseWord, lowercaseWord, and capitalizeWord with USE(APPKIT)
aestes@apple.com [Thu, 7 Jun 2012 06:20:18 +0000 (06:20 +0000)]
Wrap uppercaseWord, lowercaseWord, and capitalizeWord with USE(APPKIT)
https://bugs.webkit.org/show_bug.cgi?id=88504

Reviewed by Dan Bernstein.

uppercaseWord, lowercaseWord, and capitalizeWord are methods declared
by NSResponder that subclasses are expected to implement. WebKit should
only support these implementations on platforms that use AppKit.

Source/WebCore:

* WebCore.exp.in:
* editing/Editor.cpp:
* editing/Editor.h:
* loader/EmptyClients.h:
* page/ContextMenuController.cpp:
* page/EditorClient.h:

Source/WebKit/mac:

* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm:

Source/WebKit2:

* UIProcess/WebPageProxy.h:
* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
noel.gordon@gmail.com [Thu, 7 Jun 2012 06:14:31 +0000 (06:14 +0000)]
Unreviewed. Rolled DEPS.

* DEPS: Roll to chromium 140955.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r119683.
loislo@chromium.org [Thu, 7 Jun 2012 06:01:23 +0000 (06:01 +0000)]
Unreviewed, rolling out r119683.
http://trac.webkit.org/changeset/119683
https://bugs.webkit.org/show_bug.cgi?id=88505

it broke webkit-unit-test
WebLayerTreeViewThreadedTest.InstrumentationCallbacks on mac
(Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-06

Source/WebCore:

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::setVisible):

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHost::create):
* tests/Canvas2DLayerChromiumTest.cpp:
(Canvas2DLayerChromiumTest::fullLifecycleTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: [Chromium] Re-enable handling of smooth scrolling on Chromium Linux...
rjkroege@chromium.org [Thu, 7 Jun 2012 05:56:12 +0000 (05:56 +0000)]
Source/WebCore: [Chromium] Re-enable handling of smooth scrolling on Chromium Linux/Windows
https://bugs.webkit.org/show_bug.cgi?id=87535 by adding support for
m_hasPreciseScrollingDelta on all Chromium platforms and adjusting ScrollAnimator
and ScrollAnimatorNone accordingly to let m_hasPreciseScrollingDelta == true
force exact (non-animated) scrolling.

Reviewed by James Robinson.

Updated WebKit unit tests to validate change.

* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Adjusted #ifdefs to
make m_hasPreciseScrollingDelta available on all Chromium platforms.
(PlatformWheelEvent):
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleWheelEvent): Default scroll type is set based on
m_hasPreciseScrollingDelta value.
* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::scroll): Scroll precisely when necessary.
* platform/ScrollTypes.h: Added additional pixel scrolling subtype.
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::scroll): Updated for additional pixel scroll subtype.

Source/WebKit/chromium: [Chromium] Re-enable handling of smooth scrolling on Chromium Linux/Windows
https://bugs.webkit.org/show_bug.cgi?id=87535 by adding support for precise
scrolling deltas on all Chromium platforms.

Reviewed by James Robinson.

* src/WebInputEventConversion.cpp:
(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder): Create PlatformWheelEvents
with m_hasPreciseScrollingDelta flag as required.
* tests/ScrollAnimatorNoneTest.cpp: Added new unit test condiiton for precise scrolling.
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Stop dropping texture limits when the layer tree host becomes invisible...
commit-queue@webkit.org [Thu, 7 Jun 2012 05:00:00 +0000 (05:00 +0000)]
[chromium] Stop dropping texture limits when the layer tree host becomes invisible, and initialize with 0 allocation.
https://bugs.webkit.org/show_bug.cgi?id=87747

Patch by Michal Mocny <mmocny@google.com> on 2012-06-06
Reviewed by Adrienne Walker.

Source/WebCore:

GpuMemoryManager manages texture memory allocation limits. It will send a 0 allocation when a renderer becomes
invisible, and an appropriate allocation after a renderer is initialized.  These numbers will change
depending on the state of memory across devices and other renderers, so we would like to remove all explicit
management by the renderers themselves.

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::setVisible):

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHost::create):
* tests/Canvas2DLayerChromiumTest.cpp:
(Canvas2DLayerChromiumTest::fullLifecycleTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r119680.
kinuko@chromium.org [Thu, 7 Jun 2012 04:52:05 +0000 (04:52 +0000)]
Unreviewed, rolling out r119680.
http://trac.webkit.org/changeset/119680
https://bugs.webkit.org/show_bug.cgi?id=88498

It broke mac build (Requested by kinuko on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-06

* fileapi/File.cpp:
(WebCore::File::File):
(WebCore::File::lastModifiedDate):
(WebCore::File::lastModifiedDateForBinding):
(WebCore):
(WebCore::File::captureSnapshot):
* fileapi/File.h:
(File):
* fileapi/File.idl:
* platform/FileMetadata.h:
(WebCore::FileMetadata::FileMetadata):
* platform/FileSystem.h:
* platform/chromium/support/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
* platform/network/BlobData.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] browser video player fullscreen mode (portrait) - Controls are off scree...
tonikitoo@webkit.org [Thu, 7 Jun 2012 04:34:56 +0000 (04:34 +0000)]
[BlackBerry] browser video player fullscreen mode (portrait) - Controls are off screen so cannot exit fullscreen
https://bugs.webkit.org/show_bug.cgi?id=88488
PR #162991

Reviewed by George Staikos.
Patch by Antonio Gomes <agomes@rim.com>

When we use width:100%/pageScale as the math to calculate the width of the
FullScreen element, it goes too wide for horizontally scrollable webpages.
The reason is that 100% is relative to the content size here, and we want 100%
relative to the viewport size. However, since there is no such a thing in CSS,
we set an absolute file.

A known problem with this will be rotating the device when in fullscreen mode
that we can address when rotating is supported.

Internally reviewed by Jacky Jiang.

* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFile::lastModifiedDate should use NaN or separate boolean flag for null Date value
kinuko@chromium.org [Thu, 7 Jun 2012 04:34:40 +0000 (04:34 +0000)]
File::lastModifiedDate should use NaN or separate boolean flag for null Date value
https://bugs.webkit.org/show_bug.cgi?id=87826

Reviewed by Kent Tamura.

Test: http/tests/local/fileapi/file-last-modified-after-delete.html

* fileapi/File.cpp:
(WebCore::File::File):
(WebCore::File::captureSnapshot):
(WebCore::File::lastModifiedDate):
(WebCore::File::lastModifiedDateForBinding): Removed.
* fileapi/File.h:
(File):
* fileapi/File.idl:
* platform/FileMetadata.h:
(WebCore::FileMetadata::FileMetadata):
* platform/FileSystem.h:
* platform/chromium/support/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
* platform/network/BlobData.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Implement a top-down in-region boundary detection in InRegionScrollableArea
tonikitoo@webkit.org [Thu, 7 Jun 2012 04:34:23 +0000 (04:34 +0000)]
[BlackBerry] Implement a top-down in-region boundary detection in InRegionScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=88254
PR #125237

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>

Patch implements a top-down visibleWindowRect calculation for all scrollable
elements hit-tested by a given point.

The reason on why this approach is better is that it calculates the visible
window rect from the outtermost scrollable element towards the inner ones, and
that allows it to use the visible window rect of the previous scrollable element
as the clipping rect for the current one.

Patch also changes the return vector to store ScrollViewBase pointers, so
we can make use of static_cast properly.

Internally reviewed by Jakob Petsovits.

* Api/WebPage.cpp:
(BlackBerry::WebKit::pushBackInRegionScrollable):
(BlackBerry::WebKit::WebPagePrivate::inRegionScrollableAreasForPoint):
* Api/WebPageClient.h:
* Api/WebPage_p.h:
(WebPagePrivate):
* WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
(BlackBerry::WebKit::InRegionScrollableArea::setVisibleWindowRect):
(WebKit):
(BlackBerry::WebKit::InRegionScrollableArea::visibleWindowRect):
* WebKitSupport/InRegionScrollableArea.h:
(InRegionScrollableArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119679 268f45cc-cd09-0410-ab3c-d52691b4dbfc